)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"18360fdc35f07019c62450511ebc055d21caa3e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"79e82ba1_5c2f98e7","updated":"2023-12-14 08:32:41.000000000","message":"I\u0027m against putting the devices in the inventory. The inventory is supposed to be compact and easy for human to read, a listing of the USB devices is neither. I\u0027d rather do the same thing as done for PCI devices and make USB collection an optional collector.","commit_id":"7072441f0afcd005458afa439ee68ac107de915a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ddac53751ddfb18a977e0f92a6d8efd8580a4084","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0177fee7_a4e1d5ab","updated":"2023-12-15 10:26:40.000000000","message":"The patch looks good, one minor thing inline. Also please update the docs at https://docs.openstack.org/ironic-python-agent/latest/admin/how_it_works.html#inspection-data and add a release note.","commit_id":"e2c1f3cafb8e874bc63921b2e24a989f12a8938b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e66e1246eb1c23a3b896c5ac79c07f431b15a9a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"936b634a_44db6230","updated":"2024-01-12 23:41:20.000000000","message":"Question of the day, should there be unit tests? -1 for visibility, basically I think the change is fine, but I\u0027m on the fence if we should have a test or two. Ideally we should.","commit_id":"562cba8d0c0c5daa5f26c707f49924d958c84a3f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"84ecf3dd7d263cec6e21937831c1b0b21d882be5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d563a9a8_06b071c9","updated":"2024-01-26 15:01:54.000000000","message":"Overall looks good, but it looks like it is missing one thing. A release note.\n\nPlease add a release note using the reno tool, and provide some prose in that release note to convey that this was an added feature. Thanks!","commit_id":"54d3e6890829a77760472150d090a5322613c318"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ddac53751ddfb18a977e0f92a6d8efd8580a4084","unresolved":true,"context_lines":[{"line_number":924,"context_line":""},{"line_number":925,"context_line":"    def generate_tls_certificate(self, ip_address):"},{"line_number":926,"context_line":"        raise errors.IncompatibleHardwareMethodError()"},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"    def erase_block_device(self, node, block_device):"},{"line_number":929,"context_line":"        \"\"\"Attempt to erase a block device."},{"line_number":930,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"703097a1_7ae91160","line":927,"updated":"2023-12-15 10:26:40.000000000","message":"Please add the new call here to signify that hardware managers may override it.","commit_id":"e2c1f3cafb8e874bc63921b2e24a989f12a8938b"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e415051538ede04d8208b4f93bed02ea23258e9c","unresolved":false,"context_lines":[{"line_number":924,"context_line":""},{"line_number":925,"context_line":"    def generate_tls_certificate(self, ip_address):"},{"line_number":926,"context_line":"        raise errors.IncompatibleHardwareMethodError()"},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"    def erase_block_device(self, node, block_device):"},{"line_number":929,"context_line":"        \"\"\"Attempt to erase a block device."},{"line_number":930,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"631d91dc_ee48f9fe","line":927,"in_reply_to":"703097a1_7ae91160","updated":"2024-03-28 20:02:54.000000000","message":"Done","commit_id":"e2c1f3cafb8e874bc63921b2e24a989f12a8938b"}]}