)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c4f8672a4daf3ff14409c7770278a5fa79ce5d39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e38332c4_0998716e","updated":"2024-01-05 21:31:09.000000000","message":"Can we also add a unit test, if possible, for ensuring we can set \u003e1 ipa-api-url values on the kernel command line?","commit_id":"678672587d11beaa39f08ae8db8a4b154e351748"}],"ironic_python_agent/config.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c4f8672a4daf3ff14409c7770278a5fa79ce5d39","unresolved":true,"context_lines":[{"line_number":36,"context_line":"                    \u0027A special value \"mdns\" can be specified to fetch the \u0027"},{"line_number":37,"context_line":"                    \u0027URL using multicast DNS service discovery. If several \u0027"},{"line_number":38,"context_line":"                    \u0027URLs are provided, all of them are tried until one \u0027"},{"line_number":39,"context_line":"                    \u0027does not return a connection error.\u0027),"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027global_request_id\u0027,"},{"line_number":42,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-global-request-id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"b9130a23_0ee6aa00","line":39,"updated":"2024-01-05 21:31:09.000000000","message":"What do several URLs look like when presented on the command line? We are not adding commas to the regex. Can we be more explicit here, and maybe also include information about ordering if that is not made obvious?","commit_id":"678672587d11beaa39f08ae8db8a4b154e351748"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a68597ce8ee5d3a63135153da9ec63b53642d397","unresolved":true,"context_lines":[{"line_number":36,"context_line":"                    \u0027A special value \"mdns\" can be specified to fetch the \u0027"},{"line_number":37,"context_line":"                    \u0027URL using multicast DNS service discovery. If several \u0027"},{"line_number":38,"context_line":"                    \u0027URLs are provided, all of them are tried until one \u0027"},{"line_number":39,"context_line":"                    \u0027does not return a connection error.\u0027),"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027global_request_id\u0027,"},{"line_number":42,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-global-request-id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"8fd9181a_142c3552","line":39,"in_reply_to":"228fa7c5_3ddc6f8f","updated":"2024-01-08 18:07:58.000000000","message":"Not all my comments were addressed, to recap:\n- What do several URLs look like when presented on the command line?\n- Can we also add a unit test, if possible, for ensuring we can set \u003e1 ipa-api-url values on the kernel command line?","commit_id":"678672587d11beaa39f08ae8db8a4b154e351748"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5ac1dafbea71621cd563a213b68dea9b6a004138","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    \u0027A special value \"mdns\" can be specified to fetch the \u0027"},{"line_number":37,"context_line":"                    \u0027URL using multicast DNS service discovery. If several \u0027"},{"line_number":38,"context_line":"                    \u0027URLs are provided, all of them are tried until one \u0027"},{"line_number":39,"context_line":"                    \u0027does not return a connection error.\u0027),"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027global_request_id\u0027,"},{"line_number":42,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-global-request-id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"edc0205e_0e82bf39","line":39,"in_reply_to":"8fd9181a_142c3552","updated":"2024-01-10 08:32:06.000000000","message":"https://review.opendev.org/c/openstack/ironic-python-agent/+/903999/4/ironic_python_agent/tests/unit/test_agent.py#1273 is the best we can get. A  test on kernel params will be more of a \"check that a Python dictionary works\".\n\nSeveral URLs look like any list: comma-separated.","commit_id":"678672587d11beaa39f08ae8db8a4b154e351748"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3284d99d387f076065f9733a3395b008d000bb78","unresolved":true,"context_lines":[{"line_number":36,"context_line":"                    \u0027A special value \"mdns\" can be specified to fetch the \u0027"},{"line_number":37,"context_line":"                    \u0027URL using multicast DNS service discovery. If several \u0027"},{"line_number":38,"context_line":"                    \u0027URLs are provided, all of them are tried until one \u0027"},{"line_number":39,"context_line":"                    \u0027does not return a connection error.\u0027),"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027global_request_id\u0027,"},{"line_number":42,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-global-request-id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"eb95bf81_c0aa91f7","line":39,"in_reply_to":"b9130a23_0ee6aa00","updated":"2024-01-08 08:46:17.000000000","message":"The regex only checks that the value starts with either mdns or http(s). It does not make any assumptions about the further contents (see .+ in the end).","commit_id":"678672587d11beaa39f08ae8db8a4b154e351748"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d61e781ddced6bd728369c020a02f5df5d456df8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    \u0027A special value \"mdns\" can be specified to fetch the \u0027"},{"line_number":37,"context_line":"                    \u0027URL using multicast DNS service discovery. If several \u0027"},{"line_number":38,"context_line":"                    \u0027URLs are provided, all of them are tried until one \u0027"},{"line_number":39,"context_line":"                    \u0027does not return a connection error.\u0027),"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027global_request_id\u0027,"},{"line_number":42,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-global-request-id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"228fa7c5_3ddc6f8f","line":39,"in_reply_to":"eb95bf81_c0aa91f7","updated":"2024-01-08 17:19:09.000000000","message":"Done","commit_id":"678672587d11beaa39f08ae8db8a4b154e351748"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a18bc842d0a44a49f9a3f161a2bef987656cc52f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    \u0027A special value \"mdns\" can be specified to fetch the \u0027"},{"line_number":37,"context_line":"                    \u0027URL using multicast DNS service discovery. If several \u0027"},{"line_number":38,"context_line":"                    \u0027URLs are provided, all of them are tried until one \u0027"},{"line_number":39,"context_line":"                    \u0027does not return a connection error.\u0027),"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027global_request_id\u0027,"},{"line_number":42,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-global-request-id\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"70f34b53_6a80f354","line":39,"in_reply_to":"edc0205e_0e82bf39","updated":"2024-01-16 17:40:08.000000000","message":"Ack; thanks.","commit_id":"678672587d11beaa39f08ae8db8a4b154e351748"}],"releasenotes/notes/several-urls-9c3b8c14338b06ba.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2f87f99e2b647c394a808cf5791e1f51de3c2d01","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Supports several comma-separated URLs for ``ipa-api-url`` and"},{"line_number":5,"context_line":"    ``ipa-inspection-callback-url``. The URLs are probed in the provided"},{"line_number":6,"context_line":"    order until one does not return a connection error. The primary use case"},{"line_number":7,"context_line":"    it to support deploying nodes with only one IP stack from an Ironic"},{"line_number":8,"context_line":"    installation that has both stacks."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d010d58d_b1451399","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":6},"updated":"2024-01-11 08:41:27.000000000","message":"nit: is","commit_id":"0d4ae976c2ecf843ffc5fc9f76c98910a774708c"}]}