)]}'
{"id":"openstack%2Fironic-python-agent~912760","triplet_id":"openstack%2Fironic-python-agent~stable%2F2023.2~I8bd27fa706b298b28ef5bef405134a2c9803d757","project":"openstack/ironic-python-agent","branch":"stable/2023.2","attention_set":{},"removed_from_attention_set":{"10239":{"account":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"last_update":"2024-03-18 11:07:09.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8bd27fa706b298b28ef5bef405134a2c9803d757","subject":"Use assert_not_called","status":"MERGED","created":"2024-03-17 13:59:21.000000000","updated":"2024-03-18 11:08:14.000000000","submitted":"2024-03-18 11:07:09.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"912760","cherry_pick_of_change":910209,"cherry_pick_of_patch_set":1,"meta_rev_id":"7e8a96e0f7f91c276edd78ef095bb796a842fc10","_number":912760,"virtual_id_number":912760,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-03-18 11:07:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2024-03-18 09:23:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2024-03-18 09:23:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-17 13:59:21.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"state":"CC"},{"updated":"2024-03-17 14:05:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-03-17 15:33:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-18 09:23:24.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"}],"messages":[{"id":"be93a3d59191a8590be709fef9b1818d0f7e30e3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2024-03-17 13:59:21.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"f01cb71f7f398606d6d7d3ce7864bd7f313fee3d","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-17 14:05:58.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b7ed5e1492fe471d979cccaaff4f5ee2\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/19a3e8bd94614359920f4348ebfe9f2a : SUCCESS in 5m 01s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/abdf507f74684f8895ca564cdcd87211 : SUCCESS in 5m 20s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/2aaf73cc734845c084ca086a7b2fa9e1 : SUCCESS in 3m 46s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/063559a50b8b409d9295638c966eee84 : SUCCESS in 4m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4da0eb5c4b3fc55875912f370a3dd14da4bbbb41","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-17 15:33:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4f4d9a32eff44865a08a3550065813d4\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/baeccd524ea24bec9c4834849a0dca34 : SUCCESS in 3m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a78d60a6caf14156961409d69589031d : SUCCESS in 3m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c8bb9bd7c036444b91f485df91db834d : SUCCESS in 4m 19s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/4f4994578bc24574b3ef0420ceb702d8 : SUCCESS in 3m 27s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/b66942b70a9948b690e3b619e19fb9da : SUCCESS in 3m 16s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/2184aae4e9fe4394880904432994c373 : SUCCESS in 3m 29s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9b87ed00762c45ac8c4b5d10eedd2652 : SUCCESS in 4m 54s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/4d6b6a29148446759ab61402df390ec7 : SUCCESS in 3m 07s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/1c1fc0cb8ac04178bc90f9fe3ef2c689 : SUCCESS in 1h 01m 13s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/511d117f0263485c8aea63432c6ff2fd : SUCCESS in 1h 25m 42s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/9b570080e4d34025ae8c8520454e363d : SUCCESS in 1h 28m 21s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/b8f9a632aee14d989019ad342df845cf : SUCCESS in 22m 24s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/ae8f7a1bdc6d452d928bf321dce0f2d1 : SUCCESS in 7m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"cd0382301143b9524ee3aeb8cb319cffecd0ffc8","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2024-03-18 09:23:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"69a6779501771e0fb87d07f0a77d04136fc1ec01","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-18 09:23:58.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"3d2c6b168661ec9f5467bda5c5b0bb5b3ba51eae","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-18 11:07:09.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8fc666e9fa00486a9a24ff3766205a66\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ee024432e19b4520a314f662277e4190 : SUCCESS in 3m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bf7a9b4b20564a4abb53723c5abc3c74 : SUCCESS in 5m 11s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3fd828f04f0e41cf82146c904ab4525f : SUCCESS in 5m 01s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/aee6d476cafa4e29a187d4a2e610df7e : SUCCESS in 5m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/33c922fc41a64d649fb160d0490abe2e : SUCCESS in 6m 43s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/99f23c34013145439424240653d6a1e0 : SUCCESS in 3m 21s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/6d5fb1eeea31469ca2a92471529e1ad3 : SUCCESS in 1h 37m 38s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/f0073a06074142a88cbdb0f59e2e9601 : SUCCESS in 1h 29m 04s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/91f3d82c333c40e3ac40c46b08efb50c : SUCCESS in 1h 31m 18s","accounts_in_message":[],"_revision_number":1},{"id":"27aae08e96ed0abdd590e39eb32eab30fc431495","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-18 11:07:09.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"7e8a96e0f7f91c276edd78ef095bb796a842fc10","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-18 11:08:14.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9d5326b8e58749759f448d8e3d7efb68\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/48e29cc8673948fd87b473cb31f86508 : SUCCESS in 44s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ff55824534d5c12b7f9c993f00b7f12dc5400b93","revisions":{"ff55824534d5c12b7f9c993f00b7f12dc5400b93":{"kind":"REWORK","_number":1,"created":"2024-03-17 13:59:21.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/60/912760/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/60/912760/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/60/912760/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/60/912760/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/60/912760/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/60/912760/1"}}},"commit":{"parents":[{"commit":"76292d6f3b0740e6b5a677688ddfc274aa74f36c","subject":"Merge \"Fix referencing to the raid_device var which is not set\" into stable/2023.2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/76292d6f3b0740e6b5a677688ddfc274aa74f36c"}]}],"author":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2024-02-26 10:55:32.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2024-03-17 13:59:21.000000000","tz":0},"subject":"Use assert_not_called","message":"Use assert_not_called\n\nIPA still has 3 occurences of not_called() which are failing for me\nwhen building the Ironic Debian package in Debian Unstable (ie: with\nPython 3.12).\n\nThis patch uses assert_not_called() instead of not_called(), fixing\nthe problem.\n\nChange-Id: I8bd27fa706b298b28ef5bef405134a2c9803d757\n(cherry picked from commit ca6ff4706ba397243233d8adc5b7a20f3ee3a87a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ff55824534d5c12b7f9c993f00b7f12dc5400b93"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ff55824534d5c12b7f9c993f00b7f12dc5400b93"}]},"branch":"refs/heads/stable/2023.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}