)]}'
{"id":"openstack%2Fironic-python-agent~913208","triplet_id":"openstack%2Fironic-python-agent~master~Ifaa800449b49f64c6ba5779bfae1c8e2c3249903","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/2057668","attention_set":{},"removed_from_attention_set":{"31031":{"account":{"_account_id":31031,"name":"Daniel King","email":"openinfra@anewmind.me","username":"DanKingTech"},"last_update":"2024-04-01 14:57:34.000000000","reason":"Change was submitted"},"4571":{"account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"last_update":"2024-04-01 14:57:34.000000000","reason":"Change was submitted"}},"hashtags":["ironic-week-prio"],"change_id":"Ifaa800449b49f64c6ba5779bfae1c8e2c3249903","subject":"Fix mocking for TestGenericHardwareManager","status":"MERGED","created":"2024-03-20 20:02:16.000000000","updated":"2024-04-01 14:58:35.000000000","submitted":"2024-04-01 14:57:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"913208-bug/2057668","meta_rev_id":"0861f7488b735841bc56f12ad00bac0a7198ea6d","_number":913208,"virtual_id_number":913208,"owner":{"_account_id":31031,"name":"Daniel King","email":"openinfra@anewmind.me","username":"DanKingTech"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":32761,"name":"panhongyin","display_name":"panhongyin","email":"panhongyin@yovole.com","username":"panhongyin"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-04-01 14:57:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":2,"date":"2024-03-28 20:01:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":1,"date":"2024-03-29 07:27:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32761,"name":"panhongyin","display_name":"panhongyin","email":"panhongyin@yovole.com","username":"panhongyin"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-04-01 13:07:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":32761,"name":"panhongyin","display_name":"panhongyin","email":"panhongyin@yovole.com","username":"panhongyin"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-04-01 13:07:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":32761,"name":"panhongyin","display_name":"panhongyin","email":"panhongyin@yovole.com","username":"panhongyin"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32761,"name":"panhongyin","display_name":"panhongyin","email":"panhongyin@yovole.com","username":"panhongyin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-20 20:07:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-03-20 21:48:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-24 20:22:38.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"},{"updated":"2024-03-28 20:01:15.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2024-03-29 07:27:49.000000000","updated_by":{"_account_id":32761,"name":"panhongyin","display_name":"panhongyin","email":"panhongyin@yovole.com","username":"panhongyin"},"reviewer":{"_account_id":32761,"name":"panhongyin","display_name":"panhongyin","email":"panhongyin@yovole.com","username":"panhongyin"},"state":"REVIEWER"},{"updated":"2024-04-01 13:07:56.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"}],"messages":[{"id":"7631248c64c34d6b6d273e91b73c215b548763b8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31031,"name":"Daniel King","email":"openinfra@anewmind.me","username":"DanKingTech"},"date":"2024-03-20 20:02:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"649456fbfcef34b0d358f6b48d84240badf0e374","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-20 20:07:37.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1c231a8464bd482c815e705ccaba2225\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/eda29d6e6df047a9aa1b1918594a6789 : SUCCESS in 3m 47s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/470b9e79c2da42029d93fc0f56d04d54 : FAILURE in 3m 22s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/d3dae348a2484817bb38531171cae3ad : SUCCESS in 4m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a487aaa48f88daec090a41b128d6e1b8de7ed9c7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-20 21:48:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a5eff4f7497343e58dcaffa0697b7e18\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/14fe37d307bb43a6986cccc54a50b25e : SUCCESS in 3m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4dc9637863b747488df68a1e498f091b : SUCCESS in 3m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9057c1a03e4c4b2ea9a2f462c632e352 : SUCCESS in 6m 19s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/914353e6ced044a998d179778c996723 : SUCCESS in 5m 29s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/69a7407c14cd45958ce57b71735511e6 : SUCCESS in 8m 18s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/c40dc9d13c064c59978a7471742575e5 : SUCCESS in 4m 22s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/330eb52d2cd84763b441c4137bdd4a49 : SUCCESS in 1h 29m 44s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/43800dad57e14b81b0ae43e08ec86ba4 : FAILURE in 1h 09m 41s (non-voting)\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/3557f00bf02f4df690dd6097a9af6150 : SUCCESS in 1h 36m 45s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/4517afd8d0ea4fd28903df97a5db9849 : SUCCESS in 17m 06s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/25b0931f747c4985a50713d337499f95 : SUCCESS in 11m 30s (non-voting)\n- ipa-tox-codespell https://zuul.opendev.org/t/openstack/build/bc32d4ce22c04efa990c241390ded682 : SUCCESS in 2m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7a47a7d43d9abc70237476a455cf0d6443111a6a","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2024-03-21 15:30:38.000000000","message":"Hashtag added: ironic-week-prio","accounts_in_message":[],"_revision_number":1},{"id":"e18aeb893350ca10e05fb16bdf85e727730c86cb","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2024-03-24 20:22:38.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"66fd37498860ccb9cd636309827ad1c4889d82ea","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31031,"name":"Daniel King","email":"openinfra@anewmind.me","username":"DanKingTech"},"date":"2024-03-27 13:18:26.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"29d96d9bb14e2a88a79c989b4920e45f907b1022","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-27 13:26:46.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/735a8db0ed3f43dfac7f6c37b343f496\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/c9d9f5719780433d9564e4cbcc27c5eb : SUCCESS in 7m 30s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/c984910ad7ea480ea8bff8b3a4ec71e5 : SUCCESS in 6m 04s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e73b7fe55f4a82725826877eed7de52baf85b571","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-27 15:09:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2ef9bb285cf442cb8b7783dcf2f1440e\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/16848bb36f3b4100813b9c6b6ca8affa : SUCCESS in 5m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9decab4e63ba47ab82d782e7e6592f57 : SUCCESS in 3m 06s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/1c12c331e50d4fdca287f5e9fa306f84 : SUCCESS in 3m 59s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/eedc13947767499e92b437ca7fc73cae : SUCCESS in 5m 01s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/8d9e29f5229d48e5bee5d75fa91e450c : SUCCESS in 6m 33s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7f260bd4f31346e38d44a62a2262c516 : SUCCESS in 5m 33s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/8bbf8f2f8e264e45a94c53ad77cf6615 : SUCCESS in 3m 01s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/80868dd5411e428f9df6b195756b932a : SUCCESS in 1h 33m 00s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/d6db7c36b28d4d2384906ea7a5a9f227 : FAILURE in 1h 03m 19s (non-voting)\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/8fac20e5f4724db78f2a856c42564a07 : SUCCESS in 1h 45m 49s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/97a0cc30b5aa4e5e984f8296a04662b6 : SUCCESS in 20m 06s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/e9ffd6d3ba074fdca52bf82411969bec : SUCCESS in 7m 40s (non-voting)\n- ipa-tox-codespell https://zuul.opendev.org/t/openstack/build/3f4b50cf6c4748348fdd067caa6a54e9 : SUCCESS in 3m 00s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"2b63c539c9fcc00c179a9570e173c47967d1c676","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2024-03-28 20:01:15.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"97c0f58df52da593bdc9c9c82c8e283de152aef0","author":{"_account_id":32761,"name":"panhongyin","display_name":"panhongyin","email":"panhongyin@yovole.com","username":"panhongyin"},"date":"2024-03-29 07:27:49.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"fe22e44ffc3d7332f635ae43c6fe8c8f3d4ba9f7","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2024-04-01 13:07:56.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"4f1312f24c94939624db26a3abd9012e6a0c4253","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-01 13:08:30.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"eff90ab7abbf07380fcf6c6d8133c9e5bdd4381c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-01 14:57:34.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c14a7682ed5c47b9aadd1496fc4a51b4\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/35817bf29c7e411d959bf9cd76d18b5a : SUCCESS in 3m 38s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/bd68d44a25904eeb97f28535ed5b2196 : SUCCESS in 3m 51s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/86b749471bb34c99982f699bb09cd911 : SUCCESS in 4m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d16ef1171eca4ec9bb3be5dfd280b830 : SUCCESS in 5m 28s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/497227b022414dbb94275a73082066fe : SUCCESS in 3m 44s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/676e298b6d764d22a1ed9cb3857facf8 : SUCCESS in 1h 43m 50s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/5804d12b38184eba8a29ede947607f5e : SUCCESS in 1h 34m 45s","accounts_in_message":[],"_revision_number":2},{"id":"d38b08e4ab4057b8398e3ab0b68332b2ad9ab722","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-01 14:57:34.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"0861f7488b735841bc56f12ad00bac0a7198ea6d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-04-01 14:58:35.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e3bfd32b8e7b45649dd6571e88528886\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f053414764e54e5b894751593c740ef0 : SUCCESS in 43s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cae6b15bbc725288632ba9886dc8e2704cd5ff15","revisions":{"9fd95efd2f359bd4dd0eedcacc45c0008a55631e":{"kind":"REWORK","_number":1,"created":"2024-03-20 20:02:16.000000000","uploader":{"_account_id":31031,"name":"Daniel King","email":"openinfra@anewmind.me","username":"DanKingTech"},"ref":"refs/changes/08/913208/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/08/913208/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/913208/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/913208/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/913208/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/913208/1"}}},"commit":{"parents":[{"commit":"8de6e03539be896d360b8355d4e602b9ae34d557","subject":"Update ironic-lib min required version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8de6e03539be896d360b8355d4e602b9ae34d557"}]}],"author":{"name":"Daniel King","email":"openinfra@anewmind.me","date":"2024-03-19 15:50:13.000000000","tz":-240},"committer":{"name":"Daniel King","email":"openinfra@anewmind.me","date":"2024-03-20 19:51:36.000000000","tz":-240},"subject":"Fix mocking for TestGenericHardwareManager","message":"Fix mocking for TestGenericHardwareManager\n\n    This test class is testing the GenericHardwareManager, but did no\n    mocking for dispatch_to_managers. Therefore, if any of its methods\n    attempted to make a call to that method, it would break the unit tests.\n\n    This update adds mocking for get_managers to prevent the tests from\n    breaking if a method calls dispatch_to_managers.\n\n    Additionally, updates test_delete_configuration_skip_list.\n    test_delete_configuration_skip_list mocks get_skip_list_from_node.\n    mocks get_skip_list_from_node.\n    Correcting the return_value from a list to a set to match what is\n    returned from the original method.\n\n    Related-Bug: 2057668\n\nChange-Id: Ifaa800449b49f64c6ba5779bfae1c8e2c3249903\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9fd95efd2f359bd4dd0eedcacc45c0008a55631e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9fd95efd2f359bd4dd0eedcacc45c0008a55631e"}]},"branch":"refs/heads/master"},"cae6b15bbc725288632ba9886dc8e2704cd5ff15":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-03-27 13:18:26.000000000","uploader":{"_account_id":31031,"name":"Daniel King","email":"openinfra@anewmind.me","username":"DanKingTech"},"ref":"refs/changes/08/913208/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/08/913208/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/913208/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/913208/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/913208/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/08/913208/2"}}},"commit":{"parents":[{"commit":"8de6e03539be896d360b8355d4e602b9ae34d557","subject":"Update ironic-lib min required version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8de6e03539be896d360b8355d4e602b9ae34d557"}]}],"author":{"name":"Daniel King","email":"openinfra@anewmind.me","date":"2024-03-19 15:50:13.000000000","tz":-240},"committer":{"name":"Daniel King","email":"openinfra@anewmind.me","date":"2024-03-25 16:16:02.000000000","tz":-240},"subject":"Fix mocking for TestGenericHardwareManager","message":"Fix mocking for TestGenericHardwareManager\n\nThis test class is testing the GenericHardwareManager, but did no\nmocking for dispatch_to_managers. Therefore, if any of its methods\nattempted to make a call to that method, it would break the unit tests.\n\nThis update adds mocking for get_managers to prevent the tests from\nbreaking if a method calls dispatch_to_managers.\n\nAdditionally, updates test_delete_configuration_skip_list.\ntest_delete_configuration_skip_list mocks get_skip_list_from_node.\nmocks get_skip_list_from_node.\nCorrecting the return_value from a list to a set to match what is\nreturned from the original method.\n\nRelated-Bug: 2057668\n\nChange-Id: Ifaa800449b49f64c6ba5779bfae1c8e2c3249903\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/cae6b15bbc725288632ba9886dc8e2704cd5ff15"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/cae6b15bbc725288632ba9886dc8e2704cd5ff15"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}