)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d920436d29888f82bf232ddbf8ff91a655508847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"268255b3_0c3bb4d4","updated":"2024-04-04 21:23:56.000000000","message":"I misinterpreted that merge conflict, trying again","commit_id":"6415a8e80b77521d46fb72b402449bbd835e1f46"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5ec2d48c9ab0657f934dbc08e8c58a767c748d4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cee84cf5_dccdab89","updated":"2024-04-19 13:25:04.000000000","message":"recheck metalsmith job should be fixed now","commit_id":"215fecd4470e868e1bac9737417e166a7e10fb64"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9b6343c917c4eb7d50a9d11b61833a3e887c4eae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e7834647_0cfb5865","updated":"2024-04-11 04:02:35.000000000","message":"recheck metalsmith-integration-ipa-src-uefi usually passes","commit_id":"215fecd4470e868e1bac9737417e166a7e10fb64"}],"ironic_python_agent/efi_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"807168213d6addcf84d6cacf1d6391935b38d6cf","unresolved":true,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    for boot_num, entry, _, path in get_boot_records():"},{"line_number":325,"context_line":"        for pattern in patterns:"},{"line_number":326,"context_line":"            if pattern.search(path):"},{"line_number":327,"context_line":"                LOG.debug(\u0027Path %s matched pattern %s, \u0027"},{"line_number":328,"context_line":"                          \u0027entry will be deleted: %s\u0027,"},{"line_number":329,"context_line":"                          path, pattern.pattern, entry)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9113a9d4_790dfe50","line":326,"updated":"2024-04-05 15:45:49.000000000","message":"Do you want to make the search case-insensitive? shim can also be SHIM","commit_id":"7e087f7c25442472dad3b854fb98310a5cfca6d8"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9841473a6548a48d0f28d930756a9db1a2666803","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    for boot_num, entry, _, path in get_boot_records():"},{"line_number":325,"context_line":"        for pattern in patterns:"},{"line_number":326,"context_line":"            if pattern.search(path):"},{"line_number":327,"context_line":"                LOG.debug(\u0027Path %s matched pattern %s, \u0027"},{"line_number":328,"context_line":"                          \u0027entry will be deleted: %s\u0027,"},{"line_number":329,"context_line":"                          path, pattern.pattern, entry)"}],"source_content_type":"text/x-python","patch_set":3,"id":"65befa22_ae43489a","line":326,"in_reply_to":"9113a9d4_790dfe50","updated":"2024-04-08 22:00:31.000000000","message":"Done, in GenericHardwareManager.clean_uefi_nvram","commit_id":"7e087f7c25442472dad3b854fb98310a5cfca6d8"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"18ed549dd1f1243749c2046893e93dfce7796b1b","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    }"},{"line_number":88,"context_line":"}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"DEFAULT_CLEAN_UEFI_NVRAM_MATCH_PATTERNS \u003d [r\u0027^HD\\(\u0027, r\u0027shimx64\\.efi\u0027]"},{"line_number":91,"context_line":"DEPLOY_CLEAN_UEFI_NVRAM_ARGSINFO \u003d {"},{"line_number":92,"context_line":"    \"match_patterns\": {"},{"line_number":93,"context_line":"        \"description\": ("}],"source_content_type":"text/x-python","patch_set":1,"id":"f52ce61a_78e14170","line":90,"updated":"2024-04-02 23:23:00.000000000","message":"So any hard disks and x86_64 shim loaders.\n\nShould we also look for shimaa64.efi","commit_id":"df484fcc8727b98da1e291e53c2f076ecea3a8d5"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9841473a6548a48d0f28d930756a9db1a2666803","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    }"},{"line_number":88,"context_line":"}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"DEFAULT_CLEAN_UEFI_NVRAM_MATCH_PATTERNS \u003d [r\u0027^HD\\(\u0027, r\u0027shimx64\\.efi\u0027]"},{"line_number":91,"context_line":"DEPLOY_CLEAN_UEFI_NVRAM_ARGSINFO \u003d {"},{"line_number":92,"context_line":"    \"match_patterns\": {"},{"line_number":93,"context_line":"        \"description\": ("}],"source_content_type":"text/x-python","patch_set":1,"id":"b806ec96_96ac9bd8","line":90,"in_reply_to":"de3a7f12_13196475","updated":"2024-04-08 22:00:31.000000000","message":"I have gone with:\n\n    [r\u0027^HD\\(\u0027, r\u0027shim.*\\.efi\u0027, r\u0027grub.*\\.efi\u0027]","commit_id":"df484fcc8727b98da1e291e53c2f076ecea3a8d5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"807168213d6addcf84d6cacf1d6391935b38d6cf","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    }"},{"line_number":88,"context_line":"}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"DEFAULT_CLEAN_UEFI_NVRAM_MATCH_PATTERNS \u003d [r\u0027^HD\\(\u0027, r\u0027shimx64\\.efi\u0027]"},{"line_number":91,"context_line":"DEPLOY_CLEAN_UEFI_NVRAM_ARGSINFO \u003d {"},{"line_number":92,"context_line":"    \"match_patterns\": {"},{"line_number":93,"context_line":"        \"description\": ("}],"source_content_type":"text/x-python","patch_set":1,"id":"de3a7f12_13196475","line":90,"in_reply_to":"f52ce61a_78e14170","updated":"2024-04-05 15:45:49.000000000","message":"Maybe even shim.*\\.\n\nMaybe also add grub without shim (just in case)?","commit_id":"df484fcc8727b98da1e291e53c2f076ecea3a8d5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"807168213d6addcf84d6cacf1d6391935b38d6cf","unresolved":true,"context_lines":[{"line_number":2425,"context_line":"                \u0027reboot_requested\u0027: False,"},{"line_number":2426,"context_line":"                \u0027abortable\u0027: True"},{"line_number":2427,"context_line":"            },"},{"line_number":2428,"context_line":"            {"},{"line_number":2429,"context_line":"                \u0027step\u0027: \u0027delete_configuration\u0027,"},{"line_number":2430,"context_line":"                \u0027priority\u0027: 0,"},{"line_number":2431,"context_line":"                \u0027interface\u0027: \u0027raid\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c06a5202_2f33de86","line":2428,"updated":"2024-04-05 15:45:49.000000000","message":"A clean step as well for consistency?","commit_id":"7e087f7c25442472dad3b854fb98310a5cfca6d8"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9841473a6548a48d0f28d930756a9db1a2666803","unresolved":false,"context_lines":[{"line_number":2425,"context_line":"                \u0027reboot_requested\u0027: False,"},{"line_number":2426,"context_line":"                \u0027abortable\u0027: True"},{"line_number":2427,"context_line":"            },"},{"line_number":2428,"context_line":"            {"},{"line_number":2429,"context_line":"                \u0027step\u0027: \u0027delete_configuration\u0027,"},{"line_number":2430,"context_line":"                \u0027priority\u0027: 0,"},{"line_number":2431,"context_line":"                \u0027interface\u0027: \u0027raid\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4d496d5a_2b71a0de","line":2428,"in_reply_to":"c06a5202_2f33de86","updated":"2024-04-08 22:00:31.000000000","message":"Done","commit_id":"7e087f7c25442472dad3b854fb98310a5cfca6d8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"807168213d6addcf84d6cacf1d6391935b38d6cf","unresolved":true,"context_lines":[{"line_number":2568,"context_line":"                \u0027argsinfo\u0027: DEPLOY_CLEAN_UEFI_NVRAM_ARGSINFO,"},{"line_number":2569,"context_line":"            },"},{"line_number":2570,"context_line":"            {"},{"line_number":2571,"context_line":"                \u0027step\u0027: \u0027write_image\u0027,"},{"line_number":2572,"context_line":"                # NOTE(dtantsur): this step has to be proxied via an"},{"line_number":2573,"context_line":"                # out-of-band step with the same name, hence the priority here"},{"line_number":2574,"context_line":"                # doesn\u0027t really matter."}],"source_content_type":"text/x-python","patch_set":3,"id":"5e71383f_ca105b82","line":2571,"updated":"2024-04-05 15:45:49.000000000","message":"OMG why is this a service step? O__o","commit_id":"7e087f7c25442472dad3b854fb98310a5cfca6d8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1a55c6e679ed5f25b99681f28c40bb9cc705df2","unresolved":true,"context_lines":[{"line_number":2568,"context_line":"                \u0027argsinfo\u0027: DEPLOY_CLEAN_UEFI_NVRAM_ARGSINFO,"},{"line_number":2569,"context_line":"            },"},{"line_number":2570,"context_line":"            {"},{"line_number":2571,"context_line":"                \u0027step\u0027: \u0027write_image\u0027,"},{"line_number":2572,"context_line":"                # NOTE(dtantsur): this step has to be proxied via an"},{"line_number":2573,"context_line":"                # out-of-band step with the same name, hence the priority here"},{"line_number":2574,"context_line":"                # doesn\u0027t really matter."}],"source_content_type":"text/x-python","patch_set":3,"id":"7d70f96d_bc2e5f74","line":2571,"in_reply_to":"0e49ccac_4ba48b69","updated":"2024-04-09 09:12:47.000000000","message":"Sorry for confusing you, it was a side comment about write_image. But yes, thinking about it, clean_uefi_nvram is questionable as a service step - too easy to corrupt the deployment and also easy enough to do from within the machine.","commit_id":"7e087f7c25442472dad3b854fb98310a5cfca6d8"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9841473a6548a48d0f28d930756a9db1a2666803","unresolved":true,"context_lines":[{"line_number":2568,"context_line":"                \u0027argsinfo\u0027: DEPLOY_CLEAN_UEFI_NVRAM_ARGSINFO,"},{"line_number":2569,"context_line":"            },"},{"line_number":2570,"context_line":"            {"},{"line_number":2571,"context_line":"                \u0027step\u0027: \u0027write_image\u0027,"},{"line_number":2572,"context_line":"                # NOTE(dtantsur): this step has to be proxied via an"},{"line_number":2573,"context_line":"                # out-of-band step with the same name, hence the priority here"},{"line_number":2574,"context_line":"                # doesn\u0027t really matter."}],"source_content_type":"text/x-python","patch_set":3,"id":"0e49ccac_4ba48b69","line":2571,"in_reply_to":"5e71383f_ca105b82","updated":"2024-04-08 22:00:31.000000000","message":"Lol, removed for now. But it could be a service step if the default match pattern is an empty list, making it a noop by default.","commit_id":"7e087f7c25442472dad3b854fb98310a5cfca6d8"}],"releasenotes/notes/clean_uefi_nvram-554041f2e7b2d555.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"807168213d6addcf84d6cacf1d6391935b38d6cf","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a deploy step ``clean_uefi_nvram`` to remove unrequired extra UEFI"},{"line_number":5,"context_line":"    NVRAM boot entries. By default any entry with ``HD`` as the root device, or"},{"line_number":6,"context_line":"    with ``simx64.efi`` in the path will be deleted, ensuring that disk based"},{"line_number":7,"context_line":"    boot entries are removed before the new entry is created for the written"},{"line_number":8,"context_line":"    image. The ``match_patterns`` parameter allows a list of regular expressions"},{"line_number":9,"context_line":"    to be passed, where a match in the device path will result in that entry"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"319ec293_c6db35b2","line":6,"updated":"2024-04-05 15:45:49.000000000","message":"typo: shim","commit_id":"7e087f7c25442472dad3b854fb98310a5cfca6d8"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9841473a6548a48d0f28d930756a9db1a2666803","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a deploy step ``clean_uefi_nvram`` to remove unrequired extra UEFI"},{"line_number":5,"context_line":"    NVRAM boot entries. By default any entry with ``HD`` as the root device, or"},{"line_number":6,"context_line":"    with ``simx64.efi`` in the path will be deleted, ensuring that disk based"},{"line_number":7,"context_line":"    boot entries are removed before the new entry is created for the written"},{"line_number":8,"context_line":"    image. The ``match_patterns`` parameter allows a list of regular expressions"},{"line_number":9,"context_line":"    to be passed, where a match in the device path will result in that entry"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e782368b_883b8e8e","line":6,"in_reply_to":"319ec293_c6db35b2","updated":"2024-04-08 22:00:31.000000000","message":"Done","commit_id":"7e087f7c25442472dad3b854fb98310a5cfca6d8"}]}