)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c03b3c7d42f2548d4adc60efe8480aedf35023a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"01b4c454_e1d6c172","updated":"2024-04-23 07:01:05.000000000","message":"recheck although pep8 failure is legit","commit_id":"a92e939d02078ef0fba18f481f3d622a41cf6145"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39656dc58821634ad44491027d5933febf2d0670","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ee67deb3_7264fdc9","updated":"2024-04-24 20:38:22.000000000","message":"Fixed trivial issues in the release note. Approving since the change already had +2 before.","commit_id":"ceec5a73674c0fc078dc0384bf10ce4aae2ae8ea"}],"releasenotes/notes/support-4096-sector-size-490adc8ed256092d.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5f226d9b6c64a38779ab50b7026cd980a87d54aa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    destroy_disk_metadata: support 4096 sector size in addition to 512"},{"line_number":5,"context_line":"    A sector size of 512 was assumed and hardcoded, causing dd to fail when"},{"line_number":6,"context_line":"    it tried to write in chunks smaller than the sector size for disks with"},{"line_number":7,"context_line":"    4096 bytes sectors. The size of GPT in sectors also depends on sector size."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8ab605ea_ec7396e8","line":4,"updated":"2024-04-23 12:31:36.000000000","message":"release notes are aimed for users\nlet\u0027s try to express this from a user perspective and not mentioning internal functions\nyou can even omit it and just add something like \"ironic now supports 4096 sector size in addition to 512 when cleaning disk metadata\" at the end","commit_id":"4ac71fc45730deac7ca981df014e8110ff4c7424"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f2a44440b3ddd4b0b9d2bcf579b584a8f8919c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for disks with 4096 sector size when cleaning disk metadata."},{"line_number":5,"context_line":"    Before this only 512 sector size disks where supported."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b1a90ef0_68690569","line":4,"updated":"2024-04-24 20:36:36.000000000","message":"nit: we use present tense (\"Adds\")","commit_id":"bcaf99dab8d07fe20f1c06f55a6edf66afa620c1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f2a44440b3ddd4b0b9d2bcf579b584a8f8919c8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for disks with 4096 sector size when cleaning disk metadata."},{"line_number":5,"context_line":"    Before this only 512 sector size disks where supported."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"930e2eaa_040b6b1f","line":5,"updated":"2024-04-24 20:36:36.000000000","message":"nit: s/where/were/","commit_id":"bcaf99dab8d07fe20f1c06f55a6edf66afa620c1"}]}