)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"34e44b38903b1974a8d03d8d6da46c426af68c5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2306573a_955b1a00","updated":"2024-05-07 20:17:06.000000000","message":"Please remove the unrelated whitespace changes. \n\nThis change also needs a release note -- you can add one by running `tox -e venv -- reno new add-bmc-subnet-info` and editing+committing the resulting yaml file\n\nThanks for the submission!","commit_id":"50e682b5cdff3fe43b746af8cb4a8baa251776e7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a7c517c3f9215b94a574be534d765e9647478a74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"edf6d585_84889457","updated":"2024-05-15 16:01:23.000000000","message":"This change needs a release note.\nPlease remove all unrelated whitespace changes from this -- if committed, they will pollute our git history and make git blame less useful.","commit_id":"9767c276cb91e9bdc50d67911f1d6a1058b0bc9a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9ae08b398ce02f711037a624213d28ade7140aa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2a576d6f_6ba0e69e","updated":"2024-06-12 18:19:54.000000000","message":"Whitespace changes were not removed as requested. Please do not make style-only changes that are not reflective of our enforced lint in this repo.","commit_id":"112c15cae6b2625983bab7ccb58587a6c87d138d"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"34e44b38903b1974a8d03d8d6da46c426af68c5a","unresolved":true,"context_lines":[{"line_number":142,"context_line":"    will do the needful."},{"line_number":143,"context_line":"    \"\"\""},{"line_number":144,"context_line":"    if (os.path.isfile(\u0027/usr/sbin/mpathconf\u0027)"},{"line_number":145,"context_line":"            and not os.path.isfile(\u0027/etc/multipath.conf\u0027)):"},{"line_number":146,"context_line":"        # For Centos/Rhel/Etc which uses mpathconf, this does"},{"line_number":147,"context_line":"        # a couple different things, including configuration generation..."},{"line_number":148,"context_line":"        # which is not *really* required.. at least *shouldn\u0027t* be."}],"source_content_type":"text/x-python","patch_set":5,"id":"0e93bfff_5986bc25","line":145,"updated":"2024-05-07 20:17:06.000000000","message":"Unrelated whitespace change here and throughout. Please ensure your changes are limited to what you\u0027re meaning to adjust -- I suspect your IDE may have reformatted the whole file and created these unintended whitespace changes.","commit_id":"50e682b5cdff3fe43b746af8cb4a8baa251776e7"},{"author":{"_account_id":37011,"name":"Maximilian Brandt","display_name":"Maximilian Brandt","email":"maximilian.brandt@cloudandheat.com","username":"Schmexs"},"change_message_id":"5e527e0138695b32ec9a34c2b48527711446b49f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    will do the needful."},{"line_number":143,"context_line":"    \"\"\""},{"line_number":144,"context_line":"    if (os.path.isfile(\u0027/usr/sbin/mpathconf\u0027)"},{"line_number":145,"context_line":"            and not os.path.isfile(\u0027/etc/multipath.conf\u0027)):"},{"line_number":146,"context_line":"        # For Centos/Rhel/Etc which uses mpathconf, this does"},{"line_number":147,"context_line":"        # a couple different things, including configuration generation..."},{"line_number":148,"context_line":"        # which is not *really* required.. at least *shouldn\u0027t* be."}],"source_content_type":"text/x-python","patch_set":5,"id":"5f618d14_a46834f8","line":145,"in_reply_to":"0e93bfff_5986bc25","updated":"2024-05-11 08:50:16.000000000","message":"Acknowledged","commit_id":"50e682b5cdff3fe43b746af8cb4a8baa251776e7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"34e44b38903b1974a8d03d8d6da46c426af68c5a","unresolved":true,"context_lines":[{"line_number":2353,"context_line":"        \"\"\""},{"line_number":2354,"context_line":"        bmc_subnet \u003d self._get_bmc_address_info(\"Subnet Mask\")"},{"line_number":2355,"context_line":"        if bmc_subnet \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":2356,"context_line":"            return \u0027255.255.255.255\u0027"},{"line_number":2357,"context_line":"        return bmc_subnet"},{"line_number":2358,"context_line":""},{"line_number":2359,"context_line":"    def get_bmc_mac(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"cd20cbba_e6bd5ca5","line":2356,"updated":"2024-05-07 20:17:06.000000000","message":"Are we sure this mapping isn\u0027t a vendor-ism of some sort?","commit_id":"50e682b5cdff3fe43b746af8cb4a8baa251776e7"},{"author":{"_account_id":37011,"name":"Maximilian Brandt","display_name":"Maximilian Brandt","email":"maximilian.brandt@cloudandheat.com","username":"Schmexs"},"change_message_id":"5e527e0138695b32ec9a34c2b48527711446b49f","unresolved":false,"context_lines":[{"line_number":2353,"context_line":"        \"\"\""},{"line_number":2354,"context_line":"        bmc_subnet \u003d self._get_bmc_address_info(\"Subnet Mask\")"},{"line_number":2355,"context_line":"        if bmc_subnet \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":2356,"context_line":"            return \u0027255.255.255.255\u0027"},{"line_number":2357,"context_line":"        return bmc_subnet"},{"line_number":2358,"context_line":""},{"line_number":2359,"context_line":"    def get_bmc_mac(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"b3758c8c_81543b81","line":2356,"in_reply_to":"cd20cbba_e6bd5ca5","updated":"2024-05-11 08:50:16.000000000","message":"Yes, the BMC subnet, just like the BMC IP address, is always vendor-independent.\n(or have I misunderstood your question?)","commit_id":"50e682b5cdff3fe43b746af8cb4a8baa251776e7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a7c517c3f9215b94a574be534d765e9647478a74","unresolved":true,"context_lines":[{"line_number":846,"context_line":""},{"line_number":847,"context_line":"class Memory(encoding.SerializableComparable):"},{"line_number":848,"context_line":"    serializable_fields \u003d (\u0027total\u0027, \u0027physical_mb\u0027)"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    # physical \u003d total + kernel binary + reserved space"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"    def __init__(self, total, physical_mb\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"f17125c6_016c8a53","line":849,"updated":"2024-05-15 16:01:23.000000000","message":"nit: inadvertant whitespace addition","commit_id":"9767c276cb91e9bdc50d67911f1d6a1058b0bc9a"},{"author":{"_account_id":37011,"name":"Maximilian Brandt","display_name":"Maximilian Brandt","email":"maximilian.brandt@cloudandheat.com","username":"Schmexs"},"change_message_id":"02616716cee26b0429adce1b54399e57f9c3689c","unresolved":false,"context_lines":[{"line_number":846,"context_line":""},{"line_number":847,"context_line":"class Memory(encoding.SerializableComparable):"},{"line_number":848,"context_line":"    serializable_fields \u003d (\u0027total\u0027, \u0027physical_mb\u0027)"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    # physical \u003d total + kernel binary + reserved space"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"    def __init__(self, total, physical_mb\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"cc29380c_259bde7a","line":849,"in_reply_to":"f17125c6_016c8a53","updated":"2024-06-07 12:47:12.000000000","message":"Acknowledged","commit_id":"9767c276cb91e9bdc50d67911f1d6a1058b0bc9a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a7c517c3f9215b94a574be534d765e9647478a74","unresolved":true,"context_lines":[{"line_number":2264,"context_line":"                # instead"},{"line_number":2265,"context_line":"                crypto_caps \u003d nvme_info[\u0027fna\u0027]"},{"line_number":2266,"context_line":"                if crypto_caps \u0026 NVME_CLI_CRYPTO_FORMAT_SUPPORTED_FLAG:"},{"line_number":2267,"context_line":"                    format_mode \u003d 2  # crypto erase"},{"line_number":2268,"context_line":"                else:"},{"line_number":2269,"context_line":"                    format_mode \u003d 1  # user-data erase"},{"line_number":2270,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fd0d6fa3_d1e5bb68","line":2267,"updated":"2024-05-15 16:01:23.000000000","message":"These are reasonable whitespace fixed; but please do not make changes in the code outside of your specific change.","commit_id":"9767c276cb91e9bdc50d67911f1d6a1058b0bc9a"},{"author":{"_account_id":37011,"name":"Maximilian Brandt","display_name":"Maximilian Brandt","email":"maximilian.brandt@cloudandheat.com","username":"Schmexs"},"change_message_id":"02616716cee26b0429adce1b54399e57f9c3689c","unresolved":false,"context_lines":[{"line_number":2264,"context_line":"                # instead"},{"line_number":2265,"context_line":"                crypto_caps \u003d nvme_info[\u0027fna\u0027]"},{"line_number":2266,"context_line":"                if crypto_caps \u0026 NVME_CLI_CRYPTO_FORMAT_SUPPORTED_FLAG:"},{"line_number":2267,"context_line":"                    format_mode \u003d 2  # crypto erase"},{"line_number":2268,"context_line":"                else:"},{"line_number":2269,"context_line":"                    format_mode \u003d 1  # user-data erase"},{"line_number":2270,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"e027d50a_fd7db5eb","line":2267,"in_reply_to":"fd0d6fa3_d1e5bb68","updated":"2024-06-07 12:47:12.000000000","message":"Acknowledged","commit_id":"9767c276cb91e9bdc50d67911f1d6a1058b0bc9a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a7c517c3f9215b94a574be534d765e9647478a74","unresolved":true,"context_lines":[{"line_number":2298,"context_line":"        \"\"\"Attempt to detect BMC information"},{"line_number":2299,"context_line":""},{"line_number":2300,"context_line":"        :param type: Keyword to search for in IPMITool output"},{"line_number":2301,"context_line":"        (e.g., \u0027IP Address\u0027, \u0027Subnet Mask\u0027)"},{"line_number":2302,"context_line":"        :return: BMC information (IP address or subnet mask) or"},{"line_number":2303,"context_line":"        default value if none found"},{"line_number":2304,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"bda09814_1891e0e3","line":2301,"updated":"2024-05-15 16:01:23.000000000","message":"these are typically hanging indented -- I\u0027d align ( with K.\n\nThis isn\u0027t a style nit; this will ensure sphinx will properly identify and document this method.","commit_id":"9767c276cb91e9bdc50d67911f1d6a1058b0bc9a"},{"author":{"_account_id":37011,"name":"Maximilian Brandt","display_name":"Maximilian Brandt","email":"maximilian.brandt@cloudandheat.com","username":"Schmexs"},"change_message_id":"02616716cee26b0429adce1b54399e57f9c3689c","unresolved":false,"context_lines":[{"line_number":2298,"context_line":"        \"\"\"Attempt to detect BMC information"},{"line_number":2299,"context_line":""},{"line_number":2300,"context_line":"        :param type: Keyword to search for in IPMITool output"},{"line_number":2301,"context_line":"        (e.g., \u0027IP Address\u0027, \u0027Subnet Mask\u0027)"},{"line_number":2302,"context_line":"        :return: BMC information (IP address or subnet mask) or"},{"line_number":2303,"context_line":"        default value if none found"},{"line_number":2304,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"9139de71_cec17af6","line":2301,"in_reply_to":"bda09814_1891e0e3","updated":"2024-06-07 12:47:12.000000000","message":"Acknowledged","commit_id":"9767c276cb91e9bdc50d67911f1d6a1058b0bc9a"}]}