)]}'
{"ironic_python_agent/extensions/standby.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8aaa07961ef6cd5420b798317283e040e3a6121f","unresolved":true,"context_lines":[{"line_number":391,"context_line":"                                           use_standard_locale\u003dTrue)"},{"line_number":392,"context_line":"            if (\u0027filesystem data\u0027 in stdout"},{"line_number":393,"context_line":"                    or \u0027Filesystem\u0027 in stdout"},{"line_number":394,"context_line":"                    or \u0027NTFS\u0027 in stdout):"},{"line_number":395,"context_line":"                # Checking for presence of:"},{"line_number":396,"context_line":"                # \u0027filesystem data\u0027 catches ext4, xfs."},{"line_number":397,"context_line":"                # \u0027Filesystem\u0027 is needed for btrfs"}],"source_content_type":"text/x-python","patch_set":1,"id":"48d00972_ce9fdbc4","line":394,"updated":"2024-09-03 13:56:19.000000000","message":"Does not seem to work this way on my laptop:\n\n$ sudo file /dev/nvme0n1\n/dev/nvme0n1: block special (259/0)\n$ sudo file /dev/nvme0n1p1\n/dev/nvme0n1p1: block special (259/1)","commit_id":"3c0c75cdb076d3c522f760f1b27857dd78ffe30b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ed51252f141acda1eda7541973cb7b20d14ce1cd","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                                           use_standard_locale\u003dTrue)"},{"line_number":392,"context_line":"            if (\u0027filesystem data\u0027 in stdout"},{"line_number":393,"context_line":"                    or \u0027Filesystem\u0027 in stdout"},{"line_number":394,"context_line":"                    or \u0027NTFS\u0027 in stdout):"},{"line_number":395,"context_line":"                # Checking for presence of:"},{"line_number":396,"context_line":"                # \u0027filesystem data\u0027 catches ext4, xfs."},{"line_number":397,"context_line":"                # \u0027Filesystem\u0027 is needed for btrfs"}],"source_content_type":"text/x-python","patch_set":1,"id":"bbcefae9_c76730f3","line":394,"in_reply_to":"48d00972_ce9fdbc4","updated":"2024-09-03 23:14:23.000000000","message":"Done","commit_id":"3c0c75cdb076d3c522f760f1b27857dd78ffe30b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8aaa07961ef6cd5420b798317283e040e3a6121f","unresolved":true,"context_lines":[{"line_number":406,"context_line":"                                             log_stdout\u003dFalse)"},{"line_number":407,"context_line":"            parted \u003d json.loads(stdout)"},{"line_number":408,"context_line":"            device_block_size \u003d parted[\u0027disk\u0027][\u0027logical-sector-size\u0027]"},{"line_number":409,"context_line":"            raise errors.PartitionTableNotFound(device_block_size)"},{"line_number":410,"context_line":"        except (processutils.ProcessExecutionError,"},{"line_number":411,"context_line":"                json.decoder.JSONDecodeError,"},{"line_number":412,"context_line":"                OSError, KeyError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3af4bdb1_6084edb7","line":409,"updated":"2024-09-03 13:56:19.000000000","message":"Are you sure fix_gpt_partition cannot fail for any other reason? Maybe check for device_block_size !\u003d 512?","commit_id":"3c0c75cdb076d3c522f760f1b27857dd78ffe30b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ed51252f141acda1eda7541973cb7b20d14ce1cd","unresolved":true,"context_lines":[{"line_number":406,"context_line":"                                             log_stdout\u003dFalse)"},{"line_number":407,"context_line":"            parted \u003d json.loads(stdout)"},{"line_number":408,"context_line":"            device_block_size \u003d parted[\u0027disk\u0027][\u0027logical-sector-size\u0027]"},{"line_number":409,"context_line":"            raise errors.PartitionTableNotFound(device_block_size)"},{"line_number":410,"context_line":"        except (processutils.ProcessExecutionError,"},{"line_number":411,"context_line":"                json.decoder.JSONDecodeError,"},{"line_number":412,"context_line":"                OSError, KeyError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"57a7fb57_b18ccc87","line":409,"in_reply_to":"3af4bdb1_6084edb7","updated":"2024-09-03 23:14:23.000000000","message":"I\u0027m feeling a little out of it, so this might be disjointed, but I\u0027m not sure we can actually directly check and compare (and thus \"know\" there is a mismatch) because we can\u0027t actually know the intent since it doesn\u0027t seem to be recorded at any point.\n\nI guess the only other failure case is if sgdisk just doesn\u0027t exist to repair partition table, but that is an explicit requirement.","commit_id":"3c0c75cdb076d3c522f760f1b27857dd78ffe30b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8062b40f6daae1a531dc81008328699e287ccfa8","unresolved":true,"context_lines":[{"line_number":454,"context_line":"        # and we wrote it to disk, which could mean block size mismatching"},{"line_number":455,"context_line":"        # and ultimately, we just don\u0027t have a partition table here we can"},{"line_number":456,"context_line":"        # work with. So we raise an appropriate exception."},{"line_number":457,"context_line":"        raise errors.PartitionTableNotFound(device_block_size)"},{"line_number":458,"context_line":"    except (processutils.ProcessExecutionError,"},{"line_number":459,"context_line":"            json.decoder.JSONDecodeError,"},{"line_number":460,"context_line":"            OSError, KeyError):"}],"source_content_type":"text/x-python","patch_set":3,"id":"96ea7baf_a6999233","line":457,"updated":"2024-09-04 13:17:54.000000000","message":"So one thought I have here, is we could check len of [\u0027disk\u0027][\u0027partitions\u0027], if it exists, because that would be the number of partitions parted reads.\n\nA way to explicitly detect mismatch is we could take the native block device size, and then try to get partition data for the various sizes, 512, 1024, 2048, and 4096 using fdisk which does support doing explicit size interactions. Parted, sfdisk which both support json output don\u0027t support it. The alternative would be to proxy using a loopback. That seems like a bit much work to kind of reach what we already suspect, an underlying mismatch or bad image.","commit_id":"22a322186d547f2202b9283a9d387f66f0047d5a"}]}