)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b36de052c9bac2d5faf3384840b30fbcb1d395a1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d224b2a3_2f993428","updated":"2024-10-02 16:56:10.000000000","message":"Alternatively we can use importlib.metadata, which might be smarter... let me look into it as well.","commit_id":"ec9354ae0f0d4170ca67d64adc306504c268a3aa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"23d7a45764cbcec86e848065d94ae3879f1f3561","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc7f696f_63c48872","updated":"2024-10-02 17:21:01.000000000","message":"Idk how much the dev version naming matters but I see importlib.metadata is more conpatible so probably using it is better.\n\n```\n\u003e\u003e\u003e import importlib.metadata\n\u003e\u003e\u003e importlib.metadata.version(\u0027ironic-python-agent\u0027)\n\u00279.14.1.dev1\u0027\n\u003e\u003e\u003e import pbr.version\n\u003e\u003e\u003e pbr.version.VersionInfo(\u0027ironic_python_agent\u0027).version_string()\n\u00279.14.1\u0027\n\u003e\u003e\u003e import pkg_resources\n\u003cstdin\u003e:1: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n\u003e\u003e\u003e pkg_resources.get_distribution(\u0027ironic-python-agent\u0027).version\n\u00279.14.1.dev1\u0027\n```","commit_id":"ec9354ae0f0d4170ca67d64adc306504c268a3aa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ba7e933fcddc12054da8488ef1838d5650b85351","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ab219a50_b1b433c7","in_reply_to":"d224b2a3_2f993428","updated":"2024-10-02 17:23:12.000000000","message":"Done","commit_id":"ec9354ae0f0d4170ca67d64adc306504c268a3aa"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"caf998b010c2a3a503aa8325e7a3a3b07f004908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"597fce15_1df8b39f","in_reply_to":"dc7f696f_63c48872","updated":"2024-10-02 17:23:26.000000000","message":"I don\u0027t know if it matters, but it\u0027s nice to maintain identical behavior.","commit_id":"ec9354ae0f0d4170ca67d64adc306504c268a3aa"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"34c6ab3c813eee0bcc5bc50413eb303d90836065","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d6a263ea_d0c6700f","updated":"2024-10-03 08:27:26.000000000","message":"thanks, importlib.metadata is the way","commit_id":"2bf694ee44e58973449a5bb1584afc6ee0f01e6d"}],"ironic_python_agent/agent.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"66cbe8f883f593212f2d20420a065ab6c825ab5e","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from oslo_concurrency import processutils"},{"line_number":28,"context_line":"from oslo_config import cfg"},{"line_number":29,"context_line":"from oslo_log import log"},{"line_number":30,"context_line":"import pkg_resources"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from ironic_python_agent.api import app"},{"line_number":33,"context_line":"from ironic_python_agent import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"c06b86c5_a170db16","line":30,"updated":"2024-10-02 20:13:10.000000000","message":"Remove this line.\n\n```suggestion\n```","commit_id":"19aa89f875bb612afeeb0fd99c02d744bfe0a3f3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ffe775115c421b26f071f8954b1c70ca271e59ee","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from oslo_concurrency import processutils"},{"line_number":28,"context_line":"from oslo_config import cfg"},{"line_number":29,"context_line":"from oslo_log import log"},{"line_number":30,"context_line":"import pkg_resources"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from ironic_python_agent.api import app"},{"line_number":33,"context_line":"from ironic_python_agent import config"}],"source_content_type":"text/x-python","patch_set":3,"id":"126a3158_c92b2a6f","line":30,"in_reply_to":"c06b86c5_a170db16","updated":"2024-10-03 00:49:28.000000000","message":"Oops","commit_id":"19aa89f875bb612afeeb0fd99c02d744bfe0a3f3"}]}
