)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5c2f76256486838316cd49bf6bf9a1df81de1362","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b912b4d_6f674a04","updated":"2025-01-26 19:13:47.000000000","message":"This looks nice and clean","commit_id":"6f8f2f137dda023cef9aa49180072ff143755220"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"db72ea85f1d354b843d53b6afdee8d18893e2600","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7455c25f_a026a09b","updated":"2025-02-06 00:00:44.000000000","message":"This is fine to merge as it is, musing a bit about structure in the comments but mainly just curious. \n\n+1 instead of +2 due to service step question","commit_id":"23696ce9efe3d1fb5e9abab0d683dbbdc1d79a3b"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"fc670adb60e7c6abe41f04e6f60056b40426883f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"021ab2dc_e3d1aac8","updated":"2025-02-08 18:51:29.000000000","message":"I agree with Jay that the standby piece is weird. But I think that’s part of a broader refactor.","commit_id":"1508cc4cd0951a49c9605272e69ecd2571395107"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"257b15ba17b13bd85d8563d0e100a248e6abf698","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0c2856ca_8d132cd7","updated":"2025-02-10 04:28:32.000000000","message":"I\u0027m leaving +1 off to give Jay one more crack","commit_id":"1508cc4cd0951a49c9605272e69ecd2571395107"}],"ironic_python_agent/extensions/standby.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cf4be87b7abddf3c4363d6a5fc125ccefa3b16b6","unresolved":true,"context_lines":[{"line_number":1209,"context_line":"        # credentials are already in the container or we embed the credentials,"},{"line_number":1210,"context_line":"        # but that is not the best idea."},{"line_number":1211,"context_line":"        # --disable-selinux is alternatively needed if selinux is *not*"},{"line_number":1212,"context_line":"        # enabled on the host."},{"line_number":1213,"context_line":"        command \u003d ["},{"line_number":1214,"context_line":"            \u0027podman\u0027, \u0027run\u0027, \u0027--rm\u0027, \u0027--privileged\u0027, \u0027--pid\u003dhost\u0027,"},{"line_number":1215,"context_line":"            \u0027-v\u0027, \u0027/var/lib/containers:/var/lib/containers\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7bc0c68b_6b784392","line":1212,"updated":"2025-01-25 02:14:49.000000000","message":"likely also need to set something like:\n\n[engine]\nno_pivot_root \u003d true\n\ninto someplace like:\n\n/etc/containers/containers.conf.d/00-ipa.conf\n\nroot reason is we cannot pivot root on a ramdisk, and the container runtime tries to.","commit_id":"d2449a74f2fd7c832a2f62211005c4523153353e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"330f47b72c89e246e26510bffcc5ade9197ad835","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"        # credentials are already in the container or we embed the credentials,"},{"line_number":1210,"context_line":"        # but that is not the best idea."},{"line_number":1211,"context_line":"        # --disable-selinux is alternatively needed if selinux is *not*"},{"line_number":1212,"context_line":"        # enabled on the host."},{"line_number":1213,"context_line":"        command \u003d ["},{"line_number":1214,"context_line":"            \u0027podman\u0027, \u0027run\u0027, \u0027--rm\u0027, \u0027--privileged\u0027, \u0027--pid\u003dhost\u0027,"},{"line_number":1215,"context_line":"            \u0027-v\u0027, \u0027/var/lib/containers:/var/lib/containers\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bb39d6d2_6804bf55","line":1212,"in_reply_to":"7bc0c68b_6b784392","updated":"2025-01-28 16:30:55.000000000","message":"Done","commit_id":"d2449a74f2fd7c832a2f62211005c4523153353e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"330f47b72c89e246e26510bffcc5ade9197ad835","unresolved":false,"context_lines":[{"line_number":1222,"context_line":"        command.extend(["},{"line_number":1223,"context_line":"            container_url,"},{"line_number":1224,"context_line":"            \u0027bootc\u0027, \u0027install\u0027, \u0027to-disk\u0027,"},{"line_number":1225,"context_line":"            \u0027--wipe\u0027, \u0027--skip-fetch-check\u0027"},{"line_number":1226,"context_line":"            \u0027--root-size\u003d\u0027 + disk_size + \u0027M\u0027"},{"line_number":1227,"context_line":"        ])"},{"line_number":1228,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"69d4c8c2_d0b38eac","line":1225,"range":{"start_line":1225,"start_character":0,"end_line":1225,"end_character":42},"updated":"2025-01-28 16:30:55.000000000","message":"missing comma:\n\n736cff04854\\nCopying blob sha256:faf4696dadc3b7b1514f826877be0e1724c31e58ba2bc612294152953eed053f\\nCopying config sha256:0e519c415346b8831c8e6143550f7d78898d569ce12506ac417fcffdd09c9d42\\nWriting manifest to image destination\\nerror: unexpected argument \u0027--skip-fetch-check--root-size\u0027 found\\n\\n  tip: a similar argument exists: \u0027--skip-fetch-check\u0027\\n\\nUsage: bootc install to-disk \u003cDEVICE|--wipe|--block-setup \u003cBLOCK_SETUP\u003e|--filesystem \u003cFILESYSTEM\u003e|--root-size \u003cROOT_SIZE\u003e\u003e \u003c--target-transport \u003cTARGET_TRANSPORT\u003e|--target-imgref \u003cTARGET_IMGREF\u003e|--target-no-signature-verification|--enforce-container-sigpolicy|--target-ostree-remote \u003cTARGET_OSTREE_REMOTE\u003e|--skip-fetch-check\u003e\\n\\nFor more information, try \u0027--help\u0027.\\n\"","commit_id":"d2449a74f2fd7c832a2f62211005c4523153353e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cf4be87b7abddf3c4363d6a5fc125ccefa3b16b6","unresolved":true,"context_lines":[{"line_number":1231,"context_line":"            # SELinux enabled on the host system."},{"line_number":1232,"context_line":"            command.append(\u0027--disable-selinux\u0027)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        command.append(device)"},{"line_number":1235,"context_line":"        # Actually execute!"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"        utils.execute(*command, use_standard_locale\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c74fb6cc_11ec367c","line":1234,"updated":"2025-01-25 02:14:49.000000000","message":"More so for ironic:\n\nmid-trim errors\n\n| instance_info          | {\u0027image_source\u0027: \u0027oci://quay.io/podman/machine-os:5.3\u0027, \u0027image_type\u0027: \u0027whole-disk\u0027}                                               |\n| instance_uuid          | None                                                                                                                              |\n| last_error             | Deploy step deploy.execute_bootc_install failed on node dd861997-2600-47d8-bc3b-6d66a7d97324. Unexpected error while running      |\n|                        | command.                                                                                                                          |\n|                        | Command: podman run --rm --privileged --pid\u003dhost -v /var/lib/containers:/var/lib/containers -v /dev:/dev quay.io/podman/machine-  |\n|                        | os:5.3 bootc install to-disk --wipe --skip-fetch-check--root-size\u003d11520M --disable-selinux /dev/vda                               |\n|                        | Exit code: 127                                                                                                                    |\n|                        | Stdout: \u0027\u0027                                                                                                                        |\n|                        | Stderr: \u0027Trying to pull quay.io/podman/machine-os:5.3...\\nGetting image source signatures\\nCopying blob                           |\n|                        | sha256:954441048e95c19932c106f8b48d43d0db493c22fbc0aa0b5eacaa9adbc0bcf3\\nCopying blob                                             |\n|                        | sha256:d8ffa569d32be26d0907fdab72cbed39f4716a91f1b6ac73c17bae51d9032b1b\\nCopying blob                                             |\n|                        | sha256:f913a67b456e38b5aa6553cdc7b716f576c6e2dfe562e74c3bfd3b8283983468\\nCopying blob                                             |\n|                        | sha256:5731b810650f64bb7192a01cf71575dbc07c212d23870be946140378481aa94d\\nCopying blob                                             |\n|                        | sha256:7007dfd40933b78def7fc01830af243d15859ac14ec221a2a586eea32ed48ae6\\nCopying blob                                             |\n|                        | sha256:bf014a529c956c31245f6caf634a951e81c4fadd04ae7dbedd5d113edbbce465\\nCopying blob                                             |\n|                        | sha256:9ebeec840af737bbf8693d2f953118c785bf3ef10eaace5d522f45f32cd77b15\\nCopying blob                                             |\n|                        | sha256:5dfe30a7a1af2f7b1aa7e1c9cf01c3d5fc104b9455f7ad042dec343c160750b1\\nCopying blob                                             |\n|                        | sha256:8694393c34349a7fe9bb44d1d983f8be99c6d593b83bcb0c7166a016374954ed\\nCopying blob                                             |\n|                        | sha256:f644b165278e6ede1757b90b1c37dd149f7a190c2421b837c19d16da97f7b220\\nCopying blob                                             |\n|                        | sha256:0990715af45d4c44fd1bef85d0de6739d51770e4a5dad2b57a5469cda66877f6\\nCopying blob                                             |\n|                        | sha256:9ba87c477e4ba035ea8435a84d256995ff687dc25f1de495cda2ea342b3b88d0\\nCopying blob                                             |\n|                        | sha256:88aa1cc13f5c2c5f2bd364a7b0023ff1b2ead475b26a47d5233431c7f7bbef3f\\nCopying blob                                             |\n|                        | sha256:b50ac6991c0d47f741bd337b6ed98a0907297c6aab7494875f063413d8dcb209\\nCopying blob                                             |\n|                        | sha256:2d433cf19fdad6b29ec3da35b8d9ed5240d2e0ae3d9469505284dd1ee986977d\\nCopying blob                                             |\n|                        | sha256:deb1010004fdcb7309f87ac7e09b227d5e4e798c63d4b3b2cea3f7ab460cf6ec\\nCopying blob                                             |\n|                        | sha256:209103f0af24ae542670af2d23bd99e8fb7913841be1c9d58173cc49f08971da\\nCopying blob                                             |\n|                        | sha256:a4ee2d6c3216896cfb3180f870f39c7eae4dddf7dba2aea51d6bc7db4b4e1d29\\nCopying blob                                             |\n|                        | sha256:5d675d905978ceafc66caa74f0a43c0d6bab44a3151bb45eeccd678c827fe442\\nCopying blob                                             |\n|                        | sha256:543d14348a0d5da7b175346c7d9347f377380f0e06f447d719dfc786eea2ad93\\nCopying blob                                             |\n|                        | sha256:1ac1819d205fa91bfb299641f9e556add1f2aac6b0901ea328abe5387033d0d7\\nCopying blob                                             |\n|                        | sha256:a36085e619f09b35253c4b49e26e7d28c5533de087f3fa4e17c232b0a9456550\\nCopying blob                                             |\n|                        | sha256:d15a03a9b8c6a23fac2d941539a6bf592f3d0fd8b1b387db1d5b35ec682b601f\\nCopying blob                                             |\n|                        | sha256:7e748a958a949728ae5322f1540fc874e70174c90c1edeb2e9fa2fd6b762987c\\nCopying blob                                             |\n|                        | sha256:97b8df5882c794282963efa0a208ec687815714c7bf05b01a393ae78008151a6\\nCopying blob                                             |\n|                        | sha256:5f608babe93d4d434b9e48e6c8c472e68e15d419eb91f47db8165ba7409aa3a3\\nCopying blob                                             |\n|                        | sha256:0fe16263a0575512ac9ff7ac720ec7f02e6ea30567c1e05c120769bbc339f8d1\\nCopying blob                                             |\n|                        | sha256:8f41e030f450e9fde3a1e4b5c5695644f4442c48747f34055c0c575477ce3524\\nCopying blob                                             |\n|                        | sha256:0e572ca5be4e4da959e33ef80461edabbf350f24de7dac21898c359a2380abe9\\nCopying blob                                             |\n|                        | sha256:a178a164014ecff6a7ce806ef3cb27f757a04558d53ae47bbffe2cc5e538b37b\\nCopying blob                                             |\n|                        | sha256:e1074faa767bd571e5c1b8b37127760c45c5ec1cceb3448a8315c2f5ac9ccead\\nCopying blob                                             |\n|                        | sha256:e58e02344f11b2ec537031642fce78755ef620275185198afc70143ed4537110\\nCopying blob                                             |\n|                        | sha256:3349f0a6cbd3c4d16125e1edd039b5def6caac604014ff476780e68795dc6a20\\nCopying blob                                             |\n|                        | sha256:d3b07b978782c93f7623830640cd5103bcf9949a077917a99b2490e070655c31\\nCopying blob                                             |\n|                        | sha256:4069307b39c47575fe1924ee6bc3b9f06b9e1bb634e3df0d2045a92b6f23348b\\nCopying blob                                             |\n|                        | sha256:f56279e569c6fec116069af5bd6cc5cf69a3b68e5003fcc015e7b6e32476c66d\\nCopying blob                                             |\n|                        | sha256:f8f2bbda63b86c889d984828788432afe6983142a36e1e2a819d9add0afc0ffe\\nCopying blob                                             |\n|                        | sha256:20ae4cc8b0d857b930af1311670a803e25aac2d3d02d7a2d70af8fdc849f2c78\\nCopying blob                                             |\n|                        | sha256:3dcab21878b2ac5a1ac752fa223614708f17e812980baa7090c77130c617f660\\nCopying blob                                             |\n|                        | sha256:d29dbec6e68e34f47076f55d17521efd4430808e49c319f543bde32075f1fad1\\nCopying blob                                             |\n|                        | sha256:e10dec73b02d5f805a5931b42fef0cdd371932941605eb4e4447d127042be290\\nCopying blob                                             |\n|                        | sha256:2e64dd804c9b267d460ccfb916cde0ab4a365575a4488eaef7ca88a558b15a65\\nCopyi                                                    |\n| lessee                 | None                                                                                                                              |\n| maintenance            | False                                                                                                                             |\n| maintenance_reason     | None","commit_id":"d2449a74f2fd7c832a2f62211005c4523153353e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d69ec1cb9aa344a87a67a8128fcfddb8485c5026","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"            # SELinux enabled on the host system."},{"line_number":1232,"context_line":"            command.append(\u0027--disable-selinux\u0027)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        command.append(device)"},{"line_number":1235,"context_line":"        # Actually execute!"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"        utils.execute(*command, use_standard_locale\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e0f4f040_2d4fa94e","line":1234,"in_reply_to":"c74fb6cc_11ec367c","updated":"2025-01-28 18:46:02.000000000","message":"We don\u0027t need to actually do that. We actually preserve the important bits in the node history record","commit_id":"d2449a74f2fd7c832a2f62211005c4523153353e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cf4be87b7abddf3c4363d6a5fc125ccefa3b16b6","unresolved":true,"context_lines":[{"line_number":1234,"context_line":"        command.append(device)"},{"line_number":1235,"context_line":"        # Actually execute!"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"        utils.execute(*command, use_standard_locale\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"55acdc95_8bb63d66","line":1237,"updated":"2025-01-25 02:14:49.000000000","message":"we likey need to detect some errors:\n\nnCopying blob sha256:3900fada98efba4591a10a7be6469c72ada82aaeee0670bb2b5b65f97f6aa993\\nCopying blob sha256:a89d7496c9833abff7a5202ce5fc02eeee39b3cb808e10cd5ebb727a556e55c7\\nCopying blob sha256:a270a1ae450648699bc5a6ec3d20ad24d2332d2ff03b6f90d1605fe15f3e3ee3\\nCopying blob sha256:85ff0b8bd1b8e870fca90f526215ebe53bd05c4d2a0dde8a842120e7e374df75\\nCopying config sha256:822cf9da30c03f03493b9247dfaf151eb6cc54a20659b1f37dd3906e804b50bb\\nWriting manifest to image destination\\nError: crun: executable file `bootc` not found in $PATH: No such file or directory: OCI runtime attempted to invoke a command that was not found\\n\u0027\n[  560.197678] ironic-python-agent[571]: 2025-01-24 21:11:54.516 571 ERROR root\n\nExample, not a bootc image!\n\n\nFurther downside, we can end up truncating a long error. We likely need to mid-tirm the errors.","commit_id":"d2449a74f2fd7c832a2f62211005c4523153353e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"909f833c937594d932b2e0733fbe3510adf1d9d6","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"        command.append(device)"},{"line_number":1235,"context_line":"        # Actually execute!"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"        utils.execute(*command, use_standard_locale\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"27103311_63d038d7","line":1237,"in_reply_to":"55acdc95_8bb63d66","updated":"2025-01-28 16:56:34.000000000","message":"Done","commit_id":"d2449a74f2fd7c832a2f62211005c4523153353e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5c2f76256486838316cd49bf6bf9a1df81de1362","unresolved":true,"context_lines":[{"line_number":1166,"context_line":"            self._write_container_auth(pull_secret, url.netloc)"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"        # Get the disk size, and convert it to megabtyes."},{"line_number":1169,"context_line":"        disk_size \u003d disk_utils.get_dev_byte_size(device) / 1024 / 1024"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        # Ensure we leave enough space for a configuration drive,"},{"line_number":1172,"context_line":"        # and ESP partition."}],"source_content_type":"text/x-python","patch_set":2,"id":"e961824a_13651127","line":1169,"range":{"start_line":1169,"start_character":57,"end_line":1169,"end_character":70},"updated":"2025-01-26 19:13:47.000000000","message":"if this is \"// 1024 // 1024\" then you wouldn\u0027t need to convert float to int below","commit_id":"6f8f2f137dda023cef9aa49180072ff143755220"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8d895952b76132974b580aa8cde0bf47dd0b7bca","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"            self._write_container_auth(pull_secret, url.netloc)"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"        # Get the disk size, and convert it to megabtyes."},{"line_number":1169,"context_line":"        disk_size \u003d disk_utils.get_dev_byte_size(device) / 1024 / 1024"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        # Ensure we leave enough space for a configuration drive,"},{"line_number":1172,"context_line":"        # and ESP partition."}],"source_content_type":"text/x-python","patch_set":2,"id":"0f06192f_5ead612d","line":1169,"range":{"start_line":1169,"start_character":57,"end_line":1169,"end_character":70},"in_reply_to":"57a4781c_212a1a4f","updated":"2025-01-28 16:49:57.000000000","message":"Done","commit_id":"6f8f2f137dda023cef9aa49180072ff143755220"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"330f47b72c89e246e26510bffcc5ade9197ad835","unresolved":true,"context_lines":[{"line_number":1166,"context_line":"            self._write_container_auth(pull_secret, url.netloc)"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"        # Get the disk size, and convert it to megabtyes."},{"line_number":1169,"context_line":"        disk_size \u003d disk_utils.get_dev_byte_size(device) / 1024 / 1024"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        # Ensure we leave enough space for a configuration drive,"},{"line_number":1172,"context_line":"        # and ESP partition."}],"source_content_type":"text/x-python","patch_set":2,"id":"57a4781c_212a1a4f","line":1169,"range":{"start_line":1169,"start_character":57,"end_line":1169,"end_character":70},"in_reply_to":"e961824a_13651127","updated":"2025-01-28 16:30:55.000000000","message":"I keep forgetting that is an option!","commit_id":"6f8f2f137dda023cef9aa49180072ff143755220"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"db72ea85f1d354b843d53b6afdee8d18893e2600","unresolved":true,"context_lines":[{"line_number":1113,"context_line":"                raise errors.ClockSyncError(msg)"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"    @base.async_command(\u0027execute_bootc_install\u0027)"},{"line_number":1116,"context_line":"    def execute_bootc_install(self, image_source, instance_info\u003d{},"},{"line_number":1117,"context_line":"                              pull_secret\u003dNone, configdrive\u003dNone):"},{"line_number":1118,"context_line":"        \"\"\"Asynchronously prepares specified image on local OS install device."},{"line_number":1119,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da005a40_72781a9a","line":1116,"updated":"2025-02-06 00:00:44.000000000","message":"It seems strange to me that we still have the standby extension as it\u0027s own thing in a world with deploy steps; I wonder if an alternative way to structure this would be /all bootc code/ inside a hardware manager, advertising the steps it exposes for deploy, and then those steps are used.\n\nObviously this works, but I guess I\u0027ve just lost the thread on why there\u0027s value in having the standby extension do this stuff rather than just using the steps framework + hardware managers to execute it all.","commit_id":"23696ce9efe3d1fb5e9abab0d683dbbdc1d79a3b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5543df525ee3783852a40aad96e45836de8a89ca","unresolved":true,"context_lines":[{"line_number":1113,"context_line":"                raise errors.ClockSyncError(msg)"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"    @base.async_command(\u0027execute_bootc_install\u0027)"},{"line_number":1116,"context_line":"    def execute_bootc_install(self, image_source, instance_info\u003d{},"},{"line_number":1117,"context_line":"                              pull_secret\u003dNone, configdrive\u003dNone):"},{"line_number":1118,"context_line":"        \"\"\"Asynchronously prepares specified image on local OS install device."},{"line_number":1119,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"44b8e70e_ace283f6","line":1116,"in_reply_to":"da005a40_72781a9a","updated":"2025-02-06 16:39:32.000000000","message":"I think it is more convention with the existing code of the code base. \n\nIt can get wired through differently, I just think we need a good example of it and testing together which I don\u0027t think we really have today.","commit_id":"23696ce9efe3d1fb5e9abab0d683dbbdc1d79a3b"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"db72ea85f1d354b843d53b6afdee8d18893e2600","unresolved":true,"context_lines":[{"line_number":2797,"context_line":"                \u0027argsinfo\u0027: inject_files.ARGSINFO,"},{"line_number":2798,"context_line":"            },"},{"line_number":2799,"context_line":"            {"},{"line_number":2800,"context_line":"                \u0027step\u0027: \u0027execute_bootc_install\u0027,"},{"line_number":2801,"context_line":"                # NOTE(TheJulia): Similar to write_image above, this step"},{"line_number":2802,"context_line":"                # has to be called directly by a driver to represent the"},{"line_number":2803,"context_line":"                # flow, hence no priority here and realistically it also"}],"source_content_type":"text/x-python","patch_set":5,"id":"b45d2bf3_6f1c4222","line":2800,"updated":"2025-02-06 00:00:44.000000000","message":"would this ever make sense to run as a service step?","commit_id":"23696ce9efe3d1fb5e9abab0d683dbbdc1d79a3b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5543df525ee3783852a40aad96e45836de8a89ca","unresolved":true,"context_lines":[{"line_number":2797,"context_line":"                \u0027argsinfo\u0027: inject_files.ARGSINFO,"},{"line_number":2798,"context_line":"            },"},{"line_number":2799,"context_line":"            {"},{"line_number":2800,"context_line":"                \u0027step\u0027: \u0027execute_bootc_install\u0027,"},{"line_number":2801,"context_line":"                # NOTE(TheJulia): Similar to write_image above, this step"},{"line_number":2802,"context_line":"                # has to be called directly by a driver to represent the"},{"line_number":2803,"context_line":"                # flow, hence no priority here and realistically it also"}],"source_content_type":"text/x-python","patch_set":5,"id":"df5e7f1e_c51f64a9","line":2800,"in_reply_to":"b45d2bf3_6f1c4222","updated":"2025-02-06 16:39:32.000000000","message":"Possibly?! Might as much also be a totally bad idea.\n\nI think part of the the idea why I put it in the list is because we have write_image.","commit_id":"23696ce9efe3d1fb5e9abab0d683dbbdc1d79a3b"}],"releasenotes/notes/add-support-for-bootc-70b8a4546b176ab4.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"db72ea85f1d354b843d53b6afdee8d18893e2600","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to Ironic-Python-Agent for it to facilitate deployment"},{"line_number":5,"context_line":"    of bootable containers."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a604ca3_18604ebb","line":4,"updated":"2025-02-06 00:00:44.000000000","message":"nit: s/for it//","commit_id":"23696ce9efe3d1fb5e9abab0d683dbbdc1d79a3b"}],"tox.ini":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"330f47b72c89e246e26510bffcc5ade9197ad835","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    HTTPS_PROXY"},{"line_number":25,"context_line":"    no_proxy"},{"line_number":26,"context_line":"    NO_PROXY"},{"line_number":27,"context_line":"basepython \u003d python3.12"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[testenv:codespell]"},{"line_number":30,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"c600c2db_2c8a35e2","line":27,"updated":"2025-01-28 16:30:55.000000000","message":"whoops, I need to remove this change.","commit_id":"d1b48370684378041e4bf650d199111cbbc0a8d8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8d895952b76132974b580aa8cde0bf47dd0b7bca","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    HTTPS_PROXY"},{"line_number":25,"context_line":"    no_proxy"},{"line_number":26,"context_line":"    NO_PROXY"},{"line_number":27,"context_line":"basepython \u003d python3.12"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[testenv:codespell]"},{"line_number":30,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"0253fe44_1cd03611","line":27,"in_reply_to":"c600c2db_2c8a35e2","updated":"2025-01-28 16:49:57.000000000","message":"Done","commit_id":"d1b48370684378041e4bf650d199111cbbc0a8d8"}]}