)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"4c17d0850fadd68f3b617088c15dd8f0348beb42","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     satoshi-sh \u003csatoss1108@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-03-31 21:36:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Implement manual cleaning for ContainerHardwareManager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Implemented manual cleaning"},{"line_number":10,"context_line":"- Refactored the code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f5c6da32_1869cc15","line":7,"updated":"2025-03-31 22:19:48.000000000","message":"this looks done to me?","commit_id":"c02d32fcbd9cb360fcafc08f39466ac5239832c7"},{"author":{"_account_id":37707,"name":"Satoshi Shirosaka","display_name":"Satoshi S.","email":"satoss1108@gmail.com","username":"satoshi-sh"},"change_message_id":"83dd9561726325a482a17301118720d414e6f928","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     satoshi-sh \u003csatoss1108@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-03-31 21:36:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Implement manual cleaning for ContainerHardwareManager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Implemented manual cleaning"},{"line_number":10,"context_line":"- Refactored the code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ae94c5e7_ba0a74c1","line":7,"in_reply_to":"f5c6da32_1869cc15","updated":"2025-03-31 23:40:30.000000000","message":"Done","commit_id":"c02d32fcbd9cb360fcafc08f39466ac5239832c7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8266a678a053313dbfbbe9e55023ee62c00ba6ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1009b81b_6b6099fa","updated":"2025-04-08 17:57:25.000000000","message":"Reviewed with multiple cores as part of PTG review jam.\n\nApproved as part of PTG review jam. Thanks Satoshi!","commit_id":"7e6bc5cb8538e19a443e9db7d8d2517c14f5fbd4"}],"ironic_python_agent/hardware_managers/container.py":[{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"dddd12dcb5a04fc0434d4e3ca70119b0395ee8af","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    def _create_container_step(self):"},{"line_number":65,"context_line":"        return {"},{"line_number":66,"context_line":"            \"step\": \"container_clean_step\","},{"line_number":67,"context_line":"            \"priority\": 0,  # run only manual cleaning"},{"line_number":68,"context_line":"            \"interface\": \"deploy\","},{"line_number":69,"context_line":"            \"reboot_requested\": False,"},{"line_number":70,"context_line":"            \"abortable\": True,"}],"source_content_type":"text/x-python","patch_set":13,"id":"626237eb_ffa50742","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":54},"updated":"2025-04-08 12:56:12.000000000","message":"I don\u0027t think a priority of 0 means to run only manual cleaning, as this comment suggests.\n\nI saw that: `If the step’s priority is zero, the step will not be executed.` https://docs.openstack.org/ironic/latest/admin/node-deployment.html#overriding-default-deploy-steps\n\nAre we intentionally assigning zero here for a special reason?","commit_id":"7e6bc5cb8538e19a443e9db7d8d2517c14f5fbd4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"75b830201c79989ef38233962d358e634257b513","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    def _create_container_step(self):"},{"line_number":65,"context_line":"        return {"},{"line_number":66,"context_line":"            \"step\": \"container_clean_step\","},{"line_number":67,"context_line":"            \"priority\": 0,  # run only manual cleaning"},{"line_number":68,"context_line":"            \"interface\": \"deploy\","},{"line_number":69,"context_line":"            \"reboot_requested\": False,"},{"line_number":70,"context_line":"            \"abortable\": True,"}],"source_content_type":"text/x-python","patch_set":13,"id":"dfbd70ba_7297feb7","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":54},"in_reply_to":"6090314b_fd881268","updated":"2025-04-08 16:51:07.000000000","message":"That doc is ... imprecise and should probably be updated.\n\nAutomated cleaning operates using priorities to order steps.\nManual cleaning (and servicing) operates using explicit lists of steps, and priorites don\u0027t matter in this case.\n\nThis means that in practice, if you want a manual cleaning only step, you assign it priority of 0.","commit_id":"7e6bc5cb8538e19a443e9db7d8d2517c14f5fbd4"},{"author":{"_account_id":37707,"name":"Satoshi Shirosaka","display_name":"Satoshi S.","email":"satoss1108@gmail.com","username":"satoshi-sh"},"change_message_id":"55bf6c422dc9e12514ff6f13efcb17c4f467102a","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    def _create_container_step(self):"},{"line_number":65,"context_line":"        return {"},{"line_number":66,"context_line":"            \"step\": \"container_clean_step\","},{"line_number":67,"context_line":"            \"priority\": 0,  # run only manual cleaning"},{"line_number":68,"context_line":"            \"interface\": \"deploy\","},{"line_number":69,"context_line":"            \"reboot_requested\": False,"},{"line_number":70,"context_line":"            \"abortable\": True,"}],"source_content_type":"text/x-python","patch_set":13,"id":"6090314b_fd881268","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":54},"in_reply_to":"626237eb_ffa50742","updated":"2025-04-08 13:49:39.000000000","message":"I think the line mentions automated cleaning. This is a conversation with Jay on Slack. \n```\nI have a question about priority.  Step with priority 0 doesn\u0027t get included in auto-cleaning, right?\nHow about a priority non-zero step? Does it get included in manual cleaning? I assumed it doesn\u0027t.\n\nJayF\n  11:17 AM\nso manual cleaning is 100% explicit\n11:17\nyou\u0027re saying \"clean this node using these steps in this order\"\n11:17\nautomated cleaning is automatic; where a node is just deleted by a tenant, then we take any clean steps with nonzero priority, order by priority, and run those steps\n11:17\nso a clean step with priority 0 \u003d\u003d available for manual cleaning, won\u0027t run in the automated cleaning\n11:18\n(deploy steps work this way, too; nonzero \u003d\u003d automatically run; zero \u003d\u003d not run)\n```","commit_id":"7e6bc5cb8538e19a443e9db7d8d2517c14f5fbd4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b12006a5e0458d4aecf034c09600e5deda43095c","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    def _create_container_step(self):"},{"line_number":65,"context_line":"        return {"},{"line_number":66,"context_line":"            \"step\": \"container_clean_step\","},{"line_number":67,"context_line":"            \"priority\": 0,  # run only manual cleaning"},{"line_number":68,"context_line":"            \"interface\": \"deploy\","},{"line_number":69,"context_line":"            \"reboot_requested\": False,"},{"line_number":70,"context_line":"            \"abortable\": True,"}],"source_content_type":"text/x-python","patch_set":13,"id":"6c4d08ed_9f6c3388","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":54},"in_reply_to":"dfbd70ba_7297feb7","updated":"2025-04-08 16:52:23.000000000","message":"(reflecting: that doc probably predates manual cleaning entirely)","commit_id":"7e6bc5cb8538e19a443e9db7d8d2517c14f5fbd4"}]}