)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0d7bbcef11f0d96496ba1dc75ab84e621a523910","unresolved":true,"context_lines":[{"line_number":11,"context_line":"This change implements a check for UTF-16 compatibility and tries to decode efibootmgr output as UTF-8 otherwise."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #2072336"},{"line_number":14,"context_line":"Co-Authored-By: Jakub Jelinek \u003cjakub.jelinek@cern.ch\u003e"},{"line_number":15,"context_line":"Change-Id: I35432773826d13edb1dc9dd25f99bb0907a8fa0d"},{"line_number":16,"context_line":"Signed-off-by: Morten Stephansen \u003cmorten.kaastrup.stephansen@cern.ch\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a221ad7_dfeb8182","line":14,"updated":"2025-08-06 22:54:48.000000000","message":"Jakub needs to Signed-off-by this change for it to be OK to land.","commit_id":"7c327002ca2c9d97780c9db1875ba3bc6d08074d"},{"author":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"change_message_id":"91201bf291f5995af832c93886110972015b1ea3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This change implements a check for UTF-16 compatibility and tries to decode efibootmgr output as UTF-8 otherwise."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #2072336"},{"line_number":14,"context_line":"Co-Authored-By: Jakub Jelinek \u003cjakub.jelinek@cern.ch\u003e"},{"line_number":15,"context_line":"Change-Id: I35432773826d13edb1dc9dd25f99bb0907a8fa0d"},{"line_number":16,"context_line":"Signed-off-by: Morten Stephansen \u003cmorten.kaastrup.stephansen@cern.ch\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e2cbfea5_3c89d698","line":14,"in_reply_to":"7a221ad7_dfeb8182","updated":"2025-08-07 08:07:15.000000000","message":"Done","commit_id":"7c327002ca2c9d97780c9db1875ba3bc6d08074d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0d7bbcef11f0d96496ba1dc75ab84e621a523910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f6a6d9dc_c4009fd9","updated":"2025-08-06 22:54:48.000000000","message":"I\u0027m OK with the code; but we need to ensure all contributors have Signed-Off-By on the change to ensure DCO is complied with.","commit_id":"7c327002ca2c9d97780c9db1875ba3bc6d08074d"}],"ironic_python_agent/efi_utils.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"3f333f392dd0e07f8235196cd8a1edc4d27e0fa9","unresolved":true,"context_lines":[{"line_number":288,"context_line":"    cmd_output \u003d efi_output[0].decode(\u0027utf-16\u0027, errors\u003d\u0027ignore\u0027)"},{"line_number":289,"context_line":"    # Check that the output is encoded as UTF-16 otherwise try UTF-8."},{"line_number":290,"context_line":"    utf_16_matched \u003d False"},{"line_number":291,"context_line":"    for line in cmd_output.split(\u0027\\n\u0027):"},{"line_number":292,"context_line":"        if _ENTRY_LABEL.match(line):"},{"line_number":293,"context_line":"            utf_16_matched \u003d True"},{"line_number":294,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ce3bcfe_874ec64d","line":291,"updated":"2025-08-04 13:16:48.000000000","message":"we effectively regexing over whole thing several times on current \u0027default\u0027 behavior, and I honestly not sure what performance penalty could be for regexing over a \u0027random\u0027 garbage...\n\nhow about we add a new check that is not regex-based (fixed string that should always be there) and detect correct decoding based on that?\n\ne.g. `BootCurrent:` or `BootOrder:` seem like good candidates for that, \nso smth like the following:\n\n```\n_DETECT_ENCODING_STRING\u003d\"BootCurrent: \"\ncmd_output \u003d efi_output[0].decode(\u0027utf-16\u0027, errors\u003d\u0027ignore\u0027).split(\u0027\\n\u0027)\nfor line in cmd_output:\n    if line.startswith(_DETECT_ENCODING_STRING):\n        break\nelse:\n    cmd_output \u003d efi_output[0].decode(\u0027utf-8\u0027, errors\u003d\u0027ignore\u0027).split(\u0027\\n\u0027)\nfor line in cmd_output:\n    match \u003d _ENTRY_LABEL.match(line)\n    ...\n```","commit_id":"5939cd62c0f887cadde8ddbcceb9c975c5a13101"},{"author":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"change_message_id":"aab73e77d691598ec4275bd78e4ae4fecd3fadd1","unresolved":false,"context_lines":[{"line_number":288,"context_line":"    cmd_output \u003d efi_output[0].decode(\u0027utf-16\u0027, errors\u003d\u0027ignore\u0027)"},{"line_number":289,"context_line":"    # Check that the output is encoded as UTF-16 otherwise try UTF-8."},{"line_number":290,"context_line":"    utf_16_matched \u003d False"},{"line_number":291,"context_line":"    for line in cmd_output.split(\u0027\\n\u0027):"},{"line_number":292,"context_line":"        if _ENTRY_LABEL.match(line):"},{"line_number":293,"context_line":"            utf_16_matched \u003d True"},{"line_number":294,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":1,"id":"aa7e8053_95954b5d","line":291,"in_reply_to":"9ce3bcfe_874ec64d","updated":"2025-08-04 14:47:53.000000000","message":"Done","commit_id":"5939cd62c0f887cadde8ddbcceb9c975c5a13101"}]}