)]}'
{"id":"openstack%2Fironic-python-agent~959114","triplet_id":"openstack%2Fironic-python-agent~master~I7b6acbd6583831ba82d6a68ce0d8410ee0bd18a2","project":"openstack/ironic-python-agent","branch":"master","attention_set":{},"removed_from_attention_set":{"38243":{"account":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"last_update":"2025-09-02 20:21:52.000000000","reason":"Change was submitted"}},"hashtags":["ironic-week-prio"],"change_id":"I7b6acbd6583831ba82d6a68ce0d8410ee0bd18a2","subject":"Removed redundant side-effects","status":"MERGED","created":"2025-09-02 10:00:29.000000000","updated":"2025-09-08 13:14:24.000000000","submitted":"2025-09-02 20:21:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"959114","meta_rev_id":"ffde6bd80f9b295549144c196292cbbd1f2d85b0","_number":959114,"virtual_id_number":959114,"owner":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-09-02 20:21:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":2,"date":"2025-09-02 16:45:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2025-09-02 18:19:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":1,"date":"2025-09-02 18:19:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-02 10:12:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-09-02 11:56:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-09-02 16:45:01.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2025-09-02 18:19:56.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"}],"messages":[{"id":"ca010327620bcb7f516d2c6c08c0c84ca58a22e3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"date":"2025-09-02 10:00:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"46b7d14a86855c0852c4adce706f00793315322a","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-02 10:12:27.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6e6a6e84c33d436b88de2d5a3b59da8b\n\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/1ec2487ec0a54d5c82627d7037c37163 : SUCCESS in 6m 10s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/3020b1a22efb4add97eb5f26114a71be : SUCCESS in 6m 18s (non-voting)\n- openstack-tox-py313-arm64 https://zuul.opendev.org/t/openstack/build/acc69706bc4342dea4f69795dfa4110a : SUCCESS in 9m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e9ba30c2a7fc2c3d8c0b209c86984eda757ecbe2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-02 11:56:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/034b20f76f444347966301a8f8f0957d\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/dfd2aabccf9346019ab9f64aeb9f2f7e : SUCCESS in 3m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/365e0fce341b40f8b470890e02ca683f : SUCCESS in 2m 47s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/18247166ff744129807ba4547b65bc9e : SUCCESS in 5m 27s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/5042671b4b1e4ca2a77c7214a0c4ca4a : SUCCESS in 5m 15s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/72a0fad8cbd5469e87b42e922250c359 : SUCCESS in 5m 47s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9f206de49d594373a652125031277663 : SUCCESS in 8m 31s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/7ab4e22fea6446c79d547ed2fb592c74 : SUCCESS in 3m 40s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/74b0354c766041168defd7a2695f6484 : SUCCESS in 1h 50m 52s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/2a9baa5234ce4a46844708e5748513cd : SUCCESS in 1h 08m 31s\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/ba2c57f0444c4b6fa8eac737301a4568 : SUCCESS in 5m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f9325b76037c6b6b55462b7b6df47b365829ed31","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2025-09-02 16:45:01.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9f2946dc9cef021b9ea32ba9ab6b675b9f84d1ea","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2025-09-02 16:45:08.000000000","message":"Hashtag added: ironic-week-prio","accounts_in_message":[],"_revision_number":1},{"id":"6f3a434f6f82693d87f7a012cdb1463a7192d17b","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2025-09-02 16:45:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"edac3f3f688e6eb58036593d9e351c451dc45c97","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2025-09-02 18:19:56.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e7e14f898084997e12de0c3409836733536b7126","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-02 18:20:24.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d5e577658ae5b62170163ff007aec6c5d9347a3d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-02 20:21:51.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1e93875980224bce809db96812eba3af\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/52e3e43752eb44ec909bc7cc5b6c5dbf : SUCCESS in 6m 58s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/a1c050d574e74c3f95c8dcb45574ccfa : SUCCESS in 4m 00s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/7a59e99b971243c088a13e6953a7f150 : SUCCESS in 2m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/412bf3a2456243dea9d77e52b329073a : SUCCESS in 6m 09s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/1cbbff8707804b15ab1e8d21d2351960 : SUCCESS in 4m 58s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/171feb0e975f4562946ea9d9a5c8e76e : SUCCESS in 1h 55m 58s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/9ee8ea5628814806bcff5aa741dff158 : SUCCESS in 1h 09m 38s","accounts_in_message":[],"_revision_number":1},{"id":"7bcc9d53d4cc5af597e4e25f3245089f224ce19d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-02 20:21:52.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"8da4492504888031450ab4b7c190a5b2791eed4c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-02 20:23:55.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f3b8eb29f5d3460ebabc350d60422499\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d004fc563ccc4773b74a2a3799c322d2 : SUCCESS in 1m 30s","accounts_in_message":[],"_revision_number":1},{"id":"ffde6bd80f9b295549144c196292cbbd1f2d85b0","author":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"date":"2025-09-08 13:14:24.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"41a00b24657f93686e6311e5999390ab1254a249","revisions":{"41a00b24657f93686e6311e5999390ab1254a249":{"kind":"REWORK","_number":1,"created":"2025-09-02 10:00:29.000000000","uploader":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"ref":"refs/changes/14/959114/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/14/959114/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/959114/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/959114/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/959114/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/959114/1"}}},"commit":{"parents":[{"commit":"0fa82ee2ee3c4e1774b81400d4b6c6904e73b8ae","subject":"Merge \"Fix for motherboards where efibootmgr returns UTF-8.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0fa82ee2ee3c4e1774b81400d4b6c6904e73b8ae"}]}],"author":{"name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","date":"2025-09-02 09:58:44.000000000","tz":0},"committer":{"name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","date":"2025-09-02 10:00:21.000000000","tz":0},"subject":"Removed redundant side-effects","message":"Removed redundant side-effects\n\nIn test_create_configuration_with_different_disks_skip_list there are redundant side-effects which are never used.\n\nChange-Id: I7b6acbd6583831ba82d6a68ce0d8410ee0bd18a2\nSigned-off-by: Morten Stephansen \u003cmorten.kaastrup.stephansen@cern.ch\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/41a00b24657f93686e6311e5999390ab1254a249"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/41a00b24657f93686e6311e5999390ab1254a249"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}