)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6abaca74d634553d24b12f3a54bf22b36c2e83d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5f17aa5_6a5c00a3","updated":"2025-10-02 20:52:04.000000000","message":"I\u0027m slightly concerned if this is too complex for a backport, given it does (subtly) change behavior. Curious what other cores think.","commit_id":"378979b85dbe7e94986527f66a307f6972cc6794"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b47fc160ea5b55c8d21c9ed2f8aac16b280bd423","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b8d93de8_f242bafc","updated":"2025-11-03 19:11:42.000000000","message":"The needful is to merge the fix, even though there are some slight differences, I\u0027m more confident in this having been freshly tested and being fully understood versus prior state.","commit_id":"378979b85dbe7e94986527f66a307f6972cc6794"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f0ac3e3cf911f38ec88f575c79bc7272b65328cd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5028177_ebf774a9","in_reply_to":"a5f17aa5_6a5c00a3","updated":"2025-10-03 17:16:54.000000000","message":"Honestly, its a bit much to backport. -269, +1499...\n\nI\u0027ve already found my eyes glaze over looking at it which is not a good sign.","commit_id":"378979b85dbe7e94986527f66a307f6972cc6794"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"05b850069fa296c9ca16ecf5d03bad5d8fb78ed8","unresolved":true,"context_lines":[{"line_number":1800,"context_line":"                          if \u0027volume_name\u0027 in d}"},{"line_number":1801,"context_line":"        if len(raid_skip_list) \u003d\u003d 0:"},{"line_number":1802,"context_line":"            return None"},{"line_number":1803,"context_line":"        else:"},{"line_number":1804,"context_line":"            return raid_skip_list"},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"    def list_block_devices_check_skip_list(self, node,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f82730c5_796aea6a","line":1803,"updated":"2025-11-04 10:07:51.000000000","message":"nit: you can skip the else here","commit_id":"378979b85dbe7e94986527f66a307f6972cc6794"}],"releasenotes/notes/safeguards_raid_fix-6521157d95aed18f.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6abaca74d634553d24b12f3a54bf22b36c2e83d0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    If a volume_name is present in the skip_block_devices property,"},{"line_number":5,"context_line":"    the function validate_confiuguration will now fail unless"},{"line_number":6,"context_line":"    all logical disks in the target_raid_config have a volume_name"},{"line_number":7,"context_line":"    specified."},{"line_number":8,"context_line":"fixes:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The skip_block_devices property now supports RAIDs, including scenarios"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"998eac5f_68bf6de0","line":7,"updated":"2025-10-02 20:52:04.000000000","message":"Is this too much of a change in behavior for a stable branch?","commit_id":"378979b85dbe7e94986527f66a307f6972cc6794"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f0ac3e3cf911f38ec88f575c79bc7272b65328cd","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    If a volume_name is present in the skip_block_devices property,"},{"line_number":5,"context_line":"    the function validate_confiuguration will now fail unless"},{"line_number":6,"context_line":"    all logical disks in the target_raid_config have a volume_name"},{"line_number":7,"context_line":"    specified."},{"line_number":8,"context_line":"fixes:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The skip_block_devices property now supports RAIDs, including scenarios"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f0c0f3c5_2f915142","line":7,"in_reply_to":"51765b1f_25ee575c","updated":"2025-10-03 17:16:54.000000000","message":"Is there any way to \"fix\" some of the issues without the full body of this change?\n\nIt just feels like a lot. There does appear to be some reformatting, which makes me more hesitant about backporting but maybe it would be okay.","commit_id":"378979b85dbe7e94986527f66a307f6972cc6794"},{"author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"change_message_id":"a7282723aabe4d730741d26945d3e38d85af1cd1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    If a volume_name is present in the skip_block_devices property,"},{"line_number":5,"context_line":"    the function validate_confiuguration will now fail unless"},{"line_number":6,"context_line":"    all logical disks in the target_raid_config have a volume_name"},{"line_number":7,"context_line":"    specified."},{"line_number":8,"context_line":"fixes:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The skip_block_devices property now supports RAIDs, including scenarios"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"51765b1f_25ee575c","line":7,"in_reply_to":"998eac5f_68bf6de0","updated":"2025-10-02 21:01:10.000000000","message":"valid, I think it should be ok though, as the change of behaviour is only applicable to the cases when the skip_block_devices property is used for RAIDs, which is broken without this change","commit_id":"378979b85dbe7e94986527f66a307f6972cc6794"},{"author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"change_message_id":"44756f7fa7c48ce5be5805b56cff44da19a282fc","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    If a volume_name is present in the skip_block_devices property,"},{"line_number":5,"context_line":"    the function validate_confiuguration will now fail unless"},{"line_number":6,"context_line":"    all logical disks in the target_raid_config have a volume_name"},{"line_number":7,"context_line":"    specified."},{"line_number":8,"context_line":"fixes:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The skip_block_devices property now supports RAIDs, including scenarios"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"305a8dc3_808d3337","line":7,"in_reply_to":"f0c0f3c5_2f915142","updated":"2025-10-06 06:53:32.000000000","message":"Technically, yes, we could address points 1-4 in just a couple of hundred lines (i.e., handle a scenario where the root partition is not on the same physical disks as a logical array, which is not supposed to be deleted).\nOr we can change some of the refactors - this can save around 100 lines in hardware.py\nThe change is giant, but two-thirds of the lines added are tests, so it could be doable, but I understand the concerns.","commit_id":"378979b85dbe7e94986527f66a307f6972cc6794"}]}