)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d4179f5a5803af0678b6a9af5f7508c185596c9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5025b87c_adbaecab","updated":"2025-10-01 11:52:58.000000000","message":"This is going to break literally every out-of-tree hardware manager. What about doing the opposite thing and move GenericHardwareManager to ironic_python_agent.hardware_managers instead? People are not supposed to subclass it.","commit_id":"4b6251fbfaefb61f883e503a0d9979b4f488a4d3"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3ce1950feb08805caa2359927597dee9692ca1e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7c0077b5_2879f09b","in_reply_to":"5025b87c_adbaecab","updated":"2025-10-01 19:31:43.000000000","message":"I want to do that, too, as the next step. The end goal would be to have hardware_managers hold all the HardwareManagers (base, generic, all of them) and hardware.py be relegated to hardware utilities. Not sure it\u0027s reasonable to fully get there but the file is too large.\n\nIf we\u0027re concerned about out-of-tree managers, I can import HardwareManager into hardware.py -- we generally haven\u0027t treated it as an API interface with deprecations, but we can do that if needed.","commit_id":"4b6251fbfaefb61f883e503a0d9979b4f488a4d3"}]}