)]}'
{"id":"openstack%2Fironic-python-agent~966032","triplet_id":"openstack%2Fironic-python-agent~stable%2F2025.1~I28129f2ededb37474025f35164d5dc9ece21ec8e","project":"openstack/ironic-python-agent","branch":"stable/2025.1","attention_set":{},"removed_from_attention_set":{"38243":{"account":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"last_update":"2025-11-11 21:18:16.000000000","reason":"Change was submitted"},"35099":{"account":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"last_update":"2025-11-11 21:18:16.000000000","reason":"Change was submitted"}},"hashtags":["ironic-week-prio"],"change_id":"I28129f2ededb37474025f35164d5dc9ece21ec8e","subject":"Fix for matching hints with lists of strings","status":"MERGED","created":"2025-11-04 12:30:35.000000000","updated":"2025-11-11 21:19:15.000000000","submitted":"2025-11-11 21:18:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"966032","meta_rev_id":"d5a00c6f1ac3e92291d613c91101c70948535050","_number":966032,"virtual_id_number":966032,"owner":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-11-11 21:18:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":2,"date":"2025-11-10 17:40:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2025-11-11 19:35:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":1,"date":"2025-11-11 19:35:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"}],"reviewers":{"REVIEWER":[{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-04 12:30:35.000000000","updated_by":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"reviewer":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"state":"REVIEWER"},{"updated":"2025-11-04 12:48:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-11-04 14:00:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-11-10 17:40:59.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2025-11-11 19:35:05.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"}],"messages":[{"id":"7b5f5e3fba2ba29f4e5a017c640031fd918fb1ff","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"date":"2025-11-04 12:30:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7c56995b77a6f0dd5bf6c00ea2f839daaede7aff","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-04 12:48:07.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d87e365c1dda4bacbc651d7261789691\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/24ef36ba381d41008424d59efba829fb : SUCCESS in 6m 21s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/aa5716d5a43a4a4181e9b7e5cdaad48d : SUCCESS in 6m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b6a989b9b0d80a58c7da27fd2ae97c2b92b8137f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-04 14:00:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6de24cde8fa54f1e9bb16343ef54b056\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ef9a4fc801eb479e961051353352571d : SUCCESS in 4m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/29e4a4a3fc9946858d7747605d9eba2e : SUCCESS in 5m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/cd3a7524eab14f29b389ec14e119327b : SUCCESS in 3m 13s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/40cd2c12ab8840e0a35b0f974d144984 : SUCCESS in 5m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/00ae9c4093b045e687e1c004aa79c161 : SUCCESS in 8m 01s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/50e9d151ce9842219cc9bd9adde238f4 : SUCCESS in 2m 59s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/b17264013fae43bdb8de3d354f4c0b5a : SUCCESS in 5m 15s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/d5589bdf8c2d4604a728dc8d516a56e8 : SUCCESS in 2m 37s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/cec166b9b2674eaeae5fe3882876d23b : SUCCESS in 1h 13m 14s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/926245cd581e45c1a80519b22cf56610 : SUCCESS in 1h 17m 35s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/d04fb52ae8be4f7fb264d213307a40c6 : SUCCESS in 49m 12s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/7a178bda43f344fb943b4a7e43b5f1d1 : SUCCESS in 51m 47s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/d1dd22e9417f436dbfa77ecd9187b8b8 : SUCCESS in 18m 05s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/3188390f589b450c8059e7cb9dd2ea5d : SUCCESS in 8m 40s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/b143a4f46f104ebf81f416dae9bd24ca : SUCCESS in 1h 17m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8eb27ef4eb283355282626ef75e93ed475857bdb","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"date":"2025-11-04 14:06:46.000000000","message":"Hashtag added: ironic-week-prio","accounts_in_message":[],"_revision_number":1},{"id":"2f60fa11e0729173c67113f8a7bc8746efa1d124","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2025-11-10 17:40:59.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"160bddc8aa67b2e3d3f9f97ce8e513c6b8aef443","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2025-11-11 19:35:05.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6ac99c2e39f77792badefe5e205c736166de3e31","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-11 19:35:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9205234bf0d2854d6fd3b8249570cec70c30bbe5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-11 21:18:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a394f1d2b2db44db8d5b842aac08cd22\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a3b24d1c5fa144a5894a1b75d6d7d691 : SUCCESS in 4m 29s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/462673b5df334538b33c88bb3dd11f94 : SUCCESS in 3m 51s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/79be33c93859441aa84c91aa631e5303 : SUCCESS in 5m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6e5f952430704d57bd54f210b97ccca3 : SUCCESS in 8m 20s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/67d36a5642de40f69257cfadad452152 : SUCCESS in 3m 10s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/3b79e458d1db47ccb25098f0233ec03a : SUCCESS in 3m 55s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/7abbfee8376e4d8395a3b99cfb924b47 : SUCCESS in 4m 07s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/f75997df57a744cbae0c5ef101f3689e : SUCCESS in 47m 54s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/7a5c6c344bbe46deb65a25a502aa1eba : SUCCESS in 1h 16m 21s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/bb4e6e5c87744aa9aad777d1fee0dda6 : SUCCESS in 1h 38m 11s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/6325457f12024826b07b60cca1ef2223 : SUCCESS in 1h 13m 36s","accounts_in_message":[],"_revision_number":1},{"id":"68c43097b3afaba7e8fe3eeae5e6aec44aa1e8d8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-11 21:18:16.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"d5a00c6f1ac3e92291d613c91101c70948535050","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-11 21:19:15.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/95f9b3ffe85f4992a792b4bbc8738df0\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e30a06f490514508be4981074bd62772 : SUCCESS in 41s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/13f36fa914fb4b2789ba2ef4d8ca9f54 : SUCCESS in 40s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6cb0d9915f5e12724d623f92ebf97b3bc3ae3e3b","revisions":{"6cb0d9915f5e12724d623f92ebf97b3bc3ae3e3b":{"kind":"REWORK","_number":1,"created":"2025-11-04 12:30:35.000000000","uploader":{"_account_id":38243,"name":"Morten Stephansen","display_name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","username":"mostepha"},"ref":"refs/changes/32/966032/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/32/966032/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/966032/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/966032/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/966032/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/966032/1"}}},"commit":{"parents":[{"commit":"1492c7056379667792d529b0b2e07a3cbd60683b","subject":"Fix software RAID creation on different physical devices","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1492c7056379667792d529b0b2e07a3cbd60683b"}]}],"author":{"name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","date":"2025-10-31 13:28:16.000000000","tz":0},"committer":{"name":"Morten Stephansen","email":"morten.kaastrup.stephansen@cern.ch","date":"2025-11-04 12:28:34.000000000","tz":0},"subject":"Fix for matching hints with lists of strings","message":"Fix for matching hints with lists of strings\n\nAdded logic for matching hints with lists of WWN/Serial. These lists\nappear when both lsblk and udev are used to fetch the information about\na device. One consequence of this is that it allows a device on the\nskip list to be used as root device, thus overwriting the protected\ndata. This has previously been handled before matching the hints,\ne.g. the removed section in hardware.py. This patch aims to fix the\nproblem globally by handling the issue inside the find_devices_by_hints\nfunction.\n\nCloses-bug: #2130410\nChange-Id: I28129f2ededb37474025f35164d5dc9ece21ec8e\nSigned-off-by: Morten Stephansen \u003cmorten.kaastrup.stephansen@cern.ch\u003e\nSigned-off-by: Jakub Jelinek \u003cjakub.jelinek@cern.ch\u003e\n(cherry picked from commit bb4b4fdb3887c1fbe0e8536869ac68e9ed1dbe96)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6cb0d9915f5e12724d623f92ebf97b3bc3ae3e3b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6cb0d9915f5e12724d623f92ebf97b3bc3ae3e3b"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
