)]}'
{"id":"openstack%2Fironic-python-agent~997624","triplet_id":"openstack%2Fironic-python-agent~stable%2F2025.1~Ia869cd1c796660cbd7e6656a5a2dd49d89be30b0","project":"openstack/ironic-python-agent","branch":"stable/2025.1","attention_set":{},"removed_from_attention_set":{"11655":{"account":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"last_update":"2026-07-17 10:26:35.000000000","reason":"Change was submitted"}},"hashtags":["ironic-week-prio"],"change_id":"Ia869cd1c796660cbd7e6656a5a2dd49d89be30b0","subject":"Fix: Remove legacy agent_token fallback code","status":"MERGED","created":"2026-07-16 17:07:59.000000000","updated":"2026-07-17 10:28:06.000000000","submitted":"2026-07-17 10:26:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"997624","cherry_pick_of_change":997449,"cherry_pick_of_patch_set":1,"meta_rev_id":"666dca7cf27a4e9c5b36d5b78471d89baacd1fda","_number":997624,"virtual_id_number":997624,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-07-17 10:26:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":2,"date":"2026-07-17 04:26:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2026-07-17 09:23:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":1,"date":"2026-07-17 09:23:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-16 17:07:59.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"CC"},{"updated":"2026-07-16 19:25:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-07-17 04:26:52.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2026-07-17 09:23:47.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"}],"messages":[{"id":"694c6ea11775e0ff0770d66a3f2cf7c9ddcaca58","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2026-07-16 17:07:59.000000000","message":"Patch Set 1: Cherry Picked from branch stable/2025.2.","accounts_in_message":[],"_revision_number":1},{"id":"87021edad4348c94b93df7d824064ef22a48f666","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2026-07-16 17:10:27.000000000","message":"Hashtag added: ironic-week-prio","accounts_in_message":[],"_revision_number":1},{"id":"549180bd93fef011e46b5a81fdc667b5eeb5870f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-16 19:25:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8ccb4ed6eb5e45a89c5e5981a46fc974\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/69d5916ba7ce4740bae4e775ef72f1d2 : SUCCESS in 4m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dba4adc218434046ad5159a601d1c782 : SUCCESS in 4m 45s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/fc085d55e5b6448bbacf4abaf3d06583 : SUCCESS in 4m 59s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/eb5a0ddb12264e7a90a3db138b139106 : SUCCESS in 5m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3a452a6d11b0467cbddca3c07a03367f : SUCCESS in 9m 07s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e9181a6b6f9b4b21ba3b7e63f0212810 : SUCCESS in 5m 48s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/e10d8d8a01b1477da835a95d53284d48 : SUCCESS in 3m 43s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/090655ec1b0646188afd19fec338898e : SUCCESS in 5m 08s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/29a08b4f4dff478e871c92ee0aed52de : SUCCESS in 1h 16m 45s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/71e493a56b094dee979e8dc5888c95e2 : SUCCESS in 1h 26m 24s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/ce40286b79a74dd9b1c3d0d09650917d : SUCCESS in 1h 26m 55s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/499af6615a1b43b582826079fec5175a : SUCCESS in 1h 14m 05s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/aa735d9176a74eda91cdbc0c64a30d38 : SUCCESS in 21m 11s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/89a4f89669c347f09ca1a2d0264cc1c9 : SUCCESS in 10m 07s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/632eb0779f0c49b28b69949a8f4d3b94 : SUCCESS in 2h 10m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b160a4f4617fb9d2e926a478d6586075bc2bdc3a","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2026-07-17 04:26:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3e7a55b4c0d099218a6433d39c8b94c2aaf664d9","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2026-07-17 09:23:47.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"584cc177a550eab772ae1a6b96391140450e1606","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-17 09:24:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"101c3aeb58b6446caad215a6b7c197ccc320b8ce","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-17 10:26:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bfe1ce4a2f1a443c8ade6fe391e316ac\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9b9da983ca6c43bb8d0f7b91217426e2 : SUCCESS in 6m 48s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3e889ca6c0514aa9a97239c1dcf0236c : SUCCESS in 4m 19s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/b52ab551c215435089dfaaee75114846 : SUCCESS in 4m 21s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b4990b4ca1b449ecbf9f77f011d79d85 : SUCCESS in 10m 17s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/eb91c5e57f3d40718ea8162cc3d6c58b : SUCCESS in 5m 09s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/4a584b921471425a90b21e271afa7d06 : SUCCESS in 3m 27s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/33ada83186c3411f87b53c5ffb229067 : SUCCESS in 3m 24s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/64db5415c448400a89f5704d4b5e276a : SUCCESS in 1h 00m 40s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/e966ce7788cb4f38b5cdb8789fb16054 : SUCCESS in 43m 42s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/0290284c8e8344c7995ed3653adaa86e : SUCCESS in 46m 04s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/3363d3304781406a9272c3a4a72f74d6 : SUCCESS in 41m 52s","accounts_in_message":[],"_revision_number":1},{"id":"3a482f700c4f0bc8de6388740e921cd586400ee2","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-17 10:26:35.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"666dca7cf27a4e9c5b36d5b78471d89baacd1fda","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-17 10:28:06.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/020cbd07cf3a4ea3bc6de0186af740f1\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0217bc30047d4540982412ff9e511098 : SUCCESS in 56s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9f38696985384a03af6c5cda796bbf00 : SUCCESS in 1m 02s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"03bdd46dd009320990d60e533b2c2209b4098055","revisions":{"03bdd46dd009320990d60e533b2c2209b4098055":{"kind":"REWORK","_number":1,"created":"2026-07-16 17:07:59.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/24/997624/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/24/997624/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/997624/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/997624/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/997624/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/997624/1"}}},"commit":{"parents":[{"commit":"b0df13dc6e5b8c26e619619ce1c2f486bec2b169","subject":"Add a flag to disable installing bootloaders","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b0df13dc6e5b8c26e619619ce1c2f486bec2b169"}]}],"author":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2026-07-14 22:48:26.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2026-07-16 17:07:59.000000000","tz":0},"subject":"Fix: Remove legacy agent_token fallback code","message":"Fix: Remove legacy agent_token fallback code\n\nRemoves the very old fallback code which would allow a\nclient to GET /v1/commands unauthenticated very early\nin an IPA run.\n\nThis cleans up the checks entirely, making the code\nsuitable for a world that always has an agent token.\n\nAssisted-by: Claude Code (Sonnet)\nCloses-Bug: #2160196\nChange-Id: Ia869cd1c796660cbd7e6656a5a2dd49d89be30b0\nSigned-off-by: Jay Faulkner \u003cjay@jvf.cc\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/03bdd46dd009320990d60e533b2c2209b4098055"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/03bdd46dd009320990d60e533b2c2209b4098055"}]},"branch":"refs/heads/stable/2025.1","conflicts":{"base":"f1d8d584ba488cb09391b98e00209c4887ea3298","ours":"b0df13dc6e5b8c26e619619ce1c2f486bec2b169","theirs":"ad668af0f1189ae6305f3b8d926c679a4d4c16a5","merge_strategy":"recursive","contains_conflicts":false}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
