)]}'
{"id":"openstack%2Fironic-python-agent~998491","triplet_id":"openstack%2Fironic-python-agent~unmaintained%2F2024.1~I69e85a1c5040066674d90a6e12acc30cec96ba76","project":"openstack/ironic-python-agent","branch":"unmaintained/2024.1","topic":"security-2160050-2024.1","attention_set":{},"removed_from_attention_set":{"11655":{"account":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"last_update":"2026-07-23 17:40:07.000000000","reason":"\u003cGERRIT_ACCOUNT_11655\u003e replied on the change","reason_account":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}}},"hashtags":["CVE-2026-66138"],"change_id":"I69e85a1c5040066674d90a6e12acc30cec96ba76","subject":"security: fix NTP command handling","status":"NEW","created":"2026-07-23 14:08:50.000000000","updated":"2026-07-24 04:33:24.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c59bb18aa2d214bf797823cd3cc30dd1bfcaf142","_number":998491,"virtual_id_number":998491,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2026-07-23 15:52:12.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"date":"2026-07-23 17:53:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-23 15:52:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9189f6a4073c493d52e5815628b5d950079ad288","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2026-07-23 14:08:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f3e62e25453b69663c0557259f86dd66401e1d23","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-23 15:52:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/10316bc3ada544b69e052091dee71750\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c64b2d02fa7544c0a3ebf91ab8d2b0ce : SUCCESS in 3m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cdf1b289d5b645aab14917eb8a8a5b97 : SUCCESS in 3m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f9e996cf86c049659d10bbecc53a9ff1 : SUCCESS in 4m 10s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/8c0b914871924845bff2de44e2d945a2 : SUCCESS in 4m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fe5e707d2e3b4cf6ab886f37c7a95300 : SUCCESS in 5m 45s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ec30e5b6cf5a4be6b49ff4bbe0acc57b : SUCCESS in 5m 52s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/79aa5125e5fb4b29bfcb9245b94abcac : SUCCESS in 4m 18s\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/4c1b3988c09b4b4fbc8017698c1091c9 : SUCCESS in 4m 00s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/acb61dd52eb5494b881777fcc04ba201 : FAILURE in 19m 57s\n- ipa-tempest-uefi-redfish-vmedia-src https://zuul.opendev.org/t/openstack/build/fc069c6159ae41c4a4bbb46b0abd08d0 : SUCCESS in 1h 16m 54s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/9f6cfaf7da204457a67722f9519c7cb3 : SUCCESS in 58m 11s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/acfd4c2b87ba41fe9749a8d41c18c7a1 : SUCCESS in 1h 37m 16s (non-voting)\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/357deaab20e340758c949fd772d1bf22 : FAILURE in 20m 02s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/d7cf5cf7ae8842d1852bdd962a4db094 : SUCCESS in 21m 29s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/2876453ef7464749851598089be8e41b : SUCCESS in 10m 23s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/41dc6908b8d24da5a512eaf2b117dc32 : FAILURE in 19m 47s (non-voting)\n- ipa-tox-codespell https://zuul.opendev.org/t/openstack/build/aeda2572dead4db4b622b17368457e5e : FAILURE in 2m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"49084a294eec948f631c6a6d27063cb008369b90","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2026-07-23 17:40:07.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e33046330ef1d4c01652af1972236bce78d1aad7","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2026-07-23 17:53:10.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"c59bb18aa2d214bf797823cd3cc30dd1bfcaf142","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2026-07-24 04:33:24.000000000","message":"Hashtag added: CVE-2026-66138","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"176cec5720de5b351b0d5817efd018fa70f234c0","revisions":{"176cec5720de5b351b0d5817efd018fa70f234c0":{"kind":"REWORK","_number":1,"created":"2026-07-23 14:08:50.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/91/998491/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/91/998491/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/998491/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/998491/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/998491/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/91/998491/1"}}},"commit":{"parents":[{"commit":"1f12cbb5837f9f90cafcf0d4b1d294abed35a036","subject":"Add a flag to disable installing bootloaders","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1f12cbb5837f9f90cafcf0d4b1d294abed35a036"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2026-07-14 20:13:49.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2026-07-23 04:02:01.000000000","tz":-420},"subject":"security: fix NTP command handling","message":"security: fix NTP command handling\n\nAdds basic validation of the NTP server parameter to harden the\nusage of the NTP server time setting *AND* also uses shlex.quote\nto and removes shell\u003dtrue from the execution invocation to prevent\nany possibliity of injecting a malicious command to be executed.\n\nNOTE(JayF): Rebase to unmaintained/2024.1 no conflicts, but had to add\n            imports.\n\nRelated-Bug: 2160050\nAssisted-By: Claude Opus 4.6\nChange-Id: I69e85a1c5040066674d90a6e12acc30cec96ba76\nSigned-off-by: Julia Kreger \u003cjuliaashleykreger@gmail.com\u003e\nSigned-off-by: Jay Faulkner \u003cjay@jvf.cc\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/176cec5720de5b351b0d5817efd018fa70f234c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/176cec5720de5b351b0d5817efd018fa70f234c0"}]},"branch":"refs/heads/unmaintained/2024.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}