)]}'
{"id":"openstack%2Fironic-python-agent~998492","triplet_id":"openstack%2Fironic-python-agent~unmaintained%2F2023.1~I69e85a1c5040066674d90a6e12acc30cec96ba76","project":"openstack/ironic-python-agent","branch":"unmaintained/2023.1","topic":"security-2160050-2023.1","attention_set":{},"removed_from_attention_set":{"11655":{"account":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"last_update":"2026-07-24 15:09:17.000000000","reason":"Change was submitted"}},"hashtags":["CVE-2026-66138"],"change_id":"I69e85a1c5040066674d90a6e12acc30cec96ba76","subject":"security: fix NTP command handling","status":"MERGED","created":"2026-07-23 14:08:59.000000000","updated":"2026-07-24 15:11:06.000000000","submitted":"2026-07-24 15:09:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"998492-security-2160050-2023.1","meta_rev_id":"98a2b1d58a58c9227677864280fae6f98be559c0","_number":998492,"virtual_id_number":998492,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-07-24 15:09:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"all":[{"value":2,"date":"2026-07-24 13:42:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2026-07-23 14:33:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},{"value":2,"date":"2026-07-24 01:23:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"all":[{"value":1,"date":"2026-07-24 13:42:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-23 14:33:21.000000000","updated_by":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"reviewer":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"state":"REVIEWER"},{"updated":"2026-07-23 15:20:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-07-24 01:23:44.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"},{"updated":"2026-07-24 13:42:48.000000000","updated_by":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"reviewer":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"state":"REVIEWER"}],"messages":[{"id":"8dcb8248a9dc72d4ccc7bf8ea55f416a9127197e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2026-07-23 14:08:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fe76aea9d56ba9d7038bcaae3a377de1b1945815","author":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"date":"2026-07-23 14:33:21.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"09abb98b2f8726d9aff650f5414d233717d00835","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-23 15:20:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/01f76307b581424cbaa0305bcca44178\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8023fee936394f65b964999cb51132d5 : SUCCESS in 3m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5664b7363a014875bd9b807ce5db0c6d : SUCCESS in 3m 19s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/61e5b184e0bf4491ae71b004928afb61 : SUCCESS in 3m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6ca6c41faff541c9a152e61f65c828b9 : SUCCESS in 6m 20s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/35342e6db47f4221bc02339c53513822 : SUCCESS in 5m 25s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/92ee977e15db40648d421dd7bdfff570 : SUCCESS in 4m 04s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/5cf6ad91ee5340c98a7433369e12a0c4 : SUCCESS in 1h 02m 45s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/983e59d26b65454790bb85f3101f878a : SUCCESS in 23m 42s (non-voting)\n- ipa-tox-bandit https://zuul.opendev.org/t/openstack/build/c065445c3c8340fb9706ddb64a31d059 : FAILURE in 3m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"292b7d83b747eb4d9b8f4e64dcf4c2688dafd533","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2026-07-24 01:23:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"13a1abc74993dca8d27f7085d8878683d5b6db47","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2026-07-24 04:33:24.000000000","message":"Hashtag added: CVE-2026-66138","accounts_in_message":[],"_revision_number":1},{"id":"3a558219e6413cdbba781da7c91932583c65fb66","author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"date":"2026-07-24 13:42:48.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"98ab11fba2016bc227427e95e3ee7ea8cf8c28f0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-24 13:43:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8d553f035b1eb7e57429bd73fbf29f36496c3c09","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-24 15:09:17.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0ef05160e2874c269aa1bd0588b4e160\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5de8c3017a9c44a287647064e5ba4673 : SUCCESS in 3m 44s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/91f37e10facf4ad282ecf2e26f5b5e75 : SUCCESS in 4m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2e64fb2e8140473e94564f7a9bc4d30e : SUCCESS in 5m 48s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f1d6d222ea6049f0a0c00e73b0d569b9 : SUCCESS in 6m 13s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/2f114378062c439d8279927538d9d490 : SUCCESS in 4m 29s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/2ea126300c0e4bb8a4086b7f6a7f0b1f : SUCCESS in 1h 20m 50s","accounts_in_message":[],"_revision_number":1},{"id":"582d8140a211f2ce1e579e4d4e61d42c4031f97c","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-24 15:09:17.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"98a2b1d58a58c9227677864280fae6f98be559c0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-24 15:11:06.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/369a8f5c00ad441493cc32b056b26862\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/64df70ecb4114460acf1cba2424e8a91 : SUCCESS in 1m 15s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3be703b920114569a69acf5b50fe9632 : SUCCESS in 1m 01s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f704efe3af46c02595b5fd4221a2647b584996cd","revisions":{"f704efe3af46c02595b5fd4221a2647b584996cd":{"kind":"REWORK","_number":1,"created":"2026-07-23 14:08:59.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/92/998492/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/92/998492/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/92/998492/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/92/998492/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/92/998492/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/92/998492/1"}}},"commit":{"parents":[{"commit":"2322b3c0ee6645ec900c9a9505cc0a1ddcbcfcdb","subject":"Add a flag to disable installing bootloaders","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2322b3c0ee6645ec900c9a9505cc0a1ddcbcfcdb"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2026-07-14 20:13:49.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2026-07-23 04:02:30.000000000","tz":-420},"subject":"security: fix NTP command handling","message":"security: fix NTP command handling\n\nAdds basic validation of the NTP server parameter to harden the\nusage of the NTP server time setting *AND* also uses shlex.quote\nto and removes shell\u003dtrue from the execution invocation to prevent\nany possibliity of injecting a malicious command to be executed.\n\nNOTE(JayF): Rebase to unmaintained/2024.1 no conflicts, but had to add\n            imports.\n\nRelated-Bug: 2160050\nAssisted-By: Claude Opus 4.6\nChange-Id: I69e85a1c5040066674d90a6e12acc30cec96ba76\nSigned-off-by: Julia Kreger \u003cjuliaashleykreger@gmail.com\u003e\nSigned-off-by: Jay Faulkner \u003cjay@jvf.cc\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f704efe3af46c02595b5fd4221a2647b584996cd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f704efe3af46c02595b5fd4221a2647b584996cd"}]},"branch":"refs/heads/unmaintained/2023.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
