)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"c43b31f06cc2b8aa843ccdaac938700b41319e07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f943a99d_d1db3ea5","updated":"2026-10-29 18:26:34.000000000","message":"Reviewed this spec.  It looks good, just one minor comment.","commit_id":"984676c71dd8bd651c7d20e975352d739beaf6ed"}],"specs/approved/console-snapshot-and-recording.rst":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"95fd2d7e6fda5f429fc7a3063035a14a929d4a37","unresolved":true,"context_lines":[{"line_number":240,"context_line":"resulting URL is handled as a separate code path: the conductor is notified and"},{"line_number":241,"context_line":"takes a brief node lock only to write the URL into node history. ``ironic-api``"},{"line_number":242,"context_line":"and ``ironic-conductor`` remain independently upgradable; the API only issues"},{"line_number":243,"context_line":"the new request when the negotiated microversion is in use."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Driver API impact"},{"line_number":246,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d188216a_c2c047b9","line":243,"updated":"2026-10-20 00:56:18.000000000","message":"Currently the ironic-novncproxy doesn\u0027t interact with rpc at all (other than through the optional indirection database API). This could increase the scope of this change a bit, and impact ironic installation tools which may have to propagate rpc config to ironic-novncproxy","commit_id":"cfbb83a16914c5f93c0b84f7e20e35ae1dbabd00"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"052caa7d4153c0cbefb9bdaf2192522aaebde94c","unresolved":true,"context_lines":[{"line_number":240,"context_line":"resulting URL is handled as a separate code path: the conductor is notified and"},{"line_number":241,"context_line":"takes a brief node lock only to write the URL into node history. ``ironic-api``"},{"line_number":242,"context_line":"and ``ironic-conductor`` remain independently upgradable; the API only issues"},{"line_number":243,"context_line":"the new request when the negotiated microversion is in use."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Driver API impact"},{"line_number":246,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a355aed8_86be35a9","line":243,"in_reply_to":"83258a03_103f4c5d","updated":"2026-10-22 16:54:39.000000000","message":"Issue is, it either has to be wired in or db config has to be wired in. So... we semi-expect ironic.conf to be shared here anyway. Updated version will be explicit on the callout.","commit_id":"cfbb83a16914c5f93c0b84f7e20e35ae1dbabd00"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"91d08e96f6e609d27c257a99651b3614f677448d","unresolved":true,"context_lines":[{"line_number":240,"context_line":"resulting URL is handled as a separate code path: the conductor is notified and"},{"line_number":241,"context_line":"takes a brief node lock only to write the URL into node history. ``ironic-api``"},{"line_number":242,"context_line":"and ``ironic-conductor`` remain independently upgradable; the API only issues"},{"line_number":243,"context_line":"the new request when the negotiated microversion is in use."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Driver API impact"},{"line_number":246,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"83258a03_103f4c5d","line":243,"in_reply_to":"d188216a_c2c047b9","updated":"2026-10-22 15:11:05.000000000","message":"I guess I was thinking we had wired it in. :(","commit_id":"cfbb83a16914c5f93c0b84f7e20e35ae1dbabd00"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"c43b31f06cc2b8aa843ccdaac938700b41319e07","unresolved":true,"context_lines":[{"line_number":66,"context_line":"screenshot or a short, bounded video recording. The capture is performed by"},{"line_number":67,"context_line":"``ironic-novncproxy`` -- which already terminates the node\u0027s VNC connection --"},{"line_number":68,"context_line":"uploaded to object storage, and the resulting temporary URL is written to the"},{"line_number":69,"context_line":"node\u0027s history. The operator reads the most recent URL from node history (or"},{"line_number":70,"context_line":"from the response to an on-demand request) and downloads directly from the"},{"line_number":71,"context_line":"object store."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"aef345c3_bb65746f","line":69,"range":{"start_line":69,"start_character":29,"end_line":69,"end_character":55},"updated":"2026-10-29 18:26:34.000000000","message":"why just the most recent URL?  What if they need more?","commit_id":"984676c71dd8bd651c7d20e975352d739beaf6ed"}]}