)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send sensor data to Ceilometer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Spec for sensor data collection and sending them to Ceilometer"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I307282eb5add3b1f5ed08e8b26b7d89a323533bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_d104301a","line":9,"updated":"2014-06-25 11:38:01.000000000","message":"Should duplicate the first paragraph from the text","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send sensor data to Ceilometer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Spec for sensor data collection and sending them to Ceilometer"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I307282eb5add3b1f5ed08e8b26b7d89a323533bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_e0d20e33","line":9,"updated":"2014-06-26 09:26:10.000000000","message":"Please use the first paragraph here instead","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5fc6a04492c47cd5ce77c2838becf48b8be1b494","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send sensor data to Ceilometer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Send sensor data to Ceilometer"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I307282eb5add3b1f5ed08e8b26b7d89a323533bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_310d2690","line":9,"updated":"2014-06-26 10:36:16.000000000","message":"Sorry, I was not clear again. Here should be:\n\n This blueprint will define the sensor data collection interface and implement \n a driver based on IPMI to collect sensor data and send them to Ceilometer.","commit_id":"b131ee59dbddb5473246ad169808a011ec537104"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"4e13788c8bc6d9359dfcee6469c4b00a0951a614","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send sensor data to Ceilometer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Send sensor data to Ceilometer"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I307282eb5add3b1f5ed08e8b26b7d89a323533bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_2c422d0f","line":9,"in_reply_to":"1ae5cdf2_310d2690","updated":"2014-06-26 10:53:33.000000000","message":"Yes, it is me that miss understand you.","commit_id":"b131ee59dbddb5473246ad169808a011ec537104"}],"specs/juno/send-data-to-ceilometer.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Ceilometer needs the hardware level performance/status data collection from"},{"line_number":21,"context_line":"monitor physical nodes, our Ironic owns the IPMI credential, so that is easy"},{"line_number":22,"context_line":"for our Ironic to get IPMI sensor data and sent to Ceilometer via notification"},{"line_number":23,"context_line":"bus."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_ec16b348","line":21,"updated":"2014-06-25 11:38:01.000000000","message":"probably this should spell \"monitored physical nodes. Ironic owns...\"","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Ceilometer needs the hardware level performance/status data collection from"},{"line_number":21,"context_line":"monitor physical nodes, our Ironic owns the IPMI credential, so that is easy"},{"line_number":22,"context_line":"for our Ironic to get IPMI sensor data and sent to Ceilometer via notification"},{"line_number":23,"context_line":"bus."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_2c289b84","line":22,"updated":"2014-06-25 11:38:01.000000000","message":"s/sent/send/","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Ceilometer needs the hardware level performance/status data collection from"},{"line_number":21,"context_line":"monitor physical nodes, our Ironic owns the IPMI credential, so that is easy"},{"line_number":22,"context_line":"for our Ironic to get IPMI sensor data and sent to Ceilometer via notification"},{"line_number":23,"context_line":"bus."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_2c4fbb6b","line":23,"updated":"2014-06-25 11:38:01.000000000","message":"Which notification bus? AMQP? Please be a bit more specific.","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"1. Creates a new ironic.driver.base.ManagementInterface methods for gathering"},{"line_number":30,"context_line":"hardware sensor data:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"   def get_sensors_data(self, task):"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_6c70e3a4","line":29,"updated":"2014-06-25 11:38:01.000000000","message":"s/methods/method/ (or do you expect more?)","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":36,"context_line":"       \u0027Sensor Type\u0027 -\u003e \u0027Sensor ID\u0027 -\u003e \u0027Field\u0027:\u0027Value\u0027"},{"line_number":37,"context_line":"       \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Example of actual message: http://paste.openstack.org/show/68808/"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_2c76dba3","line":39,"updated":"2014-06-25 11:38:01.000000000","message":"Please consider copying example message here. E.g. currently this link gives error 500.","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"1f1d05783f2b5733297d54e9eeff719f7ddb1554","unresolved":false,"context_lines":[{"line_number":36,"context_line":"       \u0027Sensor Type\u0027 -\u003e \u0027Sensor ID\u0027 -\u003e \u0027Field\u0027:\u0027Value\u0027"},{"line_number":37,"context_line":"       \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Example of actual message: http://paste.openstack.org/show/68808/"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_7eece0f4","line":39,"in_reply_to":"1ae5cdf2_2c76dba3","updated":"2014-06-26 08:34:19.000000000","message":"The example message is very long text, so can not past here.","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \u0027-v\u0027 option, we can get the entire sensor data including the extended"},{"line_number":48,"context_line":"    sensor informations, that is all sensor data in details including the"},{"line_number":49,"context_line":"    sensor current value(field name is \u0027Sensor Reading\u0027), here is an example"},{"line_number":50,"context_line":"    which is the command return result:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    http://paste.openstack.org/show/63267/"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_0c811f4d","line":50,"updated":"2014-06-25 11:38:01.000000000","message":"Please split this paragraph into several sentences for the sake of readability.","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    So we can translate the result to a dict format which is group by \u0027Sensor"},{"line_number":55,"context_line":"    Type\u0027, for different type, we have different field names, by default, the"},{"line_number":56,"context_line":"    IPMI node can support the basic three types: \u0027Fan\u0027, \u0027Temperature\u0027, and"},{"line_number":57,"context_line":"    \u0027Voltage\u0027."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"3. Adds periodic task to conductor which emits notification to Ceilometer by an"},{"line_number":60,"context_line":"   interval."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_2c841b5c","line":57,"updated":"2014-06-25 11:38:01.000000000","message":"ditto here","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0027Voltage\u0027."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"3. Adds periodic task to conductor which emits notification to Ceilometer by an"},{"line_number":60,"context_line":"   interval."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_0ccf5fb4","line":60,"updated":"2014-06-25 11:38:01.000000000","message":"1. How will it be implemented? Will conductor poll all drivers for all nodes assigned to this conductor? Poll only ipmitool driver? What if ipmitool is disabled and ipminative enabled? All this should be clarified.\n\n2. What is the medium for sending data? AMQP? Which channel, what format? Please be specific or provide a link explaining this.\n\n3. There probably will be some configurations options (at least how often data will be sent). They should be stated somewhere in the spec.","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"An alternative way to do it is that we can enable our \u0027ipminative\u0027 driver to"},{"line_number":68,"context_line":"support IPMI data collection, using python api to access IPMI node, call \u0027sdr\u0027"},{"line_number":69,"context_line":"subcommand via IPMI python API to get the sensor data."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_cc53b7e0","line":69,"updated":"2014-06-25 11:38:01.000000000","message":"I think, we have to implement both (and probably there will be more options). If users have ipminative enabled (and ipmitool disabled) there\u0027s no reason for us not give them stats.","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"1f1d05783f2b5733297d54e9eeff719f7ddb1554","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"An alternative way to do it is that we can enable our \u0027ipminative\u0027 driver to"},{"line_number":68,"context_line":"support IPMI data collection, using python api to access IPMI node, call \u0027sdr\u0027"},{"line_number":69,"context_line":"subcommand via IPMI python API to get the sensor data."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_7915dae4","line":69,"in_reply_to":"1ae5cdf2_cc53b7e0","updated":"2014-06-26 08:34:19.000000000","message":"@Dmitry, agree with you.\n\nAn alternative way to do it is that we can enable our \u0027ipminative\u0027 driver to\nsupport IPMI sensor data collection, using *pyghmi* lib *get_sensor_data* \ncommand method call to access IPMI node.\n\nHowever this *get_sensor_data* is one new command introduced recently in \nlatest release still not stable now, I did some testing with physical server, \nit still does not work, some IPMI sensor raw data can not be parsed by \n*get_sensor_data* command.\n\nSo we will support \u0027ipminative\u0027 driver later.","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":97,"context_line":"---------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"We emit notification to Ceilometer via AMQP, AMQP-mediated interactions are"},{"line_number":100,"context_line":"assumed to be secure, else we have to call Ceilometer APIs which are"},{"line_number":101,"context_line":"authenticated."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_4c57a7ca","line":100,"updated":"2014-06-25 11:38:01.000000000","message":"this \"else\" clause should be discussed in \"alternatives\", not here","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":125,"context_line":"----------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"To be working on the Ceilometer code to consume the Ironic notifications will"},{"line_number":128,"context_line":"be Chris Dent (LP ID \u003d\u003d cdent)."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_ec65d3af","line":128,"updated":"2014-06-25 11:38:01.000000000","message":"This should be in \"other contributors\" (and it\u0027s there already), why is it here?","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"The data notification structure defined by Ironic should be confirmed with"},{"line_number":157,"context_line":"Ceilometer team to consume the notifications as well."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_0cb91fec","line":157,"updated":"2014-06-25 11:38:01.000000000","message":"Is it a prerequisite for this spec? If yes, we should have the results (probably after Paris meet-up). Otherwise we should state structure ourselves and leave a comment, that we\u0027ll fix the structure on demand.","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Testing"},{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"None"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_ec987377","line":163,"updated":"2014-06-25 11:38:01.000000000","message":"I hope we\u0027ll have at least unit tests for it :)","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1084bf7c6a221cea48be943ca4d62c4446ef3d20","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Documentation Impact"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"None"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_6c9b8366","line":169,"updated":"2014-06-25 11:38:01.000000000","message":"Documentation should be extended to explain how it works. For example if users do not use ipmi* drivers, they may want to enable and configure them in order to get stats reported.","commit_id":"0b27205f5b86fb1385d78840f67fb0a9d3400ae2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Ceilometer needs the hardware level performance/status data collection from"},{"line_number":21,"context_line":"monitored physical nodes. Ironic owns the IPMI credential, so that is easy for"},{"line_number":22,"context_line":"our Ironic to get IPMI sensor data and send to Ceilometer via our OpenStack"},{"line_number":23,"context_line":"common AMQP notification bus."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_e0c68e15","line":22,"updated":"2014-06-26 09:26:10.000000000","message":"s/our//g","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  def get_sensors_data(self, task):"},{"line_number":33,"context_line":"      \"\"\" Get the sensors data from IPMI node"},{"line_number":34,"context_line":"      The method get_sensors_data() will return a dict which is the common"},{"line_number":35,"context_line":"      data structure as below:"},{"line_number":36,"context_line":"      \u0027Sensor Type\u0027 -\u003e \u0027Sensor ID\u0027 -\u003e \u0027Field\u0027:\u0027Value\u0027"},{"line_number":37,"context_line":"      \"\"\""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_40a02242","line":34,"updated":"2014-06-26 09:26:10.000000000","message":"\"The method get_sensors_data()\" seems redundant, maybe just \"This method\"? Also it\u0027s better to use standard :returns: tag in docstring.","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      \u0027Sensor Type\u0027 -\u003e \u0027Sensor ID\u0027 -\u003e \u0027Field\u0027:\u0027Value\u0027"},{"line_number":37,"context_line":"      \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  Example of actual message: http://paste.openstack.org/show/68808/"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_c0bc32b8","line":39,"updated":"2014-06-26 09:26:10.000000000","message":"I\u0027m still receiving error 500 here. Can you access the link?","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"656fcddb4cc807d8c925493a77ba12c67ed588bd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      \u0027Sensor Type\u0027 -\u003e \u0027Sensor ID\u0027 -\u003e \u0027Field\u0027:\u0027Value\u0027"},{"line_number":37,"context_line":"      \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  Example of actual message: http://paste.openstack.org/show/68808/"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_11acaa87","line":39,"in_reply_to":"1ae5cdf2_a372d00f","updated":"2014-06-26 10:36:28.000000000","message":"Yeah, works for me, paste must be a bit unstable","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c28eb50ef0c0781a334634783b7955df7bcbf03b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      \u0027Sensor Type\u0027 -\u003e \u0027Sensor ID\u0027 -\u003e \u0027Field\u0027:\u0027Value\u0027"},{"line_number":37,"context_line":"      \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  Example of actual message: http://paste.openstack.org/show/68808/"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_a372d00f","line":39,"in_reply_to":"1ae5cdf2_c0bc32b8","updated":"2014-06-26 09:57:29.000000000","message":"@Dmitry,\n\nIt works, I can access this url, so can you try again?\n\nThanks","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"command call."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  We call IPMI command \u0027ipmitool sdr -v\u0027 to retrieve sensor data, with this"},{"line_number":47,"context_line":"  \u0027-v\u0027 option. We can get the entire sensor data including the extended"},{"line_number":48,"context_line":"  sensor informations, that is all sensor data in details including the"},{"line_number":49,"context_line":"  sensor current value(field name is \u0027Sensor Reading\u0027). Here is an example"},{"line_number":50,"context_line":"  which is the command return result:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_40366252","line":47,"updated":"2014-06-26 09:26:10.000000000","message":"I suggest: \"We call IPMI command \u0027ipmitool sdr -v\u0027 to retrieve sensor data. With \u0027-v\u0027 option we get the entire sensor data including the extended sensor information and the current value in \u0027Sendor Reading\u0027 field.\"","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  sensor current value(field name is \u0027Sensor Reading\u0027). Here is an example"},{"line_number":50,"context_line":"  which is the command return result:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  http://paste.openstack.org/show/63267/"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  So we can translate the result to a dict format which is group by \u0027Sensor"},{"line_number":55,"context_line":"  Type\u0027. For different type, we have different field names. By default, the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_a049e6b9","line":52,"updated":"2014-06-26 09:26:10.000000000","message":"this link also gives error 500. Is it only me?","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  http://paste.openstack.org/show/63267/"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  So we can translate the result to a dict format which is group by \u0027Sensor"},{"line_number":55,"context_line":"  Type\u0027. For different type, we have different field names. By default, the"},{"line_number":56,"context_line":"  IPMI node can support the basic three types: \u0027Fan\u0027, \u0027Temperature\u0027, and"},{"line_number":57,"context_line":"  \u0027Voltage\u0027."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_20b23696","line":54,"updated":"2014-06-26 09:26:10.000000000","message":"s/group/grouped/","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  http://paste.openstack.org/show/63267/"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  So we can translate the result to a dict format which is group by \u0027Sensor"},{"line_number":55,"context_line":"  Type\u0027. For different type, we have different field names. By default, the"},{"line_number":56,"context_line":"  IPMI node can support the basic three types: \u0027Fan\u0027, \u0027Temperature\u0027, and"},{"line_number":57,"context_line":"  \u0027Voltage\u0027."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_60afde2b","line":55,"updated":"2014-06-26 09:26:10.000000000","message":"s/type/types/","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  So we can translate the result to a dict format which is group by \u0027Sensor"},{"line_number":55,"context_line":"  Type\u0027. For different type, we have different field names. By default, the"},{"line_number":56,"context_line":"  IPMI node can support the basic three types: \u0027Fan\u0027, \u0027Temperature\u0027, and"},{"line_number":57,"context_line":"  \u0027Voltage\u0027."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"3. Adds periodic task to conductor which emits notification to Ceilometer by an"},{"line_number":60,"context_line":"   interval."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_2040765e","line":57,"updated":"2014-06-26 09:26:10.000000000","message":"Could you provide at least artificial example of what will be send to ceilometer, including minimum required set of fields?","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c28eb50ef0c0781a334634783b7955df7bcbf03b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  So we can translate the result to a dict format which is group by \u0027Sensor"},{"line_number":55,"context_line":"  Type\u0027. For different type, we have different field names. By default, the"},{"line_number":56,"context_line":"  IPMI node can support the basic three types: \u0027Fan\u0027, \u0027Temperature\u0027, and"},{"line_number":57,"context_line":"  \u0027Voltage\u0027."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"3. Adds periodic task to conductor which emits notification to Ceilometer by an"},{"line_number":60,"context_line":"   interval."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_83acf436","line":57,"in_reply_to":"1ae5cdf2_2040765e","updated":"2014-06-26 09:57:29.000000000","message":"Sure, it is listed in below section -  http://paste.openstack.org/show/68808/","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"656fcddb4cc807d8c925493a77ba12c67ed588bd","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  So we can translate the result to a dict format which is group by \u0027Sensor"},{"line_number":55,"context_line":"  Type\u0027. For different type, we have different field names. By default, the"},{"line_number":56,"context_line":"  IPMI node can support the basic three types: \u0027Fan\u0027, \u0027Temperature\u0027, and"},{"line_number":57,"context_line":"  \u0027Voltage\u0027."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"3. Adds periodic task to conductor which emits notification to Ceilometer by an"},{"line_number":60,"context_line":"   interval."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_f1e1fed0","line":57,"in_reply_to":"1ae5cdf2_83acf436","updated":"2014-06-26 10:36:28.000000000","message":"sorry, I was not clear enough. I meant some short artificial example right here, inline, so that we can kind of agree on the structure","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  Supports configurations options:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  conductor.send_sensor_data - Allow(True) to send sensor data message via"},{"line_number":68,"context_line":"  AMQP notification bus or not(False)."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":71,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_e3fe9804","line":68,"updated":"2014-06-26 09:26:10.000000000","message":"If it is False, no data will be collected or sent, right? Than we can just say \"boolean value, whether to enable collecting and sending sensor data\"","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c28eb50ef0c0781a334634783b7955df7bcbf03b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  Supports configurations options:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  conductor.send_sensor_data - Allow(True) to send sensor data message via"},{"line_number":68,"context_line":"  AMQP notification bus or not(False)."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":71,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_034f0493","line":68,"in_reply_to":"1ae5cdf2_e3fe9804","updated":"2014-06-26 09:57:29.000000000","message":"yes, will do.","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  AMQP notification bus or not(False)."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":71,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  In this method, we will check *CONF.conductor.send_sensor_data* value, do"},{"line_number":74,"context_line":"  nothing if it is false. And check out the nodes which driver is"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_63128859","line":71,"updated":"2014-06-26 09:26:10.000000000","message":"Please state the default value, if any.","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  In this method, we will check *CONF.conductor.send_sensor_data* value, do"},{"line_number":74,"context_line":"  nothing if it is false. And check out the nodes which driver is"},{"line_number":75,"context_line":"  *pxe_ipmitool*."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  We will call openstack.common.notifier.notify() method to send the sensor"},{"line_number":78,"context_line":"  data to AMQP notification bus, Ceilometer will consume the message."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_e373f8b1","line":75,"updated":"2014-06-26 09:26:10.000000000","message":"First part is redundant - we already explained what this option is for.\n\nI don\u0027t agree with the second part, I think we need to call get_sensor_data for all deployed nodes. If get_sensor_data returns None (not implemented) for the node, do not send anything.\n\nAre we calling it only for deployed nodes? please clarify as well.","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  *pxe_ipmitool*."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  We will call openstack.common.notifier.notify() method to send the sensor"},{"line_number":78,"context_line":"  data to AMQP notification bus, Ceilometer will consume the message."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  Here is the sample message which will be sent to Ceilomter:"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_6367e8ea","line":78,"updated":"2014-06-26 09:26:10.000000000","message":"This is implementation detail, I think it\u0027s not needed","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  We will call openstack.common.notifier.notify() method to send the sensor"},{"line_number":78,"context_line":"  data to AMQP notification bus, Ceilometer will consume the message."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  Here is the sample message which will be sent to Ceilomter:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  http://paste.openstack.org/show/68808/"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_e39a18c4","line":80,"updated":"2014-06-26 09:26:10.000000000","message":"s/Ceilomter/Ceilometer/","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"However this *get_sensor_data* is one new command introduced recently in"},{"line_number":93,"context_line":"latest release still not stable now, I did some testing with physical server,"},{"line_number":94,"context_line":"it still does not work, some IPMI sensor raw data can not be parsed by"},{"line_number":95,"context_line":"*get_sensor_data* command."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"So we will support \u0027ipminative\u0027 driver later."},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_03a0e4f2","line":95,"updated":"2014-06-26 09:26:10.000000000","message":"thank you for clarification!","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"it still does not work, some IPMI sensor raw data can not be parsed by"},{"line_number":95,"context_line":"*get_sensor_data* command."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"So we will support \u0027ipminative\u0027 driver later."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_40aca29f","line":97,"updated":"2014-06-26 09:26:10.000000000","message":"\"... later with a separate spec.\"","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"For the *interface* with Ceilometer, we have alternative way to call Ceilometer"},{"line_number":102,"context_line":"API directly to avoid the AMQP-mediated is not secure."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_e0b5aed0","line":102,"updated":"2014-06-26 09:26:10.000000000","message":"\"to avoid the AMQP-mediated is not secure\". You probably meant \"to avoid less-secure AMQP medium\"? I\u0027m afraid, I don\u0027t get it.","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7ed2105ad89606e7eba0cf2ae23007c5b1f5cac1","unresolved":false,"context_lines":[{"line_number":192,"context_line":"Testing"},{"line_number":193,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"We will have least unit tests. But for the IPMI data collection with physical"},{"line_number":196,"context_line":"server integration, it is difficult for us to do the *real* testing in CI."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_43590cfc","line":195,"updated":"2014-06-26 09:26:10.000000000","message":"s/least/at least/","commit_id":"80b4df836e2625a422cfed87001fd9198db17346"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5fc6a04492c47cd5ce77c2838becf48b8be1b494","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"1. Creates a new ironic.driver.base.ManagementInterface method for gathering"},{"line_number":30,"context_line":"hardware sensor data:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  def get_sensors_data(self, task):"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_71d7aebf","line":29,"updated":"2014-06-26 10:36:16.000000000","message":"Looks like there are some indentation problems here (see built doc). I suggest using proper bullet list:\n\n * Text\n    \n   blah-blah\n\n * Other text\n\n   blah-blah","commit_id":"b131ee59dbddb5473246ad169808a011ec537104"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"4e13788c8bc6d9359dfcee6469c4b00a0951a614","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"1. Creates a new ironic.driver.base.ManagementInterface method for gathering"},{"line_number":30,"context_line":"hardware sensor data:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  def get_sensors_data(self, task):"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_6c47d51d","line":29,"in_reply_to":"1ae5cdf2_71d7aebf","updated":"2014-06-26 10:53:33.000000000","message":"Good idea:)","commit_id":"b131ee59dbddb5473246ad169808a011ec537104"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5fc6a04492c47cd5ce77c2838becf48b8be1b494","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":76,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"},{"line_number":77,"context_line":"  value is 600. It calls get_sensor_data for all deployed nodes. If "},{"line_number":78,"context_line":"  get_sensor_data returns None (not implemented) for the node, do not send"},{"line_number":79,"context_line":"  anything."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_b14696a5","line":77,"updated":"2014-06-26 10:36:16.000000000","message":"Part starting with \"It calls\" should be moved to line #68","commit_id":"b131ee59dbddb5473246ad169808a011ec537104"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5fc6a04492c47cd5ce77c2838becf48b8be1b494","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Alternatives"},{"line_number":87,"context_line":"------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"An alternative way to do it is that we can enable our \u0027ipminative\u0027 driver to"},{"line_number":90,"context_line":"support IPMI sensor data collection, using *pyghmi* lib *get_sensor_data*"},{"line_number":91,"context_line":"command method call to access IPMI node."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_11e4aaa6","line":88,"updated":"2014-06-26 10:36:16.000000000","message":"As we have two alternatives considered here, let us also create a bullet list:\n\n * An alternative way to do it is that we can enable \u0027ipminative\u0027 driver....\n\n   ....\n\n * For the *interface* with Ceilometer, we have ...","commit_id":"b131ee59dbddb5473246ad169808a011ec537104"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ad45ebc119105f7505901566a804ac7ff94b3af1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      data structure as below:"},{"line_number":37,"context_line":"      \u0027Sensor Type\u0027 -\u003e \u0027Sensor ID\u0027 -\u003e \u0027Field\u0027:\u0027Value\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"      :returns: returns a consistent format dict of sensor data group by"},{"line_number":40,"context_line":"                sensor type, which can be processed by Ceilometer."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"      \"\"\""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1ae5cdf2_8695dd89","line":39,"updated":"2014-06-26 12:32:32.000000000","message":"redundant second \"returns\"","commit_id":"fae444ff8a52b90fa2c0a74fdd61d693498ec795"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ad45ebc119105f7505901566a804ac7ff94b3af1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  New *periodic_task* method *_send_sensor_data* will be added into"},{"line_number":68,"context_line":"  *ironic.conductor.manager*."},{"line_number":69,"context_line":"  It calls get_sensor_data for all deployed nodes. If get_sensor_data returns"},{"line_number":70,"context_line":"  None (not implemented) for the node, do not send anything."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  Supports configurations options:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1ae5cdf2_06e9cd19","line":70,"updated":"2014-06-26 12:32:32.000000000","message":"s/do/does/ (sorry, it\u0027s my fault)","commit_id":"fae444ff8a52b90fa2c0a74fdd61d693498ec795"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ad45ebc119105f7505901566a804ac7ff94b3af1","unresolved":false,"context_lines":[{"line_number":117,"context_line":"Driver API impact"},{"line_number":118,"context_line":"-----------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"A new function called *get_sensors_data* will be added to the *ironic.driver"},{"line_number":121,"context_line":".base.ManagementInterface*."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1ae5cdf2_06d0ed51","line":120,"updated":"2014-06-26 12:32:32.000000000","message":"please do not split the module name:\n\n A new function called *get_sensors_data* will be added to the \n *ironic.driver.base.ManagementInterface*.","commit_id":"fae444ff8a52b90fa2c0a74fdd61d693498ec795"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0862e6a5fcae39d9ca940917a354144437c6ba0d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      data structure as below:"},{"line_number":37,"context_line":"      \u0027Sensor Type\u0027 -\u003e \u0027Sensor ID\u0027 -\u003e \u0027Field\u0027:\u0027Value\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"      returns a consistent format dict of sensor data group by sensor type,"},{"line_number":40,"context_line":"      which can be processed by Ceilometer."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"      \"\"\""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1ae5cdf2_a90f0a2d","line":39,"updated":"2014-06-26 12:51:30.000000000","message":"s/returns/:returns:/","commit_id":"b1f5bc66eee2d4eade5df10cc7de45156ca37113"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"baff782d619fcbd0d708c502f876faaa7dcb6b7b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  hardware sensor data:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  def get_sensors_data(self, task):"},{"line_number":33,"context_line":"      \"\"\" Get the sensors data from IPMI node"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      This method get_sensors_data() will return a dict which is the common"},{"line_number":36,"context_line":"      data structure as below:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"1ae5cdf2_843ce893","line":33,"updated":"2014-06-26 19:53:30.000000000","message":"Wan-yen Hsu:\r\nIs this interface only for IPMI nodes or is it a standard interface for IPMI and non-IPMI nodes?     I think a standard interace will be needed for both IPMI and non-IPMI nodes.  Can we have two specs-  one for standard interface, configuration and flow and one for IPMI specific?","commit_id":"a3a1f4a5408addf9403f852b9fdaf79a2717b2a2"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"2dd5fe2711b808fb25f5107cbe56fcf1c21eadb0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  hardware sensor data:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  def get_sensors_data(self, task):"},{"line_number":33,"context_line":"      \"\"\" Get the sensors data from IPMI node"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      This method get_sensors_data() will return a dict which is the common"},{"line_number":36,"context_line":"      data structure as below:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"1ae5cdf2_6230a755","line":33,"in_reply_to":"1ae5cdf2_843ce893","updated":"2014-06-26 23:13:24.000000000","message":"Yes, this get_sensors_data() is designed for common interface including IPMI and non-IPMI nodes, so here docstring is not exactly, will remove the *IPMI* words from the docstring.","commit_id":"a3a1f4a5408addf9403f852b9fdaf79a2717b2a2"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"baff782d619fcbd0d708c502f876faaa7dcb6b7b","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      This method get_sensors_data() will return a dict which is the common"},{"line_number":36,"context_line":"      data structure as below:"},{"line_number":37,"context_line":"      \u0027Sensor Type\u0027 -\u003e \u0027Sensor ID\u0027 -\u003e \u0027Field\u0027:\u0027Value\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"      :returns: a consistent format dict of sensor data group by sensor type,"},{"line_number":40,"context_line":"                which can be processed by Ceilometer."}],"source_content_type":"text/x-rst","patch_set":16,"id":"1ae5cdf2_24ea34a0","line":37,"updated":"2014-06-26 19:53:30.000000000","message":"Wan-yen Hsu:  This interface will need to allow vendors to provide extra sensor types and extra sensor IDs that are not \"basic\".","commit_id":"a3a1f4a5408addf9403f852b9fdaf79a2717b2a2"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"2dd5fe2711b808fb25f5107cbe56fcf1c21eadb0","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      This method get_sensors_data() will return a dict which is the common"},{"line_number":36,"context_line":"      data structure as below:"},{"line_number":37,"context_line":"      \u0027Sensor Type\u0027 -\u003e \u0027Sensor ID\u0027 -\u003e \u0027Field\u0027:\u0027Value\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"      :returns: a consistent format dict of sensor data group by sensor type,"},{"line_number":40,"context_line":"                which can be processed by Ceilometer."}],"source_content_type":"text/x-rst","patch_set":16,"id":"1ae5cdf2_8283f3c9","line":37,"in_reply_to":"1ae5cdf2_24ea34a0","updated":"2014-06-26 23:13:24.000000000","message":"Yes, we support all Sensor Types, however for the \u0027basic\u0027 sensor types, that is the first version have to be supported for Ceilometer part, Ironic will not check and make difference if it is *basic* sensor type or not.","commit_id":"a3a1f4a5408addf9403f852b9fdaf79a2717b2a2"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c0479b91f179202fc7457cde3d7d8431d7dfe4f5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  So we can translate the result to a dict format which is grouped by \u0027Sensor"},{"line_number":60,"context_line":"  Type\u0027. For different types, we have different field names. By default, the"},{"line_number":61,"context_line":"  IPMI node can support the basic three types: \u0027Fan\u0027, \u0027Temperature\u0027, and"},{"line_number":62,"context_line":"  \u0027Voltage\u0027."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Adds periodic task to conductor which emits notification to Ceilometer by an"},{"line_number":65,"context_line":"  interval."}],"source_content_type":"text/x-rst","patch_set":16,"id":"1ae5cdf2_9f699c27","line":62,"updated":"2014-06-26 14:16:22.000000000","message":"Would it make to also mention explicitly that non-varying sensor data is probably not very useful to report in this way and should be filtered out of the notification, as discussed in the comments for the corresponding ceilometer spec review:\n\n  https://review.openstack.org/#/c/100657/5/specs/juno/ironic-notifications.rst","commit_id":"a3a1f4a5408addf9403f852b9fdaf79a2717b2a2"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"2dd5fe2711b808fb25f5107cbe56fcf1c21eadb0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  So we can translate the result to a dict format which is grouped by \u0027Sensor"},{"line_number":60,"context_line":"  Type\u0027. For different types, we have different field names. By default, the"},{"line_number":61,"context_line":"  IPMI node can support the basic three types: \u0027Fan\u0027, \u0027Temperature\u0027, and"},{"line_number":62,"context_line":"  \u0027Voltage\u0027."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Adds periodic task to conductor which emits notification to Ceilometer by an"},{"line_number":65,"context_line":"  interval."}],"source_content_type":"text/x-rst","patch_set":16,"id":"1ae5cdf2_825a1380","line":62,"in_reply_to":"1ae5cdf2_9f699c27","updated":"2014-06-26 23:13:24.000000000","message":"Good idea, will add the section for non-varying sensors which will not be sent to Ceilometer, and will filtered out from Ironic code.","commit_id":"a3a1f4a5408addf9403f852b9fdaf79a2717b2a2"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"baff782d619fcbd0d708c502f876faaa7dcb6b7b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  None (not implemented) for the node, does not send anything."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  Supports configurations options:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  conductor.send_sensor_data - boolean value, whether to enable collecting"},{"line_number":76,"context_line":"  and sending sensor data."}],"source_content_type":"text/x-rst","patch_set":16,"id":"1ae5cdf2_f82b8c79","line":73,"updated":"2014-06-26 19:53:30.000000000","message":"Wan-yen Hsu:  It would be useful if it can allow sensor types to be collected configurable so that it will only collect the sensor data of interest.   The default can be all sensors.  This can be an optional feature that some Ironic drivers (IPMI dirver or non-IPMI vendor drivers) may choose to support.","commit_id":"a3a1f4a5408addf9403f852b9fdaf79a2717b2a2"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"2dd5fe2711b808fb25f5107cbe56fcf1c21eadb0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  None (not implemented) for the node, does not send anything."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  Supports configurations options:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  conductor.send_sensor_data - boolean value, whether to enable collecting"},{"line_number":76,"context_line":"  and sending sensor data."}],"source_content_type":"text/x-rst","patch_set":16,"id":"1ae5cdf2_e2a4b74d","line":73,"in_reply_to":"1ae5cdf2_f82b8c79","updated":"2014-06-26 23:13:24.000000000","message":"This is good idea, I will add this feature into Alternatives that we can support the configurable collection with a separate spec I think.","commit_id":"a3a1f4a5408addf9403f852b9fdaf79a2717b2a2"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"86ddd6179ceefa5a9a670724e66f1cc12232f53b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Implements the interface into \u0027ipmitool\u0027 driver to gather data via IPMI"},{"line_number":49,"context_line":"  command call."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  We call IPMI command \u0027ipmitool sdr -v\u0027 to retrieve sensor data. With \u0027-v\u0027"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_d56912f9","line":48,"updated":"2014-06-27 19:44:16.000000000","message":"what about other drivers, Native IPMI I believe can support such an interface, while ssh can not (/me envisions a really ugly hack that would allow ssh to support it, but it would not be pretty)","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"22f18cef5d74be46389225131c4401fcd034ee50","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Implements the interface into \u0027ipmitool\u0027 driver to gather data via IPMI"},{"line_number":49,"context_line":"  command call."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  We call IPMI command \u0027ipmitool sdr -v\u0027 to retrieve sensor data. With \u0027-v\u0027"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_2abf2dfd","line":48,"in_reply_to":"1ae5cdf2_d56912f9","updated":"2014-06-27 23:23:59.000000000","message":"Chris, yes, we will support it once the *pyghmi* lib is stable, we have the section for \u0027ipmitool\u0027 supporting in below Alternatives first section, it has some defect(I will raise) for its new *get_sensor_data* command.","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2b3d896200f585eeac383504a7f01c63615c8618","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  Supports configurations options:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  conductor.send_sensor_data - boolean value, whether to enable collecting"},{"line_number":79,"context_line":"  and sending sensor data."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":82,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_dde9431b","line":79,"updated":"2014-06-27 15:02:57.000000000","message":"Can I assume it defaults to False?","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"22f18cef5d74be46389225131c4401fcd034ee50","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  Supports configurations options:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  conductor.send_sensor_data - boolean value, whether to enable collecting"},{"line_number":79,"context_line":"  and sending sensor data."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":82,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_4abab90b","line":79,"in_reply_to":"1ae5cdf2_dde9431b","updated":"2014-06-27 23:23:59.000000000","message":"Sure, will add it:)","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2b3d896200f585eeac383504a7f01c63615c8618","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":82,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"},{"line_number":83,"context_line":"  value is 600."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  Here is the sample message which will be sent to Ceilometer:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  http://paste.openstack.org/show/68808/"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_1896593e","line":84,"updated":"2014-06-27 15:02:57.000000000","message":"It would be good to have another configuration option here (send_sensor_data_types?) where you could list what types of data you want to send, that would allow people to tune which type of data they want to consume and not waste bandwidth sending everything all the time. (By default we could send everything)\n\nWhat you guys think?","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"22f18cef5d74be46389225131c4401fcd034ee50","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":82,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"},{"line_number":83,"context_line":"  value is 600."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  Here is the sample message which will be sent to Ceilometer:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  http://paste.openstack.org/show/68808/"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_eab38506","line":84,"in_reply_to":"1ae5cdf2_1896593e","updated":"2014-06-27 23:23:59.000000000","message":"That is ok, I will add this configuration option \u0027send_sensor_data_types\u0027 to support the sensor type customization, such as:\n\n* Default option setting:\n\n    send_sensor_data_types\u003dALL \n    #by default, send all(which has \u0027Sensor Reading\u0027 field, required by Ceilometer.\n\n* For customization setting:\n\n    send_sensor_data_types\u003dTemperature,Fan,Current,Current \n    #which match sensor data\u0027s \u0027Sensor Type\u0027 field value.","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"86ddd6179ceefa5a9a670724e66f1cc12232f53b","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Data model impact"},{"line_number":116,"context_line":"-----------------"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"None"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_557d02b1","line":117,"updated":"2014-06-27 19:44:16.000000000","message":"would ever have a need to know when the last sensor data was collected?","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"22f18cef5d74be46389225131c4401fcd034ee50","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Data model impact"},{"line_number":116,"context_line":"-----------------"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"None"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_caa7a9ba","line":117,"in_reply_to":"1ae5cdf2_557d02b1","updated":"2014-06-27 23:23:59.000000000","message":"I understand you mean that we need introduce new nods\u0027s field such as last_sensor_data_collected to record the timestamp of latest collection for the node?","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2b3d896200f585eeac383504a7f01c63615c8618","unresolved":false,"context_lines":[{"line_number":120,"context_line":"REST API impact"},{"line_number":121,"context_line":"---------------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"None"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Driver API impact"},{"line_number":126,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_388315cc","line":123,"updated":"2014-06-27 15:02:57.000000000","message":"Question: The management interface will expose it\u0027s methods like set/get boot devices on the REST API, do you think that the get_sensor_data() is something that we want to expose as well?","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"22f18cef5d74be46389225131c4401fcd034ee50","unresolved":false,"context_lines":[{"line_number":120,"context_line":"REST API impact"},{"line_number":121,"context_line":"---------------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"None"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Driver API impact"},{"line_number":126,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_ea98e56a","line":123,"in_reply_to":"1ae5cdf2_388315cc","updated":"2014-06-27 23:23:59.000000000","message":"Lucas, I missed this, sure we can support expose the REST API for more consumer to use this function with API call.","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2b3d896200f585eeac383504a7f01c63615c8618","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Performance Impact"},{"line_number":156,"context_line":"------------------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Other deployer impact"},{"line_number":161,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_ac47ea4a","line":158,"updated":"2014-06-27 15:02:57.000000000","message":"I\u0027m sure it\u0027s going to have some Performance impact, periodic tasks sucks :( they run one after the other in a single greenthread. So periodic tasks like this which poke the BMC will affect the timing of other periodic tasks waiting to run.","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"22f18cef5d74be46389225131c4401fcd034ee50","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Performance Impact"},{"line_number":156,"context_line":"------------------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Other deployer impact"},{"line_number":161,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_2a9e4d54","line":158,"in_reply_to":"1ae5cdf2_ac47ea4a","updated":"2014-06-27 23:23:59.000000000","message":"Yes, will address this.","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2b3d896200f585eeac383504a7f01c63615c8618","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Other deployer impact"},{"line_number":161,"context_line":"---------------------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"None"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Developer impact"},{"line_number":166,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_58b0e18a","line":163,"updated":"2014-06-27 15:02:57.000000000","message":"as per template[1], this section should mention the configuration options been added\n\n[1] https://github.com/openstack/ironic-specs/blob/master/specs/template.rst#other-deployer-impact","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"22f18cef5d74be46389225131c4401fcd034ee50","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Other deployer impact"},{"line_number":161,"context_line":"---------------------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"None"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Developer impact"},{"line_number":166,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_8ab681da","line":163,"in_reply_to":"1ae5cdf2_58b0e18a","updated":"2014-06-27 23:23:59.000000000","message":"OK, let me add these into tis section, thanks for your reference Lucas.","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45ff029e08402cb27a81a2dc38788d8deabec5d4","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  Haomeng, Wang(LP ID \u003d\u003d whaom)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Other contributors:"},{"line_number":181,"context_line":"  Co-work with Ceilometer team developer Chris Dent (LP ID \u003d\u003d cdent)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Work Items"},{"line_number":184,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"dab895d6_0ed8971c","line":181,"updated":"2014-06-29 15:26:22.000000000","message":"I\u0027m chdent on LP","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ed5401ff60423f161ed58c84e6a4121d788bcd03","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  Haomeng, Wang(LP ID \u003d\u003d whaom)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Other contributors:"},{"line_number":181,"context_line":"  Co-work with Ceilometer team developer Chris Dent (LP ID \u003d\u003d cdent)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Work Items"},{"line_number":184,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"dab895d6_18f9bc4d","line":181,"in_reply_to":"dab895d6_0ed8971c","updated":"2014-06-29 23:07:04.000000000","message":"Chris, sorry, will change.","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"22f18cef5d74be46389225131c4401fcd034ee50","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":".. _Ceilometer spec: https://blueprints.launchpad.net/ironic/+spec/send-data-to-ceilometer"},{"line_number":224,"context_line":".. _Review in progress: https://review.openstack.org/#/c/72538/"},{"line_number":225,"context_line":".. _Sample data: http://paste.openstack.org/show/68808/"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"1ae5cdf2_0aca714e","line":225,"updated":"2014-06-27 23:23:59.000000000","message":"Will change to latest sample data to reflect the spec change - http://paste.openstack.org/show/85053/","commit_id":"10cf944fea4c31e86b9c72c53669848861b258b6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"a336e8cb77b5832b143b24de20b531cf80c686f2","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  * Default option setting:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    send_sensor_data_types\u003dALL "},{"line_number":97,"context_line":"    #by default, send all(which has \u0027Sensor Reading\u0027 field, required by"},{"line_number":98,"context_line":"    Ceilometer."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab895d6_9b5ce627","line":96,"updated":"2014-06-29 23:37:02.000000000","message":"Trailing whitespace.","commit_id":"a42c7bfca5c1298904748190d3b2df0086b708ea"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"a336e8cb77b5832b143b24de20b531cf80c686f2","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  * For customization setting:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    send_sensor_data_types\u003dTemperature,Fan,Current,Current "},{"line_number":103,"context_line":"    #which match sensor data\u0027s \u0027Sensor Type\u0027 field value."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab895d6_bb40ca36","line":102,"updated":"2014-06-29 23:37:02.000000000","message":"Trailing whitespace.","commit_id":"a42c7bfca5c1298904748190d3b2df0086b708ea"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"a336e8cb77b5832b143b24de20b531cf80c686f2","unresolved":false,"context_lines":[{"line_number":136,"context_line":"REST API impact"},{"line_number":137,"context_line":"---------------"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"The management interfaceThe management interface will expose the new method "},{"line_number":140,"context_line":"*get_sensors_data*. User can call this api to retrieve the sensors data."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Driver API impact"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab895d6_db3d7ebd","line":139,"updated":"2014-06-29 23:37:02.000000000","message":"\"The management interface\" is repeated twice.\n\nAlso trailing whitespace.","commit_id":"a42c7bfca5c1298904748190d3b2df0086b708ea"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"af06dffcb8b35b4a75c8e1c5e3c79215a7df1f32","unresolved":false,"context_lines":[{"line_number":136,"context_line":"REST API impact"},{"line_number":137,"context_line":"---------------"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"The management interfaceThe management interface will expose the new method"},{"line_number":140,"context_line":"*get_sensors_data*. User can call this api to retrieve the sensors data."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Driver API impact"}],"source_content_type":"text/x-rst","patch_set":20,"id":"dab895d6_1b5ff60f","line":139,"updated":"2014-06-29 23:47:34.000000000","message":"\"The management interfaceThe management interface\"\n\n^^^ still repeated","commit_id":"65fda389c20258b235b8e5b79ec0d57f9e463714"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"91d3be9c135b0a9a34096eaec6de0a4305117704","unresolved":false,"context_lines":[{"line_number":136,"context_line":"REST API impact"},{"line_number":137,"context_line":"---------------"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"The management interfaceThe management interface will expose the new method"},{"line_number":140,"context_line":"*get_sensors_data*. User can call this api to retrieve the sensors data."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Driver API impact"}],"source_content_type":"text/x-rst","patch_set":20,"id":"dab895d6_7bcab2a2","line":139,"in_reply_to":"dab895d6_1b5ff60f","updated":"2014-06-30 00:05:04.000000000","message":"Good catch, will fix, thank you.","commit_id":"65fda389c20258b235b8e5b79ec0d57f9e463714"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b5c2b7f56376dc07aedba53917c1f633c0e04603","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Creates a new ironic.driver.base.ManagementInterface common method i"},{"line_number":30,"context_line":"  *get_sensors_data* for gathering hardware sensor data:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  def get_sensors_data(self, task):"}],"source_content_type":"text/x-rst","patch_set":23,"id":"dab895d6_61603836","line":29,"updated":"2014-06-30 10:18:51.000000000","message":"trailing \u0027i\u0027 ?","commit_id":"2f1f7364825e80cada4f17f67edd12460807d4fd"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b5c2b7f56376dc07aedba53917c1f633c0e04603","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  * For customization setting:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    send_sensor_data_types\u003dTemperature,Fan,Current,Current"},{"line_number":105,"context_line":"    #which match sensor data\u0027s \u0027Sensor Type\u0027 field value."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"dab895d6_81cc6c37","line":104,"updated":"2014-06-30 10:18:51.000000000","message":"duplicated \"Current\"","commit_id":"2f1f7364825e80cada4f17f67edd12460807d4fd"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b5c2b7f56376dc07aedba53917c1f633c0e04603","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  collect the sensor data of interest. The default can be all sensors. This can"},{"line_number":129,"context_line":"  be an optional feature that some Ironic drivers (IPMI dirver or non-IPMI"},{"line_number":130,"context_line":"  vendor drivers) may choose to support later with a separate spec."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Data model impact"},{"line_number":134,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":23,"id":"dab895d6_c1a4a459","line":131,"updated":"2014-06-30 10:18:51.000000000","message":"Another alternative would be Ceilometer pulling it from our API? since it\u0027s going to be exposed","commit_id":"2f1f7364825e80cada4f17f67edd12460807d4fd"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"5ce55db2d3ef3d52a98fc9cd89f6ad19a53ecd89","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  collect the sensor data of interest. The default can be all sensors. This can"},{"line_number":129,"context_line":"  be an optional feature that some Ironic drivers (IPMI dirver or non-IPMI"},{"line_number":130,"context_line":"  vendor drivers) may choose to support later with a separate spec."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Data model impact"},{"line_number":134,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":23,"id":"dab895d6_7cc1bfe3","line":131,"in_reply_to":"dab895d6_c1a4a459","updated":"2014-06-30 10:53:06.000000000","message":"Yes, that is good idea, thank Lucas.","commit_id":"2f1f7364825e80cada4f17f67edd12460807d4fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9aa734e128ac8f942e2fc73010b62bc46ee27a07","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      This method get_sensors_data() will return a dict which is the common"},{"line_number":36,"context_line":"      data structure to support both IPMI and non-IPMI sensors as below:"},{"line_number":37,"context_line":"      \u0027Sensor Type\u0027 -\u003e \u0027Sensor ID\u0027 -\u003e \u0027Field\u0027:\u0027Value\u0027"},{"line_number":38,"context_line":"      The sensor current reading value should be found in \u0027Sensor Reading\u0027"},{"line_number":39,"context_line":"      field."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      :returns: a consistent format dict of sensor data group by sensor type,"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_22651645","line":38,"updated":"2014-07-02 17:35:59.000000000","message":"I\u0027m a bit confused here. What/where is the \u0027Sensor Reading\u0027 field? Isn\u0027t the value in \u0027Value\u0027 above, or do you mean something else?\n\nAhh, ok, that\u0027s from the ipmitool command mentioned below. I don\u0027t think that this should be mentioned here in the base get_sensors_data() method. But you can put it in the docstring for ironic.driver.module.ipmitool.ManagementInterface\u0027s method.\n\nThese examples are great but when this is coded, I would expect there to be a more detailed description of the returned dict.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9aa734e128ac8f942e2fc73010b62bc46ee27a07","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  Here is an example which is the command return result:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  http://paste.openstack.org/show/63267/"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  So we can translate the result to a dict format which is grouped by \u0027Sensor"},{"line_number":62,"context_line":"  Type\u0027. For different types, we have different field names. By default, the"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_2587e062","line":59,"updated":"2014-07-02 17:35:59.000000000","message":"This didn\u0027t work for me:-( A good reason for trying to describe things in the spec itself.\n\nThat\u0027s an example of output from the ipmitool\u0027s command?","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c227529e718e48dcd91cb2a46f47e392dc4b6d8c","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  Here is an example which is the command return result:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  http://paste.openstack.org/show/63267/"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  So we can translate the result to a dict format which is grouped by \u0027Sensor"},{"line_number":62,"context_line":"  Type\u0027. For different types, we have different field names. By default, the"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_f703cc0a","line":59,"in_reply_to":"baada198_2587e062","updated":"2014-07-03 02:31:39.000000000","message":"Hi Ruby,\n\nYes, this is example of the result ipmitool command.\n\nLooks like there is something problem with paste.openstack.org, we can get error for the first accessing.\n\nCan you please refresh the page again?\n\n\nThanks","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb95e2fe4ff9a35038a88a1ed5e6bf405cbdf12c","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  New *periodic_task* method *_send_sensor_data* will be added into"},{"line_number":73,"context_line":"  *ironic.conductor.manager*."},{"line_number":74,"context_line":"  It calls get_sensor_data for all deployed nodes. If get_sensor_data returns"},{"line_number":75,"context_line":"  None (not implemented) for the node, does not send anything."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_b01c0c15","line":74,"updated":"2014-07-02 17:36:54.000000000","message":"Do we want to be more specific here? Do you really mean \u0027deployed\u0027 (ie associated with an instance), or are we gathering sensor data for all nodes that are registered with Ironic, or all nodes that are powered on or ??","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c227529e718e48dcd91cb2a46f47e392dc4b6d8c","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  New *periodic_task* method *_send_sensor_data* will be added into"},{"line_number":73,"context_line":"  *ironic.conductor.manager*."},{"line_number":74,"context_line":"  It calls get_sensor_data for all deployed nodes. If get_sensor_data returns"},{"line_number":75,"context_line":"  None (not implemented) for the node, does not send anything."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_f72aec7c","line":74,"in_reply_to":"baada198_b01c0c15","updated":"2014-07-03 02:31:39.000000000","message":"Yes, agree with you, for the nodes which is associated with an instance, we can get sensor date from them, will address the \u0027powered on\u0027 status.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"d9d1797020b35702d1837ea6bfa1e1daaeca3a87","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  New *periodic_task* method *_send_sensor_data* will be added into"},{"line_number":73,"context_line":"  *ironic.conductor.manager*."},{"line_number":74,"context_line":"  It calls get_sensor_data for all deployed nodes. If get_sensor_data returns"},{"line_number":75,"context_line":"  None (not implemented) for the node, does not send anything."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_7d0ac48a","line":74,"in_reply_to":"baada198_f72aec7c","updated":"2014-07-07 22:17:38.000000000","message":"Wan-yen:  Do you really want to restrict this to just deployed nodes?  I see use cases to get sensor data for all registered nodes as well.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9aa734e128ac8f942e2fc73010b62bc46ee27a07","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  New *periodic_task* method *_send_sensor_data* will be added into"},{"line_number":73,"context_line":"  *ironic.conductor.manager*."},{"line_number":74,"context_line":"  It calls get_sensor_data for all deployed nodes. If get_sensor_data returns"},{"line_number":75,"context_line":"  None (not implemented) for the node, does not send anything."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  Supports configurations options:"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_c5bf04fa","line":75,"updated":"2014-07-02 17:35:59.000000000","message":"doesn\u0027t send anything for that node, right? I\u0027m assuming you don\u0027t mean it doesn\u0027t send any data at all.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c227529e718e48dcd91cb2a46f47e392dc4b6d8c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  New *periodic_task* method *_send_sensor_data* will be added into"},{"line_number":73,"context_line":"  *ironic.conductor.manager*."},{"line_number":74,"context_line":"  It calls get_sensor_data for all deployed nodes. If get_sensor_data returns"},{"line_number":75,"context_line":"  None (not implemented) for the node, does not send anything."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  Supports configurations options:"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_f7510c0f","line":75,"in_reply_to":"baada198_c5bf04fa","updated":"2014-07-03 02:31:39.000000000","message":"Yes, we send nothing for this case.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d7f867bb1c5901cca285cabae0c6c056a2d018ac","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":84,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"},{"line_number":85,"context_line":"  value is 600."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  Here is the sample message which will be sent to Ceilometer:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_7b8fd0cc","line":85,"updated":"2014-07-02 08:28:24.000000000","message":"I agree with Lucas on this one -- there\u0027s no harm in sending data to ceilometer at less than this period, should the conductor be restarted or the node remapped to a different conductor. I see no problem here.\n\nThe only risk is in poking the BMC too aggressively, but we have already added a safeguard against that within the ipmitool driver. (conductor rapid-firing restarts notwithstanding, and that\u0027s another sort of issue entirely...)","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"848072cbef0dc5c5da97a76c88c03a820c976e5e","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":84,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"},{"line_number":85,"context_line":"  value is 600."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  Here is the sample message which will be sent to Ceilometer:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_7e170952","line":85,"updated":"2014-06-30 15:15:37.000000000","message":"with out any data changes to the data model how will the periodic task act on restart or conductor failure.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e565f69ef2bf37a5c82e365bc409b1be2d9aaa7f","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":84,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"},{"line_number":85,"context_line":"  value is 600."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  Here is the sample message which will be sent to Ceilometer:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_80c8b323","line":85,"in_reply_to":"baada198_4adb4a1b","updated":"2014-07-02 07:55:51.000000000","message":"Hmm, I\u0027m not sure if that\u0027s really needed, I talked to eoghan a little about it and there\u0027s no harm in resubmitting the data to ceilometer, all it\u0027s going to do is to create a new data point in ceilometer, which is totally expected.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c227529e718e48dcd91cb2a46f47e392dc4b6d8c","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":84,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"},{"line_number":85,"context_line":"  value is 600."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  Here is the sample message which will be sent to Ceilometer:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_773dfcba","line":85,"in_reply_to":"baada198_7b8fd0cc","updated":"2014-07-03 02:31:39.000000000","message":"Good idea, thank you Deva, Lucas and Chris.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3f858be2d9e5de88aae7b677b05381394d0ae81a","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":84,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"},{"line_number":85,"context_line":"  value is 600."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  Here is the sample message which will be sent to Ceilometer:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_0173104e","line":85,"in_reply_to":"baada198_7e170952","updated":"2014-06-30 15:31:14.000000000","message":"I don\u0027t know if I got the question, but Ironic would just resend the metrics? I don\u0027t think it\u0027s a big problem because all it would do is get ceilometer to create another data timestamp (datapoint, data entry, idk how it\u0027s called in ceilometer).\n\nWhat are the concerns here?","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"dcb3acf8f6118f3c3040c5bf93f4006db3449149","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":84,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"},{"line_number":85,"context_line":"  value is 600."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  Here is the sample message which will be sent to Ceilometer:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_4adb4a1b","line":85,"in_reply_to":"baada198_7e170952","updated":"2014-07-01 07:02:55.000000000","message":"I understand do you mean we need add data model to record such as the last collection time stamp? I think this is a good idea, can we create separated specs to cover this send-message-audit function which can record the time stamp when the message is sending for each node?","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"ecdbc90c47a86c214c877e6107841f7e1faa9968","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  conductor.send_sensor_data_interval - Seconds between conductor sending"},{"line_number":84,"context_line":"  sensor data message to Ceilometer via the AMQP notification bus. The default"},{"line_number":85,"context_line":"  value is 600."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  Here is the sample message which will be sent to Ceilometer:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_56bf41fb","line":85,"in_reply_to":"baada198_80c8b323","updated":"2014-07-02 08:38:24.000000000","message":"Since Ironic don\u0027t need to send notifications at a fixed interval, I don\u0027t think we should care about conductor failures. Furthermore, that data won\u0027t be used in Ironic in the future, so I would just avoid caching it.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9aa734e128ac8f942e2fc73010b62bc46ee27a07","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  * Default option setting:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    send_sensor_data_types\u003dALL"},{"line_number":99,"context_line":"    #by default, send all which has \u0027Sensor Reading\u0027 field, required by"},{"line_number":100,"context_line":"    Ceilometer."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_652b9830","line":98,"updated":"2014-07-02 17:35:59.000000000","message":"just to be consistent (if I understand correctly), you mean conductor.send_sensor_data_types?","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c227529e718e48dcd91cb2a46f47e392dc4b6d8c","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  * Default option setting:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    send_sensor_data_types\u003dALL"},{"line_number":99,"context_line":"    #by default, send all which has \u0027Sensor Reading\u0027 field, required by"},{"line_number":100,"context_line":"    Ceilometer."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_b747944a","line":98,"in_reply_to":"baada198_652b9830","updated":"2014-07-03 02:31:39.000000000","message":"yes, it is conductor.send_sensor_data_types.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9aa734e128ac8f942e2fc73010b62bc46ee27a07","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* For the *interface* with Ceilometer, we have alternative way to call"},{"line_number":125,"context_line":"  Ceilometer API directly to avoid less-secure AMQP medium."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* We can allow sensor types to be collected configurable so that it will only"},{"line_number":128,"context_line":"  collect the sensor data of interest. The default can be all sensors. This can"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_85034c41","line":125,"updated":"2014-07-02 17:35:59.000000000","message":"So why not use the Ceilometer API directly?","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c227529e718e48dcd91cb2a46f47e392dc4b6d8c","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* For the *interface* with Ceilometer, we have alternative way to call"},{"line_number":125,"context_line":"  Ceilometer API directly to avoid less-secure AMQP medium."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* We can allow sensor types to be collected configurable so that it will only"},{"line_number":128,"context_line":"  collect the sensor data of interest. The default can be all sensors. This can"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_f7866c64","line":125,"in_reply_to":"baada198_85034c41","updated":"2014-07-03 02:31:39.000000000","message":"This solution is confirmed with Ceilometer team, we send the notification by internal, that is fine with AMQP, because for current Ceilometer, all the notification are sent by AMQP directly.\n\nSo here is a security concern, will address and follow with Ceiloemter in the future.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"fcf5242754938ad2eb34e0642dc36703c738b2fc","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* For the *interface* with Ceilometer, we have alternative way to call"},{"line_number":125,"context_line":"  Ceilometer API directly to avoid less-secure AMQP medium."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* We can allow sensor types to be collected configurable so that it will only"},{"line_number":128,"context_line":"  collect the sensor data of interest. The default can be all sensors. This can"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_925d2918","line":125,"in_reply_to":"baada198_f7866c64","updated":"2014-07-03 14:06:16.000000000","message":"Using notifications is the most effective way to manage scaling concerns.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d7f867bb1c5901cca285cabae0c6c056a2d018ac","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  vendor drivers) may choose to support later with a separate spec."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* Another way, Ceilometer can pull Ironic API *get_sensors_data* to retrieve"},{"line_number":133,"context_line":"  the sensor data actively."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Data model impact"},{"line_number":136,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_9bbd846b","line":133,"updated":"2014-07-02 08:28:24.000000000","message":"Simply noting here that any active polling of a BMC is prone to error and latency problems.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c227529e718e48dcd91cb2a46f47e392dc4b6d8c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  vendor drivers) may choose to support later with a separate spec."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* Another way, Ceilometer can pull Ironic API *get_sensors_data* to retrieve"},{"line_number":133,"context_line":"  the sensor data actively."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Data model impact"},{"line_number":136,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_b78cf480","line":133,"in_reply_to":"baada198_9bbd846b","updated":"2014-07-03 02:31:39.000000000","message":"Agree with you Deva, so we did not prefer this solution.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d7f867bb1c5901cca285cabae0c6c056a2d018ac","unresolved":false,"context_lines":[{"line_number":141,"context_line":"---------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"The management interface will expose the new method *get_sensors_data*. User"},{"line_number":144,"context_line":"can call this api to retrieve the sensors data."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Driver API impact"},{"line_number":147,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_bbc088e1","line":144,"updated":"2014-07-02 08:28:24.000000000","message":"As noted above, this poses some risk right now, but with a move to an asycn API planned\nfor next cycle, I think the API change is reasonable.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c227529e718e48dcd91cb2a46f47e392dc4b6d8c","unresolved":false,"context_lines":[{"line_number":141,"context_line":"---------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"The management interface will expose the new method *get_sensors_data*. User"},{"line_number":144,"context_line":"can call this api to retrieve the sensors data."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Driver API impact"},{"line_number":147,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_57de386e","line":144,"in_reply_to":"baada198_bbc088e1","updated":"2014-07-03 02:31:39.000000000","message":"OK.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d7f867bb1c5901cca285cabae0c6c056a2d018ac","unresolved":false,"context_lines":[{"line_number":179,"context_line":"Have some Performance impact about the periodic tasks, they run one after the"},{"line_number":180,"context_line":"other in a single greenthread. So periodic tasks like this which poke the BMC"},{"line_number":181,"context_line":"will affect the timing of other periodic tasks waiting to run."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Other deployer impact"},{"line_number":185,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_dbb7fc84","line":182,"updated":"2014-07-02 08:28:24.000000000","message":"Also has a scalability impact -- as the number of nodes managed by a single conductor\nincreases, the time for this periodic task to run will also increase.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c227529e718e48dcd91cb2a46f47e392dc4b6d8c","unresolved":false,"context_lines":[{"line_number":179,"context_line":"Have some Performance impact about the periodic tasks, they run one after the"},{"line_number":180,"context_line":"other in a single greenthread. So periodic tasks like this which poke the BMC"},{"line_number":181,"context_line":"will affect the timing of other periodic tasks waiting to run."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Other deployer impact"},{"line_number":185,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_b7687488","line":182,"in_reply_to":"baada198_dbb7fc84","updated":"2014-07-03 02:31:39.000000000","message":"Yes, will involve the performance issue for single conductor.","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"fcf5242754938ad2eb34e0642dc36703c738b2fc","unresolved":false,"context_lines":[{"line_number":237,"context_line":"supported, and how to enable it."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"References"},{"line_number":241,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"* `Ceilometer spec`_"}],"source_content_type":"text/x-rst","patch_set":24,"id":"baada198_725335e2","line":240,"updated":"2014-07-03 14:06:16.000000000","message":"You may wish to add a reference to the related ceilometer spec: https://github.com/openstack/ceilometer-specs/blob/master/specs/juno/ironic-notifications.rst","commit_id":"0ccece7fe721bccd065f0aade3a7b39883475179"}]}
