)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"change_message_id":"f149b6ea47ca47a9be46b0866717506641080593","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send iLO health metrics to ceilometer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Updated Design Specification for blue print"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I83530fd80c7f18534a922222675dc42d1ee34daa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a80dd14_6f2f29f7","line":9,"updated":"2015-03-05 09:43:31.000000000","message":"Add the link to the blueprint here.","commit_id":"5e619f244a5b09633970f451b69a16f5b7ef6f55"}],"specs/kilo/send-ilo-health-metrics-to-ceilometer.rst":[{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"476f41e1feeed2d1f40d7bae317dd0f4e85814e8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"IloVirtualMediaAgentDriver to use an IloIPMIManagement interface which will"},{"line_number":31,"context_line":"implement the get_sensors_data interface to return both iLO reported health"},{"line_number":32,"context_line":"sensor information and IPMI sensor information.   The IloIPMIManagement"},{"line_number":33,"context_line":"interface will be derived from the existing IPMIManagement interface and the"},{"line_number":34,"context_line":"get_sensors_data interface will be implemented to call an iLO specific"},{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_1780a48a","line":33,"updated":"2014-10-10 05:18:48.000000000","message":"If only get_sensors_data needs IPMI call, can it be done without deriving it from IPMIManagement Interface ? As , all other management functions wouldn\u0027t be needing IPMI ( https://blueprints.launchpad.net/ironic/+spec/ilo-management-interface )","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"42b2c43872338da03928679b2a178134149bb7e8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"IloVirtualMediaAgentDriver to use an IloIPMIManagement interface which will"},{"line_number":31,"context_line":"implement the get_sensors_data interface to return both iLO reported health"},{"line_number":32,"context_line":"sensor information and IPMI sensor information.   The IloIPMIManagement"},{"line_number":33,"context_line":"interface will be derived from the existing IPMIManagement interface and the"},{"line_number":34,"context_line":"get_sensors_data interface will be implemented to call an iLO specific"},{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_c02baa31","line":33,"in_reply_to":"baa201ad_0c9ed356","updated":"2014-10-10 13:52:25.000000000","message":"Maybe this is how to approach what Anuhsa is getting at.  I\u0027ll take a look.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"42b2c43872338da03928679b2a178134149bb7e8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"IloVirtualMediaAgentDriver to use an IloIPMIManagement interface which will"},{"line_number":31,"context_line":"implement the get_sensors_data interface to return both iLO reported health"},{"line_number":32,"context_line":"sensor information and IPMI sensor information.   The IloIPMIManagement"},{"line_number":33,"context_line":"interface will be derived from the existing IPMIManagement interface and the"},{"line_number":34,"context_line":"get_sensors_data interface will be implemented to call an iLO specific"},{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_7561ded2","line":33,"in_reply_to":"baa201ad_1780a48a","updated":"2014-10-10 13:52:25.000000000","message":"If all the interfaces for IloManagment are iLO based, then get_sensors_data could be implemented without deriving it from IPMIManagment.   But, if we need to return IPMI based sensors from the iLO interface in addition to the iLO health sensors we still want to be able to invoke an IPMIManagment get_sensors_data interface so we don\u0027t have to replicate the functionality.    Derivation seems like a reasonable approach even if it is only for one interface.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"65ff5650e89cbe508b4200c861bd006e2150fec5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"IloVirtualMediaAgentDriver to use an IloIPMIManagement interface which will"},{"line_number":31,"context_line":"implement the get_sensors_data interface to return both iLO reported health"},{"line_number":32,"context_line":"sensor information and IPMI sensor information.   The IloIPMIManagement"},{"line_number":33,"context_line":"interface will be derived from the existing IPMIManagement interface and the"},{"line_number":34,"context_line":"get_sensors_data interface will be implemented to call an iLO specific"},{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_0c9ed356","line":33,"in_reply_to":"baa201ad_1780a48a","updated":"2014-10-10 11:32:05.000000000","message":"probably it\u0027s time to move some IPMI functions to smth like ironic.common.ipmi and just reuse them from drivers.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5f5a8b37bcb72b7678d9ef4b609c691c31630040","unresolved":false,"context_lines":[{"line_number":30,"context_line":"IloVirtualMediaAgentDriver to use an IloIPMIManagement interface which will"},{"line_number":31,"context_line":"implement the get_sensors_data interface to return both iLO reported health"},{"line_number":32,"context_line":"sensor information and IPMI sensor information.   The IloIPMIManagement"},{"line_number":33,"context_line":"interface will be derived from the existing IPMIManagement interface and the"},{"line_number":34,"context_line":"get_sensors_data interface will be implemented to call an iLO specific"},{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_e1999020","line":33,"in_reply_to":"baa201ad_7561ded2","updated":"2014-10-10 15:43:48.000000000","message":"\u003e if we need to return IPMI based sensors from the iLO interface in addition to the iLO health sensors\n\nwith your current suggestion about adding vendor to type name - you have to. otherwise you don\u0027t","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"476f41e1feeed2d1f40d7bae317dd0f4e85814e8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The IloIPMIManagement interface will return"},{"line_number":39,"context_line":"a sensor dictionary containing both the iLO and IPMI sensor information.  The"},{"line_number":40,"context_line":"sensor dictionary returned by get_sensors_data() will remain in the"},{"line_number":41,"context_line":"same base format that is currently defined for IPMI sensors.   In order to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_57306c07","line":38,"updated":"2014-10-10 05:18:48.000000000","message":"In case if this is the final naming , I would prefer IloManagement ( as it is now in code)  instead of IloIPMIManagement","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"9c9381ff9a5df3206d2bf1a28789738d31eff93c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The IloIPMIManagement interface will return"},{"line_number":39,"context_line":"a sensor dictionary containing both the iLO and IPMI sensor information.  The"},{"line_number":40,"context_line":"sensor dictionary returned by get_sensors_data() will remain in the"},{"line_number":41,"context_line":"same base format that is currently defined for IPMI sensors.   In order to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_a930609f","line":38,"in_reply_to":"baa201ad_57306c07","updated":"2014-10-10 05:42:13.000000000","message":"+1\nIf we did not run with IPMI, we should not have such special words.\n\nAnd another concern about ilo, I understand our ilo server supports ipmi commands also, if this is case, can we have ipmi implements for such sensor data handling?","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"65ff5650e89cbe508b4200c861bd006e2150fec5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The IloIPMIManagement interface will return"},{"line_number":39,"context_line":"a sensor dictionary containing both the iLO and IPMI sensor information.  The"},{"line_number":40,"context_line":"sensor dictionary returned by get_sensors_data() will remain in the"},{"line_number":41,"context_line":"same base format that is currently defined for IPMI sensors.   In order to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_8ca9e37d","line":38,"in_reply_to":"baa201ad_57306c07","updated":"2014-10-10 11:32:05.000000000","message":"+1 to IloManagement","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"42b2c43872338da03928679b2a178134149bb7e8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The IloIPMIManagement interface will return"},{"line_number":39,"context_line":"a sensor dictionary containing both the iLO and IPMI sensor information.  The"},{"line_number":40,"context_line":"sensor dictionary returned by get_sensors_data() will remain in the"},{"line_number":41,"context_line":"same base format that is currently defined for IPMI sensors.   In order to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_f5a4ee09","line":38,"in_reply_to":"baa201ad_57306c07","updated":"2014-10-10 13:52:25.000000000","message":"IloManagment works for me.   I\u0027ll make sure this is the final naming.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"42b2c43872338da03928679b2a178134149bb7e8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The IloIPMIManagement interface will return"},{"line_number":39,"context_line":"a sensor dictionary containing both the iLO and IPMI sensor information.  The"},{"line_number":40,"context_line":"sensor dictionary returned by get_sensors_data() will remain in the"},{"line_number":41,"context_line":"same base format that is currently defined for IPMI sensors.   In order to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_a016a6ef","line":38,"in_reply_to":"baa201ad_a930609f","updated":"2014-10-10 13:52:25.000000000","message":"IPMI doesn\u0027t provide the health information.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"9de713993dc8f3afe52a5da6ff52c2f6a374b22e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The IloIPMIManagement interface will return"},{"line_number":39,"context_line":"a sensor dictionary containing both the iLO and IPMI sensor information.  The"},{"line_number":40,"context_line":"sensor dictionary returned by get_sensors_data() will remain in the"},{"line_number":41,"context_line":"same base format that is currently defined for IPMI sensors.   In order to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_3172ea11","line":38,"in_reply_to":"baa201ad_f5a4ee09","updated":"2014-10-13 03:09:26.000000000","message":"Ok, make sense, that is fine with me, thanks for the response.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"65ff5650e89cbe508b4200c861bd006e2150fec5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"the driverID would be \"ilo.\".   The driverID must be [a-z] only and the"},{"line_number":46,"context_line":"dot postfix is used to delimit the driverID and the"},{"line_number":47,"context_line":"Sensor ID.   The following shows an example returned sensor dictionary with one"},{"line_number":48,"context_line":"Sensor Type from IPMI and one Sensor Type from iLO."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"::"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_6cdaff18","line":48,"updated":"2014-10-10 11:32:05.000000000","message":"Did you agree this with Ceilometer folks? https://blueprints.launchpad.net/ceilometer/+spec/generic-notification-sensor-meter-plugin does not seem to cover it. It\u0027s quite a large (and possibly breaking) change.\n\nAlso, I\u0027m not convinced you should do it. Fan speed should not be different. If you add something not provided by IPMI, it does not need prefix either. Could you provide some deeper reasoning?","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"5b7f449434786e7a3ea78872e97c530dbf2b0086","unresolved":false,"context_lines":[{"line_number":45,"context_line":"the driverID would be \"ilo.\".   The driverID must be [a-z] only and the"},{"line_number":46,"context_line":"dot postfix is used to delimit the driverID and the"},{"line_number":47,"context_line":"Sensor ID.   The following shows an example returned sensor dictionary with one"},{"line_number":48,"context_line":"Sensor Type from IPMI and one Sensor Type from iLO."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"::"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_0141340b","line":48,"in_reply_to":"baa201ad_000cd293","updated":"2014-10-10 15:22:40.000000000","message":"Changing the name from hardware.ipmi.temperature to hardware.temperature could certainly be done.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"42b2c43872338da03928679b2a178134149bb7e8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"the driverID would be \"ilo.\".   The driverID must be [a-z] only and the"},{"line_number":46,"context_line":"dot postfix is used to delimit the driverID and the"},{"line_number":47,"context_line":"Sensor ID.   The following shows an example returned sensor dictionary with one"},{"line_number":48,"context_line":"Sensor Type from IPMI and one Sensor Type from iLO."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"::"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_95a64252","line":48,"in_reply_to":"baa201ad_6cdaff18","updated":"2014-10-10 13:52:25.000000000","message":"There has been no agreement, this is more of a proposal on an approach.   I have communicated with the ceilometer team about issues with the current sensor meter naming from a meter name/resource ID perspective, not from a vendor specific perspective.  See: https://bugs.launchpad.net/bugs/1377157\n\nI would agree that the base information in a meter should not be fundamentally different between sensors of type Fan, Temperature, Voltage,  but the meta information is certainly different based on the sensor provider.  I wanted an easy way for a consumer of provider specific sensors to be able to lookup the provider specific sensors easily in ceilometer.    There are other approaches, like having a standard \u0027key\u0027 : \u0027value\u0027 name in the sensor metadata which you could use in a ceilometer query.   For example, identify the need for a \u0027Provider\u0027 : \u0027providername\u0027  at the same level as \u0027Sensor Reading\u0027 where providername is \u0027ipmi\u0027 or \u0027ilo\u0027.\n\nWith the current ceilometer naming, the generic Temperature don\u0027t appear generic when you look at them in  ceilometer, the sensors are named hardware.ipmi.Temperature.   Clearly having an ilo Temperature sample with meter name hardware.ipmi.Temperature doesn\u0027t seem very friendly.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"82f66824ecdd6f0abda11502602aa7fd528817d0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"the driverID would be \"ilo.\".   The driverID must be [a-z] only and the"},{"line_number":46,"context_line":"dot postfix is used to delimit the driverID and the"},{"line_number":47,"context_line":"Sensor ID.   The following shows an example returned sensor dictionary with one"},{"line_number":48,"context_line":"Sensor Type from IPMI and one Sensor Type from iLO."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"::"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_000cd293","line":48,"in_reply_to":"baa201ad_95a64252","updated":"2014-10-10 14:01:15.000000000","message":"\u003e hardware.ipmi.Temperature\n\nright it should be fixed to just hardware.Temperature","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"65ff5650e89cbe508b4200c861bd006e2150fec5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"solution."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"https://blueprints.launchpad.net/ironic/+spec/support-per-driver-sensor-meters"},{"line_number":96,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/generic-notification-sensor-meter-plugin"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_2c3e372a","line":95,"updated":"2014-10-10 11:32:05.000000000","message":"does it have a spec? I can\u0027t find it.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"42b2c43872338da03928679b2a178134149bb7e8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"solution."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"https://blueprints.launchpad.net/ironic/+spec/support-per-driver-sensor-meters"},{"line_number":96,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/generic-notification-sensor-meter-plugin"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_7580fe8b","line":95,"in_reply_to":"baa201ad_2c3e372a","updated":"2014-10-10 13:52:25.000000000","message":"I\u0027ll be putting together the other specs next week.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"65ff5650e89cbe508b4200c861bd006e2150fec5","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    identifier followed by the actual Sensor Type."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    * IPMI Sensor Types would be: ipmi.Temperature, ipmi.Fan, ..."},{"line_number":319,"context_line":"    * ILO Sensor Types would be : ilo.Temperature, ilo.Fan, ilo.Health,..."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":322,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_cc64cb4b","line":319,"updated":"2014-10-10 11:32:05.000000000","message":"how will ipmi.Temperature be different from ilo.Temperature? I\u0027m storngly for leaving them generic and standard, not vendor-specific.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"6ece78adf226985b7d080687aee6fa64b7b120f2","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    identifier followed by the actual Sensor Type."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    * IPMI Sensor Types would be: ipmi.Temperature, ipmi.Fan, ..."},{"line_number":319,"context_line":"    * ILO Sensor Types would be : ilo.Temperature, ilo.Fan, ilo.Health,..."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":322,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_33368be8","line":319,"in_reply_to":"baa201ad_21a47856","updated":"2014-10-10 16:30:05.000000000","message":"To play back what I think you are saying: \n It is the providers responsibility to create a provider specific key in the\n metadata to identify who provided the sample\n\nFrom my perspective, IPMI is a sensor provider, so there would be an \"ipmi_extras\" in addition to an \"ilo_extras\" key since these are two different providers.    IMO the only true generic per sample content is the ceilometer defined sample counter_unit and counter_volume.\n\nDoes this summary seem reasonable ? \n* There would be hardware.SensorType ceilometer named meters where the SensorType would be generic Temperature, Fan, Voltage, Current, Health, ....   Ceilometer would name sensor meters genrically as hardware.SensorType \n* The Resource ID for all the sensors in a given platform would be the Ironic Node UUID.\n* Each Sample would contain a provider key in the metadata indicating the actual provider of the sample.    For now, just { \u0027provider\u0027 : \u0027ipmi\u0027 } or { \u0027provider\u0027 : \u0027ilo\u0027 }\n\nI think something along these lines would work.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"c19768e943578fd757d6a633c48a1a1ae1a02b78","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    identifier followed by the actual Sensor Type."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    * IPMI Sensor Types would be: ipmi.Temperature, ipmi.Fan, ..."},{"line_number":319,"context_line":"    * ILO Sensor Types would be : ilo.Temperature, ilo.Fan, ilo.Health,..."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":322,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_54dd8a41","line":319,"in_reply_to":"baa201ad_22629ad8","updated":"2014-10-13 17:36:58.000000000","message":"I\u0027ve been do some prototyping of this strategy and I have some observations about the user experience with this naming structure.\n\nNaming all the sensors for all platforms in the ceilometer namespace as simply \u0027hardware.temperature\u0027, \u0027hardware.fan\u0027, etc along with the Ironic Node UUID as the Resource ID has some interesting issues.\n\nThis naming creates one meter in each platform named \u0027hardware.SensorType\u0027 and this meter will contain samples for every sensor of SensorType in the platform.   If there are two temperature sensors in a platform, each sample in meter \u0027hardware.temperature\u0027 for the platform will be for either temperature sensor 1 or temperature sensor 2.    Add in two different providers for sensor on the platform and you get 2 more samples.\n\nThis generic naming strategy for the meters puts a burden on the meter consumer to code up some kind of differentiation between individual samples.   I haven\u0027t been able to figure out a way to do this without some kind of understanding as to how the samples are gathered for sensors.\n\nI\u0027m back to wanting each sensor on a platform to be an individual ceilometer meter so it is easy for a sensor consumer to get all the samples for an  individual meter.    I think we should create Ceilometer meter names for sensors that contain a sensor identifier like this \u0027hardware.SensorType:SensorID\u0027.\n\nIf we name sensors uniquely by SensorID and we want to differentiate the \u0027provider\u0027 of a given sample for a sensor (using a metadata field) as proposed above, then it puts a constraint on every possible provider to use the same SensorID, (which may not be possible).\n\nNote that with \u0027SensorID\u0027 style naming, there will be a sample per \u0027provider\u0027 within a given sensor meter so a consumer that cares about the provider will need to have an understanding of how the samples are gathered for sensors.   Same issue I outlined above.\n\nThoughts, other ideas, ...?","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9bf3009ccd0c206bece49a4aec991fd8e85cde2c","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    identifier followed by the actual Sensor Type."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    * IPMI Sensor Types would be: ipmi.Temperature, ipmi.Fan, ..."},{"line_number":319,"context_line":"    * ILO Sensor Types would be : ilo.Temperature, ilo.Fan, ilo.Health,..."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":322,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_22629ad8","line":319,"in_reply_to":"baa201ad_33368be8","updated":"2014-10-13 07:34:19.000000000","message":"\u003e  IMO the only true generic per sample content is the ceilometer defined sample counter_unit and counter_volume.\n\n+1\n\n\u003e Does this summary seem reasonable ?\n\nYes, thanks! And if some driver wants to add something _really_ specific, it can be prefixed with driver name.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"82f66824ecdd6f0abda11502602aa7fd528817d0","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    identifier followed by the actual Sensor Type."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    * IPMI Sensor Types would be: ipmi.Temperature, ipmi.Fan, ..."},{"line_number":319,"context_line":"    * ILO Sensor Types would be : ilo.Temperature, ilo.Fan, ilo.Health,..."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":322,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_e0642e4b","line":319,"in_reply_to":"baa201ad_40c33a8a","updated":"2014-10-10 14:01:15.000000000","message":"\u003e The metadata certainly contains different, although similar information\nAnd it should be normalized to something common either by ipmi or by ilo driver. There can be vendor-specific metadata, but there should no be different temperatures. Temperature is not vendor-specific, you know ;)\n\n\u003e I really just want to have consistency in the ceilometer counter_name and resource_id for all sensors regardless of the sensor provider\n\nYou\u0027re doing the opposite IMO by making sensor types vendor-specific. Imagine I have a bunch of boxes and need to get temperature for them. I don\u0027t know the driver. What should I do?","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ba96a779dce975616ea9ea77e2b242e59c485a81","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    identifier followed by the actual Sensor Type."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    * IPMI Sensor Types would be: ipmi.Temperature, ipmi.Fan, ..."},{"line_number":319,"context_line":"    * ILO Sensor Types would be : ilo.Temperature, ilo.Fan, ilo.Health,..."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":322,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_a4ae8596","line":319,"in_reply_to":"baa201ad_54dd8a41","updated":"2014-10-13 19:06:23.000000000","message":"\u003e  I think we should create Ceilometer meter names for sensors that contain a sensor identifier like this \u0027hardware.SensorType:SensorID\u0027.\n\nSounds reasonable. Probably with fallback two just hardware.SensorType.\n\nI\u0027m still not sure why you assume that we\u0027ll have sensors data from different vendors for a node. Node can have only one management driver (say ilo) and thus SensorID will be consistent. What is wrong with this reasoning?\n\nP.S.\nI guess this discussion is already long enough to be brought to ML (if not to the summit). Mind summarizing it in email?","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"24a6449a747101e5f6b116648a6a04817f2206f0","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    identifier followed by the actual Sensor Type."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    * IPMI Sensor Types would be: ipmi.Temperature, ipmi.Fan, ..."},{"line_number":319,"context_line":"    * ILO Sensor Types would be : ilo.Temperature, ilo.Fan, ilo.Health,..."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":322,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_50982f1b","line":319,"in_reply_to":"baa201ad_a4ae8596","updated":"2014-10-13 21:22:04.000000000","message":"The only reason I was attempting to support sensor data coming from multiple providers (not vendors) was to provide one set of \"generic sensor information\" and one set of \"vendor sensor information\" for a given platform.    The \"generic sensor information\" would be IPMI and a consumer could rely on this set of sensor information being available across multiple vendor platforms even if a vendor implemented its own management interface to provide alternative sensor infromation.  The vendor specific sensor information would come from the vendor and could be used in addition to the \"generic sensor information\".\n\nI was not attempting to have the vendor specific sensor information replace the IPMI  \"generic sensor information\".  The current implementation of some ironic vendor specific drivers use the IPMI Management Interface get_sensors_data() instead of implementing their own so there is a precedence in the Juno release for the existence of IPMI sensor information coming from a vendor specific driver.\n\nIs this the kind of summary you were looking for?   If not, give me a little more detail (via email) about what you are looking for and I\u0027ll put something together for you.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"42b2c43872338da03928679b2a178134149bb7e8","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    identifier followed by the actual Sensor Type."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    * IPMI Sensor Types would be: ipmi.Temperature, ipmi.Fan, ..."},{"line_number":319,"context_line":"    * ILO Sensor Types would be : ilo.Temperature, ilo.Fan, ilo.Health,..."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":322,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_40c33a8a","line":319,"in_reply_to":"baa201ad_cc64cb4b","updated":"2014-10-10 13:52:25.000000000","message":"The main difference would be in how ceilometer names the meter and what a consumer of a meter sample could expect with regard to contents of the meter sample metadata.  The base sample information counter_unit, counter_volume would be similar.   Take a look at the above two examples I give of sample information for Temperature Sensor from IPMI vrs ILO on lines 118/153.    The metadata certainly contains different, although similar information.\n\nI really just want to have consistency in the ceilometer counter_name and resource_id for all sensors regardless of the sensor provider.   Right now, everything is IPMI centric even though the what is returned from get_sensors_data appears generic.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"5b7f449434786e7a3ea78872e97c530dbf2b0086","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    identifier followed by the actual Sensor Type."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    * IPMI Sensor Types would be: ipmi.Temperature, ipmi.Fan, ..."},{"line_number":319,"context_line":"    * ILO Sensor Types would be : ilo.Temperature, ilo.Fan, ilo.Health,..."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":322,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_e62fe6f4","line":319,"in_reply_to":"baa201ad_e0642e4b","updated":"2014-10-10 15:22:40.000000000","message":"If you have a bunch of boxes controlled by Ironic, you have the Ironic Node UUIDs for them.   With what I proposed as sensor meter naming conventions for ceilometer, you would query ceilometer for all the resources with a resource ID \u003d\u003d to the Ironic Node UUID.   This would get you a single resource containing links to every sensor on the Ironic Node, a small list acquired very quickly.    Then you would simply look for meters containing the name \"temperature\" (because you don\u0027t care about provider specific information).    If you cared about provider specific information you could look for a specific providers temperatures, like \"ipmi.temperature\" or \"ilo.temperature\".  \n\nFYI:  With what is going out with Juno, a sensor consumer is going to have search all hardware.ipmi.temperature meters in ceilometer for a specific metadata field which matches the Ironic Node UUID.\n\nNow, my approach above does bring up the issue that the consumer may want to be aware that there may be more than one sensor provider and make a choice on which providers information it wants to use, but its not a requirement for correct operation.   Certainly it would be ideal if there were only one set of sensor information per platform with no information replication.    But, different sensor providers can provide additional information about sensors than what IPMI can provide (via their metadata) even though the base information for the meter is exactly the same.","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5f5a8b37bcb72b7678d9ef4b609c691c31630040","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    identifier followed by the actual Sensor Type."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    * IPMI Sensor Types would be: ipmi.Temperature, ipmi.Fan, ..."},{"line_number":319,"context_line":"    * ILO Sensor Types would be : ilo.Temperature, ilo.Fan, ilo.Health,..."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":322,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_21a47856","line":319,"in_reply_to":"baa201ad_e62fe6f4","updated":"2014-10-10 15:43:48.000000000","message":"\u003e f you cared about provider specific information you could look for a specific providers temperatures, like \"ipmi.temperature\" or \"ilo.temperature\"\n\nIMO you should be finding vendor key like \u0027ilo_extras\u0027 under generic \u0027temperature\u0027","commit_id":"d37358534cf21352bb9e41f64e87984c36904b82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d4d7751b91ae1474b7ecc6d3b4921a6b8796316c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"sensor information and IPMI sensor information.   The IloManagement"},{"line_number":33,"context_line":"interface will be derived from the existing IPMIManagement interface and the"},{"line_number":34,"context_line":"get_sensors_data interface will be implemented to call an iLO specific"},{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Since a Management drivers get_sensors_data interface could return"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_50b04f8b","line":35,"updated":"2014-10-21 12:45:56.000000000","message":"why \"in addition\"? do they contain different data?","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"3e5e5b45296c17226cb6d8f97bbcccc724d2649f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"sensor information and IPMI sensor information.   The IloManagement"},{"line_number":33,"context_line":"interface will be derived from the existing IPMIManagement interface and the"},{"line_number":34,"context_line":"get_sensors_data interface will be implemented to call an iLO specific"},{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Since a Management drivers get_sensors_data interface could return"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_9b8493d5","line":35,"in_reply_to":"9aa7fdbe_50b04f8b","updated":"2014-10-21 16:06:04.000000000","message":"Yes the contain some different resource_metadata information, see \"Reported Temperature Sensor\" examples below in Alternatives Section.    There is a choice to be made as to whether the ILO driver just adds in health information (which is what I proposed here to maintain backward compatibility) or have ILO report all the sensor information it has from its health report.","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d4d7751b91ae1474b7ecc6d3b4921a6b8796316c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"This change will also affect the Ceilometer name for sensors.   With the"},{"line_number":64,"context_line":"\" (0x##)\" removed, you will see a name like the following,"},{"line_number":65,"context_line":"\"hardware.temperature.system_board\" instead of the current"},{"line_number":66,"context_line":"name of \"hardware.temperature.system_board_(0x16)\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The following are some example of iLO reported health information that will"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_909397f9","line":66,"updated":"2014-10-21 12:45:56.000000000","message":"Please split these 2 proposals into their own spec. The idea is to have one spec for general changes to all drivers and one for driver-specific things.","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"c2fbec584545a0f3e017965df6a63f73a1320e9f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"This change will also affect the Ceilometer name for sensors.   With the"},{"line_number":64,"context_line":"\" (0x##)\" removed, you will see a name like the following,"},{"line_number":65,"context_line":"\"hardware.temperature.system_board\" instead of the current"},{"line_number":66,"context_line":"name of \"hardware.temperature.system_board_(0x16)\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The following are some example of iLO reported health information that will"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_c1e1ceff","line":66,"in_reply_to":"9aa7fdbe_909397f9","updated":"2014-10-21 16:35:51.000000000","message":"I just realized while working on my conductor spec that this really needs to be in an Ironic spec.   Would it work to o put in the conductor support-per-driver-sensor-meters specification or does it need to be its own spec?","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"b7df7eb6341eda181a11444f0a564af457a40b9e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"This change will also affect the Ceilometer name for sensors.   With the"},{"line_number":64,"context_line":"\" (0x##)\" removed, you will see a name like the following,"},{"line_number":65,"context_line":"\"hardware.temperature.system_board\" instead of the current"},{"line_number":66,"context_line":"name of \"hardware.temperature.system_board_(0x16)\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The following are some example of iLO reported health information that will"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_8616f7a5","line":66,"in_reply_to":"9aa7fdbe_909397f9","updated":"2014-10-21 19:14:10.000000000","message":"I just submitted a blueprint for changing the ipmitool driver and I\u0027ll write up a spec with the details above for the change.    This change really didn\u0027t fit into any of the other specs I\u0027m currently working.\nhttps://blueprints.launchpad.net/ironic/+spec/change-ipmi-sensor-id-name","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"3e5e5b45296c17226cb6d8f97bbcccc724d2649f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"This change will also affect the Ceilometer name for sensors.   With the"},{"line_number":64,"context_line":"\" (0x##)\" removed, you will see a name like the following,"},{"line_number":65,"context_line":"\"hardware.temperature.system_board\" instead of the current"},{"line_number":66,"context_line":"name of \"hardware.temperature.system_board_(0x16)\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The following are some example of iLO reported health information that will"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_1b4fc3be","line":66,"in_reply_to":"9aa7fdbe_909397f9","updated":"2014-10-21 16:06:04.000000000","message":"I\u0027ll move this info to the ceilometer spec for the generic-notification-sensor-meter-plugin blueprint.","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d4d7751b91ae1474b7ecc6d3b4921a6b8796316c","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"* https://blueprints.launchpad.net/ironic/+spec/support-per-driver-sensor-meters"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"* https://blueprints.launchpad.net/ceilometer/+spec/generic-notification-sensor-meter-plugin"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"* This feature will require a functional change to the python proliantutils to"},{"line_number":328,"context_line":"  support the RIBCL command to get ProLiant platform health information."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_d0635f18","line":325,"updated":"2014-10-21 12:45:56.000000000","message":"Please provide a link to spec, not to launchpad blueprint. From the short summary in the blueprint I can\u0027t really tell, if it covers everything discussed on ML.","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"3e5e5b45296c17226cb6d8f97bbcccc724d2649f","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"* https://blueprints.launchpad.net/ironic/+spec/support-per-driver-sensor-meters"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"* https://blueprints.launchpad.net/ceilometer/+spec/generic-notification-sensor-meter-plugin"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"* This feature will require a functional change to the python proliantutils to"},{"line_number":328,"context_line":"  support the RIBCL command to get ProLiant platform health information."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_dbdb7beb","line":325,"in_reply_to":"9aa7fdbe_d0635f18","updated":"2014-10-21 16:06:04.000000000","message":"Now that I have agreement on the change with the ceilometer folks I\u0027ll write the spec and provide the link here.","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d4d7751b91ae1474b7ecc6d3b4921a6b8796316c","unresolved":false,"context_lines":[{"line_number":327,"context_line":"* This feature will require a functional change to the python proliantutils to"},{"line_number":328,"context_line":"  support the RIBCL command to get ProLiant platform health information."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  * The needed addition to proliantutils to support this is currently in review"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"Testing"},{"line_number":333,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_1045e76f","line":330,"updated":"2014-10-21 12:45:56.000000000","message":"Is it public? If so, please provide a link to PR/bug/whatever. Anyway, we\u0027ll need to document the minimal required version of proliantutils to use this feature.","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"3e5e5b45296c17226cb6d8f97bbcccc724d2649f","unresolved":false,"context_lines":[{"line_number":327,"context_line":"* This feature will require a functional change to the python proliantutils to"},{"line_number":328,"context_line":"  support the RIBCL command to get ProLiant platform health information."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  * The needed addition to proliantutils to support this is currently in review"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"Testing"},{"line_number":333,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_9b13b365","line":330,"in_reply_to":"9aa7fdbe_1045e76f","updated":"2014-10-21 16:06:04.000000000","message":"The proliantutils library is available via https://pypi.python.org/pypi/proliantutils/0.1.0 and the source is on github.     I provided my changes via patch to Nisha Agarwal and they have been accepted into their github repository.    I requested to Nisha that the revision get bumped and a new version be placed on pypi.python.org.   When I get confirmation from Nisha, I will add the version and repository info as you requested.   I\u0027ll also add the link pypi link above as well.","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d4d7751b91ae1474b7ecc6d3b4921a6b8796316c","unresolved":false,"context_lines":[{"line_number":335,"context_line":"Unit tests will be need to be added to verify the new code paths.   In order to"},{"line_number":336,"context_line":"verify correct operation of the full capabilities, ProLiant platform hardware"},{"line_number":337,"context_line":"will be necessary and for the time being this will have to accomplished through"},{"line_number":338,"context_line":"3rd party testing."},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"Upgrades and Backwards Compatibility"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_304aeb80","line":338,"updated":"2014-10-21 12:45:56.000000000","message":"What do you mean here? 3rdparty CI for ILO or your private testing?","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"3e5e5b45296c17226cb6d8f97bbcccc724d2649f","unresolved":false,"context_lines":[{"line_number":335,"context_line":"Unit tests will be need to be added to verify the new code paths.   In order to"},{"line_number":336,"context_line":"verify correct operation of the full capabilities, ProLiant platform hardware"},{"line_number":337,"context_line":"will be necessary and for the time being this will have to accomplished through"},{"line_number":338,"context_line":"3rd party testing."},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"Upgrades and Backwards Compatibility"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_36301ee8","line":338,"in_reply_to":"9aa7fdbe_304aeb80","updated":"2014-10-21 16:06:04.000000000","message":"I will be doing private testing and I\u0027m trying to get tied into any HP (3rd party from my perspective) testing that might be going on to verify other ILO capabilities already available in ironic.","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d4d7751b91ae1474b7ecc6d3b4921a6b8796316c","unresolved":false,"context_lines":[{"line_number":342,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"Removal of the \"_(0x##)\" from the sensor names could impact code which parses"},{"line_number":345,"context_line":"the names of sensors."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"Documentation Impact"},{"line_number":348,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_505e8f46","line":345,"updated":"2014-10-21 12:45:56.000000000","message":"+ bumping minimal version of proliantutils?","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"3e5e5b45296c17226cb6d8f97bbcccc724d2649f","unresolved":false,"context_lines":[{"line_number":342,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"Removal of the \"_(0x##)\" from the sensor names could impact code which parses"},{"line_number":345,"context_line":"the names of sensors."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"Documentation Impact"},{"line_number":348,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_7678e68f","line":345,"in_reply_to":"9aa7fdbe_505e8f46","updated":"2014-10-21 16:06:04.000000000","message":"Yes, when I have the new version # for proliantutils I will reference it here","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d4d7751b91ae1474b7ecc6d3b4921a6b8796316c","unresolved":false,"context_lines":[{"line_number":348,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"The only document that I know needs to be updated will be the"},{"line_number":351,"context_line":"ironic doc/source/deploy/intsall-guide.rst.   This  will need to be updated"},{"line_number":352,"context_line":"to document all customer visible changes associated with this work."},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_b055fb1e","line":351,"updated":"2014-10-21 12:45:56.000000000","message":"s/intsall/install/","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"3e5e5b45296c17226cb6d8f97bbcccc724d2649f","unresolved":false,"context_lines":[{"line_number":348,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"The only document that I know needs to be updated will be the"},{"line_number":351,"context_line":"ironic doc/source/deploy/intsall-guide.rst.   This  will need to be updated"},{"line_number":352,"context_line":"to document all customer visible changes associated with this work."},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_76ed4625","line":351,"in_reply_to":"9aa7fdbe_b055fb1e","updated":"2014-10-21 16:06:04.000000000","message":"done","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d4d7751b91ae1474b7ecc6d3b4921a6b8796316c","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"The only document that I know needs to be updated will be the"},{"line_number":351,"context_line":"ironic doc/source/deploy/intsall-guide.rst.   This  will need to be updated"},{"line_number":352,"context_line":"to document all customer visible changes associated with this work."},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"References"},{"line_number":355,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_cbff3200","line":352,"updated":"2014-10-21 12:45:56.000000000","message":"I think it will require separating enabling ceilometer metrics in general from IPMI-specific part in http://docs.openstack.org/developer/ironic/deploy/install-guide.html#ipmi-support","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"3e5e5b45296c17226cb6d8f97bbcccc724d2649f","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"The only document that I know needs to be updated will be the"},{"line_number":351,"context_line":"ironic doc/source/deploy/intsall-guide.rst.   This  will need to be updated"},{"line_number":352,"context_line":"to document all customer visible changes associated with this work."},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"References"},{"line_number":355,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_161b1a1c","line":352,"in_reply_to":"9aa7fdbe_cbff3200","updated":"2014-10-21 16:06:04.000000000","message":"I think it would be good to have a Sensor Metrics Logging Section with an IPMI and ILO subsection.","commit_id":"9a0365781c5025479aa7ed2839d88e0a4aaa951a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"df942f75327f761e7064eb9a93892d0e26306ba0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"set to a unique text value per driver.   For IPMI, the value will be \"ipmi\" and"},{"line_number":44,"context_line":"for the HP ilo driver, it will be \"ilo\".   Adding this key will require"},{"line_number":45,"context_line":"changing each driver that currently implement the get_sensors_data"},{"line_number":46,"context_line":"interface."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The following are some example of iLO reported health information that will"},{"line_number":49,"context_line":"be provided."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_e1ad96ea","line":46,"updated":"2014-10-24 11:03:30.000000000","message":"this should go to https://review.openstack.org/#/c/130074/ IMO (if it\u0027s not already there), because it\u0027s a generic change","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"938c24740d75f16db9be5cfbf9035fe243f17cbf","unresolved":false,"context_lines":[{"line_number":43,"context_line":"set to a unique text value per driver.   For IPMI, the value will be \"ipmi\" and"},{"line_number":44,"context_line":"for the HP ilo driver, it will be \"ilo\".   Adding this key will require"},{"line_number":45,"context_line":"changing each driver that currently implement the get_sensors_data"},{"line_number":46,"context_line":"interface."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The following are some example of iLO reported health information that will"},{"line_number":49,"context_line":"be provided."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_076705b8","line":46,"in_reply_to":"9aa7fdbe_e1ad96ea","updated":"2014-10-24 18:16:51.000000000","message":"Okay, I removed this paragraph from this doc and added it to the 130074 with some rework.","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"df942f75327f761e7064eb9a93892d0e26306ba0","unresolved":false,"context_lines":[{"line_number":237,"context_line":"consistent naming strategy for all sensors.    I submitted a Ceilometer and"},{"line_number":238,"context_line":"ironic bug with a proposed solution for sensor naming which resulted in"},{"line_number":239,"context_line":"a quick fix to Ceilometer for Juno leaving the remaining naming issues to"},{"line_number":240,"context_line":"be addressed separately.  See: https://bugs.launchpad.net/bugs/1377157"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Scalability impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_6189a674","line":240,"updated":"2014-10-24 11:03:30.000000000","message":"this is not related to this particular spec","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"938c24740d75f16db9be5cfbf9035fe243f17cbf","unresolved":false,"context_lines":[{"line_number":237,"context_line":"consistent naming strategy for all sensors.    I submitted a Ceilometer and"},{"line_number":238,"context_line":"ironic bug with a proposed solution for sensor naming which resulted in"},{"line_number":239,"context_line":"a quick fix to Ceilometer for Juno leaving the remaining naming issues to"},{"line_number":240,"context_line":"be addressed separately.  See: https://bugs.launchpad.net/bugs/1377157"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Scalability impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_1501f0ae","line":240,"in_reply_to":"9aa7fdbe_6189a674","updated":"2014-10-24 18:16:51.000000000","message":"Okay, I have removed the above from this specification.","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"df942f75327f761e7064eb9a93892d0e26306ba0","unresolved":false,"context_lines":[{"line_number":257,"context_line":"sensor information is currently conductor based.    I have no specific"},{"line_number":258,"context_line":"plans to change this, but as more drivers implement the ability to"},{"line_number":259,"context_line":"return sensor information, maybe the configuration options should"},{"line_number":260,"context_line":"be driver based."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"Developer impact"},{"line_number":263,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_a17f0e65","line":260,"updated":"2014-10-24 11:03:30.000000000","message":"ditto. you\u0027d better state how to enable ilo sensor metrics in Ironic","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"938c24740d75f16db9be5cfbf9035fe243f17cbf","unresolved":false,"context_lines":[{"line_number":257,"context_line":"sensor information is currently conductor based.    I have no specific"},{"line_number":258,"context_line":"plans to change this, but as more drivers implement the ability to"},{"line_number":259,"context_line":"return sensor information, maybe the configuration options should"},{"line_number":260,"context_line":"be driver based."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"Developer impact"},{"line_number":263,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_f0cc7a8b","line":260,"in_reply_to":"9aa7fdbe_a17f0e65","updated":"2014-10-24 18:16:51.000000000","message":"Done","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"df942f75327f761e7064eb9a93892d0e26306ba0","unresolved":false,"context_lines":[{"line_number":263,"context_line":"----------------"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"When this is implemented, the ironic conductor and the ironic Ceilometer"},{"line_number":266,"context_line":"notification plugin will need to be changed for this code to be enabled."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_218b1e69","line":266,"updated":"2014-10-24 11:03:30.000000000","message":"How exactly conductor should be changed? please state","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"938c24740d75f16db9be5cfbf9035fe243f17cbf","unresolved":false,"context_lines":[{"line_number":263,"context_line":"----------------"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"When this is implemented, the ironic conductor and the ironic Ceilometer"},{"line_number":266,"context_line":"notification plugin will need to be changed for this code to be enabled."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_10c65e68","line":266,"in_reply_to":"9aa7fdbe_218b1e69","updated":"2014-10-24 18:16:51.000000000","message":"Done","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"df942f75327f761e7064eb9a93892d0e26306ba0","unresolved":false,"context_lines":[{"line_number":285,"context_line":"  Ceilometer than can support sensors from more than one ironic driver"},{"line_number":286,"context_line":"  There is currently an ongoing discussion about this on the openstack-dev"},{"line_number":287,"context_line":"  mailing list titled \"[openstack-dev] [Ironic][Ceilometer] Proposed"},{"line_number":288,"context_line":"  Change to Sensor meter naming in Ceilometer\""},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":291,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_61f0c6fe","line":288,"updated":"2014-10-24 11:03:30.000000000","message":"this is not required to state, that spec is dependency of this one","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"938c24740d75f16db9be5cfbf9035fe243f17cbf","unresolved":false,"context_lines":[{"line_number":285,"context_line":"  Ceilometer than can support sensors from more than one ironic driver"},{"line_number":286,"context_line":"  There is currently an ongoing discussion about this on the openstack-dev"},{"line_number":287,"context_line":"  mailing list titled \"[openstack-dev] [Ironic][Ceilometer] Proposed"},{"line_number":288,"context_line":"  Change to Sensor meter naming in Ceilometer\""},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"* create an IloSensor class to encapsulate acquisition and conductor formatting"},{"line_number":291,"context_line":"  of iLO health information.   This class will implement the get_sensors_data"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_70a88a8d","line":288,"in_reply_to":"9aa7fdbe_61f0c6fe","updated":"2014-10-24 18:16:51.000000000","message":"I removed this.","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"df942f75327f761e7064eb9a93892d0e26306ba0","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"This work is dependent upon the acceptance of the following work."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"* https://blueprints.launchpad.net/ironic/+spec/support-per-driver-sensor-meters"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"* https://blueprints.launchpad.net/ceilometer/+spec/generic-notification-sensor-meter-plugin"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_e16676ec","line":304,"updated":"2014-10-24 11:03:30.000000000","message":"to additionally express dependency, please make this patch depend on https://review.openstack.org/#/c/130074/","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"938c24740d75f16db9be5cfbf9035fe243f17cbf","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"This work is dependent upon the acceptance of the following work."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"* https://blueprints.launchpad.net/ironic/+spec/support-per-driver-sensor-meters"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"* https://blueprints.launchpad.net/ceilometer/+spec/generic-notification-sensor-meter-plugin"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_b00f5287","line":304,"in_reply_to":"9aa7fdbe_e16676ec","updated":"2014-10-24 18:16:51.000000000","message":"Done","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"df942f75327f761e7064eb9a93892d0e26306ba0","unresolved":false,"context_lines":[{"line_number":311,"context_line":"support the RIBCL command to get ProLiant platform health information."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"* The needed addition to proliantutils to support this is currently in"},{"line_number":314,"context_line":"  review by Nisha Agarwal. https://pypi.python.org/pypi/proliantutils"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"Testing"},{"line_number":317,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_81a3eafe","line":314,"updated":"2014-10-24 11:03:30.000000000","message":"please don\u0027t forget to update it with the exact version, once change passes review.","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"938c24740d75f16db9be5cfbf9035fe243f17cbf","unresolved":false,"context_lines":[{"line_number":311,"context_line":"support the RIBCL command to get ProLiant platform health information."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"* The needed addition to proliantutils to support this is currently in"},{"line_number":314,"context_line":"  review by Nisha Agarwal. https://pypi.python.org/pypi/proliantutils"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"Testing"},{"line_number":317,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_f0239aba","line":314,"in_reply_to":"9aa7fdbe_81a3eafe","updated":"2014-10-24 18:16:51.000000000","message":"Okay","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"df942f75327f761e7064eb9a93892d0e26306ba0","unresolved":false,"context_lines":[{"line_number":326,"context_line":"This changes will have a dependency on an updated version of the proliantutils"},{"line_number":327,"context_line":"package and a version dependency could be added to the requirements.txt"},{"line_number":328,"context_line":"file.  Note: There is currently no requirements.txt dependency on"},{"line_number":329,"context_line":"proliantutils in Ironic."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"Each driver which relies on proliantutils attempts to load the proliantutils"},{"line_number":332,"context_line":"package using oslo.importutils.try_import at driver initilization time"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_e1dbd679","line":329,"updated":"2014-10-24 11:03:30.000000000","message":"and there won\u0027t be by the way. minimum version should be in the documentation","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"938c24740d75f16db9be5cfbf9035fe243f17cbf","unresolved":false,"context_lines":[{"line_number":326,"context_line":"This changes will have a dependency on an updated version of the proliantutils"},{"line_number":327,"context_line":"package and a version dependency could be added to the requirements.txt"},{"line_number":328,"context_line":"file.  Note: There is currently no requirements.txt dependency on"},{"line_number":329,"context_line":"proliantutils in Ironic."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"Each driver which relies on proliantutils attempts to load the proliantutils"},{"line_number":332,"context_line":"package using oslo.importutils.try_import at driver initilization time"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_90108e5a","line":329,"in_reply_to":"9aa7fdbe_e1dbd679","updated":"2014-10-24 18:16:51.000000000","message":"Okay, I updated to indicate required proliantutil version will be documented in drivers/ilo.rst","commit_id":"913ee8edfc9c8435f07affb39b3097fe52425491"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"960329f5da891099d2e9359a512fd5a3ec1f3556","unresolved":false,"context_lines":[{"line_number":317,"context_line":"and the driver will fail to load if the package cannot be imported.  The oslo"},{"line_number":318,"context_line":"try_import interface does not have any version checking capabilities, so the"},{"line_number":319,"context_line":"minimum version dependency will need to be resolved by reading documentation"},{"line_number":320,"context_line":"and updating proliantutils as necessary."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Documentation Impact"},{"line_number":323,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_cf798f83","line":320,"updated":"2014-11-24 16:29:05.000000000","message":"I\u0027m not sure what you mean by this. That whoever wants to use the ilo driver needs to make sure they have the right proliantutils library installed? The code itself will not check/do anything, or will raise exceptions or things won\u0027t work but it won\u0027t be obvious or ??\n\nWill things be backwards compatible or not, after upgrading to the latest proliantutils and using the code corresponding to this spec?","commit_id":"4123dd6c6d5f33fd5bb1af875abd2070ab9f49b8"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"6a7ada5a15f046ce9d2e7244c9a6b7c89b0e1f8e","unresolved":false,"context_lines":[{"line_number":317,"context_line":"and the driver will fail to load if the package cannot be imported.  The oslo"},{"line_number":318,"context_line":"try_import interface does not have any version checking capabilities, so the"},{"line_number":319,"context_line":"minimum version dependency will need to be resolved by reading documentation"},{"line_number":320,"context_line":"and updating proliantutils as necessary."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Documentation Impact"},{"line_number":323,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_8461263b","line":320,"in_reply_to":"5a890539_832cc003","updated":"2014-11-24 21:47:08.000000000","message":"I\u0027ve updated the doc per your suggestions.    I looked into minimal version checking, but the oslo.importutils library does not provide any run time version checking capabilities so some other mechanism would have to be used or developed.   This is outside the scope of what I am trying to accomplish and I would propose that,  if necessary, run time version checking work should be done as a separate development task.","commit_id":"4123dd6c6d5f33fd5bb1af875abd2070ab9f49b8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b7f00680bb53299e6888d386d8481a1533dfc206","unresolved":false,"context_lines":[{"line_number":317,"context_line":"and the driver will fail to load if the package cannot be imported.  The oslo"},{"line_number":318,"context_line":"try_import interface does not have any version checking capabilities, so the"},{"line_number":319,"context_line":"minimum version dependency will need to be resolved by reading documentation"},{"line_number":320,"context_line":"and updating proliantutils as necessary."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Documentation Impact"},{"line_number":323,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_5b1abcc6","line":320,"in_reply_to":"5a890539_8461263b","updated":"2014-11-24 22:08:34.000000000","message":"Yes, that is definitely outside the scope of this spec/feature. Thx.","commit_id":"4123dd6c6d5f33fd5bb1af875abd2070ab9f49b8"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"ed9e3a9b43a5664dfff12857d100d653db85a9f4","unresolved":false,"context_lines":[{"line_number":317,"context_line":"and the driver will fail to load if the package cannot be imported.  The oslo"},{"line_number":318,"context_line":"try_import interface does not have any version checking capabilities, so the"},{"line_number":319,"context_line":"minimum version dependency will need to be resolved by reading documentation"},{"line_number":320,"context_line":"and updating proliantutils as necessary."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Documentation Impact"},{"line_number":323,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_d5092285","line":320,"in_reply_to":"5a890539_cf798f83","updated":"2014-11-24 17:57:47.000000000","message":"The required proliantutils version is documented in the ilo documentation, doc/source/drivers/ilo.rst.    If you install a proliantutil version lower than what is specified in this documentation, the ilo drivers dependent on proliantutils will fail in unspecified ways.   The proliantutils library changes I make will be backward compatible with the currently released proliantutils 0.1.1 and this will be documented in the ilo.rst documentation.","commit_id":"4123dd6c6d5f33fd5bb1af875abd2070ab9f49b8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c8c3bf298cea03bf1f181a738d2fb6a7db63f92a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"and the driver will fail to load if the package cannot be imported.  The oslo"},{"line_number":318,"context_line":"try_import interface does not have any version checking capabilities, so the"},{"line_number":319,"context_line":"minimum version dependency will need to be resolved by reading documentation"},{"line_number":320,"context_line":"and updating proliantutils as necessary."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Documentation Impact"},{"line_number":323,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_832cc003","line":320,"in_reply_to":"5a890539_d5092285","updated":"2014-11-24 18:46:07.000000000","message":"Thx for clarifying. Perhaps you could add a link to [1] in the first paragraph, and refer to it in the 2nd paragraph. And mention something like \u0027Since the code doesn\u0027t check for a minimally-required version of proliantutils, the ilo driver will fail in unspecified ways if the proliantutils package is less than 0.1.1. It is the responsibility of the user to read the documentation [1] and install/upgrade the proliantutils package.\n\nwrt backwards compatibility. I didn\u0027t read the other specs; assuming the other specs can handle backwards compatibilility, I guess this one will too since it is adding more sensor info, not changing any of the existing sensor info that is/could be emitted?\n\nAs an aside. A suggestion -- maybe add something in the code (and proliantutils library) to detect if the library is less than the mimimal version needed, and if so, to log an error. I don\u0027t think it is a good user experience for the driver to fail in unexpected ways :-(\n\n[1] http://docs.openstack.org/developer/ironic/drivers/ilo.html?highlight\u003dilo#prerequisites","commit_id":"4123dd6c6d5f33fd5bb1af875abd2070ab9f49b8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"f973b6f03415d5c073274e369df7ab5e0a8030d3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"IloVirtualMediaAgentDriver to use an IloManagement interface which will"},{"line_number":31,"context_line":"implement the get_sensors_data interface to return both iLO reported health"},{"line_number":32,"context_line":"sensor information and IPMI sensor information.  The IloManagement interface"},{"line_number":33,"context_line":"will be derived from the existing IPMIManagement interface and the"},{"line_number":34,"context_line":"get_sensors_data interface will be implemented to call an iLO specific"},{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."}],"source_content_type":"text/x-rst","patch_set":6,"id":"da86d52c_7e3c22e3","line":33,"updated":"2015-02-03 08:33:16.000000000","message":"Why to derive from IPMIManagement? Can directly call IPMI method as specified in https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/management.py#L164 . Deriving is not necessary in my opinion.","commit_id":"f654e5fb213dc6e888c2c6930f13f8c93cf342f9"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"a20239a0d144dc12c3c073c0f96afa8fe4032a0b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"IloVirtualMediaAgentDriver to use an IloManagement interface which will"},{"line_number":31,"context_line":"implement the get_sensors_data interface to return both iLO reported health"},{"line_number":32,"context_line":"sensor information and IPMI sensor information.  The IloManagement interface"},{"line_number":33,"context_line":"will be derived from the existing IPMIManagement interface and the"},{"line_number":34,"context_line":"get_sensors_data interface will be implemented to call an iLO specific"},{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."}],"source_content_type":"text/x-rst","patch_set":6,"id":"da86d52c_44402d07","line":33,"in_reply_to":"da86d52c_7e3c22e3","updated":"2015-02-04 14:09:16.000000000","message":"It could be done without deriving from IPMIManagment, but this would require instantiating an new ipmitool.IPMIManagment() interface on every get_sensor_data() invocation instead of instantiating a single IPMIManagment() interface when the IloManagment() interface is instantiated.    I believe using derivation would always be better from a performance perspective.","commit_id":"f654e5fb213dc6e888c2c6930f13f8c93cf342f9"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"f973b6f03415d5c073274e369df7ab5e0a8030d3","unresolved":false,"context_lines":[{"line_number":270,"context_line":"  of iLO health information.  This class will implement the get_sensors_data"},{"line_number":271,"context_line":"  interface which will be used by the IloManagement class"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"* Create an IloManagement class which is derived from the IloManagement"},{"line_number":274,"context_line":"  class.  This class will instantiate an IloSensor class during"},{"line_number":275,"context_line":"  initialization the resulting instantiated class will be used to acquire iLO"},{"line_number":276,"context_line":"  sensor information in its get_sensors_data interface."}],"source_content_type":"text/x-rst","patch_set":6,"id":"da86d52c_61d72324","line":273,"updated":"2015-02-03 08:33:16.000000000","message":"you meant IPMIManagement?  But still not sure if its required though","commit_id":"f654e5fb213dc6e888c2c6930f13f8c93cf342f9"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"a20239a0d144dc12c3c073c0f96afa8fe4032a0b","unresolved":false,"context_lines":[{"line_number":270,"context_line":"  of iLO health information.  This class will implement the get_sensors_data"},{"line_number":271,"context_line":"  interface which will be used by the IloManagement class"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"* Create an IloManagement class which is derived from the IloManagement"},{"line_number":274,"context_line":"  class.  This class will instantiate an IloSensor class during"},{"line_number":275,"context_line":"  initialization the resulting instantiated class will be used to acquire iLO"},{"line_number":276,"context_line":"  sensor information in its get_sensors_data interface."}],"source_content_type":"text/x-rst","patch_set":6,"id":"da86d52c_c46a5d80","line":273,"in_reply_to":"da86d52c_61d72324","updated":"2015-02-04 14:09:16.000000000","message":"Fixed in next version","commit_id":"f654e5fb213dc6e888c2c6930f13f8c93cf342f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"432c8b0ac96a282f80fd66c589302134d2fd1134","unresolved":false,"context_lines":[{"line_number":289,"context_line":"      https://review.openstack.org/#/c/130359/"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"* https://blueprints.launchpad.net/ironic/+spec/change-ipmi-sensor-id-name"},{"line_number":292,"context_line":"      https://review.openstack.org/#/c/130070/"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"This feature will require a functional change to the python proliantutils to"},{"line_number":295,"context_line":"support the RIBCL command to get ProLiant platform health information."}],"source_content_type":"text/x-rst","patch_set":7,"id":"da86d52c_0092cf4a","line":292,"updated":"2015-02-17 11:35:40.000000000","message":"Are these 2 still requirements? IF they are, we can\u0027t merge this one, right?","commit_id":"7a7c55fc63c424cf9aee3e82d7f515b229427824"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"ce14d59f2b22b16bff219659b58a2693ba534454","unresolved":false,"context_lines":[{"line_number":289,"context_line":"      https://review.openstack.org/#/c/130359/"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"* https://blueprints.launchpad.net/ironic/+spec/change-ipmi-sensor-id-name"},{"line_number":292,"context_line":"      https://review.openstack.org/#/c/130070/"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"This feature will require a functional change to the python proliantutils to"},{"line_number":295,"context_line":"support the RIBCL command to get ProLiant platform health information."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba7be1f8_53ef6e87","line":292,"in_reply_to":"da86d52c_0092cf4a","updated":"2015-02-22 17:27:33.000000000","message":"The change-ipmi-sensor-id name cannot be done due to compatibility issues, see the spec and associated  comments for details.   As such, it is no longer a valid dependency, so I removed it.    The other two are still dependencies which need to be managed in order to implement a complete solution.   This work","commit_id":"7a7c55fc63c424cf9aee3e82d7f515b229427824"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"432c8b0ac96a282f80fd66c589302134d2fd1134","unresolved":false,"context_lines":[{"line_number":295,"context_line":"support the RIBCL command to get ProLiant platform health information."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"* The needed addition to proliantutils to support this is currently in"},{"line_number":298,"context_line":"  review by Nisha Agarwal. https://pypi.python.org/pypi/proliantutils"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"Testing"},{"line_number":301,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da86d52c_2099936e","line":298,"updated":"2015-02-17 11:35:40.000000000","message":"Were this addition done already? If not, do you have a link to PR?","commit_id":"7a7c55fc63c424cf9aee3e82d7f515b229427824"},{"author":{"_account_id":13448,"name":"Jim Mankovich","email":"jmank@hpe.com","username":"jmank"},"change_message_id":"ce14d59f2b22b16bff219659b58a2693ba534454","unresolved":false,"context_lines":[{"line_number":295,"context_line":"support the RIBCL command to get ProLiant platform health information."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"* The needed addition to proliantutils to support this is currently in"},{"line_number":298,"context_line":"  review by Nisha Agarwal. https://pypi.python.org/pypi/proliantutils"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"Testing"},{"line_number":301,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba7be1f8_b3d50abb","line":298,"in_reply_to":"ba7be1f8_13743298","updated":"2015-02-22 17:27:33.000000000","message":"I\u0027ve updated the doc to reflect Nisha Comment about prolianutils.","commit_id":"7a7c55fc63c424cf9aee3e82d7f515b229427824"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"754ba2455b3e11c48d1c492ce42c4b1cf920d99c","unresolved":false,"context_lines":[{"line_number":295,"context_line":"support the RIBCL command to get ProLiant platform health information."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"* The needed addition to proliantutils to support this is currently in"},{"line_number":298,"context_line":"  review by Nisha Agarwal. https://pypi.python.org/pypi/proliantutils"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"Testing"},{"line_number":301,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba7be1f8_13743298","line":298,"in_reply_to":"da86d52c_2099936e","updated":"2015-02-20 17:51:18.000000000","message":"DMitry, these are part of proliantutils pypi package, under kilo branch. additionally as proliantutils is on stackforge now , these changes will reflect there too.","commit_id":"7a7c55fc63c424cf9aee3e82d7f515b229427824"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"6c92b4dc29b43ea38d98d972c07ddf6d181564db","unresolved":false,"context_lines":[{"line_number":289,"context_line":"      https://review.openstack.org/#/c/130359/"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"This feature will require a functional change to the python proliantutils to"},{"line_number":292,"context_line":"support the RIBCL command to get ProLiant platform health information."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"* Per Nisha Agarwal, these changes are now part of the proliutils pypi package,"},{"line_number":295,"context_line":"  under the kilo branch, and these changes to prolianutils will be reflected"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a80dd14_838d3a7e","line":292,"updated":"2015-03-04 18:54:02.000000000","message":"for my understanding: is this still needed. the item below seems to say its done?","commit_id":"5e619f244a5b09633970f451b69a16f5b7ef6f55"}],"specs/liberty/send-ilo-health-metrics-to-ceilometer.rst":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1485d010fc0ab4d87bcc668eb11c7f0ca41cc62c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Send iLO health metrics to Ceilometer"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/send-ilo-health-metrics-to-ceilometer"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint is for the implementation of an iLO ManagementInterface which"},{"line_number":14,"context_line":"will implement a get_sensors_data method to collect platform health"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a7e1126_0960b0cd","line":11,"updated":"2015-12-17 12:15:46.000000000","message":"Hi, when you\u0027re going to update this, please change this link to RFE bug 1526757 and use it to track progress.","commit_id":"e4e6932d6a95c85bb9bad3948e31e989bda13160"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4c5f97943ec82867a7520e73c75e831c10dc9174","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/send-ilo-health-metrics-to-ceilometer"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint is for the implementation of an iLO ManagementInterface which"},{"line_number":14,"context_line":"will implement a get_sensors_data method to collect platform health"},{"line_number":15,"context_line":"information from iLO via RIBCL."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_c5e1109c","line":13,"updated":"2015-04-22 15:13:12.000000000","message":"IloManagementInterface is already there.  May be you just need to modify the get_sensors_data() in it.","commit_id":"e4e6932d6a95c85bb9bad3948e31e989bda13160"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4c5f97943ec82867a7520e73c75e831c10dc9174","unresolved":false,"context_lines":[{"line_number":30,"context_line":"IloVirtualMediaAgentDriver to use an IloManagement interface which will"},{"line_number":31,"context_line":"implement the get_sensors_data interface to return both iLO reported health"},{"line_number":32,"context_line":"sensor information and IPMI sensor information.  The IloManagement interface"},{"line_number":33,"context_line":"will be derived from the existing IPMIManagement interface and the"},{"line_number":34,"context_line":"get_sensors_data interface will be implemented to call an iLO specific"},{"line_number":35,"context_line":"get_sensors_data implementation in addition to calling the IPMIManagement"},{"line_number":36,"context_line":"get_sensors_data interface."}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_e5fd343b","line":33,"updated":"2015-04-22 15:13:12.000000000","message":"Can we just create a new IPMIManagement object here and use it - just like we do here - https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/management.py#L228-L230","commit_id":"e4e6932d6a95c85bb9bad3948e31e989bda13160"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4c5f97943ec82867a7520e73c75e831c10dc9174","unresolved":false,"context_lines":[{"line_number":275,"context_line":"  of iLO health information.  This class will implement the get_sensors_data"},{"line_number":276,"context_line":"  interface which will be used by the IloManagement class"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"* Create an IloManagement class which is derived from the IPMIManagment"},{"line_number":279,"context_line":"  class.  This class will instantiate an IloSensor class during"},{"line_number":280,"context_line":"  initialization the resulting instantiated class will be used to acquire iLO"},{"line_number":281,"context_line":"  sensor information in its get_sensors_data interface."}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_7778b98f","line":278,"updated":"2015-04-22 15:13:12.000000000","message":"It\u0027s not derived from IPMIManagement anymore.","commit_id":"e4e6932d6a95c85bb9bad3948e31e989bda13160"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4c5f97943ec82867a7520e73c75e831c10dc9174","unresolved":false,"context_lines":[{"line_number":296,"context_line":"This feature will require a functional change to the python proliantutils to"},{"line_number":297,"context_line":"support the RIBCL command to get ProLiant platform health information."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"* Per Nisha Agarwal, these changes are now part of the proliutils pypi package,"},{"line_number":300,"context_line":"  under the kilo branch, and these changes to prolianutils will be reflected"},{"line_number":301,"context_line":"  on the new proliantutils stackforge project."},{"line_number":302,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_f8982dc2","line":299,"updated":"2015-04-22 15:13:12.000000000","message":"These changes are already in stackforge/proliantutils.\n\nhttps://review.openstack.org/#/c/158041/","commit_id":"e4e6932d6a95c85bb9bad3948e31e989bda13160"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4c5f97943ec82867a7520e73c75e831c10dc9174","unresolved":false,"context_lines":[{"line_number":323,"context_line":"try_import interface does not provide any version checking capabilities, so it"},{"line_number":324,"context_line":"is the responsiblity of the user to read the documentation (see link above) and"},{"line_number":325,"context_line":"install/upgrade the proliantutils package to the minimum version specified.  If"},{"line_number":326,"context_line":"the incorrect minimum version of prolianutils is installed, the ilo drivers"},{"line_number":327,"context_line":"will fail in unspecified ways."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_5865d9b2","line":326,"updated":"2015-04-22 15:13:12.000000000","message":"We can check if ilo_object throws attribute error when trying to call the health related methods.  If it throws attribute error, we can throw meaningful error message to use.  We have done this in cleaning.\n\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/management.py#L85-L92","commit_id":"e4e6932d6a95c85bb9bad3948e31e989bda13160"}]}