)]}'
{"specs/kilo/maintenance-reason.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bf25ed4e944e2d9fb47b5018407d30ca962413bd","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* A new API endpoint should be added to more easily manage maintenance mode."},{"line_number":41,"context_line":"  This endpoint can toggle maintenance mode on or off, with an optional"},{"line_number":42,"context_line":"  reason for \u0027on\u0027, and clearing the reason when toggled \u0027off\u0027."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_f4c31788","line":42,"updated":"2014-10-20 15:03:05.000000000","message":"What about changing maintenance via update API? still allowed? will it clean/set maintenance reason?","commit_id":"6fc248d2bf3f46a19539941359cd603051868c0e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0687e27e16953770b00f00a1e703cb89f1d85e4c","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* A new API endpoint should be added to more easily manage maintenance mode."},{"line_number":41,"context_line":"  This endpoint can toggle maintenance mode on or off, with an optional"},{"line_number":42,"context_line":"  reason for \u0027on\u0027, and clearing the reason when toggled \u0027off\u0027."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_2fb9ca2e","line":42,"in_reply_to":"9aa7fdbe_f4c31788","updated":"2014-10-20 15:27:35.000000000","message":"We still have to, to avoid breaking the existing API contract. IMO it should leave maintenance_reason alone (unless also explicitly updated).","commit_id":"6fc248d2bf3f46a19539941359cd603051868c0e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0687e27e16953770b00f00a1e703cb89f1d85e4c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"automatically set a maintenance reason when putting a node into maintenance"},{"line_number":51,"context_line":"mode. Work would need to be done to make Ironic notify the operator or"},{"line_number":52,"context_line":"integrate with the other system; and possibly cause the operator to do manual"},{"line_number":53,"context_line":"work to put the reason in the other system."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Data model impact"},{"line_number":56,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_2f90ea94","line":53,"updated":"2014-10-20 15:27:35.000000000","message":"Honestly this could even be an integration point with an existing CMDB: the ability to put a URL to a ticket # or something similar in maintenance_reason would be incredibly useful in integrating with existing tooling.","commit_id":"6fc248d2bf3f46a19539941359cd603051868c0e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0687e27e16953770b00f00a1e703cb89f1d85e4c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"This will add a `maintenance_reason` field to the `node` table, with an"},{"line_number":59,"context_line":"accompanying database migration. This field will default to NULL, which will"},{"line_number":60,"context_line":"also be the value when the node is not in maintenance mode, or there is no"},{"line_number":61,"context_line":"reason."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"REST API impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_4fe44e3b","line":61,"updated":"2014-10-20 15:27:35.000000000","message":"Given this, I ask Dmitry\u0027s question again slightly differently:\n\nif I do\n\n# ironic node-update UUID replace maintenance\u003dfalse\n\nWill Ironic automatically clear maintenance_reason?","commit_id":"6fc248d2bf3f46a19539941359cd603051868c0e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cc01b6fc1bcad2d30f506d4e2d932a02bc5696d9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"This will add a `maintenance_reason` field to the `node` table, with an"},{"line_number":59,"context_line":"accompanying database migration. This field will default to NULL, which will"},{"line_number":60,"context_line":"also be the value when the node is not in maintenance mode, or there is no"},{"line_number":61,"context_line":"reason."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"REST API impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa7fdbe_ef942246","line":61,"in_reply_to":"9aa7fdbe_4fe44e3b","updated":"2014-10-20 15:33:38.000000000","message":"My answer would be yes. Otherwise we may easily end up with wrong maintenance reason. Consider:\n\n ironic node-set-maintenance-mode on \"Some reason.\"\n ironic node-update UUID replace maintenance\u003dfalse\n ironic node-update UUID replace maintenance\u003dtrue\n\nReason is still \"Some reason\", though it\u0027s wrong.","commit_id":"6fc248d2bf3f46a19539941359cd603051868c0e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba0524d77991769c3344f884be9f1409e6447a85","unresolved":false,"context_lines":[{"line_number":121,"context_line":"RPC API impact"},{"line_number":122,"context_line":"--------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"None."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Driver API impact"},{"line_number":127,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_f157a400","line":124,"updated":"2014-10-20 16:27:02.000000000","message":"Does this change affect the RPC API? We\u0027ll need a new version?","commit_id":"2158f51d5a3de65091a64013eeebfa9832112f69"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9389b9eaaa06addad273e0b2df4d1b0e66cb4311","unresolved":false,"context_lines":[{"line_number":121,"context_line":"RPC API impact"},{"line_number":122,"context_line":"--------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"None."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Driver API impact"},{"line_number":127,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_b12c3c4c","line":124,"in_reply_to":"9aa7fdbe_f157a400","updated":"2014-10-20 16:32:22.000000000","message":"Right now no because the new API endpoint will invoke update_node(). But I see a RPC method being created in the future once we do more things than updating the DB, for e.g signalizing other services like Nova that the node is now in maintenance mode and should be removed immediately from the list of available nodes.","commit_id":"2158f51d5a3de65091a64013eeebfa9832112f69"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba0524d77991769c3344f884be9f1409e6447a85","unresolved":false,"context_lines":[{"line_number":216,"context_line":"still use the node.update call to set maintenance on or off."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"To avoid having an outdated maintenance reason, using the node.update call"},{"line_number":219,"context_line":"to set maintenance mode off will clear the maintenance reason."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_f1a5e404","line":219,"updated":"2014-10-20 16:27:02.000000000","message":"Are we going to deprecate node.update for modifying maintenance mode?","commit_id":"2158f51d5a3de65091a64013eeebfa9832112f69"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9389b9eaaa06addad273e0b2df4d1b0e66cb4311","unresolved":false,"context_lines":[{"line_number":216,"context_line":"still use the node.update call to set maintenance on or off."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"To avoid having an outdated maintenance reason, using the node.update call"},{"line_number":219,"context_line":"to set maintenance mode off will clear the maintenance reason."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9aa7fdbe_31ce8c84","line":219,"in_reply_to":"9aa7fdbe_f1a5e404","updated":"2014-10-20 16:32:22.000000000","message":"I think we should","commit_id":"2158f51d5a3de65091a64013eeebfa9832112f69"}]}