)]}'
{"specs/backlog/iscsi-ilo-share-boot-images.rst":[{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"0c36765b526a4e6ab0201d0bd4781a7609e71d32","unresolved":false,"context_lines":[{"line_number":20,"context_line":"the deploy.  It builds separate boot images for each instance, even though"},{"line_number":21,"context_line":"instances deployed with same image might be using the same boot files and"},{"line_number":22,"context_line":"same kernel command-line arguments. This leads to the wastage of storage"},{"line_number":23,"context_line":"space in Swift, when it can be more efficiently utilized."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_06422c68","line":23,"updated":"2014-12-05 23:55:19.000000000","message":"This will be applicable to agent-ilo driver as well as we plan to support partition image for agent-driver.  My sugestion is to extend the scope of this spec for iLO virtula media drivers.","commit_id":"8b465440fb6c6181aa7b4fc822056f520fa014ea"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7401ba0980b37fe54403d6dd42838b1ee314d74d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"the deploy.  It builds separate boot images for each instance, even though"},{"line_number":21,"context_line":"instances deployed with same image might be using the same boot files and"},{"line_number":22,"context_line":"same kernel command-line arguments. This leads to the wastage of storage"},{"line_number":23,"context_line":"space in Swift, when it can be more efficiently utilized."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_73148fe9","line":23,"in_reply_to":"5a890539_06422c68","updated":"2014-12-06 05:37:26.000000000","message":"The change proposed is generic and will be reused by agent_ilo driver if it supports partition images.  But I can make a reference to that.","commit_id":"8b465440fb6c6181aa7b4fc822056f520fa014ea"}],"specs/kilo/ilo-drivers-share-boot-images.rst":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"61475f1e430437daecbdec6f18167ffed0890c53","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Scalability impact"},{"line_number":114,"context_line":"------------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"iLO driver(s) will consume lesser space for boot images than before."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Performance Impact"},{"line_number":119,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_974b5586","line":116,"updated":"2014-12-10 17:56:14.000000000","message":"nit: /lesser/less/","commit_id":"39ef11211547db50f60c74c8c7c9771012778aae"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2e638ccf9f616192388afd85b116b4b77d814043","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Scalability impact"},{"line_number":114,"context_line":"------------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"iLO driver(s) will consume lesser space for boot images than before."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Performance Impact"},{"line_number":119,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_3c6fd62c","line":116,"in_reply_to":"3a961159_974b5586","updated":"2014-12-11 04:58:41.000000000","message":"Done","commit_id":"39ef11211547db50f60c74c8c7c9771012778aae"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"03f2b6dedd5db94268a43ce1cb9b0552cf58a05f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Enable boot images sharing for iLO driver(s)"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/iscsi-ilo-share-boot-images"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change is to enable ``iscsi_ilo`` driver to share the boot images so"},{"line_number":14,"context_line":"that the storage space can be efficiently utilized. The same change may be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_1a725ae3","line":11,"updated":"2014-12-17 16:28:27.000000000","message":"This file name and the launchpad URL should match (I\u0027m not sure why but it is mentioned in the template. Maybe cuz some scripts assume this in order to do their magic.)","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"df61ac34f18e0b291a34b73cbc2c86168c59cee4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Enable boot images sharing for iLO driver(s)"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/iscsi-ilo-share-boot-images"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change is to enable ``iscsi_ilo`` driver to share the boot images so"},{"line_number":14,"context_line":"that the storage space can be efficiently utilized. The same change may be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_552af390","line":11,"in_reply_to":"3a961159_1a725ae3","updated":"2014-12-17 16:43:45.000000000","message":"Done. Will fix this.","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"03f2b6dedd5db94268a43ce1cb9b0552cf58a05f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  Swift object to indicate how many instances are using the boot ISO."},{"line_number":45,"context_line":"  Everytime a new instance is using the boot ISO, it is incremented, and when"},{"line_number":46,"context_line":"  a node is teared down, it is decremented. When ``reference_count`` becomes"},{"line_number":47,"context_line":"  0, the Swift object is removed."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* A lock is acquired by the thread during deploy or tear_down when handling"},{"line_number":50,"context_line":"  with the boot ISO - creating boot ISO and/or manipulating"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_75ba8fe2","line":47,"updated":"2014-12-17 16:28:27.000000000","message":"So the \u0027reference_count\u0027 is part of Swift, and Swift knows to remove the object when this is 0? Ironic doesn\u0027t have to tell Swift to delete it?\n\nI was wondering about why we care to delete the object if it isn\u0027t being used. It could be used again in the future? Or maybe we leave that cleanup for an operator to do. On the other hand, since Ironic adds it, I guess it should delete it too. ... umm, I don\u0027t know that this spec explicitly says that Ironic is adding the image to swift but I assume it is ;)","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5b0bb9333154737affa49d44d8352370cf9d3f89","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  Swift object to indicate how many instances are using the boot ISO."},{"line_number":45,"context_line":"  Everytime a new instance is using the boot ISO, it is incremented, and when"},{"line_number":46,"context_line":"  a node is teared down, it is decremented. When ``reference_count`` becomes"},{"line_number":47,"context_line":"  0, the Swift object is removed."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* A lock is acquired by the thread during deploy or tear_down when handling"},{"line_number":50,"context_line":"  with the boot ISO - creating boot ISO and/or manipulating"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_62139e0d","line":47,"in_reply_to":"3a961159_362f2e40","updated":"2014-12-18 07:35:42.000000000","message":"Done. Added this in alternatives.","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"df61ac34f18e0b291a34b73cbc2c86168c59cee4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  Swift object to indicate how many instances are using the boot ISO."},{"line_number":45,"context_line":"  Everytime a new instance is using the boot ISO, it is incremented, and when"},{"line_number":46,"context_line":"  a node is teared down, it is decremented. When ``reference_count`` becomes"},{"line_number":47,"context_line":"  0, the Swift object is removed."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* A lock is acquired by the thread during deploy or tear_down when handling"},{"line_number":50,"context_line":"  with the boot ISO - creating boot ISO and/or manipulating"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_d0127108","line":47,"in_reply_to":"3a961159_75ba8fe2","updated":"2014-12-17 16:43:45.000000000","message":"Swift object is added by Ironic and then removed by Ironic when it is no longer used. We could keep that in Swift, but we don\u0027t know if the boot image will be used ever again.  The boot image could be no longer be of use because of any of the above:\n\n1. The OS image is no longer present in Glance or is no longer used for deployment.\n2. The kernel for the OS has changed and hence boot image needs to be built again.\n3. The ramdisk for the OS has changed and hence boot image needs to be built again.\n4. The kernel command-line has changed and hence it needs to be rebuilt - the kernel command-line used to boot the user image is part of the boot image itself (like PXE which reads from a config file, but this config file is within the boot image).\n\nSo it\u0027s a bet on whether we want to keep the image for future use or not.  Because the boot image can be built easily if needed (it takes only a 3-4 seconds to build the image) and later reused, I would like to not waste the storage space for which I don\u0027t know when I am going to reuse.  And building a new one if required is trivial.","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a40dccb41a5b9281f129c57130eea7358c94e00","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  Swift object to indicate how many instances are using the boot ISO."},{"line_number":45,"context_line":"  Everytime a new instance is using the boot ISO, it is incremented, and when"},{"line_number":46,"context_line":"  a node is teared down, it is decremented. When ``reference_count`` becomes"},{"line_number":47,"context_line":"  0, the Swift object is removed."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* A lock is acquired by the thread during deploy or tear_down when handling"},{"line_number":50,"context_line":"  with the boot ISO - creating boot ISO and/or manipulating"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_362f2e40","line":47,"in_reply_to":"3a961159_d0127108","updated":"2014-12-17 17:14:59.000000000","message":"Thx for explaining. Would be useful to have that rationale in the spec.","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"03f2b6dedd5db94268a43ce1cb9b0552cf58a05f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  with the boot ISO - creating boot ISO and/or manipulating"},{"line_number":51,"context_line":"  ``reference count``.  The name of the lock will be the hashed value derived"},{"line_number":52,"context_line":"  above (during deploy) OR the value of ``ilo_boot_iso`` in ``instance_info``"},{"line_number":53,"context_line":"  (during tear down)."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* This doesn\u0027t have any impact when a different conductor takes over the node"},{"line_number":56,"context_line":"  after it is deployed because tear_down operation gets the name of the boot"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_b50cf795","line":53,"updated":"2014-12-17 16:28:27.000000000","message":"I think I\u0027m missing something. Why do we need a lock if the object is in Swift? Won\u0027t the first thread that talks to Swift win? Eg, you can have a bunch of threads creating the ISO image, but only one (I would think) will succeed in adding it to swift. And if the reference_count is in swift, then swift should be handling access to it?","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a40dccb41a5b9281f129c57130eea7358c94e00","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  with the boot ISO - creating boot ISO and/or manipulating"},{"line_number":51,"context_line":"  ``reference count``.  The name of the lock will be the hashed value derived"},{"line_number":52,"context_line":"  above (during deploy) OR the value of ``ilo_boot_iso`` in ``instance_info``"},{"line_number":53,"context_line":"  (during tear down)."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* This doesn\u0027t have any impact when a different conductor takes over the node"},{"line_number":56,"context_line":"  after it is deployed because tear_down operation gets the name of the boot"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_d6026ab3","line":53,"in_reply_to":"3a961159_90bd49da","updated":"2014-12-17 17:14:59.000000000","message":"Ah, that\u0027s what I wanted to know. That Swift itself doesn\u0027t lock the reference count. Please add this information to the spec.\n\nPresumably, issuing 2? requests to Swift (1 to get count, 1 to set count, maybe a diff one to get the object) won\u0027t have a performance impact.","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"df61ac34f18e0b291a34b73cbc2c86168c59cee4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  with the boot ISO - creating boot ISO and/or manipulating"},{"line_number":51,"context_line":"  ``reference count``.  The name of the lock will be the hashed value derived"},{"line_number":52,"context_line":"  above (during deploy) OR the value of ``ilo_boot_iso`` in ``instance_info``"},{"line_number":53,"context_line":"  (during tear down)."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* This doesn\u0027t have any impact when a different conductor takes over the node"},{"line_number":56,"context_line":"  after it is deployed because tear_down operation gets the name of the boot"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_90bd49da","line":53,"in_reply_to":"3a961159_b50cf795","updated":"2014-12-17 16:43:45.000000000","message":"We would require a lock because threads might be trying to create and delete at the same time.  Image if boot image exists with a reference count of 1, and a deploy request for a new node and tear down request for existing node comes - if both read the value of reference count at same time deploy request will increment reference count, and tear down will actually delete the image - making the deploy request fail later on.\n\nReference count is just a meta-propertry of the Swift object, and there is no way to atomically increase or decrease in Swift like a semaphore.  We have to read the value and then increment or decrement it. Hence we need the lock.","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5b0bb9333154737affa49d44d8352370cf9d3f89","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  with the boot ISO - creating boot ISO and/or manipulating"},{"line_number":51,"context_line":"  ``reference count``.  The name of the lock will be the hashed value derived"},{"line_number":52,"context_line":"  above (during deploy) OR the value of ``ilo_boot_iso`` in ``instance_info``"},{"line_number":53,"context_line":"  (during tear down)."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* This doesn\u0027t have any impact when a different conductor takes over the node"},{"line_number":56,"context_line":"  after it is deployed because tear_down operation gets the name of the boot"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_c20372b6","line":53,"in_reply_to":"3a961159_d6026ab3","updated":"2014-12-18 07:35:42.000000000","message":"Done.  It doesn\u0027t impact performance, I will make a note of that down too.","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"03f2b6dedd5db94268a43ce1cb9b0552cf58a05f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"* This doesn\u0027t have any impact when a different conductor takes over the node"},{"line_number":56,"context_line":"  after it is deployed because tear_down operation gets the name of the boot"},{"line_number":57,"context_line":"  image from value of the property ``ilo_boot_iso`` in ``instance_info`` of"},{"line_number":58,"context_line":"  the node."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* There is a proposal underway to enable ``agent_ilo`` [1] to deploy partition"},{"line_number":61,"context_line":"  images.  When ``agent_ilo`` driver is enabled to deploy partition images, the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_7579affb","line":58,"updated":"2014-12-17 16:28:27.000000000","message":"So how does the reference count for the image get decremented in this case?","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a40dccb41a5b9281f129c57130eea7358c94e00","unresolved":false,"context_lines":[{"line_number":55,"context_line":"* This doesn\u0027t have any impact when a different conductor takes over the node"},{"line_number":56,"context_line":"  after it is deployed because tear_down operation gets the name of the boot"},{"line_number":57,"context_line":"  image from value of the property ``ilo_boot_iso`` in ``instance_info`` of"},{"line_number":58,"context_line":"  the node."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* There is a proposal underway to enable ``agent_ilo`` [1] to deploy partition"},{"line_number":61,"context_line":"  images.  When ``agent_ilo`` driver is enabled to deploy partition images, the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_36156e9b","line":58,"in_reply_to":"3a961159_1090794d","updated":"2014-12-17 17:14:59.000000000","message":"Ok, sorry, it didn\u0027t register with me, what \u0027name of the boot image\u0027 meant. \n\nMaybe something like \u0027When deploying, the boot ISO\u0027s Swift name is stored in node.instance_info[\"ilo_boot_iso\"]. So even if a different conductor takes over the node after it is deployed, the Swift object is known without needing the original conductor\u0027s name to generate the name of the boot image.","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5b0bb9333154737affa49d44d8352370cf9d3f89","unresolved":false,"context_lines":[{"line_number":55,"context_line":"* This doesn\u0027t have any impact when a different conductor takes over the node"},{"line_number":56,"context_line":"  after it is deployed because tear_down operation gets the name of the boot"},{"line_number":57,"context_line":"  image from value of the property ``ilo_boot_iso`` in ``instance_info`` of"},{"line_number":58,"context_line":"  the node."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* There is a proposal underway to enable ``agent_ilo`` [1] to deploy partition"},{"line_number":61,"context_line":"  images.  When ``agent_ilo`` driver is enabled to deploy partition images, the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_c2f1b2ce","line":58,"in_reply_to":"3a961159_36156e9b","updated":"2014-12-18 07:35:42.000000000","message":"Done. Thanks for helping me rephrase it.","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"df61ac34f18e0b291a34b73cbc2c86168c59cee4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"* This doesn\u0027t have any impact when a different conductor takes over the node"},{"line_number":56,"context_line":"  after it is deployed because tear_down operation gets the name of the boot"},{"line_number":57,"context_line":"  image from value of the property ``ilo_boot_iso`` in ``instance_info`` of"},{"line_number":58,"context_line":"  the node."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* There is a proposal underway to enable ``agent_ilo`` [1] to deploy partition"},{"line_number":61,"context_line":"  images.  When ``agent_ilo`` driver is enabled to deploy partition images, the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_1090794d","line":58,"in_reply_to":"3a961159_7579affb","updated":"2014-12-17 16:43:45.000000000","message":"Reference count is just decremented as usual.  We find the Swift object from ilo_boot_iso, we would get the value of meta-property reference_count and then decrement it.  Conductor name is used only for generating the hash during deploy. Tear down uses the value stored in instance_info.","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"87fc86a7cf51856b9a428d9dbe67dbd0b0fed1ff","unresolved":false,"context_lines":[{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Unit tests will be added for the changes. This will soon be tested in the"},{"line_number":158,"context_line":"3rd party CI with every test on ``iscsi_ilo`` driver."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Upgrades and Backwards Compatibility"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_8c5a8a28","line":158,"updated":"2014-12-18 00:51:45.000000000","message":"will test on agent-ilo driver as well.","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5b0bb9333154737affa49d44d8352370cf9d3f89","unresolved":false,"context_lines":[{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Unit tests will be added for the changes. This will soon be tested in the"},{"line_number":158,"context_line":"3rd party CI with every test on ``iscsi_ilo`` driver."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Upgrades and Backwards Compatibility"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_c29ff25d","line":158,"in_reply_to":"3a961159_8c5a8a28","updated":"2014-12-18 07:35:42.000000000","message":"Done","commit_id":"293652cf76d86836de4af7a2065de7affe704637"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"928afcbffe84e15bb4a8bae9fe1e6a768607c971","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  tear_down when handling with the boot ISO - creating boot ISO and/or"},{"line_number":51,"context_line":"  incrementing/decrementing ``reference count``.  The name of the lock will be"},{"line_number":52,"context_line":"  the hashed value derived above (during deploy) OR the value of"},{"line_number":53,"context_line":"  ``ilo_boot_iso`` in node\u0027s ``instance_info`` (during tear down). Lock is"},{"line_number":54,"context_line":"  required because two operations (first a ``head_object`` and followed"},{"line_number":55,"context_line":"  by a ``post_object``) in Swift are required to atomically increment or"},{"line_number":56,"context_line":"  decrement value of ``reference_count``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_9df70159","line":53,"updated":"2014-12-18 14:17:48.000000000","message":"isn\u0027t the hashed value derived above, and the value of node.instance_info[\u0027ilo_boot_iso\u0027] the same value? The above makes it seem like it could be different names.\n\nI think you can probably just write \u0027The name of the lock will be the same name as the boot ISO image\u0027.","commit_id":"47a7aeb1c2cde3ec55a59431e09b7e1ca9bb3fc1"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e2cd3f31e406c0f5345ff3346b34b9b6d22110c2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  tear_down when handling with the boot ISO - creating boot ISO and/or"},{"line_number":51,"context_line":"  incrementing/decrementing ``reference count``.  The name of the lock will be"},{"line_number":52,"context_line":"  the hashed value derived above (during deploy) OR the value of"},{"line_number":53,"context_line":"  ``ilo_boot_iso`` in node\u0027s ``instance_info`` (during tear down). Lock is"},{"line_number":54,"context_line":"  required because two operations (first a ``head_object`` and followed"},{"line_number":55,"context_line":"  by a ``post_object``) in Swift are required to atomically increment or"},{"line_number":56,"context_line":"  decrement value of ``reference_count``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_00b1e8e0","line":53,"in_reply_to":"3a961159_9df70159","updated":"2014-12-18 14:25:07.000000000","message":"Done","commit_id":"47a7aeb1c2cde3ec55a59431e09b7e1ca9bb3fc1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"928afcbffe84e15bb4a8bae9fe1e6a768607c971","unresolved":false,"context_lines":[{"line_number":78,"context_line":"iLO driver(s) can continue creating boot ISO image per instance, but this"},{"line_number":79,"context_line":"will not use the space efficiently."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"We could avoid deleting the images in Swift during tear down, but we don\u0027t know"},{"line_number":82,"context_line":"if the boot image will be used ever again. The boot image could be no longer"},{"line_number":83,"context_line":"be of use because of any of the above:"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_5d59195a","line":81,"updated":"2014-12-18 14:17:48.000000000","message":"and avoid needing a reference_count (this is what I would really like to avoid because then we wouldn\u0027t need locks)","commit_id":"47a7aeb1c2cde3ec55a59431e09b7e1ca9bb3fc1"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e2cd3f31e406c0f5345ff3346b34b9b6d22110c2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"iLO driver(s) can continue creating boot ISO image per instance, but this"},{"line_number":79,"context_line":"will not use the space efficiently."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"We could avoid deleting the images in Swift during tear down, but we don\u0027t know"},{"line_number":82,"context_line":"if the boot image will be used ever again. The boot image could be no longer"},{"line_number":83,"context_line":"be of use because of any of the above:"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_a0bf34a9","line":81,"in_reply_to":"3a961159_5d59195a","updated":"2014-12-18 14:25:07.000000000","message":"Done","commit_id":"47a7aeb1c2cde3ec55a59431e09b7e1ca9bb3fc1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"928afcbffe84e15bb4a8bae9fe1e6a768607c971","unresolved":false,"context_lines":[{"line_number":79,"context_line":"will not use the space efficiently."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"We could avoid deleting the images in Swift during tear down, but we don\u0027t know"},{"line_number":82,"context_line":"if the boot image will be used ever again. The boot image could be no longer"},{"line_number":83,"context_line":"be of use because of any of the above:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* The OS image is no longer present in Glance or is no longer used for"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_5d2039b0","line":82,"updated":"2014-12-18 14:17:48.000000000","message":"\u0027be no longer\u0027 -\u003e \u0027no longer\u0027","commit_id":"47a7aeb1c2cde3ec55a59431e09b7e1ca9bb3fc1"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e2cd3f31e406c0f5345ff3346b34b9b6d22110c2","unresolved":false,"context_lines":[{"line_number":79,"context_line":"will not use the space efficiently."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"We could avoid deleting the images in Swift during tear down, but we don\u0027t know"},{"line_number":82,"context_line":"if the boot image will be used ever again. The boot image could be no longer"},{"line_number":83,"context_line":"be of use because of any of the above:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* The OS image is no longer present in Glance or is no longer used for"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_e0e05cce","line":82,"in_reply_to":"3a961159_5d2039b0","updated":"2014-12-18 14:25:07.000000000","message":"Done","commit_id":"47a7aeb1c2cde3ec55a59431e09b7e1ca9bb3fc1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"928afcbffe84e15bb4a8bae9fe1e6a768607c971","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"We could avoid deleting the images in Swift during tear down, but we don\u0027t know"},{"line_number":82,"context_line":"if the boot image will be used ever again. The boot image could be no longer"},{"line_number":83,"context_line":"be of use because of any of the above:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* The OS image is no longer present in Glance or is no longer used for"},{"line_number":86,"context_line":"  deployment."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_9d2aa18e","line":83,"updated":"2014-12-18 14:17:48.000000000","message":"\u0027above\u0027 -\u003e \u0027below\u0027","commit_id":"47a7aeb1c2cde3ec55a59431e09b7e1ca9bb3fc1"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e2cd3f31e406c0f5345ff3346b34b9b6d22110c2","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"We could avoid deleting the images in Swift during tear down, but we don\u0027t know"},{"line_number":82,"context_line":"if the boot image will be used ever again. The boot image could be no longer"},{"line_number":83,"context_line":"be of use because of any of the above:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* The OS image is no longer present in Glance or is no longer used for"},{"line_number":86,"context_line":"  deployment."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_00e808b3","line":83,"in_reply_to":"3a961159_9d2aa18e","updated":"2014-12-18 14:25:07.000000000","message":"Done","commit_id":"47a7aeb1c2cde3ec55a59431e09b7e1ca9bb3fc1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"928afcbffe84e15bb4a8bae9fe1e6a768607c971","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"I would like to not waste the storage space because I don\u0027t know if I am going"},{"line_number":97,"context_line":"to reuse it or not.  And building a new boot image if required is trivial and"},{"line_number":98,"context_line":"takes only a 3-4 seconds."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Data model impact"},{"line_number":101,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_e0ecdc2b","line":98,"updated":"2014-12-18 14:17:48.000000000","message":"how about \u0027To avoid wasting Swift storage space, we chose to delete the images when they aren\u0027t being used. The tradeoff is building/storing a boot image again, but building a new boot image is trivial and takes 3-4 seconds.\u0027","commit_id":"47a7aeb1c2cde3ec55a59431e09b7e1ca9bb3fc1"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e2cd3f31e406c0f5345ff3346b34b9b6d22110c2","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"I would like to not waste the storage space because I don\u0027t know if I am going"},{"line_number":97,"context_line":"to reuse it or not.  And building a new boot image if required is trivial and"},{"line_number":98,"context_line":"takes only a 3-4 seconds."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Data model impact"},{"line_number":101,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_60cc6c62","line":98,"in_reply_to":"3a961159_e0ecdc2b","updated":"2014-12-18 14:25:07.000000000","message":"Done","commit_id":"47a7aeb1c2cde3ec55a59431e09b7e1ca9bb3fc1"}],"specs/kilo/iscsi-ilo-share-boot-images.rst":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d4978cb1ace8748a42544e42e39d0f5c0ce10409","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  + Glance UUID of boot kernel"},{"line_number":38,"context_line":"  + Glance UUID of boot ramdisk"},{"line_number":39,"context_line":"  + Name of the conductor node"},{"line_number":40,"context_line":"  + Kernel command-line arguments"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* A meta-property named ``reference_count`` can be used in the boot ISO"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_6d477578","line":39,"updated":"2014-11-26 15:56:05.000000000","message":"Why is conductor name important? Couldn\u0027t the boot ISO be shared across conductors?","commit_id":"8d71dddbe6d853690678d1997a600bf1e55591af"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"8c0ab656d975907e2054ea187a18e0d1ea19c8fe","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  + Glance UUID of boot kernel"},{"line_number":38,"context_line":"  + Glance UUID of boot ramdisk"},{"line_number":39,"context_line":"  + Name of the conductor node"},{"line_number":40,"context_line":"  + Kernel command-line arguments"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* A meta-property named ``reference_count`` can be used in the boot ISO"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_44327df3","line":39,"in_reply_to":"5a890539_6d477578","updated":"2014-11-27 09:38:00.000000000","message":"The blocker to share the boot ISO across conductor is a distributed locking mechanism available across conductors.  As discussed in the summit, Apache Zookeeper might solve the problem, but there are two things to consider:\n\n* Apache zookeeper needs to added as a locking mechanism in Ironic which is some effort.\n* Comparison of benefits of \"sharing boot ISO across instances in a single conductor\" vs \"sharing boot ISO across instances in all conductors\".  Imagine a situation with 125 instances booting across 4 conductors (which I believe was the deployment situation that rackspace guys told).  The current code will create 125 boot ISOs for 125 instances.  \"sharing boot ISO across instances in a single conductor\" will create 4 boot ISOs. \"sharing boot ISO across instances in all conductors\" will create only a single boot ISO.\n\nThe current proposed change I believe might bring most of the change that we are looking for (eventhough this is situation-dependent).  The effort required for the current proposed change is little.  \"sharing boot ISO across instances in all conductors\" may be pursued once we have the apache zookeeper (or some other better locking mechanism) in Ironic.","commit_id":"8d71dddbe6d853690678d1997a600bf1e55591af"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d4978cb1ace8748a42544e42e39d0f5c0ce10409","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  a node is teared down, it is decremented. When ``reference_count`` becomes"},{"line_number":46,"context_line":"  0, the Swift object is removed."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* A lock is acquired by the thread during deploy or tear_down when handling"},{"line_number":49,"context_line":"  with the boot ISO - creating boot ISO and/or manipulating"},{"line_number":50,"context_line":"  ``reference count``.  The name of the lock will be the Glance UUID of the"},{"line_number":51,"context_line":"  image being deployed."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_8d5bc154","line":48,"updated":"2014-11-26 15:56:05.000000000","message":"This would have to be a distributed lock, which is then exposed to network partitions or other race conditions. Could this counter be handled better somewhere else? Or is there another way to track this without a counter at all?\n\nPerhaps use a TTL and have conductor\u0027s periodically update it.","commit_id":"8d71dddbe6d853690678d1997a600bf1e55591af"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"8c0ab656d975907e2054ea187a18e0d1ea19c8fe","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  a node is teared down, it is decremented. When ``reference_count`` becomes"},{"line_number":46,"context_line":"  0, the Swift object is removed."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* A lock is acquired by the thread during deploy or tear_down when handling"},{"line_number":49,"context_line":"  with the boot ISO - creating boot ISO and/or manipulating"},{"line_number":50,"context_line":"  ``reference count``.  The name of the lock will be the Glance UUID of the"},{"line_number":51,"context_line":"  image being deployed."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_645db915","line":48,"in_reply_to":"5a890539_8d5bc154","updated":"2014-11-27 09:38:00.000000000","message":"Again the current proposed change just lives within a single conductor and can be implement solely with the current locking mechanisms available.","commit_id":"8d71dddbe6d853690678d1997a600bf1e55591af"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d4978cb1ace8748a42544e42e39d0f5c0ce10409","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  ``reference count``.  The name of the lock will be the Glance UUID of the"},{"line_number":51,"context_line":"  image being deployed."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* This doesn\u0027t have any impact when a different conductor takes over the node"},{"line_number":54,"context_line":"  after it is deployed because tear_down operation just checks the"},{"line_number":55,"context_line":"  ``reference_count`` within the Swift object (whose UUID is mentioned in"},{"line_number":56,"context_line":"  instance_info of the node)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_ad587d58","line":53,"updated":"2014-11-26 15:56:05.000000000","message":"OK - that seems to be in contradiction to having the name of the conductor node be part of the hash.","commit_id":"8d71dddbe6d853690678d1997a600bf1e55591af"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"8c0ab656d975907e2054ea187a18e0d1ea19c8fe","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  ``reference count``.  The name of the lock will be the Glance UUID of the"},{"line_number":51,"context_line":"  image being deployed."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* This doesn\u0027t have any impact when a different conductor takes over the node"},{"line_number":54,"context_line":"  after it is deployed because tear_down operation just checks the"},{"line_number":55,"context_line":"  ``reference_count`` within the Swift object (whose UUID is mentioned in"},{"line_number":56,"context_line":"  instance_info of the node)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_e47fe964","line":53,"in_reply_to":"5a890539_ad587d58","updated":"2014-11-27 09:38:00.000000000","message":"This doesn\u0027t haven any impact because even if the conductor dies after deploying the node, the boot ISO name is recorded in the node\u0027s instance_info and is used.  We just need to conductor name during the deployment (for either creating the boot ISO or reusing the currently available boot ISO).  After deployment we don\u0027t use the conductor node anywhere, and it is independent of the conductor.","commit_id":"8d71dddbe6d853690678d1997a600bf1e55591af"}]}
