)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"696ff220d1b3148a795fd379a1679bb0367c5fdf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partial image support for agent driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes to support deploy using partial images in agent driver"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie54eb749412f49f17e59b1ed86e5595762573cd2"},{"line_number":12,"context_line":"Implements: blueprint partial-image-support-for-agent-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a890539_b5c60947","line":9,"updated":"2014-11-26 15:29:40.000000000","message":"I think we usually call it \u0027partition images\u0027","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"ba04f9c554184d7a0340c2fa1860a43b2c32038d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partial image support for agent driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes to support deploy using partial images in agent driver"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie54eb749412f49f17e59b1ed86e5595762573cd2"},{"line_number":12,"context_line":"Implements: blueprint partial-image-support-for-agent-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_f8d84181","line":9,"in_reply_to":"5a890539_b5c60947","updated":"2014-12-09 13:52:39.000000000","message":"Sure, will refer it as partition image henceforth.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"}],"specs/kilo/partial-image-support-for-agent-driver.rst":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"a2d7bcf61ecacdf04a5692d78c1c215b09710e32","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Partial image support for agent driver"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/partial-image-support-for-agent-driver"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_35369903","line":8,"updated":"2014-11-26 16:07:47.000000000","message":"Rather than \"partial image\", we have been referring to this as \"partition image\". I don\u0027t see any strong reason to change that, so please update this document to use \"partition image\".","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"ba04f9c554184d7a0340c2fa1860a43b2c32038d","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Partial image support for agent driver"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/partial-image-support-for-agent-driver"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_0f5333e3","line":8,"in_reply_to":"5a890539_35369903","updated":"2014-12-09 13:52:39.000000000","message":"Done","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"82fcd3e25e07c81b8aa56a648e3758e7d95359f4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/partial-image-support-for-agent-driver"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint suggests to enhance agent driver to support deploy partial"},{"line_number":14,"context_line":"images with subsequent boot to happen over pxe or vmdeia as specified by"},{"line_number":15,"context_line":"the driver."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_2d156d9b","line":14,"updated":"2014-11-26 16:08:33.000000000","message":"Nit: s/vmdeia/vmedia/","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"ba04f9c554184d7a0340c2fa1860a43b2c32038d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/partial-image-support-for-agent-driver"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint suggests to enhance agent driver to support deploy partial"},{"line_number":14,"context_line":"images with subsequent boot to happen over pxe or vmdeia as specified by"},{"line_number":15,"context_line":"the driver."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_af5bfff4","line":14,"in_reply_to":"5a890539_2d156d9b","updated":"2014-12-09 13:52:39.000000000","message":"Done","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"696ff220d1b3148a795fd379a1679bb0367c5fdf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"As of now agent driver support only disk images that can be deployed on the"},{"line_number":21,"context_line":"baremetal. With disk image based deploy, the subsequent boot will happen from"},{"line_number":22,"context_line":"the local hard drive. Ironic does not have control over the subsequent boots"},{"line_number":23,"context_line":"of the provisioned baremetal node."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_55fc0572","line":20,"updated":"2014-11-26 15:29:40.000000000","message":"s/disk images/whole disk images/ for the sake of clarity","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"ba04f9c554184d7a0340c2fa1860a43b2c32038d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"As of now agent driver support only disk images that can be deployed on the"},{"line_number":21,"context_line":"baremetal. With disk image based deploy, the subsequent boot will happen from"},{"line_number":22,"context_line":"the local hard drive. Ironic does not have control over the subsequent boots"},{"line_number":23,"context_line":"of the provisioned baremetal node."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_cf6f6b92","line":20,"in_reply_to":"5a890539_55fc0572","updated":"2014-12-09 13:52:39.000000000","message":"Done","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2efd0be0a28cbbf69aa685721e2c74c2b17b2479","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* Agent driver validate the specified image type is of partial image(raw) by"},{"line_number":29,"context_line":"  looking for kernel_id and ramdisk_id image properties."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Send partition information(root, swap, etc) to the agent ramdisk through"},{"line_number":32,"context_line":"  image_info."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_7023cea7","line":29,"updated":"2014-11-26 16:07:18.000000000","message":"would this work if the image was not in glance?","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"ba04f9c554184d7a0340c2fa1860a43b2c32038d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* Agent driver validate the specified image type is of partial image(raw) by"},{"line_number":29,"context_line":"  looking for kernel_id and ramdisk_id image properties."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Send partition information(root, swap, etc) to the agent ramdisk through"},{"line_number":32,"context_line":"  image_info."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d8f9c5c9","line":29,"in_reply_to":"5a890539_7023cea7","updated":"2014-12-09 13:52:39.000000000","message":"If kernel and ramdisk are not present on the glance, then deploy will fail. This is true even for our pxe_ipmitool driver.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"22da9d6ae5bf0d5b88a046a9aa4d84b86d86f751","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  controller."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Post deploy, agent driver prepares the config for subsequent boot, either"},{"line_number":41,"context_line":"  using pxe or vmedia as defined by the driver."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_f8302109","line":41,"updated":"2014-12-01 20:03:29.000000000","message":"We should allow a vmedia agent driver to support both local boot or netboot for the subsequent reboots after a node has been provisioned.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"ba04f9c554184d7a0340c2fa1860a43b2c32038d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  controller."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Post deploy, agent driver prepares the config for subsequent boot, either"},{"line_number":41,"context_line":"  using pxe or vmedia as defined by the driver."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_98b57df0","line":41,"in_reply_to":"5a890539_f8302109","updated":"2014-12-09 13:52:39.000000000","message":"Yes, vmedia agent driver should also support both local and boot and netboot.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"82fcd3e25e07c81b8aa56a648e3758e7d95359f4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Post deploy, agent driver prepares the config for subsequent boot, either"},{"line_number":41,"context_line":"  using pxe or vmedia as defined by the driver."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_d01722ed","line":42,"updated":"2014-11-26 16:08:33.000000000","message":"I think Ironic\u0027s partitioning code should be split into a library that Ironic and IPA can both use. That should be added here and/or under work items.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"82fcd3e25e07c81b8aa56a648e3758e7d95359f4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"We can use iscsi method to write partial image on to the target disk."},{"line_number":48,"context_line":"We need agent ramdisk to support iscsi, similar to the ironic DIB element."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_b0f376e6","line":48,"updated":"2014-11-26 16:08:33.000000000","message":"I would like to also do this to support running the PXE driver with the agent ramdisk, but that\u0027s off topic for this spec. :)","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"ba04f9c554184d7a0340c2fa1860a43b2c32038d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"We can use iscsi method to write partial image on to the target disk."},{"line_number":48,"context_line":"We need agent ramdisk to support iscsi, similar to the ironic DIB element."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_73863267","line":48,"in_reply_to":"5a890539_b0f376e6","updated":"2014-12-09 13:52:39.000000000","message":"I just mentioned it as an alternative. \nSince the deploy can also be done through iscsi method.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"82fcd3e25e07c81b8aa56a648e3758e7d95359f4","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Work Items"},{"line_number":119,"context_line":"----------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Dependencies"},{"line_number":123,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_50db324f","line":120,"updated":"2014-11-26 16:08:33.000000000","message":"Would like to see this section filled out.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"ba04f9c554184d7a0340c2fa1860a43b2c32038d","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Work Items"},{"line_number":119,"context_line":"----------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Dependencies"},{"line_number":123,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_33baea0a","line":120,"in_reply_to":"5a890539_50db324f","updated":"2014-12-09 13:52:39.000000000","message":"Added more details.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"82fcd3e25e07c81b8aa56a648e3758e7d95359f4","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Testing"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_30bdc6d8","line":128,"updated":"2014-11-26 16:08:33.000000000","message":"We\u0027ll need to do some work on devstack/devstack-gate/tempest to enable testing both types of images with the agent.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"ba04f9c554184d7a0340c2fa1860a43b2c32038d","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Testing"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b345fa18","line":128,"in_reply_to":"5a890539_30bdc6d8","updated":"2014-12-09 13:52:39.000000000","message":"Added more details.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"82fcd3e25e07c81b8aa56a648e3758e7d95359f4","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Documentation Impact"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"References"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_f0c25e52","line":136,"updated":"2014-11-26 16:08:33.000000000","message":"I\u0027d like to see this section filled out.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"ba04f9c554184d7a0340c2fa1860a43b2c32038d","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Documentation Impact"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"References"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_33510ad9","line":136,"in_reply_to":"5a890539_f0c25e52","updated":"2014-12-09 13:52:39.000000000","message":"Added this section.","commit_id":"39a0838849875be11e121318e44832143d4e8ef8"}],"specs/kilo/partition-image-support-for-agent-driver.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1b4a3b0b68accfb9452782973c7d5cc4b5e4ba7","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Other end user impact"},{"line_number":85,"context_line":"---------------------"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"None."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Scalability impact"},{"line_number":90,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_6905e544","line":87,"updated":"2014-12-12 16:13:50.000000000","message":"ability to deploy partition images on nodes managed by the agent","commit_id":"f63216e9dab27497461c8c35aca37541ecc24d32"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"1e47d1117d351fb6fc6f54108a3ae30e165d894f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Other end user impact"},{"line_number":85,"context_line":"---------------------"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"None."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Scalability impact"},{"line_number":90,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_f0807148","line":87,"in_reply_to":"3a961159_6905e544","updated":"2014-12-16 19:23:03.000000000","message":"Sure.  I will update the spec with this comment.","commit_id":"f63216e9dab27497461c8c35aca37541ecc24d32"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1b4a3b0b68accfb9452782973c7d5cc4b5e4ba7","unresolved":false,"context_lines":[{"line_number":124,"context_line":"* Factor out the partitioning code from ironic into a common library"},{"line_number":125,"context_line":"  for both IPA and ironic code base."},{"line_number":126,"context_line":"  [I think we need to host it outside ironic, so that it can be used"},{"line_number":127,"context_line":"  by both IPA and ironic. Need suggesstion how to go about this.]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* Make necessary changes in agent driver common code, such as validate,"},{"line_number":130,"context_line":"  deploy, etc."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_49d4a9bc","line":127,"updated":"2014-12-12 16:13:50.000000000","message":"I would vote for splitting away everything in ironic.common, ironic.dhcp and ironic.drivers.modules that does not touch ironic.conductor. And put it on PyPI as smth like libironic :) of course it should be discussed...","commit_id":"f63216e9dab27497461c8c35aca37541ecc24d32"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"1e47d1117d351fb6fc6f54108a3ae30e165d894f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"* Factor out the partitioning code from ironic into a common library"},{"line_number":125,"context_line":"  for both IPA and ironic code base."},{"line_number":126,"context_line":"  [I think we need to host it outside ironic, so that it can be used"},{"line_number":127,"context_line":"  by both IPA and ironic. Need suggesstion how to go about this.]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* Make necessary changes in agent driver common code, such as validate,"},{"line_number":130,"context_line":"  deploy, etc."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_f0ba316d","line":127,"in_reply_to":"3a961159_49d4a9bc","updated":"2014-12-16 19:23:03.000000000","message":"Instead of splitting all the items above, I would suggest we take staggered approach. \n1. Make all the common modules for [disk partition] available in libironic and put it on PyPI - maybe hosted alongside IPA\n2. Use this module in IPA to support partition images.\n3. Replace the [disk partition] code in ironic with libironic. \n\nWe can repeat the above activities as and when required, since, all the common modules is not immediately required  for this spec.","commit_id":"f63216e9dab27497461c8c35aca37541ecc24d32"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"64e3a7366328edf34972c887fefb99b3fa45b3d1","unresolved":false,"context_lines":[{"line_number":124,"context_line":"* Factor out the partitioning code from ironic into a common library"},{"line_number":125,"context_line":"  for both IPA and ironic code base."},{"line_number":126,"context_line":"  [I think we need to host it outside ironic, so that it can be used"},{"line_number":127,"context_line":"  by both IPA and ironic. Need suggesstion how to go about this.]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* Make necessary changes in agent driver common code, such as validate,"},{"line_number":130,"context_line":"  deploy, etc."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_ac1e0d6e","line":127,"in_reply_to":"3a961159_aa3491df","updated":"2014-12-22 06:27:29.000000000","message":"We can host this library under oslo incubator as oslo.libironic. \nInitially add only disk_partition.py and related code, along with their testcases, Later on we can add more code depending on the common need. \n\nI dont think it will impact our testing complexity, as we will be moving the testcases along with the code.","commit_id":"f63216e9dab27497461c8c35aca37541ecc24d32"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d9047a399a7bd0aa5a80f09342a2faed89831ca6","unresolved":false,"context_lines":[{"line_number":124,"context_line":"* Factor out the partitioning code from ironic into a common library"},{"line_number":125,"context_line":"  for both IPA and ironic code base."},{"line_number":126,"context_line":"  [I think we need to host it outside ironic, so that it can be used"},{"line_number":127,"context_line":"  by both IPA and ironic. Need suggesstion how to go about this.]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* Make necessary changes in agent driver common code, such as validate,"},{"line_number":130,"context_line":"  deploy, etc."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_aa3491df","line":127,"in_reply_to":"3a961159_c5ac928f","updated":"2014-12-17 19:17:55.000000000","message":"I am concerned about where this library would live. Maybe oslo incubator is an option? I am thinking if its published as a library this will impact our testing complexity.","commit_id":"f63216e9dab27497461c8c35aca37541ecc24d32"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"00a9f24085b16b558e801f2b36afd30d7ac46241","unresolved":false,"context_lines":[{"line_number":124,"context_line":"* Factor out the partitioning code from ironic into a common library"},{"line_number":125,"context_line":"  for both IPA and ironic code base."},{"line_number":126,"context_line":"  [I think we need to host it outside ironic, so that it can be used"},{"line_number":127,"context_line":"  by both IPA and ironic. Need suggesstion how to go about this.]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* Make necessary changes in agent driver common code, such as validate,"},{"line_number":130,"context_line":"  deploy, etc."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_b11f9d08","line":127,"in_reply_to":"3a961159_f0ba316d","updated":"2014-12-18 00:37:20.000000000","message":"I agree with the staggered approach.  Let\u0027s focus on refactoring the disk partition code to support this spec for Kilo.","commit_id":"f63216e9dab27497461c8c35aca37541ecc24d32"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"41af2149cdb3a37aa89789a5758a17e5c375fc55","unresolved":false,"context_lines":[{"line_number":124,"context_line":"* Factor out the partitioning code from ironic into a common library"},{"line_number":125,"context_line":"  for both IPA and ironic code base."},{"line_number":126,"context_line":"  [I think we need to host it outside ironic, so that it can be used"},{"line_number":127,"context_line":"  by both IPA and ironic. Need suggesstion how to go about this.]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* Make necessary changes in agent driver common code, such as validate,"},{"line_number":130,"context_line":"  deploy, etc."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_c5ac928f","line":127,"in_reply_to":"3a961159_f0ba316d","updated":"2014-12-16 21:39:38.000000000","message":"I agree with this direction just generally caution overloading too much in the \"lib\" as many people care about the ramdisk not getting too large. The more things we include in \"libironic\" (oslo.partition?) the more things we have to ship with IPA.","commit_id":"f63216e9dab27497461c8c35aca37541ecc24d32"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d9047a399a7bd0aa5a80f09342a2faed89831ca6","unresolved":false,"context_lines":[{"line_number":135,"context_line":"* Make necessary changes in agent_ilo driver to generate iso for subsequent"},{"line_number":136,"context_line":"  reboot."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* Make changes in IPA (agent ramdisk) to recognize the incoming imag"},{"line_number":139,"context_line":"  information and take appropriate action to deploy partition image on the"},{"line_number":140,"context_line":"  disk."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_a8e3dd03","line":138,"updated":"2014-12-17 19:17:55.000000000","message":"nit: s/imag/image/","commit_id":"f63216e9dab27497461c8c35aca37541ecc24d32"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"abcbf3463b0bb59868d276010df2714afa71bf3f","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Dependencies"},{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Testing"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a930d6b_42517b61","line":154,"updated":"2015-01-21 22:50:05.000000000","message":"Nit: I can see this being dependent on the creation of the new oslo lib. I am ok with landing as is. The work is called out in the Work Items section.","commit_id":"67d0de1298e376c665550289f37a831f51e1b1cb"}]}