)]}'
{"specs/kilo/driver-internal-info.rst":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0c352e96dbedb0301b9b8ae8d3670cffeb3ce37e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Driver Internal Info"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/driver-internal-info"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_be7eaaac","line":11,"updated":"2015-01-22 10:08:39.000000000","message":"Leads to page not found","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"34b5178bfef80b02ea5dd01af7388fdb429d41d8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Driver Internal Info"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/driver-internal-info"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_4f3a72ce","line":11,"in_reply_to":"1a930d6b_be7eaaac","updated":"2015-01-22 10:52:08.000000000","message":"Create this spec, thanks.","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"103e0a0fba7c2e60f1daff574ffa05c2bc582aaa","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Add a new table driver_internal_info to save driver own infos, which will not"},{"line_number":27,"context_line":"expose to Admin/user via API."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Add ensure_next_boot_device into base.ManagementInterface."},{"line_number":30,"context_line":"During PXE deploy processing, the target machine will boot by itself. Some"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_3677313c","line":27,"updated":"2015-01-22 17:10:44.000000000","message":"FFT: It could be exposed and treated as a internal attribute in our API (so it wouldn\u0027t support updates via API). We do it for things like \"reservation\" which is an internal attribute that holds the name of the conductor which is currently managing that node.\n\nI just think about exposing because I don\u0027t know how hard to debug it could be for an operator if the values are not visible at all via the API.\n\nPlus, we may not even need to have a separated database table for it, it could be yet-another column in the node table.","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"33615e44e3212297caa39dc7004a0b67114ba943","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Add a new table driver_internal_info to save driver own infos, which will not"},{"line_number":27,"context_line":"expose to Admin/user via API."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Add ensure_next_boot_device into base.ManagementInterface."},{"line_number":30,"context_line":"During PXE deploy processing, the target machine will boot by itself. Some"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_a302f33b","line":27,"in_reply_to":"1a930d6b_3677313c","updated":"2015-01-23 03:40:36.000000000","message":"Thanks, Lucas, internal attribute sounds nice. I will play around with this.","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"103e0a0fba7c2e60f1daff574ffa05c2bc582aaa","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Add a new table driver_internal_info to save driver own infos, which will not"},{"line_number":27,"context_line":"expose to Admin/user via API."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Add ensure_next_boot_device into base.ManagementInterface."},{"line_number":30,"context_line":"During PXE deploy processing, the target machine will boot by itself. Some"},{"line_number":31,"context_line":"Drivers has to set next boot device again in  _continue_deploy()."},{"line_number":32,"context_line":"Add ensure_next_boot_device into base.ManagementInterface to support"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_765ff9e5","line":29,"updated":"2015-01-22 17:10:44.000000000","message":"What is ensure_next_boot_device? A attribute of the class? A method?","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"33615e44e3212297caa39dc7004a0b67114ba943","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Add a new table driver_internal_info to save driver own infos, which will not"},{"line_number":27,"context_line":"expose to Admin/user via API."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Add ensure_next_boot_device into base.ManagementInterface."},{"line_number":30,"context_line":"During PXE deploy processing, the target machine will boot by itself. Some"},{"line_number":31,"context_line":"Drivers has to set next boot device again in  _continue_deploy()."},{"line_number":32,"context_line":"Add ensure_next_boot_device into base.ManagementInterface to support"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_e3fcfb40","line":29,"in_reply_to":"1a930d6b_765ff9e5","updated":"2015-01-23 03:40:36.000000000","message":"A method","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"103e0a0fba7c2e60f1daff574ffa05c2bc582aaa","unresolved":false,"context_lines":[{"line_number":27,"context_line":"expose to Admin/user via API."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Add ensure_next_boot_device into base.ManagementInterface."},{"line_number":30,"context_line":"During PXE deploy processing, the target machine will boot by itself. Some"},{"line_number":31,"context_line":"Drivers has to set next boot device again in  _continue_deploy()."},{"line_number":32,"context_line":"Add ensure_next_boot_device into base.ManagementInterface to support"},{"line_number":33,"context_line":"this unconditionally."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_f6f8497e","line":30,"updated":"2015-01-22 17:10:44.000000000","message":"what it means \"will boot by itself\" ?\n\nAs part of the PXE deploy process, before rebooting the machine will be configured to boot from network and powered on.","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"33615e44e3212297caa39dc7004a0b67114ba943","unresolved":false,"context_lines":[{"line_number":27,"context_line":"expose to Admin/user via API."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Add ensure_next_boot_device into base.ManagementInterface."},{"line_number":30,"context_line":"During PXE deploy processing, the target machine will boot by itself. Some"},{"line_number":31,"context_line":"Drivers has to set next boot device again in  _continue_deploy()."},{"line_number":32,"context_line":"Add ensure_next_boot_device into base.ManagementInterface to support"},{"line_number":33,"context_line":"this unconditionally."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_833fb7d5","line":30,"in_reply_to":"1a930d6b_f6f8497e","updated":"2015-01-23 03:40:36.000000000","message":"Ironic will only change the pxe_config from deploy to boot section and send signal to ramdisk. Then ramdisk will stop ISCSI and reboot the machine. This is what I mean boot by itself. It\u0027s not reboot by using ipmitool alike.\n\nFor some drivers don\u0027t support set boot device persistent, the machine will boot from disk. So Ironic need to set boot device again.","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"103e0a0fba7c2e60f1daff574ffa05c2bc582aaa","unresolved":false,"context_lines":[{"line_number":30,"context_line":"During PXE deploy processing, the target machine will boot by itself. Some"},{"line_number":31,"context_line":"Drivers has to set next boot device again in  _continue_deploy()."},{"line_number":32,"context_line":"Add ensure_next_boot_device into base.ManagementInterface to support"},{"line_number":33,"context_line":"this unconditionally."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Alternatives"},{"line_number":36,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_f64be928","line":33,"updated":"2015-01-22 17:10:44.000000000","message":"duplicated \"Add ensure_next_boot_device into base.ManagementInterface...\"","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"103e0a0fba7c2e60f1daff574ffa05c2bc582aaa","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Add a new table driver_internal_info."},{"line_number":44,"context_line":"As one node has only one driver, so driver_internal_info will map to node"},{"line_number":45,"context_line":"as many to one. It only contains id, node_id and key/value pair."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"REST API impact"},{"line_number":48,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_961625a6","line":45,"updated":"2015-01-22 17:10:44.000000000","message":"Please use bullet points to differentiate the changes, it\u0027s hard to know where one change ends and the other starts.\n\n * Add database table driver_internal_info \n \n * As one node has ...","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"103e0a0fba7c2e60f1daff574ffa05c2bc582aaa","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Driver API impact"},{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Add ensure_next_boot_device into base.ManagementInterface."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Nova driver impact"},{"line_number":61,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_b6d241d0","line":58,"updated":"2015-01-22 17:10:44.000000000","message":"I\u0027m a bit confused the reasoning why we need to add an extra method to the management class for this case. Isn\u0027t passing another parameter to the set_boot_device enough? Or even using the \"persistent\" parameter and in case it\u0027s True we save it to the new table.","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"010d2a55056c94efe4c6dc9db24ba9fc548d4fbe","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Driver API impact"},{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Add ensure_next_boot_device into base.ManagementInterface."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Nova driver impact"},{"line_number":61,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_9ae628b3","line":58,"in_reply_to":"1a930d6b_27a7ee0d","updated":"2015-01-23 12:08:16.000000000","message":"Right, let me see if I get it...\n\nBecause right now in Ironic we also don\u0027t support setting multiple boot devices either -- in a certain order. For e.g is not possible to say boot from DISK and then PXE. We only consider the last invoked set_boot_device(), so if you call set_boot_device(DISK) and then set_boot_device(PXE) and reboot the machine, it\u0027s going to PXE boot it (and not boot from DISK and then the second time PXE).\n\nIs that the same case for AMT?\n\nOr, is that AMT only considers the first call instead of the last? Say we have the DISK \u0026 PXE example, if I tell a AMT hardware to boot from DISK, then issue another command saying boot from PXE and reboot it. It will boot from DISK?","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"510e6e85b6e843092237a71573fed5f936f1308c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Driver API impact"},{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Add ensure_next_boot_device into base.ManagementInterface."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Nova driver impact"},{"line_number":61,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_0cbd7cd8","line":58,"in_reply_to":"1a930d6b_9ae628b3","updated":"2015-01-26 02:03:11.000000000","message":"Yes, AMT is the second case, only take the first call.","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"33615e44e3212297caa39dc7004a0b67114ba943","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Driver API impact"},{"line_number":56,"context_line":"-----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Add ensure_next_boot_device into base.ManagementInterface."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Nova driver impact"},{"line_number":61,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_27a7ee0d","line":58,"in_reply_to":"1a930d6b_b6d241d0","updated":"2015-01-23 03:40:36.000000000","message":"Add another parameter to set_boot_device is possible.\n\nFor example, in the case of AMT driver, it doesn\u0027t support  send multiple requests, so \"normal\" set_boot_device will only store the boot_device into DB. AMT driver has  to call \"special\" set_boot_device to really send request to AMT firmware before next boot. \n\nI can add a parameter to distinguish this two behaviors in one function. But I am afraid this will mislead other drivers.\n\nBTW, because this is only need by some drivers: AMT and IPMItool. Alternative is propose this as driver-specific method, and use isinstance() as a condition.","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"103e0a0fba7c2e60f1daff574ffa05c2bc582aaa","unresolved":false,"context_lines":[{"line_number":97,"context_line":"-----------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Primary assignee:"},{"line_number":100,"context_line":"  tan-lin-good@gmail.com"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Work Items"},{"line_number":103,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_16d795c0","line":100,"updated":"2015-01-22 17:10:44.000000000","message":"nit: should be ur launchpad id","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"103e0a0fba7c2e60f1daff574ffa05c2bc582aaa","unresolved":false,"context_lines":[{"line_number":108,"context_line":"Support clean a node\u0027s driver_internal_infos when it changes its driver."},{"line_number":109,"context_line":"Update some drivers with this feature."},{"line_number":110,"context_line":"Add ensure_next_boot_device() to base.ManagementInterface."},{"line_number":111,"context_line":"Update PXE deploy process with this feature."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Dependencies"},{"line_number":114,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_76eff987","line":111,"updated":"2015-01-22 17:10:44.000000000","message":"nit: use bullet points or enumerated list","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"103e0a0fba7c2e60f1daff574ffa05c2bc582aaa","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":124,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":125,"context_line":"None"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Documentation Impact"},{"line_number":128,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a930d6b_f68929cb","line":125,"updated":"2015-01-22 17:10:44.000000000","message":"As a change to the db is being made you will need a migration script","commit_id":"37e9f89d55a5b250f05e571782dae963058eeea7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a273caca700ba03193413f67a83b2d0e4093cf1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* Add a new internal attribute `driver_internal_info` in nodes table,"},{"line_number":27,"context_line":"  which cannot modify by Admin/user by calling node.update API"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Modify node.update to clear `driver_internal_info` when update driver via"},{"line_number":30,"context_line":"  node.update API."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a930d6b_0201c0ae","line":27,"updated":"2015-01-26 09:43:50.000000000","message":"s/modify/be modified/","commit_id":"09777ae52d1226bb0f24f9099dba0c41056f4492"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a273caca700ba03193413f67a83b2d0e4093cf1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"* Add a new internal attribute `driver_internal_info` in nodes table,"},{"line_number":27,"context_line":"  which cannot modify by Admin/user by calling node.update API"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Modify node.update to clear `driver_internal_info` when update driver via"},{"line_number":30,"context_line":"  node.update API."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a930d6b_e293d458","line":29,"updated":"2015-01-26 09:43:50.000000000","message":"s/update driver/driver is changed/","commit_id":"09777ae52d1226bb0f24f9099dba0c41056f4492"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"45abbf02e9ed60f2efda7bb72929d7c8676c1652","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  which cannot modify by Admin/user by calling node.update API"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Modify node.update to clear `driver_internal_info` when update driver via"},{"line_number":30,"context_line":"  node.update API."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a930d6b_113d48c4","line":30,"updated":"2015-01-27 16:22:13.000000000","message":"I was wondering if we should leave it up to the driver to clear or not clear whatever information is there. This might be too restrictive.\n\nYou can\u0027t change the driver associated with a node, just driver info. I can\u0027t think of any case offhand, but what if a driver wanted to store something that shouldn\u0027t be removed (or removed depending on what was updated).","commit_id":"09777ae52d1226bb0f24f9099dba0c41056f4492"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7017cd30b5a89d93ed899b2670f7e0f270619087","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  which cannot modify by Admin/user by calling node.update API"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Modify node.update to clear `driver_internal_info` when update driver via"},{"line_number":30,"context_line":"  node.update API."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a930d6b_d1402009","line":30,"in_reply_to":"1a930d6b_113d48c4","updated":"2015-01-27 16:24:39.000000000","message":"oh, I didn\u0027t realize we can\u0027t change the driver. Then it should not be cleared automagically at all","commit_id":"09777ae52d1226bb0f24f9099dba0c41056f4492"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b5913f55db911a8c0696c902793ac07da92d61f0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  which cannot modify by Admin/user by calling node.update API"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Modify node.update to clear `driver_internal_info` when update driver via"},{"line_number":30,"context_line":"  node.update API."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a930d6b_acd97b58","line":30,"in_reply_to":"1a930d6b_d1402009","updated":"2015-01-27 16:45:42.000000000","message":"When I read this, I wasn\u0027t sure if it meant when the \u0027driver\u0027 field was updated (which I didn\u0027t think was possible but it turns out it is), or whether it meant if any driver-related information was updated. I think you meant the \u0027driver\u0027 field. Which makes sense :-)","commit_id":"09777ae52d1226bb0f24f9099dba0c41056f4492"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a273caca700ba03193413f67a83b2d0e4093cf1","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* Add `driver_internal_info` to the nodes table with a migration."},{"line_number":98,"context_line":"* Update object Node."},{"line_number":99,"context_line":"* Support clean a node\u0027s driver_internal_infos when it changes its driver."},{"line_number":100,"context_line":"* Update some drivers with this feature."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a930d6b_428ae81b","line":99,"updated":"2015-01-26 09:43:50.000000000","message":"s/Support clean/Clean/  s/driver_internal_infos/driver_internal_info/","commit_id":"09777ae52d1226bb0f24f9099dba0c41056f4492"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a273caca700ba03193413f67a83b2d0e4093cf1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"* Add `driver_internal_info` to the nodes table with a migration."},{"line_number":98,"context_line":"* Update object Node."},{"line_number":99,"context_line":"* Support clean a node\u0027s driver_internal_infos when it changes its driver."},{"line_number":100,"context_line":"* Update some drivers with this feature."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Dependencies"},{"line_number":103,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a930d6b_628fe42a","line":100,"updated":"2015-01-26 09:43:50.000000000","message":"some - which?","commit_id":"09777ae52d1226bb0f24f9099dba0c41056f4492"}]}
