)]}'
{"specs/liberty/override-pxe-options-via-glance-property.rst":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7219235fbb4d6cc2fa847e7c58efec33ca57338b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"correctly. Currently, Ironic tries to determine things like the root"},{"line_number":21,"context_line":"filesystem the image is on (\"root\u003d\" kernel command line) by getting the"},{"line_number":22,"context_line":"UUID of the image filesystem and setting as the root\u003d parameter. This"},{"line_number":23,"context_line":"is correct for all images because some may need to boot from a different"},{"line_number":24,"context_line":"root filesystem, e.g:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":" * The device path of its LVM volume [root\u003d/dev/mapper/vg-lv_root]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7ad32947_9d2ceb4b","line":23,"updated":"2015-04-28 09:13:40.000000000","message":"\"This is not correct ...\"","commit_id":"fcd6d8773b7561d7168dd443e4fc2133bdcefb49"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"04f2c2a08a147b7ba81fa9454e243f8eeaf4088c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"correctly. Currently, Ironic tries to determine things like the root"},{"line_number":21,"context_line":"filesystem the image is on (\"root\u003d\" kernel command line) by getting the"},{"line_number":22,"context_line":"UUID of the image filesystem and setting as the root\u003d parameter. This"},{"line_number":23,"context_line":"is correct for all images because some may need to boot from a different"},{"line_number":24,"context_line":"root filesystem, e.g:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":" * The device path of its LVM volume [root\u003d/dev/mapper/vg-lv_root]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5ad0253b_382065f7","line":23,"in_reply_to":"7ad32947_9d2ceb4b","updated":"2015-04-28 16:12:57.000000000","message":"This should be fixed before merging or in a followup patch as it actually changes the meaning of the problem statement :)","commit_id":"fcd6d8773b7561d7168dd443e4fc2133bdcefb49"},{"author":{"_account_id":11042,"name":"chenglch","email":"chenglch@cn.ibm.com","username":"chenglch"},"change_message_id":"0fb9a6c66a4f87ea5b02cd201e580e08886df651","unresolved":false,"context_lines":[{"line_number":52,"context_line":"line from the ``instance_info`` field instead of the default one in"},{"line_number":53,"context_line":"the template. It\u0027s important to note that the values present at the"},{"line_number":54,"context_line":"``pxe_append_params`` configuration option will still be appended at"},{"line_number":55,"context_line":"the end of the image\u0027s custom kernel command line by Ironic."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Setting the keys in the ``instance_info`` field is important because"},{"line_number":58,"context_line":"it also allows Ironic to operate in standalone mode without Glance."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7ad32947_ce22b2b9","line":55,"updated":"2015-04-28 03:19:37.000000000","message":"Does instance_info.kernel_cmdline have pattern parameters?\nIf have, do we need to replace these patterns in  switch_pxe_config?","commit_id":"fcd6d8773b7561d7168dd443e4fc2133bdcefb49"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e3690ad7000c3e65945dad5f84ed9980ba3a7e7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"line from the ``instance_info`` field instead of the default one in"},{"line_number":53,"context_line":"the template. It\u0027s important to note that the values present at the"},{"line_number":54,"context_line":"``pxe_append_params`` configuration option will still be appended at"},{"line_number":55,"context_line":"the end of the image\u0027s custom kernel command line by Ironic."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Setting the keys in the ``instance_info`` field is important because"},{"line_number":58,"context_line":"it also allows Ironic to operate in standalone mode without Glance."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7ad32947_9d5e2be8","line":55,"in_reply_to":"7ad32947_ce22b2b9","updated":"2015-04-28 09:12:15.000000000","message":"No for this spec, the \"instance_info.kernel_cmdline\" line should contain the full command line to boot the image.\n\nThe kernel cmdline set in the pxe_config.template (and variations) to boot the user images will be completed replaced by the \"instance_info.kernel_cmdline\" (if set)","commit_id":"fcd6d8773b7561d7168dd443e4fc2133bdcefb49"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"e158f2f405364f9424848122f3207056cfdb8948","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"In the same way Ironic look at the Glance image properties to find out the"},{"line_number":41,"context_line":"Glance UUID for the image\u0027s kernel and ramdisk (kernel_id and ramdisk_id)"},{"line_number":42,"context_line":"and populate the node\u0027s ``instance_info`` field with the ``kernel`` and"},{"line_number":43,"context_line":"``ramdisk`` keys."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3acd31a7_0f655644","line":40,"updated":"2015-04-29 18:37:45.000000000","message":"nit: s/look/looks/","commit_id":"b921e8e45881d4a34dd8fde26cfa1c77535b5e41"}]}