)]}'
{"specs/approved/cisco-ucs-oob-raid-configuration.rst":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"3a8fe4e8eeca590d0a20b98437cfb311defb77e1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"It proposes implementing the RAID interface as described by parent spec [1] for"},{"line_number":27,"context_line":"UCS drivers."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"List of changes required:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_1513cc0e","line":27,"updated":"2015-08-27 17:11:49.000000000","message":"again, I found \u0027UCS drivers\u0027 (plural) is confusing.","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"8877eae12cd2e33ba1c3adf8c7642e228c73f20a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"It proposes implementing the RAID interface as described by parent spec [1] for"},{"line_number":27,"context_line":"UCS drivers."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"List of changes required:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_51c94177","line":27,"in_reply_to":"da20952f_1513cc0e","updated":"2015-08-31 08:55:18.000000000","message":"As Sam said on other spec, \n\nThere are multiple drivers which use the UCSM power and management driver interfaces: pxe_ucs and agent_ucs","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"3a8fe4e8eeca590d0a20b98437cfb311defb77e1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  respective service-profile ManagedObject. The service-profile information is"},{"line_number":57,"context_line":"  captured as part of node driver_info properties."},{"line_number":58,"context_line":"  UcsSdk provides RAIDHelper interface, which actually creates the required"},{"line_number":59,"context_line":"  policies specified above. UCS driver uses of this interface and makes"},{"line_number":60,"context_line":"  appropriate calls to create_config and delete_config operations."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_aa5f1b40","line":59,"updated":"2015-08-27 17:11:49.000000000","message":"Nit: s/uses of/uses/","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"8877eae12cd2e33ba1c3adf8c7642e228c73f20a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  respective service-profile ManagedObject. The service-profile information is"},{"line_number":57,"context_line":"  captured as part of node driver_info properties."},{"line_number":58,"context_line":"  UcsSdk provides RAIDHelper interface, which actually creates the required"},{"line_number":59,"context_line":"  policies specified above. UCS driver uses of this interface and makes"},{"line_number":60,"context_line":"  appropriate calls to create_config and delete_config operations."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_11bbc9e6","line":59,"in_reply_to":"da20952f_aa5f1b40","updated":"2015-08-31 08:55:18.000000000","message":"Done","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"df1c70e70608345fecd6e29e33c79d65c048c658","unresolved":false,"context_lines":[{"line_number":128,"context_line":"Work Items"},{"line_number":129,"context_line":"----------"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"* Add RAIDInterface inheriting from base.RAIDInterface for ucs drivers."},{"line_number":132,"context_line":"* Writing and unit-test cases for RAID interface of ucs drivers."},{"line_number":133,"context_line":"* Writing configuration documents."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_1c914247","line":131,"updated":"2015-08-31 08:53:38.000000000","message":"Better to avoid the word \"Interface\" in the class because it is actually implementation of the interface.  Something like UcsRaidManagement sounds good to me.","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"2fbdf132494236a70d698de49cade259930b8bf2","unresolved":false,"context_lines":[{"line_number":128,"context_line":"Work Items"},{"line_number":129,"context_line":"----------"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"* Add RAIDInterface inheriting from base.RAIDInterface for ucs drivers."},{"line_number":132,"context_line":"* Writing and unit-test cases for RAID interface of ucs drivers."},{"line_number":133,"context_line":"* Writing configuration documents."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_836aefeb","line":131,"in_reply_to":"da20952f_03c25f34","updated":"2015-09-04 09:46:56.000000000","message":"Done","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"2fbdf132494236a70d698de49cade259930b8bf2","unresolved":false,"context_lines":[{"line_number":128,"context_line":"Work Items"},{"line_number":129,"context_line":"----------"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"* Add RAIDInterface inheriting from base.RAIDInterface for ucs drivers."},{"line_number":132,"context_line":"* Writing and unit-test cases for RAID interface of ucs drivers."},{"line_number":133,"context_line":"* Writing configuration documents."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_43605701","line":131,"in_reply_to":"da20952f_1c914247","updated":"2015-09-04 09:46:56.000000000","message":"Done","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"8877eae12cd2e33ba1c3adf8c7642e228c73f20a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"Work Items"},{"line_number":129,"context_line":"----------"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"* Add RAIDInterface inheriting from base.RAIDInterface for ucs drivers."},{"line_number":132,"context_line":"* Writing and unit-test cases for RAID interface of ucs drivers."},{"line_number":133,"context_line":"* Writing configuration documents."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_5cc25a35","line":131,"in_reply_to":"da20952f_1c914247","updated":"2015-08-31 08:55:18.000000000","message":"Will follow that in implementation.","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"03b85ec2de6806e9452a7fd755805f092a139ca5","unresolved":false,"context_lines":[{"line_number":128,"context_line":"Work Items"},{"line_number":129,"context_line":"----------"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"* Add RAIDInterface inheriting from base.RAIDInterface for ucs drivers."},{"line_number":132,"context_line":"* Writing and unit-test cases for RAID interface of ucs drivers."},{"line_number":133,"context_line":"* Writing configuration documents."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_03c25f34","line":131,"in_reply_to":"da20952f_5cc25a35","updated":"2015-09-04 09:33:08.000000000","message":"+1","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"3a8fe4e8eeca590d0a20b98437cfb311defb77e1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":146,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":147,"context_line":"Adding RAID interface support for ucs drivers will not break any"},{"line_number":148,"context_line":"compatibility with either on REST API or RPC APIs."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Documentation Impact"},{"line_number":151,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_359cd0bf","line":148,"updated":"2015-08-27 17:11:49.000000000","message":"remove \u0027on\u0027?","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"8877eae12cd2e33ba1c3adf8c7642e228c73f20a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":146,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":147,"context_line":"Adding RAID interface support for ucs drivers will not break any"},{"line_number":148,"context_line":"compatibility with either on REST API or RPC APIs."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Documentation Impact"},{"line_number":151,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_f1b735f3","line":148,"in_reply_to":"da20952f_359cd0bf","updated":"2015-08-31 08:55:18.000000000","message":"Done","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"03b85ec2de6806e9452a7fd755805f092a139ca5","unresolved":false,"context_lines":[{"line_number":154,"context_line":"References"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":156,"context_line":".. [1] New driver interface for RAID configuration: https://review.openstack.org/#/c/173214"},{"line_number":157,"context_line":".. [2] Implement Zapping States: https://review.openstack.org/#/c/185122"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_c305477a","line":157,"updated":"2015-09-04 09:33:08.000000000","message":"nit: this [2] reference is not being refereed anywhere","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"2fbdf132494236a70d698de49cade259930b8bf2","unresolved":false,"context_lines":[{"line_number":154,"context_line":"References"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":156,"context_line":".. [1] New driver interface for RAID configuration: https://review.openstack.org/#/c/173214"},{"line_number":157,"context_line":".. [2] Implement Zapping States: https://review.openstack.org/#/c/185122"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_6376bbd8","line":157,"in_reply_to":"da20952f_c305477a","updated":"2015-09-04 09:46:56.000000000","message":"will remove it.","commit_id":"07d11dd7057a7f9918a1ac62ed1fd918e0a3bed1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"bea42d281f1c057e02cc2b3c3e11ee7412e99aa1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"It proposes implementing the RAID interface as described by parent spec [1] for"},{"line_number":27,"context_line":"UCS drivers."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"List of changes required:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da20952f_d4faa474","line":26,"updated":"2015-09-07 06:45:30.000000000","message":"nits: s/by parent spec/by the parent spec/","commit_id":"bb1c92f8c6bfb2f8534182901506cdc6b1c01d34"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"c35f546347c6790c1a64d9e249212e406580e012","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"It proposes implementing the RAID interface as described by parent spec [1] for"},{"line_number":27,"context_line":"UCS drivers."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"List of changes required:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da20952f_c1e3bfa2","line":26,"in_reply_to":"da20952f_d4faa474","updated":"2015-09-07 09:28:33.000000000","message":"Done","commit_id":"bb1c92f8c6bfb2f8534182901506cdc6b1c01d34"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"bea42d281f1c057e02cc2b3c3e11ee7412e99aa1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    validate() method validates the required UCS parameters for OOB RAID"},{"line_number":40,"context_line":"    configuration. Also calls validate() of super class to validate json"},{"line_number":41,"context_line":"    schema."},{"line_number":42,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":43,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."}],"source_content_type":"text/x-rst","patch_set":11,"id":"da20952f_14333c63","line":40,"updated":"2015-09-07 06:45:30.000000000","message":"nits: s/of super class/of the super class/","commit_id":"bb1c92f8c6bfb2f8534182901506cdc6b1c01d34"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"c35f546347c6790c1a64d9e249212e406580e012","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    validate() method validates the required UCS parameters for OOB RAID"},{"line_number":40,"context_line":"    configuration. Also calls validate() of super class to validate json"},{"line_number":41,"context_line":"    schema."},{"line_number":42,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":43,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."}],"source_content_type":"text/x-rst","patch_set":11,"id":"da20952f_2824e00a","line":40,"in_reply_to":"da20952f_14333c63","updated":"2015-09-07 09:28:33.000000000","message":"Done","commit_id":"bb1c92f8c6bfb2f8534182901506cdc6b1c01d34"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"bea42d281f1c057e02cc2b3c3e11ee7412e99aa1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    validate() method validates the required UCS parameters for OOB RAID"},{"line_number":40,"context_line":"    configuration. Also calls validate() of super class to validate json"},{"line_number":41,"context_line":"    schema."},{"line_number":42,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":43,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."},{"line_number":44,"context_line":"    These methods return states.CLEANWAIT. To know the deploy status, need to"},{"line_number":45,"context_line":"    query the FSM status using UcsSdk."}],"source_content_type":"text/x-rst","patch_set":11,"id":"da20952f_94750cfb","line":42,"updated":"2015-09-07 06:45:30.000000000","message":"It would be better to clarify What \"create_configuration and delete_configuration operations are asynchronous\" means.\n\nDoes it mean that create_configuration and delete_configuration operations work simultaneously or concurrently if target nodes are different ?\n\nBecause it doesn\u0027t make sense if create_configuration and delete_configuration operations work simultaneously or concurrently to the same single target node.","commit_id":"bb1c92f8c6bfb2f8534182901506cdc6b1c01d34"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"c35f546347c6790c1a64d9e249212e406580e012","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    validate() method validates the required UCS parameters for OOB RAID"},{"line_number":40,"context_line":"    configuration. Also calls validate() of super class to validate json"},{"line_number":41,"context_line":"    schema."},{"line_number":42,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":43,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."},{"line_number":44,"context_line":"    These methods return states.CLEANWAIT. To know the deploy status, need to"},{"line_number":45,"context_line":"    query the FSM status using UcsSdk."}],"source_content_type":"text/x-rst","patch_set":11,"id":"da20952f_6b45f26c","line":42,"in_reply_to":"da20952f_94750cfb","updated":"2015-09-07 09:28:33.000000000","message":"I\u0027ve tried to explain the same in the following lines of the spec. Actually the driver deploys the RAID configuration simultaneously. But the RAID configuration won\u0027t be applied simultaneously on the target node by UCS Manager. The RAID configuration will be deployed as part of UCSM FSM deploy state. So there will be delay between, when the operation is invoked and when the configuration is actually deployed. So I\u0027ve mentioned them as asynchronous operations. Will update accordingly.","commit_id":"bb1c92f8c6bfb2f8534182901506cdc6b1c01d34"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"bea42d281f1c057e02cc2b3c3e11ee7412e99aa1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    schema."},{"line_number":42,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":43,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."},{"line_number":44,"context_line":"    These methods return states.CLEANWAIT. To know the deploy status, need to"},{"line_number":45,"context_line":"    query the FSM status using UcsSdk."},{"line_number":46,"context_line":"    New periodic task will be added to fetch the UCSM FSM status of these"},{"line_number":47,"context_line":"    operations. Once the configuration deploy is complete, this task sends rpc"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da20952f_34e9a07f","line":44,"updated":"2015-09-07 06:45:30.000000000","message":"nits: s/need to/we need to/","commit_id":"bb1c92f8c6bfb2f8534182901506cdc6b1c01d34"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"c35f546347c6790c1a64d9e249212e406580e012","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    schema."},{"line_number":42,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":43,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."},{"line_number":44,"context_line":"    These methods return states.CLEANWAIT. To know the deploy status, need to"},{"line_number":45,"context_line":"    query the FSM status using UcsSdk."},{"line_number":46,"context_line":"    New periodic task will be added to fetch the UCSM FSM status of these"},{"line_number":47,"context_line":"    operations. Once the configuration deploy is complete, this task sends rpc"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da20952f_0870fc09","line":44,"in_reply_to":"da20952f_34e9a07f","updated":"2015-09-07 09:28:33.000000000","message":"Done","commit_id":"bb1c92f8c6bfb2f8534182901506cdc6b1c01d34"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"bea42d281f1c057e02cc2b3c3e11ee7412e99aa1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    These methods return states.CLEANWAIT. To know the deploy status, need to"},{"line_number":45,"context_line":"    query the FSM status using UcsSdk."},{"line_number":46,"context_line":"    New periodic task will be added to fetch the UCSM FSM status of these"},{"line_number":47,"context_line":"    operations. Once the configuration deploy is complete, this task sends rpc"},{"line_number":48,"context_line":"    message to the conductor to resume cleaning. This periodic task is enabled"},{"line_number":49,"context_line":"    only if pxe_ucs, agent_ucs drivers are enabled in the conductor."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"da20952f_286620ed","line":47,"updated":"2015-09-07 06:45:30.000000000","message":"What is \"the configuration deploy\"?\n\nI interpreted as below, am I correct?\n\ns/Once the configuration deploy is complete/Once the RAID configuration has been completed/","commit_id":"bb1c92f8c6bfb2f8534182901506cdc6b1c01d34"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"c35f546347c6790c1a64d9e249212e406580e012","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    These methods return states.CLEANWAIT. To know the deploy status, need to"},{"line_number":45,"context_line":"    query the FSM status using UcsSdk."},{"line_number":46,"context_line":"    New periodic task will be added to fetch the UCSM FSM status of these"},{"line_number":47,"context_line":"    operations. Once the configuration deploy is complete, this task sends rpc"},{"line_number":48,"context_line":"    message to the conductor to resume cleaning. This periodic task is enabled"},{"line_number":49,"context_line":"    only if pxe_ucs, agent_ucs drivers are enabled in the conductor."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"da20952f_286b801f","line":47,"in_reply_to":"da20952f_286620ed","updated":"2015-09-07 09:28:33.000000000","message":"Yes, will update accordingly.","commit_id":"bb1c92f8c6bfb2f8534182901506cdc6b1c01d34"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"5dbccd979f675610fbeb43b8ac527c78b4ded9f8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    schema."},{"line_number":42,"context_line":"    create_configuration and delete_configuration operations are implemented"},{"line_number":43,"context_line":"    as asynchronous RAID configuration deployment operations by UCS drivers."},{"line_number":44,"context_line":"    UcsSdk/UCS-API asynchrously deploys the RAID configuration on the target"},{"line_number":45,"context_line":"    node. UCS driver(s) sends the RAID configuration simultaniously to the"},{"line_number":46,"context_line":"    target node when the operation is invoked, but UCS Manager would not deploy"},{"line_number":47,"context_line":"    the configuration simultaniouly on the target node. UCS Manager accepts"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da20952f_aace892a","line":44,"updated":"2015-09-08 01:08:38.000000000","message":"s/asynchrously/asynchronously/","commit_id":"e2bea220148170eb00bf966ca010a39f8b48d981"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"2d58117b19622d338f357292404c737e7aec34d7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    schema."},{"line_number":42,"context_line":"    create_configuration and delete_configuration operations are implemented"},{"line_number":43,"context_line":"    as asynchronous RAID configuration deployment operations by UCS drivers."},{"line_number":44,"context_line":"    UcsSdk/UCS-API asynchrously deploys the RAID configuration on the target"},{"line_number":45,"context_line":"    node. UCS driver(s) sends the RAID configuration simultaniously to the"},{"line_number":46,"context_line":"    target node when the operation is invoked, but UCS Manager would not deploy"},{"line_number":47,"context_line":"    the configuration simultaniouly on the target node. UCS Manager accepts"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da20952f_8a5b8553","line":44,"in_reply_to":"da20952f_aace892a","updated":"2015-09-08 01:19:27.000000000","message":"Done","commit_id":"e2bea220148170eb00bf966ca010a39f8b48d981"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"5dbccd979f675610fbeb43b8ac527c78b4ded9f8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    create_configuration and delete_configuration operations are implemented"},{"line_number":43,"context_line":"    as asynchronous RAID configuration deployment operations by UCS drivers."},{"line_number":44,"context_line":"    UcsSdk/UCS-API asynchrously deploys the RAID configuration on the target"},{"line_number":45,"context_line":"    node. UCS driver(s) sends the RAID configuration simultaniously to the"},{"line_number":46,"context_line":"    target node when the operation is invoked, but UCS Manager would not deploy"},{"line_number":47,"context_line":"    the configuration simultaniouly on the target node. UCS Manager accepts"},{"line_number":48,"context_line":"    the RAID configuration and deploys it as part of UCS Manager FSM deploy"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da20952f_cae89d7d","line":45,"updated":"2015-09-08 01:08:38.000000000","message":"s/simultaniously/simultaneously/","commit_id":"e2bea220148170eb00bf966ca010a39f8b48d981"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"2d58117b19622d338f357292404c737e7aec34d7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    create_configuration and delete_configuration operations are implemented"},{"line_number":43,"context_line":"    as asynchronous RAID configuration deployment operations by UCS drivers."},{"line_number":44,"context_line":"    UcsSdk/UCS-API asynchrously deploys the RAID configuration on the target"},{"line_number":45,"context_line":"    node. UCS driver(s) sends the RAID configuration simultaniously to the"},{"line_number":46,"context_line":"    target node when the operation is invoked, but UCS Manager would not deploy"},{"line_number":47,"context_line":"    the configuration simultaniouly on the target node. UCS Manager accepts"},{"line_number":48,"context_line":"    the RAID configuration and deploys it as part of UCS Manager FSM deploy"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da20952f_6a607101","line":45,"in_reply_to":"da20952f_cae89d7d","updated":"2015-09-08 01:19:27.000000000","message":"Done","commit_id":"e2bea220148170eb00bf966ca010a39f8b48d981"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"5dbccd979f675610fbeb43b8ac527c78b4ded9f8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    UcsSdk/UCS-API asynchrously deploys the RAID configuration on the target"},{"line_number":45,"context_line":"    node. UCS driver(s) sends the RAID configuration simultaniously to the"},{"line_number":46,"context_line":"    target node when the operation is invoked, but UCS Manager would not deploy"},{"line_number":47,"context_line":"    the configuration simultaniouly on the target node. UCS Manager accepts"},{"line_number":48,"context_line":"    the RAID configuration and deploys it as part of UCS Manager FSM deploy"},{"line_number":49,"context_line":"    state. Hence there will be delay between, when the operation is invoked"},{"line_number":50,"context_line":"    and when the RAID configuration is deployed. To know the deploy status,"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da20952f_6a04f148","line":47,"updated":"2015-09-08 01:08:38.000000000","message":"s/simultaniouly/simultaneously/","commit_id":"e2bea220148170eb00bf966ca010a39f8b48d981"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"2d58117b19622d338f357292404c737e7aec34d7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    UcsSdk/UCS-API asynchrously deploys the RAID configuration on the target"},{"line_number":45,"context_line":"    node. UCS driver(s) sends the RAID configuration simultaniously to the"},{"line_number":46,"context_line":"    target node when the operation is invoked, but UCS Manager would not deploy"},{"line_number":47,"context_line":"    the configuration simultaniouly on the target node. UCS Manager accepts"},{"line_number":48,"context_line":"    the RAID configuration and deploys it as part of UCS Manager FSM deploy"},{"line_number":49,"context_line":"    state. Hence there will be delay between, when the operation is invoked"},{"line_number":50,"context_line":"    and when the RAID configuration is deployed. To know the deploy status,"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da20952f_2a56f929","line":47,"in_reply_to":"da20952f_6a04f148","updated":"2015-09-08 01:19:27.000000000","message":"Done","commit_id":"e2bea220148170eb00bf966ca010a39f8b48d981"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"520a83c918075fba2d032fef7b7a15efd64a53c5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Out-of-band RAID configuration using Cisco UCS drivers"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/cisco-ucs-oob-raid-configuration"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposes to implement out-of-band RAID configuration interface"},{"line_number":14,"context_line":"for Cisco UCS drivers. This implementation supports configuration of Cisco"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a7e1126_f74bbc57","line":11,"updated":"2015-12-17 12:04:05.000000000","message":"Hi, when you\u0027re going to update this, please change this link to RFE bug 1526362 and use it to track progress.","commit_id":"b7f941c23040b1f9dce66ff1029be04d0664f673"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"74551f35b946962e836bd83c7c187a0fc13bf11e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    states.CLEANWAIT."},{"line_number":53,"context_line":"    New periodic task will be added to fetch the UCSM FSM status of these"},{"line_number":54,"context_line":"    operations. Once the RAID has been completed, this task sends rpc message"},{"line_number":55,"context_line":"    to the ironic-conductor to resume cleaning. This periodic task is enabled"},{"line_number":56,"context_line":"    only if pxe_ucs, agent_ucs drivers are enabled in the conductor."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* RAID management changes:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a29b11f_fea1c794","line":55,"updated":"2015-10-22 12:18:12.000000000","message":"you\u0027re already in ironic-conductor, not need for RPC","commit_id":"b7f941c23040b1f9dce66ff1029be04d0664f673"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"74551f35b946962e836bd83c7c187a0fc13bf11e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    New periodic task will be added to fetch the UCSM FSM status of these"},{"line_number":54,"context_line":"    operations. Once the RAID has been completed, this task sends rpc message"},{"line_number":55,"context_line":"    to the ironic-conductor to resume cleaning. This periodic task is enabled"},{"line_number":56,"context_line":"    only if pxe_ucs, agent_ucs drivers are enabled in the conductor."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* RAID management changes:"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a29b11f_9eac538d","line":56,"updated":"2015-10-22 12:18:12.000000000","message":"just use driver periodic tasks, it will work automatically","commit_id":"b7f941c23040b1f9dce66ff1029be04d0664f673"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"74551f35b946962e836bd83c7c187a0fc13bf11e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":144,"context_line":"* Implement Zapping States - https://review.openstack.org/185122"},{"line_number":145,"context_line":"* New driver interface for RAID configuration - https://review.openstack.org/173214"},{"line_number":146,"context_line":"* UcsSdk to support RAID configuration utility"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Testing"},{"line_number":149,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a29b11f_bea7cfa5","line":146,"updated":"2015-10-22 12:18:12.000000000","message":"any estimates on it?","commit_id":"b7f941c23040b1f9dce66ff1029be04d0664f673"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"42d83d34ab524636e0d30cd5ef58745bfd2ea6f5","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":"* Implement Zapping States - https://review.openstack.org/185122"},{"line_number":144,"context_line":"* New driver interface for RAID configuration - https://review.openstack.org/173214"},{"line_number":145,"context_line":"* UcsSdk to support RAID configuration utility"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"dae33548_6ef6ff8f","line":143,"updated":"2016-02-18 13:57:26.000000000","message":"Zapping replaced by manual cleaning.","commit_id":"dac21b844ece0737142670bbe02d769b50267d22"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"9eeed7ddc1a178a6772ccea9baf12ee44127b0db","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":"* Implement Zapping States - https://review.openstack.org/185122"},{"line_number":144,"context_line":"* New driver interface for RAID configuration - https://review.openstack.org/173214"},{"line_number":145,"context_line":"* UcsSdk to support RAID configuration utility"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"1af94dfe_e0abb7d4","line":143,"in_reply_to":"dae33548_6ef6ff8f","updated":"2016-03-16 21:57:05.000000000","message":"Done","commit_id":"dac21b844ece0737142670bbe02d769b50267d22"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"42d83d34ab524636e0d30cd5ef58745bfd2ea6f5","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Dependencies"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":"* Implement Zapping States - https://review.openstack.org/185122"},{"line_number":144,"context_line":"* New driver interface for RAID configuration - https://review.openstack.org/173214"},{"line_number":145,"context_line":"* UcsSdk to support RAID configuration utility"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":15,"id":"dae33548_8e8c23db","line":144,"updated":"2016-02-18 13:57:26.000000000","message":"It\u0027s already merged and released, no dependency.","commit_id":"dac21b844ece0737142670bbe02d769b50267d22"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"9eeed7ddc1a178a6772ccea9baf12ee44127b0db","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Dependencies"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":"* Implement Zapping States - https://review.openstack.org/185122"},{"line_number":144,"context_line":"* New driver interface for RAID configuration - https://review.openstack.org/173214"},{"line_number":145,"context_line":"* UcsSdk to support RAID configuration utility"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1af94dfe_40bb8b27","line":144,"in_reply_to":"dae33548_8e8c23db","updated":"2016-03-16 21:57:05.000000000","message":"Done","commit_id":"dac21b844ece0737142670bbe02d769b50267d22"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36042302d3b3477485127efcd74d732a722677cb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    states.CLEANWAIT."},{"line_number":53,"context_line":"    New periodic task will be added to fetch the UCSM FSM status of these"},{"line_number":54,"context_line":"    operations. This periodic task is enabled only if pxe_ucs, agent_ucs"},{"line_number":55,"context_line":"    drivers are enabled in the conductor."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* RAID management changes:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"1af94dfe_0847c64b","line":55,"updated":"2016-03-17 14:34:24.000000000","message":"note: this will be a driver periodic task","commit_id":"4e135f82fe50c892f068411de92d241c91947682"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"ba520fb145086b9c9082c8067a68e9f92681e1c8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    states.CLEANWAIT."},{"line_number":53,"context_line":"    New periodic task will be added to fetch the UCSM FSM status of these"},{"line_number":54,"context_line":"    operations. This periodic task is enabled only if pxe_ucs, agent_ucs"},{"line_number":55,"context_line":"    drivers are enabled in the conductor."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* RAID management changes:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"fa0719c6_8deea320","line":55,"in_reply_to":"1af94dfe_0847c64b","updated":"2016-03-21 18:43:01.000000000","message":"Done","commit_id":"4e135f82fe50c892f068411de92d241c91947682"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ba5362682ef4594e3197b1f56338b6e6657c36df","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Alternatives"},{"line_number":69,"context_line":"------------"},{"line_number":70,"context_line":"Operator can change the RAID configuration manually whenever required after"},{"line_number":71,"context_line":"putting the node to MANAGEABLE state. But this has to be done for each node."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Data model impact"},{"line_number":74,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa0719c6_937de170","line":71,"updated":"2016-03-22 22:51:42.000000000","message":"Not even sure this is an alternative as to get from MANAGEABLE -\u003e AVAILABLE requires traversing cleaning, which could tear down the raid.","commit_id":"61a80df4853840e146b700b1a2ae10e895d02de6"}],"specs/liberty/cisco-ucs-oob-raid-configuration.rst":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"fbb14e18e8440ec34bf455ef75f87f337bd7fde2","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * get_logical_disk_properties"},{"line_number":36,"context_line":"    * create_config"},{"line_number":37,"context_line":"    * delete_config"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_5fcb8b72","line":35,"updated":"2015-06-16 11:16:08.000000000","message":"Are you planning add some extra keys/properties in raid configuration ? If so, please mention them. You might need a new schema for the JSON than the default.  Otherwise you might not need to implement get_logical_disk_properties.","commit_id":"afb6a2d55c3f5e53df11b7f51d49ce8f297c4721"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"6296f79b4a78ef3f73511ef6cb6708d0dc5640bb","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * get_logical_disk_properties"},{"line_number":36,"context_line":"    * create_config"},{"line_number":37,"context_line":"    * delete_config"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_651d9c0e","line":35,"in_reply_to":"fa32b979_5fcb8b72","updated":"2015-06-16 12:02:01.000000000","message":"Okay, will update accordingly.","commit_id":"afb6a2d55c3f5e53df11b7f51d49ce8f297c4721"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"fbb14e18e8440ec34bf455ef75f87f337bd7fde2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * get_logical_disk_properties"},{"line_number":36,"context_line":"    * create_config"},{"line_number":37,"context_line":"    * delete_config"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* RAID management changes:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_9f2a732b","line":36,"updated":"2015-06-16 11:16:08.000000000","message":"I hope create_config and delete_config will use the ucs library to do the job. A word on it might be good.","commit_id":"afb6a2d55c3f5e53df11b7f51d49ce8f297c4721"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"6296f79b4a78ef3f73511ef6cb6708d0dc5640bb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * get_logical_disk_properties"},{"line_number":36,"context_line":"    * create_config"},{"line_number":37,"context_line":"    * delete_config"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* RAID management changes:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_2500f4a9","line":36,"in_reply_to":"fa32b979_9f2a732b","updated":"2015-06-16 12:02:01.000000000","message":"Will update.","commit_id":"afb6a2d55c3f5e53df11b7f51d49ce8f297c4721"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"fbb14e18e8440ec34bf455ef75f87f337bd7fde2","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* RAID management changes:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  Controlling the RAID configuration is creating storage-profile ManagedObject"},{"line_number":42,"context_line":"  and associating with the Server object in UCS Manager 2.4. Earlier version"},{"line_number":43,"context_line":"  of UCSM requires to configure LocalDiskConfigPolicy and associate with"},{"line_number":44,"context_line":"  respective service-profile ManagedObject. The service-profile information is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_3fe9e7e6","line":41,"updated":"2015-06-16 11:16:08.000000000","message":"Are all of these in Ironic or are they implemented in Ucs library ?","commit_id":"afb6a2d55c3f5e53df11b7f51d49ce8f297c4721"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"6296f79b4a78ef3f73511ef6cb6708d0dc5640bb","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* RAID management changes:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  Controlling the RAID configuration is creating storage-profile ManagedObject"},{"line_number":42,"context_line":"  and associating with the Server object in UCS Manager 2.4. Earlier version"},{"line_number":43,"context_line":"  of UCSM requires to configure LocalDiskConfigPolicy and associate with"},{"line_number":44,"context_line":"  respective service-profile ManagedObject. The service-profile information is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_0505b0ba","line":41,"in_reply_to":"fa32b979_3fe9e7e6","updated":"2015-06-16 12:02:01.000000000","message":"Ironic has to make the appropriate calls. The updated SDK will provide the RAID configuration interface.","commit_id":"afb6a2d55c3f5e53df11b7f51d49ce8f297c4721"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"66e9fb1a53566ec8b79078d3b2dfb3364de1512a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Dependencies"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":122,"context_line":"* Implement Zapping States - https://review.openstack.org/140826"},{"line_number":123,"context_line":"* UcsSdk to support RAID configuration utility"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Testing"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_1fc1832e","line":123,"updated":"2015-06-16 11:21:29.000000000","message":"Shouldn\u0027t https://blueprints.launchpad.net/ironic/+spec/ironic-generic-raid-interface be a dependency of this??","commit_id":"afb6a2d55c3f5e53df11b7f51d49ce8f297c4721"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"6296f79b4a78ef3f73511ef6cb6708d0dc5640bb","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Dependencies"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":122,"context_line":"* Implement Zapping States - https://review.openstack.org/140826"},{"line_number":123,"context_line":"* UcsSdk to support RAID configuration utility"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Testing"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_85830004","line":123,"in_reply_to":"fa32b979_1fc1832e","updated":"2015-06-16 12:02:01.000000000","message":"Yes, have mentioned in the references, will update here.","commit_id":"afb6a2d55c3f5e53df11b7f51d49ce8f297c4721"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4eae2e044881f362da1e253fd0a24ea274dbab9f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Out-of-band RAID configuration using Cisco UCS drivers"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/cisco-ucs-oob-raid-configuration"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposes to implement out-of-band RAID configuration interface"},{"line_number":14,"context_line":"for Cisco UCS drivers. This implementation supports configuration of Cisco"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_73b210e7","line":11,"updated":"2015-07-28 09:00:29.000000000","message":"+1","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"163cbe392370fe664dcee7ff6ba3f63807233001","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Out-of-band RAID configuration using Cisco UCS drivers"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/cisco-ucs-oob-raid-configuration"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposes to implement out-of-band RAID configuration interface"},{"line_number":14,"context_line":"for Cisco UCS drivers. This implementation supports configuration of Cisco"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_2443e843","line":11,"updated":"2015-07-28 06:01:48.000000000","message":"Looks like this url not working, and try to find cisco raid blueprint, no result[1], so can you double-check if your bp is in invalid status or missing?\n\n[1] https://blueprints.launchpad.net/ironic?searchtext\u003dcisco","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"baf24d3d494bc9e2a31173f9b662b46471eb3f85","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Out-of-band RAID configuration using Cisco UCS drivers"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/cisco-ucs-oob-raid-configuration"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposes to implement out-of-band RAID configuration interface"},{"line_number":14,"context_line":"for Cisco UCS drivers. This implementation supports configuration of Cisco"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_db953a33","line":11,"in_reply_to":"3a50d1a3_2443e843","updated":"2015-07-28 09:22:09.000000000","message":"Done","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"baf24d3d494bc9e2a31173f9b662b46471eb3f85","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Out-of-band RAID configuration using Cisco UCS drivers"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/cisco-ucs-oob-raid-configuration"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposes to implement out-of-band RAID configuration interface"},{"line_number":14,"context_line":"for Cisco UCS drivers. This implementation supports configuration of Cisco"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_7b96663f","line":11,"in_reply_to":"3a50d1a3_73b210e7","updated":"2015-07-28 09:22:09.000000000","message":"Done","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"163cbe392370fe664dcee7ff6ba3f63807233001","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"New RAID interface will be added ucs drivers. It proposes to implement"},{"line_number":27,"context_line":"RAIDInterface as mentioned in the parent spec [1]."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"List of changes required:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_e452e0dd","line":26,"updated":"2015-07-28 06:01:48.000000000","message":"Why new RAID interface have to be added for ucs driver, does this existing raid interface patch [1] not working with cisco system or not? Sorry, I am not familiar with Cisco Hardware, so have such concern.\n\n\nhttps://review.openstack.org/#/c/196003/12/ironic/drivers/base.py\u0026L956","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"baf24d3d494bc9e2a31173f9b662b46471eb3f85","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"New RAID interface will be added ucs drivers. It proposes to implement"},{"line_number":27,"context_line":"RAIDInterface as mentioned in the parent spec [1]."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"List of changes required:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_fbc11630","line":26,"in_reply_to":"3a50d1a3_13faac75","updated":"2015-07-28 09:22:09.000000000","message":"Will update it.","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4eae2e044881f362da1e253fd0a24ea274dbab9f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"New RAID interface will be added ucs drivers. It proposes to implement"},{"line_number":27,"context_line":"RAIDInterface as mentioned in the parent spec [1]."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"List of changes required:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_13faac75","line":26,"in_reply_to":"3a50d1a3_e452e0dd","updated":"2015-07-28 09:00:29.000000000","message":"I believe this is just poorly written, see the second sentence and my comment below for a better understanding. Its proposing implementing the RAID interface as described by [1] for the UCSM drivers","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"fbe9d65bd644c7bfed62be6c9eb82f59af4870a0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"New RAID interface will be added ucs drivers. It proposes to implement"},{"line_number":27,"context_line":"RAIDInterface as mentioned in the parent spec [1]."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"List of changes required:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_ce77e89d","line":27,"updated":"2015-07-27 14:26:36.000000000","message":"Add RAIDInterface to UCS Drivers as described by the parent spec [1]","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"baf24d3d494bc9e2a31173f9b662b46471eb3f85","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"New RAID interface will be added ucs drivers. It proposes to implement"},{"line_number":27,"context_line":"RAIDInterface as mentioned in the parent spec [1]."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"List of changes required:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_db69bafa","line":27,"in_reply_to":"3a50d1a3_ce77e89d","updated":"2015-07-28 09:22:09.000000000","message":"Done","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"163cbe392370fe664dcee7ff6ba3f63807233001","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * create_config"},{"line_number":36,"context_line":"    * delete_config"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* RAID management changes:"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_a42db847","line":36,"updated":"2015-07-28 06:01:48.000000000","message":"How about this abstract interface method *get_properties*, should these be implemented? Because it is abstract method.","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"baf24d3d494bc9e2a31173f9b662b46471eb3f85","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * create_config"},{"line_number":36,"context_line":"    * delete_config"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* RAID management changes:"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_7be426df","line":36,"in_reply_to":"3a50d1a3_533834ee","updated":"2015-07-28 09:22:09.000000000","message":"Done","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4eae2e044881f362da1e253fd0a24ea274dbab9f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * create_config"},{"line_number":36,"context_line":"    * delete_config"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* RAID management changes:"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_533834ee","line":36,"in_reply_to":"3a50d1a3_a42db847","updated":"2015-07-28 09:00:29.000000000","message":"+1","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"baf24d3d494bc9e2a31173f9b662b46471eb3f85","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * create_config"},{"line_number":36,"context_line":"    * delete_config"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* RAID management changes:"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_9be9f2b9","line":36,"in_reply_to":"3a50d1a3_a42db847","updated":"2015-07-28 09:22:09.000000000","message":"Done","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"163cbe392370fe664dcee7ff6ba3f63807233001","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Security impact"},{"line_number":83,"context_line":"---------------"},{"line_number":84,"context_line":"None"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Other end user impact"},{"line_number":87,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_c4d9e458","line":84,"updated":"2015-07-28 06:01:48.000000000","message":"I understand it will involve new security issue if we dont care, so should we take care the UCMS credentials?","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4eae2e044881f362da1e253fd0a24ea274dbab9f","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Security impact"},{"line_number":83,"context_line":"---------------"},{"line_number":84,"context_line":"None"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Other end user impact"},{"line_number":87,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_e8d62e4e","line":84,"in_reply_to":"3a50d1a3_c4d9e458","updated":"2015-07-28 09:00:29.000000000","message":"The required credentials are already needed by Ironic in order to support the driver functionality thats implemented in-tree now, so there should be no change in security between what already exists and adding this new feature to the driver.","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"baf24d3d494bc9e2a31173f9b662b46471eb3f85","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Security impact"},{"line_number":83,"context_line":"---------------"},{"line_number":84,"context_line":"None"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Other end user impact"},{"line_number":87,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_be005c02","line":84,"in_reply_to":"3a50d1a3_e8d62e4e","updated":"2015-07-28 09:22:09.000000000","message":"Thanks sam for clarifying this.","commit_id":"db0fbb1370f5ae7f6410f9baba4f32bb9250219a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4afda3057777a0c297d841f3346e7482ee8309d4","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"List of changes required:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  * ucs.raid.RAIDManagement for RAID configuration operations"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_aeb800c9","line":31,"updated":"2015-07-29 02:19:42.000000000","message":"nit: not intended propertly.","commit_id":"e16c2e66714071c5935f6d82ab568dfe90b9fee0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4afda3057777a0c297d841f3346e7482ee8309d4","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * get_properties"},{"line_number":36,"context_line":"    * create_configuration"},{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_cee22cd5","line":35,"updated":"2015-07-29 02:19:42.000000000","message":"Are you planning to add some new properties to the raid config (I assume because you are extending the one provided by default) ? Might be worth mentioning the new properties that are being added which are not mentioned in the parent spec.  \n\nAnd one more thing, if you are adding new properties, you might require to implement your own validate() as well to make sure that the target raid config passed has the correct value for new attributes (either a different raid schema or extending the current one, i would suggest a new raid schema).","commit_id":"e16c2e66714071c5935f6d82ab568dfe90b9fee0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4afda3057777a0c297d841f3346e7482ee8309d4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * get_properties"},{"line_number":36,"context_line":"    * create_configuration"},{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* RAID management changes:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a50d1a3_4ef61c90","line":36,"updated":"2015-07-29 02:19:42.000000000","message":"Does it happen synchronously or asynchronously.  If synchronously, you have to return None, otherwise states.CLEANING (may be states.CLEANWAIT in future). Might be worth calling out.  Also, might be worth adding a sentence or two for this method - are you planning to add a new root device hint for the root volume ? Are you planning to call raid.update_raid_info() after creating the RAID configuration ?","commit_id":"e16c2e66714071c5935f6d82ab568dfe90b9fee0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a712e6a28acc271bb9dfe3a62971133599dc689d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently pxe_ucs and agent_ucs drivers doesn\u0027t support RAID configuration on"},{"line_number":21,"context_line":"UCSM managed servers."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_50c2c786","line":20,"updated":"2015-08-04 12:41:42.000000000","message":"nit: s/does/do/","commit_id":"ba8bd87bb78699fb0a97da6ade6a04e50df55c45"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"85aa5eebbb2e6819032642ae29d0ad3b3edc1bbe","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently pxe_ucs and agent_ucs drivers doesn\u0027t support RAID configuration on"},{"line_number":21,"context_line":"UCSM managed servers."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_9c2b7c94","line":20,"in_reply_to":"1a4dcd0f_50c2c786","updated":"2015-08-04 19:39:31.000000000","message":"Done","commit_id":"ba8bd87bb78699fb0a97da6ade6a04e50df55c45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a712e6a28acc271bb9dfe3a62971133599dc689d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":40,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."},{"line_number":41,"context_line":"    To know the deploy status, need to query the FSM status using UcsSdk."},{"line_number":42,"context_line":"    These methods return states.CLEANWAIT."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_f0be73fe","line":40,"updated":"2015-08-04 12:41:42.000000000","message":"I assume FSM is something internal to the UCS Manager, right?","commit_id":"ba8bd87bb78699fb0a97da6ade6a04e50df55c45"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"85aa5eebbb2e6819032642ae29d0ad3b3edc1bbe","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":40,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."},{"line_number":41,"context_line":"    To know the deploy status, need to query the FSM status using UcsSdk."},{"line_number":42,"context_line":"    These methods return states.CLEANWAIT."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_9c029c0a","line":40,"in_reply_to":"1a4dcd0f_f0be73fe","updated":"2015-08-04 19:39:31.000000000","message":"Yes, its internal to UCS Manager.","commit_id":"ba8bd87bb78699fb0a97da6ade6a04e50df55c45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a712e6a28acc271bb9dfe3a62971133599dc689d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":130,"context_line":"* Implement Zapping States - https://review.openstack.org/140826"},{"line_number":131,"context_line":"* New driver interface for RAID configuration - https://review.openstack.org/135899"},{"line_number":132,"context_line":"* UcsSdk to support RAID configuration utility"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Testing"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_10bc3f04","line":132,"updated":"2015-08-04 12:41:42.000000000","message":"any estimates on when it will be available?","commit_id":"ba8bd87bb78699fb0a97da6ade6a04e50df55c45"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"85aa5eebbb2e6819032642ae29d0ad3b3edc1bbe","unresolved":false,"context_lines":[{"line_number":129,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":130,"context_line":"* Implement Zapping States - https://review.openstack.org/140826"},{"line_number":131,"context_line":"* New driver interface for RAID configuration - https://review.openstack.org/135899"},{"line_number":132,"context_line":"* UcsSdk to support RAID configuration utility"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Testing"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_19821195","line":132,"in_reply_to":"1a4dcd0f_10bc3f04","updated":"2015-08-04 19:39:31.000000000","message":"Will be available as part of v0.8.2.5, beta is in place. will be released in PyPI by 15thAug.","commit_id":"ba8bd87bb78699fb0a97da6ade6a04e50df55c45"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a712e6a28acc271bb9dfe3a62971133599dc689d","unresolved":false,"context_lines":[{"line_number":147,"context_line":"References"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":"[1] _`New driver interface for RAID configuration`:https://review.openstack.org/#/c/173214"},{"line_number":150,"context_line":"[2] _`Implement Zapping States`:https://review.openstack.org/#/c/185122"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_b0378baf","line":150,"updated":"2015-08-04 12:41:42.000000000","message":"nit: formatting is off here, also links seem unused","commit_id":"ba8bd87bb78699fb0a97da6ade6a04e50df55c45"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"85aa5eebbb2e6819032642ae29d0ad3b3edc1bbe","unresolved":false,"context_lines":[{"line_number":147,"context_line":"References"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":"[1] _`New driver interface for RAID configuration`:https://review.openstack.org/#/c/173214"},{"line_number":150,"context_line":"[2] _`Implement Zapping States`:https://review.openstack.org/#/c/185122"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_94990871","line":150,"in_reply_to":"1a4dcd0f_b0378baf","updated":"2015-08-04 19:39:31.000000000","message":"Done","commit_id":"ba8bd87bb78699fb0a97da6ade6a04e50df55c45"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1885b58fc32ff988014c1bacad3f3d167429b4b6","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * get_properties"},{"line_number":36,"context_line":"    * create_configuration"},{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_d99492e3","line":35,"updated":"2015-08-05 07:17:47.000000000","message":"I had a question on PS3, are we going to add more properties for the raid configuration (like custom parameters for finding out disks, etc) ?  If not, you will probably not require to implement get_properties().\n\nAlso, most likely you need validate() method to make sure that all the parameters (credentials, bmc ip) for out of band raid management are provided.   The validate of ucs.raid.RAIDInterface need to call validate() of super class as well (to validate json schema).","commit_id":"747ff81c66affae6bc3092e5ee442b19481a2a42"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"cdd1cea9b2091b05df0346639863b413fddf758b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  The following methods will be implemented:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * get_properties"},{"line_number":36,"context_line":"    * create_configuration"},{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_ac3b819b","line":35,"in_reply_to":"1a4dcd0f_d99492e3","updated":"2015-08-05 10:10:58.000000000","message":"Sorry, I did not remove this method. The existing schema is sufficient. I\u0027m not adding any new properties.\n\nWill update the bp with validate() method info.","commit_id":"747ff81c66affae6bc3092e5ee442b19481a2a42"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1885b58fc32ff988014c1bacad3f3d167429b4b6","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":40,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."},{"line_number":41,"context_line":"    To know the deploy status, need to query the FSM status using UcsSdk."},{"line_number":42,"context_line":"    These methods return states.CLEANWAIT."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* RAID management changes:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_79ba1e70","line":41,"updated":"2015-08-05 07:17:47.000000000","message":"Are we going to add a new periodic task for this purpose? If so, please mention it.  I think periodic task need to be enabled only if *_ucs drivers are enabled in the conductor.","commit_id":"747ff81c66affae6bc3092e5ee442b19481a2a42"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"cdd1cea9b2091b05df0346639863b413fddf758b","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":40,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."},{"line_number":41,"context_line":"    To know the deploy status, need to query the FSM status using UcsSdk."},{"line_number":42,"context_line":"    These methods return states.CLEANWAIT."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* RAID management changes:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_5dce25b5","line":41,"updated":"2015-08-05 10:10:58.000000000","message":"Will update the bp with this info.","commit_id":"747ff81c66affae6bc3092e5ee442b19481a2a42"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"6d87eb309e44ca57ed0bb505f3cdb582f3f7bb40","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    * create_configuration"},{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    validate method calls validate() of super class as well, to validate json"},{"line_number":40,"context_line":"    schema."},{"line_number":41,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":42,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_e3f8b44b","line":39,"updated":"2015-08-05 10:42:49.000000000","message":"I think you meant to say that validate() method validates the required ucs parameters for out of band raid configuration as well as calls validate() of super class to validate json schema. Right ?","commit_id":"94851467360f324074e83264a6fca3294666b674"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"2278bbb3467d0978db557efc6f76a2561c2a5d0d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    * create_configuration"},{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    validate method calls validate() of super class as well, to validate json"},{"line_number":40,"context_line":"    schema."},{"line_number":41,"context_line":"    create_configuration and delete_configuration operations are asynchronous."},{"line_number":42,"context_line":"    UCS Manager accepts the configuration and deploys it in FSM deploy state."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_d74c4944","line":39,"in_reply_to":"1a4dcd0f_e3f8b44b","updated":"2015-08-05 13:13:05.000000000","message":"yes, will update accordingly. Thank you for pointing it out.","commit_id":"94851467360f324074e83264a6fca3294666b674"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"64e28b447302121b2025c24ab46435a52c92f614","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * validate"},{"line_number":36,"context_line":"    * create_configuration"},{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    validate() method validates the required UCS parameters for OOB RAID"},{"line_number":40,"context_line":"    configuration. Also calls validate() of super class to validate json"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a4dcd0f_bc80d48c","line":37,"updated":"2015-08-10 06:15:04.000000000","message":"I understand this spec depens on ironic-generic-raid-interface bp[1], and will inherit from RAIDInterface common interface, so if it is the case, how about this abstract interface method *get_properties* [2], should these be implemented? Because it is abstract method.\n\n[1] https://blueprints.launchpad.net/ironic/+spec/ironic-generic-raid-interface\n\n\n[2] https://review.openstack.org/#/c/196003/17/ironic/drivers/base.py","commit_id":"9b900b7535f6897175a1373a6dbe4fb1cea8b900"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"2a5f48d1ab9ebf0b496085526a3fa93794a79f49","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * validate"},{"line_number":36,"context_line":"    * create_configuration"},{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    validate() method validates the required UCS parameters for OOB RAID"},{"line_number":40,"context_line":"    configuration. Also calls validate() of super class to validate json"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a4dcd0f_d7c01b2d","line":37,"in_reply_to":"1a4dcd0f_bc80d48c","updated":"2015-08-10 06:34:47.000000000","message":"rameshg87: suggested me to remove it. I thinks special implementation is required only when additional properties are added. I may be wrong.\n\n\tRamakrishnan G\t\tAug 5 12:47 PM\nI had a question on PS3, are we going to add more properties for the raid configuration (like custom parameters for finding out disks, etc) ? If not, you will probably not require to implement get_properties().","commit_id":"9b900b7535f6897175a1373a6dbe4fb1cea8b900"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"85f7029c1a27c59f0bcbb7fa48113fe23e8d3dcf","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    * validate"},{"line_number":36,"context_line":"    * create_configuration"},{"line_number":37,"context_line":"    * delete_configuration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    validate() method validates the required UCS parameters for OOB RAID"},{"line_number":40,"context_line":"    configuration. Also calls validate() of super class to validate json"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a4dcd0f_17d8c3ee","line":37,"in_reply_to":"1a4dcd0f_d7c01b2d","updated":"2015-08-10 06:41:50.000000000","message":"Yes, we depends on that patch, so suggest to revise this section once that patch is land if need, thank you.","commit_id":"9b900b7535f6897175a1373a6dbe4fb1cea8b900"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"64e28b447302121b2025c24ab46435a52c92f614","unresolved":false,"context_lines":[{"line_number":128,"context_line":"Work Items"},{"line_number":129,"context_line":"----------"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"* Add RAID interface to ucs drivers."},{"line_number":132,"context_line":"* Writing and unit-test cases for RAID interface of ucs drivers."},{"line_number":133,"context_line":"* Writing configuration documents."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a4dcd0f_979ff3b3","line":131,"updated":"2015-08-10 06:15:04.000000000","message":"Do we add new UCS RAID interface, or inherit from RAIDInterface common interface, which is defined/implemented by this patch [1]?\n\n[1] https://review.openstack.org/#/c/196003/17/ironic/drivers/base.py","commit_id":"9b900b7535f6897175a1373a6dbe4fb1cea8b900"},{"author":{"_account_id":10662,"name":"Gopi Krishna S","email":"saripurigopi@gmail.com","username":"saripurigopi"},"change_message_id":"2a5f48d1ab9ebf0b496085526a3fa93794a79f49","unresolved":false,"context_lines":[{"line_number":128,"context_line":"Work Items"},{"line_number":129,"context_line":"----------"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"* Add RAID interface to ucs drivers."},{"line_number":132,"context_line":"* Writing and unit-test cases for RAID interface of ucs drivers."},{"line_number":133,"context_line":"* Writing configuration documents."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a4dcd0f_77cfc7b3","line":131,"in_reply_to":"1a4dcd0f_979ff3b3","updated":"2015-08-10 06:34:47.000000000","message":"Inheriting RAIDInterface common interface and implementing UCS specific part.","commit_id":"9b900b7535f6897175a1373a6dbe4fb1cea8b900"}]}
