)]}'
{"specs/liberty/remove-swift-dependency-for-ilo-drivers.rst":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7b7635a315911b2ee104d60c578f9e5a33ba57c3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Scalability impact"},{"line_number":100,"context_line":"------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"None."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Performance Impact"},{"line_number":105,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_33309407","line":102,"updated":"2015-06-19 14:39:58.000000000","message":"It seems that it will have scalability impact as this single web server will have to store all these images, whereas in case of swift there may be lots of machines.","commit_id":"053d2ff85a29e6303a73bccbbd702a5fa0239f22"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ca018dfae696f1b3d40a5a0a545d3547cc6e3bd6","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Scalability impact"},{"line_number":100,"context_line":"------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"None."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Performance Impact"},{"line_number":105,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_56c71f45","line":102,"in_reply_to":"fa32b979_33309407","updated":"2015-06-22 09:43:40.000000000","message":"IMO That is true for other drivers in ironic already. Today other drivers can work without glance/swift while only iLO drivers cannot. How does it explicitly apply to ilo drivers and impacts the ilo drivers alone.","commit_id":"053d2ff85a29e6303a73bccbbd702a5fa0239f22"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7b7635a315911b2ee104d60c578f9e5a33ba57c3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"http_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":118,"context_line":"http_url \u003d http://10.10.1.30/httpboot"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Since the same config variables exists under `[ipxe]` and is required by"},{"line_number":121,"context_line":"ilo drivers to be able to run standalone, we can deprecate the same in `[ipxe]`"},{"line_number":122,"context_line":"and move it under `[deploy]`."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_53a518b3","line":120,"updated":"2015-06-19 14:39:58.000000000","message":"If it will be deprecated, so it seems should be mentioned in upgrades and backwards compatibility.","commit_id":"053d2ff85a29e6303a73bccbbd702a5fa0239f22"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ca018dfae696f1b3d40a5a0a545d3547cc6e3bd6","unresolved":false,"context_lines":[{"line_number":117,"context_line":"http_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":118,"context_line":"http_url \u003d http://10.10.1.30/httpboot"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Since the same config variables exists under `[ipxe]` and is required by"},{"line_number":121,"context_line":"ilo drivers to be able to run standalone, we can deprecate the same in `[ipxe]`"},{"line_number":122,"context_line":"and move it under `[deploy]`."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_b6b54bd1","line":120,"in_reply_to":"fa32b979_53a518b3","updated":"2015-06-22 09:43:40.000000000","message":"Ok. WIll add. As i understand for Liberty it would be retained at both places and can be removed completely in M release from \u0027[ipxe]\u0027. If not Please let me know the process to deprecate the config variables.","commit_id":"053d2ff85a29e6303a73bccbbd702a5fa0239f22"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Today the ilo drivers require swift to host the images like"},{"line_number":21,"context_line":"boot_iso and floppy images."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_2d73efe8","line":20,"updated":"2015-06-23 08:51:36.000000000","message":"This alone is not the problem description.  Also we need to add  \n\n  There are standalone use-cases of Ironic (like bifrost) \n  which are capable of deploying nodes without requiring \n  other Openstack services.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Today the ilo drivers require swift to host the images like"},{"line_number":21,"context_line":"boot_iso and floppy images."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_17f4ca58","line":20,"in_reply_to":"fa32b979_2d73efe8","updated":"2015-06-24 04:55:34.000000000","message":"ok","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Today the ilo drivers require swift to host the images like"},{"line_number":21,"context_line":"boot_iso and floppy images."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_d846c34e","line":21,"updated":"2015-06-23 08:51:36.000000000","message":"Good if we mentioned in detail:\n\n  boot_iso (from which instance boots) and floppy images \n  (to pass parameters to the deploy ramdisk)","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Today the ilo drivers require swift to host the images like"},{"line_number":21,"context_line":"boot_iso and floppy images."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_d7a0a244","line":21,"in_reply_to":"fa32b979_d846c34e","updated":"2015-06-24 04:55:34.000000000","message":"ok","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The ilo drivers can use the webserver to host the images required."},{"line_number":27,"context_line":"The existing swift will continue to work as it should work if"},{"line_number":28,"context_line":"user wants to use the swift."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_0d262bce","line":26,"updated":"2015-06-23 08:51:36.000000000","message":"can use a webserver","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The ilo drivers can use the webserver to host the images required."},{"line_number":27,"context_line":"The existing swift will continue to work as it should work if"},{"line_number":28,"context_line":"user wants to use the swift."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_3790eeec","line":26,"in_reply_to":"fa32b979_0d262bce","updated":"2015-06-24 04:55:34.000000000","message":"ok","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The ilo drivers can use the webserver to host the images required."},{"line_number":27,"context_line":"The existing swift will continue to work as it should work if"},{"line_number":28,"context_line":"user wants to use the swift."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* The driver will check if the image is hosted on a http webserver or glance"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_580cf33a","line":27,"updated":"2015-06-23 08:51:36.000000000","message":"I think you meant to say:\n\n  The existing mechanism of using Swift to host boot ISO and \n  floppy images will be retained as the default behaviour.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The ilo drivers can use the webserver to host the images required."},{"line_number":27,"context_line":"The existing swift will continue to work as it should work if"},{"line_number":28,"context_line":"user wants to use the swift."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* The driver will check if the image is hosted on a http webserver or glance"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_f731260c","line":27,"in_reply_to":"fa32b979_580cf33a","updated":"2015-06-24 04:55:34.000000000","message":"ok.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":27,"context_line":"The existing swift will continue to work as it should work if"},{"line_number":28,"context_line":"user wants to use the swift."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* The driver will check if the image is hosted on a http webserver or glance"},{"line_number":31,"context_line":"  and download the image."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* The automatic boot_iso created during deploy process using iscsi_ilo driver,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_98859b5a","line":30,"updated":"2015-06-23 08:51:36.000000000","message":"The driver will decide if the created images is to be hosted on a http(s) web server or glance.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"The existing swift will continue to work as it should work if"},{"line_number":28,"context_line":"user wants to use the swift."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* The driver will check if the image is hosted on a http webserver or glance"},{"line_number":31,"context_line":"  and download the image."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* The automatic boot_iso created during deploy process using iscsi_ilo driver,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_0227a6b6","line":30,"in_reply_to":"fa32b979_98859b5a","updated":"2015-06-24 04:55:34.000000000","message":"This is in regards to the images (kernel and ramdisk) provided in the driver_info","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  Since the same config variables exists under `[ipxe]` and is required by"},{"line_number":48,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"},{"line_number":49,"context_line":"  `[ipxe]` and move it under `[deploy]`."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_58a873db","line":49,"updated":"2015-06-23 08:51:36.000000000","message":"It\u0027s currently in [pxe]","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  Since the same config variables exists under `[ipxe]` and is required by"},{"line_number":48,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"},{"line_number":49,"context_line":"  `[ipxe]` and move it under `[deploy]`."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_222c2a98","line":49,"in_reply_to":"fa32b979_58a873db","updated":"2015-06-24 04:55:34.000000000","message":"ohk","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Driver API impact"},{"line_number":83,"context_line":"-----------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"This is a new feature for ilo drivers and backward compatibility to use"},{"line_number":86,"context_line":"swift would be taken care."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Nova driver impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_f8ddc770","line":85,"updated":"2015-06-23 08:51:36.000000000","message":"This is not an impact to Driver API. Change is to iLO driver alone.  This should be None.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Driver API impact"},{"line_number":83,"context_line":"-----------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"This is a new feature for ilo drivers and backward compatibility to use"},{"line_number":86,"context_line":"swift would be taken care."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Nova driver impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_8297368f","line":85,"in_reply_to":"fa32b979_f8ddc770","updated":"2015-06-24 04:55:34.000000000","message":"k","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Nova driver impact"},{"line_number":89,"context_line":"------------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"None. As Nova canot accept the images from the http webserver."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Security impact"},{"line_number":94,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_38ca4fa2","line":91,"updated":"2015-06-23 08:51:36.000000000","message":"Better to just say None.  Nova doesn\u0027t know anything about Ironic drivers or iLO driver.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Nova driver impact"},{"line_number":89,"context_line":"------------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"None. As Nova canot accept the images from the http webserver."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Security impact"},{"line_number":94,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_428dae7a","line":91,"in_reply_to":"fa32b979_38ca4fa2","updated":"2015-06-24 04:55:34.000000000","message":"k","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Other end user impact"},{"line_number":99,"context_line":"---------------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"User needs to provide `kernel` and `ramdisk` in the node.instance_info"},{"line_number":102,"context_line":"for automatic boot_iso creation."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Scalability impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_785e97ea","line":101,"updated":"2015-06-23 08:51:36.000000000","message":"This is already there for standalone use case.  Nothing is being added new for this.  This should be None.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Other end user impact"},{"line_number":99,"context_line":"---------------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"User needs to provide `kernel` and `ramdisk` in the node.instance_info"},{"line_number":102,"context_line":"for automatic boot_iso creation."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Scalability impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_c2ef7e1b","line":101,"in_reply_to":"fa32b979_785e97ea","updated":"2015-06-24 04:55:34.000000000","message":"k","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":115,"context_line":"---------------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The http webserver configuration is out of scope of ironic but it should be"},{"line_number":118,"context_line":"configured on the conductor node."},{"line_number":119,"context_line":"User needs to manually configure the weserver, and add the config options"},{"line_number":120,"context_line":"in ironic.conf under `deploy` as:"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_b86c1f9d","line":118,"updated":"2015-06-23 08:51:36.000000000","message":"configured on every conductor node.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"---------------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The http webserver configuration is out of scope of ironic but it should be"},{"line_number":118,"context_line":"configured on the conductor node."},{"line_number":119,"context_line":"User needs to manually configure the weserver, and add the config options"},{"line_number":120,"context_line":"in ironic.conf under `deploy` as:"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_a2c27a83","line":118,"in_reply_to":"fa32b979_b86c1f9d","updated":"2015-06-24 04:55:34.000000000","message":"ok.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":122,"context_line":"http_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":123,"context_line":"http_url \u003d http://10.10.1.30/httpboot"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Since the same config variables exists under `[ipxe]` and is required by"},{"line_number":126,"context_line":"ilo drivers to be able to run standalone, we can deprecate the same in `[ipxe]`"},{"line_number":127,"context_line":"and move it under `[deploy]`."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_f8f947c9","line":125,"updated":"2015-06-23 08:51:36.000000000","message":"[pxe]","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":143,"context_line":"Work Items"},{"line_number":144,"context_line":"----------"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"* To add the config variables in ironic.conf file."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* To enable http webserver in ilo drivers."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_b81adf15","line":146,"updated":"2015-06-23 08:51:36.000000000","message":"Wouldn\u0027t it be better if it is split as \n\n * Modify ipxe to use config variables from `[deploy]` section\n * Enable support for using webserver instead of Swift in ilo drivers.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":143,"context_line":"Work Items"},{"line_number":144,"context_line":"----------"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"* To add the config variables in ironic.conf file."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* To enable http webserver in ilo drivers."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_6266b2bc","line":146,"in_reply_to":"fa32b979_b81adf15","updated":"2015-06-24 04:55:34.000000000","message":"it is there as third item. i will reorder.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Testing"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* Functional tests to ensure that the deploy works fine for ilo drivers"},{"line_number":161,"context_line":"  with swift/glance as backend or http webserver as backend."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Upgrades and Backwards Compatibility"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_78ba17e3","line":160,"updated":"2015-06-23 08:51:36.000000000","message":"Where are you planning to add these tests ?","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Testing"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* Functional tests to ensure that the deploy works fine for ilo drivers"},{"line_number":161,"context_line":"  with swift/glance as backend or http webserver as backend."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Upgrades and Backwards Compatibility"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_62fd52b0","line":160,"in_reply_to":"fa32b979_78ba17e3","updated":"2015-06-24 04:55:34.000000000","message":"I didnt mean for adding these. I meant these will be executed.\nWe can add these in our nightly tests or CI tests.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"655283cfa27e0fd00901558730f8792d3d2db835","unresolved":false,"context_lines":[{"line_number":163,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"The ilo drivers will continue to work with glance/swift as backend."},{"line_number":167,"context_line":"The iPXE code will continue to work for config options in either of the"},{"line_number":168,"context_line":"section."},{"line_number":169,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_18caeb6e","line":166,"updated":"2015-06-23 08:51:36.000000000","message":"There is no role of glance here.  I think it\u0027s direct with Swift.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0ac82575fdb0618440d7bee071e534e727e05a9","unresolved":false,"context_lines":[{"line_number":163,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"The ilo drivers will continue to work with glance/swift as backend."},{"line_number":167,"context_line":"The iPXE code will continue to work for config options in either of the"},{"line_number":168,"context_line":"section."},{"line_number":169,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_022d6645","line":166,"in_reply_to":"fa32b979_18caeb6e","updated":"2015-06-24 04:55:34.000000000","message":"ok.","commit_id":"501ca1a384a6257ea3e71d3178ad8cde5fee7582"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"45f6b672f7d90587233913eedf3c4ec282f93202","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Today the ilo drivers require swift to host the images like"},{"line_number":24,"context_line":"boot_iso (from which the instance boots) and floppy images"},{"line_number":25,"context_line":"(used for passing parameters to deploy ramdisk)."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_820df63f","line":23,"updated":"2015-06-24 04:45:51.000000000","message":"May be better to mention about the drivers - iscsi_ilo and agent_ilo","commit_id":"58656dca3cb55333fd5b33b9bd30d8cecde876e3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"45f6b672f7d90587233913eedf3c4ec282f93202","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The ilo drivers can use a webserver to host the images required."},{"line_number":31,"context_line":"The existing mechanism of using swift to host boot_iso and floppy"},{"line_number":32,"context_line":"images would be retained as the default behavior."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_42036e10","line":30,"updated":"2015-06-24 04:45:51.000000000","message":"iscsi_ilo and agent_ilo drivers","commit_id":"58656dca3cb55333fd5b33b9bd30d8cecde876e3"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"f28c439fa8f4d7c3015ef12c6860567018965072","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The ilo drivers can use a webserver to host the images required."},{"line_number":31,"context_line":"The existing mechanism of using swift to host boot_iso and floppy"},{"line_number":32,"context_line":"images would be retained as the default behavior."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_55e807e2","line":30,"in_reply_to":"fa32b979_42036e10","updated":"2015-06-24 07:03:13.000000000","message":"ok","commit_id":"58656dca3cb55333fd5b33b9bd30d8cecde876e3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"45f6b672f7d90587233913eedf3c4ec282f93202","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The ilo drivers can use a webserver to host the images required."},{"line_number":31,"context_line":"The existing mechanism of using swift to host boot_iso and floppy"},{"line_number":32,"context_line":"images would be retained as the default behavior."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* The driver will check if the image is hosted on a http webserver or glance"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_6200f202","line":31,"updated":"2015-06-24 04:45:51.000000000","message":"The existing behaviour\n\ns/boot_iso/boot ISO","commit_id":"58656dca3cb55333fd5b33b9bd30d8cecde876e3"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"f28c439fa8f4d7c3015ef12c6860567018965072","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The ilo drivers can use a webserver to host the images required."},{"line_number":31,"context_line":"The existing mechanism of using swift to host boot_iso and floppy"},{"line_number":32,"context_line":"images would be retained as the default behavior."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* The driver will check if the image is hosted on a http webserver or glance"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_b5de333c","line":31,"in_reply_to":"fa32b979_6200f202","updated":"2015-06-24 07:03:13.000000000","message":"ok","commit_id":"58656dca3cb55333fd5b33b9bd30d8cecde876e3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"45f6b672f7d90587233913eedf3c4ec282f93202","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* The driver will check if the image is hosted on a http webserver or glance"},{"line_number":35,"context_line":"  and download the image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The automatic boot_iso created during deploy process using iscsi_ilo driver,"},{"line_number":38,"context_line":"  will be hosted on swift or http webserver as per the config variable under"},{"line_number":39,"context_line":"  `[ilo]` in ironic.conf:"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_6229d29a","line":37,"updated":"2015-06-24 04:45:51.000000000","message":"The boot_iso generated during deploy process by iscsi_ilo driver\n\nAlso may be good to mention floppy images\n\nThe boot ISO (by iscsi_ilo driver) and floppy image (by both iscsi_ilo and agent_ilo driver) generated during deploy process will be hosted on Swift or HTTP(s) web server as per ....","commit_id":"58656dca3cb55333fd5b33b9bd30d8cecde876e3"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"f28c439fa8f4d7c3015ef12c6860567018965072","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* The driver will check if the image is hosted on a http webserver or glance"},{"line_number":35,"context_line":"  and download the image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The automatic boot_iso created during deploy process using iscsi_ilo driver,"},{"line_number":38,"context_line":"  will be hosted on swift or http webserver as per the config variable under"},{"line_number":39,"context_line":"  `[ilo]` in ironic.conf:"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_95d9af58","line":37,"in_reply_to":"fa32b979_6229d29a","updated":"2015-06-24 07:03:13.000000000","message":"ok","commit_id":"58656dca3cb55333fd5b33b9bd30d8cecde876e3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"45f6b672f7d90587233913eedf3c4ec282f93202","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  Since the same config variables exists under `[pxe]` and is required by"},{"line_number":52,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"},{"line_number":53,"context_line":"  `[pxe]` and move it under `[deploy]`."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_fd26e7b8","line":54,"updated":"2015-06-24 04:45:51.000000000","message":"Also, we need to mention about take over.  I missed that part in the previous patch.  Now iLO drivers needs take over if use_web_server\u003dTrue.  This would be applicable in both wait-call-back and active states.  In take over, iLO driver will need to:\n\nFor wait-call-back state: Re-generate floppy image\nFor active: Re-generate BOOT ISO","commit_id":"58656dca3cb55333fd5b33b9bd30d8cecde876e3"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"f28c439fa8f4d7c3015ef12c6860567018965072","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  Since the same config variables exists under `[pxe]` and is required by"},{"line_number":52,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"},{"line_number":53,"context_line":"  `[pxe]` and move it under `[deploy]`."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Alternatives"},{"line_number":57,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_f5d83b55","line":54,"in_reply_to":"fa32b979_fd26e7b8","updated":"2015-06-24 07:03:13.000000000","message":"Ok","commit_id":"58656dca3cb55333fd5b33b9bd30d8cecde876e3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"45f6b672f7d90587233913eedf3c4ec282f93202","unresolved":false,"context_lines":[{"line_number":158,"context_line":"Testing"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"* Functional tests to ensure that the deploy works fine for ilo drivers"},{"line_number":162,"context_line":"  with swift as backend or http webserver as backend."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Upgrades and Backwards Compatibility"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_bd1cdf66","line":161,"updated":"2015-06-24 04:45:51.000000000","message":"Where are you planning to add these functional tests ?","commit_id":"58656dca3cb55333fd5b33b9bd30d8cecde876e3"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"f28c439fa8f4d7c3015ef12c6860567018965072","unresolved":false,"context_lines":[{"line_number":158,"context_line":"Testing"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"* Functional tests to ensure that the deploy works fine for ilo drivers"},{"line_number":162,"context_line":"  with swift as backend or http webserver as backend."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Upgrades and Backwards Compatibility"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_35eb03de","line":161,"in_reply_to":"fa32b979_bd1cdf66","updated":"2015-06-24 07:03:13.000000000","message":"i replied in previous comment.","commit_id":"58656dca3cb55333fd5b33b9bd30d8cecde876e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1bd389afb442b02e7529b4d8305e236378339532","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The ilo drivers (iscsi_ilo and agent_ilo) can use a webserver to"},{"line_number":31,"context_line":"host the images required. Swift would be used as a default backend"},{"line_number":32,"context_line":"to host boot ISO and floppy images for these drivers."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_85925d4a","line":30,"updated":"2015-06-26 14:20:38.000000000","message":"nit: s/webserver/web server/","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"859a7d0374640493ad1f0cd5a864c8dcc4d510c3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The ilo drivers (iscsi_ilo and agent_ilo) can use a webserver to"},{"line_number":31,"context_line":"host the images required. Swift would be used as a default backend"},{"line_number":32,"context_line":"to host boot ISO and floppy images for these drivers."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba3cc151_e336b602","line":30,"in_reply_to":"fa32b979_85925d4a","updated":"2015-06-30 04:21:21.000000000","message":"ok","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1bd389afb442b02e7529b4d8305e236378339532","unresolved":false,"context_lines":[{"line_number":37,"context_line":"* The automatic boot_iso created (as required by iscsi_ilo) and floppy images"},{"line_number":38,"context_line":"  (as required by both agent_ilo and iscsi_ilo) during deploy process,"},{"line_number":39,"context_line":"  will be hosted on swift or http webserver as per the config variable under"},{"line_number":40,"context_line":"  `[ilo]` in ironic.conf:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  use_web_server\u003dTrue"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_2597d13b","line":40,"updated":"2015-06-26 14:20:38.000000000","message":"formatting: please use ::","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"859a7d0374640493ad1f0cd5a864c8dcc4d510c3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"* The automatic boot_iso created (as required by iscsi_ilo) and floppy images"},{"line_number":38,"context_line":"  (as required by both agent_ilo and iscsi_ilo) during deploy process,"},{"line_number":39,"context_line":"  will be hosted on swift or http webserver as per the config variable under"},{"line_number":40,"context_line":"  `[ilo]` in ironic.conf:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  use_web_server\u003dTrue"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba3cc151_a340ae57","line":40,"in_reply_to":"fa32b979_2597d13b","updated":"2015-06-30 04:21:21.000000000","message":"ok","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1bd389afb442b02e7529b4d8305e236378339532","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  The default value would be False and will default to use swift."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* User needs to manually configure the webserver, and add the config options"},{"line_number":47,"context_line":"  in ironic.conf under `deploy` as:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  http_server_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":50,"context_line":"  http_server_url \u003d http://10.10.1.30/httpboot"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_459c555d","line":47,"updated":"2015-06-26 14:20:38.000000000","message":"ditto","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"859a7d0374640493ad1f0cd5a864c8dcc4d510c3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  The default value would be False and will default to use swift."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* User needs to manually configure the webserver, and add the config options"},{"line_number":47,"context_line":"  in ironic.conf under `deploy` as:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  http_server_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":50,"context_line":"  http_server_url \u003d http://10.10.1.30/httpboot"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba3cc151_632386be","line":47,"in_reply_to":"fa32b979_459c555d","updated":"2015-06-30 04:21:21.000000000","message":"ok","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1bd389afb442b02e7529b4d8305e236378339532","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Since the same config variables exists under `[pxe]` and is required by"},{"line_number":53,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"},{"line_number":54,"context_line":"  `[pxe]` and move it under `[deploy]`."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* To add the functionality of take_over() to ilo drivers. This is to enable"},{"line_number":57,"context_line":"  a case when the conductor node goes down and other conductor takes over the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_e5a1e996","line":54,"updated":"2015-06-26 14:20:38.000000000","message":"I would prefer separate setting, there\u0027s little point in mixing iPXE and ilo files (though a lot of people probably will do it)","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"859a7d0374640493ad1f0cd5a864c8dcc4d510c3","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Since the same config variables exists under `[pxe]` and is required by"},{"line_number":53,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"},{"line_number":54,"context_line":"  `[pxe]` and move it under `[deploy]`."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* To add the functionality of take_over() to ilo drivers. This is to enable"},{"line_number":57,"context_line":"  a case when the conductor node goes down and other conductor takes over the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba3cc151_630aa628","line":54,"in_reply_to":"fa32b979_e5a1e996","updated":"2015-06-30 04:21:21.000000000","message":"if i get more comments on keeping them seperate i will not do any changes to ipxe. The above is an opinion from one of the core member Ramakrishnan G","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1bd389afb442b02e7529b4d8305e236378339532","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  scenarios:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  for wait_call_back state: implement regeneration of floppy images."},{"line_number":62,"context_line":"  for active state : implement regeneration of boot ISO."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_059f2d51","line":62,"updated":"2015-06-26 14:20:38.000000000","message":"please convert this to a proper list","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"859a7d0374640493ad1f0cd5a864c8dcc4d510c3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  scenarios:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  for wait_call_back state: implement regeneration of floppy images."},{"line_number":62,"context_line":"  for active state : implement regeneration of boot ISO."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba3cc151_b5ff8100","line":62,"in_reply_to":"fa32b979_059f2d51","updated":"2015-06-30 04:21:21.000000000","message":"k","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1bd389afb442b02e7529b4d8305e236378339532","unresolved":false,"context_lines":[{"line_number":128,"context_line":"The http webserver configuration is out of scope of ironic but it should be"},{"line_number":129,"context_line":"configured on every conductor node."},{"line_number":130,"context_line":"User needs to manually configure the weserver, and add the config options"},{"line_number":131,"context_line":"in ironic.conf under `deploy` as:"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"http_server_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":134,"context_line":"http_server_url \u003d http://10.10.1.30/httpboot"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_a5abe174","line":131,"updated":"2015-06-26 14:20:38.000000000","message":"formatting: use ::","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"859a7d0374640493ad1f0cd5a864c8dcc4d510c3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"The http webserver configuration is out of scope of ironic but it should be"},{"line_number":129,"context_line":"configured on every conductor node."},{"line_number":130,"context_line":"User needs to manually configure the weserver, and add the config options"},{"line_number":131,"context_line":"in ironic.conf under `deploy` as:"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"http_server_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":134,"context_line":"http_server_url \u003d http://10.10.1.30/httpboot"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba3cc151_950efd32","line":131,"in_reply_to":"fa32b979_a5abe174","updated":"2015-06-30 04:21:21.000000000","message":"k","commit_id":"ad6670afd2e661ab5455f37e23f58d37634af1c7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c93e2d912d10f11b6002e1125341c07d067a00ec","unresolved":false,"context_lines":[{"line_number":32,"context_line":"to host boot ISO and floppy images for these drivers."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* The driver will check if the image is hosted on a http webserver or glance"},{"line_number":35,"context_line":"  and download the image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The automatic boot_iso created (as required by iscsi_ilo) and floppy images"},{"line_number":38,"context_line":"  (as required by both agent_ilo and iscsi_ilo) during deploy process,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_ba750599","line":35,"updated":"2015-06-30 20:38:52.000000000","message":"By \u0027image\u0027, do you mean floppy images only, and/or boot ISOs?\n\nAnd you mention glance here.","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"08f753f8b66fa7f78a948d835fb2aa9583953029","unresolved":false,"context_lines":[{"line_number":32,"context_line":"to host boot ISO and floppy images for these drivers."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* The driver will check if the image is hosted on a http webserver or glance"},{"line_number":35,"context_line":"  and download the image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The automatic boot_iso created (as required by iscsi_ilo) and floppy images"},{"line_number":38,"context_line":"  (as required by both agent_ilo and iscsi_ilo) during deploy process,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_49a0ab43","line":35,"in_reply_to":"ba3cc151_ba750599","updated":"2015-07-01 04:28:43.000000000","message":"Here the image means the final OS image, kernel and ramdisk which are prerequiste for the drivers i.e. the mandatory info given in driver_info and instance_info.\n\nI mentioned glance here because these images are generally uploaded at glance, correct?(if http webserver is not being used)","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c93e2d912d10f11b6002e1125341c07d067a00ec","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    use_web_server\u003dTrue"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  The default value would be `False` and will default to use swift."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* User needs to manually configure the webserver, and add the config options"},{"line_number":47,"context_line":"  in ironic.conf under `deploy` as::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_ba898528","line":44,"updated":"2015-06-30 20:38:52.000000000","message":"How do you specify if you want to use glance?\n\nI almost wonder if we should avoid these binary (True/False) config variables. In case some third mechanism shows up, like some new image-hosting-service.\n\nWhat do you think about eg \u0027image-service\u0027, although swift is \u0027object storage\u0027.\n\n\u0027use_web_server\u0027 seems too generic. use web server for what?","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"48aa621f6bcce69290da6b2dddcabafdbc593ca8","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    use_web_server\u003dTrue"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  The default value would be `False` and will default to use swift."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* User needs to manually configure the webserver, and add the config options"},{"line_number":47,"context_line":"  in ironic.conf under `deploy` as::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_a14f03bc","line":44,"in_reply_to":"ba3cc151_ba898528","updated":"2015-07-01 09:37:27.000000000","message":"For the boot_iso and floppy images ilo drivers currently use swift. This dependency is being removed to use http web server. It has not used glance for storing these images.\n\nI could not get the idea of \"image_service\" completely, but as i understand, it should implement something like :\n\nif image_service \u003d\u003d \"swift\":\n    do existing things\nelse if image_service \u003d\u003d \"http web server\":\n    use http web server.\n\nDo you mean above?\n\nWill it be better to rename it as \"use_http_web_server_for_images\"? Does that sound OK?","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c93e2d912d10f11b6002e1125341c07d067a00ec","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  in ironic.conf under `deploy` as::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    http_server_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":50,"context_line":"    http_server_url \u003d http://10.10.1.30/httpboot"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Since the same config variables exists under `[pxe]` and is required by"},{"line_number":53,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_faf38d9c","line":50,"updated":"2015-06-30 20:38:52.000000000","message":"are these examples, or are you proposing these as default values?","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"08f753f8b66fa7f78a948d835fb2aa9583953029","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  in ironic.conf under `deploy` as::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    http_server_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":50,"context_line":"    http_server_url \u003d http://10.10.1.30/httpboot"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Since the same config variables exists under `[pxe]` and is required by"},{"line_number":53,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_a91cd777","line":50,"in_reply_to":"ba3cc151_faf38d9c","updated":"2015-07-01 04:28:43.000000000","message":"These are examples. i will keep the same values for these variables as they exist in the config file today under [pxe]","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"063fa429b05dfaa17ee779b31838cc6e26cdf6e5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    http_server_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":50,"context_line":"    http_server_url \u003d http://10.10.1.30/httpboot"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Since the same config variables exists under `[pxe]` and is required by"},{"line_number":53,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"},{"line_number":54,"context_line":"  `[pxe]` and move it under `[deploy]`."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_4ebd3467","line":52,"updated":"2015-06-30 14:12:33.000000000","message":"nit: s/is/are/","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"08f753f8b66fa7f78a948d835fb2aa9583953029","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    http_server_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":50,"context_line":"    http_server_url \u003d http://10.10.1.30/httpboot"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Since the same config variables exists under `[pxe]` and is required by"},{"line_number":53,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"},{"line_number":54,"context_line":"  `[pxe]` and move it under `[deploy]`."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_090e233b","line":52,"in_reply_to":"ba3cc151_4ebd3467","updated":"2015-07-01 04:28:43.000000000","message":"k","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c93e2d912d10f11b6002e1125341c07d067a00ec","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Since the same config variables exists under `[pxe]` and is required by"},{"line_number":53,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"},{"line_number":54,"context_line":"  `[pxe]` and move it under `[deploy]`."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* To add the functionality of take_over() to ilo drivers. This is to enable"},{"line_number":57,"context_line":"  a case when the conductor node goes down and other conductor takes over the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_1a4671bf","line":54,"updated":"2015-06-30 20:38:52.000000000","message":"Note the existing defaults; for http_root \u003d /httpboot, http_url \u003d None","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"08f753f8b66fa7f78a948d835fb2aa9583953029","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Since the same config variables exists under `[pxe]` and is required by"},{"line_number":53,"context_line":"  ilo drivers to be able to run standalone, we can deprecate the same in"},{"line_number":54,"context_line":"  `[pxe]` and move it under `[deploy]`."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* To add the functionality of take_over() to ilo drivers. This is to enable"},{"line_number":57,"context_line":"  a case when the conductor node goes down and other conductor takes over the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_c907db1a","line":54,"in_reply_to":"ba3cc151_1a4671bf","updated":"2015-07-01 04:28:43.000000000","message":"I will keep the same defaults.","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c93e2d912d10f11b6002e1125341c07d067a00ec","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"The http webserver configuration is out of scope of ironic but it should be"},{"line_number":130,"context_line":"configured on every conductor node."},{"line_number":131,"context_line":"User needs to manually configure the weserver, and add the config options"},{"line_number":132,"context_line":"in ironic.conf under `deploy` as::"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    http_server_root \u003d /opt/stack/ironic/data/httpboot"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_7a6e9d02","line":131,"updated":"2015-06-30 20:38:52.000000000","message":"s/weserver/web server/","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"48aa621f6bcce69290da6b2dddcabafdbc593ca8","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"The http webserver configuration is out of scope of ironic but it should be"},{"line_number":130,"context_line":"configured on every conductor node."},{"line_number":131,"context_line":"User needs to manually configure the weserver, and add the config options"},{"line_number":132,"context_line":"in ironic.conf under `deploy` as::"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    http_server_root \u003d /opt/stack/ironic/data/httpboot"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_a1306302","line":131,"in_reply_to":"ba3cc151_7a6e9d02","updated":"2015-07-01 09:37:27.000000000","message":"ok","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"063fa429b05dfaa17ee779b31838cc6e26cdf6e5","unresolved":false,"context_lines":[{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"* Functional tests to ensure that the deploy works fine for ilo drivers"},{"line_number":173,"context_line":"  with swift as backend or http webserver as backend."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_6ec038e1","line":173,"updated":"2015-06-30 14:12:33.000000000","message":"Ironic currently does not have functional tests, you probably meant integration ones (in tempest)","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"08f753f8b66fa7f78a948d835fb2aa9583953029","unresolved":false,"context_lines":[{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"* Functional tests to ensure that the deploy works fine for ilo drivers"},{"line_number":173,"context_line":"  with swift as backend or http webserver as backend."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_2c3775e4","line":173,"in_reply_to":"ba3cc151_6ec038e1","updated":"2015-07-01 04:28:43.000000000","message":"Actually i meant that i will do these tests to ensure ilo drivers work fine with both swift and without swift. I will make this more clear.","commit_id":"c8908858eacf63e8269d3c806660e04444d29a31"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e8d5d3586066789ebe9da94376553ea42ec645db","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* The driver will check if the user OS image, kernel and ramdisk (initial"},{"line_number":35,"context_line":"  images which are required by the driver in driver_info and instance_info)"},{"line_number":36,"context_line":"  is hosted on a http web server or glance and download the image."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* The automatic boot_iso created (as required by iscsi_ilo for booting up the"},{"line_number":39,"context_line":"  instance) and floppy images (as required by both agent_ilo and iscsi_ilo for"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_919e1806","line":36,"updated":"2015-07-06 15:46:04.000000000","message":"without this change, does ilo use glance to host the images, or does ilo expect the images to be in swift?\n\nI\u0027m trying to understand if this spec is only to get images from an http web server, and/or if it is to also support images in glance.","commit_id":"fe5df860378dd61627213c6c7d36ecf4bde4adeb"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfe328b529eab8aa6a1b9262855079c3b7f07bd4","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* The driver will check if the user OS image, kernel and ramdisk (initial"},{"line_number":35,"context_line":"  images which are required by the driver in driver_info and instance_info)"},{"line_number":36,"context_line":"  is hosted on a http web server or glance and download the image."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* The automatic boot_iso created (as required by iscsi_ilo for booting up the"},{"line_number":39,"context_line":"  instance) and floppy images (as required by both agent_ilo and iscsi_ilo for"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_63e4e60c","line":36,"in_reply_to":"ba3cc151_919e1806","updated":"2015-07-06 17:10:55.000000000","message":"This spec is to support images from webserver also (retaining existing thing also).\n\nCurrently, ilo use iso images stored in glance which is using swift as backend. But for floppy images and automatic boot iso, it uses swift.","commit_id":"fe5df860378dd61627213c6c7d36ecf4bde4adeb"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d67dd06bd6c26156590490832f284561bc80c35d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  instance) and floppy images (as required by both agent_ilo and iscsi_ilo for"},{"line_number":40,"context_line":"  passing parameters to deploy ramdisk) during deploy process,"},{"line_number":41,"context_line":"  will be hosted on swift or http web server as per the config variable under"},{"line_number":42,"context_line":"  `[ilo]` in ironic.conf::"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    use_http_web_server_for_images\u003dTrue"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_f848a0ce","line":42,"updated":"2015-07-06 18:00:29.000000000","message":"is a conf option needed here. I believe others using the is_http_url() function. ( see https://github.com/openstack/ironic/blob/master/ironic/common/utils.py#L538 )","commit_id":"fe5df860378dd61627213c6c7d36ecf4bde4adeb"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"61f58457702f2901f2a616b549c958fcc48ee96e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  instance) and floppy images (as required by both agent_ilo and iscsi_ilo for"},{"line_number":40,"context_line":"  passing parameters to deploy ramdisk) during deploy process,"},{"line_number":41,"context_line":"  will be hosted on swift or http web server as per the config variable under"},{"line_number":42,"context_line":"  `[ilo]` in ironic.conf::"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    use_http_web_server_for_images\u003dTrue"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_03da2517","line":42,"in_reply_to":"ba3cc151_f848a0ce","updated":"2015-07-09 07:09:10.000000000","message":"hmmm i think yes because then that means i will have to check the kernel/ramdisk input urls and based on that take decisions if automatic boot_iso and floppy images shall be hosted where.\n\nWith the proposed approach, it will use the http_web_server if the config variable is true irrespective of kernel/ramdisk\u0027s host. It is quite possible that user has one(say kernel) on glance and another on http web server(say ramdisk). It will be difficult for driver to decide the host for the images which wiould get created at runtime.","commit_id":"fe5df860378dd61627213c6c7d36ecf4bde4adeb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e8d5d3586066789ebe9da94376553ea42ec645db","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"The http web server configuration is out of scope of ironic but it should be"},{"line_number":134,"context_line":"configured on every conductor node."},{"line_number":135,"context_line":"User needs to manually configure the weserver, and add the config options"},{"line_number":136,"context_line":"in ironic.conf under `deploy` as::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    http_server_root \u003d /opt/stack/ironic/data/httpboot"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_9157f8c9","line":135,"updated":"2015-07-06 15:46:04.000000000","message":"s/weserver/web server/","commit_id":"fe5df860378dd61627213c6c7d36ecf4bde4adeb"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bfe328b529eab8aa6a1b9262855079c3b7f07bd4","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"The http web server configuration is out of scope of ironic but it should be"},{"line_number":134,"context_line":"configured on every conductor node."},{"line_number":135,"context_line":"User needs to manually configure the weserver, and add the config options"},{"line_number":136,"context_line":"in ironic.conf under `deploy` as::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    http_server_root \u003d /opt/stack/ironic/data/httpboot"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_83b32a0a","line":135,"in_reply_to":"ba3cc151_9157f8c9","updated":"2015-07-06 17:10:55.000000000","message":"ok","commit_id":"fe5df860378dd61627213c6c7d36ecf4bde4adeb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8239ff949ccb4b1ce582d38e11fbc82de58e99f9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  will be hosted on swift or http web server as per the config variable under"},{"line_number":38,"context_line":"  `[ilo]` in ironic.conf::"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    use_http_web_server_for_images\u003dTrue"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  The default value would be `False` and will default to use swift."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba3cc151_dba8648f","line":40,"updated":"2015-07-10 07:14:41.000000000","message":"nit: /_web// it\u0027s actually self-repeating and is more consistent with http_server_* variables below","commit_id":"273c941b281cff255885c0414033cf727d8878e7"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"bba7746da7b7c11ed3567c200505d324e28b9cdf","unresolved":false,"context_lines":[{"line_number":127,"context_line":"---------------------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"The http web server configuration is out of scope of ironic but it should be"},{"line_number":130,"context_line":"configured on every conductor node."},{"line_number":131,"context_line":"User needs to manually configure the web server, and add the config options"},{"line_number":132,"context_line":"in ironic.conf under `deploy` as::"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba3cc151_c00e3e8c","line":130,"updated":"2015-07-09 23:25:33.000000000","message":"I think I understand what your saying here. Perhaps better to word as: The http web server configuration is out of scope for ironic but http_server_root must be reachable by each conductor.","commit_id":"273c941b281cff255885c0414033cf727d8878e7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"eb5a1cb62aed39998931e40d042dd9e7f45b0a84","unresolved":false,"context_lines":[{"line_number":127,"context_line":"---------------------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"The http web server configuration is out of scope of ironic but it should be"},{"line_number":130,"context_line":"configured on every conductor node."},{"line_number":131,"context_line":"User needs to manually configure the web server, and add the config options"},{"line_number":132,"context_line":"in ironic.conf under `deploy` as::"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba3cc151_75704a74","line":130,"in_reply_to":"ba3cc151_c00e3e8c","updated":"2015-07-10 03:41:58.000000000","message":"Ok. Will update as suggested if required to place anew version of the spec.","commit_id":"273c941b281cff255885c0414033cf727d8878e7"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"bba7746da7b7c11ed3567c200505d324e28b9cdf","unresolved":false,"context_lines":[{"line_number":132,"context_line":"in ironic.conf under `deploy` as::"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    http_server_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":135,"context_line":"    http_server_url \u003d http://10.10.1.30/httpboot"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Since the same config variables exists under `[pxe]` and is required by"},{"line_number":138,"context_line":"ilo drivers to be able to run standalone, we can deprecate the same in `[pxe]`"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba3cc151_4049ceb6","line":135,"updated":"2015-07-09 23:25:33.000000000","message":"maybe better to not show a actual ip in this example, something like \u003chttp_server_ip\u003e in place of 10.10.1.30 would be better IMO.","commit_id":"273c941b281cff255885c0414033cf727d8878e7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"eb5a1cb62aed39998931e40d042dd9e7f45b0a84","unresolved":false,"context_lines":[{"line_number":132,"context_line":"in ironic.conf under `deploy` as::"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    http_server_root \u003d /opt/stack/ironic/data/httpboot"},{"line_number":135,"context_line":"    http_server_url \u003d http://10.10.1.30/httpboot"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Since the same config variables exists under `[pxe]` and is required by"},{"line_number":138,"context_line":"ilo drivers to be able to run standalone, we can deprecate the same in `[pxe]`"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba3cc151_f55bfaf7","line":135,"in_reply_to":"ba3cc151_4049ceb6","updated":"2015-07-10 03:41:58.000000000","message":"Ok. I will change if i need to place another version of the spec. dont want to loose +2 ;)","commit_id":"273c941b281cff255885c0414033cf727d8878e7"}]}