)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8b85bf0a0de6910f436d6e029863fdba263016ec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ramakrishnan G \u003crameshg87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-07 06:25:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for UEFI iSCSI boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change proposes a new deploy driver for support"},{"line_number":10,"context_line":"UEFI iSCSI boot."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a29b11f_c7451e43","line":7,"updated":"2015-10-22 13:19:19.000000000","message":"please mention that it\u0027s for iLO","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b13a0783cf191b48167efeab14f08105e869fe06","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ramakrishnan G \u003crameshg87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-07 06:25:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for UEFI iSCSI boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change proposes a new deploy driver for support"},{"line_number":10,"context_line":"UEFI iSCSI boot."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da85f559_943934db","line":7,"in_reply_to":"3a29b11f_c7451e43","updated":"2015-11-13 07:06:28.000000000","message":"Done","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d9b1e9ae916ac392d88f4abae4f661aa49d72f95","unresolved":false,"context_lines":[{"line_number":10,"context_line":"supports booting from iSCSI volume. This change proposes"},{"line_number":11,"context_line":"to add a new implementation of DeployInterface to support"},{"line_number":12,"context_line":"booting from iSCSI Cinder volume."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I86fb4fa7913cc7f925b2e450c81fb618135bf169"},{"line_number":15,"context_line":"Partial-Bug: 1526861"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa0719c6_c07f4ede","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"updated":"2016-03-23 16:30:31.000000000","message":"might be good to add a depends on to Ibf50be735905f868e0d523ab16353a6b5cc300af here.","commit_id":"364f618cc0f07ff8982a20512032af015019edc7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5d620df1cb4f37744e079b2599d49f0858ceb429","unresolved":false,"context_lines":[{"line_number":10,"context_line":"supports booting from iSCSI volume. This change proposes"},{"line_number":11,"context_line":"to add a new implementation of DeployInterface to support"},{"line_number":12,"context_line":"booting from iSCSI Cinder volume."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I86fb4fa7913cc7f925b2e450c81fb618135bf169"},{"line_number":15,"context_line":"Partial-Bug: 1526861"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a061dce_04a30eb3","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"in_reply_to":"fa0719c6_c07f4ede","updated":"2016-04-07 04:21:48.000000000","message":"Done","commit_id":"364f618cc0f07ff8982a20512032af015019edc7"}],"specs/approved/ilo-uefi-iscsi-boot.rst":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"ea803bfef18cfc4b9c550e88af9924d6ebfe0f5f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"API, etc) for booting from a Cinder volume.  HP Proliant Gen9 hardware"},{"line_number":23,"context_line":"(having HP ProLiant Gen9 System ROM P89 release version 1.40 or higher)"},{"line_number":24,"context_line":"supports booting from an iSCSI volume.  Hardware can be configured"},{"line_number":25,"context_line":"programatically to boot from an iSCSI volume (without using bootloaders like"},{"line_number":26,"context_line":"iPXE). But there is no way in Ironic to use this feature."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_d69d6a0b","line":25,"updated":"2015-08-14 18:45:44.000000000","message":"s/programatically/programmatically/","commit_id":"2ae33ad8e0b0f40c52928885fd69f07c21bc7bac"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"07953d94e36f0df428d2576c259a3944246f05fa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"API, etc) for booting from a Cinder volume.  HP Proliant Gen9 hardware"},{"line_number":23,"context_line":"(having HP ProLiant Gen9 System ROM P89 release version 1.40 or higher)"},{"line_number":24,"context_line":"supports booting from an iSCSI volume.  Hardware can be configured"},{"line_number":25,"context_line":"programatically to boot from an iSCSI volume (without using bootloaders like"},{"line_number":26,"context_line":"iPXE). But there is no way in Ironic to use this feature."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_1503c00e","line":25,"in_reply_to":"1a4dcd0f_d69d6a0b","updated":"2015-10-07 05:42:39.000000000","message":"Done","commit_id":"2ae33ad8e0b0f40c52928885fd69f07c21bc7bac"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"7297e314934fbd6383edf418127c0b90c6dee296","unresolved":false,"context_lines":[{"line_number":160,"context_line":"------------------"},{"line_number":161,"context_line":"None."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Other deployer impact"},{"line_number":164,"context_line":"---------------------"},{"line_number":165,"context_line":"Deployers can configure the HP Proliant Gen9 hardware with the newly added"},{"line_number":166,"context_line":"deploy driver and use UEFI iSCSI boot feature. The workflow will be as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_d90bf8d4","line":163,"updated":"2015-09-04 10:36:06.000000000","message":"I believe that deployer is really interested in multipath support.\n\nAnd the spec \"Volume connection information for Ironic nodes\" [1] says \"If multiplath is configured in Cinder, it may also return multiple values in \u0027target_iqns\u0027, \u0027target_portals\u0027, \u0027target_luns\u0027 keys. \n\nSo it would be better to state if multipath is supported or not.\n\n[1] https://review.openstack.org/#/c/200496","commit_id":"2ae33ad8e0b0f40c52928885fd69f07c21bc7bac"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"07953d94e36f0df428d2576c259a3944246f05fa","unresolved":false,"context_lines":[{"line_number":160,"context_line":"------------------"},{"line_number":161,"context_line":"None."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Other deployer impact"},{"line_number":164,"context_line":"---------------------"},{"line_number":165,"context_line":"Deployers can configure the HP Proliant Gen9 hardware with the newly added"},{"line_number":166,"context_line":"deploy driver and use UEFI iSCSI boot feature. The workflow will be as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_522b8e94","line":163,"in_reply_to":"da20952f_d90bf8d4","updated":"2015-10-07 05:42:39.000000000","message":"As of now no.  I will mention it in the spec. Thanks.","commit_id":"2ae33ad8e0b0f40c52928885fd69f07c21bc7bac"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"adf7087bfb85c3bbbca419cc4cbadd79928a3623","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* This change proposes a new implementation of ``DeployInterface`` named"},{"line_number":32,"context_line":"  ``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder"},{"line_number":33,"context_line":"  volume for HP Proliant Gen9 Hardware (having HP ProLiant Gen9 System ROM"},{"line_number":34,"context_line":"  P89 release version 1.40 or higher)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a2fa921_e9298838","line":32,"updated":"2015-10-07 09:42:30.000000000","message":"I wish we had done s/Uefi/UEFI/ and s/Iscsi/iSCSI/ instead, but it\u0027s too late now :(","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b13a0783cf191b48167efeab14f08105e869fe06","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* This change proposes a new implementation of ``DeployInterface`` named"},{"line_number":32,"context_line":"  ``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder"},{"line_number":33,"context_line":"  volume for HP Proliant Gen9 Hardware (having HP ProLiant Gen9 System ROM"},{"line_number":34,"context_line":"  P89 release version 1.40 or higher)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_1917bd55","line":32,"in_reply_to":"7a2fa921_e9298838","updated":"2015-11-13 07:06:28.000000000","message":"Naming is wierd, we have 3 things there:\n\nIlo \u003d iLO \nUefi \u003d UEFI\nIscsi \u003d iSCSI\n\nI don\u0027t know how we can name all these properly.  Following a common thing (capitalising only first letter, rest small) seemed better. WDYT ?","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"adf7087bfb85c3bbbca419cc4cbadd79928a3623","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* This change proposes a new implementation of ``DeployInterface`` named"},{"line_number":32,"context_line":"  ``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder"},{"line_number":33,"context_line":"  volume for HP Proliant Gen9 Hardware (having HP ProLiant Gen9 System ROM"},{"line_number":34,"context_line":"  P89 release version 1.40 or higher)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  The new driver will be implemented with the following methods:"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a2fa921_6916d8f2","line":34,"updated":"2015-10-07 09:42:30.000000000","message":"I\u0027m assuming this HP product info is correct.","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b13a0783cf191b48167efeab14f08105e869fe06","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* This change proposes a new implementation of ``DeployInterface`` named"},{"line_number":32,"context_line":"  ``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder"},{"line_number":33,"context_line":"  volume for HP Proliant Gen9 Hardware (having HP ProLiant Gen9 System ROM"},{"line_number":34,"context_line":"  P89 release version 1.40 or higher)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  The new driver will be implemented with the following methods:"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_f93e79d9","line":34,"in_reply_to":"7a2fa921_6916d8f2","updated":"2015-11-13 07:06:28.000000000","message":"Yes.","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"adf7087bfb85c3bbbca419cc4cbadd79928a3623","unresolved":false,"context_lines":[{"line_number":83,"context_line":"          :returns: status of the deploy. One of ironic.common.states."},{"line_number":84,"context_line":"          \"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  + ``prepare()`` - Nothing."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  + ``tear_down()`` - This will do the following:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a2fa921_a9915054","line":86,"updated":"2015-10-07 09:42:30.000000000","message":"\"Do nothing\" or \"No-op\" might be better, but feel free to ignore.","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b13a0783cf191b48167efeab14f08105e869fe06","unresolved":false,"context_lines":[{"line_number":83,"context_line":"          :returns: status of the deploy. One of ironic.common.states."},{"line_number":84,"context_line":"          \"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  + ``prepare()`` - Nothing."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  + ``tear_down()`` - This will do the following:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_d910555c","line":86,"in_reply_to":"7a2fa921_a9915054","updated":"2015-11-13 07:06:28.000000000","message":"Done","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"adf7087bfb85c3bbbca419cc4cbadd79928a3623","unresolved":false,"context_lines":[{"line_number":101,"context_line":"          Removes iSCSI settings on the bare metal."},{"line_number":102,"context_line":"          \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  + ``clean_up()`` - Nothing."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* This change proposes to add the new ``IloUefiIscsiBootDeploy`` as part of"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a2fa921_e99c285f","line":104,"updated":"2015-10-07 09:42:30.000000000","message":"as above","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b13a0783cf191b48167efeab14f08105e869fe06","unresolved":false,"context_lines":[{"line_number":101,"context_line":"          Removes iSCSI settings on the bare metal."},{"line_number":102,"context_line":"          \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  + ``clean_up()`` - Nothing."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* This change proposes to add the new ``IloUefiIscsiBootDeploy`` as part of"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_f9151949","line":104,"in_reply_to":"7a2fa921_e99c285f","updated":"2015-11-13 07:06:28.000000000","message":"Done","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"adf7087bfb85c3bbbca419cc4cbadd79928a3623","unresolved":false,"context_lines":[{"line_number":177,"context_line":"  ``node.properties[\u0027capabilities\u0027]`` (or it could be populated by inspection,"},{"line_number":178,"context_line":"  but it\u0027s not part of this spec on how it gets populated)."},{"line_number":179,"context_line":"* Tenant creates a Cinder volume."},{"line_number":180,"context_line":"* Tenant requests an bare metal instance to be booted up with a Cinder volume."},{"line_number":181,"context_line":"* Nova scheduler selects a bare metal node capable of booting from Cinder"},{"line_number":182,"context_line":"  volume."},{"line_number":183,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a2fa921_494afcc6","line":180,"updated":"2015-10-07 09:42:30.000000000","message":"nit: s/an/a/","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b13a0783cf191b48167efeab14f08105e869fe06","unresolved":false,"context_lines":[{"line_number":177,"context_line":"  ``node.properties[\u0027capabilities\u0027]`` (or it could be populated by inspection,"},{"line_number":178,"context_line":"  but it\u0027s not part of this spec on how it gets populated)."},{"line_number":179,"context_line":"* Tenant creates a Cinder volume."},{"line_number":180,"context_line":"* Tenant requests an bare metal instance to be booted up with a Cinder volume."},{"line_number":181,"context_line":"* Nova scheduler selects a bare metal node capable of booting from Cinder"},{"line_number":182,"context_line":"  volume."},{"line_number":183,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_990bad2b","line":180,"in_reply_to":"7a2fa921_494afcc6","updated":"2015-11-13 07:06:28.000000000","message":"Done","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"62856b54195152f81d7734ce9fefbef25d6d0a3d","unresolved":false,"context_lines":[{"line_number":179,"context_line":"* Tenant creates a Cinder volume."},{"line_number":180,"context_line":"* Tenant requests an bare metal instance to be booted up with a Cinder volume."},{"line_number":181,"context_line":"* Nova scheduler selects a bare metal node capable of booting from Cinder"},{"line_number":182,"context_line":"  volume."},{"line_number":183,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":184,"context_line":"* When Proliant Gen9 hardware gets selected, the ``iscsi_ilo`` and"},{"line_number":185,"context_line":"  ``agent_ilo``  driver reads this information, sets up the hardware to boot"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_e1379be1","line":182,"updated":"2015-11-08 23:27:31.000000000","message":"Meaning the deployer needs to create a flavor for this, right?","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b13a0783cf191b48167efeab14f08105e869fe06","unresolved":false,"context_lines":[{"line_number":179,"context_line":"* Tenant creates a Cinder volume."},{"line_number":180,"context_line":"* Tenant requests an bare metal instance to be booted up with a Cinder volume."},{"line_number":181,"context_line":"* Nova scheduler selects a bare metal node capable of booting from Cinder"},{"line_number":182,"context_line":"  volume."},{"line_number":183,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":184,"context_line":"* When Proliant Gen9 hardware gets selected, the ``iscsi_ilo`` and"},{"line_number":185,"context_line":"  ``agent_ilo``  driver reads this information, sets up the hardware to boot"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_b908f12e","line":182,"in_reply_to":"da85f559_e1379be1","updated":"2015-11-13 07:06:28.000000000","message":"Yes, will mention it.","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"62856b54195152f81d7734ce9fefbef25d6d0a3d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"* Tenant requests an bare metal instance to be booted up with a Cinder volume."},{"line_number":181,"context_line":"* Nova scheduler selects a bare metal node capable of booting from Cinder"},{"line_number":182,"context_line":"  volume."},{"line_number":183,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":184,"context_line":"* When Proliant Gen9 hardware gets selected, the ``iscsi_ilo`` and"},{"line_number":185,"context_line":"  ``agent_ilo``  driver reads this information, sets up the hardware to boot"},{"line_number":186,"context_line":"  from Cinder volume and hands it over to the tenant."}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_81348fde","line":183,"updated":"2015-11-08 23:27:31.000000000","message":"Is there more info on this part?","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b13a0783cf191b48167efeab14f08105e869fe06","unresolved":false,"context_lines":[{"line_number":180,"context_line":"* Tenant requests an bare metal instance to be booted up with a Cinder volume."},{"line_number":181,"context_line":"* Nova scheduler selects a bare metal node capable of booting from Cinder"},{"line_number":182,"context_line":"  volume."},{"line_number":183,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":184,"context_line":"* When Proliant Gen9 hardware gets selected, the ``iscsi_ilo`` and"},{"line_number":185,"context_line":"  ``agent_ilo``  driver reads this information, sets up the hardware to boot"},{"line_number":186,"context_line":"  from Cinder volume and hands it over to the tenant."}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_59054512","line":183,"in_reply_to":"da85f559_81348fde","updated":"2015-11-13 07:06:28.000000000","message":"Yes, there is a nova spec for this.  Will reference this here.","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"62856b54195152f81d7734ce9fefbef25d6d0a3d","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Dependencies"},{"line_number":206,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":207,"context_line":"[3] Support multiple deploy mechanisms simultaneously https://review.openstack.org/209821"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Testing"},{"line_number":210,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_a13193ee","line":207,"updated":"2015-11-08 23:27:31.000000000","message":"Is this a hard dependency or just a \"nice to have\" thing?","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b13a0783cf191b48167efeab14f08105e869fe06","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Dependencies"},{"line_number":206,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":207,"context_line":"[3] Support multiple deploy mechanisms simultaneously https://review.openstack.org/209821"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Testing"},{"line_number":210,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_342ac87f","line":207,"in_reply_to":"da85f559_a13193ee","updated":"2015-11-13 07:06:28.000000000","message":"Well we can restrict it to nice to have for now because someone can make this feature work without this as well.  But supporting multiple deploy mechanisms might be the best way to utilize the hardware properly.","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"adf7087bfb85c3bbbca419cc4cbadd79928a3623","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Documentation Impact"},{"line_number":218,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":219,"context_line":"Documentation will be added on how to configured the node with the new"},{"line_number":220,"context_line":"deploy driver."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a2fa921_49219cfa","line":219,"updated":"2015-10-07 09:42:30.000000000","message":"nit: s/configured/configure/","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b13a0783cf191b48167efeab14f08105e869fe06","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Documentation Impact"},{"line_number":218,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":219,"context_line":"Documentation will be added on how to configured the node with the new"},{"line_number":220,"context_line":"deploy driver."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_d41edc5e","line":219,"in_reply_to":"7a2fa921_49219cfa","updated":"2015-11-13 07:06:28.000000000","message":"Done","commit_id":"5589b1a9c0469bd88ad675428692cc25a0584d64"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"45a1b2d0ad2f11ee4f67f70e289363b71b5f3a5d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* This change proposes a new implementation of ``DeployInterface`` named"},{"line_number":34,"context_line":"  ``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder"},{"line_number":35,"context_line":"  volume for HP ProLiant Gen9 Hardware (having HP ProLiant Gen9 System ROM"},{"line_number":36,"context_line":"  P89 release version 1.40 or higher)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_1481bb4a","line":34,"updated":"2015-11-24 18:51:36.000000000","message":"Will the actual driver have a boot interface?","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"be85f6d1af8f7f60db98d2f5fa18ccb6136ce7aa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* This change proposes a new implementation of ``DeployInterface`` named"},{"line_number":34,"context_line":"  ``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder"},{"line_number":35,"context_line":"  volume for HP ProLiant Gen9 Hardware (having HP ProLiant Gen9 System ROM"},{"line_number":36,"context_line":"  P89 release version 1.40 or higher)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a710552_1d3a4837","line":34,"in_reply_to":"9a8ffd7b_1481bb4a","updated":"2015-12-15 05:06:25.000000000","message":"No, there will not be any boot interface for this. The operations done in deploy are actually boot interface related as there is no actual deploy happening here.","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"824ddc028b22d7c8f715f34bad5727b8c24594f8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* This change proposes a new implementation of ``DeployInterface`` named"},{"line_number":34,"context_line":"  ``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder"},{"line_number":35,"context_line":"  volume for HP ProLiant Gen9 Hardware (having HP ProLiant Gen9 System ROM"},{"line_number":36,"context_line":"  P89 release version 1.40 or higher)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_c1bec2fe","line":34,"in_reply_to":"9a8ffd7b_1481bb4a","updated":"2015-12-11 15:19:06.000000000","message":"The driver should have only one interface i.e. either deploy interface or boot interface. So ideally only boot interface should apply to boot from cinder volume. We would like to get opinion from others on this part.","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"45a1b2d0ad2f11ee4f67f70e289363b71b5f3a5d","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - This will validate whether the necessary inputs"},{"line_number":43,"context_line":"      for booting from iSCSI volume are provided in node (in the place as"},{"line_number":44,"context_line":"      mentioned in the parent spec). This includes target IQN, LUN number,"},{"line_number":45,"context_line":"      IP address of target, port, authentication method, username, password."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - Check if an attribute ``node.properties.capabilities[\u0027iscsi_boot\u0027]``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_b9f8e87d","line":44,"updated":"2015-11-24 18:51:36.000000000","message":"What is the parent spec? Is it one or both of the specs below under \u0027Dependencies\u0027?\n\nOh, maybe the Volume connection information one (https://review.openstack.org/#/c/200496/)? If so, you should add it to the Dependencies section.","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"824ddc028b22d7c8f715f34bad5727b8c24594f8","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - This will validate whether the necessary inputs"},{"line_number":43,"context_line":"      for booting from iSCSI volume are provided in node (in the place as"},{"line_number":44,"context_line":"      mentioned in the parent spec). This includes target IQN, LUN number,"},{"line_number":45,"context_line":"      IP address of target, port, authentication method, username, password."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - Check if an attribute ``node.properties.capabilities[\u0027iscsi_boot\u0027]``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_eab37c4b","line":44,"in_reply_to":"9a8ffd7b_b9f8e87d","updated":"2015-12-11 15:19:06.000000000","message":"Yes correct. Ok will add in dependencies section.","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"45a1b2d0ad2f11ee4f67f70e289363b71b5f3a5d","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  + ``clean_up()`` - Do nothing."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* Multipathing will be supported."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. _`moved to ironic-lib`: https://review.openstack.org/#/c/230924/"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_b468efbb","line":110,"updated":"2015-11-24 18:51:36.000000000","message":"What do you mean by this?","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3873d2f6a63b54939461cef2288960b357b39186","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  + ``clean_up()`` - Do nothing."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* Multipathing will be supported."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. _`moved to ironic-lib`: https://review.openstack.org/#/c/230924/"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_20c2cb53","line":110,"in_reply_to":"7a740942_ca7ec0ae","updated":"2015-12-14 23:54:44.000000000","message":"The multipathing is supported via available and connected NICS. SO this is HP hardware specific thing. It has provision of 4 attempts. \nSo if the target volume becomes unreachable via one network(NIC), the OS tries to reach the volume via another NIC(network/route). Its a failover facility for the target.","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"824ddc028b22d7c8f715f34bad5727b8c24594f8","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  + ``clean_up()`` - Do nothing."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* Multipathing will be supported."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. _`moved to ironic-lib`: https://review.openstack.org/#/c/230924/"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_ca7ec0ae","line":110,"in_reply_to":"9a8ffd7b_b468efbb","updated":"2015-12-11 15:19:06.000000000","message":"WIll check back and respond.","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"45a1b2d0ad2f11ee4f67f70e289363b71b5f3a5d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Alternatives"},{"line_number":115,"context_line":"------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Propose a separate driver which might increase the driver matrix and might"},{"line_number":118,"context_line":"make the bare metal node tied down to a single use case (either always"},{"line_number":119,"context_line":"boot only from iSCSI Cinder volume OR always deploy to bare metal\u0027s local"},{"line_number":120,"context_line":"disk)."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_746cc79c","line":117,"updated":"2015-11-24 18:51:36.000000000","message":"I\u0027m not sure I understand. Aren\u0027t you proposing a new driver that uses this new IloUefiIscsiBootDeploy interface?","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"824ddc028b22d7c8f715f34bad5727b8c24594f8","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Alternatives"},{"line_number":115,"context_line":"------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Propose a separate driver which might increase the driver matrix and might"},{"line_number":118,"context_line":"make the bare metal node tied down to a single use case (either always"},{"line_number":119,"context_line":"boot only from iSCSI Cinder volume OR always deploy to bare metal\u0027s local"},{"line_number":120,"context_line":"disk)."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_eaa4dc4b","line":117,"in_reply_to":"9a8ffd7b_746cc79c","updated":"2015-12-11 15:19:06.000000000","message":"There are two ways to propose the boot from iscsi/cinder volume.\n1. Use the existing drivers: This will have dependency on https://review.openstack.org/#/c/209821/\n\n2. Introduce a new driver.\n\nThis spec proposes to introduce a new driver for ilo iscsi uefi boot.","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"be85f6d1af8f7f60db98d2f5fa18ccb6136ce7aa","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Alternatives"},{"line_number":115,"context_line":"------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Propose a separate driver which might increase the driver matrix and might"},{"line_number":118,"context_line":"make the bare metal node tied down to a single use case (either always"},{"line_number":119,"context_line":"boot only from iSCSI Cinder volume OR always deploy to bare metal\u0027s local"},{"line_number":120,"context_line":"disk)."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a710552_9852c6dc","line":117,"in_reply_to":"9a8ffd7b_746cc79c","updated":"2015-12-15 05:06:25.000000000","message":"This spec proposes to implement new Deploy interface, but can be used along with existing drivers using the mixing of deploy interfaces proposed as part of https://review.openstack.org/#/c/209821/\n\nSo that the exiting driver can have multiple deploy interfaces and based on the instance_info provided, appropriate deploy interface would get used. This will not need new driver implementation, but having a DeployInterface would suffice.","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"45a1b2d0ad2f11ee4f67f70e289363b71b5f3a5d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Other end user impact"},{"line_number":163,"context_line":"---------------------"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Users can request for a bare metal to be a booted from an iSCSI Cinder"},{"line_number":166,"context_line":"volume from Nova, and Ironic can fulfill the request with HPE ProLiant"},{"line_number":167,"context_line":"Gen9 servers."},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_7481278f","line":165,"updated":"2015-11-24 18:51:36.000000000","message":"nit: s/be a booted/be booted/","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"824ddc028b22d7c8f715f34bad5727b8c24594f8","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Other end user impact"},{"line_number":163,"context_line":"---------------------"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Users can request for a bare metal to be a booted from an iSCSI Cinder"},{"line_number":166,"context_line":"volume from Nova, and Ironic can fulfill the request with HPE ProLiant"},{"line_number":167,"context_line":"Gen9 servers."},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_6a46ac7c","line":165,"in_reply_to":"9a8ffd7b_7481278f","updated":"2015-12-11 15:19:06.000000000","message":"Ok","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"45a1b2d0ad2f11ee4f67f70e289363b71b5f3a5d","unresolved":false,"context_lines":[{"line_number":198,"context_line":"  For more information, refer nova spec"},{"line_number":199,"context_line":"  `Add support for booting bare metals from Cinder volume`_."},{"line_number":200,"context_line":"* When ProLiant Gen9 hardware gets selected, the iLO driver"},{"line_number":201,"context_line":"  driver reads this information, sets up the hardware to boot"},{"line_number":202,"context_line":"  from Cinder volume and hands it over to the tenant."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":".. _`Add support for booting bare metals from Cinder volume`: https://review.openstack.org/#/c/211101/"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_941dabbf","line":201,"updated":"2015-11-24 18:51:36.000000000","message":"nit, extra \u0027driver\u0027","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"824ddc028b22d7c8f715f34bad5727b8c24594f8","unresolved":false,"context_lines":[{"line_number":198,"context_line":"  For more information, refer nova spec"},{"line_number":199,"context_line":"  `Add support for booting bare metals from Cinder volume`_."},{"line_number":200,"context_line":"* When ProLiant Gen9 hardware gets selected, the iLO driver"},{"line_number":201,"context_line":"  driver reads this information, sets up the hardware to boot"},{"line_number":202,"context_line":"  from Cinder volume and hands it over to the tenant."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":".. _`Add support for booting bare metals from Cinder volume`: https://review.openstack.org/#/c/211101/"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_ea529c34","line":201,"in_reply_to":"9a8ffd7b_941dabbf","updated":"2015-12-11 15:19:06.000000000","message":"Ok","commit_id":"13fc9407d44c329109fcc3c093e664ef4ea3e1bd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5e353732c823ccbdbe1f5643f297b2247fe31a64","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      the existing config drive partition and rewrite a new one (when Cinder"},{"line_number":73,"context_line":"      volume is reused multiple times)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    - Makes a proliantutils call (only supported on Gen9 hardware and above)"},{"line_number":76,"context_line":"      to set the the iSCSI target details on the bare metal server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    The function definition will be as follows::"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a7e1126_56497630","line":75,"updated":"2015-12-17 11:32:09.000000000","message":"One suggestions. AFAIK out of band setting for iSCSI target is not only HP specific. This driver can be generic if we extend management interface with set/clear iSCSI settings.","commit_id":"a48a7c90e736f9c07f65d56d33a918ce60903ca8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"15cc2981a448b44ef190c62d49a2a78455b93e5f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      the existing config drive partition and rewrite a new one (when Cinder"},{"line_number":73,"context_line":"      volume is reused multiple times)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    - Makes a proliantutils call (only supported on Gen9 hardware and above)"},{"line_number":76,"context_line":"      to set the the iSCSI target details on the bare metal server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    The function definition will be as follows::"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3afc51ec_4a7104e0","line":75,"in_reply_to":"3a7e1126_56497630","updated":"2016-03-14 11:09:47.000000000","message":"Its being planned as part of parent spec \nhttps://review.openstack.org/#/c/200496/","commit_id":"a48a7c90e736f9c07f65d56d33a918ce60903ca8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"944f8fc884d31fd964cdfaabf1d84de7a2701db2","unresolved":false,"context_lines":[{"line_number":267,"context_line":"References"},{"line_number":268,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":".. _`Configuring the iSCSI Software Initiator for Proliant`: http://h20565.www2.hpe.com/hpsc/doc/public/display?sp4ts.oid\u003d7829634\u0026docId\u003demr_na-c04565930\u0026docLocale\u003den_US"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa69d971_954b2787","line":270,"range":{"start_line":270,"start_character":61,"end_line":270,"end_character":168},"updated":"2016-01-04 13:26:17.000000000","message":"This link is unresponsive and does not load.","commit_id":"a48a7c90e736f9c07f65d56d33a918ce60903ca8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"15cc2981a448b44ef190c62d49a2a78455b93e5f","unresolved":false,"context_lines":[{"line_number":267,"context_line":"References"},{"line_number":268,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":".. _`Configuring the iSCSI Software Initiator for Proliant`: http://h20565.www2.hpe.com/hpsc/doc/public/display?sp4ts.oid\u003d7829634\u0026docId\u003demr_na-c04565930\u0026docLocale\u003den_US"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da6ed579_801a5516","line":270,"range":{"start_line":270,"start_character":61,"end_line":270,"end_character":168},"in_reply_to":"fa69d971_954b2787","updated":"2016-03-14 11:09:47.000000000","message":"It does open for me. Its a pdf file. The google search for \u0027HP UEFI Deployment Guide for HP ProLiant Gen9 Servers\u0027 will land you to same page.\n\nipxe based implementation is being implemented as part of parent spec.\nhttps://review.openstack.org/#/c/215849/","commit_id":"a48a7c90e736f9c07f65d56d33a918ce60903ca8"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ef3b0a7c09ea88188c05c669ac2a05f6c34625af","unresolved":false,"context_lines":[{"line_number":8,"context_line":"UEFI iSCSI Boot for ProLiant Servers"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/ilo-uefi-iscsi-boot"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"HPE ProLiant Gen9 servers support booting from iSCSI volume in its firmware."},{"line_number":14,"context_line":"This feature is about adding support for booting from a iSCSI Cinder volume"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_803c5de3","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":65},"updated":"2016-03-15 03:02:34.000000000","message":"We use RFE but to track bp now, so can we add bug link here?\n\nhttps://bugs.launchpad.net/ironic/+bug/1526861","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f81ef10ff1a9488ab843e5a10a032a14d373b6d3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"UEFI iSCSI Boot for ProLiant Servers"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/ilo-uefi-iscsi-boot"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"HPE ProLiant Gen9 servers support booting from iSCSI volume in its firmware."},{"line_number":14,"context_line":"This feature is about adding support for booting from a iSCSI Cinder volume"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_4f12810a","line":11,"in_reply_to":"3afc51ec_803c5de3","updated":"2016-03-15 10:30:30.000000000","message":"Done","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ef3b0a7c09ea88188c05c669ac2a05f6c34625af","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/ilo-uefi-iscsi-boot"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"HPE ProLiant Gen9 servers support booting from iSCSI volume in its firmware."},{"line_number":14,"context_line":"This feature is about adding support for booting from a iSCSI Cinder volume"},{"line_number":15,"context_line":"for these servers."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_c00dc53f","line":14,"range":{"start_line":14,"start_character":54,"end_line":14,"end_character":61},"updated":"2016-03-15 03:02:34.000000000","message":"nit: s/a/an","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f81ef10ff1a9488ab843e5a10a032a14d373b6d3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/ilo-uefi-iscsi-boot"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"HPE ProLiant Gen9 servers support booting from iSCSI volume in its firmware."},{"line_number":14,"context_line":"This feature is about adding support for booting from a iSCSI Cinder volume"},{"line_number":15,"context_line":"for these servers."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_affb45c0","line":14,"in_reply_to":"3afc51ec_c00dc53f","updated":"2016-03-15 10:30:30.000000000","message":"Done","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ef3b0a7c09ea88188c05c669ac2a05f6c34625af","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* This change proposes a new implementation of ``DeployInterface`` named"},{"line_number":34,"context_line":"  ``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder"},{"line_number":35,"context_line":"  volume for HP ProLiant Gen9 Hardware (having HP ProLiant Gen9 System ROM"},{"line_number":36,"context_line":"  P89 release version 1.40 or higher)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_5b2406ae","line":34,"range":{"start_line":34,"start_character":2,"end_line":34,"end_character":28},"updated":"2016-03-15 03:02:34.000000000","message":"idea: should we introduce a new common interface UefiIscsiBootDeploy, and have default implementation on base class, and IloUefiIscsiBootDeploy just focus on the special code to support Ilo devices?","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f81ef10ff1a9488ab843e5a10a032a14d373b6d3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* This change proposes a new implementation of ``DeployInterface`` named"},{"line_number":34,"context_line":"  ``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder"},{"line_number":35,"context_line":"  volume for HP ProLiant Gen9 Hardware (having HP ProLiant Gen9 System ROM"},{"line_number":36,"context_line":"  P89 release version 1.40 or higher)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_6f0dbde7","line":34,"range":{"start_line":34,"start_character":2,"end_line":34,"end_character":28},"in_reply_to":"3afc51ec_5b2406ae","updated":"2016-03-15 10:30:30.000000000","message":"It would implement from base.BootInterface\nThere is no common plumbing that would be needed. It would be making the iLO proliantutils calls to set up the iscsi target.","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ef3b0a7c09ea88188c05c669ac2a05f6c34625af","unresolved":false,"context_lines":[{"line_number":87,"context_line":"          :returns: status of the deploy. One of ironic.common.states."},{"line_number":88,"context_line":"          \"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  + ``prepare()`` - Do nothing."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  + ``tear_down()`` - This will do the following:"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_fbba3222","line":90,"range":{"start_line":90,"start_character":2,"end_line":90,"end_character":31},"updated":"2016-03-15 03:02:34.000000000","message":"I understand that we need to get iscsi connection info from cinder first, then pass to iLO server, right?\nIf yes, should we call cinder api to get it here to prepare iscsi remote disk?","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f81ef10ff1a9488ab843e5a10a032a14d373b6d3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"          :returns: status of the deploy. One of ironic.common.states."},{"line_number":88,"context_line":"          \"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  + ``prepare()`` - Do nothing."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  + ``tear_down()`` - This will do the following:"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_2f2e1543","line":90,"in_reply_to":"3afc51ec_fbba3222","updated":"2016-03-15 10:30:30.000000000","message":"That would be done in deploy(). The necessary cinder based iscsi connection information would be present in the node .","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ef3b0a7c09ea88188c05c669ac2a05f6c34625af","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    - Clears the iSCSI settings from the ProLiant hardware by making a"},{"line_number":95,"context_line":"      proliantutils call."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    - Ironic conductor connects to the remote iscsi volume and erases the"},{"line_number":98,"context_line":"      config drive."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    The function definition will be as follows::"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_fb91929a","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":19},"updated":"2016-03-15 03:02:34.000000000","message":"I think there is other staff to be removed, such as the keys/ip/etc which are injected by nova \u0026 cloudinit, how do you think about?","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f81ef10ff1a9488ab843e5a10a032a14d373b6d3","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      proliantutils call."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    - Ironic conductor connects to the remote iscsi volume and erases the"},{"line_number":98,"context_line":"      config drive."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    The function definition will be as follows::"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_af97c546","line":98,"in_reply_to":"3afc51ec_fb91929a","updated":"2016-03-15 10:30:30.000000000","message":"Wont that be all part of Config Drive?\nWe may not be able to track if the scripts on the volume moves that data to other partitions from config drive. \nDid you meant any other thing here?","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ef3b0a7c09ea88188c05c669ac2a05f6c34625af","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"None."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Client (CLI) impact"},{"line_number":141,"context_line":"-------------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"None."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"RPC API impact"},{"line_number":146,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_fb6d1299","line":143,"range":{"start_line":140,"start_character":0,"end_line":143,"end_character":5},"updated":"2016-03-15 03:02:34.000000000","message":"should we involve new node-set-provision-states options for user to input iscsi info to launch the boot via standalone bifrost ironic project support here?","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f81ef10ff1a9488ab843e5a10a032a14d373b6d3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Client (CLI) impact"},{"line_number":141,"context_line":"-------------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"None."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"RPC API impact"},{"line_number":146,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_ef9d4d67","line":143,"in_reply_to":"3afc51ec_fb6d1299","updated":"2016-03-15 10:30:30.000000000","message":"May be, but that should be generic enough and be part of a separate spec WDYt?","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"ef3b0a7c09ea88188c05c669ac2a05f6c34625af","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":".. _`Driver composition reform`: https://review.openstack.org/#/c/188370/"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Testing"},{"line_number":252,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Unit tests will be added."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":257,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_dbedb6f0","line":254,"range":{"start_line":251,"start_character":0,"end_line":254,"end_character":25},"updated":"2016-03-15 03:02:34.000000000","message":"how do you think should we add some new tempest codes to cover this new iscsi boot function?","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f81ef10ff1a9488ab843e5a10a032a14d373b6d3","unresolved":false,"context_lines":[{"line_number":251,"context_line":"Testing"},{"line_number":252,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Unit tests will be added."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":257,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_0f8fd92a","line":254,"in_reply_to":"3afc51ec_dbedb6f0","updated":"2016-03-15 10:30:30.000000000","message":"iLO drivers are not exercised as part of tempest. It may be useful for generic implementation.","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"44b2fcfc211fc9446380500d8c05be05930e2814","unresolved":false,"context_lines":[{"line_number":264,"context_line":"Documentation will be added on how to configure the node with the new"},{"line_number":265,"context_line":"deploy driver."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"References"},{"line_number":268,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":".. _`Configuring the iSCSI Software Initiator for Proliant`: http://h20565.www2.hpe.com/hpsc/doc/public/display?sp4ts.oid\u003d7829634\u0026docId\u003demr_na-c04565930\u0026docLocale\u003den_US"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_7b9aa264","line":270,"range":{"start_line":267,"start_character":0,"end_line":270,"end_character":168},"updated":"2016-03-15 03:06:17.000000000","message":"Not sure why these section context is not rendered by browser, just display empty under this section, have wrong rst syntax or other reason?","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f81ef10ff1a9488ab843e5a10a032a14d373b6d3","unresolved":false,"context_lines":[{"line_number":264,"context_line":"Documentation will be added on how to configure the node with the new"},{"line_number":265,"context_line":"deploy driver."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"References"},{"line_number":268,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":".. _`Configuring the iSCSI Software Initiator for Proliant`: http://h20565.www2.hpe.com/hpsc/doc/public/display?sp4ts.oid\u003d7829634\u0026docId\u003demr_na-c04565930\u0026docLocale\u003den_US"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_e9b9c216","line":270,"range":{"start_line":267,"start_character":0,"end_line":270,"end_character":168},"in_reply_to":"3afc51ec_7b9aa264","updated":"2016-03-15 10:30:30.000000000","message":"Done","commit_id":"06ff00f57f7cb83c74cbd0575bff7fcdb19492e6"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"932e01b59323af0d4982686ee46994b2daf064aa","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      the existing config drive partition and rewrite a new one (when Cinder"},{"line_number":73,"context_line":"      volume is reused multiple times)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    - Makes a proliantutils call (only supported on Gen9 hardware and above)"},{"line_number":76,"context_line":"      to set the the iSCSI target details on the bare metal server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    The function definition will be as follows::"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa0719c6_be0b3623","line":76,"range":{"start_line":75,"start_character":4,"end_line":76,"end_character":67},"updated":"2016-03-24 09:59:48.000000000","message":"I\u0027m just wondering if we move this call to prepare() because tear_down() takes care of clearing iscsi settings, and also it become easier to share the common code with irmc :-)","commit_id":"364f618cc0f07ff8982a20512032af015019edc7"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"4425718455eeb8ff7b12652c675f98962c8f9d24","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      the existing config drive partition and rewrite a new one (when Cinder"},{"line_number":73,"context_line":"      volume is reused multiple times)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    - Makes a proliantutils call (only supported on Gen9 hardware and above)"},{"line_number":76,"context_line":"      to set the the iSCSI target details on the bare metal server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    The function definition will be as follows::"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a061dce_ad567e27","line":76,"range":{"start_line":75,"start_character":4,"end_line":76,"end_character":67},"in_reply_to":"9a061dce_1e335b15","updated":"2016-04-07 08:36:08.000000000","message":"Shivanand,\n\nThanks for the reply.\n\nI\u0027m going to develop irmc driver which set iscsi and fc setting via OOB for cinder integration.\n\nCould we, ilo and irmc, could share the code for the L.69-73 portion in deploy()?\n\nI thought we could if we move the deploy() to a new common class.\n\nBest regards,\nNaohiro","commit_id":"364f618cc0f07ff8982a20512032af015019edc7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5d620df1cb4f37744e079b2599d49f0858ceb429","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      the existing config drive partition and rewrite a new one (when Cinder"},{"line_number":73,"context_line":"      volume is reused multiple times)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    - Makes a proliantutils call (only supported on Gen9 hardware and above)"},{"line_number":76,"context_line":"      to set the the iSCSI target details on the bare metal server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    The function definition will be as follows::"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a061dce_1e335b15","line":76,"range":{"start_line":75,"start_character":4,"end_line":76,"end_character":67},"in_reply_to":"fa0719c6_be0b3623","updated":"2016-04-07 04:21:48.000000000","message":"These are direct poliantutils calls that are done to set the iscsi settings on the node. There is no other code that would go here. I\u0027m not sure how you would b able to leverage iLO specific code.\nIt is kept in \u0027deploy\u0027 as upon performing these settings, node would be restarted and there are no further steps to that.","commit_id":"364f618cc0f07ff8982a20512032af015019edc7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, Ironic (or any other ironic driver) provides no capability to boot"},{"line_number":21,"context_line":"from Cinder volume. Changes are proposed to `add support in Ironic framework`_"},{"line_number":22,"context_line":"(data model, API, etc) for booting from a Cinder volume. HPE ProLiant Gen9"},{"line_number":23,"context_line":"hardware (having HPE ProLiant Gen9 System ROM P89 release version 1.40 or"},{"line_number":24,"context_line":"higher) supports booting from an iSCSI volume. Hardware can be configured"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_3ef7bbf6","line":21,"updated":"2016-11-21 15:52:22.000000000","message":"There is a second specification, generic boot from volume support, which should likely be referenced as well since it supplies substrate interface that will be needed.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, Ironic (or any other ironic driver) provides no capability to boot"},{"line_number":21,"context_line":"from Cinder volume. Changes are proposed to `add support in Ironic framework`_"},{"line_number":22,"context_line":"(data model, API, etc) for booting from a Cinder volume. HPE ProLiant Gen9"},{"line_number":23,"context_line":"hardware (having HPE ProLiant Gen9 System ROM P89 release version 1.40 or"},{"line_number":24,"context_line":"higher) supports booting from an iSCSI volume. Hardware can be configured"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_3dc8ba54","line":21,"in_reply_to":"7a77a97e_3ef7bbf6","updated":"2016-12-09 09:37:40.000000000","message":"Done","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, Ironic (or any other ironic driver) provides no capability to boot"},{"line_number":21,"context_line":"from Cinder volume. Changes are proposed to `add support in Ironic framework`_"},{"line_number":22,"context_line":"(data model, API, etc) for booting from a Cinder volume. HPE ProLiant Gen9"},{"line_number":23,"context_line":"hardware (having HPE ProLiant Gen9 System ROM P89 release version 1.40 or"},{"line_number":24,"context_line":"higher) supports booting from an iSCSI volume. Hardware can be configured"},{"line_number":25,"context_line":"programmatically to boot from an iSCSI volume (without using bootloaders like"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_3e45fb16","line":22,"range":{"start_line":22,"start_character":56,"end_line":22,"end_character":57},"updated":"2016-11-21 15:52:22.000000000","message":"nit: This might be a good place to begin a new paragraph since the description is shifting focus from ironic to the capabilities of Gen9 hardware.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, Ironic (or any other ironic driver) provides no capability to boot"},{"line_number":21,"context_line":"from Cinder volume. Changes are proposed to `add support in Ironic framework`_"},{"line_number":22,"context_line":"(data model, API, etc) for booting from a Cinder volume. HPE ProLiant Gen9"},{"line_number":23,"context_line":"hardware (having HPE ProLiant Gen9 System ROM P89 release version 1.40 or"},{"line_number":24,"context_line":"higher) supports booting from an iSCSI volume. Hardware can be configured"},{"line_number":25,"context_line":"programmatically to boot from an iSCSI volume (without using bootloaders like"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_fd0d628f","line":22,"range":{"start_line":22,"start_character":56,"end_line":22,"end_character":57},"in_reply_to":"7a77a97e_3e45fb16","updated":"2016-12-09 09:37:40.000000000","message":"Done","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":33,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":34,"context_line":"change proposes a new implementation of ``DeployInterface`` named"},{"line_number":35,"context_line":"``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":36,"context_line":"for HPE ProLiant Gen9 Hardware (having HPE ProLiant Gen9 System ROM P89 release"},{"line_number":37,"context_line":"version 1.40 or higher). The aim is to have a completely new driver which helps"},{"line_number":38,"context_line":"facilitate to leverage the remote storage as a boot volume."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Again, here a soft dependency exists on the"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_febd43d8","line":37,"range":{"start_line":36,"start_character":32,"end_line":37,"end_character":23},"updated":"2016-11-21 15:52:22.000000000","message":"This seems redundant from the problem description.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":34,"context_line":"change proposes a new implementation of ``DeployInterface`` named"},{"line_number":35,"context_line":"``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":36,"context_line":"for HPE ProLiant Gen9 Hardware (having HPE ProLiant Gen9 System ROM P89 release"},{"line_number":37,"context_line":"version 1.40 or higher). The aim is to have a completely new driver which helps"},{"line_number":38,"context_line":"facilitate to leverage the remote storage as a boot volume."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Again, here a soft dependency exists on the"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_7866c0bb","line":37,"range":{"start_line":36,"start_character":32,"end_line":37,"end_character":23},"in_reply_to":"7a77a97e_febd43d8","updated":"2016-12-09 09:37:40.000000000","message":"Removed. Done","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    - This will validate whether the necessary inputs"},{"line_number":52,"context_line":"      for booting from iSCSI volume are provided in node (in the place as"},{"line_number":53,"context_line":"      mentioned in the `parent spec`_). This includes target IQN, LUN number,"},{"line_number":54,"context_line":"      IP address of target, port, authentication method, username, password."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    - Check if an attribute ``node.properties.capabilities[\u0027iscsi_boot\u0027]``"},{"line_number":57,"context_line":"      is set to ``true`` (This attribute may be populated by inspection or may"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_1e983f6a","line":54,"updated":"2016-11-21 15:52:22.000000000","message":"One thing likely worth noting, is this information comes from the originating storage system driver in cinder, so there can be some variation, and you can\u0027t expect to always have all of these parameters, that is unless proliant hardware explicitly requires all of these fields.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    - This will validate whether the necessary inputs"},{"line_number":52,"context_line":"      for booting from iSCSI volume are provided in node (in the place as"},{"line_number":53,"context_line":"      mentioned in the `parent spec`_). This includes target IQN, LUN number,"},{"line_number":54,"context_line":"      IP address of target, port, authentication method, username, password."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    - Check if an attribute ``node.properties.capabilities[\u0027iscsi_boot\u0027]``"},{"line_number":57,"context_line":"      is set to ``true`` (This attribute may be populated by inspection or may"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_d356d5cc","line":54,"in_reply_to":"7a77a97e_1e983f6a","updated":"2016-12-09 09:37:40.000000000","message":"Added. Please have a look.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":59,"context_line":"      information about this attribute is also mentioned in the"},{"line_number":60,"context_line":"      `parent spec`_)."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    - Need to check if the implementation of the validation logic in the"},{"line_number":63,"context_line":"      reference driver for boot from volume can be reused for the node managed"},{"line_number":64,"context_line":"      by this driver."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. _`parent spec`: https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/volume-connection-information.html"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_9e1fefb6","line":64,"range":{"start_line":62,"start_character":6,"end_line":64,"end_character":21},"updated":"2016-11-21 15:52:22.000000000","message":"Nit: This would likely read more clearly if started off as \"If any of the validation logic in the reference driver can be reused, we will attempt to reuse...\"","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"      information about this attribute is also mentioned in the"},{"line_number":60,"context_line":"      `parent spec`_)."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    - Need to check if the implementation of the validation logic in the"},{"line_number":63,"context_line":"      reference driver for boot from volume can be reused for the node managed"},{"line_number":64,"context_line":"      by this driver."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. _`parent spec`: https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/volume-connection-information.html"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_80dd8216","line":64,"range":{"start_line":62,"start_character":6,"end_line":64,"end_character":21},"in_reply_to":"7a77a97e_9e1fefb6","updated":"2016-12-09 09:37:40.000000000","message":"makes more sense.. thanks","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      reference driver for boot from volume can be reused for the node managed"},{"line_number":64,"context_line":"      by this driver."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. _`parent spec`: https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/volume-connection-information.html"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  The function definition will be as follows::"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_fe7c63ed","line":66,"updated":"2016-11-21 15:52:22.000000000","message":"This should likely link to the approved path instead of the not implemented path, as once the feature lands, this link will be broken.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      reference driver for boot from volume can be reused for the node managed"},{"line_number":64,"context_line":"      by this driver."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. _`parent spec`: https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/volume-connection-information.html"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  The function definition will be as follows::"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_60f8664a","line":66,"in_reply_to":"7a77a97e_fe7c63ed","updated":"2016-12-09 09:37:40.000000000","message":"Done in all such references.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - ``prepare()`` - This will do the following:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    - Makes a ``proliantutils`` call (only supported on Gen9 hardware and"},{"line_number":83,"context_line":"      above) to set the the iSCSI target details on the bare metal server."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    - Hence, ``proposed_new_driver.deploy.prepare`` method turns out to be the"},{"line_number":86,"context_line":"      major operation place for the iSCSI target booting configuration to be"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_8b716c7a","line":83,"range":{"start_line":82,"start_character":38,"end_line":83,"end_character":11},"updated":"2016-11-21 15:52:22.000000000","message":"nit: It seems a little redundant to mention Gen9 hardware again, perhaps something about returning an exception if unsupported by the hardware?","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - ``prepare()`` - This will do the following:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    - Makes a ``proliantutils`` call (only supported on Gen9 hardware and"},{"line_number":83,"context_line":"      above) to set the the iSCSI target details on the bare metal server."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    - Hence, ``proposed_new_driver.deploy.prepare`` method turns out to be the"},{"line_number":86,"context_line":"      major operation place for the iSCSI target booting configuration to be"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_230f582f","line":83,"range":{"start_line":82,"start_character":38,"end_line":83,"end_character":11},"in_reply_to":"7a77a97e_8b716c7a","updated":"2016-12-09 09:37:40.000000000","message":"Done","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    - Clears the iSCSI settings from the ProLiant hardware by making a"},{"line_number":130,"context_line":"      ``proliantutils`` call."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    - Ironic conductor connects to the remote iSCSI volume and takes the"},{"line_number":133,"context_line":"      necessary actions required. Here also the reference driver"},{"line_number":134,"context_line":"      implementation can be suitably reused."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_ab9f084f","line":132,"range":{"start_line":132,"start_character":39,"end_line":132,"end_character":58},"updated":"2016-11-21 15:52:22.000000000","message":"The conductor will not be attaching the remote to the conductor, we will simply remove references to it in the conductor side records, and a user can then re-use or delete the volume offered by cinder.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    - Clears the iSCSI settings from the ProLiant hardware by making a"},{"line_number":130,"context_line":"      ``proliantutils`` call."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    - Ironic conductor connects to the remote iSCSI volume and takes the"},{"line_number":133,"context_line":"      necessary actions required. Here also the reference driver"},{"line_number":134,"context_line":"      implementation can be suitably reused."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_49a0f59f","line":132,"range":{"start_line":132,"start_character":39,"end_line":132,"end_character":58},"in_reply_to":"7a77a97e_ab9f084f","updated":"2016-12-09 09:37:40.000000000","message":"Have rephrased the statement. Please have a re-look.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":147,"context_line":"encourage the reference driver implementation framework to provide varied hook"},{"line_number":148,"context_line":"points to be consumed by downstream vendor drivers to plugin their desired"},{"line_number":149,"context_line":"iSCSI configuration setup implementation (enabling their out-of-band"},{"line_number":150,"context_line":"environment\u0027s needs). This option will make the reference driver code taking"},{"line_number":151,"context_line":"care of various vendor needs and can easily fall into the trap of"},{"line_number":152,"context_line":"*one-size-fits-all* syndrome and may prove to be grown out of place."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Another option could be to wait till the `Driver composition reform"},{"line_number":155,"context_line":"specification`_ functionality gets in vogue and then instead of adding any more"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_2b085891","line":152,"range":{"start_line":150,"start_character":22,"end_line":152,"end_character":68},"updated":"2016-11-21 15:52:22.000000000","message":"++++++++","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":147,"context_line":"encourage the reference driver implementation framework to provide varied hook"},{"line_number":148,"context_line":"points to be consumed by downstream vendor drivers to plugin their desired"},{"line_number":149,"context_line":"iSCSI configuration setup implementation (enabling their out-of-band"},{"line_number":150,"context_line":"environment\u0027s needs). This option will make the reference driver code taking"},{"line_number":151,"context_line":"care of various vendor needs and can easily fall into the trap of"},{"line_number":152,"context_line":"*one-size-fits-all* syndrome and may prove to be grown out of place."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Another option could be to wait till the `Driver composition reform"},{"line_number":155,"context_line":"specification`_ functionality gets in vogue and then instead of adding any more"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_c326a467","line":152,"range":{"start_line":150,"start_character":22,"end_line":152,"end_character":68},"in_reply_to":"7a77a97e_2b085891","updated":"2016-12-09 09:37:40.000000000","message":":-)","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":206,"context_line":"---------------------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Users can request for a bare metal to be booted from an iSCSI Cinder volume"},{"line_number":209,"context_line":"from Nova, and Ironic can fulfill the request with HPE ProLiant Gen9 servers."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Scalability impact"},{"line_number":212,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_4b59148e","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":9},"updated":"2016-11-21 15:52:22.000000000","message":"This individual  specification does not enable that.  Nova will not have the functionality until we have the capability to use the store information transmitted by Nova.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":206,"context_line":"---------------------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Users can request for a bare metal to be booted from an iSCSI Cinder volume"},{"line_number":209,"context_line":"from Nova, and Ironic can fulfill the request with HPE ProLiant Gen9 servers."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Scalability impact"},{"line_number":212,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_e9eaa1ab","line":209,"range":{"start_line":209,"start_character":0,"end_line":209,"end_character":9},"in_reply_to":"7a77a97e_4b59148e","updated":"2016-12-09 09:37:40.000000000","message":"Agreed. Removed this ``Nova`` mentioning for now.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":221,"context_line":"Other deployer impact"},{"line_number":222,"context_line":"---------------------"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Deployers can configure the HPE ProLiant Gen9 hardware with the newly added"},{"line_number":225,"context_line":"deploy driver and use UEFI iSCSI boot feature. The workflow will be as"},{"line_number":226,"context_line":"follows:"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_ab8548ae","line":224,"range":{"start_line":224,"start_character":10,"end_line":224,"end_character":13},"updated":"2016-11-21 15:52:22.000000000","message":"s/can/will be able to/","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":221,"context_line":"Other deployer impact"},{"line_number":222,"context_line":"---------------------"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Deployers can configure the HPE ProLiant Gen9 hardware with the newly added"},{"line_number":225,"context_line":"deploy driver and use UEFI iSCSI boot feature. The workflow will be as"},{"line_number":226,"context_line":"follows:"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_8904cd7e","line":224,"range":{"start_line":224,"start_character":10,"end_line":224,"end_character":13},"in_reply_to":"7a77a97e_ab8548ae","updated":"2016-12-09 09:37:40.000000000","message":"Done","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":263,"context_line":"----------"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"* Add a new deploy driver."},{"line_number":266,"context_line":"* Write unit tests."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Dependencies"},{"line_number":269,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_1e591f8f","line":266,"updated":"2016-11-21 15:52:22.000000000","message":"Please add update ilo driver documentation as an explicit work item.","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":263,"context_line":"----------"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"* Add a new deploy driver."},{"line_number":266,"context_line":"* Write unit tests."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Dependencies"},{"line_number":269,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_4959d559","line":266,"in_reply_to":"7a77a97e_1e591f8f","updated":"2016-12-09 09:37:40.000000000","message":"Done","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"79c0ac0409c79f24dfa8aa7668c61a445ebb6533","unresolved":false,"context_lines":[{"line_number":274,"context_line":"Testing"},{"line_number":275,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Unit tests will be added."},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":280,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a77a97e_4b6cb408","line":277,"updated":"2016-11-21 15:52:22.000000000","message":"Unit tests are implied.  Will this functionality be tested in third-party CI?","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"0cfe394ee62b289607fdfa9bce24ad5fd48dd7e7","unresolved":false,"context_lines":[{"line_number":274,"context_line":"Testing"},{"line_number":275,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Unit tests will be added."},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":280,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a71b18c_d4a57804","line":277,"in_reply_to":"7a77a97e_4b6cb408","updated":"2016-12-09 09:37:40.000000000","message":"Updated this portion","commit_id":"0b214ca01067e7006743f039553089e55f33c809"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"559656e9aed9d5bdde6298e1833c94f8c953a3ab","unresolved":false,"context_lines":[{"line_number":36,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":37,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":38,"context_line":"change proposes a new implementation of ``DeployInterface`` named"},{"line_number":39,"context_line":"``IloUefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":40,"context_line":"for HPE ProLiant Gen9 Hardware. The aim is to have a completely new driver"},{"line_number":41,"context_line":"which helps facilitate to leverage the remote storage as a boot volume."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a71b18c_d5a57204","line":39,"updated":"2016-12-09 10:10:48.000000000","message":"nit: Can this be named as IloUefiIscsiDeploy as Ironic have both \u0027boot\u0027 and \u0027deploy\u0027 interfaces","commit_id":"56544364ad4e635da6d44f32acaaae53ec20deda"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"559656e9aed9d5bdde6298e1833c94f8c953a3ab","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  - ``clean_up()`` - This will do the following:"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    - Depending upon whether the node wants to re-use or delete the volume"},{"line_number":145,"context_line":"      offered by cinder while in case of reboot, the iSCSI target settings are"},{"line_number":146,"context_line":"      to be retained or cleared from the ProLiant hardware by making a"},{"line_number":147,"context_line":"      ``proliantutils`` call."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a71b18c_95377aaf","line":145,"updated":"2016-12-09 10:10:48.000000000","message":"I think iscsi target settings should not be cleared in case of reboot. The node should reboot using same cindr volume. It should be cleared only when node is tear_down. Anyways clean_up will not get called during node reboot.","commit_id":"56544364ad4e635da6d44f32acaaae53ec20deda"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":24,"context_line":"an iSCSI volume in their firmware themselves."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Hardware can also be configured programmatically to boot from an iSCSI volume"},{"line_number":27,"context_line":"(without using bootloaders like iPXE) via the firmware/lights out management."},{"line_number":28,"context_line":"HPE ProLiant Gen9 hardware (having HPE ProLiant Gen9 System ROM P89 release"},{"line_number":29,"context_line":"version 1.40 or higher) supports such a booting option from an iSCSI volume."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_ae4b695d","line":27,"range":{"start_line":27,"start_character":54,"end_line":27,"end_character":76},"updated":"2017-10-04 07:42:15.000000000","message":"s/ \u0027/lights out management\u0027 //","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"an iSCSI volume in their firmware themselves."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Hardware can also be configured programmatically to boot from an iSCSI volume"},{"line_number":27,"context_line":"(without using bootloaders like iPXE) via the firmware/lights out management."},{"line_number":28,"context_line":"HPE ProLiant Gen9 hardware (having HPE ProLiant Gen9 System ROM P89 release"},{"line_number":29,"context_line":"version 1.40 or higher) supports such a booting option from an iSCSI volume."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_e9d8a6ef","line":27,"range":{"start_line":27,"start_character":54,"end_line":27,"end_character":76},"in_reply_to":"7f515b1d_ae4b695d","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":37,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":38,"context_line":"change proposes two new methods for ilo management interface"},{"line_number":39,"context_line":"``set_iscsi_boot_target`` and ``clear_iscsi_boot_target`` which will facilitate"},{"line_number":40,"context_line":"booting from iSCSI Cinder volume for UEFI iSCSI boot capable HPE Proliant servers."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In ``IloPXEBoot``, ``prepare_instance()`` will check whether volume is provisioned"},{"line_number":43,"context_line":"with the user image to boot from or not, if provisioned then it set the iSCSI target"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_4ea875da","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":12},"updated":"2017-10-04 07:42:15.000000000","message":"setting and clearing iSCSI target information using iLO interface.","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":38,"context_line":"change proposes two new methods for ilo management interface"},{"line_number":39,"context_line":"``set_iscsi_boot_target`` and ``clear_iscsi_boot_target`` which will facilitate"},{"line_number":40,"context_line":"booting from iSCSI Cinder volume for UEFI iSCSI boot capable HPE Proliant servers."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In ``IloPXEBoot``, ``prepare_instance()`` will check whether volume is provisioned"},{"line_number":43,"context_line":"with the user image to boot from or not, if provisioned then it set the iSCSI target"}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_c9fa8a41","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":12},"in_reply_to":"7f515b1d_4ea875da","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":39,"context_line":"``set_iscsi_boot_target`` and ``clear_iscsi_boot_target`` which will facilitate"},{"line_number":40,"context_line":"booting from iSCSI Cinder volume for UEFI iSCSI boot capable HPE Proliant servers."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In ``IloPXEBoot``, ``prepare_instance()`` will check whether volume is provisioned"},{"line_number":43,"context_line":"with the user image to boot from or not, if provisioned then it set the iSCSI target"},{"line_number":44,"context_line":"related attributes."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_ce8c6581","line":42,"range":{"start_line":42,"start_character":3,"end_line":42,"end_character":17},"updated":"2017-10-04 07:42:15.000000000","message":"Better to refer it as \u0027ilo-pxe\u0027 boot interface.","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"``set_iscsi_boot_target`` and ``clear_iscsi_boot_target`` which will facilitate"},{"line_number":40,"context_line":"booting from iSCSI Cinder volume for UEFI iSCSI boot capable HPE Proliant servers."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In ``IloPXEBoot``, ``prepare_instance()`` will check whether volume is provisioned"},{"line_number":43,"context_line":"with the user image to boot from or not, if provisioned then it set the iSCSI target"},{"line_number":44,"context_line":"related attributes."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_a9a50e49","line":42,"range":{"start_line":42,"start_character":3,"end_line":42,"end_character":17},"in_reply_to":"7f515b1d_ce8c6581","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In ``IloPXEBoot``, ``prepare_instance()`` will check whether volume is provisioned"},{"line_number":43,"context_line":"with the user image to boot from or not, if provisioned then it set the iSCSI target"},{"line_number":44,"context_line":"related attributes."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  - Check if in node capabilities boot mode is set to ``uefi`` and"},{"line_number":47,"context_line":"    ``iscsi_boot`` is true. If boot mode is ``bios`` it let iPXE to"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_cee1052d","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":19},"updated":"2017-10-04 07:42:15.000000000","message":"If requested boot mode is \u0027UEFI\u0027.","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In ``IloPXEBoot``, ``prepare_instance()`` will check whether volume is provisioned"},{"line_number":43,"context_line":"with the user image to boot from or not, if provisioned then it set the iSCSI target"},{"line_number":44,"context_line":"related attributes."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  - Check if in node capabilities boot mode is set to ``uefi`` and"},{"line_number":47,"context_line":"    ``iscsi_boot`` is true. If boot mode is ``bios`` it let iPXE to"}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_69371601","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":19},"in_reply_to":"7f515b1d_cee1052d","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":43,"context_line":"with the user image to boot from or not, if provisioned then it set the iSCSI target"},{"line_number":44,"context_line":"related attributes."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  - Check if in node capabilities boot mode is set to ``uefi`` and"},{"line_number":47,"context_line":"    ``iscsi_boot`` is true. If boot mode is ``bios`` it let iPXE to"},{"line_number":48,"context_line":"    boot the volume."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_4ecf55b0","line":46,"range":{"start_line":46,"start_character":34,"end_line":46,"end_character":43},"updated":"2017-10-04 07:42:15.000000000","message":"capability name is \u0027boot_mode\u0027","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"with the user image to boot from or not, if provisioned then it set the iSCSI target"},{"line_number":44,"context_line":"related attributes."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  - Check if in node capabilities boot mode is set to ``uefi`` and"},{"line_number":47,"context_line":"    ``iscsi_boot`` is true. If boot mode is ``bios`` it let iPXE to"},{"line_number":48,"context_line":"    boot the volume."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_e922e6b8","line":46,"range":{"start_line":46,"start_character":34,"end_line":46,"end_character":43},"in_reply_to":"7f515b1d_4ecf55b0","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":43,"context_line":"with the user image to boot from or not, if provisioned then it set the iSCSI target"},{"line_number":44,"context_line":"related attributes."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  - Check if in node capabilities boot mode is set to ``uefi`` and"},{"line_number":47,"context_line":"    ``iscsi_boot`` is true. If boot mode is ``bios`` it let iPXE to"},{"line_number":48,"context_line":"    boot the volume."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"},{"line_number":51,"context_line":"    not using storage interface ``should_write_image``. If not, then it may"},{"line_number":52,"context_line":"    notify the trigger of the mechanism to write the image to volume. Although"},{"line_number":53,"context_line":"    this mechanism is ideally part of deploy interface\u0027s ``prepare()`` method"},{"line_number":54,"context_line":"    but can be re-used here if the deploy interface is properly configured."},{"line_number":55,"context_line":"    It should raise an exception if that is not properly configured."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  - Alternatively, boot interface\u0027s ``validate()`` method could also check for"},{"line_number":58,"context_line":"    this and raise this exception if an invalid configuration is requested or"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_6e58d1f9","line":55,"range":{"start_line":46,"start_character":4,"end_line":55,"end_character":68},"updated":"2017-10-04 07:42:15.000000000","message":"May be better to add pseudo code. It may be become easier to understand.","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"with the user image to boot from or not, if provisioned then it set the iSCSI target"},{"line_number":44,"context_line":"related attributes."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  - Check if in node capabilities boot mode is set to ``uefi`` and"},{"line_number":47,"context_line":"    ``iscsi_boot`` is true. If boot mode is ``bios`` it let iPXE to"},{"line_number":48,"context_line":"    boot the volume."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"},{"line_number":51,"context_line":"    not using storage interface ``should_write_image``. If not, then it may"},{"line_number":52,"context_line":"    notify the trigger of the mechanism to write the image to volume. Although"},{"line_number":53,"context_line":"    this mechanism is ideally part of deploy interface\u0027s ``prepare()`` method"},{"line_number":54,"context_line":"    but can be re-used here if the deploy interface is properly configured."},{"line_number":55,"context_line":"    It should raise an exception if that is not properly configured."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  - Alternatively, boot interface\u0027s ``validate()`` method could also check for"},{"line_number":58,"context_line":"    this and raise this exception if an invalid configuration is requested or"}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_2486e314","line":55,"range":{"start_line":46,"start_character":4,"end_line":55,"end_character":68},"in_reply_to":"7f515b1d_6e58d1f9","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    It should raise an exception if that is not properly configured."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  - Alternatively, boot interface\u0027s ``validate()`` method could also check for"},{"line_number":58,"context_line":"    this and raise this exception if an invalid configuration is requested or"},{"line_number":59,"context_line":"    configured for the server"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  - If check is satisfied it will set iSCSI target details by calling"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_ee6ba182","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":61},"updated":"2017-10-04 07:42:15.000000000","message":"What is the invalid configuration here?","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    It should raise an exception if that is not properly configured."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  - Alternatively, boot interface\u0027s ``validate()`` method could also check for"},{"line_number":58,"context_line":"    this and raise this exception if an invalid configuration is requested or"},{"line_number":59,"context_line":"    configured for the server"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  - If check is satisfied it will set iSCSI target details by calling"}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_848b571d","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":61},"in_reply_to":"7f515b1d_ee6ba182","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  - It will also set boot device to ``ISCSIBOOT``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"In ``IloPXEBoot``, ``clean_up_instance()`` method it will clear the iSCSI"},{"line_number":67,"context_line":"target details by calling ``clear_iscsi_boot_target`` ilo management module."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In ``IloVirtualMediaBoot``, ``prepare_instance()`` will check whether volume"},{"line_number":70,"context_line":"is provisioned with the user image to boot from or not, if provisioned then"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_4e12b50b","line":67,"range":{"start_line":67,"start_character":54,"end_line":67,"end_character":75},"updated":"2017-10-04 07:42:15.000000000","message":"s/ \u0027ilo management module\u0027 / \u0027from ilo management module\u0027/","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  - It will also set boot device to ``ISCSIBOOT``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"In ``IloPXEBoot``, ``clean_up_instance()`` method it will clear the iSCSI"},{"line_number":67,"context_line":"target details by calling ``clear_iscsi_boot_target`` ilo management module."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In ``IloVirtualMediaBoot``, ``prepare_instance()`` will check whether volume"},{"line_number":70,"context_line":"is provisioned with the user image to boot from or not, if provisioned then"}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_4481dffa","line":67,"range":{"start_line":67,"start_character":54,"end_line":67,"end_character":75},"in_reply_to":"7f515b1d_4e12b50b","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":66,"context_line":"In ``IloPXEBoot``, ``clean_up_instance()`` method it will clear the iSCSI"},{"line_number":67,"context_line":"target details by calling ``clear_iscsi_boot_target`` ilo management module."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In ``IloVirtualMediaBoot``, ``prepare_instance()`` will check whether volume"},{"line_number":70,"context_line":"is provisioned with the user image to boot from or not, if provisioned then"},{"line_number":71,"context_line":"it set the iSCSI target related attributes."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_4e2bd52f","line":69,"range":{"start_line":69,"start_character":3,"end_line":69,"end_character":26},"updated":"2017-10-04 07:42:15.000000000","message":"iLO virtual media based boot interface \u0027ilo-virtual-media\u0027","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"In ``IloPXEBoot``, ``clean_up_instance()`` method it will clear the iSCSI"},{"line_number":67,"context_line":"target details by calling ``clear_iscsi_boot_target`` ilo management module."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In ``IloVirtualMediaBoot``, ``prepare_instance()`` will check whether volume"},{"line_number":70,"context_line":"is provisioned with the user image to boot from or not, if provisioned then"},{"line_number":71,"context_line":"it set the iSCSI target related attributes."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_c4602fd2","line":69,"range":{"start_line":69,"start_character":3,"end_line":69,"end_character":26},"in_reply_to":"7f515b1d_4e2bd52f","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2128cecdd1df4f71b2e87dc9e2bc9909d195c91b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    ``iscsi_boot`` is true. If boot mode is ``bios`` it will throw"},{"line_number":75,"context_line":"    error ``virtual media can\u0027t boot volume in bios mode.``"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"},{"line_number":78,"context_line":"    not using storage interface ``should_write_image``. If not, then it may"},{"line_number":79,"context_line":"    notify the trigger of the mechanism to write the image to volume. Although"},{"line_number":80,"context_line":"    this mechanism is ideally part of deploy interface\u0027s ``prepare()`` method"},{"line_number":81,"context_line":"    but can be re-used here if the deploy interface is properly configured."},{"line_number":82,"context_line":"    It should raise an exception if that is not properly configured."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  - Alternatively, boot interface\u0027s ``validate()`` method could also check for"},{"line_number":85,"context_line":"    this and raise this exception if an invalid configuration is requested or"},{"line_number":86,"context_line":"    configured for the server"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  - If check is satisfied it will set iSCSI target details by calling"},{"line_number":89,"context_line":"    ``set_iscsi_boot_target`` ilo management module."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  - It will also set boot device to ``ISCSIBOOT``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"In ``IloVirtualMediaBoot``, ``clean_up_instance()`` method it will clear the iSCSI"},{"line_number":94,"context_line":"target details by calling ``clear_iscsi_boot_target`` ilo management module."}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_663c9192","line":91,"range":{"start_line":77,"start_character":0,"end_line":91,"end_character":49},"updated":"2017-10-03 09:52:23.000000000","message":"This is a repeat from lines 50-64.","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    ``iscsi_boot`` is true. If boot mode is ``bios`` it will throw"},{"line_number":75,"context_line":"    error ``virtual media can\u0027t boot volume in bios mode.``"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"},{"line_number":78,"context_line":"    not using storage interface ``should_write_image``. If not, then it may"},{"line_number":79,"context_line":"    notify the trigger of the mechanism to write the image to volume. Although"},{"line_number":80,"context_line":"    this mechanism is ideally part of deploy interface\u0027s ``prepare()`` method"},{"line_number":81,"context_line":"    but can be re-used here if the deploy interface is properly configured."},{"line_number":82,"context_line":"    It should raise an exception if that is not properly configured."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  - Alternatively, boot interface\u0027s ``validate()`` method could also check for"},{"line_number":85,"context_line":"    this and raise this exception if an invalid configuration is requested or"},{"line_number":86,"context_line":"    configured for the server"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  - If check is satisfied it will set iSCSI target details by calling"},{"line_number":89,"context_line":"    ``set_iscsi_boot_target`` ilo management module."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  - It will also set boot device to ``ISCSIBOOT``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"In ``IloVirtualMediaBoot``, ``clean_up_instance()`` method it will clear the iSCSI"},{"line_number":94,"context_line":"target details by calling ``clear_iscsi_boot_target`` ilo management module."}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_04b08742","line":91,"range":{"start_line":77,"start_character":0,"end_line":91,"end_character":49},"in_reply_to":"7f515b1d_663c9192","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2128cecdd1df4f71b2e87dc9e2bc9909d195c91b","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  - It will also set boot device to ``ISCSIBOOT``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"In ``IloVirtualMediaBoot``, ``clean_up_instance()`` method it will clear the iSCSI"},{"line_number":94,"context_line":"target details by calling ``clear_iscsi_boot_target`` ilo management module."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"In iLO management interface there will be two new methods ``set_iscsi_boot_target``"},{"line_number":97,"context_line":"and ``clear_iscsi_boot_target`` will call appropriate library to set and clear"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_86078dca","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":76},"updated":"2017-10-03 09:52:23.000000000","message":"again this is a repeat except the name of the boot interface.","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  - It will also set boot device to ``ISCSIBOOT``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"In ``IloVirtualMediaBoot``, ``clean_up_instance()`` method it will clear the iSCSI"},{"line_number":94,"context_line":"target details by calling ``clear_iscsi_boot_target`` ilo management module."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"In iLO management interface there will be two new methods ``set_iscsi_boot_target``"},{"line_number":97,"context_line":"and ``clear_iscsi_boot_target`` will call appropriate library to set and clear"}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_c4b5cf33","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":76},"in_reply_to":"7f515b1d_86078dca","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2128cecdd1df4f71b2e87dc9e2bc9909d195c91b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"In ``IloVirtualMediaBoot``, ``clean_up_instance()`` method it will clear the iSCSI"},{"line_number":94,"context_line":"target details by calling ``clear_iscsi_boot_target`` ilo management module."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"In iLO management interface there will be two new methods ``set_iscsi_boot_target``"},{"line_number":97,"context_line":"and ``clear_iscsi_boot_target`` will call appropriate library to set and clear"},{"line_number":98,"context_line":"iSCSI target info."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  The function definition with its pseudo-code will be as follows:"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_06fb9dc0","line":98,"range":{"start_line":96,"start_character":0,"end_line":98,"end_character":18},"updated":"2017-10-03 09:52:23.000000000","message":"Already stated at line 39","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":93,"context_line":"In ``IloVirtualMediaBoot``, ``clean_up_instance()`` method it will clear the iSCSI"},{"line_number":94,"context_line":"target details by calling ``clear_iscsi_boot_target`` ilo management module."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"In iLO management interface there will be two new methods ``set_iscsi_boot_target``"},{"line_number":97,"context_line":"and ``clear_iscsi_boot_target`` will call appropriate library to set and clear"},{"line_number":98,"context_line":"iSCSI target info."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  The function definition with its pseudo-code will be as follows:"}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_a4b2d347","line":98,"range":{"start_line":96,"start_character":0,"end_line":98,"end_character":18},"in_reply_to":"7f515b1d_06fb9dc0","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2128cecdd1df4f71b2e87dc9e2bc9909d195c91b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      \"\"\""},{"line_number":119,"context_line":"      #Library call to clear iscsi target info"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Multipathing can be supported, if multiple NICs are enabled on the bare metal"},{"line_number":122,"context_line":"then iSCSI configuration is set up on all the enabled NICs. This can provide"},{"line_number":123,"context_line":"multiple redundant paths to the target if target is reachable through these"},{"line_number":124,"context_line":"NICs."}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_0624bd5c","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":29},"updated":"2017-10-03 09:52:23.000000000","message":"Does it require any change in ironic for supporting it?\nIf it doesnt require any change then i think it doesnt make any sense to mention it here, it should part of the docs rather.\nAnd moreover, it doesnt look ilo specific, rather it looks as a common thing applicable to any volume boot(not sure though). Possibly others can pour in their view points on this.","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      \"\"\""},{"line_number":119,"context_line":"      #Library call to clear iscsi target info"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Multipathing can be supported, if multiple NICs are enabled on the bare metal"},{"line_number":122,"context_line":"then iSCSI configuration is set up on all the enabled NICs. This can provide"},{"line_number":123,"context_line":"multiple redundant paths to the target if target is reachable through these"},{"line_number":124,"context_line":"NICs."}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_c46a6f7f","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":29},"in_reply_to":"7f515b1d_0624bd5c","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":205,"context_line":"* Tenant creates a Cinder volume."},{"line_number":206,"context_line":"* Tenant requests a bare metal instance to be booted up with a Cinder volume"},{"line_number":207,"context_line":"  with the above mentioned flavor."},{"line_number":208,"context_line":"* Nova scheduler selects a bare metal node capable of booting from Cinder"},{"line_number":209,"context_line":"  volume."},{"line_number":210,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":211,"context_line":"  For more information, refer nova spec"},{"line_number":212,"context_line":"  `Add support for booting bare metals from Cinder volume`_."}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_0ecb9d72","line":209,"range":{"start_line":208,"start_character":2,"end_line":209,"end_character":9},"updated":"2017-10-04 07:42:15.000000000","message":"Add a note that node having \u0027ilo-virtual-media\u0027 as boot interface with capability \u0027iscsi_boot\u003dtrue\u0027 should also have capability \u0027boot_mode\u0027 configured to \u0027uefi\u0027 only.","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":205,"context_line":"* Tenant creates a Cinder volume."},{"line_number":206,"context_line":"* Tenant requests a bare metal instance to be booted up with a Cinder volume"},{"line_number":207,"context_line":"  with the above mentioned flavor."},{"line_number":208,"context_line":"* Nova scheduler selects a bare metal node capable of booting from Cinder"},{"line_number":209,"context_line":"  volume."},{"line_number":210,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":211,"context_line":"  For more information, refer nova spec"},{"line_number":212,"context_line":"  `Add support for booting bare metals from Cinder volume`_."}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_e4a0cb92","line":209,"range":{"start_line":208,"start_character":2,"end_line":209,"end_character":9},"in_reply_to":"7f515b1d_0ecb9d72","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":233,"context_line":"Work Items"},{"line_number":234,"context_line":"----------"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Need to populate iscsi intiator iqn of the server via the inspection"},{"line_number":237,"context_line":"  process."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_4eae3599","line":236,"range":{"start_line":236,"start_character":2,"end_line":236,"end_character":51},"updated":"2017-10-04 07:42:15.000000000","message":"Is this mandatory?","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":233,"context_line":"Work Items"},{"line_number":234,"context_line":"----------"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Need to populate iscsi intiator iqn of the server via the inspection"},{"line_number":237,"context_line":"  process."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_24b4a3d0","line":236,"range":{"start_line":236,"start_character":2,"end_line":236,"end_character":51},"in_reply_to":"7f515b1d_4eae3599","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2128cecdd1df4f71b2e87dc9e2bc9909d195c91b","unresolved":false,"context_lines":[{"line_number":234,"context_line":"----------"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Need to populate iscsi intiator iqn of the server via the inspection"},{"line_number":237,"context_line":"  process."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"Dependencies"},{"line_number":240,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_e691a153","line":237,"updated":"2017-10-03 09:52:23.000000000","message":"Implementing set_iscsi_boot_target() and clear_iscsi_boot_target() are missing from work items.","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":234,"context_line":"----------"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Need to populate iscsi intiator iqn of the server via the inspection"},{"line_number":237,"context_line":"  process."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"Dependencies"},{"line_number":240,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_04fbe778","line":237,"in_reply_to":"7f515b1d_e691a153","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2128cecdd1df4f71b2e87dc9e2bc9909d195c91b","unresolved":false,"context_lines":[{"line_number":239,"context_line":"Dependencies"},{"line_number":240,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"To some extent on the implementation to be provided by as per proposal"},{"line_number":243,"context_line":"`Boot from Volume - Reference Drivers`_."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Testing"},{"line_number":246,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_86a30db2","line":243,"range":{"start_line":242,"start_character":0,"end_line":243,"end_character":40},"updated":"2017-10-03 09:52:23.000000000","message":"Since this work is already accomplished in last release(Pike), possibly we can remove this dependency.","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":239,"context_line":"Dependencies"},{"line_number":240,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"To some extent on the implementation to be provided by as per proposal"},{"line_number":243,"context_line":"`Boot from Volume - Reference Drivers`_."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Testing"},{"line_number":246,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_c4f02f94","line":243,"range":{"start_line":242,"start_character":0,"end_line":243,"end_character":40},"in_reply_to":"7f515b1d_86a30db2","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":245,"context_line":"Testing"},{"line_number":246,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"It is the expectation that vendors implementing boot from cinder/volume"},{"line_number":249,"context_line":"functionality, should have a test in their CI."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":252,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_6e821103","line":249,"range":{"start_line":248,"start_character":0,"end_line":249,"end_character":46},"updated":"2017-10-04 07:42:15.000000000","message":"May be you can add that this feature would be tested using iLO third-party CI.","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"28af6481452ebbfbc80d6f52a02c9f8a61d450f8","unresolved":false,"context_lines":[{"line_number":245,"context_line":"Testing"},{"line_number":246,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"It is the expectation that vendors implementing boot from cinder/volume"},{"line_number":249,"context_line":"functionality, should have a test in their CI."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":252,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":31,"id":"3f4b6375_c445cfb5","line":249,"range":{"start_line":248,"start_character":0,"end_line":249,"end_character":46},"in_reply_to":"7f515b1d_6e821103","updated":"2017-10-25 07:41:24.000000000","message":"Done","commit_id":"af0692dcc0eaddfe8e09b696a3417a7c4da81ac9"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"4e6b665c8cd66830aa1e1217469bc123b3b37bc5","unresolved":false,"context_lines":[{"line_number":129,"context_line":"In iLO management there will be two new interfaces ``set_iscsi_boot_target`` and"},{"line_number":130,"context_line":"``clear_iscsi_boot_target`` to set and clear the iSCSI target information, it will"},{"line_number":131,"context_line":"call appropriate library."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  The function definition with its pseudo-code will be as follows:"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  .. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":33,"id":"3f4b6375_39b0458a","line":132,"updated":"2017-10-25 10:16:53.000000000","message":"Will these method be defined to base.ManagementInterface?","commit_id":"1281148f7fa4fdf565c906f6521a1921407b34ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"a04bf2b813c245b206490376f5ae1926c1745547","unresolved":false,"context_lines":[{"line_number":129,"context_line":"In iLO management there will be two new interfaces ``set_iscsi_boot_target`` and"},{"line_number":130,"context_line":"``clear_iscsi_boot_target`` to set and clear the iSCSI target information, it will"},{"line_number":131,"context_line":"call appropriate library."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  The function definition with its pseudo-code will be as follows:"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  .. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":33,"id":"3f4b6375_2e1b41ca","line":132,"in_reply_to":"3f4b6375_39b0458a","updated":"2017-10-26 04:53:33.000000000","message":"It will be in HPE iLO management interface not in the base.","commit_id":"1281148f7fa4fdf565c906f6521a1921407b34ea"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"4e6b665c8cd66830aa1e1217469bc123b3b37bc5","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  interface and adds the capability ``iscsi_boot\u003dtrue``  in"},{"line_number":226,"context_line":"  ``node.properties[\u0027capabilities\u0027]`` (or it could be populated by"},{"line_number":227,"context_line":"  inspection, but it\u0027s not part of this spec on how it gets populated)."},{"line_number":228,"context_line":"* Server initiator iqn must be populated by inspection and added to volume"},{"line_number":229,"context_line":"  connector table for the node to be considered bootable."},{"line_number":230,"context_line":"* Operator creates a flavor with Compute capability ``iscsi_boot\u003dtrue`` to"},{"line_number":231,"context_line":"  request bare metal booting from Cinder volume."}],"source_content_type":"text/x-rst","patch_set":33,"id":"3f4b6375_79ec7d8e","line":228,"updated":"2017-10-25 10:16:53.000000000","message":"It seems allowed to create volume connectors manually according to a difference between PS 31.","commit_id":"1281148f7fa4fdf565c906f6521a1921407b34ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"a04bf2b813c245b206490376f5ae1926c1745547","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  interface and adds the capability ``iscsi_boot\u003dtrue``  in"},{"line_number":226,"context_line":"  ``node.properties[\u0027capabilities\u0027]`` (or it could be populated by"},{"line_number":227,"context_line":"  inspection, but it\u0027s not part of this spec on how it gets populated)."},{"line_number":228,"context_line":"* Server initiator iqn must be populated by inspection and added to volume"},{"line_number":229,"context_line":"  connector table for the node to be considered bootable."},{"line_number":230,"context_line":"* Operator creates a flavor with Compute capability ``iscsi_boot\u003dtrue`` to"},{"line_number":231,"context_line":"  request bare metal booting from Cinder volume."}],"source_content_type":"text/x-rst","patch_set":33,"id":"3f4b6375_2edea1d9","line":228,"in_reply_to":"3f4b6375_79ec7d8e","updated":"2017-10-26 04:53:33.000000000","message":"Done","commit_id":"1281148f7fa4fdf565c906f6521a1921407b34ea"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"4e6b665c8cd66830aa1e1217469bc123b3b37bc5","unresolved":false,"context_lines":[{"line_number":237,"context_line":"  to \u0027uefi\u0027 only."},{"line_number":238,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":239,"context_line":"  For more information, refer nova spec"},{"line_number":240,"context_line":"  `Add support for booting bare metals from Cinder volume`_."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":".. _`Add support for booting bare metals from Cinder volume`: https://review.openstack.org/#/c/211101/"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"3f4b6375_3e026b3e","line":240,"updated":"2017-10-25 10:16:53.000000000","message":"This SPEC was abandoned since the blueprint was approved as a specless BP. It would be better to refer to the ironic SPEC[1] containing how nova passes the information.\n\n[1] https://specs.openstack.org/openstack/ironic-specs/specs/9.0/volume-connection-information.html","commit_id":"1281148f7fa4fdf565c906f6521a1921407b34ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"a04bf2b813c245b206490376f5ae1926c1745547","unresolved":false,"context_lines":[{"line_number":237,"context_line":"  to \u0027uefi\u0027 only."},{"line_number":238,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":239,"context_line":"  For more information, refer nova spec"},{"line_number":240,"context_line":"  `Add support for booting bare metals from Cinder volume`_."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":".. _`Add support for booting bare metals from Cinder volume`: https://review.openstack.org/#/c/211101/"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"3f4b6375_0e988519","line":240,"in_reply_to":"3f4b6375_3e026b3e","updated":"2017-10-26 04:53:33.000000000","message":"Done","commit_id":"1281148f7fa4fdf565c906f6521a1921407b34ea"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"4e6b665c8cd66830aa1e1217469bc123b3b37bc5","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Need to implement ``set_iscsi_boot_target`` and ``clear_iscsi_boot_target``"},{"line_number":265,"context_line":"in ilo management interface."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Dependencies"},{"line_number":268,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"3f4b6375_b920b5ad","line":266,"updated":"2017-10-25 10:16:53.000000000","message":"Why don\u0027t you add changes to boot interfaces?","commit_id":"1281148f7fa4fdf565c906f6521a1921407b34ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"a04bf2b813c245b206490376f5ae1926c1745547","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"Need to implement ``set_iscsi_boot_target`` and ``clear_iscsi_boot_target``"},{"line_number":265,"context_line":"in ilo management interface."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Dependencies"},{"line_number":268,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"3f4b6375_aeb97179","line":266,"in_reply_to":"3f4b6375_b920b5ad","updated":"2017-10-26 04:53:33.000000000","message":"Done","commit_id":"1281148f7fa4fdf565c906f6521a1921407b34ea"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c1c7e0641e14abb2e9785128cba0af506f3687d1","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"HPE ProLiant Servers which support UEFI iSCSI Boot in its firmware, this"},{"line_number":14,"context_line":"feature is about adding support for booting from an iSCSI Cinder volume"},{"line_number":15,"context_line":"for those servers in uefi mode."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_1a700d08","line":15,"range":{"start_line":15,"start_character":21,"end_line":15,"end_character":25},"updated":"2017-11-02 06:22:05.000000000","message":"nit: s/ uefi / UEFI /","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7a7fb42172ffbd34cbed0a892ea13e513f71d71f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"HPE ProLiant Servers which support UEFI iSCSI Boot in its firmware, this"},{"line_number":14,"context_line":"feature is about adding support for booting from an iSCSI Cinder volume"},{"line_number":15,"context_line":"for those servers in uefi mode."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_32dbcced","line":15,"range":{"start_line":15,"start_character":21,"end_line":15,"end_character":25},"in_reply_to":"3f4b6375_1a700d08","updated":"2017-11-03 05:00:10.000000000","message":"Done","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c1c7e0641e14abb2e9785128cba0af506f3687d1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, Ironic has provided the capability to boot from Cinder volume."},{"line_number":21,"context_line":"Moreover, currently the support is limited to boot from an iSCSI volume"},{"line_number":22,"context_line":"with using bootloaders like iPXE but it still doesn\u0027t provide any way to"},{"line_number":23,"context_line":"harness the feature of some servers which inherently supports booting from"},{"line_number":24,"context_line":"an iSCSI volume in their firmware themselves."}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_ba58d989","line":21,"range":{"start_line":21,"start_character":10,"end_line":21,"end_character":24},"updated":"2017-11-02 06:22:05.000000000","message":"May be : s/ \u0027currently the \u0027 / \u0027this\u0027 /","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7a7fb42172ffbd34cbed0a892ea13e513f71d71f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, Ironic has provided the capability to boot from Cinder volume."},{"line_number":21,"context_line":"Moreover, currently the support is limited to boot from an iSCSI volume"},{"line_number":22,"context_line":"with using bootloaders like iPXE but it still doesn\u0027t provide any way to"},{"line_number":23,"context_line":"harness the feature of some servers which inherently supports booting from"},{"line_number":24,"context_line":"an iSCSI volume in their firmware themselves."}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_12d8d0ec","line":21,"range":{"start_line":21,"start_character":10,"end_line":21,"end_character":24},"in_reply_to":"3f4b6375_ba58d989","updated":"2017-11-03 05:00:10.000000000","message":"Done","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c1c7e0641e14abb2e9785128cba0af506f3687d1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Moreover, currently the support is limited to boot from an iSCSI volume"},{"line_number":22,"context_line":"with using bootloaders like iPXE but it still doesn\u0027t provide any way to"},{"line_number":23,"context_line":"harness the feature of some servers which inherently supports booting from"},{"line_number":24,"context_line":"an iSCSI volume in their firmware themselves."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Hardware can also be configured programmatically to boot from an iSCSI volume"},{"line_number":27,"context_line":"(without using bootloaders like iPXE) via the firmware. HPE ProLiant Gen9"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_1a492db6","line":24,"range":{"start_line":24,"start_character":16,"end_line":24,"end_character":44},"updated":"2017-11-02 06:22:05.000000000","message":"s/ \u0027in their firmware themselves\u0027 / \u0027using their firmware capabilities.\u0027 /","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7a7fb42172ffbd34cbed0a892ea13e513f71d71f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Moreover, currently the support is limited to boot from an iSCSI volume"},{"line_number":22,"context_line":"with using bootloaders like iPXE but it still doesn\u0027t provide any way to"},{"line_number":23,"context_line":"harness the feature of some servers which inherently supports booting from"},{"line_number":24,"context_line":"an iSCSI volume in their firmware themselves."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Hardware can also be configured programmatically to boot from an iSCSI volume"},{"line_number":27,"context_line":"(without using bootloaders like iPXE) via the firmware. HPE ProLiant Gen9"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_f2e09499","line":24,"range":{"start_line":24,"start_character":16,"end_line":24,"end_character":44},"in_reply_to":"3f4b6375_1a492db6","updated":"2017-11-03 05:00:10.000000000","message":"Done","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c1c7e0641e14abb2e9785128cba0af506f3687d1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"an iSCSI volume in their firmware themselves."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Hardware can also be configured programmatically to boot from an iSCSI volume"},{"line_number":27,"context_line":"(without using bootloaders like iPXE) via the firmware. HPE ProLiant Gen9"},{"line_number":28,"context_line":"hardware (having HPE ProLiant Gen9 System ROM P89 release version 1.40"},{"line_number":29,"context_line":"or higher) supports such a booting option from an iSCSI volume."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_3ae1899c","line":27,"range":{"start_line":27,"start_character":69,"end_line":27,"end_character":73},"updated":"2017-11-02 06:22:05.000000000","message":"and Gen10 (based on iLO5) as well.","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7a7fb42172ffbd34cbed0a892ea13e513f71d71f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"an iSCSI volume in their firmware themselves."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Hardware can also be configured programmatically to boot from an iSCSI volume"},{"line_number":27,"context_line":"(without using bootloaders like iPXE) via the firmware. HPE ProLiant Gen9"},{"line_number":28,"context_line":"hardware (having HPE ProLiant Gen9 System ROM P89 release version 1.40"},{"line_number":29,"context_line":"or higher) supports such a booting option from an iSCSI volume."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_d2dd98dd","line":27,"range":{"start_line":27,"start_character":69,"end_line":27,"end_character":73},"in_reply_to":"3f4b6375_3ae1899c","updated":"2017-11-03 05:00:10.000000000","message":"Done","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c1c7e0641e14abb2e9785128cba0af506f3687d1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"iSCSI boot capable HPE Proliant servers."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"In ``ilo-pxe`` and ``ilo-virtual-media`` boot interface, ``prepare_instance()``"},{"line_number":44,"context_line":"will check whether volume is provisioned with the user image to boot from"},{"line_number":45,"context_line":"or not, if provisioned then it set the iSCSI target if requested boot"},{"line_number":46,"context_line":"mode is \u0027UEFI\u0027, in case of \u0027BIOS\u0027 ``ilo-pxe`` boot interface will let iPXE to"},{"line_number":47,"context_line":"boot the volume and ``ilo-virtual-media`` boot interface will throw error"},{"line_number":48,"context_line":"``virtual media can\u0027t boot volume in bios mode.``"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_da9a7512","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":7},"updated":"2017-11-02 06:22:05.000000000","message":"Do you mean the given volume is a bootable or not?","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7a7fb42172ffbd34cbed0a892ea13e513f71d71f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"iSCSI boot capable HPE Proliant servers."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"In ``ilo-pxe`` and ``ilo-virtual-media`` boot interface, ``prepare_instance()``"},{"line_number":44,"context_line":"will check whether volume is provisioned with the user image to boot from"},{"line_number":45,"context_line":"or not, if provisioned then it set the iSCSI target if requested boot"},{"line_number":46,"context_line":"mode is \u0027UEFI\u0027, in case of \u0027BIOS\u0027 ``ilo-pxe`` boot interface will let iPXE to"},{"line_number":47,"context_line":"boot the volume and ``ilo-virtual-media`` boot interface will throw error"},{"line_number":48,"context_line":"``virtual media can\u0027t boot volume in bios mode.``"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_b22b3ce9","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":7},"in_reply_to":"3f4b6375_da9a7512","updated":"2017-11-03 05:00:10.000000000","message":"Done","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c1c7e0641e14abb2e9785128cba0af506f3687d1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"will check whether volume is provisioned with the user image to boot from"},{"line_number":45,"context_line":"or not, if provisioned then it set the iSCSI target if requested boot"},{"line_number":46,"context_line":"mode is \u0027UEFI\u0027, in case of \u0027BIOS\u0027 ``ilo-pxe`` boot interface will let iPXE to"},{"line_number":47,"context_line":"boot the volume and ``ilo-virtual-media`` boot interface will throw error"},{"line_number":48,"context_line":"``virtual media can\u0027t boot volume in bios mode.``"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  The function definition for ``ilo-pxe`` boot interface with its pseudo-code"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_bab45983","line":47,"range":{"start_line":47,"start_character":68,"end_line":47,"end_character":73},"updated":"2017-11-02 06:22:05.000000000","message":"nit: s/ error / an error/","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7a7fb42172ffbd34cbed0a892ea13e513f71d71f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"will check whether volume is provisioned with the user image to boot from"},{"line_number":45,"context_line":"or not, if provisioned then it set the iSCSI target if requested boot"},{"line_number":46,"context_line":"mode is \u0027UEFI\u0027, in case of \u0027BIOS\u0027 ``ilo-pxe`` boot interface will let iPXE to"},{"line_number":47,"context_line":"boot the volume and ``ilo-virtual-media`` boot interface will throw error"},{"line_number":48,"context_line":"``virtual media can\u0027t boot volume in bios mode.``"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  The function definition for ``ilo-pxe`` boot interface with its pseudo-code"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_123c502d","line":47,"range":{"start_line":47,"start_character":68,"end_line":47,"end_character":73},"in_reply_to":"3f4b6375_bab45983","updated":"2017-11-03 05:00:10.000000000","message":"Done","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c1c7e0641e14abb2e9785128cba0af506f3687d1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"or not, if provisioned then it set the iSCSI target if requested boot"},{"line_number":46,"context_line":"mode is \u0027UEFI\u0027, in case of \u0027BIOS\u0027 ``ilo-pxe`` boot interface will let iPXE to"},{"line_number":47,"context_line":"boot the volume and ``ilo-virtual-media`` boot interface will throw error"},{"line_number":48,"context_line":"``virtual media can\u0027t boot volume in bios mode.``"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  The function definition for ``ilo-pxe`` boot interface with its pseudo-code"},{"line_number":51,"context_line":"  will be as follows:"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_1aa5ad47","line":48,"range":{"start_line":48,"start_character":37,"end_line":48,"end_character":46},"updated":"2017-11-02 06:22:05.000000000","message":"s/ bios mode / ``bios`` boot mode /","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7a7fb42172ffbd34cbed0a892ea13e513f71d71f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"or not, if provisioned then it set the iSCSI target if requested boot"},{"line_number":46,"context_line":"mode is \u0027UEFI\u0027, in case of \u0027BIOS\u0027 ``ilo-pxe`` boot interface will let iPXE to"},{"line_number":47,"context_line":"boot the volume and ``ilo-virtual-media`` boot interface will throw error"},{"line_number":48,"context_line":"``virtual media can\u0027t boot volume in bios mode.``"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  The function definition for ``ilo-pxe`` boot interface with its pseudo-code"},{"line_number":51,"context_line":"  will be as follows:"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_d24118a8","line":48,"range":{"start_line":48,"start_character":37,"end_line":48,"end_character":46},"in_reply_to":"3f4b6375_1aa5ad47","updated":"2017-11-03 05:00:10.000000000","message":"Done","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c1c7e0641e14abb2e9785128cba0af506f3687d1","unresolved":false,"context_lines":[{"line_number":104,"context_line":"          #Call the management interface"},{"line_number":105,"context_line":"          task.driver.management.clear_iscsi_boot_target(task)"},{"line_number":106,"context_line":"          #Set boot device to \u0027ISCSIBOOT\u0027"},{"line_number":107,"context_line":"          deploy_utils.try_set_boot_device(task, boot_devices.ISCSIBOOT)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        elif deploy_utils.is_iscsi_boot(task) and boot_mode \u003d\u003d \u0027bios\u0027:"},{"line_number":110,"context_line":"          #Throw the error in bios boot mode"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_1a280d95","line":107,"range":{"start_line":107,"start_character":10,"end_line":107,"end_character":72},"updated":"2017-11-02 06:22:05.000000000","message":"May be \u0027return\u0027 after this step.","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7a7fb42172ffbd34cbed0a892ea13e513f71d71f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"          #Call the management interface"},{"line_number":105,"context_line":"          task.driver.management.clear_iscsi_boot_target(task)"},{"line_number":106,"context_line":"          #Set boot device to \u0027ISCSIBOOT\u0027"},{"line_number":107,"context_line":"          deploy_utils.try_set_boot_device(task, boot_devices.ISCSIBOOT)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        elif deploy_utils.is_iscsi_boot(task) and boot_mode \u003d\u003d \u0027bios\u0027:"},{"line_number":110,"context_line":"          #Throw the error in bios boot mode"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_32286ce0","line":107,"range":{"start_line":107,"start_character":10,"end_line":107,"end_character":72},"in_reply_to":"3f4b6375_1a280d95","updated":"2017-11-03 05:00:10.000000000","message":"Done","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c1c7e0641e14abb2e9785128cba0af506f3687d1","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        if deploy_utils.is_iscsi_boot(task) and boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":125,"context_line":"          #Call the management interface"},{"line_number":126,"context_line":"          task.driver.management.clear_iscsi_boot_target(task)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"In iLO management there will be two new interfaces ``set_iscsi_boot_target`` and"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_dd2dcf95","line":126,"range":{"start_line":126,"start_character":10,"end_line":126,"end_character":62},"updated":"2017-11-02 06:22:05.000000000","message":"\u0027else\u0027 fall to current code of vmedia clean up.","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7a7fb42172ffbd34cbed0a892ea13e513f71d71f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        if deploy_utils.is_iscsi_boot(task) and boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":125,"context_line":"          #Call the management interface"},{"line_number":126,"context_line":"          task.driver.management.clear_iscsi_boot_target(task)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"In iLO management there will be two new interfaces ``set_iscsi_boot_target`` and"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_d26fd825","line":126,"range":{"start_line":126,"start_character":10,"end_line":126,"end_character":62},"in_reply_to":"3f4b6375_dd2dcf95","updated":"2017-11-03 05:00:10.000000000","message":"Done","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c1c7e0641e14abb2e9785128cba0af506f3687d1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"          task.driver.management.clear_iscsi_boot_target(task)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"In iLO management there will be two new interfaces ``set_iscsi_boot_target`` and"},{"line_number":130,"context_line":"``clear_iscsi_boot_target`` to set and clear the iSCSI target information, it will"},{"line_number":131,"context_line":"call appropriate library."},{"line_number":132,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_3d56232c","line":129,"range":{"start_line":129,"start_character":7,"end_line":129,"end_character":17},"updated":"2017-11-02 06:22:05.000000000","message":"s/ \u0027management\u0027 / \u0027management interface ``ilo.management.IloManagement`` \u0027","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7a7fb42172ffbd34cbed0a892ea13e513f71d71f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"          task.driver.management.clear_iscsi_boot_target(task)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"In iLO management there will be two new interfaces ``set_iscsi_boot_target`` and"},{"line_number":130,"context_line":"``clear_iscsi_boot_target`` to set and clear the iSCSI target information, it will"},{"line_number":131,"context_line":"call appropriate library."},{"line_number":132,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_92ccc035","line":129,"range":{"start_line":129,"start_character":7,"end_line":129,"end_character":17},"in_reply_to":"3f4b6375_3d56232c","updated":"2017-11-03 05:00:10.000000000","message":"Done","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c1c7e0641e14abb2e9785128cba0af506f3687d1","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        :param task: a task from TaskManager."},{"line_number":143,"context_line":"        \"\"\""},{"line_number":144,"context_line":"        #Library call to set iscsi target info"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"      def clear_iscsi_boot_target(self, task):"},{"line_number":147,"context_line":"        \"\"\"Clear iscsi boot volume target info from the node."}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_fde9ab19","line":144,"range":{"start_line":144,"start_character":9,"end_line":144,"end_character":16},"updated":"2017-11-02 06:22:05.000000000","message":"Proliantutils","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7a7fb42172ffbd34cbed0a892ea13e513f71d71f","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        :param task: a task from TaskManager."},{"line_number":143,"context_line":"        \"\"\""},{"line_number":144,"context_line":"        #Library call to set iscsi target info"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"      def clear_iscsi_boot_target(self, task):"},{"line_number":147,"context_line":"        \"\"\"Clear iscsi boot volume target info from the node."}],"source_content_type":"text/x-rst","patch_set":34,"id":"3f4b6375_52d2c8d2","line":144,"range":{"start_line":144,"start_character":9,"end_line":144,"end_character":16},"in_reply_to":"3f4b6375_fde9ab19","updated":"2017-11-03 05:00:10.000000000","message":"Done","commit_id":"1b6f7d0d4b40ff7b3d37b8fefe9525c965a4b3fe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a14e259aa73dbdca7228a909f4ce5fe9b1570da2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"HPE ProLiant Servers (Gen9 and beyond) supports UEFI iSCSI Boot through its"},{"line_number":14,"context_line":"firmware. The proposed feature is to add support for this firmware based"},{"line_number":15,"context_line":"booting of an iSCSI Cinder volume in UEFI mode for Ironic iLO drivers."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":36,"id":"ff82abbf_fc1be67d","line":15,"range":{"start_line":15,"start_character":41,"end_line":15,"end_character":46},"updated":"2017-11-24 13:17:41.000000000","message":"s/ mode / boot mode /","commit_id":"0783f0581f93bede90fc4b9a696db76f2d35c3d9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5a9cbb1bf79bf1a90cd646c56b204c25ad1d98b3","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"HPE ProLiant Servers (Gen9 and beyond) supports UEFI iSCSI Boot through its"},{"line_number":14,"context_line":"firmware. The proposed feature is to add support for this firmware based"},{"line_number":15,"context_line":"booting of an iSCSI Cinder volume in UEFI mode for Ironic iLO drivers."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":36,"id":"ff82abbf_233fccb4","line":15,"range":{"start_line":15,"start_character":41,"end_line":15,"end_character":46},"in_reply_to":"ff82abbf_fc1be67d","updated":"2017-11-27 13:41:53.000000000","message":"+1","commit_id":"0783f0581f93bede90fc4b9a696db76f2d35c3d9"}],"specs/approved/uefi-iscsi-boot.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9f0027f65b3338cd9f5e698bf1d7272a21c939","unresolved":false,"context_lines":[{"line_number":35,"context_line":"This change is based on the reference driver implementation guideline as"},{"line_number":36,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":37,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":38,"context_line":"change proposes a new implementation of ``DeployInterface`` named"},{"line_number":39,"context_line":"``UefiIscsiBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":40,"context_line":"for hardware which support UEFI iSCSI Boot. The aim is to have a completely"},{"line_number":41,"context_line":"new interface based on driver composition which helps facilitate to leverage"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5ff73747_f98c9c80","line":38,"range":{"start_line":38,"start_character":40,"end_line":38,"end_character":59},"updated":"2017-10-04 07:42:15.000000000","message":"s/\u0027``DeployInterface``\u0027/ \u0027``deploy`` interface\u0027","commit_id":"ea8999357aef07886a86f6ac4becf3a38d481f7b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526861"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Servers which support UEFI iSCSI Boot in its firmware, this feature is about"},{"line_number":14,"context_line":"adding support for booting from an iSCSI Cinder volume for those servers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_5ee36806","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":27},"updated":"2017-05-15 20:36:29.000000000","message":"Stupid question: What delineates UEFI from BIOS mode boot in terms of setting the BMC to connect to remote iSCSI storage for system boot?\n\nWouldn\u0027t this just be boot mode? As such, wouldn\u0027t that also mean that this should be boot interface changes, not deploy interface changes?","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a89cd5d074bd11263ce30ed7d8bd1d9b763b884e","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526861"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Servers which support UEFI iSCSI Boot in its firmware, this feature is about"},{"line_number":14,"context_line":"adding support for booting from an iSCSI Cinder volume for those servers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_3f23da07","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":27},"in_reply_to":"1f013ff3_5ee36806","updated":"2017-05-16 17:01:26.000000000","message":"Right question. In the legacy bios mode,  it depends on the\nvarious network interfaces to implement the iSCSI boot option ROM code. In UEFI it has  device independent  support for network interfaces from multiple vendors. This feature is available for 13th generation Dell PowerEdge servers as well.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Cinder volume."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Hardware can also be configured programmatically to boot from an iSCSI volume"},{"line_number":26,"context_line":"(without using bootloaders like iPXE). For instance, HPE ProLiant Gen9 hardware"},{"line_number":27,"context_line":"(having HPE ProLiant Gen9 System ROM P89 release version 1.40 or higher)"},{"line_number":28,"context_line":"supports such a booting option from an iSCSI volume."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_5ecc8888","line":26,"updated":"2017-05-15 20:36:29.000000000","message":"It might be better to say  \"from an iSCSI volume via the firmware/lights out management.\"","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Cinder volume."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Hardware can also be configured programmatically to boot from an iSCSI volume"},{"line_number":26,"context_line":"(without using bootloaders like iPXE). For instance, HPE ProLiant Gen9 hardware"},{"line_number":27,"context_line":"(having HPE ProLiant Gen9 System ROM P89 release version 1.40 or higher)"},{"line_number":28,"context_line":"supports such a booting option from an iSCSI volume."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_b1bef162","line":26,"in_reply_to":"1f013ff3_5ecc8888","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Cinder volume."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Hardware can also be configured programmatically to boot from an iSCSI volume"},{"line_number":26,"context_line":"(without using bootloaders like iPXE). For instance, HPE ProLiant Gen9 hardware"},{"line_number":27,"context_line":"(having HPE ProLiant Gen9 System ROM P89 release version 1.40 or higher)"},{"line_number":28,"context_line":"supports such a booting option from an iSCSI volume."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_dea538b7","line":28,"range":{"start_line":26,"start_character":39,"end_line":28,"end_character":52},"updated":"2017-05-15 20:36:29.000000000","message":"nit: Stating specific hardware and and ROM versions makes this look and sound like something that is entirely a single vendor specific feature. Personally, I would prefer that this be minimized.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Cinder volume."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Hardware can also be configured programmatically to boot from an iSCSI volume"},{"line_number":26,"context_line":"(without using bootloaders like iPXE). For instance, HPE ProLiant Gen9 hardware"},{"line_number":27,"context_line":"(having HPE ProLiant Gen9 System ROM P89 release version 1.40 or higher)"},{"line_number":28,"context_line":"supports such a booting option from an iSCSI volume."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_d18dfdd3","line":28,"range":{"start_line":26,"start_character":39,"end_line":28,"end_character":52},"in_reply_to":"1f013ff3_dea538b7","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9b27c28a967a8b97a8d30fbabe8ae03d7e445511","unresolved":false,"context_lines":[{"line_number":35,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":36,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":37,"context_line":"change proposes a new implementation of deploy interface named"},{"line_number":38,"context_line":"``UEFIiSCSIBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":39,"context_line":"for hardware which support UEFI iSCSI Boot. The aim is to have a completely"},{"line_number":40,"context_line":"new interface based on driver composition which helps facilitate to leverage"},{"line_number":41,"context_line":"the remote storage as a boot volume."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_6b79bbfa","line":38,"updated":"2017-05-16 07:03:00.000000000","message":"Having \"Boot\" in a deploy interface name is a good sign that it should not be a deploy interface in the first place :)","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":36,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":37,"context_line":"change proposes a new implementation of deploy interface named"},{"line_number":38,"context_line":"``UEFIiSCSIBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":39,"context_line":"for hardware which support UEFI iSCSI Boot. The aim is to have a completely"},{"line_number":40,"context_line":"new interface based on driver composition which helps facilitate to leverage"},{"line_number":41,"context_line":"the remote storage as a boot volume."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_5e912852","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":74},"updated":"2017-05-15 20:36:29.000000000","message":"Shouldn\u0027t this be boot interface changes?","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"This change is based on the reference driver implementation guideline as"},{"line_number":35,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":36,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":37,"context_line":"change proposes a new implementation of deploy interface named"},{"line_number":38,"context_line":"``UEFIiSCSIBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":39,"context_line":"for hardware which support UEFI iSCSI Boot. The aim is to have a completely"},{"line_number":40,"context_line":"new interface based on driver composition which helps facilitate to leverage"},{"line_number":41,"context_line":"the remote storage as a boot volume."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_7e94e444","line":38,"range":{"start_line":37,"start_character":40,"end_line":38,"end_character":23},"updated":"2017-05-15 20:36:29.000000000","message":"Why is a new deploy interface required?","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":35,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":36,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":37,"context_line":"change proposes a new implementation of deploy interface named"},{"line_number":38,"context_line":"``UEFIiSCSIBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":39,"context_line":"for hardware which support UEFI iSCSI Boot. The aim is to have a completely"},{"line_number":40,"context_line":"new interface based on driver composition which helps facilitate to leverage"},{"line_number":41,"context_line":"the remote storage as a boot volume."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_046fa592","line":38,"in_reply_to":"1f013ff3_1f8f082b","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a89cd5d074bd11263ce30ed7d8bd1d9b763b884e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":36,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":37,"context_line":"change proposes a new implementation of deploy interface named"},{"line_number":38,"context_line":"``UEFIiSCSIBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":39,"context_line":"for hardware which support UEFI iSCSI Boot. The aim is to have a completely"},{"line_number":40,"context_line":"new interface based on driver composition which helps facilitate to leverage"},{"line_number":41,"context_line":"the remote storage as a boot volume."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_9f5c2e7f","line":38,"in_reply_to":"1f013ff3_1f8f082b","updated":"2017-05-16 17:01:26.000000000","message":"I agree. I feel this feature should be part of existing ilo.boot.IloPXEBoot interface wherein it can use the OOB setting of ISCSI target into the iLO when iscsi boot is requested along with UEFI boot mode. In case of BIOS it can let it fall through the iPXE mechanism of booting the volume.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b8a8978e4506b341f47de1b5f9cff05f99168aa4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":36,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":37,"context_line":"change proposes a new implementation of deploy interface named"},{"line_number":38,"context_line":"``UEFIiSCSIBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":39,"context_line":"for hardware which support UEFI iSCSI Boot. The aim is to have a completely"},{"line_number":40,"context_line":"new interface based on driver composition which helps facilitate to leverage"},{"line_number":41,"context_line":"the remote storage as a boot volume."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_1f8f082b","line":38,"in_reply_to":"1f013ff3_6b79bbfa","updated":"2017-05-16 12:18:27.000000000","message":"++\n\nPart of the reason the whole idea of capabilities was put in place so that the storage interface could sanity check if the boot interface supported iscsi boot.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":35,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":36,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":37,"context_line":"change proposes a new implementation of deploy interface named"},{"line_number":38,"context_line":"``UEFIiSCSIBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":39,"context_line":"for hardware which support UEFI iSCSI Boot. The aim is to have a completely"},{"line_number":40,"context_line":"new interface based on driver composition which helps facilitate to leverage"},{"line_number":41,"context_line":"the remote storage as a boot volume."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_645ae9f3","line":38,"in_reply_to":"1f013ff3_6b79bbfa","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":37,"context_line":"change proposes a new implementation of deploy interface named"},{"line_number":38,"context_line":"``UEFIiSCSIBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":39,"context_line":"for hardware which support UEFI iSCSI Boot. The aim is to have a completely"},{"line_number":40,"context_line":"new interface based on driver composition which helps facilitate to leverage"},{"line_number":41,"context_line":"the remote storage as a boot volume."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The new deploy interface will be implemented with the following methods:"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_1ec28034","line":41,"range":{"start_line":39,"start_character":44,"end_line":41,"end_character":36},"updated":"2017-05-15 20:36:29.000000000","message":"Why? if I as a vendor wish to support telling my hardware to connect to an iSCSI target, the users (operators) of the software must already explicitly:\n- Opt into a storage interface configuration on the node for cinder side operations\n- Provide configuration indicating that the node has a remote root volume\n- Explicitly set the capability on the node to signal that it supports iscsi boot.\n- Have placed the hardware configuration information such that the connector information can be submitted to cinder...\n\nWhy does ironic need a new deploy interface to achieve this?  Especially when that effectively locks that node to a single use case?","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":36,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":37,"context_line":"change proposes a new implementation of deploy interface named"},{"line_number":38,"context_line":"``UEFIiSCSIBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":39,"context_line":"for hardware which support UEFI iSCSI Boot. The aim is to have a completely"},{"line_number":40,"context_line":"new interface based on driver composition which helps facilitate to leverage"},{"line_number":41,"context_line":"the remote storage as a boot volume."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The new deploy interface will be implemented with the following methods:"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_e46dd998","line":41,"range":{"start_line":39,"start_character":44,"end_line":41,"end_character":36},"in_reply_to":"1f013ff3_1ec28034","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a89cd5d074bd11263ce30ed7d8bd1d9b763b884e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"``UEFIiSCSIBootDeploy`` which facilitates booting from iSCSI Cinder volume"},{"line_number":39,"context_line":"for hardware which support UEFI iSCSI Boot. The aim is to have a completely"},{"line_number":40,"context_line":"new interface based on driver composition which helps facilitate to leverage"},{"line_number":41,"context_line":"the remote storage as a boot volume."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"The new deploy interface will be implemented with the following methods:"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_7fede289","line":41,"in_reply_to":"1f013ff3_1ec28034","updated":"2017-05-16 17:01:26.000000000","message":"Yes, it should be a boot interface and can be handled through existing ilo.boot.IloPXEBoot interface","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - ``validate()`` - This will do the following:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - This will validate whether the necessary inputs for booting from iSCSI"},{"line_number":48,"context_line":"      volume are provided in node (in the place as mentioned in the"},{"line_number":49,"context_line":"      `parent spec`_). This includes target IQN, LUN number, IP address of"},{"line_number":50,"context_line":"      target, port, authentication method, username, password."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"      This information comes from the originating storage system driver in"},{"line_number":53,"context_line":"      cinder, so there can be some variation, and we can\u0027t and don\u0027t expect to"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_5e000835","line":50,"range":{"start_line":47,"start_character":0,"end_line":50,"end_character":62},"updated":"2017-05-15 20:36:29.000000000","message":"Wouldn\u0027t the storage interface do this as well?","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - ``validate()`` - This will do the following:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - This will validate whether the necessary inputs for booting from iSCSI"},{"line_number":48,"context_line":"      volume are provided in node (in the place as mentioned in the"},{"line_number":49,"context_line":"      `parent spec`_). This includes target IQN, LUN number, IP address of"},{"line_number":50,"context_line":"      target, port, authentication method, username, password."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"      This information comes from the originating storage system driver in"},{"line_number":53,"context_line":"      cinder, so there can be some variation, and we can\u0027t and don\u0027t expect to"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_840855d9","line":50,"range":{"start_line":47,"start_character":0,"end_line":50,"end_character":62},"in_reply_to":"1f013ff3_5e000835","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      volume. The logic for policy based validation of additional parameters"},{"line_number":57,"context_line":"      needs to be accommodated here."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    - Check if the attribute ``node.properties.capabilities[\u0027iscsi_boot\u0027]``"},{"line_number":60,"context_line":"      is set to ``true`` (This attribute may be populated by inspection or may"},{"line_number":61,"context_line":"      be populated manually, but it is out of scope of this spec.  More"},{"line_number":62,"context_line":"      information about this attribute is also mentioned in the"},{"line_number":63,"context_line":"      `parent spec`_)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    - If any of the validation logic in the reference driver can be reused, we"},{"line_number":66,"context_line":"      will attempt to reuse."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_9eee9086","line":63,"range":{"start_line":59,"start_character":0,"end_line":63,"end_character":22},"updated":"2017-05-15 20:36:29.000000000","message":"This seems redundant if it is a specific interface that your desiring your users to opt into.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      volume. The logic for policy based validation of additional parameters"},{"line_number":57,"context_line":"      needs to be accommodated here."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    - Check if the attribute ``node.properties.capabilities[\u0027iscsi_boot\u0027]``"},{"line_number":60,"context_line":"      is set to ``true`` (This attribute may be populated by inspection or may"},{"line_number":61,"context_line":"      be populated manually, but it is out of scope of this spec.  More"},{"line_number":62,"context_line":"      information about this attribute is also mentioned in the"},{"line_number":63,"context_line":"      `parent spec`_)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    - If any of the validation logic in the reference driver can be reused, we"},{"line_number":66,"context_line":"      will attempt to reuse."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_640f89e1","line":63,"range":{"start_line":59,"start_character":0,"end_line":63,"end_character":22},"in_reply_to":"1f013ff3_9eee9086","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"          booting the machine from remote volume is missing."},{"line_number":80,"context_line":"      \"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  - ``prepare()`` - This will do the following:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - Makes a call to management interface to set the the iSCSI target details"},{"line_number":85,"context_line":"      on the bare metal server."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - Management interface will have modules to set iSCSI target details"},{"line_number":88,"context_line":"      for each vendor\u0027s who support this feature."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_613d69ba","line":85,"range":{"start_line":82,"start_character":0,"end_line":85,"end_character":31},"updated":"2017-05-15 20:36:29.000000000","message":"Crazy idea... why don\u0027t we just define a new management interface standard and allow the existing deploy methods to tell the BMC to attach the iscsi iscsi devices?","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9b27c28a967a8b97a8d30fbabe8ae03d7e445511","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  - ``prepare()`` - This will do the following:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - Makes a call to management interface to set the the iSCSI target details"},{"line_number":85,"context_line":"      on the bare metal server."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - Management interface will have modules to set iSCSI target details"},{"line_number":88,"context_line":"      for each vendor\u0027s who support this feature."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_4b7effe4","line":85,"updated":"2017-05-16 07:03:00.000000000","message":"Why can\u0027t it be a new boot interface though? Otherwise yeah, anything is better than Yet Another deploy interface.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  - ``prepare()`` - This will do the following:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - Makes a call to management interface to set the the iSCSI target details"},{"line_number":85,"context_line":"      on the bare metal server."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - Management interface will have modules to set iSCSI target details"},{"line_number":88,"context_line":"      for each vendor\u0027s who support this feature."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_a42eb140","line":85,"in_reply_to":"1f013ff3_4b7effe4","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b8a8978e4506b341f47de1b5f9cff05f99168aa4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  - ``prepare()`` - This will do the following:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - Makes a call to management interface to set the the iSCSI target details"},{"line_number":85,"context_line":"      on the bare metal server."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - Management interface will have modules to set iSCSI target details"},{"line_number":88,"context_line":"      for each vendor\u0027s who support this feature."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_5fed90ed","line":85,"in_reply_to":"1f013ff3_4b7effe4","updated":"2017-05-16 12:18:27.000000000","message":"I guess it could be another boot interface on the profile list.  It would add some complexity, but I think it is do-able.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  - ``prepare()`` - This will do the following:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - Makes a call to management interface to set the the iSCSI target details"},{"line_number":85,"context_line":"      on the bare metal server."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - Management interface will have modules to set iSCSI target details"},{"line_number":88,"context_line":"      for each vendor\u0027s who support this feature."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_843175a5","line":85,"in_reply_to":"1f013ff3_5fed90ed","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a89cd5d074bd11263ce30ed7d8bd1d9b763b884e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  - ``prepare()`` - This will do the following:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - Makes a call to management interface to set the the iSCSI target details"},{"line_number":85,"context_line":"      on the bare metal server."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - Management interface will have modules to set iSCSI target details"},{"line_number":88,"context_line":"      for each vendor\u0027s who support this feature."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_3f84fab0","line":85,"in_reply_to":"1f013ff3_5fed90ed","updated":"2017-05-16 17:01:26.000000000","message":"Replied above. Implementing using ilo.boot.IloPXEBoot interface.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    - Makes a call to management interface to set the the iSCSI target details"},{"line_number":85,"context_line":"      on the bare metal server."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - Management interface will have modules to set iSCSI target details"},{"line_number":88,"context_line":"      for each vendor\u0027s who support this feature."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    - Probably it can also throw an ``Unsupported`` kind of exception if there"},{"line_number":91,"context_line":"      is any attempt to set the iSCSI target parameters for booting from remote"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_2132c1f2","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":49},"updated":"2017-05-15 20:36:29.000000000","message":"Awesome!","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    - Management interface will have modules to set iSCSI target details"},{"line_number":88,"context_line":"      for each vendor\u0027s who support this feature."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    - Probably it can also throw an ``Unsupported`` kind of exception if there"},{"line_number":91,"context_line":"      is any attempt to set the iSCSI target parameters for booting from remote"},{"line_number":92,"context_line":"      volume on a server."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    - Hence, ``proposed_new_driver.deploy.prepare`` method turns out to be the"},{"line_number":95,"context_line":"      major operation place for the iSCSI target booting configuration to be"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_9e4a107e","line":92,"range":{"start_line":90,"start_character":6,"end_line":92,"end_character":25},"updated":"2017-05-15 20:36:29.000000000","message":"Why would it throw an ``Unsupported`` kind of exception? When would it?","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    - Management interface will have modules to set iSCSI target details"},{"line_number":88,"context_line":"      for each vendor\u0027s who support this feature."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    - Probably it can also throw an ``Unsupported`` kind of exception if there"},{"line_number":91,"context_line":"      is any attempt to set the iSCSI target parameters for booting from remote"},{"line_number":92,"context_line":"      volume on a server."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    - Hence, ``proposed_new_driver.deploy.prepare`` method turns out to be the"},{"line_number":95,"context_line":"      major operation place for the iSCSI target booting configuration to be"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_076567e1","line":92,"range":{"start_line":90,"start_character":6,"end_line":92,"end_character":25},"in_reply_to":"1f013ff3_9e4a107e","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"      is any attempt to set the iSCSI target parameters for booting from remote"},{"line_number":92,"context_line":"      volume on a server."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    - Hence, ``proposed_new_driver.deploy.prepare`` method turns out to be the"},{"line_number":95,"context_line":"      major operation place for the iSCSI target booting configuration to be"},{"line_number":96,"context_line":"      set on the server and above bare metals."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_beb70c87","line":94,"range":{"start_line":94,"start_character":15,"end_line":94,"end_character":35},"updated":"2017-05-15 20:36:29.000000000","message":"Per the community agreement with driver composition, there will be no driver. ``task.driver.\u003cinterface\u003e.\u003cmethod\u003e`` may be what your looking for.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":91,"context_line":"      is any attempt to set the iSCSI target parameters for booting from remote"},{"line_number":92,"context_line":"      volume on a server."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    - Hence, ``proposed_new_driver.deploy.prepare`` method turns out to be the"},{"line_number":95,"context_line":"      major operation place for the iSCSI target booting configuration to be"},{"line_number":96,"context_line":"      set on the server and above bare metals."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_879e17b6","line":94,"range":{"start_line":94,"start_character":15,"end_line":94,"end_character":35},"in_reply_to":"1f013ff3_beb70c87","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    def prepare(self, task):"},{"line_number":103,"context_line":"      \"\"\"Prepare the deployment environment for this task\u0027s node."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      Sets the iSCSI target configuration on the node for PXE-booting."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      :param task: a TaskManager instance containing the node to act on."},{"line_number":108,"context_line":"      \"\"\""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_4135cdd9","line":105,"range":{"start_line":105,"start_character":58,"end_line":105,"end_character":69},"updated":"2017-05-15 20:36:29.000000000","message":"Nit: You may want to revise this to match the theme of the spec.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    def prepare(self, task):"},{"line_number":103,"context_line":"      \"\"\"Prepare the deployment environment for this task\u0027s node."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      Sets the iSCSI target configuration on the node for PXE-booting."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      :param task: a TaskManager instance containing the node to act on."},{"line_number":108,"context_line":"      \"\"\""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_07aa07d1","line":105,"range":{"start_line":105,"start_character":58,"end_line":105,"end_character":69},"in_reply_to":"1f013ff3_4135cdd9","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      # boot_devices.ISCSI maps to NETWORK(may vary depends on vendor\u0027s node)"},{"line_number":112,"context_line":"      deploy_utils.try_set_boot_device(task, boot_devices.ISCSI)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  - ``deploy()`` - Do nothing."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    - The reference driver implementation in essence immediately returns"},{"line_number":117,"context_line":"      DEPLOYDONE if node is defined to boot from a remote volume. Perhaps this"},{"line_number":118,"context_line":"      method may reuse that part as like any network booting configuration."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    - Although mostly a ``noop`` method but should initiate reboot of the node."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_813bd5cf","line":118,"range":{"start_line":114,"start_character":0,"end_line":118,"end_character":75},"updated":"2017-05-15 20:36:29.000000000","message":"Wouldn\u0027t it make more sense to use the existing stock deploy/validate code and wire in assertion/check into boot/management interfaces for power?  Since you can\u0027t/shouldn\u0027t check until before you boot?\n\nI guess, from the operational standpoint, the deployment interface does help support the workflow, but adding new alternative workflows for supporting what is effectively firmware/bmc configuration that put be asserted prior to power-up, just seems not to really make any sense.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      # boot_devices.ISCSI maps to NETWORK(may vary depends on vendor\u0027s node)"},{"line_number":112,"context_line":"      deploy_utils.try_set_boot_device(task, boot_devices.ISCSI)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  - ``deploy()`` - Do nothing."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    - The reference driver implementation in essence immediately returns"},{"line_number":117,"context_line":"      DEPLOYDONE if node is defined to boot from a remote volume. Perhaps this"},{"line_number":118,"context_line":"      method may reuse that part as like any network booting configuration."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    - Although mostly a ``noop`` method but should initiate reboot of the node."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_c7b3ff4c","line":118,"range":{"start_line":114,"start_character":0,"end_line":118,"end_character":75},"in_reply_to":"1f013ff3_813bd5cf","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":245,"context_line":"Other end user impact"},{"line_number":246,"context_line":"---------------------"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Users can request for a bare metal to be booted from an iSCSI Cinder volume"},{"line_number":249,"context_line":"and Ironic can fulfill the request with for servers which support UEFI iSCSI"},{"line_number":250,"context_line":"Boot."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"Scalability impact"},{"line_number":253,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_0160e5a4","line":250,"range":{"start_line":248,"start_character":0,"end_line":250,"end_character":5},"updated":"2017-05-15 20:36:29.000000000","message":"Nit: This seems like a redundant statement.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":245,"context_line":"Other end user impact"},{"line_number":246,"context_line":"---------------------"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Users can request for a bare metal to be booted from an iSCSI Cinder volume"},{"line_number":249,"context_line":"and Ironic can fulfill the request with for servers which support UEFI iSCSI"},{"line_number":250,"context_line":"Boot."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"Scalability impact"},{"line_number":253,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_c7e1bf2c","line":250,"range":{"start_line":248,"start_character":0,"end_line":250,"end_character":5},"in_reply_to":"1f013ff3_0160e5a4","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":323,"context_line":"Testing"},{"line_number":324,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"There is a plan to come up with a base gate test, orchestrated by a tempest"},{"line_number":327,"context_line":"test case, to functionally test the base boot from Cinder volume functionality."},{"line_number":328,"context_line":"Based on the same lines, a third part CI test job imitating the base version"},{"line_number":329,"context_line":"will be added to test this feature for servers which support UEFI iSCSI Boot."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_010585c2","line":326,"range":{"start_line":326,"start_character":0,"end_line":326,"end_character":48},"updated":"2017-05-15 20:36:29.000000000","message":"Please detail the plan here.","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":323,"context_line":"Testing"},{"line_number":324,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"There is a plan to come up with a base gate test, orchestrated by a tempest"},{"line_number":327,"context_line":"test case, to functionally test the base boot from Cinder volume functionality."},{"line_number":328,"context_line":"Based on the same lines, a third part CI test job imitating the base version"},{"line_number":329,"context_line":"will be added to test this feature for servers which support UEFI iSCSI Boot."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_472b6f2f","line":326,"range":{"start_line":326,"start_character":0,"end_line":326,"end_character":48},"in_reply_to":"1f013ff3_010585c2","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c7ef55b103cc877c3bfa0f6617b01cbe6995ddc3","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"There is a plan to come up with a base gate test, orchestrated by a tempest"},{"line_number":327,"context_line":"test case, to functionally test the base boot from Cinder volume functionality."},{"line_number":328,"context_line":"Based on the same lines, a third part CI test job imitating the base version"},{"line_number":329,"context_line":"will be added to test this feature for servers which support UEFI iSCSI Boot."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"Upgrades and Backwards Compatibility"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_c10e7de4","line":328,"range":{"start_line":328,"start_character":50,"end_line":328,"end_character":59},"updated":"2017-05-15 20:36:29.000000000","message":"s/imiting/limiting/?","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"47a2be387d644f243002f8311d42c8251b9c8342","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"There is a plan to come up with a base gate test, orchestrated by a tempest"},{"line_number":327,"context_line":"test case, to functionally test the base boot from Cinder volume functionality."},{"line_number":328,"context_line":"Based on the same lines, a third part CI test job imitating the base version"},{"line_number":329,"context_line":"will be added to test this feature for servers which support UEFI iSCSI Boot."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"Upgrades and Backwards Compatibility"}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f013ff3_e79efb61","line":328,"range":{"start_line":328,"start_character":50,"end_line":328,"end_character":59},"in_reply_to":"1f013ff3_c10e7de4","updated":"2017-05-17 06:24:23.000000000","message":"Done","commit_id":"b4c50ba456b03b0c6d336bebf8f1c699fb0a3475"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"244b840a0e3ff6ce94f091f2e2aeea719a2cdd98","unresolved":false,"context_lines":[{"line_number":32,"context_line":"This change is based on the reference driver implementation guideline as"},{"line_number":33,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":34,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":35,"context_line":"change uses pxe boot interface for UEFI iSCSI Boot."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"In prepare ramdisk and prepare instance of vendor pxe boot, it will call"},{"line_number":38,"context_line":"management interface to set and unset iSCSI boot related stuff on the"}],"source_content_type":"text/x-rst","patch_set":23,"id":"1f013ff3_989552e7","line":35,"range":{"start_line":35,"start_character":7,"end_line":35,"end_character":30},"updated":"2017-05-17 11:22:51.000000000","message":"proposes to have a new boot interface that can be defined by the vendors which would be based on ``PXEBoot`` interface","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d495d0430e71bb2eaad214e54fd18f13d741e20","unresolved":false,"context_lines":[{"line_number":32,"context_line":"This change is based on the reference driver implementation guideline as"},{"line_number":33,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":34,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":35,"context_line":"change uses pxe boot interface for UEFI iSCSI Boot."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"In prepare ramdisk and prepare instance of vendor pxe boot, it will call"},{"line_number":38,"context_line":"management interface to set and unset iSCSI boot related stuff on the"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_5a503533","line":35,"range":{"start_line":35,"start_character":7,"end_line":35,"end_character":30},"in_reply_to":"1f013ff3_989552e7","updated":"2017-05-18 07:41:27.000000000","message":"Done","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"244b840a0e3ff6ce94f091f2e2aeea719a2cdd98","unresolved":false,"context_lines":[{"line_number":34,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":35,"context_line":"change uses pxe boot interface for UEFI iSCSI Boot."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"In prepare ramdisk and prepare instance of vendor pxe boot, it will call"},{"line_number":38,"context_line":"management interface to set and unset iSCSI boot related stuff on the"},{"line_number":39,"context_line":"hardware using appropriate library calls."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"1f013ff3_9863121b","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":59},"updated":"2017-05-17 11:22:51.000000000","message":"In ``prepare_ramdisk`` and ``prepare_instance`` methods of vendor boot interface defined based on ``PXEBoot``,","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d495d0430e71bb2eaad214e54fd18f13d741e20","unresolved":false,"context_lines":[{"line_number":34,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":35,"context_line":"change uses pxe boot interface for UEFI iSCSI Boot."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"In prepare ramdisk and prepare instance of vendor pxe boot, it will call"},{"line_number":38,"context_line":"management interface to set and unset iSCSI boot related stuff on the"},{"line_number":39,"context_line":"hardware using appropriate library calls."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_7a19b986","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":59},"in_reply_to":"1f013ff3_9863121b","updated":"2017-05-18 07:41:27.000000000","message":"Done","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"244b840a0e3ff6ce94f091f2e2aeea719a2cdd98","unresolved":false,"context_lines":[{"line_number":35,"context_line":"change uses pxe boot interface for UEFI iSCSI Boot."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"In prepare ramdisk and prepare instance of vendor pxe boot, it will call"},{"line_number":38,"context_line":"management interface to set and unset iSCSI boot related stuff on the"},{"line_number":39,"context_line":"hardware using appropriate library calls."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true and boot mode"}],"source_content_type":"text/x-rst","patch_set":23,"id":"1f013ff3_38499e8a","line":38,"range":{"start_line":38,"start_character":28,"end_line":38,"end_character":37},"updated":"2017-05-17 11:22:51.000000000","message":"No un-setting of iSCSI parameters in prepare_* methods.\ns/ \u0027and unset\u0027 //g","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d495d0430e71bb2eaad214e54fd18f13d741e20","unresolved":false,"context_lines":[{"line_number":35,"context_line":"change uses pxe boot interface for UEFI iSCSI Boot."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"In prepare ramdisk and prepare instance of vendor pxe boot, it will call"},{"line_number":38,"context_line":"management interface to set and unset iSCSI boot related stuff on the"},{"line_number":39,"context_line":"hardware using appropriate library calls."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true and boot mode"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_5d2caf98","line":38,"range":{"start_line":38,"start_character":28,"end_line":38,"end_character":37},"in_reply_to":"1f013ff3_38499e8a","updated":"2017-05-18 07:41:27.000000000","message":"Done","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"244b840a0e3ff6ce94f091f2e2aeea719a2cdd98","unresolved":false,"context_lines":[{"line_number":38,"context_line":"management interface to set and unset iSCSI boot related stuff on the"},{"line_number":39,"context_line":"hardware using appropriate library calls."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true and boot mode"},{"line_number":42,"context_line":"    is set to ``uefi``."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  - If check is satisfied it will call the management interface to set iSCSI"},{"line_number":45,"context_line":"    target details."}],"source_content_type":"text/x-rst","patch_set":23,"id":"1f013ff3_732bc981","line":42,"range":{"start_line":41,"start_character":4,"end_line":42,"end_character":23},"updated":"2017-05-17 11:22:51.000000000","message":"Need to check if iscsi_boot being requested using node capabilities. This will work only for iSCSI boot.","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d495d0430e71bb2eaad214e54fd18f13d741e20","unresolved":false,"context_lines":[{"line_number":38,"context_line":"management interface to set and unset iSCSI boot related stuff on the"},{"line_number":39,"context_line":"hardware using appropriate library calls."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true and boot mode"},{"line_number":42,"context_line":"    is set to ``uefi``."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  - If check is satisfied it will call the management interface to set iSCSI"},{"line_number":45,"context_line":"    target details."}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_bd34ebdf","line":42,"range":{"start_line":41,"start_character":4,"end_line":42,"end_character":23},"in_reply_to":"1f013ff3_732bc981","updated":"2017-05-18 07:41:27.000000000","message":"Done","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"244b840a0e3ff6ce94f091f2e2aeea719a2cdd98","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  - It will also set appropriate boot device for UEFI iSCSI boot, based on"},{"line_number":48,"context_line":"    vendors specification."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - In clean up phase it will call the management interface to unset iSCSI"},{"line_number":51,"context_line":"    target details."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_5a2cb598","line":50,"range":{"start_line":50,"start_character":7,"end_line":50,"end_character":21},"updated":"2017-05-17 11:22:51.000000000","message":"s/ \u0027clean up phase\u0027 / \u0027``clean_up`` method\u0027","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d495d0430e71bb2eaad214e54fd18f13d741e20","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  - It will also set appropriate boot device for UEFI iSCSI boot, based on"},{"line_number":48,"context_line":"    vendors specification."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  - In clean up phase it will call the management interface to unset iSCSI"},{"line_number":51,"context_line":"    target details."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_5dedcf23","line":50,"range":{"start_line":50,"start_character":7,"end_line":50,"end_character":21},"in_reply_to":"ff0f0b1f_5a2cb598","updated":"2017-05-18 07:41:27.000000000","message":"Done","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"244b840a0e3ff6ce94f091f2e2aeea719a2cdd98","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  .. code-block:: python"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      # Check for boot from volume and boot mode"},{"line_number":61,"context_line":"      if task.node.driver_internal_info.get(\u0027boot_from_volume\u0027) and"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_9a9a4d6c","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":52},"updated":"2017-05-17 11:22:51.000000000","message":"May be this code should look like: \n\nclass VendorPXEBoot(pxe.PXEBoot):\n\n    def prepare_ramdisk(self, task, ramdisk_params):\n        super(VendorPXEBoot, self).prepare_ramdisk(task, ramdisk_params) \n        capabilities \u003d deploy_utils.parse_instance_info_capabilities(node)\n        iscsi_boot \u003d capabilities.get(\u0027iscsi_boot\u0027, \u0027false\u0027).lower()\n        if (( iscsi_boot \u003d\u003d \u0027true\u0027 ) and\n            ( task.node.driver_internal_info.get(\u0027boot_from_volume\u0027) and\n            (deploy_utils.get_boot_mode_for_deploy(node) \u003d\u003d \u0027uefi\u0027):\n           task.driver.management.set_iscsi_boot_target(task)\n           deploy_utils.try_set_boot_device(task, boot_devices.ISCSI)","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d495d0430e71bb2eaad214e54fd18f13d741e20","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  .. code-block:: python"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      # Check for boot from volume and boot mode"},{"line_number":61,"context_line":"      if task.node.driver_internal_info.get(\u0027boot_from_volume\u0027) and"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_36c69c69","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":52},"in_reply_to":"ff0f0b1f_169b98c9","updated":"2017-05-18 07:41:27.000000000","message":"Done","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d495d0430e71bb2eaad214e54fd18f13d741e20","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  .. code-block:: python"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      # Check for boot from volume and boot mode"},{"line_number":61,"context_line":"      if task.node.driver_internal_info.get(\u0027boot_from_volume\u0027) and"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_bdaaab16","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":52},"in_reply_to":"ff0f0b1f_9a9a4d6c","updated":"2017-05-18 07:41:27.000000000","message":"Done","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"214b8349b461548f2a81d18b638171782fbe1a88","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  .. code-block:: python"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      # Check for boot from volume and boot mode"},{"line_number":61,"context_line":"      if task.node.driver_internal_info.get(\u0027boot_from_volume\u0027) and"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_169b98c9","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":52},"in_reply_to":"ff0f0b1f_9a9a4d6c","updated":"2017-05-18 06:51:05.000000000","message":"I think this one needs little bit change as below :-\nclass VendorPXEBoot(pxe.PXEBoot):\n    def prepare_ramdisk(self, task, ramdisk_params):\n\n        capabilities \u003d deploy_utils.parse_instance_info_capabilities(node)\n        iscsi_boot \u003d capabilities.get(\u0027iscsi_boot\u0027, \u0027false\u0027).lower()\n\n        if (( iscsi_boot \u003d\u003d \u0027true\u0027 ) and\n            ( task.node.driver_internal_info.get(\u0027boot_from_volume\u0027) and\n            (deploy_utils.get_boot_mode_for_deploy(node) \u003d\u003d \u0027uefi\u0027):\n\n            if not task.driver.storage.should_write_image(task):\n                return\n            else:\n                # Image needs to be provisioned on the volume, let ipxe does it\n                super(VendorPXEBoot, self).prepare_ramdisk(task, ramdisk_params)","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"214b8349b461548f2a81d18b638171782fbe1a88","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      # boot_devices.ISCSI maps to NETWORK(may vary depends on vendor\u0027s node)"},{"line_number":67,"context_line":"      deploy_utils.try_set_boot_device(task, boot_devices.ISCSI)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def prepare_instance(self, task):"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"      # Check for boot from volume and boot mode"},{"line_number":72,"context_line":"      if task.node.driver_internal_info.get(\u0027boot_from_volume\u0027) and"},{"line_number":73,"context_line":"        deploy_utils.get_boot_mode_for_deploy(node) \u003d\u003d \u0027uefi\u0027:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        task.driver.management.set_iscsi_boot_target(task)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"      # boot_devices.ISCSI maps to NETWORK(may vary depends on vendor\u0027s node)"},{"line_number":78,"context_line":"      deploy_utils.try_set_boot_device(task, boot_devices.ISCSI)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def clean_up(self, task):"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_9669e8bf","line":78,"range":{"start_line":69,"start_character":3,"end_line":78,"end_character":64},"updated":"2017-05-18 06:51:05.000000000","message":"Need to fallback to PXE implementation incase of non-iscsi and non-uefi def prepare_instance(self, task):\n    # Check for boot from volume and boot mode\n    capabilities \u003d deploy_utils.parse_instance_info_capabilities(node)\n    iscsi_boot \u003d capabilities.get(\u0027iscsi_boot\u0027, \u0027false\u0027).lower()\n    if ((iscsi_boot \u003d\u003d \u0027true\u0027 ) and\n        (task.node.driver_internal_info.get(\u0027boot_from_volume\u0027)) and\n        (deploy_utils.get_boot_mode_for_deploy(node) \u003d\u003d \u0027uefi\u0027)):\n        task.driver.management.set_iscsi_boot_target(task)\n        # boot_devices.ISCSI maps to NETWORK(may vary depends on vendor\u0027s node)\n        deploy_utils.try_set_boot_device(task, boot_devices.ISCSI)\n    else:\n        # Let ipxe handle it\n        super(VendorPXEBoot, self).prepare_instance(task)","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d495d0430e71bb2eaad214e54fd18f13d741e20","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      # boot_devices.ISCSI maps to NETWORK(may vary depends on vendor\u0027s node)"},{"line_number":67,"context_line":"      deploy_utils.try_set_boot_device(task, boot_devices.ISCSI)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def prepare_instance(self, task):"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"      # Check for boot from volume and boot mode"},{"line_number":72,"context_line":"      if task.node.driver_internal_info.get(\u0027boot_from_volume\u0027) and"},{"line_number":73,"context_line":"        deploy_utils.get_boot_mode_for_deploy(node) \u003d\u003d \u0027uefi\u0027:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        task.driver.management.set_iscsi_boot_target(task)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"      # boot_devices.ISCSI maps to NETWORK(may vary depends on vendor\u0027s node)"},{"line_number":78,"context_line":"      deploy_utils.try_set_boot_device(task, boot_devices.ISCSI)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def clean_up(self, task):"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_f9881772","line":78,"range":{"start_line":69,"start_character":3,"end_line":78,"end_character":64},"in_reply_to":"ff0f0b1f_9669e8bf","updated":"2017-05-18 07:41:27.000000000","message":"Done","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"244b840a0e3ff6ce94f091f2e2aeea719a2cdd98","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  .. code-block:: python"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def set_iscsi_boot_target(self, task):"},{"line_number":102,"context_line":"      \"\"\"Set iscsi boot volume target info into the node."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"      :param task: a task from TaskManager."}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_3a0d8190","line":101,"range":{"start_line":101,"start_character":4,"end_line":101,"end_character":42},"updated":"2017-05-17 11:22:51.000000000","message":"These methods needs to be defined in base.py:ManagementInterface() and should raise UnsupportedDriverExtension.\nThese methods needs to be defined by vendors in their \u0027Management\u0027 interface class with appropriate definition.","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d495d0430e71bb2eaad214e54fd18f13d741e20","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  .. code-block:: python"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def set_iscsi_boot_target(self, task):"},{"line_number":102,"context_line":"      \"\"\"Set iscsi boot volume target info into the node."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"      :param task: a task from TaskManager."}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff0f0b1f_5d670f27","line":101,"range":{"start_line":101,"start_character":4,"end_line":101,"end_character":42},"in_reply_to":"ff0f0b1f_3a0d8190","updated":"2017-05-18 07:41:27.000000000","message":"Done","commit_id":"2818e52d7da87b3374a6f42364fe6d9561dd19ea"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526861"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Servers which support UEFI iSCSI Boot in its firmware, this feature is about"},{"line_number":14,"context_line":"adding support for booting from an iSCSI Cinder volume for those servers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_f5d6cb4f","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":73},"updated":"2017-06-12 13:22:41.000000000","message":"Following up from my prior stupid question noticeable in https://review.openstack.org/#/c/207337/22..25/specs/approved/uefi-iscsi-boot.rst\n\nWhat prevents a vendor driver from supporting both possibilities potentially?  Ideally, wouldn\u0027t it be their boot interface validate methods that should raise an exception if an invalid configuration is requested or configured for the server?","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"66aa12741d65da345def245dc3a2693c89c9db0e","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526861"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Servers which support UEFI iSCSI Boot in its firmware, this feature is about"},{"line_number":14,"context_line":"adding support for booting from an iSCSI Cinder volume for those servers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":25,"id":"3f1d235d_db2c44ae","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":73},"in_reply_to":"7f231b9d_e831340d","updated":"2017-07-07 16:41:50.000000000","message":"I understand the difference. My question was more to inquire why the two features cannot be de-coupled, as purely the new feature is booting from iscsi.  But at the same time, this specification is joining the two distinct features together as a singular goal or feature. With both in generic drivers, this becomes a matter of achieving feature parity for individual drivers.\n\nIf a user is requesting iscsi boot, The driver can take the appropriate action in the driver\u0027s boot interface.  The same is also true for secure boot. The validate interface should error if the user requests an known unsupported configuration.\n\nI feel like this is an attempt to join the two features, when truly there are two separate things that we\u0027ve defined in the generic drivers.\n\nTruthfully, I see no need to change the conductor or management driver interfaces because we have a prepare_instance method on the boot interface. That method can independently perform items 1 through 4 on your summary, and step 5 is realistically if the boot interface placed the proper configuration, a result of a power state change.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526861"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Servers which support UEFI iSCSI Boot in its firmware, this feature is about"},{"line_number":14,"context_line":"adding support for booting from an iSCSI Cinder volume for those servers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_e831340d","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":73},"in_reply_to":"7f231b9d_f5d6cb4f","updated":"2017-06-13 06:54:12.000000000","message":"Yes this would be change in boot interface. The difference betweeen BIOS and UEFI iscsi boot is:-\n1. In case of BIOS - We would need to use external bootloader like ipxe to perform boot from iscsi volume\n2. In case of newer platforms like Proliant and PowerEdge one can set the iscsi volume target within BMC. BMC offers this iscsi volume as one of the boot device. Once boot device is set to the UEFI iscsi target, no external bootloader is required to boot from configured iscsi volume.\nTo summarize for UEFI ISCSI boot using BMC iscsi boot fetaure:\n1. Retrieve ISCSI initiator information from BMC\n2. Populate that information in Ironic volume connectors \n3. Set the ISCSI volume target onto BMC\n4. Set boot device of the node to \u0027UEFI ISCSi Target\u0027\n5. Power on the node to boot from the configured iscsi volume.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":34,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":35,"context_line":"change proposes to have a new boot interface that can be defined by the vendors"},{"line_number":36,"context_line":"which would be based on ``PXEBoot`` interface for UEFI iSCSI Boot."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In ``prepare_ramdisk`` method of vendor boot interface defined based on"},{"line_number":39,"context_line":"``PXEBoot``, it will check whether volume is provisioned or not, if not then"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_d5598ffe","line":36,"range":{"start_line":36,"start_character":12,"end_line":36,"end_character":35},"updated":"2017-06-12 13:22:41.000000000","message":"Would this be based on in code, or concept?","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":34,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":35,"context_line":"change proposes to have a new boot interface that can be defined by the vendors"},{"line_number":36,"context_line":"which would be based on ``PXEBoot`` interface for UEFI iSCSI Boot."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In ``prepare_ramdisk`` method of vendor boot interface defined based on"},{"line_number":39,"context_line":"``PXEBoot``, it will check whether volume is provisioned or not, if not then"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_fbb3404c","line":36,"range":{"start_line":36,"start_character":12,"end_line":36,"end_character":35},"in_reply_to":"7f231b9d_d5598ffe","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"which would be based on ``PXEBoot`` interface for UEFI iSCSI Boot."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In ``prepare_ramdisk`` method of vendor boot interface defined based on"},{"line_number":39,"context_line":"``PXEBoot``, it will check whether volume is provisioned or not, if not then"},{"line_number":40,"context_line":"it will let ipxe to provision it."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true, boot mode"},{"line_number":43,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_f5324ba7","line":40,"range":{"start_line":39,"start_character":63,"end_line":40,"end_character":33},"updated":"2017-06-12 13:22:41.000000000","message":"This statement is incorrect. iPXE will not provision a volume, it will attach and trigger boot of a volume as if it is a local hard drive.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"which would be based on ``PXEBoot`` interface for UEFI iSCSI Boot."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In ``prepare_ramdisk`` method of vendor boot interface defined based on"},{"line_number":39,"context_line":"``PXEBoot``, it will check whether volume is provisioned or not, if not then"},{"line_number":40,"context_line":"it will let ipxe to provision it."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true, boot mode"},{"line_number":43,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_1b927c9f","line":40,"range":{"start_line":39,"start_character":63,"end_line":40,"end_character":33},"in_reply_to":"7f231b9d_f5324ba7","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"``PXEBoot``, it will check whether volume is provisioned or not, if not then"},{"line_number":40,"context_line":"it will let ipxe to provision it."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true, boot mode"},{"line_number":43,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_15a147aa","line":42,"range":{"start_line":42,"start_character":59,"end_line":42,"end_character":63},"updated":"2017-06-12 13:22:41.000000000","message":"If my memory serves, presently if defined, it should be true, and if memory serves will contain the id of the volume.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"``PXEBoot``, it will check whether volume is provisioned or not, if not then"},{"line_number":40,"context_line":"it will let ipxe to provision it."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true, boot mode"},{"line_number":43,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_d5b50ff0","line":42,"range":{"start_line":42,"start_character":22,"end_line":42,"end_character":27},"updated":"2017-06-12 13:22:41.000000000","message":"driver internal info","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"``PXEBoot``, it will check whether volume is provisioned or not, if not then"},{"line_number":40,"context_line":"it will let ipxe to provision it."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true, boot mode"},{"line_number":43,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_1bc03c7b","line":42,"range":{"start_line":42,"start_character":59,"end_line":42,"end_character":63},"in_reply_to":"7f231b9d_15a147aa","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"``PXEBoot``, it will check whether volume is provisioned or not, if not then"},{"line_number":40,"context_line":"it will let ipxe to provision it."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true, boot mode"},{"line_number":43,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_fbba2008","line":42,"range":{"start_line":42,"start_character":22,"end_line":42,"end_character":27},"in_reply_to":"7f231b9d_d5b50ff0","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true, boot mode"},{"line_number":43,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"},{"line_number":46,"context_line":"    not, if not fallback to ipxe, to provision it."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  The function definition with its pseudo-code will be as follows:"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_158f0724","line":46,"range":{"start_line":45,"start_character":4,"end_line":46,"end_character":7},"updated":"2017-06-12 13:22:41.000000000","message":"Please elaborate on this a little more. How would it check if the volume is provisioned or not? You may want to explicitly refer to what check is being performed, even if you just say \"prior check\".","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"},{"line_number":46,"context_line":"    not, if not fallback to ipxe, to provision it."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  The function definition with its pseudo-code will be as follows:"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_d5986f6b","line":46,"range":{"start_line":46,"start_character":47,"end_line":46,"end_character":50},"updated":"2017-06-12 13:22:41.000000000","message":"s/it/the node/","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true, boot mode"},{"line_number":43,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"},{"line_number":46,"context_line":"    not, if not fallback to ipxe, to provision it."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  The function definition with its pseudo-code will be as follows:"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_bb3148a5","line":46,"range":{"start_line":45,"start_character":4,"end_line":46,"end_character":7},"in_reply_to":"7f231b9d_158f0724","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"},{"line_number":46,"context_line":"    not, if not fallback to ipxe, to provision it."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  The function definition with its pseudo-code will be as follows:"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_db3764b0","line":46,"range":{"start_line":46,"start_character":47,"end_line":46,"end_character":50},"in_reply_to":"7f231b9d_d5986f6b","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  The function definition with its pseudo-code will be as follows:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  .. code-block:: python"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    class VendorPXEBoot(pxe.PXEBoot):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"      def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # Check for boot from volume and boot mode"},{"line_number":58,"context_line":"        capabilities \u003d deploy_utils.parse_instance_info_capabilities(node)"},{"line_number":59,"context_line":"        iscsi_boot \u003d capabilities.get(\u0027iscsi_boot\u0027, \u0027true\u0027).lower()"},{"line_number":60,"context_line":"        if task.node.driver_internal_info.get(\u0027boot_from_volume\u0027) and"},{"line_number":61,"context_line":"          deploy_utils.get_boot_mode_for_deploy(node) \u003d\u003d \u0027uefi\u0027 and"},{"line_number":62,"context_line":"          iscsi_boot \u003d\u003d \"true\":"},{"line_number":63,"context_line":"          if not task.driver.storage.should_write_image(task):"},{"line_number":64,"context_line":"            return"},{"line_number":65,"context_line":"          else:"},{"line_number":66,"context_line":"            # Image needs to be provisioned on the volume, let ipxe does it"},{"line_number":67,"context_line":"            super(VendorPXEBoot, self).prepare_ramdisk(task, ramdisk_params)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In ``prepare_instance`` and ``clean_up`` methods of vendor boot interface"},{"line_number":70,"context_line":"defined based on ``PXEBoot``,  it will call management interface to set and"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_75cd1b5c","line":67,"range":{"start_line":51,"start_character":0,"end_line":67,"end_character":76},"updated":"2017-06-12 13:22:41.000000000","message":"I don\u0027t think we should be putting pseudo-code in vendor recommendation specification. It is up to the vendor to write the methods as they feel best suits their integration into ironic.\n\nInstead, we should be setting forth the expectations.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  The function definition with its pseudo-code will be as follows:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  .. code-block:: python"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    class VendorPXEBoot(pxe.PXEBoot):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"      def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # Check for boot from volume and boot mode"},{"line_number":58,"context_line":"        capabilities \u003d deploy_utils.parse_instance_info_capabilities(node)"},{"line_number":59,"context_line":"        iscsi_boot \u003d capabilities.get(\u0027iscsi_boot\u0027, \u0027true\u0027).lower()"},{"line_number":60,"context_line":"        if task.node.driver_internal_info.get(\u0027boot_from_volume\u0027) and"},{"line_number":61,"context_line":"          deploy_utils.get_boot_mode_for_deploy(node) \u003d\u003d \u0027uefi\u0027 and"},{"line_number":62,"context_line":"          iscsi_boot \u003d\u003d \"true\":"},{"line_number":63,"context_line":"          if not task.driver.storage.should_write_image(task):"},{"line_number":64,"context_line":"            return"},{"line_number":65,"context_line":"          else:"},{"line_number":66,"context_line":"            # Image needs to be provisioned on the volume, let ipxe does it"},{"line_number":67,"context_line":"            super(VendorPXEBoot, self).prepare_ramdisk(task, ramdisk_params)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In ``prepare_instance`` and ``clean_up`` methods of vendor boot interface"},{"line_number":70,"context_line":"defined based on ``PXEBoot``,  it will call management interface to set and"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_fb16a0f1","line":67,"range":{"start_line":51,"start_character":0,"end_line":67,"end_character":76},"in_reply_to":"7f231b9d_75cd1b5c","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"defined based on ``PXEBoot``,  it will call management interface to set and"},{"line_number":71,"context_line":"clear iSCSI boot related stuff."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true, boot mode"},{"line_number":74,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  - If check is satisfied it will call the management interface to set iSCSI"},{"line_number":77,"context_line":"    target details in."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  - It will also set appropriate boot device for UEFI iSCSI boot, based on"},{"line_number":80,"context_line":"    vendors specification."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_1595c7e4","line":77,"range":{"start_line":73,"start_character":0,"end_line":77,"end_character":22},"updated":"2017-06-12 13:22:41.000000000","message":"Wait a second.... this does not seem like it HAS to be a UEFI specific feature. Wouldn\u0027t it be better to indicate to just let the call with-in the management driver sort out if it is is data for the Option Rom or UEFI interface, instead of explicitly stating ``uefi`` as a a conditional prior to setting ISCSI specific boot parameters.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"defined based on ``PXEBoot``,  it will call management interface to set and"},{"line_number":71,"context_line":"clear iSCSI boot related stuff."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  - Check if in driver info ``boot_from_volume`` is set to true, boot mode"},{"line_number":74,"context_line":"    is set to ``uefi`` and ``iscsi_boot`` true in node capabilities."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  - If check is satisfied it will call the management interface to set iSCSI"},{"line_number":77,"context_line":"    target details in."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  - It will also set appropriate boot device for UEFI iSCSI boot, based on"},{"line_number":80,"context_line":"    vendors specification."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_fbc46061","line":77,"range":{"start_line":73,"start_character":0,"end_line":77,"end_character":22},"in_reply_to":"7f231b9d_1595c7e4","updated":"2017-06-13 06:54:12.000000000","message":"Only in UEFI mode BMC would allow to set boot option as ``UEFI target``","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  - If check is satisfied it will call the management interface to set iSCSI"},{"line_number":77,"context_line":"    target details in."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  - It will also set appropriate boot device for UEFI iSCSI boot, based on"},{"line_number":80,"context_line":"    vendors specification."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  - In ``clean_up`` method it will call the management interface to clear iSCSI"},{"line_number":83,"context_line":"    target details in."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_d07d1d6f","line":80,"range":{"start_line":79,"start_character":66,"end_line":80,"end_character":26},"updated":"2017-06-12 13:22:41.000000000","message":"Nit: if a uniform, easy to implement standard is set forth, then I don\u0027t see the need for vendors to submit specifications for reaching compatibility with-in their drivers.  However that would also mean that such a specification should set the stage for either boot mode, and it is a driver implementor\u0027s choice as to what occurs under the hood in their driver, such as if their management driver raises an exception if iscsi boot is requested in bios mode and they have no way of setting it. Hopefully that makes sense.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  - If check is satisfied it will call the management interface to set iSCSI"},{"line_number":77,"context_line":"    target details in."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  - It will also set appropriate boot device for UEFI iSCSI boot, based on"},{"line_number":80,"context_line":"    vendors specification."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  - In ``clean_up`` method it will call the management interface to clear iSCSI"},{"line_number":83,"context_line":"    target details in."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_9b844c0e","line":80,"range":{"start_line":79,"start_character":66,"end_line":80,"end_character":26},"in_reply_to":"7f231b9d_d07d1d6f","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  The function definition with its pseudo-code will be as follows:"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  .. code-block:: python"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    class VendorPXEBoot(pxe.PXEBoot):"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"      def prepare_instance(self, task):"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        # Check for boot from volume and boot mode"},{"line_number":95,"context_line":"        capabilities \u003d deploy_utils.parse_instance_info_capabilities(node)"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_7094098c","line":92,"range":{"start_line":88,"start_character":0,"end_line":92,"end_character":39},"updated":"2017-06-12 13:22:41.000000000","message":"Same objection as earlier. We should bestsellers setting expectations.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  The function definition with its pseudo-code will be as follows:"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  .. code-block:: python"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    class VendorPXEBoot(pxe.PXEBoot):"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"      def prepare_instance(self, task):"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        # Check for boot from volume and boot mode"},{"line_number":95,"context_line":"        capabilities \u003d deploy_utils.parse_instance_info_capabilities(node)"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_3b79b82e","line":92,"range":{"start_line":88,"start_character":0,"end_line":92,"end_character":39},"in_reply_to":"7f231b9d_7094098c","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"In management interface will have two new methods, for setting and unsetting"},{"line_number":123,"context_line":"iSCSI target details."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  - ``set_iscsi_boot_target()`` - This will do the following:"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    - This will validate whether the necessary inputs for booting from iSCSI"},{"line_number":128,"context_line":"      volume are provided in node, and set target info making appropriate"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_cbe68ee9","line":125,"range":{"start_line":125,"start_character":10,"end_line":125,"end_character":15},"updated":"2017-06-12 13:22:41.000000000","message":"Crazy question: What about FC/FCOE supporting hardware?","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"In management interface will have two new methods, for setting and unsetting"},{"line_number":123,"context_line":"iSCSI target details."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  - ``set_iscsi_boot_target()`` - This will do the following:"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    - This will validate whether the necessary inputs for booting from iSCSI"},{"line_number":128,"context_line":"      volume are provided in node, and set target info making appropriate"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_7b9cd05c","line":125,"range":{"start_line":125,"start_character":10,"end_line":125,"end_character":15},"in_reply_to":"7f231b9d_cbe68ee9","updated":"2017-06-13 06:54:12.000000000","message":"Right now they only support iscsi.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"          # Let ipxe handle it"},{"line_number":120,"context_line":"          super(VendorPXEBoot, self).clean_up(task)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"In management interface will have two new methods, for setting and unsetting"},{"line_number":123,"context_line":"iSCSI target details."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  - ``set_iscsi_boot_target()`` - This will do the following:"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    - This will validate whether the necessary inputs for booting from iSCSI"},{"line_number":128,"context_line":"      volume are provided in node, and set target info making appropriate"},{"line_number":129,"context_line":"      library call."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  - ``clear_iscsi_boot_target()`` - This will do the following:"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    - This will clear the iSCSI target volume info in node, making appropriate"},{"line_number":134,"context_line":"      library call."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  - Both will raise ``UnsupportedDriverExtension`` for vendor who dont support"},{"line_number":137,"context_line":"    this"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  The function definition with its pseudo-code will be as follows:"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_50e6ad46","line":137,"range":{"start_line":122,"start_character":0,"end_line":137,"end_character":8},"updated":"2017-06-12 13:22:41.000000000","message":"Looks great!","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":266,"context_line":"  interface and adds the capability ``iscsi_boot\u003dtrue``  in"},{"line_number":267,"context_line":"  ``node.properties[\u0027capabilities\u0027]`` (or it could be populated by"},{"line_number":268,"context_line":"  inspection, but it\u0027s not part of this spec on how it gets populated)."},{"line_number":269,"context_line":"* Server intiator iqn could be populated by inspection and added to volume"},{"line_number":270,"context_line":"  connector table."},{"line_number":271,"context_line":"* Operator creates a flavor with Compute capability ``iscsi_boot\u003dtrue`` to"},{"line_number":272,"context_line":"  request bare metal booting from Cinder volume."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_2bbce203","line":269,"range":{"start_line":269,"start_character":22,"end_line":269,"end_character":28},"updated":"2017-06-12 13:22:41.000000000","message":"s/could//must/","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":266,"context_line":"  interface and adds the capability ``iscsi_boot\u003dtrue``  in"},{"line_number":267,"context_line":"  ``node.properties[\u0027capabilities\u0027]`` (or it could be populated by"},{"line_number":268,"context_line":"  inspection, but it\u0027s not part of this spec on how it gets populated)."},{"line_number":269,"context_line":"* Server intiator iqn could be populated by inspection and added to volume"},{"line_number":270,"context_line":"  connector table."},{"line_number":271,"context_line":"* Operator creates a flavor with Compute capability ``iscsi_boot\u003dtrue`` to"},{"line_number":272,"context_line":"  request bare metal booting from Cinder volume."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_fba7c0a6","line":269,"range":{"start_line":269,"start_character":22,"end_line":269,"end_character":28},"in_reply_to":"7f231b9d_2bbce203","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":267,"context_line":"  ``node.properties[\u0027capabilities\u0027]`` (or it could be populated by"},{"line_number":268,"context_line":"  inspection, but it\u0027s not part of this spec on how it gets populated)."},{"line_number":269,"context_line":"* Server intiator iqn could be populated by inspection and added to volume"},{"line_number":270,"context_line":"  connector table."},{"line_number":271,"context_line":"* Operator creates a flavor with Compute capability ``iscsi_boot\u003dtrue`` to"},{"line_number":272,"context_line":"  request bare metal booting from Cinder volume."},{"line_number":273,"context_line":"* Tenant creates a Cinder volume."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_2b5182d9","line":270,"range":{"start_line":270,"start_character":17,"end_line":270,"end_character":18},"updated":"2017-06-12 13:22:41.000000000","message":"s/./ for the node to be considered bootable.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":267,"context_line":"  ``node.properties[\u0027capabilities\u0027]`` (or it could be populated by"},{"line_number":268,"context_line":"  inspection, but it\u0027s not part of this spec on how it gets populated)."},{"line_number":269,"context_line":"* Server intiator iqn could be populated by inspection and added to volume"},{"line_number":270,"context_line":"  connector table."},{"line_number":271,"context_line":"* Operator creates a flavor with Compute capability ``iscsi_boot\u003dtrue`` to"},{"line_number":272,"context_line":"  request bare metal booting from Cinder volume."},{"line_number":273,"context_line":"* Tenant creates a Cinder volume."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_5bcc7469","line":270,"range":{"start_line":270,"start_character":17,"end_line":270,"end_character":18},"in_reply_to":"7f231b9d_2b5182d9","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"* Add two new methods in management interface ``set_iscsi_boot_target``"},{"line_number":307,"context_line":"  and ``clear_iscsi_boot_target``."},{"line_number":308,"context_line":"* Add new boot device ``ISCSI_BOOT`` will map to appropriate vendor boot device"},{"line_number":309,"context_line":"  for UEFI iSCSI Boot."},{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_2be3c235","line":309,"range":{"start_line":308,"start_character":0,"end_line":309,"end_character":22},"updated":"2017-06-12 13:22:41.000000000","message":"Explicitly mapping all \"ISCSI_BOOT\" devices to UEFI iSCSI seems wrong.  Method should not explicitly map to form of media utilized to boot a system.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"* Add two new methods in management interface ``set_iscsi_boot_target``"},{"line_number":307,"context_line":"  and ``clear_iscsi_boot_target``."},{"line_number":308,"context_line":"* Add new boot device ``ISCSI_BOOT`` will map to appropriate vendor boot device"},{"line_number":309,"context_line":"  for UEFI iSCSI Boot."},{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_db064487","line":309,"range":{"start_line":308,"start_character":0,"end_line":309,"end_character":22},"in_reply_to":"7f231b9d_2be3c235","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":307,"context_line":"  and ``clear_iscsi_boot_target``."},{"line_number":308,"context_line":"* Add new boot device ``ISCSI_BOOT`` will map to appropriate vendor boot device"},{"line_number":309,"context_line":"  for UEFI iSCSI Boot."},{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"},{"line_number":313,"context_line":"* Write unit tests."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_ab74729a","line":310,"range":{"start_line":310,"start_character":15,"end_line":310,"end_character":17},"updated":"2017-06-12 13:22:41.000000000","message":"Each vendor\u0027s what?","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":307,"context_line":"  and ``clear_iscsi_boot_target``."},{"line_number":308,"context_line":"* Add new boot device ``ISCSI_BOOT`` will map to appropriate vendor boot device"},{"line_number":309,"context_line":"  for UEFI iSCSI Boot."},{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"},{"line_number":313,"context_line":"* Write unit tests."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_eb7a6a86","line":310,"range":{"start_line":310,"start_character":24,"end_line":310,"end_character":50},"updated":"2017-06-12 13:22:41.000000000","message":"Question: Does it really?","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":307,"context_line":"  and ``clear_iscsi_boot_target``."},{"line_number":308,"context_line":"* Add new boot device ``ISCSI_BOOT`` will map to appropriate vendor boot device"},{"line_number":309,"context_line":"  for UEFI iSCSI Boot."},{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"},{"line_number":313,"context_line":"* Write unit tests."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_db31a40d","line":310,"range":{"start_line":310,"start_character":15,"end_line":310,"end_character":17},"in_reply_to":"7f231b9d_ab74729a","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":307,"context_line":"  and ``clear_iscsi_boot_target``."},{"line_number":308,"context_line":"* Add new boot device ``ISCSI_BOOT`` will map to appropriate vendor boot device"},{"line_number":309,"context_line":"  for UEFI iSCSI Boot."},{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"},{"line_number":313,"context_line":"* Write unit tests."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_bb34a8fc","line":310,"range":{"start_line":310,"start_character":24,"end_line":310,"end_character":50},"in_reply_to":"7f231b9d_eb7a6a86","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":309,"context_line":"  for UEFI iSCSI Boot."},{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"},{"line_number":313,"context_line":"* Write unit tests."},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_b04aa17d","line":312,"range":{"start_line":312,"start_character":48,"end_line":312,"end_character":50},"updated":"2017-06-12 13:22:41.000000000","message":"nit: s/by/via/","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":309,"context_line":"  for UEFI iSCSI Boot."},{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"},{"line_number":313,"context_line":"* Write unit tests."},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_b03f41d5","line":312,"range":{"start_line":312,"start_character":51,"end_line":312,"end_character":61},"updated":"2017-06-12 13:22:41.000000000","message":"s/inspection/the inspection process./","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":309,"context_line":"  for UEFI iSCSI Boot."},{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"},{"line_number":313,"context_line":"* Write unit tests."},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_bb1dc874","line":312,"range":{"start_line":312,"start_character":51,"end_line":312,"end_character":61},"in_reply_to":"7f231b9d_b03f41d5","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":309,"context_line":"  for UEFI iSCSI Boot."},{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"},{"line_number":313,"context_line":"* Write unit tests."},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_9b144c50","line":312,"range":{"start_line":312,"start_character":48,"end_line":312,"end_character":50},"in_reply_to":"7f231b9d_b04aa17d","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"},{"line_number":313,"context_line":"* Write unit tests."},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Dependencies"},{"line_number":316,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_b0186181","line":313,"range":{"start_line":313,"start_character":0,"end_line":313,"end_character":19},"updated":"2017-06-12 13:22:41.000000000","message":"Unit tests are implied part of the process to land any code in ironic, you can drop this line item if you so desire.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":310,"context_line":"* Each vendor\u0027s need to inherit pxe boot interface and call this management"},{"line_number":311,"context_line":"  methods."},{"line_number":312,"context_line":"* Need to populate iscsi intiator iqn of server by inspection"},{"line_number":313,"context_line":"* Write unit tests."},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Dependencies"},{"line_number":316,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_7b173053","line":313,"range":{"start_line":313,"start_character":0,"end_line":313,"end_character":19},"in_reply_to":"7f231b9d_b0186181","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":321,"context_line":"Testing"},{"line_number":322,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"Will have a new gate in CI, orchestrated by a tempest test case, to"},{"line_number":325,"context_line":"functionally test the base boot from Cinder volume functionality, in"},{"line_number":326,"context_line":"UEFI mode."},{"line_number":327,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_f01819d4","line":324,"range":{"start_line":324,"start_character":0,"end_line":324,"end_character":26},"updated":"2017-06-12 13:22:41.000000000","message":"perhaps \"It is the expectation that vendors implementing boot from cinder/volume functionality, should have a test in  their CI,...\"","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":321,"context_line":"Testing"},{"line_number":322,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"Will have a new gate in CI, orchestrated by a tempest test case, to"},{"line_number":325,"context_line":"functionally test the base boot from Cinder volume functionality, in"},{"line_number":326,"context_line":"UEFI mode."},{"line_number":327,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_3e0e4632","line":324,"range":{"start_line":324,"start_character":0,"end_line":324,"end_character":26},"in_reply_to":"7f231b9d_f01819d4","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb4ecaab10112aa046174d4266a7da00c7ac252f","unresolved":false,"context_lines":[{"line_number":322,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"Will have a new gate in CI, orchestrated by a tempest test case, to"},{"line_number":325,"context_line":"functionally test the base boot from Cinder volume functionality, in"},{"line_number":326,"context_line":"UEFI mode."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":329,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_d06cfd09","line":326,"range":{"start_line":325,"start_character":64,"end_line":326,"end_character":10},"updated":"2017-06-12 13:22:41.000000000","message":"This is redundant in that it is up to the vendor\u0027s driver. The tempest test should care about a vendor driver booting from a remote volume.","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"7d9936a395f72a178bb83115df399e4c4f630f3c","unresolved":false,"context_lines":[{"line_number":322,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"Will have a new gate in CI, orchestrated by a tempest test case, to"},{"line_number":325,"context_line":"functionally test the base boot from Cinder volume functionality, in"},{"line_number":326,"context_line":"UEFI mode."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":329,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7f231b9d_1e1dca65","line":326,"range":{"start_line":325,"start_character":64,"end_line":326,"end_character":10},"in_reply_to":"7f231b9d_d06cfd09","updated":"2017-06-13 06:54:12.000000000","message":"Done","commit_id":"b0db729f58fe73bc89416e521221b963d39bde8e"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"4e1883ef0fbba2eef49a8dfc0085d4093e3b7899","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Hardware can also be configured programmatically to boot from an iSCSI volume"},{"line_number":29,"context_line":"(without using bootloaders like iPXE) via the firmware/lights out management."},{"line_number":30,"context_line":"For instance, HPE ProLiant Gen9 hardware (having HPE ProLiant Gen9 System ROM"},{"line_number":31,"context_line":"P89 release version 1.40 or higher) supports such a booting option from an"},{"line_number":32,"context_line":"iSCSI volume."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"df3967d1_fb52df3a","line":31,"updated":"2017-08-02 21:05:56.000000000","message":"Gen9 hardware and above support UEFI iSCSI boot.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":39,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":40,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":41,"context_line":"change proposes a new boot interface named ``UEFIiSCSIBoot`` which will"},{"line_number":42,"context_line":"facilitate booting from iSCSI Cinder volume for UEFI iSCSI boot capable"},{"line_number":43,"context_line":"servers. The aim is to have a common way for the vendor drivers of setting"},{"line_number":44,"context_line":"the iSCSI target parameters into their servers and hence leverage the remote"},{"line_number":45,"context_line":"storage as a boot volume."}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_db48182e","line":42,"range":{"start_line":42,"start_character":48,"end_line":42,"end_character":58},"updated":"2017-07-27 12:19:27.000000000","message":"Please separate UEFI out from iSCSI.\n\nAn operator/user should be able to choose between the two, and they are not conjoined as an operational requirement unless this is an HP design constraint of the firwmare. In any mode, UEFI or BIOS, a system can be booted from an iSCSI target. UEFI just looks for a partition and a specific file on that partition. BIOS starts reading at block 0 of the disk and executes that code.\n\nI hope this helps it become clear why  I have an issue with the two items being joined into a singular interface.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"2023785b0446fff4b283b8e975e61e68575428ba","unresolved":false,"context_lines":[{"line_number":39,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ to support booting ironic"},{"line_number":40,"context_line":"nodes from a storage device that is hosted and/or controlled remotely. This"},{"line_number":41,"context_line":"change proposes a new boot interface named ``UEFIiSCSIBoot`` which will"},{"line_number":42,"context_line":"facilitate booting from iSCSI Cinder volume for UEFI iSCSI boot capable"},{"line_number":43,"context_line":"servers. The aim is to have a common way for the vendor drivers of setting"},{"line_number":44,"context_line":"the iSCSI target parameters into their servers and hence leverage the remote"},{"line_number":45,"context_line":"storage as a boot volume."}],"source_content_type":"text/x-rst","patch_set":28,"id":"df3967d1_0f7ea618","line":42,"in_reply_to":"ff346bd7_db48182e","updated":"2017-08-01 21:49:04.000000000","message":"Just want to add some clarification for the scope of this spec.  UEFI provides a network stack and an iSCSI software initiator.  UEFI also defines an  EFI_ISCSI_INITIATOR_NAME_PROTOCOL to manage  iSCSI initiator.   On the other hand, some NIC vendors may support iSCSI for BIOS mode but the implementation and interface are NIC vendor specific.   Therefore, this spec is proposing a boot interface for platforms that support UEFI iSCSI boot capability in the system ROM firmware.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"4e1883ef0fbba2eef49a8dfc0085d4093e3b7899","unresolved":false,"context_lines":[{"line_number":43,"context_line":"servers. The aim is to have a common way for the vendor drivers of setting"},{"line_number":44,"context_line":"the iSCSI target parameters into their servers and hence leverage the remote"},{"line_number":45,"context_line":"storage as a boot volume."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"In ``prepare_instance()`` method of this new boot interface defined, it will"},{"line_number":48,"context_line":"check whether volume is provisioned with the user image to boot from or not,"},{"line_number":49,"context_line":"if provisioned then it set the iSCSI target related attributes."}],"source_content_type":"text/x-rst","patch_set":28,"id":"df3967d1_5bfb2b46","line":46,"updated":"2017-08-02 21:05:56.000000000","message":"We should allow user to set initiator iqn (an optional parameter).","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":44,"context_line":"the iSCSI target parameters into their servers and hence leverage the remote"},{"line_number":45,"context_line":"storage as a boot volume."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"In ``prepare_instance()`` method of this new boot interface defined, it will"},{"line_number":48,"context_line":"check whether volume is provisioned with the user image to boot from or not,"},{"line_number":49,"context_line":"if provisioned then it set the iSCSI target related attributes."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  - Check if in node capabilities boot mode is set to ``uefi`` and"}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_9ba610ab","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":76},"updated":"2017-07-27 12:19:27.000000000","message":"It is the user\u0027s responsibility in this arrangement to tell nova what to boot and how to boot it.  By what criteria would this work?  Why should it assume to override the user\u0027s choices?  This is why we have the should_write_image logic in the storage interface.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  - Check if in node capabilities boot mode is set to ``uefi`` and"},{"line_number":52,"context_line":"    ``iscsi_boot`` is true."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"},{"line_number":55,"context_line":"    not using storage interface ``should_write_image``. If not, then it may"},{"line_number":56,"context_line":"    notify the trigger of the mechanism to write the image to volume. Although"},{"line_number":57,"context_line":"    this mechanism is ideally part of deploy interface\u0027s ``prepare()`` method"},{"line_number":58,"context_line":"    but can be re-used here if the deploy interface is properly configured."},{"line_number":59,"context_line":"    It should raise an exception if that is not properly configured."}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_bbc2f432","line":56,"range":{"start_line":54,"start_character":2,"end_line":56,"end_character":69},"updated":"2017-07-27 12:19:27.000000000","message":"This is essentially describing the deploy interface skip logic.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  - If check is satisfied it will check whether volume is provisioned or"},{"line_number":55,"context_line":"    not using storage interface ``should_write_image``. If not, then it may"},{"line_number":56,"context_line":"    notify the trigger of the mechanism to write the image to volume. Although"},{"line_number":57,"context_line":"    this mechanism is ideally part of deploy interface\u0027s ``prepare()`` method"},{"line_number":58,"context_line":"    but can be re-used here if the deploy interface is properly configured."},{"line_number":59,"context_line":"    It should raise an exception if that is not properly configured."},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_fb7e3c17","line":57,"range":{"start_line":56,"start_character":70,"end_line":57,"end_character":70},"updated":"2017-07-27 12:19:27.000000000","message":"This is commentary regarding the implementation that has landed. It has nothing to do with a proposed solution aside provide context of what is desired to do differently.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    but can be re-used here if the deploy interface is properly configured."},{"line_number":59,"context_line":"    It should raise an exception if that is not properly configured."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  - Alternatively, boot interface\u0027s ``validate()`` method could also check for"},{"line_number":62,"context_line":"    this and raise this exception if an invalid configuration is requested or"},{"line_number":63,"context_line":"    configured for the server"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  - If check is satisfied it will set iSCSI target details in."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_3ba8448a","line":63,"range":{"start_line":61,"start_character":2,"end_line":63,"end_character":29},"updated":"2017-07-27 12:19:27.000000000","message":"It absolutely should.  Boot, Deploy, and Storage are the only three interfaces whose validation return values matter to nova as of the Pike release.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    this and raise this exception if an invalid configuration is requested or"},{"line_number":63,"context_line":"    configured for the server"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  - If check is satisfied it will set iSCSI target details in."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  - It will also set boot device to ``ISCSIBOOT``."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_3bfde46d","line":65,"range":{"start_line":65,"start_character":59,"end_line":65,"end_character":62},"updated":"2017-07-27 12:19:27.000000000","message":"In? Into the controller? Node firmware settings?","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  - It will also set boot device to ``ISCSIBOOT``."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In ``clean_up_instance()`` method it will clear the iSCSI target details."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Additionally the ``validate()`` can do the following:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_bb6af47d","line":69,"range":{"start_line":69,"start_character":3,"end_line":69,"end_character":25},"updated":"2017-07-27 12:19:27.000000000","message":"Where is this method intended to reside? Seems like it does the same as clear_iscsi_boot_target that your proposing around line 107.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In ``clean_up_instance()`` method it will clear the iSCSI target details."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Additionally the ``validate()`` can do the following:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  - validate whether the necessary inputs for booting from iSCSI target volume"},{"line_number":74,"context_line":"    are provided in node. This includes target IQN, LUN number, IP address of"}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_3b5724cd","line":71,"range":{"start_line":71,"start_character":32,"end_line":71,"end_character":52},"updated":"2017-07-27 12:19:27.000000000","message":"s/can/should/","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":71,"context_line":"Additionally the ``validate()`` can do the following:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  - validate whether the necessary inputs for booting from iSCSI target volume"},{"line_number":74,"context_line":"    are provided in node. This includes target IQN, LUN number, IP address of"},{"line_number":75,"context_line":"    target, port, authentication method, username, password."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    This information comes from the originating storage system driver in"}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_1b10e0a7","line":74,"range":{"start_line":74,"start_character":17,"end_line":74,"end_character":25},"updated":"2017-07-27 12:19:27.000000000","message":"in node? This should be in the associated node\u0027s volume target records.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    This information comes from the originating storage system driver in"},{"line_number":78,"context_line":"    cinder, so there can be some variation, and we can\u0027t and don\u0027t expect to"},{"line_number":79,"context_line":"    always have all of these parameters. Target IP address, port, IQN, LUN"},{"line_number":80,"context_line":"    number are the least fulfilling requirements from any hardware, it seems."},{"line_number":81,"context_line":"    The logic for policy based validation of additional parameters could also"},{"line_number":82,"context_line":"    be accommodated here."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_5bd9c854","line":80,"range":{"start_line":80,"start_character":66,"end_line":80,"end_character":77},"updated":"2017-07-27 12:19:27.000000000","message":"I don\u0027t understand \", it seems.\"","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cinder, so there can be some variation, and we can\u0027t and don\u0027t expect to"},{"line_number":79,"context_line":"    always have all of these parameters. Target IP address, port, IQN, LUN"},{"line_number":80,"context_line":"    number are the least fulfilling requirements from any hardware, it seems."},{"line_number":81,"context_line":"    The logic for policy based validation of additional parameters could also"},{"line_number":82,"context_line":"    be accommodated here."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  - If any of the validation logic in the can be reused, we will attempt to"},{"line_number":85,"context_line":"    reuse."}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_5bc2e85a","line":82,"range":{"start_line":81,"start_character":4,"end_line":82,"end_character":25},"updated":"2017-07-27 12:19:27.000000000","message":"If it relates to booting a node, yes.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  - If any of the validation logic in the can be reused, we will attempt to"},{"line_number":85,"context_line":"    reuse."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Multipathing can be supported, if multiple NICs are enabled on the bare metal"},{"line_number":88,"context_line":"then iSCSI configuration is set up on all the enabled NICs. This can provide"},{"line_number":89,"context_line":"multiple redundant paths to the target if target is reachable through these"},{"line_number":90,"context_line":"NICs."}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_9b70500a","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":77},"updated":"2017-07-27 12:19:27.000000000","message":"For the record, multipath is not about multiple connections. It is about supporting multiple possible paths to storage that could be served even over one connection.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Multipathing can be supported, if multiple NICs are enabled on the bare metal"},{"line_number":88,"context_line":"then iSCSI configuration is set up on all the enabled NICs. This can provide"},{"line_number":89,"context_line":"multiple redundant paths to the target if target is reachable through these"},{"line_number":90,"context_line":"NICs."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"},{"line_number":93,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_fbd07c21","line":90,"updated":"2017-07-27 12:19:27.000000000","message":"Question: Will introspection be updated to help populate the connectors information?","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"2023785b0446fff4b283b8e975e61e68575428ba","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Multipathing can be supported, if multiple NICs are enabled on the bare metal"},{"line_number":88,"context_line":"then iSCSI configuration is set up on all the enabled NICs. This can provide"},{"line_number":89,"context_line":"multiple redundant paths to the target if target is reachable through these"},{"line_number":90,"context_line":"NICs."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"},{"line_number":93,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":28,"id":"df3967d1_0a221453","line":90,"in_reply_to":"ff346bd7_fbd07c21","updated":"2017-08-01 21:49:04.000000000","message":"I think it\u0027s a good idea to have introspection to populate the info (if it supports it).","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":98,"context_line":"setting and unsetting iSCSI target details."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  - ``set_iscsi_boot_target()`` - This will do the following:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    - This will validate whether the necessary inputs for booting from iSCSI"},{"line_number":104,"context_line":"      volume are provided in node, and set target info making appropriate"},{"line_number":105,"context_line":"      library call."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  - ``clear_iscsi_boot_target()`` - This will do the following:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    - This will clear the iSCSI target volume info in node, making appropriate"},{"line_number":110,"context_line":"      library call."}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_3bf044fd","line":107,"range":{"start_line":101,"start_character":0,"end_line":107,"end_character":63},"updated":"2017-07-27 12:19:27.000000000","message":"This is likely PTG discussion worthy, as it seems cleaner, however boot interface logic for prepare_instance is likely unavoidable on the vendor boot interface level.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"2023785b0446fff4b283b8e975e61e68575428ba","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      volume are provided in node, and set target info making appropriate"},{"line_number":105,"context_line":"      library call."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  - ``clear_iscsi_boot_target()`` - This will do the following:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    - This will clear the iSCSI target volume info in node, making appropriate"},{"line_number":110,"context_line":"      library call."}],"source_content_type":"text/x-rst","patch_set":28,"id":"df3967d1_0a6d7431","line":107,"in_reply_to":"ff346bd7_3bf044fd","updated":"2017-08-01 21:49:04.000000000","message":"Unfortunately, iLO team won\u0027t be able to make to PTG in person.   If needed, perhaps we can discuss it in the weekly IRC meeting or join PTG remotely if this alternative is available.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":117,"context_line":"and in those the appropriate library call will happen to set and clear"},{"line_number":118,"context_line":"iSCSI target info."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"But the downside of it is vendor will lose the flexibility to write the"},{"line_number":121,"context_line":"methods as they feel best suits their integration into ironic. Again, this"},{"line_number":122,"context_line":"will also require change in vendor\u0027s conductor or management driver"},{"line_number":123,"context_line":"interfaces."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_9b017009","line":123,"range":{"start_line":120,"start_character":0,"end_line":123,"end_character":11},"updated":"2017-07-27 12:19:27.000000000","message":"Please provide detailed perceived caveats to your proposed alternative.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"2023785b0446fff4b283b8e975e61e68575428ba","unresolved":false,"context_lines":[{"line_number":121,"context_line":"methods as they feel best suits their integration into ironic. Again, this"},{"line_number":122,"context_line":"will also require change in vendor\u0027s conductor or management driver"},{"line_number":123,"context_line":"interfaces."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Data model impact"},{"line_number":127,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":28,"id":"df3967d1_cadacc15","line":124,"updated":"2017-08-01 21:49:04.000000000","message":"In the future if Ironic extends the BFV to support image provisioning for cinder volume, then these two set/clear_iscsi_boot_target methods are not sufficient.  It seems to me that the new boot interface as proposed by this spec is more flexible and extensible.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":193,"context_line":"  interface and adds the capability ``iscsi_boot\u003dtrue``  in"},{"line_number":194,"context_line":"  ``node.properties[\u0027capabilities\u0027]`` (or it could be populated by"},{"line_number":195,"context_line":"  inspection, but it\u0027s not part of this spec on how it gets populated)."},{"line_number":196,"context_line":"* Server initiator iqn must be populated by inspection and added to volume"},{"line_number":197,"context_line":"  connector table for the node to be considered bootable."},{"line_number":198,"context_line":"* Operator creates a flavor with Compute capability ``iscsi_boot\u003dtrue`` to"},{"line_number":199,"context_line":"  request bare metal booting from Cinder volume."}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_9b53b039","line":196,"range":{"start_line":196,"start_character":28,"end_line":196,"end_character":54},"updated":"2017-07-27 12:19:27.000000000","message":"Mentioning inspection is excess information.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":202,"context_line":"  with the above mentioned flavor."},{"line_number":203,"context_line":"* Nova scheduler selects a bare metal node capable of booting from Cinder"},{"line_number":204,"context_line":"  volume."},{"line_number":205,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":206,"context_line":"  For more information, refer nova spec"},{"line_number":207,"context_line":"  `Add support for booting bare metals from Cinder volume`_."},{"line_number":208,"context_line":"* When appropriate hardware gets selected, this new boot interface reads this"},{"line_number":209,"context_line":"  information, sets up the hardware to boot from Cinder volume and hands"},{"line_number":210,"context_line":"  it over to the tenant."}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_fb899cc9","line":207,"range":{"start_line":205,"start_character":0,"end_line":207,"end_character":60},"updated":"2017-07-27 12:19:27.000000000","message":"As of earlier this week, the nova ironic virt driver does this.  There really is no need to link to a specification that never landed, since we added that functionality via a blueprint as we had a spec in ironic that covered it.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":205,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":206,"context_line":"  For more information, refer nova spec"},{"line_number":207,"context_line":"  `Add support for booting bare metals from Cinder volume`_."},{"line_number":208,"context_line":"* When appropriate hardware gets selected, this new boot interface reads this"},{"line_number":209,"context_line":"  information, sets up the hardware to boot from Cinder volume and hands"},{"line_number":210,"context_line":"  it over to the tenant."},{"line_number":211,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_5b69c8f6","line":208,"range":{"start_line":208,"start_character":43,"end_line":208,"end_character":51},"updated":"2017-07-27 12:19:27.000000000","message":"It may be better to say \"the supported boot interface reads\"","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":206,"context_line":"  For more information, refer nova spec"},{"line_number":207,"context_line":"  `Add support for booting bare metals from Cinder volume`_."},{"line_number":208,"context_line":"* When appropriate hardware gets selected, this new boot interface reads this"},{"line_number":209,"context_line":"  information, sets up the hardware to boot from Cinder volume and hands"},{"line_number":210,"context_line":"  it over to the tenant."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":".. _`Add support for booting bare metals from Cinder volume`: https://review.openstack.org/#/c/211101/"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_5b52e83c","line":210,"range":{"start_line":209,"start_character":15,"end_line":210,"end_character":24},"updated":"2017-07-27 12:19:27.000000000","message":"The machine must still walk through the state machine. We can\u0027t go from set provision state ACTIVE -\u003e boot.prepare_instance() -\u003e return DEPLOY_DONE().  The Boot from Volume spec for generic drivers walks the machine through the deploy step and triggers attachment data to be recorded with cinder at that time as there is entirely the possibility that we may need to write a deployment image to a target at a future point in time.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4d884b638c0c7d8800748822a7c91f690681f079","unresolved":false,"context_lines":[{"line_number":209,"context_line":"  information, sets up the hardware to boot from Cinder volume and hands"},{"line_number":210,"context_line":"  it over to the tenant."},{"line_number":211,"context_line":""},{"line_number":212,"context_line":".. _`Add support for booting bare metals from Cinder volume`: https://review.openstack.org/#/c/211101/"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Developer impact"},{"line_number":215,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":28,"id":"ff346bd7_1bec608d","line":212,"range":{"start_line":212,"start_character":62,"end_line":212,"end_character":102},"updated":"2017-07-27 12:19:27.000000000","message":"This has a -1 from 2015. If it is being used as context for this specification, it is out of date.","commit_id":"83d88966bc16e0c048518fc25dd9295bc150a08e"}],"specs/liberty/ilo-uefi-iscsi-boot.rst":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8c973cff9bbe90d9869c8a491cd81881b74681b5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":"This change proposes a new driver uefi_iscsi_ilo which facilitates booting"},{"line_number":30,"context_line":"from iSCSI Cinder volume for HP Proliant Gen9 Hardware (having HP ProLiant"},{"line_number":31,"context_line":"Gen9 System ROM P89 release version 1.40 or higher)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_a4712478","line":29,"updated":"2015-08-06 07:01:54.000000000","message":"IMO it will be better to add a new deploy mechanism for iscsi_ilo driver itself instead of adding a new driver.","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7790d49ece69157268da71ae49f29796e7c6ed88","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":"This change proposes a new driver uefi_iscsi_ilo which facilitates booting"},{"line_number":30,"context_line":"from iSCSI Cinder volume for HP Proliant Gen9 Hardware (having HP ProLiant"},{"line_number":31,"context_line":"Gen9 System ROM P89 release version 1.40 or higher)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_e7a2c498","line":29,"in_reply_to":"1a4dcd0f_a4712478","updated":"2015-08-06 10:55:09.000000000","message":"Yeah, I am proposing to depend on https://review.openstack.org/209821","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8c973cff9bbe90d9869c8a491cd81881b74681b5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  The function definition will be as follows::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"      def validate(task):"},{"line_number":49,"context_line":"          \"\"\"Validates the given RAID configuration."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"          :param task: TaskManager object containing the node."},{"line_number":52,"context_line":"          :raises: InvalidParameterValue, if RAID configuration is invalid."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_c43eb08a","line":49,"updated":"2015-08-06 07:01:54.000000000","message":"Is Uefi Iscsi deploy dependent on RAID configuration?","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7790d49ece69157268da71ae49f29796e7c6ed88","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  The function definition will be as follows::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"      def validate(task):"},{"line_number":49,"context_line":"          \"\"\"Validates the given RAID configuration."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"          :param task: TaskManager object containing the node."},{"line_number":52,"context_line":"          :raises: InvalidParameterValue, if RAID configuration is invalid."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_07fc9070","line":49,"in_reply_to":"1a4dcd0f_c43eb08a","updated":"2015-08-06 10:55:09.000000000","message":"Done","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8c973cff9bbe90d9869c8a491cd81881b74681b5","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"          :param task: TaskManager object containing the node."},{"line_number":52,"context_line":"          :raises: InvalidParameterValue, if RAID configuration is invalid."},{"line_number":53,"context_line":"          :raises: MissingParameterValue, if RAID configuration has some"},{"line_number":54,"context_line":"              missing parameters."},{"line_number":55,"context_line":"          \"\"\""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_c4da304b","line":53,"updated":"2015-08-06 07:01:54.000000000","message":"You might want to revisit the exceptions likely to be thrown.","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7790d49ece69157268da71ae49f29796e7c6ed88","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"          :param task: TaskManager object containing the node."},{"line_number":52,"context_line":"          :raises: InvalidParameterValue, if RAID configuration is invalid."},{"line_number":53,"context_line":"          :raises: MissingParameterValue, if RAID configuration has some"},{"line_number":54,"context_line":"              missing parameters."},{"line_number":55,"context_line":"          \"\"\""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_c7fa2875","line":53,"in_reply_to":"1a4dcd0f_c4da304b","updated":"2015-08-06 10:55:09.000000000","message":"I think this is correct, these two exceptions can be thrown.","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"310b35553cc0478fc3e0a675cb957035b0b97ec7","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  - Ironic connects to the Cinder volume and writes the config drive to the"},{"line_number":60,"context_line":"    end of the disk (as done by Ironic Python Agent, this code needs to be"},{"line_number":61,"context_line":"    moved to ironic-lib[2]). It should delete the existing config drive"},{"line_number":62,"context_line":"    partition and rewrite a new one (when Cinder volume is reused multiple"},{"line_number":63,"context_line":"    times)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a50d1a3_38ab3220","line":61,"updated":"2015-07-31 21:18:54.000000000","message":"config drive should be deleted during tear_down -- however, having an extra check here isn\u0027t bad","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7790d49ece69157268da71ae49f29796e7c6ed88","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  - Ironic connects to the Cinder volume and writes the config drive to the"},{"line_number":60,"context_line":"    end of the disk (as done by Ironic Python Agent, this code needs to be"},{"line_number":61,"context_line":"    moved to ironic-lib[2]). It should delete the existing config drive"},{"line_number":62,"context_line":"    partition and rewrite a new one (when Cinder volume is reused multiple"},{"line_number":63,"context_line":"    times)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_ee03f4b6","line":61,"in_reply_to":"3a50d1a3_38ab3220","updated":"2015-08-06 10:55:09.000000000","message":"Done","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5ca85325d332dcabe94313a00c8098c510087233","unresolved":false,"context_lines":[{"line_number":82,"context_line":"* ``tear_down()`` - This will do the following:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  - Clears the iSCSI settings from the Proliant hardware by making a"},{"line_number":85,"context_line":"    proliantutils call."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  The function definition will be as follows::"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a50d1a3_03b3beea","line":85,"updated":"2015-07-30 10:50:29.000000000","message":"Shouldn\u0027t we remove config drive as well? Wont it be a security risk to leave it there?","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"310b35553cc0478fc3e0a675cb957035b0b97ec7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"* ``tear_down()`` - This will do the following:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  - Clears the iSCSI settings from the Proliant hardware by making a"},{"line_number":85,"context_line":"    proliantutils call."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  The function definition will be as follows::"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a50d1a3_78469a7c","line":85,"in_reply_to":"3a50d1a3_03b3beea","updated":"2015-07-31 21:18:54.000000000","message":"I agree - tear_down should erase the config drive.\n\nfurthermore, how will this driver implement the cleaning step? this is normally where a secure erase would take place.","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7790d49ece69157268da71ae49f29796e7c6ed88","unresolved":false,"context_lines":[{"line_number":82,"context_line":"* ``tear_down()`` - This will do the following:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  - Clears the iSCSI settings from the Proliant hardware by making a"},{"line_number":85,"context_line":"    proliantutils call."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  The function definition will be as follows::"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_3dac799f","line":85,"in_reply_to":"3a50d1a3_78469a7c","updated":"2015-08-06 10:55:09.000000000","message":"Done","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"310b35553cc0478fc3e0a675cb957035b0b97ec7","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Alternatives"},{"line_number":98,"context_line":"------------"},{"line_number":99,"context_line":"None."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Data model impact"},{"line_number":102,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a50d1a3_530e1f33","line":99,"updated":"2015-07-31 21:18:54.000000000","message":"what would be the pros and cons to adding this functionality to the existing iscsi_ilo driver?\n\n(that might be a terrible idea, but I\u0027d like us to think about the impact a bit before we go doubling the number of drivers, again)","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8c973cff9bbe90d9869c8a491cd81881b74681b5","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Alternatives"},{"line_number":98,"context_line":"------------"},{"line_number":99,"context_line":"None."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Data model impact"},{"line_number":102,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_a494c442","line":99,"in_reply_to":"3a50d1a3_530e1f33","updated":"2015-08-06 07:01:54.000000000","message":"+1 i agree with Deva here","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7790d49ece69157268da71ae49f29796e7c6ed88","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Alternatives"},{"line_number":98,"context_line":"------------"},{"line_number":99,"context_line":"None."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Data model impact"},{"line_number":102,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_7d90c143","line":99,"in_reply_to":"3a50d1a3_530e1f33","updated":"2015-08-06 10:55:09.000000000","message":"I will add it, actually I like mixing it with iscsi_ilo (and other ilo drivers) in a generic way.  I am not sure if it will be a terrible idea, but will propose the spec and see.","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"310b35553cc0478fc3e0a675cb957035b0b97ec7","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"State Machine Impact"},{"line_number":106,"context_line":"--------------------"},{"line_number":107,"context_line":"None."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"REST API impact"},{"line_number":110,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a50d1a3_783d3adc","line":107,"updated":"2015-07-31 21:18:54.000000000","message":"if volume is disconnected at tear-down, how does this interact with cleaning?","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7790d49ece69157268da71ae49f29796e7c6ed88","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"State Machine Impact"},{"line_number":106,"context_line":"--------------------"},{"line_number":107,"context_line":"None."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"REST API impact"},{"line_number":110,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_fd27f10f","line":107,"in_reply_to":"3a50d1a3_783d3adc","updated":"2015-08-06 10:55:09.000000000","message":"the cinder volume shouldn\u0027t be erased during cleaning right ? may be the user wanted to move the image to some other compute (probably a vm).  so i think, we shouldn\u0027t touch the cinder volume during cleaning.","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"310b35553cc0478fc3e0a675cb957035b0b97ec7","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  but it\u0027s not part of this spec on how it gets populated)."},{"line_number":157,"context_line":"* Tenant creates a Cinder volume."},{"line_number":158,"context_line":"* Tenant requests an bare metal instance to be booted up with a Cinder volume."},{"line_number":159,"context_line":"* Nova scheduler selects a bare metal node capable of booting from Cinder"},{"line_number":160,"context_line":"  volume."},{"line_number":161,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":162,"context_line":"* When Proliant Gen9 hardware gets selected, the ``uefi_iscsi_ilo`` driver"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a50d1a3_f34acb54","line":159,"updated":"2015-07-31 21:18:54.000000000","message":"this requires scheduler changes -- where have those been discussed?","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7790d49ece69157268da71ae49f29796e7c6ed88","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  but it\u0027s not part of this spec on how it gets populated)."},{"line_number":157,"context_line":"* Tenant creates a Cinder volume."},{"line_number":158,"context_line":"* Tenant requests an bare metal instance to be booted up with a Cinder volume."},{"line_number":159,"context_line":"* Nova scheduler selects a bare metal node capable of booting from Cinder"},{"line_number":160,"context_line":"  volume."},{"line_number":161,"context_line":"* Nova Ironic virt driver passes information about iSCSI volume to Ironic."},{"line_number":162,"context_line":"* When Proliant Gen9 hardware gets selected, the ``uefi_iscsi_ilo`` driver"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_9de10dd3","line":159,"in_reply_to":"3a50d1a3_f34acb54","updated":"2015-08-06 10:55:09.000000000","message":"this has been (or rather should be) discussed in the parent spec.  some new attributes (like iscsi_boot, rbd_boot, etc) will be added, by which nova scheduler can figure out whether the bare metal supports booting from a specific type of cinder volume.","commit_id":"91543956e5f5ec0d15f5ac7fbca69228b720bab2"}]}