)]}'
{"specs/approved/intel-node-manager.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29e34073079133bc7ff3875c7608c7af47085382","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Intel Node Manager, an Intel server firmware feature, is a smart way to"},{"line_number":19,"context_line":"optimize and manage power, cooling, and compute resources in the data center."},{"line_number":20,"context_line":"There is no support of Intel Node Manager policies for power and CPU control"},{"line_number":21,"context_line":"in Ironic."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa1b9901_af6be9f0","line":18,"updated":"2015-08-21 18:22:48.000000000","message":"could you please elaborate on \"smart way\" for those who haven\u0027t heard about node manager? what does it actually do? how does it benefit ironic?","commit_id":"f771e197d4decb82f74ad9961e984a24e356ac9d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e9297157975154280a97d7dd3f7dd91e98ae3d8b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Intel Node Manager, an Intel server firmware feature, is a smart way to"},{"line_number":19,"context_line":"optimize and manage power, cooling, and compute resources in the data center."},{"line_number":20,"context_line":"There is no support of Intel Node Manager policies for power and CPU control"},{"line_number":21,"context_line":"in Ironic."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa1b9901_75108a00","line":18,"in_reply_to":"fa1b9901_af6be9f0","updated":"2015-08-26 15:53:53.000000000","message":"Done","commit_id":"f771e197d4decb82f74ad9961e984a24e356ac9d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29e34073079133bc7ff3875c7608c7af47085382","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GET /v1/drivers/\u003cdriver\u003e/firmware/intel_nm will return list of available"},{"line_number":34,"context_line":"parameters::"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  ["},{"line_number":37,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa1b9901_cf709ddf","line":34,"updated":"2015-08-21 18:22:48.000000000","message":"API will be defined in the parent spec, you\u0027d better just list available parameters. Also, which \u003cdriver\u003e will use this interface?","commit_id":"f771e197d4decb82f74ad9961e984a24e356ac9d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e9297157975154280a97d7dd3f7dd91e98ae3d8b","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"GET /v1/drivers/\u003cdriver\u003e/firmware/intel_nm will return list of available"},{"line_number":34,"context_line":"parameters::"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  ["},{"line_number":37,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa1b9901_b5d86254","line":34,"in_reply_to":"fa1b9901_cf709ddf","updated":"2015-08-26 15:53:53.000000000","message":"Done","commit_id":"f771e197d4decb82f74ad9961e984a24e356ac9d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29e34073079133bc7ff3875c7608c7af47085382","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Intel Node Manager policies are extension of IPMI standard. ``IntelNMFirmware``"},{"line_number":93,"context_line":"interface should work in Ironic with ``ipmi*`` drivers and should use"},{"line_number":94,"context_line":"``send_raw()`` method for interactions with a node. ``send_raw()`` method"},{"line_number":95,"context_line":"will be extended and should return response raw data."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Other parameter notes:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa1b9901_6f7631da","line":95,"updated":"2015-08-21 18:22:48.000000000","message":"But it\u0027s not a part of IPMI standard, right? That means we might want to subclass IPMI driver...","commit_id":"f771e197d4decb82f74ad9961e984a24e356ac9d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e9297157975154280a97d7dd3f7dd91e98ae3d8b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Intel Node Manager policies are extension of IPMI standard. ``IntelNMFirmware``"},{"line_number":93,"context_line":"interface should work in Ironic with ``ipmi*`` drivers and should use"},{"line_number":94,"context_line":"``send_raw()`` method for interactions with a node. ``send_raw()`` method"},{"line_number":95,"context_line":"will be extended and should return response raw data."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Other parameter notes:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa1b9901_d818ad20","line":95,"in_reply_to":"fa1b9901_6f7631da","updated":"2015-08-26 15:53:53.000000000","message":"We can use driver.vendor.send_raw() with ipmi vendor interface.","commit_id":"f771e197d4decb82f74ad9961e984a24e356ac9d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"43c79f1f7b8d205b91ed7c4b50eea10a2bc7cf92","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Other parameter notes:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* Domain ID is always 00h (Entire platform)."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"* The driver uses one Policy ID."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_a5ee1389","line":103,"updated":"2015-09-11 14:55:44.000000000","message":"Please clarify what the domain id is.","commit_id":"6e3fb5b040e1e9419b477ec50ef47e0be69d3306"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"24d2d58b3c03174718aafc3fd0db68e5c7758392","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Other parameter notes:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* Domain ID is always 00h (Entire platform)."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"* The driver uses one Policy ID."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_a44b002b","line":103,"in_reply_to":"da20952f_a5ee1389","updated":"2015-09-14 09:13:05.000000000","message":"Done","commit_id":"6e3fb5b040e1e9419b477ec50ef47e0be69d3306"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"43c79f1f7b8d205b91ed7c4b50eea10a2bc7cf92","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"* The driver uses one Policy ID."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* Policy storage is persistent."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Policy lifecycle:"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_c5e786e1","line":107,"updated":"2015-09-11 14:55:44.000000000","message":"IIUC operator does not have to do anything about it as it is managed by NM, please mention it.","commit_id":"6e3fb5b040e1e9419b477ec50ef47e0be69d3306"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"24d2d58b3c03174718aafc3fd0db68e5c7758392","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"* The driver uses one Policy ID."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* Policy storage is persistent."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Policy lifecycle:"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_241290b5","line":107,"in_reply_to":"da20952f_c5e786e1","updated":"2015-09-14 09:13:05.000000000","message":"Sorry, do not fully understand your suggestion. Policy storage option for NM can be persistent or non-persistent. If policy storage is persistent applied policies stored into NVRAM, and operator should know about this feature and he/she should not re-apply policies after reset.","commit_id":"6e3fb5b040e1e9419b477ec50ef47e0be69d3306"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"43c79f1f7b8d205b91ed7c4b50eea10a2bc7cf92","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Other deployer impact"},{"line_number":168,"context_line":"---------------------"},{"line_number":169,"context_line":"New config option ``policy_id`` will be added, it\u0027s Policy ID that the driver"},{"line_number":170,"context_line":"uses."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_6596ba95","line":169,"updated":"2015-09-11 14:55:44.000000000","message":"But then if several drivers are enabled on a conductor, they will have to use the same policy?","commit_id":"6e3fb5b040e1e9419b477ec50ef47e0be69d3306"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"24d2d58b3c03174718aafc3fd0db68e5c7758392","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Other deployer impact"},{"line_number":168,"context_line":"---------------------"},{"line_number":169,"context_line":"New config option ``policy_id`` will be added, it\u0027s Policy ID that the driver"},{"line_number":170,"context_line":"uses."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_04cf4cb1","line":169,"in_reply_to":"da20952f_6596ba95","updated":"2015-09-14 09:13:05.000000000","message":"Policy is a set of parameters for the node, so is not a problem to have policies wit the same ID for different nodes. If we use the same ID for one of nodes, new parameters overwrite the existing, no new policy will be created.","commit_id":"6e3fb5b040e1e9419b477ec50ef47e0be69d3306"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"fb1f76d850ab7eb0849da8e8a44ce4048c733d9a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  that Intel NM policy applies to (01h - CPU subsystem, 02h – memory"},{"line_number":105,"context_line":"  subsystem for example)."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* The driver uses one Policy ID."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* Policy storage is persistent."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa80f949_baf2c7d0","line":107,"updated":"2015-11-05 16:47:53.000000000","message":"AFAIU the Policy ID is unique over all domains, so there are possible to apply only one policy at time, can I enable diff policy for diff domains? Maybe it would be better to specify policy id in request, parameters for which one would be assigned?","commit_id":"96ddbb59e4923223a5ddbed510ee373949aae5a3"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"4785cdf8c6058c226ce3e3848c87688463faa70e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  that Intel NM policy applies to (01h - CPU subsystem, 02h – memory"},{"line_number":105,"context_line":"  subsystem for example)."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* The driver uses one Policy ID."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* Policy storage is persistent."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa80f949_b684025e","line":107,"in_reply_to":"fa80f949_7310ec59","updated":"2015-11-06 09:54:39.000000000","message":"got it, thanks for clarification","commit_id":"96ddbb59e4923223a5ddbed510ee373949aae5a3"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b6eff09ceafbee9833759aa7b5821cc72d6a8ed5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  that Intel NM policy applies to (01h - CPU subsystem, 02h – memory"},{"line_number":105,"context_line":"  subsystem for example)."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* The driver uses one Policy ID."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* Policy storage is persistent."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa80f949_7310ec59","line":107,"in_reply_to":"fa80f949_baf2c7d0","updated":"2015-11-06 09:51:42.000000000","message":"Anton, Intel NM specification defines these types of domains:\n\n 00h Entire platform\n 01h CPU subsystem\n 02h Memory subsystem\n 03h Reserved\n 04h High Power I/O subsystem\n\nI think entire platform policies covers most of use cases for cloud administrators, so first version of driver will support only 00 domain. Domain selection can be added in the future (if someone wants it). Possible issues can be detected only during tests on real hardware.","commit_id":"96ddbb59e4923223a5ddbed510ee373949aae5a3"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"3fb56c43462afd2b9fc027da84f1ab50d7507769","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        :param task: the ironic task used to identify the node."},{"line_number":50,"context_line":"        :param kwargs: a dict of parameters for policy control"},{"line_number":51,"context_line":"                       {"},{"line_number":52,"context_line":"                         # Global, per domain, per polycy control"},{"line_number":53,"context_line":"                         # True as value is enable, False is disable."},{"line_number":54,"context_line":"                         \u0027global\u0027: value1,"},{"line_number":55,"context_line":"                         \u0027domain\u0027: value2,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"ba8a016a_64ddb641","line":52,"updated":"2015-11-24 11:21:23.000000000","message":"policy","commit_id":"8ca0997122d79f81183f461d23c5d04efa83a5c2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"14c675bbb45d575bb8be1e1ae08dec11a909635c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        :param task: the ironic task used to identify the node."},{"line_number":50,"context_line":"        :param kwargs: a dict of parameters for policy control"},{"line_number":51,"context_line":"                       {"},{"line_number":52,"context_line":"                         # Global, per domain, per polycy control"},{"line_number":53,"context_line":"                         # True as value is enable, False is disable."},{"line_number":54,"context_line":"                         \u0027global\u0027: value1,"},{"line_number":55,"context_line":"                         \u0027domain\u0027: value2,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a8ffd7b_557c3c20","line":52,"in_reply_to":"ba8a016a_64ddb641","updated":"2015-11-24 11:39:49.000000000","message":"Done","commit_id":"8ca0997122d79f81183f461d23c5d04efa83a5c2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6fb78c0ee7be3d5ea11bf241d22cc63c790d495c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* Standard via driver management interface properties API. Properties names and"},{"line_number":35,"context_line":"  parameters will be compatible with standard DCMI limits spec"},{"line_number":36,"context_line":"  (https://review.openstack.org/#/c/251957/). Both \u0027limit_power\u0027 and"},{"line_number":37,"context_line":"  \u0027limit_thermal\u0027 properties will be supported. New ``IPMI_IntelNMManagement``"},{"line_number":38,"context_line":"  interface will be implemented. Limits method will use Intel Node Manager IPMI"},{"line_number":39,"context_line":"  command set."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_c53b8e37","line":37,"updated":"2015-12-09 16:40:23.000000000","message":"IIUC there is no need for it as DCMI may be used directly? (so dcmi management interface can be used?) And if so, there may be a problem that needs to be clarified in this spec - power and termal limits that are created using dcmi can not be altered by node manager vendor passthru, only via dcmi.","commit_id":"c6c0af176c494ddc11c9b83f2ad3c505e80f93bb"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"25c53bb963ba452313009195c72dc5a3f9dc47c0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* Standard via driver management interface properties API. Properties names and"},{"line_number":35,"context_line":"  parameters will be compatible with standard DCMI limits spec"},{"line_number":36,"context_line":"  (https://review.openstack.org/#/c/251957/). Both \u0027limit_power\u0027 and"},{"line_number":37,"context_line":"  \u0027limit_thermal\u0027 properties will be supported. New ``IPMI_IntelNMManagement``"},{"line_number":38,"context_line":"  interface will be implemented. Limits method will use Intel Node Manager IPMI"},{"line_number":39,"context_line":"  command set."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_3bbda3d7","line":37,"in_reply_to":"7a740942_c53b8e37","updated":"2015-12-10 13:24:54.000000000","message":"There is no problem. New management interface methods for Intel NM will use native vendor-specific NM command for standard limits. Intel or DCMI driver can be used for a node, not both.","commit_id":"c6c0af176c494ddc11c9b83f2ad3c505e80f93bb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6fb78c0ee7be3d5ea11bf241d22cc63c790d495c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                         # Global, per domain, per policy control"},{"line_number":55,"context_line":"                         # True as value is enable, False is disable."},{"line_number":56,"context_line":"                         \u0027global\u0027: value1,"},{"line_number":57,"context_line":"                         \u0027domain\u0027: value2,"},{"line_number":58,"context_line":"                         \u0027policy\u0027: value3,"},{"line_number":59,"context_line":"                         # Domain ID. One of \u0027platform\u0027, \u0027cpu\u0027, \u0027memory\u0027, \u0027io\u0027."},{"line_number":60,"context_line":"                         \u0027domain_id\u0027: value4,"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_45031e0e","line":57,"updated":"2015-12-09 16:40:23.000000000","message":"What do these \u0027domain\u0027 and \u0027policy\u0027 values refer to? Is it meant to be \u0027per_domain\u0027 and \u0027per_policy\u0027 with boolean values?","commit_id":"c6c0af176c494ddc11c9b83f2ad3c505e80f93bb"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"25c53bb963ba452313009195c72dc5a3f9dc47c0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                         # Global, per domain, per policy control"},{"line_number":55,"context_line":"                         # True as value is enable, False is disable."},{"line_number":56,"context_line":"                         \u0027global\u0027: value1,"},{"line_number":57,"context_line":"                         \u0027domain\u0027: value2,"},{"line_number":58,"context_line":"                         \u0027policy\u0027: value3,"},{"line_number":59,"context_line":"                         # Domain ID. One of \u0027platform\u0027, \u0027cpu\u0027, \u0027memory\u0027, \u0027io\u0027."},{"line_number":60,"context_line":"                         \u0027domain_id\u0027: value4,"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_0d0c2a3a","line":57,"in_reply_to":"7a740942_45031e0e","updated":"2015-12-10 13:24:54.000000000","message":"If parameter is true user can specify Domain ID or Policy ID. I think names are correct here in this context.","commit_id":"c6c0af176c494ddc11c9b83f2ad3c505e80f93bb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6fb78c0ee7be3d5ea11bf241d22cc63c790d495c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        :param kwargs: a dict of parameters for a policy"},{"line_number":73,"context_line":"                       {"},{"line_number":74,"context_line":"                         # Domain ID. One of \u0027platform\u0027, \u0027cpu\u0027, \u0027memory\u0027, \u0027io\u0027."},{"line_number":75,"context_line":"                         \u0027domain_id\u0027: value1,"},{"line_number":76,"context_line":"                         # Policy enabled - True, disabled - False."},{"line_number":77,"context_line":"                         \u0027enabled\u0027: value2,"},{"line_number":78,"context_line":"                         # Policy ID."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_c5c06e7f","line":75,"updated":"2015-12-09 16:40:23.000000000","message":"So the policy can be specified for any domain? (IIRC if was only whole system policies in earlier patch sets)","commit_id":"c6c0af176c494ddc11c9b83f2ad3c505e80f93bb"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"25c53bb963ba452313009195c72dc5a3f9dc47c0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        :param kwargs: a dict of parameters for a policy"},{"line_number":73,"context_line":"                       {"},{"line_number":74,"context_line":"                         # Domain ID. One of \u0027platform\u0027, \u0027cpu\u0027, \u0027memory\u0027, \u0027io\u0027."},{"line_number":75,"context_line":"                         \u0027domain_id\u0027: value1,"},{"line_number":76,"context_line":"                         # Policy enabled - True, disabled - False."},{"line_number":77,"context_line":"                         \u0027enabled\u0027: value2,"},{"line_number":78,"context_line":"                         # Policy ID."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_6d34cedd","line":75,"in_reply_to":"7a740942_c5c06e7f","updated":"2015-12-10 13:24:54.000000000","message":"Yes.","commit_id":"c6c0af176c494ddc11c9b83f2ad3c505e80f93bb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6fb78c0ee7be3d5ea11bf241d22cc63c790d495c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                         # Policy power domain, \u0027primary\u0027 or \u0027secondary\u0027."},{"line_number":204,"context_line":"                         \u0027power_domain\u0027: value3,"},{"line_number":205,"context_line":"                       }"},{"line_number":206,"context_line":"        :return: a dict containing Intel NM capabilities for a node."},{"line_number":207,"context_line":"        \"\"\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @base.passthru([\u0027GET\u0027], async\u003dFalse)"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_82e33c33","line":206,"updated":"2015-12-09 16:40:23.000000000","message":"Might be good to clarify what it contains - depending on the policy trigger type it is maximum/minimum values for limits (power consumption, temperature, time after reset, ...)","commit_id":"c6c0af176c494ddc11c9b83f2ad3c505e80f93bb"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"25c53bb963ba452313009195c72dc5a3f9dc47c0","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                         # Policy power domain, \u0027primary\u0027 or \u0027secondary\u0027."},{"line_number":204,"context_line":"                         \u0027power_domain\u0027: value3,"},{"line_number":205,"context_line":"                       }"},{"line_number":206,"context_line":"        :return: a dict containing Intel NM capabilities for a node."},{"line_number":207,"context_line":"        \"\"\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @base.passthru([\u0027GET\u0027], async\u003dFalse)"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_adb0768c","line":206,"in_reply_to":"7a740942_82e33c33","updated":"2015-12-10 13:24:54.000000000","message":"Done","commit_id":"c6c0af176c494ddc11c9b83f2ad3c505e80f93bb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6fb78c0ee7be3d5ea11bf241d22cc63c790d495c","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Other deployer impact"},{"line_number":268,"context_line":"---------------------"},{"line_number":269,"context_line":"New config option ``policy_id`` will be added, it\u0027s Policy ID that the driver"},{"line_number":270,"context_line":"will use for standard management properties interface."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_22b5a8cf","line":269,"updated":"2015-12-09 16:40:23.000000000","message":"The fact that existing policy can be rewritten after \u0027set\u0027 in most cases should be clarified somewhere. Also, all the methods contain policy_id field, so in fact any policy id can be specified. Should this config option be removed? Or should policy_id be removed from all methods\u0027 kwargs?","commit_id":"c6c0af176c494ddc11c9b83f2ad3c505e80f93bb"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"25c53bb963ba452313009195c72dc5a3f9dc47c0","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Other deployer impact"},{"line_number":268,"context_line":"---------------------"},{"line_number":269,"context_line":"New config option ``policy_id`` will be added, it\u0027s Policy ID that the driver"},{"line_number":270,"context_line":"will use for standard management properties interface."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_0df66af9","line":269,"in_reply_to":"7a740942_22b5a8cf","updated":"2015-12-10 13:24:54.000000000","message":"This is \"reserved\" ID. Vendor methods should return error if reserved value is used.","commit_id":"c6c0af176c494ddc11c9b83f2ad3c505e80f93bb"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"fa66739186a173faf2b1f1a5961225a478635743","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                         # \u0027temperature\u0027 - temperature limit, \u0027power\u0027 - power"},{"line_number":82,"context_line":"                         # reading timeout, \u0027reset\u0027 - time after reset,"},{"line_number":83,"context_line":"                         # \u0027boot\u0027 - boot time policy."},{"line_number":84,"context_line":"                         \u0027policy_trigger\u0027: value4,"},{"line_number":85,"context_line":"                         # CPU power correction, one of \u0027auto\u0027, \u0027unaggressive\u0027,"},{"line_number":86,"context_line":"                         # \u0027aggressive\u0027."},{"line_number":87,"context_line":"                         \u0027cpu_power_correction\u0027: value5,"}],"source_content_type":"text/x-rst","patch_set":25,"id":"3a7e1126_e22bd5e9","line":84,"updated":"2015-12-17 22:22:31.000000000","message":"Seems following is missing:\n\"[4] – Policy Configuration Action\n\u003d0 – Policy Pointed by Policy Id shall be removed (remaining bytes\nshall be ignored on read). Corresponding (with the same Policy Id)\nAlert Thresholds and Suspend Periods will be removed as well.\n\u003d1 – Add Power Policy. This command creates/modifies policy of\ntype that will maintain Power limit.\"","commit_id":"db25000823eb75ecf0ba1160ff6602ecea01515c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"506d8cc914eae57c6ebc7382e58ee97d406dbce4","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                         # \u0027temperature\u0027 - temperature limit, \u0027power\u0027 - power"},{"line_number":82,"context_line":"                         # reading timeout, \u0027reset\u0027 - time after reset,"},{"line_number":83,"context_line":"                         # \u0027boot\u0027 - boot time policy."},{"line_number":84,"context_line":"                         \u0027policy_trigger\u0027: value4,"},{"line_number":85,"context_line":"                         # CPU power correction, one of \u0027auto\u0027, \u0027unaggressive\u0027,"},{"line_number":86,"context_line":"                         # \u0027aggressive\u0027."},{"line_number":87,"context_line":"                         \u0027cpu_power_correction\u0027: value5,"}],"source_content_type":"text/x-rst","patch_set":25,"id":"3a7e1126_0410554d","line":84,"in_reply_to":"3a7e1126_e22bd5e9","updated":"2015-12-18 10:30:41.000000000","message":"Good question, but it\u0027s not missing. I try to make NM vendor API more \"RESTful\". Ironic vendors\u0027 API supports different CRUD HTTP methods, please look at \"@base.passthru([\u0027PUT\u0027])\" decorator l67 for example. For removing HTTP \"DELETE\" with vendor\u0027s method name \"remove_nm_policy\" used (l121). Refs: http://docs.openstack.org/developer/ironic/dev/vendor-passthru.html#writing-vendor-methods , http://www.restapitutorial.com/lessons/httpmethods.html","commit_id":"db25000823eb75ecf0ba1160ff6602ecea01515c"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"fa66739186a173faf2b1f1a5961225a478635743","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                       }"},{"line_number":172,"context_line":"        :returns: a dict containing policy suspend periods."},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @base.passthru([\u0027DELETE\u0027])"},{"line_number":176,"context_line":"    def remove_nm_policy_suspend(self, task, **kwargs):"},{"line_number":177,"context_line":"        \"\"\"Remove Intel NM policy suspend periods."}],"source_content_type":"text/x-rst","patch_set":25,"id":"3a7e1126_88455318","line":174,"updated":"2015-12-17 22:22:31.000000000","message":"Will you add more methods like \"Reset Node Manager Statistics\", or \"Get Node Manager Statistics\", or they are covered by \"Standard via driver management interface properties API\"?","commit_id":"db25000823eb75ecf0ba1160ff6602ecea01515c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"506d8cc914eae57c6ebc7382e58ee97d406dbce4","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                       }"},{"line_number":172,"context_line":"        :returns: a dict containing policy suspend periods."},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @base.passthru([\u0027DELETE\u0027])"},{"line_number":176,"context_line":"    def remove_nm_policy_suspend(self, task, **kwargs):"},{"line_number":177,"context_line":"        \"\"\"Remove Intel NM policy suspend periods."}],"source_content_type":"text/x-rst","patch_set":25,"id":"3a7e1126_84a525b6","line":174,"in_reply_to":"3a7e1126_88455318","updated":"2015-12-18 10:30:41.000000000","message":"Yes, but they are not related to these specs. Mentioned features should be part of Ironic and Ceilometer integration and require a new spec.","commit_id":"db25000823eb75ecf0ba1160ff6602ecea01515c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"82ac75751d91e3b2f36365a38662869bd1d965bf","unresolved":false,"context_lines":[{"line_number":301,"context_line":"* Implement ``IntelNMVendorPassthru``."},{"line_number":302,"context_line":"* Create unit tests."},{"line_number":303,"context_line":"* Add documentation."},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"Dependencies"},{"line_number":306,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"fa0719c6_a1ac0ea1","line":304,"updated":"2016-03-22 22:23:14.000000000","message":"I think you\u0027re missing a step -- won\u0027t you need to make a new set of drivers that will utilize the new management interface implementation you\u0027re making?","commit_id":"52140b5d54c637606d7f88142077bfbe6b0f805c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"50d43375f26a9fb87e0392fed755da7e08f06620","unresolved":false,"context_lines":[{"line_number":301,"context_line":"* Implement ``IntelNMVendorPassthru``."},{"line_number":302,"context_line":"* Create unit tests."},{"line_number":303,"context_line":"* Add documentation."},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"Dependencies"},{"line_number":306,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"9a061dce_4096c9f0","line":304,"in_reply_to":"fa0719c6_a1ac0ea1","updated":"2016-04-06 08:56:26.000000000","message":"Done","commit_id":"52140b5d54c637606d7f88142077bfbe6b0f805c"}]}
