)]}'
{"specs/approved/inband-raid-configuration.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d87cf21aeea1b2a505463854433a97a91afb32c9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    steps belonging to the ``raid`` interface.  It will change the priority"},{"line_number":52,"context_line":"    of the raid clean steps returned by the agent ramdisk to 0 and then send it"},{"line_number":53,"context_line":"    to the conductor.  An empty list is returned if agent ramdisk returns an"},{"line_number":54,"context_line":"    empty list for steps belonging to the ``raid`` interface."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* RAID configuration will be limited to zapping for now."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_ec48932f","line":54,"updated":"2015-09-10 22:12:18.000000000","message":"You changed it so that this doesn\u0027t happen. It knows the clean steps via the decorator, which sets the priority to 0.","commit_id":"78edfb3e8fda3046db4724fdceff1bccdf681a49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d87cf21aeea1b2a505463854433a97a91afb32c9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  ``agent_base_vendor.post_clean_step_hook`` will be added for driver"},{"line_number":64,"context_line":"  implementors wishing to do something after an in-band clean step is"},{"line_number":65,"context_line":"  done (in normal case, Ironic conductor will poll the status of the last"},{"line_number":66,"context_line":"  in-band clean step and resume cleaning with the next clean step). Driver"},{"line_number":67,"context_line":"  implementors can just decorate a method with this decorator and it will be"},{"line_number":68,"context_line":"  invoked on the successful completion of the clean step.  The decorated"},{"line_number":69,"context_line":"  method would recieve ``task`` argument and the command status sent by agent"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_ec92d356","line":66,"updated":"2015-09-10 22:12:18.000000000","message":"No need for the stuff in parentheses, you already mentioned it above.","commit_id":"78edfb3e8fda3046db4724fdceff1bccdf681a49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d87cf21aeea1b2a505463854433a97a91afb32c9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  in-band clean step and resume cleaning with the next clean step). Driver"},{"line_number":67,"context_line":"  implementors can just decorate a method with this decorator and it will be"},{"line_number":68,"context_line":"  invoked on the successful completion of the clean step.  The decorated"},{"line_number":69,"context_line":"  method would recieve ``task`` argument and the command status sent by agent"},{"line_number":70,"context_line":"  ramdisk."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  For example::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_cc7caf22","line":69,"updated":"2015-09-10 22:12:18.000000000","message":"s/recieve/receive/","commit_id":"78edfb3e8fda3046db4724fdceff1bccdf681a49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d87cf21aeea1b2a505463854433a97a91afb32c9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  implementors can just decorate a method with this decorator and it will be"},{"line_number":68,"context_line":"  invoked on the successful completion of the clean step.  The decorated"},{"line_number":69,"context_line":"  method would recieve ``task`` argument and the command status sent by agent"},{"line_number":70,"context_line":"  ramdisk."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  For example::"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_ecd893f1","line":70,"updated":"2015-09-10 22:12:18.000000000","message":"How about\n\nWhen the agent ramdisk is running an in-band clean step, the conductor gets the status of the last in-band clean step on every heartbeat. When an in-band clean step completes, the conductor resumes the cleaning and goes on to the next clean step if any. A new mechanism -- the agent_base_vendor.post_clean_step_hook decorator, will be added. This allows a driver implementor to specify a function to be invoked after successful completion of an in-band clean step (and before the next clean step is started).\nThe decorated function would take two arguments: the task and the command status (of the clean step) returned by the agent ramdisk.","commit_id":"78edfb3e8fda3046db4724fdceff1bccdf681a49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d87cf21aeea1b2a505463854433a97a91afb32c9","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* A method ``agent._create_configuration_final`` will be added as a post clean"},{"line_number":79,"context_line":"  step hook for ``raid.create_configuration``. ``update_raid_info`` will be"},{"line_number":80,"context_line":"  called in this method with the actual RAID configuration returned from the"},{"line_number":81,"context_line":"  agent ramdisk."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* A method ``agent._delete_configuration_final`` will be added as a post clean"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_0c9b8718","line":80,"updated":"2015-09-10 22:12:18.000000000","message":"Maybe \u0027This method will call update_raid_info() with the actual ...\u0027","commit_id":"78edfb3e8fda3046db4724fdceff1bccdf681a49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d87cf21aeea1b2a505463854433a97a91afb32c9","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* A method ``agent._delete_configuration_final`` will be added as a post clean"},{"line_number":84,"context_line":"  step hook for ``raid.delete_configuration``. This will set"},{"line_number":85,"context_line":"  ``node.target_raid_configuration`` to ``None``."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Alternatives"},{"line_number":88,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_0c6947f8","line":85,"updated":"2015-09-10 22:12:18.000000000","message":"I don\u0027t see the reason for setting it to None. It can be the target raid configuration for some subsequent create. Even if it isn\u0027t used again, this is something that the user specified, so I don\u0027t see why we\u0027d clear it.\n\n(We should clear node.raid_config though.)","commit_id":"78edfb3e8fda3046db4724fdceff1bccdf681a49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d87cf21aeea1b2a505463854433a97a91afb32c9","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  ``node.target_raid_configuration`` to ``None``."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Alternatives"},{"line_number":88,"context_line":"------------"},{"line_number":89,"context_line":"One alternative implementation possible is to decorate the methods"},{"line_number":90,"context_line":"``AgentRAID.create_configuration`` and ``AgentRAID.delete_configuration``."},{"line_number":91,"context_line":"This will cause the ``raid.create_configuration`` and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_4c317f0a","line":88,"updated":"2015-09-10 22:12:18.000000000","message":"What was wrong with the original alternative?","commit_id":"78edfb3e8fda3046db4724fdceff1bccdf681a49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d87cf21aeea1b2a505463854433a97a91afb32c9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"the ``GET /v1/nodes/NNNN/clean_steps`` will return"},{"line_number":97,"context_line":"``raid.create_configuration`` and ``raid.delete_configuration`` as a possible"},{"line_number":98,"context_line":"clean step.  This might be misleading to the operator and in-consistent with"},{"line_number":99,"context_line":"other in-band clean step implementation."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Data model impact"},{"line_number":102,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_2c13eb66","line":99,"updated":"2015-09-10 22:12:18.000000000","message":"If I am not mistaken, I think you decided to code it this way, right? with the clean_step decorator?","commit_id":"78edfb3e8fda3046db4724fdceff1bccdf681a49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d87cf21aeea1b2a505463854433a97a91afb32c9","unresolved":false,"context_lines":[{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"* Implement the mechanism for post clean step hook."},{"line_number":182,"context_line":"* Implement ``AgentRAID``"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Dependencies"},{"line_number":185,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_4f2651bb","line":182,"updated":"2015-09-10 22:12:18.000000000","message":"The spec is meant to describe what is needed for that feature. Not what is left to do at the time you update the spec :)","commit_id":"78edfb3e8fda3046db4724fdceff1bccdf681a49"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f28c094a7e9b520cb1be127e437fa55509def07a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  configuration.  When software RAID configuration is done, agent based"},{"line_number":66,"context_line":"  ``raid.create_config`` should be used as a clean step so that software RAID"},{"line_number":67,"context_line":"  is configured everytime after a secure disk erase (which wipes out the"},{"line_number":68,"context_line":"  previous software RAID configuration if it exists)."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_146617bb","side":"PARENT","line":68,"updated":"2015-09-11 13:34:46.000000000","message":"I don\u0027t think we should remove the bits talking about software raid. When I was reading the changes I was thinking only about hardware raid and that raised a lot of confusion in my mind when I looked at the code [1] and saw the raid interface being added to drivers such as agent_ssh, agent_vbox\n\n[1] https://review.openstack.org/#/c/198238/25/ironic/drivers/agent.py","commit_id":"64143911a55b07f04113536fb561f3d99a1bace7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f28c094a7e9b520cb1be127e437fa55509def07a","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* RAID configuration will be limited to zapping at first, we\u0027ll consider"},{"line_number":51,"context_line":"  interaction with cleaning mechanism later. This allows us to make"},{"line_number":52,"context_line":"  ``target_raid_config`` mandatory for the new clean steps."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* When the agent ramdisk is running an in-band clean step, the conductor gets"},{"line_number":55,"context_line":"  the status of the last in-band clean step on every heartbeat. When an in-band"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_d6366702","line":52,"updated":"2015-09-11 13:34:46.000000000","message":"This paragraph confuses me, all the other changes are talking about doing raid as part of cleaning.\n\nSpecifically the \"RAID configuration will be limited to zapping at first, we\u0027ll consider interaction with cleaning mechanism later\" bits.\n\nit sounds like RAID will be only implemented as zapping steps and not as cleaning steps, which is controversial because the rest of the spec talks about RAID as cleaning steps. Or what it\u0027s meant to say is that RAID as part of cleaning is disabled by default?","commit_id":"345c512814e210d149d4a1ca5d41448c722e90db"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2fa380cbfff85842f2c6c3f72b010114189076bb","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* It is possible to have a hardware manager that does software RAID"},{"line_number":82,"context_line":"  configuration, but it goes beyond the scope of this spec, as it requires"},{"line_number":83,"context_line":"  RAID configuration to be run as a clean step after disc erasure."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba15a1d1_ce1ac317","line":83,"updated":"2015-09-14 15:19:26.000000000","message":"s/disc/disk","commit_id":"52849ebbee757145b67473fa95f76fbedf733be7"}]}