)]}'
{"specs/approved/agent-image-proxy.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a68497d58151670063ba900f81d015065616badc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  driver proxy parameter is set agent driver adds ``image_proxy`` parameter to"},{"line_number":37,"context_line":"  agent\u0027s kernel command line with a value (URL of proxy)."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Before image downloading IPA try to get ``image_proxy`` parameter. If it\u0027s"},{"line_number":40,"context_line":"present IPA adds ``proxies`` to requests.get() method."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Swift Temporary URL changes:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba15a1d1_c0aff929","line":39,"updated":"2015-09-21 08:40:03.000000000","message":"How does it get the parameter? Is it via kernel command line?","commit_id":"310c31b527a70dfbaeb2e66f6b772768d499d61d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"69779ee5b2cea3b448341b4e9d8f678f1b3ae144","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  driver proxy parameter is set agent driver adds ``image_proxy`` parameter to"},{"line_number":37,"context_line":"  agent\u0027s kernel command line with a value (URL of proxy)."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Before image downloading IPA try to get ``image_proxy`` parameter. If it\u0027s"},{"line_number":40,"context_line":"present IPA adds ``proxies`` to requests.get() method."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Swift Temporary URL changes:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba15a1d1_97862264","line":39,"in_reply_to":"ba15a1d1_c0aff929","updated":"2015-09-21 11:01:13.000000000","message":"Yes. Done.","commit_id":"310c31b527a70dfbaeb2e66f6b772768d499d61d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a68497d58151670063ba900f81d015065616badc","unresolved":false,"context_lines":[{"line_number":45,"context_line":"conductor. New config parameter ``swift_temp_url_cachetime`` will be added to"},{"line_number":46,"context_line":"``glance`` group. When a temporary URL for image is created agent driver"},{"line_number":47,"context_line":"stores it into the cache with UUID of Glance image as a key. Agent driver uses"},{"line_number":48,"context_line":"URL from cache for same UUIDs and checks expiration of temporary URLs."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Notes about proxy service:"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba15a1d1_e0ac7d37","line":48,"updated":"2015-09-21 08:40:03.000000000","message":"I\u0027m not sure how this change is related to proxy support, could you elaborate?","commit_id":"310c31b527a70dfbaeb2e66f6b772768d499d61d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"69779ee5b2cea3b448341b4e9d8f678f1b3ae144","unresolved":false,"context_lines":[{"line_number":45,"context_line":"conductor. New config parameter ``swift_temp_url_cachetime`` will be added to"},{"line_number":46,"context_line":"``glance`` group. When a temporary URL for image is created agent driver"},{"line_number":47,"context_line":"stores it into the cache with UUID of Glance image as a key. Agent driver uses"},{"line_number":48,"context_line":"URL from cache for same UUIDs and checks expiration of temporary URLs."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Notes about proxy service:"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba15a1d1_77ed8e8d","line":48,"in_reply_to":"ba15a1d1_e0ac7d37","updated":"2015-09-21 11:01:13.000000000","message":"Done","commit_id":"310c31b527a70dfbaeb2e66f6b772768d499d61d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0d3adde56c3a987304275d19e2cbfb8c339eb2ab","unresolved":false,"context_lines":[{"line_number":40,"context_line":"kernel command line. If it\u0027s present IPA adds ``proxies`` to requests.get()"},{"line_number":41,"context_line":"method."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Swift Temporary URL changes:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"For caching proxies different URLs are mapped to different files in the cache."},{"line_number":46,"context_line":"Therefore caching of Swift Temporary URLs for images should be implemented on"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a1a9d01_f280dcf9","line":43,"updated":"2015-10-01 18:17:10.000000000","message":"Why is this included in this spec? It feels like an entirely different feature.","commit_id":"fcc463afa6b80c3af9219f6445a3e20887245d5b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"4ef4d80f987be0fedb67695e470e6e604e5c4171","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Swift Temporary URL changes:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"For caching proxies different URLs are mapped to different files in the cache."},{"line_number":46,"context_line":"Therefore caching of Swift Temporary URLs for images should be implemented on"},{"line_number":47,"context_line":"the conductor. New config parameter ``swift_temp_url_cachetime`` will be added"},{"line_number":48,"context_line":"to ``glance`` group. When a temporary URL for image is created agent driver"},{"line_number":49,"context_line":"stores it into the cache with UUID of Glance image as a key. Agent driver uses"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a1a9d01_e4429ead","line":46,"updated":"2015-09-30 13:39:49.000000000","message":"Please elaborate a bit more - IIUC URLs will be different because expiration time is contained in temp url \u003d\u003e it will be different for all deployments.","commit_id":"fcc463afa6b80c3af9219f6445a3e20887245d5b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"4ef4d80f987be0fedb67695e470e6e604e5c4171","unresolved":false,"context_lines":[{"line_number":126,"context_line":"* Two new optional parameters will be added for agent deploy driver in the"},{"line_number":127,"context_line":"  node.driver_info: ``image_http_proxy`` and ``image_https_proxy``."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* A new config option ``swift_temp_url_cachetime`` will be added in ``glance``"},{"line_number":130,"context_line":"  group."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* Deployer must install and configure proxy service(s)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a1a9d01_44858acc","line":129,"updated":"2015-09-30 13:39:49.000000000","message":"Can\u0027t we just use expiration time from temp url instead (maybe minus some additional time during which agent will be booting)?","commit_id":"fcc463afa6b80c3af9219f6445a3e20887245d5b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"628f5ce928eac7c03e71f12459bb30fd3338c835","unresolved":false,"context_lines":[{"line_number":126,"context_line":"* Two new optional parameters will be added for agent deploy driver in the"},{"line_number":127,"context_line":"  node.driver_info: ``image_http_proxy`` and ``image_https_proxy``."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* A new config option ``swift_temp_url_cachetime`` will be added in ``glance``"},{"line_number":130,"context_line":"  group."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* Deployer must install and configure proxy service(s)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a1a9d01_b411d0b1","line":129,"in_reply_to":"9a1a9d01_44858acc","updated":"2015-10-02 13:04:35.000000000","message":"IMO this new parameter can be used also for on/off the feature.","commit_id":"fcc463afa6b80c3af9219f6445a3e20887245d5b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"01115885f9f157a40a9bdf00b1adbd05d0d27b87","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently Ironic Python Agent (IPA) is able to download images via direct"},{"line_number":20,"context_line":"HTTP(S) links, but it does not support proxy configuration. If IPA will support"},{"line_number":21,"context_line":"proxy configuration for images downloading user can place caching proxies in"},{"line_number":22,"context_line":"same physical network segments as nodes for reducing owerall network traffic"},{"line_number":23,"context_line":"and deploying time."},{"line_number":24,"context_line":"There are two different types of image source when Ironic does deploy with"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_4474d634","line":21,"updated":"2015-10-08 15:50:28.000000000","message":"s/images/image/","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"90dcd0dd1ba22d64bd6ffe3927674ad727619426","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently Ironic Python Agent (IPA) is able to download images via direct"},{"line_number":20,"context_line":"HTTP(S) links, but it does not support proxy configuration. If IPA will support"},{"line_number":21,"context_line":"proxy configuration for images downloading user can place caching proxies in"},{"line_number":22,"context_line":"same physical network segments as nodes for reducing owerall network traffic"},{"line_number":23,"context_line":"and deploying time."},{"line_number":24,"context_line":"There are two different types of image source when Ironic does deploy with"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_65b9a2cb","line":21,"in_reply_to":"7a2fa921_4474d634","updated":"2015-10-09 13:53:16.000000000","message":"Done","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"01115885f9f157a40a9bdf00b1adbd05d0d27b87","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Currently Ironic Python Agent (IPA) is able to download images via direct"},{"line_number":20,"context_line":"HTTP(S) links, but it does not support proxy configuration. If IPA will support"},{"line_number":21,"context_line":"proxy configuration for images downloading user can place caching proxies in"},{"line_number":22,"context_line":"same physical network segments as nodes for reducing owerall network traffic"},{"line_number":23,"context_line":"and deploying time."},{"line_number":24,"context_line":"There are two different types of image source when Ironic does deploy with"},{"line_number":25,"context_line":"IPA: Glance UUID and HTTP(S) URL. When HTTP(s) URLs are used we can simple"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_a4a28a97","line":22,"updated":"2015-10-08 15:50:28.000000000","message":"s/same physical/the same physical/","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"90dcd0dd1ba22d64bd6ffe3927674ad727619426","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Currently Ironic Python Agent (IPA) is able to download images via direct"},{"line_number":20,"context_line":"HTTP(S) links, but it does not support proxy configuration. If IPA will support"},{"line_number":21,"context_line":"proxy configuration for images downloading user can place caching proxies in"},{"line_number":22,"context_line":"same physical network segments as nodes for reducing owerall network traffic"},{"line_number":23,"context_line":"and deploying time."},{"line_number":24,"context_line":"There are two different types of image source when Ironic does deploy with"},{"line_number":25,"context_line":"IPA: Glance UUID and HTTP(S) URL. When HTTP(s) URLs are used we can simple"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_a5c33a37","line":22,"in_reply_to":"7a2fa921_a4a28a97","updated":"2015-10-09 13:53:16.000000000","message":"Done","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"01115885f9f157a40a9bdf00b1adbd05d0d27b87","unresolved":false,"context_lines":[{"line_number":21,"context_line":"proxy configuration for images downloading user can place caching proxies in"},{"line_number":22,"context_line":"same physical network segments as nodes for reducing owerall network traffic"},{"line_number":23,"context_line":"and deploying time."},{"line_number":24,"context_line":"There are two different types of image source when Ironic does deploy with"},{"line_number":25,"context_line":"IPA: Glance UUID and HTTP(S) URL. When HTTP(s) URLs are used we can simple"},{"line_number":26,"context_line":"utilize HTTP(S) proxy configuration parameter, additional Ironic features"},{"line_number":27,"context_line":"are not needed. When we use Glance UUIDs there is a problem with Swift"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_c4ad4685","line":24,"updated":"2015-10-08 15:50:28.000000000","message":"s/image source/image sources/","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"90dcd0dd1ba22d64bd6ffe3927674ad727619426","unresolved":false,"context_lines":[{"line_number":21,"context_line":"proxy configuration for images downloading user can place caching proxies in"},{"line_number":22,"context_line":"same physical network segments as nodes for reducing owerall network traffic"},{"line_number":23,"context_line":"and deploying time."},{"line_number":24,"context_line":"There are two different types of image source when Ironic does deploy with"},{"line_number":25,"context_line":"IPA: Glance UUID and HTTP(S) URL. When HTTP(s) URLs are used we can simple"},{"line_number":26,"context_line":"utilize HTTP(S) proxy configuration parameter, additional Ironic features"},{"line_number":27,"context_line":"are not needed. When we use Glance UUIDs there is a problem with Swift"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_05f78e8b","line":24,"in_reply_to":"7a2fa921_c4ad4685","updated":"2015-10-09 13:53:16.000000000","message":"Done","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"01115885f9f157a40a9bdf00b1adbd05d0d27b87","unresolved":false,"context_lines":[{"line_number":22,"context_line":"same physical network segments as nodes for reducing owerall network traffic"},{"line_number":23,"context_line":"and deploying time."},{"line_number":24,"context_line":"There are two different types of image source when Ironic does deploy with"},{"line_number":25,"context_line":"IPA: Glance UUID and HTTP(S) URL. When HTTP(s) URLs are used we can simple"},{"line_number":26,"context_line":"utilize HTTP(S) proxy configuration parameter, additional Ironic features"},{"line_number":27,"context_line":"are not needed. When we use Glance UUIDs there is a problem with Swift"},{"line_number":28,"context_line":"temporary URLs, because current time is used for temporary URLs calculation."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_44d93621","line":25,"updated":"2015-10-08 15:50:28.000000000","message":"s/we can simple/so we can simply/","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"90dcd0dd1ba22d64bd6ffe3927674ad727619426","unresolved":false,"context_lines":[{"line_number":22,"context_line":"same physical network segments as nodes for reducing owerall network traffic"},{"line_number":23,"context_line":"and deploying time."},{"line_number":24,"context_line":"There are two different types of image source when Ironic does deploy with"},{"line_number":25,"context_line":"IPA: Glance UUID and HTTP(S) URL. When HTTP(s) URLs are used we can simple"},{"line_number":26,"context_line":"utilize HTTP(S) proxy configuration parameter, additional Ironic features"},{"line_number":27,"context_line":"are not needed. When we use Glance UUIDs there is a problem with Swift"},{"line_number":28,"context_line":"temporary URLs, because current time is used for temporary URLs calculation."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_e52932e7","line":25,"in_reply_to":"7a2fa921_44d93621","updated":"2015-10-09 13:53:16.000000000","message":"Done","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"01115885f9f157a40a9bdf00b1adbd05d0d27b87","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Two new optional parameters ``image_http_proxy`` and ``image_https_proxy`` will"},{"line_number":37,"context_line":"be added to agent deploy driver. New behavior of agent deploy driver methods:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* get_properties() - returns description of new parameters."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_048a5e1b","line":36,"updated":"2015-10-08 15:50:28.000000000","message":"Please also support \u0027image_no_proxy\u0027","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"90dcd0dd1ba22d64bd6ffe3927674ad727619426","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Two new optional parameters ``image_http_proxy`` and ``image_https_proxy`` will"},{"line_number":37,"context_line":"be added to agent deploy driver. New behavior of agent deploy driver methods:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* get_properties() - returns description of new parameters."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_7105e40e","line":36,"in_reply_to":"7a2fa921_048a5e1b","updated":"2015-10-09 13:53:16.000000000","message":"Added with the name \u0027image_proxy_disable\u0027.","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"01115885f9f157a40a9bdf00b1adbd05d0d27b87","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  driver proxy parameter is set agent driver adds ``image_proxy`` parameter to"},{"line_number":45,"context_line":"  agent\u0027s kernel command line with a value (URL of proxy)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Before image downloading IPA try to get ``image_proxy`` parameter from the"},{"line_number":48,"context_line":"kernel command line. If it\u0027s present IPA adds ``proxies`` to requests.get()"},{"line_number":49,"context_line":"method."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_84418eab","line":47,"updated":"2015-10-08 15:50:28.000000000","message":"s/IPA try/IPA will try/","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"93713d84c0373df93b78e5be02425f1fd73816fc","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  agent\u0027s kernel command line with a value (URL of proxy)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Before image downloading IPA try to get ``image_proxy`` parameter from the"},{"line_number":48,"context_line":"kernel command line. If it\u0027s present IPA adds ``proxies`` to requests.get()"},{"line_number":49,"context_line":"method."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Swift Temporary URL changes:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_f93533f7","line":48,"updated":"2015-10-05 14:32:24.000000000","message":"It may be better to pass it in image_info - https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L379-L393 as it may be more general, and seems to be more consistent with current agent code.","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"90dcd0dd1ba22d64bd6ffe3927674ad727619426","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  agent\u0027s kernel command line with a value (URL of proxy)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Before image downloading IPA try to get ``image_proxy`` parameter from the"},{"line_number":48,"context_line":"kernel command line. If it\u0027s present IPA adds ``proxies`` to requests.get()"},{"line_number":49,"context_line":"method."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Swift Temporary URL changes:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_11083027","line":48,"in_reply_to":"7a2fa921_eac61667","updated":"2015-10-09 13:53:16.000000000","message":"Done","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7ddbb844da8e505499ae7b0e5410d3887e320a9c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  agent\u0027s kernel command line with a value (URL of proxy)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Before image downloading IPA try to get ``image_proxy`` parameter from the"},{"line_number":48,"context_line":"kernel command line. If it\u0027s present IPA adds ``proxies`` to requests.get()"},{"line_number":49,"context_line":"method."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Swift Temporary URL changes:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_eac61667","line":48,"in_reply_to":"7a2fa921_f93533f7","updated":"2015-10-08 13:41:01.000000000","message":"Yup, you can just add something like this in agent driver:\n\n image_info \u003d {\n     ....\n     \u0027proxies\u0027: {\u0027http\u0027: node.driver_info.get(\u0027image_http_proxy\u0027),\n                     \u0027https\u0027: node.driver_info.get(\u0027image_https_proxy\u0027)}\n }\n\nAnd on the agent side:\n\n def _request_url(image_info, url):\n     proxies \u003d image_info.get(\u0027proxies\u0027, {})\n     resp \u003d requests.get(url, stream\u003dTrue, proxies\u003dproxies)\n     ...\n\nIf it is used for image download only, this is a cleaner way.","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6e82d33c8783afc0cec5041c10814bdc983c6e65","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For caching proxies different URLs are mapped to different files in the cache."},{"line_number":54,"context_line":"Therefore caching of Swift Temporary URLs for images should be implemented on"},{"line_number":55,"context_line":"the conductor. New config parameter ``swift_temp_url_cachetime`` will be added"},{"line_number":56,"context_line":"to ``glance`` group. When a temporary URL for image is created agent driver"},{"line_number":57,"context_line":"stores it into the cache with UUID of Glance image as a key. Agent driver uses"},{"line_number":58,"context_line":"URL from cache for same UUIDs and checks expiration of temporary URLs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_90a58605","line":55,"updated":"2015-10-05 08:55:31.000000000","message":"Is swift_temp_url_cachetime a boolean variable?\n\nHow would the safe enough time to use the cached tempurl be computed by driver?","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"90dcd0dd1ba22d64bd6ffe3927674ad727619426","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For caching proxies different URLs are mapped to different files in the cache."},{"line_number":54,"context_line":"Therefore caching of Swift Temporary URLs for images should be implemented on"},{"line_number":55,"context_line":"the conductor. New config parameter ``swift_temp_url_cachetime`` will be added"},{"line_number":56,"context_line":"to ``glance`` group. When a temporary URL for image is created agent driver"},{"line_number":57,"context_line":"stores it into the cache with UUID of Glance image as a key. Agent driver uses"},{"line_number":58,"context_line":"URL from cache for same UUIDs and checks expiration of temporary URLs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_91b8c02b","line":55,"in_reply_to":"9a1a9d01_90a58605","updated":"2015-10-09 13:53:16.000000000","message":"Info about a parameter updated.","commit_id":"1c1af13378bde79d12bfe5462610ce1e3ddca604"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"402d0aba72f0eaf97d68f8dffc132b87533353b6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Three new optional parameters: ``image_http_proxy``, ``image_https_proxy`` and"},{"line_number":37,"context_line":"``image_proxy_disable`` will be added to agent deploy driver. First two"},{"line_number":38,"context_line":"parameter are strings with format \"PROTOCOL://PROXY_IP:PROXY_PORT\"."},{"line_number":39,"context_line":"``image_proxy_disable`` is a boolean parameter which disables usage of proxies,"},{"line_number":40,"context_line":"default is False."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_972c2d9a","line":37,"updated":"2015-10-09 14:56:23.000000000","message":"I don\u0027t like \u0027image_proxy_disable\u0027 as a name. I think it should be \u0027image_no_proxy\u0027\n\nno_proxy consists of a string of IP addresses or DNS names that should not use a proxy server.\n\nFor example:\n no_proxy\u003d.example.com,example.com,10.0.0.0/16\n\nWhich is support by the requests library.\n\nThe standard names for environment variables for proxies are:\n\n http_proxy\n https_proxy\n no_proxy\n ftp_proxy (not needed)\n socks_proxy (not needed)\n\nI think we should try to mimic that as people who use proxy servers are familiar with these environment variable names.","commit_id":"0c9c7ff5c229829c772d098e5798df3d4c6f29aa"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5a2e296cbd7ff5e080949de045e9d4d5f44956cd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Three new optional parameters: ``image_http_proxy``, ``image_https_proxy`` and"},{"line_number":37,"context_line":"``image_proxy_disable`` will be added to agent deploy driver. First two"},{"line_number":38,"context_line":"parameter are strings with format \"PROTOCOL://PROXY_IP:PROXY_PORT\"."},{"line_number":39,"context_line":"``image_proxy_disable`` is a boolean parameter which disables usage of proxies,"},{"line_number":40,"context_line":"default is False."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_cd7bf4bc","line":37,"in_reply_to":"7a2fa921_12dcab71","updated":"2015-10-09 15:43:57.000000000","message":"Agree, makes sense to add this.","commit_id":"0c9c7ff5c229829c772d098e5798df3d4c6f29aa"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"603e70e99a513fa969fc476820808d68de31fa1a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Three new optional parameters: ``image_http_proxy``, ``image_https_proxy`` and"},{"line_number":37,"context_line":"``image_proxy_disable`` will be added to agent deploy driver. First two"},{"line_number":38,"context_line":"parameter are strings with format \"PROTOCOL://PROXY_IP:PROXY_PORT\"."},{"line_number":39,"context_line":"``image_proxy_disable`` is a boolean parameter which disables usage of proxies,"},{"line_number":40,"context_line":"default is False."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_12dcab71","line":37,"in_reply_to":"7a2fa921_17533d6c","updated":"2015-10-09 15:11:49.000000000","message":"The point is to use the proxies but for some IP addresses or domains you do not use proxies.\n\nIf I work for example.com and we use proxy servers. Then I need to use the proxy server to get to openstack.org, but for a system inside example.com, I do not use a proxy server.  Also, example.com has their proxy servers setup so they will not fetch content from inside example.com\u0027s network. The proxy servers will only fetch content from outside the example.com network. This is a real situation.","commit_id":"0c9c7ff5c229829c772d098e5798df3d4c6f29aa"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"cca0e33223d4da96bb30db87016135c6f08a4928","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Three new optional parameters: ``image_http_proxy``, ``image_https_proxy`` and"},{"line_number":37,"context_line":"``image_proxy_disable`` will be added to agent deploy driver. First two"},{"line_number":38,"context_line":"parameter are strings with format \"PROTOCOL://PROXY_IP:PROXY_PORT\"."},{"line_number":39,"context_line":"``image_proxy_disable`` is a boolean parameter which disables usage of proxies,"},{"line_number":40,"context_line":"default is False."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_ede0302b","line":37,"in_reply_to":"7a2fa921_972c2d9a","updated":"2015-10-09 16:06:17.000000000","message":"Done, but requests library supports \"no_proxy\" only as environment variable, not as a get() parameter.","commit_id":"0c9c7ff5c229829c772d098e5798df3d4c6f29aa"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5c292cc7e2841b5dbf28df29946fa8a0a9c511d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Three new optional parameters: ``image_http_proxy``, ``image_https_proxy`` and"},{"line_number":37,"context_line":"``image_proxy_disable`` will be added to agent deploy driver. First two"},{"line_number":38,"context_line":"parameter are strings with format \"PROTOCOL://PROXY_IP:PROXY_PORT\"."},{"line_number":39,"context_line":"``image_proxy_disable`` is a boolean parameter which disables usage of proxies,"},{"line_number":40,"context_line":"default is False."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_17533d6c","line":37,"in_reply_to":"7a2fa921_972c2d9a","updated":"2015-10-09 15:03:50.000000000","message":"I don\u0027t think this parameter should be added. If e.g. you pass proxies\u003d{\u0027http\u0027: None, \u0027https\u0027: None} to requests no proxy will be used. So if image_http_proxy and image_https_proxy are not in driver info, such dict with None values will be constructed which will basically mean that no proxy is needed.","commit_id":"0c9c7ff5c229829c772d098e5798df3d4c6f29aa"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"16d04b38203f927ea5c5c3aa896e3d3aa56bf6e5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Currently Ironic Python Agent (IPA) is able to download images via direct"},{"line_number":20,"context_line":"HTTP(S) links, but it does not support proxy configuration. If IPA will support"},{"line_number":21,"context_line":"proxy configuration for image downloading user can place caching proxies in"},{"line_number":22,"context_line":"the same physical network segments as nodes for reducing owerall network"},{"line_number":23,"context_line":"traffic and deploying time."},{"line_number":24,"context_line":"There are two different types of image sources when Ironic does deploy with"},{"line_number":25,"context_line":"IPA: Glance UUID and HTTP(S) URL. When HTTP(s) URLs are used so we can simply"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a29b11f_3f16eba7","line":22,"updated":"2015-10-19 20:13:44.000000000","message":"s/owerall/overall/","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"16d04b38203f927ea5c5c3aa896e3d3aa56bf6e5","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Three new optional parameters: ``image_http_proxy``, ``image_https_proxy`` and"},{"line_number":37,"context_line":"``image_no_proxy`` will be added to agent deploy driver. First two parameters"},{"line_number":38,"context_line":"are strings with format \"PROTOCOL://PROXY_IP:PROXY_PORT\". ``image_no_proxy``"},{"line_number":39,"context_line":"is a list of comma-separated URLs that should be excluded from proxying."},{"line_number":40,"context_line":"New behavior of agent deploy driver methods:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a29b11f_a221824f","line":38,"updated":"2015-10-19 20:13:44.000000000","message":"it is odd to need to specify the protocol if I eg was adding a value for image_http_proxy. Wouldn\u0027t you assume the protocol is \u0027http\u0027? I wouldn\u0027t be surprised if some people forget to put it in. (But this is just me wondering.)","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"32b30f4110df505c1cafb7bcebf067fcf53e556b","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Three new optional parameters: ``image_http_proxy``, ``image_https_proxy`` and"},{"line_number":37,"context_line":"``image_no_proxy`` will be added to agent deploy driver. First two parameters"},{"line_number":38,"context_line":"are strings with format \"PROTOCOL://PROXY_IP:PROXY_PORT\". ``image_no_proxy``"},{"line_number":39,"context_line":"is a list of comma-separated URLs that should be excluded from proxying."},{"line_number":40,"context_line":"New behavior of agent deploy driver methods:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a29b11f_2c045c48","line":38,"in_reply_to":"3a29b11f_1dfbd0c2","updated":"2015-10-20 15:58:43.000000000","message":"Oh, maybe I\u0027m missing something then. You could have image_http_proxy \u003d https://..., and image_https_proxy\u003dhttp://...?","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"07f8aca90c0034cc6d21919940de4a0b53c3a4e8","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Three new optional parameters: ``image_http_proxy``, ``image_https_proxy`` and"},{"line_number":37,"context_line":"``image_no_proxy`` will be added to agent deploy driver. First two parameters"},{"line_number":38,"context_line":"are strings with format \"PROTOCOL://PROXY_IP:PROXY_PORT\". ``image_no_proxy``"},{"line_number":39,"context_line":"is a list of comma-separated URLs that should be excluded from proxying."},{"line_number":40,"context_line":"New behavior of agent deploy driver methods:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a29b11f_1dfbd0c2","line":38,"in_reply_to":"3a29b11f_a221824f","updated":"2015-10-20 14:23:25.000000000","message":"https? :)","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"16d04b38203f927ea5c5c3aa896e3d3aa56bf6e5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"is a list of comma-separated URLs that should be excluded from proxying."},{"line_number":40,"context_line":"New behavior of agent deploy driver methods:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* get_properties() - returns description of new parameters."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* validate() - validate new parameter(s) (if present)."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a29b11f_ff5dd379","line":42,"updated":"2015-10-19 20:13:44.000000000","message":"Oh, so these are parameters for the node\u0027s driver_info. Please mention that above in the first paragraph/sentence.","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"acd3a70ea4ad0556e30feefbb3778b2369aad942","unresolved":false,"context_lines":[{"line_number":54,"context_line":"If \"proxies\" key is present IPA adds a parameter to requests.get() method."},{"line_number":55,"context_line":"Requests library supports \"no_proxy\" only as environment variable, not as a"},{"line_number":56,"context_line":"get() parameter. If \"no_proxy\" parameter is set agent should add it to Python\u0027s"},{"line_number":57,"context_line":"\"os.environ\" before get() call."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Swift Temporary URL changes:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a2ca52d_5b0512c0","line":57,"updated":"2015-10-14 01:57:47.000000000","message":"Is there any reason the agent driver doesn\u0027t just rewrite the URL in image_info to point at the proxy?","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cb424ad9e38d15818e9568edd55592ec6f4b6d7d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"If \"proxies\" key is present IPA adds a parameter to requests.get() method."},{"line_number":55,"context_line":"Requests library supports \"no_proxy\" only as environment variable, not as a"},{"line_number":56,"context_line":"get() parameter. If \"no_proxy\" parameter is set agent should add it to Python\u0027s"},{"line_number":57,"context_line":"\"os.environ\" before get() call."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Swift Temporary URL changes:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a2ca52d_67186d85","line":57,"in_reply_to":"5a2ca52d_5b0512c0","updated":"2015-10-14 05:11:46.000000000","message":"I don\u0027t think we want to add the complexity of figuring out proxy servers into the agent driver. Let requests take care of it already has the logic.","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"33c434c8c82d1551e34c069c292ec9f87466a142","unresolved":false,"context_lines":[{"line_number":54,"context_line":"If \"proxies\" key is present IPA adds a parameter to requests.get() method."},{"line_number":55,"context_line":"Requests library supports \"no_proxy\" only as environment variable, not as a"},{"line_number":56,"context_line":"get() parameter. If \"no_proxy\" parameter is set agent should add it to Python\u0027s"},{"line_number":57,"context_line":"\"os.environ\" before get() call."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Swift Temporary URL changes:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a2ca52d_ec7c6222","line":57,"in_reply_to":"5a2ca52d_5b0512c0","updated":"2015-10-14 04:13:16.000000000","message":"I\u0027m assuming these are standard SOCKS style proxies, which generally are supported natively (which is why it\u0027s being added to the environment, so requests will honor it).","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2a716e3b3488382ec773bc9b58cc52e84b23960f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"If \"proxies\" key is present IPA adds a parameter to requests.get() method."},{"line_number":55,"context_line":"Requests library supports \"no_proxy\" only as environment variable, not as a"},{"line_number":56,"context_line":"get() parameter. If \"no_proxy\" parameter is set agent should add it to Python\u0027s"},{"line_number":57,"context_line":"\"os.environ\" before get() call."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Swift Temporary URL changes:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a2ca52d_34c6e59a","line":57,"in_reply_to":"5a2ca52d_67186d85","updated":"2015-10-15 10:10:31.000000000","message":"Agree with John.","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"acd3a70ea4ad0556e30feefbb3778b2369aad942","unresolved":false,"context_lines":[{"line_number":65,"context_line":"cache for same UUIDs and checks expiration of temporary URLs."},{"line_number":66,"context_line":"New integer config parameter ``swift_temp_url_cachetime`` will be added to"},{"line_number":67,"context_line":"``glance`` group. If it greater than zero agent driver enables caching"},{"line_number":68,"context_line":"of URL\u0027s and use it\u0027s value for new temp URL duration."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Notes about proxy service:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a2ca52d_1b58faf9","line":68,"updated":"2015-10-14 01:57:47.000000000","message":"So the conductor is caching these images? What serves them from the conductor?\n\nI\u0027m also not sure that\u0027s useful; presumably Swift clusters are optimized for serving files over HTTP quickly. Why would the conductor be able to do this better?","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"07f8aca90c0034cc6d21919940de4a0b53c3a4e8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"cache for same UUIDs and checks expiration of temporary URLs."},{"line_number":66,"context_line":"New integer config parameter ``swift_temp_url_cachetime`` will be added to"},{"line_number":67,"context_line":"``glance`` group. If it greater than zero agent driver enables caching"},{"line_number":68,"context_line":"of URL\u0027s and use it\u0027s value for new temp URL duration."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Notes about proxy service:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a29b11f_9dbb60e5","line":68,"in_reply_to":"3a29b11f_3f67cb26","updated":"2015-10-20 14:23:25.000000000","message":"Yes, that would match the current behavior today. Remember that it\u0027s just caching the temp URL for the swift object; this isn\u0027t horribly expensive to generate, just a bit of crypto. :)","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"32b30f4110df505c1cafb7bcebf067fcf53e556b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"cache for same UUIDs and checks expiration of temporary URLs."},{"line_number":66,"context_line":"New integer config parameter ``swift_temp_url_cachetime`` will be added to"},{"line_number":67,"context_line":"``glance`` group. If it greater than zero agent driver enables caching"},{"line_number":68,"context_line":"of URL\u0027s and use it\u0027s value for new temp URL duration."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Notes about proxy service:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a29b11f_52360e53","line":68,"in_reply_to":"3a29b11f_9dbb60e5","updated":"2015-10-20 15:58:43.000000000","message":"ok.","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"33c434c8c82d1551e34c069c292ec9f87466a142","unresolved":false,"context_lines":[{"line_number":65,"context_line":"cache for same UUIDs and checks expiration of temporary URLs."},{"line_number":66,"context_line":"New integer config parameter ``swift_temp_url_cachetime`` will be added to"},{"line_number":67,"context_line":"``glance`` group. If it greater than zero agent driver enables caching"},{"line_number":68,"context_line":"of URL\u0027s and use it\u0027s value for new temp URL duration."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Notes about proxy service:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a2ca52d_ac766a3c","line":68,"in_reply_to":"5a2ca52d_1b58faf9","updated":"2015-10-14 04:13:16.000000000","message":"The conductor is caching the *temp URLs* not the images themselves. Preventing the URL from changing can help a caching proxy do a better job caching.","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2a716e3b3488382ec773bc9b58cc52e84b23960f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"cache for same UUIDs and checks expiration of temporary URLs."},{"line_number":66,"context_line":"New integer config parameter ``swift_temp_url_cachetime`` will be added to"},{"line_number":67,"context_line":"``glance`` group. If it greater than zero agent driver enables caching"},{"line_number":68,"context_line":"of URL\u0027s and use it\u0027s value for new temp URL duration."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Notes about proxy service:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a2ca52d_d46211ad","line":68,"in_reply_to":"5a2ca52d_55613f38","updated":"2015-10-15 10:10:31.000000000","message":"Yes, in memory, each conductor has own.","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"766f0efd658fae43b7c3ad6a269f2e0e2c5ecd31","unresolved":false,"context_lines":[{"line_number":65,"context_line":"cache for same UUIDs and checks expiration of temporary URLs."},{"line_number":66,"context_line":"New integer config parameter ``swift_temp_url_cachetime`` will be added to"},{"line_number":67,"context_line":"``glance`` group. If it greater than zero agent driver enables caching"},{"line_number":68,"context_line":"of URL\u0027s and use it\u0027s value for new temp URL duration."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Notes about proxy service:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a2ca52d_55613f38","line":68,"in_reply_to":"5a2ca52d_ac766a3c","updated":"2015-10-14 16:34:04.000000000","message":"Aha. Next question then: what cache is this stored in, just memory?","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"16d04b38203f927ea5c5c3aa896e3d3aa56bf6e5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"cache for same UUIDs and checks expiration of temporary URLs."},{"line_number":66,"context_line":"New integer config parameter ``swift_temp_url_cachetime`` will be added to"},{"line_number":67,"context_line":"``glance`` group. If it greater than zero agent driver enables caching"},{"line_number":68,"context_line":"of URL\u0027s and use it\u0027s value for new temp URL duration."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Notes about proxy service:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a29b11f_3f67cb26","line":68,"in_reply_to":"5a2ca52d_cdefbbe7","updated":"2015-10-19 20:13:44.000000000","message":"If the conductor dies, is it OK for the cache to disappear?","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5a53e7a54d63c44c4c0b19d263e2bad6ab57e06e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"cache for same UUIDs and checks expiration of temporary URLs."},{"line_number":66,"context_line":"New integer config parameter ``swift_temp_url_cachetime`` will be added to"},{"line_number":67,"context_line":"``glance`` group. If it greater than zero agent driver enables caching"},{"line_number":68,"context_line":"of URL\u0027s and use it\u0027s value for new temp URL duration."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Notes about proxy service:"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a2ca52d_cdefbbe7","line":68,"in_reply_to":"5a2ca52d_d46211ad","updated":"2015-10-15 23:34:31.000000000","message":"Could you please clarify this if you push another patch? :)","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"acd3a70ea4ad0556e30feefbb3778b2369aad942","unresolved":false,"context_lines":[{"line_number":131,"context_line":"------------------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Proxy support for image downloading by agent can improve scalability (reduce"},{"line_number":134,"context_line":"network traffic and time of deploy) in proper configured environment."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Performance Impact"},{"line_number":137,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a2ca52d_3b14d6f3","line":134,"updated":"2015-10-14 01:57:47.000000000","message":"If conductors are caching images from swift, there may also be a scalability impact there.","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"33c434c8c82d1551e34c069c292ec9f87466a142","unresolved":false,"context_lines":[{"line_number":131,"context_line":"------------------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Proxy support for image downloading by agent can improve scalability (reduce"},{"line_number":134,"context_line":"network traffic and time of deploy) in proper configured environment."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Performance Impact"},{"line_number":137,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a2ca52d_6c8ff223","line":134,"in_reply_to":"5a2ca52d_3b14d6f3","updated":"2015-10-14 04:13:16.000000000","message":"see above","commit_id":"2e3490cc2c716bc84ebf0ecd98918bd19531c758"}]}