)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"99cc11529b3e35e3ef14eba084395f77d3529035","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-11-23 17:27:57 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec to support tarpayload"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2dd4d65f3233e774c33b0aa7807622b283311bee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_eb0cff43","line":8,"updated":"2015-11-24 02:14:51.000000000","message":"Please add commit message","commit_id":"20ec6184cec68b8b6be3543dcdfee4eb1b3f0ba6"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"dfe28bf0c4982b3b1fd8702d61c7b0eb98e895e0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tar payload spec describes how tar payload support"},{"line_number":10,"context_line":"will be implemented with agent driver and agent ramdisk."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2dd4d65f3233e774c33b0aa7807622b283311bee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba8a016a_1de8a67b","line":11,"updated":"2015-11-24 02:48:30.000000000","message":"Please include the blueprint name. Please follow the format here\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"66852eabc0b6d6d2398aed54092a77ff1eb51181"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7c7d56cee9fb2b361c09a58d107d4af4e53b27d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Arun S A G \u003csaga@yahoo-inc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-23 21:47:02 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec to propose tarpayload support in IPA"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec describes steps involved in adding"},{"line_number":10,"context_line":"support for deploying OS tarballs using ironic\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a8ffd7b_b3277b11","line":7,"updated":"2015-11-25 13:13:12.000000000","message":"\"Add spec for deploying OS tarballs\", I don\u0027t think tarpayload is a common term..","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1945039423f374ad35a6d9e1125e1b6459894e25","unresolved":false,"context_lines":[{"line_number":10,"context_line":"support for deploying OS tarballs using ironic\u0027s"},{"line_number":11,"context_line":"agent driver."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-bug: #1526767"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2dd4d65f3233e774c33b0aa7807622b283311bee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a7b0d38_3fa70f51","line":13,"updated":"2015-12-22 17:17:22.000000000","message":"s/Related-bug/Partial-bug/","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"}],"specs/approved/tar-payload.rst":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a9a04951b63294f43cc6af98faf18f9669b05d75","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/tar-payload"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The agent driver only support whole disk images that can be deployed to "},{"line_number":14,"context_line":"baremetal. Partition image support was proposed to agent driver and it is in"},{"line_number":15,"context_line":"backlog. With tar payload support operators can deploy OS tarballs with agent "},{"line_number":16,"context_line":"driver."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_cb8b3b67","line":13,"updated":"2015-11-24 01:46:48.000000000","message":"whitespace at end of line(s)","commit_id":"20ec6184cec68b8b6be3543dcdfee4eb1b3f0ba6"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"54347e7665233e6e0f0290da60ec2832f979da03","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/tar-payload"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The agent driver only support whole disk images that can be deployed to "},{"line_number":14,"context_line":"baremetal. Partition image support was proposed to agent driver and it is in"},{"line_number":15,"context_line":"backlog. With tar payload support operators can deploy OS tarballs with agent "},{"line_number":16,"context_line":"driver."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_8b3453fb","line":13,"in_reply_to":"ba8a016a_cb8b3b67","updated":"2015-11-24 02:14:33.000000000","message":"+1","commit_id":"20ec6184cec68b8b6be3543dcdfee4eb1b3f0ba6"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"54347e7665233e6e0f0290da60ec2832f979da03","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The agent driver only support whole disk images that can be deployed to "},{"line_number":14,"context_line":"baremetal. Partition image support was proposed to agent driver and it is in"},{"line_number":15,"context_line":"backlog. With tar payload support operators can deploy OS tarballs with agent "},{"line_number":16,"context_line":"driver."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_2b3be7ec","line":15,"updated":"2015-11-24 02:14:33.000000000","message":"ditto","commit_id":"20ec6184cec68b8b6be3543dcdfee4eb1b3f0ba6"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"54347e7665233e6e0f0290da60ec2832f979da03","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Ironic python agent supports deploying OS as whole disk images and partition "},{"line_number":23,"context_line":"images. Modern installers like anaconda support deploying tarballs to the disk."},{"line_number":24,"context_line":"Tarballs are easy to create and faster deploy. This feature will let operators "},{"line_number":25,"context_line":"upload OS tarballs to glance and deploy it to barmetal using agent driver."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_4b3e6bdb","line":22,"updated":"2015-11-24 02:14:33.000000000","message":"ditto","commit_id":"20ec6184cec68b8b6be3543dcdfee4eb1b3f0ba6"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"54347e7665233e6e0f0290da60ec2832f979da03","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Ironic python agent supports deploying OS as whole disk images and partition "},{"line_number":23,"context_line":"images. Modern installers like anaconda support deploying tarballs to the disk."},{"line_number":24,"context_line":"Tarballs are easy to create and faster deploy. This feature will let operators "},{"line_number":25,"context_line":"upload OS tarballs to glance and deploy it to barmetal using agent driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_eb25dfc1","line":24,"updated":"2015-11-24 02:14:33.000000000","message":"ditto","commit_id":"20ec6184cec68b8b6be3543dcdfee4eb1b3f0ba6"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"54347e7665233e6e0f0290da60ec2832f979da03","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Agent driver inspects the image to find if it is a partition image or a "},{"line_number":32,"context_line":"  whole disk image or a tarball."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* If it is a tarball agent driver sends \"default\" partition info (root, swap,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_0b2143b4","line":31,"updated":"2015-11-24 02:14:33.000000000","message":"ditto","commit_id":"20ec6184cec68b8b6be3543dcdfee4eb1b3f0ba6"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"54347e7665233e6e0f0290da60ec2832f979da03","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* If it is a tarball agent driver sends \"default\" partition info (root, swap,"},{"line_number":35,"context_line":"  etc) through image_info to agent ramdisk."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Upon receiving the partition information, agent ramdisk will partition and "},{"line_number":38,"context_line":"  format the os_install disk and extract the tarball on to it."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* The tarball extraction will preserve acls and extended filesystem attributes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_cb2a5b90","line":37,"updated":"2015-11-24 02:14:33.000000000","message":"ditto","commit_id":"20ec6184cec68b8b6be3543dcdfee4eb1b3f0ba6"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"54347e7665233e6e0f0290da60ec2832f979da03","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* The tarball extraction will preserve acls and extended filesystem attributes."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* Once the tarball is extracted, agent ramdisk will generate a host-only "},{"line_number":43,"context_line":"  ramdisk and install the bootloader to the MBR of the os_install disk."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Factor out the partitioning code from ironic into a different library"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_8b1bf37f","line":42,"updated":"2015-11-24 02:14:33.000000000","message":"ditto","commit_id":"20ec6184cec68b8b6be3543dcdfee4eb1b3f0ba6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1c7897f5e53981e928b975af0dfe2e006c879037","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/tar-payload"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The agent driver only support whole disk images that can be deployed to"},{"line_number":14,"context_line":"baremetal. Partition image support was proposed to agent driver and it is in"},{"line_number":15,"context_line":"backlog. With tar payload support operators can deploy OS tarballs with agent"},{"line_number":16,"context_line":"driver."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_cc0fec86","line":13,"updated":"2015-11-25 18:14:20.000000000","message":"nit: s/support/supports/","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1c7897f5e53981e928b975af0dfe2e006c879037","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Ironic python agent supports deploying OS as whole disk images and partition"},{"line_number":23,"context_line":"images. Modern installers like anaconda support deploying tarballs to the disk."},{"line_number":24,"context_line":"Tarballs are easy to create and faster deploy. This feature will let operators"},{"line_number":25,"context_line":"upload OS tarballs to glance and deploy it to barmetal using agent driver."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_2ce6b8b4","line":23,"updated":"2015-11-25 18:14:20.000000000","message":"might be worth adding a link for people to get more info about anaconda.","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1c7897f5e53981e928b975af0dfe2e006c879037","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Ironic python agent supports deploying OS as whole disk images and partition"},{"line_number":23,"context_line":"images. Modern installers like anaconda support deploying tarballs to the disk."},{"line_number":24,"context_line":"Tarballs are easy to create and faster deploy. This feature will let operators"},{"line_number":25,"context_line":"upload OS tarballs to glance and deploy it to barmetal using agent driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_ec9510e4","line":24,"updated":"2015-11-25 18:14:20.000000000","message":"s/deploy/to deploy/","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1c7897f5e53981e928b975af0dfe2e006c879037","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Ironic python agent supports deploying OS as whole disk images and partition"},{"line_number":23,"context_line":"images. Modern installers like anaconda support deploying tarballs to the disk."},{"line_number":24,"context_line":"Tarballs are easy to create and faster deploy. This feature will let operators"},{"line_number":25,"context_line":"upload OS tarballs to glance and deploy it to barmetal using agent driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_0c99741f","line":25,"updated":"2015-11-25 18:14:20.000000000","message":"s/barmetal/bare metal/","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1c7897f5e53981e928b975af0dfe2e006c879037","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Agent driver inspects the image to find if it is a partition image or a"},{"line_number":32,"context_line":"  whole disk image or a tarball."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* If it is a tarball agent driver sends \"default\" partition info (root, swap,"},{"line_number":35,"context_line":"  etc) through image_info to agent ramdisk."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_0c35f4f5","line":32,"updated":"2015-11-25 18:14:20.000000000","message":"We don\u0027t yet have support for partition image. Does this work depend on the partition image support being implemented first? If not, maybe just remove reference to partition image or were you going to make that change to detect partition image anyway?","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7c7d56cee9fb2b361c09a58d107d4af4e53b27d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  whole disk image or a tarball."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* If it is a tarball agent driver sends \"default\" partition info (root, swap,"},{"line_number":35,"context_line":"  etc) through image_info to agent ramdisk."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Upon receiving the partition information, agent ramdisk will partition and"},{"line_number":38,"context_line":"  format the os_install disk and extract the tarball on to it."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_33138bba","line":35,"updated":"2015-11-25 13:13:12.000000000","message":"it should also send an image type, right?","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7c7d56cee9fb2b361c09a58d107d4af4e53b27d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* The tarball extraction will preserve acls and extended filesystem attributes."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* Once the tarball is extracted, agent ramdisk will generate a host-only"},{"line_number":43,"context_line":"  ramdisk and install the bootloader to the MBR of the os_install disk."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Factor out the partitioning code from ironic into a different library"},{"line_number":46,"context_line":"  and use it in both IPA and ironic code base."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_53164fa8","line":43,"updated":"2015-11-25 13:13:12.000000000","message":"does it means that we\u0027ll have to add explicit support for all major distribution\u0027s way of building ramdisks? also we have to ensure we don\u0027t enable PXE boot with tarball images. also we need to stop treating instance ramdisk as mandatory field (IIRC we do right now).","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7c7d56cee9fb2b361c09a58d107d4af4e53b27d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  ramdisk and install the bootloader to the MBR of the os_install disk."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Factor out the partitioning code from ironic into a different library"},{"line_number":46,"context_line":"  and use it in both IPA and ironic code base."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_f30c2396","line":46,"updated":"2015-11-25 13:13:12.000000000","message":"this is already done, the library is called ironic-lib and people are working on adopting it now. feel free to jump in with reviews: https://review.openstack.org/#/c/184443/","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7c7d56cee9fb2b361c09a58d107d4af4e53b27d","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"     - Related test cases."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  2. Use oslo.libironic in IPA"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* Make necessary changes in agent driver common code, such as validate,"},{"line_number":152,"context_line":"  deploy, etc."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_1310c7a7","line":149,"updated":"2015-11-25 13:13:12.000000000","message":"see above, all this is done already","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1c7897f5e53981e928b975af0dfe2e006c879037","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"     - Related test cases."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  2. Use oslo.libironic in IPA"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* Make necessary changes in agent driver common code, such as validate,"},{"line_number":152,"context_line":"  deploy, etc."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_e7820b52","line":149,"in_reply_to":"9a8ffd7b_1310c7a7","updated":"2015-11-25 18:14:20.000000000","message":"Take a look at ironic-lib. If there is more code in ironic that needs to go into ironic-lib still, you can move it there.","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1c7897f5e53981e928b975af0dfe2e006c879037","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* Make changes in IPA (agent ramdisk) to recognize the incoming image"},{"line_number":158,"context_line":"  information and take appropriate action to deploy tarball image on the"},{"line_number":159,"context_line":"  disk."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Dependencies"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_e7044b7f","line":159,"updated":"2015-11-25 18:14:20.000000000","message":"Anyone know: How do we sync ironic + IPA? if IPA has the new feature but ironic doesn\u0027t, that is fine. But if ironic has this feature and an older agent ramdisk is being used, then it just barfs?","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1c7897f5e53981e928b975af0dfe2e006c879037","unresolved":false,"context_lines":[{"line_number":159,"context_line":"  disk."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Dependencies"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_47baf70b","line":162,"updated":"2015-11-25 18:14:20.000000000","message":"I guess it is dependent on https://review.openstack.org/#/c/184443/","commit_id":"32624e39c9f87c48380164633d329cc764dad636"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f77b0a005e02bb370aac8f961cb144257027011c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* Agent driver inspects the image to find if it is whole disk  or a"},{"line_number":33,"context_line":"  compressed OS tarball image."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* If it is a tarball agent driver sends \"default\" partition info (root, swap,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_5af857c3","line":32,"updated":"2015-12-02 16:25:13.000000000","message":"Please describe how agent driver will determine that image is OS tarball image.","commit_id":"0f86aafc4df7e8fed8d794a7bd961e23980f3c3b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"dd6f183924a9d4fe763d41eca37964b5fba6f129","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* Agent driver inspects the image to find if it is whole disk  or a"},{"line_number":33,"context_line":"  compressed OS tarball image."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* If it is a tarball agent driver sends \"default\" partition info (root, swap,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_754f5c34","line":32,"in_reply_to":"9a8ffd7b_5af857c3","updated":"2015-12-03 02:59:05.000000000","message":"I am thinking using a new property in glance named \u0027image_format\u0027 where it\u0027s value can be \u0027tar\u0027. Or we can add a new glance disk format named \u0027tar\u0027 http://docs.openstack.org/developer/glance/formats.html","commit_id":"0f86aafc4df7e8fed8d794a7bd961e23980f3c3b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f77b0a005e02bb370aac8f961cb144257027011c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  etc) and image_type (as tarball) through image_info to agent ramdisk."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Upon receiving the partition information, agent ramdisk will partition and"},{"line_number":39,"context_line":"  format the os_install disk and extract the tarball on to it."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* The tarball extraction will preserve acls and extended filesystem attributes."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_7aad1b83","line":39,"updated":"2015-12-02 16:25:13.000000000","message":"Where agent takes the info about filesystem type for root partition for formatting?","commit_id":"0f86aafc4df7e8fed8d794a7bd961e23980f3c3b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"dd6f183924a9d4fe763d41eca37964b5fba6f129","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  etc) and image_type (as tarball) through image_info to agent ramdisk."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Upon receiving the partition information, agent ramdisk will partition and"},{"line_number":39,"context_line":"  format the os_install disk and extract the tarball on to it."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* The tarball extraction will preserve acls and extended filesystem attributes."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_360b1026","line":39,"in_reply_to":"9a8ffd7b_7aad1b83","updated":"2015-12-03 02:59:05.000000000","message":"I am thinking whether we should leverage node.target_raid_data for this. May be rename target_raid_data to target_part_data (more generic name to describe and store both partition and hardware/software raid information). To support more plain partitions we should probably need to add new \"verbs\" in the \"raid_data\" like \u0027filesystem\u0027, \u0027raid_type\u0027 to accept None , \u0027create_biosboot\u0027\n\nI will update the spec with more information on how to do this. Thanks for pointing it out.","commit_id":"0f86aafc4df7e8fed8d794a7bd961e23980f3c3b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c7265f57823852c6ef9a44db795bc0d0ddf5bf7e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"We can use iscsi method to write tarball image on to the target disk."},{"line_number":51,"context_line":"We need agent ramdisk to support iscsi, similar to the ironic DIB element."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_563d6f8d","line":51,"updated":"2015-12-03 06:00:58.000000000","message":"agent ramdisk already supports iscsi","commit_id":"0f86aafc4df7e8fed8d794a7bd961e23980f3c3b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f77b0a005e02bb370aac8f961cb144257027011c","unresolved":false,"context_lines":[{"line_number":134,"context_line":"* Make necessary changes in agent driver common code, such as validate,"},{"line_number":135,"context_line":"  deploy, etc."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* Make necessary changes in agent_ipmitool driver to generate correct"},{"line_number":138,"context_line":"  pxe config for subsequent reboot."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Make changes in IPA (agent ramdisk) to recognize the incoming image"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_e59c106c","line":137,"updated":"2015-12-02 16:25:13.000000000","message":"Please provide info about this changes in \"Proposed change\" section.","commit_id":"0f86aafc4df7e8fed8d794a7bd961e23980f3c3b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"dd6f183924a9d4fe763d41eca37964b5fba6f129","unresolved":false,"context_lines":[{"line_number":134,"context_line":"* Make necessary changes in agent driver common code, such as validate,"},{"line_number":135,"context_line":"  deploy, etc."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* Make necessary changes in agent_ipmitool driver to generate correct"},{"line_number":138,"context_line":"  pxe config for subsequent reboot."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Make changes in IPA (agent ramdisk) to recognize the incoming image"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_56833456","line":137,"in_reply_to":"9a8ffd7b_e59c106c","updated":"2015-12-03 02:59:05.000000000","message":"I checked the agent_ipmitool driver, looks like the current one is good enough. I will remove this like from work items.","commit_id":"0f86aafc4df7e8fed8d794a7bd961e23980f3c3b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f77b0a005e02bb370aac8f961cb144257027011c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"Dependencies"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Ironic-lib: https://review.openstack.org/#/c/184443/"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_5ae61716","line":147,"updated":"2015-12-02 16:25:13.000000000","message":"Partitioning support for IPA.","commit_id":"0f86aafc4df7e8fed8d794a7bd961e23980f3c3b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"dd6f183924a9d4fe763d41eca37964b5fba6f129","unresolved":false,"context_lines":[{"line_number":144,"context_line":"Dependencies"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Ironic-lib: https://review.openstack.org/#/c/184443/"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_76ef581e","line":147,"in_reply_to":"9a8ffd7b_5ae61716","updated":"2015-12-03 02:59:05.000000000","message":"Will update it to say \u0027Partitioning support for IPA\u0027","commit_id":"0f86aafc4df7e8fed8d794a7bd961e23980f3c3b"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"c05ec1251dc58451f8ae982fee7c1089e851beec","unresolved":false,"context_lines":[{"line_number":32,"context_line":"* Add a new glance ``disk_format`` named ``tar``. Operator should upload OS"},{"line_number":33,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Agent driver retrives disk_format property from the glance image to see if"},{"line_number":36,"context_line":"  it is compressed OS tarball image."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* If it is a tarball agent driver retrieves and sends the part_data from"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a740942_a5cab79f","line":35,"updated":"2015-12-05 15:38:04.000000000","message":"s/retrives/retrieves/","commit_id":"fa927fac6a1e3f01963a93257c637bf02b128c10"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"c05ec1251dc58451f8ae982fee7c1089e851beec","unresolved":false,"context_lines":[{"line_number":38,"context_line":"* If it is a tarball agent driver retrieves and sends the part_data from"},{"line_number":39,"context_line":"  node.target_raid_config along with image_info to agent ramdisk."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* The operator can convery partition information to the node by adding it to"},{"line_number":42,"context_line":"  node.target_raid_config along with the raid configuration."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* Operator specifies only the root partition specific information in the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a740942_c5cd83b8","line":41,"updated":"2015-12-05 15:38:04.000000000","message":"s/convery/convey/","commit_id":"fa927fac6a1e3f01963a93257c637bf02b128c10"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"c05ec1251dc58451f8ae982fee7c1089e851beec","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        }"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Upon retriving the partition information, agent ramdisk will partition and"},{"line_number":115,"context_line":"  format the os_install disk and extract the tarball on to it."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"* The tarball extraction will preserve acls and extended filesystem attributes."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a740942_85c0db7d","line":114,"updated":"2015-12-05 15:38:04.000000000","message":"s/retriving/retrieving/","commit_id":"fa927fac6a1e3f01963a93257c637bf02b128c10"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"029ff08636c878e885bbfe6291fc2f2db6c98711","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/tar-payload"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The agent driver only supports whole disk images that can be deployed to"},{"line_number":14,"context_line":"baremetal. Partition image support was proposed to agent driver and it is in"},{"line_number":15,"context_line":"backlog. With tar payload support operators can deploy OS tarballs with agent"},{"line_number":16,"context_line":"driver."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_51f9124d","line":14,"updated":"2015-12-11 22:56:58.000000000","message":"A bit concerned about this depending on a spec that hasn\u0027t even had work started on it.","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"573665136fb981d635439100c699c9f4749aead9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/tar-payload"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The agent driver only supports whole disk images that can be deployed to"},{"line_number":14,"context_line":"baremetal. Partition image support was proposed to agent driver and it is in"},{"line_number":15,"context_line":"backlog. With tar payload support operators can deploy OS tarballs with agent"},{"line_number":16,"context_line":"driver."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a710552_4a4ec9c2","line":14,"in_reply_to":"7a740942_51f9124d","updated":"2015-12-15 01:29:57.000000000","message":"As discussed on IRC. I think we can definitely implement this independent of partition image support.","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"029ff08636c878e885bbfe6291fc2f2db6c98711","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  node.target_raid_config along with image_info to agent ramdisk."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* The operator can convey partition information to the node by adding it to"},{"line_number":42,"context_line":"  node.target_raid_config along with the raid configuration."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* Operator specifies only the root partition specific information in the"},{"line_number":45,"context_line":"  node.target_raid_data and rest of the partitions if needed should be created"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_bcd92df5","line":42,"updated":"2015-12-11 22:56:58.000000000","message":"I really dislike overloading this place. We should have the metadata about deploying the image put in instance_info before deployment, like it\u0027s handled for images today.","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"573665136fb981d635439100c699c9f4749aead9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  node.target_raid_config along with image_info to agent ramdisk."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* The operator can convey partition information to the node by adding it to"},{"line_number":42,"context_line":"  node.target_raid_config along with the raid configuration."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* Operator specifies only the root partition specific information in the"},{"line_number":45,"context_line":"  node.target_raid_data and rest of the partitions if needed should be created"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a710552_ead535b9","line":42,"in_reply_to":"7a740942_bcd92df5","updated":"2015-12-15 01:29:57.000000000","message":"Okay! So do we introduce a new glance image metadata field? Or create a  custom glance property named \u0027part-data\u0027 and add the partition information there?","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"029ff08636c878e885bbfe6291fc2f2db6c98711","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  #. Optional properties"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    - ``disk_label`` - ``gpt`` or ``msdos`` This by default set to ``msdos``."},{"line_number":64,"context_line":"      ``CONF.raid.default_disk_label`` will be used to figure out the default"},{"line_number":65,"context_line":"      disk label."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    - ``volume_name`` - Partition label to be used when creating the partition."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_9c21d14f","line":64,"updated":"2015-12-11 22:56:58.000000000","message":"This seems like it should be kept in the same place as the partition metadata. I wouldn\u0027t make this a universal setting.","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"029ff08636c878e885bbfe6291fc2f2db6c98711","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    - ``volume_name`` - Partition label to be used when creating the partition."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    - ``disk_type`` - ``hdd`` or ``ssd``. It has a default value of"},{"line_number":70,"context_line":"      ``CONF.raid.default_disk_type``. The default value of this config"},{"line_number":71,"context_line":"      variable will be hdd."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_bc528d65","line":69,"updated":"2015-12-11 22:56:58.000000000","message":"Not sure why this matters for tar image deployment?","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"573665136fb981d635439100c699c9f4749aead9","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    - ``volume_name`` - Partition label to be used when creating the partition."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    - ``disk_type`` - ``hdd`` or ``ssd``. It has a default value of"},{"line_number":70,"context_line":"      ``CONF.raid.default_disk_type``. The default value of this config"},{"line_number":71,"context_line":"      variable will be hdd."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_775c3e19","line":69,"in_reply_to":"7a740942_bc528d65","updated":"2015-12-15 01:29:57.000000000","message":"Operator might want to install, OS on a disk that is connected to the system on interface_type \u0027sas\u0027 and an \u0027ssd\u0027.","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"029ff08636c878e885bbfe6291fc2f2db6c98711","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      ``CONF.raid.default_disk_type``. The default value of this config"},{"line_number":71,"context_line":"      variable will be hdd."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    - ``interface_type`` - ``sata`` or ``scsi`` or ``sas``. It has a default"},{"line_number":74,"context_line":"      value of ``CONF.raid.default_interface_type``. The default value of this"},{"line_number":75,"context_line":"      config variable will be ``sas``."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_1cc88121","line":73,"updated":"2015-12-11 22:56:58.000000000","message":"same: Not sure why this matters for tar image deployment?","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"573665136fb981d635439100c699c9f4749aead9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      ``CONF.raid.default_disk_type``. The default value of this config"},{"line_number":71,"context_line":"      variable will be hdd."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    - ``interface_type`` - ``sata`` or ``scsi`` or ``sas``. It has a default"},{"line_number":74,"context_line":"      value of ``CONF.raid.default_interface_type``. The default value of this"},{"line_number":75,"context_line":"      config variable will be ``sas``."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_69dea26e","line":73,"in_reply_to":"7a740942_1cc88121","updated":"2015-12-15 01:29:57.000000000","message":"same comment as above.","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"029ff08636c878e885bbfe6291fc2f2db6c98711","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    Example::"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        {"},{"line_number":80,"context_line":"          \u0027part_data\u0027:"},{"line_number":81,"context_line":"            ["},{"line_number":82,"context_line":"              {"},{"line_number":83,"context_line":"                \u0027mountpoint\u0027: \u0027/\u0027,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_3c7f7de1","line":80,"updated":"2015-12-11 22:56:58.000000000","message":"Assuming you\u0027d put this into instance_info at deploy time? We should be specific about that.","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"029ff08636c878e885bbfe6291fc2f2db6c98711","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            ["},{"line_number":82,"context_line":"              {"},{"line_number":83,"context_line":"                \u0027mountpoint\u0027: \u0027/\u0027,"},{"line_number":84,"context_line":"                \u0027filesystem\u0027: \u0027xfs\u0027,"},{"line_number":85,"context_line":"                \u0027size_gb\u0027: 50,"},{"line_number":86,"context_line":"                \u0027disk_label\u0027: \u0027msdos\u0027,"},{"line_number":87,"context_line":"                \u0027volume_name\u0027: \u0027root\u0027,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_dce439a9","line":84,"updated":"2015-12-11 22:56:58.000000000","message":"You\u0027ll have to limit the number of filesystems, or at least document that some filesystems may require a custom ramdisk.\n\nYou should add a work item to add fs utils for the supported filesystems to the ramdisk.","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"573665136fb981d635439100c699c9f4749aead9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            ["},{"line_number":82,"context_line":"              {"},{"line_number":83,"context_line":"                \u0027mountpoint\u0027: \u0027/\u0027,"},{"line_number":84,"context_line":"                \u0027filesystem\u0027: \u0027xfs\u0027,"},{"line_number":85,"context_line":"                \u0027size_gb\u0027: 50,"},{"line_number":86,"context_line":"                \u0027disk_label\u0027: \u0027msdos\u0027,"},{"line_number":87,"context_line":"                \u0027volume_name\u0027: \u0027root\u0027,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_89c2ee83","line":84,"in_reply_to":"7a740942_dce439a9","updated":"2015-12-15 01:29:57.000000000","message":"Agree. Most likely it will be limited to xfs and ext4. btrfs may be added later when it becomes \"stable\".","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"029ff08636c878e885bbfe6291fc2f2db6c98711","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Alternatives"},{"line_number":125,"context_line":"------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"None."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_5cf9294d","line":126,"updated":"2015-12-11 22:56:58.000000000","message":"There are a litany of alternatives; including using normal disk images.","commit_id":"f7e151261eb575e84178951a2286d486a6378ecb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c957ce208853614940580fcbbb5dd5dfb747fdcc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  ``part_data`` and rest of the partitions if needed should be created"},{"line_number":43,"context_line":"  using cloud-init."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Partition information is stored in glance property as json string."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* The json string consists of both mandatory and optional properties that"},{"line_number":48,"context_line":"  describe how the partition should be laid out."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a710552_a23e36d8","line":45,"updated":"2015-12-15 23:52:33.000000000","message":"You may want to mention how this information gets into Ironic -- i.e. probably added to instance_info before deploy.","commit_id":"8e63329a8b989bcc33def9f258461e1bd8dd26cc"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"03c50694d3f36d6c84327fb70f68bbcbcdc545b5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  ``part_data`` and rest of the partitions if needed should be created"},{"line_number":43,"context_line":"  using cloud-init."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Partition information is stored in glance property as json string."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* The json string consists of both mandatory and optional properties that"},{"line_number":48,"context_line":"  describe how the partition should be laid out."}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa69d971_aff91950","line":45,"in_reply_to":"5a710552_a23e36d8","updated":"2016-01-09 14:00:29.000000000","message":"Done","commit_id":"8e63329a8b989bcc33def9f258461e1bd8dd26cc"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c957ce208853614940580fcbbb5dd5dfb747fdcc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                \u0027size_gb\u0027: 50,"},{"line_number":85,"context_line":"                \u0027disk_label\u0027: \u0027msdos\u0027,"},{"line_number":86,"context_line":"                \u0027volume_name\u0027: \u0027root\u0027,"},{"line_number":87,"context_line":"                \u0027disk_type\u0027: \u0027hdd\u0027,"},{"line_number":88,"context_line":"                \u0027interface_type\u0027: \u0027sas\u0027,"},{"line_number":89,"context_line":"              }"},{"line_number":90,"context_line":"            ]"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a710552_02594a5a","line":87,"updated":"2015-12-15 23:52:33.000000000","message":"If your goal is to determine which device to image, you should probably use root_hints rather than coding a new way into this for tar images.","commit_id":"8e63329a8b989bcc33def9f258461e1bd8dd26cc"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"03c50694d3f36d6c84327fb70f68bbcbcdc545b5","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                \u0027size_gb\u0027: 50,"},{"line_number":85,"context_line":"                \u0027disk_label\u0027: \u0027msdos\u0027,"},{"line_number":86,"context_line":"                \u0027volume_name\u0027: \u0027root\u0027,"},{"line_number":87,"context_line":"                \u0027disk_type\u0027: \u0027hdd\u0027,"},{"line_number":88,"context_line":"                \u0027interface_type\u0027: \u0027sas\u0027,"},{"line_number":89,"context_line":"              }"},{"line_number":90,"context_line":"            ]"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa69d971_cff6cd5c","line":87,"in_reply_to":"5a710552_02594a5a","updated":"2016-01-09 14:00:29.000000000","message":"Done","commit_id":"8e63329a8b989bcc33def9f258461e1bd8dd26cc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b9321ff106bcc20cef174ce77c12ba88f1729470","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":36,"context_line":"  it is compressed OS tarball image."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* The operator can convey partition information to the node by adding it to"},{"line_number":39,"context_line":"  glance property ``part_data``."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Operator specifies only the root partition specific information in the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a710552_4b5bd887","line":38,"updated":"2015-12-16 10:07:58.000000000","message":"Not sure that it\u0027s needed. Nova passes root, swap, ephemeral sizes to instance_info. We only should know root filesystem type for populating root partition.","commit_id":"1921ea81ceb22c9d3d684543fdfc30737b9c81ed"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"9f5fb07927b325da4f8a547dfa08d0e057fb0ab0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":36,"context_line":"  it is compressed OS tarball image."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* The operator can convey partition information to the node by adding it to"},{"line_number":39,"context_line":"  glance property ``part_data``."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Operator specifies only the root partition specific information in the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"fa69d971_cfdfadd4","line":38,"in_reply_to":"5a710552_4b5bd887","updated":"2016-01-09 13:59:01.000000000","message":"Done","commit_id":"1921ea81ceb22c9d3d684543fdfc30737b9c81ed"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b9321ff106bcc20cef174ce77c12ba88f1729470","unresolved":false,"context_lines":[{"line_number":191,"context_line":"Dependencies"},{"line_number":192,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Partitioning support for IPA: https://review.openstack.org/#/c/184443/"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a710552_cb1ee862","line":194,"updated":"2015-12-16 10:07:58.000000000","message":"Also a new \"tar\" format for Glance.","commit_id":"1921ea81ceb22c9d3d684543fdfc30737b9c81ed"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"9f5fb07927b325da4f8a547dfa08d0e057fb0ab0","unresolved":false,"context_lines":[{"line_number":191,"context_line":"Dependencies"},{"line_number":192,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Partitioning support for IPA: https://review.openstack.org/#/c/184443/"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":12,"id":"fa69d971_6fefa187","line":194,"in_reply_to":"5a710552_cb1ee862","updated":"2016-01-09 13:59:01.000000000","message":"Done","commit_id":"1921ea81ceb22c9d3d684543fdfc30737b9c81ed"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1945039423f374ad35a6d9e1125e1b6459894e25","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Add a new glance ``disk_format`` named ``tar``. Operator should upload OS"},{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":35,"context_line":"  it is compressed OS tarball image."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_45c1ee2d","line":32,"updated":"2015-12-22 17:17:22.000000000","message":"so eg \u0027glance image-create ... --disk-format tar ...\u0027 right?","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1fcb376d4163ccc8a121a7a265be193fb210593d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Add a new glance ``disk_format`` named ``tar``. Operator should upload OS"},{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":35,"context_line":"  it is compressed OS tarball image."}],"source_content_type":"text/x-rst","patch_set":14,"id":"da6ed579_1578c5c3","line":32,"in_reply_to":"1a7b0d38_2cce94b4","updated":"2016-01-12 20:28:38.000000000","message":"Yes, that would be useful.","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"21964fe130e8a60267f1b696fe88b6cabea18eac","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Add a new glance ``disk_format`` named ``tar``. Operator should upload OS"},{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":35,"context_line":"  it is compressed OS tarball image."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_2cce94b4","line":32,"in_reply_to":"1a7b0d38_45c1ee2d","updated":"2016-01-09 13:57:01.000000000","message":"That\u0027s right ruby. Do you want me to add the example command to the spec?","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1945039423f374ad35a6d9e1125e1b6459894e25","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":35,"context_line":"  it is compressed OS tarball image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The operator specifies ``fstype`` and ``disk_label`` as glance image"},{"line_number":38,"context_line":"  properties."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_c502be6f","line":35,"updated":"2015-12-22 17:17:22.000000000","message":"do you mean it looks to see if the disk_format value is \u0027tar\u0027, or do you mean it will do something more than checking that value?","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"21964fe130e8a60267f1b696fe88b6cabea18eac","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":35,"context_line":"  it is compressed OS tarball image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The operator specifies ``fstype`` and ``disk_label`` as glance image"},{"line_number":38,"context_line":"  properties."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_8cba2822","line":35,"in_reply_to":"1a7b0d38_c502be6f","updated":"2016-01-09 13:57:01.000000000","message":"Yes, it will check the disk_format to see if it is \u0027tar\u0027, it will be the only check.","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1945039423f374ad35a6d9e1125e1b6459894e25","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  it is compressed OS tarball image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The operator specifies ``fstype`` and ``disk_label`` as glance image"},{"line_number":38,"context_line":"  properties."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* If the operator does not specify ``fstype`` or ``disk_label`` agent ramdisk"},{"line_number":41,"context_line":"  will by default use ext4 as fstype and msdos as disk_label."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_802264b8","line":38,"updated":"2015-12-22 17:17:22.000000000","message":"maybe move this point/combine with the first one. You mean eg glance image-create .. --property fstype\u003d\u003cfstype\u003e --property disk_label\u003d\u003clabel\u003e, right?\n\nOr did you mean this is per node, so via the node\u0027s instance_info?","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"21964fe130e8a60267f1b696fe88b6cabea18eac","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  it is compressed OS tarball image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The operator specifies ``fstype`` and ``disk_label`` as glance image"},{"line_number":38,"context_line":"  properties."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* If the operator does not specify ``fstype`` or ``disk_label`` agent ramdisk"},{"line_number":41,"context_line":"  will by default use ext4 as fstype and msdos as disk_label."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_4c83e056","line":38,"in_reply_to":"1a7b0d38_802264b8","updated":"2016-01-09 13:57:01.000000000","message":"Right and yes, this is not per node, this is specific to glance image.","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1945039423f374ad35a6d9e1125e1b6459894e25","unresolved":false,"context_lines":[{"line_number":37,"context_line":"* The operator specifies ``fstype`` and ``disk_label`` as glance image"},{"line_number":38,"context_line":"  properties."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* If the operator does not specify ``fstype`` or ``disk_label`` agent ramdisk"},{"line_number":41,"context_line":"  will by default use ext4 as fstype and msdos as disk_label."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Agent driver sends ``root_gb``, ``swap_mb``,  ``fstype``, ``disk_label`` to"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_20061021","line":40,"updated":"2015-12-22 17:17:22.000000000","message":"if the glance image doesn\u0027t have these properties right?","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"21964fe130e8a60267f1b696fe88b6cabea18eac","unresolved":false,"context_lines":[{"line_number":37,"context_line":"* The operator specifies ``fstype`` and ``disk_label`` as glance image"},{"line_number":38,"context_line":"  properties."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* If the operator does not specify ``fstype`` or ``disk_label`` agent ramdisk"},{"line_number":41,"context_line":"  will by default use ext4 as fstype and msdos as disk_label."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Agent driver sends ``root_gb``, ``swap_mb``,  ``fstype``, ``disk_label`` to"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_cc97d08e","line":40,"in_reply_to":"1a7b0d38_20061021","updated":"2016-01-09 13:57:01.000000000","message":"yes fstype and disk_label are glance image properties","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1945039423f374ad35a6d9e1125e1b6459894e25","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Dependencies"},{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Partitioning support for IPA: https://review.openstack.org/#/c/184443/"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* Add a new ``disk_format`` named tar to glance."},{"line_number":158,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_fa0995de","line":155,"updated":"2015-12-22 17:17:22.000000000","message":"This has merged so you could delete it. (or not).","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"21964fe130e8a60267f1b696fe88b6cabea18eac","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Dependencies"},{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Partitioning support for IPA: https://review.openstack.org/#/c/184443/"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* Add a new ``disk_format`` named tar to glance."},{"line_number":158,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_ccc5908e","line":155,"in_reply_to":"1a7b0d38_fa0995de","updated":"2016-01-09 13:57:01.000000000","message":"Okay. I prefer to just leave it as it is.","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1945039423f374ad35a6d9e1125e1b6459894e25","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Documentation Impact"},{"line_number":174,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_6520aa4a","line":171,"updated":"2015-12-22 17:17:22.000000000","message":"I was wondering about this. What happens if you have a tarball glance image but IPA doesn\u0027t know what to do with it? I think ipa is meant to be backwards compat.\n\nWe\u0027ll need to deal with this but I\u0027m not sure how. jroll mentioned \"we should fail gracefully, or somehow determine that IPA supports that ahead of time (which is really hard since you can\u0027t do that without booting the ramdisk)\". It might be the case that IPA can fail gracefully, I am not familiar with the IPA code.","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"21964fe130e8a60267f1b696fe88b6cabea18eac","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Documentation Impact"},{"line_number":174,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a7b0d38_6cd49c46","line":171,"in_reply_to":"1a7b0d38_6520aa4a","updated":"2016-01-09 13:57:01.000000000","message":"To determine what are the image types IPA supports we could created a new API. The agent driver can call this API to find the supported image types, if the tar is not one of the image types supported we could fail.","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1fcb376d4163ccc8a121a7a265be193fb210593d","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Documentation Impact"},{"line_number":174,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da6ed579_50abab89","line":171,"in_reply_to":"1a7b0d38_6cd49c46","updated":"2016-01-12 20:28:38.000000000","message":"I think it is worth adding a note about this compatibility issue between ironic and IPA, with this as a possible solution. See what others think. I\u0027m not sure how/if we\u0027ve been handling this with other features.","commit_id":"1b42cb604168bab2ea7ec82cf0b9a169afd8de6b"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"420b4840a50b16ba324b86e961e53a506938cb03","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":35,"context_line":"  it is compressed OS tarball image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The operator specifies ``fstype`` and ``disk_label`` as glance image"},{"line_number":38,"context_line":"  properties."}],"source_content_type":"text/x-rst","patch_set":15,"id":"fa69d971_f59c0a5f","line":35,"updated":"2015-12-31 17:25:13.000000000","message":"I think it\u0027s necessary to have the agent understand what type of compression is being used somehow in this property. gzip is probably the most common but it\u0027s not the only one.","commit_id":"204c08bf3fbdef983ebc693426d5b657e5c62297"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"c49074647270a56dd1ee3c731af5f3d74558aa57","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":35,"context_line":"  it is compressed OS tarball image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The operator specifies ``fstype`` and ``disk_label`` as glance image"},{"line_number":38,"context_line":"  properties."}],"source_content_type":"text/x-rst","patch_set":15,"id":"fa69d971_f5a2ca4a","line":35,"in_reply_to":"fa69d971_f59c0a5f","updated":"2015-12-31 17:48:17.000000000","message":"Tar utility has ability to automatically determine the compression type. After downloading the image agent ramdisk will use \u0027-xaf\u0027 switch to extract the tarball. According to tar man page\n\n -a, --auto-compress\n Use archive suffix to determine the compression program.\n\n\nSo we don\u0027t really need any special code to find the compression type. If decompression doesn\u0027t work we just error out.","commit_id":"204c08bf3fbdef983ebc693426d5b657e5c62297"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"420b4840a50b16ba324b86e961e53a506938cb03","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"None."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Performance Impact"},{"line_number":114,"context_line":"------------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"None."}],"source_content_type":"text/x-rst","patch_set":15,"id":"fa69d971_75a9fa7a","line":113,"updated":"2015-12-31 17:25:13.000000000","message":"It\u0027d be good to mention that the compression has a potential performance improvement since the image won\u0027t take as much time to download.","commit_id":"204c08bf3fbdef983ebc693426d5b657e5c62297"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"c49074647270a56dd1ee3c731af5f3d74558aa57","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"None."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Performance Impact"},{"line_number":114,"context_line":"------------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"None."}],"source_content_type":"text/x-rst","patch_set":15,"id":"fa69d971_958a6ebe","line":113,"in_reply_to":"fa69d971_75a9fa7a","updated":"2015-12-31 17:48:17.000000000","message":"okay","commit_id":"204c08bf3fbdef983ebc693426d5b657e5c62297"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c3ff8da8ad11586ea2fb5d26bae2e959e88767fe","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526767"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The agent driver only supports whole disk images that can be deployed to"},{"line_number":14,"context_line":"baremetal. With tar payload support operators can deploy OS tarballs with agent"},{"line_number":15,"context_line":"driver."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa69d971_e8e2e400","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":19},"updated":"2016-01-08 08:37:58.000000000","message":"Can we support \u0027tgz\u0027 file to have small image size to save network and storage resource?","commit_id":"51334ecccd26c5bcac841e749cece5e8dc16342b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"90c5b1f1cfc836cac87b9e66aa89d91c540451d1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526767"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The agent driver only supports whole disk images that can be deployed to"},{"line_number":14,"context_line":"baremetal. With tar payload support operators can deploy OS tarballs with agent"},{"line_number":15,"context_line":"driver."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa69d971_babf325f","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":19},"in_reply_to":"fa69d971_e8e2e400","updated":"2016-01-09 13:54:41.000000000","message":"Yes! Tgz are smaller than disk images and can save bandwidth and storage. Please see the performance improvements section.","commit_id":"51334ecccd26c5bcac841e749cece5e8dc16342b"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c3ff8da8ad11586ea2fb5d26bae2e959e88767fe","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Ironic python agent supports deploying OS as whole disk images and partition"},{"line_number":22,"context_line":"images. Modern installers like `anaconda support \u003chttps://github.com/rhinstaller/pykickstart/blob/master/docs/kickstart-docs.rst#liveimg\u003e`_"},{"line_number":23,"context_line":"deploying tarballs to the disk. Tarballs are easy to create and faster to"},{"line_number":24,"context_line":"deploy. This feature will let operators upload OS tarballs to glance and"},{"line_number":25,"context_line":"deploy it to bare metal using agent driver."}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa69d971_6d636642","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":139},"updated":"2016-01-08 08:37:58.000000000","message":"can we move this link to below reference section?","commit_id":"51334ecccd26c5bcac841e749cece5e8dc16342b"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c3ff8da8ad11586ea2fb5d26bae2e959e88767fe","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Add a new glance ``disk_format`` named ``tar``. Operator should upload OS"},{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa69d971_4deea28c","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":48},"updated":"2016-01-08 08:37:58.000000000","message":"Dont think this should be ironic change, so we can remove the non-ironic changes here?","commit_id":"51334ecccd26c5bcac841e749cece5e8dc16342b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"90c5b1f1cfc836cac87b9e66aa89d91c540451d1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Add a new glance ``disk_format`` named ``tar``. Operator should upload OS"},{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa69d971_9a310e0e","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":48},"in_reply_to":"fa69d971_4deea28c","updated":"2016-01-09 13:54:41.000000000","message":"I think this is one of the important part of the spec, it provides clear understanding to the reader. I think it should be mentioned here, even though it is not ironic related change.","commit_id":"51334ecccd26c5bcac841e749cece5e8dc16342b"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c3ff8da8ad11586ea2fb5d26bae2e959e88767fe","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* Add a new glance ``disk_format`` named ``tar``. Operator should upload OS"},{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":35,"context_line":"  it is compressed OS tarball image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The operator specifies ``fstype`` and ``disk_label`` as glance image"},{"line_number":38,"context_line":"  properties."}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa69d971_a82f0c87","line":35,"range":{"start_line":34,"start_character":75,"end_line":35,"end_character":36},"updated":"2016-01-08 08:37:58.000000000","message":"Can we add more validations here to make sure it is valid tar can be used for following steps?\n\n1. compare the checksum\n2. check if it is real tar file which can be untared (tar -t)","commit_id":"51334ecccd26c5bcac841e749cece5e8dc16342b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"90c5b1f1cfc836cac87b9e66aa89d91c540451d1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* Add a new glance ``disk_format`` named ``tar``. Operator should upload OS"},{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":35,"context_line":"  it is compressed OS tarball image."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The operator specifies ``fstype`` and ``disk_label`` as glance image"},{"line_number":38,"context_line":"  properties."}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa69d971_8f053512","line":35,"range":{"start_line":34,"start_character":75,"end_line":35,"end_character":36},"in_reply_to":"fa69d971_a82f0c87","updated":"2016-01-09 13:54:41.000000000","message":"Yes all the validations we do to the a whole disk image like comparing checksum, checking image and ram size will be done. \n\nThe validations to check tar will be done using the disk_format glance property. We assume that the user knows what they are doing when the upload the tar image and they set the disk_format to tar.\n\nIf the disk_format is set to tar, but the image is not really a tarball (does not ends with tar.gz or other valid extensions)- we can error out in the agent driver.\n\nIf an user fakes a tar.gz image then IPA will try to extract it and fail, this failure can be notified.\n\nif the disk_format is not set to tar but the image is a tarball, we could find out using the extension and error out in the ironic agent driver itself.","commit_id":"51334ecccd26c5bcac841e749cece5e8dc16342b"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c3ff8da8ad11586ea2fb5d26bae2e959e88767fe","unresolved":false,"context_lines":[{"line_number":145,"context_line":"  deploy, etc."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"* Make changes in IPA (agent ramdisk) to recognize the incoming image"},{"line_number":148,"context_line":"  information and take appropriate action to deploy tarball image on the"},{"line_number":149,"context_line":"  disk."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* Make use of ironic-lib in IPA to get create partitions in agent ramdisk."}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa69d971_0d0c2a93","line":148,"range":{"start_line":148,"start_character":23,"end_line":148,"end_character":41},"updated":"2016-01-08 08:37:58.000000000","message":"Can we have a clear information here how the actions will be taken? Will get the tar image from swfit viar tmp_url? How to download it, if we will write it down to local disk and untar it, and can we \u0027untar\u0027 it on http stream, so we will not depends on the agent temp fs to hold the image, then we can not support the big tar image which size is bigger than agent temp fs in-mem, any thoughts?","commit_id":"51334ecccd26c5bcac841e749cece5e8dc16342b"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"90c5b1f1cfc836cac87b9e66aa89d91c540451d1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"  deploy, etc."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"* Make changes in IPA (agent ramdisk) to recognize the incoming image"},{"line_number":148,"context_line":"  information and take appropriate action to deploy tarball image on the"},{"line_number":149,"context_line":"  disk."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* Make use of ironic-lib in IPA to get create partitions in agent ramdisk."}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa69d971_6f27a1b6","line":148,"range":{"start_line":148,"start_character":23,"end_line":148,"end_character":41},"in_reply_to":"fa69d971_0d0c2a93","updated":"2016-01-09 13:54:41.000000000","message":"Regarding ram size and image size, we are going to do validation in the agent driver itself as i mentioned earlier.\n\nYes currently i believe the disk images are retrieved using swift temp urls. To download it we will reuse the methods in IPA\u0027s \"Imagedownload\" class.\n\nCurrently in the first iteration i don\u0027t want to stream the tar image directly to disk. We can add it as an enhancement.","commit_id":"51334ecccd26c5bcac841e749cece5e8dc16342b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bec54b2f6641b92508d241c2c8f2df0f21bd71a9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Ironic python agent supports deploying OS as whole disk images and partition"},{"line_number":22,"context_line":"images. Modern installers like anaconda support deploying tarballs to the disk."},{"line_number":23,"context_line":"Tarballs are easy to create and faster to deploy. This feature will let"},{"line_number":24,"context_line":"operators upload OS tarballs to glance and deploy it to bare metal using agent"},{"line_number":25,"context_line":"driver."}],"source_content_type":"text/x-rst","patch_set":18,"id":"da6ed579_35006934","line":22,"updated":"2016-01-12 20:27:42.000000000","message":"if you do another revision, maybe s/anaconda/anaconda [1]/\n\nAnd then below at line 186, s/* /[1] /\n\nor something like that, so the reader can see that there is a link avail for more info.","commit_id":"bcf41a92cf188348e598c32aaafeba69be5a0506"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bec54b2f6641b92508d241c2c8f2df0f21bd71a9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Add a new glance ``disk_format`` named ``tar``. Operator should upload OS"},{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* The following file extensions are supported by IPA .tar, .tbz, .tgz, .txz,"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da6ed579_f01adf6d","line":31,"updated":"2016-01-12 20:27:42.000000000","message":"How about:\n\nThis feature is dependent on an update to glance, to add ``tar`` to the list of possible values for ``disk_format``.","commit_id":"bcf41a92cf188348e598c32aaafeba69be5a0506"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bec54b2f6641b92508d241c2c8f2df0f21bd71a9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* Add a new glance ``disk_format`` named ``tar``. Operator should upload OS"},{"line_number":32,"context_line":"  tarballs with ``disk_format`` as ``tar``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* The following file extensions are supported by IPA .tar, .tbz, .tgz, .txz,"},{"line_number":35,"context_line":"  .tar.bz2, tar.gz, tar.xz"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da6ed579_b51d3975","line":34,"updated":"2016-01-12 20:27:42.000000000","message":"s/IPA/IPA :/","commit_id":"bcf41a92cf188348e598c32aaafeba69be5a0506"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bec54b2f6641b92508d241c2c8f2df0f21bd71a9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  properties."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* If the operator does not specify ``fstype`` or ``disk_label`` agent ramdisk"},{"line_number":45,"context_line":"  will by default use ext4 as fstype and msdos as disk_label."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* Agent driver sends ``root_gb``, ``swap_mb``,  ``fstype``, ``disk_label`` to"},{"line_number":48,"context_line":"  agent ramdisk through image_info."}],"source_content_type":"text/x-rst","patch_set":18,"id":"da6ed579_1073f381","line":45,"updated":"2016-01-12 20:27:42.000000000","message":"I would combine this with the previous point. Eg:\n\nWhen creating the glance image, the operator can specify the image properties ``fstype`` and ``disk_label``. By default, if they are not specified, fstype is \u0027ext4\u0027 and \u0027disk_label\u0027 is \u0027msdos\u0027.  Eg: glance image-create .. --property fstype\u003d\u003cfstype\u003e --property disk_label\u003d\u003clabel\u003e","commit_id":"bcf41a92cf188348e598c32aaafeba69be5a0506"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3226b811496a531a28c62cf743e6dbe992b09bc7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* This feature is dependent on an update to glance, to add ``tar`` to the list"},{"line_number":32,"context_line":"  of possible values for ``disk_format``. Eg: \u0027glance image-create ..."},{"line_number":33,"context_line":"  --disk-format tar ...\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The following file extensions are supported by IPA: .tar, .tbz, .tgz, .txz,"}],"source_content_type":"text/x-rst","patch_set":19,"id":"da6ed579_e24407b8","line":32,"updated":"2016-01-14 00:47:44.000000000","message":"See below line 42; I suggest removing the Eg from here, and combining it with the example below.","commit_id":"def845c69eb7264364c773a82bd9b1947a02e375"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"1feb0d7daadbadfc0d12c99111ea666c47beabc3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* This feature is dependent on an update to glance, to add ``tar`` to the list"},{"line_number":32,"context_line":"  of possible values for ``disk_format``. Eg: \u0027glance image-create ..."},{"line_number":33,"context_line":"  --disk-format tar ...\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The following file extensions are supported by IPA: .tar, .tbz, .tgz, .txz,"}],"source_content_type":"text/x-rst","patch_set":19,"id":"da6ed579_47c92a58","line":32,"in_reply_to":"da6ed579_e24407b8","updated":"2016-01-14 20:18:34.000000000","message":"Done","commit_id":"def845c69eb7264364c773a82bd9b1947a02e375"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3226b811496a531a28c62cf743e6dbe992b09bc7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  it is compressed OS tarball image by checking the ``disk_format`` and file"},{"line_number":40,"context_line":"  extension."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* When creating the glance image, the operator can specify the image properties"},{"line_number":43,"context_line":"  ``fstype`` and ``disk_label``. By default, if they are not specified, fstype"},{"line_number":44,"context_line":"  is \u0027ext4\u0027 and \u0027disk_label\u0027 is \u0027msdos\u0027. Eg: glance image-create .. --property"},{"line_number":45,"context_line":"  fstype\u003d\u003cfstype\u003e --property disk_label\u003d\u003clabel\u003e"}],"source_content_type":"text/x-rst","patch_set":19,"id":"da6ed579_857675a2","line":42,"updated":"2016-01-14 00:47:44.000000000","message":"I think this would flow better if you reordered some of these points.\n\nMove this before the previous point, and change it to something like:\n\nWhen creating the glance image, the operator should specify the disk_format as tar, and may specify the image properties...(what you have). Eg: glance image-create --name my-image --disk-format tar --property\u003dext4 --property disk_label\u003dmsdos \u003c my-image.tgz","commit_id":"def845c69eb7264364c773a82bd9b1947a02e375"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"1feb0d7daadbadfc0d12c99111ea666c47beabc3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  it is compressed OS tarball image by checking the ``disk_format`` and file"},{"line_number":40,"context_line":"  extension."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* When creating the glance image, the operator can specify the image properties"},{"line_number":43,"context_line":"  ``fstype`` and ``disk_label``. By default, if they are not specified, fstype"},{"line_number":44,"context_line":"  is \u0027ext4\u0027 and \u0027disk_label\u0027 is \u0027msdos\u0027. Eg: glance image-create .. --property"},{"line_number":45,"context_line":"  fstype\u003d\u003cfstype\u003e --property disk_label\u003d\u003clabel\u003e"}],"source_content_type":"text/x-rst","patch_set":19,"id":"da6ed579_27ce7663","line":42,"in_reply_to":"da6ed579_857675a2","updated":"2016-01-14 20:18:34.000000000","message":"Done","commit_id":"def845c69eb7264364c773a82bd9b1947a02e375"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9380a555a626a6236cffbceb8d8584df74222e38","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  .tar.bz2, tar.gz, tar.xz"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* When creating the glance image, the operator should specify the disk_format"},{"line_number":38,"context_line":"  as tar, and may specify the image properties ``fstype`` and ``disk_format``"},{"line_number":39,"context_line":"  By default, if they are not specified, fstype is \u0027ext4\u0027 and \u0027disk_label\u0027 is"},{"line_number":40,"context_line":"  \u0027msdos\u0027. Eg: glance image-create .. --property fstype\u003d\u003cfstype\u003e --property"},{"line_number":41,"context_line":"  disk_label\u003d\u003clabel\u003e --disk-format tar"}],"source_content_type":"text/x-rst","patch_set":20,"id":"da6ed579_356c60cd","line":38,"updated":"2016-01-14 20:51:11.000000000","message":"nit, need a period after ``disk_format``.\n\n(If you do another revision).","commit_id":"a40acace6a38947df38770ab88d28a1d287afe9b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"af0547b1f2310768534444aadfa5114c6239be09","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  .tar.bz2, tar.gz, tar.xz"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* When creating the glance image, the operator should specify the disk_format"},{"line_number":38,"context_line":"  as tar, and may specify the image properties ``fstype`` and ``disk_format``"},{"line_number":39,"context_line":"  By default, if they are not specified, fstype is \u0027ext4\u0027 and \u0027disk_label\u0027 is"},{"line_number":40,"context_line":"  \u0027msdos\u0027. Eg: glance image-create .. --property fstype\u003d\u003cfstype\u003e --property"},{"line_number":41,"context_line":"  disk_label\u003d\u003clabel\u003e --disk-format tar"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba63e191_96c80d24","line":38,"updated":"2016-01-20 10:59:45.000000000","message":"nit: s/ \u0027disk_format\u0027 /  \u0027disk_label\u0027","commit_id":"a40acace6a38947df38770ab88d28a1d287afe9b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"af0547b1f2310768534444aadfa5114c6239be09","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* Partitioning support for IPA: https://review.openstack.org/#/c/184443/"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* Add a new ``disk_format`` named tar to glance."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba63e191_6987bed7","line":167,"updated":"2016-01-20 10:59:45.000000000","message":"Add reference URL to glance review here.","commit_id":"a40acace6a38947df38770ab88d28a1d287afe9b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e0e50a2fd69cff0ed213e8dce57289169f377bfd","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"None."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Other end user impact"},{"line_number":113,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"9a68dd71_5b2afae8","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":4},"updated":"2016-01-26 20:50:13.000000000","message":"I think there is a probably a security impact for this. Considering all the tar file related exploits. Can we get some content added here? Or at least justification why there is no security impact.","commit_id":"dcc599934522a93897256784af2424ec8bc64f0c"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"6b6106c92560d7a90c4fdfd3beb3c372ca207242","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"None."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Other end user impact"},{"line_number":113,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"9a68dd71_383f0727","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":4},"in_reply_to":"9a68dd71_565df1ea","updated":"2016-01-26 22:48:01.000000000","message":"Hi John,\n\nAll the CVE\u0027s mentioned in that email thread affects the docker package \n\nPlease See \nhttps://rhn.redhat.com/errata/RHBA-2014-1977.html\nhttps://rhn.redhat.com/errata/RHSA-2015-0623.html\n\nThe security bugs were related to how docker handles image archives. \n\nIn IPA we are actually going to use the actual tar utility to handle the images. I haven\u0027t seen any exploits in tar archive itself. However i will add a security impact statement advising users to disallow untrusted OS image archives.","commit_id":"dcc599934522a93897256784af2424ec8bc64f0c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1b265ce8da0e8ad3e4fa31510bb071a17191fca1","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"None."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Other end user impact"},{"line_number":113,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"9a68dd71_565df1ea","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":4},"in_reply_to":"9a68dd71_5b2afae8","updated":"2016-01-26 21:00:44.000000000","message":"+1. Right, it was brought up in the mailing list. I forgot about it.","commit_id":"dcc599934522a93897256784af2424ec8bc64f0c"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d3b6e26d8b6068b13638b08e0b4fe9906d66ae92","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Operators are recommended to avoid using unstrusted OS tarballs with IPA."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":23,"id":"9a68dd71_9b5b8d2e","line":109,"updated":"2016-01-26 23:02:50.000000000","message":"Maybe a little more detail. Yes the CVEs are in Docker in how they used tar files. Where will the tar files be used in Ironic?\n\nIs it limited to only being during a deploy? And so an untrusted tarfile could compromise a deployed host. Any other issues?\n\nWill the tarfile be processed anywhere else? If so, what steps should be taken to ensure no issue occurs.\n\nThanks.","commit_id":"e7c8a810ab1d73b926801c73fab703faa2abc8cd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d3b6e26d8b6068b13638b08e0b4fe9906d66ae92","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Operators are recommended to avoid using unstrusted OS tarballs with IPA."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Other end user impact"},{"line_number":113,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":23,"id":"9a68dd71_7b081929","line":110,"range":{"start_line":110,"start_character":41,"end_line":110,"end_character":51},"updated":"2016-01-26 23:02:50.000000000","message":"s/unstrusted/untrusted/","commit_id":"e7c8a810ab1d73b926801c73fab703faa2abc8cd"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"96588d8a2e3c1671e784fb1ca0b007b29826e6b7","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The agent driver only supports whole disk images that can be deployed to"},{"line_number":14,"context_line":"baremetal. With tar payload support operators can deploy OS tarballs with agent"},{"line_number":15,"context_line":"driver."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_8ae1129d","line":15,"updated":"2016-02-02 16:59:28.000000000","message":"Ok, so this seems we have 2 different problems that can be broken into different specs.\n\n1. Agent to be able to support deploying partition images (by that I mostly mean, agent should use ironic-lib and be able to create the partition table and so on)\n\n2. Support for deploying tarball images (independent if it\u0027s agent or iscsi, both should work with this)","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"b1c90c1ad19f777ad336db3ec139d2f355e0db68","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The agent driver only supports whole disk images that can be deployed to"},{"line_number":14,"context_line":"baremetal. With tar payload support operators can deploy OS tarballs with agent"},{"line_number":15,"context_line":"driver."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_a5ac318d","line":15,"in_reply_to":"7a5de9d1_8ae1129d","updated":"2016-02-02 23:55:17.000000000","message":"Lucas,\n\nThanks for the review.","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"96588d8a2e3c1671e784fb1ca0b007b29826e6b7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"images. Modern installers like anaconda [1] support deploying tarballs to the"},{"line_number":23,"context_line":"disk. Tarballs are easy to create and faster to deploy. This feature will let"},{"line_number":24,"context_line":"operators upload OS tarballs to glance and deploy it to bare metal using agent"},{"line_number":25,"context_line":"driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_0a5c42ec","line":25,"updated":"2016-02-02 16:59:28.000000000","message":"Why only the agent driver? I don\u0027t see the reason why the iSCSI approach wouldn\u0027t work with tarballs either. In fact, parts of the work for both agent or iscsi will go into ironic-lib which is common on both methodologies (that\u0027s where the disk gets partitioned and filesystems created)","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"b1c90c1ad19f777ad336db3ec139d2f355e0db68","unresolved":false,"context_lines":[{"line_number":22,"context_line":"images. Modern installers like anaconda [1] support deploying tarballs to the"},{"line_number":23,"context_line":"disk. Tarballs are easy to create and faster to deploy. This feature will let"},{"line_number":24,"context_line":"operators upload OS tarballs to glance and deploy it to bare metal using agent"},{"line_number":25,"context_line":"driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_aa72c047","line":25,"in_reply_to":"7a5de9d1_0a5c42ec","updated":"2016-02-02 23:55:17.000000000","message":"I agree. I initially wanted get it done on the agent driver side first and come back to iscsi. I see why not do it both with iscsi and agent driver. I will update the spec to reflect that.","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"96588d8a2e3c1671e784fb1ca0b007b29826e6b7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"disk. Tarballs are easy to create and faster to deploy. This feature will let"},{"line_number":24,"context_line":"operators upload OS tarballs to glance and deploy it to bare metal using agent"},{"line_number":25,"context_line":"driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_2a87be13","line":26,"updated":"2016-02-02 16:59:28.000000000","message":"I think you can highlight more pos/cons between both methods. E.g, being filesystem agnostic is very powerful, the same image can be deployed on different filesystem to optmize the application that will run on that node. That\u0027s painful for images because you would need 1 image per fs type.","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"b1c90c1ad19f777ad336db3ec139d2f355e0db68","unresolved":false,"context_lines":[{"line_number":23,"context_line":"disk. Tarballs are easy to create and faster to deploy. This feature will let"},{"line_number":24,"context_line":"operators upload OS tarballs to glance and deploy it to bare metal using agent"},{"line_number":25,"context_line":"driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_45869d14","line":26,"in_reply_to":"7a5de9d1_2a87be13","updated":"2016-02-02 23:55:17.000000000","message":"I agree. I think it is good to highlight that. Will do.","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"96588d8a2e3c1671e784fb1ca0b007b29826e6b7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* This feature is dependent on an update to glance, to add ``tar`` to the list"},{"line_number":32,"context_line":"  of possible values for ``disk_format``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* The following file extensions are supported by IPA: .tar, .tbz, .tgz, .txz,"},{"line_number":35,"context_line":"  .tar.bz2, tar.gz, tar.xz"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_eadbe64d","line":32,"updated":"2016-02-02 16:59:28.000000000","message":"What about OVA ? Is that something you guys are thinking of ? It\u0027s already supported by glance","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c641e18878365f40771ad24a59f52da0e6f69d81","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* This feature is dependent on an update to glance, to add ``tar`` to the list"},{"line_number":32,"context_line":"  of possible values for ``disk_format``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* The following file extensions are supported by IPA: .tar, .tbz, .tgz, .txz,"},{"line_number":35,"context_line":"  .tar.bz2, tar.gz, tar.xz"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a5ae5dd_a2f67ed5","line":32,"in_reply_to":"5a5ae5dd_48f81f7d","updated":"2016-02-03 10:13:30.000000000","message":"Yeah, I know little about OVF/OVA so it might worth investigating if having a tar.gz inside the .ova is aligned with the scope of the format. If so, I would say we should go for it,","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"b1c90c1ad19f777ad336db3ec139d2f355e0db68","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* This feature is dependent on an update to glance, to add ``tar`` to the list"},{"line_number":32,"context_line":"  of possible values for ``disk_format``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* The following file extensions are supported by IPA: .tar, .tbz, .tgz, .txz,"},{"line_number":35,"context_line":"  .tar.bz2, tar.gz, tar.xz"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a5ae5dd_48f81f7d","line":32,"in_reply_to":"7a5de9d1_eadbe64d","updated":"2016-02-02 23:55:17.000000000","message":"OVA is a good alternative if glance doesn\u0027t accept it. But having said that from existing OVA  images i have seen, It is a tar archive  of a binary disk image format (normally vmdk) followed by an xml description.\n\nHowever OS tarball doesn\u0027t have such xml description. Tar ball is just compressed archive of what you see in a root (/) filesystem.\n\nMay be we can create the tarballs as OVA archives, adding XML to describe what is really in the image (architecture, distro name, grub version etc)\n\n\nSo it would be like, \nRHEL6.ova \u003c- [ OS_tarball.tar.gz, RHEL6.xml]\n\nThoughts?","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"96588d8a2e3c1671e784fb1ca0b007b29826e6b7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  as tar and may specify the image properties ``fstype`` and ``disk_label``."},{"line_number":39,"context_line":"  By default, if they are not specified, fstype is \u0027ext4\u0027 and \u0027disk_label\u0027 is"},{"line_number":40,"context_line":"  \u0027msdos\u0027. Eg: glance image-create .. --property fstype\u003d\u003cfstype\u003e --property"},{"line_number":41,"context_line":"  disk_label\u003d\u003clabel\u003e --disk-format tar"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":44,"context_line":"  it is compressed OS tarball image by checking the ``disk_format`` and file"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_2fdcb017","line":41,"updated":"2016-02-02 16:59:28.000000000","message":"Do we need the disk_label distinction here? Can\u0027t we just let Ironic do the MBR vs GPT bits as we do today? (via boot_mode)","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c641e18878365f40771ad24a59f52da0e6f69d81","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  as tar and may specify the image properties ``fstype`` and ``disk_label``."},{"line_number":39,"context_line":"  By default, if they are not specified, fstype is \u0027ext4\u0027 and \u0027disk_label\u0027 is"},{"line_number":40,"context_line":"  \u0027msdos\u0027. Eg: glance image-create .. --property fstype\u003d\u003cfstype\u003e --property"},{"line_number":41,"context_line":"  disk_label\u003d\u003clabel\u003e --disk-format tar"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":44,"context_line":"  it is compressed OS tarball image by checking the ``disk_format`` and file"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a5ae5dd_2d0a7fd3","line":41,"in_reply_to":"5a5ae5dd_e5f2566f","updated":"2016-02-03 10:13:30.000000000","message":"Gotcha, yeah GPT is, at least theoretically, backwards compatible with BIOS (there are issues, see: http://www.rodsbooks.com/gdisk/bios.html).\n\nBut since GPT was designed to work with BIOS I don\u0027t think Ironic should prevent users from doing that. So I\u0027m +1 with the idea.\n\n...\n\nI wonder about the place that option will live tho. We do select the boot mode (UEFI vs BIOS) of the node via node\u0027s capabilities and the spec is suggesting adding the disk label as part of the image metadata, it sounds inconsistent to me. I would think that being able to boot GPT on a BIOS system is a property/capability of the node and not of the image. What you think about making that disk label choice part of the capabilities? Same as boot mode, we can have a capability such as \"gpt_disk_label:True\"(or something along that line) and if set will create a GPT partition table instead of MSDOS (for both BIOS or UEFI boot mode).","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"b1c90c1ad19f777ad336db3ec139d2f355e0db68","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  as tar and may specify the image properties ``fstype`` and ``disk_label``."},{"line_number":39,"context_line":"  By default, if they are not specified, fstype is \u0027ext4\u0027 and \u0027disk_label\u0027 is"},{"line_number":40,"context_line":"  \u0027msdos\u0027. Eg: glance image-create .. --property fstype\u003d\u003cfstype\u003e --property"},{"line_number":41,"context_line":"  disk_label\u003d\u003clabel\u003e --disk-format tar"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Agent driver retrieves disk_format property from the glance image to see if"},{"line_number":44,"context_line":"  it is compressed OS tarball image by checking the ``disk_format`` and file"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a5ae5dd_e5f2566f","line":41,"in_reply_to":"7a5de9d1_2fdcb017","updated":"2016-02-02 23:55:17.000000000","message":"Boot mode is excellent if you want to distinguish between Legacy bios boot and UEFI boot. In some systems, especially all across yahoo we do a legacy bios boot (UEFI in bios compatibility mode)  and still create gpt disk labels. I think disk_format will help there.\n\nPlease note that in a biosboot system gpt disk partition is needed if it has to work with more than 2TB disks.\n\nSo boot_mode \u003d\u003d \u0027uefi\u0027 -\u003e GPT and EFI system partition\nboot_mode \u003d\u003d \u0027bios\u0027  and disk_format \u003d gpt -\u003e Should work as well.\n\nThoughts?","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"96588d8a2e3c1671e784fb1ca0b007b29826e6b7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"* The tarball extraction will preserve acls and extended filesystem attributes."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Once the tarball is extracted, agent ramdisk will install the bootloader on"},{"line_number":59,"context_line":"  the MBR."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Possible compatibility issue if IPA doesn\u0027t support tarball image (old IPA"},{"line_number":62,"context_line":"  ramdisk). This can be worked around by adding an API to IPA that returns list"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_6f762808","line":59,"updated":"2016-02-02 16:59:28.000000000","message":"Only if local boot is specified, correct? [0]\n\n[0] http://docs.openstack.org/developer/ironic/deploy/install-guide.html?highlight\u003dlocal%20boot#local-boot-with-partition-images","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"b1c90c1ad19f777ad336db3ec139d2f355e0db68","unresolved":false,"context_lines":[{"line_number":56,"context_line":"* The tarball extraction will preserve acls and extended filesystem attributes."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Once the tarball is extracted, agent ramdisk will install the bootloader on"},{"line_number":59,"context_line":"  the MBR."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Possible compatibility issue if IPA doesn\u0027t support tarball image (old IPA"},{"line_number":62,"context_line":"  ramdisk). This can be worked around by adding an API to IPA that returns list"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a5ae5dd_a5a3fe4e","line":59,"in_reply_to":"7a5de9d1_6f762808","updated":"2016-02-02 23:55:17.000000000","message":"Yes, thanks for pointing that out. It will install boot loader only if local_boot is specified.","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"96588d8a2e3c1671e784fb1ca0b007b29826e6b7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"* Possible compatibility issue if IPA doesn\u0027t support tarball image (old IPA"},{"line_number":62,"context_line":"  ramdisk). This can be worked around by adding an API to IPA that returns list"},{"line_number":63,"context_line":"  of supported image types. This API can be called by ironic during nova boot"},{"line_number":64,"context_line":"  to validate whether given image type is supported by IPA."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_8aeef2b2","line":64,"updated":"2016-02-02 16:59:28.000000000","message":"Are we doing this as part of this work? \n\nCause, in some way passing a parameter that is not supported (e.g fstype) will raise errors, handling that correctly and presenting nicely to the user (node\u0027s last_error + logs) may be enough.","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"b1c90c1ad19f777ad336db3ec139d2f355e0db68","unresolved":false,"context_lines":[{"line_number":61,"context_line":"* Possible compatibility issue if IPA doesn\u0027t support tarball image (old IPA"},{"line_number":62,"context_line":"  ramdisk). This can be worked around by adding an API to IPA that returns list"},{"line_number":63,"context_line":"  of supported image types. This API can be called by ironic during nova boot"},{"line_number":64,"context_line":"  to validate whether given image type is supported by IPA."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a5ae5dd_e5c016e3","line":64,"in_reply_to":"7a5de9d1_8aeef2b2","updated":"2016-02-02 23:55:17.000000000","message":"I think returning error on unsupported parameters is simpler. I like this idea. I think this should just do it.","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"96588d8a2e3c1671e784fb1ca0b007b29826e6b7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Alternatives"},{"line_number":68,"context_line":"------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Using whole disk images to deploy the OS."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_4a2a3a80","line":70,"updated":"2016-02-02 16:59:28.000000000","message":"Partition images too, no? If you convert the tar balls to partition images it works as well","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"b1c90c1ad19f777ad336db3ec139d2f355e0db68","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Alternatives"},{"line_number":68,"context_line":"------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Using whole disk images to deploy the OS."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a5ae5dd_655bc655","line":70,"in_reply_to":"7a5de9d1_4a2a3a80","updated":"2016-02-02 23:55:17.000000000","message":"Yes. Initially i specified whole disk images because partition images are not supported in agent driver node.\n\nSince i am changing the spec to add support for both drivers i will add partition images as well.","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"96588d8a2e3c1671e784fb1ca0b007b29826e6b7","unresolved":false,"context_lines":[{"line_number":112,"context_line":"there are no known exploits available at this time, an untrusted malicious tar"},{"line_number":113,"context_line":"archive could potentially compromise the target node during deployment."},{"line_number":114,"context_line":"Standard tar utility will be used to extract the payload to help minimize"},{"line_number":115,"context_line":"security impact during extraction."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Other end user impact"},{"line_number":118,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7a5de9d1_0a5be22f","line":115,"updated":"2016-02-02 16:59:28.000000000","message":"I think the same applies for image deployment, people should pay attention to what they are deploying (tar or image). Specially on baremetal.","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":12640,"name":"Arun S A G","email":"sagarun@gmail.com","username":"sagarun"},"change_message_id":"b1c90c1ad19f777ad336db3ec139d2f355e0db68","unresolved":false,"context_lines":[{"line_number":112,"context_line":"there are no known exploits available at this time, an untrusted malicious tar"},{"line_number":113,"context_line":"archive could potentially compromise the target node during deployment."},{"line_number":114,"context_line":"Standard tar utility will be used to extract the payload to help minimize"},{"line_number":115,"context_line":"security impact during extraction."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Other end user impact"},{"line_number":118,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a5ae5dd_c5307a0a","line":115,"in_reply_to":"7a5de9d1_0a5be22f","updated":"2016-02-02 23:55:17.000000000","message":"Agree!","commit_id":"4ee562f737b9317ffce7f5fd8539b1e9ace6db56"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0ae09c245f2bd3606cb77d4663a359ebc02f1084","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* This feature will require an update to glance, to add ``tar`` to the list"},{"line_number":35,"context_line":"  of possible values for ``disk_format``"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* The following file extensions are supported by IPA: .tar, .tbz, .tgz, .txz,"},{"line_number":38,"context_line":"  .tar.bz2, tar.gz, tar.xz"}],"source_content_type":"text/x-rst","patch_set":26,"id":"bab6814e_dd1ba171","line":35,"updated":"2016-05-20 20:41:54.000000000","message":"We need to cite that spec/RFC/blueprint/whatever glance uses here.","commit_id":"4ed47dabd689364c11972151582e75e3b532ee9d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0ae09c245f2bd3606cb77d4663a359ebc02f1084","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"* Make changes in IPA (agent ramdisk) to recognize the incoming image"},{"line_number":178,"context_line":"  information and take appropriate action to deploy tarball image on the"},{"line_number":179,"context_line":"  disk."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"* Make use of ironic-lib in IPA to get create partitions and filesystems in"},{"line_number":182,"context_line":"  both deploy drivers."}],"source_content_type":"text/x-rst","patch_set":26,"id":"bab6814e_bde21d2d","line":179,"updated":"2016-05-20 20:41:54.000000000","message":"You\u0027ll likely also have to add support for tar and the various compression schemes to the ramdisks.","commit_id":"4ed47dabd689364c11972151582e75e3b532ee9d"}]}