)]}'
{"specs/approved/boot-from-volume-reference-drivers.rst":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"5dd63d7b34cbe4a4ffe6b1c8f39d2abf97760df8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Below are various boot from volume scenarios. These scenarios are"},{"line_number":51,"context_line":"intended to provide a clear definition of conditions and requirements."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"**Scenario 1 - iPXE boot from iSCSI volume**:"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  Conditions:"},{"line_number":56,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa0719c6_3e04df15","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":44},"updated":"2016-03-21 20:31:06.000000000","message":"suggestion: maybe make these section titles with ~\u0027s ?","commit_id":"5558df7f7afbe136f90828507e805b9bb995d2b9"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"5dd63d7b34cbe4a4ffe6b1c8f39d2abf97760df8","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"None"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"\"ironic\" CLI"},{"line_number":340,"context_line":"-~~~~~~~~~~~"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"None. All expected CLI updates are expected to be part of the"},{"line_number":343,"context_line":"specification covering information storage,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa0719c6_336098ce","line":340,"range":{"start_line":339,"start_character":0,"end_line":340,"end_character":12},"updated":"2016-03-21 20:31:06.000000000","message":"does not render correctly.","commit_id":"5558df7f7afbe136f90828507e805b9bb995d2b9"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"5dd63d7b34cbe4a4ffe6b1c8f39d2abf97760df8","unresolved":false,"context_lines":[{"line_number":343,"context_line":"specification covering information storage,"},{"line_number":344,"context_line":"`Add volume connection information for Ironic nodes`_."},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"\"openstack baremetal\" CLI"},{"line_number":347,"context_line":"~-~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"None"},{"line_number":350,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa0719c6_b3aae8d2","line":347,"range":{"start_line":346,"start_character":0,"end_line":347,"end_character":25},"updated":"2016-03-21 20:31:06.000000000","message":"same here.","commit_id":"5558df7f7afbe136f90828507e805b9bb995d2b9"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"5dd63d7b34cbe4a4ffe6b1c8f39d2abf97760df8","unresolved":false,"context_lines":[{"line_number":438,"context_line":"[storage]default_storage_provider - Defaults to none, but represents the global"},{"line_number":439,"context_line":"default storage provider."},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"[cinder]url\u003dhttp://api.address:port"},{"line_number":442,"context_line":"[cinder]url_timeout\u003d30"},{"line_number":443,"context_line":"[cinder]retries\u003d3"},{"line_number":444,"context_line":"[cinder]auth_strategy\u003d\u003cnoauth|keystone\u003e"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"Developer impact"},{"line_number":447,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa0719c6_fe51c763","line":444,"range":{"start_line":441,"start_character":0,"end_line":444,"end_character":39},"updated":"2016-03-21 20:31:06.000000000","message":"didn\u0027t render well","commit_id":"5558df7f7afbe136f90828507e805b9bb995d2b9"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"738a715171b1e13f45b43144cc4f4e7517a5c8c9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"outside of Ironic\u0027s scope at this point in time. Additionally not covered"},{"line_number":46,"context_line":"is the requirement to use UEFI HTTP boot support, which was discussed"},{"line_number":47,"context_line":"during the `ironic mitaka midcycle`_. In our use, it would only be directly"},{"line_number":48,"context_line":"invoking iPXE, and as a dependency it does not make sense at this time"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Below are various boot from volume scenarios. These scenarios are"},{"line_number":51,"context_line":"intended to provide a clear definition of conditions and requirements."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_3cb9f615","line":48,"range":{"start_line":48,"start_character":15,"end_line":48,"end_character":70},"updated":"2016-03-24 09:25:49.000000000","message":"I understood that this spec doesn\u0027t cover MPIO and UEFI HTTP in this paragraph.\n\nBut in terms of the last sentence, I couldn\u0027t understand what doesn\u0027t make sense.\n\nWould you please complement some words for non native English speaker?","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"44e2206e52c3f5062af49a97bcbf21ed4f8434a2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"outside of Ironic\u0027s scope at this point in time. Additionally not covered"},{"line_number":46,"context_line":"is the requirement to use UEFI HTTP boot support, which was discussed"},{"line_number":47,"context_line":"during the `ironic mitaka midcycle`_. In our use, it would only be directly"},{"line_number":48,"context_line":"invoking iPXE, and as a dependency it does not make sense at this time"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Below are various boot from volume scenarios. These scenarios are"},{"line_number":51,"context_line":"intended to provide a clear definition of conditions and requirements."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_5044a5b5","line":48,"range":{"start_line":48,"start_character":15,"end_line":48,"end_character":70},"in_reply_to":"fa0719c6_3cb9f615","updated":"2016-03-31 12:28:38.000000000","message":"Okay, will revise to make this cleaner to a non-native english speaker.","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d9291b2ad53c026899f8b4c1eda57ed6abd4d8d8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Below are various boot from volume scenarios. These scenarios are"},{"line_number":51,"context_line":"intended to provide a clear definition of conditions and requirements."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Scenario 1 - iPXE boot from iSCSI volume"},{"line_number":54,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  Conditions:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_df72af10","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":40},"updated":"2016-03-23 09:10:11.000000000","message":"Is this scenario almost same as \"netboot\" of current iscsi driver?\nSuch as the current \"netboot\" always boot via pxe and the root partition is in local disk, does this scenario 1 always boot via iPXE and iPXE NBP attach the root partition in Cinder via iSCSI?","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"738a715171b1e13f45b43144cc4f4e7517a5c8c9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Below are various boot from volume scenarios. These scenarios are"},{"line_number":51,"context_line":"intended to provide a clear definition of conditions and requirements."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Scenario 1 - iPXE boot from iSCSI volume"},{"line_number":54,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  Conditions:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_99f1346e","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":40},"in_reply_to":"fa0719c6_38ee50b4","updated":"2016-03-24 09:25:49.000000000","message":"Okay, I understood.","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a53d49bb3b138407ff9ea045aa05a07a37cf1711","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Below are various boot from volume scenarios. These scenarios are"},{"line_number":51,"context_line":"intended to provide a clear definition of conditions and requirements."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Scenario 1 - iPXE boot from iSCSI volume"},{"line_number":54,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  Conditions:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_38ee50b4","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":40},"in_reply_to":"fa0719c6_df72af10","updated":"2016-03-23 14:21:57.000000000","message":"Similar, however it essentially requires a different configuration to boot than the current netboot capabilities, as well as substrate to handle controller failures.","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d9291b2ad53c026899f8b4c1eda57ed6abd4d8d8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    - Scenario 1 or 2 implemented"},{"line_number":122,"context_line":"    - Additional logic for RBD template generation."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Scenario 4 - Boot via hardware HBA to volume"},{"line_number":125,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_24191ed8","line":124,"range":{"start_line":124,"start_character":22,"end_line":124,"end_character":34},"updated":"2016-03-23 09:10:11.000000000","message":"Does it mean that it\u0027s not FC function of CNA card?\n\nDon\u0027t we need to consider to the following scenarios too?\n Scenario 4\u0027 Boot via FC function of CNA card \n Secnario 4\u0027\u0027 Boot via iSCSI function of CNA card","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a53d49bb3b138407ff9ea045aa05a07a37cf1711","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    - Scenario 1 or 2 implemented"},{"line_number":122,"context_line":"    - Additional logic for RBD template generation."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Scenario 4 - Boot via hardware HBA to volume"},{"line_number":125,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_786a88ef","line":124,"range":{"start_line":124,"start_character":22,"end_line":124,"end_character":34},"in_reply_to":"fa0719c6_24191ed8","updated":"2016-03-23 14:21:57.000000000","message":"Realistically, it means any as we put the responsibility of booting the node on the bios and it\u0027s settings.  Naturally, this is entirely dependent upon the capabilities of the device and it\u0027s default behavior.\n\nSo, ultimately, I don\u0027t think we need additional scenarios since from our standpoint, we\u0027re generic and just powering on a node.","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"44e2206e52c3f5062af49a97bcbf21ed4f8434a2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    - Scenario 1 or 2 implemented"},{"line_number":122,"context_line":"    - Additional logic for RBD template generation."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Scenario 4 - Boot via hardware HBA to volume"},{"line_number":125,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_50e02596","line":124,"range":{"start_line":124,"start_character":22,"end_line":124,"end_character":34},"in_reply_to":"fa0719c6_6f8e0e2f","updated":"2016-03-31 12:28:38.000000000","message":"That is correct.","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"738a715171b1e13f45b43144cc4f4e7517a5c8c9","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    - Scenario 1 or 2 implemented"},{"line_number":122,"context_line":"    - Additional logic for RBD template generation."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Scenario 4 - Boot via hardware HBA to volume"},{"line_number":125,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_6f8e0e2f","line":124,"range":{"start_line":124,"start_character":22,"end_line":124,"end_character":34},"in_reply_to":"fa0719c6_786a88ef","updated":"2016-03-24 09:25:49.000000000","message":"Okay, I understood that \"hardware HBA\" can be any HBA if it has the capability to boot from SAN, so we don\u0027t need additional scenario for CNA.\nAm I correct?","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"738a715171b1e13f45b43144cc4f4e7517a5c8c9","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  Conditions:"},{"line_number":132,"context_line":"    - Metadata service use expected"},{"line_number":133,"context_line":"    - Configuration drive support is unavailable"},{"line_number":134,"context_line":"    - Node boot defaults to block storage device"},{"line_number":135,"context_line":"    - Tenant network isolation would be supported"},{"line_number":136,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":137,"context_line":"      via external means."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_722c3599","line":134,"range":{"start_line":134,"start_character":6,"end_line":134,"end_character":48},"updated":"2016-03-24 09:25:49.000000000","message":"Is this the condition that administrator set target wwwn in advance manually?","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"106fa7453de147d6a676d6f78a6bc0f7a618ad3f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  Conditions:"},{"line_number":132,"context_line":"    - Metadata service use expected"},{"line_number":133,"context_line":"    - Configuration drive support is unavailable"},{"line_number":134,"context_line":"    - Node boot defaults to block storage device"},{"line_number":135,"context_line":"    - Tenant network isolation would be supported"},{"line_number":136,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":137,"context_line":"      via external means."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_192d39fe","line":134,"range":{"start_line":134,"start_character":6,"end_line":134,"end_character":48},"in_reply_to":"ba0121b8_561e5e5f","updated":"2016-03-31 12:40:32.000000000","message":"I just realized, although hardware dependent, we might just ab able to offer up iscsi target information via DHCP....","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"44e2206e52c3f5062af49a97bcbf21ed4f8434a2","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  Conditions:"},{"line_number":132,"context_line":"    - Metadata service use expected"},{"line_number":133,"context_line":"    - Configuration drive support is unavailable"},{"line_number":134,"context_line":"    - Node boot defaults to block storage device"},{"line_number":135,"context_line":"    - Tenant network isolation would be supported"},{"line_number":136,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":137,"context_line":"      via external means."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_561e5e5f","line":134,"range":{"start_line":134,"start_character":6,"end_line":134,"end_character":48},"in_reply_to":"fa0719c6_722c3599","updated":"2016-03-31 12:28:38.000000000","message":"For iSCSI, I\u0027m not entirely sure how that would work right now.  The user might have to point the node\u0027s configuration at the discovery service.  For FC, I think that will depend on HBA settings since some will just boot to whatever is offered as LUN 0.\n\nThis really makes me think, that later on, we may need another scenario where we provide an interface for an IPA with vendor tools could be run to do any required HBA setting updates, but I think that is far ouside our scope at the moment.","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d9291b2ad53c026899f8b4c1eda57ed6abd4d8d8","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    - Tenant network isolation would be supported"},{"line_number":136,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":137,"context_line":"      via external means."},{"line_number":138,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":139,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  Requirements:"},{"line_number":142,"context_line":"    - Creation of a no-op deployment driver"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_64d4b6bc","line":139,"range":{"start_line":138,"start_character":4,"end_line":139,"end_character":72},"updated":"2016-03-23 09:10:11.000000000","message":"What kind of HBA card do we support, Qlogic, Emulex, or something else?\n\nHow can IPA write WWN addresses to HBA cards to attach the volume?\nDoes each vendor have to develop own hardware manager?","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"44e2206e52c3f5062af49a97bcbf21ed4f8434a2","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    - Tenant network isolation would be supported"},{"line_number":136,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":137,"context_line":"      via external means."},{"line_number":138,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":139,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  Requirements:"},{"line_number":142,"context_line":"    - Creation of a no-op deployment driver"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_96df5668","line":139,"range":{"start_line":138,"start_character":4,"end_line":139,"end_character":72},"in_reply_to":"fa0719c6_122a19db","updated":"2016-03-31 12:28:38.000000000","message":"More-so dependent upon the hardware and how it works in that storage environment.  If cinder can say \"Hey, here is your boot lun\" and it works, awesome, if not we may have some additional work there such as asserting settings.  This is where the diverse variety of configuration options going to be troublesome for us and a generic scenario. :(","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a53d49bb3b138407ff9ea045aa05a07a37cf1711","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    - Tenant network isolation would be supported"},{"line_number":136,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":137,"context_line":"      via external means."},{"line_number":138,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":139,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  Requirements:"},{"line_number":142,"context_line":"    - Creation of a no-op deployment driver"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_735469fe","line":139,"range":{"start_line":138,"start_character":4,"end_line":139,"end_character":72},"in_reply_to":"fa0719c6_64d4b6bc","updated":"2016-03-23 14:21:57.000000000","message":"We essentially won\u0027t be interacting with the initiators nor do we want to explicitly focus on a specific set of initiators given the desire for the operation to be generic.  The initiators will need to be configured to have enough fabric information to boot under standard conditions.\n\nIt might be a future item that vendors may wish to develop IPA hardware managers to assert configuration via IPA, but I think that would be a different scenario.","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"738a715171b1e13f45b43144cc4f4e7517a5c8c9","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    - Tenant network isolation would be supported"},{"line_number":136,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":137,"context_line":"      via external means."},{"line_number":138,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":139,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  Requirements:"},{"line_number":142,"context_line":"    - Creation of a no-op deployment driver"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_122a19db","line":139,"range":{"start_line":138,"start_character":4,"end_line":139,"end_character":72},"in_reply_to":"fa0719c6_735469fe","updated":"2016-03-24 09:25:49.000000000","message":"\u003e The initiators will need to be configured to have enough fabric information to boot under standard conditions.\n\nIn terms of this condition, is this L.134?\nIf a bare metal server is reassigned to another customer, does Ironic administrator reset target wwn manually each time?\n\nAha, if we need to preconfigure the HBA settings, perhaps consequently, is this scenario just same as the current local disk scenario? Because the only difference is the location of disk.\nI think the answer must be yes.","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d9291b2ad53c026899f8b4c1eda57ed6abd4d8d8","unresolved":false,"context_lines":[{"line_number":144,"context_line":"      flow to be taken for a node deployment, and upon cleaning change the"},{"line_number":145,"context_line":"      node to the cleaning network and boot the agent to perform cleaning."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Scenario 5 - Boot via hardware HBA to volume with OS image deployment"},{"line_number":148,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  Scenario involves boot to a local volume where the volume needs to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_7f0d63e7","line":147,"range":{"start_line":147,"start_character":22,"end_line":147,"end_character":69},"updated":"2016-03-23 09:10:11.000000000","message":"Same as the line 124.\n\nDoes it mean that it\u0027s not FC function of CNA card?\n\nDon\u0027t we need to consider the following scenarios too?\n Scenario 5\u0027 Boot via FC function of CNA card to volume with OS image deployment\n Secnario 5\u0027\u0027 Boot via iSCSI function of CNA card to volume with OS image deployment","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a53d49bb3b138407ff9ea045aa05a07a37cf1711","unresolved":false,"context_lines":[{"line_number":144,"context_line":"      flow to be taken for a node deployment, and upon cleaning change the"},{"line_number":145,"context_line":"      node to the cleaning network and boot the agent to perform cleaning."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Scenario 5 - Boot via hardware HBA to volume with OS image deployment"},{"line_number":148,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  Scenario involves boot to a local volume where the volume needs to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_93077dc9","line":147,"range":{"start_line":147,"start_character":22,"end_line":147,"end_character":69},"in_reply_to":"fa0719c6_7f0d63e7","updated":"2016-03-23 14:21:57.000000000","message":"Same reply as reply to 124, except that this scenario is focused on the case where we need to explicitly lay an image down on the volume.  It is actually very similar to existing deployment processes, however there may be additional items that need to be improved to facilitate this, such as passing sufficient information to IPA for the image to write out to the correct volume, and possibly updating IPA to better understand multipathing.","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"44e2206e52c3f5062af49a97bcbf21ed4f8434a2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"      flow to be taken for a node deployment, and upon cleaning change the"},{"line_number":145,"context_line":"      node to the cleaning network and boot the agent to perform cleaning."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Scenario 5 - Boot via hardware HBA to volume with OS image deployment"},{"line_number":148,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  Scenario involves boot to a local volume where the volume needs to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_16dfc60d","line":147,"range":{"start_line":147,"start_character":22,"end_line":147,"end_character":69},"in_reply_to":"fa0719c6_8d9baa17","updated":"2016-03-31 12:28:38.000000000","message":"In scenario4, we expect something like cinder to write the image out to the volume for us in advance.  In this scenario, we the IPA agent to perform the write out to a blank volume, and because of that and the fact that this would require a fully functional deploy driver, we need to to delineate the scenario.","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"738a715171b1e13f45b43144cc4f4e7517a5c8c9","unresolved":false,"context_lines":[{"line_number":144,"context_line":"      flow to be taken for a node deployment, and upon cleaning change the"},{"line_number":145,"context_line":"      node to the cleaning network and boot the agent to perform cleaning."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Scenario 5 - Boot via hardware HBA to volume with OS image deployment"},{"line_number":148,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  Scenario involves boot to a local volume where the volume needs to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa0719c6_8d9baa17","line":147,"range":{"start_line":147,"start_character":22,"end_line":147,"end_character":69},"in_reply_to":"fa0719c6_93077dc9","updated":"2016-03-24 09:25:49.000000000","message":"Now I think I could understand. This scenario is almost same as the current local disk scenario.\n\nIf so, why do we distinguish between Scenario 4 and 5?\nScenario 4 needs to not only pre-install OS but also pre-set WWN into HBA, it seems the bare metal cannot be recycled from one user to another without administrator\u0027s intervention.","commit_id":"c734f5058fb80ffad4180895c667fdf8e3e012fe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eb2634cdb945b9fe8d46d6893f3f161e94ef7f8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          tenant network isolation, however that is considered out of"},{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"},{"line_number":71,"context_line":"      of ``iscsi_boot`` set to a value of ``true``."},{"line_number":72,"context_line":"    - Node has a defined volume connector with an ``boot_index``"},{"line_number":73,"context_line":"      value of ``0``"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_46d645c6","line":71,"updated":"2016-04-04 16:00:39.000000000","message":"I think we should have a capability called \"boot_volume_type\" with values \"local\" (the default), \"iscsi\" (this case), \"fibrechannel\" (the next case), \"rbd\" (the 3rd case). This will allow us not to specify what to do if a node has all these capabilities set to \"true\" (or do we want to somehow support it?)","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1846f440dd407c052e388311767b6dbe23c2b04","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          tenant network isolation, however that is considered out of"},{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"},{"line_number":71,"context_line":"      of ``iscsi_boot`` set to a value of ``true``."},{"line_number":72,"context_line":"    - Node has a defined volume connector with an ``boot_index``"},{"line_number":73,"context_line":"      value of ``0``"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_fd5fd63e","line":71,"in_reply_to":"9a061dce_46d645c6","updated":"2016-04-06 12:56:16.000000000","message":"Long explanation short, I think we need to support all the possible capabilities because we don\u0027t want to put operators in the position of having to shuffle nodes around in what would basically be logical groups.\n\nThinking about this a little more, the method for the connection to storage used would be governed by the type of connection information provided from cinder, so the driver, hardware (and ultimately hardware connectivity) would all have to be able to support the method.\n\nThe driver will have to reconcile as much as possible, and potentially fail the validation of the node such that the nova driver tries to reschedule in the event a volume exists with insufficient connection information.  The conundrum that I see is that it would be very easy for some operators to support all of these methods, and we would still have to have the validation logic of what each use scenario needs/","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa6ac4d908c2553410f701728309f91758687b11","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          tenant network isolation, however that is considered out of"},{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"},{"line_number":71,"context_line":"      of ``iscsi_boot`` set to a value of ``true``."},{"line_number":72,"context_line":"    - Node has a defined volume connector with an ``boot_index``"},{"line_number":73,"context_line":"      value of ``0``"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_388e20d0","line":71,"in_reply_to":"9a061dce_fd5fd63e","updated":"2016-04-07 11:17:15.000000000","message":"I think I got it, thanks","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eb2634cdb945b9fe8d46d6893f3f161e94ef7f8","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    - Scenario 1 or 2 implemented"},{"line_number":124,"context_line":"    - Additional logic for RBD template generation."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Scenario 4 - Boot via hardware HBA to volume"},{"line_number":127,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_a6dbe1ec","line":126,"updated":"2016-04-04 16:00:39.000000000","message":"Is HBA a well-known abbreviation? quick googling gives a lot of weird suggestions :)","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa6ac4d908c2553410f701728309f91758687b11","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    - Scenario 1 or 2 implemented"},{"line_number":124,"context_line":"    - Additional logic for RBD template generation."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Scenario 4 - Boot via hardware HBA to volume"},{"line_number":127,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_d86c440a","line":126,"in_reply_to":"9a061dce_7d5f46e5","updated":"2016-04-07 11:17:15.000000000","message":"Well, I\u0027m good at not knowing the well known things :D Could you please expand it once for people like me?","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1846f440dd407c052e388311767b6dbe23c2b04","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    - Scenario 1 or 2 implemented"},{"line_number":124,"context_line":"    - Additional logic for RBD template generation."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Scenario 4 - Boot via hardware HBA to volume"},{"line_number":127,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_7d5f46e5","line":126,"in_reply_to":"9a061dce_a6dbe1ec","updated":"2016-04-06 12:56:16.000000000","message":"It is an extremely well known abbreviation in the storage arena, although you make an excellent point.  Do you think \"Host Bus Adapter (HBA)\" would be better for those who know and think of it using just the acronym?","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d591e25843508eeb4ea6552df652d1887eb39258","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    - Scenario 1 or 2 implemented"},{"line_number":124,"context_line":"    - Additional logic for RBD template generation."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Scenario 4 - Boot via hardware HBA to volume"},{"line_number":127,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a18252c_ed88d224","line":126,"in_reply_to":"9a061dce_d86c440a","updated":"2016-04-13 13:09:32.000000000","message":"Absolutely!","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eb2634cdb945b9fe8d46d6893f3f161e94ef7f8","unresolved":false,"context_lines":[{"line_number":141,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  Requirements:"},{"line_number":144,"context_line":"    - Creation of a no-op deployment driver"},{"line_number":145,"context_line":"    - Creation of a new driver, ?agent_hba_ipmitool? to allow the standard"},{"line_number":146,"context_line":"      flow to be taken for a node deployment, and upon cleaning change the"},{"line_number":147,"context_line":"      node to the cleaning network and boot the agent to perform cleaning."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_86d85df1","line":144,"updated":"2016-04-04 16:00:39.000000000","message":"fake_ipmitool?","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa6ac4d908c2553410f701728309f91758687b11","unresolved":false,"context_lines":[{"line_number":141,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  Requirements:"},{"line_number":144,"context_line":"    - Creation of a no-op deployment driver"},{"line_number":145,"context_line":"    - Creation of a new driver, ?agent_hba_ipmitool? to allow the standard"},{"line_number":146,"context_line":"      flow to be taken for a node deployment, and upon cleaning change the"},{"line_number":147,"context_line":"      node to the cleaning network and boot the agent to perform cleaning."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_98348cfc","line":144,"in_reply_to":"9a061dce_5a640848","updated":"2016-04-07 11:17:15.000000000","message":"Isn\u0027t it what you propose on the next line?","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1846f440dd407c052e388311767b6dbe23c2b04","unresolved":false,"context_lines":[{"line_number":141,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  Requirements:"},{"line_number":144,"context_line":"    - Creation of a no-op deployment driver"},{"line_number":145,"context_line":"    - Creation of a new driver, ?agent_hba_ipmitool? to allow the standard"},{"line_number":146,"context_line":"      flow to be taken for a node deployment, and upon cleaning change the"},{"line_number":147,"context_line":"      node to the cleaning network and boot the agent to perform cleaning."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_5a640848","line":144,"in_reply_to":"9a061dce_86d85df1","updated":"2016-04-06 12:56:16.000000000","message":"Kind of, although fully functional for everything else not deployment related although I see the scenario as really requiring the driver to be able to be able to invoke what we know as a normal deploy through the same driver, so optionally invoke deployment based on user supplied data.","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d591e25843508eeb4ea6552df652d1887eb39258","unresolved":false,"context_lines":[{"line_number":141,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  Requirements:"},{"line_number":144,"context_line":"    - Creation of a no-op deployment driver"},{"line_number":145,"context_line":"    - Creation of a new driver, ?agent_hba_ipmitool? to allow the standard"},{"line_number":146,"context_line":"      flow to be taken for a node deployment, and upon cleaning change the"},{"line_number":147,"context_line":"      node to the cleaning network and boot the agent to perform cleaning."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a18252c_83300fea","line":144,"in_reply_to":"9a061dce_98348cfc","updated":"2016-04-13 13:09:32.000000000","message":"Well, this would be a component, the item below would be more of a whole item.  I guess it would make more sense to better delineate that somehow.","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eb2634cdb945b9fe8d46d6893f3f161e94ef7f8","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  Requirements:"},{"line_number":144,"context_line":"    - Creation of a no-op deployment driver"},{"line_number":145,"context_line":"    - Creation of a new driver, ?agent_hba_ipmitool? to allow the standard"},{"line_number":146,"context_line":"      flow to be taken for a node deployment, and upon cleaning change the"},{"line_number":147,"context_line":"      node to the cleaning network and boot the agent to perform cleaning."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_e6e5d9a8","line":145,"updated":"2016-04-04 16:00:39.000000000","message":"not sure what was planned, but what I see is \"?agent_hba_ipmitool?\". some weird symbol?","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa6ac4d908c2553410f701728309f91758687b11","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  Requirements:"},{"line_number":144,"context_line":"    - Creation of a no-op deployment driver"},{"line_number":145,"context_line":"    - Creation of a new driver, ?agent_hba_ipmitool? to allow the standard"},{"line_number":146,"context_line":"      flow to be taken for a node deployment, and upon cleaning change the"},{"line_number":147,"context_line":"      node to the cleaning network and boot the agent to perform cleaning."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_9b02c608","line":145,"in_reply_to":"9a061dce_7a610c39","updated":"2016-04-07 11:17:15.000000000","message":"Haha, got it :) I hope we\u0027ll land the driver composition, and won\u0027t have to figure out one more crazy naming.","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1846f440dd407c052e388311767b6dbe23c2b04","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  Requirements:"},{"line_number":144,"context_line":"    - Creation of a no-op deployment driver"},{"line_number":145,"context_line":"    - Creation of a new driver, ?agent_hba_ipmitool? to allow the standard"},{"line_number":146,"context_line":"      flow to be taken for a node deployment, and upon cleaning change the"},{"line_number":147,"context_line":"      node to the cleaning network and boot the agent to perform cleaning."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_7a610c39","line":145,"in_reply_to":"9a061dce_e6e5d9a8","updated":"2016-04-06 12:56:16.000000000","message":"Just a proposed possible driver name in the current naming scheme.  I was kind of hoping with question marks someone would suggest something better :)","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eb2634cdb945b9fe8d46d6893f3f161e94ef7f8","unresolved":false,"context_lines":[{"line_number":245,"context_line":"           and exists as a future driver capability that makes sense to"},{"line_number":246,"context_line":"           define now."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"  - Creation of an ``agent_volume_ipmitool`` driver with a similar"},{"line_number":249,"context_line":"    composition to the existing ``agent_ipmitool`` driver."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"      - The existing PXE boot interface will be utilized with template"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_c6e2559f","line":248,"updated":"2016-04-04 16:00:39.000000000","message":"oh, more fancy names.. :) lets wait for the driver composition maybe?","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d591e25843508eeb4ea6552df652d1887eb39258","unresolved":false,"context_lines":[{"line_number":245,"context_line":"           and exists as a future driver capability that makes sense to"},{"line_number":246,"context_line":"           define now."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"  - Creation of an ``agent_volume_ipmitool`` driver with a similar"},{"line_number":249,"context_line":"    composition to the existing ``agent_ipmitool`` driver."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"      - The existing PXE boot interface will be utilized with template"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a18252c_8d1cbec2","line":248,"in_reply_to":"9a061dce_7b7a5289","updated":"2016-04-13 13:09:32.000000000","message":"I completely agree.","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa6ac4d908c2553410f701728309f91758687b11","unresolved":false,"context_lines":[{"line_number":245,"context_line":"           and exists as a future driver capability that makes sense to"},{"line_number":246,"context_line":"           define now."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"  - Creation of an ``agent_volume_ipmitool`` driver with a similar"},{"line_number":249,"context_line":"    composition to the existing ``agent_ipmitool`` driver."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"      - The existing PXE boot interface will be utilized with template"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_7b7a5289","line":248,"in_reply_to":"9a061dce_b85bac2d","updated":"2016-04-07 11:17:15.000000000","message":"Yeah, I should probably say \"depend\" in a sense of syncing these 2 works, so that they end up being consistent with each other.","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1846f440dd407c052e388311767b6dbe23c2b04","unresolved":false,"context_lines":[{"line_number":245,"context_line":"           and exists as a future driver capability that makes sense to"},{"line_number":246,"context_line":"           define now."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"  - Creation of an ``agent_volume_ipmitool`` driver with a similar"},{"line_number":249,"context_line":"    composition to the existing ``agent_ipmitool`` driver."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"      - The existing PXE boot interface will be utilized with template"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_b85bac2d","line":248,"in_reply_to":"9a061dce_c6e2559f","updated":"2016-04-06 12:56:16.000000000","message":"I don\u0027t think we can realistically \"wait\" in the blocking sense, I do think we can work in parallel and try to adopt driver composition as an early consumer, since honestly it does kind of make some of the headaches a little less... headachy. :)    I think ;)","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eb2634cdb945b9fe8d46d6893f3f161e94ef7f8","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        be iPXE."},{"line_number":254,"context_line":"      - If the node is deployed without volume information, the method calls"},{"line_number":255,"context_line":"        will be directed to the ``AgentDeploy`` class in the agent driver"},{"line_number":256,"context_line":"        module."},{"line_number":257,"context_line":"      - If the node is configured to deploy with ``volume_connector``"},{"line_number":258,"context_line":"        information present, the driver will assume deployment consists of"},{"line_number":259,"context_line":"        creating the appropriate configuration on disk for iPXE, and to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_26eeb18b","line":256,"updated":"2016-04-04 16:00:39.000000000","message":"then we can implement it as part of agent_ipmitool driver, why having one more?","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d591e25843508eeb4ea6552df652d1887eb39258","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        be iPXE."},{"line_number":254,"context_line":"      - If the node is deployed without volume information, the method calls"},{"line_number":255,"context_line":"        will be directed to the ``AgentDeploy`` class in the agent driver"},{"line_number":256,"context_line":"        module."},{"line_number":257,"context_line":"      - If the node is configured to deploy with ``volume_connector``"},{"line_number":258,"context_line":"        information present, the driver will assume deployment consists of"},{"line_number":259,"context_line":"        creating the appropriate configuration on disk for iPXE, and to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a18252c_68279012","line":256,"in_reply_to":"9a061dce_1bd23628","updated":"2016-04-13 13:09:32.000000000","message":"True, I guess I would prefer a very explicit delineation between the two since we have such a variety of use cases, although driver composition gives us that in the end.  Perhaps we should just stop thinking about it as the based or integrated in the agent_ipmitool driver, since its just different drivers mixed together. :)\n\nThinking about this further, a case could be made for strong explicit delineation as it allows for documentation to better convey what a driver is truly capable of, and that truthfully was the main context that I was thinking in with this specification, that we have to be very explicit about what should, and how it should work.","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1846f440dd407c052e388311767b6dbe23c2b04","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        be iPXE."},{"line_number":254,"context_line":"      - If the node is deployed without volume information, the method calls"},{"line_number":255,"context_line":"        will be directed to the ``AgentDeploy`` class in the agent driver"},{"line_number":256,"context_line":"        module."},{"line_number":257,"context_line":"      - If the node is configured to deploy with ``volume_connector``"},{"line_number":258,"context_line":"        information present, the driver will assume deployment consists of"},{"line_number":259,"context_line":"        creating the appropriate configuration on disk for iPXE, and to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_b8ebacaf","line":256,"in_reply_to":"9a061dce_26eeb18b","updated":"2016-04-06 12:56:16.000000000","message":"I thought about this for quite a while and discussed it with a few others and the idea of forcing an operator to make an active decision to support booting from a remote volume seemed to be what people generally came to a consensus on.  I guess part of my concern is the expectation of things just kind of working, when they might not because of any number of reasons when a local boot operation works just fine.  In my mind, that means an operator needs to test that it works in their environment, based on their configuration, and only then make that choice.  I guess the argument could be said with capabilities as well, and part of me sees this as just cleaner compared to what we would need to do to the agent deploy driver out of the gate.","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa6ac4d908c2553410f701728309f91758687b11","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        be iPXE."},{"line_number":254,"context_line":"      - If the node is deployed without volume information, the method calls"},{"line_number":255,"context_line":"        will be directed to the ``AgentDeploy`` class in the agent driver"},{"line_number":256,"context_line":"        module."},{"line_number":257,"context_line":"      - If the node is configured to deploy with ``volume_connector``"},{"line_number":258,"context_line":"        information present, the driver will assume deployment consists of"},{"line_number":259,"context_line":"        creating the appropriate configuration on disk for iPXE, and to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_1bd23628","line":256,"in_reply_to":"9a061dce_b8ebacaf","updated":"2016-04-07 11:17:15.000000000","message":"\u003e make an active decision to support booting from a remote volume\n\nisn\u0027t adding a required capability an \"active decision\" on its own?","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eb2634cdb945b9fe8d46d6893f3f161e94ef7f8","unresolved":false,"context_lines":[{"line_number":369,"context_line":"Driver API impact"},{"line_number":370,"context_line":"-----------------"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"None"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"Nova driver impact"},{"line_number":375,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_06f3ad74","line":372,"updated":"2016-04-04 16:00:39.000000000","message":"you were talking about a new driver interface, if I got it right. could you please elaborate here?","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1846f440dd407c052e388311767b6dbe23c2b04","unresolved":false,"context_lines":[{"line_number":369,"context_line":"Driver API impact"},{"line_number":370,"context_line":"-----------------"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"None"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"Nova driver impact"},{"line_number":375,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_38f95c4e","line":372,"in_reply_to":"9a061dce_06f3ad74","updated":"2016-04-06 12:56:16.000000000","message":"Thinking about this, I guess we would ultimately end up with an API Interface for interacting with the storage driver in order to help ensure that the information is synced and up to date.  In a sense, concetually like task.driver.storage.blah().  I guess I have some more writing to do in my next update. :)\n\nIf you are perceiving anything besides that, please let me know.","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa6ac4d908c2553410f701728309f91758687b11","unresolved":false,"context_lines":[{"line_number":494,"context_line":"Implementation of `Add volume connection information for Ironic nodes`_."},{"line_number":495,"context_line":"This specification should not be entirely dependent upon the implementation"},{"line_number":496,"context_line":"of the `Nova Specs - Ironic - Boot from Cinder volume`_ specification."},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"Testing"},{"line_number":499,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a061dce_9ba486ba","line":497,"updated":"2016-04-07 11:17:15.000000000","message":"I would add the driver composition reform as a soft dependency here","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d591e25843508eeb4ea6552df652d1887eb39258","unresolved":false,"context_lines":[{"line_number":494,"context_line":"Implementation of `Add volume connection information for Ironic nodes`_."},{"line_number":495,"context_line":"This specification should not be entirely dependent upon the implementation"},{"line_number":496,"context_line":"of the `Nova Specs - Ironic - Boot from Cinder volume`_ specification."},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"Testing"},{"line_number":499,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a18252c_03cebfb3","line":497,"in_reply_to":"9a061dce_9ba486ba","updated":"2016-04-13 13:09:32.000000000","message":"Will do.","commit_id":"0607c3cbb129b4581afd24af65fcc2dea0495108"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e5c024e9a5148fae75fb89c4bbaf8a08b32ee9f3","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Below are various boot from volume scenarios. These scenarios are"},{"line_number":53,"context_line":"intended to provide a clear definition of conditions and requirements."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Scenario 1 - iPXE boot from iSCSI volume"},{"line_number":56,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9abb7d3a_92f25a6e","line":54,"updated":"2016-05-27 05:43:19.000000000","message":"Just want to clarify. Do we make a reference driver for each scenario?","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Below are various boot from volume scenarios. These scenarios are"},{"line_number":53,"context_line":"intended to provide a clear definition of conditions and requirements."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Scenario 1 - iPXE boot from iSCSI volume"},{"line_number":56,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_7def001e","line":54,"in_reply_to":"9abb7d3a_92f25a6e","updated":"2016-06-10 20:07:41.000000000","message":"In the case of the reference drivers, we will just be adding support based upon the scenarios into the existing drivers.","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e5c024e9a5148fae75fb89c4bbaf8a08b32ee9f3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"},{"line_number":71,"context_line":"      of ``iscsi_boot`` set to a value of ``true``."},{"line_number":72,"context_line":"    - Node has a defined volume connector with an ``boot_index``"},{"line_number":73,"context_line":"      value of ``0``"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Requirements:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bab6814e_25410864","line":72,"range":{"start_line":72,"start_character":32,"end_line":72,"end_character":41},"updated":"2016-05-27 05:43:19.000000000","message":"s/connector/target/ ?","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"},{"line_number":71,"context_line":"      of ``iscsi_boot`` set to a value of ``true``."},{"line_number":72,"context_line":"    - Node has a defined volume connector with an ``boot_index``"},{"line_number":73,"context_line":"      value of ``0``"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Requirements:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_f871fea9","line":72,"range":{"start_line":72,"start_character":32,"end_line":72,"end_character":41},"in_reply_to":"bab6814e_25410864","updated":"2016-06-10 20:07:41.000000000","message":"Done","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e5c024e9a5148fae75fb89c4bbaf8a08b32ee9f3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      value of ``0``"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Requirements:"},{"line_number":76,"context_line":"    - Storage driver interface"},{"line_number":77,"context_line":"    - iPXE template and generation logic changes"},{"line_number":78,"context_line":"    - Implementation of substrate logic in the agent and PXE driver modules"},{"line_number":79,"context_line":"      to appropriately handle booting a node in a boot from volume scenario."}],"source_content_type":"text/x-rst","patch_set":8,"id":"bab6814e_c5f3dc71","line":76,"range":{"start_line":76,"start_character":6,"end_line":76,"end_character":30},"updated":"2016-05-27 05:43:19.000000000","message":"Why do we need it? Would you add brief explanation?","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      value of ``0``"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Requirements:"},{"line_number":76,"context_line":"    - Storage driver interface"},{"line_number":77,"context_line":"    - iPXE template and generation logic changes"},{"line_number":78,"context_line":"    - Implementation of substrate logic in the agent and PXE driver modules"},{"line_number":79,"context_line":"      to appropriately handle booting a node in a boot from volume scenario."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_1deb5ce0","line":76,"range":{"start_line":76,"start_character":6,"end_line":76,"end_character":30},"in_reply_to":"bab6814e_c5f3dc71","updated":"2016-06-10 20:07:41.000000000","message":"Sure, will add a brief explanation.  Essentially it is required for handling failures since we\u0027re consuming data from cinder, if that data should change, say do to a storage controller fail-over, we don\u0027t want to force the user to have to re-provision machines to update the configuration.","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e5c024e9a5148fae75fb89c4bbaf8a08b32ee9f3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    - Tenant network isolation is unsupported due to iPXE requirements."},{"line_number":92,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"},{"line_number":93,"context_line":"      setting of ``fiberchannel_boot`` set to a value of ``true``."},{"line_number":94,"context_line":"    - Node has a defined volume connector with a ``boot_index``"},{"line_number":95,"context_line":"      value of ``0``"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  Requirements:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bab6814e_053de4dc","line":94,"range":{"start_line":94,"start_character":32,"end_line":94,"end_character":41},"updated":"2016-05-27 05:43:19.000000000","message":"s/connector/target/ ?","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    - Tenant network isolation is unsupported due to iPXE requirements."},{"line_number":92,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"},{"line_number":93,"context_line":"      setting of ``fiberchannel_boot`` set to a value of ``true``."},{"line_number":94,"context_line":"    - Node has a defined volume connector with a ``boot_index``"},{"line_number":95,"context_line":"      value of ``0``"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  Requirements:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_186deacc","line":94,"range":{"start_line":94,"start_character":32,"end_line":94,"end_character":41},"in_reply_to":"bab6814e_053de4dc","updated":"2016-06-10 20:07:41.000000000","message":"Done","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e5c024e9a5148fae75fb89c4bbaf8a08b32ee9f3","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Scenario 4 - Boot via hardware Host Bus Adapter (HBA) to volume"},{"line_number":128,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"},{"line_number":131,"context_line":"  to be pre-populated with a bootable operating system. No volume deployment"},{"line_number":132,"context_line":"  operation is expected."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  Conditions:"},{"line_number":135,"context_line":"    - Metadata service use expected"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bab6814e_4d753130","line":132,"range":{"start_line":130,"start_character":0,"end_line":132,"end_character":24},"updated":"2016-05-27 05:43:19.000000000","message":"I think it\u0027s good to add some descriptions here like your  comment in the patchset 4:\n\n\n\"Realistically, it means any as we put the responsibility of booting the node on the bios and it\u0027s settings. Naturally, this is entirely dependent upon the capabilities of the device and it\u0027s default behavior.\nSo, ultimately, I don\u0027t think we need additional scenarios since from our standpoint, we\u0027re generic and just powering on a node.\"\n\n\nin order to clarify the scenario.\n(The same question which Naohiro asked in patchset 4 had come into my mind ;p)","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Scenario 4 - Boot via hardware Host Bus Adapter (HBA) to volume"},{"line_number":128,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"},{"line_number":131,"context_line":"  to be pre-populated with a bootable operating system. No volume deployment"},{"line_number":132,"context_line":"  operation is expected."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  Conditions:"},{"line_number":135,"context_line":"    - Metadata service use expected"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_0b563206","line":132,"range":{"start_line":130,"start_character":0,"end_line":132,"end_character":24},"in_reply_to":"bab6814e_4d753130","updated":"2016-06-10 20:07:41.000000000","message":"Will be in the next revision.  A bit condensed and re-written, please let me know what you think once it posted.","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f1cb08aad85a2a37a92ec762611025a1d9dd5b02","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"  Requirements:"},{"line_number":164,"context_line":"    - This method is expected to be identical to the"},{"line_number":165,"context_line":"      ``Boot via hardware HBA to volume`` method, however via the inclusion"},{"line_number":166,"context_line":"      of default logic that only invokes deploy phase when explicitly"},{"line_number":167,"context_line":"      requested for boot from a volume."},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_db4ed56d","line":165,"updated":"2016-04-29 16:05:24.000000000","message":"`..`_","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"  Requirements:"},{"line_number":164,"context_line":"    - This method is expected to be identical to the"},{"line_number":165,"context_line":"      ``Boot via hardware HBA to volume`` method, however via the inclusion"},{"line_number":166,"context_line":"      of default logic that only invokes deploy phase when explicitly"},{"line_number":167,"context_line":"      requested for boot from a volume."},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_d8ba4271","line":165,"in_reply_to":"1a122d0e_db4ed56d","updated":"2016-06-10 20:07:41.000000000","message":"Done","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f1cb08aad85a2a37a92ec762611025a1d9dd5b02","unresolved":false,"context_lines":[{"line_number":221,"context_line":"       of ``none`` will result in a driver interface that performs ``no-op``"},{"line_number":222,"context_line":"       behavior."},{"line_number":223,"context_line":"     - A global configuration parameter for the default storage driver to"},{"line_number":224,"context_line":"       be utilized, when appropriate, which can be overridden by a host-level"},{"line_number":225,"context_line":"       driver_info setting, similar to the"},{"line_number":226,"context_line":"       `Add network provider interface and implementations`_ change,"},{"line_number":227,"context_line":"       however with the goal of the setting to be placed in the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_bb515910","line":224,"updated":"2016-04-29 16:05:24.000000000","message":"We agreed to not have a default.","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":221,"context_line":"       of ``none`` will result in a driver interface that performs ``no-op``"},{"line_number":222,"context_line":"       behavior."},{"line_number":223,"context_line":"     - A global configuration parameter for the default storage driver to"},{"line_number":224,"context_line":"       be utilized, when appropriate, which can be overridden by a host-level"},{"line_number":225,"context_line":"       driver_info setting, similar to the"},{"line_number":226,"context_line":"       `Add network provider interface and implementations`_ change,"},{"line_number":227,"context_line":"       however with the goal of the setting to be placed in the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_7ed63d28","line":224,"in_reply_to":"1a122d0e_bb515910","updated":"2016-06-10 20:07:41.000000000","message":"We did and the next revision should reflect that, if I missed anything that we discussed in Austin, please let me know.","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f1cb08aad85a2a37a92ec762611025a1d9dd5b02","unresolved":false,"context_lines":[{"line_number":225,"context_line":"       driver_info setting, similar to the"},{"line_number":226,"context_line":"       `Add network provider interface and implementations`_ change,"},{"line_number":227,"context_line":"       however with the goal of the setting to be placed in the"},{"line_number":228,"context_line":"       driver_info parameter."},{"line_number":229,"context_line":"     - Addition of a node level setting called ``storage_provider`` to"},{"line_number":230,"context_line":"       allow the client to override the default storage management driver."},{"line_number":231,"context_line":"     - Initial and reference storage driver to be based upon cinder,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_1b55edf8","line":228,"updated":"2016-04-29 16:05:24.000000000","message":"node.storage_interface (not in driver_info)","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"       driver_info setting, similar to the"},{"line_number":226,"context_line":"       `Add network provider interface and implementations`_ change,"},{"line_number":227,"context_line":"       however with the goal of the setting to be placed in the"},{"line_number":228,"context_line":"       driver_info parameter."},{"line_number":229,"context_line":"     - Addition of a node level setting called ``storage_provider`` to"},{"line_number":230,"context_line":"       allow the client to override the default storage management driver."},{"line_number":231,"context_line":"     - Initial and reference storage driver to be based upon cinder,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_deb491f3","line":228,"in_reply_to":"1a122d0e_1b55edf8","updated":"2016-06-10 20:07:41.000000000","message":"I think the driver info stuff came from a previous thought, but corrected in the next revision.  Thank you!","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e5c024e9a5148fae75fb89c4bbaf8a08b32ee9f3","unresolved":false,"context_lines":[{"line_number":236,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":237,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":238,"context_line":"           process being initiated."},{"line_number":239,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":240,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":241,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":242,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":243,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":244,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":245,"context_line":"           capability that makes sense to define now."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9abb7d3a_0f23e506","line":242,"range":{"start_line":239,"start_character":0,"end_line":242,"end_character":68},"updated":"2016-05-27 05:43:19.000000000","message":"This means the driver itself attach/detach volumes? Maybe they are needed for stand alone mode. However, if we use ironic with nova/cinder, nova sends volume attach/detach request to cinder and so volume already attached to the node from the cinder point of view. How do we handle it?","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":236,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":237,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":238,"context_line":"           process being initiated."},{"line_number":239,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":240,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":241,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":242,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":243,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":244,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":245,"context_line":"           capability that makes sense to define now."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_9848bace","line":242,"range":{"start_line":239,"start_character":0,"end_line":242,"end_character":68},"in_reply_to":"9abb7d3a_0f23e506","updated":"2016-06-10 20:07:41.000000000","message":"Yes.  Detach was requested by the cinder community at the last cinder midcycle for when baremetal nodes are powered off since they are not in use.  These methods are to enable that functionality, and ultimately they are also needed for stand alone mode.\n\nI think nova should still send attach/detach requests as pertinent to the supplied configuration/instance.  Unless we need to implement those explicit calls in the nova ironic virt driver.\n\nMy perspective is that all Ironic would do following up would just be a follow-up check and assert any missing state/configuration based upon the request.","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f1cb08aad85a2a37a92ec762611025a1d9dd5b02","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  - Updating of the ``pxe.PXEBoot`` driver logic to support the creation of"},{"line_number":272,"context_line":"    the appropriate iPXE configurations for booting from the various boot"},{"line_number":273,"context_line":"    scenarios if the ``volume_connector`` information is defined, iPXE is"},{"line_number":274,"context_line":"    enabled, and a storage provider is available."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"  - Updating of the ``agent.AgentDeploy`` driver logic to handle triggering"},{"line_number":277,"context_line":"    the storage driver to refresh configuration upon a conductor takeover"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_fb5751fe","line":274,"updated":"2016-04-29 16:05:24.000000000","message":"We need a way to figure out if a boot interface implementation actually supports connecting volumes. Otherwise we will silently produce a broken deployment.\n\nBecause of 3rd party drivers we can\u0027t actually maintain a \"known to work\" list.\n\nAnd do we need the same for the deploy inteface for the same reason?","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  - Updating of the ``pxe.PXEBoot`` driver logic to support the creation of"},{"line_number":272,"context_line":"    the appropriate iPXE configurations for booting from the various boot"},{"line_number":273,"context_line":"    scenarios if the ``volume_connector`` information is defined, iPXE is"},{"line_number":274,"context_line":"    enabled, and a storage provider is available."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"  - Updating of the ``agent.AgentDeploy`` driver logic to handle triggering"},{"line_number":277,"context_line":"    the storage driver to refresh configuration upon a conductor takeover"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_5e77013a","line":274,"in_reply_to":"1a122d0e_fb5751fe","updated":"2016-06-10 20:07:41.000000000","message":"I think we do.  I talked through this with NobodyCam and the next revision might have a viable solution.  Please let me know what you think.","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e5c024e9a5148fae75fb89c4bbaf8a08b32ee9f3","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    storage_provider detach_volumes method and purge volume information"},{"line_number":310,"context_line":"    if not already implemented."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"  - Updating the iPXE template logic to support to support the creation of"},{"line_number":313,"context_line":"    the various file formats required for Scenarios 1-3, 6.  See:"},{"line_number":314,"context_line":"    `IPXE sanhook command`_, `IPXE san connection URLs`_"},{"line_number":315,"context_line":"    `Document rbdroot option`_ and `nfsroot kernel command line option`_."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9abb7d3a_d286a212","line":312,"range":{"start_line":312,"start_character":37,"end_line":312,"end_character":47},"updated":"2016-05-27 05:43:19.000000000","message":"It can be removed.","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    storage_provider detach_volumes method and purge volume information"},{"line_number":310,"context_line":"    if not already implemented."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"  - Updating the iPXE template logic to support to support the creation of"},{"line_number":313,"context_line":"    the various file formats required for Scenarios 1-3, 6.  See:"},{"line_number":314,"context_line":"    `IPXE sanhook command`_, `IPXE san connection URLs`_"},{"line_number":315,"context_line":"    `Document rbdroot option`_ and `nfsroot kernel command line option`_."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_b8665627","line":312,"range":{"start_line":312,"start_character":37,"end_line":312,"end_character":47},"in_reply_to":"9abb7d3a_d286a212","updated":"2016-06-10 20:07:41.000000000","message":"Good catch, thank you.","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e5c024e9a5148fae75fb89c4bbaf8a08b32ee9f3","unresolved":false,"context_lines":[{"line_number":353,"context_line":"Data model impact"},{"line_number":354,"context_line":"-----------------"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"A `storage_provider` field will be added to the node object which will"},{"line_number":357,"context_line":"be mapped to the appropriate storage driver."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"State Machine Impact"},{"line_number":360,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9abb7d3a_f2af667b","line":357,"range":{"start_line":356,"start_character":0,"end_line":357,"end_character":44},"updated":"2016-05-27 05:43:19.000000000","message":"Also `storage_interface` will be added to the node object based on the comment from Dmitry L228 ?","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e27bb90c2a65c208d0588f9df57cc5c70ecacf5c","unresolved":false,"context_lines":[{"line_number":353,"context_line":"Data model impact"},{"line_number":354,"context_line":"-----------------"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"A `storage_provider` field will be added to the node object which will"},{"line_number":357,"context_line":"be mapped to the appropriate storage driver."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"State Machine Impact"},{"line_number":360,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_deabf187","line":357,"range":{"start_line":356,"start_character":0,"end_line":357,"end_character":44},"in_reply_to":"9abb7d3a_f2af667b","updated":"2016-06-10 20:07:41.000000000","message":"Correct, will be in the next revision.","commit_id":"91c2f15eea224b6f170e2e4ad5cec8bc68c38e8e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"* Presently ironic has no support in the reference drivers to boot an"},{"line_number":22,"context_line":"  node from a remote volume."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Due to the lack of this support, users\u0027 capabilities and usability are"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_8127c5c8","line":21,"updated":"2016-06-14 19:35:00.000000000","message":"nit s/an/a/","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"* Presently ironic has no support in the reference drivers to boot an"},{"line_number":22,"context_line":"  node from a remote volume."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Due to the lack of this support, users\u0027 capabilities and usability are"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_6f2bfeeb","line":21,"in_reply_to":"7aa08908_8127c5c8","updated":"2016-06-17 18:44:28.000000000","message":"Done","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":37,"context_line":"As there is a large variety of potential connection methods and"},{"line_number":38,"context_line":"configurations, the scenarios we have identified appear suitable for"},{"line_number":39,"context_line":"implementation in a reference driver. If a generic scenario is missing,"},{"line_number":40,"context_line":"please raise it to our attention. We are primarily focused on the use of"},{"line_number":41,"context_line":"cinder, but intend to make the storage substrate pluggable and generic."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Not covered as part of this specification is handling of support for"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_e49fb7b1","line":40,"updated":"2016-06-14 19:35:00.000000000","message":"I don\u0027t think this \u0027If a generic scenario is missing..\u0027 sentence belongs in this spec. Did you mean to get feedback from folks that are reviewing this spec, but not to have this sentence after the spec was approved?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"As there is a large variety of potential connection methods and"},{"line_number":38,"context_line":"configurations, the scenarios we have identified appear suitable for"},{"line_number":39,"context_line":"implementation in a reference driver. If a generic scenario is missing,"},{"line_number":40,"context_line":"please raise it to our attention. We are primarily focused on the use of"},{"line_number":41,"context_line":"cinder, but intend to make the storage substrate pluggable and generic."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Not covered as part of this specification is handling of support for"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_efdb6eeb","line":40,"in_reply_to":"7aa08908_e49fb7b1","updated":"2016-06-17 18:44:28.000000000","message":"Well, there has been somewhat of an agreement with the cores I spoke with that we might find it necessary to update the specification later on as we iterate, so the intention was to eventually remove it.   I think at this point  it has served it\u0027s purpose and I\u0027ll remove it.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":45,"context_line":"outside of Ironic\u0027s scope at this point in time."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Additionally not covered is the requirement to use UEFI HTTP boot support,"},{"line_number":48,"context_line":"which was discussed during the `ironic mitaka midcycle`_. In this use case,"},{"line_number":49,"context_line":"only the iPXE UEFI boot loader would be booted using this method which makes"},{"line_number":50,"context_line":"its use redundant in the current boot loading process."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_24109fff","line":48,"updated":"2016-06-14 19:35:00.000000000","message":"I\u0027m not sure what \u0027this\u0027 use case refers to -- what was discussed at the midcycle?\n\nvs \u0027this\u0027 method (in next line). What method is that?\n\nAnd by \u0027current boot loading\u0027, do you mean what ironic does now, which would mean that the use case is redundant (ie, not needed cuz it can already be done?)","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"outside of Ironic\u0027s scope at this point in time."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Additionally not covered is the requirement to use UEFI HTTP boot support,"},{"line_number":48,"context_line":"which was discussed during the `ironic mitaka midcycle`_. In this use case,"},{"line_number":49,"context_line":"only the iPXE UEFI boot loader would be booted using this method which makes"},{"line_number":50,"context_line":"its use redundant in the current boot loading process."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_2f03b611","line":48,"in_reply_to":"7aa08908_24109fff","updated":"2016-06-17 18:44:28.000000000","message":"UEFI HTTP booting, I\u0027ll adjust the text to make it more clear.  The redundant case would be UEFI HTTP Boot.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"12605c467e33232c2dbff8d039b88e289097cdab","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":64,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":65,"context_line":"      volume via external means."},{"line_number":66,"context_line":"    - Tenant network isolation is unsupported due to the need for iPXE boot."},{"line_number":67,"context_line":"        - Potentially in the future, a framework could be created to enable"},{"line_number":68,"context_line":"          tenant network isolation, however that is considered out of"},{"line_number":69,"context_line":"          scope at this time."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_41ad799a","line":66,"range":{"start_line":66,"start_character":6,"end_line":66,"end_character":76},"updated":"2016-06-16 12:39:11.000000000","message":"It may be supported with some kind of proxie. Nova metadata works in the same way. So theoretically it is possible.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":64,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":65,"context_line":"      volume via external means."},{"line_number":66,"context_line":"    - Tenant network isolation is unsupported due to the need for iPXE boot."},{"line_number":67,"context_line":"        - Potentially in the future, a framework could be created to enable"},{"line_number":68,"context_line":"          tenant network isolation, however that is considered out of"},{"line_number":69,"context_line":"          scope at this time."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_aa31545b","line":66,"range":{"start_line":66,"start_character":6,"end_line":66,"end_character":76},"in_reply_to":"7aa08908_41ad799a","updated":"2016-06-17 18:44:28.000000000","message":"Yup, line 67. :)  I know Sam has been working on a proxy of some sort.  Combined with appropriate firewall rules, I believe it is quite possible in the future.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"},{"line_number":71,"context_line":"      of ``iscsi_boot`` set to a value of ``true``."},{"line_number":72,"context_line":"    - Node has a defined volume target with an ``boot_index``"},{"line_number":73,"context_line":"      value of ``0``"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Requirements:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_04912347","line":72,"updated":"2016-06-14 19:35:00.000000000","message":"nit, s/with an/with a/","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"},{"line_number":71,"context_line":"      of ``iscsi_boot`` set to a value of ``true``."},{"line_number":72,"context_line":"    - Node has a defined volume target with an ``boot_index``"},{"line_number":73,"context_line":"      value of ``0``"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Requirements:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_ca22e0b8","line":72,"in_reply_to":"7aa08908_04912347","updated":"2016-06-17 18:44:28.000000000","message":"Done","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"64f9c3f302a59f6cb76334b43d9c6be2a3bd74c5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    - Tenant network isolation is unsupported due to iPXE requirements."},{"line_number":121,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"},{"line_number":122,"context_line":"      setting of ``rbd_boot`` set to a value of ``true``."},{"line_number":123,"context_line":"    - Booting kernel/ramdisk must support Ceph RBD booting as set forth in"},{"line_number":124,"context_line":"      `document rbdroot option`_ post."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  Requirements:"},{"line_number":127,"context_line":"    - Scenario 1 or 2 implemented"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_610b557e","line":124,"range":{"start_line":123,"start_character":0,"end_line":124,"end_character":38},"updated":"2016-06-16 15:24:28.000000000","message":"I don\u0027t see this patch with \"rbdboot\" option was accepted","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    - Tenant network isolation is unsupported due to iPXE requirements."},{"line_number":121,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"},{"line_number":122,"context_line":"      setting of ``rbd_boot`` set to a value of ``true``."},{"line_number":123,"context_line":"    - Booting kernel/ramdisk must support Ceph RBD booting as set forth in"},{"line_number":124,"context_line":"      `document rbdroot option`_ post."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  Requirements:"},{"line_number":127,"context_line":"    - Scenario 1 or 2 implemented"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_4c03ad10","line":124,"range":{"start_line":123,"start_character":0,"end_line":124,"end_character":38},"in_reply_to":"7aa08908_610b557e","updated":"2016-06-17 18:44:28.000000000","message":"Apparently not :(  Guess when I was looking I hit a few too many references where people had been carrying the patch locally.  Removing the option. :(","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":124,"context_line":"      `document rbdroot option`_ post."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  Requirements:"},{"line_number":127,"context_line":"    - Scenario 1 or 2 implemented"},{"line_number":128,"context_line":"    - Additional logic for RBD template generation."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Scenario 4 - Boot via hardware Host Bus Adapter (HBA) to volume"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_a4700f09","line":127,"updated":"2016-06-14 19:35:00.000000000","message":"this can be \u0027scenario 1\u0027 only, since 2 needs 1 to be implemented anyway.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":124,"context_line":"      `document rbdroot option`_ post."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  Requirements:"},{"line_number":127,"context_line":"    - Scenario 1 or 2 implemented"},{"line_number":128,"context_line":"    - Additional logic for RBD template generation."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Scenario 4 - Boot via hardware Host Bus Adapter (HBA) to volume"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_f2acf2ee","line":127,"in_reply_to":"7aa08908_a4700f09","updated":"2016-06-17 18:44:28.000000000","message":"No longer applicable, removing Scenario 3.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"64f9c3f302a59f6cb76334b43d9c6be2a3bd74c5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"},{"line_number":134,"context_line":"  to be pre-populated with a bootable operating system. No volume deployment"},{"line_number":135,"context_line":"  operation is expected."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  This scenario is based upon the expectation that the environment and"},{"line_number":138,"context_line":"  the node\u0027s firmware settings are such that it is capable of booting"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_1c78faf7","line":135,"range":{"start_line":134,"start_character":56,"end_line":135,"end_character":24},"updated":"2016-06-16 15:24:28.000000000","message":"hmm, does one of provided scenario need deployment operations?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":131,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  Scenario involves boot to a local volume, however, the volume is expected"},{"line_number":134,"context_line":"  to be pre-populated with a bootable operating system. No volume deployment"},{"line_number":135,"context_line":"  operation is expected."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  This scenario is based upon the expectation that the environment and"},{"line_number":138,"context_line":"  the node\u0027s firmware settings are such that it is capable of booting"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_2f8d73d3","line":135,"range":{"start_line":134,"start_character":56,"end_line":135,"end_character":24},"in_reply_to":"7aa08908_1c78faf7","updated":"2016-06-17 18:44:28.000000000","message":"Possibly, we expect to essentially no-op the deployment process although there many be \"deployment processes\" that need to still be applied so from the standpoint of this specification, we don\u0027t expect to deploy a volume in this scenario.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"64f9c3f302a59f6cb76334b43d9c6be2a3bd74c5","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  Requirements:"},{"line_number":152,"context_line":"    - Creation of driver deploy method functionality that under normal"},{"line_number":153,"context_line":"      circumstances performs a no-op, and defaults the next boot state"},{"line_number":154,"context_line":"      to local disk when the user requests a node to be deployed."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Scenario 5 - Boot via Host Bus Adapter (HBA) to volume with image deployment"},{"line_number":157,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_43457641","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":65},"updated":"2016-06-16 15:24:28.000000000","message":"Should we manage boot parameters to setup hba boot?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d3eafe77ab2f073e712709d51ef9346f744bf071","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  Requirements:"},{"line_number":152,"context_line":"    - Creation of driver deploy method functionality that under normal"},{"line_number":153,"context_line":"      circumstances performs a no-op, and defaults the next boot state"},{"line_number":154,"context_line":"      to local disk when the user requests a node to be deployed."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Scenario 5 - Boot via Host Bus Adapter (HBA) to volume with image deployment"},{"line_number":157,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_b1b9c87b","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":65},"in_reply_to":"5a9d85d2_c4c97b7a","updated":"2016-06-23 19:14:44.000000000","message":"I would love to see that, but I think that would be more of a hardware manager task upon IPA boot-up.  Given the additional complexity, I feel that is out of scope, although could be a very easy RFE I suspect once we have the rest of the tooling in place.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"92569243d80c59a89309cf61979db742b31fa746","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  Requirements:"},{"line_number":152,"context_line":"    - Creation of driver deploy method functionality that under normal"},{"line_number":153,"context_line":"      circumstances performs a no-op, and defaults the next boot state"},{"line_number":154,"context_line":"      to local disk when the user requests a node to be deployed."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Scenario 5 - Boot via Host Bus Adapter (HBA) to volume with image deployment"},{"line_number":157,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_c4c97b7a","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":65},"in_reply_to":"7aa08908_1227fe12","updated":"2016-06-21 10:08:17.000000000","message":"Yeah, I mean bios setup","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  Requirements:"},{"line_number":152,"context_line":"    - Creation of driver deploy method functionality that under normal"},{"line_number":153,"context_line":"      circumstances performs a no-op, and defaults the next boot state"},{"line_number":154,"context_line":"      to local disk when the user requests a node to be deployed."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Scenario 5 - Boot via Host Bus Adapter (HBA) to volume with image deployment"},{"line_number":157,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_1227fe12","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":65},"in_reply_to":"7aa08908_43457641","updated":"2016-06-17 18:44:28.000000000","message":"As in the settings of the HBA itself?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"64f9c3f302a59f6cb76334b43d9c6be2a3bd74c5","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Scenario 5 - Boot via Host Bus Adapter (HBA) to volume with image deployment"},{"line_number":157,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  Scenario involves boot to a local volume where the volume needs to"},{"line_number":160,"context_line":"  be written out by Ironic\u0027s mechanisms."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  Conditions:"},{"line_number":163,"context_line":"    - Metadata service is not required"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_b7ec5fbc","line":160,"range":{"start_line":159,"start_character":0,"end_line":160,"end_character":40},"updated":"2016-06-16 15:24:28.000000000","message":"So, here image will be written to volume?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Scenario 5 - Boot via Host Bus Adapter (HBA) to volume with image deployment"},{"line_number":157,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  Scenario involves boot to a local volume where the volume needs to"},{"line_number":160,"context_line":"  be written out by Ironic\u0027s mechanisms."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  Conditions:"},{"line_number":163,"context_line":"    - Metadata service is not required"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_92792eff","line":160,"range":{"start_line":159,"start_character":0,"end_line":160,"end_character":40},"in_reply_to":"7aa08908_b7ec5fbc","updated":"2016-06-17 18:44:28.000000000","message":"Correct.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":206,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  These are some additional items that it might make sense to develop"},{"line_number":209,"context_line":"  later on after reference driver implementation has been completed."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"     * Boot the agent from a remote volume to facilitate a deployment."},{"line_number":212,"context_line":"     * Creation of a deployment framework to allow IPA to potentially"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_77b1bb46","line":209,"updated":"2016-06-14 19:35:00.000000000","message":"So outside the scope of this spec, right?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":206,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  These are some additional items that it might make sense to develop"},{"line_number":209,"context_line":"  later on after reference driver implementation has been completed."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"     * Boot the agent from a remote volume to facilitate a deployment."},{"line_number":212,"context_line":"     * Creation of a deployment framework to allow IPA to potentially"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_d2cd7631","line":209,"in_reply_to":"7aa08908_77b1bb46","updated":"2016-06-17 18:44:28.000000000","message":"Yes, I\u0027ll reiterate that.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"64f9c3f302a59f6cb76334b43d9c6be2a3bd74c5","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"     .. code-block:: python"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"         utils.check_capability("},{"line_number":228,"context_line":"             task.driver.boot.capabilities, \u0027iscsi_volume_boot\u0027)"},{"line_number":229,"context_line":"         utils.check_compatability("},{"line_number":230,"context_line":"             task.driver.deploy.capabilities, \u0027iscsi_volume_deploy\u0027)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"  - Implementation of logic in the existing reference driver deploy"},{"line_number":233,"context_line":"    validate methods to fail the validation of any node that has volume"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_6e54d9c9","line":230,"range":{"start_line":227,"start_character":0,"end_line":230,"end_character":68},"updated":"2016-06-16 15:24:28.000000000","message":"How this capabilities will be mapped on nodes? I mean I have node N with driver D which supports storage_interface with capabilities C1, C2, does this mean I can boot node with volume via C1, C2 protocols? If node doesn\u0027t support C1, create another storage_interface?\n\nAlso I\u0027m wondering, could we generate connection info (iqn for iscsi) in software initiators case?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"     .. code-block:: python"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"         utils.check_capability("},{"line_number":228,"context_line":"             task.driver.boot.capabilities, \u0027iscsi_volume_boot\u0027)"},{"line_number":229,"context_line":"         utils.check_compatability("},{"line_number":230,"context_line":"             task.driver.deploy.capabilities, \u0027iscsi_volume_deploy\u0027)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"  - Implementation of logic in the existing reference driver deploy"},{"line_number":233,"context_line":"    validate methods to fail the validation of any node that has volume"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_9588f823","line":230,"range":{"start_line":227,"start_character":0,"end_line":230,"end_character":68},"in_reply_to":"7aa08908_6e54d9c9","updated":"2016-06-17 18:44:28.000000000","message":"So on a node level there will be the capabilities defined on the node properties which will allow an operator to define if it is capable of supporting C1, or C1 and C2, or just C2.  This mechanism is purely for one driver to be able to check if another drive supports a feature.\n\nAs for the IQN question, I had not thought about that, and honestly I don\u0027t see why not.  It is contrary to https://review.openstack.org/#/c/200496 though... But I\u0027ve raised that question on revision 39.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"92569243d80c59a89309cf61979db742b31fa746","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"     .. code-block:: python"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"         utils.check_capability("},{"line_number":228,"context_line":"             task.driver.boot.capabilities, \u0027iscsi_volume_boot\u0027)"},{"line_number":229,"context_line":"         utils.check_compatability("},{"line_number":230,"context_line":"             task.driver.deploy.capabilities, \u0027iscsi_volume_deploy\u0027)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"  - Implementation of logic in the existing reference driver deploy"},{"line_number":233,"context_line":"    validate methods to fail the validation of any node that has volume"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_04b703d9","line":230,"range":{"start_line":227,"start_character":0,"end_line":230,"end_character":68},"in_reply_to":"7aa08908_9588f823","updated":"2016-06-21 10:08:17.000000000","message":"Get it, thanks","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    provisioned with erroneous user expectations."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"  - Creation of a storage driver interface:"},{"line_number":240,"context_line":"     - Similar in composition to the DHCP driver interface, where a default"},{"line_number":241,"context_line":"       of ``none`` will result in a driver interface that performs ``no-op``"},{"line_number":242,"context_line":"       behavior, while exposing an empty set of storage capabilities."},{"line_number":243,"context_line":"     - A node level ``storage_interface`` setting with default value,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_5723df04","line":240,"updated":"2016-06-14 19:35:00.000000000","message":"I am probably bikeshedding here, but I don\u0027t like how we use \u0027driver\u0027 for many things.\n\nI think the dhcp stuff is referred to as \u0027DHCP providers\u0027. Would it be fair/OK to call this a storage provider interface vs a storage driver interface?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    provisioned with erroneous user expectations."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"  - Creation of a storage driver interface:"},{"line_number":240,"context_line":"     - Similar in composition to the DHCP driver interface, where a default"},{"line_number":241,"context_line":"       of ``none`` will result in a driver interface that performs ``no-op``"},{"line_number":242,"context_line":"       behavior, while exposing an empty set of storage capabilities."},{"line_number":243,"context_line":"     - A node level ``storage_interface`` setting with default value,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_60302857","line":240,"in_reply_to":"7aa08908_5723df04","updated":"2016-06-17 18:44:28.000000000","message":"Slightly bikesheddy but I absolutely agree.  I think storage provider works just fine. :)","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":240,"context_line":"     - Similar in composition to the DHCP driver interface, where a default"},{"line_number":241,"context_line":"       of ``none`` will result in a driver interface that performs ``no-op``"},{"line_number":242,"context_line":"       behavior, while exposing an empty set of storage capabilities."},{"line_number":243,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":244,"context_line":"       similar to the `Add network provider interface and implementations`_"},{"line_number":245,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":246,"context_line":"       with the driver that that is to be utilized.."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_57ce3f5a","line":243,"updated":"2016-06-14 19:35:00.000000000","message":"I\u0027m not sure what this means. Is this a new node attribute/field? Or a configuration setting? Or ?\n\nOh, if by \u0027similar to the .. network provider changes, I am guessing you mean similar to the node. network_provider attribute that was added.\n\nWhat do you think of node.storage_provider instead of node.storage_interface?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":240,"context_line":"     - Similar in composition to the DHCP driver interface, where a default"},{"line_number":241,"context_line":"       of ``none`` will result in a driver interface that performs ``no-op``"},{"line_number":242,"context_line":"       behavior, while exposing an empty set of storage capabilities."},{"line_number":243,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":244,"context_line":"       similar to the `Add network provider interface and implementations`_"},{"line_number":245,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":246,"context_line":"       with the driver that that is to be utilized.."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_e6cb9070","line":243,"in_reply_to":"7aa08908_57ce3f5a","updated":"2016-06-17 18:44:28.000000000","message":"node object/attribute that ties to a specific driver, akin to the network_interface functionality being added as part of tenant network isolation.  I think it was node.storage_provider prior to the summit, and upon discussion with Dmitry it was decided that naming should be similar.\n\nSee: https://review.openstack.org/#/c/317391/6/ironic/objects/node.py","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":243,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":244,"context_line":"       similar to the `Add network provider interface and implementations`_"},{"line_number":245,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":246,"context_line":"       with the driver that that is to be utilized.."},{"line_number":247,"context_line":"     - Initial and reference storage driver to be based upon cinder,"},{"line_number":248,"context_line":"       leveraging ``python-cinderclient``, to support the following"},{"line_number":249,"context_line":"       fundamental operations detailed below."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_97f54752","line":246,"updated":"2016-06-14 19:35:00.000000000","message":"extra period\nextra \u0027that\u0027 (but maybe you wanted that)","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":243,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":244,"context_line":"       similar to the `Add network provider interface and implementations`_"},{"line_number":245,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":246,"context_line":"       with the driver that that is to be utilized.."},{"line_number":247,"context_line":"     - Initial and reference storage driver to be based upon cinder,"},{"line_number":248,"context_line":"       leveraging ``python-cinderclient``, to support the following"},{"line_number":249,"context_line":"       fundamental operations detailed below."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_a6ace89f","line":246,"in_reply_to":"7aa08908_97f54752","updated":"2016-06-17 18:44:28.000000000","message":"lol, Good catch, thank you!","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"64f9c3f302a59f6cb76334b43d9c6be2a3bd74c5","unresolved":false,"context_lines":[{"line_number":248,"context_line":"       leveraging ``python-cinderclient``, to support the following"},{"line_number":249,"context_line":"       fundamental operations detailed below."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"         - ``sync_config`` - Initially implemented in order to allow the"},{"line_number":252,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":253,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":254,"context_line":"           process being initiated."},{"line_number":255,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":256,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":257,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_f77a6476","line":254,"range":{"start_line":251,"start_character":13,"end_line":254,"end_character":35},"updated":"2016-06-16 15:24:28.000000000","message":"What information it will sync?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d3eafe77ab2f073e712709d51ef9346f744bf071","unresolved":false,"context_lines":[{"line_number":248,"context_line":"       leveraging ``python-cinderclient``, to support the following"},{"line_number":249,"context_line":"       fundamental operations detailed below."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"         - ``sync_config`` - Initially implemented in order to allow the"},{"line_number":252,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":253,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":254,"context_line":"           process being initiated."},{"line_number":255,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":256,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":257,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_9133ec13","line":254,"range":{"start_line":251,"start_character":13,"end_line":254,"end_character":35},"in_reply_to":"5a9d85d2_84f93383","updated":"2016-06-23 19:14:44.000000000","message":"So, it would be important in the nova scenario as well in that if there is a failure of some sort, but yes, all the work for that would be orchestrated by Ironic.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"92569243d80c59a89309cf61979db742b31fa746","unresolved":false,"context_lines":[{"line_number":248,"context_line":"       leveraging ``python-cinderclient``, to support the following"},{"line_number":249,"context_line":"       fundamental operations detailed below."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"         - ``sync_config`` - Initially implemented in order to allow the"},{"line_number":252,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":253,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":254,"context_line":"           process being initiated."},{"line_number":255,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":256,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":257,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_84f93383","line":254,"range":{"start_line":251,"start_character":13,"end_line":254,"end_character":35},"in_reply_to":"7aa08908_e609d032","updated":"2016-06-21 10:08:17.000000000","message":"So, this will differ from nova scenario, where nova obtains initiator info and returns target info.\n\nHere, all the work would be done by ironic itself, right?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":248,"context_line":"       leveraging ``python-cinderclient``, to support the following"},{"line_number":249,"context_line":"       fundamental operations detailed below."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"         - ``sync_config`` - Initially implemented in order to allow the"},{"line_number":252,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":253,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":254,"context_line":"           process being initiated."},{"line_number":255,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":256,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":257,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_e609d032","line":254,"range":{"start_line":251,"start_character":13,"end_line":254,"end_character":35},"in_reply_to":"7aa08908_f77a6476","updated":"2016-06-17 18:44:28.000000000","message":"Connection and target information as defined in https://review.openstack.org/#/c/200496","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"64f9c3f302a59f6cb76334b43d9c6be2a3bd74c5","unresolved":false,"context_lines":[{"line_number":252,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":253,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":254,"context_line":"           process being initiated."},{"line_number":255,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":256,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":257,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":258,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":259,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":260,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":261,"context_line":"           capability that makes sense to define now."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_f7e544dc","line":258,"range":{"start_line":255,"start_character":0,"end_line":258,"end_character":68},"updated":"2016-06-16 15:24:28.000000000","message":"Does, this methods will be used only for standalone mode? How does this work for nova-cinder-ironic case.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":252,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":253,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":254,"context_line":"           process being initiated."},{"line_number":255,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":256,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":257,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":258,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":259,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":260,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":261,"context_line":"           capability that makes sense to define now."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_41c52e5a","line":258,"range":{"start_line":255,"start_character":0,"end_line":258,"end_character":68},"in_reply_to":"7aa08908_f7e544dc","updated":"2016-06-17 18:44:28.000000000","message":"In both cases, it will be used to inform cinder to update any zones or masks for power operations.  Example: If we shutdown the node, we ought  remove the attachments, but re-add them when we power-up.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"64f9c3f302a59f6cb76334b43d9c6be2a3bd74c5","unresolved":false,"context_lines":[{"line_number":256,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":257,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":258,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":259,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":260,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":261,"context_line":"           capability that makes sense to define now."},{"line_number":262,"context_line":"         - ``remove_volume`` - Raises an"},{"line_number":263,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":264,"context_line":"           capability that makes sense to define now."},{"line_number":265,"context_line":"         - ``validate`` - Initially implemented to validate that sufficient"},{"line_number":266,"context_line":"           configuration is present in the configuration to allow for the"},{"line_number":267,"context_line":"           functionality to operate. This validation will be skipped if no"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_57c25854","line":264,"range":{"start_line":259,"start_character":0,"end_line":264,"end_character":53},"updated":"2016-06-16 15:24:28.000000000","message":"how it differ from attach and dettach","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":256,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":257,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":258,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":259,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":260,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":261,"context_line":"           capability that makes sense to define now."},{"line_number":262,"context_line":"         - ``remove_volume`` - Raises an"},{"line_number":263,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":264,"context_line":"           capability that makes sense to define now."},{"line_number":265,"context_line":"         - ``validate`` - Initially implemented to validate that sufficient"},{"line_number":266,"context_line":"           configuration is present in the configuration to allow for the"},{"line_number":267,"context_line":"           functionality to operate. This validation will be skipped if no"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_41736e4e","line":264,"range":{"start_line":259,"start_character":0,"end_line":264,"end_character":53},"in_reply_to":"7aa08908_57c25854","updated":"2016-06-17 18:44:28.000000000","message":"attach/detach is the connection, add/remove is the existence of a volume.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    scenario."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    .. NOTE::"},{"line_number":297,"context_line":"      If this has occurred, there is the distinct possibility,"},{"line_number":298,"context_line":"      depending on the exact architecture and configuration, that the"},{"line_number":299,"context_line":"      node may be in, or close to a hard failure state. This is not a"},{"line_number":300,"context_line":"      state that can be accurately identified by ironic, however it may"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_fa4e326d","line":297,"updated":"2016-06-14 19:35:00.000000000","message":"I\u0027m a bit lost here. Why would a conductor takeover (which usually means a conductor died, has nothing to do with the nodes/volumes?) indicate that the node might be close to a hard failure state?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    scenario."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    .. NOTE::"},{"line_number":297,"context_line":"      If this has occurred, there is the distinct possibility,"},{"line_number":298,"context_line":"      depending on the exact architecture and configuration, that the"},{"line_number":299,"context_line":"      node may be in, or close to a hard failure state. This is not a"},{"line_number":300,"context_line":"      state that can be accurately identified by ironic, however it may"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_01dcc6e2","line":297,"in_reply_to":"7aa08908_fa4e326d","updated":"2016-06-17 18:44:28.000000000","message":"If a conductor is co-located with cinder, the node may be in a failed state that we cannot determine.  More like, if we\u0027ve had a failure, we might not be able to tell at all.  I\u0027m going to try and do a little bit of a re-write to make that more clear.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    boot from volume."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"  - Addition of a helper method that returns and sets if not already"},{"line_number":320,"context_line":"    set the ``boot_option`` instance_info parameter based upon the"},{"line_number":321,"context_line":"    hardware configuration, and supplied volume configuration information,"},{"line_number":322,"context_line":"    enabling matching and identification of what the next appropriate step"},{"line_number":323,"context_line":"    is for each scenario."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_1a105eff","line":320,"updated":"2016-06-14 19:35:00.000000000","message":"s/set the/set the node\u0027s/\n\nor\n\nset the node.instance_info\u0027s boot_option parameter","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    boot from volume."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"  - Addition of a helper method that returns and sets if not already"},{"line_number":320,"context_line":"    set the ``boot_option`` instance_info parameter based upon the"},{"line_number":321,"context_line":"    hardware configuration, and supplied volume configuration information,"},{"line_number":322,"context_line":"    enabling matching and identification of what the next appropriate step"},{"line_number":323,"context_line":"    is for each scenario."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_b331c90d","line":320,"in_reply_to":"7aa08908_1a105eff","updated":"2016-06-17 18:44:28.000000000","message":"I like the second option!   Thank you!","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"  - Updating of the conductor ``_do_node_tear_down`` method to call the"},{"line_number":326,"context_line":"    storage provider detach_volumes method and purge volume information"},{"line_number":327,"context_line":"    if not already implemented."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  - Updating the iPXE template logic to support the creation of"},{"line_number":330,"context_line":"    the various file formats required for Scenarios 1-3, 6.  See:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_dabed6d2","line":327,"updated":"2016-06-14 19:35:00.000000000","message":"what do you mean by \u0027if not already implemented\u0027?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"  - Updating of the conductor ``_do_node_tear_down`` method to call the"},{"line_number":326,"context_line":"    storage provider detach_volumes method and purge volume information"},{"line_number":327,"context_line":"    if not already implemented."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  - Updating the iPXE template logic to support the creation of"},{"line_number":330,"context_line":"    the various file formats required for Scenarios 1-3, 6.  See:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_674677c1","line":327,"in_reply_to":"7aa08908_dabed6d2","updated":"2016-06-17 18:44:28.000000000","message":"If the information storage spec does not include purging of that information upon node teardown, we need to ensure that we remove the volume information when this functionality is implemented.  Looks like that is going to be covered under that specification soon, although I would prefer to keep the item in this specification to ensure that we do this since it is fairly critical that the information is purged upon teardown.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    `Document rbdroot option`_ and `nfsroot kernel command line option`_."},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"As previously noted, each scenario will be submitted separately as"},{"line_number":335,"context_line":"incremental additions to ironic."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"In order to support scenario 5, the agent driver will need to"},{"line_number":338,"context_line":"understand how to deploy to a system with such configuration."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_5a79462e","line":335,"updated":"2016-06-14 19:35:00.000000000","message":"Are all the scenarios above going to be implemented as part of this spec? (Maybe I missed something.)\n\nWhat do you mean by \u0027submitted separatedly\u0027? Is each scenario going to be in a separate spec, and this spec is just putting the framework in place?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    `Document rbdroot option`_ and `nfsroot kernel command line option`_."},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"As previously noted, each scenario will be submitted separately as"},{"line_number":335,"context_line":"incremental additions to ironic."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"In order to support scenario 5, the agent driver will need to"},{"line_number":338,"context_line":"understand how to deploy to a system with such configuration."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_2703cf43","line":335,"in_reply_to":"7aa08908_5a79462e","updated":"2016-06-17 18:44:28.000000000","message":"Single spec, many patches if that makes sense, each patch adding a new part of the puzzle and each scenario\u0027s final implementation will be as separate revisions.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":338,"context_line":"understand how to deploy to a system with such configuration."},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"  - Updating of the deploy driver to enable the logic added for scenarios 1-4"},{"line_number":341,"context_line":"    to be bypassed using a ``force_deployment`` parameter which should be"},{"line_number":342,"context_line":"    removed from the node\u0027s instance_info prior to the node reaching the"},{"line_number":343,"context_line":"    active state."},{"line_number":344,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_da7d36e8","line":341,"updated":"2016-06-14 19:35:00.000000000","message":"what sets/adds the force_deployment parameter?\n\n(And to be honest, that name seems odd but I can wait to see how it will e used...)","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":338,"context_line":"understand how to deploy to a system with such configuration."},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"  - Updating of the deploy driver to enable the logic added for scenarios 1-4"},{"line_number":341,"context_line":"    to be bypassed using a ``force_deployment`` parameter which should be"},{"line_number":342,"context_line":"    removed from the node\u0027s instance_info prior to the node reaching the"},{"line_number":343,"context_line":"    active state."},{"line_number":344,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_62e4a53b","line":341,"in_reply_to":"7aa08908_da7d36e8","updated":"2016-06-17 18:44:28.000000000","message":"To be fully determined, likely an operator or potentially the nova driver.  In a stand-alone case, it makes sense at least to allow a user to say \"I absolutely want a deploy via the agent\".  Absolutely open to other ideas to help facilitate that end goal.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"In order to support scenario 6:"},{"line_number":350,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"},{"line_number":351,"context_line":"    a alternative path in the iPXE template where the previously defined"},{"line_number":352,"context_line":"    settings cause the on-disk PXE booting template to boot the node from"},{"line_number":353,"context_line":"    the NFS root."},{"line_number":354,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_da67f622","line":351,"updated":"2016-06-14 19:35:00.000000000","message":"s/a/an/","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"In order to support scenario 6:"},{"line_number":350,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"},{"line_number":351,"context_line":"    a alternative path in the iPXE template where the previously defined"},{"line_number":352,"context_line":"    settings cause the on-disk PXE booting template to boot the node from"},{"line_number":353,"context_line":"    the NFS root."},{"line_number":354,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_e27ff5dc","line":351,"in_reply_to":"7aa08908_da67f622","updated":"2016-06-17 18:44:28.000000000","message":"Done","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":364,"context_line":"An alternative could be to simply not develop this functionality and to"},{"line_number":365,"context_line":"encourage downstream consumers to independently develop similar tooling"},{"line_number":366,"context_line":"to meet their specific environment\u0027s needs. That being said, both options"},{"line_number":367,"context_line":"are unappealing from the the standpoint of wishing to grow and enhance"},{"line_number":368,"context_line":"ironic."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_1a3cdedf","line":367,"updated":"2016-06-14 19:35:00.000000000","message":"s/the the/the/","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":364,"context_line":"An alternative could be to simply not develop this functionality and to"},{"line_number":365,"context_line":"encourage downstream consumers to independently develop similar tooling"},{"line_number":366,"context_line":"to meet their specific environment\u0027s needs. That being said, both options"},{"line_number":367,"context_line":"are unappealing from the the standpoint of wishing to grow and enhance"},{"line_number":368,"context_line":"ironic."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_c28479d4","line":367,"in_reply_to":"7aa08908_1a3cdedf","updated":"2016-06-17 18:44:28.000000000","message":"Done","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":413,"context_line":"interface `storage_interface` that will be mapped to a selectable storage"},{"line_number":414,"context_line":"driver of the available storage drivers."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Within this storage interface, new methods will be defined to support"},{"line_number":417,"context_line":"expected storage operations.  Below are the methods that are anticipated"},{"line_number":418,"context_line":"to be added and publicly available from drivers::"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_f562c3ab","line":416,"updated":"2016-06-14 19:35:00.000000000","message":"Do you mean that you\u0027d add\n\nironic.drivers.base.BaseDriver.storage_interface and its value would be something of (a new) class StorageInterface. And this new class would have these methods here?","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":413,"context_line":"interface `storage_interface` that will be mapped to a selectable storage"},{"line_number":414,"context_line":"driver of the available storage drivers."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Within this storage interface, new methods will be defined to support"},{"line_number":417,"context_line":"expected storage operations.  Below are the methods that are anticipated"},{"line_number":418,"context_line":"to be added and publicly available from drivers::"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_424369af","line":416,"in_reply_to":"7aa08908_f562c3ab","updated":"2016-06-17 18:44:28.000000000","message":"Based on what I believe is being done for the network_interface functionality, yes.","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a2d53a43d0f21d4afa87befe5b4174eb01c45ef","unresolved":false,"context_lines":[{"line_number":591,"context_line":"As this feature set is being created as a new set of reference drivers"},{"line_number":592,"context_line":"built upon existing drivers and their capability, no compatibility issues"},{"line_number":593,"context_line":"are expected as the API field additions related to this specification will"},{"line_number":594,"context_line":"hidden to an API client that does not request the appropriate API version."},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"Documentation Impact"},{"line_number":597,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_95d37f03","line":594,"updated":"2016-06-14 19:35:00.000000000","message":"s/hidden/be hidden/","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00900404f501a1db949ed23e7330051a213076bd","unresolved":false,"context_lines":[{"line_number":591,"context_line":"As this feature set is being created as a new set of reference drivers"},{"line_number":592,"context_line":"built upon existing drivers and their capability, no compatibility issues"},{"line_number":593,"context_line":"are expected as the API field additions related to this specification will"},{"line_number":594,"context_line":"hidden to an API client that does not request the appropriate API version."},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"Documentation Impact"},{"line_number":597,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_e2a7f5b9","line":594,"in_reply_to":"7aa08908_95d37f03","updated":"2016-06-17 18:44:28.000000000","message":"Done","commit_id":"665e04409093e93be31dd21a353c8192062540b6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a0ca9efcee09dc49ba1d78625619beab886b772c","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"  - Creation of a storage provider interface:"},{"line_number":213,"context_line":"     - Similar in composition to the DHCP provider interface, where a default"},{"line_number":214,"context_line":"       of ``none`` will result in a provider interface that performs ``no-op``"},{"line_number":215,"context_line":"       behavior, while exposing an empty set of storage capabilities."},{"line_number":216,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":217,"context_line":"       similar to the `Add network provider interface and implementations`_"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_67b0c98c","line":214,"updated":"2016-06-21 19:38:36.000000000","message":"this should be a Python None value according to the driver composition spec","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"25f42132292b8c077692c021be41145bdd67ad9f","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"  - Creation of a storage provider interface:"},{"line_number":213,"context_line":"     - Similar in composition to the DHCP provider interface, where a default"},{"line_number":214,"context_line":"       of ``none`` will result in a provider interface that performs ``no-op``"},{"line_number":215,"context_line":"       behavior, while exposing an empty set of storage capabilities."},{"line_number":216,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":217,"context_line":"       similar to the `Add network provider interface and implementations`_"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_54b8522a","line":214,"in_reply_to":"3aaa91ec_67b0c98c","updated":"2016-06-27 17:24:33.000000000","message":"OK, I\u0027ll correct it.","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a0ca9efcee09dc49ba1d78625619beab886b772c","unresolved":false,"context_lines":[{"line_number":254,"context_line":"  - Updating of the ``agent.AgentDeploy`` driver logic to support skipping"},{"line_number":255,"context_line":"    deployment of a node if a storage provider is enabled, volume information"},{"line_number":256,"context_line":"    exists for the volume, and the volume has an index of 0 indicating it is"},{"line_number":257,"context_line":"    the boot volume. In essence, this means that if the node is defined to boot"},{"line_number":258,"context_line":"    from a remote volume, that the driver.deploy.deploy method should"},{"line_number":259,"context_line":"    immediately return DEPLOYDONE as any network booting configuration,"},{"line_number":260,"context_line":"    if applicable, would have be written out via driver.deploy.prepare method."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_47adcd30","line":257,"updated":"2016-06-21 19:38:36.000000000","message":"can we do something like\n\n if task.driver.storage_provider is not None and not task.driver.storage_provider.flash_image():\n   # skip flashing image\n\nwhat you have here sounds like we need the deploy driver to be aware of how volume information looks like","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"25f42132292b8c077692c021be41145bdd67ad9f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"  - Updating of the ``agent.AgentDeploy`` driver logic to support skipping"},{"line_number":255,"context_line":"    deployment of a node if a storage provider is enabled, volume information"},{"line_number":256,"context_line":"    exists for the volume, and the volume has an index of 0 indicating it is"},{"line_number":257,"context_line":"    the boot volume. In essence, this means that if the node is defined to boot"},{"line_number":258,"context_line":"    from a remote volume, that the driver.deploy.deploy method should"},{"line_number":259,"context_line":"    immediately return DEPLOYDONE as any network booting configuration,"},{"line_number":260,"context_line":"    if applicable, would have be written out via driver.deploy.prepare method."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_3445c6b2","line":257,"in_reply_to":"3aaa91ec_47adcd30","updated":"2016-06-27 17:24:33.000000000","message":"That was pretty much what I was thinking of!  I\u0027ll list this as an example code block.","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1b663d218a2d10bf0653d3e35e0871466a75cdec","unresolved":false,"context_lines":[{"line_number":273,"context_line":"      possibility, depending on the exact architecture and configuration,"},{"line_number":274,"context_line":"      such as with co-located services or network segmentation,"},{"line_number":275,"context_line":"      that the node may be in or close to a hard failure state."},{"line_number":276,"context_line":"      This is not a state that can be accurately identified by ironic."},{"line_number":277,"context_line":"      However, the community may wish to consider warning the operator"},{"line_number":278,"context_line":"      that a catastrophic failure which would require manual intervention"},{"line_number":279,"context_line":"      may have occurred."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"  - Updating of the ``pxe.PXEBoot`` validate interface to leverage a helper"},{"line_number":282,"context_line":"    method when a storage provider and boot volume is defined in the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7aa08908_57f682d7","line":279,"range":{"start_line":276,"start_character":4,"end_line":279,"end_character":24},"updated":"2016-06-17 23:19:24.000000000","message":"@Julia - please ensure I\u0027ve conveyed your intent accurately here.","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"25f42132292b8c077692c021be41145bdd67ad9f","unresolved":false,"context_lines":[{"line_number":273,"context_line":"      possibility, depending on the exact architecture and configuration,"},{"line_number":274,"context_line":"      such as with co-located services or network segmentation,"},{"line_number":275,"context_line":"      that the node may be in or close to a hard failure state."},{"line_number":276,"context_line":"      This is not a state that can be accurately identified by ironic."},{"line_number":277,"context_line":"      However, the community may wish to consider warning the operator"},{"line_number":278,"context_line":"      that a catastrophic failure which would require manual intervention"},{"line_number":279,"context_line":"      may have occurred."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"  - Updating of the ``pxe.PXEBoot`` validate interface to leverage a helper"},{"line_number":282,"context_line":"    method when a storage provider and boot volume is defined in the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_f7950087","line":279,"range":{"start_line":276,"start_character":4,"end_line":279,"end_character":24},"in_reply_to":"3aaa91ec_4c8974ca","updated":"2016-06-27 17:24:33.000000000","message":"Agreed, although I\u0027ve seen a number of smaller deployment architectures that leverage co-located services on the same controllers.  There could also be the possibility that a network segmentation may cause similar failures. :\\","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7489242c808bc0265d177f1ddc41a091a28bc37","unresolved":false,"context_lines":[{"line_number":273,"context_line":"      possibility, depending on the exact architecture and configuration,"},{"line_number":274,"context_line":"      such as with co-located services or network segmentation,"},{"line_number":275,"context_line":"      that the node may be in or close to a hard failure state."},{"line_number":276,"context_line":"      This is not a state that can be accurately identified by ironic."},{"line_number":277,"context_line":"      However, the community may wish to consider warning the operator"},{"line_number":278,"context_line":"      that a catastrophic failure which would require manual intervention"},{"line_number":279,"context_line":"      may have occurred."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"  - Updating of the ``pxe.PXEBoot`` validate interface to leverage a helper"},{"line_number":282,"context_line":"    method when a storage provider and boot volume is defined in the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_4c8974ca","line":279,"range":{"start_line":276,"start_character":4,"end_line":279,"end_character":24},"in_reply_to":"5a9d85d2_1a0ae0d2","updated":"2016-06-21 19:38:27.000000000","message":"I\u0027m not even sure this note is worth mentioning. Is it the case that conductors would be co-located with the volume \u0027provider\u0027. That seems like an odd setup. Whoever does that should know what they are doing.","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b32faf8624d96d99c88ae4e200d68f5b10942e35","unresolved":false,"context_lines":[{"line_number":273,"context_line":"      possibility, depending on the exact architecture and configuration,"},{"line_number":274,"context_line":"      such as with co-located services or network segmentation,"},{"line_number":275,"context_line":"      that the node may be in or close to a hard failure state."},{"line_number":276,"context_line":"      This is not a state that can be accurately identified by ironic."},{"line_number":277,"context_line":"      However, the community may wish to consider warning the operator"},{"line_number":278,"context_line":"      that a catastrophic failure which would require manual intervention"},{"line_number":279,"context_line":"      may have occurred."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"  - Updating of the ``pxe.PXEBoot`` validate interface to leverage a helper"},{"line_number":282,"context_line":"    method when a storage provider and boot volume is defined in the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a9d85d2_1a0ae0d2","line":279,"range":{"start_line":276,"start_character":4,"end_line":279,"end_character":24},"in_reply_to":"7aa08908_57f682d7","updated":"2016-06-20 15:40:17.000000000","message":"I believe so, although I would like to hear from others if it makes sense since we all process information differently.","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a0ca9efcee09dc49ba1d78625619beab886b772c","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"Changes to the driver API will be limited to the introduction of a new"},{"line_number":389,"context_line":"interface `storage_interface` that will be mapped to a selectable storage"},{"line_number":390,"context_line":"driver of the available storage drivers."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Within this storage interface, new methods will be defined to support"},{"line_number":393,"context_line":"expected storage operations.  Below are the methods that are anticipated"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_a7aab117","line":390,"updated":"2016-06-21 19:38:36.000000000","message":"please also cover the new \"interface capabilities\" thing","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"25f42132292b8c077692c021be41145bdd67ad9f","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"Changes to the driver API will be limited to the introduction of a new"},{"line_number":389,"context_line":"interface `storage_interface` that will be mapped to a selectable storage"},{"line_number":390,"context_line":"driver of the available storage drivers."},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"Within this storage interface, new methods will be defined to support"},{"line_number":393,"context_line":"expected storage operations.  Below are the methods that are anticipated"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_f74a2025","line":390,"in_reply_to":"3aaa91ec_a7aab117","updated":"2016-06-27 17:24:33.000000000","message":"Good catch, will do.","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"25f42132292b8c077692c021be41145bdd67ad9f","unresolved":false,"context_lines":[{"line_number":468,"context_line":""},{"line_number":469,"context_line":"There is a strong likelihood, in a case where a conductor failover occurs,"},{"line_number":470,"context_line":"that the ``_do_takeover`` will be impacted in cases where drivers for"},{"line_number":471,"context_line":"scenarios 1-3 and 6 are utilized.  Largely this will be due to the queries"},{"line_number":472,"context_line":"out to cinder for each node to validate the known configuration information,"},{"line_number":473,"context_line":"and to potentially update the configuration on disk."},{"line_number":474,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_8d450fb5","line":471,"range":{"start_line":471,"start_character":10,"end_line":471,"end_character":19},"updated":"2016-06-27 17:24:33.000000000","message":"Correcting as this was missed in the removal of Ceph.","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a0ca9efcee09dc49ba1d78625619beab886b772c","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"  [storage]"},{"line_number":494,"context_line":"  storage_providers # Defaults to none and is a list of the"},{"line_number":495,"context_line":"  available drivers."},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"  [cinder]"},{"line_number":498,"context_line":"  url\u003dhttp://api.address:port"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_87a7b54e","line":495,"updated":"2016-06-21 19:38:36.000000000","message":"should be enabled_storage_interfaces to be in sync with the driver composition","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"25f42132292b8c077692c021be41145bdd67ad9f","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"  [storage]"},{"line_number":494,"context_line":"  storage_providers # Defaults to none and is a list of the"},{"line_number":495,"context_line":"  available drivers."},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"  [cinder]"},{"line_number":498,"context_line":"  url\u003dhttp://api.address:port"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_f2162e57","line":495,"in_reply_to":"3aaa91ec_87a7b54e","updated":"2016-06-27 17:24:33.000000000","message":"Done","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"9711f1909e8940fa829ec82768f22d5cb41e0d7c","unresolved":false,"context_lines":[{"line_number":556,"context_line":"gate test could be where an ironic deployment boots from a Cinder volume,"},{"line_number":557,"context_line":"which a tempest test could orchestrate."},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"Scenarios 4 and 5 are the most difficult to test as they have detached"},{"line_number":560,"context_line":"infrastucture expectations outside of our direct control. However, we may"},{"line_number":561,"context_line":"find that the base overlay is sufficient to test with unit tests due to"},{"line_number":562,"context_line":"what will ultimately be significant underlying common paths."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_c22a4b7e","line":559,"updated":"2016-06-21 19:42:16.000000000","message":"I guess 5 is testable as it does not rely on hardware, but providing an NFS root isn\u0027t something that we already do in the gates so there\u0027s complexity there.","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"25f42132292b8c077692c021be41145bdd67ad9f","unresolved":false,"context_lines":[{"line_number":556,"context_line":"gate test could be where an ironic deployment boots from a Cinder volume,"},{"line_number":557,"context_line":"which a tempest test could orchestrate."},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"Scenarios 4 and 5 are the most difficult to test as they have detached"},{"line_number":560,"context_line":"infrastucture expectations outside of our direct control. However, we may"},{"line_number":561,"context_line":"find that the base overlay is sufficient to test with unit tests due to"},{"line_number":562,"context_line":"what will ultimately be significant underlying common paths."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3aaa91ec_4d3687e8","line":559,"in_reply_to":"3aaa91ec_c22a4b7e","updated":"2016-06-27 17:24:33.000000000","message":"Ugh, that should have been 3 and 4 since we removed the Ceph scenario.\n\nUpdating.","commit_id":"d2ae6b53de0402a0a72c08f79ae646fd4ec33654"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ffd22951babb0d40529a0314c615109ca4104408","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Not covered as part of this specification is handling of support for"},{"line_number":44,"context_line":"MultiPath IO, sometimes referred to as MPIO. We feel this is largely"},{"line_number":45,"context_line":"outside of Ironic\u0027s scope at this point in time."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Additionally not covered is the requirement to use UEFI HTTP boot support,"},{"line_number":48,"context_line":"which was set forth during the `ironic mitaka midcycle`_. Using UEFI HTTP boot"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_169ceb5b","line":45,"updated":"2016-07-21 14:06:47.000000000","message":"Does multipath support require a mechanism similar to implementing network bonding such as portgroup and configdrive?","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"de284c7c15676c079691ccf76fab96e746367f1a","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Not covered as part of this specification is handling of support for"},{"line_number":44,"context_line":"MultiPath IO, sometimes referred to as MPIO. We feel this is largely"},{"line_number":45,"context_line":"outside of Ironic\u0027s scope at this point in time."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Additionally not covered is the requirement to use UEFI HTTP boot support,"},{"line_number":48,"context_line":"which was set forth during the `ironic mitaka midcycle`_. Using UEFI HTTP boot"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_574b612b","line":45,"in_reply_to":"dada55a8_169ceb5b","updated":"2016-07-25 13:54:23.000000000","message":"True multipath support requires images that understand multipathing, have the correct environment specific multipath configuration.  We don\u0027t need to implement anything like port binding, but an operator could potentially pass some of what was needed via a configuration drive.  Some multi-pathing with native HBAs should generally just work.  Use cases with software initiators though, that is a little more difficult to convey the information across.  Hence why it is out of scope at this time.","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ffd22951babb0d40529a0314c615109ca4104408","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  Conditions:"},{"line_number":88,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":89,"context_line":"      ironic conductor. Similar to the PXE driver netboot option."},{"line_number":90,"context_line":"    - Metadata service use expected"},{"line_number":91,"context_line":"    - Configuration drive is not supported"},{"line_number":92,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":93,"context_line":"      via external means."}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_64cc76bb","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":35},"updated":"2016-07-21 14:06:47.000000000","message":"nit: is expected.","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"23df82905d7eb683dc82a50a4d8461b78c936a70","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  Conditions:"},{"line_number":88,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":89,"context_line":"      ironic conductor. Similar to the PXE driver netboot option."},{"line_number":90,"context_line":"    - Metadata service use expected"},{"line_number":91,"context_line":"    - Configuration drive is not supported"},{"line_number":92,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":93,"context_line":"      via external means."}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_8d55c6c7","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":35},"in_reply_to":"dada55a8_64cc76bb","updated":"2016-07-25 14:00:11.000000000","message":"Done","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ffd22951babb0d40529a0314c615109ca4104408","unresolved":false,"context_lines":[{"line_number":98,"context_line":"      value of ``0``"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  Requirements:"},{"line_number":101,"context_line":"    - Scenario 1 implemented"},{"line_number":102,"context_line":"    - Additional logic for iPXE template generation in the FCoE use case"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Scenario 3 - Boot via hardware Host Bus Adapter (HBA) to volume"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_81bd32da","line":101,"updated":"2016-07-21 14:06:47.000000000","message":"nit: I prefer using `Scenario 1 - iPXE boot from iSCSI volume`_","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"23df82905d7eb683dc82a50a4d8461b78c936a70","unresolved":false,"context_lines":[{"line_number":98,"context_line":"      value of ``0``"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  Requirements:"},{"line_number":101,"context_line":"    - Scenario 1 implemented"},{"line_number":102,"context_line":"    - Additional logic for iPXE template generation in the FCoE use case"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Scenario 3 - Boot via hardware Host Bus Adapter (HBA) to volume"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_4d4bce2b","line":101,"in_reply_to":"dada55a8_81bd32da","updated":"2016-07-25 14:00:11.000000000","message":"Good catch, thank you!","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ffd22951babb0d40529a0314c615109ca4104408","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  directly to a presented volume via the HBA once powered on."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  Conditions:"},{"line_number":116,"context_line":"    - Metadata service use expected"},{"line_number":117,"context_line":"    - Configuration drive support is unavailable"},{"line_number":118,"context_line":"    - Node boot defaults to block storage device"},{"line_number":119,"context_line":"    - Tenant network isolation would be supported"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_046c9a9a","line":116,"range":{"start_line":116,"start_character":26,"end_line":116,"end_character":35},"updated":"2016-07-21 14:06:47.000000000","message":"nit: is expected","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"de284c7c15676c079691ccf76fab96e746367f1a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  directly to a presented volume via the HBA once powered on."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  Conditions:"},{"line_number":116,"context_line":"    - Metadata service use expected"},{"line_number":117,"context_line":"    - Configuration drive support is unavailable"},{"line_number":118,"context_line":"    - Node boot defaults to block storage device"},{"line_number":119,"context_line":"    - Tenant network isolation would be supported"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_376d0d9a","line":116,"range":{"start_line":116,"start_character":26,"end_line":116,"end_character":35},"in_reply_to":"dada55a8_046c9a9a","updated":"2016-07-25 13:54:23.000000000","message":"Done","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ffd22951babb0d40529a0314c615109ca4104408","unresolved":false,"context_lines":[{"line_number":121,"context_line":"      via external means."},{"line_number":122,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":123,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  Requirements:"},{"line_number":126,"context_line":"    - Creation of driver deploy method functionality that under normal"},{"line_number":127,"context_line":"      circumstances performs a no-op, and defaults the next boot state"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_84b36a09","line":124,"updated":"2016-07-21 14:06:47.000000000","message":"Isn\u0027t it necessary to set anything to node.properties[\u0027capabilities\u0027] in this scenario?","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"de284c7c15676c079691ccf76fab96e746367f1a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"      via external means."},{"line_number":122,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":123,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  Requirements:"},{"line_number":126,"context_line":"    - Creation of driver deploy method functionality that under normal"},{"line_number":127,"context_line":"      circumstances performs a no-op, and defaults the next boot state"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_97add98a","line":124,"in_reply_to":"dada55a8_84b36a09","updated":"2016-07-25 13:54:23.000000000","message":"Great catch, and truthfully it is a different kind of boot in a sense, in that we need to know that there is an HBA present in order to handle the node appropriately.   This will be in the next revision.","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ffd22951babb0d40529a0314c615109ca4104408","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    - Network isolation is supported"},{"line_number":141,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":142,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  Requirements:"},{"line_number":145,"context_line":"    - This method is expected to be essentially identical to the scenario"},{"line_number":146,"context_line":"      defined in"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_212f2689","line":143,"updated":"2016-07-21 14:06:47.000000000","message":"Isn\u0027t it necessary to set anything to node.properties[\u0027capabilities\u0027] in this scenario?","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"de284c7c15676c079691ccf76fab96e746367f1a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    - Network isolation is supported"},{"line_number":141,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":142,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  Requirements:"},{"line_number":145,"context_line":"    - This method is expected to be essentially identical to the scenario"},{"line_number":146,"context_line":"      defined in"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_17356945","line":143,"in_reply_to":"dada55a8_212f2689","updated":"2016-07-25 13:54:23.000000000","message":"Done","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ffd22951babb0d40529a0314c615109ca4104408","unresolved":false,"context_lines":[{"line_number":152,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  Scenario involves use of a kernel and ramdisk image hosted by the conductor"},{"line_number":155,"context_line":"  host in order enable the node to boot via iPXE with sufficient command line"},{"line_number":156,"context_line":"  parameters to enable the root volume to attach during the boot sequence."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  This is a logical progression given that users have indicated that they"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_0976733d","line":155,"range":{"start_line":155,"start_character":7,"end_line":155,"end_character":22},"updated":"2016-07-21 14:06:47.000000000","message":"nit: in order to enable","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"de284c7c15676c079691ccf76fab96e746367f1a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  Scenario involves use of a kernel and ramdisk image hosted by the conductor"},{"line_number":155,"context_line":"  host in order enable the node to boot via iPXE with sufficient command line"},{"line_number":156,"context_line":"  parameters to enable the root volume to attach during the boot sequence."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  This is a logical progression given that users have indicated that they"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_f737f54a","line":155,"range":{"start_line":155,"start_character":7,"end_line":155,"end_character":22},"in_reply_to":"dada55a8_0976733d","updated":"2016-07-25 13:54:23.000000000","message":"Done","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":14427,"name":"Blake Caldwell","email":"blakec@ornl.gov","username":"caldweb"},"change_message_id":"6c81bef111413f699b14efe55d23255478af54e5","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    - Tenant network isolation is unsupported due to iPXE need."},{"line_number":169,"context_line":"    - Node is configured with ``node.properties[\u0027capabilities\u0027]`` setting of"},{"line_number":170,"context_line":"      ``nfs_boot`` set to a value of true coupled with ``instance_info`` of"},{"line_number":171,"context_line":"      setting of ``nfs_root`` which provides nfs root connection information."},{"line_number":172,"context_line":"    - Kernel and ramdisk utilized support the"},{"line_number":173,"context_line":"      `nfsroot kernel command line option`_."},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3aaa91ec_2d32a2f2","line":171,"updated":"2016-06-29 15:37:40.000000000","message":"or metadata via `Override PXE kernel cmdline via Glance property`_,","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ffd22951babb0d40529a0314c615109ca4104408","unresolved":false,"context_lines":[{"line_number":182,"context_line":"     * Boot the agent from a remote volume to facilitate a deployment."},{"line_number":183,"context_line":"     * Creation of a deployment framework to allow IPA to potentially"},{"line_number":184,"context_line":"       apply HBA settings"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Proposed change"},{"line_number":187,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_41033ab8","line":185,"updated":"2016-07-21 14:06:47.000000000","message":"Why don\u0027t we add some features which are not supported in this SPEC but necessary later?\n\n* Multipath IO\n* Tenant network isolation\n* Configuration drive","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"de284c7c15676c079691ccf76fab96e746367f1a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"     * Boot the agent from a remote volume to facilitate a deployment."},{"line_number":183,"context_line":"     * Creation of a deployment framework to allow IPA to potentially"},{"line_number":184,"context_line":"       apply HBA settings"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Proposed change"},{"line_number":187,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_f7d375d3","line":185,"in_reply_to":"dada55a8_41033ab8","updated":"2016-07-25 13:54:23.000000000","message":"Agreed and will be in the next update, however configuration drives are problematic due to minimum volume size.  Potentially it could be done another way, but I think that might end up being a very long discussion.","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"0927d1feb09ac40112fe74e02e1410c561f0a9eb","unresolved":false,"context_lines":[{"line_number":225,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":226,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":227,"context_line":"           process being initiated."},{"line_number":228,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":229,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":230,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":231,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":232,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":233,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":234,"context_line":"           capability that makes sense to define now, intended for volume"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1aa78d24_282000b0","line":231,"range":{"start_line":228,"start_character":0,"end_line":231,"end_character":68},"updated":"2016-07-11 06:51:01.000000000","message":"From the view of cinder, an attachment operation need two steps:\n1. initialize connection[1] which is used to expose a volume, like adding a volume to iscsi tgt server.\n2. a callback api[2] which is *usually* used to update cinder\u0027s database. This api is used to inform cinder about \"Which instance is using the volume?\", \"Where is the mountpoint of the volume?\". And of course different drivers get a little different actions.\n\nThis design may be difficult to be accepted by cinder-group. Why not implement a loop ourselves to attach/detach volumes one by one?\n[1]: https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_actions.py#L170\n[2]: https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_actions.py#L46","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ce22806daebd286e1664bfd301be29813f655ea2","unresolved":false,"context_lines":[{"line_number":225,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":226,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":227,"context_line":"           process being initiated."},{"line_number":228,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":229,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":230,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":231,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":232,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":233,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":234,"context_line":"           capability that makes sense to define now, intended for volume"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1aa78d24_f8d218ff","line":231,"range":{"start_line":228,"start_character":0,"end_line":231,"end_character":68},"in_reply_to":"1aa78d24_282000b0","updated":"2016-07-11 22:03:09.000000000","message":"From my point of view, those are the intended steps of the methods and essentially what I discussed with the cinder community at the Mitaka midcycle.  Of course, we can\u0027t update the API with the mountpoint, at least in all cases.\n\nAre you referring to us implementing a loop or cinder implementing a loop?","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"de284c7c15676c079691ccf76fab96e746367f1a","unresolved":false,"context_lines":[{"line_number":225,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":226,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":227,"context_line":"           process being initiated."},{"line_number":228,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":229,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":230,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":231,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":232,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":233,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":234,"context_line":"           capability that makes sense to define now, intended for volume"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_3707cd1e","line":231,"range":{"start_line":228,"start_character":0,"end_line":231,"end_character":68},"in_reply_to":"1aa78d24_f7cd7ebb","updated":"2016-07-25 13:54:23.000000000","message":"So this is not cinder exclusive, it is designed with the possibility of something besides cinder being used.  Such as if someone wishes to implement their own storage driver to drive a specific SAN fabric.  If we can pass-through the call, then that will be great, but from a use and intent standpoint, I think the plurality makes sense.","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"d143934dfa948ededcc015d2fdb77a1cfe475518","unresolved":false,"context_lines":[{"line_number":225,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":226,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":227,"context_line":"           process being initiated."},{"line_number":228,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":229,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":230,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":231,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":232,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":233,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":234,"context_line":"           capability that makes sense to define now, intended for volume"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1aa78d24_f7cd7ebb","line":231,"range":{"start_line":228,"start_character":0,"end_line":231,"end_character":68},"in_reply_to":"1aa78d24_f8d218ff","updated":"2016-07-14 02:27:17.000000000","message":"Sorry, I don\u0027t known that you have made an agreement.\nSo, cinderclient will have a new api \"attach_volumes\", then the loop should be implemented in cinder, according to the name \"attach_volumes\" but not \"attach_volume\".","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":14427,"name":"Blake Caldwell","email":"blakec@ornl.gov","username":"caldweb"},"change_message_id":"6c81bef111413f699b14efe55d23255478af54e5","unresolved":false,"context_lines":[{"line_number":319,"context_line":"In order to support scenario 4, the agent driver will need to"},{"line_number":320,"context_line":"understand how to deploy to a system with such configuration."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  - Updating of the deploy driver to enable the logic added for scenarios 1-4"},{"line_number":323,"context_line":"    to be bypassed using a ``force_deployment`` parameter which should be"},{"line_number":324,"context_line":"    removed from the node\u0027s instance_info prior to the node reaching the"},{"line_number":325,"context_line":"    active state."}],"source_content_type":"text/x-rst","patch_set":13,"id":"3aaa91ec_c87d42b3","line":322,"range":{"start_line":322,"start_character":74,"end_line":322,"end_character":77},"updated":"2016-06-29 15:37:40.000000000","message":"nit: 1-3?","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"839b409de755b2d6d912ab645c1d714a16d8ad54","unresolved":false,"context_lines":[{"line_number":319,"context_line":"In order to support scenario 4, the agent driver will need to"},{"line_number":320,"context_line":"understand how to deploy to a system with such configuration."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  - Updating of the deploy driver to enable the logic added for scenarios 1-4"},{"line_number":323,"context_line":"    to be bypassed using a ``force_deployment`` parameter which should be"},{"line_number":324,"context_line":"    removed from the node\u0027s instance_info prior to the node reaching the"},{"line_number":325,"context_line":"    active state."}],"source_content_type":"text/x-rst","patch_set":13,"id":"3aaa91ec_edc69098","line":322,"range":{"start_line":322,"start_character":74,"end_line":322,"end_character":77},"in_reply_to":"3aaa91ec_c87d42b3","updated":"2016-06-30 20:03:23.000000000","message":"Good catch, thanks!","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":14427,"name":"Blake Caldwell","email":"blakec@ornl.gov","username":"caldweb"},"change_message_id":"6c81bef111413f699b14efe55d23255478af54e5","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"},{"line_number":333,"context_line":"    an alternative path in the iPXE template where the previously defined"},{"line_number":334,"context_line":"    settings cause the on-disk PXE booting template to boot the node from"},{"line_number":335,"context_line":"    the NFS root."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"Later potential improvements above and beyond this initial specification:"},{"line_number":338,"context_line":"  - Creation of logic to allow Ironic users to leverage the storage provider"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3aaa91ec_7b697625","line":335,"updated":"2016-06-29 15:37:40.000000000","message":"I would like this to be more general where PXE parameters for booting the node can be specified from different metadata sources: image_info or instance_info (https://review.openstack.org/#/c/178229/).\n\n\"Settings for booting the node via NFS root will be provided as PXE parameters specified by the on-disk PXE template, or other metadata via external means (glance or instance_info).\"","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0f0f7cac14c15d32f4e4af77d57afda715261eac","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"},{"line_number":333,"context_line":"    an alternative path in the iPXE template where the previously defined"},{"line_number":334,"context_line":"    settings cause the on-disk PXE booting template to boot the node from"},{"line_number":335,"context_line":"    the NFS root."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"Later potential improvements above and beyond this initial specification:"},{"line_number":338,"context_line":"  - Creation of logic to allow Ironic users to leverage the storage provider"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3aaa91ec_40c2de87","line":335,"in_reply_to":"3aaa91ec_23ac278b","updated":"2016-07-01 14:18:20.000000000","message":"Awesome!   I highly suspect override would land before this, but you never know. :)\nThe use cases are different, and it allows for better validation, but overall it sounds like a plan to me.","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"de284c7c15676c079691ccf76fab96e746367f1a","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"},{"line_number":333,"context_line":"    an alternative path in the iPXE template where the previously defined"},{"line_number":334,"context_line":"    settings cause the on-disk PXE booting template to boot the node from"},{"line_number":335,"context_line":"    the NFS root."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"Later potential improvements above and beyond this initial specification:"},{"line_number":338,"context_line":"  - Creation of logic to allow Ironic users to leverage the storage provider"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_d2ed9f8f","line":335,"in_reply_to":"3aaa91ec_40c2de87","updated":"2016-07-25 13:54:23.000000000","message":"Blake, I\u0027m not going to mention anything regarding this for now since a new version of the override patch has not been uploaded.  Should it begin making traction, I\u0027ll happily amend the specification.","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":14427,"name":"Blake Caldwell","email":"blakec@ornl.gov","username":"caldweb"},"change_message_id":"15f7abcd654133e47e4fdaa38a4d5c5236fa3372","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"},{"line_number":333,"context_line":"    an alternative path in the iPXE template where the previously defined"},{"line_number":334,"context_line":"    settings cause the on-disk PXE booting template to boot the node from"},{"line_number":335,"context_line":"    the NFS root."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"Later potential improvements above and beyond this initial specification:"},{"line_number":338,"context_line":"  - Creation of logic to allow Ironic users to leverage the storage provider"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3aaa91ec_23ac278b","line":335,"in_reply_to":"3aaa91ec_4d652443","updated":"2016-06-30 20:49:40.000000000","message":"Agreed that they are complementary features. I am working on a revision for the glance-based override patch currently, and will be updating it shortly.\n\nShould the glance override be complete before the implementation of scenario 5, then scenario 5 could perform a similar merge of global, image, and instance-level values for \u0027nfs_root\u0027.\n\nIdeally both instance_info[\u0027kernel_cmdline\u0027] and instance_info[\u0027nfs_root\u0027] would be respected since the targeted use cases are different. However \u0027nfs_root\u0027 as proposed here would allow for more complete node validation.","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"839b409de755b2d6d912ab645c1d714a16d8ad54","unresolved":false,"context_lines":[{"line_number":332,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"},{"line_number":333,"context_line":"    an alternative path in the iPXE template where the previously defined"},{"line_number":334,"context_line":"    settings cause the on-disk PXE booting template to boot the node from"},{"line_number":335,"context_line":"    the NFS root."},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"Later potential improvements above and beyond this initial specification:"},{"line_number":338,"context_line":"  - Creation of logic to allow Ironic users to leverage the storage provider"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3aaa91ec_4d652443","line":335,"in_reply_to":"3aaa91ec_7b697625","updated":"2016-06-30 20:03:23.000000000","message":"I can agree with that, although they seem like two complimentary features with ultimately similar template changes in mind.  Looks like the override feature is approved, just the revision has been sitting for ~10 months. :(\n\nAre you thinking to try and piggy back the support for glance based override on the command line via this feature?","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":14427,"name":"Blake Caldwell","email":"blakec@ornl.gov","username":"caldweb"},"change_message_id":"6c81bef111413f699b14efe55d23255478af54e5","unresolved":false,"context_lines":[{"line_number":527,"context_line":"  juliaashleykreger"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"Other contributors:"},{"line_number":530,"context_line":"  \u003cTBD\u003e"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"Work Items"},{"line_number":533,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3aaa91ec_52e349d9","line":530,"updated":"2016-06-29 15:37:40.000000000","message":"blakec","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ffd22951babb0d40529a0314c615109ca4104408","unresolved":false,"context_lines":[{"line_number":527,"context_line":"  juliaashleykreger"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"Other contributors:"},{"line_number":530,"context_line":"  \u003cTBD\u003e"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"Work Items"},{"line_number":533,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_f8164a4a","line":530,"in_reply_to":"3aaa91ec_52e349d9","updated":"2016-07-21 14:06:47.000000000","message":"I\u0027m interested in this feature, too. (id: shiina-hironori)","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":14427,"name":"Blake Caldwell","email":"blakec@ornl.gov","username":"caldweb"},"change_message_id":"6c81bef111413f699b14efe55d23255478af54e5","unresolved":false,"context_lines":[{"line_number":610,"context_line":".. _`Nova Specs - Ironic - Boot from Cinder volume`: https://review.openstack.org/#/c/211101/"},{"line_number":611,"context_line":".. _`ironic mitaka midcycle`: https://etherpad.openstack.org/p/ironic-mitaka-midcycle"},{"line_number":612,"context_line":".. _`nfsroot kernel command line option`: https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt"},{"line_number":613,"context_line":".. _`Root device hints`: https://specs.openstack.org/openstack/ironic-specs/specs/kilo-implemented/root-device-hints.html"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3aaa91ec_b29c2d0f","line":613,"updated":"2016-06-29 15:37:40.000000000","message":".. _`Override PXE kernel cmdline via Glance property`: https://review.openstack.org/#/c/178229/","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"de284c7c15676c079691ccf76fab96e746367f1a","unresolved":false,"context_lines":[{"line_number":610,"context_line":".. _`Nova Specs - Ironic - Boot from Cinder volume`: https://review.openstack.org/#/c/211101/"},{"line_number":611,"context_line":".. _`ironic mitaka midcycle`: https://etherpad.openstack.org/p/ironic-mitaka-midcycle"},{"line_number":612,"context_line":".. _`nfsroot kernel command line option`: https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt"},{"line_number":613,"context_line":".. _`Root device hints`: https://specs.openstack.org/openstack/ironic-specs/specs/kilo-implemented/root-device-hints.html"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dada55a8_525ecf45","line":613,"in_reply_to":"3aaa91ec_b29c2d0f","updated":"2016-07-25 13:54:23.000000000","message":"Per previous note and discussion, holding off on adding this for the time being.","commit_id":"2fd617c3510fda5f1e0f3153bab40bd664846e14"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  Conditions:"},{"line_number":59,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":60,"context_line":"      ironic conductor. This is similar to the PXE driver netboot option."},{"line_number":61,"context_line":"    - Metadata service use is expected"},{"line_number":62,"context_line":"    - Configuration drive is not supported"},{"line_number":63,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":64,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_6df7b259","line":61,"range":{"start_line":61,"start_character":30,"end_line":61,"end_character":38},"updated":"2016-07-25 14:48:58.000000000","message":"nit: add period","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  Conditions:"},{"line_number":59,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":60,"context_line":"      ironic conductor. This is similar to the PXE driver netboot option."},{"line_number":61,"context_line":"    - Metadata service use is expected"},{"line_number":62,"context_line":"    - Configuration drive is not supported"},{"line_number":63,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":64,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_a4ca529f","line":61,"range":{"start_line":61,"start_character":30,"end_line":61,"end_character":38},"in_reply_to":"dada55a8_6df7b259","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":60,"context_line":"      ironic conductor. This is similar to the PXE driver netboot option."},{"line_number":61,"context_line":"    - Metadata service use is expected"},{"line_number":62,"context_line":"    - Configuration drive is not supported"},{"line_number":63,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":64,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":65,"context_line":"      volume via external means."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_4d890eca","line":62,"range":{"start_line":62,"start_character":33,"end_line":62,"end_character":42},"updated":"2016-07-25 14:48:58.000000000","message":"ditto period","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":60,"context_line":"      ironic conductor. This is similar to the PXE driver netboot option."},{"line_number":61,"context_line":"    - Metadata service use is expected"},{"line_number":62,"context_line":"    - Configuration drive is not supported"},{"line_number":63,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":64,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":65,"context_line":"      volume via external means."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_e4c44a93","line":62,"range":{"start_line":62,"start_character":33,"end_line":62,"end_character":42},"in_reply_to":"dada55a8_4d890eca","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":65,"context_line":"      volume via external means."},{"line_number":66,"context_line":"    - Tenant network isolation is unsupported due to the need for iPXE boot."},{"line_number":67,"context_line":"        - Potentially in the future, a framework or proxy could be created to"},{"line_number":68,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_0db6f689","line":67,"range":{"start_line":67,"start_character":52,"end_line":67,"end_character":57},"updated":"2016-07-25 14:48:58.000000000","message":"proxy design pattern?","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":65,"context_line":"      volume via external means."},{"line_number":66,"context_line":"    - Tenant network isolation is unsupported due to the need for iPXE boot."},{"line_number":67,"context_line":"        - Potentially in the future, a framework or proxy could be created to"},{"line_number":68,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_44d3965f","line":67,"range":{"start_line":67,"start_character":52,"end_line":67,"end_character":57},"in_reply_to":"dada55a8_0db6f689","updated":"2016-07-25 20:06:43.000000000","message":"Sambetts and I had talked about possibly creating a proxy to assist with network booting an isolated instance due to tenant network isolation prior to the summit.  Sam created a prototype proxy as a result, although I don\u0027t know if he chose to continue down that path.","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      value of ``0``."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Requirements:"},{"line_number":76,"context_line":"    - Storage driver interface"},{"line_number":77,"context_line":"        - A storage driver/provider interface is needed in order to support"},{"line_number":78,"context_line":"          recovery of systems in the event of a failure or change in hardware"},{"line_number":79,"context_line":"          configuration."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_0d143542","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":30},"updated":"2016-07-25 14:48:58.000000000","message":"nit: maybe period or collon punctuation mark?","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      value of ``0``."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Requirements:"},{"line_number":76,"context_line":"    - Storage driver interface"},{"line_number":77,"context_line":"        - A storage driver/provider interface is needed in order to support"},{"line_number":78,"context_line":"          recovery of systems in the event of a failure or change in hardware"},{"line_number":79,"context_line":"          configuration."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_e43f2a23","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":30},"in_reply_to":"dada55a8_0d143542","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        - A storage driver/provider interface is needed in order to support"},{"line_number":78,"context_line":"          recovery of systems in the event of a failure or change in hardware"},{"line_number":79,"context_line":"          configuration."},{"line_number":80,"context_line":"    - iPXE template and generation logic changes"},{"line_number":81,"context_line":"    - Implementation of substrate logic in the agent and PXE driver modules"},{"line_number":82,"context_line":"      to appropriately handle booting a node in a boot from volume scenario."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_6d297189","line":80,"range":{"start_line":80,"start_character":41,"end_line":80,"end_character":48},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        - A storage driver/provider interface is needed in order to support"},{"line_number":78,"context_line":"          recovery of systems in the event of a failure or change in hardware"},{"line_number":79,"context_line":"          configuration."},{"line_number":80,"context_line":"    - iPXE template and generation logic changes"},{"line_number":81,"context_line":"    - Implementation of substrate logic in the agent and PXE driver modules"},{"line_number":82,"context_line":"      to appropriately handle booting a node in a boot from volume scenario."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_84010e6d","line":80,"range":{"start_line":80,"start_character":41,"end_line":80,"end_character":48},"in_reply_to":"dada55a8_6d297189","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  Conditions:"},{"line_number":88,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":89,"context_line":"      ironic conductor. Similar to the PXE driver netboot option."},{"line_number":90,"context_line":"    - Metadata service use expected"},{"line_number":91,"context_line":"    - Configuration drive is not supported"},{"line_number":92,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":93,"context_line":"      via external means."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_8d74a59c","line":90,"range":{"start_line":90,"start_character":27,"end_line":90,"end_character":35},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  Conditions:"},{"line_number":88,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":89,"context_line":"      ironic conductor. Similar to the PXE driver netboot option."},{"line_number":90,"context_line":"    - Metadata service use expected"},{"line_number":91,"context_line":"    - Configuration drive is not supported"},{"line_number":92,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":93,"context_line":"      via external means."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_a441b20d","line":90,"range":{"start_line":90,"start_character":27,"end_line":90,"end_character":35},"in_reply_to":"dada55a8_8d74a59c","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":89,"context_line":"      ironic conductor. Similar to the PXE driver netboot option."},{"line_number":90,"context_line":"    - Metadata service use expected"},{"line_number":91,"context_line":"    - Configuration drive is not supported"},{"line_number":92,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":93,"context_line":"      via external means."},{"line_number":94,"context_line":"    - Tenant network isolation is unsupported due to iPXE requirements."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_ed63a1db","line":91,"range":{"start_line":91,"start_character":33,"end_line":91,"end_character":42},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":89,"context_line":"      ironic conductor. Similar to the PXE driver netboot option."},{"line_number":90,"context_line":"    - Metadata service use expected"},{"line_number":91,"context_line":"    - Configuration drive is not supported"},{"line_number":92,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":93,"context_line":"      via external means."},{"line_number":94,"context_line":"    - Tenant network isolation is unsupported due to iPXE requirements."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_04ffdeaa","line":91,"range":{"start_line":91,"start_character":33,"end_line":91,"end_character":42},"in_reply_to":"dada55a8_ed63a1db","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  directly to a presented volume via the HBA once powered on."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  Conditions:"},{"line_number":116,"context_line":"    - Metadata service use is expected"},{"line_number":117,"context_line":"    - Configuration drive support is unavailable"},{"line_number":118,"context_line":"    - Node boot defaults to block storage device"},{"line_number":119,"context_line":"    - Tenant network isolation would be supported"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_2d8c997e","line":116,"range":{"start_line":116,"start_character":30,"end_line":116,"end_character":38},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  directly to a presented volume via the HBA once powered on."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  Conditions:"},{"line_number":116,"context_line":"    - Metadata service use is expected"},{"line_number":117,"context_line":"    - Configuration drive support is unavailable"},{"line_number":118,"context_line":"    - Node boot defaults to block storage device"},{"line_number":119,"context_line":"    - Tenant network isolation would be supported"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_04451eb2","line":116,"range":{"start_line":116,"start_character":30,"end_line":116,"end_character":38},"in_reply_to":"dada55a8_2d8c997e","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  Conditions:"},{"line_number":116,"context_line":"    - Metadata service use is expected"},{"line_number":117,"context_line":"    - Configuration drive support is unavailable"},{"line_number":118,"context_line":"    - Node boot defaults to block storage device"},{"line_number":119,"context_line":"    - Tenant network isolation would be supported"},{"line_number":120,"context_line":"    - Operating system is already deployed to the intended boot volume"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_6decd129","line":117,"range":{"start_line":117,"start_character":37,"end_line":117,"end_character":48},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  Conditions:"},{"line_number":116,"context_line":"    - Metadata service use is expected"},{"line_number":117,"context_line":"    - Configuration drive support is unavailable"},{"line_number":118,"context_line":"    - Node boot defaults to block storage device"},{"line_number":119,"context_line":"    - Tenant network isolation would be supported"},{"line_number":120,"context_line":"    - Operating system is already deployed to the intended boot volume"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_44155699","line":117,"range":{"start_line":117,"start_character":37,"end_line":117,"end_character":48},"in_reply_to":"dada55a8_6decd129","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  Conditions:"},{"line_number":116,"context_line":"    - Metadata service use is expected"},{"line_number":117,"context_line":"    - Configuration drive support is unavailable"},{"line_number":118,"context_line":"    - Node boot defaults to block storage device"},{"line_number":119,"context_line":"    - Tenant network isolation would be supported"},{"line_number":120,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":121,"context_line":"      via external means."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_edd8c181","line":118,"range":{"start_line":118,"start_character":42,"end_line":118,"end_character":48},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  Conditions:"},{"line_number":116,"context_line":"    - Metadata service use is expected"},{"line_number":117,"context_line":"    - Configuration drive support is unavailable"},{"line_number":118,"context_line":"    - Node boot defaults to block storage device"},{"line_number":119,"context_line":"    - Tenant network isolation would be supported"},{"line_number":120,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":121,"context_line":"      via external means."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_c42146fe","line":118,"range":{"start_line":118,"start_character":42,"end_line":118,"end_character":48},"in_reply_to":"dada55a8_edd8c181","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    - Metadata service use is expected"},{"line_number":117,"context_line":"    - Configuration drive support is unavailable"},{"line_number":118,"context_line":"    - Node boot defaults to block storage device"},{"line_number":119,"context_line":"    - Tenant network isolation would be supported"},{"line_number":120,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":121,"context_line":"      via external means."},{"line_number":122,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_2de3f934","line":119,"range":{"start_line":119,"start_character":40,"end_line":119,"end_character":49},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    - Metadata service use is expected"},{"line_number":117,"context_line":"    - Configuration drive support is unavailable"},{"line_number":118,"context_line":"    - Node boot defaults to block storage device"},{"line_number":119,"context_line":"    - Tenant network isolation would be supported"},{"line_number":120,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":121,"context_line":"      via external means."},{"line_number":122,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_4461d6a7","line":119,"range":{"start_line":119,"start_character":40,"end_line":119,"end_character":49},"in_reply_to":"dada55a8_2de3f934","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":121,"context_line":"      via external means."},{"line_number":122,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":123,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":124,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"},{"line_number":125,"context_line":"      setting of ``hba_boot`` set to a value of ``true``."},{"line_number":126,"context_line":"    - Node has a defined volume target with a ``boot_index``"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_0d739581","line":123,"range":{"start_line":123,"start_character":41,"end_line":123,"end_character":44},"updated":"2016-07-25 14:48:58.000000000","message":"Logical Unit Number, right?","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":121,"context_line":"      via external means."},{"line_number":122,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":123,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":124,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"},{"line_number":125,"context_line":"      setting of ``hba_boot`` set to a value of ``true``."},{"line_number":126,"context_line":"    - Node has a defined volume target with a ``boot_index``"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_c41b061b","line":123,"range":{"start_line":123,"start_character":41,"end_line":123,"end_character":44},"in_reply_to":"dada55a8_0d739581","updated":"2016-07-25 20:06:43.000000000","message":"Yes, Augmenting the text to state that upon the first reference .","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  be written out by Ironic\u0027s mechanisms."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  Conditions:"},{"line_number":141,"context_line":"    - Metadata service is not required"},{"line_number":142,"context_line":"    - Configuration drive is supportable"},{"line_number":143,"context_line":"    - Node boots to block storage device"},{"line_number":144,"context_line":"    - Network isolation is supported"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_cdddfd43","line":141,"range":{"start_line":141,"start_character":30,"end_line":141,"end_character":38},"updated":"2016-07-25 14:48:58.000000000","message":"ditto period","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  be written out by Ironic\u0027s mechanisms."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  Conditions:"},{"line_number":141,"context_line":"    - Metadata service is not required"},{"line_number":142,"context_line":"    - Configuration drive is supportable"},{"line_number":143,"context_line":"    - Node boots to block storage device"},{"line_number":144,"context_line":"    - Network isolation is supported"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_a4b412f2","line":141,"range":{"start_line":141,"start_character":30,"end_line":141,"end_character":38},"in_reply_to":"dada55a8_cdddfd43","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  Conditions:"},{"line_number":141,"context_line":"    - Metadata service is not required"},{"line_number":142,"context_line":"    - Configuration drive is supportable"},{"line_number":143,"context_line":"    - Node boots to block storage device"},{"line_number":144,"context_line":"    - Network isolation is supported"},{"line_number":145,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_0de8b5e1","line":142,"range":{"start_line":142,"start_character":29,"end_line":142,"end_character":40},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  Conditions:"},{"line_number":141,"context_line":"    - Metadata service is not required"},{"line_number":142,"context_line":"    - Configuration drive is supportable"},{"line_number":143,"context_line":"    - Node boots to block storage device"},{"line_number":144,"context_line":"    - Network isolation is supported"},{"line_number":145,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_84b74ef4","line":142,"range":{"start_line":142,"start_character":29,"end_line":142,"end_character":40},"in_reply_to":"dada55a8_0de8b5e1","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  Conditions:"},{"line_number":141,"context_line":"    - Metadata service is not required"},{"line_number":142,"context_line":"    - Configuration drive is supportable"},{"line_number":143,"context_line":"    - Node boots to block storage device"},{"line_number":144,"context_line":"    - Network isolation is supported"},{"line_number":145,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":146,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_8dbae5df","line":143,"range":{"start_line":143,"start_character":34,"end_line":143,"end_character":40},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  Conditions:"},{"line_number":141,"context_line":"    - Metadata service is not required"},{"line_number":142,"context_line":"    - Configuration drive is supportable"},{"line_number":143,"context_line":"    - Node boots to block storage device"},{"line_number":144,"context_line":"    - Network isolation is supported"},{"line_number":145,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":146,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_e4ce0a82","line":143,"range":{"start_line":143,"start_character":34,"end_line":143,"end_character":40},"in_reply_to":"dada55a8_8dbae5df","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    - Metadata service is not required"},{"line_number":142,"context_line":"    - Configuration drive is supportable"},{"line_number":143,"context_line":"    - Node boots to block storage device"},{"line_number":144,"context_line":"    - Network isolation is supported"},{"line_number":145,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":146,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":147,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_0dcf1580","line":144,"range":{"start_line":144,"start_character":27,"end_line":144,"end_character":36},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    - Metadata service is not required"},{"line_number":142,"context_line":"    - Configuration drive is supportable"},{"line_number":143,"context_line":"    - Node boots to block storage device"},{"line_number":144,"context_line":"    - Network isolation is supported"},{"line_number":145,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":146,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":147,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_64a17aa9","line":144,"range":{"start_line":144,"start_character":27,"end_line":144,"end_character":36},"in_reply_to":"dada55a8_0dcf1580","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"  have enabled similar boot functionality downstream."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  Conditions:"},{"line_number":169,"context_line":"    - Metadata service use expected"},{"line_number":170,"context_line":"    - Configuration drive support is unavailable"},{"line_number":171,"context_line":"    - Node boot defaults to iPXE"},{"line_number":172,"context_line":"    - Node boot utilizes kernel and ramdisk hosted by the conductor"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_0df9d580","line":169,"range":{"start_line":169,"start_character":27,"end_line":169,"end_character":35},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":166,"context_line":"  have enabled similar boot functionality downstream."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  Conditions:"},{"line_number":169,"context_line":"    - Metadata service use expected"},{"line_number":170,"context_line":"    - Configuration drive support is unavailable"},{"line_number":171,"context_line":"    - Node boot defaults to iPXE"},{"line_number":172,"context_line":"    - Node boot utilizes kernel and ramdisk hosted by the conductor"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_a499b270","line":169,"range":{"start_line":169,"start_character":27,"end_line":169,"end_character":35},"in_reply_to":"dada55a8_0df9d580","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  Conditions:"},{"line_number":169,"context_line":"    - Metadata service use expected"},{"line_number":170,"context_line":"    - Configuration drive support is unavailable"},{"line_number":171,"context_line":"    - Node boot defaults to iPXE"},{"line_number":172,"context_line":"    - Node boot utilizes kernel and ramdisk hosted by the conductor"},{"line_number":173,"context_line":"    - Operating System is already deployed to the intended boot volume"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_ed3a8133","line":170,"range":{"start_line":170,"start_character":37,"end_line":170,"end_character":48},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  Conditions:"},{"line_number":169,"context_line":"    - Metadata service use expected"},{"line_number":170,"context_line":"    - Configuration drive support is unavailable"},{"line_number":171,"context_line":"    - Node boot defaults to iPXE"},{"line_number":172,"context_line":"    - Node boot utilizes kernel and ramdisk hosted by the conductor"},{"line_number":173,"context_line":"    - Operating System is already deployed to the intended boot volume"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_849c6e5e","line":170,"range":{"start_line":170,"start_character":37,"end_line":170,"end_character":48},"in_reply_to":"dada55a8_ed3a8133","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  Conditions:"},{"line_number":169,"context_line":"    - Metadata service use expected"},{"line_number":170,"context_line":"    - Configuration drive support is unavailable"},{"line_number":171,"context_line":"    - Node boot defaults to iPXE"},{"line_number":172,"context_line":"    - Node boot utilizes kernel and ramdisk hosted by the conductor"},{"line_number":173,"context_line":"    - Operating System is already deployed to the intended boot volume"},{"line_number":174,"context_line":"      via external means."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_8d12e5b2","line":171,"range":{"start_line":171,"start_character":28,"end_line":171,"end_character":32},"updated":"2016-07-25 14:48:58.000000000","message":"ditto","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  Conditions:"},{"line_number":169,"context_line":"    - Metadata service use expected"},{"line_number":170,"context_line":"    - Configuration drive support is unavailable"},{"line_number":171,"context_line":"    - Node boot defaults to iPXE"},{"line_number":172,"context_line":"    - Node boot utilizes kernel and ramdisk hosted by the conductor"},{"line_number":173,"context_line":"    - Operating System is already deployed to the intended boot volume"},{"line_number":174,"context_line":"      via external means."}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_c49e6653","line":171,"range":{"start_line":171,"start_character":28,"end_line":171,"end_character":32},"in_reply_to":"dada55a8_8d12e5b2","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"1b8273fad6e2385559c7ef4e530cf7af0676a14f","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"  - Updating of the ``agent.AgentDeploy`` driver logic to support skipping"},{"line_number":265,"context_line":"    deployment of a node if a storage provider is enabled, volume information"},{"line_number":266,"context_line":"    exists for the volume, and the volume has an index of 0 indicating it is"},{"line_number":267,"context_line":"    the boot volume. In essence, this means that if the node is defined to boot"},{"line_number":268,"context_line":"    from a remote volume, that the driver.deploy.deploy method should"},{"line_number":269,"context_line":"    immediately return DEPLOYDONE as any network booting configuration,"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_2d02d90b","line":266,"range":{"start_line":266,"start_character":58,"end_line":266,"end_character":59},"updated":"2016-07-25 14:48:58.000000000","message":"super nit: s/0/``0``/ ?","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b39ff696f06b0cf2833f10ba161e422d20accd7","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"  - Updating of the ``agent.AgentDeploy`` driver logic to support skipping"},{"line_number":265,"context_line":"    deployment of a node if a storage provider is enabled, volume information"},{"line_number":266,"context_line":"    exists for the volume, and the volume has an index of 0 indicating it is"},{"line_number":267,"context_line":"    the boot volume. In essence, this means that if the node is defined to boot"},{"line_number":268,"context_line":"    from a remote volume, that the driver.deploy.deploy method should"},{"line_number":269,"context_line":"    immediately return DEPLOYDONE as any network booting configuration,"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dada55a8_e4d1eafc","line":266,"range":{"start_line":266,"start_character":58,"end_line":266,"end_character":59},"in_reply_to":"dada55a8_2d02d90b","updated":"2016-07-25 20:06:43.000000000","message":"Done","commit_id":"5cd63fedb22b19ed6a68235e0d0a01e7519f9be7"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"17119484865b0fc06f63107716971b383bc7a74d","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    provisioned with erroneous user expectations."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"  - Creation of a storage provider interface:"},{"line_number":224,"context_line":"     - Similar in composition to the DHCP provider interface, where a default"},{"line_number":225,"context_line":"       of None will result in a provider interface that performs ``no-op``"},{"line_number":226,"context_line":"       behavior, while exposing an empty set of storage capabilities."},{"line_number":227,"context_line":"     - A node level ``storage_interface`` setting with default value,"}],"source_content_type":"text/x-rst","patch_set":16,"id":"dada55a8_c5248d0e","line":224,"updated":"2016-07-26 08:27:40.000000000","message":"Is this configuration still necessary?\nIn Other deployer impact section,default_storage_provider described in old revisions was deleted now.","commit_id":"9ea735df203cc1d0bded1bb40a801216a177a2a3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fcc2a6a0280696d1ebed09d0cc915657686823b9","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    provisioned with erroneous user expectations."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"  - Creation of a storage provider interface:"},{"line_number":224,"context_line":"     - Similar in composition to the DHCP provider interface, where a default"},{"line_number":225,"context_line":"       of None will result in a provider interface that performs ``no-op``"},{"line_number":226,"context_line":"       behavior, while exposing an empty set of storage capabilities."},{"line_number":227,"context_line":"     - A node level ``storage_interface`` setting with default value,"}],"source_content_type":"text/x-rst","patch_set":16,"id":"dada55a8_fad95af4","line":224,"in_reply_to":"dada55a8_c5248d0e","updated":"2016-07-26 13:45:40.000000000","message":"Yes, this is intended to convey that there will be no default enabled storage provider..  Updating it since the network interface functionality has landed.\n\ndefault_storage_provider was intended to apply to all nodes, however this is functionality an operator needs to explicitly opt-in to.","commit_id":"9ea735df203cc1d0bded1bb40a801216a177a2a3"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"17119484865b0fc06f63107716971b383bc7a74d","unresolved":false,"context_lines":[{"line_number":274,"context_line":"     .. code-block:: python"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"         if (task.driver.storage_provider is not None and"},{"line_number":277,"context_line":"                 not task.driver.storage_provider.flash_image(task)):"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"  - Updating of the ``pxe.PXEBoot`` driver logic to support the creation of"},{"line_number":280,"context_line":"    the appropriate iPXE configurations for booting from the various boot"}],"source_content_type":"text/x-rst","patch_set":16,"id":"dada55a8_5c7081a4","line":277,"range":{"start_line":277,"start_character":50,"end_line":277,"end_character":61},"updated":"2016-07-26 08:27:40.000000000","message":"This method is not listed in supported operations of storage driver.","commit_id":"9ea735df203cc1d0bded1bb40a801216a177a2a3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fcc2a6a0280696d1ebed09d0cc915657686823b9","unresolved":false,"context_lines":[{"line_number":274,"context_line":"     .. code-block:: python"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"         if (task.driver.storage_provider is not None and"},{"line_number":277,"context_line":"                 not task.driver.storage_provider.flash_image(task)):"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"  - Updating of the ``pxe.PXEBoot`` driver logic to support the creation of"},{"line_number":280,"context_line":"    the appropriate iPXE configurations for booting from the various boot"}],"source_content_type":"text/x-rst","patch_set":16,"id":"dada55a8_75ef3d1e","line":277,"range":{"start_line":277,"start_character":50,"end_line":277,"end_character":61},"in_reply_to":"dada55a8_5c7081a4","updated":"2016-07-26 13:45:40.000000000","message":"It was intended as an example, but good point, it should be detailed.... and likely renamed.  I think flash_image was just something that came up as an idea at the summit.","commit_id":"9ea735df203cc1d0bded1bb40a801216a177a2a3"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"17119484865b0fc06f63107716971b383bc7a74d","unresolved":false,"context_lines":[{"line_number":617,"context_line":".. _`IPXE sanhook command`: http://ipxe.org/cmd/sanhook"},{"line_number":618,"context_line":".. _`IPXE san connection URLs`: http://ipxe.org/sanuri"},{"line_number":619,"context_line":".. _`Driver composition reform specification`: https://review.openstack.org/#/c/188370/"},{"line_number":620,"context_line":".. _`Add network provider interface and implementations`: https://review.openstack.org/#/c/139687"},{"line_number":621,"context_line":".. _`Add volume connection information for Ironic nodes`: https://review.openstack.org/#/c/200496/"},{"line_number":622,"context_line":".. _`Nova Specs - Ironic - Boot from Cinder volume`: https://review.openstack.org/#/c/211101/"},{"line_number":623,"context_line":".. _`ironic mitaka midcycle`: https://etherpad.openstack.org/p/ironic-mitaka-midcycle"}],"source_content_type":"text/x-rst","patch_set":16,"id":"dada55a8_d9c2c352","line":620,"range":{"start_line":620,"start_character":58,"end_line":620,"end_character":97},"updated":"2016-07-26 08:27:40.000000000","message":"This patch was abandoned.\nThe new patch is https://review.openstack.org/#/c/285852/","commit_id":"9ea735df203cc1d0bded1bb40a801216a177a2a3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fcc2a6a0280696d1ebed09d0cc915657686823b9","unresolved":false,"context_lines":[{"line_number":617,"context_line":".. _`IPXE sanhook command`: http://ipxe.org/cmd/sanhook"},{"line_number":618,"context_line":".. _`IPXE san connection URLs`: http://ipxe.org/sanuri"},{"line_number":619,"context_line":".. _`Driver composition reform specification`: https://review.openstack.org/#/c/188370/"},{"line_number":620,"context_line":".. _`Add network provider interface and implementations`: https://review.openstack.org/#/c/139687"},{"line_number":621,"context_line":".. _`Add volume connection information for Ironic nodes`: https://review.openstack.org/#/c/200496/"},{"line_number":622,"context_line":".. _`Nova Specs - Ironic - Boot from Cinder volume`: https://review.openstack.org/#/c/211101/"},{"line_number":623,"context_line":".. _`ironic mitaka midcycle`: https://etherpad.openstack.org/p/ironic-mitaka-midcycle"}],"source_content_type":"text/x-rst","patch_set":16,"id":"dada55a8_b58535d0","line":620,"range":{"start_line":620,"start_character":58,"end_line":620,"end_character":97},"in_reply_to":"dada55a8_d9c2c352","updated":"2016-07-26 13:45:40.000000000","message":"Thank you!","commit_id":"9ea735df203cc1d0bded1bb40a801216a177a2a3"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"17119484865b0fc06f63107716971b383bc7a74d","unresolved":false,"context_lines":[{"line_number":619,"context_line":".. _`Driver composition reform specification`: https://review.openstack.org/#/c/188370/"},{"line_number":620,"context_line":".. _`Add network provider interface and implementations`: https://review.openstack.org/#/c/139687"},{"line_number":621,"context_line":".. _`Add volume connection information for Ironic nodes`: https://review.openstack.org/#/c/200496/"},{"line_number":622,"context_line":".. _`Nova Specs - Ironic - Boot from Cinder volume`: https://review.openstack.org/#/c/211101/"},{"line_number":623,"context_line":".. _`ironic mitaka midcycle`: https://etherpad.openstack.org/p/ironic-mitaka-midcycle"},{"line_number":624,"context_line":".. _`nfsroot kernel command line option`: https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt"},{"line_number":625,"context_line":".. _`Root device hints`: https://specs.openstack.org/openstack/ironic-specs/specs/kilo-implemented/root-device-hints.html"}],"source_content_type":"text/x-rst","patch_set":16,"id":"dada55a8_25b7693b","line":622,"range":{"start_line":622,"start_character":53,"end_line":622,"end_character":93},"updated":"2016-07-26 08:27:40.000000000","message":"This spec was also abandoned.\nThe new spec is https://review.openstack.org/#/c/311696/","commit_id":"9ea735df203cc1d0bded1bb40a801216a177a2a3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fcc2a6a0280696d1ebed09d0cc915657686823b9","unresolved":false,"context_lines":[{"line_number":619,"context_line":".. _`Driver composition reform specification`: https://review.openstack.org/#/c/188370/"},{"line_number":620,"context_line":".. _`Add network provider interface and implementations`: https://review.openstack.org/#/c/139687"},{"line_number":621,"context_line":".. _`Add volume connection information for Ironic nodes`: https://review.openstack.org/#/c/200496/"},{"line_number":622,"context_line":".. _`Nova Specs - Ironic - Boot from Cinder volume`: https://review.openstack.org/#/c/211101/"},{"line_number":623,"context_line":".. _`ironic mitaka midcycle`: https://etherpad.openstack.org/p/ironic-mitaka-midcycle"},{"line_number":624,"context_line":".. _`nfsroot kernel command line option`: https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt"},{"line_number":625,"context_line":".. _`Root device hints`: https://specs.openstack.org/openstack/ironic-specs/specs/kilo-implemented/root-device-hints.html"}],"source_content_type":"text/x-rst","patch_set":16,"id":"dada55a8_f56b2d1c","line":622,"range":{"start_line":622,"start_character":53,"end_line":622,"end_character":93},"in_reply_to":"dada55a8_25b7693b","updated":"2016-07-26 13:45:40.000000000","message":"Thank you!","commit_id":"9ea735df203cc1d0bded1bb40a801216a177a2a3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"adb67d78f9da4d1ca568923e652e9e7720f415de","unresolved":false,"context_lines":[{"line_number":226,"context_line":"       ``no-op`` behavior, while exposing an empty set of storage"},{"line_number":227,"context_line":"       capabilities."},{"line_number":228,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":229,"context_line":"       similar to the `Add network provider interface and implementations`_"},{"line_number":230,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":231,"context_line":"       with the provider that is to be utilized."},{"line_number":232,"context_line":"     - Initial and reference storage driver to be based upon cinder,"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dada55a8_23a29cae","line":229,"range":{"start_line":229,"start_character":22,"end_line":229,"end_character":75},"updated":"2016-07-26 18:49:27.000000000","message":"The linked patchset\u0027s title has changed, it should be updated.","commit_id":"9afa8583b26f01d7427ac050f590caa8464c0eaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"51f4942f4447daf604c0299426316350e8b96f94","unresolved":false,"context_lines":[{"line_number":226,"context_line":"       ``no-op`` behavior, while exposing an empty set of storage"},{"line_number":227,"context_line":"       capabilities."},{"line_number":228,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":229,"context_line":"       similar to the `Add network provider interface and implementations`_"},{"line_number":230,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":231,"context_line":"       with the provider that is to be utilized."},{"line_number":232,"context_line":"     - Initial and reference storage driver to be based upon cinder,"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bacf61ea_b4581e58","line":229,"range":{"start_line":229,"start_character":22,"end_line":229,"end_character":75},"in_reply_to":"dada55a8_23a29cae","updated":"2016-07-27 21:19:49.000000000","message":"Done","commit_id":"9afa8583b26f01d7427ac050f590caa8464c0eaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"adb67d78f9da4d1ca568923e652e9e7720f415de","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"     .. code-block:: python"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"         if (task.driver.storage_provider is not None and"},{"line_number":282,"context_line":"                 not task.driver.storage_provider.check_write_image(task)):"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  - Updating of the ``pxe.PXEBoot`` driver logic to support the creation of"},{"line_number":285,"context_line":"    the appropriate iPXE configurations for booting from the various boot"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dada55a8_03c0384f","line":282,"range":{"start_line":281,"start_character":13,"end_line":282,"end_character":75},"updated":"2016-07-26 18:49:27.000000000","message":"s/storage_provider/storage/","commit_id":"9afa8583b26f01d7427ac050f590caa8464c0eaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"51f4942f4447daf604c0299426316350e8b96f94","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"     .. code-block:: python"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"         if (task.driver.storage_provider is not None and"},{"line_number":282,"context_line":"                 not task.driver.storage_provider.check_write_image(task)):"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  - Updating of the ``pxe.PXEBoot`` driver logic to support the creation of"},{"line_number":285,"context_line":"    the appropriate iPXE configurations for booting from the various boot"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bacf61ea_74db46ee","line":282,"range":{"start_line":281,"start_character":13,"end_line":282,"end_character":75},"in_reply_to":"dada55a8_03c0384f","updated":"2016-07-27 21:19:49.000000000","message":"Done","commit_id":"9afa8583b26f01d7427ac050f590caa8464c0eaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"adb67d78f9da4d1ca568923e652e9e7720f415de","unresolved":false,"context_lines":[{"line_number":531,"context_line":"sections in the conductor configuration file:"},{"line_number":532,"context_line":"::"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"  [storage]"},{"line_number":535,"context_line":"  enabled_storage_interfaces # Defaults to none and is a list of the"},{"line_number":536,"context_line":"  available drivers."},{"line_number":537,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"dada55a8_e3efe4ae","line":534,"range":{"start_line":534,"start_character":0,"end_line":534,"end_character":11},"updated":"2016-07-26 18:49:27.000000000","message":"This should be [DEFAULT]","commit_id":"9afa8583b26f01d7427ac050f590caa8464c0eaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"51f4942f4447daf604c0299426316350e8b96f94","unresolved":false,"context_lines":[{"line_number":531,"context_line":"sections in the conductor configuration file:"},{"line_number":532,"context_line":"::"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"  [storage]"},{"line_number":535,"context_line":"  enabled_storage_interfaces # Defaults to none and is a list of the"},{"line_number":536,"context_line":"  available drivers."},{"line_number":537,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"bacf61ea_f49456e9","line":534,"range":{"start_line":534,"start_character":0,"end_line":534,"end_character":11},"in_reply_to":"dada55a8_e3efe4ae","updated":"2016-07-27 21:19:49.000000000","message":"Done","commit_id":"9afa8583b26f01d7427ac050f590caa8464c0eaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a027b8afb56d45b2572c5cc89820a0c84346778b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":238,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":239,"context_line":"           process being initiated."},{"line_number":240,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":241,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":242,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":243,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":244,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":245,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":246,"context_line":"           capability that makes sense to define now, intended for volume"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bacf61ea_220aed21","line":243,"range":{"start_line":240,"start_character":0,"end_line":243,"end_character":68},"updated":"2016-07-28 23:03:44.000000000","message":"This is intended to be more along the lines of initalizing the connection (thus export the target to the initiator).\n\nDigging down through the cinder interface, this is actually more in-line with initialize and terminate connection  https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L1311\n\nAttach/Detach may have come from the original discussion at the cinder midcycle since different_words()\n\ntl;dr, we need to verify behavior requirements.","commit_id":"cb74b71722133854a26c5f2d2b7ecc7a36f9f7ff"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1e05b0beb00642b7e0471461d7d910b0afb06e13","unresolved":false,"context_lines":[{"line_number":237,"context_line":"           conductor to obtain and assert up to date configuration"},{"line_number":238,"context_line":"           information in the event of the conductor ``take_over``"},{"line_number":239,"context_line":"           process being initiated."},{"line_number":240,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"},{"line_number":241,"context_line":"           through attached volumes and remove the storage attachments."},{"line_number":242,"context_line":"         - ``attach_volumes`` - Initially implemented to enumerate"},{"line_number":243,"context_line":"           through configured volumes and issue attachment requests."},{"line_number":244,"context_line":"         - ``add_volume`` - Raises an"},{"line_number":245,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":246,"context_line":"           capability that makes sense to define now, intended for volume"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bacf61ea_afa13d48","line":243,"range":{"start_line":240,"start_character":0,"end_line":243,"end_character":68},"in_reply_to":"bacf61ea_220aed21","updated":"2016-08-01 12:56:35.000000000","message":"Updating in next revision to be a little more clear in the cinder case.","commit_id":"cb74b71722133854a26c5f2d2b7ecc7a36f9f7ff"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ed615c1f9336eda9faf612653aef122d00f21706","unresolved":false,"context_lines":[{"line_number":469,"context_line":"credentials that are already populated in the configuration for keystone"},{"line_number":470,"context_line":"to connect to cinder to obtain and update mapping information for volumes."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Scenarios 1-3 and 5 are designed such that the tenant machine is able to"},{"line_number":473,"context_line":"reach the various services being offered up by whatever the volume driver"},{"line_number":474,"context_line":"is set to leverage over the node\u0027s default network configuration. As a"},{"line_number":475,"context_line":"result of the need to network boot, the flat network topology is required"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bacf61ea_f37c4922","line":472,"range":{"start_line":472,"start_character":10,"end_line":472,"end_character":13},"updated":"2016-07-28 13:13:41.000000000","message":"1-2?\nScenario 3 doesn\u0027t need network boot.","commit_id":"cb74b71722133854a26c5f2d2b7ecc7a36f9f7ff"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a027b8afb56d45b2572c5cc89820a0c84346778b","unresolved":false,"context_lines":[{"line_number":469,"context_line":"credentials that are already populated in the configuration for keystone"},{"line_number":470,"context_line":"to connect to cinder to obtain and update mapping information for volumes."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Scenarios 1-3 and 5 are designed such that the tenant machine is able to"},{"line_number":473,"context_line":"reach the various services being offered up by whatever the volume driver"},{"line_number":474,"context_line":"is set to leverage over the node\u0027s default network configuration. As a"},{"line_number":475,"context_line":"result of the need to network boot, the flat network topology is required"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bacf61ea_df4aca82","line":472,"range":{"start_line":472,"start_character":10,"end_line":472,"end_character":13},"in_reply_to":"bacf61ea_f37c4922","updated":"2016-07-28 23:03:44.000000000","message":"Good catch.  Will address in the next revision.","commit_id":"cb74b71722133854a26c5f2d2b7ecc7a36f9f7ff"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ed615c1f9336eda9faf612653aef122d00f21706","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":"This will increase the overall complexity and set of capabilities that"},{"line_number":548,"context_line":"ironic offers, however, no developer impact is expected."},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"Implementation"},{"line_number":551,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":552,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"bacf61ea_d33f9a23","line":549,"updated":"2016-07-28 13:13:41.000000000","message":"This spec is a reference implementation. It would be better to add a sentence such a \"Each driver developer needs to follow this interface to implement this proposed feature\".","commit_id":"cb74b71722133854a26c5f2d2b7ecc7a36f9f7ff"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1e05b0beb00642b7e0471461d7d910b0afb06e13","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":"This will increase the overall complexity and set of capabilities that"},{"line_number":548,"context_line":"ironic offers, however, no developer impact is expected."},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"Implementation"},{"line_number":551,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":552,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"bacf61ea_9a85955b","line":549,"in_reply_to":"bacf61ea_d33f9a23","updated":"2016-08-01 12:56:35.000000000","message":"Next revision has this adjusted to be a bit more specific for driver developers.","commit_id":"cb74b71722133854a26c5f2d2b7ecc7a36f9f7ff"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a027b8afb56d45b2572c5cc89820a0c84346778b","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":"This will increase the overall complexity and set of capabilities that"},{"line_number":548,"context_line":"ironic offers, however, no developer impact is expected."},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"Implementation"},{"line_number":551,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":552,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"bacf61ea_5f5ffa40","line":549,"in_reply_to":"bacf61ea_d33f9a23","updated":"2016-07-28 23:03:44.000000000","message":"Perhaps \"Pattern after and utilize the storage_interface substrate\"?","commit_id":"cb74b71722133854a26c5f2d2b7ecc7a36f9f7ff"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ed615c1f9336eda9faf612653aef122d00f21706","unresolved":false,"context_lines":[{"line_number":592,"context_line":""},{"line_number":593,"context_line":"Testing"},{"line_number":594,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"The level of full stack functional and integration tests is a topic that"},{"line_number":597,"context_line":"requires further discussion in the ironic community. An initial case for a"},{"line_number":598,"context_line":"gate test could be where an ironic deployment boots from a Cinder volume,"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bacf61ea_5e8f3123","line":595,"updated":"2016-07-28 13:13:41.000000000","message":"nit: unit tests are usually mentioned in other specs.","commit_id":"cb74b71722133854a26c5f2d2b7ecc7a36f9f7ff"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a027b8afb56d45b2572c5cc89820a0c84346778b","unresolved":false,"context_lines":[{"line_number":592,"context_line":""},{"line_number":593,"context_line":"Testing"},{"line_number":594,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"The level of full stack functional and integration tests is a topic that"},{"line_number":597,"context_line":"requires further discussion in the ironic community. An initial case for a"},{"line_number":598,"context_line":"gate test could be where an ironic deployment boots from a Cinder volume,"}],"source_content_type":"text/x-rst","patch_set":19,"id":"bacf61ea_b9f3cb9d","line":595,"in_reply_to":"bacf61ea_5e8f3123","updated":"2016-07-28 23:03:44.000000000","message":"The spec instructions defines that unit tests are implied and do not need to be mentioned.","commit_id":"cb74b71722133854a26c5f2d2b7ecc7a36f9f7ff"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ed615c1f9336eda9faf612653aef122d00f21706","unresolved":false,"context_lines":[{"line_number":610,"context_line":"reference drivers and their capability, no compatibility issues are expected"},{"line_number":611,"context_line":"as the API field additions related to this specification will be hidden from"},{"line_number":612,"context_line":"an API client that does not request the appropriate API version."},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"Documentation Impact"},{"line_number":615,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":616,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"bacf61ea_1ec5b93b","line":613,"updated":"2016-07-28 13:13:41.000000000","message":"A database migration script would be necessary.","commit_id":"cb74b71722133854a26c5f2d2b7ecc7a36f9f7ff"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a027b8afb56d45b2572c5cc89820a0c84346778b","unresolved":false,"context_lines":[{"line_number":610,"context_line":"reference drivers and their capability, no compatibility issues are expected"},{"line_number":611,"context_line":"as the API field additions related to this specification will be hidden from"},{"line_number":612,"context_line":"an API client that does not request the appropriate API version."},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"Documentation Impact"},{"line_number":615,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":616,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"bacf61ea_191017a8","line":613,"in_reply_to":"bacf61ea_1ec5b93b","updated":"2016-07-28 23:03:44.000000000","message":"I believe that is implied as database fields would be added.","commit_id":"cb74b71722133854a26c5f2d2b7ecc7a36f9f7ff"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"7522cfb356d5a0647d36ae3fb54c7e91581434a4","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    immediately return DEPLOYDONE as any network booting configuration,"},{"line_number":281,"context_line":"    if applicable, would have be written out via driver.deploy.prepare method."},{"line_number":282,"context_line":"    Example:"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"     .. code-block:: python"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"         if (task.node.storage_interface is not None and"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3ac371cc_f080e548","line":283,"updated":"2016-08-15 04:15:35.000000000","message":"Isn\u0027t it necessary to add the same logic to iscsi_deploy.ISCSIDeploy and other deploy interfaces? Are only drivers with agent deploy interface and pxe boot interface available for this feature?","commit_id":"87496f26eafdca3851dfa9006b5a61ac32125ef7"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9c016da3a8f34513fcb49d41f8d12ad03fd56af8","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    immediately return DEPLOYDONE as any network booting configuration,"},{"line_number":281,"context_line":"    if applicable, would have be written out via driver.deploy.prepare method."},{"line_number":282,"context_line":"    Example:"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"     .. code-block:: python"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"         if (task.node.storage_interface is not None and"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3ac371cc_b6a62d51","line":283,"in_reply_to":"3ac371cc_3da8751f","updated":"2016-08-16 04:38:18.000000000","message":"I got it. There is no problem for me if only agent deploy interface is available as a first generic implementation.","commit_id":"87496f26eafdca3851dfa9006b5a61ac32125ef7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9392fc578482fc692eb98bd47106a128599718b3","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    immediately return DEPLOYDONE as any network booting configuration,"},{"line_number":281,"context_line":"    if applicable, would have be written out via driver.deploy.prepare method."},{"line_number":282,"context_line":"    Example:"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"     .. code-block:: python"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"         if (task.node.storage_interface is not None and"}],"source_content_type":"text/x-rst","patch_set":20,"id":"1ac06dbe_c89374f9","line":283,"in_reply_to":"3ac371cc_f080e548","updated":"2016-08-19 17:41:59.000000000","message":"Looks like it would be the same with the iscsi deploy driver as well, I\u0027ll update the spec.","commit_id":"87496f26eafdca3851dfa9006b5a61ac32125ef7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f56cd9c559caecf9b3112f182a22d6cf05557026","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    immediately return DEPLOYDONE as any network booting configuration,"},{"line_number":281,"context_line":"    if applicable, would have be written out via driver.deploy.prepare method."},{"line_number":282,"context_line":"    Example:"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"     .. code-block:: python"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"         if (task.node.storage_interface is not None and"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3ac371cc_3da8751f","line":283,"in_reply_to":"3ac371cc_f080e548","updated":"2016-08-15 16:37:17.000000000","message":"Only necessary if full parity is available or desired.  When this feature was originally planned, it was intended to focus on the Agent based interfaces as cleaning should be used in any environment where this is used as any ephemeral/local storage will not be cleaned up otherwise, since the iscsi drivers did not feature the cleaning functionality. That being said, it looks like cleaning is now supported for the ISCSIDeploy method.  I\u0027ll put it on my to-do list to look it over carefully, and if necessary amend this review or post a revision to the specification.","commit_id":"87496f26eafdca3851dfa9006b5a61ac32125ef7"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9f1d6053b2665ce6977a4aed7c736ba5e0d42a83","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":60,"context_line":"      ironic conductor. This is similar to the PXE driver netboot option."},{"line_number":61,"context_line":"    - Metadata service use is expected."},{"line_number":62,"context_line":"    - Configuration drive is not supported."},{"line_number":63,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":64,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":65,"context_line":"      volume via external means."}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_e6b58b31","line":62,"updated":"2016-10-05 20:30:51.000000000","message":"I haven\u0027t thought about this much, but why can\u0027t we support a configdrive? Same question for the other scenarios.\n\nIt\u0027s fine if it\u0027s out of scope for now, but it\u0027d be nicer to say \"later\" than \"never.\"\n\nEdit: I think you do say \"potentially allowed later\" below, but maybe specify that here as well.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"297e0220a326aa3c9c93f5ac1bb7d7e050b55909","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":60,"context_line":"      ironic conductor. This is similar to the PXE driver netboot option."},{"line_number":61,"context_line":"    - Metadata service use is expected."},{"line_number":62,"context_line":"    - Configuration drive is not supported."},{"line_number":63,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":64,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":65,"context_line":"      volume via external means."}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_bdd96e59","line":62,"in_reply_to":"1a95cdbc_9cdea66b","updated":"2016-10-07 17:05:30.000000000","message":"This is a good point. I think I was thinking about a case where you copy the volume to a disk and then add a configdrive. Given those cinder limitations, I\u0027m fine with leaving it out initially.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6090664004502dc3ea51f1be35a19c5d46d1ac6a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":60,"context_line":"      ironic conductor. This is similar to the PXE driver netboot option."},{"line_number":61,"context_line":"    - Metadata service use is expected."},{"line_number":62,"context_line":"    - Configuration drive is not supported."},{"line_number":63,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":64,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":65,"context_line":"      volume via external means."}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_9cdea66b","line":62,"in_reply_to":"1a95cdbc_e6b58b31","updated":"2016-10-06 18:26:47.000000000","message":"I think everything is potential, and largely these steps are intended to be iterative steps to implementation from a feature standpoint.  It could be done eventually, and I fully support that, but there are some technical limitations that exist with cinder which means we should avoid trying to add making configuration drives part of a minimum viable product.\n\nThe technical limitations that the cinder team communicated to me during their mid-cycle earlier this year was that there is a minimum supported/possible volume expansion size, and there is a minimal supported volume size.  Both of which are fairly large which means appending a small configuration drive to the end of a volume is not the most viable thing to do, and a new volume for a small configuration drive could be a large waste of storage resources.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"4becc4c121c357f183f99ff1dfa3feb5fabf2d0c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        - Potentially in the future, a framework or proxy could be created to"},{"line_number":68,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"},{"line_number":71,"context_line":"      of ``iscsi_boot`` set to a value of ``true``."},{"line_number":72,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":73,"context_line":"      value of ``0``."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"fa7ab95a_c9162258","line":71,"range":{"start_line":70,"start_character":5,"end_line":71,"end_character":51},"updated":"2016-08-31 04:00:08.000000000","message":"Hi, Julia:\n     I have a question here.\n     Who will configure this property?\n     1. operator\n     2. ironic will set this automaticly  when the node\u0027s volume target info is configured.\n     3. nova ironic virt driver will configure it.\n\nThanks in advance.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1ccf77369729ae62dce472d3956177cc49cc1e6d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        - Potentially in the future, a framework or proxy could be created to"},{"line_number":68,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"},{"line_number":71,"context_line":"      of ``iscsi_boot`` set to a value of ``true``."},{"line_number":72,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":73,"context_line":"      value of ``0``."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a89bdaa_26fd246e","line":71,"range":{"start_line":70,"start_character":5,"end_line":71,"end_character":51},"in_reply_to":"fa7ab95a_58c9fa59","updated":"2016-09-08 11:52:29.000000000","message":"That is correct, a cloud operator would be in charge of setting the capability.  That doesn\u0027t prevent them from possible later automatically adding some level of detection to inspection and preference setting to help populate the field, but at the same time I\u0027m aware of operators that have things like FC HBAs or iSCSI HBAs that don\u0027t intend nor want to use them.  Realistically, and operator may also only be able to support so many nodes based on infrastructure constraints as well.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"1a69b909f70c47964dcf2a8ea9205b2695aaf068","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        - Potentially in the future, a framework or proxy could be created to"},{"line_number":68,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":69,"context_line":"          scope at this time."},{"line_number":70,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]`` setting"},{"line_number":71,"context_line":"      of ``iscsi_boot`` set to a value of ``true``."},{"line_number":72,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":73,"context_line":"      value of ``0``."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"fa7ab95a_58c9fa59","line":71,"range":{"start_line":70,"start_character":5,"end_line":71,"end_character":51},"in_reply_to":"fa7ab95a_c9162258","updated":"2016-08-31 06:31:59.000000000","message":"I think this should be set by cloud operator.\nBecause nova-scheduler need some way to chose a baremetal that support sanboot.\nSo this capabilities needed to be exposed to nova in advance.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9f1d6053b2665ce6977a4aed7c736ba5e0d42a83","unresolved":false,"context_lines":[{"line_number":159,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  Scenario involves use of a kernel and ramdisk image hosted by the"},{"line_number":162,"context_line":"  conductor host in order to enable the node to boot via iPXE with"},{"line_number":163,"context_line":"  sufficient command line parameters to enable the root volume to"},{"line_number":164,"context_line":"  attach during the boot sequence."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_c656cfd1","line":162,"range":{"start_line":162,"start_character":2,"end_line":162,"end_character":16},"updated":"2016-10-05 20:30:51.000000000","message":"Can we allow specifying a separate host for the kernel and ramdisk? This may allow better scalability characteristics.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"297e0220a326aa3c9c93f5ac1bb7d7e050b55909","unresolved":false,"context_lines":[{"line_number":159,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  Scenario involves use of a kernel and ramdisk image hosted by the"},{"line_number":162,"context_line":"  conductor host in order to enable the node to boot via iPXE with"},{"line_number":163,"context_line":"  sufficient command line parameters to enable the root volume to"},{"line_number":164,"context_line":"  attach during the boot sequence."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_5def8ae8","line":162,"range":{"start_line":162,"start_character":2,"end_line":162,"end_character":16},"in_reply_to":"1a95cdbc_5c109e01","updated":"2016-10-07 17:05:30.000000000","message":"Sounds fine.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6090664004502dc3ea51f1be35a19c5d46d1ac6a","unresolved":false,"context_lines":[{"line_number":159,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  Scenario involves use of a kernel and ramdisk image hosted by the"},{"line_number":162,"context_line":"  conductor host in order to enable the node to boot via iPXE with"},{"line_number":163,"context_line":"  sufficient command line parameters to enable the root volume to"},{"line_number":164,"context_line":"  attach during the boot sequence."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_5c109e01","line":162,"range":{"start_line":162,"start_character":2,"end_line":162,"end_character":16},"in_reply_to":"1a95cdbc_c656cfd1","updated":"2016-10-06 18:26:47.000000000","message":"That sounds like the iPXE to swift discussions that have been occurring.  I don\u0027t see why not in the grand scheme of things, but that seems like something that would also be kind of out of scope since it could apply to any iPXE based boot operation.  That is if we even keep the concept of it moving further down the road.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9f1d6053b2665ce6977a4aed7c736ba5e0d42a83","unresolved":false,"context_lines":[{"line_number":163,"context_line":"  sufficient command line parameters to enable the root volume to"},{"line_number":164,"context_line":"  attach during the boot sequence."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  This is a logical progression given that users have indicated that they"},{"line_number":167,"context_line":"  have enabled similar boot functionality downstream."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"  Conditions:"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_4642bf11","line":166,"updated":"2016-10-05 20:30:51.000000000","message":"A reference to something like an IRC conversation on eavesdrop would be good here.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"297e0220a326aa3c9c93f5ac1bb7d7e050b55909","unresolved":false,"context_lines":[{"line_number":163,"context_line":"  sufficient command line parameters to enable the root volume to"},{"line_number":164,"context_line":"  attach during the boot sequence."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  This is a logical progression given that users have indicated that they"},{"line_number":167,"context_line":"  have enabled similar boot functionality downstream."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"  Conditions:"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_ddb1da02","line":166,"in_reply_to":"1a95cdbc_1cbb76e6","updated":"2016-10-07 17:05:30.000000000","message":"Sounds fine. Just a suggestion, wasn\u0027t the cause of the -1.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6090664004502dc3ea51f1be35a19c5d46d1ac6a","unresolved":false,"context_lines":[{"line_number":163,"context_line":"  sufficient command line parameters to enable the root volume to"},{"line_number":164,"context_line":"  attach during the boot sequence."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"  This is a logical progression given that users have indicated that they"},{"line_number":167,"context_line":"  have enabled similar boot functionality downstream."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"  Conditions:"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_1cbb76e6","line":166,"in_reply_to":"1a95cdbc_4642bf11","updated":"2016-10-06 18:26:47.000000000","message":"Good point, although this has largely come about from in person discussions at summits.  I\u0027ll take a look and see what I can find.  I think one of the companies actually proposed their downstream feature as a feature to Kilo during Liberty.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9f1d6053b2665ce6977a4aed7c736ba5e0d42a83","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  later on after reference driver implementation has been completed,"},{"line_number":188,"context_line":"  however these are out of scope of the existing specification."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"     * Boot the agent from a remote volume to facilitate a deployment."},{"line_number":191,"context_line":"     * Creation of a deployment framework to allow IPA to potentially"},{"line_number":192,"context_line":"       apply HBA settings."},{"line_number":193,"context_line":"     * Multipath IO configuration handling and potentially passing."}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_c66def99","line":190,"updated":"2016-10-05 20:30:51.000000000","message":"Ah, is this why we can\u0027t have a configdrive?","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"297e0220a326aa3c9c93f5ac1bb7d7e050b55909","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  later on after reference driver implementation has been completed,"},{"line_number":188,"context_line":"  however these are out of scope of the existing specification."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"     * Boot the agent from a remote volume to facilitate a deployment."},{"line_number":191,"context_line":"     * Creation of a deployment framework to allow IPA to potentially"},{"line_number":192,"context_line":"       apply HBA settings."},{"line_number":193,"context_line":"     * Multipath IO configuration handling and potentially passing."}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_9d61123c","line":190,"in_reply_to":"1a95cdbc_5cac1ea0","updated":"2016-10-07 17:05:30.000000000","message":"OK, no problem. Let\u0027s leave it out of the initial implementation.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6090664004502dc3ea51f1be35a19c5d46d1ac6a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  later on after reference driver implementation has been completed,"},{"line_number":188,"context_line":"  however these are out of scope of the existing specification."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"     * Boot the agent from a remote volume to facilitate a deployment."},{"line_number":191,"context_line":"     * Creation of a deployment framework to allow IPA to potentially"},{"line_number":192,"context_line":"       apply HBA settings."},{"line_number":193,"context_line":"     * Multipath IO configuration handling and potentially passing."}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_5cac1ea0","line":190,"in_reply_to":"1a95cdbc_c66def99","updated":"2016-10-06 18:26:47.000000000","message":"No, this is unrelated.  See my earlier comment as to the technical limitations. :(","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9f1d6053b2665ce6977a4aed7c736ba5e0d42a83","unresolved":false,"context_lines":[{"line_number":200,"context_line":"In order to support an initial feature set, i.e. Scenarios 1-4,"},{"line_number":201,"context_line":"for boot from volume, we propose the following:"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  - Implementation of a basic capability concept via a helper method that"},{"line_number":204,"context_line":"    will allow a driver/provider capability to be checked by another portion"},{"line_number":205,"context_line":"    of the code base, returning false if the capabilities definition"},{"line_number":206,"context_line":"    is missing. Example:"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_46271f64","line":203,"updated":"2016-10-05 20:30:51.000000000","message":"We can talk about this in the implementation, but maybe mixin classes would help here. It could get out of hand for drivers that support many of these features, though.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6090664004502dc3ea51f1be35a19c5d46d1ac6a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"In order to support an initial feature set, i.e. Scenarios 1-4,"},{"line_number":201,"context_line":"for boot from volume, we propose the following:"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  - Implementation of a basic capability concept via a helper method that"},{"line_number":204,"context_line":"    will allow a driver/provider capability to be checked by another portion"},{"line_number":205,"context_line":"    of the code base, returning false if the capabilities definition"},{"line_number":206,"context_line":"    is missing. Example:"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_bccd225f","line":203,"in_reply_to":"1a95cdbc_46271f64","updated":"2016-10-06 18:26:47.000000000","message":"How would mixing classes help us to know if the classs being mixed in does or does not have an understanding or support of some portion of functionality at a base level?  Maybe this is a discussion best for BCN. :)\n\nTo me, it seems like we need to be able to know if this other portion of ironic has a concept of this, but that portion might differ, especially with driver composition as someone could mix together their own high level \"driver\" of sorts.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"297e0220a326aa3c9c93f5ac1bb7d7e050b55909","unresolved":false,"context_lines":[{"line_number":200,"context_line":"In order to support an initial feature set, i.e. Scenarios 1-4,"},{"line_number":201,"context_line":"for boot from volume, we propose the following:"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  - Implementation of a basic capability concept via a helper method that"},{"line_number":204,"context_line":"    will allow a driver/provider capability to be checked by another portion"},{"line_number":205,"context_line":"    of the code base, returning false if the capabilities definition"},{"line_number":206,"context_line":"    is missing. Example:"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_bd8ece2b","line":203,"in_reply_to":"1a95cdbc_bccd225f","updated":"2016-10-07 17:05:30.000000000","message":"Sounds fine. I won\u0027t be at Barcelona :(\n\nBut this  is an implementation detail, so it\u0027s not the cause of spec -1.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9f1d6053b2665ce6977a4aed7c736ba5e0d42a83","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    enabling matching and identification of what the next appropriate step"},{"line_number":312,"context_line":"    is for each scenario."},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  - Updating of the conductor ``_do_node_tear_down`` method to call the"},{"line_number":315,"context_line":"    storage provider detach_volumes method and purge volume information"},{"line_number":316,"context_line":"    if not already implemented."},{"line_number":317,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_06051779","line":314,"updated":"2016-10-05 20:30:51.000000000","message":"I\u0027m a little worried about what happens when this fails, but let\u0027s talk more about it in the implementation.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6090664004502dc3ea51f1be35a19c5d46d1ac6a","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    enabling matching and identification of what the next appropriate step"},{"line_number":312,"context_line":"    is for each scenario."},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  - Updating of the conductor ``_do_node_tear_down`` method to call the"},{"line_number":315,"context_line":"    storage provider detach_volumes method and purge volume information"},{"line_number":316,"context_line":"    if not already implemented."},{"line_number":317,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_3c64b247","line":314,"in_reply_to":"1a95cdbc_06051779","updated":"2016-10-06 18:26:47.000000000","message":"My understanding from the cinder folks was that this was already a problem with nova\u0027s use of cinder in that sometimes detachments were not getting called, mappings would be left orphaned for volumes.  Not as much of a problem for a VM if cinder or the backend storage is tracking LUNs correctly...  but with physical storage networks this could indeed be a problem.  I think the approach that I was going with was to try our best to clean it up and remove our references to it, but it may make sense to blow up the teardown in the event storage driver fails to be able to remove it.  Definitely worth some thought.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"297e0220a326aa3c9c93f5ac1bb7d7e050b55909","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    enabling matching and identification of what the next appropriate step"},{"line_number":312,"context_line":"    is for each scenario."},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"  - Updating of the conductor ``_do_node_tear_down`` method to call the"},{"line_number":315,"context_line":"    storage provider detach_volumes method and purge volume information"},{"line_number":316,"context_line":"    if not already implemented."},{"line_number":317,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_ddad5a85","line":314,"in_reply_to":"1a95cdbc_3c64b247","updated":"2016-10-07 17:05:30.000000000","message":"Definitely worth some thought. I\u0027ve seen the nova case you\u0027re talking about in production systems many times.\n\nPerhaps you can add \"Add notifications for each step of the boot from volume process\" as a work item? That way, if a notification is sent at the start of the tear down, but an end notification never gets sent, an external service can try to force detach.\n\nWDYT? I\u0027m open to discussing more about notifications in IRC at some point if you want.\n\nI\u0027m also fine with it if you want to add me as an additional contributor and have me do the notification pieces once the initial patch set for this is up.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9f1d6053b2665ce6977a4aed7c736ba5e0d42a83","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    def attach_volumes(self, task):"},{"line_number":414,"context_line":"    \"\"\"Informs the storage subsystem to detach all volumes for the node.\"\"\""},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def detach_valumes(self, task):"},{"line_number":417,"context_line":"    \"\"\"Informs the storage subsystem to detach all volumes for the node.\"\"\""},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def add_volume(self, task):"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_46363f53","line":416,"range":{"start_line":416,"start_character":15,"end_line":416,"end_character":22},"updated":"2016-10-05 20:30:51.000000000","message":"nit: s/valumes/volumes","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6090664004502dc3ea51f1be35a19c5d46d1ac6a","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    def attach_volumes(self, task):"},{"line_number":414,"context_line":"    \"\"\"Informs the storage subsystem to detach all volumes for the node.\"\"\""},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def detach_valumes(self, task):"},{"line_number":417,"context_line":"    \"\"\"Informs the storage subsystem to detach all volumes for the node.\"\"\""},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def add_volume(self, task):"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_5c5b3e87","line":416,"range":{"start_line":416,"start_character":15,"end_line":416,"end_character":22},"in_reply_to":"1a95cdbc_46363f53","updated":"2016-10-06 18:26:47.000000000","message":"Doh!  Great catch! I will fix in the next or a follow-up revision.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"297e0220a326aa3c9c93f5ac1bb7d7e050b55909","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    def attach_volumes(self, task):"},{"line_number":414,"context_line":"    \"\"\"Informs the storage subsystem to detach all volumes for the node.\"\"\""},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def detach_valumes(self, task):"},{"line_number":417,"context_line":"    \"\"\"Informs the storage subsystem to detach all volumes for the node.\"\"\""},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def add_volume(self, task):"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_9dde720f","line":416,"range":{"start_line":416,"start_character":15,"end_line":416,"end_character":22},"in_reply_to":"1a95cdbc_5c5b3e87","updated":"2016-10-07 17:05:30.000000000","message":"NP, not cause of the -1, just found it.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9f1d6053b2665ce6977a4aed7c736ba5e0d42a83","unresolved":false,"context_lines":[{"line_number":479,"context_line":"Scalability impact"},{"line_number":480,"context_line":"------------------"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"None."},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"Performance Impact"},{"line_number":485,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_061357b9","line":482,"updated":"2016-10-05 20:30:51.000000000","message":"This can impact scalability if the storage implementation (cinder) doesn\u0027t scale well.","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6090664004502dc3ea51f1be35a19c5d46d1ac6a","unresolved":false,"context_lines":[{"line_number":479,"context_line":"Scalability impact"},{"line_number":480,"context_line":"------------------"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"None."},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"Performance Impact"},{"line_number":485,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_9c5f8640","line":482,"in_reply_to":"1a95cdbc_061357b9","updated":"2016-10-06 18:26:47.000000000","message":"Agreed, although I take that as a direct impact to the operation of Ironic, which seems even less so being something that would have to be explicitly opt\u0027ed in to use by the operator. Wouldn\u0027t that be an operational choice impairs operational performance decision?  Perhaps something more for installation or architectural guidance documentation stating \"Hey, here is the scaling consideration you need to make\"?","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"297e0220a326aa3c9c93f5ac1bb7d7e050b55909","unresolved":false,"context_lines":[{"line_number":479,"context_line":"Scalability impact"},{"line_number":480,"context_line":"------------------"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"None."},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"Performance Impact"},{"line_number":485,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1a95cdbc_5d478abb","line":482,"in_reply_to":"1a95cdbc_9c5f8640","updated":"2016-10-07 17:05:30.000000000","message":"+1 to documenting it.\n\nAdditional network calls are explicitly called out in the template: https://github.com/openstack/ironic-specs/blob/master/specs/template.rst#scalability-impact\n\nso I think it should be added. I\u0027m not 100% sure whether optional features require documentation here, though.\n\nIs there a place besides the template that describes what this section is meant for?","commit_id":"fd613cf1796182f7ccb57bde75caaf6ee13b0a81"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Due to the lack of this support, users\u0027 capabilities and usability are"},{"line_number":25,"context_line":"  limited. Providing this functionality allows deployments to leverage"},{"line_number":26,"context_line":"  greater capabilities."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Boot from Volume scenarios"},{"line_number":29,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_cdb0bbe0","line":26,"updated":"2016-10-11 20:01:17.000000000","message":"I think we should mention what exactly user may get by using boot from volume for example it enables snapshots","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"92f6cdb86938565798c9d912cf5440c966f5060c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Due to the lack of this support, users\u0027 capabilities and usability are"},{"line_number":25,"context_line":"  limited. Providing this functionality allows deployments to leverage"},{"line_number":26,"context_line":"  greater capabilities."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Boot from Volume scenarios"},{"line_number":29,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_0b9a7463","line":26,"in_reply_to":"fa6399be_c5614eaa","updated":"2016-10-12 18:25:54.000000000","message":"I think the scenarios are more than sufficient.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Due to the lack of this support, users\u0027 capabilities and usability are"},{"line_number":25,"context_line":"  limited. Providing this functionality allows deployments to leverage"},{"line_number":26,"context_line":"  greater capabilities."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Boot from Volume scenarios"},{"line_number":29,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_c5614eaa","line":26,"in_reply_to":"fa6399be_cdb0bbe0","updated":"2016-10-12 14:17:35.000000000","message":"That is the purpose of the scenarios below.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  Conditions:"},{"line_number":59,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":60,"context_line":"      ironic conductor. This is similar to the PXE driver netboot option."},{"line_number":61,"context_line":"    - Metadata service use is expected."},{"line_number":62,"context_line":"    - Configuration drive is not supported."},{"line_number":63,"context_line":"        - For context: This is a limitation as a result of the minimum"},{"line_number":64,"context_line":"          new volume and new volume extension sizes. This may be a"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_588e2b79","line":61,"updated":"2016-10-11 20:01:17.000000000","message":"what is the role of metadata server here?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"92f6cdb86938565798c9d912cf5440c966f5060c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  Conditions:"},{"line_number":59,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":60,"context_line":"      ironic conductor. This is similar to the PXE driver netboot option."},{"line_number":61,"context_line":"    - Metadata service use is expected."},{"line_number":62,"context_line":"    - Configuration drive is not supported."},{"line_number":63,"context_line":"        - For context: This is a limitation as a result of the minimum"},{"line_number":64,"context_line":"          new volume and new volume extension sizes. This may be a"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_2bebb8b1","line":61,"in_reply_to":"fa6399be_25968a4c","updated":"2016-10-12 18:25:54.000000000","message":"Can you clarify that this is the intent? I actually parsed this as requiring an *image* metadata service initially.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b9c2f718cc736de2bd29f892f4ca3b26991bfcbe","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  Conditions:"},{"line_number":59,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":60,"context_line":"      ironic conductor. This is similar to the PXE driver netboot option."},{"line_number":61,"context_line":"    - Metadata service use is expected."},{"line_number":62,"context_line":"    - Configuration drive is not supported."},{"line_number":63,"context_line":"        - For context: This is a limitation as a result of the minimum"},{"line_number":64,"context_line":"          new volume and new volume extension sizes. This may be a"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_c4106604","line":61,"in_reply_to":"fa6399be_25968a4c","updated":"2016-10-12 17:01:13.000000000","message":"Done","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  Conditions:"},{"line_number":59,"context_line":"    - Node boot defaults to network booting via iPXE controlled by the"},{"line_number":60,"context_line":"      ironic conductor. This is similar to the PXE driver netboot option."},{"line_number":61,"context_line":"    - Metadata service use is expected."},{"line_number":62,"context_line":"    - Configuration drive is not supported."},{"line_number":63,"context_line":"        - For context: This is a limitation as a result of the minimum"},{"line_number":64,"context_line":"          new volume and new volume extension sizes. This may be a"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_25968a4c","line":61,"in_reply_to":"fa6399be_588e2b79","updated":"2016-10-12 14:17:35.000000000","message":"Use is expected as configuration drive support is not available.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":73,"context_line":"          scope at this time."},{"line_number":74,"context_line":"    - Node is configured by the operator with the"},{"line_number":75,"context_line":"      ``node.properties[\u0027capabilities\u0027]`` setting of ``iscsi_boot``"},{"line_number":76,"context_line":"      set to a value of ``true``."},{"line_number":77,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":78,"context_line":"      value of ``0``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_0d2633ce","line":75,"updated":"2016-10-11 20:01:17.000000000","message":"why not use existed capabilities:boot_option\u003discsi_boot here? I assume this is for Ironic+Nova case, for standalone case we should use instance_info/ ?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":72,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":73,"context_line":"          scope at this time."},{"line_number":74,"context_line":"    - Node is configured by the operator with the"},{"line_number":75,"context_line":"      ``node.properties[\u0027capabilities\u0027]`` setting of ``iscsi_boot``"},{"line_number":76,"context_line":"      set to a value of ``true``."},{"line_number":77,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":78,"context_line":"      value of ``0``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_57fa55be","line":75,"in_reply_to":"fa6399be_0d2633ce","updated":"2016-10-12 14:17:35.000000000","message":"Two reasons: 1) The underlying volume connection information spec indicated this format, largely because of the second reason.  2) This is a capability as there are multiple possible supported boot methods. I.e. an operator has a pool of resources.  They may have FCoE support or iSCSI support, or potentially both, and neither.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"92f6cdb86938565798c9d912cf5440c966f5060c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":73,"context_line":"          scope at this time."},{"line_number":74,"context_line":"    - Node is configured by the operator with the"},{"line_number":75,"context_line":"      ``node.properties[\u0027capabilities\u0027]`` setting of ``iscsi_boot``"},{"line_number":76,"context_line":"      set to a value of ``true``."},{"line_number":77,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":78,"context_line":"      value of ``0``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_eb7c60ed","line":75,"in_reply_to":"fa6399be_57fa55be","updated":"2016-10-12 18:25:54.000000000","message":"Perhaps this ought to be named something distinct from \"iscsi_boot\" to avoid confusion on this point - something like \"iscsi_volume_boot\". That can wait until implementation, just a thought.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0d691fc8cff572376dda519469a21198eb660ebf","unresolved":false,"context_lines":[{"line_number":72,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":73,"context_line":"          scope at this time."},{"line_number":74,"context_line":"    - Node is configured by the operator with the"},{"line_number":75,"context_line":"      ``node.properties[\u0027capabilities\u0027]`` setting of ``iscsi_boot``"},{"line_number":76,"context_line":"      set to a value of ``true``."},{"line_number":77,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":78,"context_line":"      value of ``0``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_8b812492","line":75,"in_reply_to":"fa6399be_eb7c60ed","updated":"2016-10-19 11:59:10.000000000","message":"It is an interesting thought, but an implementation detail on another spec. ;)","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    - Implementation of substrate logic in the deploy and PXE driver modules"},{"line_number":87,"context_line":"      to appropriately handle booting a node in a boot from volume scenario."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Scenario 2 - iPXE boot from FCoE"},{"line_number":90,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  Conditions:"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_78820f54","line":89,"range":{"start_line":89,"start_character":28,"end_line":89,"end_character":32},"updated":"2016-10-11 20:01:17.000000000","message":"what is FCoE?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    - Implementation of substrate logic in the deploy and PXE driver modules"},{"line_number":87,"context_line":"      to appropriately handle booting a node in a boot from volume scenario."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Scenario 2 - iPXE boot from FCoE"},{"line_number":90,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  Conditions:"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_971b0d1b","line":89,"range":{"start_line":89,"start_character":28,"end_line":89,"end_character":32},"in_reply_to":"fa6399be_78820f54","updated":"2016-10-12 14:17:35.000000000","message":"FiberChannel over Ethernet.  Seems like that got lost over time.  I\u0027ll add it back shortly.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":98,"context_line":"      via external means."},{"line_number":99,"context_line":"    - Tenant network isolation is unsupported due to iPXE requirements."},{"line_number":100,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"},{"line_number":101,"context_line":"      setting of ``fiberchannel_boot`` set to a value of ``true``."},{"line_number":102,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":103,"context_line":"      value of ``0``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_58bc6b05","line":100,"updated":"2016-10-11 20:01:17.000000000","message":"ditto about boot_option property","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":98,"context_line":"      via external means."},{"line_number":99,"context_line":"    - Tenant network isolation is unsupported due to iPXE requirements."},{"line_number":100,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"},{"line_number":101,"context_line":"      setting of ``fiberchannel_boot`` set to a value of ``true``."},{"line_number":102,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":103,"context_line":"      value of ``0``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_f7a449ba","line":100,"in_reply_to":"fa6399be_58bc6b05","updated":"2016-10-12 14:17:35.000000000","message":"Same reply regarding boot_option as scenario 1.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    - Metadata service use is expected."},{"line_number":122,"context_line":"    - Configuration drive support is unavailable."},{"line_number":123,"context_line":"    - Node boot defaults to block storage device."},{"line_number":124,"context_line":"    - Tenant network isolation is supported."},{"line_number":125,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":126,"context_line":"      via external means."},{"line_number":127,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_b844a774","line":124,"updated":"2016-10-11 20:01:17.000000000","message":"How it is possible?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b9c2f718cc736de2bd29f892f4ca3b26991bfcbe","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    - Metadata service use is expected."},{"line_number":122,"context_line":"    - Configuration drive support is unavailable."},{"line_number":123,"context_line":"    - Node boot defaults to block storage device."},{"line_number":124,"context_line":"    - Tenant network isolation is supported."},{"line_number":125,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":126,"context_line":"      via external means."},{"line_number":127,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_04fb3ec2","line":124,"in_reply_to":"fa6399be_97aead83","updated":"2016-10-12 17:01:13.000000000","message":"Done","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    - Metadata service use is expected."},{"line_number":122,"context_line":"    - Configuration drive support is unavailable."},{"line_number":123,"context_line":"    - Node boot defaults to block storage device."},{"line_number":124,"context_line":"    - Tenant network isolation is supported."},{"line_number":125,"context_line":"    - Operating system is already deployed to the intended boot volume"},{"line_number":126,"context_line":"      via external means."},{"line_number":127,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_97aead83","line":124,"in_reply_to":"fa6399be_b844a774","updated":"2016-10-12 14:17:35.000000000","message":"Because we won\u0027t use network booting in this case, so there are no network driver interface assumptions.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"  Requirements:"},{"line_number":136,"context_line":"    - Creation of driver deploy method functionality that under normal"},{"line_number":137,"context_line":"      circumstances performs a no-op, and defaults the next boot state"},{"line_number":138,"context_line":"      to local disk when the user requests a node to be deployed."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Scenario 4 - Boot via Host Bus Adapter (HBA) to volume with image deployment"},{"line_number":141,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_58538be1","line":138,"updated":"2016-10-11 20:01:17.000000000","message":"next boot state should be ipxe boot?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":135,"context_line":"  Requirements:"},{"line_number":136,"context_line":"    - Creation of driver deploy method functionality that under normal"},{"line_number":137,"context_line":"      circumstances performs a no-op, and defaults the next boot state"},{"line_number":138,"context_line":"      to local disk when the user requests a node to be deployed."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Scenario 4 - Boot via Host Bus Adapter (HBA) to volume with image deployment"},{"line_number":141,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_57f9757f","line":138,"in_reply_to":"fa6399be_58538be1","updated":"2016-10-12 14:17:35.000000000","message":"No, standard power-on boot to disk, although this raises the eventual possibility that we MAY have nodes or ipmi management interfaces that report SAN based disks differently for boot preference.  But, I suspect that may just be something we will have to address when someone comes to the community with something like that.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    - Metadata service is not required."},{"line_number":148,"context_line":"    - Configuration drive is supportable."},{"line_number":149,"context_line":"    - Node boots to block storage device."},{"line_number":150,"context_line":"    - Network isolation is supported."},{"line_number":151,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":152,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":153,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_78884f23","line":150,"updated":"2016-10-11 20:01:17.000000000","message":"We still need to have access to SAN right?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    - Metadata service is not required."},{"line_number":148,"context_line":"    - Configuration drive is supportable."},{"line_number":149,"context_line":"    - Node boots to block storage device."},{"line_number":150,"context_line":"    - Network isolation is supported."},{"line_number":151,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":152,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":153,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_d7ee658a","line":150,"in_reply_to":"fa6399be_78884f23","updated":"2016-10-12 14:17:35.000000000","message":"We will, but via a storage network that is independent of the network interfaces knowledgeable to the OS.  What the bios should see is just another block device being offered via the HBA and boot according to whatever the hardware\u0027s default settings are.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b9c2f718cc736de2bd29f892f4ca3b26991bfcbe","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    - Metadata service is not required."},{"line_number":148,"context_line":"    - Configuration drive is supportable."},{"line_number":149,"context_line":"    - Node boots to block storage device."},{"line_number":150,"context_line":"    - Network isolation is supported."},{"line_number":151,"context_line":"    - Infrastructure and HBA BIOS configuration is such that the node will"},{"line_number":152,"context_line":"      boot to what is expected to be the LUN offered as the boot volume."},{"line_number":153,"context_line":"    - Node is configured with the ``node.properties[\u0027capabilities\u0027]``"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_842d8e48","line":150,"in_reply_to":"fa6399be_d7ee658a","updated":"2016-10-12 17:01:13.000000000","message":"Done","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"92f6cdb86938565798c9d912cf5440c966f5060c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    - Metadata service use expected."},{"line_number":176,"context_line":"    - Configuration drive support is unavailable."},{"line_number":177,"context_line":"    - Node boot defaults to iPXE."},{"line_number":178,"context_line":"    - Node boot utilizes kernel and ramdisk hosted by the conductor"},{"line_number":179,"context_line":"    - Operating System is already deployed to the intended boot volume"},{"line_number":180,"context_line":"      via external means."},{"line_number":181,"context_line":"    - Tenant network isolation is unsupported due to iPXE need."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_067d096e","line":178,"updated":"2016-10-12 18:25:54.000000000","message":"extremely small nit: all the other points end in .\n\nmaybe make it consistent","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0d691fc8cff572376dda519469a21198eb660ebf","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    - Metadata service use expected."},{"line_number":176,"context_line":"    - Configuration drive support is unavailable."},{"line_number":177,"context_line":"    - Node boot defaults to iPXE."},{"line_number":178,"context_line":"    - Node boot utilizes kernel and ramdisk hosted by the conductor"},{"line_number":179,"context_line":"    - Operating System is already deployed to the intended boot volume"},{"line_number":180,"context_line":"      via external means."},{"line_number":181,"context_line":"    - Tenant network isolation is unsupported due to iPXE need."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_eb338011","line":178,"in_reply_to":"fa6399be_067d096e","updated":"2016-10-19 11:59:10.000000000","message":"Good catch!","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"92f6cdb86938565798c9d912cf5440c966f5060c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"      via external means."},{"line_number":181,"context_line":"    - Tenant network isolation is unsupported due to iPXE need."},{"line_number":182,"context_line":"    - Node is configured with ``node.properties[\u0027capabilities\u0027]`` setting of"},{"line_number":183,"context_line":"      ``nfs_boot`` set to a value of true coupled with ``instance_info`` of"},{"line_number":184,"context_line":"      setting of ``nfs_root`` which provides nfs root connection information."},{"line_number":185,"context_line":"    - Kernel and ramdisk utilized support the"},{"line_number":186,"context_line":"      `nfsroot kernel command line option`_."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_66c0857d","line":183,"range":{"start_line":183,"start_character":55,"end_line":183,"end_character":72},"updated":"2016-10-12 18:25:54.000000000","message":"I\u0027m a bit confused here. Is \"nfs_root\" another key in the \"instance_info\" dict?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0d691fc8cff572376dda519469a21198eb660ebf","unresolved":false,"context_lines":[{"line_number":180,"context_line":"      via external means."},{"line_number":181,"context_line":"    - Tenant network isolation is unsupported due to iPXE need."},{"line_number":182,"context_line":"    - Node is configured with ``node.properties[\u0027capabilities\u0027]`` setting of"},{"line_number":183,"context_line":"      ``nfs_boot`` set to a value of true coupled with ``instance_info`` of"},{"line_number":184,"context_line":"      setting of ``nfs_root`` which provides nfs root connection information."},{"line_number":185,"context_line":"    - Kernel and ramdisk utilized support the"},{"line_number":186,"context_line":"      `nfsroot kernel command line option`_."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_06a50903","line":183,"range":{"start_line":183,"start_character":55,"end_line":183,"end_character":72},"in_reply_to":"fa6399be_66c0857d","updated":"2016-10-19 11:59:10.000000000","message":"I think what makes it odd is the \"of\", which seems like it should updated.  To answer the question, yes that is the intent.  Since the only place that I refer to a dictionary otherwise is on a yet to be landed data structure, I think it would be best to leave it as-is.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":217,"context_line":"         utils.check_compatability("},{"line_number":218,"context_line":"             task.driver.deploy.capabilities, \u0027iscsi_volume_deploy\u0027)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"  - Implementation of logic in the existing reference driver deploy"},{"line_number":221,"context_line":"    validate methods to fail the validation of any node that has volume"},{"line_number":222,"context_line":"    storage configured when the driver that a node is configured with"},{"line_number":223,"context_line":"    lacks any such support as identified by the previously noted"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_58470bbb","line":220,"updated":"2016-10-11 20:01:17.000000000","message":"Can it be solved at scheduling time when ironic+nova is used? Nova has limitud number of reschedules which is 3 by default.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":217,"context_line":"         utils.check_compatability("},{"line_number":218,"context_line":"             task.driver.deploy.capabilities, \u0027iscsi_volume_deploy\u0027)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"  - Implementation of logic in the existing reference driver deploy"},{"line_number":221,"context_line":"    validate methods to fail the validation of any node that has volume"},{"line_number":222,"context_line":"    storage configured when the driver that a node is configured with"},{"line_number":223,"context_line":"    lacks any such support as identified by the previously noted"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_7a3bc038","line":220,"in_reply_to":"fa6399be_58470bbb","updated":"2016-10-12 14:17:35.000000000","message":"Via the capabilities, some of it should be able to be properly scheduled, however this is more-so to enable a fast fail based on incompatible or missing node level configuration or an incompatible mix of underlying drivers.  This is particularly important in cases where the node would be booting via an Host Bus Adapter, otherwise we have little ability to tell the user that we thing things should have worked..","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"92f6cdb86938565798c9d912cf5440c966f5060c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"         utils.check_compatability("},{"line_number":218,"context_line":"             task.driver.deploy.capabilities, \u0027iscsi_volume_deploy\u0027)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"  - Implementation of logic in the existing reference driver deploy"},{"line_number":221,"context_line":"    validate methods to fail the validation of any node that has volume"},{"line_number":222,"context_line":"    storage configured when the driver that a node is configured with"},{"line_number":223,"context_line":"    lacks any such support as identified by the previously noted"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_86ae7983","line":220,"in_reply_to":"fa6399be_7a3bc038","updated":"2016-10-12 18:25:54.000000000","message":"This sounds correct. Vasyl, I think it will work like this:\n\n1. nova schedules to a node that advertises the BFV type via capabiltiies dict\n2. ironic validates that other properties, which may be outside of capabilities dict, are valid\n3. ironic continues deploy or fails out based on result of validation\n\nThe alternative would be stuffing everything into the capabilities dict. That goes above and beyond what\u0027s currently done for validate methods. For example, we don\u0027t send ipmi_user/ipmi_password to nova.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0d691fc8cff572376dda519469a21198eb660ebf","unresolved":false,"context_lines":[{"line_number":217,"context_line":"         utils.check_compatability("},{"line_number":218,"context_line":"             task.driver.deploy.capabilities, \u0027iscsi_volume_deploy\u0027)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"  - Implementation of logic in the existing reference driver deploy"},{"line_number":221,"context_line":"    validate methods to fail the validation of any node that has volume"},{"line_number":222,"context_line":"    storage configured when the driver that a node is configured with"},{"line_number":223,"context_line":"    lacks any such support as identified by the previously noted"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_c65f9173","line":220,"in_reply_to":"fa6399be_86ae7983","updated":"2016-10-19 11:59:10.000000000","message":"Exactly","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"92f6cdb86938565798c9d912cf5440c966f5060c","unresolved":false,"context_lines":[{"line_number":230,"context_line":"       default of None will result in a provider interface that performs"},{"line_number":231,"context_line":"       ``no-op`` behavior, while exposing an empty set of storage"},{"line_number":232,"context_line":"       capabilities."},{"line_number":233,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":234,"context_line":"       similar to the `Add network interface to base driver class`_"},{"line_number":235,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":236,"context_line":"       with the provider that is to be utilized."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_c604f17f","line":233,"range":{"start_line":233,"start_character":21,"end_line":233,"end_character":41},"updated":"2016-10-12 18:25:54.000000000","message":"I\u0027m just curious. Can this storage interface be used for simply attaching different volumes at deploy time, even if we don\u0027t boot from them? (not now, but in the future)","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0d691fc8cff572376dda519469a21198eb660ebf","unresolved":false,"context_lines":[{"line_number":230,"context_line":"       default of None will result in a provider interface that performs"},{"line_number":231,"context_line":"       ``no-op`` behavior, while exposing an empty set of storage"},{"line_number":232,"context_line":"       capabilities."},{"line_number":233,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":234,"context_line":"       similar to the `Add network interface to base driver class`_"},{"line_number":235,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":236,"context_line":"       with the provider that is to be utilized."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_86ad998a","line":233,"range":{"start_line":233,"start_character":21,"end_line":233,"end_character":41},"in_reply_to":"fa6399be_c604f17f","updated":"2016-10-19 11:59:10.000000000","message":"So, ultimately the idea is to issue attachments for everything that we can.  So if a dedicated HBA finds the volume via a storage infrastructure, then the volume should appear to a locally booted OS.  The downside is issuing an attachment for iscsi use cases where we have no mechanism to inform the OS that there is an attachment pending for it.  I seem to remember tossing that idea around with some of the cinder folks, and their answer was the tool to perform attachments inside the OS.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"92f6cdb86938565798c9d912cf5440c966f5060c","unresolved":false,"context_lines":[{"line_number":235,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":236,"context_line":"       with the provider that is to be utilized."},{"line_number":237,"context_line":"     - Initial and reference storage driver to be based upon cinder,"},{"line_number":238,"context_line":"       leveraging ``python-cinderclient``, to support the following"},{"line_number":239,"context_line":"       fundamental operations detailed below."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_a6ee1db2","line":238,"range":{"start_line":238,"start_character":20,"end_line":238,"end_character":39},"updated":"2016-10-12 18:25:54.000000000","message":"Why not openstack client?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0d691fc8cff572376dda519469a21198eb660ebf","unresolved":false,"context_lines":[{"line_number":235,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":236,"context_line":"       with the provider that is to be utilized."},{"line_number":237,"context_line":"     - Initial and reference storage driver to be based upon cinder,"},{"line_number":238,"context_line":"       leveraging ``python-cinderclient``, to support the following"},{"line_number":239,"context_line":"       fundamental operations detailed below."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"         - ``detach_volumes`` - Initially implemented to enumerate"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_a667fdb5","line":238,"range":{"start_line":238,"start_character":20,"end_line":238,"end_character":39},"in_reply_to":"fa6399be_a6ee1db2","updated":"2016-10-19 11:59:10.000000000","message":"As I understand it, OSC is intended for end-user usage, not exactly for direct rest API interaction usage.  Besides, OSC presently imports python-cinderclient to connect to cinder. :)","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"92f6cdb86938565798c9d912cf5440c966f5060c","unresolved":false,"context_lines":[{"line_number":247,"context_line":"           we will reserve the volumes in our configuration, initialize"},{"line_number":248,"context_line":"           connections to the volumes meanwhile supplying current initator"},{"line_number":249,"context_line":"           configuration, then trigger the cinder volume attach call to update"},{"line_number":250,"context_line":"           the database configuraiton. Additionally, we will update the volume"},{"line_number":251,"context_line":"           metadata to allow for easy user identification of volumes that are"},{"line_number":252,"context_line":"           for ironic nodes by recording information to allow for"},{"line_number":253,"context_line":"           reconciliation of nodes that are powered off with detached volume."}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_26104da8","line":250,"range":{"start_line":250,"start_character":24,"end_line":250,"end_character":37},"updated":"2016-10-12 18:25:54.000000000","message":"nit: s/configuraiton/configuration","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":248,"context_line":"           connections to the volumes meanwhile supplying current initator"},{"line_number":249,"context_line":"           configuration, then trigger the cinder volume attach call to update"},{"line_number":250,"context_line":"           the database configuraiton. Additionally, we will update the volume"},{"line_number":251,"context_line":"           metadata to allow for easy user identification of volumes that are"},{"line_number":252,"context_line":"           for ironic nodes by recording information to allow for"},{"line_number":253,"context_line":"           reconciliation of nodes that are powered off with detached volume."},{"line_number":254,"context_line":"         - ``add_volume`` - Raises an"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_b309282f","line":251,"updated":"2016-10-11 20:01:17.000000000","message":"that are used for ironic nodes","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":248,"context_line":"           connections to the volumes meanwhile supplying current initator"},{"line_number":249,"context_line":"           configuration, then trigger the cinder volume attach call to update"},{"line_number":250,"context_line":"           the database configuraiton. Additionally, we will update the volume"},{"line_number":251,"context_line":"           metadata to allow for easy user identification of volumes that are"},{"line_number":252,"context_line":"           for ironic nodes by recording information to allow for"},{"line_number":253,"context_line":"           reconciliation of nodes that are powered off with detached volume."},{"line_number":254,"context_line":"         - ``add_volume`` - Raises an"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_ba4ab8aa","line":251,"in_reply_to":"fa6399be_b309282f","updated":"2016-10-12 14:17:35.000000000","message":"\"that are used by ironic nodes\" sounds far better to me, but great catch, thank you!","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b9c2f718cc736de2bd29f892f4ca3b26991bfcbe","unresolved":false,"context_lines":[{"line_number":248,"context_line":"           connections to the volumes meanwhile supplying current initator"},{"line_number":249,"context_line":"           configuration, then trigger the cinder volume attach call to update"},{"line_number":250,"context_line":"           the database configuraiton. Additionally, we will update the volume"},{"line_number":251,"context_line":"           metadata to allow for easy user identification of volumes that are"},{"line_number":252,"context_line":"           for ironic nodes by recording information to allow for"},{"line_number":253,"context_line":"           reconciliation of nodes that are powered off with detached volume."},{"line_number":254,"context_line":"         - ``add_volume`` - Raises an"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_443616e7","line":251,"in_reply_to":"fa6399be_ba4ab8aa","updated":"2016-10-12 17:01:13.000000000","message":"Wel, I didn\u0027t see the by on line 252, so \"for\" does actually make more sense. :)","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"  - Updating of the ``agent.AgentDeploy`` and ``iscsi_deploy.ISCSIDeploy``"},{"line_number":281,"context_line":"    driver logic to support skipping deployment of a node if a storage"},{"line_number":282,"context_line":"    provider is enabled, volume information exists for the volume, and"},{"line_number":283,"context_line":"    the volume has an index of ``0`` indicating it is the boot volume."},{"line_number":284,"context_line":"    In essence, this means that if the node is defined to boot from a"},{"line_number":285,"context_line":"    remote volume, that the driver.deploy.deploy method should immediately"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_be200f9d","line":282,"updated":"2016-10-11 20:01:17.000000000","message":"If the deployment is skipped there is no need to set kernel and initrams options in driver_info? Node will never boot to ramdisk if storage provider is enabled right?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"  - Updating of the ``agent.AgentDeploy`` and ``iscsi_deploy.ISCSIDeploy``"},{"line_number":281,"context_line":"    driver logic to support skipping deployment of a node if a storage"},{"line_number":282,"context_line":"    provider is enabled, volume information exists for the volume, and"},{"line_number":283,"context_line":"    the volume has an index of ``0`` indicating it is the boot volume."},{"line_number":284,"context_line":"    In essence, this means that if the node is defined to boot from a"},{"line_number":285,"context_line":"    remote volume, that the driver.deploy.deploy method should immediately"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_9afdf43c","line":282,"in_reply_to":"fa6399be_be200f9d","updated":"2016-10-12 14:17:35.000000000","message":"I believe they are required for cleaning operations.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"92f6cdb86938565798c9d912cf5440c966f5060c","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    storage provider detach_volumes method and purge volume information"},{"line_number":321,"context_line":"    if not already implemented."},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        - At the beginning and completion of the storage detachment"},{"line_number":324,"context_line":"          interaction, a notification shall be generated to allow"},{"line_number":325,"context_line":"          visibity into if the process is successfully completed."},{"line_number":326,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_0645096f","line":323,"updated":"2016-10-12 18:25:54.000000000","message":"Not sure if we should also do this during the attachment phase. Let\u0027s wait on the implementation to decide. I think there can be some sort of generic deploy notification that can cover the attachment phase, possibly.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0d691fc8cff572376dda519469a21198eb660ebf","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    storage provider detach_volumes method and purge volume information"},{"line_number":321,"context_line":"    if not already implemented."},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        - At the beginning and completion of the storage detachment"},{"line_number":324,"context_line":"          interaction, a notification shall be generated to allow"},{"line_number":325,"context_line":"          visibity into if the process is successfully completed."},{"line_number":326,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_260f6d89","line":323,"in_reply_to":"fa6399be_0645096f","updated":"2016-10-19 11:59:10.000000000","message":"Agreed.  The spec can always be revised once it has been landed if the implementation details change.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":336,"context_line":"understand how to deploy to a system with such configuration."},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"  - Updating of the deploy driver to enable the logic added for scenarios 1-3"},{"line_number":339,"context_line":"    to be bypassed using a ``force_deployment`` parameter which should be"},{"line_number":340,"context_line":"    removed from the node\u0027s instance_info prior to the node reaching the"},{"line_number":341,"context_line":"    active state."},{"line_number":342,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_f3cac04e","line":339,"updated":"2016-10-11 20:01:17.000000000","message":"what is force_deployment? and how exactly we are going to use this flag? When we add it/remove etc? Can we have a more detail description here?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b9c2f718cc736de2bd29f892f4ca3b26991bfcbe","unresolved":false,"context_lines":[{"line_number":336,"context_line":"understand how to deploy to a system with such configuration."},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"  - Updating of the deploy driver to enable the logic added for scenarios 1-3"},{"line_number":339,"context_line":"    to be bypassed using a ``force_deployment`` parameter which should be"},{"line_number":340,"context_line":"    removed from the node\u0027s instance_info prior to the node reaching the"},{"line_number":341,"context_line":"    active state."},{"line_number":342,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_e4f72af3","line":339,"in_reply_to":"fa6399be_f3cac04e","updated":"2016-10-12 17:01:13.000000000","message":"Done","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":336,"context_line":"understand how to deploy to a system with such configuration."},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"  - Updating of the deploy driver to enable the logic added for scenarios 1-3"},{"line_number":339,"context_line":"    to be bypassed using a ``force_deployment`` parameter which should be"},{"line_number":340,"context_line":"    removed from the node\u0027s instance_info prior to the node reaching the"},{"line_number":341,"context_line":"    active state."},{"line_number":342,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_1a45646f","line":339,"in_reply_to":"fa6399be_f3cac04e","updated":"2016-10-12 14:17:35.000000000","message":"I\u0027ll make this more verbose as this is more of a \"We have an HBA attached volume, we actually want the agent to write out the OS/config drive to the volume.\"","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"  - Agent will need to be informed of the desired volume for the boot volume,"},{"line_number":344,"context_line":"    and, if supplied to the target, connection information. The appropriate"},{"line_number":345,"context_line":"    information should be passed in using `Root device hints`_."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"In order to support scenario 5:"},{"line_number":348,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_d303fc71","line":345,"updated":"2016-10-11 20:01:17.000000000","message":"Can we have a more detail description here? What exactly we expected to pass via root device hints?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b9c2f718cc736de2bd29f892f4ca3b26991bfcbe","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"  - Agent will need to be informed of the desired volume for the boot volume,"},{"line_number":344,"context_line":"    and, if supplied to the target, connection information. The appropriate"},{"line_number":345,"context_line":"    information should be passed in using `Root device hints`_."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"In order to support scenario 5:"},{"line_number":348,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_c4f4e6f3","line":345,"in_reply_to":"fa6399be_4d3ba4d1","updated":"2016-10-12 17:01:13.000000000","message":"Done","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"  - Agent will need to be informed of the desired volume for the boot volume,"},{"line_number":344,"context_line":"    and, if supplied to the target, connection information. The appropriate"},{"line_number":345,"context_line":"    information should be passed in using `Root device hints`_."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"In order to support scenario 5:"},{"line_number":348,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_4d3ba4d1","line":345,"in_reply_to":"fa6399be_d303fc71","updated":"2016-10-12 14:17:35.000000000","message":"I\u0027ll detail what is expected to be passed.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":392,"context_line":""},{"line_number":393,"context_line":"None. All expected CLI updates are expected to be part of the"},{"line_number":394,"context_line":"specification covering information storage,"},{"line_number":395,"context_line":"`Add volume connection information for Ironic nodes`_."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"\"openstack baremetal\" CLI"},{"line_number":398,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_fe3a87cc","line":395,"updated":"2016-10-11 20:01:17.000000000","message":"the spec is merged, please update link to use docs instead of commit reference.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":392,"context_line":""},{"line_number":393,"context_line":"None. All expected CLI updates are expected to be part of the"},{"line_number":394,"context_line":"specification covering information storage,"},{"line_number":395,"context_line":"`Add volume connection information for Ironic nodes`_."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"\"openstack baremetal\" CLI"},{"line_number":398,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_ed50f80c","line":395,"in_reply_to":"fa6399be_fe3a87cc","updated":"2016-10-12 14:17:35.000000000","message":"Will do.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed6ac93e8e06222fbca91016c3d68b4124ded7c1","unresolved":false,"context_lines":[{"line_number":451,"context_line":"Ramdisk impact"},{"line_number":452,"context_line":"--------------"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"While we should be able to derive the intended root volume and pass"},{"line_number":455,"context_line":"an appropriate root hint if necessary in order to facilitate a deployment"},{"line_number":456,"context_line":"as part of"},{"line_number":457,"context_line":"`Scenario 4 - Boot via Host Bus Adapter (HBA) to volume with image deployment`_"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_3307d81d","line":454,"updated":"2016-10-11 20:01:17.000000000","message":"It confuses a little in l 281 it is said that deployment is skipped why we need ramdisk at all?","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ccefc313abab7cf10b56f64d9e027dfa79caa16","unresolved":false,"context_lines":[{"line_number":451,"context_line":"Ramdisk impact"},{"line_number":452,"context_line":"--------------"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"While we should be able to derive the intended root volume and pass"},{"line_number":455,"context_line":"an appropriate root hint if necessary in order to facilitate a deployment"},{"line_number":456,"context_line":"as part of"},{"line_number":457,"context_line":"`Scenario 4 - Boot via Host Bus Adapter (HBA) to volume with image deployment`_"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fa6399be_8d4cdc71","line":454,"in_reply_to":"fa6399be_3307d81d","updated":"2016-10-12 14:17:35.000000000","message":"Cleaning or an explicitly forced deployment in the use case of Host Bus Adapters.","commit_id":"012c74f3faec8875cb29693e1def3ac15231d273"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Not covered as part of this specification is handling of support for"},{"line_number":44,"context_line":"MultiPath IO, sometimes referred to as MPIO. We feel this is largely"},{"line_number":45,"context_line":"outside of Ironic\u0027s scope at this point in time."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Additionally not covered is the requirement to use UEFI HTTP boot support,"},{"line_number":48,"context_line":"which was set forth during the `ironic mitaka midcycle`_. Using UEFI HTTP boot"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_eff9eec9","line":45,"updated":"2016-10-22 14:56:23.000000000","message":"I have quite a few customers who don\u0027t feel the same :)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Not covered as part of this specification is handling of support for"},{"line_number":44,"context_line":"MultiPath IO, sometimes referred to as MPIO. We feel this is largely"},{"line_number":45,"context_line":"outside of Ironic\u0027s scope at this point in time."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Additionally not covered is the requirement to use UEFI HTTP boot support,"},{"line_number":48,"context_line":"which was set forth during the `ironic mitaka midcycle`_. Using UEFI HTTP boot"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_dcc4e493","line":45,"in_reply_to":"da6895a0_eff9eec9","updated":"2016-10-28 13:28:57.000000000","message":"To fully support MPIO, we would need to have efforts that help push some information into the configuration drive, since MPIO is largely up to the guest OS an the hardware.  :)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      support is not feasible at this time."},{"line_number":63,"context_line":"    - Configuration drive is not supported."},{"line_number":64,"context_line":"        - For context: This is a limitation as a result of the minimum"},{"line_number":65,"context_line":"          new volume and new volume extension sizes. This may be a"},{"line_number":66,"context_line":"          capability at a later point in time, but is out of scope"},{"line_number":67,"context_line":"          for an initial implementation."},{"line_number":68,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_95d12cd0","line":65,"updated":"2016-10-19 20:15:34.000000000","message":"in cinder, right?","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      support is not feasible at this time."},{"line_number":63,"context_line":"    - Configuration drive is not supported."},{"line_number":64,"context_line":"        - For context: This is a limitation as a result of the minimum"},{"line_number":65,"context_line":"          new volume and new volume extension sizes. This may be a"},{"line_number":66,"context_line":"          capability at a later point in time, but is out of scope"},{"line_number":67,"context_line":"          for an initial implementation."},{"line_number":68,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_939ce15e","line":65,"in_reply_to":"fa6399be_95d12cd0","updated":"2016-10-28 13:28:57.000000000","message":"Done.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        - For context: This is a limitation as a result of the minimum"},{"line_number":65,"context_line":"          new volume and new volume extension sizes. This may be a"},{"line_number":66,"context_line":"          capability at a later point in time, but is out of scope"},{"line_number":67,"context_line":"          for an initial implementation."},{"line_number":68,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":69,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":70,"context_line":"      volume via external means."}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_0ff702d4","line":67,"updated":"2016-10-22 14:56:23.000000000","message":"I guess we can just use large config drives. Anyway, let\u0027s postpone it.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          new volume and new volume extension sizes. This may be a"},{"line_number":66,"context_line":"          capability at a later point in time, but is out of scope"},{"line_number":67,"context_line":"          for an initial implementation."},{"line_number":68,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":69,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":70,"context_line":"      volume via external means."},{"line_number":71,"context_line":"    - Tenant network isolation is unsupported due to the need for iPXE boot."}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_2f04c6be","line":68,"updated":"2016-10-22 14:56:23.000000000","message":"nit: would be nice to state this version","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          new volume and new volume extension sizes. This may be a"},{"line_number":66,"context_line":"          capability at a later point in time, but is out of scope"},{"line_number":67,"context_line":"          for an initial implementation."},{"line_number":68,"context_line":"    - iPXE version sufficient to support boot from iSCSI target."},{"line_number":69,"context_line":"    - Operating system is already deployed to the intended iSCSI boot"},{"line_number":70,"context_line":"      volume via external means."},{"line_number":71,"context_line":"    - Tenant network isolation is unsupported due to the need for iPXE boot."}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_fcf608d6","line":68,"in_reply_to":"da6895a0_2f04c6be","updated":"2016-10-28 13:28:57.000000000","message":"I agree, although an operator may be building their own IPXE binary from the IPXE source that lacks iscsi, and as such I think it is best just to leave this as-is.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    - Tenant network isolation is unsupported due to the need for iPXE boot."},{"line_number":72,"context_line":"        - Potentially in the future, a framework or proxy could be created to"},{"line_number":73,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":74,"context_line":"          scope at this time."},{"line_number":75,"context_line":"    - Node is configured by the operator with the"},{"line_number":76,"context_line":"      ``node.properties[\u0027capabilities\u0027]`` setting of ``iscsi_boot``"},{"line_number":77,"context_line":"      set to a value of ``true``."}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_4f01faad","line":74,"updated":"2016-10-22 14:56:23.000000000","message":"We may try to document the requirements for that. It seems like we need: 1. iPXE HTTP proxy, 2. Cinder to listen on tenant network. Nothing seems impossible to me. Anyway, I agree with postponing this one as well.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":74,"context_line":"          scope at this time."},{"line_number":75,"context_line":"    - Node is configured by the operator with the"},{"line_number":76,"context_line":"      ``node.properties[\u0027capabilities\u0027]`` setting of ``iscsi_boot``"},{"line_number":77,"context_line":"      set to a value of ``true``."},{"line_number":78,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":79,"context_line":"      value of ``0``."}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_6f2cfe4a","line":76,"updated":"2016-10-22 14:56:23.000000000","message":"It does not like like this is specific to a node, right? I wonder if it can be automatically set by the driver. This is something I\u0027ve had in backlog for a while: http://specs.openstack.org/openstack/ironic-specs/specs/backlog/driver-capabilities.html (not exatly this idea, but quite related)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"62b1953a5c211ebe6d187eeb956c5414e3c44436","unresolved":false,"context_lines":[{"line_number":73,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":74,"context_line":"          scope at this time."},{"line_number":75,"context_line":"    - Node is configured by the operator with the"},{"line_number":76,"context_line":"      ``node.properties[\u0027capabilities\u0027]`` setting of ``iscsi_boot``"},{"line_number":77,"context_line":"      set to a value of ``true``."},{"line_number":78,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":79,"context_line":"      value of ``0``."}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_8d214c50","line":76,"in_reply_to":"da6895a0_6f2cfe4a","updated":"2016-10-24 09:48:37.000000000","message":"Hm, but operator might still want to use the usual boot ?","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"          enable tenant network isolation, however that is considered out of"},{"line_number":74,"context_line":"          scope at this time."},{"line_number":75,"context_line":"    - Node is configured by the operator with the"},{"line_number":76,"context_line":"      ``node.properties[\u0027capabilities\u0027]`` setting of ``iscsi_boot``"},{"line_number":77,"context_line":"      set to a value of ``true``."},{"line_number":78,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":79,"context_line":"      value of ``0``."}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_9cd18cd0","line":76,"in_reply_to":"da6895a0_8d214c50","updated":"2016-10-28 13:28:57.000000000","message":"This would be specific to a node.  Imagine I have two racks with mutually exclusive storage fabric capabilities.  Only the operator will know if the hardware can and should possess this information for scheduling.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"62b1953a5c211ebe6d187eeb956c5414e3c44436","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    - Node is configured by the operator with the"},{"line_number":76,"context_line":"      ``node.properties[\u0027capabilities\u0027]`` setting of ``iscsi_boot``"},{"line_number":77,"context_line":"      set to a value of ``true``."},{"line_number":78,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":79,"context_line":"      value of ``0``."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  Requirements:"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_2dd76024","line":78,"updated":"2016-10-24 09:48:37.000000000","message":"I\u0027d state this explicitly, in volume_targets table.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    - Node is configured by the operator with the"},{"line_number":76,"context_line":"      ``node.properties[\u0027capabilities\u0027]`` setting of ``iscsi_boot``"},{"line_number":77,"context_line":"      set to a value of ``true``."},{"line_number":78,"context_line":"    - Node has a defined volume target with a ``boot_index``"},{"line_number":79,"context_line":"      value of ``0``."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  Requirements:"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_bcd650c3","line":78,"in_reply_to":"da6895a0_2dd76024","updated":"2016-10-28 13:28:57.000000000","message":"Done","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"      defined in"},{"line_number":162,"context_line":"      `Scenario 3 - Boot via hardware Host Bus Adapter (HBA) to volume`_,"},{"line_number":163,"context_line":"      however via the inclusion of default logic that only invokes deploy"},{"line_number":164,"context_line":"      phase when explicitly requested for boot from a volume."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Scenario 5 - iPXE boot to NFS root volume"},{"line_number":167,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_8f3152a5","line":164,"updated":"2016-10-22 14:56:23.000000000","message":"I suspect there will be different drivers for that, but worth clarifying.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":161,"context_line":"      defined in"},{"line_number":162,"context_line":"      `Scenario 3 - Boot via hardware Host Bus Adapter (HBA) to volume`_,"},{"line_number":163,"context_line":"      however via the inclusion of default logic that only invokes deploy"},{"line_number":164,"context_line":"      phase when explicitly requested for boot from a volume."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Scenario 5 - iPXE boot to NFS root volume"},{"line_number":167,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_d55e4444","line":164,"updated":"2016-10-19 20:15:34.000000000","message":"I\u0027m not sure how the user can distinguish scenario 4 from 3. What am I missing?","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"      defined in"},{"line_number":162,"context_line":"      `Scenario 3 - Boot via hardware Host Bus Adapter (HBA) to volume`_,"},{"line_number":163,"context_line":"      however via the inclusion of default logic that only invokes deploy"},{"line_number":164,"context_line":"      phase when explicitly requested for boot from a volume."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Scenario 5 - iPXE boot to NFS root volume"},{"line_number":167,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_3c56c029","line":164,"in_reply_to":"da6895a0_8f3152a5","updated":"2016-10-28 13:28:57.000000000","message":"Line 160 in the next revision should provide greater clarity.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":219,"context_line":"             task.driver.boot.capabilities, \u0027iscsi_volume_boot\u0027)"},{"line_number":220,"context_line":"         utils.check_compatability("},{"line_number":221,"context_line":"             task.driver.deploy.capabilities, \u0027iscsi_volume_deploy\u0027)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"  - Implementation of logic in the existing reference driver deploy"},{"line_number":224,"context_line":"    validate methods to fail the validation of any node that has volume"},{"line_number":225,"context_line":"    storage configured when the driver that a node is configured with"}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_6085b457","line":222,"updated":"2016-10-19 20:15:34.000000000","message":"are driver.[boot|deploy].capabilities new? (Or have I forgotten how things work)\n\nOk, I\u0027m not that forgetful. You mention it below -- maybe mention that here, since you only mention the helper method (which isn\u0027t as interesting), not the new boot.capabilities.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":219,"context_line":"             task.driver.boot.capabilities, \u0027iscsi_volume_boot\u0027)"},{"line_number":220,"context_line":"         utils.check_compatability("},{"line_number":221,"context_line":"             task.driver.deploy.capabilities, \u0027iscsi_volume_deploy\u0027)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"  - Implementation of logic in the existing reference driver deploy"},{"line_number":224,"context_line":"    validate methods to fail the validation of any node that has volume"},{"line_number":225,"context_line":"    storage configured when the driver that a node is configured with"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_1777153b","line":222,"in_reply_to":"fa6399be_6085b457","updated":"2016-10-28 13:28:57.000000000","message":"I\u0027m further clarifying this slightly since I\u0027m introducing an as-needed concept for understanding if something is supported in another driver, hopefully it answers the question.  If not, I think we just need to talk about it. :)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    validate methods to fail the validation of any node that has volume"},{"line_number":225,"context_line":"    storage configured when the driver that a node is configured with"},{"line_number":226,"context_line":"    lacks any such support as identified by the previously noted"},{"line_number":227,"context_line":"    capability interface."},{"line_number":228,"context_line":"    This is to help ensure that such nodes are not accidentally"},{"line_number":229,"context_line":"    provisioned with erroneous user expectations."},{"line_number":230,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_af261666","line":227,"updated":"2016-10-22 14:56:23.000000000","message":"Any ideas how to help 3rd party deploy interfaces achieve the same?","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    validate methods to fail the validation of any node that has volume"},{"line_number":225,"context_line":"    storage configured when the driver that a node is configured with"},{"line_number":226,"context_line":"    lacks any such support as identified by the previously noted"},{"line_number":227,"context_line":"    capability interface."},{"line_number":228,"context_line":"    This is to help ensure that such nodes are not accidentally"},{"line_number":229,"context_line":"    provisioned with erroneous user expectations."},{"line_number":230,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_b781094d","line":227,"in_reply_to":"da6895a0_af261666","updated":"2016-10-28 13:28:57.000000000","message":"Such as the ansible deploy driver?  I suspect those users have a completely different expectation of the result of a deployment.   Long story short, I don\u0027t think there really is a way to effectively help them other then add some logic on their own to meet their deploy use case.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ad15fc565e76f6af7cf0ca3d9b65d6ea6a2641d4","unresolved":false,"context_lines":[{"line_number":231,"context_line":"  - Creation of a storage provider interface:"},{"line_number":232,"context_line":"     - Similar in composition to the network provider interface, where a"},{"line_number":233,"context_line":"       default of None will result in a provider interface that performs"},{"line_number":234,"context_line":"       ``no-op`` behavior, while exposing an empty set of storage"},{"line_number":235,"context_line":"       capabilities."},{"line_number":236,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":237,"context_line":"       similar to the `Add network interface to base driver class`_"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_60ecff8f","line":234,"updated":"2016-10-24 09:59:35.000000000","message":"So there won\u0027t be any default_storage_interface? This does not correspond to a logic that is proposed in update to driver composition spec.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":231,"context_line":"  - Creation of a storage provider interface:"},{"line_number":232,"context_line":"     - Similar in composition to the network provider interface, where a"},{"line_number":233,"context_line":"       default of None will result in a provider interface that performs"},{"line_number":234,"context_line":"       ``no-op`` behavior, while exposing an empty set of storage"},{"line_number":235,"context_line":"       capabilities."},{"line_number":236,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":237,"context_line":"       similar to the `Add network interface to base driver class`_"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_37ab3976","line":234,"in_reply_to":"da6895a0_60ecff8f","updated":"2016-10-28 13:28:57.000000000","message":"default_storage_interface would be an override for the default.  Revising this slightly since we\u0027ve since learned that we can\u0027t just map python None to anything and expect it to work, which is where driver composition is going.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":236,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":237,"context_line":"       similar to the `Add network interface to base driver class`_"},{"line_number":238,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":239,"context_line":"       with the provider that is to be utilized."},{"line_number":240,"context_line":"     - Initial and reference storage driver to be based upon cinder,"},{"line_number":241,"context_line":"       leveraging ``python-cinderclient`` for the REST API interface,"},{"line_number":242,"context_line":"       to support the following fundamental operations detailed below."}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_cf2b4a2f","line":239,"updated":"2016-10-22 14:56:23.000000000","message":"I guess you can link to the driver composition too (maybe it won\u0027t be implemented by that time, but it\u0027s definitely a good source of inspiration :)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":236,"context_line":"     - A node level ``storage_interface`` setting with default value,"},{"line_number":237,"context_line":"       similar to the `Add network interface to base driver class`_"},{"line_number":238,"context_line":"       change, to define if a node is to utilize the storage interface along"},{"line_number":239,"context_line":"       with the provider that is to be utilized."},{"line_number":240,"context_line":"     - Initial and reference storage driver to be based upon cinder,"},{"line_number":241,"context_line":"       leveraging ``python-cinderclient`` for the REST API interface,"},{"line_number":242,"context_line":"       to support the following fundamental operations detailed below."}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_77305157","line":239,"in_reply_to":"da6895a0_cf2b4a2f","updated":"2016-10-28 13:28:57.000000000","message":"Done :)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":248,"context_line":"           through known configured volumes and issue storage"},{"line_number":249,"context_line":"           attachment requests. In the case of the cinder driver,"},{"line_number":250,"context_line":"           we will reserve the volumes in our configuration, initialize"},{"line_number":251,"context_line":"           connections to the volumes meanwhile supplying current initator"},{"line_number":252,"context_line":"           configuration, then trigger the cinder volume attach call to update"},{"line_number":253,"context_line":"           the database configuration. Additionally, we will update the volume"},{"line_number":254,"context_line":"           metadata to allow for easy user identification of volumes that are"}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_0077983a","line":251,"updated":"2016-10-19 20:15:34.000000000","message":"s/initator/initiator/","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":248,"context_line":"           through known configured volumes and issue storage"},{"line_number":249,"context_line":"           attachment requests. In the case of the cinder driver,"},{"line_number":250,"context_line":"           we will reserve the volumes in our configuration, initialize"},{"line_number":251,"context_line":"           connections to the volumes meanwhile supplying current initator"},{"line_number":252,"context_line":"           configuration, then trigger the cinder volume attach call to update"},{"line_number":253,"context_line":"           the database configuration. Additionally, we will update the volume"},{"line_number":254,"context_line":"           metadata to allow for easy user identification of volumes that are"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_970c0596","line":251,"in_reply_to":"fa6399be_0077983a","updated":"2016-10-28 13:28:57.000000000","message":"Done","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":261,"context_line":"         - ``remove_volume`` - Raises an"},{"line_number":262,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":263,"context_line":"           capability that makes sense to define now, intended for volume"},{"line_number":264,"context_line":"           creation in a stand-alone or hardware composition model."},{"line_number":265,"context_line":"         - ``validate`` - Initially implemented to validate that sufficient"},{"line_number":266,"context_line":"           configuration is present in the configuration to allow for the"},{"line_number":267,"context_line":"           functionality to operate. This validation will be skipped if no"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_ef200e4c","line":264,"updated":"2016-10-22 14:56:23.000000000","message":"I highly suggest we don\u0027t add them. I won\u0027t block this spec based on that alone, but I fully agree with Ruby\u0027s concerns.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":261,"context_line":"         - ``remove_volume`` - Raises an"},{"line_number":262,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":263,"context_line":"           capability that makes sense to define now, intended for volume"},{"line_number":264,"context_line":"           creation in a stand-alone or hardware composition model."},{"line_number":265,"context_line":"         - ``validate`` - Initially implemented to validate that sufficient"},{"line_number":266,"context_line":"           configuration is present in the configuration to allow for the"},{"line_number":267,"context_line":"           functionality to operate. This validation will be skipped if no"}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_a0b34ce8","line":264,"updated":"2016-10-19 20:15:34.000000000","message":"I\u0027m not convinced it makes sense to add these now, but I guess it won\u0027t hurt. (The problem with adding is if we decide to change them later when we first use it, and then have to deal with deprecations due to out-of-tree usage of it.)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"         - ``remove_volume`` - Raises an"},{"line_number":262,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":263,"context_line":"           capability that makes sense to define now, intended for volume"},{"line_number":264,"context_line":"           creation in a stand-alone or hardware composition model."},{"line_number":265,"context_line":"         - ``validate`` - Initially implemented to validate that sufficient"},{"line_number":266,"context_line":"           configuration is present in the configuration to allow for the"},{"line_number":267,"context_line":"           functionality to operate. This validation will be skipped if no"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_f76aa119","line":264,"in_reply_to":"da6895a0_ef200e4c","updated":"2016-10-28 13:28:57.000000000","message":"I can agree with that, my huge concern is the addition of them is a breaking change to third party drivers if/when they occur.  I\u0027ll remove them for now, and hopefully we get around to adding them quickly.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":268,"context_line":"           volumes are defined."},{"line_number":269,"context_line":"         - ``sort_path_preferences`` - Raises an"},{"line_number":270,"context_line":"           ``UnsupportedDriverExtension``. Exists as a future driver"},{"line_number":271,"context_line":"           capability that makes sense to define now. Prioritization sorting"},{"line_number":272,"context_line":"           capability will be key as time progresses for operators to evenly"},{"line_number":273,"context_line":"           utilize their infrastructure. In future, each path"},{"line_number":274,"context_line":"           provided can be evaluated and some sort of weighting system (to"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_0f1e220c","line":271,"updated":"2016-10-22 14:56:23.000000000","message":"ditto. it\u0027s hard to judge if it\u0027s a good idea or not right now, so let\u0027s not commit to it","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":275,"context_line":"           be determined) applied."},{"line_number":276,"context_line":"           The dictionary defining the path can then be updated with a numeric"},{"line_number":277,"context_line":"           preference."},{"line_number":278,"context_line":"         - ``check_write_image`` - Provides an interface to allow the storage"},{"line_number":279,"context_line":"           other components to ask the storage driver if the image should be"},{"line_number":280,"context_line":"           written to disk.  This allows all of the logic to be housed with"},{"line_number":281,"context_line":"           the storage driver."}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_2f1be61c","line":278,"updated":"2016-10-22 14:56:23.000000000","message":"nit: maybe \"should_write_image\" (if I understand it right, of course). also maybe it should be a property/constant?","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":275,"context_line":"           be determined) applied."},{"line_number":276,"context_line":"           The dictionary defining the path can then be updated with a numeric"},{"line_number":277,"context_line":"           preference."},{"line_number":278,"context_line":"         - ``check_write_image`` - Provides an interface to allow the storage"},{"line_number":279,"context_line":"           other components to ask the storage driver if the image should be"},{"line_number":280,"context_line":"           written to disk.  This allows all of the logic to be housed with"},{"line_number":281,"context_line":"           the storage driver."}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_374c19c7","line":278,"in_reply_to":"da6895a0_2f1be61c","updated":"2016-10-28 13:28:57.000000000","message":"I think it ends up being a logical check of multiple different parameters to determine if we can and should do something.  Changing the name :)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":276,"context_line":"           The dictionary defining the path can then be updated with a numeric"},{"line_number":277,"context_line":"           preference."},{"line_number":278,"context_line":"         - ``check_write_image`` - Provides an interface to allow the storage"},{"line_number":279,"context_line":"           other components to ask the storage driver if the image should be"},{"line_number":280,"context_line":"           written to disk.  This allows all of the logic to be housed with"},{"line_number":281,"context_line":"           the storage driver."},{"line_number":282,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_80356847","line":279,"updated":"2016-10-19 20:15:34.000000000","message":"there\u0027s something odd here. what is \u0027storage other components\u0027? Maybe you mean s/storage//","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":276,"context_line":"           The dictionary defining the path can then be updated with a numeric"},{"line_number":277,"context_line":"           preference."},{"line_number":278,"context_line":"         - ``check_write_image`` - Provides an interface to allow the storage"},{"line_number":279,"context_line":"           other components to ask the storage driver if the image should be"},{"line_number":280,"context_line":"           written to disk.  This allows all of the logic to be housed with"},{"line_number":281,"context_line":"           the storage driver."},{"line_number":282,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_77f3f173","line":279,"in_reply_to":"fa6399be_80356847","updated":"2016-10-28 13:28:57.000000000","message":"s/driver/interface/ would have been the intent :)  I\u0027ll change that, and if it makes more sense \\o/, if not, we can always revise it.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":278,"context_line":"         - ``check_write_image`` - Provides an interface to allow the storage"},{"line_number":279,"context_line":"           other components to ask the storage driver if the image should be"},{"line_number":280,"context_line":"           written to disk.  This allows all of the logic to be housed with"},{"line_number":281,"context_line":"           the storage driver."},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"  - Updating of the ``agent.AgentDeploy`` and ``iscsi_deploy.ISCSIDeploy``"},{"line_number":284,"context_line":"    driver logic to support skipping deployment of a node if a storage"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_4f181a1e","line":281,"updated":"2016-10-22 14:56:23.000000000","message":"I understand that deploy drivers will do:\n\n if task.driver.storage.should_write_image:\n   # boot IPA, put the image to the remove disk, then boot the user instance\n else:\n   # just boot the user instance\n\nOh, see there is an example below. Would be good to start with it for ease of reading :)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":278,"context_line":"         - ``check_write_image`` - Provides an interface to allow the storage"},{"line_number":279,"context_line":"           other components to ask the storage driver if the image should be"},{"line_number":280,"context_line":"           written to disk.  This allows all of the logic to be housed with"},{"line_number":281,"context_line":"           the storage driver."},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"  - Updating of the ``agent.AgentDeploy`` and ``iscsi_deploy.ISCSIDeploy``"},{"line_number":284,"context_line":"    driver logic to support skipping deployment of a node if a storage"}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_40c7d011","line":281,"updated":"2016-10-19 20:15:34.000000000","message":"I\u0027m not sure I understand this, but I\u0027ll wait to see the code :)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":278,"context_line":"         - ``check_write_image`` - Provides an interface to allow the storage"},{"line_number":279,"context_line":"           other components to ask the storage driver if the image should be"},{"line_number":280,"context_line":"           written to disk.  This allows all of the logic to be housed with"},{"line_number":281,"context_line":"           the storage driver."},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"  - Updating of the ``agent.AgentDeploy`` and ``iscsi_deploy.ISCSIDeploy``"},{"line_number":284,"context_line":"    driver logic to support skipping deployment of a node if a storage"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_d702fd3d","line":281,"in_reply_to":"da6895a0_4f181a1e","updated":"2016-10-28 13:28:57.000000000","message":"\\o/  Will move it.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"  - Updating of the ``agent.AgentDeploy`` and ``iscsi_deploy.ISCSIDeploy``"},{"line_number":284,"context_line":"    driver logic to support skipping deployment of a node if a storage"},{"line_number":285,"context_line":"    provider is enabled, volume information exists for the volume, and"},{"line_number":286,"context_line":"    the volume has an index of ``0`` indicating it is the boot volume."},{"line_number":287,"context_line":"    In essence, this means that if the node is defined to boot from a"},{"line_number":288,"context_line":"    remote volume, that the driver.deploy.deploy method should immediately"}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_c0268015","line":285,"updated":"2016-10-19 20:15:34.000000000","message":"what do you mean by \u0027enabled\u0027? Is there some flag that needs to be explicitly set? Oh, by your example below, looks like you mean if a storage-interface is specified.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"  - Updating of the ``agent.AgentDeploy`` and ``iscsi_deploy.ISCSIDeploy``"},{"line_number":284,"context_line":"    driver logic to support skipping deployment of a node if a storage"},{"line_number":285,"context_line":"    provider is enabled, volume information exists for the volume, and"},{"line_number":286,"context_line":"    the volume has an index of ``0`` indicating it is the boot volume."},{"line_number":287,"context_line":"    In essence, this means that if the node is defined to boot from a"},{"line_number":288,"context_line":"    remote volume, that the driver.deploy.deploy method should immediately"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_b7d669c3","line":285,"in_reply_to":"fa6399be_c0268015","updated":"2016-10-28 13:28:57.000000000","message":"Clarified.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    In essence, this means that if the node is defined to boot from a"},{"line_number":288,"context_line":"    remote volume, that the driver.deploy.deploy method should immediately"},{"line_number":289,"context_line":"    return DEPLOYDONE as any network booting configuration, if applicable,"},{"line_number":290,"context_line":"    would have be written out via driver.deploy.prepare method."},{"line_number":291,"context_line":"    Example:"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"     .. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_a0b7ccf3","line":290,"updated":"2016-10-19 20:15:34.000000000","message":"nit: s/be/to be/","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    In essence, this means that if the node is defined to boot from a"},{"line_number":288,"context_line":"    remote volume, that the driver.deploy.deploy method should immediately"},{"line_number":289,"context_line":"    return DEPLOYDONE as any network booting configuration, if applicable,"},{"line_number":290,"context_line":"    would have be written out via driver.deploy.prepare method."},{"line_number":291,"context_line":"    Example:"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"     .. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_d7775dd2","line":290,"in_reply_to":"fa6399be_a0b7ccf3","updated":"2016-10-28 13:28:57.000000000","message":"Done","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"         if (task.node.storage_interface is not None and"},{"line_number":296,"context_line":"                 not task.driver.storage.check_write_image(task)):"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"  - Updating of the ``pxe.PXEBoot`` driver logic to support the creation of"},{"line_number":299,"context_line":"    the appropriate iPXE configurations for booting from the various boot"},{"line_number":300,"context_line":"    scenarios if the ``volume_target`` information is defined, iPXE is"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_6fd31e39","line":297,"updated":"2016-10-22 14:56:23.000000000","message":"+1 (though I guess this is implied)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0c8cd7200ca1e544f6c58bd03ad2df7d3b8b1cbe","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"         if (task.node.storage_interface is not None and"},{"line_number":296,"context_line":"                 not task.driver.storage.check_write_image(task)):"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"  - Updating of the ``pxe.PXEBoot`` driver logic to support the creation of"},{"line_number":299,"context_line":"    the appropriate iPXE configurations for booting from the various boot"},{"line_number":300,"context_line":"    scenarios if the ``volume_target`` information is defined, iPXE is"}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_dfeabe73","line":297,"updated":"2016-10-21 13:19:04.000000000","message":"When writing code, we also need:\nUpdating of the agent.AgentDeply and iscsi_deploy.ISCSIDeploy driver logic to skip validating instance_info/image_source if the node is defined to boot from a remote volume as above because user image is already deployed to the volume, then image_source is unnecessary.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"         if (task.node.storage_interface is not None and"},{"line_number":296,"context_line":"                 not task.driver.storage.check_write_image(task)):"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"  - Updating of the ``pxe.PXEBoot`` driver logic to support the creation of"},{"line_number":299,"context_line":"    the appropriate iPXE configurations for booting from the various boot"},{"line_number":300,"context_line":"    scenarios if the ``volume_target`` information is defined, iPXE is"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_52a19ba8","line":297,"in_reply_to":"da6895a0_6fd31e39","updated":"2016-10-28 13:28:57.000000000","message":"Agreed, great reminder, thank you!  I\u0027ve added some additional text to hopefully remind us.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                 not task.driver.storage.check_write_image(task)):"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"  - Updating of the ``pxe.PXEBoot`` driver logic to support the creation of"},{"line_number":299,"context_line":"    the appropriate iPXE configurations for booting from the various boot"},{"line_number":300,"context_line":"    scenarios if the ``volume_target`` information is defined, iPXE is"},{"line_number":301,"context_line":"    enabled, and a storage provider is available."},{"line_number":302,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_8fd87255","line":299,"updated":"2016-10-22 14:56:23.000000000","message":"side note: there is a proposal to separate iPXE boot interface from PXE one. I suspect this spec could benefit from it.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                 not task.driver.storage.check_write_image(task)):"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"  - Updating of the ``pxe.PXEBoot`` driver logic to support the creation of"},{"line_number":299,"context_line":"    the appropriate iPXE configurations for booting from the various boot"},{"line_number":300,"context_line":"    scenarios if the ``volume_target`` information is defined, iPXE is"},{"line_number":301,"context_line":"    enabled, and a storage provider is available."},{"line_number":302,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_528fdb22","line":299,"in_reply_to":"da6895a0_8fd87255","updated":"2016-10-28 13:28:57.000000000","message":"It absolutely would.  Worthy of a revision later or possibly a pivot if that gets traction.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"  - Updating of the deploy driver to enable the logic added for scenarios 1-3"},{"line_number":342,"context_line":"    to be bypassed using a ``force_deployment`` parameter which should be"},{"line_number":343,"context_line":"    removed from the node\u0027s instance_info prior to the node reaching the"},{"line_number":344,"context_line":"    active state. This, in effect, would cause ironic to support a deployment"},{"line_number":345,"context_line":"    operation when the supplied volume information is normally expected to"},{"line_number":346,"context_line":"    have a valid Operating System and boot loader already in place."}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_afdd3644","line":343,"updated":"2016-10-22 14:56:23.000000000","message":"s/instance_info/driver_internal_info/ ? or should it really be provided by user and/or nova?","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"  - Updating of the deploy driver to enable the logic added for scenarios 1-3"},{"line_number":342,"context_line":"    to be bypassed using a ``force_deployment`` parameter which should be"},{"line_number":343,"context_line":"    removed from the node\u0027s instance_info prior to the node reaching the"},{"line_number":344,"context_line":"    active state. This, in effect, would cause ironic to support a deployment"},{"line_number":345,"context_line":"    operation when the supplied volume information is normally expected to"},{"line_number":346,"context_line":"    have a valid Operating System and boot loader already in place."}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_d2ca0b4f","line":343,"in_reply_to":"da6895a0_afdd3644","updated":"2016-10-28 13:28:57.000000000","message":"instance_info as provided by who or whatever is using the api.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    setting a WWN or volume serial number if avilable."},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"In order to support scenario 5:"},{"line_number":354,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"},{"line_number":355,"context_line":"    an alternative path in the iPXE template where the previously defined"},{"line_number":356,"context_line":"    settings cause the on-disk PXE booting template to boot the node from"},{"line_number":357,"context_line":"    the NFS root."}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_202bbc95","line":354,"updated":"2016-10-19 20:15:34.000000000","message":"I\u0027m not sure why it needs 3 but will find out in the code.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    setting a WWN or volume serial number if avilable."},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"In order to support scenario 5:"},{"line_number":354,"context_line":"  - Scenario 3 must be implemented.  This is anticipated to largely be"},{"line_number":355,"context_line":"    an alternative path in the iPXE template where the previously defined"},{"line_number":356,"context_line":"    settings cause the on-disk PXE booting template to boot the node from"},{"line_number":357,"context_line":"    the NFS root."}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_5260bb35","line":354,"in_reply_to":"fa6399be_202bbc95","updated":"2016-10-28 13:28:57.000000000","message":"I think it was because of template changes.  I don\u0027t remember offhand.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":360,"context_line":"  - Creation of logic to allow Ironic users to leverage the storage provider"},{"line_number":361,"context_line":"    to request a volume for their node.  Such functionality would require"},{"line_number":362,"context_line":"    ironic to deploy the OS image, and should be covered by a separate"},{"line_number":363,"context_line":"    specification."},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"Alternatives"},{"line_number":366,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_cfe26a03","line":363,"updated":"2016-10-22 14:56:23.000000000","message":"Not sure I understand how it\u0027s different from scenarios above..","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":360,"context_line":"  - Creation of logic to allow Ironic users to leverage the storage provider"},{"line_number":361,"context_line":"    to request a volume for their node.  Such functionality would require"},{"line_number":362,"context_line":"    ironic to deploy the OS image, and should be covered by a separate"},{"line_number":363,"context_line":"    specification."},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"Alternatives"},{"line_number":366,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_f26aaf19","line":363,"in_reply_to":"da6895a0_cfe26a03","updated":"2016-10-28 13:28:57.000000000","message":"Think IPA from a volume.  I suspect it should be removed.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":416,"context_line":"The first change is the introduction of a list of supported advanced driver"},{"line_number":417,"context_line":"features defined by the deploy and boot driver classes, known as capabilities,"},{"line_number":418,"context_line":"that allow for other driver components to become aware of what functionality"},{"line_number":419,"context_line":"is present in a neighboring driver interface/composition."},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"The second change is the introduction of a new `storage_interface` that will"},{"line_number":422,"context_line":"be mapped to a selectable storage driver of the available storage drivers."}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_db63d5db","line":419,"updated":"2016-10-19 20:15:34.000000000","message":"Are we sure that we want the capabilities to be a list of strings, vs a dictionary of key:value pairs?\n\nHow do the values of these capabilities get set? Are they hardcoded?\n\nAre they going to be available/exposed via an API so users can see what the capabilities are?","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":416,"context_line":"The first change is the introduction of a list of supported advanced driver"},{"line_number":417,"context_line":"features defined by the deploy and boot driver classes, known as capabilities,"},{"line_number":418,"context_line":"that allow for other driver components to become aware of what functionality"},{"line_number":419,"context_line":"is present in a neighboring driver interface/composition."},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"The second change is the introduction of a new `storage_interface` that will"},{"line_number":422,"context_line":"be mapped to a selectable storage driver of the available storage drivers."}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_e0d01a56","line":419,"in_reply_to":"fa6399be_db63d5db","updated":"2016-10-28 13:28:57.000000000","message":"I\u0027m honestly not sure.  I kind of just wanted to keep it super simple, and for some unreasonable reason using a dictionary doesn\u0027t feel like it makes sense to me.\n\nBased on the earlier notes, it would be a hardcoded list that we would update as-needed.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    \"\"\"Future method to add a volume based on instance config.\"\"\""},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def remove_volume(self, task):"},{"line_number":438,"context_line":"    \"\"\"Future method to remove a volume based on instance config.\"\"\""},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def validate(self, task):"},{"line_number":441,"context_line":"    \"\"\"Validate that the storage driver has appropriate configuration.\"\"\""}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_efe72e10","line":438,"updated":"2016-10-22 14:56:23.000000000","message":"see above re remong these","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    \"\"\"Future method to add a volume based on instance config.\"\"\""},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def remove_volume(self, task):"},{"line_number":438,"context_line":"    \"\"\"Future method to remove a volume based on instance config.\"\"\""},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def validate(self, task):"},{"line_number":441,"context_line":"    \"\"\"Validate that the storage driver has appropriate configuration.\"\"\""}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_60732a81","line":438,"in_reply_to":"da6895a0_efe72e10","updated":"2016-10-28 13:28:57.000000000","message":"Done","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    \"\"\"Validate that the storage driver has appropriate configuration.\"\"\""},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    def sort_path_preferences(self, task):"},{"line_number":444,"context_line":"    \"\"\"Future method to allow for path preference determination.\"\"\""},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def check_write_image(self, task):"},{"line_number":447,"context_line":"    \"\"\"Determines if deploy should perform the image write-out.\"\"\""}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_0fe54208","line":444,"updated":"2016-10-22 14:56:23.000000000","message":"and this","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    \"\"\"Validate that the storage driver has appropriate configuration.\"\"\""},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    def sort_path_preferences(self, task):"},{"line_number":444,"context_line":"    \"\"\"Future method to allow for path preference determination.\"\"\""},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def check_write_image(self, task):"},{"line_number":447,"context_line":"    \"\"\"Determines if deploy should perform the image write-out.\"\"\""}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_e02c9a4c","line":444,"in_reply_to":"da6895a0_0fe54208","updated":"2016-10-28 13:28:57.000000000","message":"Done","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def check_write_image(self, task):"},{"line_number":447,"context_line":"    \"\"\"Determines if deploy should perform the image write-out.\"\"\""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"Nova driver impact"},{"line_number":450,"context_line":"------------------"},{"line_number":451,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_5bd3455f","line":448,"updated":"2016-10-19 20:15:34.000000000","message":"What storage interfaces will be implemented as part of this spec? \u0027cinder\u0027? \u0027noop\u0027?\n\nI don\u0027t know if it falls in this spec or assumed due to the driver composition work, but what additional configs will be added? Is it similar to network ones? enabled_storage_interfaces, default_storage_interface?","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def check_write_image(self, task):"},{"line_number":447,"context_line":"    \"\"\"Determines if deploy should perform the image write-out.\"\"\""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"Nova driver impact"},{"line_number":450,"context_line":"------------------"},{"line_number":451,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_40af0694","line":448,"in_reply_to":"fa6399be_5bd3455f","updated":"2016-10-28 13:28:57.000000000","message":"cinder, and noop, but given the other references for alignment with driver composition.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":462,"context_line":"as part of"},{"line_number":463,"context_line":"`Scenario 4 - Boot via Host Bus Adapter (HBA) to volume with image deployment`_"},{"line_number":464,"context_line":", the IPA ramdisk should likely have functionality added in the form of a"},{"line_number":465,"context_line":"HardwareManager in order to support Mutli-Path IO.  That being said MPIO"},{"line_number":466,"context_line":"is out of scope for this specification."},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_2ff206d3","line":465,"updated":"2016-10-22 14:56:23.000000000","message":"typo in Multi. Also, it\u0027s not a hard requirement, right?","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":462,"context_line":"as part of"},{"line_number":463,"context_line":"`Scenario 4 - Boot via Host Bus Adapter (HBA) to volume with image deployment`_"},{"line_number":464,"context_line":", the IPA ramdisk should likely have functionality added in the form of a"},{"line_number":465,"context_line":"HardwareManager in order to support Mutli-Path IO.  That being said MPIO"},{"line_number":466,"context_line":"is out of scope for this specification."},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_60f96a80","line":465,"in_reply_to":"da6895a0_2ff206d3","updated":"2016-10-28 13:28:57.000000000","message":"No, not a hard requirement.  It is just a contextual note.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":494,"context_line":"Scalability impact"},{"line_number":495,"context_line":"------------------"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"This feature, while it is a feature that would be opted into use by"},{"line_number":498,"context_line":"an operator.  In the case where it is enabled, additional calls to"},{"line_number":499,"context_line":"the backend storage interface may have a performance impact depending"},{"line_number":500,"context_line":"upon architecture of the deployment."}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_7b0f29e1","line":497,"updated":"2016-10-19 20:15:34.000000000","message":"maybe \u0027This is a feature that would be ..\u0027 ? (I\u0027m not quite sure what you had in mind.)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":494,"context_line":"Scalability impact"},{"line_number":495,"context_line":"------------------"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"This feature, while it is a feature that would be opted into use by"},{"line_number":498,"context_line":"an operator.  In the case where it is enabled, additional calls to"},{"line_number":499,"context_line":"the backend storage interface may have a performance impact depending"},{"line_number":500,"context_line":"upon architecture of the deployment."}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_20e93281","line":497,"in_reply_to":"fa6399be_7b0f29e1","updated":"2016-10-28 13:28:57.000000000","message":"Done","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":495,"context_line":"------------------"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"This feature, while it is a feature that would be opted into use by"},{"line_number":498,"context_line":"an operator.  In the case where it is enabled, additional calls to"},{"line_number":499,"context_line":"the backend storage interface may have a performance impact depending"},{"line_number":500,"context_line":"upon architecture of the deployment."},{"line_number":501,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_1bff0dab","line":498,"updated":"2016-10-19 20:15:34.000000000","message":"I\u0027d prefer we didn\u0027t use \u0027enabled\u0027, since we don\u0027t add any flag that explicitly enables/disables it.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":495,"context_line":"------------------"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"This feature, while it is a feature that would be opted into use by"},{"line_number":498,"context_line":"an operator.  In the case where it is enabled, additional calls to"},{"line_number":499,"context_line":"the backend storage interface may have a performance impact depending"},{"line_number":500,"context_line":"upon architecture of the deployment."},{"line_number":501,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_e031fa0c","line":498,"in_reply_to":"fa6399be_1bff0dab","updated":"2016-10-28 13:28:57.000000000","message":"Done","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":512,"context_line":"---------------------"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"Deployers wishing to use these drivers will naturally need to add these"},{"line_number":515,"context_line":"drivers to the available list."},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"A default storage configuration driver will be set to ``None`` which will"},{"line_number":518,"context_line":"prevent any storage related code from being invoked until the operator"}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_bbe70111","line":515,"updated":"2016-10-19 20:15:34.000000000","message":"is this list, the config option I mentioned above?","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":512,"context_line":"---------------------"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"Deployers wishing to use these drivers will naturally need to add these"},{"line_number":515,"context_line":"drivers to the available list."},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"A default storage configuration driver will be set to ``None`` which will"},{"line_number":518,"context_line":"prevent any storage related code from being invoked until the operator"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_236f7cc6","line":515,"in_reply_to":"fa6399be_bbe70111","updated":"2016-10-28 13:28:57.000000000","message":"Yes, revised to be a little more clear.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"62b1953a5c211ebe6d187eeb956c5414e3c44436","unresolved":false,"context_lines":[{"line_number":526,"context_line":"  enabled_storage_interfaces \u003d \u003cNone\u003e # Defaults to none and is a list of the"},{"line_number":527,"context_line":"  available drivers."},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"  [cinder]"},{"line_number":530,"context_line":"  url \u003d http://api.address:port"},{"line_number":531,"context_line":"  url_timeout \u003d 30"},{"line_number":532,"context_line":"  retries \u003d 3"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_40429b11","line":529,"updated":"2016-10-24 09:48:37.000000000","message":"MIght be worth adding cinder auth parameters too here, as it is done nowadays with other services.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":526,"context_line":"  enabled_storage_interfaces \u003d \u003cNone\u003e # Defaults to none and is a list of the"},{"line_number":527,"context_line":"  available drivers."},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"  [cinder]"},{"line_number":530,"context_line":"  url \u003d http://api.address:port"},{"line_number":531,"context_line":"  url_timeout \u003d 30"},{"line_number":532,"context_line":"  retries \u003d 3"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_4380f046","line":529,"in_reply_to":"da6895a0_40429b11","updated":"2016-10-28 13:28:57.000000000","message":"I\u0027ll revise it if necessary after we land this spec based upon the code.  I think the authtoken data would be utilized.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":538,"context_line":""},{"line_number":539,"context_line":"This will increase the overall complexity and set of capabilities that"},{"line_number":540,"context_line":"ironic offers. Driver developers wishing to implement driver specific"},{"line_number":541,"context_line":"functionality should expect certian substrate operations to occur,"},{"line_number":542,"context_line":"and attempt to leverage the substrate set forth in this specification and"},{"line_number":543,"context_line":"the `Add volume connection information for Ironic nodes`_ specification."},{"line_number":544,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_3ba131aa","line":541,"updated":"2016-10-19 20:15:34.000000000","message":"s/certian/certain/","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":566,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"Logic will need to be implemented in IPA to handle the scenario when no disks"},{"line_number":569,"context_line":"are detected. ``cleaning`` and ``discovery`` operations should be able to be"},{"line_number":570,"context_line":"executed upon hardware nodes that have no local disk storage."},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"Additionally in IPA, as a soft dependency, logic MAY be required to better"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_4fef3ae8","line":569,"updated":"2016-10-22 14:56:23.000000000","message":"s/discovery/introspection/? I really wonder how exactly it will look. Right now our customers expect introspection to return the local_gb of the attached disk. This does work with iBFT (well, sometimes), but I guess won\u0027t work here, right?\n\nI wonder how we modify inspection process and presenting nodes to Nova in this case (i.e. what to put as local_gb and who populates it).","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":566,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"Logic will need to be implemented in IPA to handle the scenario when no disks"},{"line_number":569,"context_line":"are detected. ``cleaning`` and ``discovery`` operations should be able to be"},{"line_number":570,"context_line":"executed upon hardware nodes that have no local disk storage."},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"Additionally in IPA, as a soft dependency, logic MAY be required to better"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_432ab02d","line":569,"in_reply_to":"da6895a0_4fef3ae8","updated":"2016-10-28 13:28:57.000000000","message":"I\u0027ll fix it to inspection.  I  honestly haven\u0027t spent any cycles thinking about this.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":573,"context_line":"handle directly attached volume selection when multipathing is present."},{"line_number":574,"context_line":"This will require its own specification or well-defined and validated plan"},{"line_number":575,"context_line":"as IPA cannot expect OS multipathing support to handle MPIO scenarios in all"},{"line_number":576,"context_line":"cases, or to even be present."},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Implementation of `Add volume connection information for Ironic nodes`_."},{"line_number":579,"context_line":"This specification should not be entirely dependent upon the implementation"}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_7b99e96d","line":576,"updated":"2016-10-19 20:15:34.000000000","message":"I thought we weren\u0027t going to handle MPIO in this spec.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":573,"context_line":"handle directly attached volume selection when multipathing is present."},{"line_number":574,"context_line":"This will require its own specification or well-defined and validated plan"},{"line_number":575,"context_line":"as IPA cannot expect OS multipathing support to handle MPIO scenarios in all"},{"line_number":576,"context_line":"cases, or to even be present."},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Implementation of `Add volume connection information for Ironic nodes`_."},{"line_number":579,"context_line":"This specification should not be entirely dependent upon the implementation"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_a3f38c9d","line":576,"in_reply_to":"fa6399be_7b99e96d","updated":"2016-10-28 13:28:57.000000000","message":"Informational context with \u0027may\u0027.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":583,"context_line":"that these two efforts are anticipated to be worked in parallel, and this"},{"line_number":584,"context_line":"implementation effort should appropriately incorporate functionality as the"},{"line_number":585,"context_line":"functionality for the `Driver composition reform specification`_ begins to"},{"line_number":586,"context_line":"become available."},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"Testing"},{"line_number":589,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_6fba3ee3","line":586,"updated":"2016-10-22 14:56:23.000000000","message":"+1","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":591,"context_line":"The level of full stack functional and integration tests is a topic that"},{"line_number":592,"context_line":"requires further discussion in the ironic community. An initial case for a"},{"line_number":593,"context_line":"gate test could be where an ironic deployment boots from a Cinder volume,"},{"line_number":594,"context_line":"which a tempest test could orchestrate."},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"Scenarios 3 and 4 are the most difficult to test as they have detached"},{"line_number":597,"context_line":"infrastucture expectations outside of our direct control. However, we may"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_8fbf92cf","line":594,"updated":"2016-10-22 14:56:23.000000000","message":"+1, seems like a good start","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb96bfdd2e62d6057c558df406f1af3a786fd69a","unresolved":false,"context_lines":[{"line_number":596,"context_line":"Scenarios 3 and 4 are the most difficult to test as they have detached"},{"line_number":597,"context_line":"infrastucture expectations outside of our direct control. However, we may"},{"line_number":598,"context_line":"find that the base overlay is sufficient to test with unit tests due to"},{"line_number":599,"context_line":"what will ultimately be significant underlying common paths."},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":602,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_afb456f2","line":599,"updated":"2016-10-22 14:56:23.000000000","message":"I guess we can talk to 3rdparty CI owners about some coverage..","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":596,"context_line":"Scenarios 3 and 4 are the most difficult to test as they have detached"},{"line_number":597,"context_line":"infrastucture expectations outside of our direct control. However, we may"},{"line_number":598,"context_line":"find that the base overlay is sufficient to test with unit tests due to"},{"line_number":599,"context_line":"what will ultimately be significant underlying common paths."},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":602,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_a34f0cbc","line":599,"in_reply_to":"da6895a0_afb456f2","updated":"2016-10-28 13:28:57.000000000","message":"Possibly.  I suspect we might be able to simulate some of this as well.","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5389526165c2c6b50e7abca094dad0c7cba9f391","unresolved":false,"context_lines":[{"line_number":627,"context_line":"References"},{"line_number":628,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"Relavent specifications:"},{"line_number":631,"context_line":"  - `Add volume connection information for Ironic nodes`_"},{"line_number":632,"context_line":"  - `Nova Specs - Ironic - Boot from Cinder volume`_"},{"line_number":633,"context_line":"Mitaka midcycle etherpad:"}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa6399be_e0bf04fa","line":630,"updated":"2016-10-19 20:15:34.000000000","message":"s/Relavent/Relevant/ :)","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"789b7e4acc56a63aa7cf9c8f4d4e7594954d1222","unresolved":false,"context_lines":[{"line_number":635,"context_line":""},{"line_number":636,"context_line":".. _`IPXE sanhook command`: http://ipxe.org/cmd/sanhook"},{"line_number":637,"context_line":".. _`IPXE san connection URLs`: http://ipxe.org/sanuri"},{"line_number":638,"context_line":".. _`Driver composition reform specification`: https://review.openstack.org/#/c/188370/"},{"line_number":639,"context_line":".. _`Add network interface to base driver class`: https://review.openstack.org/#/c/285852/"},{"line_number":640,"context_line":".. _`Add volume connection information for Ironic nodes`: https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/volume-connection-information.html"},{"line_number":641,"context_line":".. _`Nova Specs - Ironic - Boot from Cinder volume`: https://review.openstack.org/#/c/311696/"}],"source_content_type":"text/x-rst","patch_set":24,"id":"da6895a0_7ca7954f","line":638,"updated":"2016-10-20 19:06:06.000000000","message":"nit: this spec is already merged if you do another patchset please update link to:https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/driver-composition-reform.html","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194195de748674768a5525def8f0459aa527555b","unresolved":false,"context_lines":[{"line_number":635,"context_line":""},{"line_number":636,"context_line":".. _`IPXE sanhook command`: http://ipxe.org/cmd/sanhook"},{"line_number":637,"context_line":".. _`IPXE san connection URLs`: http://ipxe.org/sanuri"},{"line_number":638,"context_line":".. _`Driver composition reform specification`: https://review.openstack.org/#/c/188370/"},{"line_number":639,"context_line":".. _`Add network interface to base driver class`: https://review.openstack.org/#/c/285852/"},{"line_number":640,"context_line":".. _`Add volume connection information for Ironic nodes`: https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/volume-connection-information.html"},{"line_number":641,"context_line":".. _`Nova Specs - Ironic - Boot from Cinder volume`: https://review.openstack.org/#/c/311696/"}],"source_content_type":"text/x-rst","patch_set":24,"id":"ba5da102_63dc14e5","line":638,"in_reply_to":"da6895a0_7ca7954f","updated":"2016-10-28 13:28:57.000000000","message":"Done","commit_id":"d30c7e738858632b745a7de8ecfa3b97df693ced"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1a8bb6b7af23e47c19088817ad30e44f18fcaab7","unresolved":false,"context_lines":[{"line_number":541,"context_line":""},{"line_number":542,"context_line":"Other contributors:"},{"line_number":543,"context_line":"  blakec"},{"line_number":544,"context_line":"  shiina-hironori"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"Work Items"},{"line_number":547,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":26,"id":"ba5da102_31d7b724","line":544,"updated":"2016-10-28 20:48:36.000000000","message":"nit: The above two lines rendered as one line.","commit_id":"cd17651481f1a52c665c7cce2a7e25f658b6b8b1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1a8bb6b7af23e47c19088817ad30e44f18fcaab7","unresolved":false,"context_lines":[{"line_number":577,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"The level of full stack functional and integration tests is a topic that"},{"line_number":580,"context_line":"requires further discussion in the ironic community. An initial case for a"},{"line_number":581,"context_line":"gate test could be where an ironic deployment boots from a Cinder volume,"},{"line_number":582,"context_line":"which a tempest test could orchestrate."},{"line_number":583,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"ba5da102_71e12ffe","line":580,"updated":"2016-10-28 20:48:36.000000000","message":"Did we talk about this at the summit today? I can\u0027t remember. (Anyway, we can update this later; I\u0027m sure we\u0027ll \u0027do the right thing\u0027.)","commit_id":"cd17651481f1a52c665c7cce2a7e25f658b6b8b1"}]}
