)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1b57f38ef4fc464b52623ec6020c8c2a87cbf571","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Akira Yoshiyama \u003cakirayoshiyama@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-17 13:34:04 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nova-compatible-console-logging.rst to not-implemented"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds nova-compatible-console-logging spec to the list of approved"},{"line_number":10,"context_line":"and not-implemented. It is based on ironic-console-server."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_70afc92b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":58},"updated":"2016-04-21 15:19:18.000000000","message":"The subject of the commit seems to be a little confusing at first glance, perhaps \"Add nova compatible console logging\" ?","commit_id":"e01ac154a69bdb401692e525f6b13af367ae9493"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"49356d73fb922f36b38b7ff6a9c409ab359110cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Akira Yoshiyama \u003cakirayoshiyama@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-17 13:34:04 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nova-compatible-console-logging.rst to not-implemented"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds nova-compatible-console-logging spec to the list of approved"},{"line_number":10,"context_line":"and not-implemented. It is based on ironic-console-server."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_16675126","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":58},"in_reply_to":"1a122d0e_70afc92b","updated":"2016-04-22 08:08:30.000000000","message":"Yes, it should be fixed","commit_id":"e01ac154a69bdb401692e525f6b13af367ae9493"}],"specs/approved/nova-compatible-console-logging.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1b57f38ef4fc464b52623ec6020c8c2a87cbf571","unresolved":false,"context_lines":[{"line_number":36,"context_line":"(``ironic.drivers.base.ConsoleInterface`` needs to add the methods)"},{"line_number":37,"context_line":"And we need to apply them to pre-existing node drivers."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Then, ``ironic-conductor`` needs additional REST APIs and RPC APIs to"},{"line_number":40,"context_line":"get/clean the content of a log file."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In addition, ``ironic-console-server`` has serial console capability."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_0b2468ad","line":39,"range":{"start_line":39,"start_character":15,"end_line":39,"end_character":24},"updated":"2016-04-21 15:19:18.000000000","message":"I think you just mean ``ironic`` since realistically, as designed, it would be ironic-api and ironic-conductor that would need to be updated.","commit_id":"e01ac154a69bdb401692e525f6b13af367ae9493"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"49356d73fb922f36b38b7ff6a9c409ab359110cd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"(``ironic.drivers.base.ConsoleInterface`` needs to add the methods)"},{"line_number":37,"context_line":"And we need to apply them to pre-existing node drivers."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Then, ``ironic-conductor`` needs additional REST APIs and RPC APIs to"},{"line_number":40,"context_line":"get/clean the content of a log file."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In addition, ``ironic-console-server`` has serial console capability."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_96d7e1be","line":39,"range":{"start_line":39,"start_character":15,"end_line":39,"end_character":24},"in_reply_to":"1a122d0e_0b2468ad","updated":"2016-04-22 08:08:30.000000000","message":"+1","commit_id":"e01ac154a69bdb401692e525f6b13af367ae9493"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"d3071236e38ababe159730cdb3f7cb6cc3b0439b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526368"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This implements console drivers using \"ironic-console-server\" which"},{"line_number":15,"context_line":"provides nova-compatible console logging capability."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_164bde5a","line":15,"updated":"2016-05-12 17:15:20.000000000","message":"Nit: \"provides a\"","commit_id":"6bc0d80d20c1afa9fda67661e4f0a1c1bfab7686"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"d3071236e38ababe159730cdb3f7cb6cc3b0439b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Currently Ironic doesn\u0027t have console logging capability. Console logs"},{"line_number":22,"context_line":"are very useful to investigate the cause of problem on OS booting."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_76722aaf","line":22,"updated":"2016-05-12 17:15:20.000000000","message":"Nit: \"problems\"","commit_id":"6bc0d80d20c1afa9fda67661e4f0a1c1bfab7686"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"d3071236e38ababe159730cdb3f7cb6cc3b0439b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"logging and serial console connection. ``ironic-conductor`` runs it if"},{"line_number":30,"context_line":"a node was deployed or turned on, and terminates it if a node was"},{"line_number":31,"context_line":"released or turned off. It runs a command specified in option \u0027-c\u0027,"},{"line_number":32,"context_line":"and saves the output into a log file specified in option \u0027-f\u0027."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"To use it, we will add new console drivers like"},{"line_number":35,"context_line":"``ipmitool.IPMIIcsConsole`` It has methods for console logging."}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_161abe17","line":32,"updated":"2016-05-12 17:15:20.000000000","message":"If ironic-console-server just runs a command and pipes its output to a file, why do we need it at all? We can make ironic-conductor run the command and redirect its output by itself.","commit_id":"6bc0d80d20c1afa9fda67661e4f0a1c1bfab7686"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"53b5801097aa58130abf6a83682cfbf1f5d6c089","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"ironicclient.v1.node.NodeManager will be added 2 methods to get/clear"},{"line_number":93,"context_line":"the content of a console log for a node. To use them, ironic command"},{"line_number":94,"context_line":"will be added 2 sub-commands below:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* ironic node-get-console-log \u003cnode_ident\u003e"},{"line_number":97,"context_line":"* ironic node-clear-console-log \u003cnode_ident\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_3b787ef8","line":94,"updated":"2016-05-12 21:52:04.000000000","message":"\"the two subcommands below will be added to the ironic command\"","commit_id":"6bc0d80d20c1afa9fda67661e4f0a1c1bfab7686"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"53b5801097aa58130abf6a83682cfbf1f5d6c089","unresolved":false,"context_lines":[{"line_number":102,"context_line":"RPC API impact"},{"line_number":103,"context_line":"--------------"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"2 methods will be added below:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* get_console_log(self, context, node_id, topic\u003dNone):"},{"line_number":108,"context_line":"  Gets the content of a console log of a node."}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_5b8742d7","line":105,"updated":"2016-05-12 21:52:04.000000000","message":"\"The two methods below will be added\"","commit_id":"6bc0d80d20c1afa9fda67661e4f0a1c1bfab7686"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"d3071236e38ababe159730cdb3f7cb6cc3b0439b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Driver API impact"},{"line_number":117,"context_line":"-----------------"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"ironic.drivers.base.ConsoleInterface will be added 4 methods below:"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"* start_console_log(self, task)"},{"line_number":122,"context_line":"  Starts console logging of a node."}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_76ceaab5","line":119,"updated":"2016-05-12 17:15:20.000000000","message":"Nit: \"The following four methods will be added to ironic.drivers.base.ConsoleInterface:\"","commit_id":"6bc0d80d20c1afa9fda67661e4f0a1c1bfab7686"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"d3071236e38ababe159730cdb3f7cb6cc3b0439b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  Clears the content of a console log of a node."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"They will be non-abstract methods (just \u0027pass\u0027), so pre-existing"},{"line_number":131,"context_line":"methods doesn\u0027t need to implement them. See `WIP: driver base: add"},{"line_number":132,"context_line":"methods for ConsoleInterface`_ for details."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_b66e5294","line":131,"updated":"2016-05-12 17:15:20.000000000","message":"\"methods\" -\u003e \"classes\", I think.\nNit: \"doesn\u0027t\" -\u003e \"don\u0027t\"","commit_id":"6bc0d80d20c1afa9fda67661e4f0a1c1bfab7686"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"d3071236e38ababe159730cdb3f7cb6cc3b0439b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"get_console_output() will be implemented in ironic driver of Nova. It"},{"line_number":139,"context_line":"returns a string, as same as"},{"line_number":140,"context_line":"nova.virt.libvirt.driver.LibvirtDriver.get_console_output(). No other"},{"line_number":141,"context_line":"impact for nova, and horizon can use it."},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_960eaee3","line":139,"updated":"2016-05-12 17:15:20.000000000","message":"Nit: \"the same as\"","commit_id":"6bc0d80d20c1afa9fda67661e4f0a1c1bfab7686"}]}