)]}'
{"specs/approved/interface-attach-detach-api.rst":[{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"94241410acf2e323943fecf27ffeddd5e4c706fc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"using their extra field, doing the mapping this way may not work for a third"},{"line_number":24,"context_line":"party network interface implementation. This also ties the ironic nova virt"},{"line_number":25,"context_line":"driver to a particular network interface mapping implementation. If a third"},{"line_number":26,"context_line":"party network interface wants to do something different with the ironic ports"},{"line_number":27,"context_line":"or we as the Ironic team want to change an implementation detail we have to"},{"line_number":28,"context_line":"summit changes into nova."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_d7031db7","line":26,"range":{"start_line":26,"start_character":14,"end_line":26,"end_character":23},"updated":"2016-06-06 05:50:08.000000000","message":"We need to add a mechanism here for the third party interface to show the user what has been done in its response..","commit_id":"c7bb44bffea0cf2da1c383ee9cf7fa66e07912f1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4812eb86759071ddea3a3f6046e0a42f20c33dcc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"using their extra field, doing the mapping this way may not work for a third"},{"line_number":24,"context_line":"party network interface implementation. This also ties the ironic nova virt"},{"line_number":25,"context_line":"driver to a particular network interface mapping implementation. If a third"},{"line_number":26,"context_line":"party network interface wants to do something different with the ironic ports"},{"line_number":27,"context_line":"or we as the Ironic team want to change an implementation detail we have to"},{"line_number":28,"context_line":"summit changes into nova."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_4c7e77e5","line":26,"range":{"start_line":26,"start_character":14,"end_line":26,"end_character":23},"in_reply_to":"7aa08908_d7031db7","updated":"2016-06-06 10:17:18.000000000","message":"The point of this spec is to allow the underlying implementation of attaching/detaching an interface to an Ironic node to be abstracted so it can be different per network driver implementation. From the users perspective all they should need to know is that the attach/detach was successful or not successful, which is accomplished through the API with different responses. There is no standard on what the different driver implementations might do, so I opted for an empty response body, as that is the only way to provide a consistent API.","commit_id":"c7bb44bffea0cf2da1c383ee9cf7fa66e07912f1"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"94241410acf2e323943fecf27ffeddd5e4c706fc","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    + 404, Node not found"},{"line_number":88,"context_line":"    + 400/422, The request was good but unable to attach the interface for a"},{"line_number":89,"context_line":"      defined reason"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  - Expected data is a JSON::"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_3781c14b","line":89,"range":{"start_line":89,"start_character":14,"end_line":89,"end_character":20},"updated":"2016-06-06 05:50:08.000000000","message":"Can you specify the reasons here.. one reason I can think of is if the interface driver required is not loaded in ironic.","commit_id":"c7bb44bffea0cf2da1c383ee9cf7fa66e07912f1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4812eb86759071ddea3a3f6046e0a42f20c33dcc","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    + 404, Node not found"},{"line_number":88,"context_line":"    + 400/422, The request was good but unable to attach the interface for a"},{"line_number":89,"context_line":"      defined reason"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  - Expected data is a JSON::"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_8cb5ffce","line":89,"range":{"start_line":89,"start_character":14,"end_line":89,"end_character":20},"in_reply_to":"7aa08908_3781c14b","updated":"2016-06-06 10:17:18.000000000","message":"The reasons here can be different per driver implementation, for example, \"Can not attach, no free Ironic port\"\n\nIf there is an error like the one you\u0027ve described I\u0027d expect a 5XX error.","commit_id":"c7bb44bffea0cf2da1c383ee9cf7fa66e07912f1"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"94241410acf2e323943fecf27ffeddd5e4c706fc","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"      {"},{"line_number":94,"context_line":"          \"title\": \"Attachment\","},{"line_number":95,"context_line":"          \"type\": \"object\","},{"line_number":96,"context_line":"          \"properties\": {"},{"line_number":97,"context_line":"              \"interface_id\": {"},{"line_number":98,"context_line":"                  \"description\": \"ID of interface to attach\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_d734bddf","line":95,"range":{"start_line":95,"start_character":19,"end_line":95,"end_character":25},"updated":"2016-06-06 05:50:08.000000000","message":"is this a python \"object\" ? What should the request be for sending in the neutron port id.","commit_id":"c7bb44bffea0cf2da1c383ee9cf7fa66e07912f1"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"671e8de762081b3a90944488d9e1819b1bac556f","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"      {"},{"line_number":94,"context_line":"          \"title\": \"Attachment\","},{"line_number":95,"context_line":"          \"type\": \"object\","},{"line_number":96,"context_line":"          \"properties\": {"},{"line_number":97,"context_line":"              \"interface_id\": {"},{"line_number":98,"context_line":"                  \"description\": \"ID of interface to attach\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_6fedf0ee","line":95,"range":{"start_line":95,"start_character":19,"end_line":95,"end_character":25},"in_reply_to":"7aa08908_4ca677c2","updated":"2016-06-07 05:20:56.000000000","message":"An example would be good.","commit_id":"c7bb44bffea0cf2da1c383ee9cf7fa66e07912f1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"97993d5cab3cff4997b233bf2695f1c9073257bc","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"      {"},{"line_number":94,"context_line":"          \"title\": \"Attachment\","},{"line_number":95,"context_line":"          \"type\": \"object\","},{"line_number":96,"context_line":"          \"properties\": {"},{"line_number":97,"context_line":"              \"interface_id\": {"},{"line_number":98,"context_line":"                  \"description\": \"ID of interface to attach\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_b483a103","line":95,"range":{"start_line":95,"start_character":19,"end_line":95,"end_character":25},"in_reply_to":"7aa08908_6fedf0ee","updated":"2016-06-07 09:45:31.000000000","message":"Done","commit_id":"c7bb44bffea0cf2da1c383ee9cf7fa66e07912f1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4812eb86759071ddea3a3f6046e0a42f20c33dcc","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"      {"},{"line_number":94,"context_line":"          \"title\": \"Attachment\","},{"line_number":95,"context_line":"          \"type\": \"object\","},{"line_number":96,"context_line":"          \"properties\": {"},{"line_number":97,"context_line":"              \"interface_id\": {"},{"line_number":98,"context_line":"                  \"description\": \"ID of interface to attach\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_4ca677c2","line":95,"range":{"start_line":95,"start_character":19,"end_line":95,"end_character":25},"in_reply_to":"7aa08908_d734bddf","updated":"2016-06-06 10:17:18.000000000","message":"Part of our spec template is defining the APIs using http://json-schema.org/ that is what is used here.","commit_id":"c7bb44bffea0cf2da1c383ee9cf7fa66e07912f1"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"94241410acf2e323943fecf27ffeddd5e4c706fc","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    + 404, Node not found"},{"line_number":116,"context_line":"    + 400/422, The request was good but unable to detach the interface for a"},{"line_number":117,"context_line":"      defined reason"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  - Expected data is as above."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_779349a4","line":117,"range":{"start_line":117,"start_character":14,"end_line":117,"end_character":20},"updated":"2016-06-06 05:50:08.000000000","message":"same as line 89","commit_id":"c7bb44bffea0cf2da1c383ee9cf7fa66e07912f1"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"0dcb9e288bdb26548acd790401a5975639fffb1a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"driver to a particular network interface mapping implementation. If a third"},{"line_number":26,"context_line":"party network interface wants to do something different with the ironic ports"},{"line_number":27,"context_line":"or we as the Ironic team want to change an implementation detail we have to"},{"line_number":28,"context_line":"summit changes into nova."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_126b61f2","line":28,"updated":"2016-07-06 16:26:42.000000000","message":"Typo: \"submit\"","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"35f617ac463a8b061ac9330a05d257d87b5fa488","unresolved":false,"context_lines":[{"line_number":25,"context_line":"driver to a particular network interface mapping implementation. If a third"},{"line_number":26,"context_line":"party network interface wants to do something different with the ironic ports"},{"line_number":27,"context_line":"or we as the Ironic team want to change an implementation detail we have to"},{"line_number":28,"context_line":"summit changes into nova."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_ae0be07b","line":28,"in_reply_to":"1aa78d24_126b61f2","updated":"2016-07-07 10:13:57.000000000","message":"Done","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"0dcb9e288bdb26548acd790401a5975639fffb1a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"To solve this problem I propose to add 2 two new API endpoints interface-attach"},{"line_number":34,"context_line":"and interface-detach:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface-attach"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_7253c539","line":33,"updated":"2016-07-06 16:26:42.000000000","message":"Add a comma after \"endpoints\"","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"35f617ac463a8b061ac9330a05d257d87b5fa488","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"To solve this problem I propose to add 2 two new API endpoints interface-attach"},{"line_number":34,"context_line":"and interface-detach:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface-attach"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_ee70480d","line":33,"in_reply_to":"1aa78d24_7253c539","updated":"2016-07-07 10:13:57.000000000","message":"Done","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"0dcb9e288bdb26548acd790401a5975639fffb1a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface-attach"},{"line_number":37,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface-detach"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"These API end points will take via a POST body, a JSON representation of a"},{"line_number":40,"context_line":"generic VIF object. Making it generic allows for non-neutron based"},{"line_number":41,"context_line":"implementations to use this API. This VIF object will be passed to new"},{"line_number":42,"context_line":"functions in the pluggable network interfaces:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_b237edfd","line":39,"updated":"2016-07-06 16:26:42.000000000","message":"\"endpoints\"","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"35f617ac463a8b061ac9330a05d257d87b5fa488","unresolved":false,"context_lines":[{"line_number":36,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface-attach"},{"line_number":37,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface-detach"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"These API end points will take via a POST body, a JSON representation of a"},{"line_number":40,"context_line":"generic VIF object. Making it generic allows for non-neutron based"},{"line_number":41,"context_line":"implementations to use this API. This VIF object will be passed to new"},{"line_number":42,"context_line":"functions in the pluggable network interfaces:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_8e8544d0","line":39,"in_reply_to":"1aa78d24_b237edfd","updated":"2016-07-07 10:13:57.000000000","message":"Done","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"0dcb9e288bdb26548acd790401a5975639fffb1a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ..."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The network interface can use these functions to handle attaching the vif to"},{"line_number":51,"context_line":"the Ironic node in which ever way it needs to for its implementation, this"},{"line_number":52,"context_line":"may be adding a field to the Ironic port as with the existing implementation,"},{"line_number":53,"context_line":"or it might be different."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_ad05d011","line":51,"updated":"2016-07-06 16:26:42.000000000","message":"\"whichever\"\n\"implementation, this\" -\u003e \"implementation. This\"","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"35f617ac463a8b061ac9330a05d257d87b5fa488","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ..."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The network interface can use these functions to handle attaching the vif to"},{"line_number":51,"context_line":"the Ironic node in which ever way it needs to for its implementation, this"},{"line_number":52,"context_line":"may be adding a field to the Ironic port as with the existing implementation,"},{"line_number":53,"context_line":"or it might be different."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_2e4ed0c0","line":51,"in_reply_to":"1aa78d24_ad05d011","updated":"2016-07-07 10:13:57.000000000","message":"Done","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"0dcb9e288bdb26548acd790401a5975639fffb1a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Continue to use a port update to allow nova to interact with ironic ports and"},{"line_number":63,"context_line":"  soon to be portgroups, documenting the vif_port_id etc logic as a defined API"},{"line_number":64,"context_line":"  for the network interfaces to use."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_cd4e5c6e","line":63,"updated":"2016-07-06 16:26:42.000000000","message":"\"to be \" -\u003e \"\"","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"35f617ac463a8b061ac9330a05d257d87b5fa488","unresolved":false,"context_lines":[{"line_number":60,"context_line":"------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Continue to use a port update to allow nova to interact with ironic ports and"},{"line_number":63,"context_line":"  soon to be portgroups, documenting the vif_port_id etc logic as a defined API"},{"line_number":64,"context_line":"  for the network interfaces to use."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_4e699cf8","line":63,"in_reply_to":"1aa78d24_cd4e5c6e","updated":"2016-07-07 10:13:57.000000000","message":"Done","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"0dcb9e288bdb26548acd790401a5975639fffb1a","unresolved":false,"context_lines":[{"line_number":240,"context_line":"port update. A deprecation message should be issued on a port update if a user"},{"line_number":241,"context_line":"is directly setting vif_port_id on a port or portgroup."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"New nova virt driver should continue to work with an old Ironic API using API"},{"line_number":244,"context_line":"discovery and if the new API is available use it and if it isn\u0027t do it the port"},{"line_number":245,"context_line":"update way, for one cycle."},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_edccf8bc","line":243,"updated":"2016-07-06 16:26:42.000000000","message":"\"driver\" -\u003e \"drivers\"","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"35f617ac463a8b061ac9330a05d257d87b5fa488","unresolved":false,"context_lines":[{"line_number":240,"context_line":"port update. A deprecation message should be issued on a port update if a user"},{"line_number":241,"context_line":"is directly setting vif_port_id on a port or portgroup."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"New nova virt driver should continue to work with an old Ironic API using API"},{"line_number":244,"context_line":"discovery and if the new API is available use it and if it isn\u0027t do it the port"},{"line_number":245,"context_line":"update way, for one cycle."},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_315591c5","line":243,"in_reply_to":"1aa78d24_edccf8bc","updated":"2016-07-07 10:13:57.000000000","message":"Done","commit_id":"ad158ab97adb60bf0890711f8b0bcd188971d68c"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2a0a575458b05fdac07d4aecb68e1ab951558961","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1582188"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"We are adding pluggable network interfaces to Ironic, these interfaces will be"},{"line_number":14,"context_line":"configurable per Ironic node, this means that different nodes might have"},{"line_number":15,"context_line":"different ways of handling their network interfaces. We need a way that"},{"line_number":16,"context_line":"different network interfaces can override the interface mapping logic currently"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aa78d24_bdecabbb","line":13,"updated":"2016-07-07 13:05:20.000000000","message":"\"Ironic, these\" -\u003e \"Ironic. These\"","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"633aca5e05c2a75a0e251e563e39a2e4f0c2b653","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1582188"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"We are adding pluggable network interfaces to Ironic, these interfaces will be"},{"line_number":14,"context_line":"configurable per Ironic node, this means that different nodes might have"},{"line_number":15,"context_line":"different ways of handling their network interfaces. We need a way that"},{"line_number":16,"context_line":"different network interfaces can override the interface mapping logic currently"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_4f0273b5","line":13,"in_reply_to":"1aa78d24_bdecabbb","updated":"2016-08-10 14:45:56.000000000","message":"Done","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"80bcdeddc9873b0fbdd202c5f4626e49fa69070e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently we use an Ironic port update to assign neutron ports to Ironic ports"},{"line_number":23,"context_line":"using their extra field, doing the mapping this way may not work for a third"},{"line_number":24,"context_line":"party network interface implementation. This also ties the ironic nova virt"},{"line_number":25,"context_line":"driver to a particular network interface mapping implementation. If a third"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_79beeaff","line":22,"updated":"2016-07-21 11:05:48.000000000","message":"We also have internal_info now.","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"633aca5e05c2a75a0e251e563e39a2e4f0c2b653","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently we use an Ironic port update to assign neutron ports to Ironic ports"},{"line_number":23,"context_line":"using their extra field, doing the mapping this way may not work for a third"},{"line_number":24,"context_line":"party network interface implementation. This also ties the ironic nova virt"},{"line_number":25,"context_line":"driver to a particular network interface mapping implementation. If a third"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_2fff3fab","line":22,"in_reply_to":"dada55a8_79beeaff","updated":"2016-08-10 14:45:56.000000000","message":"Done","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2a0a575458b05fdac07d4aecb68e1ab951558961","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently we use an Ironic port update to assign neutron ports to Ironic ports"},{"line_number":23,"context_line":"using their extra field, doing the mapping this way may not work for a third"},{"line_number":24,"context_line":"party network interface implementation. This also ties the ironic nova virt"},{"line_number":25,"context_line":"driver to a particular network interface mapping implementation. If a third"},{"line_number":26,"context_line":"party network interface wants to do something different with the ironic ports"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aa78d24_fd1753a0","line":23,"updated":"2016-07-07 13:05:20.000000000","message":"\"field, doing\" -\u003e \"field. Doing\"","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"633aca5e05c2a75a0e251e563e39a2e4f0c2b653","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently we use an Ironic port update to assign neutron ports to Ironic ports"},{"line_number":23,"context_line":"using their extra field, doing the mapping this way may not work for a third"},{"line_number":24,"context_line":"party network interface implementation. This also ties the ironic nova virt"},{"line_number":25,"context_line":"driver to a particular network interface mapping implementation. If a third"},{"line_number":26,"context_line":"party network interface wants to do something different with the ironic ports"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_cf8023fa","line":23,"in_reply_to":"1aa78d24_fd1753a0","updated":"2016-08-10 14:45:56.000000000","message":"Done","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"80bcdeddc9873b0fbdd202c5f4626e49fa69070e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"using their extra field, doing the mapping this way may not work for a third"},{"line_number":24,"context_line":"party network interface implementation. This also ties the ironic nova virt"},{"line_number":25,"context_line":"driver to a particular network interface mapping implementation. If a third"},{"line_number":26,"context_line":"party network interface wants to do something different with the ironic ports"},{"line_number":27,"context_line":"or we as the Ironic team want to change an implementation detail we have to"},{"line_number":28,"context_line":"submit changes into nova."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_b915029d","line":26,"range":{"start_line":26,"start_character":36,"end_line":26,"end_character":55},"updated":"2016-07-21 11:05:48.000000000","message":"Could you provide an example of that somewhere?","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"633aca5e05c2a75a0e251e563e39a2e4f0c2b653","unresolved":false,"context_lines":[{"line_number":23,"context_line":"using their extra field, doing the mapping this way may not work for a third"},{"line_number":24,"context_line":"party network interface implementation. This also ties the ironic nova virt"},{"line_number":25,"context_line":"driver to a particular network interface mapping implementation. If a third"},{"line_number":26,"context_line":"party network interface wants to do something different with the ironic ports"},{"line_number":27,"context_line":"or we as the Ironic team want to change an implementation detail we have to"},{"line_number":28,"context_line":"submit changes into nova."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_0f7fdb15","line":26,"range":{"start_line":26,"start_character":36,"end_line":26,"end_character":55},"in_reply_to":"dada55a8_b915029d","updated":"2016-08-10 14:45:56.000000000","message":"Done","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2a0a575458b05fdac07d4aecb68e1ab951558961","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"To solve this problem I propose to add 2 two new API endpoints,"},{"line_number":34,"context_line":"interface_attach and interface_detach:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_attach"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aa78d24_7d24030c","line":33,"updated":"2016-07-07 13:05:20.000000000","message":"\"2 two\" -\u003e \"two\"","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"633aca5e05c2a75a0e251e563e39a2e4f0c2b653","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"To solve this problem I propose to add 2 two new API endpoints,"},{"line_number":34,"context_line":"interface_attach and interface_detach:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_attach"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_2f729f49","line":33,"in_reply_to":"1aa78d24_7d24030c","updated":"2016-08-10 14:45:56.000000000","message":"Done","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"80bcdeddc9873b0fbdd202c5f4626e49fa69070e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"REST API impact"},{"line_number":77,"context_line":"---------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* v1/nodes/\u003cnode_id\u003e/interface_attach"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  - Calls interface_attach on the network interface for the node, passing in"},{"line_number":82,"context_line":"    the json provided"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_b4bfc95f","line":79,"updated":"2016-07-21 11:05:48.000000000","message":"It would be good to have some examples of what can be here, in current case it\u0027s just a port update, but for third party interfaces, can some asynchronous actions happen here? If so, how it is going to interact with nova?","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"633aca5e05c2a75a0e251e563e39a2e4f0c2b653","unresolved":false,"context_lines":[{"line_number":76,"context_line":"REST API impact"},{"line_number":77,"context_line":"---------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* v1/nodes/\u003cnode_id\u003e/interface_attach"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  - Calls interface_attach on the network interface for the node, passing in"},{"line_number":82,"context_line":"    the json provided"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_efc36787","line":79,"in_reply_to":"dada55a8_b4bfc95f","updated":"2016-08-10 14:45:56.000000000","message":"This is intended to be a synchronous API endpoint, and the normal ironic rules apply for avoiding implementing tasks that take a long time or are unstable under synchronous endpoints.","commit_id":"b2fa175ab0e72596317a32ab8999a2e7b7e0d0a1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ec7bd5b9d5c025f30bd8dee61eb465542b6beaed","unresolved":false,"context_lines":[{"line_number":24,"context_line":"third party network interface implementation. This also ties the ironic nova"},{"line_number":25,"context_line":"virt driver to a particular network interface mapping implementation. If a"},{"line_number":26,"context_line":"third party network interface wants to do something different with network"},{"line_number":27,"context_line":"interface mapping such as storing the port ids for dynamic vNIC creation later"},{"line_number":28,"context_line":"in the provisioning process or we as the Ironic team want to change an"},{"line_number":29,"context_line":"implementation detail we have to submit changes into nova."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_6b3a29cf","line":27,"updated":"2016-10-18 21:22:56.000000000","message":"nit s/ids/IDs/","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f78be430e2689a6c026974c0d670b0c416961fec","unresolved":false,"context_lines":[{"line_number":24,"context_line":"third party network interface implementation. This also ties the ironic nova"},{"line_number":25,"context_line":"virt driver to a particular network interface mapping implementation. If a"},{"line_number":26,"context_line":"third party network interface wants to do something different with network"},{"line_number":27,"context_line":"interface mapping such as storing the port ids for dynamic vNIC creation later"},{"line_number":28,"context_line":"in the provisioning process or we as the Ironic team want to change an"},{"line_number":29,"context_line":"implementation detail we have to submit changes into nova."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_7790394f","line":27,"in_reply_to":"fa6399be_6b3a29cf","updated":"2016-10-19 10:20:08.000000000","message":"Done","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"884bf2aaa2acc19692087a7930b61b6929df8ae4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"To solve this problem I propose to add two new API endpoints, interface_attach"},{"line_number":35,"context_line":"and interface_detach:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_attach"},{"line_number":38,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_detach"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"These API endpoints will take via a POST body, a JSON representation of a"},{"line_number":41,"context_line":"generic VIF object. Making it generic allows for non-neutron based"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_12bbcb76","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":40},"updated":"2016-10-18 01:41:41.000000000","message":"nit: It would be better to itemize them.","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f78be430e2689a6c026974c0d670b0c416961fec","unresolved":false,"context_lines":[{"line_number":34,"context_line":"To solve this problem I propose to add two new API endpoints, interface_attach"},{"line_number":35,"context_line":"and interface_detach:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_attach"},{"line_number":38,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_detach"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"These API endpoints will take via a POST body, a JSON representation of a"},{"line_number":41,"context_line":"generic VIF object. Making it generic allows for non-neutron based"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_37aec198","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":40},"in_reply_to":"fa6399be_12bbcb76","updated":"2016-10-19 10:20:08.000000000","message":"I\u0027m not sure what you mean","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9db278d122828ec6edc3aabf02a42730cf07ce46","unresolved":false,"context_lines":[{"line_number":42,"context_line":"implementations to use this API. This VIF object will be passed to new"},{"line_number":43,"context_line":"functions in the pluggable network interfaces:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def interface_attach(self, vif):"},{"line_number":46,"context_line":"    ..."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def interface_detach(self, vif):"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_c610bfae","line":45,"updated":"2016-10-17 20:04:36.000000000","message":"In future we can pass here additional information like portgroup metadata to allow dynamic portgroup creation on the fly.","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ec7bd5b9d5c025f30bd8dee61eb465542b6beaed","unresolved":false,"context_lines":[{"line_number":77,"context_line":"REST API impact"},{"line_number":78,"context_line":"---------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* v1/nodes/\u003cnode_id\u003e/interface_attach"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  - Calls interface_attach on the network interface for the node, passing in"},{"line_number":83,"context_line":"    the json provided"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_4ba805dc","line":80,"updated":"2016-10-18 21:22:56.000000000","message":"bike shedding time.\n\nWhy \u0027interface_attach\u0027? It implies \u0027network interface\u0027.  Is \u0027interface\u0027 more important/relevant than \u0027network\u0027? I am only asking if, in the future, there is some Foo thing, and one could have foo interfaces too.\n\n\u0027network_interface_attach\u0027 is too long I think. Or is it?  \u0027network_int_attach\u0027? What\u0027s the lingo used in the industry?","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f78be430e2689a6c026974c0d670b0c416961fec","unresolved":false,"context_lines":[{"line_number":77,"context_line":"REST API impact"},{"line_number":78,"context_line":"---------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* v1/nodes/\u003cnode_id\u003e/interface_attach"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  - Calls interface_attach on the network interface for the node, passing in"},{"line_number":83,"context_line":"    the json provided"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_779e7955","line":80,"in_reply_to":"fa6399be_4ba805dc","updated":"2016-10-19 10:20:08.000000000","message":"I choose interface attach/detach because it aligns with the nova command/API for doing the same thing for VMs.","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ec7bd5b9d5c025f30bd8dee61eb465542b6beaed","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    avoiding implementing tasks that take a long time or are unstable under"},{"line_number":86,"context_line":"    synchronous endpoints."},{"line_number":87,"context_line":"  - Method: POST"},{"line_number":88,"context_line":"  - Normal http response: 204"},{"line_number":89,"context_line":"  - Expected response codes:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    + 404, Node not found"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_0b61ada8","line":88,"updated":"2016-10-18 21:22:56.000000000","message":"s/Normal/Success/ ?","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f78be430e2689a6c026974c0d670b0c416961fec","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    avoiding implementing tasks that take a long time or are unstable under"},{"line_number":86,"context_line":"    synchronous endpoints."},{"line_number":87,"context_line":"  - Method: POST"},{"line_number":88,"context_line":"  - Normal http response: 204"},{"line_number":89,"context_line":"  - Expected response codes:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    + 404, Node not found"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_7a466022","line":88,"in_reply_to":"fa6399be_0b61ada8","updated":"2016-10-19 10:20:08.000000000","message":"Done","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ec7bd5b9d5c025f30bd8dee61eb465542b6beaed","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    synchronous endpoints."},{"line_number":87,"context_line":"  - Method: POST"},{"line_number":88,"context_line":"  - Normal http response: 204"},{"line_number":89,"context_line":"  - Expected response codes:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    + 404, Node not found"},{"line_number":92,"context_line":"    + 400/422, The request was good but unable to attach the interface for a"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_8bd85d81","line":89,"updated":"2016-10-18 21:22:56.000000000","message":"s/Expected/Expected error/","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f78be430e2689a6c026974c0d670b0c416961fec","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    synchronous endpoints."},{"line_number":87,"context_line":"  - Method: POST"},{"line_number":88,"context_line":"  - Normal http response: 204"},{"line_number":89,"context_line":"  - Expected response codes:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    + 404, Node not found"},{"line_number":92,"context_line":"    + 400/422, The request was good but unable to attach the interface for a"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_9a55f4c7","line":89,"in_reply_to":"fa6399be_8bd85d81","updated":"2016-10-19 10:20:08.000000000","message":"Done","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ec7bd5b9d5c025f30bd8dee61eb465542b6beaed","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    synchronous endpoints."},{"line_number":126,"context_line":"  - Method: POST"},{"line_number":127,"context_line":"  - Normal http response: 204"},{"line_number":128,"context_line":"  - Expected response codes:"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    + 404, Node not found"},{"line_number":131,"context_line":"    + 400/422, The request was good but unable to detach the interface for a"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_8b469d1f","line":128,"updated":"2016-10-18 21:22:56.000000000","message":"ditto","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f78be430e2689a6c026974c0d670b0c416961fec","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    synchronous endpoints."},{"line_number":126,"context_line":"  - Method: POST"},{"line_number":127,"context_line":"  - Normal http response: 204"},{"line_number":128,"context_line":"  - Expected response codes:"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    + 404, Node not found"},{"line_number":131,"context_line":"    + 400/422, The request was good but unable to detach the interface for a"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_ba50f8d5","line":128,"in_reply_to":"fa6399be_8b469d1f","updated":"2016-10-19 10:20:08.000000000","message":"Done","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ec7bd5b9d5c025f30bd8dee61eb465542b6beaed","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Is a corresponding change in the client library and CLI necessary? Yes"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Is this change discoverable by clients? Yes via microversions"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Client (CLI) impact"},{"line_number":145,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_cbec15f6","line":142,"updated":"2016-10-18 21:22:56.000000000","message":"I\u0027m not sure what this question means :)","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f78be430e2689a6c026974c0d670b0c416961fec","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Is a corresponding change in the client library and CLI necessary? Yes"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Is this change discoverable by clients? Yes via microversions"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Client (CLI) impact"},{"line_number":145,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_17d1bdcd","line":142,"in_reply_to":"fa6399be_cbec15f6","updated":"2016-10-19 10:20:08.000000000","message":"From the template:\n\nIs this change discoverable by clients? Not all clients will upgrade at the same time, so this change must work with older clients without breaking them.\n\nI\u0027ll reword the line to make more sense.","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"884bf2aaa2acc19692087a7930b61b6929df8ae4","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  def interface_detach(self, task, interface_id):"},{"line_number":174,"context_line":"      raise NotImplemented"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Nova driver impact"},{"line_number":177,"context_line":"------------------"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_e5512fda","line":175,"updated":"2016-10-18 01:41:41.000000000","message":"Will the existing flat and neutron interfaces implement these methods to set interface_ids to a port or a portgroup like nova does currently?\nIf correct, I would like that to be described explicitly.","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f78be430e2689a6c026974c0d670b0c416961fec","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  def interface_detach(self, task, interface_id):"},{"line_number":174,"context_line":"      raise NotImplemented"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Nova driver impact"},{"line_number":177,"context_line":"------------------"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_7a6d8098","line":175,"in_reply_to":"fa6399be_e5512fda","updated":"2016-10-19 10:20:08.000000000","message":"Done","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9db278d122828ec6edc3aabf02a42730cf07ce46","unresolved":false,"context_lines":[{"line_number":177,"context_line":"------------------"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Nova driver plug/unplug_vifs logic will be replaced by calling attach/detach"},{"line_number":180,"context_line":"for every vif passed into those functions."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Ramdisk impact"},{"line_number":183,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_e62ea3f9","line":180,"updated":"2016-10-17 20:04:36.000000000","message":"Looks like by having this attach detach interface API macs_for_instance() will be not needed anymore.","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f78be430e2689a6c026974c0d670b0c416961fec","unresolved":false,"context_lines":[{"line_number":177,"context_line":"------------------"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Nova driver plug/unplug_vifs logic will be replaced by calling attach/detach"},{"line_number":180,"context_line":"for every vif passed into those functions."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Ramdisk impact"},{"line_number":183,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_9a6c149e","line":180,"in_reply_to":"fa6399be_e62ea3f9","updated":"2016-10-19 10:20:08.000000000","message":"Done","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ec7bd5b9d5c025f30bd8dee61eb465542b6beaed","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"New nova virt drivers should continue to work with an old Ironic API using API"},{"line_number":256,"context_line":"discovery and if the new API is available use it and if it isn\u0027t do it the port"},{"line_number":257,"context_line":"update way, for one cycle."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Documentation Impact"},{"line_number":260,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_6b7ce920","line":257,"updated":"2016-10-18 21:22:56.000000000","message":"I don\u0027t know about this. The ironic API version is hardcoded in nova. Or are you going to propose changing that.","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f78be430e2689a6c026974c0d670b0c416961fec","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"New nova virt drivers should continue to work with an old Ironic API using API"},{"line_number":256,"context_line":"discovery and if the new API is available use it and if it isn\u0027t do it the port"},{"line_number":257,"context_line":"update way, for one cycle."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Documentation Impact"},{"line_number":260,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_3aeb087a","line":257,"in_reply_to":"fa6399be_6b7ce920","updated":"2016-10-19 10:20:08.000000000","message":"Done","commit_id":"e05fc6f07b39658bccc586d3a8b64c6bd0d0da2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"305416a0ceac2b30a07610539d2e7412b792cb43","unresolved":false,"context_lines":[{"line_number":35,"context_line":"and interface_detach:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_attach"},{"line_number":38,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_detach"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"These API endpoints will take via a POST body, a JSON representation of a"},{"line_number":41,"context_line":"generic VIF object. Making it generic allows for non-neutron based"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_0c6d1998","line":38,"updated":"2016-10-19 17:59:00.000000000","message":"I think Hironori meant that you should render this as a list or bullets. Right now, the two lines render as one line :-(","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"5264fbb9657113be8d68a43d7bb8e18dd514927d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"and interface_detach:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_attach"},{"line_number":38,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_detach"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"These API endpoints will take via a POST body, a JSON representation of a"},{"line_number":41,"context_line":"generic VIF object. Making it generic allows for non-neutron based"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_3fa74bbe","line":38,"in_reply_to":"fa6399be_0c6d1998","updated":"2016-10-20 10:40:12.000000000","message":"Done","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f4b9239e9595f0cbf86550da715357c13c7d1080","unresolved":false,"context_lines":[{"line_number":35,"context_line":"and interface_detach:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_attach"},{"line_number":38,"context_line":"POST v1/nodes/\u003cnode_id\u003e/interface_detach"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"These API endpoints will take via a POST body, a JSON representation of a"},{"line_number":41,"context_line":"generic VIF object. Making it generic allows for non-neutron based"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_e259a536","line":38,"in_reply_to":"fa6399be_3fa74bbe","updated":"2016-10-20 16:41:48.000000000","message":"I meant it. Thanks.","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"305416a0ceac2b30a07610539d2e7412b792cb43","unresolved":false,"context_lines":[{"line_number":78,"context_line":"---------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* v1/nodes/\u003cnode_id\u003e/interface_attach"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  - Calls interface_attach on the network interface for the node, passing in"},{"line_number":83,"context_line":"    the json provided"},{"line_number":84,"context_line":"  - This is a synchronous API endpoint, and the normal ironic rules apply for"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_0cc99978","line":81,"updated":"2016-10-19 17:59:00.000000000","message":"Maybe add (so I remember): We use \u0027interface_attach\u0027 to be consistent with nova\u0027s CLI \u0027nova interface-attach ...\u0027.","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"5264fbb9657113be8d68a43d7bb8e18dd514927d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"---------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* v1/nodes/\u003cnode_id\u003e/interface_attach"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  - Calls interface_attach on the network interface for the node, passing in"},{"line_number":83,"context_line":"    the json provided"},{"line_number":84,"context_line":"  - This is a synchronous API endpoint, and the normal ironic rules apply for"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_7fad439a","line":81,"in_reply_to":"fa6399be_0cc99978","updated":"2016-10-20 10:40:12.000000000","message":"Done","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"305416a0ceac2b30a07610539d2e7412b792cb43","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"\"openstack baremetal\" CLI"},{"line_number":153,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":154,"context_line":"* openstack baremetal node interface attach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":155,"context_line":"* openstack baremetal node interface detach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"RPC API impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_4f0543c0","line":154,"updated":"2016-10-19 17:59:00.000000000","message":"do you know what the equivalent \u0027openstack\u0027 command is for \u0027nova interface-attach\u0027 and \u0027nova interface-detach\u0027? I looked quickly and didn\u0027t see any openstack commands with \u0027interface attach\u0027.","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"5264fbb9657113be8d68a43d7bb8e18dd514927d","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"\"openstack baremetal\" CLI"},{"line_number":153,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":154,"context_line":"* openstack baremetal node interface attach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":155,"context_line":"* openstack baremetal node interface detach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"RPC API impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_1fefe787","line":154,"in_reply_to":"fa6399be_4f0543c0","updated":"2016-10-20 10:40:12.000000000","message":"I have also looked, and there doesn\u0027t seem to be one, I\u0027ll enquire on the nova IRC and see if there is one planned.","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"305416a0ceac2b30a07610539d2e7412b792cb43","unresolved":false,"context_lines":[{"line_number":174,"context_line":"      raise NotImplemented"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Existing flat, neutron and noop network interfaces will need extending to"},{"line_number":177,"context_line":"include implementations for these functions."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Flat network driver will need to implement add_provisioning_network to bind the"},{"line_number":180,"context_line":"ports that used to be bound by nova."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_0f634bdd","line":177,"updated":"2016-10-19 17:59:00.000000000","message":"for out of tree drivers or actually out-of-tree network interfaces, if we add this, will those break?","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f0cee8000d78a85e65f2fc8e56eacbc84c789103","unresolved":false,"context_lines":[{"line_number":174,"context_line":"      raise NotImplemented"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Existing flat, neutron and noop network interfaces will need extending to"},{"line_number":177,"context_line":"include implementations for these functions."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Flat network driver will need to implement add_provisioning_network to bind the"},{"line_number":180,"context_line":"ports that used to be bound by nova."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_9386a1d9","line":177,"in_reply_to":"fa6399be_0f634bdd","updated":"2016-10-19 22:00:48.000000000","message":"Yeah, maybe return none instead. Or, can we move the vif_port_id logic here in the base class and issue warnings here?","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"5264fbb9657113be8d68a43d7bb8e18dd514927d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"      raise NotImplemented"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Existing flat, neutron and noop network interfaces will need extending to"},{"line_number":177,"context_line":"include implementations for these functions."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Flat network driver will need to implement add_provisioning_network to bind the"},{"line_number":180,"context_line":"ports that used to be bound by nova."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_3f374b00","line":177,"in_reply_to":"fa6399be_9386a1d9","updated":"2016-10-20 10:40:12.000000000","message":"I\u0027ve added some stuff in the deprecation section explaining how we should handle it for out of tree network interfaces.","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"305416a0ceac2b30a07610539d2e7412b792cb43","unresolved":false,"context_lines":[{"line_number":185,"context_line":"plug/unplug_vifs logic will be replaced by calling attach/detach for every vif"},{"line_number":186,"context_line":"passed into those functions."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"macs_for_instance will be removed because mapping is handled inside Ironic so"},{"line_number":189,"context_line":"mac_address assignment must happen at binding later in the process."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"network_binding_host_id will be changed to return None, so that neutron ports"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_cfaf93e1","line":188,"updated":"2016-10-19 17:59:00.000000000","message":"macs_for_instance is a method in the ironic driver, right?","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"de3767e5636032e999780bf2d3f7e4c3b1a91cf2","unresolved":false,"context_lines":[{"line_number":185,"context_line":"plug/unplug_vifs logic will be replaced by calling attach/detach for every vif"},{"line_number":186,"context_line":"passed into those functions."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"macs_for_instance will be removed because mapping is handled inside Ironic so"},{"line_number":189,"context_line":"mac_address assignment must happen at binding later in the process."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"network_binding_host_id will be changed to return None, so that neutron ports"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_1ed44d1e","line":188,"in_reply_to":"fa6399be_cfaf93e1","updated":"2016-10-20 08:31:39.000000000","message":"yes, it is method from ironic virt driver\nhttps://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L674","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"de3767e5636032e999780bf2d3f7e4c3b1a91cf2","unresolved":false,"context_lines":[{"line_number":188,"context_line":"macs_for_instance will be removed because mapping is handled inside Ironic so"},{"line_number":189,"context_line":"mac_address assignment must happen at binding later in the process."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"network_binding_host_id will be changed to return None, so that neutron ports"},{"line_number":192,"context_line":"remain unbound until Ironic binds them during deployment."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_de7495ff","line":191,"updated":"2016-10-20 08:31:39.000000000","message":"currently we setting None only for Neutron network driver\nhttps://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1231","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"5264fbb9657113be8d68a43d7bb8e18dd514927d","unresolved":false,"context_lines":[{"line_number":188,"context_line":"macs_for_instance will be removed because mapping is handled inside Ironic so"},{"line_number":189,"context_line":"mac_address assignment must happen at binding later in the process."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"network_binding_host_id will be changed to return None, so that neutron ports"},{"line_number":192,"context_line":"remain unbound until Ironic binds them during deployment."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_71f017fe","line":191,"in_reply_to":"fa6399be_de7495ff","updated":"2016-10-20 10:40:12.000000000","message":"This is saying that it will now return None for all cases.","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"305416a0ceac2b30a07610539d2e7412b792cb43","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"},{"line_number":195,"context_line":"Ironic can use it to bind neutron ports into flat networks like nova does"},{"line_number":196,"context_line":"today."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Ramdisk impact"},{"line_number":199,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_ef91b79b","line":196,"updated":"2016-10-19 17:59:00.000000000","message":"The nova side will have a blueprint associated with it, right?","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b0917f8dbf7ebfc9f7452501a10009a1412f9f8b","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"},{"line_number":195,"context_line":"Ironic can use it to bind neutron ports into flat networks like nova does"},{"line_number":196,"context_line":"today."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Ramdisk impact"},{"line_number":199,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da6895a0_bc2f6df5","line":196,"in_reply_to":"fa6399be_20fe43ae","updated":"2016-10-20 18:59:15.000000000","message":"I didn\u0027t saw drivers that bind hardware server ports in flat network. By design flat network scenario means that hardware servers are pre-connected by administrator. With VMs we still need to bind port, but not with hardware servers. I vote to use ironic node.id for vlan and for flat network. Curious about other thoughts on this.","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"5264fbb9657113be8d68a43d7bb8e18dd514927d","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"},{"line_number":195,"context_line":"Ironic can use it to bind neutron ports into flat networks like nova does"},{"line_number":196,"context_line":"today."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Ramdisk impact"},{"line_number":199,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_d1700375","line":196,"in_reply_to":"fa6399be_3ee3d1da","updated":"2016-10-20 10:40:12.000000000","message":"This spec will change the flat network interface behaviour, currently nova updates the ports with host_id \u003d\u003d nova compute host id, with this spec nova won\u0027t do that anymore, so we need this compute host id in the instance info so that the flat network interface can do the binding in Ironic.","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6ed602dc46dbfb09de3662bbd2cb615685f09ab8","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"},{"line_number":195,"context_line":"Ironic can use it to bind neutron ports into flat networks like nova does"},{"line_number":196,"context_line":"today."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Ramdisk impact"},{"line_number":199,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_85b3a199","line":196,"in_reply_to":"fa6399be_6553ed17","updated":"2016-10-20 12:09:45.000000000","message":"But in ironic we set it to ironic node node.id\n\nhttps://github.com/openstack/ironic/blob/master/ironic/common/neutron.py#L105\n\nI\u0027m not super neutron expert, but it looks host_id is needed only to initiate binding process so the value is not important for Ironic case, it is important that some of ML2 drivers actually bind port.\n\nhttps://github.com/openstack/neutron/blob/4e58f4415d8f12f1b760116d77944871a28636f1/neutron/plugins/ml2/plugin.py#L389\n\nhttps://github.com/openstack/neutron/blob/4e58f4415d8f12f1b760116d77944871a28636f1/neutron/plugins/ml2/plugin.py#L409-L428","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"193f14824a68ced1180605c06a66923d0bbe3908","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"},{"line_number":195,"context_line":"Ironic can use it to bind neutron ports into flat networks like nova does"},{"line_number":196,"context_line":"today."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Ramdisk impact"},{"line_number":199,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_20fe43ae","line":196,"in_reply_to":"fa6399be_85b3a199","updated":"2016-10-20 12:34:20.000000000","message":"We do that for the neutron network interface case because it\u0027ll get handled by our baremetal vnic type.\n\nBut this is for the flat network case, so to maintain the existing behaviour and so that nova doesn\u0027t think that the binding and therefore the provisioning failed, the compute host id should be used for the flat network interface.\n\nUnless we want to rework the whole flat network scenario at this point to actually use a vnic type that makes sense instead of the one that is given to the port by nova?","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"a930c0d1fb0ee3878fd34dd7f52ad72ad202805d","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"},{"line_number":195,"context_line":"Ironic can use it to bind neutron ports into flat networks like nova does"},{"line_number":196,"context_line":"today."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Ramdisk impact"},{"line_number":199,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_6553ed17","line":196,"in_reply_to":"fa6399be_94111907","updated":"2016-10-20 11:56:37.000000000","message":"https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1234\n\nand\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/driver.py#L1589\n\nCurrently results in \n\nhttp://logs.openstack.org/75/370875/18/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa/35e1c85/logs/screen-q-svc.txt.gz#_2016-10-20_10_59_58_460\n\nwhich is the id of the actual nova CPU service not the Ironic node_id","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2143f1d386510fb247bd4ac32c4cd371849c6d24","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"},{"line_number":195,"context_line":"Ironic can use it to bind neutron ports into flat networks like nova does"},{"line_number":196,"context_line":"today."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Ramdisk impact"},{"line_number":199,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_94111907","line":196,"in_reply_to":"fa6399be_d1700375","updated":"2016-10-20 10:44:44.000000000","message":"compute host_id is ironic node_id we can get ironic node id directly from the task.node.uuid so no need to save it in instance_info right?","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"de3767e5636032e999780bf2d3f7e4c3b1a91cf2","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"},{"line_number":195,"context_line":"Ironic can use it to bind neutron ports into flat networks like nova does"},{"line_number":196,"context_line":"today."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Ramdisk impact"},{"line_number":199,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_3ee3d1da","line":196,"in_reply_to":"fa6399be_ef91b79b","updated":"2016-10-20 08:31:39.000000000","message":"This sentence confusing, ironic do not bind ports when flat network is used. Using flat network means that nodes are pre-connected to it.\nAlso we setting host_id to ironic node uuid [0] why we need duplicate information in instance_info?\n\n[0] https://github.com/openstack/ironic/blob/master/ironic/common/neutron.py#L105","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"305416a0ceac2b30a07610539d2e7412b792cb43","unresolved":false,"context_lines":[{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"},{"line_number":195,"context_line":"Ironic can use it to bind neutron ports into flat networks like nova does"},{"line_number":196,"context_line":"today."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Ramdisk impact"},{"line_number":199,"context_line":"--------------"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_0fbfcbfb","line":197,"updated":"2016-10-19 17:59:00.000000000","message":"I wonder if we should mention that we\u0027ll need to bump the ironic API version that is used by the nova driver.","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"5264fbb9657113be8d68a43d7bb8e18dd514927d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"nova driver will need to include the host_id in the instance_info so that"},{"line_number":195,"context_line":"Ironic can use it to bind neutron ports into flat networks like nova does"},{"line_number":196,"context_line":"today."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Ramdisk impact"},{"line_number":199,"context_line":"--------------"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_d1c80358","line":197,"in_reply_to":"fa6399be_0fbfcbfb","updated":"2016-10-20 10:40:12.000000000","message":"Done","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"305416a0ceac2b30a07610539d2e7412b792cb43","unresolved":false,"context_lines":[{"line_number":266,"context_line":"Old nova virt drivers will continue to do what they do now, and the neutron"},{"line_number":267,"context_line":"network interface will need to continue to support interface attachment via"},{"line_number":268,"context_line":"port update. A deprecation message should be issued on a port update if a user"},{"line_number":269,"context_line":"is directly setting vif_port_id on a port or portgroup."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Ironic must be upgraded before Nova is as newer nova virt drivers won\u0027t work"},{"line_number":272,"context_line":"with older versions of Ironic which are missing the new APIs."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_4fd38338","line":269,"updated":"2016-10-19 17:59:00.000000000","message":"Are we going to deprecate and then delete the ability to directly set vif_port_id on a port/portgroup via a port-update?","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"5264fbb9657113be8d68a43d7bb8e18dd514927d","unresolved":false,"context_lines":[{"line_number":266,"context_line":"Old nova virt drivers will continue to do what they do now, and the neutron"},{"line_number":267,"context_line":"network interface will need to continue to support interface attachment via"},{"line_number":268,"context_line":"port update. A deprecation message should be issued on a port update if a user"},{"line_number":269,"context_line":"is directly setting vif_port_id on a port or portgroup."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Ironic must be upgraded before Nova is as newer nova virt drivers won\u0027t work"},{"line_number":272,"context_line":"with older versions of Ironic which are missing the new APIs."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_513793fe","line":269,"in_reply_to":"fa6399be_4fd38338","updated":"2016-10-20 10:40:12.000000000","message":"Deprecate it yes, but because its just a field set in a json we can\u0027t ever delete the ability to set it, we can only warn people that it\u0027ll be ignored in the future.","commit_id":"a4905240b1522e82b1f087b1dad041574098d0ea"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"86e0d2215e27dd86b0cfa84173ecc208e0f2b503","unresolved":false,"context_lines":[{"line_number":26,"context_line":"third party network interface wants to do something different with network"},{"line_number":27,"context_line":"interface mapping such as storing the port IDs for dynamic vNIC creation later"},{"line_number":28,"context_line":"in the provisioning process or we as the Ironic team want to change an"},{"line_number":29,"context_line":"implementation detail we have to submit changes into nova."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_6aae6799","line":29,"updated":"2016-11-09 16:20:37.000000000","message":"This also makes it easier to do post-boot network attach/detach in the future, without a task to poll port.extra or something. :)","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"10eb598b1857bcbebdbb626f9206f8fccd63da95","unresolved":false,"context_lines":[{"line_number":26,"context_line":"third party network interface wants to do something different with network"},{"line_number":27,"context_line":"interface mapping such as storing the port IDs for dynamic vNIC creation later"},{"line_number":28,"context_line":"in the provisioning process or we as the Ironic team want to change an"},{"line_number":29,"context_line":"implementation detail we have to submit changes into nova."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_9272ee0f","line":29,"in_reply_to":"9a629dbe_6aae6799","updated":"2016-11-10 13:03:42.000000000","message":"Done","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9de73b4fba76552caa916024e6c1a84eed04dda0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  - This is a synchronous API endpoint, and the normal ironic rules apply for"},{"line_number":88,"context_line":"    avoiding implementing tasks that take a long time or are unstable under"},{"line_number":89,"context_line":"    synchronous endpoints."},{"line_number":90,"context_line":"  - Method: POST"},{"line_number":91,"context_line":"  - Successful http response: 204"},{"line_number":92,"context_line":"  - Expected error response codes:"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5da102_5661e503","line":90,"updated":"2016-11-03 17:03:09.000000000","message":"I\u0027m not a REST API expert -- wondering why it is POST instead of PUT. Looks like we use PUT for eg setting boot device, changing node power and provision state, setting raid config, start/stop console.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d00d9b3b07bb4aca99d056692a54fde236711cc8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  - This is a synchronous API endpoint, and the normal ironic rules apply for"},{"line_number":88,"context_line":"    avoiding implementing tasks that take a long time or are unstable under"},{"line_number":89,"context_line":"    synchronous endpoints."},{"line_number":90,"context_line":"  - Method: POST"},{"line_number":91,"context_line":"  - Successful http response: 204"},{"line_number":92,"context_line":"  - Expected error response codes:"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_84e675b2","line":90,"in_reply_to":"9a629dbe_29482287","updated":"2016-11-08 23:08:33.000000000","message":"Nova\u0027s interface stuff is http://developer.openstack.org/api-ref/compute/#port-interfaces-servers-os-interface. So POST and DELETE, which seems in line with your alternative.\n\nI don\u0027t know that it matters if the interface ID can be any string -- what might be the problem with that?","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"86e0d2215e27dd86b0cfa84173ecc208e0f2b503","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  - This is a synchronous API endpoint, and the normal ironic rules apply for"},{"line_number":88,"context_line":"    avoiding implementing tasks that take a long time or are unstable under"},{"line_number":89,"context_line":"    synchronous endpoints."},{"line_number":90,"context_line":"  - Method: POST"},{"line_number":91,"context_line":"  - Successful http response: 204"},{"line_number":92,"context_line":"  - Expected error response codes:"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_2de489df","line":90,"in_reply_to":"9a629dbe_84e675b2","updated":"2016-11-09 16:20:37.000000000","message":"I don\u0027t foresee any problems with the alternative here, and I quite like it. We should mandate that the (node, interface_id) combination be unique in any case, which removes potential problems there.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd5e55b3e939e6d2f5c1751dd53981e653883b24","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  - This is a synchronous API endpoint, and the normal ironic rules apply for"},{"line_number":88,"context_line":"    avoiding implementing tasks that take a long time or are unstable under"},{"line_number":89,"context_line":"    synchronous endpoints."},{"line_number":90,"context_line":"  - Method: POST"},{"line_number":91,"context_line":"  - Successful http response: 204"},{"line_number":92,"context_line":"  - Expected error response codes:"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_29482287","line":90,"in_reply_to":"9a629dbe_85c40141","updated":"2016-11-08 23:00:48.000000000","message":"I dunno. I looked at nova, and it looks like they use POST (although I could be wrong, I\u0027m not that familiar with nova stuff) so I guess POST it is.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ecb1640213e5600c30c4a83bf7654c2e065c5f6e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  - This is a synchronous API endpoint, and the normal ironic rules apply for"},{"line_number":88,"context_line":"    avoiding implementing tasks that take a long time or are unstable under"},{"line_number":89,"context_line":"    synchronous endpoints."},{"line_number":90,"context_line":"  - Method: POST"},{"line_number":91,"context_line":"  - Successful http response: 204"},{"line_number":92,"context_line":"  - Expected error response codes:"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_85c40141","line":90,"in_reply_to":"ba5da102_5661e503","updated":"2016-11-07 14:39:14.000000000","message":"As I understand it PUT is for editing the node resource itself, boot device, power state and provision state are all part of the node object, however I see this endpoints not as editing the node but rather more like adding and removing a subresource.\n\nAn alternative API form which I also like is:\n\nTo attach:\nPOST v1/nodes/\u003cnode_id\u003e/interface\n\n{\n    \"interface_id\": \"8e6ba175-1c16-4dfa-82b9-dfc12f129170\"\n}\n\nTo detach:\nDELETE v1/nodes/\u003cnode_id\u003e/interface/\u003cinterface_id\u003e\n\nHowever I wasn\u0027t sure if that might result in problems with the fact that the interface_id can be any string.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"86e0d2215e27dd86b0cfa84173ecc208e0f2b503","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    + 404, Node not found"},{"line_number":95,"context_line":"    + 400/422, The request was good but unable to attach the interface for a"},{"line_number":96,"context_line":"      defined reason"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  - Expected data is a JSON"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_6d38413e","line":96,"updated":"2016-11-09 16:20:37.000000000","message":"Well, 400 is bad request, right? Implying the request was not good. Which cases throw 400 vs 422 here?\n\nDo we also need 409 for e.g. the interface is already attached to this node?","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"10eb598b1857bcbebdbb626f9206f8fccd63da95","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    + 404, Node not found"},{"line_number":95,"context_line":"    + 400/422, The request was good but unable to attach the interface for a"},{"line_number":96,"context_line":"      defined reason"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  - Expected data is a JSON"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_568e8179","line":96,"in_reply_to":"9a629dbe_6d38413e","updated":"2016-11-10 13:03:42.000000000","message":"Done","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd5e55b3e939e6d2f5c1751dd53981e653883b24","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    + Example::"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        {"},{"line_number":117,"context_line":"          \"interface_id\": \"8e6ba175-1c16-4dfa-82b9-dfc12f129170\""},{"line_number":118,"context_line":"        }"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  - Expected response body is empty"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_e4e011cf","line":117,"updated":"2016-11-08 23:00:48.000000000","message":"do we think that our network interfaces will save this interface ID in some internal field in the node or a port? Will it be in the same location or will it depend on the network interface? (Seems like we\u0027d want this info to be saved in the same place regardless of type of network interface?)","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"10eb598b1857bcbebdbb626f9206f8fccd63da95","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    + Example::"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        {"},{"line_number":117,"context_line":"          \"interface_id\": \"8e6ba175-1c16-4dfa-82b9-dfc12f129170\""},{"line_number":118,"context_line":"        }"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  - Expected response body is empty"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_3dfad375","line":117,"in_reply_to":"9a629dbe_e4e011cf","updated":"2016-11-10 13:03:42.000000000","message":"This is entirely down to the network interface implementation. Some network interfaces might store the information on the ports (like ours does today) however some network interface implementations might not have ports to store that information on because they interact with flex-nic cards and create the NICs at deploy time. So in those cases I\u0027d expect they might store the vifs in a list on the node\u0027s internal driver info or something instead.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd5e55b3e939e6d2f5c1751dd53981e653883b24","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Is a corresponding change in the client library and CLI necessary? Yes"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"* As these are new API entry points they will not affect older clients."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Client (CLI) impact"},{"line_number":148,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_e492d14a","line":145,"updated":"2016-11-08 23:00:48.000000000","message":"I need guidelines for our API: http://developer.openstack.org/api-ref/baremetal/\n\nAll the /nodes/\u003cident\u003e/something endpoints are modifying some node attribute. We then have /nodes/\u003cident\u003e/states/stuff \u0026 management/stuff. should we add a /nodes/\u003cident\u003e/network/stuff to handle this? Or should we decide going forward, to just add endpoints to the node like you are doing here?\n\nAlso, I don\u0027t like \u0027interface_attach\u0027 and \u0027interface_detach\u0027 even though nova uses them, because our node\u0027s \u0027driver\u0027 consists of interfaces so \u0027interface\u0027 is overloaded.\n\nIt\u0027d be really good to know what nova\u0027s OSC equivalent commands are.\n\nI\u0027m now swaying towards /nodes/\u003cid\u003e/network_interface_attach or /nodes/\u003cid\u003e/vif_attach or /nodes/\u003cid\u003e/network_attach ???","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"66b1e3d7b0a603d56b14c7ea3ff474fa89180afa","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Is a corresponding change in the client library and CLI necessary? Yes"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"* As these are new API entry points they will not affect older clients."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Client (CLI) impact"},{"line_number":148,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_553857ef","line":145,"in_reply_to":"9a629dbe_1b145b9e","updated":"2016-11-09 21:33:58.000000000","message":"I\u0027d say \u0027vifs\u0027, just like we use \u0027ports\u0027 or \u0027nodes\u0027. A node can have more than one vif.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"38aa3cf61f2cf53a44c31fce052a0b9c8ac3857a","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Is a corresponding change in the client library and CLI necessary? Yes"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"* As these are new API entry points they will not affect older clients."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Client (CLI) impact"},{"line_number":148,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_1b145b9e","line":145,"in_reply_to":"9a629dbe_8d7915cb","updated":"2016-11-09 16:58:50.000000000","message":"++. Although I don\u0027t know if it is \u0027vif\u0027 or \u0027vifs\u0027, we\u0027re just adding one vif, right?\n\nPOST /v1/nodes/node-ident/vif\nDELETE /v1/nodes/node-ident/vif/vif-id","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"86e0d2215e27dd86b0cfa84173ecc208e0f2b503","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Is a corresponding change in the client library and CLI necessary? Yes"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"* As these are new API entry points they will not affect older clients."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Client (CLI) impact"},{"line_number":148,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_8d7915cb","line":145,"in_reply_to":"9a629dbe_e492d14a","updated":"2016-11-09 16:20:37.000000000","message":"Hm, yeah, these are good points. However I\u0027m not sure any of these suggestions are better. Maybe vif attach. Maybe we could do /nodes/ident/vifs/(attach|detach), or POST(/DELETE) /nodes/ident/vifs(/interface_id). I think I like the last one.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9de73b4fba76552caa916024e6c1a84eed04dda0","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"\"ironic\" CLI"},{"line_number":151,"context_line":"~~~~~~~~~~~~"},{"line_number":152,"context_line":"* ironic node-interface-attach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":153,"context_line":"* ironic node-interface-detach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\"openstack baremetal\" CLI"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5da102_a98ae661","line":152,"updated":"2016-11-03 17:03:09.000000000","message":"what is \u003cinterface_id\u003e? is that the json blob? And if it is the json blob, we might want to be able to allow the input of that via file, \u0027-\u0027 (standard input), or json string. Similar to raid config \u0026 clean steps.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd5e55b3e939e6d2f5c1751dd53981e653883b24","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"\"ironic\" CLI"},{"line_number":151,"context_line":"~~~~~~~~~~~~"},{"line_number":152,"context_line":"* ironic node-interface-attach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":153,"context_line":"* ironic node-interface-detach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\"openstack baremetal\" CLI"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_c405cdc2","line":152,"in_reply_to":"9a629dbe_29a5cf03","updated":"2016-11-08 23:00:48.000000000","message":"Ah, thx for clarifying.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ecb1640213e5600c30c4a83bf7654c2e065c5f6e","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"\"ironic\" CLI"},{"line_number":151,"context_line":"~~~~~~~~~~~~"},{"line_number":152,"context_line":"* ironic node-interface-attach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":153,"context_line":"* ironic node-interface-detach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\"openstack baremetal\" CLI"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_29a5cf03","line":152,"in_reply_to":"ba5da102_a98ae661","updated":"2016-11-07 14:39:14.000000000","message":"Not the JSON blob itself, just a string, representing the interface in someway, in a OpenStack environment that might be a neutron port UUID, in a standalone environment it might be something different. The client should take the ID and build the JSON body with it as it does for other requests.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9de73b4fba76552caa916024e6c1a84eed04dda0","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\"ironic\" CLI"},{"line_number":151,"context_line":"~~~~~~~~~~~~"},{"line_number":152,"context_line":"* ironic node-interface-attach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":153,"context_line":"* ironic node-interface-detach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\"openstack baremetal\" CLI"},{"line_number":156,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5da102_c9d2ba5b","line":153,"updated":"2016-11-03 17:03:09.000000000","message":"ditto","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"38aa3cf61f2cf53a44c31fce052a0b9c8ac3857a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\"ironic\" CLI"},{"line_number":151,"context_line":"~~~~~~~~~~~~"},{"line_number":152,"context_line":"* ironic node-interface-attach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":153,"context_line":"* ironic node-interface-detach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\"openstack baremetal\" CLI"},{"line_number":156,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_dba82323","line":153,"in_reply_to":"9a629dbe_ed537137","updated":"2016-11-09 16:58:50.000000000","message":"+1","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"86e0d2215e27dd86b0cfa84173ecc208e0f2b503","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\"ironic\" CLI"},{"line_number":151,"context_line":"~~~~~~~~~~~~"},{"line_number":152,"context_line":"* ironic node-interface-attach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":153,"context_line":"* ironic node-interface-detach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\"openstack baremetal\" CLI"},{"line_number":156,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_ed537137","line":153,"in_reply_to":"ba5da102_c9d2ba5b","updated":"2016-11-09 16:20:37.000000000","message":"If we change the API, maybe these should be node-vif-(attach|detach) or whatever.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9de73b4fba76552caa916024e6c1a84eed04dda0","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\"openstack baremetal\" CLI"},{"line_number":156,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":157,"context_line":"* openstack baremetal node interface attach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":158,"context_line":"* openstack baremetal node interface detach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"RPC API impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5da102_a9b82612","line":157,"updated":"2016-11-03 17:03:09.000000000","message":"did you manage to find out from nova, what/if they have an equivalent OSC command?","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd5e55b3e939e6d2f5c1751dd53981e653883b24","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\"openstack baremetal\" CLI"},{"line_number":156,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":157,"context_line":"* openstack baremetal node interface attach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":158,"context_line":"* openstack baremetal node interface detach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"RPC API impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_c4d30d37","line":157,"in_reply_to":"9a629dbe_687338b2","updated":"2016-11-08 23:00:48.000000000","message":"what are the commands? \u0027 openstack \u003c what \u003e interface attach\u0027 ? I looked and didn\u0027t see any command with \u0027attach\u0027 but I could have missed it.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"0b73cc3c6cf817f13da5e1bee685f7f03a4646a9","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"\"openstack baremetal\" CLI"},{"line_number":156,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":157,"context_line":"* openstack baremetal node interface attach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":158,"context_line":"* openstack baremetal node interface detach \u003cnode_id\u003e \u003cinterface_id\u003e"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"RPC API impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_687338b2","line":157,"in_reply_to":"ba5da102_a9b82612","updated":"2016-11-07 17:13:30.000000000","message":"Nova has these exact concepts. They map perfectly.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"86e0d2215e27dd86b0cfa84173ecc208e0f2b503","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"nova.virt.driver.IronicDriver.macs_for_instance will be removed because mapping"},{"line_number":192,"context_line":"is handled inside Ironic so mac_address assignment must happen at binding later"},{"line_number":193,"context_line":"in the process."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"nova.virt.driver.IronicDriver.network_binding_host_id will be changed to return"},{"line_number":196,"context_line":"None in all cases, so that neutron ports remain unbound until Ironic binds them"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_7023b6a7","line":193,"updated":"2016-11-09 16:20:37.000000000","message":"Hm, aren\u0027t these used to create the ports for the instance? I guess we can always pass them in the port-update.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"10eb598b1857bcbebdbb626f9206f8fccd63da95","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"nova.virt.driver.IronicDriver.macs_for_instance will be removed because mapping"},{"line_number":192,"context_line":"is handled inside Ironic so mac_address assignment must happen at binding later"},{"line_number":193,"context_line":"in the process."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"nova.virt.driver.IronicDriver.network_binding_host_id will be changed to return"},{"line_number":196,"context_line":"None in all cases, so that neutron ports remain unbound until Ironic binds them"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_78eff9e8","line":193,"in_reply_to":"9a629dbe_7023b6a7","updated":"2016-11-10 13:03:42.000000000","message":"This function currently returns the mac addresses to be used to create the neutron ports, however in some cases the node might not have a port until the vif is attached and they also might want to program the generated mac address onto the physical machines port.\n\nThe current plan is to standardise and leave it up to network interface to override the mac_address with the physical mac_address at port-update if that\u0027s what it needs to do.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9de73b4fba76552caa916024e6c1a84eed04dda0","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"nova driver will need to include the nova compute host ID in the instance_info"},{"line_number":200,"context_line":"so that the ironic flat network interface can use it to update the neutron"},{"line_number":201,"context_line":"ports mimicking the existing nova behavior."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"The nova driver ironic CLI/API version requirement will need to be increased to"},{"line_number":204,"context_line":"the version that implements the attach and detach APIs."}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5da102_a7fbed45","line":201,"updated":"2016-11-03 17:03:09.000000000","message":"I don\u0027t know enough to comment as to whether it would be OK to use ironic\u0027s node.id for this instead of nova\u0027s compute host ID, but it would be nice to decouple ironic from nova. Eg, if it isn\u0027t specified in the instance_info, use node.id?\n\nAlso, what key were you going to use in node.instance_info for the compute host ID? (\u0027host_id\u0027, \u0027binding_host_id\u0027???).","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ecb1640213e5600c30c4a83bf7654c2e065c5f6e","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"nova driver will need to include the nova compute host ID in the instance_info"},{"line_number":200,"context_line":"so that the ironic flat network interface can use it to update the neutron"},{"line_number":201,"context_line":"ports mimicking the existing nova behavior."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"The nova driver ironic CLI/API version requirement will need to be increased to"},{"line_number":204,"context_line":"the version that implements the attach and detach APIs."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_2cca3da2","line":201,"in_reply_to":"ba5da102_a7fbed45","updated":"2016-11-07 14:39:14.000000000","message":"I think this is possible to do, however it won\u0027t maintain the existing functionality (although we want to change it eventually anyway).\n\nRight now in a flat network scenario Nova creates and binds the neutron ports with the same information as it uses for a VM including setting the vnic type to things like vxlan and gre (even though it doesn\u0027t make sense), which results in a successfully bound port, however it doesn\u0027t ever become ACTIVE, because there isn\u0027t a VM to attach it too. Neutron also uses the host id as a reference to call back to nova to make nova aware that the port has been bound, deleted or updated in neutron.\n\nAs part of the multitenancy work we introduced a new vnic type, \"baremetal\" which is specifically designed for handling Ironic ports and for ports with that vnic type we set the host id to the ironic node id, and have custom code in neutron to handle it.\n\nSomething we discussed at the summit was to have the flat network scenario move over to the new vnic type however for that to work we need to have a special ml2 driver that identifies that its a baremetal vnic and a flat network and marks the port bound without doing anything.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"86e0d2215e27dd86b0cfa84173ecc208e0f2b503","unresolved":false,"context_lines":[{"line_number":200,"context_line":"so that the ironic flat network interface can use it to update the neutron"},{"line_number":201,"context_line":"ports mimicking the existing nova behavior."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"The nova driver ironic CLI/API version requirement will need to be increased to"},{"line_number":204,"context_line":"the version that implements the attach and detach APIs."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Ramdisk impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_f05d0616","line":203,"updated":"2016-11-09 16:20:37.000000000","message":"s/CLI/client.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c1f5a5d781e8c8dc0f1510588401ee70e72ea00f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"so that the ironic flat network interface can use it to update the neutron"},{"line_number":201,"context_line":"ports mimicking the existing nova behavior."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"The nova driver ironic CLI/API version requirement will need to be increased to"},{"line_number":204,"context_line":"the version that implements the attach and detach APIs."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Ramdisk impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_b9f60df7","line":203,"in_reply_to":"9a629dbe_191c5969","updated":"2016-11-09 21:38:44.000000000","message":"Yes, that\u0027s true. But I think this section is describing what needs to be changed on the nova side? Maybe it needs two separate sentences, one to mention up\u0027ing the hard-coded ironic API version, and one to mention  that a new client is needed. I forgot how we indicate the client version to nova -- I see it in nova\u0027s test-requirements, and mentioned in release notes.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"66b1e3d7b0a603d56b14c7ea3ff474fa89180afa","unresolved":false,"context_lines":[{"line_number":200,"context_line":"so that the ironic flat network interface can use it to update the neutron"},{"line_number":201,"context_line":"ports mimicking the existing nova behavior."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"The nova driver ironic CLI/API version requirement will need to be increased to"},{"line_number":204,"context_line":"the version that implements the attach and detach APIs."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Ramdisk impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_191c5969","line":203,"in_reply_to":"9a629dbe_dbfae342","updated":"2016-11-09 21:33:58.000000000","message":"We need to update python-ironicclient to know about the new APIs, so yes, we need to update the client and the API version we pin to.","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"38aa3cf61f2cf53a44c31fce052a0b9c8ac3857a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"so that the ironic flat network interface can use it to update the neutron"},{"line_number":201,"context_line":"ports mimicking the existing nova behavior."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"The nova driver ironic CLI/API version requirement will need to be increased to"},{"line_number":204,"context_line":"the version that implements the attach and detach APIs."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Ramdisk impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_dbfae342","line":203,"in_reply_to":"9a629dbe_f05d0616","updated":"2016-11-09 16:58:50.000000000","message":"no, it isn\u0027t the client. it is ironic\u0027s REST API version. Maybe s/CLI// to avoid confusion.\n\n(I mean, it isn\u0027t the version of python-ironicclient.)","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"b702ff64ae3aa96eaa1ed3be9636c95afe93a0db","unresolved":false,"context_lines":[{"line_number":278,"context_line":"added to ensure that the network interfaces will still process a vif_port_id"},{"line_number":279,"context_line":"set via that method."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"As the old vif_port_id field is still support although deprecated, old nova"},{"line_number":282,"context_line":"virt drivers will continue to work using that method."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Ironic must be upgraded before Nova is as newer nova virt drivers won\u0027t work"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa6399be_354cb9c7","line":281,"range":{"start_line":281,"start_character":38,"end_line":281,"end_character":45},"updated":"2016-10-20 17:38:21.000000000","message":"nit: s/support/supported","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"10eb598b1857bcbebdbb626f9206f8fccd63da95","unresolved":false,"context_lines":[{"line_number":278,"context_line":"added to ensure that the network interfaces will still process a vif_port_id"},{"line_number":279,"context_line":"set via that method."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"As the old vif_port_id field is still support although deprecated, old nova"},{"line_number":282,"context_line":"virt drivers will continue to work using that method."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Ironic must be upgraded before Nova is as newer nova virt drivers won\u0027t work"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_ec226ea2","line":281,"range":{"start_line":281,"start_character":38,"end_line":281,"end_character":45},"in_reply_to":"fa6399be_354cb9c7","updated":"2016-11-10 13:03:42.000000000","message":"Done","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"86e0d2215e27dd86b0cfa84173ecc208e0f2b503","unresolved":false,"context_lines":[{"line_number":288,"context_line":"interface_attach and interface_detach methods, so during the period that"},{"line_number":289,"context_line":"vif_port_id is a deprecated method, we should also ensure we provide a default"},{"line_number":290,"context_line":"implementation of attach and detach which will be used in cases where we detect"},{"line_number":291,"context_line":"a NotImplemented error."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"Documentation Impact"},{"line_number":294,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_707f3666","line":291,"updated":"2016-11-09 16:20:37.000000000","message":"What\u0027s this default look like? The \"Driver API\" section says they\u0027ll raise NotImplemented, can you fix that? :)","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"10eb598b1857bcbebdbb626f9206f8fccd63da95","unresolved":false,"context_lines":[{"line_number":288,"context_line":"interface_attach and interface_detach methods, so during the period that"},{"line_number":289,"context_line":"vif_port_id is a deprecated method, we should also ensure we provide a default"},{"line_number":290,"context_line":"implementation of attach and detach which will be used in cases where we detect"},{"line_number":291,"context_line":"a NotImplemented error."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"Documentation Impact"},{"line_number":294,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a629dbe_0c3c02c7","line":291,"in_reply_to":"9a629dbe_707f3666","updated":"2016-11-10 13:03:42.000000000","message":"Done","commit_id":"5e192d41f4d18dd7a60a937f4db814166ae9d64b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4f445d6ce8f2995d37b5b8498600fa621bc6e74f","unresolved":false,"context_lines":[{"line_number":299,"context_line":"implementation of attach and detach which will be used in cases where we detect"},{"line_number":300,"context_line":"a NotImplemented error, this default implementation should match the behaviour"},{"line_number":301,"context_line":"of ironic nova virt driver implementation setting the vif_port_id in port.extra"},{"line_number":302,"context_line":"and will be removed when support for vif_port_id in port.extra is removed."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"Documentation Impact"},{"line_number":305,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a629dbe_11dfb369","line":302,"updated":"2016-11-10 13:20:15.000000000","message":"Well, we aren\u0027t detecting a NotImplemented error, it\u0027s just not overridden, so the default implementation is used.","commit_id":"4ea0cdb48e153e53aa7e19644154e1a2e97c8e53"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cde6029cd88b117366d3ba564f02172bbe06d423","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            \"type\": \"object\","},{"line_number":102,"context_line":"            \"properties\": {"},{"line_number":103,"context_line":"                \"vifs\": {"},{"line_number":104,"context_line":"                    \"description\": \"List of vifs currently attached\""},{"line_number":105,"context_line":"                    \"type\": \"list\""},{"line_number":106,"context_line":"                },"},{"line_number":107,"context_line":"            },"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a629dbe_0f06a71c","line":104,"updated":"2016-11-10 15:05:08.000000000","message":"nit s/vifs/VIF IDs/","commit_id":"748f0a76146fa8da833819ac900267e5725aaeb3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cde6029cd88b117366d3ba564f02172bbe06d423","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    + 409, Conflict between the requested VIF to attach and other VIFs already"},{"line_number":133,"context_line":"      attached"},{"line_number":134,"context_line":"    + 422, The request was good but unable to attach the VIF for a"},{"line_number":135,"context_line":"      defined reason, for example: \"No physical interface\u0027s available to attach"},{"line_number":136,"context_line":"      too\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  - Expected data is a JSON"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a629dbe_8f40f735","line":135,"updated":"2016-11-10 15:05:08.000000000","message":"nit s/interface\u0027s/interfaces/","commit_id":"748f0a76146fa8da833819ac900267e5725aaeb3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cde6029cd88b117366d3ba564f02172bbe06d423","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            \"type\": \"object\","},{"line_number":145,"context_line":"            \"properties\": {"},{"line_number":146,"context_line":"                \"id\": {"},{"line_number":147,"context_line":"                    \"description\": \"ID of interface to attach\""},{"line_number":148,"context_line":"                    \"type\": \"string\""},{"line_number":149,"context_line":"                },"},{"line_number":150,"context_line":"            },"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a629dbe_0f7b078d","line":147,"updated":"2016-11-10 15:05:08.000000000","message":"nit s/interface/VIF/","commit_id":"748f0a76146fa8da833819ac900267e5725aaeb3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cde6029cd88b117366d3ba564f02172bbe06d423","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  - Expected response body is empty"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* v1/nodes/\u003cnode_id\u003e/vifs/\u003cvif_id\u003e"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"  - Calls vif_detach on the network interface for the node, passing in the json"},{"line_number":165,"context_line":"    provided"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a629dbe_4ff6dff9","line":162,"updated":"2016-11-10 15:05:08.000000000","message":"s/v1/DELETE v1/","commit_id":"748f0a76146fa8da833819ac900267e5725aaeb3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cde6029cd88b117366d3ba564f02172bbe06d423","unresolved":false,"context_lines":[{"line_number":162,"context_line":"* v1/nodes/\u003cnode_id\u003e/vifs/\u003cvif_id\u003e"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"  - Calls vif_detach on the network interface for the node, passing in the json"},{"line_number":165,"context_line":"    provided"},{"line_number":166,"context_line":"  - This is a synchronous API endpoint, and the normal ironic rules apply for"},{"line_number":167,"context_line":"    avoiding implementing tasks that take a long time or are unstable under"},{"line_number":168,"context_line":"    synchronous endpoints."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a629dbe_4fcdffb5","line":165,"updated":"2016-11-10 15:05:08.000000000","message":"no json needed here, we have the VIF ID, right?","commit_id":"748f0a76146fa8da833819ac900267e5725aaeb3"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"0d66474a71b1baf9bc5372c687556a2a3f8a1f3a","unresolved":false,"context_lines":[{"line_number":162,"context_line":"* v1/nodes/\u003cnode_id\u003e/vifs/\u003cvif_id\u003e"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"  - Calls vif_detach on the network interface for the node, passing in the json"},{"line_number":165,"context_line":"    provided"},{"line_number":166,"context_line":"  - This is a synchronous API endpoint, and the normal ironic rules apply for"},{"line_number":167,"context_line":"    avoiding implementing tasks that take a long time or are unstable under"},{"line_number":168,"context_line":"    synchronous endpoints."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a629dbe_4f0fbf87","line":165,"in_reply_to":"9a629dbe_4fcdffb5","updated":"2016-11-10 15:09:07.000000000","message":"Correct no json can be passed here anyway, this is left over from previous iterations.","commit_id":"748f0a76146fa8da833819ac900267e5725aaeb3"}]}
