)]}'
{"specs/approved/agent-api.rst":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"4092ec938382c7e7238d6db12449c8b5d00fe137","unresolved":false,"context_lines":[{"line_number":208,"context_line":"Ramdisk impact"},{"line_number":209,"context_line":"--------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"None"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Security impact"},{"line_number":214,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aa78d24_7ddf3a3a","line":211,"updated":"2016-07-11 21:32:47.000000000","message":"Just curious, why is this different from the \"Ramdisk impact\" section in other files?","commit_id":"5e5f5faf4e1b83aa147b33d827d62e612c57728f"}],"specs/approved/cisco-ucs-oob-raid-configuration.rst":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2d1a190af69706c13474bb98ce5c9caf1998ac81","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. NOTE: This section was not present at the time this spec was approved."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Security impact"},{"line_number":110,"context_line":"---------------"},{"line_number":111,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aa78d24_64f7758b","line":108,"updated":"2016-07-06 21:10:23.000000000","message":"done","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"258e3a58c29f8b31afce2d2b491591d2c33d8cbf","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. NOTE: This section was not present at the time this spec was approved."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Security impact"},{"line_number":110,"context_line":"---------------"},{"line_number":111,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_f7eaafab","line":108,"updated":"2016-05-23 22:35:06.000000000","message":"nit; accidentally added an extra line","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"}],"specs/approved/collect-system-logs-from-ipa.rst":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"4092ec938382c7e7238d6db12449c8b5d00fe137","unresolved":false,"context_lines":[{"line_number":209,"context_line":"Ramdisk impact"},{"line_number":210,"context_line":"--------------"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"None"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Security impact"},{"line_number":215,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aa78d24_fdeb2ada","line":212,"updated":"2016-07-11 21:32:47.000000000","message":"Just curious, why is this different from the \"Ramdisk impact\" section of the other files?","commit_id":"5e5f5faf4e1b83aa147b33d827d62e612c57728f"}],"specs/approved/ipxe-swift-tempurls.rst":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2d1a190af69706c13474bb98ce5c9caf1998ac81","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. NOTE: This section was not present at the time this spec was approved."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Security impact"},{"line_number":93,"context_line":"---------------"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aa78d24_042dd1fd","line":91,"updated":"2016-07-06 21:10:23.000000000","message":"done","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"258e3a58c29f8b31afce2d2b491591d2c33d8cbf","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. NOTE: This section was not present at the time this spec was approved."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Security impact"},{"line_number":93,"context_line":"---------------"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_57f73b8c","line":91,"updated":"2016-05-23 22:35:06.000000000","message":"nit; extra line added here","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"}],"specs/approved/nova-compatible-serial-console.rst":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"4092ec938382c7e7238d6db12449c8b5d00fe137","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Ramdisk impact"},{"line_number":138,"context_line":"--------------"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"None"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Security impact"},{"line_number":143,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aa78d24_5dbb5ee5","line":140,"updated":"2016-07-11 21:32:47.000000000","message":"Just curious, why is this different from the \"Ramdisk impact\" section of the other files?","commit_id":"5e5f5faf4e1b83aa147b33d827d62e612c57728f"}],"specs/template.rst":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2d1a190af69706c13474bb98ce5c9caf1998ac81","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"In this section, please describe any changes you expect to make to the"},{"line_number":277,"context_line":"``ironic-python-agent`` or its member classes, to the ramdisk build process, or"},{"line_number":278,"context_line":"that otherwise affect the resulting ramdisk and its contents.  Be mindful of"},{"line_number":279,"context_line":"the downstream impat this may have."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"This could include changes in any of the following:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aa78d24_c4f0e993","line":278,"updated":"2016-07-06 21:10:23.000000000","message":"done","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"db895cf899435a395b426c0e92a409993dcf4546","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"In this section, please describe any changes you expect to make to the"},{"line_number":277,"context_line":"``ironic-python-agent`` or its member classes, to the ramdisk build process, or"},{"line_number":278,"context_line":"that otherwise affect the resulting ramdisk and its contents.  Be mindful of"},{"line_number":279,"context_line":"the downstream impat this may have."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"This could include changes in any of the following:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_bcd64625","line":278,"range":{"start_line":278,"start_character":62,"end_line":278,"end_character":63},"updated":"2016-05-24 03:50:06.000000000","message":"nit:extra space","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2d1a190af69706c13474bb98ce5c9caf1998ac81","unresolved":false,"context_lines":[{"line_number":276,"context_line":"In this section, please describe any changes you expect to make to the"},{"line_number":277,"context_line":"``ironic-python-agent`` or its member classes, to the ramdisk build process, or"},{"line_number":278,"context_line":"that otherwise affect the resulting ramdisk and its contents.  Be mindful of"},{"line_number":279,"context_line":"the downstream impat this may have."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"This could include changes in any of the following:"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aa78d24_a4edddb8","line":279,"updated":"2016-07-06 21:10:23.000000000","message":"done","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d1ed89c02ba42f44a305efc93cb19fe2fc576cf4","unresolved":false,"context_lines":[{"line_number":276,"context_line":"In this section, please describe any changes you expect to make to the"},{"line_number":277,"context_line":"``ironic-python-agent`` or its member classes, to the ramdisk build process, or"},{"line_number":278,"context_line":"that otherwise affect the resulting ramdisk and its contents.  Be mindful of"},{"line_number":279,"context_line":"the downstream impat this may have."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"This could include changes in any of the following:"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_b7f1476d","line":279,"updated":"2016-05-23 22:38:45.000000000","message":"s/impat/impact/","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"550bf78b8ea97fadda2f30f3d2697fded011a900","unresolved":false,"context_lines":[{"line_number":278,"context_line":"that otherwise affect the resulting ramdisk and its contents.  Be mindful of"},{"line_number":279,"context_line":"the downstream impat this may have."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"This could include changes in any of the following:"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"* Are you adding a new ironic-python-agent HardwareManager? This is like adding"},{"line_number":284,"context_line":"  a new driver and should be documented, but will probably be easy to accept."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_0203a10e","line":281,"updated":"2016-05-24 09:20:48.000000000","message":"I think we could expect a mention here when a new extension is added to IPA, a new method is added to an existing extension or an existing method is updated.\n\nFor example, recently a code added a new parameter to an existing method [0]. Ironic was then updated to use that new parameter and it caused new versions of Ironic to be incompatible with old ramdisks it happens and we failed to catch it.\n\n[0] https://review.openstack.org/#/c/284347/","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7e8c9d3a1b079cd9649127679cc69c99c10a807f","unresolved":false,"context_lines":[{"line_number":278,"context_line":"that otherwise affect the resulting ramdisk and its contents.  Be mindful of"},{"line_number":279,"context_line":"the downstream impat this may have."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"This could include changes in any of the following:"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"* Are you adding a new ironic-python-agent HardwareManager? This is like adding"},{"line_number":284,"context_line":"  a new driver and should be documented, but will probably be easy to accept."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_0278c18e","line":281,"in_reply_to":"bab6814e_0203a10e","updated":"2016-05-24 09:22:36.000000000","message":"See https://review.openstack.org/#/c/319183/ as well","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e0a4f47c77e115cffb80a758c97d2d016c0b00a0","unresolved":false,"context_lines":[{"line_number":279,"context_line":"the downstream impat this may have."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"This could include changes in any of the following:"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"* Are you adding a new ironic-python-agent HardwareManager? This is like adding"},{"line_number":284,"context_line":"  a new driver and should be documented, but will probably be easy to accept."},{"line_number":285,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_dcbd03d9","line":282,"updated":"2016-05-24 07:57:24.000000000","message":"The first thing to call out IMO:\n\n* Are you changing an ironic-python-agent API or adding a new extension to the API?","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"550bf78b8ea97fadda2f30f3d2697fded011a900","unresolved":false,"context_lines":[{"line_number":281,"context_line":"This could include changes in any of the following:"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"* Are you adding a new ironic-python-agent HardwareManager? This is like adding"},{"line_number":284,"context_line":"  a new driver and should be documented, but will probably be easy to accept."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"* Are you changing the HardwareManager base class or interface definitions?"},{"line_number":287,"context_line":"  This is considered an API change and needs to be considered closely for"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_5fe622e9","line":284,"range":{"start_line":284,"start_character":41,"end_line":284,"end_character":76},"updated":"2016-05-24 09:20:48.000000000","message":"(thinking out loud here, please Jay correct me if I\u0027m wrong)\n\nNot sure if that\u0027s easy to accept, in reality specific hardware managers are very tied to proprietary tools. E.g both onmetal [0] and proliant [1] have hardware managers out-of-tree because of the dependency on vendor tool/code.\n\n[0] https://github.com/rackerlabs/onmetal-ironic-hardware-manager/tree/master/onmetal_ironic_hardware_manager\n\n[1] https://github.com/openstack/diskimage-builder/tree/master/elements/proliant-tools (see the README)","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"47d2b2b5f2e991c11db583eb71cf09737e732210","unresolved":false,"context_lines":[{"line_number":281,"context_line":"This could include changes in any of the following:"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"* Are you adding a new ironic-python-agent HardwareManager? This is like adding"},{"line_number":284,"context_line":"  a new driver and should be documented, but will probably be easy to accept."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"* Are you changing the HardwareManager base class or interface definitions?"},{"line_number":287,"context_line":"  This is considered an API change and needs to be considered closely for"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_611a5619","line":284,"range":{"start_line":284,"start_character":41,"end_line":284,"end_character":76},"in_reply_to":"bab6814e_5fe622e9","updated":"2016-05-24 14:53:15.000000000","message":"There absolutely are potential places for additional hardware managers, perhaps even having them disabled by default unless enabled explicitly with utilities in the ramdisk. \n\nAlso, I could forsee us supporting open hardware, such as OpenPower, directly in the HWM.\n\nYou\u0027re right that a generic enough hardware manager would be tough to write, as we\u0027ve seen with our GenericHardwareManager and the edges already; but I think it\u0027s something we should think about and encourage people to do more.","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d1ed89c02ba42f44a305efc93cb19fe2fc576cf4","unresolved":false,"context_lines":[{"line_number":287,"context_line":"  This is considered an API change and needs to be considered closely for"},{"line_number":288,"context_line":"  potential impact on downstream users."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"* Are you changing the build process, or proposing a new one."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"* If you are adding any new dependencies, explicitly call them out, and"},{"line_number":293,"context_line":"  indicate any expected change in the size of the resulting ramdisk. This may"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_5701fb38","line":290,"updated":"2016-05-23 22:38:45.000000000","message":"s/./?/","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e0a4f47c77e115cffb80a758c97d2d016c0b00a0","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"* Are you going to make changes to ironic-inspector, or changes that will"},{"line_number":297,"context_line":"  affect it? This is now packaged with the default ramdisk capabilities."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"Security impact"},{"line_number":301,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_3cb36f0c","line":298,"updated":"2016-05-24 07:57:24.000000000","message":"* Are you updating the hardware inventory returned by the hardware manager list_hardware_info?\n\n(this is similar to a section about ironic-inspector but with a bit smaller scope)","commit_id":"1c46f62d231d0390e9688a8a4d3b68603308983c"}]}