)]}'
{"specs/approved/collect-system-logs-from-ipa.rst":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"636364ae24409e09cf1fed25c3a3a733b6ba7c35","unresolved":false,"context_lines":[{"line_number":122,"context_line":"When the logs are collected, Ironic should decode the base64 encoded"},{"line_number":123,"context_line":"tar.gz file and store it according to the ``deploy_logs_storage_backend``"},{"line_number":124,"context_line":"configuration. All log objects will be named with the following pattern:"},{"line_number":125,"context_line":"*\u003cnode-uuid\u003e[_\u003cinstance-uuid\u003e]_\u003ctimestamp yyyy-mm-dd_h:m:s\u003e*.tar.gz. Note"},{"line_number":126,"context_line":"that, ``instance_uuid`` is not a required field for deploying a node when"},{"line_number":127,"context_line":"Ironic is configured to be used in **standalone** mode so, if present"},{"line_number":128,"context_line":"it will be appended to the name."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_35b82411","line":125,"updated":"2016-06-17 14:56:24.000000000","message":"I think the * needs to be moved to after .tar.gz if it\u0027s for formatting :)","commit_id":"151e9f1547189c3e6e8c1154decefce859fc97a9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f1678b2e205550f3c8cc6c6b62259ebb1a256d4c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"When the logs are collected, Ironic should decode the base64 encoded"},{"line_number":123,"context_line":"tar.gz file and store it according to the ``deploy_logs_storage_backend``"},{"line_number":124,"context_line":"configuration. All log objects will be named with the following pattern:"},{"line_number":125,"context_line":"*\u003cnode-uuid\u003e[_\u003cinstance-uuid\u003e]_\u003ctimestamp yyyy-mm-dd_h:m:s\u003e*.tar.gz. Note"},{"line_number":126,"context_line":"that, ``instance_uuid`` is not a required field for deploying a node when"},{"line_number":127,"context_line":"Ironic is configured to be used in **standalone** mode so, if present"},{"line_number":128,"context_line":"it will be appended to the name."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_b5109401","line":125,"in_reply_to":"7aa08908_35b82411","updated":"2016-06-17 14:57:38.000000000","message":"hah good catch!","commit_id":"151e9f1547189c3e6e8c1154decefce859fc97a9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"685943b41f85235ef8e641a46e032ad07167efd3","unresolved":false,"context_lines":[{"line_number":80,"context_line":"New configuration options will be added to Ironic under the ``[agent]``"},{"line_number":81,"context_line":"group:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"#. ``deploy_logs_collect`` (string): Whether Ironic should retrieve"},{"line_number":84,"context_line":"   the deployment logs or not. Valid options are: \"always\", \"on_failure\""},{"line_number":85,"context_line":"   or \"never\". Defaults to \"on_failure\"."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_6507da1c","line":83,"updated":"2016-06-22 21:38:07.000000000","message":"nit s/retrieve/collect/ :)","commit_id":"cb731d507e3c5fd8f4d93fb14d97a18188eedc42"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e8c8346656d22286ad62052536262c87cb9c53f3","unresolved":false,"context_lines":[{"line_number":80,"context_line":"New configuration options will be added to Ironic under the ``[agent]``"},{"line_number":81,"context_line":"group:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"#. ``deploy_logs_collect`` (string): Whether Ironic should retrieve"},{"line_number":84,"context_line":"   the deployment logs or not. Valid options are: \"always\", \"on_failure\""},{"line_number":85,"context_line":"   or \"never\". Defaults to \"on_failure\"."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_63764bd8","line":83,"in_reply_to":"3aaa91ec_6507da1c","updated":"2016-06-24 14:48:18.000000000","message":"Done","commit_id":"cb731d507e3c5fd8f4d93fb14d97a18188eedc42"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"685943b41f85235ef8e641a46e032ad07167efd3","unresolved":false,"context_lines":[{"line_number":122,"context_line":"When the logs are collected, Ironic should decode the base64 encoded"},{"line_number":123,"context_line":"tar.gz file and store it according to the ``deploy_logs_storage_backend``"},{"line_number":124,"context_line":"configuration. All log objects will be named with the following pattern:"},{"line_number":125,"context_line":"*\u003cnode-uuid\u003e[_\u003cinstance-uuid\u003e]_\u003ctimestamp yyyy-mm-dd_h:m:s\u003e.tar.gz*. Note"},{"line_number":126,"context_line":"that, ``instance_uuid`` is not a required field for deploying a node when"},{"line_number":127,"context_line":"Ironic is configured to be used in **standalone** mode so, if present"},{"line_number":128,"context_line":"it will be appended to the name."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_10abb2d7","line":125,"updated":"2016-06-22 21:38:07.000000000","message":"if someone is trying to parse the file name, it may not make sense to use _ as the separator in yyyy-mm-dd_h:m:s; maybe \u0027-\u0027 or \u0027:\u0027 or ??\n\nI was also wondering about using _ as the separator for node/instance, since instance is optional but it isn\u0027t that hard to parse, see that there are 2 parts (so no instance) or 3 parts (so 2nd one is instance). I suppose an alternative is to use the separator regardless, so if no instance you\u0027d have node-uuid__timestamp.","commit_id":"cb731d507e3c5fd8f4d93fb14d97a18188eedc42"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e8c8346656d22286ad62052536262c87cb9c53f3","unresolved":false,"context_lines":[{"line_number":122,"context_line":"When the logs are collected, Ironic should decode the base64 encoded"},{"line_number":123,"context_line":"tar.gz file and store it according to the ``deploy_logs_storage_backend``"},{"line_number":124,"context_line":"configuration. All log objects will be named with the following pattern:"},{"line_number":125,"context_line":"*\u003cnode-uuid\u003e[_\u003cinstance-uuid\u003e]_\u003ctimestamp yyyy-mm-dd_h:m:s\u003e.tar.gz*. Note"},{"line_number":126,"context_line":"that, ``instance_uuid`` is not a required field for deploying a node when"},{"line_number":127,"context_line":"Ironic is configured to be used in **standalone** mode so, if present"},{"line_number":128,"context_line":"it will be appended to the name."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_5e4a0427","line":125,"in_reply_to":"3aaa91ec_10abb2d7","updated":"2016-06-24 14:48:18.000000000","message":"Why it wouldn\u0027t make sense ? That\u0027s the separation between date and time, e.g 2016-09-22_03:20:43. An alternative would be something like 2016/09/22-03:20:43. What do you think?\n\nFor the 2nd paragraph, I believe it will be unique depending on the cloud deployed. For e.g, all clouds deployed with nova will contain the instance uuid. Clouds deploying with ironic standalone can opt to either create a fake instance uuid for the instances or not use instance uuid at all. I think it\u0027s very unlikely to have a mix of both with and without instance uuid as part of the same cloud.","commit_id":"cb731d507e3c5fd8f4d93fb14d97a18188eedc42"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cf797ee8707e9aa506b07e1fc2011a3d7ad58f8f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"When the logs are collected, Ironic should decode the base64 encoded"},{"line_number":123,"context_line":"tar.gz file and store it according to the ``deploy_logs_storage_backend``"},{"line_number":124,"context_line":"configuration. All log objects will be named with the following pattern:"},{"line_number":125,"context_line":"*\u003cnode-uuid\u003e[_\u003cinstance-uuid\u003e]_\u003ctimestamp yyyy-mm-dd_h:m:s\u003e.tar.gz*. Note"},{"line_number":126,"context_line":"that, ``instance_uuid`` is not a required field for deploying a node when"},{"line_number":127,"context_line":"Ironic is configured to be used in **standalone** mode so, if present"},{"line_number":128,"context_line":"it will be appended to the name."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_01256ead","line":125,"in_reply_to":"3aaa91ec_3d6ed096","updated":"2016-06-27 16:06:04.000000000","message":"I will change it to \"YYYY/MM/DD-HH:MM:SS\". Right yeah these files are for troubleshooting and the timestamp is just to have an idea of when the deployment [failure] happened and avoid naming collision.\n\nRe instance uuid, even in the worst case scenario where there\u0027s a mix of files with and w/o instance uuid it\u0027s shouldn\u0027t be hard to create a regex that would parse both cases.","commit_id":"cb731d507e3c5fd8f4d93fb14d97a18188eedc42"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2f7b3e82d5076994731178e2f73aa51e77aa2259","unresolved":false,"context_lines":[{"line_number":122,"context_line":"When the logs are collected, Ironic should decode the base64 encoded"},{"line_number":123,"context_line":"tar.gz file and store it according to the ``deploy_logs_storage_backend``"},{"line_number":124,"context_line":"configuration. All log objects will be named with the following pattern:"},{"line_number":125,"context_line":"*\u003cnode-uuid\u003e[_\u003cinstance-uuid\u003e]_\u003ctimestamp yyyy-mm-dd_h:m:s\u003e.tar.gz*. Note"},{"line_number":126,"context_line":"that, ``instance_uuid`` is not a required field for deploying a node when"},{"line_number":127,"context_line":"Ironic is configured to be used in **standalone** mode so, if present"},{"line_number":128,"context_line":"it will be appended to the name."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_3d6ed096","line":125,"in_reply_to":"3aaa91ec_5e4a0427","updated":"2016-06-27 15:30:50.000000000","message":"Ooo, I like \u00272016/09/22-03:20:43\u0027. Honestly, I don\u0027t know how folks might want to use these files, or if there are existing \u0027standards\u0027 for them.\n\nI don\u0027t have a strong opinion on the node_instance thing. I tend to go with the \u0027avoid potential problem\u0027 approach but what you said makes sense too. It does mean that if someone has two usecases, openstack+ironic, and standalone ironic (don\u0027t ask me why), that their script will have to be a bit different depending on which cluster they are dealing with.","commit_id":"cb731d507e3c5fd8f4d93fb14d97a18188eedc42"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b51f935981548299939592ba4845f2b1a95d2c5d","unresolved":false,"context_lines":[{"line_number":228,"context_line":"Performance Impact"},{"line_number":229,"context_line":"------------------"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"The node will stay a little longer on the ``deploying`` provision state"},{"line_number":232,"context_line":"while IPA is collecting the logs, if enabled."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_b34abac3","line":231,"range":{"start_line":231,"start_character":35,"end_line":231,"end_character":37},"updated":"2016-06-22 15:52:10.000000000","message":"nit:  in\n\n in the ...","commit_id":"cb731d507e3c5fd8f4d93fb14d97a18188eedc42"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e8c8346656d22286ad62052536262c87cb9c53f3","unresolved":false,"context_lines":[{"line_number":228,"context_line":"Performance Impact"},{"line_number":229,"context_line":"------------------"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"The node will stay a little longer on the ``deploying`` provision state"},{"line_number":232,"context_line":"while IPA is collecting the logs, if enabled."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_034ca79c","line":231,"range":{"start_line":231,"start_character":35,"end_line":231,"end_character":37},"in_reply_to":"3aaa91ec_b34abac3","updated":"2016-06-24 14:48:18.000000000","message":"Done","commit_id":"cb731d507e3c5fd8f4d93fb14d97a18188eedc42"}]}