)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ebc237e2cc701527922a5c90409ab1c6f82855fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hironori Shiina \u003cshiina.hironori@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-01 13:48:58 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow-up patch of 75290c72f7c3138bfdab151728718f771dfb9685"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a follow-up patch of 75290c72f7c3138bfdab151728718f771dfb9685"},{"line_number":10,"context_line":"adds explanation about config option [console]terminal."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_5aaf487d","line":7,"updated":"2016-08-02 19:17:11.000000000","message":"Please make this line actually reflect what the change is, rather than just referencing it as a follow-up patch.","commit_id":"8c091c44714699108c457fa59c0b6252efcbfce7"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"35fdcfcc09656dbbdf2cb211e91b9d04cd1d1cc4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hironori Shiina \u003cshiina.hironori@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-01 13:48:58 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow-up patch of 75290c72f7c3138bfdab151728718f771dfb9685"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a follow-up patch of 75290c72f7c3138bfdab151728718f771dfb9685"},{"line_number":10,"context_line":"adds explanation about config option [console]terminal."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_7eeb15b1","line":7,"in_reply_to":"bacf61ea_5aaf487d","updated":"2016-08-03 01:43:23.000000000","message":"Done","commit_id":"8c091c44714699108c457fa59c0b6252efcbfce7"}],"specs/approved/nova-compatible-serial-console.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d1426ea797cff2278505e2320111d500abe75b7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"For example, to use PXE + IPMItool + socat, specify ``pxe_ipmitool_socat``."},{"line_number":165,"context_line":"To use IPA + IPMItool + socat, specify ``agent_ipmitool_socat``."},{"line_number":166,"context_line":"To use existing shellinabox console, deployer doesn\u0027t need to change anything."},{"line_number":167,"context_line":"We will implement new driver interface ``IPMISocatConsole`` initially, so that"},{"line_number":168,"context_line":"just ``pxe_ipmitool_socat`` and ``agent_ipmitool_socat`` drivers will support"},{"line_number":169,"context_line":"socat console. After ``Driver composition reform`` [#]_ is implemented, this"},{"line_number":170,"context_line":"feature will be available for a lot more drivers (or hardware types)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_03f8abc3","line":167,"updated":"2016-07-14 17:11:05.000000000","message":"nit, s/driver/console/\n\nnit, don\u0027t need s/initially//\n\nWell, how about\n\nThe new console interface ``IPMISocatConsole`` will be supported by two new drivers: ``pxe_ipmitool_socat`` and ``agent_ipmitool_socal``. After ...","commit_id":"10d459aaed641473d5bc6068d2f31bad4f140afe"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"db540365d6917d8e11f6998329b393f940722462","unresolved":false,"context_lines":[{"line_number":164,"context_line":"For example, to use PXE + IPMItool + socat, specify ``pxe_ipmitool_socat``."},{"line_number":165,"context_line":"To use IPA + IPMItool + socat, specify ``agent_ipmitool_socat``."},{"line_number":166,"context_line":"To use existing shellinabox console, deployer doesn\u0027t need to change anything."},{"line_number":167,"context_line":"We will implement new driver interface ``IPMISocatConsole`` initially, so that"},{"line_number":168,"context_line":"just ``pxe_ipmitool_socat`` and ``agent_ipmitool_socat`` drivers will support"},{"line_number":169,"context_line":"socat console. After ``Driver composition reform`` [#]_ is implemented, this"},{"line_number":170,"context_line":"feature will be available for a lot more drivers (or hardware types)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_c30e10e4","line":167,"in_reply_to":"1aa78d24_03f8abc3","updated":"2016-08-01 11:25:55.000000000","message":"Done","commit_id":"10d459aaed641473d5bc6068d2f31bad4f140afe"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d1426ea797cff2278505e2320111d500abe75b7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"just ``pxe_ipmitool_socat`` and ``agent_ipmitool_socat`` drivers will support"},{"line_number":169,"context_line":"socat console. After ``Driver composition reform`` [#]_ is implemented, this"},{"line_number":170,"context_line":"feature will be available for a lot more drivers (or hardware types)."},{"line_number":171,"context_line":"About configuration options, existing options ``terminal_pid_dir``,"},{"line_number":172,"context_line":"``subprocess_checking_interval``, ``subprocess_timeout`` are available for"},{"line_number":173,"context_line":"socat in the same way as shellinabox."},{"line_number":174,"context_line":"``terminal_cert_dir`` is not used in the case of socat because SSL is not"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_23ffa7ab","line":171,"updated":"2016-07-14 17:11:05.000000000","message":"Might want to start a new paragraph here (ie, put a blank line before this).","commit_id":"10d459aaed641473d5bc6068d2f31bad4f140afe"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"db540365d6917d8e11f6998329b393f940722462","unresolved":false,"context_lines":[{"line_number":168,"context_line":"just ``pxe_ipmitool_socat`` and ``agent_ipmitool_socat`` drivers will support"},{"line_number":169,"context_line":"socat console. After ``Driver composition reform`` [#]_ is implemented, this"},{"line_number":170,"context_line":"feature will be available for a lot more drivers (or hardware types)."},{"line_number":171,"context_line":"About configuration options, existing options ``terminal_pid_dir``,"},{"line_number":172,"context_line":"``subprocess_checking_interval``, ``subprocess_timeout`` are available for"},{"line_number":173,"context_line":"socat in the same way as shellinabox."},{"line_number":174,"context_line":"``terminal_cert_dir`` is not used in the case of socat because SSL is not"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_a3283c34","line":171,"in_reply_to":"1aa78d24_23ffa7ab","updated":"2016-08-01 11:25:55.000000000","message":"Done","commit_id":"10d459aaed641473d5bc6068d2f31bad4f140afe"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d1426ea797cff2278505e2320111d500abe75b7","unresolved":false,"context_lines":[{"line_number":176,"context_line":"``terminal`` is not used in the case of socat because hard-coded ``socat`` is"},{"line_number":177,"context_line":"used in the code, and absolute path is not needed because it\u0027s distro specific,"},{"line_number":178,"context_line":"in ubuntu for e.g it\u0027s ``/usr/bin/socat``, but in fedora, maybe it\u0027s different"},{"line_number":179,"context_line":"and doesn\u0027t work."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Developer impact"},{"line_number":182,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_c3db434e","line":179,"updated":"2016-07-14 17:11:05.000000000","message":"you mean socat doesn\u0027t work in fedora?\n\nOr do you mean to say \u0027but in fedora, socat may be located in a different path.\u0027\n\nfwiw, I am guessing that this \u0027terminal\u0027 config was added because shellinabox could be located in different paths and it probably wasn\u0027t hooked up so that just invoking \u0027shellinabox\u0027 worked.","commit_id":"10d459aaed641473d5bc6068d2f31bad4f140afe"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"db540365d6917d8e11f6998329b393f940722462","unresolved":false,"context_lines":[{"line_number":176,"context_line":"``terminal`` is not used in the case of socat because hard-coded ``socat`` is"},{"line_number":177,"context_line":"used in the code, and absolute path is not needed because it\u0027s distro specific,"},{"line_number":178,"context_line":"in ubuntu for e.g it\u0027s ``/usr/bin/socat``, but in fedora, maybe it\u0027s different"},{"line_number":179,"context_line":"and doesn\u0027t work."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Developer impact"},{"line_number":182,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_c3af307b","line":179,"in_reply_to":"1aa78d24_c3db434e","updated":"2016-08-01 11:25:55.000000000","message":"No, this mean, in case of fedora, maybe file path of socat is different from Ubuntu\u0027s one. So latter is correct.","commit_id":"10d459aaed641473d5bc6068d2f31bad4f140afe"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"5a22f711b0e0776885602b72a363b43541aac41b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"To use IPA + IPMItool + socat, specify ``agent_ipmitool_socat``."},{"line_number":166,"context_line":"To use existing shellinabox console, deployer doesn\u0027t need to change anything."},{"line_number":167,"context_line":"The new console interface ``IPMISocatConsole`` will be supported by two"},{"line_number":168,"context_line":"new drivers: ``pxe_ipmitool_socat`` and ``agent_ipmitool_socal``."},{"line_number":169,"context_line":"After ``Driver composition reform`` [#]_ is implemented, this"},{"line_number":170,"context_line":"feature will be available for a lot more drivers (or hardware types)."},{"line_number":171,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_fcab83d4","line":168,"range":{"start_line":168,"start_character":61,"end_line":168,"end_character":62},"updated":"2016-08-03 08:04:39.000000000","message":"nit: s/socal/socat/","commit_id":"623b20a1b813ed096ad9a8905bec883f27fabd9e"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"a6bb0bdb1e5634064e35a3ff7df72d2b326fea68","unresolved":false,"context_lines":[{"line_number":165,"context_line":"To use IPA + IPMItool + socat, specify ``agent_ipmitool_socat``."},{"line_number":166,"context_line":"To use existing shellinabox console, deployer doesn\u0027t need to change anything."},{"line_number":167,"context_line":"The new console interface ``IPMISocatConsole`` will be supported by two"},{"line_number":168,"context_line":"new drivers: ``pxe_ipmitool_socat`` and ``agent_ipmitool_socal``."},{"line_number":169,"context_line":"After ``Driver composition reform`` [#]_ is implemented, this"},{"line_number":170,"context_line":"feature will be available for a lot more drivers (or hardware types)."},{"line_number":171,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_5d644648","line":168,"range":{"start_line":168,"start_character":61,"end_line":168,"end_character":62},"in_reply_to":"bacf61ea_fcab83d4","updated":"2016-08-03 09:59:11.000000000","message":"Done","commit_id":"623b20a1b813ed096ad9a8905bec883f27fabd9e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"5a22f711b0e0776885602b72a363b43541aac41b","unresolved":false,"context_lines":[{"line_number":176,"context_line":"supported."},{"line_number":177,"context_line":"``terminal`` is not used in the case of socat because hard-coded ``socat`` is"},{"line_number":178,"context_line":"used in the code, and absolute path is not needed because it\u0027s distro specific,"},{"line_number":179,"context_line":"in ubuntu for e.g it\u0027s ``/usr/bin/socat``, but in fedora, maybe it\u0027s different"},{"line_number":180,"context_line":"and doesn\u0027t work."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Developer impact"},{"line_number":183,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_dc6ddfcd","line":180,"range":{"start_line":179,"start_character":43,"end_line":180,"end_character":16},"updated":"2016-08-03 08:04:39.000000000","message":"As Ruby mentions, it seems a little confusing. How about just writing \u0027but it might be different in another distro.\u0027?","commit_id":"623b20a1b813ed096ad9a8905bec883f27fabd9e"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"a6bb0bdb1e5634064e35a3ff7df72d2b326fea68","unresolved":false,"context_lines":[{"line_number":176,"context_line":"supported."},{"line_number":177,"context_line":"``terminal`` is not used in the case of socat because hard-coded ``socat`` is"},{"line_number":178,"context_line":"used in the code, and absolute path is not needed because it\u0027s distro specific,"},{"line_number":179,"context_line":"in ubuntu for e.g it\u0027s ``/usr/bin/socat``, but in fedora, maybe it\u0027s different"},{"line_number":180,"context_line":"and doesn\u0027t work."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Developer impact"},{"line_number":183,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_7d2aeae8","line":180,"range":{"start_line":179,"start_character":43,"end_line":180,"end_character":16},"in_reply_to":"bacf61ea_dc6ddfcd","updated":"2016-08-03 09:59:11.000000000","message":"Done","commit_id":"623b20a1b813ed096ad9a8905bec883f27fabd9e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"64bc66e97ba5b239dbf4688a9ca4559891dba86c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"supported."},{"line_number":177,"context_line":"``terminal`` is not used in the case of socat because hard-coded ``socat`` is"},{"line_number":178,"context_line":"used in the code, and absolute path is not needed because it\u0027s distro specific,"},{"line_number":179,"context_line":"in ubuntu for e.g it\u0027s ``/usr/bin/socat``, but it might be different in other"},{"line_number":180,"context_line":"distro."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bacf61ea_20974549","line":179,"range":{"start_line":179,"start_character":3,"end_line":179,"end_character":9},"updated":"2016-08-04 22:16:01.000000000","message":"nit: Ubuntu","commit_id":"a12f19a7e621d26f67c9cf689aec030b8a54bccb"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"64bc66e97ba5b239dbf4688a9ca4559891dba86c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"supported."},{"line_number":177,"context_line":"``terminal`` is not used in the case of socat because hard-coded ``socat`` is"},{"line_number":178,"context_line":"used in the code, and absolute path is not needed because it\u0027s distro specific,"},{"line_number":179,"context_line":"in ubuntu for e.g it\u0027s ``/usr/bin/socat``, but it might be different in other"},{"line_number":180,"context_line":"distro."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bacf61ea_80955134","line":179,"range":{"start_line":179,"start_character":14,"end_line":179,"end_character":17},"updated":"2016-08-04 22:16:01.000000000","message":"s/e.g./example/","commit_id":"a12f19a7e621d26f67c9cf689aec030b8a54bccb"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"52235ed1ce2bec70d6e82ae143e5d3b9a3e6d2fa","unresolved":false,"context_lines":[{"line_number":176,"context_line":"supported."},{"line_number":177,"context_line":"``terminal`` is not used in the case of socat because hard-coded ``socat`` is"},{"line_number":178,"context_line":"used in the code, and absolute path is not needed because it\u0027s distro specific,"},{"line_number":179,"context_line":"in ubuntu for e.g it\u0027s ``/usr/bin/socat``, but it might be different in other"},{"line_number":180,"context_line":"distro."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ad45d7e_6251ce62","line":179,"range":{"start_line":179,"start_character":3,"end_line":179,"end_character":9},"in_reply_to":"bacf61ea_20974549","updated":"2016-08-08 14:29:53.000000000","message":"Done","commit_id":"a12f19a7e621d26f67c9cf689aec030b8a54bccb"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"52235ed1ce2bec70d6e82ae143e5d3b9a3e6d2fa","unresolved":false,"context_lines":[{"line_number":176,"context_line":"supported."},{"line_number":177,"context_line":"``terminal`` is not used in the case of socat because hard-coded ``socat`` is"},{"line_number":178,"context_line":"used in the code, and absolute path is not needed because it\u0027s distro specific,"},{"line_number":179,"context_line":"in ubuntu for e.g it\u0027s ``/usr/bin/socat``, but it might be different in other"},{"line_number":180,"context_line":"distro."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ad45d7e_a24bc6af","line":179,"range":{"start_line":179,"start_character":14,"end_line":179,"end_character":17},"in_reply_to":"bacf61ea_80955134","updated":"2016-08-08 14:29:53.000000000","message":"Done","commit_id":"a12f19a7e621d26f67c9cf689aec030b8a54bccb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f68daaf8afa9f849e4330bf3ecadf63a3619f0b6","unresolved":false,"context_lines":[{"line_number":177,"context_line":"``terminal`` is not used in the case of socat because hard-coded ``socat`` is"},{"line_number":178,"context_line":"used in the code, and absolute path is not needed because it\u0027s distro specific,"},{"line_number":179,"context_line":"in ubuntu for e.g it\u0027s ``/usr/bin/socat``, but it might be different in other"},{"line_number":180,"context_line":"distro."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Developer impact"},{"line_number":183,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bacf61ea_9607a2c8","line":180,"updated":"2016-08-03 17:48:38.000000000","message":"We need to ensure these config documentation hints make it into the release notes when the code is landed too.","commit_id":"a12f19a7e621d26f67c9cf689aec030b8a54bccb"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"64bc66e97ba5b239dbf4688a9ca4559891dba86c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"``terminal`` is not used in the case of socat because hard-coded ``socat`` is"},{"line_number":178,"context_line":"used in the code, and absolute path is not needed because it\u0027s distro specific,"},{"line_number":179,"context_line":"in ubuntu for e.g it\u0027s ``/usr/bin/socat``, but it might be different in other"},{"line_number":180,"context_line":"distro."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Developer impact"},{"line_number":183,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bacf61ea_a0897528","line":180,"range":{"start_line":180,"start_character":0,"end_line":180,"end_character":6},"updated":"2016-08-04 22:16:01.000000000","message":"nit: distros or distributions","commit_id":"a12f19a7e621d26f67c9cf689aec030b8a54bccb"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"52235ed1ce2bec70d6e82ae143e5d3b9a3e6d2fa","unresolved":false,"context_lines":[{"line_number":177,"context_line":"``terminal`` is not used in the case of socat because hard-coded ``socat`` is"},{"line_number":178,"context_line":"used in the code, and absolute path is not needed because it\u0027s distro specific,"},{"line_number":179,"context_line":"in ubuntu for e.g it\u0027s ``/usr/bin/socat``, but it might be different in other"},{"line_number":180,"context_line":"distro."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Developer impact"},{"line_number":183,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ad45d7e_42e80a7d","line":180,"range":{"start_line":180,"start_character":0,"end_line":180,"end_character":6},"in_reply_to":"bacf61ea_a0897528","updated":"2016-08-08 14:29:53.000000000","message":"Done","commit_id":"a12f19a7e621d26f67c9cf689aec030b8a54bccb"}]}
