)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ac00a39374bbfe6a32ef2d202869cc192423887","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-10 09:40:31 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new capabilities to ironic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes to add few more capabilities"},{"line_number":10,"context_line":"which can be implemented inband or out-of-band"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a629dbe_156cec9a","line":7,"updated":"2016-11-10 19:39:21.000000000","message":"I would really like the commit subject to indicate that this is targeted at the iLO driver.","commit_id":"1e17b0726b77c945ba64187af7905b512aeefd08"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"320de585a7c8b8c36f2a745b693980ac825bfb96","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-10 09:40:31 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new capabilities to ironic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes to add few more capabilities"},{"line_number":10,"context_line":"which can be implemented inband or out-of-band"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a629dbe_16a90de0","line":7,"in_reply_to":"9a629dbe_156cec9a","updated":"2016-11-14 04:13:11.000000000","message":"Dmitry and jroll wants the spec to be generic. I have proposed the generic spec which helps in standardizing the capabilities. Any driver can implement them after the capabilities are finalized and approved. The ilo drivers will implement them out-of-band, other drivers may implement them  inband.","commit_id":"1e17b0726b77c945ba64187af7905b512aeefd08"}],"specs/approved/add-new-oob-properties-to-ilo-drivers.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"17e0bf01dee1ea6e45ad0904c0fca85fb5b000c0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    capability name : max_rotational_drive_rpm"},{"line_number":53,"context_line":"    possible values : Integer value"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    capability name : raid_level"},{"line_number":56,"context_line":"    possible values : current raid level configured"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    capability name : cpu_vt"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_6bc89d75","line":55,"range":{"start_line":55,"start_character":22,"end_line":55,"end_character":32},"updated":"2016-07-27 14:21:20.000000000","message":"s/raid_level/hardware_raid_level/, that is if it is detectable in a generic sense.","commit_id":"a3b0b35e7a44ccfb2115b8cc49511a0c4f5c8841"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a68084645c6113a56b78d6eb3f3842d997301db2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    capability name : max_rotational_drive_rpm"},{"line_number":53,"context_line":"    possible values : Integer value"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    capability name : raid_level"},{"line_number":56,"context_line":"    possible values : current raid level configured"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    capability name : cpu_vt"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_6115dc47","line":55,"range":{"start_line":55,"start_character":22,"end_line":55,"end_character":32},"in_reply_to":"bacf61ea_6bc89d75","updated":"2016-07-29 16:40:43.000000000","message":"We can get raid levels OOB for all the logical volumes configured on the system. I will rename the capability as logical_raid_level_\u003cnum\u003e where num can start from 1.\n\nSo, ideally it may look like logical_raid_level_1 \u003d 0, logical_raid_level_2 \u003d 5, etc. on a system with raid levels 0 and 5 configured.","commit_id":"a3b0b35e7a44ccfb2115b8cc49511a0c4f5c8841"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"17e0bf01dee1ea6e45ad0904c0fca85fb5b000c0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    capability name : cpu_vt"},{"line_number":59,"context_line":"    possible values : Enabled|Disabled"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    capability name : controller_\u003cnum\u003e"},{"line_number":62,"context_line":"    possible values : Vary from hardware to hardware"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"},{"line_number":65,"context_line":"as the hardware can have both kind of drives attached. The capability"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_8b3071a0","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":52},"updated":"2016-07-27 14:21:20.000000000","message":"What exactly is the intended use of this field?  Maybe at least some examples if some of the data is to relate to other data?","commit_id":"a3b0b35e7a44ccfb2115b8cc49511a0c4f5c8841"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a68084645c6113a56b78d6eb3f3842d997301db2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    capability name : cpu_vt"},{"line_number":59,"context_line":"    possible values : Enabled|Disabled"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    capability name : controller_\u003cnum\u003e"},{"line_number":62,"context_line":"    possible values : Vary from hardware to hardware"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"},{"line_number":65,"context_line":"as the hardware can have both kind of drives attached. The capability"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_4c844f5d","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":52},"in_reply_to":"bacf61ea_8b3071a0","updated":"2016-07-29 16:40:43.000000000","message":"The value will look like:\n{\u0027controller_1\u0027: u\u0027HP Smart Array P244br Controller in Slot 0\u0027}\n\nSo if there are multiple controllers attached, it will be named as controller_1, controller_2, etc.\n\nThis capability is required for hardware disk erase.","commit_id":"a3b0b35e7a44ccfb2115b8cc49511a0c4f5c8841"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"17e0bf01dee1ea6e45ad0904c0fca85fb5b000c0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"There are other changes which would be required for supporting few"},{"line_number":70,"context_line":"of the above properties."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Since the boot_mode_* properties deal with the boot mode of the"},{"line_number":73,"context_line":"  server the ilo drivers would need to read them from instance_info and"},{"line_number":74,"context_line":"  take an appropriate action."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Alternatives"},{"line_number":77,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_ebe64de7","line":74,"range":{"start_line":72,"start_character":2,"end_line":74,"end_character":29},"updated":"2016-07-27 14:21:20.000000000","message":"Wouldn\u0027t this be the presentation of the current state?  Would the ilo drivers be making automatic changes to the values and configuration?  I\u0027m really not sure why this is being mentioned.","commit_id":"a3b0b35e7a44ccfb2115b8cc49511a0c4f5c8841"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a68084645c6113a56b78d6eb3f3842d997301db2","unresolved":false,"context_lines":[{"line_number":69,"context_line":"There are other changes which would be required for supporting few"},{"line_number":70,"context_line":"of the above properties."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Since the boot_mode_* properties deal with the boot mode of the"},{"line_number":73,"context_line":"  server the ilo drivers would need to read them from instance_info and"},{"line_number":74,"context_line":"  take an appropriate action."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Alternatives"},{"line_number":77,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_ec8ee3ce","line":74,"range":{"start_line":72,"start_character":2,"end_line":74,"end_character":29},"in_reply_to":"bacf61ea_ebe64de7","updated":"2016-07-29 16:40:43.000000000","message":"Actually the boot_mode capability has to be manually configured on the node and the node selection from nova depeneds on the value of boot_mode.\nSo for ex: system supports both uefi and bios, but the boot_mode is set as BIOS the operator cannot get the node selected for uefi provisioning as boot_mode can have only one value.\n\nNow when we have these two additional capabilities populated in instance_info, the proposed logic is :\nIf ‘boot_mode_uefi’:\n   Use ‘uefi’\nElse if ‘boot_mode_bios’:\n  Use ‘bios’\nElse if ‘boot_mode’:\n  Use boot_mode\nElse\n  Use ‘default_boot_mode’","commit_id":"a3b0b35e7a44ccfb2115b8cc49511a0c4f5c8841"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"204e45eb203ca66bd5fcb26a81a618eff32338cb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"There are other changes which would be required for supporting few"},{"line_number":70,"context_line":"of the above properties."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Since the boot_mode_* properties deal with the boot mode of the"},{"line_number":73,"context_line":"  server the ilo drivers would need to read them from instance_info and"},{"line_number":74,"context_line":"  take an appropriate action."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Alternatives"},{"line_number":77,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_f5c21884","line":74,"range":{"start_line":72,"start_character":2,"end_line":74,"end_character":29},"in_reply_to":"bacf61ea_ec8ee3ce","updated":"2016-11-10 19:26:31.000000000","message":"Thank you for clarifying that these boot_mode capability settings would be capabilities based.","commit_id":"a3b0b35e7a44ccfb2115b8cc49511a0c4f5c8841"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"17e0bf01dee1ea6e45ad0904c0fca85fb5b000c0","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"- The new properties which would be added as part of this spec."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"- The nova flavor samples how these properties can be used in creation"},{"line_number":198,"context_line":"  of required nova flavors."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"References"},{"line_number":201,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_4b4b19b1","line":198,"range":{"start_line":197,"start_character":0,"end_line":198,"end_character":27},"updated":"2016-07-27 14:21:20.000000000","message":"It seems like many of these parameters would be generic, and thus be documented in main documentation, not a specific driver\u0027s documentation.","commit_id":"a3b0b35e7a44ccfb2115b8cc49511a0c4f5c8841"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a68084645c6113a56b78d6eb3f3842d997301db2","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"- The new properties which would be added as part of this spec."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"- The nova flavor samples how these properties can be used in creation"},{"line_number":198,"context_line":"  of required nova flavors."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"References"},{"line_number":201,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_ac5d0b49","line":198,"range":{"start_line":197,"start_character":0,"end_line":198,"end_character":27},"in_reply_to":"bacf61ea_4b4b19b1","updated":"2016-07-29 16:40:43.000000000","message":"But they will be discovered only for iLO drivers and hence should be under ilo documentation. If other drivers implement them, then it can move to generic documentation at that time.","commit_id":"a3b0b35e7a44ccfb2115b8cc49511a0c4f5c8841"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"204e45eb203ca66bd5fcb26a81a618eff32338cb","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"- The new properties which would be added as part of this spec."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"- The nova flavor samples how these properties can be used in creation"},{"line_number":198,"context_line":"  of required nova flavors."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"References"},{"line_number":201,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_757a8889","line":198,"range":{"start_line":197,"start_character":0,"end_line":198,"end_character":27},"in_reply_to":"bacf61ea_ac5d0b49","updated":"2016-11-10 19:26:31.000000000","message":"But you are setting a semi-generic cross driver standard by it being in one driver, should another driver adopt the same pattern.","commit_id":"a3b0b35e7a44ccfb2115b8cc49511a0c4f5c8841"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ac00a39374bbfe6a32ef2d202869cc192423887","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1599425"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec adds few more capabilities to ironic drivers."},{"line_number":14,"context_line":"The capabilities can be implemented in-band or out-of-band"},{"line_number":15,"context_line":"as per driver wish."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_15db0c1c","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":55},"updated":"2016-11-10 19:39:21.000000000","message":"This should detail that this is iLO drivers.","commit_id":"1e17b0726b77c945ba64187af7905b512aeefd08"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"320de585a7c8b8c36f2a745b693980ac825bfb96","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1599425"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec adds few more capabilities to ironic drivers."},{"line_number":14,"context_line":"The capabilities can be implemented in-band or out-of-band"},{"line_number":15,"context_line":"as per driver wish."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_5692a5a0","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":55},"in_reply_to":"9a629dbe_15db0c1c","updated":"2016-11-14 04:13:11.000000000","message":"DOne as suggested by Dmitry and jroll","commit_id":"1e17b0726b77c945ba64187af7905b512aeefd08"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ac00a39374bbfe6a32ef2d202869cc192423887","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The operator may be interested to schedule and select the hardware"},{"line_number":21,"context_line":"based on many other hardware properties like cpu_vt, trusted_boot,"},{"line_number":22,"context_line":"etc."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_75a7e8bc","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":13},"updated":"2016-11-10 19:39:21.000000000","message":"nit: The operator would be interested in offering and a user would be interested in scheduling.  The operator wouldn\u0027t necessarily be making both decisions unless it is in a stand-alone mode.","commit_id":"1e17b0726b77c945ba64187af7905b512aeefd08"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"320de585a7c8b8c36f2a745b693980ac825bfb96","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The operator may be interested to schedule and select the hardware"},{"line_number":21,"context_line":"based on many other hardware properties like cpu_vt, trusted_boot,"},{"line_number":22,"context_line":"etc."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_768fa975","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":13},"in_reply_to":"9a629dbe_75a7e8bc","updated":"2016-11-14 04:13:11.000000000","message":"ok will change it to user","commit_id":"1e17b0726b77c945ba64187af7905b512aeefd08"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ac00a39374bbfe6a32ef2d202869cc192423887","unresolved":false,"context_lines":[{"line_number":183,"context_line":"Work Items"},{"line_number":184,"context_line":"----------"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"* To add the above capabilities to the inspection."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Dependencies"},{"line_number":189,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_b59b4065","line":186,"updated":"2016-11-10 19:39:21.000000000","message":"1) Please highlight that this is explicitly in the iLO driver.\n2) Documentation, in this case, must be work item.  Since this would essentially set a standard for other drivers to adopt and users to schedule.","commit_id":"1e17b0726b77c945ba64187af7905b512aeefd08"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"320de585a7c8b8c36f2a745b693980ac825bfb96","unresolved":false,"context_lines":[{"line_number":183,"context_line":"Work Items"},{"line_number":184,"context_line":"----------"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"* To add the above capabilities to the inspection."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Dependencies"},{"line_number":189,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_968c3d81","line":186,"in_reply_to":"9a629dbe_b59b4065","updated":"2016-11-14 04:13:11.000000000","message":"Ok will add that as work item.","commit_id":"1e17b0726b77c945ba64187af7905b512aeefd08"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Following properties will be discovered::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    capability name: trusted_boot"},{"line_number":30,"context_line":"    possible values: True|False"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    capability name: iscsi_boot"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_c69cb55f","line":29,"updated":"2016-11-27 11:39:15.000000000","message":"is it \"supports trusted boot\" or \"set up to use trusted boot\"?","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Following properties will be discovered::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    capability name: trusted_boot"},{"line_number":30,"context_line":"    possible values: True|False"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    capability name: iscsi_boot"},{"line_number":33,"context_line":"    possible values: True|False"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_e6a531a2","line":30,"updated":"2016-11-27 11:39:15.000000000","message":"we use lower case true|false currently, please change it everywhere","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    capability name: trusted_boot"},{"line_number":30,"context_line":"    possible values: True|False"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    capability name: iscsi_boot"},{"line_number":33,"context_line":"    possible values: True|False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    capability name : boot_mode_uefi"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_06a30d9e","line":32,"updated":"2016-11-27 11:39:15.000000000","message":"please elaborate on this one","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    possible values: True|False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    capability name : boot_mode_uefi"},{"line_number":36,"context_line":"    possible values : True|False"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    capability name : boot_mode_bios"},{"line_number":39,"context_line":"    possible values : True|False"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_26ac898b","line":36,"updated":"2016-11-27 11:39:15.000000000","message":"it is supported boot mode or current boot mode? ironic-inspector already dedects current boot mode under boot_mode name. So if it\u0027s current boot mode, please rename to the same.","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    capability name : sriov_enabled"},{"line_number":42,"context_line":"    possible values : True|False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    capability name : iscsi_iqn"},{"line_number":45,"context_line":"    possible values : vary from hardware to hardware"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    capability_name : drive_ssd"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_46a9857a","line":44,"updated":"2016-11-27 11:39:15.000000000","message":"please elaborate on this one","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    possible values : Integer value"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    capability name : logical_raid_level_\u003cnum\u003e"},{"line_number":57,"context_line":"    possible values : current raid levels configured"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    capability name : cpu_vt"},{"line_number":60,"context_line":"    possible values : Enabled|Disabled"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_66b841c9","line":57,"updated":"2016-11-27 11:39:15.000000000","message":"please provide an example, it\u0027s not clear how it is going to be used","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    possible values : current raid levels configured"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    capability name : cpu_vt"},{"line_number":60,"context_line":"    possible values : Enabled|Disabled"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    capability name : controller_\u003cnum\u003e"},{"line_number":63,"context_line":"    possible values : Vary from hardware to hardware"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_86bd5db9","line":60,"updated":"2016-11-27 11:39:15.000000000","message":"true|false","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    possible values : Enabled|Disabled"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    capability name : controller_\u003cnum\u003e"},{"line_number":63,"context_line":"    possible values : Vary from hardware to hardware"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    capability name : raid_capable"},{"line_number":66,"context_line":"    possible values : True|False"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_a6aed97e","line":63,"updated":"2016-11-27 11:39:15.000000000","message":"please elaborate on this one","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    capability name : hardware_disk_erase_capable"},{"line_number":69,"context_line":"    possible values : True|False"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    capability name : \u003cvendor\u003e_gpu_count"},{"line_number":72,"context_line":"    possible values : Numeric count"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    capability name : gpu_vendor_\u003cvendor\u003e_id"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_c6b3d5e7","line":71,"updated":"2016-11-27 11:39:15.000000000","message":"what is \"vendor\" here? why not just use gpu_count?","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":81,"context_line":"as the hardware can have both kind of drives attached. The capability"},{"line_number":82,"context_line":"``controller_\u003cnum\u003e`` has `num` as dynamic number as there can be"},{"line_number":83,"context_line":"multiple controllers attached to the server. This capability will"},{"line_number":84,"context_line":"contain the value like `HP Smart Array P244br Controller in Slot 0`."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"The capabilities ``logical_raid_level_\u003cnum\u003e`` will have \"num\""},{"line_number":87,"context_line":"as the dynamic number and will have names as ``logical_raid_level_1``,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_e6cc516c","line":84,"updated":"2016-11-27 11:39:15.000000000","message":"please move explanations to under each value (also it\u0027s still unclear what \"controller\" here means generally)","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"The capabilities ``logical_raid_level_\u003cnum\u003e`` will have \"num\""},{"line_number":87,"context_line":"as the dynamic number and will have names as ``logical_raid_level_1``,"},{"line_number":88,"context_line":"``logical_raid_level_2``, and so on."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The capabilities ``boot_mode_*`` are added as a hardware could be"},{"line_number":91,"context_line":"supporting both bios and uefi and the current capability ``boot_mode``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_06ca2d4e","line":88,"updated":"2016-11-27 11:39:15.000000000","message":"see above - it\u0027s unclear what value is","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cc2baf11410f6e3ed103e3435a0d09fd4c2febe","unresolved":false,"context_lines":[{"line_number":88,"context_line":"``logical_raid_level_2``, and so on."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The capabilities ``boot_mode_*`` are added as a hardware could be"},{"line_number":91,"context_line":"supporting both bios and uefi and the current capability ``boot_mode``"},{"line_number":92,"context_line":"can accept only one value. The drivers would need to adjust the"},{"line_number":93,"context_line":"deploy behaviour when the new capabilities ``boot_mode_bios`` or"},{"line_number":94,"context_line":"``boot_mode_uefi`` are given in nova flavor. The changes required"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a74a57a_26c3a939","line":91,"updated":"2016-11-27 11:39:15.000000000","message":"boot_mode is the current (or requested) boot mode, so maybe we need supports_uefi\u003dtrue or something like that","commit_id":"1294551d0709253eacd670aded5fd9789a376a73"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b9c987b833188e6c25b8ee42ec4594103833b468","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec adds few more capabilities to ironic drivers."},{"line_number":14,"context_line":"The capabilities can be implemented in-band or out-of-band"},{"line_number":15,"context_line":"as per driver wish."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da4df55a_1e0afed2","line":15,"range":{"start_line":15,"start_character":7,"end_line":15,"end_character":13},"updated":"2016-12-22 10:09:16.000000000","message":"driver maintainer\u0027s wish :)","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b9c987b833188e6c25b8ee42ec4594103833b468","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    capability_name : drive_rotational"},{"line_number":60,"context_line":"    possible_values : true|false"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    capability name : max_rotational_drive_rpm"},{"line_number":63,"context_line":"    possible values : Integer value"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    capability name : logical_raid_level_\u003cnum\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da4df55a_5eb006f5","line":62,"range":{"start_line":62,"start_character":22,"end_line":62,"end_character":46},"updated":"2016-12-22 10:09:16.000000000","message":"rotational_drive_max_rpm","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b9c987b833188e6c25b8ee42ec4594103833b468","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    possible values : Integer value"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    capability name : logical_raid_level_\u003cnum\u003e"},{"line_number":66,"context_line":"    possible values : current raid levels configured"},{"line_number":67,"context_line":"    explanation     : The capabilities ``logical_raid_level_\u003cnum\u003e``"},{"line_number":68,"context_line":"                      will have \"num\" as the dynamic number and"},{"line_number":69,"context_line":"                      will have names as ``logical_raid_level_1``,"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da4df55a_bec49240","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":52},"updated":"2016-12-22 10:09:16.000000000","message":"The values for this are true|false too right?","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"34d2dbb6455a076d14c6b96a7e8850fbe744d6a6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    possible values : Integer value"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    capability name : logical_raid_level_\u003cnum\u003e"},{"line_number":66,"context_line":"    possible values : current raid levels configured"},{"line_number":67,"context_line":"    explanation     : The capabilities ``logical_raid_level_\u003cnum\u003e``"},{"line_number":68,"context_line":"                      will have \"num\" as the dynamic number and"},{"line_number":69,"context_line":"                      will have names as ``logical_raid_level_1``,"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5201f7_0cefd687","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":52},"in_reply_to":"da4df55a_bec49240","updated":"2017-01-04 17:11:58.000000000","message":"No. It will have the raid level configured as its values.","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b9c987b833188e6c25b8ee42ec4594103833b468","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                      gives flexibility to the operator to choose a"},{"line_number":73,"context_line":"                      hardware which has the desired raid configured."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    capability name : cpu_vt"},{"line_number":76,"context_line":"    possible values : true|false"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    capability name : controller_\u003cnum\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da4df55a_5e9e4657","line":75,"range":{"start_line":75,"start_character":22,"end_line":75,"end_character":28},"updated":"2016-12-22 10:09:16.000000000","message":"Could you elaborate on this?","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"34d2dbb6455a076d14c6b96a7e8850fbe744d6a6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                      gives flexibility to the operator to choose a"},{"line_number":73,"context_line":"                      hardware which has the desired raid configured."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    capability name : cpu_vt"},{"line_number":76,"context_line":"    possible values : true|false"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    capability name : controller_\u003cnum\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5201f7_acfeca35","line":75,"range":{"start_line":75,"start_character":22,"end_line":75,"end_character":28},"in_reply_to":"da4df55a_5e9e4657","updated":"2017-01-04 17:11:58.000000000","message":"Its same as what inspector already has.","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b9c987b833188e6c25b8ee42ec4594103833b468","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                      This capability will contain the value like"},{"line_number":83,"context_line":"                      `HP Smart Array P244br Controller in Slot 0`."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    capability name : raid_capable"},{"line_number":86,"context_line":"    possible values : true|false"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    capability name : hardware_disk_erase_capable"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da4df55a_fe2a9ae6","line":85,"range":{"start_line":85,"start_character":22,"end_line":85,"end_character":34},"updated":"2016-12-22 10:09:16.000000000","message":"I\u0027d prefer hardware_raid_capable, as there also is software raid","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"34d2dbb6455a076d14c6b96a7e8850fbe744d6a6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                      This capability will contain the value like"},{"line_number":83,"context_line":"                      `HP Smart Array P244br Controller in Slot 0`."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    capability name : raid_capable"},{"line_number":86,"context_line":"    possible values : true|false"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    capability name : hardware_disk_erase_capable"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5201f7_4ca0fe43","line":85,"range":{"start_line":85,"start_character":22,"end_line":85,"end_character":34},"in_reply_to":"da4df55a_fe2a9ae6","updated":"2017-01-04 17:11:58.000000000","message":"ok.","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b9c987b833188e6c25b8ee42ec4594103833b468","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    capability name : raid_capable"},{"line_number":86,"context_line":"    possible values : true|false"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    capability name : hardware_disk_erase_capable"},{"line_number":89,"context_line":"    possible values : true|false"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    capability name : \u003cvendor\u003e_gpu_count"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da4df55a_de46b6be","line":88,"range":{"start_line":88,"start_character":22,"end_line":88,"end_character":49},"updated":"2016-12-22 10:09:16.000000000","message":"What does this mean?","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b9c987b833188e6c25b8ee42ec4594103833b468","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    capability name : hardware_disk_erase_capable"},{"line_number":89,"context_line":"    possible values : true|false"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    capability name : \u003cvendor\u003e_gpu_count"},{"line_number":92,"context_line":"    possible values : Numeric count"},{"line_number":93,"context_line":"    explanation     : There can be GPU cards from different"},{"line_number":94,"context_line":"                      vendors like NVIDIA, AMD etc."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    capability name : gpu_vendor_id_for_vendor_\u003cvendor\u003e"},{"line_number":97,"context_line":"    possible values : vary from vendor to vendor"},{"line_number":98,"context_line":"                      Example: vendor ID for NVIDIA can be 0x10b5."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    capability name : gpu_product_id_for_vendor_\u003cvendor\u003e"},{"line_number":101,"context_line":"    possible values : vary from hardware to hardware"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"},{"line_number":104,"context_line":"as the hardware can have both kind of drives attached."}],"source_content_type":"text/x-rst","patch_set":9,"id":"da4df55a_fe629a15","line":101,"range":{"start_line":91,"start_character":4,"end_line":101,"end_character":52},"updated":"2016-12-22 10:09:16.000000000","message":"Are these and controller_\u003cnum\u003e really capabilities? In my understanding, capabilities should be only true/false, as the traits (basically new names for capabilities on the nova side) will be implemented this way.\n\nThese can be encoded in the resource_class name, e.g. baremetal_platinum can mean that the node has 3 nvidia GPUs with 2 smart array controllers.","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"34d2dbb6455a076d14c6b96a7e8850fbe744d6a6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    capability name : hardware_disk_erase_capable"},{"line_number":89,"context_line":"    possible values : true|false"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    capability name : \u003cvendor\u003e_gpu_count"},{"line_number":92,"context_line":"    possible values : Numeric count"},{"line_number":93,"context_line":"    explanation     : There can be GPU cards from different"},{"line_number":94,"context_line":"                      vendors like NVIDIA, AMD etc."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    capability name : gpu_vendor_id_for_vendor_\u003cvendor\u003e"},{"line_number":97,"context_line":"    possible values : vary from vendor to vendor"},{"line_number":98,"context_line":"                      Example: vendor ID for NVIDIA can be 0x10b5."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    capability name : gpu_product_id_for_vendor_\u003cvendor\u003e"},{"line_number":101,"context_line":"    possible values : vary from hardware to hardware"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"},{"line_number":104,"context_line":"as the hardware can have both kind of drives attached."}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5201f7_4c6e3e02","line":101,"range":{"start_line":91,"start_character":4,"end_line":101,"end_character":52},"in_reply_to":"da4df55a_fe629a15","updated":"2017-01-04 17:11:58.000000000","message":"Yes these are capabilities in my opinion as of now.\nI didn\u0027t get your explanation and example.","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"37d726a8cfbbc6dd00b9f3afa1543de1c45e4db2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"supporting both bios and uefi and the current capability ``boot_mode``"},{"line_number":108,"context_line":"can accept only one value. The drivers would need to adjust the"},{"line_number":109,"context_line":"deploy behaviour when the new capabilities ``boot_mode_bios`` or"},{"line_number":110,"context_line":"``boot_mode_uefi`` are given in nova flavor. The changes required"},{"line_number":111,"context_line":"in drivers for ``boot_mode_*`` capabilities is out of scope of"},{"line_number":112,"context_line":"this spec."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Alternatives"},{"line_number":115,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a71b18c_9e891629","line":112,"range":{"start_line":110,"start_character":45,"end_line":112,"end_character":10},"updated":"2016-12-05 21:06:11.000000000","message":"Hi, just wondering about this: will \u0027boot_mode\u0027 stay intact and two new capabilities \u0027boot_mode_bios\u0027 and \u0027boot_mode_uefi\u0027 will be added? Thanks!","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"34d2dbb6455a076d14c6b96a7e8850fbe744d6a6","unresolved":false,"context_lines":[{"line_number":107,"context_line":"supporting both bios and uefi and the current capability ``boot_mode``"},{"line_number":108,"context_line":"can accept only one value. The drivers would need to adjust the"},{"line_number":109,"context_line":"deploy behaviour when the new capabilities ``boot_mode_bios`` or"},{"line_number":110,"context_line":"``boot_mode_uefi`` are given in nova flavor. The changes required"},{"line_number":111,"context_line":"in drivers for ``boot_mode_*`` capabilities is out of scope of"},{"line_number":112,"context_line":"this spec."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Alternatives"},{"line_number":115,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba5201f7_8c5f4640","line":112,"range":{"start_line":110,"start_character":45,"end_line":112,"end_character":10},"in_reply_to":"3a71b18c_9e891629","updated":"2017-01-04 17:11:58.000000000","message":"Yes that\u0027s true. If we remove boot_mode capability it may break backward compatibility.","commit_id":"023347b112050498110c7f6d3e2295e7d923891d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8ceda939be28f46018c27f8b34b36919a02b21ea","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    explanation     : There can be GPU cards from different"},{"line_number":94,"context_line":"                      vendors like NVIDIA, AMD etc."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    capability name : gpu_vendor_id_for_vendor_\u003cvendor\u003e"},{"line_number":97,"context_line":"    possible values : true|false"},{"line_number":98,"context_line":"                      Example: vendor ID for NVIDIA can be 0x10b5"},{"line_number":99,"context_line":"                      so the attribute become"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_5ee68be8","line":96,"range":{"start_line":96,"start_character":22,"end_line":96,"end_character":55},"updated":"2017-01-06 16:45:26.000000000","message":"gpu_vendor_id_\u003cvendor\u003e then","commit_id":"0179ba9e9c102663124864eb51d835255f01879e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8ceda939be28f46018c27f8b34b36919a02b21ea","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                      gpu_vendor_id_for_vendor_NVIDIA or "},{"line_number":101,"context_line":"                      gpu_vendor_id_for_vendor_0x10b5."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    capability name : gpu_product_id_for_vendor_\u003cvendor\u003e"},{"line_number":104,"context_line":"    possible values : true|false"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_9efb9378","line":103,"range":{"start_line":103,"start_character":22,"end_line":103,"end_character":56},"updated":"2017-01-06 16:45:26.000000000","message":"gpu_product_id_\u003cproduct\u003e, where \u003cproduct\u003e is an id.","commit_id":"0179ba9e9c102663124864eb51d835255f01879e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c8ead42af3a12d2a47a3da8a2afbddb3d74cff93","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    capability name : sriov_enabled"},{"line_number":48,"context_line":"    possible values : true|false"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    capability name : iscsi_iqn"},{"line_number":51,"context_line":"    possible values : vary from hardware to hardware"},{"line_number":52,"context_line":"    explanation     : This is the IQN available on the"},{"line_number":53,"context_line":"                      hardware which is iSCSI UEFI deploy"},{"line_number":54,"context_line":"                      capable."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    capability_name : drive_ssd"},{"line_number":57,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_8efe8503","line":54,"range":{"start_line":50,"start_character":4,"end_line":54,"end_character":30},"updated":"2017-01-10 19:03:57.000000000","message":"I don\u0027t think that iqn belongs to capabilities. It should be true/false, like bmc_can_connect_to_iscsi_iqn, to indicate that bmc supports it, the iqn value itself should be stored elsewhere iiuc.","commit_id":"5f75cb5d581dc1933958a51f9ab8a0a5268ad4e8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"df96c37f730e20790fa7f62caba29b866ce0589a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    capability name : sriov_enabled"},{"line_number":48,"context_line":"    possible values : true|false"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    capability name : iscsi_iqn"},{"line_number":51,"context_line":"    possible values : vary from hardware to hardware"},{"line_number":52,"context_line":"    explanation     : This is the IQN available on the"},{"line_number":53,"context_line":"                      hardware which is iSCSI UEFI deploy"},{"line_number":54,"context_line":"                      capable."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    capability_name : drive_ssd"},{"line_number":57,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_eac8a857","line":54,"range":{"start_line":50,"start_character":4,"end_line":54,"end_character":30},"in_reply_to":"ba5201f7_8efe8503","updated":"2017-01-11 17:04:34.000000000","message":"It is needed by the EFI iSCSI boot from cinder volume. As discussed, this will now be written to driver_info instead of capabilities.","commit_id":"5f75cb5d581dc1933958a51f9ab8a0a5268ad4e8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c8ead42af3a12d2a47a3da8a2afbddb3d74cff93","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    capability name : hardware_raid_capable"},{"line_number":84,"context_line":"    possible values : true|false"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    capability name : \u003cvendor\u003e_gpu_count"},{"line_number":87,"context_line":"    possible values : Numeric count"},{"line_number":88,"context_line":"    explanation     : There can be GPU cards from different"},{"line_number":89,"context_line":"                      vendors like NVIDIA, AMD etc."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    capability name : gpu_vendor_id_for_vendor_\u003cvendor\u003e"},{"line_number":92,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_4e4e5dc2","line":89,"range":{"start_line":86,"start_character":4,"end_line":89,"end_character":51},"updated":"2017-01-10 19:03:57.000000000","message":"This does not seem to be a capability, it is a property, just like memory_mb or disk_gb.","commit_id":"5f75cb5d581dc1933958a51f9ab8a0a5268ad4e8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"df96c37f730e20790fa7f62caba29b866ce0589a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    capability name : hardware_raid_capable"},{"line_number":84,"context_line":"    possible values : true|false"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    capability name : \u003cvendor\u003e_gpu_count"},{"line_number":87,"context_line":"    possible values : Numeric count"},{"line_number":88,"context_line":"    explanation     : There can be GPU cards from different"},{"line_number":89,"context_line":"                      vendors like NVIDIA, AMD etc."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    capability name : gpu_vendor_id_for_vendor_\u003cvendor\u003e"},{"line_number":92,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_2aed50b7","line":89,"range":{"start_line":86,"start_character":4,"end_line":89,"end_character":51},"in_reply_to":"ba5201f7_4e4e5dc2","updated":"2017-01-11 17:04:34.000000000","message":"Since Nova doesn\u0027t understand custom property, it has to be capability right now.","commit_id":"5f75cb5d581dc1933958a51f9ab8a0a5268ad4e8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c8ead42af3a12d2a47a3da8a2afbddb3d74cff93","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                      gpu_vendor_id_for_vendor_NVIDIA or"},{"line_number":96,"context_line":"                      gpu_vendor_id_for_vendor_0x10b5."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    capability name : gpu_product_id_for_vendor_\u003cvendor\u003e"},{"line_number":99,"context_line":"    possible values : true|false"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_033eeed9","line":98,"updated":"2017-01-10 19:03:57.000000000","message":"So I still don\u0027t get, is it a product id specified here? If so, why is it \u003cvendor\u003e? Otherwise it\u0027s the same as gpu_vendor_id_for_vendor_\u003cvendor\u003e.","commit_id":"5f75cb5d581dc1933958a51f9ab8a0a5268ad4e8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"df96c37f730e20790fa7f62caba29b866ce0589a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                      gpu_vendor_id_for_vendor_NVIDIA or"},{"line_number":96,"context_line":"                      gpu_vendor_id_for_vendor_0x10b5."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    capability name : gpu_product_id_for_vendor_\u003cvendor\u003e"},{"line_number":99,"context_line":"    possible values : true|false"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_6a7f58e0","line":98,"in_reply_to":"ba5201f7_033eeed9","updated":"2017-01-11 17:04:34.000000000","message":"Chnaged it to gpu_\u003cproduct_id\u003e_for_vendor_\u003cvendor_id\u003e","commit_id":"5f75cb5d581dc1933958a51f9ab8a0a5268ad4e8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2810fb2d0248d58587bf664995ecfdd3e90a045f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                      custom property, hence it has to be"},{"line_number":96,"context_line":"                      capability."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    capability name : gpu_vendor_id_for_vendor_\u003cvendor\u003e"},{"line_number":99,"context_line":"    possible values : true|false"},{"line_number":100,"context_line":"                      Example: vendor ID for NVIDIA can be 0x10b5"},{"line_number":101,"context_line":"                      so the attribute become"},{"line_number":102,"context_line":"                      gpu_vendor_id_for_vendor_NVIDIA or"},{"line_number":103,"context_line":"                      gpu_vendor_id_for_vendor_0x10b5."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    capability name : gpu_\u003cproduct_id\u003e_for_vendor_\u003cvendor\u003e"},{"line_number":106,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a57fde8_8d5ec643","line":103,"range":{"start_line":98,"start_character":0,"end_line":103,"end_character":54},"updated":"2017-01-12 16:35:41.000000000","message":"Why is this a node capability ? Isn\u0027t it the same as one requesting \"NVIDIA_gpu_count \u003e 0\" ?","commit_id":"eae4dced9408d6538e53596aae3e114c96c4dd1a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2810fb2d0248d58587bf664995ecfdd3e90a045f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                      gpu_vendor_id_for_vendor_NVIDIA or"},{"line_number":103,"context_line":"                      gpu_vendor_id_for_vendor_0x10b5."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    capability name : gpu_\u003cproduct_id\u003e_for_vendor_\u003cvendor\u003e"},{"line_number":106,"context_line":"    possible values : true|false"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    capability name : bios_firmware_version"},{"line_number":109,"context_line":"    possible values : vary from hardware to hardware."}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a57fde8_ad5b8a53","line":106,"range":{"start_line":105,"start_character":0,"end_line":106,"end_character":32},"updated":"2017-01-12 16:35:41.000000000","message":"same question as above","commit_id":"eae4dced9408d6538e53596aae3e114c96c4dd1a"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"1fa27dd880c023cfdcfe79bc12abef92c30fec9c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    capability name : secure_boot"},{"line_number":128,"context_line":"    possible values : true|false"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    capability name : pci_gpu_devices"},{"line_number":131,"context_line":"    possible values : count of total GPU devices."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    capability name : nic_capacity"},{"line_number":134,"context_line":"    possible values : Maximum NIC capacity value with unit."}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a57fde8_1174a833","line":131,"range":{"start_line":130,"start_character":4,"end_line":131,"end_character":49},"updated":"2017-01-12 19:13:51.000000000","message":"is this a sum of `\u003cvendor\u003e_gpu_count` from line 93 above?","commit_id":"857d199ed705ceedf57ce812c4c8b52923c596c7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8602b662e4c3e0d3f6cc7914e5cc9c37ff871b7b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    capability name : secure_boot"},{"line_number":128,"context_line":"    possible values : true|false"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    capability name : pci_gpu_devices"},{"line_number":131,"context_line":"    possible values : count of total GPU devices."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    capability name : nic_capacity"},{"line_number":134,"context_line":"    possible values : Maximum NIC capacity value with unit."}],"source_content_type":"text/x-rst","patch_set":20,"id":"7a3c09a3_df4ec495","line":131,"range":{"start_line":130,"start_character":4,"end_line":131,"end_character":49},"in_reply_to":"9a57fde8_1174a833","updated":"2017-01-13 07:36:11.000000000","message":"Yes and it already exists in ilo drivers today.","commit_id":"857d199ed705ceedf57ce812c4c8b52923c596c7"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"1fa27dd880c023cfdcfe79bc12abef92c30fec9c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    capability name : pci_gpu_devices"},{"line_number":131,"context_line":"    possible values : count of total GPU devices."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    capability name : nic_capacity"},{"line_number":134,"context_line":"    possible values : Maximum NIC capacity value with unit."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    capability name : rom_firmware_version"},{"line_number":137,"context_line":"    possible values : vary from hardware to hardware."}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a57fde8_f1c48441","line":134,"range":{"start_line":133,"start_character":4,"end_line":134,"end_character":59},"updated":"2017-01-12 19:13:51.000000000","message":"is this the speed of the fastest nic on the system?","commit_id":"857d199ed705ceedf57ce812c4c8b52923c596c7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8602b662e4c3e0d3f6cc7914e5cc9c37ff871b7b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    capability name : pci_gpu_devices"},{"line_number":131,"context_line":"    possible values : count of total GPU devices."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    capability name : nic_capacity"},{"line_number":134,"context_line":"    possible values : Maximum NIC capacity value with unit."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    capability name : rom_firmware_version"},{"line_number":137,"context_line":"    possible values : vary from hardware to hardware."}],"source_content_type":"text/x-rst","patch_set":20,"id":"7a3c09a3_ff43806a","line":134,"range":{"start_line":133,"start_character":4,"end_line":134,"end_character":59},"in_reply_to":"9a57fde8_f1c48441","updated":"2017-01-13 07:36:11.000000000","message":"Yes","commit_id":"857d199ed705ceedf57ce812c4c8b52923c596c7"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"1fa27dd880c023cfdcfe79bc12abef92c30fec9c","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    capability name : nic_capacity"},{"line_number":134,"context_line":"    possible values : Maximum NIC capacity value with unit."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    capability name : rom_firmware_version"},{"line_number":137,"context_line":"    possible values : vary from hardware to hardware."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"}],"source_content_type":"text/x-rst","patch_set":20,"id":"9a57fde8_f1dba419","line":136,"range":{"start_line":136,"start_character":22,"end_line":136,"end_character":42},"updated":"2017-01-12 19:13:51.000000000","message":"how is this different from `bios_firmware_version` above?","commit_id":"857d199ed705ceedf57ce812c4c8b52923c596c7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8602b662e4c3e0d3f6cc7914e5cc9c37ff871b7b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    capability name : nic_capacity"},{"line_number":134,"context_line":"    possible values : Maximum NIC capacity value with unit."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    capability name : rom_firmware_version"},{"line_number":137,"context_line":"    possible values : vary from hardware to hardware."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"}],"source_content_type":"text/x-rst","patch_set":20,"id":"7a3c09a3_82377ce2","line":136,"range":{"start_line":136,"start_character":22,"end_line":136,"end_character":42},"in_reply_to":"9a57fde8_f1dba419","updated":"2017-01-13 07:36:11.000000000","message":"ouch my mistake. I added from iRMC spec, so didn\u0027t see. Will remove it.","commit_id":"857d199ed705ceedf57ce812c4c8b52923c596c7"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"055b09efa3488d8ef006f527cfd208456db75da2","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1599425"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec adds few more capabilities to ironic drivers."},{"line_number":14,"context_line":"The capabilities can be implemented in-band or out-of-band"},{"line_number":15,"context_line":"as per driver maintainer\u0027s wish."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"3a461143_ebde116c","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":18},"updated":"2017-01-27 07:33:55.000000000","message":"nit: s/few/a few/","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1599425"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec adds few more capabilities to ironic drivers."},{"line_number":14,"context_line":"The capabilities can be implemented in-band or out-of-band"},{"line_number":15,"context_line":"as per driver maintainer\u0027s wish."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_bdd80ef1","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":18},"in_reply_to":"3a461143_ebde116c","updated":"2017-02-20 17:48:00.000000000","message":"ok","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"055b09efa3488d8ef006f527cfd208456db75da2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec adds few more capabilities to ironic drivers."},{"line_number":14,"context_line":"The capabilities can be implemented in-band or out-of-band"},{"line_number":15,"context_line":"as per driver maintainer\u0027s wish."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":21,"id":"3a461143_eb73717e","line":15,"range":{"start_line":15,"start_character":27,"end_line":15,"end_character":31},"updated":"2017-01-27 07:33:55.000000000","message":"nit: s/wish/technical decision/","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec adds few more capabilities to ironic drivers."},{"line_number":14,"context_line":"The capabilities can be implemented in-band or out-of-band"},{"line_number":15,"context_line":"as per driver maintainer\u0027s wish."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_1dee7a8b","line":15,"range":{"start_line":15,"start_character":27,"end_line":15,"end_character":31},"in_reply_to":"3a461143_eb73717e","updated":"2017-02-20 17:48:00.000000000","message":"ok","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7165f3009f4f6b9e81cc30b182cc5f24a1918acb","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    capability name : boot_mode_uefi"},{"line_number":38,"context_line":"    possible values : true|false"},{"line_number":39,"context_line":"    explanation     : The hardware supports uefi boot or not."},{"line_number":40,"context_line":"                      It is not the current boot mode."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    capability name : boot_mode_bios"},{"line_number":43,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a3c09a3_65d1bafb","line":40,"range":{"start_line":39,"start_character":22,"end_line":40,"end_character":54},"updated":"2017-01-13 08:33:04.000000000","message":"Just curious how are you going to detect this in in-band case, by looking at dmidecode? what happens if the node is set to legacy-boot only in bios, but has uefi possibility, is it still going to be reported correctly?","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"18f8212056b5cc35ec179da8dac6f473d4863ae2","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    capability name : boot_mode_uefi"},{"line_number":38,"context_line":"    possible values : true|false"},{"line_number":39,"context_line":"    explanation     : The hardware supports uefi boot or not."},{"line_number":40,"context_line":"                      It is not the current boot mode."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    capability name : boot_mode_bios"},{"line_number":43,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":21,"id":"fa31d9ce_9e2effa3","line":40,"range":{"start_line":39,"start_character":22,"end_line":40,"end_character":54},"in_reply_to":"5a3905b3_4d7823f3","updated":"2017-02-16 15:03:21.000000000","message":"Perhaps explicitly note that this may only be able to be detected out of band?","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"1d58004dd74ff68a2668d5ca75fa0117c6929eb5","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    capability name : boot_mode_uefi"},{"line_number":38,"context_line":"    possible values : true|false"},{"line_number":39,"context_line":"    explanation     : The hardware supports uefi boot or not."},{"line_number":40,"context_line":"                      It is not the current boot mode."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    capability name : boot_mode_bios"},{"line_number":43,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a3c09a3_9c10bc50","line":40,"range":{"start_line":39,"start_character":22,"end_line":40,"end_character":54},"in_reply_to":"7a3c09a3_65d1bafb","updated":"2017-01-13 11:23:45.000000000","message":"I don\u0027t know if it can be detected inband. OOB it is possible to detect. Till now what I know is that inband we can get current boot mode. May be it needs some investigation. But I believe the investigation for this is out of scope of this spec.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4338cdcff4f36efbe3499a320a896ce1cdf022f1","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    capability name : boot_mode_uefi"},{"line_number":38,"context_line":"    possible values : true|false"},{"line_number":39,"context_line":"    explanation     : The hardware supports uefi boot or not."},{"line_number":40,"context_line":"                      It is not the current boot mode."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    capability name : boot_mode_bios"},{"line_number":43,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":21,"id":"5a3905b3_4d7823f3","line":40,"range":{"start_line":39,"start_character":22,"end_line":40,"end_character":54},"in_reply_to":"7a3c09a3_9c10bc50","updated":"2017-01-20 10:27:06.000000000","message":"Yeah, I\u0027m not sure about in-band either. You can figure out which mode you are booted on at the moment the ramdisk is running, but, I\u0027m not sure there\u0027s a way to know if a node booted in Legacy BIOS can figure out if the machine supports UEFI boot.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    capability name : boot_mode_uefi"},{"line_number":38,"context_line":"    possible values : true|false"},{"line_number":39,"context_line":"    explanation     : The hardware supports uefi boot or not."},{"line_number":40,"context_line":"                      It is not the current boot mode."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    capability name : boot_mode_bios"},{"line_number":43,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_7decd6c7","line":40,"range":{"start_line":39,"start_character":22,"end_line":40,"end_character":54},"in_reply_to":"fa31d9ce_9e2effa3","updated":"2017-02-20 17:48:00.000000000","message":"Ok Sure.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"18f8212056b5cc35ec179da8dac6f473d4863ae2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    capability name : sriov_enabled"},{"line_number":48,"context_line":"    possible values : true|false"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    capability name : iscsi_iqn"},{"line_number":51,"context_line":"    possible values : vary from hardware to hardware"},{"line_number":52,"context_line":"    explanation     : This is the IQN available on the"},{"line_number":53,"context_line":"                      hardware which is iSCSI UEFI deploy"},{"line_number":54,"context_line":"                      capable."},{"line_number":55,"context_line":"                      This property will be written to"},{"line_number":56,"context_line":"                      the volume connectors table"},{"line_number":57,"context_line":"                      as it has to consumed during boot from"},{"line_number":58,"context_line":"                      cinder volume."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    capability_name : drive_ssd"},{"line_number":61,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":21,"id":"fa31d9ce_c13096eb","line":58,"range":{"start_line":50,"start_character":0,"end_line":58,"end_character":36},"updated":"2017-02-16 15:03:21.000000000","message":"Instead of store an inn from the bios (by the way, we should try and get the ip address of the iscsi interface, if possible), lets get the volume connectors API landed create/update the ports instead of adding a capability to serve the same purpose....","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"961eb3e1c896595636941cdfa7201dd4f3eac2d8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    capability name : sriov_enabled"},{"line_number":48,"context_line":"    possible values : true|false"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    capability name : iscsi_iqn"},{"line_number":51,"context_line":"    possible values : vary from hardware to hardware"},{"line_number":52,"context_line":"    explanation     : This is the IQN available on the"},{"line_number":53,"context_line":"                      hardware which is iSCSI UEFI deploy"},{"line_number":54,"context_line":"                      capable."},{"line_number":55,"context_line":"                      This property will be written to"},{"line_number":56,"context_line":"                      the volume connectors table"},{"line_number":57,"context_line":"                      as it has to consumed during boot from"},{"line_number":58,"context_line":"                      cinder volume."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    capability_name : drive_ssd"},{"line_number":61,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_28b03543","line":58,"range":{"start_line":50,"start_character":0,"end_line":58,"end_character":36},"in_reply_to":"fa31d9ce_c13096eb","updated":"2017-02-21 17:01:22.000000000","message":"This iqn is not set by any REST call. Hence has to inspect and get it from hardware. The iqn is possible to change only manually and not via any REST call. Hence we think it should be inspected as required by EFI ISCSI boot from cinder volume.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                      as it has to consumed during boot from"},{"line_number":58,"context_line":"                      cinder volume."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    capability_name : drive_ssd"},{"line_number":61,"context_line":"    possible values : true|false"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    capability_name : drive_rotational"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_8c1df168","line":60,"updated":"2017-02-20 02:52:14.000000000","message":"it\u0027s a bit unclear is this implies that ALL drives are SSD or just some. maybe call it \"has_ssd\"?","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                      as it has to consumed during boot from"},{"line_number":58,"context_line":"                      cinder volume."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    capability_name : drive_ssd"},{"line_number":61,"context_line":"    possible values : true|false"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    capability_name : drive_rotational"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_02fa9742","line":60,"in_reply_to":"da36d5c6_8c1df168","updated":"2017-02-20 17:48:00.000000000","message":"It applies even if one disk is SSD. I will update it to has_ssd if that makes more sense.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    capability_name : drive_ssd"},{"line_number":61,"context_line":"    possible values : true|false"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    capability_name : drive_rotational"},{"line_number":64,"context_line":"    possible_values : true|false"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    capability name : rotational_drive_max_rpm"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_ac1ab56c","line":63,"updated":"2017-02-20 02:52:14.000000000","message":"ditto","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    capability_name : drive_ssd"},{"line_number":61,"context_line":"    possible values : true|false"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    capability_name : drive_rotational"},{"line_number":64,"context_line":"    possible_values : true|false"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    capability name : rotational_drive_max_rpm"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_2295dbe3","line":63,"in_reply_to":"da36d5c6_ac1ab56c","updated":"2017-02-20 17:48:00.000000000","message":"ditto","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                      set to ``true``. These capabilities would be"},{"line_number":83,"context_line":"                      used only for scheduling, and ironic is"},{"line_number":84,"context_line":"                      not supposed to create RAID level as per these"},{"line_number":85,"context_line":"                      capabilities."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    capability name : cpu_vt"},{"line_number":88,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_cc2529af","line":85,"updated":"2017-02-20 02:52:14.000000000","message":"it seems reasonable for the RAID interfaces to set this capability, no?","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"961eb3e1c896595636941cdfa7201dd4f3eac2d8","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                      set to ``true``. These capabilities would be"},{"line_number":83,"context_line":"                      used only for scheduling, and ironic is"},{"line_number":84,"context_line":"                      not supposed to create RAID level as per these"},{"line_number":85,"context_line":"                      capabilities."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    capability name : cpu_vt"},{"line_number":88,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_88ba0109","line":85,"in_reply_to":"da36d5c6_cc2529af","updated":"2017-02-21 17:01:22.000000000","message":"Yes, ideally it should be done by RAID interfaces. But it makes sense to inspection in the case the RAID was pre-configured before registering the node to ironic. WDYT?","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    capability name : cpu_vt"},{"line_number":88,"context_line":"    possible values : true|false"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    capability name : hardware_raid_capable"},{"line_number":91,"context_line":"    possible values : true|false"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    capability name : \u003cvendor\u003e_gpu_count"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_ec2aed7d","line":90,"updated":"2017-02-20 02:52:14.000000000","message":"s/_capable// as you don\u0027t have this suffex anywhere else","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    capability name : cpu_vt"},{"line_number":88,"context_line":"    possible values : true|false"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    capability name : hardware_raid_capable"},{"line_number":91,"context_line":"    possible values : true|false"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    capability name : \u003cvendor\u003e_gpu_count"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_a2254bc3","line":90,"in_reply_to":"da36d5c6_ec2aed7d","updated":"2017-02-20 17:48:00.000000000","message":"ok","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                      vendors like NVIDIA, AMD etc."},{"line_number":97,"context_line":"                      Since nova cannot understand"},{"line_number":98,"context_line":"                      custom property, hence it has to be"},{"line_number":99,"context_line":"                      capability."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    capability name : gpu_\u003cproduct_id\u003e_for_vendor_\u003cvendor\u003e"},{"line_number":102,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_0c20219b","line":99,"updated":"2017-02-20 02:52:14.000000000","message":"do we need a generic gpu_count too?","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                      vendors like NVIDIA, AMD etc."},{"line_number":97,"context_line":"                      Since nova cannot understand"},{"line_number":98,"context_line":"                      custom property, hence it has to be"},{"line_number":99,"context_line":"                      capability."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    capability name : gpu_\u003cproduct_id\u003e_for_vendor_\u003cvendor\u003e"},{"line_number":102,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_e206631f","line":99,"in_reply_to":"da36d5c6_0c20219b","updated":"2017-02-20 17:48:00.000000000","message":"its already there as pci_gpu_devices. See Line 127","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    capability name : gpu_\u003cproduct_id\u003e_for_vendor_\u003cvendor\u003e"},{"line_number":102,"context_line":"    possible values : true|false"},{"line_number":103,"context_line":"    explanation     : It helps the operator to select the"},{"line_number":104,"context_line":"                      gpu device based on product id."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    capability name : cpu_fpgas"},{"line_number":107,"context_line":"    possible values : count of such devices."}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_2c25e5aa","line":104,"updated":"2017-02-20 02:52:14.000000000","message":"this lools too detailed to me. I don\u0027t think cloud software should depend on specfic product_id, but rather on some capability (which? e.g. numa_cores?) it may expose.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      gpu device based on product id."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    capability name : cpu_fpgas"},{"line_number":107,"context_line":"    possible values : count of such devices."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The other drivers/vendors may require the below list of capabilities."},{"line_number":110,"context_line":"These are already implemented by iLO drivers::"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_4c3a19cf","line":107,"updated":"2017-02-20 02:52:14.000000000","message":"such - which?","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      gpu device based on product id."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    capability name : cpu_fpgas"},{"line_number":107,"context_line":"    possible values : count of such devices."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The other drivers/vendors may require the below list of capabilities."},{"line_number":110,"context_line":"These are already implemented by iLO drivers::"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_9d3a6acc","line":107,"in_reply_to":"da36d5c6_4c3a19cf","updated":"2017-02-20 17:48:00.000000000","message":":) FPGA devices","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":110,"context_line":"These are already implemented by iLO drivers::"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    capability name : boot_mode"},{"line_number":113,"context_line":"    possible values : bios, uefi"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    capability name : \u003cdriver\u003e_firmware_version"},{"line_number":116,"context_line":"    possible values : varies from hardware to hardware"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_6c37dde3","line":113,"updated":"2017-02-20 02:52:14.000000000","message":"explanation: the current boot mode","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":110,"context_line":"These are already implemented by iLO drivers::"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    capability name : boot_mode"},{"line_number":113,"context_line":"    possible values : bios, uefi"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    capability name : \u003cdriver\u003e_firmware_version"},{"line_number":116,"context_line":"    possible values : varies from hardware to hardware"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_dd4ea2c0","line":113,"in_reply_to":"da36d5c6_6c37dde3","updated":"2017-02-20 17:48:00.000000000","message":"1. As I understand this doesn\u0027t imply current boot mode in ironic, it implies the boot mode to be set during deploy.\nFor Eg, the system may be in BIOS boot mode but the boot_mode capability is set to UEFI before deploy and when the system boots up it boots up in UEFI boot mode. So it is the expected deploy boot mode of the system in ironic terms.\n2. I will modify the spec to say that boot_mode is manually filled/used by ilo drivers. but ilo drivers don\u0027t intend to inspect this as there can be hardware which supports both bios and uefi.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    capability name : boot_mode"},{"line_number":113,"context_line":"    possible values : bios, uefi"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    capability name : \u003cdriver\u003e_firmware_version"},{"line_number":116,"context_line":"    possible values : varies from hardware to hardware"},{"line_number":117,"context_line":"    explanation     : Here driver means ilo or irmc or any other"},{"line_number":118,"context_line":"                      vendor. Hence the capability becomes"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_8c3411df","line":115,"updated":"2017-02-20 02:52:14.000000000","message":"again, we should expose firmware capabilities, not just (usually hard to decrypt) firmware version.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    capability name : boot_mode"},{"line_number":113,"context_line":"    possible values : bios, uefi"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    capability name : \u003cdriver\u003e_firmware_version"},{"line_number":116,"context_line":"    possible values : varies from hardware to hardware"},{"line_number":117,"context_line":"    explanation     : Here driver means ilo or irmc or any other"},{"line_number":118,"context_line":"                      vendor. Hence the capability becomes"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_3da6dec1","line":115,"in_reply_to":"da36d5c6_8c3411df","updated":"2017-02-20 17:48:00.000000000","message":"hmmm I am not sure why not ilo_firmware_version/irmc_firmware_version.\n\nSecondly I don\u0027t understand which firmware capabilities you meant here, example will help.\n\nIts already existing capability for ilo drivers.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    capability name : server_model"},{"line_number":122,"context_line":"    possible values : varies from hardware to hardware."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    capability name : secure_boot"},{"line_number":125,"context_line":"    possible values : true|false"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    capability name : pci_gpu_devices"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_ac31d5ee","line":124,"updated":"2017-02-20 02:52:14.000000000","message":"is it \"supported\" or \"enabled\"?","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    capability name : server_model"},{"line_number":122,"context_line":"    possible values : varies from hardware to hardware."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    capability name : secure_boot"},{"line_number":125,"context_line":"    possible values : true|false"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    capability name : pci_gpu_devices"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_dd906298","line":124,"in_reply_to":"da36d5c6_ac31d5ee","updated":"2017-02-20 17:48:00.000000000","message":"it means secure boot supported","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    capability name : secure_boot"},{"line_number":125,"context_line":"    possible values : true|false"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    capability name : pci_gpu_devices"},{"line_number":128,"context_line":"    possible values : count of total GPU devices."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    capability name : nic_capacity"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_cc4c4979","line":127,"updated":"2017-02-20 02:52:14.000000000","message":"you don\u0027t have pci_ prefix above, so you may want to drop it here.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    capability name : secure_boot"},{"line_number":125,"context_line":"    possible values : true|false"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    capability name : pci_gpu_devices"},{"line_number":128,"context_line":"    possible values : count of total GPU devices."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    capability name : nic_capacity"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_1dd03a53","line":127,"in_reply_to":"da36d5c6_cc4c4979","updated":"2017-02-20 17:48:00.000000000","message":"yeah but this capability is already there from Kilo. So dropping the prefix now may be backward compatibility for ilo drivers.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5bc5111e294e900a17b6cfefa71a808215f45c42","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    capability name : nic_capacity"},{"line_number":131,"context_line":"    possible values : Maximum NIC capacity value with unit."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    capability name : rom_firmware_version"},{"line_number":134,"context_line":"    possible values : vary from hardware to hardware."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_ec510d10","line":133,"updated":"2017-02-20 02:52:14.000000000","message":"how is it different from \u003cdriver\u003e_firmware_version? also see above my opinion on firmware versions?","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab2c5fb5f7376d80f7bc9d9c317323e0ac7f14f2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    capability name : nic_capacity"},{"line_number":131,"context_line":"    possible values : Maximum NIC capacity value with unit."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    capability name : rom_firmware_version"},{"line_number":134,"context_line":"    possible values : vary from hardware to hardware."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da36d5c6_5dcab2a2","line":133,"in_reply_to":"da36d5c6_ec510d10","updated":"2017-02-20 17:48:00.000000000","message":"this is bios firmware version.","commit_id":"e4f16f6b707add75a65dc9ff52ded5889330c874"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"1cebbe9e45e1a75cbc6214a32d027b8706073ed6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Proposed change"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Following properties will be discovered::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    capability name: trusted_boot"},{"line_number":30,"context_line":"    possible values: true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_c25cf927","line":27,"updated":"2017-03-17 23:37:04.000000000","message":"Hi, are these going to be added to SUPPORTED_CAPABILITIES for the drivers?","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Proposed change"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Following properties will be discovered::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    capability name: trusted_boot"},{"line_number":30,"context_line":"    possible values: true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_d1d52abb","line":27,"in_reply_to":"1a1ced50_c25cf927","updated":"2017-04-06 09:07:20.000000000","message":"yes","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"1cebbe9e45e1a75cbc6214a32d027b8706073ed6","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Following properties will be discovered::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    capability name: trusted_boot"},{"line_number":30,"context_line":"    possible values: true|false"},{"line_number":31,"context_line":"    explanation    : The hardware supports trusted boot or not."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_426009cf","line":29,"updated":"2017-03-17 23:37:04.000000000","message":"Isn\u0027t trusted_boot already a recognized capability?","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Following properties will be discovered::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    capability name: trusted_boot"},{"line_number":30,"context_line":"    possible values: true|false"},{"line_number":31,"context_line":"    explanation    : The hardware supports trusted boot or not."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_71fd3e39","line":29,"in_reply_to":"1a1ced50_426009cf","updated":"2017-04-06 09:07:20.000000000","message":"yes for some drivers, but not for all i guess. this spec covers all available capabilities in ironic side till now","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7d1bd67da6612130fb384330c22b3b3e25e35147","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                      This property will be written to"},{"line_number":60,"context_line":"                      the volume connectors table"},{"line_number":61,"context_line":"                      as it has to consumed during boot from"},{"line_number":62,"context_line":"                      cinder volume."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    capability_name : has_ssd"},{"line_number":65,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_da34e8df","line":62,"updated":"2017-03-17 18:15:07.000000000","message":"This seems more like a property than a capability, and doesn\u0027t seem useful for scheduling. Can we separate properties from capabilities in this spec?","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                      This property will be written to"},{"line_number":60,"context_line":"                      the volume connectors table"},{"line_number":61,"context_line":"                      as it has to consumed during boot from"},{"line_number":62,"context_line":"                      cinder volume."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    capability_name : has_ssd"},{"line_number":65,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_917322e8","line":62,"in_reply_to":"1a1ced50_da34e8df","updated":"2017-04-06 09:07:20.000000000","message":"Ok. i have removed this from the spec. we will add it to efi iscsi boot from volume work.","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7d1bd67da6612130fb384330c22b3b3e25e35147","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    possible_values : true|false"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    capability name : rotational_drive_max_rpm"},{"line_number":71,"context_line":"    possible values : Integer value"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    capability name : logical_raid_level_\u003cnum\u003e"},{"line_number":74,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_7a469424","line":71,"updated":"2017-03-17 18:15:07.000000000","message":"Feels like this could be a few traits - e.g. ROTATIONAL_DRIVE_5400_RPM, ROTATIONAL_DRIVER_7200_RPM, etc. Then those would be booleans, and fit better with the traits in the scheduler.","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    possible_values : true|false"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    capability name : rotational_drive_max_rpm"},{"line_number":71,"context_line":"    possible values : Integer value"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    capability name : logical_raid_level_\u003cnum\u003e"},{"line_number":74,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_71809e8c","line":71,"in_reply_to":"1a1ced50_7a469424","updated":"2017-04-06 09:07:20.000000000","message":"done","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7d1bd67da6612130fb384330c22b3b3e25e35147","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      vendors like NVIDIA, AMD etc."},{"line_number":105,"context_line":"                      Since nova cannot understand"},{"line_number":106,"context_line":"                      custom property, hence it has to be"},{"line_number":107,"context_line":"                      capability."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    capability name : gpu_\u003cproduct_id\u003e_for_vendor_\u003cvendor\u003e"},{"line_number":110,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_9acef081","line":107,"updated":"2017-03-17 18:15:07.000000000","message":"I wonder if we could handle this outside of capabilities now that we have custom resource classes. If we represented it in the database as a countable thing (maybe node.devices.gpus \u003d [{\u0027vendor\u0027: \u0027foo\u0027, \u0027product_id\u0027: \u0027bar\u0027}, ...] or something, then we could tell nova\u0027s resource tracker that the node has a count of 1 CUSTOM_HARDWARE_GPU_FOO_BAR, and we could require that in a flavor.","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      vendors like NVIDIA, AMD etc."},{"line_number":105,"context_line":"                      Since nova cannot understand"},{"line_number":106,"context_line":"                      custom property, hence it has to be"},{"line_number":107,"context_line":"                      capability."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    capability name : gpu_\u003cproduct_id\u003e_for_vendor_\u003cvendor\u003e"},{"line_number":110,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_11515237","line":107,"in_reply_to":"1a1ced50_95cec381","updated":"2017-04-06 09:07:20.000000000","message":"removed","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"afaf2e526e47dce88f8bc6fcfb7863bbce1e485d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      vendors like NVIDIA, AMD etc."},{"line_number":105,"context_line":"                      Since nova cannot understand"},{"line_number":106,"context_line":"                      custom property, hence it has to be"},{"line_number":107,"context_line":"                      capability."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    capability name : gpu_\u003cproduct_id\u003e_for_vendor_\u003cvendor\u003e"},{"line_number":110,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_95cec381","line":107,"in_reply_to":"1a1ced50_9acef081","updated":"2017-03-17 18:16:19.000000000","message":"To be clear, if we want to do something like that, let\u0027s keep that work separate :)","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7d1bd67da6612130fb384330c22b3b3e25e35147","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    capability name : gpu_\u003cproduct_id\u003e_for_vendor_\u003cvendor\u003e"},{"line_number":110,"context_line":"    possible values : true|false"},{"line_number":111,"context_line":"    explanation     : It helps the operator to select the"},{"line_number":112,"context_line":"                      gpu device based on product id."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    capability name : cpu_fpgas"},{"line_number":115,"context_line":"    possible values : count of such devices."}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_bacbac71","line":112,"updated":"2017-03-17 18:15:07.000000000","message":"See previous comment :)","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    capability name : gpu_\u003cproduct_id\u003e_for_vendor_\u003cvendor\u003e"},{"line_number":110,"context_line":"    possible values : true|false"},{"line_number":111,"context_line":"    explanation     : It helps the operator to select the"},{"line_number":112,"context_line":"                      gpu device based on product id."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    capability name : cpu_fpgas"},{"line_number":115,"context_line":"    possible values : count of such devices."}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_b124e6c7","line":112,"in_reply_to":"1a1ced50_bacbac71","updated":"2017-04-06 09:07:20.000000000","message":"removed","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"1cebbe9e45e1a75cbc6214a32d027b8706073ed6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    capability name : cpu_fpgas"},{"line_number":115,"context_line":"    possible values : count of such devices."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    capability name : boot_mode"},{"line_number":118,"context_line":"    possible values : bios, uefi"},{"line_number":119,"context_line":"    explanation     : This represents the deploy boot mode of"},{"line_number":120,"context_line":"                      the system."}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_c281594c","line":117,"updated":"2017-03-17 23:37:04.000000000","message":"boot_mode is supported too, right?","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    capability name : cpu_fpgas"},{"line_number":115,"context_line":"    possible values : count of such devices."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    capability name : boot_mode"},{"line_number":118,"context_line":"    possible values : bios, uefi"},{"line_number":119,"context_line":"    explanation     : This represents the deploy boot mode of"},{"line_number":120,"context_line":"                      the system."}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_b10d0640","line":117,"in_reply_to":"1a1ced50_c281594c","updated":"2017-04-06 09:07:20.000000000","message":"yeah, spec tries to list all attributes(existing and new).","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7d1bd67da6612130fb384330c22b3b3e25e35147","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    capability name : nvme_ssd_count"},{"line_number":126,"context_line":"    possible values : Integer value"},{"line_number":127,"context_line":"    explanation     : Gets the count for NVMe SSD disks."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    capability name : total_persistent_memory"},{"line_number":130,"context_line":"    possible values : size in MiB"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_5a8398cc","line":127,"updated":"2017-03-17 18:15:07.000000000","message":"Hm, these will be more difficult to do in the new nova way. I feel like if we represent them in a particular way, we might be able to do something with custom resource classes or traits, but I think I\u0027d like to discuss it with nova folks first.","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    capability name : nvme_ssd_count"},{"line_number":126,"context_line":"    possible values : Integer value"},{"line_number":127,"context_line":"    explanation     : Gets the count for NVMe SSD disks."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    capability name : total_persistent_memory"},{"line_number":130,"context_line":"    possible values : size in MiB"}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_23476d4e","line":127,"in_reply_to":"1a1ced50_5a8398cc","updated":"2017-04-06 09:07:20.000000000","message":"converted it to boolean atleast for the presence of such devices","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7d1bd67da6612130fb384330c22b3b3e25e35147","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    possible values : size in MiB"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    capability name : nvdimm_n_size"},{"line_number":133,"context_line":"    possible values : size in MiB"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    capability name : logical_nvdimm_n"},{"line_number":136,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_5a5ab884","line":133,"updated":"2017-03-17 18:15:07.000000000","message":"Ditto for these memory things","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    possible values : size in MiB"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    capability name : nvdimm_n_size"},{"line_number":133,"context_line":"    possible values : size in MiB"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    capability name : logical_nvdimm_n"},{"line_number":136,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_c36fa1c3","line":133,"in_reply_to":"1a1ced50_5a5ab884","updated":"2017-04-06 09:07:20.000000000","message":"ditto","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"1cebbe9e45e1a75cbc6214a32d027b8706073ed6","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    capability name : logical_nvdimm_n"},{"line_number":136,"context_line":"    possible values : true|false"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"The other drivers/vendors may require the below list of capabilities."},{"line_number":139,"context_line":"These are already implemented by iLO drivers::"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    capability name : \u003cdriver\u003e_firmware_version"},{"line_number":142,"context_line":"    possible values : varies from hardware to hardware"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_82d84155","line":139,"range":{"start_line":138,"start_character":0,"end_line":139,"end_character":46},"updated":"2017-03-17 23:37:04.000000000","message":"Is it possible to be more specific about the \u0027other drivers/vendors\u0027 here? Does it mean, drivers other than iLO? L13 and L27 imply that the changes are for all ironic drivers.","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    capability name : logical_nvdimm_n"},{"line_number":136,"context_line":"    possible values : true|false"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"The other drivers/vendors may require the below list of capabilities."},{"line_number":139,"context_line":"These are already implemented by iLO drivers::"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    capability name : \u003cdriver\u003e_firmware_version"},{"line_number":142,"context_line":"    possible values : varies from hardware to hardware"}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_63d9f581","line":139,"range":{"start_line":138,"start_character":0,"end_line":139,"end_character":46},"in_reply_to":"1a1ced50_82d84155","updated":"2017-04-06 09:07:20.000000000","message":"yes the spec is intended for all the ironic drivers. this spec is just for standardizing capabilities names. implementing out of scope of this spec.\n\nThe other vendors/drivers mean other than ilo drivers","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7d1bd67da6612130fb384330c22b3b3e25e35147","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    possible values : varies from hardware to hardware"},{"line_number":143,"context_line":"    explanation     : Here driver means ilo or irmc or any other"},{"line_number":144,"context_line":"                      vendor. Hence the capability becomes"},{"line_number":145,"context_line":"                      ilo_firmware_version or irmc_firmware_version."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    capability name : server_model"},{"line_number":148,"context_line":"    possible values : varies from hardware to hardware."}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_dae5c8a8","line":145,"updated":"2017-03-17 18:15:07.000000000","message":"These may need to become custom traits at some point, or... something.","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    possible values : varies from hardware to hardware"},{"line_number":143,"context_line":"    explanation     : Here driver means ilo or irmc or any other"},{"line_number":144,"context_line":"                      vendor. Hence the capability becomes"},{"line_number":145,"context_line":"                      ilo_firmware_version or irmc_firmware_version."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    capability name : server_model"},{"line_number":148,"context_line":"    possible values : varies from hardware to hardware."}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_43bf11fb","line":145,"in_reply_to":"1a1ced50_dae5c8a8","updated":"2017-04-06 09:07:20.000000000","message":"dont know how to deal with this..... \ni have kept it because we already have it in place for ilo drivers. i dont want capabilities names to be lost when we move for traits.","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"1cebbe9e45e1a75cbc6214a32d027b8706073ed6","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    capability name : rom_firmware_version"},{"line_number":160,"context_line":"    possible values : vary from hardware to hardware."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Few which are already implemented by ironic-inspector::"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    capability name : cpu_aes"},{"line_number":165,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_a2ab7d88","line":162,"updated":"2017-03-17 23:37:04.000000000","message":"This sentence can be rephrased.","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    capability name : rom_firmware_version"},{"line_number":160,"context_line":"    possible values : vary from hardware to hardware."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Few which are already implemented by ironic-inspector::"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    capability name : cpu_aes"},{"line_number":165,"context_line":"    possible values : true|false"}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_e33bc599","line":162,"in_reply_to":"1a1ced50_a2ab7d88","updated":"2017-04-06 09:07:20.000000000","message":"please suggest i will rephrase.","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"1cebbe9e45e1a75cbc6214a32d027b8706073ed6","unresolved":false,"context_lines":[{"line_number":187,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"},{"line_number":188,"context_line":"as the hardware can have both kind of drives attached."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"The capabilities ``boot_mode_*`` are added as a hardware could be"},{"line_number":191,"context_line":"supporting both bios and uefi and the current capability ``boot_mode``"},{"line_number":192,"context_line":"can accept only one value. The drivers would need to adjust the"},{"line_number":193,"context_line":"deploy behaviour when the new capabilities ``boot_mode_bios`` or"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_a2e7fde2","line":190,"updated":"2017-03-17 23:37:04.000000000","message":"It is nice to have the explanation on boot_mode_*.","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":187,"context_line":"``drive_ssd`` and ``drive_rotational`` are two different properties"},{"line_number":188,"context_line":"as the hardware can have both kind of drives attached."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"The capabilities ``boot_mode_*`` are added as a hardware could be"},{"line_number":191,"context_line":"supporting both bios and uefi and the current capability ``boot_mode``"},{"line_number":192,"context_line":"can accept only one value. The drivers would need to adjust the"},{"line_number":193,"context_line":"deploy behaviour when the new capabilities ``boot_mode_bios`` or"}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_e364e5bb","line":190,"in_reply_to":"1a1ced50_a2e7fde2","updated":"2017-04-06 09:07:20.000000000","message":"thank u","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"1cebbe9e45e1a75cbc6214a32d027b8706073ed6","unresolved":false,"context_lines":[{"line_number":284,"context_line":"Work Items"},{"line_number":285,"context_line":"----------"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"* To add the above capabilities to the inspection."},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"Dependencies"},{"line_number":290,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a1ced50_622b45ec","line":287,"updated":"2017-03-17 23:37:04.000000000","message":"Is there an impact on ironic-python-agent or ironic-inspector?","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b49e3ed59d5d421646cc6987f53b3d40267fda80","unresolved":false,"context_lines":[{"line_number":284,"context_line":"Work Items"},{"line_number":285,"context_line":"----------"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"* To add the above capabilities to the inspection."},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"Dependencies"},{"line_number":290,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":24,"id":"bff0334d_23ff6dab","line":287,"in_reply_to":"1a1ced50_622b45ec","updated":"2017-04-06 09:07:20.000000000","message":"no impact. It is upto specific drivers to implement the capabilities which they want to support. So if ironic-inspector wants to implement them, they have to do it. implementation is out of scope of this spec.","commit_id":"7a632052661f2313e072b43058f5508857fb6cc4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6dbc1d5e075cfd1949cc70ecb6f3d7cfd4107257","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    capability name : persistent_memory"},{"line_number":106,"context_line":"    possible values : true|false"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    capability name : nvdimm_n"},{"line_number":109,"context_line":"    possible values : true|false"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    capability name : logical_nvdimm_n"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7ffa3b31_8d6b9483","line":108,"updated":"2017-04-20 10:25:19.000000000","message":"what is \"n\" here?","commit_id":"e4c64776822326a71aa38ca4e46708cb97dd594d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"22d6fc4db72fb97c219097175fd670aa2d916580","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    capability name : persistent_memory"},{"line_number":106,"context_line":"    possible values : true|false"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    capability name : nvdimm_n"},{"line_number":109,"context_line":"    possible values : true|false"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    capability name : logical_nvdimm_n"}],"source_content_type":"text/x-rst","patch_set":25,"id":"7ffa3b31_d6ea2fd6","line":108,"in_reply_to":"7ffa3b31_8d6b9483","updated":"2017-04-21 06:01:52.000000000","message":"NVDIMM_N is a standard. refer https://en.wikipedia.org/wiki/NVDIMM.","commit_id":"e4c64776822326a71aa38ca4e46708cb97dd594d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6dbc1d5e075cfd1949cc70ecb6f3d7cfd4107257","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    capability name : nvdimm_n"},{"line_number":109,"context_line":"    possible values : true|false"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    capability name : logical_nvdimm_n"},{"line_number":112,"context_line":"    possible values : true|false"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"The other drivers/vendors may require the below list of capabilities."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7ffa3b31_4d07cccb","line":111,"updated":"2017-04-20 10:25:19.000000000","message":"Ditto","commit_id":"e4c64776822326a71aa38ca4e46708cb97dd594d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"22d6fc4db72fb97c219097175fd670aa2d916580","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    capability name : nvdimm_n"},{"line_number":109,"context_line":"    possible values : true|false"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    capability name : logical_nvdimm_n"},{"line_number":112,"context_line":"    possible values : true|false"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"The other drivers/vendors may require the below list of capabilities."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7ffa3b31_d698ef75","line":111,"in_reply_to":"7ffa3b31_4d07cccb","updated":"2017-04-21 06:01:52.000000000","message":"logical NVDIMMN. Generally vendors support this on top of NVDIMM.","commit_id":"e4c64776822326a71aa38ca4e46708cb97dd594d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6dbc1d5e075cfd1949cc70ecb6f3d7cfd4107257","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    possible values : true|false"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    capability name : pci_gpu_devices"},{"line_number":130,"context_line":"    possible values : count of total GPU devices."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    capability name : nic_capacity"},{"line_number":133,"context_line":"    possible values : Maximum NIC capacity value with unit."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7ffa3b31_0d0d44e7","line":130,"updated":"2017-04-20 10:25:19.000000000","message":"I don\u0027t like that this is countable, but we already use it, so probably fine.","commit_id":"e4c64776822326a71aa38ca4e46708cb97dd594d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"22d6fc4db72fb97c219097175fd670aa2d916580","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    possible values : true|false"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    capability name : pci_gpu_devices"},{"line_number":130,"context_line":"    possible values : count of total GPU devices."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    capability name : nic_capacity"},{"line_number":133,"context_line":"    possible values : Maximum NIC capacity value with unit."}],"source_content_type":"text/x-rst","patch_set":25,"id":"7ffa3b31_76811bfb","line":130,"in_reply_to":"7ffa3b31_0d0d44e7","updated":"2017-04-21 06:01:52.000000000","message":"Thank you","commit_id":"e4c64776822326a71aa38ca4e46708cb97dd594d"}]}
