)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"48bbf3b4fcd2d26401420c2638f5d0b17af5db89","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladyslav Drok \u003cvdrok@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-08 15:18:11 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add CRUD notifications to ironic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes to add resources create, update, delete"},{"line_number":10,"context_line":"notifications, node provision state and maintenance mode"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_507d30b0","line":7,"updated":"2016-08-09 15:32:09.000000000","message":"this is not only about CRUD","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"745e37c20ee0f2ad17acc33958492d7eb190f821","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladyslav Drok \u003cvdrok@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-08 15:18:11 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add CRUD notifications to ironic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes to add resources create, update, delete"},{"line_number":10,"context_line":"notifications, node provision state and maintenance mode"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3ac371cc_ff10b8aa","line":7,"in_reply_to":"9ad45d7e_507d30b0","updated":"2016-08-14 21:44:15.000000000","message":"\"node\u0027s provision state and maintenance notifications\" is too long, I\u0027ve made it just \"node states notifications\" :)","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"73cba4f0633f80f66e850d79d4ea439448648762","unresolved":false,"context_lines":[{"line_number":10,"context_line":"notifications, node provision state and maintenance mode"},{"line_number":11,"context_line":"notifications and describes the corresponding work items."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-Bug: #1606520"},{"line_number":14,"context_line":"Co-Authored-By: Vladyslav Drok \u003cvdrok@mirantis.com\u003e"},{"line_number":15,"context_line":"Change-Id: I94aa182add471efbbe703f7b785040222f1f5c67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_5fbcb6ba","line":13,"updated":"2016-08-30 13:49:27.000000000","message":"Hey, I thought we were supposed to use Partial-Bug (https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references).","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9a96c8cb4c467886065c67fd55ac6e1ca444259d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"notifications, node provision state and maintenance mode"},{"line_number":11,"context_line":"notifications and describes the corresponding work items."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-Bug: #1606520"},{"line_number":14,"context_line":"Co-Authored-By: Vladyslav Drok \u003cvdrok@mirantis.com\u003e"},{"line_number":15,"context_line":"Change-Id: I94aa182add471efbbe703f7b785040222f1f5c67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_1ac0714f","line":13,"in_reply_to":"fa7ab95a_5fbcb6ba","updated":"2016-08-30 15:15:29.000000000","message":"Done","commit_id":"640846259865a7c0078873e58506e1cea1592af5"}],"specs/approved/crud-and-state-notifications.rst":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"1944d0e36db0c4135fd3c6b6d04701aaa2b21dd9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"* \"baremetal.\u003cresource\u003e.deleted\"."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Resource can be ``node``, ``port``, ``chassis`` and ``portgroup`` (after"},{"line_number":42,"context_line":"portgroups support will be added to ironic)."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Because CRUD operations can be executed via API or by ironic itself, these"},{"line_number":45,"context_line":"notifications will be implemented at the objects level."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_640c4343","line":42,"updated":"2016-08-08 13:04:05.000000000","message":"Nit: \"will be\" -\u003e \"has been\"","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"745e37c20ee0f2ad17acc33958492d7eb190f821","unresolved":false,"context_lines":[{"line_number":39,"context_line":"* \"baremetal.\u003cresource\u003e.deleted\"."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Resource can be ``node``, ``port``, ``chassis`` and ``portgroup`` (after"},{"line_number":42,"context_line":"portgroups support will be added to ironic)."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Because CRUD operations can be executed via API or by ironic itself, these"},{"line_number":45,"context_line":"notifications will be implemented at the objects level."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ac371cc_5ff90cc8","line":42,"in_reply_to":"9ad45d7e_640c4343","updated":"2016-08-14 21:44:15.000000000","message":"Done","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"48bbf3b4fcd2d26401420c2638f5d0b17af5db89","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"For node maintenance, two additional event types will be defined:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* \"baremetal.node.maintenance.start\";"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* \"baremetal.maintenance.end\"."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_90668827","line":49,"updated":"2016-08-09 15:32:09.000000000","message":"do you think we could split maintenance entered automatically (due to power failure) and maintenance applied by an operator? The former would use ERROR priority, the latter WARNING.","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"926703349d2aabadba834f9fab788b48564c80ec","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"For node maintenance, two additional event types will be defined:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* \"baremetal.node.maintenance.start\";"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* \"baremetal.maintenance.end\"."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ac371cc_6b8879e8","line":49,"in_reply_to":"3ac371cc_bf2f60f5","updated":"2016-08-15 12:44:26.000000000","message":"@Dmitry, I think it\u0027s not needed because if maintenance set automatically by ironic it\u0027s a result of error that happens before and two notifications will be sent: original error (power, state, with ERROR priority) and start maintenance (WARNING priority).","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"745e37c20ee0f2ad17acc33958492d7eb190f821","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"For node maintenance, two additional event types will be defined:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* \"baremetal.node.maintenance.start\";"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* \"baremetal.maintenance.end\"."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ac371cc_bf2f60f5","line":49,"in_reply_to":"9ad45d7e_90668827","updated":"2016-08-14 21:44:15.000000000","message":"Hm, looking at the code, we\u0027ll have to move the logic to the conductor manager. The sync_power_states task seems to be the only case when some special handling is needed, maybe instead of this split, add a separate event, like maybe power_sync_maintenance? If I\u0027m not mistaken, the only other way to enter maintenance automatically is during cleaning failure, and in this case we\u0027ll have error notification due to the provision state.","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"48bbf3b4fcd2d26401420c2638f5d0b17af5db89","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* \"baremetal.node.maintenance.start\";"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* \"baremetal.maintenance.end\"."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Node provision state notifications are also handled separately and are"},{"line_number":54,"context_line":"described in a separate section below."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_f06d4405","line":51,"updated":"2016-08-09 15:32:09.000000000","message":"+1, I think \"node\" is missing here","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"1944d0e36db0c4135fd3c6b6d04701aaa2b21dd9","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* \"baremetal.node.maintenance.start\";"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* \"baremetal.maintenance.end\"."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Node provision state notifications are also handled separately and are"},{"line_number":54,"context_line":"described in a separate section below."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_3fac12ed","line":51,"updated":"2016-08-08 13:04:05.000000000","message":"Why are these different? I think you should have \"baremetal.node.maintenance.(start|end)\" for consistency.","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"745e37c20ee0f2ad17acc33958492d7eb190f821","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* \"baremetal.node.maintenance.start\";"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* \"baremetal.maintenance.end\"."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Node provision state notifications are also handled separately and are"},{"line_number":54,"context_line":"described in a separate section below."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ac371cc_3ff6d0d7","line":51,"in_reply_to":"9ad45d7e_f06d4405","updated":"2016-08-14 21:44:15.000000000","message":"Done","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"48bbf3b4fcd2d26401420c2638f5d0b17af5db89","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* ``driver_internal_info`` for node and ``internal_info`` for port;"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* ``provision_updated_at`` for node;"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* ``power_state``, ``target_power_state``, ``provision_state``,"},{"line_number":80,"context_line":"  ``target_provision_state`` for node (these are handled separately);"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_d07000df","line":77,"updated":"2016-08-09 15:32:09.000000000","message":"then what about inspected_at and inspection_started_at?","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"745e37c20ee0f2ad17acc33958492d7eb190f821","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* ``driver_internal_info`` for node and ``internal_info`` for port;"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* ``provision_updated_at`` for node;"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* ``power_state``, ``target_power_state``, ``provision_state``,"},{"line_number":80,"context_line":"  ``target_provision_state`` for node (these are handled separately);"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ac371cc_bfa5a0b6","line":77,"in_reply_to":"9ad45d7e_d07000df","updated":"2016-08-14 21:44:15.000000000","message":"Both of these fields are not updated often, in a lot of cases only once right? So it should not be much of a burden to send the notifications when they are updated.","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"48bbf3b4fcd2d26401420c2638f5d0b17af5db89","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Priority levels - WARNING for start, INFO for end. Will be implemented"},{"line_number":103,"context_line":"via Node.save() method. Payload for start contains ``maintenance_reason`` and"},{"line_number":104,"context_line":"node UUID, for end - only UUID of the node."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Node provision state notifications"},{"line_number":107,"context_line":"----------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_30787cc4","line":104,"updated":"2016-08-09 15:32:09.000000000","message":"see above re automatic vs manual maintenance","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"48bbf3b4fcd2d26401420c2638f5d0b17af5db89","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* \"baremetal.node.provision_state_change.start\";"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* \"baremetal.node.provision_state_change.end\";"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"* \"baremetal.node.provision_state_change.fail\"."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_1073b8e8","line":115,"updated":"2016-08-09 15:32:09.000000000","message":"it\u0027s somewhat unclear whether end is triggered when fail is triggered. maybe call it \"done\" (I think that\u0027s how we call the final transition in many cases)?","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"745e37c20ee0f2ad17acc33958492d7eb190f821","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* \"baremetal.node.provision_state_change.start\";"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* \"baremetal.node.provision_state_change.end\";"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"* \"baremetal.node.provision_state_change.fail\"."},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ac371cc_dfd21c34","line":115,"in_reply_to":"9ad45d7e_1073b8e8","updated":"2016-08-14 21:44:15.000000000","message":"Nope, end is not triggered on fail. end is what was in the initial spec on notifications from Mario, and it\u0027s also what nova uses. Tho maybe \"success\" is better, let\u0027s see what others think.","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"1944d0e36db0c4135fd3c6b6d04701aaa2b21dd9","unresolved":false,"context_lines":[{"line_number":117,"context_line":"* \"baremetal.node.provision_state_change.fail\"."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Priority levels - ERROR for fail. For changes between unstable states"},{"line_number":120,"context_line":"notification priority will be DEBUG, INFO for stable provision states changes."},{"line_number":121,"context_line":"Here it is assumed that stable states are the ones in which the state change"},{"line_number":122,"context_line":"can be triggered only via API, all the others are unstable."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_da81844f","line":120,"updated":"2016-08-08 13:04:05.000000000","message":"s/,/;","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"745e37c20ee0f2ad17acc33958492d7eb190f821","unresolved":false,"context_lines":[{"line_number":117,"context_line":"* \"baremetal.node.provision_state_change.fail\"."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Priority levels - ERROR for fail. For changes between unstable states"},{"line_number":120,"context_line":"notification priority will be DEBUG, INFO for stable provision states changes."},{"line_number":121,"context_line":"Here it is assumed that stable states are the ones in which the state change"},{"line_number":122,"context_line":"can be triggered only via API, all the others are unstable."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ac371cc_ffe1d8ff","line":120,"in_reply_to":"9ad45d7e_da81844f","updated":"2016-08-14 21:44:15.000000000","message":"Done","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"48bbf3b4fcd2d26401420c2638f5d0b17af5db89","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Here it is assumed that stable states are the ones in which the state change"},{"line_number":122,"context_line":"can be triggered only via API, all the others are unstable."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"All events use the same payload with fields: ``prev_provision_state`` (previous"},{"line_number":125,"context_line":"provision state), ``prev_target_provision_state`` (previous target provision"},{"line_number":126,"context_line":"state), ``provision_state``, ``target_provision_state``, ``event`` (FSM event"},{"line_number":127,"context_line":"that triggered the state change)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_7082f495","line":124,"updated":"2016-08-09 15:32:09.000000000","message":"why shorten \"prev\"?","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"745e37c20ee0f2ad17acc33958492d7eb190f821","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Here it is assumed that stable states are the ones in which the state change"},{"line_number":122,"context_line":"can be triggered only via API, all the others are unstable."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"All events use the same payload with fields: ``prev_provision_state`` (previous"},{"line_number":125,"context_line":"provision state), ``prev_target_provision_state`` (previous target provision"},{"line_number":126,"context_line":"state), ``provision_state``, ``target_provision_state``, ``event`` (FSM event"},{"line_number":127,"context_line":"that triggered the state change)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ac371cc_5fe74c12","line":124,"in_reply_to":"9ad45d7e_7082f495","updated":"2016-08-14 21:44:15.000000000","message":"Done","commit_id":"7d865addd57025d0d0bac5cc147a6bb239439bc2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"73cba4f0633f80f66e850d79d4ea439448648762","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1606520"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes addition of new notifications to ironic: CRUD (create,"},{"line_number":14,"context_line":"update, or delete) of resources and node provision state changes."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_3fbff261","line":14,"updated":"2016-08-30 13:49:27.000000000","message":"as well as node maintenance","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9a96c8cb4c467886065c67fd55ac6e1ca444259d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1606520"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes addition of new notifications to ironic: CRUD (create,"},{"line_number":14,"context_line":"update, or delete) of resources and node provision state changes."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_6982a0c9","line":14,"in_reply_to":"fa7ab95a_3fbff261","updated":"2016-08-30 15:15:29.000000000","message":"Done","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"73cba4f0633f80f66e850d79d4ea439448648762","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* \"baremetal.node.maintenance.start\";"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* \"baremetal.node.maintenance.end\"."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Node provision state notifications are also handled separately and are"},{"line_number":54,"context_line":"described in a separate section below."}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_c229c9e7","line":51,"updated":"2016-08-30 13:49:27.000000000","message":"I\u0027m a bit dyslexic I think. What does this mean? 1. start \u003d\u003d maintenance on and end \u003d\u003d maintenance off; 2. a request is issued to set maintenance to True or False; start \u003d\u003d start of the request and end \u003d\u003d end of the request.","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9a96c8cb4c467886065c67fd55ac6e1ca444259d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* \"baremetal.node.maintenance.start\";"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* \"baremetal.node.maintenance.end\"."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Node provision state notifications are also handled separately and are"},{"line_number":54,"context_line":"described in a separate section below."}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_0953d439","line":51,"in_reply_to":"fa7ab95a_c229c9e7","updated":"2016-08-30 15:15:29.000000000","message":"I think better to use on/off terms here.","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"73cba4f0633f80f66e850d79d4ea439448648762","unresolved":false,"context_lines":[{"line_number":66,"context_line":"--------------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Priority level - DEBUG. Will be implemented via object\u0027s save() method."},{"line_number":69,"context_line":"Payload contains all the resource fields which exposed via API."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Updates of the following fields will not trigger a notification:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_c2c70994","line":69,"updated":"2016-08-30 13:49:27.000000000","message":"s/exposed/are exposed/\n\nIf we add new fields to a resource, do we need to worry about versioning of these payloads/notifications? OH -- the payloads are versioned objects, right?","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9a96c8cb4c467886065c67fd55ac6e1ca444259d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"--------------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Priority level - DEBUG. Will be implemented via object\u0027s save() method."},{"line_number":69,"context_line":"Payload contains all the resource fields which exposed via API."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Updates of the following fields will not trigger a notification:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_e6eb3a11","line":69,"in_reply_to":"fa7ab95a_c2c70994","updated":"2016-08-30 15:15:29.000000000","message":"Yes, ironic implements versioned notifications.","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"73cba4f0633f80f66e850d79d4ea439448648762","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Node maintenance notifications"},{"line_number":100,"context_line":"------------------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Priority levels - WARNING for start, INFO for end. Will be implemented"},{"line_number":103,"context_line":"via Node.save() method. Payload for start contains ``maintenance_reason`` and"},{"line_number":104,"context_line":"node UUID, for end - only UUID of the node."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_f854c0ca","line":102,"updated":"2016-08-30 13:49:27.000000000","message":"why is it a warning for start? If the operator sets it, then wouldn\u0027t it just be info? Or is it warning cuz putting a node in maintenance mode is viewed as serious?","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9a96c8cb4c467886065c67fd55ac6e1ca444259d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Node maintenance notifications"},{"line_number":100,"context_line":"------------------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Priority levels - WARNING for start, INFO for end. Will be implemented"},{"line_number":103,"context_line":"via Node.save() method. Payload for start contains ``maintenance_reason`` and"},{"line_number":104,"context_line":"node UUID, for end - only UUID of the node."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_a48ccdda","line":102,"in_reply_to":"fa7ab95a_f854c0ca","updated":"2016-08-30 15:15:29.000000000","message":"Done","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"73cba4f0633f80f66e850d79d4ea439448648762","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Priority levels - WARNING for start, INFO for end. Will be implemented"},{"line_number":103,"context_line":"via Node.save() method. Payload for start contains ``maintenance_reason`` and"},{"line_number":104,"context_line":"node UUID, for end - only UUID of the node."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Node provision state notifications"},{"line_number":107,"context_line":"----------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_b89958c6","line":104,"updated":"2016-08-30 13:49:27.000000000","message":"by \u0027start\u0027 it looks like we mean, enabling or putting a node in maintenance mode, and \u0027end\u0027 means the node is not in maintenance mode.\n\nI wonder if something else (enable/disable) might make more sense. Although I see that we have power start/end (I need to understand more about this stuff.)","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"73cba4f0633f80f66e850d79d4ea439448648762","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* \"baremetal.node.provision_state_change.end\";"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"* \"baremetal.node.provision_state_change.fail\"."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Priority levels - ERROR for fail. For changes between unstable states"},{"line_number":120,"context_line":"notification priority will be DEBUG; INFO for stable provision states changes."}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_339e49b9","line":117,"updated":"2016-08-30 13:49:27.000000000","message":"Maybe clarify which provision states are of interest. Are all of them including *_WAIT going to have corresponding notifications?\n\na *FAIL is a provision state too. I\u0027m not sure how that works with .start, .end, and .fail.\n\nstart \u003d\u003d starting the change for a node to go to target_provision_state?","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"73cba4f0633f80f66e850d79d4ea439448648762","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Other deployer impact"},{"line_number":196,"context_line":"---------------------"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Deployers should set ``notification_priority`` config options properly if"},{"line_number":199,"context_line":"they want or do not want to receive different types of notifications events."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_13e06595","line":198,"updated":"2016-08-30 13:49:27.000000000","message":"Is this a new config option?","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9a96c8cb4c467886065c67fd55ac6e1ca444259d","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Other deployer impact"},{"line_number":196,"context_line":"---------------------"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Deployers should set ``notification_priority`` config options properly if"},{"line_number":199,"context_line":"they want or do not want to receive different types of notifications events."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_29e098cc","line":198,"in_reply_to":"fa7ab95a_13e06595","updated":"2016-08-30 15:15:29.000000000","message":"Done","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"96ec0b73824f2361dec85fb0b3356c855f936302","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Other deployer impact"},{"line_number":196,"context_line":"---------------------"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Deployers should set ``notification_priority`` config options properly if"},{"line_number":199,"context_line":"they want or do not want to receive different types of notifications events."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_ed4f928f","line":198,"in_reply_to":"fa7ab95a_29e098cc","updated":"2016-08-30 16:08:27.000000000","message":"It is a new config option introduced by https://review.openstack.org/#/c/298461/\n\nIt\u0027s actually called notification_level and the spec was updated here to reflect that.","commit_id":"640846259865a7c0078873e58506e1cea1592af5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"852e18b0a108eb6c07a8e18b0916f496ffb976ce","unresolved":false,"context_lines":[{"line_number":33,"context_line":"New notifications will be based on the proposed code [#]_. The following event"},{"line_number":34,"context_line":"types will be added for CRUD operations:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* \"baremetal.\u003cresource\u003e.created\";"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* \"baremetal.\u003cresource\u003e.updated\";"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa7ab95a_32a215af","line":36,"updated":"2016-09-01 20:43:42.000000000","message":"baremetal.\u003cresource\u003e.create.\u003cstatus\u003e\nbaremetal.\u003cresource\u003e.update.\u003cstatus\u003e\nbaremetal.\u003cresource\u003e.delete.\u003cstatus\u003e\n\nwhere \u003cstatus\u003e is \u0027success\u0027 or \u0027fail\u0027.","commit_id":"a6e635ed85bb1a32c2ed3bb0440ef07015ed28e1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"852e18b0a108eb6c07a8e18b0916f496ffb976ce","unresolved":false,"context_lines":[{"line_number":43,"context_line":"portgroups support has been added to ironic)."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Because CRUD operations can be executed via API or by ironic itself, these"},{"line_number":46,"context_line":"notifications will be implemented at the objects level."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"For node maintenance, two additional event types will be defined:"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa7ab95a_925cc17e","line":46,"updated":"2016-09-01 20:43:42.000000000","message":"Let\u0027s say I want to get notifications. And some API request comes in to eg create a node with an invalid network interface. The API layer will return a FAIL before it ever gets to the objects level. And I won\u0027t get any notification. Should I? (I\u0027m still not quite clear as to what the notifications might be used for, or what an operator might be interested in.)","commit_id":"a6e635ed85bb1a32c2ed3bb0440ef07015ed28e1"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4f8ec78316aa551269bd218182c4fbf68be8cf31","unresolved":false,"context_lines":[{"line_number":43,"context_line":"portgroups support has been added to ironic)."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Because CRUD operations can be executed via API or by ironic itself, these"},{"line_number":46,"context_line":"notifications will be implemented at the objects level."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"For node maintenance, two additional event types will be defined:"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa7ab95a_37c58e8d","line":46,"in_reply_to":"fa7ab95a_925cc17e","updated":"2016-09-02 09:09:28.000000000","message":"What is use case for CRUD FAIL? \u0027success\u0027 is needed for resource indexation services, mentioned in \"Problem description\".","commit_id":"a6e635ed85bb1a32c2ed3bb0440ef07015ed28e1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"852e18b0a108eb6c07a8e18b0916f496ffb976ce","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* \"baremetal.node.maintenance.on\";"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* \"baremetal.node.maintenance.off\"."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Node provision state notifications are also handled separately and are"},{"line_number":55,"context_line":"described in a separate section below."}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa7ab95a_32905543","line":52,"updated":"2016-09-01 20:43:42.000000000","message":"based on the baremetal.node.power_set event type, I wonder if this should just be one notification, with the payload indicating if it is on or off, eg\n\nbaremetal.node.maintenance_mode.\u003cstatus\u003e ?","commit_id":"a6e635ed85bb1a32c2ed3bb0440ef07015ed28e1"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4f8ec78316aa551269bd218182c4fbf68be8cf31","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* \"baremetal.node.maintenance.on\";"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* \"baremetal.node.maintenance.off\"."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Node provision state notifications are also handled separately and are"},{"line_number":55,"context_line":"described in a separate section below."}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa7ab95a_3714ae42","line":52,"in_reply_to":"fa7ab95a_32905543","updated":"2016-09-02 09:09:28.000000000","message":"Like https://review.openstack.org/#/c/364422/3/specs/approved/notifications.rst should be \"baremetal.node.maintenance_set.success\" with maintenance payload.","commit_id":"a6e635ed85bb1a32c2ed3bb0440ef07015ed28e1"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"0412794cc73b74ada5902b76e15d1eaa7d05ea2f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"* Set \"provision_state\" to one of error states: \"fail\" notification with"},{"line_number":128,"context_line":"  ERROR level."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* Change \"provision_state\" from one unstable state to another: \"end\""},{"line_number":131,"context_line":"  notification with DEBUG level."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Here it is assumed that unstable states are: DEPLOYING, DEPLOYWAIT, CLEANING,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa7ab95a_0d59168e","line":130,"updated":"2016-08-30 16:08:19.000000000","message":"Can you clarify this behavior?\n\nI\u0027m specifically curious what happens in these cases:\n\nDEPLOY -\u003e DEPLOYWAIT -\u003e DEPLOYING -\u003e ACTIVE\n\nor\n\nCLEAN -\u003e CLEANWAIT -\u003e CLEAN -\u003e AVAILABLE\n\nDoes the notification stream go like this?\n\nstart INFO -\u003e end DEBUG -\u003e start INFO -\u003e end INFO\n\nIf a user has notification_level set to INFO, then they\u0027ll see this?\n\nstart INFO -\u003e start INFO -\u003e end INFO\n\nPerhaps it\u0027s worth adding a work item to document the expected notification flow. If we decide to do that, I\u0027ll update my power state notifications patch (https://review.openstack.org/#/c/321865/) to do so as well.","commit_id":"a6e635ed85bb1a32c2ed3bb0440ef07015ed28e1"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a44b40cbdba7f079d49b6b7bb28bcccb64a37341","unresolved":false,"context_lines":[{"line_number":127,"context_line":"* Set \"provision_state\" to one of error states: \"fail\" notification with"},{"line_number":128,"context_line":"  ERROR level."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* Change \"provision_state\" from one unstable state to another: \"end\""},{"line_number":131,"context_line":"  notification with DEBUG level."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Here it is assumed that unstable states are: DEPLOYING, DEPLOYWAIT, CLEANING,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa7ab95a_2b51300f","line":130,"in_reply_to":"fa7ab95a_0d59168e","updated":"2016-08-31 10:35:11.000000000","message":"For your example \n\nAVAILABLE -\u003e DEPLOYING -\u003e DEPLOYWAIT -\u003e DEPLOYING -\u003e ACTIVE\n\nstart INFO -\u003e end DEBUG -\u003e end DEBUG -\u003e end INFO\n\nfor users point of view deploying is single process, and quick DEPLOYING \u003c-\u003e DEPLOYWAIT changes may not be interested,\non INFO level we will see only\n\nstart INFO -\u003e end INFO\n\nI test now this patch https://review.openstack.org/#/c/348437/ with PoC searchlight plugin, it works.","commit_id":"a6e635ed85bb1a32c2ed3bb0440ef07015ed28e1"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1b6e2d98018b022d296af4c3bd40660923c40505","unresolved":false,"context_lines":[{"line_number":33,"context_line":"New notifications will be based on the proposed code [#]_. The following event"},{"line_number":34,"context_line":"types will be added for CRUD operations:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* \"baremetal.\u003cresource\u003e.create.success\u0027;"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* \"baremetal.\u003cresource\u003e.update.success\";"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_9f77f307","line":36,"range":{"start_line":36,"start_character":38,"end_line":36,"end_character":40},"updated":"2016-09-08 20:28:15.000000000","message":"nit: s/\u0027/\" to match open quote","commit_id":"0bee3b3a50b1720b0f431fbf877ae5177825e545"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d4a89380916d8ba76794fdb1dda0802d5d9c1aee","unresolved":false,"context_lines":[{"line_number":33,"context_line":"New notifications will be based on the proposed code [#]_. The following event"},{"line_number":34,"context_line":"types will be added for CRUD operations:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* \"baremetal.\u003cresource\u003e.create.success\u0027;"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* \"baremetal.\u003cresource\u003e.update.success\";"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_8d184986","line":36,"range":{"start_line":36,"start_character":38,"end_line":36,"end_character":40},"in_reply_to":"9a89bdaa_9f77f307","updated":"2016-09-12 08:08:02.000000000","message":"Done","commit_id":"0bee3b3a50b1720b0f431fbf877ae5177825e545"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1b6e2d98018b022d296af4c3bd40660923c40505","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* \"baremetal.\u003cresource\u003e.update.success\";"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* \"baremetal.\u003cresource\u003e.delete.success."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Resource can be ``node``, ``port``, ``chassis`` and ``portgroup`` (after"},{"line_number":43,"context_line":"portgroups support has been added to ironic)."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_df817bc5","line":40,"range":{"start_line":40,"start_character":38,"end_line":40,"end_character":39},"updated":"2016-09-08 20:28:15.000000000","message":"nit: end quote missing here","commit_id":"0bee3b3a50b1720b0f431fbf877ae5177825e545"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d4a89380916d8ba76794fdb1dda0802d5d9c1aee","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* \"baremetal.\u003cresource\u003e.update.success\";"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* \"baremetal.\u003cresource\u003e.delete.success."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Resource can be ``node``, ``port``, ``chassis`` and ``portgroup`` (after"},{"line_number":43,"context_line":"portgroups support has been added to ironic)."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_ad1b4d7f","line":40,"range":{"start_line":40,"start_character":38,"end_line":40,"end_character":39},"in_reply_to":"9a89bdaa_df817bc5","updated":"2016-09-12 08:08:02.000000000","message":"Done","commit_id":"0bee3b3a50b1720b0f431fbf877ae5177825e545"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1b6e2d98018b022d296af4c3bd40660923c40505","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  .. note::"},{"line_number":46,"context_line":"    Scope of this spec is limited in the \"Problem description\" section."},{"line_number":47,"context_line":"    CRUD notifications with \"fail\" status can be added later for a real use"},{"line_number":48,"context_line":"    case."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Because CRUD operations can be executed via API or by ironic itself, these"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_5f4d6bc3","line":47,"range":{"start_line":47,"start_character":29,"end_line":47,"end_character":33},"updated":"2016-09-08 20:28:15.000000000","message":"nit: this will likely change to \"error\" if that spec update merges","commit_id":"0bee3b3a50b1720b0f431fbf877ae5177825e545"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1b6e2d98018b022d296af4c3bd40660923c40505","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Priority level - INFO. Will be implemented via object\u0027s create() method."},{"line_number":64,"context_line":"Payload contains all the resource fields which are exposed via API. New global"},{"line_number":65,"context_line":"variable that represents service type (\"api\" or \"conductor\") will be set"},{"line_number":66,"context_line":"during the corresponding service startup. It is needed to determine the"},{"line_number":67,"context_line":"source of the events."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_bf98371d","line":65,"updated":"2016-09-08 20:28:15.000000000","message":"I\u0027m guessing that this will be needed to make the publisher_id descriptive, good idea","commit_id":"0bee3b3a50b1720b0f431fbf877ae5177825e545"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1b6e2d98018b022d296af4c3bd40660923c40505","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* \"baremetal.node.provision_set.end\";"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* \"baremetal.node.provision_set.fail\";"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"* \"baremetal.node.provision_set.success\"."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_df397bf4","line":120,"range":{"start_line":120,"start_character":32,"end_line":120,"end_character":36},"updated":"2016-09-08 20:28:15.000000000","message":"This will likely change to \"error\" when/if the spec update merges","commit_id":"0bee3b3a50b1720b0f431fbf877ae5177825e545"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d4a89380916d8ba76794fdb1dda0802d5d9c1aee","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* \"baremetal.node.provision_set.end\";"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* \"baremetal.node.provision_set.fail\";"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"* \"baremetal.node.provision_set.success\"."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_48354fd8","line":120,"range":{"start_line":120,"start_character":32,"end_line":120,"end_character":36},"in_reply_to":"9a89bdaa_df397bf4","updated":"2016-09-12 08:08:02.000000000","message":"Done","commit_id":"0bee3b3a50b1720b0f431fbf877ae5177825e545"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1b6e2d98018b022d296af4c3bd40660923c40505","unresolved":false,"context_lines":[{"line_number":129,"context_line":"* End transition, cleaning \"target_provision_state\": \"end\" notification with"},{"line_number":130,"context_line":"  INFO level."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* Set \"provision_state\" to one of error states: \"fail\" notification with"},{"line_number":133,"context_line":"  ERROR level."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"* Change \"provision_state\" from one unstable state to another: \"success\""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_7f2b0f95","line":132,"range":{"start_line":132,"start_character":49,"end_line":132,"end_character":53},"updated":"2016-09-08 20:28:15.000000000","message":"ditto from L120","commit_id":"0bee3b3a50b1720b0f431fbf877ae5177825e545"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d4a89380916d8ba76794fdb1dda0802d5d9c1aee","unresolved":false,"context_lines":[{"line_number":129,"context_line":"* End transition, cleaning \"target_provision_state\": \"end\" notification with"},{"line_number":130,"context_line":"  INFO level."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* Set \"provision_state\" to one of error states: \"fail\" notification with"},{"line_number":133,"context_line":"  ERROR level."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"* Change \"provision_state\" from one unstable state to another: \"success\""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_28364be7","line":132,"range":{"start_line":132,"start_character":49,"end_line":132,"end_character":53},"in_reply_to":"9a89bdaa_7f2b0f95","updated":"2016-09-12 08:08:02.000000000","message":"Done","commit_id":"0bee3b3a50b1720b0f431fbf877ae5177825e545"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d0e3a40b37144bf4bbe09b4ed546071f3847d1e1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  .. note::"},{"line_number":46,"context_line":"    Scope of this spec is limited in the \"Problem description\" section."},{"line_number":47,"context_line":"    CRUD notifications with \"error\" status can be added later for a real use"},{"line_number":48,"context_line":"    case."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Because CRUD operations can be executed via API or by ironic itself, these"},{"line_number":51,"context_line":"notifications will be implemented at the objects level."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_e4822ec8","line":48,"updated":"2016-09-13 18:59:48.000000000","message":"Probably don\u0027t want to indent this note.","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"47351a66da6153b4c8739672801bb81eb2c3fafb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  .. note::"},{"line_number":46,"context_line":"    Scope of this spec is limited in the \"Problem description\" section."},{"line_number":47,"context_line":"    CRUD notifications with \"error\" status can be added later for a real use"},{"line_number":48,"context_line":"    case."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Because CRUD operations can be executed via API or by ironic itself, these"},{"line_number":51,"context_line":"notifications will be implemented at the objects level."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_1318171d","line":48,"in_reply_to":"7a8ec9b2_e4822ec8","updated":"2016-09-14 13:18:11.000000000","message":"Done","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d0e3a40b37144bf4bbe09b4ed546071f3847d1e1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"--------------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Priority level - INFO. Will be implemented via object\u0027s create() method."},{"line_number":64,"context_line":"Payload contains all the resource fields which are exposed via API. New global"},{"line_number":65,"context_line":"variable that represents service type (\"api\" or \"conductor\") will be set"},{"line_number":66,"context_line":"during the corresponding service startup. It is needed to determine the"},{"line_number":67,"context_line":"source of the events."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_0781dc4a","line":64,"updated":"2016-09-13 18:59:48.000000000","message":"to clarify, by \u0027via API\u0027, you mean any fields that may be exposed, regardless of microversion?","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"47351a66da6153b4c8739672801bb81eb2c3fafb","unresolved":false,"context_lines":[{"line_number":61,"context_line":"--------------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Priority level - INFO. Will be implemented via object\u0027s create() method."},{"line_number":64,"context_line":"Payload contains all the resource fields which are exposed via API. New global"},{"line_number":65,"context_line":"variable that represents service type (\"api\" or \"conductor\") will be set"},{"line_number":66,"context_line":"during the corresponding service startup. It is needed to determine the"},{"line_number":67,"context_line":"source of the events."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_6e9fb003","line":64,"in_reply_to":"7a8ec9b2_0781dc4a","updated":"2016-09-14 13:18:11.000000000","message":"Correspond to the latest microversion, updated.","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d0e3a40b37144bf4bbe09b4ed546071f3847d1e1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Payload contains all the resource fields which are exposed via API. New global"},{"line_number":65,"context_line":"variable that represents service type (\"api\" or \"conductor\") will be set"},{"line_number":66,"context_line":"during the corresponding service startup. It is needed to determine the"},{"line_number":67,"context_line":"source of the events."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Update notifications"},{"line_number":70,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_e7f23006","line":67,"updated":"2016-09-13 18:59:48.000000000","message":"Isn\u0027t this also needed for the publisher_id of the notification, or are they different things?","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"47351a66da6153b4c8739672801bb81eb2c3fafb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Payload contains all the resource fields which are exposed via API. New global"},{"line_number":65,"context_line":"variable that represents service type (\"api\" or \"conductor\") will be set"},{"line_number":66,"context_line":"during the corresponding service startup. It is needed to determine the"},{"line_number":67,"context_line":"source of the events."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Update notifications"},{"line_number":70,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_30ad06ea","line":67,"in_reply_to":"7a8ec9b2_e7f23006","updated":"2016-09-14 13:18:11.000000000","message":"Yes, for \"service\" part of \"publisher_id\", done.","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d0e3a40b37144bf4bbe09b4ed546071f3847d1e1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Update notifications"},{"line_number":70,"context_line":"--------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Priority level - DEBUG. Will be implemented via object\u0027s save() method."},{"line_number":73,"context_line":"Payload contains all the resource fields which are exposed via API."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Updates of the following fields will not trigger a notification:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_e78230c8","line":72,"updated":"2016-09-13 18:59:48.000000000","message":"why DEBUG? Why not INFO?","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"546ba045b17ef68e7845989306c43f6fab85a4f7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Update notifications"},{"line_number":70,"context_line":"--------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Priority level - DEBUG. Will be implemented via object\u0027s save() method."},{"line_number":73,"context_line":"Payload contains all the resource fields which are exposed via API."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Updates of the following fields will not trigger a notification:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a8bc5a2_2616ea4b","line":72,"in_reply_to":"5a8bc5a2_b9017db1","updated":"2016-09-27 14:45:52.000000000","message":"@Grzegorz. If operation is state change now we agree that most of node\u0027s fields should be included in base notifications, and only state changes notifications can be used for this case, http://lists.openstack.org/pipermail/openstack-dev/2016-September/104587.html For other cases the simplest solution is time aggregation of changes (if your environment tolerate to small delays, ~1 second will be enough). More sophisticated solutions probably will require a lot of changes to ironic code.","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"6c1779af00a916d7cde444fc2a78040c1bbb0af7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Update notifications"},{"line_number":70,"context_line":"--------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Priority level - DEBUG. Will be implemented via object\u0027s save() method."},{"line_number":73,"context_line":"Payload contains all the resource fields which are exposed via API."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Updates of the following fields will not trigger a notification:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a8bc5a2_b9017db1","line":72,"in_reply_to":"7a8ec9b2_13a494a4","updated":"2016-09-26 16:40:17.000000000","message":"I think this is an important piece of information. Do you think there is a way that we could filter these notifications, so that searchlight would get and index only the final operation in that chain? Do you think that\u0027s possible? I think it could reduce the load on the message bus by a considerable margin and you would still get the desired final result of an updated index.","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"47351a66da6153b4c8739672801bb81eb2c3fafb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Update notifications"},{"line_number":70,"context_line":"--------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Priority level - DEBUG. Will be implemented via object\u0027s save() method."},{"line_number":73,"context_line":"Payload contains all the resource fields which are exposed via API."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Updates of the following fields will not trigger a notification:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_13a494a4","line":72,"in_reply_to":"7a8ec9b2_e78230c8","updated":"2016-09-14 13:18:11.000000000","message":"Ironic can execute DB node updates very often (during deploy procedure for example). Every operation causes chain of DB updates on different levels (conductor, fsm, drivers). So ironic can generate many updates in the short time period (this is a difference with other services like neutron, glance etc). I think administrator should be able to control these type of notifications (off/on).","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4ab0a584de00cb75d5f3741d428b3ab161e746cb","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* ``updated_at`` for all resources;"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* ``driver_internal_info`` for node and ``internal_info`` for port;"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* ``provision_updated_at`` for node;"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a89bdaa_235f0942","line":79,"updated":"2016-09-13 09:28:36.000000000","message":"Does this data have a well defined schema or it is just a dict? Does different drivers use different schema for this field? The goal of the versioned notification is to have well defined payload so the consumer could now what to expect.","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d0e3a40b37144bf4bbe09b4ed546071f3847d1e1","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* ``updated_at`` for all resources;"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* ``driver_internal_info`` for node and ``internal_info`` for port;"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* ``provision_updated_at`` for node;"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_4d10654f","line":79,"in_reply_to":"9a89bdaa_0064b61f","updated":"2016-09-13 18:59:48.000000000","message":"Balazs, internally, ironic keeps some temporary information in those two dicts \u0027driver_internal_info\u0027 and \u0027internal_info\u0027.\n\nIt does make me wonder, Yuriy, whether we should be putting these in the payload, even though they are available via the API. Presumably, notifications are not going to be used for debugging, so we may not want to provide them.","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"bc3a9606e17632c0ca16111b216b1f00563ee3da","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* ``updated_at`` for all resources;"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* ``driver_internal_info`` for node and ``internal_info`` for port;"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* ``provision_updated_at`` for node;"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a89bdaa_0064b61f","line":79,"in_reply_to":"9a89bdaa_235f0942","updated":"2016-09-13 10:17:35.000000000","message":"No. This is driver-specific. FlexibleDictField() used for this field: https://review.openstack.org/#/c/356541/7/ironic/objects/node.py","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d0e3a40b37144bf4bbe09b4ed546071f3847d1e1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"--------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Priority level - INFO. Will be implemented via object\u0027s destroy() method."},{"line_number":101,"context_line":"Payload contains only resource UUID."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Node maintenance notifications"},{"line_number":104,"context_line":"------------------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_32953840","line":101,"updated":"2016-09-13 18:59:48.000000000","message":"What do you think about having the same payload as for .create \u0026 .update? I have no idea what it would be used for, but it would be available in case the info is desired. \n\nI looked at nova\u0027s notifications, and it looks like they return the same \"base\" payload for instance.update|delete, etc, even power_on: http://docs.openstack.org/developer/nova/notifications.html#existing-versioned-notifications.","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"47351a66da6153b4c8739672801bb81eb2c3fafb","unresolved":false,"context_lines":[{"line_number":98,"context_line":"--------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Priority level - INFO. Will be implemented via object\u0027s destroy() method."},{"line_number":101,"context_line":"Payload contains only resource UUID."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Node maintenance notifications"},{"line_number":104,"context_line":"------------------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_5659aa59","line":101,"in_reply_to":"7a8ec9b2_32953840","updated":"2016-09-14 13:18:11.000000000","message":"Not sure. I don\u0027t know as information from a node on deletion moment can be used.","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d0e3a40b37144bf4bbe09b4ed546071f3847d1e1","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  notification with DEBUG level."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Here it is assumed that unstable states are: DEPLOYING, DEPLOYWAIT, CLEANING,"},{"line_number":139,"context_line":"CLEANWAIT, VERIFYING, DELETING, INSPECTING, ADOPTING."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"All events use the same payload with fields: ``previous_provision_state``,"},{"line_number":142,"context_line":"``previous_target_provision_state``, ``provision_state``,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8ec9b2_125f5c73","line":139,"updated":"2016-09-13 18:59:48.000000000","message":"This is interesting. I think I like it :)","commit_id":"b35241d13e54898e8ba5fdd16822596881017361"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0b5729c63dba1e8014c19bd06bae09820793117c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"notifications with \"error\" status can be added later for a real use case."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Because CRUD operations can be executed via API or by ironic itself, these"},{"line_number":48,"context_line":"notifications will be implemented at the objects level."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"For node maintenance, additional event type will be defined:"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_8ddcdc13","line":48,"updated":"2016-09-29 17:37:00.000000000","message":"I wonder if we should revisit this. What I mean is, maybe the CRUD notifications should be done at the API level, not the objects level. Or at least some of the CRUD notifications (which may not be \u0027consistent\u0027 with them all being done at the same level, but may be \u0027consistent\u0027 in what we mean by that notification. Eg:\n1. create. ironic itself, never creates a resource internally. The creates have to be via an API request. If we emit the notification at the end of a create request, then the performance issue (wrt getting eg chassis uuid for a node) isn\u0027t an issue cuz the info will be available. An .error notification could be issued at this level too.\n2. delete. ironic doesn\u0027t delete a resource internally; it needs to be initiated via an API request. (Looks like the node info is avail in \u0027rpc_node\u0027 variable in ...node.NodesController.delete() so again, don\u0027t need to pay the performance penalty of getting eg the chassis UUID for a node.)\n3. update. If we are interested in issuing update notifications based on user-updates, the API level would be the place where that happens. I\u0027m not sure what other updates happen by ironic doing it internally, that aren\u0027t covered by the other types of notifications described in this spec (maintenance, provision state, power states in mario\u0027s work).\n\nWhat do you think?","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bfa9fbde2eb4b92368596af766500a43c91467cb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"notifications with \"error\" status can be added later for a real use case."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Because CRUD operations can be executed via API or by ironic itself, these"},{"line_number":48,"context_line":"notifications will be implemented at the objects level."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"For node maintenance, additional event type will be defined:"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_1911585d","line":48,"in_reply_to":"3a98d1f4_248d847b","updated":"2016-10-04 01:30:01.000000000","message":"Good points. I think that it still makes sense to issue some of the notifications at the API level, eg the crud ones as you mention in the latest version.\n\nFor resource updates that are done internally, it might make sense to emit those notifications at the location where there are being updated, and to include in the payload, some indication/reason for the update? Eg, might it be useful to know if it is due to a conductor takeover? (Or maybe it isn\u0027t useful, not sure that we want to expose that.)\n\nwrt passthru vendor methods -- maybe we deal with them on a case-by-case basis, since they are vendor passthru methods :-( And/or they are out of scope of this spec...\n\nI wonder if there is anything we can put in eg the context, so that at the object-level, we can determine whether or not to emit an object-based notification (versus emitting a notification at the api level).","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97057491dd2c5731f0477c75fafc1fa6b2ac9cda","unresolved":false,"context_lines":[{"line_number":45,"context_line":"notifications with \"error\" status can be added later for a real use case."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Because CRUD operations can be executed via API or by ironic itself, these"},{"line_number":48,"context_line":"notifications will be implemented at the objects level."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"For node maintenance, additional event type will be defined:"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_248d847b","line":48,"in_reply_to":"3a98d1f4_8ddcdc13","updated":"2016-09-30 09:31:09.000000000","message":"You proposal makes sense, but I have some comments on this point.\n\n[1] \"ironic itself, never creates a resource internally\" This is not right. Drivers create ports: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/irmc/inspect.py#L177  https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/inspect.py#L56\n\n[3] \"I\u0027m not sure what other updates happen by ironic doing it internally, that aren\u0027t covered by the other types of notifications\" A good counterexample is start/stop console. It initiated via API, but conductor updates the node in async thread, it does not update power or provision state. There is also a problem that node updates (not only driver_internal_info) mixed in some drivers with hardware operations. Let\u0027s consider the following situation: 1) driver updates the node 2) driver starts hardware action 3) hardware action takes unpredictable time or stuck into 3-party library Is this delay is good for users? Changes already in the db.\n\nAlso some funny links:\n\nConductor update nodes at start https://github.com/openstack/ironic/blob/master/ironic/conductor/base_manager.py\n\nConductor update nodes in the periodic task\n\nhttps://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1391\n\nAnd a pearl, driver update node\u0027s properties in the vendor method https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/seamicro.py#L462\n\nAnd this is only quick look on the ironic tree code. The examples like above is the reason why first implementation of CRUD notification uses objects layer, and I think that objects-based notification should be an option for users.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"5b11012094b2c2517e12dbaf6918dd1bb5462394","unresolved":false,"context_lines":[{"line_number":58,"context_line":"--------------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Priority level - INFO. Will be implemented via object\u0027s create() method."},{"line_number":61,"context_line":"Payload contains all the resource fields which are exposed via API in the"},{"line_number":62,"context_line":"latest microversion. New global variable that represents service type (\"api\""},{"line_number":63,"context_line":"or \"conductor\") will be set during the corresponding service startup."},{"line_number":64,"context_line":"It is needed to determine the source of the events (\"service\" part of"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a8bc5a2_f205d710","line":61,"updated":"2016-09-26 18:26:51.000000000","message":"This looks good to me, and I think Searchlight will be happy with it.\n\nThis won\u0027t require a spec update and can just be done in code, but you may want to subclass NodePayload from https://review.openstack.org/#/c/321865/ once we decide what will go in there, for the node CRUD notifications.\n\nI think as long as we include a subset of the fields in the NodePayload in the power state patch, whatever\u0027s not in NodePayload and exposed on nodes via API can be just put into the subclass that\u0027s made for the CRUD notifications.\n\nMaybe this will be clearer once I start reviewing the code for the CRUD notifications.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e400d74d0226fb5f44f3f039b4cb008a2266e2a7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"--------------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Priority level - INFO. Will be implemented via object\u0027s create() method."},{"line_number":61,"context_line":"Payload contains all the resource fields which are exposed via API in the"},{"line_number":62,"context_line":"latest microversion. New global variable that represents service type (\"api\""},{"line_number":63,"context_line":"or \"conductor\") will be set during the corresponding service startup."},{"line_number":64,"context_line":"It is needed to determine the source of the events (\"service\" part of"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_a1870660","line":61,"in_reply_to":"3a98d1f4_143568d9","updated":"2016-09-29 09:05:43.000000000","message":"Main goal for CRUD notifications is Searchlight, but they are generic, other use cases are possible. I can not predict all of them. Even \"driver_internal_info\" field can contains helpful information (last IPA heartbeat time). If you know some useful cases and sure about non-useful you are welcome to comment this spec and describe these information.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0b5729c63dba1e8014c19bd06bae09820793117c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"--------------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Priority level - INFO. Will be implemented via object\u0027s create() method."},{"line_number":61,"context_line":"Payload contains all the resource fields which are exposed via API in the"},{"line_number":62,"context_line":"latest microversion. New global variable that represents service type (\"api\""},{"line_number":63,"context_line":"or \"conductor\") will be set during the corresponding service startup."},{"line_number":64,"context_line":"It is needed to determine the source of the events (\"service\" part of"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_fb127908","line":61,"in_reply_to":"3a98d1f4_a1870660","updated":"2016-09-29 17:37:00.000000000","message":"I don\u0027t think we should expose driver_internal_info. It is internal for a reason. If someone has a usecase for accessing some data from driver_internal_info, we can revisit it. Maybe expose it in its own field. I think that driver_internal_info should only be used for debugging... (fwiw, Devananda didn\u0027t want to expose driver_internal_info in the API.)","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97057491dd2c5731f0477c75fafc1fa6b2ac9cda","unresolved":false,"context_lines":[{"line_number":58,"context_line":"--------------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Priority level - INFO. Will be implemented via object\u0027s create() method."},{"line_number":61,"context_line":"Payload contains all the resource fields which are exposed via API in the"},{"line_number":62,"context_line":"latest microversion. New global variable that represents service type (\"api\""},{"line_number":63,"context_line":"or \"conductor\") will be set during the corresponding service startup."},{"line_number":64,"context_line":"It is needed to determine the source of the events (\"service\" part of"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_d1365de6","line":61,"in_reply_to":"3a98d1f4_fb127908","updated":"2016-09-30 09:31:09.000000000","message":"As I wrote to Rick, I can not predict all of use cases. I would be glad to get rid of some fields if people vote for this.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"fdf8015d4d6c95d05e2b0682e4b2a751383c2ddb","unresolved":false,"context_lines":[{"line_number":58,"context_line":"--------------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Priority level - INFO. Will be implemented via object\u0027s create() method."},{"line_number":61,"context_line":"Payload contains all the resource fields which are exposed via API in the"},{"line_number":62,"context_line":"latest microversion. New global variable that represents service type (\"api\""},{"line_number":63,"context_line":"or \"conductor\") will be set during the corresponding service startup."},{"line_number":64,"context_line":"It is needed to determine the source of the events (\"service\" part of"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_143568d9","line":61,"in_reply_to":"5a8bc5a2_72fd2b6d","updated":"2016-09-28 23:09:56.000000000","message":"I just wanted to echo the comment that having all of the API fields present in the notification fields is a good thing for Searchlight.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4a6b480b9bc7d46be193f3f50cdd7c357d9e9cc7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"--------------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Priority level - INFO. Will be implemented via object\u0027s create() method."},{"line_number":61,"context_line":"Payload contains all the resource fields which are exposed via API in the"},{"line_number":62,"context_line":"latest microversion. New global variable that represents service type (\"api\""},{"line_number":63,"context_line":"or \"conductor\") will be set during the corresponding service startup."},{"line_number":64,"context_line":"It is needed to determine the source of the events (\"service\" part of"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a8bc5a2_72fd2b6d","line":61,"in_reply_to":"5a8bc5a2_f205d710","updated":"2016-09-27 08:06:27.000000000","message":"Yes, maybe it makes sense, wait for power state patch.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"fdf8015d4d6c95d05e2b0682e4b2a751383c2ddb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"--------------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Priority level - DEBUG. Will be implemented via object\u0027s save() method."},{"line_number":71,"context_line":"Payload is the same as for create notifications."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Updates of the following fields will not trigger a notification:"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_b4f834e7","line":71,"updated":"2016-09-28 23:09:56.000000000","message":"I\u0027m looking at this spec from a Searchlight perspective. What is the rationale for using a DEBUG level for update notifications? As opposed to an INFO level.\n\nFor the services that Searchlight supports, it receives all CRUD notifications. Currently all of the other services send out CRUD notifications with an INFO level. This helps receivers like Searchlight which only care about CRUD operations to cut down on the amount of noise and notifications they receive.\n\nIf Ironic uses a DEBUG level for updates, then Searchlight will need to enable receiving DEBUG notifications for all services. While Searchlight will be able to filter out the DEBUG notifications that are not for Ironic, it will increase the amount of notifications that it has to process. Is there a way to generate update notifications with an INFO priority level?","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e400d74d0226fb5f44f3f039b4cb008a2266e2a7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"--------------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Priority level - DEBUG. Will be implemented via object\u0027s save() method."},{"line_number":71,"context_line":"Payload is the same as for create notifications."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Updates of the following fields will not trigger a notification:"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_ccab6988","line":71,"in_reply_to":"3a98d1f4_b4f834e7","updated":"2016-09-29 09:05:43.000000000","message":"\"If Ironic uses a DEBUG level for updates, then Searchlight will need to enable receiving DEBUG notifications for all services.\" - You are right. Agree with this you and me or disagree use of different levels of notification in ironic mentioned in approved spec: https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/notifications.html DEBUG level is selected for updates because: 1) state changes notifications have INFO or ERROR levels, these notifications will be include many node\u0027s fields, and looks like some people want to receive in our envs only changes in node state change moments, therefore should be a way for limiting notification flow and do not send update notifications 2) my proposal about additional config option(s) in ironic was not been approved by reviewers, please read review history of this spec. I think if you worry about this situation the better way is send email with your vision and proposals to openstack-dev mailing list.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0b5729c63dba1e8014c19bd06bae09820793117c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"     \"baremetal.node.updated\"."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"For create and update notifications, all secrets in the node fields will be"},{"line_number":93,"context_line":"masked."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Delete notifications"},{"line_number":96,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_bbf1d16c","line":93,"updated":"2016-09-29 17:37:00.000000000","message":"Yuriy, based on your testing, what updates (I mean, to which resource fields) cause an update notification to be issued very frequently? I\u0027d like to get an idea of whether we can exclude other fields, so that we can issue update notifications with INFO level instead of DEBUG level. (And/or would it be too complicated to issue some types of update notifications with INFO, and others with DEBUG?)","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bfa9fbde2eb4b92368596af766500a43c91467cb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"     \"baremetal.node.updated\"."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"For create and update notifications, all secrets in the node fields will be"},{"line_number":93,"context_line":"masked."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Delete notifications"},{"line_number":96,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_f452f111","line":93,"in_reply_to":"3a98d1f4_873f37d5","updated":"2016-10-04 01:30:01.000000000","message":"config option is an interesting idea. I really \u0027want it all\u0027! I want to code this to emit the desired notifications w/o having to resort to a config option.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97057491dd2c5731f0477c75fafc1fa6b2ac9cda","unresolved":false,"context_lines":[{"line_number":90,"context_line":"     \"baremetal.node.updated\"."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"For create and update notifications, all secrets in the node fields will be"},{"line_number":93,"context_line":"masked."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Delete notifications"},{"line_number":96,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_873f37d5","line":93,"in_reply_to":"3a98d1f4_bbf1d16c","updated":"2016-09-30 09:31:09.000000000","message":"Current notifications implementation shows these problems:\n\n1. Ironic code like\n\n task.node.last_error \u003d None\n task.node.save()\n\nthis causes a notification even if previous value of last_error is None, because oslo objects mark fields as changed on assignment. It can not be easy fixed in oslo because we use also dict-based fields, but ironic code can be optimized.\n\n2. Cleaning-related fields for notifications, (note: raid is not used in my env), can be updated frequently.\n\n3. Node transition via cleaning state even cleaning is disabled.\n\n4. Early state change for async tasks. I think we should not touch the states until worker thread is not started, because state may quickly reverts back with error that returns synchronously. It conforms to RFC 7231 and I have patch for power states https://review.openstack.org/#/c/359287/\n\n5. Inconsistency between objects and API fields (id \u003c-\u003e uuid). We already have this problem in API. The ultimate solution (maybe for future) is to include parent uuid to db tables and objects.\n\nI like idea of provision states notifications with base payload because 1) node updates localized in one task_manager module 2) events like \"done\", \"fail\" finalizes the operation, but we should write all changes like errors before process event (currently it\u0027s not true).\n\nI see two choices for users, 1) provision state notifications + CRUD based on sync API updates as you propose above 2) objects-level CRUD notifications + provision states notifications\n\nBoth should be on INFO level (except unstable to unstable state on DEBUG).\n\nMy proposal is: both realization with new config option for selecting 1 or 2.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"5b11012094b2c2517e12dbaf6918dd1bb5462394","unresolved":false,"context_lines":[{"line_number":96,"context_line":"--------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Priority level - INFO. Will be implemented via object\u0027s destroy() method."},{"line_number":99,"context_line":"Payload contains only resource UUID."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Node maintenance notifications"},{"line_number":102,"context_line":"------------------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a8bc5a2_b2150fe6","line":99,"updated":"2016-09-26 18:26:51.000000000","message":"Why only the UUID? It may be useful for someone to see the state of a resource immediately before it was deleted. If Searchlight doesn\u0027t need this, I\u0027m OK with it, just kind of curious.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e400d74d0226fb5f44f3f039b4cb008a2266e2a7","unresolved":false,"context_lines":[{"line_number":96,"context_line":"--------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Priority level - INFO. Will be implemented via object\u0027s destroy() method."},{"line_number":99,"context_line":"Payload contains only resource UUID."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Node maintenance notifications"},{"line_number":102,"context_line":"------------------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_4cae7986","line":99,"in_reply_to":"3a98d1f4_f4655ce1","updated":"2016-09-29 09:05:43.000000000","message":"Agree, will do.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4a6b480b9bc7d46be193f3f50cdd7c357d9e9cc7","unresolved":false,"context_lines":[{"line_number":96,"context_line":"--------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Priority level - INFO. Will be implemented via object\u0027s destroy() method."},{"line_number":99,"context_line":"Payload contains only resource UUID."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Node maintenance notifications"},{"line_number":102,"context_line":"------------------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a8bc5a2_f2921bf5","line":99,"in_reply_to":"5a8bc5a2_b2150fe6","updated":"2016-09-27 08:06:27.000000000","message":"Agree, will change in the next patch set.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"fdf8015d4d6c95d05e2b0682e4b2a751383c2ddb","unresolved":false,"context_lines":[{"line_number":96,"context_line":"--------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Priority level - INFO. Will be implemented via object\u0027s destroy() method."},{"line_number":99,"context_line":"Payload contains only resource UUID."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Node maintenance notifications"},{"line_number":102,"context_line":"------------------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a98d1f4_f4655ce1","line":99,"in_reply_to":"5a8bc5a2_f2921bf5","updated":"2016-09-28 23:09:56.000000000","message":"Another agreement here. It is very beneficial to Searchlight to have all of the resource fields present in the delete notification. Having only the UUID will sometimes require Searchlight to do a lookup (either through the Ironic API or internally with Searchlight).","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"5b11012094b2c2517e12dbaf6918dd1bb5462394","unresolved":false,"context_lines":[{"line_number":205,"context_line":"Performance Impact"},{"line_number":206,"context_line":"------------------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"None"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Other deployer impact"},{"line_number":211,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a8bc5a2_6d53a66b","line":208,"updated":"2016-09-26 18:26:51.000000000","message":"Do you think that this may have a performance impact for fields exposed via API that aren\u0027t directly on the object? I think the way this would work is that you\u0027d have to do a \"SELECT uuid FROM chassis WHERE id\u003dchassis_id;\" for returning a full API node, for example. I don\u0027t think that\u0027s bad enough of an impact to mention here, just curious about the implementation. We can discuss more in actual code review.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4a6b480b9bc7d46be193f3f50cdd7c357d9e9cc7","unresolved":false,"context_lines":[{"line_number":205,"context_line":"Performance Impact"},{"line_number":206,"context_line":"------------------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"None"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Other deployer impact"},{"line_number":211,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a8bc5a2_b5b23d4a","line":208,"in_reply_to":"5a8bc5a2_6d53a66b","updated":"2016-09-27 08:06:27.000000000","message":"And worse case for ports, there is mandatory node_id. API does the same additional SELECT for these resources, this is ironic internal architecture. Yes, this may have a performance impact.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"5b11012094b2c2517e12dbaf6918dd1bb5462394","unresolved":false,"context_lines":[{"line_number":244,"context_line":"Dependencies"},{"line_number":245,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"Generic notifications code in ironic."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Testing"},{"line_number":250,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a8bc5a2_4d042a49","line":247,"updated":"2016-09-26 18:26:51.000000000","message":"This is merged, so you can remove it if you have to update the spec again","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4a6b480b9bc7d46be193f3f50cdd7c357d9e9cc7","unresolved":false,"context_lines":[{"line_number":244,"context_line":"Dependencies"},{"line_number":245,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"Generic notifications code in ironic."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Testing"},{"line_number":250,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a8bc5a2_15b4d132","line":247,"in_reply_to":"5a8bc5a2_4d042a49","updated":"2016-09-27 08:06:27.000000000","message":"Thanks, will do in the next patch set.","commit_id":"9211785756763df4fc7ff56c330d322403e90e2b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c9b26cd115f2e660a2143603da1ab1d4ffb27a08","unresolved":false,"context_lines":[{"line_number":21,"context_line":"creation, update or deletion of a resource. Currently CRUD notifications are"},{"line_number":22,"context_line":"not implemented in ironic. Creating an efficient plugin for Searchlight is"},{"line_number":23,"context_line":"impossible without these notifications."},{"line_number":24,"context_line":"Ironic state notification also should be used by Searchlight plugin for"},{"line_number":25,"context_line":"maintain index in actual state."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_9044724a","line":24,"range":{"start_line":24,"start_character":31,"end_line":24,"end_character":37},"updated":"2016-10-03 15:02:39.000000000","message":"could","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c9b26cd115f2e660a2143603da1ab1d4ffb27a08","unresolved":false,"context_lines":[{"line_number":21,"context_line":"creation, update or deletion of a resource. Currently CRUD notifications are"},{"line_number":22,"context_line":"not implemented in ironic. Creating an efficient plugin for Searchlight is"},{"line_number":23,"context_line":"impossible without these notifications."},{"line_number":24,"context_line":"Ironic state notification also should be used by Searchlight plugin for"},{"line_number":25,"context_line":"maintain index in actual state."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_50566a06","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":25},"updated":"2016-10-03 15:02:39.000000000","message":"notifications","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c9b26cd115f2e660a2143603da1ab1d4ffb27a08","unresolved":false,"context_lines":[{"line_number":21,"context_line":"creation, update or deletion of a resource. Currently CRUD notifications are"},{"line_number":22,"context_line":"not implemented in ironic. Creating an efficient plugin for Searchlight is"},{"line_number":23,"context_line":"impossible without these notifications."},{"line_number":24,"context_line":"Ironic state notification also should be used by Searchlight plugin for"},{"line_number":25,"context_line":"maintain index in actual state."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_b066ceea","line":24,"range":{"start_line":24,"start_character":68,"end_line":24,"end_character":71},"updated":"2016-10-03 15:02:39.000000000","message":"to","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"356f9abb7dabe18f4e9d6b698fde84bf9558724c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"creation, update or deletion of a resource. Currently CRUD notifications are"},{"line_number":22,"context_line":"not implemented in ironic. Creating an efficient plugin for Searchlight is"},{"line_number":23,"context_line":"impossible without these notifications."},{"line_number":24,"context_line":"Ironic state notification also should be used by Searchlight plugin for"},{"line_number":25,"context_line":"maintain index in actual state."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_80b5017f","line":24,"range":{"start_line":24,"start_character":31,"end_line":24,"end_character":37},"in_reply_to":"3a98d1f4_9044724a","updated":"2016-10-03 16:16:29.000000000","message":"Done","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c9b26cd115f2e660a2143603da1ab1d4ffb27a08","unresolved":false,"context_lines":[{"line_number":75,"context_line":"``local_link_connection``, ``pxe_enabled``, ``created_at``, ``updated_at``."},{"line_number":76,"context_line":"These notifications will be implemented in the API. Exception is"},{"line_number":77,"context_line":"\"baremetal.port.create.success\" that will be issued also by conducror service"},{"line_number":78,"context_line":"when driver creates a port."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Chassis CRUD notifications"},{"line_number":81,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_70b606fa","line":78,"range":{"start_line":78,"start_character":5,"end_line":78,"end_character":26},"updated":"2016-10-03 15:02:39.000000000","message":"please add an example you provided earlier to be more specific.","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"356f9abb7dabe18f4e9d6b698fde84bf9558724c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"``local_link_connection``, ``pxe_enabled``, ``created_at``, ``updated_at``."},{"line_number":76,"context_line":"These notifications will be implemented in the API. Exception is"},{"line_number":77,"context_line":"\"baremetal.port.create.success\" that will be issued also by conducror service"},{"line_number":78,"context_line":"when driver creates a port."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Chassis CRUD notifications"},{"line_number":81,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_33856559","line":78,"range":{"start_line":78,"start_character":5,"end_line":78,"end_character":26},"in_reply_to":"3a98d1f4_70b606fa","updated":"2016-10-03 16:16:29.000000000","message":"Done","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":7900,"name":"Tomasz Paszkowski","email":"ss7pro@gmail.com","username":"tpaszkowski"},"change_message_id":"a68ae1da8cafb9f9e245350cf56b4765d3306d12","unresolved":false,"context_lines":[{"line_number":92,"context_line":"``description``, ``created_at``, ``updated_at``. All these notifications will"},{"line_number":93,"context_line":"be implemented in the API."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Node provision state notifications"},{"line_number":96,"context_line":"----------------------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Will be implemented via TaskManager methods."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_cb1f2fb5","line":95,"updated":"2016-10-03 15:03:39.000000000","message":"What about node cleaning ? Would it be represented by this notification sets as well ?","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"356f9abb7dabe18f4e9d6b698fde84bf9558724c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"``description``, ``created_at``, ``updated_at``. All these notifications will"},{"line_number":93,"context_line":"be implemented in the API."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Node provision state notifications"},{"line_number":96,"context_line":"----------------------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Will be implemented via TaskManager methods."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_569bbf17","line":95,"in_reply_to":"3a98d1f4_cb1f2fb5","updated":"2016-10-03 16:16:29.000000000","message":"An example of node states transition:\n\nMANAGEABLE -\u003e CLEANING -\u003e CLEANWAIT -\u003e CLEANING -\u003e AVAILABLE\n\nImmediately after change of state (-\u003e) notification will be issued, with these node\u0027s fields: \u0027clean_step\u0027, \u0027console_enabled\u0027, \u0027created_at\u0027, \u0027driver\u0027 \u0027extra\u0027, \u0027inspection_finished_at\u0027, \u0027inspection_started_at\u0027, \u0027instance_info\u0027, \u0027instance_uuid\u0027, \u0027last_error\u0027, \u0027maintenance\u0027, \u0027maintenance_reason\u0027, \u0027network_interface\u0027, \u0027name\u0027, \u0027power_state\u0027, \u0027properties\u0027, \u0027provision_state\u0027,\n\u0027provision_updated_at\u0027, \u0027resource_class\u0027, \u0027target_power_state\u0027, \u0027target_provision_state\u0027, \u0027updated_at\u0027\n\u0027uuid\u0027.\n\nIf your use case requires something else please leave a comment.","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c9b26cd115f2e660a2143603da1ab1d4ffb27a08","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Error events processing: \"error\" notification with ERROR level."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Change \"provision_state\" without starting a worker that is not \"end\" or"},{"line_number":121,"context_line":"  \"error\": \"success\" notification with INFO level."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Payload contains all fields from base ``NodePayload`` with additional fields:"},{"line_number":124,"context_line":"``instance_info``, ``previous_provision_state``,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_0b3af798","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":50},"updated":"2016-10-03 15:02:39.000000000","message":"Can\u0027t we just use end here too? (tho I like success term more than end :))","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"356f9abb7dabe18f4e9d6b698fde84bf9558724c","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Error events processing: \"error\" notification with ERROR level."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Change \"provision_state\" without starting a worker that is not \"end\" or"},{"line_number":121,"context_line":"  \"error\": \"success\" notification with INFO level."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Payload contains all fields from base ``NodePayload`` with additional fields:"},{"line_number":124,"context_line":"``instance_info``, ``previous_provision_state``,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_b3a6d5ab","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":50},"in_reply_to":"3a98d1f4_0b3af798","updated":"2016-10-03 16:16:29.000000000","message":"“end” used when an action that is not immediate succeeds, “success” used when an action that is immediate succeeds. Changes like DEPLOYING \u003c-\u003e DEPLOYWAIT are immediate.","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c9b26cd115f2e660a2143603da1ab1d4ffb27a08","unresolved":false,"context_lines":[{"line_number":124,"context_line":"``instance_info``, ``previous_provision_state``,"},{"line_number":125,"context_line":"``previous_target_provision_state``, ``event`` (FSM event that triggered the"},{"line_number":126,"context_line":"state change)."},{"line_number":127,"context_line":"For efficiently using of provision state notifications all related node changes"},{"line_number":128,"context_line":"(like setting of ``last_error``) should be done before event processing."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Node maintenance notifications"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_2b1893d2","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":24},"updated":"2016-10-03 15:02:39.000000000","message":"to efficiently use the","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"356f9abb7dabe18f4e9d6b698fde84bf9558724c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"``instance_info``, ``previous_provision_state``,"},{"line_number":125,"context_line":"``previous_target_provision_state``, ``event`` (FSM event that triggered the"},{"line_number":126,"context_line":"state change)."},{"line_number":127,"context_line":"For efficiently using of provision state notifications all related node changes"},{"line_number":128,"context_line":"(like setting of ``last_error``) should be done before event processing."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Node maintenance notifications"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_53e3d1d8","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":24},"in_reply_to":"3a98d1f4_2b1893d2","updated":"2016-10-03 16:16:29.000000000","message":"Done","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c9b26cd115f2e660a2143603da1ab1d4ffb27a08","unresolved":false,"context_lines":[{"line_number":142,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":143,"context_line":"in the API."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Node console notifications"},{"line_number":146,"context_line":"--------------------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"The following event types will be added:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_eb706b42","line":145,"updated":"2016-10-03 15:02:39.000000000","message":"Is it really related to the node state? If so, I think boot device notifications should be added too.","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"356f9abb7dabe18f4e9d6b698fde84bf9558724c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":143,"context_line":"in the API."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Node console notifications"},{"line_number":146,"context_line":"--------------------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"The following event types will be added:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_f3805d8d","line":145,"in_reply_to":"3a98d1f4_eb706b42","updated":"2016-10-03 16:16:29.000000000","message":"\"console_enabled\" field (and related \"last_error\") can not be handled on the API side, and these changes are not provision state related. This is the reason for adding console notifications.","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c9b26cd115f2e660a2143603da1ab1d4ffb27a08","unresolved":false,"context_lines":[{"line_number":283,"context_line":"Documentation Impact"},{"line_number":284,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"New notifications feature will be documented."},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"References"},{"line_number":289,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_8bfb6778","line":286,"updated":"2016-10-03 15:02:39.000000000","message":"the things you mention in developer impact should be documented too I think.","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"356f9abb7dabe18f4e9d6b698fde84bf9558724c","unresolved":false,"context_lines":[{"line_number":283,"context_line":"Documentation Impact"},{"line_number":284,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"New notifications feature will be documented."},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"References"},{"line_number":289,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a98d1f4_9314794d","line":286,"in_reply_to":"3a98d1f4_8bfb6778","updated":"2016-10-03 16:16:29.000000000","message":"Yes, agree.","commit_id":"b3c24dc4ba912f9964267dd05510d5e68b13a3a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1606520"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes addition of new notifications to ironic: CRUD (create,"},{"line_number":14,"context_line":"update, or delete) of resources, node state changes for provision state,"},{"line_number":15,"context_line":"maintenance and console state."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_aff65e5a","line":14,"updated":"2016-10-03 22:35:23.000000000","message":"s/node state changes/and node state changes/","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1606520"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes addition of new notifications to ironic: CRUD (create,"},{"line_number":14,"context_line":"update, or delete) of resources, node state changes for provision state,"},{"line_number":15,"context_line":"maintenance and console state."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_6ba7d4a6","line":14,"in_reply_to":"3a98d1f4_aff65e5a","updated":"2016-10-04 11:32:29.000000000","message":"Done","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"creation, update or deletion of a resource. Currently CRUD notifications are"},{"line_number":22,"context_line":"not implemented in ironic. Creating an efficient plugin for Searchlight is"},{"line_number":23,"context_line":"impossible without these notifications."},{"line_number":24,"context_line":"Ironic state notifications also could be used by Searchlight plugin to"},{"line_number":25,"context_line":"maintain index in actual state."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_cf7baaf3","line":24,"updated":"2016-10-03 22:35:23.000000000","message":"\u0027ironic state\u0027 is somewhat vague. Which states, or do you mean *any* time an ironic resource.\u003cfield\u003e is changed? (I don\u0027t think you mean this.)\n\nAre you referring to the above in line 14, notifications about changes to a nodes provision, maintenance, or console state?","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"creation, update or deletion of a resource. Currently CRUD notifications are"},{"line_number":22,"context_line":"not implemented in ironic. Creating an efficient plugin for Searchlight is"},{"line_number":23,"context_line":"impossible without these notifications."},{"line_number":24,"context_line":"Ironic state notifications also could be used by Searchlight plugin to"},{"line_number":25,"context_line":"maintain index in actual state."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_4b4858cc","line":24,"in_reply_to":"3a98d1f4_cf7baaf3","updated":"2016-10-04 11:32:29.000000000","message":"Done","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"not implemented in ironic. Creating an efficient plugin for Searchlight is"},{"line_number":23,"context_line":"impossible without these notifications."},{"line_number":24,"context_line":"Ironic state notifications also could be used by Searchlight plugin to"},{"line_number":25,"context_line":"maintain index in actual state."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_4f8cfad9","line":25,"updated":"2016-10-03 22:35:23.000000000","message":"I\u0027m not quite sure what you mean by this \u0027maintain index in actual state\u0027. Maybe in order to keep Searchlight\u0027s index of ironic resources up-to-date?","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"not implemented in ironic. Creating an efficient plugin for Searchlight is"},{"line_number":23,"context_line":"impossible without these notifications."},{"line_number":24,"context_line":"Ironic state notifications also could be used by Searchlight plugin to"},{"line_number":25,"context_line":"maintain index in actual state."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_2b24ec0a","line":25,"in_reply_to":"3a98d1f4_4f8cfad9","updated":"2016-10-04 11:32:29.000000000","message":"Done","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":50,"context_line":"fields from base ``NodePayload`` with additional fields: ``chassis_uuid``,"},{"line_number":51,"context_line":"``instance_info``, ``driver_info``. Secrets in the node fields will be masked."},{"line_number":52,"context_line":"All these notifications will be implemented in the API."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Port CRUD notifications"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_125775ca","line":51,"updated":"2016-10-03 22:35:23.000000000","message":"no raid_config or target_raid_config?","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":50,"context_line":"fields from base ``NodePayload`` with additional fields: ``chassis_uuid``,"},{"line_number":51,"context_line":"``instance_info``, ``driver_info``. Secrets in the node fields will be masked."},{"line_number":52,"context_line":"All these notifications will be implemented in the API."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Port CRUD notifications"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_eb3cc4e2","line":51,"in_reply_to":"3a98d1f4_125775ca","updated":"2016-10-04 11:32:29.000000000","message":"No, at least currently. They can contain low-level disks and vendor\u0027s information. Ironic write RAID level in \"properties\" field. If someone interested in \"raid_config\" or \"target_raid_config\" we can add support later and bump minor version of payload.","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":50,"context_line":"fields from base ``NodePayload`` with additional fields: ``chassis_uuid``,"},{"line_number":51,"context_line":"``instance_info``, ``driver_info``. Secrets in the node fields will be masked."},{"line_number":52,"context_line":"All these notifications will be implemented in the API."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Port CRUD notifications"},{"line_number":55,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_2f3deedc","line":52,"updated":"2016-10-03 22:35:23.000000000","message":"s/in the API/at the API level/ or maybe \u0027emitted by the ironic-api service\u0027?","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":50,"context_line":"fields from base ``NodePayload`` with additional fields: ``chassis_uuid``,"},{"line_number":51,"context_line":"``instance_info``, ``driver_info``. Secrets in the node fields will be masked."},{"line_number":52,"context_line":"All these notifications will be implemented in the API."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Port CRUD notifications"},{"line_number":55,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_eb13e462","line":52,"in_reply_to":"3a98d1f4_2f3deedc","updated":"2016-10-04 11:32:29.000000000","message":"Done","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Priority level - INFO or ERROR (for \"error\" status)."},{"line_number":74,"context_line":"Payload contains these fields: ``uuid``, ``node_uuid``, ``address``, ``extra``,"},{"line_number":75,"context_line":"``local_link_connection``, ``pxe_enabled``, ``created_at``, ``updated_at``."},{"line_number":76,"context_line":"These notifications will be implemented in the API. Exception is"},{"line_number":77,"context_line":"\"baremetal.port.create.success\" that will be issued also by conducror service"},{"line_number":78,"context_line":"when driver creates a port (examples are [#]_ and [#]_)."},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_526bbdb6","line":76,"updated":"2016-10-03 22:35:23.000000000","message":"s/implemented in the API. Exception is/emitted by the ironic-api service. In addition, /","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Priority level - INFO or ERROR (for \"error\" status)."},{"line_number":74,"context_line":"Payload contains these fields: ``uuid``, ``node_uuid``, ``address``, ``extra``,"},{"line_number":75,"context_line":"``local_link_connection``, ``pxe_enabled``, ``created_at``, ``updated_at``."},{"line_number":76,"context_line":"These notifications will be implemented in the API. Exception is"},{"line_number":77,"context_line":"\"baremetal.port.create.success\" that will be issued also by conducror service"},{"line_number":78,"context_line":"when driver creates a port (examples are [#]_ and [#]_)."},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_a6a031f5","line":76,"in_reply_to":"3a98d1f4_526bbdb6","updated":"2016-10-04 11:32:29.000000000","message":"Done","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Payload contains these fields: ``uuid``, ``node_uuid``, ``address``, ``extra``,"},{"line_number":75,"context_line":"``local_link_connection``, ``pxe_enabled``, ``created_at``, ``updated_at``."},{"line_number":76,"context_line":"These notifications will be implemented in the API. Exception is"},{"line_number":77,"context_line":"\"baremetal.port.create.success\" that will be issued also by conducror service"},{"line_number":78,"context_line":"when driver creates a port (examples are [#]_ and [#]_)."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Chassis CRUD notifications"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_127bf57b","line":77,"updated":"2016-10-03 22:35:23.000000000","message":"s/that will be issued also by conducror/will be emitted by the ironic-conductor/","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Payload contains these fields: ``uuid``, ``node_uuid``, ``address``, ``extra``,"},{"line_number":75,"context_line":"``local_link_connection``, ``pxe_enabled``, ``created_at``, ``updated_at``."},{"line_number":76,"context_line":"These notifications will be implemented in the API. Exception is"},{"line_number":77,"context_line":"\"baremetal.port.create.success\" that will be issued also by conducror service"},{"line_number":78,"context_line":"when driver creates a port (examples are [#]_ and [#]_)."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Chassis CRUD notifications"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_c67a9d76","line":77,"in_reply_to":"3a98d1f4_127bf57b","updated":"2016-10-04 11:32:29.000000000","message":"Done","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Priority level - INFO. Payload contains these fields: ``uuid``, ``extra``,"},{"line_number":92,"context_line":"``description``, ``created_at``, ``updated_at``. All these notifications will"},{"line_number":93,"context_line":"be implemented in the API."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Node provision state notifications"},{"line_number":96,"context_line":"----------------------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_92ac658d","line":93,"updated":"2016-10-03 22:35:23.000000000","message":"s/implemented in the API/emitted by the ironic-api service/","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Priority level - INFO. Payload contains these fields: ``uuid``, ``extra``,"},{"line_number":92,"context_line":"``description``, ``created_at``, ``updated_at``. All these notifications will"},{"line_number":93,"context_line":"be implemented in the API."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Node provision state notifications"},{"line_number":96,"context_line":"----------------------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_e6f4f9f1","line":93,"in_reply_to":"3a98d1f4_92ac658d","updated":"2016-10-04 11:32:29.000000000","message":"Done","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Node provision state notifications"},{"line_number":96,"context_line":"----------------------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Will be implemented via TaskManager methods."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Types of events for node provision state:"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_32e9d1b7","line":98,"updated":"2016-10-03 22:35:23.000000000","message":"s/methods/methods (and emitted by the ironic-conductor service)\u0027.","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Node provision state notifications"},{"line_number":96,"context_line":"----------------------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Will be implemented via TaskManager methods."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Types of events for node provision state:"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_66e1c929","line":98,"in_reply_to":"3a98d1f4_32e9d1b7","updated":"2016-10-04 11:32:29.000000000","message":"Done","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"----------------------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Will be implemented via TaskManager methods."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Types of events for node provision state:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* \"baremetal.node.provision_set.start\";"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_08e748ac","line":99,"updated":"2016-10-03 22:35:23.000000000","message":"I was wondering what you mean by TaskManager methods. Are you going to emit notifications for all provision states? In the previous revision, there was mention of stable vs unstable provision states. Are you going to emit for unstable provision states too?","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"----------------------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Will be implemented via TaskManager methods."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Types of events for node provision state:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* \"baremetal.node.provision_set.start\";"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_067f2515","line":99,"in_reply_to":"3a98d1f4_08e748ac","updated":"2016-10-04 11:32:29.000000000","message":"Yes, for all states. The one of the reasons is: if we drop objects-level notifications we need to emit notifications more frequently between AVAILABLE and ACTIVE states (for example) because someone can be interested in changes that ironic make itself.","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"* Error events processing: \"error\" notification with ERROR level."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Change \"provision_state\" without starting a worker that is not \"end\" or"},{"line_number":121,"context_line":"  \"error\": \"success\" notification with INFO level."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Payload contains all fields from base ``NodePayload`` with additional fields:"},{"line_number":124,"context_line":"``instance_info``, ``previous_provision_state``,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_a81494e8","line":121,"updated":"2016-10-03 22:35:23.000000000","message":"this is for synchronous actions, right, versus the above that are async.","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":142,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":143,"context_line":"in the API."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Node console notifications"},{"line_number":146,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_2837a44d","line":143,"updated":"2016-10-03 22:35:23.000000000","message":"our ironic code can also set a node to maintenance. (I don\u0027t think we have any cases where ironic will internally take a node out of maintenance). So no notifications for these kind of changes to the maintenance mode?","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":142,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":143,"context_line":"in the API."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Node console notifications"},{"line_number":146,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_66f6295e","line":143,"in_reply_to":"3a98d1f4_2837a44d","updated":"2016-10-04 11:32:29.000000000","message":"They will be covered by power and provision notifications. See handle_sync_power_state_max_retries_exceeded() function in Mario\u0027s patch for example. I\u0027m not sure that we should double mentioned notifications with maintenance notifications. Here described only API maintenance changes.","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"11ff1988832221d425cc0eef2048f1f7cd65b9f4","unresolved":false,"context_lines":[{"line_number":154,"context_line":"* \"baremetal.node.console_set.error\"."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":157,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":158,"context_line":"in the ironic conductor."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_5499e5c2","line":157,"updated":"2016-10-04 01:29:32.000000000","message":"we might also want a \u0027to_console\u0027 (that might be a bad name) value that indicates what it is being set to. (true/false, enable/disable)","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":154,"context_line":"* \"baremetal.node.console_set.error\"."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":157,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":158,"context_line":"in the ironic conductor."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_86bed562","line":157,"in_reply_to":"3a98d1f4_5499e5c2","updated":"2016-10-04 11:32:29.000000000","message":"Not sure, because this is a boolean value.","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"618637a20b78e5ba4d71af657d9ce36a77e3f48a","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":157,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":158,"context_line":"in the ironic conductor."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Alternatives"},{"line_number":161,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_68244c0c","line":158,"updated":"2016-10-03 22:35:23.000000000","message":"I\u0027m curious why you\u0027re doing this in ironic-conductor and not in ironic-api, since these can only be done via a user request. (Except for conductor take over perhaps.)","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa3a6a31e2ebc066b68e3a88b0db97b42634529b","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":157,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":158,"context_line":"in the ironic conductor."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Alternatives"},{"line_number":161,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a98d1f4_861a557b","line":158,"in_reply_to":"3a98d1f4_68244c0c","updated":"2016-10-04 11:32:29.000000000","message":"These can be started via a user request. Set console is async method.","commit_id":"edbe05272c28e21fc014dbff6b32e5b79b7b6fcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"52b442fe12be82de582710ff1c6cdbba623afb70","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":51,"context_line":"fields from base ``NodePayload`` with additional fields: ``chassis_uuid``,"},{"line_number":52,"context_line":"``instance_info``, ``driver_info``. Secrets in the node fields will be masked."},{"line_number":53,"context_line":"All these notifications will be implemented at the API level."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Port CRUD notifications"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_01870e10","line":52,"updated":"2016-10-04 14:46:34.000000000","message":"I think it would be useful to mention what you said/wrote, that raid_config and target_raid_config are excluded because they can contain low-level disk and vendor information. If/when there is a use case for them, they can be added in the future.","commit_id":"8f7d97b27b1ce0eab6dcb3813f57c9426bc90724"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b844276d16bd3ed2079ea94f63a70178d7330e84","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":51,"context_line":"fields from base ``NodePayload`` with additional fields: ``chassis_uuid``,"},{"line_number":52,"context_line":"``instance_info``, ``driver_info``. Secrets in the node fields will be masked."},{"line_number":53,"context_line":"All these notifications will be implemented at the API level."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Port CRUD notifications"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_4e311f0b","line":52,"in_reply_to":"1a95cdbc_01870e10","updated":"2016-10-05 08:47:22.000000000","message":"Done","commit_id":"8f7d97b27b1ce0eab6dcb3813f57c9426bc90724"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"52b442fe12be82de582710ff1c6cdbba623afb70","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Priority level - INFO or ERROR (for \"error\" status)."},{"line_number":75,"context_line":"Payload contains these fields: ``uuid``, ``node_uuid``, ``address``, ``extra``,"},{"line_number":76,"context_line":"``local_link_connection``, ``pxe_enabled``, ``created_at``, ``updated_at``."},{"line_number":77,"context_line":"These notifications will be implemented in the API. In addition,"},{"line_number":78,"context_line":"\"baremetal.port.create.success\" will be emitted by the ironic-conductor service"},{"line_number":79,"context_line":"when driver creates a port (examples are [#]_ and [#]_)."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_61c45240","line":77,"updated":"2016-10-04 14:46:34.000000000","message":"nit s/in the API/at the API level/.","commit_id":"8f7d97b27b1ce0eab6dcb3813f57c9426bc90724"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b844276d16bd3ed2079ea94f63a70178d7330e84","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Priority level - INFO or ERROR (for \"error\" status)."},{"line_number":75,"context_line":"Payload contains these fields: ``uuid``, ``node_uuid``, ``address``, ``extra``,"},{"line_number":76,"context_line":"``local_link_connection``, ``pxe_enabled``, ``created_at``, ``updated_at``."},{"line_number":77,"context_line":"These notifications will be implemented in the API. In addition,"},{"line_number":78,"context_line":"\"baremetal.port.create.success\" will be emitted by the ironic-conductor service"},{"line_number":79,"context_line":"when driver creates a port (examples are [#]_ and [#]_)."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_2e569329","line":77,"in_reply_to":"1a95cdbc_61c45240","updated":"2016-10-05 08:47:22.000000000","message":"Done","commit_id":"8f7d97b27b1ce0eab6dcb3813f57c9426bc90724"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"52b442fe12be82de582710ff1c6cdbba623afb70","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":144,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":145,"context_line":"in the API."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Node console notifications"},{"line_number":148,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_04f8fce4","line":145,"updated":"2016-10-04 14:46:34.000000000","message":"Let\u0027s be more explicit here. (Which is also useful in case someone assumes this is for all maintenance changes, and/or disagrees...) Maybe something like \u0027All these notifications will be implemented at the API level and reflect maintenance changes to a node due to a user request. There won\u0027t be any explicit node maintenance notifications for maintenance changes done internally by ironic. Since these internal changes occur as a result of trying to change the node\u0027s state (e.g. provision, console), one of the other notifications that is emitted will \u0027cover\u0027 these internal maintenance changes.","commit_id":"8f7d97b27b1ce0eab6dcb3813f57c9426bc90724"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b844276d16bd3ed2079ea94f63a70178d7330e84","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":144,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":145,"context_line":"in the API."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Node console notifications"},{"line_number":148,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_592c874a","line":145,"in_reply_to":"1a95cdbc_04f8fce4","updated":"2016-10-05 08:47:22.000000000","message":"Done","commit_id":"8f7d97b27b1ce0eab6dcb3813f57c9426bc90724"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"52b442fe12be82de582710ff1c6cdbba623afb70","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":159,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":160,"context_line":"in the ironic conductor."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Alternatives"},{"line_number":163,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_04b55ccc","line":160,"updated":"2016-10-04 14:46:34.000000000","message":"Maybe add \u0027Although an API request initiates the setting of a node\u0027s console, this is an asynchronous request, so it is the ironic-conductor that can easily emit notifications for the start/end of the change.","commit_id":"8f7d97b27b1ce0eab6dcb3813f57c9426bc90724"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b844276d16bd3ed2079ea94f63a70178d7330e84","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Priority level - INFO or ERROR (for \"error\" status). Payload contains all"},{"line_number":159,"context_line":"fields from base ``NodePayload``. All these notifications will be implemented"},{"line_number":160,"context_line":"in the ironic conductor."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Alternatives"},{"line_number":163,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_d9f977ca","line":160,"in_reply_to":"1a95cdbc_04b55ccc","updated":"2016-10-05 08:47:22.000000000","message":"Done","commit_id":"8f7d97b27b1ce0eab6dcb3813f57c9426bc90724"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"53420b819cc183136d608b6c97d90a201a2671fb","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Error events processing: \"error\" notification with ERROR level."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"* Change ``provision_state`` without starting a worker that is not \"end\" or"},{"line_number":126,"context_line":"  \"error\": \"success\" notification with INFO level."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Payload contains all fields from base ``NodePayload`` with additional fields:"},{"line_number":129,"context_line":"``instance_info``, ``previous_provision_state``,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1a95cdbc_1ce3c8a4","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":50},"updated":"2016-10-05 10:39:20.000000000","message":"Could you please mention an example here to make it more clear?","commit_id":"8f26a6606fdad5b5385ef51735bb89b4fb37f7c1"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a0e5fb69aba5d98a0c55ef0787e10995e276266c","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Error events processing: \"error\" notification with ERROR level."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"* Change ``provision_state`` without starting a worker that is not \"end\" or"},{"line_number":126,"context_line":"  \"error\": \"success\" notification with INFO level."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Payload contains all fields from base ``NodePayload`` with additional fields:"},{"line_number":129,"context_line":"``instance_info``, ``previous_provision_state``,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1a95cdbc_32042d7d","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":50},"in_reply_to":"1a95cdbc_1ce3c8a4","updated":"2016-10-05 11:12:11.000000000","message":"Done","commit_id":"8f26a6606fdad5b5385ef51735bb89b4fb37f7c1"}],"specs/approved/node-crud-state-notifications.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1606520"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes new notivications to Ironic: CRUD (create, update, or"},{"line_number":14,"context_line":"delete) of resources and provision states change."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_124ec06e","line":13,"updated":"2016-07-26 20:54:12.000000000","message":"s/notivications/notifications/","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"314cc1c858bcfda5bba7e55ce118336d9592190c","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1606520"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes new notivications to Ironic: CRUD (create, update, or"},{"line_number":14,"context_line":"delete) of resources and provision states change."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_12b86429","line":13,"in_reply_to":"dada55a8_124ec06e","updated":"2016-07-27 13:02:38.000000000","message":"Done","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1606520"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes new notivications to Ironic: CRUD (create, update, or"},{"line_number":14,"context_line":"delete) of resources and provision states change."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_327024a4","line":14,"updated":"2016-07-26 20:54:12.000000000","message":"s/provision/node provision/","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"314cc1c858bcfda5bba7e55ce118336d9592190c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1606520"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes new notivications to Ironic: CRUD (create, update, or"},{"line_number":14,"context_line":"delete) of resources and provision states change."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_52849c5c","line":14,"in_reply_to":"dada55a8_327024a4","updated":"2016-07-27 13:02:38.000000000","message":"Done","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Resource indexation services like Searchlight [#]_ require notifications about"},{"line_number":20,"context_line":"create, update or delete resource. Currently Ironic does not support CRUD"},{"line_number":21,"context_line":"notifications, therefore create efficient plugin for Searchlight is impossible."},{"line_number":22,"context_line":"Another problem is notification about change node provision state. Approved"},{"line_number":23,"context_line":"spec [#]_ mentions them, but as work item plan only implement of a notification"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_129c00bf","line":20,"updated":"2016-07-26 20:54:12.000000000","message":"well, currently, ironic doesn\u0027t support *any* notifications :)\n\nMaybe indicate that even after the notification work is implemented (spec or bug referenced), ironic won\u0027t have support for this.","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"notifications, therefore create efficient plugin for Searchlight is impossible."},{"line_number":22,"context_line":"Another problem is notification about change node provision state. Approved"},{"line_number":23,"context_line":"spec [#]_ mentions them, but as work item plan only implement of a notification"},{"line_number":24,"context_line":"for when a node power state is changed as example. This spec proposed more"},{"line_number":25,"context_line":"detailed description of provision state notifications and work item for"},{"line_number":26,"context_line":"implement them."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_72dbbc7c","line":24,"updated":"2016-07-26 20:54:12.000000000","message":"Did you check with Mario or whoever, as to whether they will be implementing node provision state changes?","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"16ff79b66651bee153c04db6c628e9f922464194","unresolved":false,"context_lines":[{"line_number":21,"context_line":"notifications, therefore create efficient plugin for Searchlight is impossible."},{"line_number":22,"context_line":"Another problem is notification about change node provision state. Approved"},{"line_number":23,"context_line":"spec [#]_ mentions them, but as work item plan only implement of a notification"},{"line_number":24,"context_line":"for when a node power state is changed as example. This spec proposed more"},{"line_number":25,"context_line":"detailed description of provision state notifications and work item for"},{"line_number":26,"context_line":"implement them."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_0205c978","line":24,"in_reply_to":"dada55a8_72dbbc7c","updated":"2016-07-26 23:24:47.000000000","message":"I\u0027m fine with whoever gets to it first implementing it. Feel free to add me as an \"Other contributor\" at the bottom and I\u0027ll ping the interested parties when I have time to start. I\u0027ll definitely help with reviewing even if yuriyz/vdrok get to it faster. :)","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    * \"baremetal.maintenance.end\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"For all resources payload for delete event will only contain resource uuid."},{"line_number":47,"context_line":"Payloads for create or update will contains the same fields."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* For node: \"uuid\", \"instance_uuid\", \"name\", \"last_error\", \"maintenance\","},{"line_number":50,"context_line":"  \"maintenance_reason\", \"console_enabled\", \"instance_info\", \"driver\","}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_72f73cd3","line":47,"updated":"2016-07-26 20:54:12.000000000","message":"by \u0027the same fields\u0027, do you mean the fields that were specified in the create/update command? Would it be useful to return all the fields for that resource (eg, what you\u0027d see in an \u0027ironic \u003cresource\u003e-show\u0027 command)?","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  \"maintenance_reason\", \"console_enabled\", \"instance_info\", \"driver\","},{"line_number":51,"context_line":"  \"raid_config\", \"target_raid_config\", \"extra\", \"properties\", \"chassis_uuid\","},{"line_number":52,"context_line":"  \"network_interface\". States fields for node will be covered different types"},{"line_number":53,"context_line":"  of events. Config drive content and Swift temp urls will be masked in"},{"line_number":54,"context_line":"  \"instance_info\" field."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* For port: \"uuid\", \"address\", \"extra\", \"node_uuid\", \"pxe_enabled\","}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_32df843b","line":53,"updated":"2016-07-26 20:54:12.000000000","message":"I don\u0027t understand what you mean by \u0027States fields for node...\u0027. You mean in a create/update, the power/provision states of a node will not be included in the notification?","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"* For port: \"uuid\", \"address\", \"extra\", \"node_uuid\", \"pxe_enabled\","},{"line_number":57,"context_line":"  \"local_link_connection\"."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"* For chassis: \"uuid\", \"description\", \"extra\"."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"\"baremetal.node.maintenance.start\" includes \"maintenance_reason\" in the"},{"line_number":62,"context_line":"payload with node uuid, \"baremetal.maintenance.end\" only node uuid."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_527f9816","line":59,"updated":"2016-07-26 20:54:12.000000000","message":"From line 46 to here -- does it only relate to the .created/.updated events above? If so, maybe move these up.\n\nMaybe add three subsections, for the created/updated/deleted; node.maintenance; node.provision state","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"save() methods."},{"line_number":67,"context_line":"New global variable that represent service type (\"api\" or \"conductor\")"},{"line_number":68,"context_line":"will be added and set in prepare corresponding service. It needed for determine"},{"line_number":69,"context_line":"service for \"baremetal.\u003cresource\u003e.created\" events."},{"line_number":70,"context_line":"In addition to node states and internals changes in these fields will be"},{"line_number":71,"context_line":"ignored for \"baremetal.node.updated\": \"last_error\", \"maintenance\","},{"line_number":72,"context_line":"\"maintenance_reason\". \"last_error\" should be sent with fails events,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_72c8dc55","line":69,"updated":"2016-07-26 20:54:12.000000000","message":"I\u0027m not sure I understand this. Do we internally create resources? I thought all resources have to be explicitly created via the API.","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"314cc1c858bcfda5bba7e55ce118336d9592190c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"save() methods."},{"line_number":67,"context_line":"New global variable that represent service type (\"api\" or \"conductor\")"},{"line_number":68,"context_line":"will be added and set in prepare corresponding service. It needed for determine"},{"line_number":69,"context_line":"service for \"baremetal.\u003cresource\u003e.created\" events."},{"line_number":70,"context_line":"In addition to node states and internals changes in these fields will be"},{"line_number":71,"context_line":"ignored for \"baremetal.node.updated\": \"last_error\", \"maintenance\","},{"line_number":72,"context_line":"\"maintenance_reason\". \"last_error\" should be sent with fails events,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_c9dd7be1","line":69,"in_reply_to":"dada55a8_72c8dc55","updated":"2016-07-27 13:02:38.000000000","message":"Example, driver creates ports: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/inspect.py#L38","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"16ff79b66651bee153c04db6c628e9f922464194","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Types of events for node provision state::"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    * \"baremetal.node.state_change.start\""},{"line_number":78,"context_line":"    * \"baremetal.node.state_change.end\""},{"line_number":79,"context_line":"    * \"baremetal.node.state_change.fail\""},{"line_number":80,"context_line":"    * \"baremetal.node.state_change\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_a545e743","line":77,"updated":"2016-07-26 23:24:47.000000000","message":"I know the original spec says \"baremetal.node.state_change\", but what do you think of using \"baremetal.node.provision_state_change\" instead? That\u0027s a little more specific. Someone might get confused between \"state_change\" and the node\u0027s power state.","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"314cc1c858bcfda5bba7e55ce118336d9592190c","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Types of events for node provision state::"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    * \"baremetal.node.state_change.start\""},{"line_number":78,"context_line":"    * \"baremetal.node.state_change.end\""},{"line_number":79,"context_line":"    * \"baremetal.node.state_change.fail\""},{"line_number":80,"context_line":"    * \"baremetal.node.state_change\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_635bd086","line":77,"in_reply_to":"dada55a8_a545e743","updated":"2016-07-27 13:02:38.000000000","message":"Done","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"16ff79b66651bee153c04db6c628e9f922464194","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    * \"baremetal.node.state_change.fail\""},{"line_number":80,"context_line":"    * \"baremetal.node.state_change\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Events \"start\" and \"end\" will be used if node require transition between stable"},{"line_number":83,"context_line":"states via \"\\*ING\" state. \"baremetal.node.state_change\" if node changes state"},{"line_number":84,"context_line":"immediately, \"DEPLOYING\" \u003c-\u003e \"DEPLOYWAIT\" for example."},{"line_number":85,"context_line":"All events uses the same payload with fields: \"prev_provision_state\" (previous"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_85b0a344","line":82,"range":{"start_line":82,"start_character":73,"end_line":82,"end_character":79},"updated":"2016-07-26 23:24:47.000000000","message":"Please define stable vs. unstable provision states.","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"314cc1c858bcfda5bba7e55ce118336d9592190c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    * \"baremetal.node.state_change.fail\""},{"line_number":80,"context_line":"    * \"baremetal.node.state_change\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Events \"start\" and \"end\" will be used if node require transition between stable"},{"line_number":83,"context_line":"states via \"\\*ING\" state. \"baremetal.node.state_change\" if node changes state"},{"line_number":84,"context_line":"immediately, \"DEPLOYING\" \u003c-\u003e \"DEPLOYWAIT\" for example."},{"line_number":85,"context_line":"All events uses the same payload with fields: \"prev_provision_state\" (previous"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_69360f52","line":82,"range":{"start_line":82,"start_character":73,"end_line":82,"end_character":79},"in_reply_to":"dada55a8_85b0a344","updated":"2016-07-27 13:02:38.000000000","message":"Done","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Events \"start\" and \"end\" will be used if node require transition between stable"},{"line_number":83,"context_line":"states via \"\\*ING\" state. \"baremetal.node.state_change\" if node changes state"},{"line_number":84,"context_line":"immediately, \"DEPLOYING\" \u003c-\u003e \"DEPLOYWAIT\" for example."},{"line_number":85,"context_line":"All events uses the same payload with fields: \"prev_provision_state\" (previous"},{"line_number":86,"context_line":"provision state), \"prev_target_provision_state\" (previous target provision"},{"line_number":87,"context_line":"state),\"provision_state\", target_provision_state\", \"event\" (FSM event that"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_f217aca0","line":84,"updated":"2016-07-26 20:54:12.000000000","message":"Does some external service want to know about the waiting states, or just when something starts/ends/fails? I\u0027m not sure this makes sense. If anything, maybe baremetal.node.state_change.wait?\n\nI\u0027m assuming you\u0027d have a .start emitted, even if you emitted a baremetal.node.state_change?","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Events \"start\" and \"end\" will be used if node require transition between stable"},{"line_number":83,"context_line":"states via \"\\*ING\" state. \"baremetal.node.state_change\" if node changes state"},{"line_number":84,"context_line":"immediately, \"DEPLOYING\" \u003c-\u003e \"DEPLOYWAIT\" for example."},{"line_number":85,"context_line":"All events uses the same payload with fields: \"prev_provision_state\" (previous"},{"line_number":86,"context_line":"provision state), \"prev_target_provision_state\" (previous target provision"},{"line_number":87,"context_line":"state),\"provision_state\", target_provision_state\", \"event\" (FSM event that"},{"line_number":88,"context_line":"triggered state change), \"last_error\" (will be empty except \"fail\" event)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_726bbc1e","line":85,"updated":"2016-07-26 20:54:12.000000000","message":"s/usees/use/","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"314cc1c858bcfda5bba7e55ce118336d9592190c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Events \"start\" and \"end\" will be used if node require transition between stable"},{"line_number":83,"context_line":"states via \"\\*ING\" state. \"baremetal.node.state_change\" if node changes state"},{"line_number":84,"context_line":"immediately, \"DEPLOYING\" \u003c-\u003e \"DEPLOYWAIT\" for example."},{"line_number":85,"context_line":"All events uses the same payload with fields: \"prev_provision_state\" (previous"},{"line_number":86,"context_line":"provision state), \"prev_target_provision_state\" (previous target provision"},{"line_number":87,"context_line":"state),\"provision_state\", target_provision_state\", \"event\" (FSM event that"},{"line_number":88,"context_line":"triggered state change), \"last_error\" (will be empty except \"fail\" event)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_4906ab86","line":85,"in_reply_to":"dada55a8_726bbc1e","updated":"2016-07-27 13:02:38.000000000","message":"Done","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Alternatives"},{"line_number":91,"context_line":"------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Data model impact"},{"line_number":96,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_92559051","line":93,"updated":"2016-07-26 20:54:12.000000000","message":"well, i guess the external service could \u0027poll\u0027 the resources via \u0027ironic \u003cresource\u003e-show\u0027 for most of this information (just not the create).","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"314cc1c858bcfda5bba7e55ce118336d9592190c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Alternatives"},{"line_number":91,"context_line":"------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Data model impact"},{"line_number":96,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_e9d4bfe9","line":93,"in_reply_to":"dada55a8_92559051","updated":"2016-07-27 13:02:38.000000000","message":"Done","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"6a0c1938b745665df83af4bbba690ecb9f80e8fb","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Scalability impact"},{"line_number":146,"context_line":"------------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"When CRUD notifications enabled they can create high load to message bus durung"},{"line_number":149,"context_line":"deploy on large environments."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_2c0e048c","line":148,"range":{"start_line":148,"start_character":73,"end_line":148,"end_character":79},"updated":"2016-07-26 22:09:19.000000000","message":"during","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"314cc1c858bcfda5bba7e55ce118336d9592190c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Scalability impact"},{"line_number":146,"context_line":"------------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"When CRUD notifications enabled they can create high load to message bus durung"},{"line_number":149,"context_line":"deploy on large environments."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_23cc3834","line":148,"range":{"start_line":148,"start_character":73,"end_line":148,"end_character":79},"in_reply_to":"dada55a8_2c0e048c","updated":"2016-07-27 13:02:38.000000000","message":"Done","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":159,"context_line":"The following configuration options will be added to ``ironic_notification``"},{"line_number":160,"context_line":"group (group will be created):"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* ``resources_crud_notifications`` - if enabled CRUD notifications will be"},{"line_number":163,"context_line":"  sent, boolean, default False."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* ``unstable_states_change_notifications`` - if enabled notifications about"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_72d9fcf2","line":162,"updated":"2016-07-26 20:54:12.000000000","message":"what about the value being a list of resources, so one could specify only the resources of interest?","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"16ff79b66651bee153c04db6c628e9f922464194","unresolved":false,"context_lines":[{"line_number":159,"context_line":"The following configuration options will be added to ``ironic_notification``"},{"line_number":160,"context_line":"group (group will be created):"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* ``resources_crud_notifications`` - if enabled CRUD notifications will be"},{"line_number":163,"context_line":"  sent, boolean, default False."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* ``unstable_states_change_notifications`` - if enabled notifications about"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_6223e5bd","line":162,"in_reply_to":"dada55a8_72d9fcf2","updated":"2016-07-26 23:24:47.000000000","message":"I\u0027m a bit hesitant on defining this group. In the original spec we decided to have each notification have a \"priority\" similar to log level priority (debug, warn, error, etc.) to determine whether it would be sent or not.\n\nI can see the justification for CRUD notifications being treated as a special case if some other OpenStack project (i.e. Searchlight) needs these enabled for some reason regardless of their \"priority level,\" however.\n\nI don\u0027t see the justification for the \"unstable state change\" notification option specified below, though. I think we should define unstable states in terms of the priority of the state change as in the original spec. If something enters a deploy failed or clean failed state, a warning or error notification should be sufficient to enable them. If we\u0027re sending a notification with a warning or error level that is too spammy and tells an operator things that aren\u0027t necessarily that important, we\u0027re not being strict enough about the semantics of the priority.\n\nIf we need a special option for unstable states for some reason, we should at least update the original spec and come to a consensus about that. We\u0027d have to define some sort of litmus test for when it\u0027s OK to just use the priority levels and when a new option is justified. It might become confusing to an operator if some notifications are enabled by their own special options and some other notifications are sent based on priority level.","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":163,"context_line":"  sent, boolean, default False."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* ``unstable_states_change_notifications`` - if enabled notifications about"},{"line_number":166,"context_line":"  state changes between unstable states will be sent, boolean, default False."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Developer impact"},{"line_number":169,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_529cb80d","line":166,"updated":"2016-07-26 20:54:12.000000000","message":"Would you please elaborate on what \u0027unstable states\u0027 mean? Are these for the node\u0027s provision state events?","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f91ee38686c0df1a5f382208632929bb26863cf6","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* ``unstable_states_change_notifications`` - if enabled notifications about"},{"line_number":166,"context_line":"  state changes between unstable states will be sent, boolean, default False."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Developer impact"},{"line_number":169,"context_line":"----------------"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_12bd2068","line":167,"updated":"2016-07-26 20:54:12.000000000","message":"so node.maintenance changes will always be emitted; no way to turn those off?","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"16ff79b66651bee153c04db6c628e9f922464194","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* ``unstable_states_change_notifications`` - if enabled notifications about"},{"line_number":166,"context_line":"  state changes between unstable states will be sent, boolean, default False."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Developer impact"},{"line_number":169,"context_line":"----------------"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_05003300","line":167,"in_reply_to":"dada55a8_12bd2068","updated":"2016-07-26 23:24:47.000000000","message":"Agreed, this should be specified. We should at least figure out the priority of that notification if we end up going the route of the original spec and determining whether a notification should be sent based on its priorities (debug, warning, etc.)","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"6a0c1938b745665df83af4bbba690ecb9f80e8fb","unresolved":false,"context_lines":[{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Unit tests will be added."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":204,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_0c618039","line":202,"updated":"2016-07-26 22:09:19.000000000","message":"Possibly, functional tests assigned for Sergii Turivnyi should be mentioned here?","commit_id":"b62c9ebb5ae731d1e32a7698bb563b00e746b739"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"828ca5e6220992d8b29ebdbe74a31bd705f73257","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1606520"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes new notifications to Ironic: CRUD (create, update, or"},{"line_number":14,"context_line":"delete) of resources and node provision states change."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bacf61ea_82cd6bb9","line":13,"updated":"2016-07-29 18:31:10.000000000","message":"nit: s/Ironic/ironic/ (throughout)","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c0d3f2f288205bacf8e5e7ad46e68fd7c9ba9834","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1606520"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes new notifications to Ironic: CRUD (create, update, or"},{"line_number":14,"context_line":"delete) of resources and node provision states change."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_6931bcec","line":13,"in_reply_to":"bacf61ea_82cd6bb9","updated":"2016-08-08 12:20:00.000000000","message":"Done","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"828ca5e6220992d8b29ebdbe74a31bd705f73257","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    * \"baremetal.\u003cresource\u003e.updated\""},{"line_number":36,"context_line":"    * \"baremetal.\u003cresource\u003e.deleted\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Resource can be ``node``, ``port``, ``chassis`` and ``portgroup`` (after"},{"line_number":39,"context_line":"portgroups support will be added to Ironic)."},{"line_number":40,"context_line":"For node also two additional event types related to node update will be"},{"line_number":41,"context_line":"defined::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bacf61ea_426533b3","line":38,"updated":"2016-07-29 18:31:10.000000000","message":"Given this impacts all basic resources, we should change remove \"node-\" from the beginning of the spec filename.","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"a3b0c633f806dd0a2f5072cbebfa3495c49228b8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    * \"baremetal.\u003cresource\u003e.updated\""},{"line_number":36,"context_line":"    * \"baremetal.\u003cresource\u003e.deleted\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Resource can be ``node``, ``port``, ``chassis`` and ``portgroup`` (after"},{"line_number":39,"context_line":"portgroups support will be added to Ironic)."},{"line_number":40,"context_line":"For node also two additional event types related to node update will be"},{"line_number":41,"context_line":"defined::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bacf61ea_c27b8abc","line":38,"in_reply_to":"bacf61ea_426533b3","updated":"2016-08-01 22:16:09.000000000","message":"++","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c0d3f2f288205bacf8e5e7ad46e68fd7c9ba9834","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    * \"baremetal.\u003cresource\u003e.updated\""},{"line_number":36,"context_line":"    * \"baremetal.\u003cresource\u003e.deleted\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Resource can be ``node``, ``port``, ``chassis`` and ``portgroup`` (after"},{"line_number":39,"context_line":"portgroups support will be added to Ironic)."},{"line_number":40,"context_line":"For node also two additional event types related to node update will be"},{"line_number":41,"context_line":"defined::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_8934f0de","line":38,"in_reply_to":"bacf61ea_c27b8abc","updated":"2016-08-08 12:20:00.000000000","message":"Done","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"828ca5e6220992d8b29ebdbe74a31bd705f73257","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Alternatives"},{"line_number":120,"context_line":"------------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Periodical polling Ironic resources via API."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bacf61ea_02c4db5c","line":122,"updated":"2016-07-29 18:31:10.000000000","message":"s/Periodical/Periodically/","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c0d3f2f288205bacf8e5e7ad46e68fd7c9ba9834","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Alternatives"},{"line_number":120,"context_line":"------------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Periodical polling Ironic resources via API."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_493af8ce","line":122,"in_reply_to":"bacf61ea_02c4db5c","updated":"2016-08-08 12:20:00.000000000","message":"Done","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"828ca5e6220992d8b29ebdbe74a31bd705f73257","unresolved":false,"context_lines":[{"line_number":174,"context_line":"Scalability impact"},{"line_number":175,"context_line":"------------------"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"When CRUD update notifications enabled they can create high load to message bus"},{"line_number":178,"context_line":"during deploy on large environments."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bacf61ea_029b3b73","line":177,"updated":"2016-07-29 18:31:10.000000000","message":"s/notifications enabled/notifications are enabled/","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c0d3f2f288205bacf8e5e7ad46e68fd7c9ba9834","unresolved":false,"context_lines":[{"line_number":174,"context_line":"Scalability impact"},{"line_number":175,"context_line":"------------------"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"When CRUD update notifications enabled they can create high load to message bus"},{"line_number":178,"context_line":"during deploy on large environments."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_e9248cb0","line":177,"in_reply_to":"bacf61ea_029b3b73","updated":"2016-08-08 12:20:00.000000000","message":"Done","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"a3b0c633f806dd0a2f5072cbebfa3495c49228b8","unresolved":false,"context_lines":[{"line_number":185,"context_line":"Other deployer impact"},{"line_number":186,"context_line":"---------------------"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Deployers should set ``notification_priority`` config options properly if"},{"line_number":189,"context_line":"they want or do not want to receive different types of notifications events."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bacf61ea_85387cd4","line":188,"range":{"start_line":188,"start_character":23,"end_line":188,"end_character":44},"updated":"2016-08-01 22:16:09.000000000","message":"just fyi, this may change to notification_level depending on the outcome of https://review.openstack.org/#/c/298461\n\nI don\u0027t think it\u0027s that important that it needs to be called out here, but I just wanted to let you know.","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"a3b0c633f806dd0a2f5072cbebfa3495c49228b8","unresolved":false,"context_lines":[{"line_number":217,"context_line":"Dependencies"},{"line_number":218,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Generic notifications code in Ironic."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Testing"},{"line_number":223,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bacf61ea_e22e8ea3","line":220,"updated":"2016-08-01 22:16:09.000000000","message":"portgroup support is also a dependency for that piece","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c0d3f2f288205bacf8e5e7ad46e68fd7c9ba9834","unresolved":false,"context_lines":[{"line_number":217,"context_line":"Dependencies"},{"line_number":218,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Generic notifications code in Ironic."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Testing"},{"line_number":223,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_0920009b","line":220,"in_reply_to":"bacf61ea_e22e8ea3","updated":"2016-08-08 12:20:00.000000000","message":"It\u0027s not included in work items, so I consider it not a dependency :)","commit_id":"9ee971dfea2ae2523da71f9166d2211588a46828"}]}
