)]}'
{"specs/approved/evolve-tasks.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39998532330e6566cfd5c6918612b78ed543acfd","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Instead, clients rely on the discrete resource (Node, Port, etc) and must"},{"line_number":35,"context_line":"repeatedly poll Ironic\u0027s API to observe whether the *effect* which the client"},{"line_number":36,"context_line":"hoped to achieve has, in fact, been achieved. The result of this request is"},{"line_number":37,"context_line":"lost if any other operation on the same resource is requested (and accepted) by"},{"line_number":38,"context_line":"Ironic. For example, imagine client A requests a Node to be powered on, and"},{"line_number":39,"context_line":"then client B requests the same Node to be powered off -- before client A polls"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_92528cdc","line":36,"updated":"2016-10-26 09:57:22.000000000","message":"This spec does not seem to avoid polling. Should we add notifications here?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c8205754fb756dc92655eb10c1f0df22e7502dcc","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Instead, clients rely on the discrete resource (Node, Port, etc) and must"},{"line_number":35,"context_line":"repeatedly poll Ironic\u0027s API to observe whether the *effect* which the client"},{"line_number":36,"context_line":"hoped to achieve has, in fact, been achieved. The result of this request is"},{"line_number":37,"context_line":"lost if any other operation on the same resource is requested (and accepted) by"},{"line_number":38,"context_line":"Ironic. For example, imagine client A requests a Node to be powered on, and"},{"line_number":39,"context_line":"then client B requests the same Node to be powered off -- before client A polls"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_2a0a16d3","line":36,"in_reply_to":"ba5da102_92528cdc","updated":"2016-10-27 07:02:12.000000000","message":"Well, it\u0027s meant to tell us that the user must poll to see the effect - they should be able to poll the task object instead. This change isn\u0027t intended to prevent polling.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"A \"task\" resource shall be created automatically as a result of any"},{"line_number":50,"context_line":"asynchronous action which changes properties of a Node. This includes many"},{"line_number":51,"context_line":"existing methods, such as changing the power or provision state, updating Node"},{"line_number":52,"context_line":"properties, etc, as well as any future similar methods."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"A \"task\" shall be said to be in one of three states: started, completed, or"},{"line_number":55,"context_line":"failed."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_af063f1e","line":52,"range":{"start_line":51,"start_character":65,"end_line":52,"end_character":10},"updated":"2016-11-07 16:29:20.000000000","message":"It does not seem to be async.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"A \"task\" resource shall be created automatically as a result of any"},{"line_number":50,"context_line":"asynchronous action which changes properties of a Node. This includes many"},{"line_number":51,"context_line":"existing methods, such as changing the power or provision state, updating Node"},{"line_number":52,"context_line":"properties, etc, as well as any future similar methods."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"A \"task\" shall be said to be in one of three states: started, completed, or"},{"line_number":55,"context_line":"failed."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_0b6f882b","line":52,"range":{"start_line":51,"start_character":65,"end_line":52,"end_character":10},"in_reply_to":"9a629dbe_af063f1e","updated":"2016-11-28 17:13:52.000000000","message":"removed it from the list of examples","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"properties, etc, as well as any future similar methods."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"A \"task\" shall be said to be in one of three states: started, completed, or"},{"line_number":55,"context_line":"failed."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Each \"task\" shall have one or more \"events\" associated with it, which represent"},{"line_number":58,"context_line":"discrete steps executed by Ironic in the process of carrying out the task. An"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_ed9d7f5a","line":55,"updated":"2016-10-18 18:19:29.000000000","message":"Probably obvious so maybe we don\u0027t need to mention it here, but each task will have a unique ID (uuid)?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"properties, etc, as well as any future similar methods."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"A \"task\" shall be said to be in one of three states: started, completed, or"},{"line_number":55,"context_line":"failed."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Each \"task\" shall have one or more \"events\" associated with it, which represent"},{"line_number":58,"context_line":"discrete steps executed by Ironic in the process of carrying out the task. An"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_cb575058","line":55,"in_reply_to":"da6895a0_b1a574b6","updated":"2016-11-28 17:13:52.000000000","message":"I added it here to make it clear.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":52,"context_line":"properties, etc, as well as any future similar methods."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"A \"task\" shall be said to be in one of three states: started, completed, or"},{"line_number":55,"context_line":"failed."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Each \"task\" shall have one or more \"events\" associated with it, which represent"},{"line_number":58,"context_line":"discrete steps executed by Ironic in the process of carrying out the task. An"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6895a0_b1a574b6","line":55,"in_reply_to":"fa6399be_ed9d7f5a","updated":"2016-10-26 09:32:36.000000000","message":"Yes.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":54,"context_line":"A \"task\" shall be said to be in one of three states: started, completed, or"},{"line_number":55,"context_line":"failed."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Each \"task\" shall have one or more \"events\" associated with it, which represent"},{"line_number":58,"context_line":"discrete steps executed by Ironic in the process of carrying out the task. An"},{"line_number":59,"context_line":"event contains a timestamp, a numerical status code (the HTTP status of the"},{"line_number":60,"context_line":"exception, if it is an error), and a message string (the exception string, if"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_92da8077","line":57,"updated":"2016-11-07 16:29:20.000000000","message":"I wonder will it contain all the events, even ones that have not started because the previous ones have not finished or failed?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"A \"task\" shall be said to be in one of three states: started, completed, or"},{"line_number":55,"context_line":"failed."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Each \"task\" shall have one or more \"events\" associated with it, which represent"},{"line_number":58,"context_line":"discrete steps executed by Ironic in the process of carrying out the task. An"},{"line_number":59,"context_line":"event contains a timestamp, a numerical status code (the HTTP status of the"},{"line_number":60,"context_line":"exception, if it is an error), and a message string (the exception string, if"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_6bd63cf2","line":57,"in_reply_to":"9a629dbe_92da8077","updated":"2016-11-28 17:13:52.000000000","message":"I think these should be the steps already executed.\n\nI\u0027m afraid if we want to have all states from the beginning we would start creating something like taskflow.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Each \"task\" shall have one or more \"events\" associated with it, which represent"},{"line_number":58,"context_line":"discrete steps executed by Ironic in the process of carrying out the task. An"},{"line_number":59,"context_line":"event contains a timestamp, a numerical status code (the HTTP status of the"},{"line_number":60,"context_line":"exception, if it is an error), and a message string (the exception string, if"},{"line_number":61,"context_line":"it is an error). Timestamps for \"events\" shall be stored with microsecond"},{"line_number":62,"context_line":"precision."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_bf456618","line":60,"updated":"2016-10-18 18:19:29.000000000","message":"if it isn\u0027t an error, is this HTTP 200? Or is this only used for errors?\n\nsimilar question about message string. If it isn\u0027t an error, what will be in this string?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c8205754fb756dc92655eb10c1f0df22e7502dcc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Each \"task\" shall have one or more \"events\" associated with it, which represent"},{"line_number":58,"context_line":"discrete steps executed by Ironic in the process of carrying out the task. An"},{"line_number":59,"context_line":"event contains a timestamp, a numerical status code (the HTTP status of the"},{"line_number":60,"context_line":"exception, if it is an error), and a message string (the exception string, if"},{"line_number":61,"context_line":"it is an error). Timestamps for \"events\" shall be stored with microsecond"},{"line_number":62,"context_line":"precision."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_8af962cb","line":60,"in_reply_to":"da6895a0_31e4040c","updated":"2016-10-27 07:02:12.000000000","message":"Should we instead use the error format in the API guidelines? (I notice the project-specific error code is missing here)","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Each \"task\" shall have one or more \"events\" associated with it, which represent"},{"line_number":58,"context_line":"discrete steps executed by Ironic in the process of carrying out the task. An"},{"line_number":59,"context_line":"event contains a timestamp, a numerical status code (the HTTP status of the"},{"line_number":60,"context_line":"exception, if it is an error), and a message string (the exception string, if"},{"line_number":61,"context_line":"it is an error). Timestamps for \"events\" shall be stored with microsecond"},{"line_number":62,"context_line":"precision."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6895a0_31e4040c","line":60,"in_reply_to":"fa6399be_142fc988","updated":"2016-10-26 09:32:36.000000000","message":"@Ruby, I think it should be 200 for non-errors, and the message may or may not be empty.\n\n@Yuriy, That is not the standard.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fad9955f65c15bd37114953d965156e5eccd1b96","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Each \"task\" shall have one or more \"events\" associated with it, which represent"},{"line_number":58,"context_line":"discrete steps executed by Ironic in the process of carrying out the task. An"},{"line_number":59,"context_line":"event contains a timestamp, a numerical status code (the HTTP status of the"},{"line_number":60,"context_line":"exception, if it is an error), and a message string (the exception string, if"},{"line_number":61,"context_line":"it is an error). Timestamps for \"events\" shall be stored with microsecond"},{"line_number":62,"context_line":"precision."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_142fc988","line":60,"in_reply_to":"fa6399be_bf456618","updated":"2016-10-20 11:38:24.000000000","message":"I think we should have separate description and error fields.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":61,"context_line":"it is an error). Timestamps for \"events\" shall be stored with microsecond"},{"line_number":62,"context_line":"precision."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"A \"task\" shall also record the user and tenant who made the request that"},{"line_number":65,"context_line":"created the task, or \"None\" if the action is the result of a periodic task."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. NOTE: should this be \"admin\" or \"ironic\" instead of None?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_52cf08b0","line":64,"updated":"2016-11-07 16:29:20.000000000","message":"nit - and domain","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"it is an error). Timestamps for \"events\" shall be stored with microsecond"},{"line_number":62,"context_line":"precision."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"A \"task\" shall also record the user and tenant who made the request that"},{"line_number":65,"context_line":"created the task, or \"None\" if the action is the result of a periodic task."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. NOTE: should this be \"admin\" or \"ironic\" instead of None?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_26439b43","line":64,"in_reply_to":"9a629dbe_52cf08b0","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"A \"task\" shall also record the user and tenant who made the request that"},{"line_number":65,"context_line":"created the task, or \"None\" if the action is the result of a periodic task."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. NOTE: should this be \"admin\" or \"ironic\" instead of None?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_4d9f4b5f","line":67,"updated":"2016-10-18 18:19:29.000000000","message":"fyi, this note doesn\u0027t show up in the rendered page.\n\nI prefer something other than None. But if we put something that isn\u0027t None, will the user think that this is the actual user/tenant that made the request (vs an internal task). And/or can we make something up like \u0027_admin\u0027? or \u0027_internal\u0027? Well, maybe None is easiest :)","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"A \"task\" shall also record the user and tenant who made the request that"},{"line_number":65,"context_line":"created the task, or \"None\" if the action is the result of a periodic task."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. NOTE: should this be \"admin\" or \"ironic\" instead of None?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_8f7f12aa","line":67,"in_reply_to":"9a629dbe_b255c4c7","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":64,"context_line":"A \"task\" shall also record the user and tenant who made the request that"},{"line_number":65,"context_line":"created the task, or \"None\" if the action is the result of a periodic task."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. NOTE: should this be \"admin\" or \"ironic\" instead of None?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_b255c4c7","line":67,"in_reply_to":"ba5da102_4a266a69","updated":"2016-11-07 16:29:20.000000000","message":"++","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c8205754fb756dc92655eb10c1f0df22e7502dcc","unresolved":false,"context_lines":[{"line_number":64,"context_line":"A \"task\" shall also record the user and tenant who made the request that"},{"line_number":65,"context_line":"created the task, or \"None\" if the action is the result of a periodic task."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. NOTE: should this be \"admin\" or \"ironic\" instead of None?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_4a266a69","line":67,"in_reply_to":"da6895a0_b1d73422","updated":"2016-10-27 07:02:12.000000000","message":"Periodic tasks *do* have a context object, I believe this has an auth token. We should probably use whatever that is. :)","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":64,"context_line":"A \"task\" shall also record the user and tenant who made the request that"},{"line_number":65,"context_line":"created the task, or \"None\" if the action is the result of a periodic task."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. NOTE: should this be \"admin\" or \"ironic\" instead of None?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6895a0_b1d73422","line":67,"in_reply_to":"fa6399be_4512b40a","updated":"2016-10-26 09:32:36.000000000","message":"I do not think we should overload the user/tenant with any metadata that is not actually a valid keystone user/tenant. Doing such would confuse operators more than help them.\n\nWe could add additional metadata fields (db columns) to store this, if folks feel it is going to be valuable.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"47791886df93fb0e261e6b72afbe610c82e4e018","unresolved":false,"context_lines":[{"line_number":64,"context_line":"A \"task\" shall also record the user and tenant who made the request that"},{"line_number":65,"context_line":"created the task, or \"None\" if the action is the result of a periodic task."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. NOTE: should this be \"admin\" or \"ironic\" instead of None?"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_4512b40a","line":67,"in_reply_to":"fa6399be_4d9f4b5f","updated":"2016-10-18 20:15:44.000000000","message":"Maybe it\u0027s possible to do something interesting like the hostname / identifier of the conductor executing the task, assuming that all events are carried out on the same greenthread.\n\nThat way, the operator could identify if a particular conductor is \"stuck\" on  many operations and look into it before it becomes a more severe problem. I don\u0027t want to bikeshed here, just a thought.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The ironic-api service shall begin to return \"X-Task-Id\" in the header of all"},{"line_number":72,"context_line":"API responses where the HTTP status code is 202 ACCEPTED."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Specifically, this header shall be added to the responses of the following API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_386257d9","line":71,"updated":"2016-10-18 18:19:29.000000000","message":"I\u0027d prefer s/X-Task-Id/X-Task-ID/\n\nI looked and ID seems to be used (except for Downgraded-Message-Id, the rest are ID): http://www.iana.org/assignments/message-headers/message-headers.xml#perm-headers","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The ironic-api service shall begin to return \"X-Task-Id\" in the header of all"},{"line_number":72,"context_line":"API responses where the HTTP status code is 202 ACCEPTED."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Specifically, this header shall be added to the responses of the following API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_66bcb306","line":71,"in_reply_to":"9a629dbe_12d83053","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The ironic-api service shall begin to return \"X-Task-Id\" in the header of all"},{"line_number":72,"context_line":"API responses where the HTTP status code is 202 ACCEPTED."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Specifically, this header shall be added to the responses of the following API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_12d83053","line":71,"in_reply_to":"da6895a0_516ed895","updated":"2016-11-07 16:29:20.000000000","message":"Also IIRC headers ignore the case, OpenStack-Task-ID is the same as openstack-task-id, so Id vs. ID should not matter :)","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"47791886df93fb0e261e6b72afbe610c82e4e018","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The ironic-api service shall begin to return \"X-Task-Id\" in the header of all"},{"line_number":72,"context_line":"API responses where the HTTP status code is 202 ACCEPTED."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Specifically, this header shall be added to the responses of the following API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_c5fec4ad","line":71,"in_reply_to":"fa6399be_386257d9","updated":"2016-10-18 20:15:44.000000000","message":"+1","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The ironic-api service shall begin to return \"X-Task-Id\" in the header of all"},{"line_number":72,"context_line":"API responses where the HTTP status code is 202 ACCEPTED."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Specifically, this header shall be added to the responses of the following API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6895a0_516ed895","line":71,"in_reply_to":"fa6399be_60375bff","updated":"2016-10-26 09:32:36.000000000","message":"Good point. While that guideline does indicate we can still use \"X-\" prefix, we\u0027re already discussing migrating our existing headers.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"4811ce2fbeac8ea0ad09030ebbd10c6c89ec1e00","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"**Returning task id header to clients**"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The ironic-api service shall begin to return \"X-Task-Id\" in the header of all"},{"line_number":72,"context_line":"API responses where the HTTP status code is 202 ACCEPTED."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Specifically, this header shall be added to the responses of the following API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_60375bff","line":71,"in_reply_to":"fa6399be_c5fec4ad","updated":"2016-10-21 14:48:00.000000000","message":"According to the guideline[1], X-Foo Naming is not recommended.\nOpenStack-Task-ID or OpenStack-Baremetal-Task-ID would be better.\n\n[1] https://specs.openstack.org/openstack/api-wg/guidelines/headers.html","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fad9955f65c15bd37114953d965156e5eccd1b96","unresolved":false,"context_lines":[{"line_number":77,"context_line":"- PUT /nodes/NODE/states/console"},{"line_number":78,"context_line":"- PUT /nodes/NODE/states/power"},{"line_number":79,"context_line":"- PUT /nodes/NODE/states/provision"},{"line_number":80,"context_line":"- PUT /nodes/NODE/maintenance"},{"line_number":81,"context_line":"- DELETE /nodes/NODE/maintenance"},{"line_number":82,"context_line":"- requests to /nodes/NODE/vendor_passthru where the driver indicates that the"},{"line_number":83,"context_line":"  response is asynchronous"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_14a50946","line":81,"range":{"start_line":80,"start_character":2,"end_line":81,"end_character":32},"updated":"2016-10-20 11:38:24.000000000","message":"These are sync operations.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"- PUT /nodes/NODE/states/console"},{"line_number":78,"context_line":"- PUT /nodes/NODE/states/power"},{"line_number":79,"context_line":"- PUT /nodes/NODE/states/provision"},{"line_number":80,"context_line":"- PUT /nodes/NODE/maintenance"},{"line_number":81,"context_line":"- DELETE /nodes/NODE/maintenance"},{"line_number":82,"context_line":"- requests to /nodes/NODE/vendor_passthru where the driver indicates that the"},{"line_number":83,"context_line":"  response is asynchronous"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_e10fcd36","line":81,"range":{"start_line":80,"start_character":2,"end_line":81,"end_character":32},"in_reply_to":"da6895a0_d1366851","updated":"2016-11-28 17:13:52.000000000","message":"I made those a separate list which should be changed to return HTTP 200.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":77,"context_line":"- PUT /nodes/NODE/states/console"},{"line_number":78,"context_line":"- PUT /nodes/NODE/states/power"},{"line_number":79,"context_line":"- PUT /nodes/NODE/states/provision"},{"line_number":80,"context_line":"- PUT /nodes/NODE/maintenance"},{"line_number":81,"context_line":"- DELETE /nodes/NODE/maintenance"},{"line_number":82,"context_line":"- requests to /nodes/NODE/vendor_passthru where the driver indicates that the"},{"line_number":83,"context_line":"  response is asynchronous"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6895a0_d1366851","line":81,"range":{"start_line":80,"start_character":2,"end_line":81,"end_character":32},"in_reply_to":"fa6399be_14a50946","updated":"2016-10-26 09:32:36.000000000","message":"The API returns 202 ACCEPTED for both of these calls. But you\u0027re right - they actually call manager.update_node, which is synchronous.\n\nDo you think we should change these API calls to return HTTP 200?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":79,"context_line":"- PUT /nodes/NODE/states/provision"},{"line_number":80,"context_line":"- PUT /nodes/NODE/maintenance"},{"line_number":81,"context_line":"- DELETE /nodes/NODE/maintenance"},{"line_number":82,"context_line":"- requests to /nodes/NODE/vendor_passthru where the driver indicates that the"},{"line_number":83,"context_line":"  response is asynchronous"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"**Automated tasks**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_18092f2d","line":82,"updated":"2016-11-07 16:29:20.000000000","message":"What about driver_passthru?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"- PUT /nodes/NODE/states/provision"},{"line_number":80,"context_line":"- PUT /nodes/NODE/maintenance"},{"line_number":81,"context_line":"- DELETE /nodes/NODE/maintenance"},{"line_number":82,"context_line":"- requests to /nodes/NODE/vendor_passthru where the driver indicates that the"},{"line_number":83,"context_line":"  response is asynchronous"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"**Automated tasks**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_fcb694f7","line":82,"in_reply_to":"9a629dbe_18092f2d","updated":"2016-11-28 17:13:52.000000000","message":"Added it to the list.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"\"X-Task-Id\" header, they will be added to the list of tasks and exposed in the"},{"line_number":94,"context_line":"same way as other tasks."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Such tasks will be created with the user_id and tenant_id values of \"None\"."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"**The /tasks resource**"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_6d1defbc","line":96,"updated":"2016-10-18 18:19:29.000000000","message":"If we change it to \u0027admin\u0027 or \u0027ironic\u0027 above, this will also need to be changed.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"\"X-Task-Id\" header, they will be added to the list of tasks and exposed in the"},{"line_number":94,"context_line":"same way as other tasks."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Such tasks will be created with the user_id and tenant_id values of \"None\"."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"**The /tasks resource**"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_8a1b8072","line":96,"in_reply_to":"fa6399be_6d1defbc","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5c168e9e62e65a52cd425eb005f5502f60e016a6","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Such tasks will be created with the user_id and tenant_id values of \"None\"."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"**The /tasks resource**"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"A new REST API resource shall be added to allow clients to query the status of"},{"line_number":101,"context_line":"tasks. The root of this resource shall be::"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_aac8f175","line":99,"updated":"2016-10-26 15:45:02.000000000","message":"Is it worth stating explicitly that this will be a read-only resource that will not provide an interface to create tasks? (at least that is what I have understood from reading this).","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Such tasks will be created with the user_id and tenant_id values of \"None\"."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"**The /tasks resource**"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"A new REST API resource shall be added to allow clients to query the status of"},{"line_number":101,"context_line":"tasks. The root of this resource shall be::"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_4ab16846","line":99,"in_reply_to":"ba5da102_aac8f175","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"529aaada7d9067a7546cbae24eced1104726de11","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      ["},{"line_number":111,"context_line":"        {"},{"line_number":112,"context_line":"          \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":113,"context_line":"          \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":114,"context_line":"          \u0027status\u0027: \"ENUM[started,completed,failed]\","},{"line_number":115,"context_line":"          \u0027created_at\u0027: \"\u003ctimestamp\u003e\","},{"line_number":116,"context_line":"          \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_fa50cc60","line":113,"updated":"2016-10-18 18:24:07.000000000","message":"I was wondering whether it might be useful to have a description for the task. Via the events, we should be able to figure it out, but it might be more user-friendly if we had some string. The description could be 255 or fewer chars :)","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      ["},{"line_number":111,"context_line":"        {"},{"line_number":112,"context_line":"          \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":113,"context_line":"          \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":114,"context_line":"          \u0027status\u0027: \"ENUM[started,completed,failed]\","},{"line_number":115,"context_line":"          \u0027created_at\u0027: \"\u003ctimestamp\u003e\","},{"line_number":116,"context_line":"          \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_457ebb19","line":113,"in_reply_to":"9a629dbe_b84be3af","updated":"2016-11-28 17:13:52.000000000","message":"I would add a \u0027task_type\u0027 field here, it could be filled in the classes implementing the tasks or inferred from the class name or maintained in an opcodes table.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      ["},{"line_number":111,"context_line":"        {"},{"line_number":112,"context_line":"          \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":113,"context_line":"          \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":114,"context_line":"          \u0027status\u0027: \"ENUM[started,completed,failed]\","},{"line_number":115,"context_line":"          \u0027created_at\u0027: \"\u003ctimestamp\u003e\","},{"line_number":116,"context_line":"          \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_b84be3af","line":113,"in_reply_to":"da6895a0_f110ccaa","updated":"2016-11-07 16:29:20.000000000","message":"Maybe just hardcode those in API methods?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      ["},{"line_number":111,"context_line":"        {"},{"line_number":112,"context_line":"          \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":113,"context_line":"          \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":114,"context_line":"          \u0027status\u0027: \"ENUM[started,completed,failed]\","},{"line_number":115,"context_line":"          \u0027created_at\u0027: \"\u003ctimestamp\u003e\","},{"line_number":116,"context_line":"          \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6895a0_f110ccaa","line":113,"in_reply_to":"fa6399be_fa50cc60","updated":"2016-10-26 09:32:36.000000000","message":"Agreed. Any suggestions on where to define (or infer) these names?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fad9955f65c15bd37114953d965156e5eccd1b96","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      ["},{"line_number":111,"context_line":"        {"},{"line_number":112,"context_line":"          \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":113,"context_line":"          \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":114,"context_line":"          \u0027status\u0027: \"ENUM[started,completed,failed]\","},{"line_number":115,"context_line":"          \u0027created_at\u0027: \"\u003ctimestamp\u003e\","},{"line_number":116,"context_line":"          \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_74a2c5fd","line":113,"in_reply_to":"fa6399be_fa50cc60","updated":"2016-10-20 11:38:24.000000000","message":"It\u0027s really needed. For example client B send request: what operation is going now? These descriptions in the string form should be pre-defined and not updated quickly (maybe use opcode and opcodes table?).","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        {"},{"line_number":112,"context_line":"          \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":113,"context_line":"          \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":114,"context_line":"          \u0027status\u0027: \"ENUM[started,completed,failed]\","},{"line_number":115,"context_line":"          \u0027created_at\u0027: \"\u003ctimestamp\u003e\","},{"line_number":116,"context_line":"          \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","},{"line_number":117,"context_line":"          \u0027user_id\u0027: \"\u003cuser UUID or none\u003e\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_df95ba88","line":114,"updated":"2016-10-18 18:19:29.000000000","message":"I was wondering about this. When does a task stop being currently-run? At some point *after* it is completed or failed?\n\nOr maybe you mean as long as the tasks are available? (Based on the task_ttl config.)","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        {"},{"line_number":112,"context_line":"          \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":113,"context_line":"          \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":114,"context_line":"          \u0027status\u0027: \"ENUM[started,completed,failed]\","},{"line_number":115,"context_line":"          \u0027created_at\u0027: \"\u003ctimestamp\u003e\","},{"line_number":116,"context_line":"          \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","},{"line_number":117,"context_line":"          \u0027user_id\u0027: \"\u003cuser UUID or none\u003e\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_2d2fe588","line":114,"in_reply_to":"fa6399be_ca492833","updated":"2016-11-28 17:13:52.000000000","message":"You\u0027re right Yuriy, I\u0027ll make it clear in the spec.\n\nI believe by the time the task fails or finishes it shouldn\u0027t be \"currently-run\", but it should remain on that list based on the task_ttl config. I\u0027ll update the wording to make it clear.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fad9955f65c15bd37114953d965156e5eccd1b96","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        {"},{"line_number":112,"context_line":"          \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":113,"context_line":"          \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":114,"context_line":"          \u0027status\u0027: \"ENUM[started,completed,failed]\","},{"line_number":115,"context_line":"          \u0027created_at\u0027: \"\u003ctimestamp\u003e\","},{"line_number":116,"context_line":"          \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","},{"line_number":117,"context_line":"          \u0027user_id\u0027: \"\u003cuser UUID or none\u003e\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_ca492833","line":114,"in_reply_to":"fa6399be_df95ba88","updated":"2016-10-20 11:38:24.000000000","message":"One more comment. And when task starts? Now we have the wonderful code that reverts node\u0027s provision states if conductor thread can not be started. Task is started or not if API returns HTTP 503 synchronously on change provision state? IMO it\u0027s not started, and looks like it\u0027s conforms to RFC 7231, https://tools.ietf.org/html/rfc7231#section-6.3.3.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","},{"line_number":117,"context_line":"          \u0027user_id\u0027: \"\u003cuser UUID or none\u003e\","},{"line_number":118,"context_line":"          \u0027tenant_id\u0027: \"\u003ctenant UUID or none\u003e\","},{"line_number":119,"context_line":"          \u0027events\u0027: ["},{"line_number":120,"context_line":"            {"},{"line_number":121,"context_line":"             \u0027timestamp\u0027: \"\u003ctimestamp\"\u003e,"},{"line_number":122,"context_line":"             \u0027detail\u0027: \"\u003cmessage body\u003e\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_df713a79","line":119,"updated":"2016-10-18 18:19:29.000000000","message":"Does it show events that are done, or events that are currently being processed?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","},{"line_number":117,"context_line":"          \u0027user_id\u0027: \"\u003cuser UUID or none\u003e\","},{"line_number":118,"context_line":"          \u0027tenant_id\u0027: \"\u003ctenant UUID or none\u003e\","},{"line_number":119,"context_line":"          \u0027events\u0027: ["},{"line_number":120,"context_line":"            {"},{"line_number":121,"context_line":"             \u0027timestamp\u0027: \"\u003ctimestamp\"\u003e,"},{"line_number":122,"context_line":"             \u0027detail\u0027: \"\u003cmessage body\u003e\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_6a7624d8","line":119,"in_reply_to":"fa6399be_27273db7","updated":"2016-11-28 17:13:52.000000000","message":"Yeah, I wouldn\u0027t go into too much detail on the list of all tasks, maybe we should remove this list. Someone who wants to inspect all events pertaining to this task would then query specifically for the task of interest.\n\nIt will be also consistent with what we want to expose to the ironic client.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fad9955f65c15bd37114953d965156e5eccd1b96","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","},{"line_number":117,"context_line":"          \u0027user_id\u0027: \"\u003cuser UUID or none\u003e\","},{"line_number":118,"context_line":"          \u0027tenant_id\u0027: \"\u003ctenant UUID or none\u003e\","},{"line_number":119,"context_line":"          \u0027events\u0027: ["},{"line_number":120,"context_line":"            {"},{"line_number":121,"context_line":"             \u0027timestamp\u0027: \"\u003ctimestamp\"\u003e,"},{"line_number":122,"context_line":"             \u0027detail\u0027: \"\u003cmessage body\u003e\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_27273db7","line":119,"in_reply_to":"fa6399be_df713a79","updated":"2016-10-20 11:38:24.000000000","message":"Maybe a separate parameter is needed for showing events list here.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fad9955f65c15bd37114953d965156e5eccd1b96","unresolved":false,"context_lines":[{"line_number":117,"context_line":"          \u0027user_id\u0027: \"\u003cuser UUID or none\u003e\","},{"line_number":118,"context_line":"          \u0027tenant_id\u0027: \"\u003ctenant UUID or none\u003e\","},{"line_number":119,"context_line":"          \u0027events\u0027: ["},{"line_number":120,"context_line":"            {"},{"line_number":121,"context_line":"             \u0027timestamp\u0027: \"\u003ctimestamp\"\u003e,"},{"line_number":122,"context_line":"             \u0027detail\u0027: \"\u003cmessage body\u003e\","},{"line_number":123,"context_line":"             \u0027code\u0027: \"\u003cstatus code\u003e\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_c7004137","line":120,"updated":"2016-10-20 11:38:24.000000000","message":"One suggestion: events might not be an one-moment action. For example we changing power state during deploying process. There will be start, end(fail) also. Maybe to use task-inside-task (subtask) model?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"          \u0027user_id\u0027: \"\u003cuser UUID or none\u003e\","},{"line_number":118,"context_line":"          \u0027tenant_id\u0027: \"\u003ctenant UUID or none\u003e\","},{"line_number":119,"context_line":"          \u0027events\u0027: ["},{"line_number":120,"context_line":"            {"},{"line_number":121,"context_line":"             \u0027timestamp\u0027: \"\u003ctimestamp\"\u003e,"},{"line_number":122,"context_line":"             \u0027detail\u0027: \"\u003cmessage body\u003e\","},{"line_number":123,"context_line":"             \u0027code\u0027: \"\u003cstatus code\u003e\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_e5050711","line":120,"in_reply_to":"fa6399be_c7004137","updated":"2016-11-28 17:13:52.000000000","message":"I think these should be separate events.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        },"},{"line_number":128,"context_line":"        ..."},{"line_number":129,"context_line":"      ]"},{"line_number":130,"context_line":"    }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":".. NOTE: Do we need to support tasks for Port or Driver?"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_5a037876","line":130,"updated":"2016-10-18 18:19:29.000000000","message":"I like examples; would be nice to have one with more than one event, to get an idea of what an event is. I\u0027m guessing it matches to the provision states, eg cleaning, clean wait, ...","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"      ]"},{"line_number":130,"context_line":"    }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":".. NOTE: Do we need to support tasks for Port or Driver?"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Querying a single task resource shall be possible by supplying the ``task_id``"},{"line_number":135,"context_line":"in the query string::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_7ad75c23","line":132,"updated":"2016-10-18 18:19:29.000000000","message":"We should support tasks for any async operations. For ports, this spec can cover that, s/node/port/ in the responses and requests.\n\nFor drivers... not sure if applicable and if so, what that means, maybe address after driver composition. Cuz we don\u0027t have driver objects/UUIDs.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fad9955f65c15bd37114953d965156e5eccd1b96","unresolved":false,"context_lines":[{"line_number":129,"context_line":"      ]"},{"line_number":130,"context_line":"    }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":".. NOTE: Do we need to support tasks for Port or Driver?"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Querying a single task resource shall be possible by supplying the ``task_id``"},{"line_number":135,"context_line":"in the query string::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_d4939159","line":132,"in_reply_to":"fa6399be_7ad75c23","updated":"2016-10-20 11:38:24.000000000","message":"Good question about ports. Usually async operation with port (via neutron api) are part of deploy process (change provision state). But we updates DHCP options after sync mac update (update_port). This operation can not be synchronously due to neutron\u003c-\u003eagents specific.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"529aaada7d9067a7546cbae24eced1104726de11","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":".. NOTE: Do we need to support tasks for Port or Driver?"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Querying a single task resource shall be possible by supplying the ``task_id``"},{"line_number":135,"context_line":"in the query string::"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_3af9644e","line":133,"updated":"2016-10-18 18:24:07.000000000","message":"So we don\u0027t forget, maybe add a NOTE here wrt your comment about attaching/exposing the output of async requests, in the task. (Which I\u0027m +1 on.)","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":".. NOTE: Do we need to support tasks for Port or Driver?"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Querying a single task resource shall be possible by supplying the ``task_id``"},{"line_number":135,"context_line":"in the query string::"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_30c3be58","line":133,"in_reply_to":"fa6399be_3af9644e","updated":"2016-11-28 17:13:52.000000000","message":"Added it inline.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"9621fbd9f3e2142dcb84137e0a302176bf730243","unresolved":false,"context_lines":[{"line_number":134,"context_line":"Querying a single task resource shall be possible by supplying the ``task_id``"},{"line_number":135,"context_line":"in the query string::"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    GET /tasks/\u003cTASK_UUID\u003e"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"It shall return a JSON dictionary in the following format::"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_401d840e","line":137,"updated":"2016-11-07 14:30:20.000000000","message":"What do you think about adding a method or option for querying and deleting the task?\nIn a scenario when I\u0027m polling for a status or result of a task which I started, after I get information that the task has finished, I\u0027m no longer interested in storing this information in Ironic DB.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e8caabffe77556f55a5d3c03f3927d682c85dd39","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"It shall return a JSON dictionary in the following format::"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    {"},{"line_number":142,"context_line":"      \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":143,"context_line":"      \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":144,"context_line":"      \u0027status\u0027: \"ENUM[started,completed,failed]\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_cd8046c2","line":141,"updated":"2016-10-13 23:27:32.000000000","message":"Ironic does not currently store user or tenant on any of its resources.\n\nI would consider introducing those as a separate set of changes to the API.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2506,"name":"devdatta-kulkarni","email":"kulkarni.devdatta@gmail.com","username":"devdatta-kulkarni"},"change_message_id":"14da4b125055dec7a221c43c3e8731c5a22d3f15","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"It shall return a JSON dictionary in the following format::"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    {"},{"line_number":142,"context_line":"      \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":143,"context_line":"      \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":144,"context_line":"      \u0027status\u0027: \"ENUM[started,completed,failed]\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_a43fb585","line":141,"updated":"2016-10-13 19:07:01.000000000","message":"Why no \u0027user_id\u0027 and \u0027tenant_id\u0027 in the GET on individual tasks?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"It shall return a JSON dictionary in the following format::"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    {"},{"line_number":142,"context_line":"      \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":143,"context_line":"      \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":144,"context_line":"      \u0027status\u0027: \"ENUM[started,completed,failed]\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_d098ca7a","line":141,"in_reply_to":"9a629dbe_580c8742","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"It shall return a JSON dictionary in the following format::"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    {"},{"line_number":142,"context_line":"      \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":143,"context_line":"      \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":144,"context_line":"      \u0027status\u0027: \"ENUM[started,completed,failed]\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_580c8742","line":141,"in_reply_to":"fa6399be_7fa58eb3","updated":"2016-11-07 16:29:20.000000000","message":"I think the question is about the latter, when we do GET /tasks, the tasks in the resulting list contain user/tenant info, whereas here the representation does not contain them. They are stored in DB, so should just be added here too I suppose.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"It shall return a JSON dictionary in the following format::"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    {"},{"line_number":142,"context_line":"      \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":143,"context_line":"      \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":144,"context_line":"      \u0027status\u0027: \"ENUM[started,completed,failed]\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_7fa58eb3","line":141,"in_reply_to":"fa6399be_cd8046c2","updated":"2016-10-18 18:19:29.000000000","message":"Was the question about GET /tasks/\u003cuser|tenant ID\u003e\n\nor for why the JSON dictionary doesn\u0027t include user_id \u0026 tenant_id?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"9621fbd9f3e2142dcb84137e0a302176bf730243","unresolved":false,"context_lines":[{"line_number":147,"context_line":"      \u0027events\u0027: ["},{"line_number":148,"context_line":"        {"},{"line_number":149,"context_line":"         \u0027timestamp\u0027: \"\u003ctimestamp\"\u003e,"},{"line_number":150,"context_line":"         \u0027detail\u0027: \"\u003cmessage body\u003e\","},{"line_number":151,"context_line":"         \u0027code\u0027: \"\u003cstatus code\u003e\""},{"line_number":152,"context_line":"        },"},{"line_number":153,"context_line":"        ..."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_e0a4d809","line":150,"updated":"2016-11-07 14:30:20.000000000","message":"As discussed at the summit https://etherpad.openstack.org/p/ironic-ocata-summit-task-framework we want to use the /task resource to read tasks outputs. So maybe add a \u0027result\u0027 field, which could be any JSON object?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2506,"name":"devdatta-kulkarni","email":"kulkarni.devdatta@gmail.com","username":"devdatta-kulkarni"},"change_message_id":"14da4b125055dec7a221c43c3e8731c5a22d3f15","unresolved":false,"context_lines":[{"line_number":166,"context_line":"**Changes to RequestContext**"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"A new ``task`` property shall be added to the ``RequestContext`` class, defined"},{"line_number":169,"context_line":"in ``ironic/common/context.py``. In this way, it will accessible from all"},{"line_number":170,"context_line":"methods that accept a ``context`` object."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"The ``get_admin_context`` method defined in ironic/common/context.py shall be"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_a456d5cb","line":169,"updated":"2016-10-13 19:07:01.000000000","message":"it will be accessible","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":166,"context_line":"**Changes to RequestContext**"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"A new ``task`` property shall be added to the ``RequestContext`` class, defined"},{"line_number":169,"context_line":"in ``ironic/common/context.py``. In this way, it will accessible from all"},{"line_number":170,"context_line":"methods that accept a ``context`` object."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"The ``get_admin_context`` method defined in ironic/common/context.py shall be"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_3071fe44","line":169,"in_reply_to":"fa6399be_a456d5cb","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2506,"name":"devdatta-kulkarni","email":"kulkarni.devdatta@gmail.com","username":"devdatta-kulkarni"},"change_message_id":"14da4b125055dec7a221c43c3e8731c5a22d3f15","unresolved":false,"context_lines":[{"line_number":179,"context_line":"**Using the same task id in ironic-python-agent**"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Many asynchronous operations, such as instance deployment, deletion, and"},{"line_number":182,"context_line":"cleaning, are performed"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"In order for actions done in response to interactions from the"},{"line_number":185,"context_line":"ironic-python-agent ramdisk to utilize the same task id, and thus allow a user"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_e4228d51","line":182,"updated":"2016-10-13 19:07:01.000000000","message":"seems like an incomplete sentence.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":179,"context_line":"**Using the same task id in ironic-python-agent**"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Many asynchronous operations, such as instance deployment, deletion, and"},{"line_number":182,"context_line":"cleaning, are performed"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"In order for actions done in response to interactions from the"},{"line_number":185,"context_line":"ironic-python-agent ramdisk to utilize the same task id, and thus allow a user"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_5350440b","line":182,"in_reply_to":"ba5da102_a73674b2","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":179,"context_line":"**Using the same task id in ironic-python-agent**"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Many asynchronous operations, such as instance deployment, deletion, and"},{"line_number":182,"context_line":"cleaning, are performed"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"In order for actions done in response to interactions from the"},{"line_number":185,"context_line":"ironic-python-agent ramdisk to utilize the same task id, and thus allow a user"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_a73674b2","line":182,"in_reply_to":"fa6399be_e4228d51","updated":"2016-10-26 09:32:36.000000000","message":"So it is ... oops :)","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":186,"context_line":"to Note that the ``POST /heartbeat/NODE`` call also returns an HTTP 202 status."},{"line_number":187,"context_line":"However, in order to enable tracking of long-running asynchronous tasks that"},{"line_number":188,"context_line":"also involve the ironic-python-agent ramdisk, this call shall return the"},{"line_number":189,"context_line":"**current** task identifier rather than generating a new one."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_1f49f2d0","line":189,"updated":"2016-10-18 18:19:29.000000000","message":"The two paragraphs above need a bit more word smith-ing.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":186,"context_line":"to Note that the ``POST /heartbeat/NODE`` call also returns an HTTP 202 status."},{"line_number":187,"context_line":"However, in order to enable tracking of long-running asynchronous tasks that"},{"line_number":188,"context_line":"also involve the ironic-python-agent ramdisk, this call shall return the"},{"line_number":189,"context_line":"**current** task identifier rather than generating a new one."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_13f16ccd","line":189,"in_reply_to":"9a629dbe_23a5e803","updated":"2016-11-28 17:13:52.000000000","message":"I\u0027m not sure if I understood that correctly but tried to update this paragraph.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fad9955f65c15bd37114953d965156e5eccd1b96","unresolved":false,"context_lines":[{"line_number":186,"context_line":"to Note that the ``POST /heartbeat/NODE`` call also returns an HTTP 202 status."},{"line_number":187,"context_line":"However, in order to enable tracking of long-running asynchronous tasks that"},{"line_number":188,"context_line":"also involve the ironic-python-agent ramdisk, this call shall return the"},{"line_number":189,"context_line":"**current** task identifier rather than generating a new one."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_27bbbde6","line":189,"in_reply_to":"fa6399be_1f49f2d0","updated":"2016-10-20 11:38:24.000000000","message":"Maybe IPA should report current event (like download, write, etc), otherwise they will be hidden inside prepare_image command.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":186,"context_line":"to Note that the ``POST /heartbeat/NODE`` call also returns an HTTP 202 status."},{"line_number":187,"context_line":"However, in order to enable tracking of long-running asynchronous tasks that"},{"line_number":188,"context_line":"also involve the ironic-python-agent ramdisk, this call shall return the"},{"line_number":189,"context_line":"**current** task identifier rather than generating a new one."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_23a5e803","line":189,"in_reply_to":"fa6399be_27bbbde6","updated":"2016-11-07 16:29:20.000000000","message":"++, maybe adding these intermediate steps as events inside the task, receiving them on heartbeats. OTOH, heartbeats are unauthenticated...","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5c168e9e62e65a52cd425eb005f5502f60e016a6","unresolved":false,"context_lines":[{"line_number":188,"context_line":"also involve the ironic-python-agent ramdisk, this call shall return the"},{"line_number":189,"context_line":"**current** task identifier rather than generating a new one."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Alternatives"},{"line_number":193,"context_line":"------------"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_0a639db2","line":191,"updated":"2016-10-26 15:45:02.000000000","message":"Will task state changes be pushed to the notification message bus? This could help clients (including nova.virt.ironic) implement an event-based interface rather than polling.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":188,"context_line":"also involve the ironic-python-agent ramdisk, this call shall return the"},{"line_number":189,"context_line":"**current** task identifier rather than generating a new one."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Alternatives"},{"line_number":193,"context_line":"------------"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_83f5d484","line":191,"in_reply_to":"ba5da102_0a639db2","updated":"2016-11-07 16:29:20.000000000","message":"In case of provision states, notifications are being worked on separately - http://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/crud-and-state-notifications.html, and I think they will be in-tree faster than tasks, as the spec is approved already :)","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"2347558294119395dfe3e03537f46f0a87039c49","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"Continue forcing users to poll resources and guess whether their request has"},{"line_number":196,"context_line":"been completed, or whether another user (or an automatic internal process) has"},{"line_number":197,"context_line":"overwritten their change."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_0582a352","line":197,"updated":"2016-10-27 07:36:32.000000000","message":"Can we mention celery/mistral/etc here?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"9621fbd9f3e2142dcb84137e0a302176bf730243","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    CREATE TABLE tasks {"},{"line_number":207,"context_line":"        id INT NOT NULL PRIMARY KEY,"},{"line_number":208,"context_line":"        task_uuid CHAR(36) NOT NULL,"},{"line_number":209,"context_line":"        created_at DATETIME,"},{"line_number":210,"context_line":"        updated_at DATETIME,"},{"line_number":211,"context_line":"        user_id CHAR(36),"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_7de22fa1","line":208,"updated":"2016-11-07 14:30:20.000000000","message":"If we want to store tasks output, we would probably want to add a \u0027result\u0027 blob column in this table.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1633c20231ebcfecfc58fa08e233c7892a1f4353","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        user_id CHAR(36),"},{"line_number":212,"context_line":"        tenant_id CHAR(36),"},{"line_number":213,"context_line":"        node_id INT NOT NULL,"},{"line_number":214,"context_line":"        status ENUM(\"started\", \"completed\", \"failed\"),"},{"line_number":215,"context_line":"        UNIQUE INDEX (task_uuid),"},{"line_number":216,"context_line":"        INDEX (status, updated_at, node_id),"},{"line_number":217,"context_line":"        INDEX (node_id),"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_eaf9fe4e","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":54},"updated":"2016-10-27 07:16:11.000000000","message":"I believe this is only possible with full databases.  We looked at using enum for hba/client initiator information and it seemed like we couldn\u0027t actually make this work with sqlachemy in our current form/usage.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fad9955f65c15bd37114953d965156e5eccd1b96","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        FOREIGN KEY (node_id) REFERENCES nodes (id)"},{"line_number":219,"context_line":"    }"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    CREATE TABLE events {"},{"line_number":222,"context_line":"        task_id INT NOT NULL,"},{"line_number":223,"context_line":"        event_uuid CHAR(36) NOT NULL,"},{"line_number":224,"context_line":"        timestamp TIMESTAMP,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_f4bb350d","line":221,"updated":"2016-10-20 11:38:24.000000000","message":"Where is the message (error) field here?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        FOREIGN KEY (node_id) REFERENCES nodes (id)"},{"line_number":219,"context_line":"    }"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    CREATE TABLE events {"},{"line_number":222,"context_line":"        task_id INT NOT NULL,"},{"line_number":223,"context_line":"        event_uuid CHAR(36) NOT NULL,"},{"line_number":224,"context_line":"        timestamp TIMESTAMP,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_8c66324f","line":221,"in_reply_to":"fa6399be_f4bb350d","updated":"2016-11-28 17:13:52.000000000","message":"It will be stored in the detail column.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e8caabffe77556f55a5d3c03f3927d682c85dd39","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        event_uuid CHAR(36) NOT NULL,"},{"line_number":224,"context_line":"        timestamp TIMESTAMP,"},{"line_number":225,"context_line":"        code INT NOT NULL,"},{"line_number":226,"context_line":"        detail VARCHAR(255),"},{"line_number":227,"context_line":"        PRIMARY KEY (task_id, event_uuid),"},{"line_number":228,"context_line":"        FOREIGN KEY (task_id) REFERENCES tasks (id)"},{"line_number":229,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_ed850acf","line":226,"updated":"2016-10-13 23:27:32.000000000","message":"I hope so - and we can control what is written into it from within the code, so, yes.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2506,"name":"devdatta-kulkarni","email":"kulkarni.devdatta@gmail.com","username":"devdatta-kulkarni"},"change_message_id":"14da4b125055dec7a221c43c3e8731c5a22d3f15","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        event_uuid CHAR(36) NOT NULL,"},{"line_number":224,"context_line":"        timestamp TIMESTAMP,"},{"line_number":225,"context_line":"        code INT NOT NULL,"},{"line_number":226,"context_line":"        detail VARCHAR(255),"},{"line_number":227,"context_line":"        PRIMARY KEY (task_id, event_uuid),"},{"line_number":228,"context_line":"        FOREIGN KEY (task_id) REFERENCES tasks (id)"},{"line_number":229,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_64a3ddb2","line":226,"updated":"2016-10-13 19:07:01.000000000","message":"Is 255 sufficient for the detail column?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        event_uuid CHAR(36) NOT NULL,"},{"line_number":224,"context_line":"        timestamp TIMESTAMP,"},{"line_number":225,"context_line":"        code INT NOT NULL,"},{"line_number":226,"context_line":"        detail VARCHAR(255),"},{"line_number":227,"context_line":"        PRIMARY KEY (task_id, event_uuid),"},{"line_number":228,"context_line":"        FOREIGN KEY (task_id) REFERENCES tasks (id)"},{"line_number":229,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_274b442d","line":226,"in_reply_to":"fa6399be_7fcbce1e","updated":"2016-10-26 09:32:36.000000000","message":"There is a cost (storage, performance) for going \u003e 255. Is there a reason?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        event_uuid CHAR(36) NOT NULL,"},{"line_number":224,"context_line":"        timestamp TIMESTAMP,"},{"line_number":225,"context_line":"        code INT NOT NULL,"},{"line_number":226,"context_line":"        detail VARCHAR(255),"},{"line_number":227,"context_line":"        PRIMARY KEY (task_id, event_uuid),"},{"line_number":228,"context_line":"        FOREIGN KEY (task_id) REFERENCES tasks (id)"},{"line_number":229,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_7fcbce1e","line":226,"in_reply_to":"fa6399be_ed850acf","updated":"2016-10-18 18:19:29.000000000","message":"Would it be OK if we don\u0027t cap the length of this string?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"9621fbd9f3e2142dcb84137e0a302176bf730243","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"A new configuration option shall be added, ``task_ttl``, which determines how"},{"line_number":232,"context_line":"long after a task is finished (successfully or otherwise) it is automatically"},{"line_number":233,"context_line":"purged from the time-series table. This option shall default to 24 hours."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"A new periodic task shall be added which prunes old tasks from the tasks table."},{"line_number":236,"context_line":"When a task is pruned, all associated events shall be deleted as well."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_3dcef75a","line":233,"updated":"2016-11-07 14:30:20.000000000","message":"As discussed at the summit https://etherpad.openstack.org/p/ironic-ocata-summit-task-framework we would probably use multiple backends - Redis or other time-series DB, with a fallback on MySQL.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"A new configuration option shall be added, ``task_ttl``, which determines how"},{"line_number":232,"context_line":"long after a task is finished (successfully or otherwise) it is automatically"},{"line_number":233,"context_line":"purged from the time-series table. This option shall default to 24 hours."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"A new periodic task shall be added which prunes old tasks from the tasks table."},{"line_number":236,"context_line":"When a task is pruned, all associated events shall be deleted as well."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_6c7c76ec","line":233,"in_reply_to":"9a629dbe_3dcef75a","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":232,"context_line":"long after a task is finished (successfully or otherwise) it is automatically"},{"line_number":233,"context_line":"purged from the time-series table. This option shall default to 24 hours."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"A new periodic task shall be added which prunes old tasks from the tasks table."},{"line_number":236,"context_line":"When a task is pruned, all associated events shall be deleted as well."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_9f6c220a","line":235,"updated":"2016-10-18 18:19:29.000000000","message":"and we\u0027ll have a new task resource for this periodic task, right?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":232,"context_line":"long after a task is finished (successfully or otherwise) it is automatically"},{"line_number":233,"context_line":"purged from the time-series table. This option shall default to 24 hours."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"A new periodic task shall be added which prunes old tasks from the tasks table."},{"line_number":236,"context_line":"When a task is pruned, all associated events shall be deleted as well."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_a75d94ee","line":235,"in_reply_to":"fa6399be_9f6c220a","updated":"2016-10-26 09:32:36.000000000","message":"No - the /tasks/ resource only exposes things happening on Nodes. This is not node-specific.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":260,"context_line":"which the server generates a task id, and shall implement new commands that:"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"* allow a user to query the status of a Task"},{"line_number":263,"context_line":"* allow a user to retrieve a list of events within a Task"},{"line_number":264,"context_line":"* allow a user to retrieve a list of recent events related to a given Node"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"\"ironic\" CLI"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_7a867c66","line":263,"updated":"2016-10-18 18:19:29.000000000","message":"only the events, all the info related to a particular task? eg user id, tenant id, created at...","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":260,"context_line":"which the server generates a task id, and shall implement new commands that:"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"* allow a user to query the status of a Task"},{"line_number":263,"context_line":"* allow a user to retrieve a list of events within a Task"},{"line_number":264,"context_line":"* allow a user to retrieve a list of recent events related to a given Node"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"\"ironic\" CLI"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_ac0bee7b","line":263,"in_reply_to":"fa6399be_7a867c66","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"* allow a user to query the status of a Task"},{"line_number":263,"context_line":"* allow a user to retrieve a list of events within a Task"},{"line_number":264,"context_line":"* allow a user to retrieve a list of recent events related to a given Node"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"\"ironic\" CLI"},{"line_number":267,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_7a9f5cb4","line":264,"updated":"2016-10-18 18:19:29.000000000","message":"I\u0027m not sure what you mean by this. Is it \u0027retrieve a list of tasks related to a given node\u0027? Or do you really mean \u0027recent events\u0027 of any/all tasks related to a node? And if so, how recent is \u0027recent\u0027?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"* allow a user to query the status of a Task"},{"line_number":263,"context_line":"* allow a user to retrieve a list of events within a Task"},{"line_number":264,"context_line":"* allow a user to retrieve a list of recent events related to a given Node"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"\"ironic\" CLI"},{"line_number":267,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_6c2e36fc","line":264,"in_reply_to":"ba5da102_c7d7e821","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"* allow a user to query the status of a Task"},{"line_number":263,"context_line":"* allow a user to retrieve a list of events within a Task"},{"line_number":264,"context_line":"* allow a user to retrieve a list of recent events related to a given Node"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"\"ironic\" CLI"},{"line_number":267,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_c7d7e821","line":264,"in_reply_to":"fa6399be_7a9f5cb4","updated":"2016-10-26 09:32:36.000000000","message":"I think I meant tasks here.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":262,"context_line":"* allow a user to query the status of a Task"},{"line_number":263,"context_line":"* allow a user to retrieve a list of events within a Task"},{"line_number":264,"context_line":"* allow a user to retrieve a list of recent events related to a given Node"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"\"ironic\" CLI"},{"line_number":267,"context_line":"~~~~~~~~~~~~"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_ba0d7439","line":265,"updated":"2016-10-18 18:19:29.000000000","message":"Also \u0027retrieve a list of all tasks\u0027, \u0027retrieve a list of all tasks for a specified node\u0027,","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"d7564ca53c99dd4039b1e741a5efc3c543870b4c","unresolved":false,"context_lines":[{"line_number":262,"context_line":"* allow a user to query the status of a Task"},{"line_number":263,"context_line":"* allow a user to retrieve a list of events within a Task"},{"line_number":264,"context_line":"* allow a user to retrieve a list of recent events related to a given Node"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"\"ironic\" CLI"},{"line_number":267,"context_line":"~~~~~~~~~~~~"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_0cd062f5","line":265,"in_reply_to":"ba5da102_671a9c19","updated":"2016-11-28 17:13:52.000000000","message":"Done","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":262,"context_line":"* allow a user to query the status of a Task"},{"line_number":263,"context_line":"* allow a user to retrieve a list of events within a Task"},{"line_number":264,"context_line":"* allow a user to retrieve a list of recent events related to a given Node"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"\"ironic\" CLI"},{"line_number":267,"context_line":"~~~~~~~~~~~~"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_671a9c19","line":265,"in_reply_to":"fa6399be_ba0d7439","updated":"2016-10-26 09:32:36.000000000","message":"Ah, yes. How did I miss those.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425ea9ec3dff26eb69576e8612dda21eb104779b","unresolved":false,"context_lines":[{"line_number":271,"context_line":"\"openstack baremetal\" CLI"},{"line_number":272,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"See above."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"RPC API impact"},{"line_number":277,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_5ae8d816","line":274,"updated":"2016-10-18 18:19:29.000000000","message":"I would prefer that the actual commands are spelled out here; it makes it easier to review the code and not to have to bike shed about that stuff later. I think it upsets some folks when I question the commands after it has been coded...","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":271,"context_line":"\"openstack baremetal\" CLI"},{"line_number":272,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"See above."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"RPC API impact"},{"line_number":277,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_27e7c413","line":274,"in_reply_to":"fa6399be_5ae8d816","updated":"2016-10-26 09:32:36.000000000","message":"Fair point. I\u0027ll enumerate them.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":300,"context_line":"None"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"However, there is an impact on the agent driver code, in relation to the"},{"line_number":303,"context_line":"ramdisk. When the ramdisk first makes a POST call to the /lookup resource, the"},{"line_number":304,"context_line":"agent driver should locate the currently-unfinished task and continue using the"},{"line_number":305,"context_line":"same task UUID."},{"line_number":306,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_5eaf0fe3","line":303,"range":{"start_line":303,"start_character":40,"end_line":303,"end_character":44},"updated":"2016-11-07 16:29:20.000000000","message":"I think it\u0027s get now. Or do you intend to support old vendor passthru endpoint too?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c23112aadf16ea5bedf12133e54434f264766137","unresolved":false,"context_lines":[{"line_number":302,"context_line":"However, there is an impact on the agent driver code, in relation to the"},{"line_number":303,"context_line":"ramdisk. When the ramdisk first makes a POST call to the /lookup resource, the"},{"line_number":304,"context_line":"agent driver should locate the currently-unfinished task and continue using the"},{"line_number":305,"context_line":"same task UUID."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"Security impact"},{"line_number":308,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_be174bec","line":305,"updated":"2016-11-07 16:29:20.000000000","message":"Seems like api.restrict_lookup has to be true in case of tasks enabled, otherwise lookup request may come in earlier (just someone doing GET /lookup manually) than deployment starts, and heartbeats will contain wrong task_id.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39998532330e6566cfd5c6918612b78ed543acfd","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"These new tables may grow significantly in size, particularly in a busy"},{"line_number":322,"context_line":"environment. It is still to be determined whether this will pose any problems"},{"line_number":323,"context_line":"for operators."},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"Performance Impact"},{"line_number":326,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_b25dd0ee","line":323,"updated":"2016-10-26 09:57:22.000000000","message":"Which makes me wonder if RDBMS is a good choice for keeping them... Two quite different alternatives come to my mind: Redis and ZooKeeper. I think we should at least consider something other than putting more load on our database.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5c168e9e62e65a52cd425eb005f5502f60e016a6","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"These new tables may grow significantly in size, particularly in a busy"},{"line_number":322,"context_line":"environment. It is still to be determined whether this will pose any problems"},{"line_number":323,"context_line":"for operators."},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"Performance Impact"},{"line_number":326,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_8ac16d83","line":323,"in_reply_to":"ba5da102_b25dd0ee","updated":"2016-10-26 15:45:02.000000000","message":"Is it worth considering a separate TTL configuration value for periodic tasks vs. API-triggered tasks?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fad9955f65c15bd37114953d965156e5eccd1b96","unresolved":false,"context_lines":[{"line_number":340,"context_line":"Developer impact"},{"line_number":341,"context_line":"----------------"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"None"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"Implementation"},{"line_number":346,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_d43d512c","line":343,"updated":"2016-10-20 11:38:24.000000000","message":"I think clear internal API should be created for tasks/events operation.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c155801cb602e10c7de399aceb88f7305b9544db","unresolved":false,"context_lines":[{"line_number":340,"context_line":"Developer impact"},{"line_number":341,"context_line":"----------------"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"None"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"Implementation"},{"line_number":346,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_87eed0ea","line":343,"in_reply_to":"fa6399be_d43d512c","updated":"2016-10-26 09:32:36.000000000","message":"OK","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"9621fbd9f3e2142dcb84137e0a302176bf730243","unresolved":false,"context_lines":[{"line_number":349,"context_line":"-----------"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"Primary assignee:"},{"line_number":352,"context_line":"  TBD"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"Other contributors:"},{"line_number":355,"context_line":"  TBD"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_5a581157","line":352,"updated":"2016-11-07 14:30:20.000000000","message":"Sign me up! I will have time to do this after ironic rolling upgrades.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"9621fbd9f3e2142dcb84137e0a302176bf730243","unresolved":false,"context_lines":[{"line_number":352,"context_line":"  TBD"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"Other contributors:"},{"line_number":355,"context_line":"  TBD"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"Work Items"},{"line_number":358,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_9dcf03b3","line":355,"updated":"2016-11-07 14:30:20.000000000","message":"Also sborkows will help with this or other api-evolution changes before getting to this one.","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":19213,"name":"Szymon Borkowski","email":"szymon.borkowski@intel.com","username":"sborkows"},"change_message_id":"b0a395e5c33545f6ee247f475e3c59f383e31cae","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"Backwards compatibility is retained because the new header and new REST"},{"line_number":401,"context_line":"endpoints shall only be available in a new microversion."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"This change does not include substantive changes to any existing resource."},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a77a97e_cbac2ef0","line":402,"updated":"2016-11-15 15:20:45.000000000","message":"Should we add here also information about database migration and how it affects the upgrade process?","commit_id":"65be2fd856f6bd64de2176acb80bb298724eb40b"},{"author":{"_account_id":19213,"name":"Szymon Borkowski","email":"szymon.borkowski@intel.com","username":"sborkows"},"change_message_id":"80abaf0bdd6aec326a11669af90b9e91e1ff8c61","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    .. NOTE: Add example with more then one event"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"The ``/tasks`` endpoint shall additionally support a ``?node`` query string,"},{"line_number":171,"context_line":"allowing users to retrieve the list of tasks related to a specific Node::"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"   GET /v1/tasks?node\u003d\u003cNODE_IDENT\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a6eadb0_9893b55a","line":170,"range":{"start_line":170,"start_character":53,"end_line":170,"end_character":62},"updated":"2016-12-16 15:03:38.000000000","message":"What about other resources? Is it valuable to query according to e.g. specific Port?","commit_id":"30d64d73061e53391bc8456c0788ed6889ccd5bb"},{"author":{"_account_id":19213,"name":"Szymon Borkowski","email":"szymon.borkowski@intel.com","username":"sborkows"},"change_message_id":"80abaf0bdd6aec326a11669af90b9e91e1ff8c61","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"See above."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    .. NOTE: Enumerate over actual commands here."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"\"openstack baremetal\" CLI"},{"line_number":293,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a6eadb0_83d18a25","line":290,"range":{"start_line":290,"start_character":4,"end_line":290,"end_character":48},"updated":"2016-12-16 15:03:38.000000000","message":"I do not know if I understand this correctly - do you mean adding in this section actual ironicclient commands which will be modified by that change?","commit_id":"30d64d73061e53391bc8456c0788ed6889ccd5bb"},{"author":{"_account_id":19213,"name":"Szymon Borkowski","email":"szymon.borkowski@intel.com","username":"sborkows"},"change_message_id":"80abaf0bdd6aec326a11669af90b9e91e1ff8c61","unresolved":false,"context_lines":[{"line_number":416,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"While this does not strictly have any dependencies on other work, it will"},{"line_number":419,"context_line":"benefit from being done after ETAG headers are added."},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Testing"},{"line_number":422,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a6eadb0_23efd61e","line":419,"updated":"2016-12-16 15:03:38.000000000","message":"nit: I think it will be beneficial to add here or under the References section link to that spec.","commit_id":"30d64d73061e53391bc8456c0788ed6889ccd5bb"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2e18678234c933f4b38fe2f21c61bba12cfcdea9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"it is an error). Timestamps for \"events\" shall be stored with microsecond"},{"line_number":62,"context_line":"precision."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"A \"task\" shall also record the user, domain and tenant who made the request"},{"line_number":65,"context_line":"that created the task. Periodic tasks also have a context object that has an"},{"line_number":66,"context_line":"auth token which should be recorded."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"**Returning task id header to clients**"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_4d0f8e2e","line":66,"range":{"start_line":64,"start_character":0,"end_line":66,"end_character":36},"updated":"2017-01-09 17:12:20.000000000","message":"What gets recorded (if anything) in place of this information in an Ironic standalone deployment??","commit_id":"e9487561e4785f7b4f701de5d3f4d4f2065ffa4c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2e18678234c933f4b38fe2f21c61bba12cfcdea9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  /nodes/NODE/vendor_passthru/METHOD where the driver indicates that the"},{"line_number":81,"context_line":"  response is asynchronous"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Calls which return 202 but are synchronous should start returning HTTP 200:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"- PUT /nodes/NODE/maintenance"},{"line_number":86,"context_line":"- DELETE /nodes/NODE/maintenance"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"**Automated tasks**"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_8d5ed610","line":86,"range":{"start_line":83,"start_character":0,"end_line":86,"end_character":32},"updated":"2017-01-09 17:12:20.000000000","message":"This sounds like a separate bug to me","commit_id":"e9487561e4785f7b4f701de5d3f4d4f2065ffa4c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2e18678234c933f4b38fe2f21c61bba12cfcdea9","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"This resource shall only support the HTTP GET method, shall accept all common"},{"line_number":110,"context_line":"query parameters such as those for pagination and limits, and shall return a"},{"line_number":111,"context_line":"list of currently-running and recently finished tasks::"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    {"},{"line_number":114,"context_line":"      ["}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_2d940a43","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":55},"updated":"2017-01-09 17:12:20.000000000","message":"Is it possible that this will become too big / change too often to be useful if, for example, you have a large deployment with many conductors and all are creating tasks objects for the periodics? I wonder if by default it should filter based on the user_id making the GET request, so they see only the tasks they have started/requested, with the option of viewing the \"firehose\" of tasks if they want?","commit_id":"e9487561e4785f7b4f701de5d3f4d4f2065ffa4c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2e18678234c933f4b38fe2f21c61bba12cfcdea9","unresolved":false,"context_lines":[{"line_number":133,"context_line":"New ``task_ttl`` configuration option (described below) will determine how long"},{"line_number":134,"context_line":"the tasks stay in the database and their status could be read."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    .. NOTE: Do we need to support tasks for Port or Driver?"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Querying a single task resource shall be possible by supplying the ``task_id``"},{"line_number":139,"context_line":"in the query string::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_105bd92f","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":60},"updated":"2017-01-09 17:12:20.000000000","message":"On a related thought, is it possible for a task to operate on more than one node? My initial opinion is no, but I thought I would gauge others opinions on that too, because it\u0027ll relate to the data_structure above.\n\nIt is possible to have driver level vendor passthru functions so I think that we may need to support tasks not tied to a particular node but tied to a driver/interface.\n\nI think it might be good not to rule out support for Ports as a task target because as the networking integration becomes more complex, I expect there to be a need to have async tasks in the future if not already.","commit_id":"e9487561e4785f7b4f701de5d3f4d4f2065ffa4c"},{"author":{"_account_id":19213,"name":"Szymon Borkowski","email":"szymon.borkowski@intel.com","username":"sborkows"},"change_message_id":"dee3fedbbc488aafe3e5e7b7fa58046ec79a16d3","unresolved":false,"context_lines":[{"line_number":133,"context_line":"New ``task_ttl`` configuration option (described below) will determine how long"},{"line_number":134,"context_line":"the tasks stay in the database and their status could be read."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    .. NOTE: Do we need to support tasks for Port or Driver?"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Querying a single task resource shall be possible by supplying the ``task_id``"},{"line_number":139,"context_line":"in the query string::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a430d35_b63fdc85","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":60},"in_reply_to":"ba5201f7_105bd92f","updated":"2017-02-07 14:46:22.000000000","message":"I agree with this generalization, as in a future there will be less chance that we will need to change this structure. We can now assume, that Node, Chassis, Port and Driver will be supported (maybe more?).","commit_id":"e9487561e4785f7b4f701de5d3f4d4f2065ffa4c"},{"author":{"_account_id":19213,"name":"Szymon Borkowski","email":"szymon.borkowski@intel.com","username":"sborkows"},"change_message_id":"dee3fedbbc488aafe3e5e7b7fa58046ec79a16d3","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      \u0027task_type\u0027: \"\u003ctask implementation identifier\u003e\","},{"line_number":150,"context_line":"      \u0027task_uuid\u0027: \"\u003ctask UUID\u003e\","},{"line_number":151,"context_line":"      \u0027node_uuid\u0027: \"\u003cnode UUID\u003e\","},{"line_number":152,"context_line":"      \u0027status\u0027: \"ENUM[started,completed,failed]\","},{"line_number":153,"context_line":"      \u0027created_at\u0027: \"\u003ctimestamp\u003e\","},{"line_number":154,"context_line":"      \u0027last_modified\u0027: \"\u003ctimestamp\u003e\","},{"line_number":155,"context_line":"      \u0027user_id\u0027: \"\u003cuser UUID or none\u003e\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a430d35_bca89bdc","line":152,"range":{"start_line":152,"start_character":40,"end_line":152,"end_character":46},"updated":"2017-02-07 14:46:22.000000000","message":"I wonder if we should add in this level general error code and details if the task fails. If we issue this command without the knowledge about the failure and do not specify the optional fields (list of events) we will need to issue this command again to find out the error cause, which can be obvious with specified error code.","commit_id":"e9487561e4785f7b4f701de5d3f4d4f2065ffa4c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2e18678234c933f4b38fe2f21c61bba12cfcdea9","unresolved":false,"context_lines":[{"line_number":245,"context_line":"long after a task is finished (successfully or otherwise) it is automatically"},{"line_number":246,"context_line":"purged from the time-series table. This option shall default to 24 hours."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"A new periodic task shall be added which prunes old tasks from the tasks table."},{"line_number":249,"context_line":"When a task is pruned, all associated events shall be deleted as well."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"To make sure that data stored for tasks and events doesn\u0027t have a negative"},{"line_number":252,"context_line":"impact on operators who want to make an intensive use of this feature, the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_4b53f66c","line":249,"range":{"start_line":248,"start_character":0,"end_line":249,"end_character":70},"updated":"2017-01-09 17:12:20.000000000","message":"Should this task hold a lock of some kind, periodic tasks are run on every conductor, so you might end up with multiple tasks trying to clean up the tables at the same time.","commit_id":"e9487561e4785f7b4f701de5d3f4d4f2065ffa4c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2e18678234c933f4b38fe2f21c61bba12cfcdea9","unresolved":false,"context_lines":[{"line_number":256,"context_line":"State Machine Impact"},{"line_number":257,"context_line":"--------------------"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"There may be value in adding hooks to the state machine or task manager, to"},{"line_number":260,"context_line":"simplify the creation of tasks and events. TBD."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"REST API impact"},{"line_number":263,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_06f2c306","line":260,"range":{"start_line":259,"start_character":0,"end_line":260,"end_character":47},"updated":"2017-01-09 17:12:20.000000000","message":"It occurred to me reading this that we are going to end up with a \"task manager\" and tasks which are different things which might end up being very confusing.","commit_id":"e9487561e4785f7b4f701de5d3f4d4f2065ffa4c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2e18678234c933f4b38fe2f21c61bba12cfcdea9","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"None"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"However, there is an impact on the agent driver code, in relation to the"},{"line_number":324,"context_line":"ramdisk. When the ramdisk first makes a GET call to the /lookup resource, the"},{"line_number":325,"context_line":"agent driver should locate the currently-unfinished task and continue using the"},{"line_number":326,"context_line":"same task UUID."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"api.restrict_lookup has to be true in case of tasks enabled, otherwise lookup"},{"line_number":329,"context_line":"request may come in earlier (someone doing GET /lookup manually) than"},{"line_number":330,"context_line":"deployment starts, and heartbeats will contain wrong task_id."},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"Security impact"},{"line_number":333,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_9cac3b8e","line":330,"range":{"start_line":323,"start_character":0,"end_line":330,"end_character":61},"updated":"2017-01-09 17:12:20.000000000","message":"I am unsure on the way this is proposed, I think I would prefer that when Ironic requests the ramdisk to perform an action we pass it through the task ID, because in the case of long running ramdisks, the ramdisk might perform multiple tasks per boot.","commit_id":"e9487561e4785f7b4f701de5d3f4d4f2065ffa4c"}]}
