)]}'
{"specs/not-implemented/molten-iron.rst":[{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"2490f8fe01ee611d4f9691bc8375686b91cd4381","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Molten Iron"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1633540"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Running Ironic on a set of Bare Metal machines needs a database and library"},{"line_number":14,"context_line":"to help manage the pool."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_c7b5fa7e","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":46},"updated":"2016-10-18 14:03:14.000000000","message":"Possibly mention this issue in commit message as related-bug.","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"98a57940d6dd7fe5a804adc19291e85652ac1dc2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"an Ironic setup, you are limited to being able to test one patch at a time."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Therefore, we need to maintain a pool of Bare Metal machines that are able"},{"line_number":25,"context_line":"to accept testing a patch."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"We need a system to manage the pool and also to allocate and release"},{"line_number":28,"context_line":"machines in the pool."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_2d932c5c","line":25,"updated":"2016-10-17 13:34:36.000000000","message":"I wouldn\u0027t mind seeing this sentence a little more verbose.  Largely I\u0027m wondering, with-in this context, what does \"able to accept testing a patch\" mean.","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"d709ac30d98fe22fee6ea89652c4b0533436cd32","unresolved":false,"context_lines":[{"line_number":22,"context_line":"an Ironic setup, you are limited to being able to test one patch at a time."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Therefore, we need to maintain a pool of Bare Metal machines that are able"},{"line_number":25,"context_line":"to accept testing a patch."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"We need a system to manage the pool and also to allocate and release"},{"line_number":28,"context_line":"machines in the pool."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_34cd3087","line":25,"in_reply_to":"fa6399be_2d932c5c","updated":"2016-10-17 16:17:24.000000000","message":"Will clear this up. Maybe something like\n\n\"machines that are available for a DSVM to use as a target node during Ironic\u0027s tempest tests.\"\n\nis a better description.","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"98a57940d6dd7fe5a804adc19291e85652ac1dc2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"to accept testing a patch."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"We need a system to manage the pool and also to allocate and release"},{"line_number":28,"context_line":"machines in the pool."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_12612705","line":28,"updated":"2016-10-17 13:34:36.000000000","message":"This sounds like it is a CI pool manager on top of ironic.  It seems like reservations and locking are items in ironic that users have sought in the past.  Are those requirements of this effort?","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"d709ac30d98fe22fee6ea89652c4b0533436cd32","unresolved":false,"context_lines":[{"line_number":25,"context_line":"to accept testing a patch."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"We need a system to manage the pool and also to allocate and release"},{"line_number":28,"context_line":"machines in the pool."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_894a65ab","line":28,"in_reply_to":"fa6399be_12612705","updated":"2016-10-17 16:17:24.000000000","message":"A CI pool manager is an apt description of molteniron. However, the items you mention are not required by molteniron. In fact, I believe they bypass the need for them (well, for a CI environment).","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"98a57940d6dd7fe5a804adc19291e85652ac1dc2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We will create a new client/server tool that uses a database server as the"},{"line_number":35,"context_line":"back end.  This is intended to be a lightweight solution."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_2d116c52","line":35,"updated":"2016-10-17 13:34:36.000000000","message":"So would this server tool in turn leverage Ironic\u0027s API?\n\nI think it would a good idea to be more verbose and describe the proposed change, how it will interact, and how it will integrate to solve the problem description.","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"d709ac30d98fe22fee6ea89652c4b0533436cd32","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We will create a new client/server tool that uses a database server as the"},{"line_number":35,"context_line":"back end.  This is intended to be a lightweight solution."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_89734515","line":35,"in_reply_to":"fa6399be_2d116c52","updated":"2016-10-17 16:17:24.000000000","message":"In short, no. molteniron does not interact with Ironic at all in its current state.\n\nGood advice! We will definitely flesh out this section a bit more.","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"2490f8fe01ee611d4f9691bc8375686b91cd4381","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Alternatives"},{"line_number":39,"context_line":"------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Just use one machine to handle the queue of patches.  However, the Ironic"},{"line_number":42,"context_line":"job is limited to 1 job at a time (with 1 Bare Metal machine).  It is slow"},{"line_number":43,"context_line":"but arguably sufficient."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_07545252","line":41,"range":{"start_line":41,"start_character":52,"end_line":41,"end_character":54},"updated":"2016-10-18 14:03:14.000000000","message":"Excessive white-space here and in several places below.","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"98a57940d6dd7fe5a804adc19291e85652ac1dc2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"There is no security for the MoltenIron REST api.  Any security is handled"},{"line_number":56,"context_line":"by the underlying database application."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_cdc8f0aa","line":56,"updated":"2016-10-17 13:34:36.000000000","message":"Are credentials intended to be stored in the database?  If leveraging ronic\u0027s API. is the intent that it be in NoAuth mode?","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"d709ac30d98fe22fee6ea89652c4b0533436cd32","unresolved":false,"context_lines":[{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"There is no security for the MoltenIron REST api.  Any security is handled"},{"line_number":56,"context_line":"by the underlying database application."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_d4631440","line":56,"in_reply_to":"fa6399be_cdc8f0aa","updated":"2016-10-17 16:17:24.000000000","message":"While molteniron doesn\u0027t directly communicate with Ironic, it does store information about nodes (IPMI credentials for example). It\u0027s probably worth mentioning that in this section as we do not encrypt the information in the database.","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"98a57940d6dd7fe5a804adc19291e85652ac1dc2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Other end user impact"},{"line_number":60,"context_line":"---------------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"There is no other end user interaction with MoltenIron aside from the CLI."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_4d6b0085","line":62,"updated":"2016-10-17 13:34:36.000000000","message":"Other end user impact is likely the wrong place for this question, but what is intended to leverage tooling?","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"d709ac30d98fe22fee6ea89652c4b0533436cd32","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Other end user impact"},{"line_number":60,"context_line":"---------------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"There is no other end user interaction with MoltenIron aside from the CLI."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_0f801546","line":62,"in_reply_to":"fa6399be_4d6b0085","updated":"2016-10-17 16:17:24.000000000","message":"This can probably be addressed most effectively in the Proposed Change section. Will get this to be more clear.\n\nIn short, we need to express the following:\n\n-This tool is intended for Ironic CI testing environments that uses actual baremetal hardware as target nodes rather than the libvirt guests.\n\n-It keeps track of what hardware is currently available for use as a target node in baremetal testing, and allows a DSVM to check-out (and eventually check back in) nodes from a database.\n\n-The tool will be used by the DSVM. Currently, this is done through the pre_test_hook and post_test_hook that the DSVM runs before stacking. In the pre_test_hook, you call \u0027molteniron allocate\u0027 to check out the node and retrieve the information needed to use the node as a target (ie IPMI info and hardware specs). In the post test hook, you call \u0027molteniron release\u0027 to return the node  to the pool.","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"98a57940d6dd7fe5a804adc19291e85652ac1dc2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Assignee(s)"},{"line_number":69,"context_line":"-----------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Who is leading the writing of the code? Or is this a blueprint where you\u0027re"},{"line_number":72,"context_line":"throwing it out there to see who picks it up?"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"If more than one person is working on the implementation, please designate the"},{"line_number":75,"context_line":"primary author and contact."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Primary assignee:"},{"line_number":78,"context_line":"  mark-hamzy"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_f2d2f3cf","line":75,"range":{"start_line":71,"start_character":0,"end_line":75,"end_character":27},"updated":"2016-10-17 13:34:36.000000000","message":"This should have been edited out.","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"98a57940d6dd7fe5a804adc19291e85652ac1dc2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Testing"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Testing is handled by tox running a set of testcases."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_6d8a8465","line":87,"updated":"2016-10-17 13:34:36.000000000","message":"I\u0027m interpreting this as unit tests, does this also include integration test sequences?  It seems like it would be very important for there to be some sort of integrated testing.","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"d709ac30d98fe22fee6ea89652c4b0533436cd32","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Testing"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Testing is handled by tox running a set of testcases."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_69fb5148","line":87,"in_reply_to":"fa6399be_6d8a8465","updated":"2016-10-17 16:17:24.000000000","message":"I believe that only unit tests are currently implemented. Some sort of integration testing would be valuable.","commit_id":"3eeb1cfad19becf7e2966bd6da3c96200335c8fb"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"be9a156de78b058b3f92f9715e53dcbc52559958","unresolved":false,"context_lines":[{"line_number":46,"context_line":"the DSVM runs before stacking. In the pre_test_hook, you call \u0027molteniron"},{"line_number":47,"context_line":"allocate\u0027 to check out the node and retrieve the information needed to use"},{"line_number":48,"context_line":"the node as a target (ie IPMI info and hardware specs). In the"},{"line_number":49,"context_line":"post_test_hook, you call \u0027molteniron release\u0027 to return the node to the pool."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The tool will have the following basic functionality:"},{"line_number":52,"context_line":"    - add a node"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a71b18c_78ad079a","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":14},"updated":"2016-12-06 16:11:42.000000000","message":"in the context of d-g, mentioning post_test_hook is a bit misleading. Devstack-gate\u0027s post_test_hook has always been broken and thus unsuitable for running of molteniron release. Namely, post_test_hook is not guaranteed to run.\n\nMaybe say it more generically, \"You call \u0027molteniron release\u0027 after the test is complete\".","commit_id":"5e68eb14250a21c0b51aef99f0192e2bc3662800"}]}