)]}'
{"specs/approved/ironic-ml2-integration.rst":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e5bc68a73785661defe03e8140261f449a2c3043","unresolved":false,"context_lines":[{"line_number":598,"context_line":"      * JSON schema definition of PortgroupCollection"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"* ``/v1/nodes/(node_ident)/portgroups``"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"  * Retrieve a list of portgroups for node."},{"line_number":604,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_2e24f8ad","line":601,"updated":"2016-11-04 12:30:20.000000000","message":"I\u0027m not sure if it\u0027s worth adding /detail endpoints separately. Also it does not include all the query params, but that seems consistent with the other descriptions in this spec...","commit_id":"bf373972f3b2e800deb0e004e477e6dcb125ed53"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"dc29ac28a8c8fe9785cb2b0d075d54cf3cdef100","unresolved":false,"context_lines":[{"line_number":598,"context_line":"      * JSON schema definition of PortgroupCollection"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"* ``/v1/nodes/(node_ident)/portgroups``"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"  * Retrieve a list of portgroups for node."},{"line_number":604,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_19405507","line":601,"in_reply_to":"ba5da102_2e24f8ad","updated":"2016-11-04 15:26:00.000000000","message":"Added /detail endpoints. All query params will be added in api-ref, not sure we should mention them in the spec.","commit_id":"bf373972f3b2e800deb0e004e477e6dcb125ed53"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"bae3f43c9fee289ad9222bffc4c6e1d25987d569","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"  * Response:"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"      * N/A"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"* ``/v1/nodes/(node_ident)/portgroups/detail``"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_fa5d3349","line":625,"updated":"2016-11-07 02:48:53.000000000","message":"Why response is not applicable? Should it not contain the list of port groups?","commit_id":"e62d4a0987e734477162cfacb5740848430fac26"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cd867c28822c094c3d536af5796a98ebdc2056a5","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"  * Response:"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"      * N/A"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"* ``/v1/nodes/(node_ident)/portgroups/detail``"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_461ac56f","line":625,"in_reply_to":"ba5da102_fa5d3349","updated":"2016-11-07 08:34:15.000000000","message":"Done","commit_id":"e62d4a0987e734477162cfacb5740848430fac26"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"bae3f43c9fee289ad9222bffc4c6e1d25987d569","unresolved":false,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"  * Response:"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"      * N/A"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"* ``/v1/portgroups/(portgroup_ident)/ports``"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_7a304308","line":651,"updated":"2016-11-07 02:48:53.000000000","message":"ditto","commit_id":"e62d4a0987e734477162cfacb5740848430fac26"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cd867c28822c094c3d536af5796a98ebdc2056a5","unresolved":false,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"  * Response:"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"      * N/A"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"* ``/v1/portgroups/(portgroup_ident)/ports``"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_e6403938","line":651,"in_reply_to":"ba5da102_7a304308","updated":"2016-11-07 08:34:15.000000000","message":"Done","commit_id":"e62d4a0987e734477162cfacb5740848430fac26"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"bae3f43c9fee289ad9222bffc4c6e1d25987d569","unresolved":false,"context_lines":[{"line_number":650,"context_line":""},{"line_number":651,"context_line":"      * N/A"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"* ``/v1/portgroups/(portgroup_ident)/ports``"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"  * Retrieve a list of ports for portgroup."},{"line_number":656,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_75fe9406","line":653,"updated":"2016-11-07 02:48:53.000000000","message":"Shouldn\u0027t there be a PUT/POST method to create port groups?","commit_id":"e62d4a0987e734477162cfacb5740848430fac26"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cd867c28822c094c3d536af5796a98ebdc2056a5","unresolved":false,"context_lines":[{"line_number":650,"context_line":""},{"line_number":651,"context_line":"      * N/A"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"* ``/v1/portgroups/(portgroup_ident)/ports``"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"  * Retrieve a list of ports for portgroup."},{"line_number":656,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_667349b5","line":653,"in_reply_to":"ba5da102_75fe9406","updated":"2016-11-07 08:34:15.000000000","message":"Only GET is allowed on ports/portgroups subcontrollers. To update portgroup/ports (ie POST|PUT) methods /portgroups, /ports endpoints should be used.","commit_id":"e62d4a0987e734477162cfacb5740848430fac26"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"bae3f43c9fee289ad9222bffc4c6e1d25987d569","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":"  * Response:"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"      * N/A"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"* ``/v1/portgroups/(portgroup_ident)/ports/detail``"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_fa2453c7","line":677,"updated":"2016-11-07 02:48:53.000000000","message":"ditto","commit_id":"e62d4a0987e734477162cfacb5740848430fac26"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cd867c28822c094c3d536af5796a98ebdc2056a5","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":"  * Response:"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"      * N/A"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"* ``/v1/portgroups/(portgroup_ident)/ports/detail``"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_264b115b","line":677,"in_reply_to":"ba5da102_fa2453c7","updated":"2016-11-07 08:34:15.000000000","message":"Done","commit_id":"e62d4a0987e734477162cfacb5740848430fac26"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"bae3f43c9fee289ad9222bffc4c6e1d25987d569","unresolved":false,"context_lines":[{"line_number":700,"context_line":""},{"line_number":701,"context_line":"  * Response:"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"      * N/A"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"* JSON schema definition of Portgroup (data sample):"},{"line_number":706,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_1a22e7b9","line":703,"updated":"2016-11-07 02:48:53.000000000","message":"ditto","commit_id":"e62d4a0987e734477162cfacb5740848430fac26"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cd867c28822c094c3d536af5796a98ebdc2056a5","unresolved":false,"context_lines":[{"line_number":700,"context_line":""},{"line_number":701,"context_line":"  * Response:"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"      * N/A"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"* JSON schema definition of Portgroup (data sample):"},{"line_number":706,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_465f250e","line":703,"in_reply_to":"ba5da102_1a22e7b9","updated":"2016-11-07 08:34:15.000000000","message":"Done","commit_id":"e62d4a0987e734477162cfacb5740848430fac26"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e5249e087f34b507635baf7ad1f4e00335a6f2e","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"  * Response:"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"      * JSON schema definition of Portgroup."},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"* ``/v1/nodes/(node_ident)/portgroups/detail``"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_75e23105","line":625,"range":{"start_line":625,"start_character":34,"end_line":625,"end_character":43},"updated":"2016-11-07 17:02:51.000000000","message":"PortgroupCollection","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8e455f75a64928998fc387b5b59a52932df74053","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"  * Response:"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"      * JSON schema definition of Portgroup."},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"* ``/v1/nodes/(node_ident)/portgroups/detail``"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_6bc23b35","line":625,"range":{"start_line":625,"start_character":34,"end_line":625,"end_character":43},"in_reply_to":"9a629dbe_75e23105","updated":"2016-11-08 09:52:31.000000000","message":"Done","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e5249e087f34b507635baf7ad1f4e00335a6f2e","unresolved":false,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"  * Response:"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"      * JSON schema definition of Portgroup."},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"* ``/v1/portgroups/(portgroup_ident)/ports``"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_b5920956","line":651,"range":{"start_line":651,"start_character":34,"end_line":651,"end_character":43},"updated":"2016-11-07 17:02:51.000000000","message":"PortgroupCollection, also it will contain full representations of portgroups.","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8e455f75a64928998fc387b5b59a52932df74053","unresolved":false,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"  * Response:"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"      * JSON schema definition of Portgroup."},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"* ``/v1/portgroups/(portgroup_ident)/ports``"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_ffdd2171","line":651,"range":{"start_line":651,"start_character":34,"end_line":651,"end_character":43},"in_reply_to":"9a629dbe_b5920956","updated":"2016-11-08 09:52:31.000000000","message":"Done","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e5249e087f34b507635baf7ad1f4e00335a6f2e","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":"  * Response:"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"      * JSON schema definition of Portgroup."},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"* ``/v1/portgroups/(portgroup_ident)/ports/detail``"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_75b951e9","line":677,"range":{"start_line":677,"start_character":34,"end_line":677,"end_character":43},"updated":"2016-11-07 17:02:51.000000000","message":"PortCollection","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8e455f75a64928998fc387b5b59a52932df74053","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":"  * Response:"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"      * JSON schema definition of Portgroup."},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"* ``/v1/portgroups/(portgroup_ident)/ports/detail``"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_eb03ab71","line":677,"range":{"start_line":677,"start_character":34,"end_line":677,"end_character":43},"in_reply_to":"9a629dbe_75b951e9","updated":"2016-11-08 09:52:31.000000000","message":"Done","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e5249e087f34b507635baf7ad1f4e00335a6f2e","unresolved":false,"context_lines":[{"line_number":700,"context_line":""},{"line_number":701,"context_line":"  * Response:"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"      * JSON schema definition of Portgroup."},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"* JSON schema definition of Portgroup (data sample):"},{"line_number":706,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_15a1f5a9","line":703,"range":{"start_line":703,"start_character":34,"end_line":703,"end_character":43},"updated":"2016-11-07 17:02:51.000000000","message":"PortCollection","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8e455f75a64928998fc387b5b59a52932df74053","unresolved":false,"context_lines":[{"line_number":700,"context_line":""},{"line_number":701,"context_line":"  * Response:"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"      * JSON schema definition of Portgroup."},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"* JSON schema definition of Portgroup (data sample):"},{"line_number":706,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_0bf9bf80","line":703,"range":{"start_line":703,"start_character":34,"end_line":703,"end_character":43},"in_reply_to":"9a629dbe_15a1f5a9","updated":"2016-11-08 09:52:31.000000000","message":"Done","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e5249e087f34b507635baf7ad1f4e00335a6f2e","unresolved":false,"context_lines":[{"line_number":724,"context_line":"        \"rel\": \"bookmark\""},{"line_number":725,"context_line":"      }"},{"line_number":726,"context_line":"    ],"},{"line_number":727,"context_line":"    \"node_uuid\": \"e7a6f1e2-7176-4fe8-b8e9-ed71c77d74dd\","},{"line_number":728,"context_line":"    \"updated_at\": \"2015-05-15T09:04:12.011844+00:00\","},{"line_number":729,"context_line":"    \"uuid\": \"6eb02b44-18a3-4659-8c0b-8d2802581ae4\","},{"line_number":730,"context_line":"    \"name\": \"node1_portgroup1\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_f59c816b","line":727,"updated":"2016-11-07 17:02:51.000000000","message":"internal_info missing here :(","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8e455f75a64928998fc387b5b59a52932df74053","unresolved":false,"context_lines":[{"line_number":724,"context_line":"        \"rel\": \"bookmark\""},{"line_number":725,"context_line":"      }"},{"line_number":726,"context_line":"    ],"},{"line_number":727,"context_line":"    \"node_uuid\": \"e7a6f1e2-7176-4fe8-b8e9-ed71c77d74dd\","},{"line_number":728,"context_line":"    \"updated_at\": \"2015-05-15T09:04:12.011844+00:00\","},{"line_number":729,"context_line":"    \"uuid\": \"6eb02b44-18a3-4659-8c0b-8d2802581ae4\","},{"line_number":730,"context_line":"    \"name\": \"node1_portgroup1\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_6b4cfbc7","line":727,"in_reply_to":"9a629dbe_f59c816b","updated":"2016-11-08 09:52:31.000000000","message":"Done\nand standalone_ports_supported","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e5249e087f34b507635baf7ad1f4e00335a6f2e","unresolved":false,"context_lines":[{"line_number":735,"context_line":"::"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"  {"},{"line_number":738,"context_line":"    \"portgroups\": ["},{"line_number":739,"context_line":"        {"},{"line_number":740,"context_line":"            \"address\": \"fe:54:00:77:07:d9\","},{"line_number":741,"context_line":"            \"links\": ["}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_95a3459e","line":738,"updated":"2016-11-07 17:02:51.000000000","message":"In case of portgroups/detail it contains more fields, same for ports :( Not sure such level of detail is needed tho.","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8e455f75a64928998fc387b5b59a52932df74053","unresolved":false,"context_lines":[{"line_number":735,"context_line":"::"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"  {"},{"line_number":738,"context_line":"    \"portgroups\": ["},{"line_number":739,"context_line":"        {"},{"line_number":740,"context_line":"            \"address\": \"fe:54:00:77:07:d9\","},{"line_number":741,"context_line":"            \"links\": ["}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_bf264966","line":738,"in_reply_to":"9a629dbe_6117d351","updated":"2016-11-08 09:52:31.000000000","message":"The fresh information about API object will be available at api-ref documentation. It is impossible to keep up to date API onjects in the spec.\nIndeed several new fields were added during neutron integration like internal_info/standalone_ports_supported. I\u0027ve added mention about the to this spec.\n\nhttp://docs-draft.openstack.org/34/393834/4/check/gate-ironic-api-ref/b9f8bd5//api-ref/build/html/#portgroups-portgroups","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7e5f3e69155e1dc8c8bada9512f70bf9e2919fee","unresolved":false,"context_lines":[{"line_number":735,"context_line":"::"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"  {"},{"line_number":738,"context_line":"    \"portgroups\": ["},{"line_number":739,"context_line":"        {"},{"line_number":740,"context_line":"            \"address\": \"fe:54:00:77:07:d9\","},{"line_number":741,"context_line":"            \"links\": ["}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_6117d351","line":738,"in_reply_to":"9a629dbe_95a3459e","updated":"2016-11-07 18:43:03.000000000","message":"I\u0027m fine if this is updated, and I\u0027m fine if it isn\u0027t updated. I think the goal of this patch was to add the missing API. Someone might want to revisit this spec *after* the feature has landed, to fix any glaring mistakes.","commit_id":"a5e03e9ae2a65f17099f5ba9f0ee2660ca2fd948"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"abbdab7baa3b3d68472308adbcab9fad10a35d12","unresolved":false,"context_lines":[{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"        * ironic port-create -a \u003caddress\u003e -n \u003cnode\u003e [-e \u003ckey\u003dvalue\u003e]"},{"line_number":1033,"context_line":"          [--local_link_connection \u003clocal_link_connection\u003e]"},{"line_number":1034,"context_line":"          [--portgroup_uuid \u003cportgroup_uuid\u003e] [--pxe_enabled \u003cpxe_enabled\u003e]"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"        * ironic port-update port_uuid replace portgroup_uuid\u003d\u003cportgroup_uuid\u003e"},{"line_number":1037,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_e67c9e74","line":1034,"updated":"2016-11-08 20:27:47.000000000","message":"oh. sigh. if you feel like it although i probably wouldn\u0027t, i think the options are all hyphenated, not underscores, eg s/portgroup_uuid/portgroup-uuid/\n\nAs long as we code it properly...","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7337c3171b4a81d89d23ae7c58300e5bfea9c86c","unresolved":false,"context_lines":[{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"        * ironic port-create -a \u003caddress\u003e -n \u003cnode\u003e [-e \u003ckey\u003dvalue\u003e]"},{"line_number":1033,"context_line":"          [--local_link_connection \u003clocal_link_connection\u003e]"},{"line_number":1034,"context_line":"          [--portgroup_uuid \u003cportgroup_uuid\u003e] [--pxe_enabled \u003cpxe_enabled\u003e]"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"        * ironic port-update port_uuid replace portgroup_uuid\u003d\u003cportgroup_uuid\u003e"},{"line_number":1037,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_98d7a822","line":1034,"in_reply_to":"9a629dbe_e67c9e74","updated":"2016-11-09 09:22:54.000000000","message":"It was copied from original spec, in ironicclient we using hyphenated https://github.com/openstack/python-ironicclient/blob/master/ironicclient/v1/port_shell.py#L147","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"abbdab7baa3b3d68472308adbcab9fad10a35d12","unresolved":false,"context_lines":[{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"        * openstack baremetal port set [--portgroup-uuid \u003cportgroup_uuid\u003e]"},{"line_number":1047,"context_line":"          \u003cport\u003e"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"  * For portgroups, the CLI would support the following new methods:"},{"line_number":1051,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_2614d642","line":1048,"updated":"2016-11-08 20:27:47.000000000","message":"are we also going to modify ironic port-list \u0026 osc port list to filter on --portgroup-uuid?","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7337c3171b4a81d89d23ae7c58300e5bfea9c86c","unresolved":false,"context_lines":[{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"        * openstack baremetal port set [--portgroup-uuid \u003cportgroup_uuid\u003e]"},{"line_number":1047,"context_line":"          \u003cport\u003e"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"  * For portgroups, the CLI would support the following new methods:"},{"line_number":1051,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_58c1902d","line":1048,"in_reply_to":"9a629dbe_2614d642","updated":"2016-11-09 09:22:54.000000000","message":"I think we should!","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f4ddbb410e5d040824b8e660e0eb87b841c8b32e","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"          [--limit \u003climit\u003e]  [--marker \u003cportgroup_uuid] [--sort-key \u003cfield\u003e]"},{"line_number":1062,"context_line":"          [--sort-dir \u003cdirection\u003e]"},{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"        * ironic portgroup-show [--address \u003caddress\u003e] \u003cid\u003e"},{"line_number":1065,"context_line":""},{"line_number":1066,"context_line":"            * \u003cid\u003e is the UUID of the portgroup (or MAC address if --address is"},{"line_number":1067,"context_line":"              specified)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_85c4bc5f","line":1064,"range":{"start_line":1064,"start_character":42,"end_line":1064,"end_character":52},"updated":"2016-11-08 18:44:27.000000000","message":"not needed, as mentioned below, \u003cid\u003e can be an address if --address is specified.","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7337c3171b4a81d89d23ae7c58300e5bfea9c86c","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"          [--limit \u003climit\u003e]  [--marker \u003cportgroup_uuid] [--sort-key \u003cfield\u003e]"},{"line_number":1062,"context_line":"          [--sort-dir \u003cdirection\u003e]"},{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"        * ironic portgroup-show [--address \u003caddress\u003e] \u003cid\u003e"},{"line_number":1065,"context_line":""},{"line_number":1066,"context_line":"            * \u003cid\u003e is the UUID of the portgroup (or MAC address if --address is"},{"line_number":1067,"context_line":"              specified)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_98088893","line":1064,"range":{"start_line":1064,"start_character":42,"end_line":1064,"end_character":52},"in_reply_to":"9a629dbe_85c4bc5f","updated":"2016-11-09 09:22:54.000000000","message":"Done","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"abbdab7baa3b3d68472308adbcab9fad10a35d12","unresolved":false,"context_lines":[{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"    \"openstack baremetal\" CLI:"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"        * openstack baremeta portgroup create --node \u003cuuid\u003e [--name NAME]"},{"line_number":1080,"context_line":"          [--extra \u003ckey\u003dvalue\u003e]"},{"line_number":1081,"context_line":"          [--standalone-ports-supported]"},{"line_number":1082,"context_line":"          \u003caddress\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_ab798ffe","line":1079,"updated":"2016-11-08 20:27:47.000000000","message":"nit s/baremeta/baremetal/","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7337c3171b4a81d89d23ae7c58300e5bfea9c86c","unresolved":false,"context_lines":[{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"    \"openstack baremetal\" CLI:"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"        * openstack baremeta portgroup create --node \u003cuuid\u003e [--name NAME]"},{"line_number":1080,"context_line":"          [--extra \u003ckey\u003dvalue\u003e]"},{"line_number":1081,"context_line":"          [--standalone-ports-supported]"},{"line_number":1082,"context_line":"          \u003caddress\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_58efd0af","line":1079,"in_reply_to":"9a629dbe_ab798ffe","updated":"2016-11-09 09:22:54.000000000","message":"Done","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"abbdab7baa3b3d68472308adbcab9fad10a35d12","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"          [--standalone-ports-supported]"},{"line_number":1082,"context_line":"          \u003caddress\u003e"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"        * openstack baremetal portgroup delete \u003cportgroup\u003e"},{"line_number":1085,"context_line":""},{"line_number":1086,"context_line":"        * openstack baremetal portgroup list [--marker \u003cportgroup\u003e]"},{"line_number":1087,"context_line":"          [--sort \u003ckey\u003e[:\u003cdirection\u003e]]"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_4b50f35e","line":1084,"updated":"2016-11-08 20:27:47.000000000","message":"if we are to be consistent with ports, you should be able to specify one or more portgroups to delete.","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7337c3171b4a81d89d23ae7c58300e5bfea9c86c","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"          [--standalone-ports-supported]"},{"line_number":1082,"context_line":"          \u003caddress\u003e"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"        * openstack baremetal portgroup delete \u003cportgroup\u003e"},{"line_number":1085,"context_line":""},{"line_number":1086,"context_line":"        * openstack baremetal portgroup list [--marker \u003cportgroup\u003e]"},{"line_number":1087,"context_line":"          [--sort \u003ckey\u003e[:\u003cdirection\u003e]]"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_7813b4b8","line":1084,"in_reply_to":"9a629dbe_4b50f35e","updated":"2016-11-09 09:22:54.000000000","message":"Done","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"abbdab7baa3b3d68472308adbcab9fad10a35d12","unresolved":false,"context_lines":[{"line_number":1085,"context_line":""},{"line_number":1086,"context_line":"        * openstack baremetal portgroup list [--marker \u003cportgroup\u003e]"},{"line_number":1087,"context_line":"          [--sort \u003ckey\u003e[:\u003cdirection\u003e]]"},{"line_number":1088,"context_line":"          [--long | --fields \u003cfield\u003e [\u003cfield\u003e ...]]"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"        * openstack baremetal portgroup show [--address]"},{"line_number":1091,"context_line":"          [--fields \u003cfield\u003e [\u003cfield\u003e ...]]"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_2bb1ff8f","line":1088,"updated":"2016-11-08 20:27:47.000000000","message":"are we also going to allow --address and --node (to filter on those, similar to ports)\n\nalso --limit (max num of portgroups to return per request blah blah)","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7337c3171b4a81d89d23ae7c58300e5bfea9c86c","unresolved":false,"context_lines":[{"line_number":1085,"context_line":""},{"line_number":1086,"context_line":"        * openstack baremetal portgroup list [--marker \u003cportgroup\u003e]"},{"line_number":1087,"context_line":"          [--sort \u003ckey\u003e[:\u003cdirection\u003e]]"},{"line_number":1088,"context_line":"          [--long | --fields \u003cfield\u003e [\u003cfield\u003e ...]]"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"        * openstack baremetal portgroup show [--address]"},{"line_number":1091,"context_line":"          [--fields \u003cfield\u003e [\u003cfield\u003e ...]]"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_38fe9c37","line":1088,"in_reply_to":"9a629dbe_2bb1ff8f","updated":"2016-11-09 09:22:54.000000000","message":"Added filter on --address and --node.\n--limit/max num//... are default opts, might be not mention them here?","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f4ddbb410e5d040824b8e660e0eb87b841c8b32e","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"          [--sort \u003ckey\u003e[:\u003cdirection\u003e]]"},{"line_number":1088,"context_line":"          [--long | --fields \u003cfield\u003e [\u003cfield\u003e ...]]"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"        * openstack baremetal portgroup show [--address]"},{"line_number":1091,"context_line":"          [--fields \u003cfield\u003e [\u003cfield\u003e ...]]"},{"line_number":1092,"context_line":"          \u003cportgroup\u003e"},{"line_number":1093,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_e582d8ff","line":1090,"updated":"2016-11-08 18:44:27.000000000","message":"What about this one, do we support doing show, set and unset by address too? If so, how do we set/unset address itself?","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7337c3171b4a81d89d23ae7c58300e5bfea9c86c","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"          [--sort \u003ckey\u003e[:\u003cdirection\u003e]]"},{"line_number":1088,"context_line":"          [--long | --fields \u003cfield\u003e [\u003cfield\u003e ...]]"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"        * openstack baremetal portgroup show [--address]"},{"line_number":1091,"context_line":"          [--fields \u003cfield\u003e [\u003cfield\u003e ...]]"},{"line_number":1092,"context_line":"          \u003cportgroup\u003e"},{"line_number":1093,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_5803500f","line":1090,"in_reply_to":"9a629dbe_664a4ec7","updated":"2016-11-09 09:22:54.000000000","message":"We don\u0027t using mac address as object identifier on API endpoints even if it is unique. I agree with Ruby, we should modify objects by identifiers that we using in API, ie uuid.\n\n/ports/\u003cUUID\u003e\n/nodes/\u003cUUID_OR_NAME\u003e","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"abbdab7baa3b3d68472308adbcab9fad10a35d12","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"          [--sort \u003ckey\u003e[:\u003cdirection\u003e]]"},{"line_number":1088,"context_line":"          [--long | --fields \u003cfield\u003e [\u003cfield\u003e ...]]"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"        * openstack baremetal portgroup show [--address]"},{"line_number":1091,"context_line":"          [--fields \u003cfield\u003e [\u003cfield\u003e ...]]"},{"line_number":1092,"context_line":"          \u003cportgroup\u003e"},{"line_number":1093,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_664a4ec7","line":1090,"in_reply_to":"9a629dbe_e582d8ff","updated":"2016-11-08 20:27:47.000000000","message":"i think we should be consistent with port. (Also cuz that makes it easier; I don\u0027t have to think too much about it.) So portgroup show --address, but portgroup set, unset requires portgroup uuid.","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"abbdab7baa3b3d68472308adbcab9fad10a35d12","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"        * openstack baremetal portgroup set [--address] [--name NAME]"},{"line_number":1095,"context_line":"          [--fields \u003cfield\u003e [\u003cfield\u003e ...]]"},{"line_number":1096,"context_line":"          [--standalone-ports-supported]"},{"line_number":1097,"context_line":"          \u003cportgroup\u003e"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        * openstack baremetal portgroup unset [--name] [--extra \u003ckey\u003e]"},{"line_number":1100,"context_line":"          [--standalone-ports-supported]"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_66fdee39","line":1097,"updated":"2016-11-08 20:27:47.000000000","message":"just looking at osc port set: it allows changing the node uuid. Do we also allow that for portgroups?\n\nalso --extra","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7337c3171b4a81d89d23ae7c58300e5bfea9c86c","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"        * openstack baremetal portgroup set [--address] [--name NAME]"},{"line_number":1095,"context_line":"          [--fields \u003cfield\u003e [\u003cfield\u003e ...]]"},{"line_number":1096,"context_line":"          [--standalone-ports-supported]"},{"line_number":1097,"context_line":"          \u003cportgroup\u003e"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        * openstack baremetal portgroup unset [--name] [--extra \u003ckey\u003e]"},{"line_number":1100,"context_line":"          [--standalone-ports-supported]"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_531a536f","line":1097,"in_reply_to":"9a629dbe_66fdee39","updated":"2016-11-09 09:22:54.000000000","message":"Done","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"abbdab7baa3b3d68472308adbcab9fad10a35d12","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"          \u003cportgroup\u003e"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        * openstack baremetal portgroup unset [--name] [--extra \u003ckey\u003e]"},{"line_number":1100,"context_line":"          [--standalone-ports-supported]"},{"line_number":1101,"context_line":"          \u003cportgroup\u003e"},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_7a1c9e13","line":1100,"updated":"2016-11-08 20:27:47.000000000","message":"since standalone-ports-supported is a boolean, it doesn\u0027t seem to fit properly in set \u0026 unset. It seems more in line with set --standalone-ports | --no-standalone-ports or --support-standalone-ports | -- unsupport-standalone-ports.\n\nSee eg osc port set|unset wrt enable/disable [1] or image set|unset wrt protected/unprotected, activate/deactivate [2]\n\n[1] http://docs.openstack.org/developer/python-openstackclient/command-objects/port.html#port-set\n\n[2] http://docs.openstack.org/developer/python-openstackclient/command-objects/image.html#image-set","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7337c3171b4a81d89d23ae7c58300e5bfea9c86c","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"          \u003cportgroup\u003e"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        * openstack baremetal portgroup unset [--name] [--extra \u003ckey\u003e]"},{"line_number":1100,"context_line":"          [--standalone-ports-supported]"},{"line_number":1101,"context_line":"          \u003cportgroup\u003e"},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_3305dfbb","line":1100,"in_reply_to":"9a629dbe_7a1c9e13","updated":"2016-11-09 09:22:54.000000000","message":"Good suggestion, I like [--support-standalone-ports | -- unsupport-standalone-ports] we should have the same in openstack baremetal create command.","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"abbdab7baa3b3d68472308adbcab9fad10a35d12","unresolved":false,"context_lines":[{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    * To add ports to a portgroup, the portgroup should first"},{"line_number":1105,"context_line":"      be created and then port_update called."},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"The python-ironicclient would also need the Port detailed resource extended"},{"line_number":1108,"context_line":"to include the new port attributes."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_fad6ee25","line":1105,"updated":"2016-11-08 20:27:47.000000000","message":"or port create called.","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7337c3171b4a81d89d23ae7c58300e5bfea9c86c","unresolved":false,"context_lines":[{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    * To add ports to a portgroup, the portgroup should first"},{"line_number":1105,"context_line":"      be created and then port_update called."},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"The python-ironicclient would also need the Port detailed resource extended"},{"line_number":1108,"context_line":"to include the new port attributes."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_93306ba0","line":1105,"in_reply_to":"9a629dbe_fad6ee25","updated":"2016-11-09 09:22:54.000000000","message":"Done","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"abbdab7baa3b3d68472308adbcab9fad10a35d12","unresolved":false,"context_lines":[{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    * To add ports to a portgroup, the portgroup should first"},{"line_number":1105,"context_line":"      be created and then port_update called."},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"The python-ironicclient would also need the Port detailed resource extended"},{"line_number":1108,"context_line":"to include the new port attributes."},{"line_number":1109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_fab98ecc","line":1106,"updated":"2016-11-08 20:27:47.000000000","message":"could we add a note here that even though the ironic CLI includes \u0027ironic node-port-list\u0027, we are NOT going to provide a corresponding \u0027ironic node-portgroup-list\u0027. Rather, the list of portgroups of a node will be available via ironic portgroup-list --node.\n\nThis is an inconsistency but I don\u0027t like ironic node-port-list. If others disagree, that is fine -- we should just document what we decide :)","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7337c3171b4a81d89d23ae7c58300e5bfea9c86c","unresolved":false,"context_lines":[{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    * To add ports to a portgroup, the portgroup should first"},{"line_number":1105,"context_line":"      be created and then port_update called."},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"The python-ironicclient would also need the Port detailed resource extended"},{"line_number":1108,"context_line":"to include the new port attributes."},{"line_number":1109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a629dbe_13d8dbee","line":1106,"in_reply_to":"9a629dbe_fab98ecc","updated":"2016-11-09 09:22:54.000000000","message":"We are going far away from ironic CLI, I\u0027m not sure that we should even add a new functionality there.\nAdded a not about not provide \u0027ironic node-portgroup-list\u0027","commit_id":"de2e263e476e98abd229e7719b314480acba3b9a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eed3e1c91d3d732c39cd9860aec80513285b44b7","unresolved":false,"context_lines":[{"line_number":159,"context_line":"+------------------------+--------------------------------------------------+"},{"line_number":160,"context_line":"| host_id                | This should be set to the Ironic node uuid.      |"},{"line_number":161,"context_line":"+------------------------+--------------------------------------------------+"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"A JSON example to describe the structure is:"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"{\"port\":"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_124b225a","line":162,"updated":"2016-11-10 19:04:20.000000000","message":"We really need to fix the display of this at some point.  Just noticed it in the rendered output :(","commit_id":"36edf94c5dac1b27ab48c54e9399b07889b6ec62"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eed3e1c91d3d732c39cd9860aec80513285b44b7","unresolved":false,"context_lines":[{"line_number":614,"context_line":""},{"line_number":615,"context_line":"  * Method type GET."},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"  * Normal http response code will be 200."},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"  * Expected error http response code(s):"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_12e7a240","line":617,"range":{"start_line":617,"start_character":2,"end_line":617,"end_character":42},"updated":"2016-11-10 19:04:20.000000000","message":"nit: I\u0027m not exactly a fan of future tense in this context, but *shrug* :)","commit_id":"36edf94c5dac1b27ab48c54e9399b07889b6ec62"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"419a45ebb358c83648fdbb2f53710d37af74d882","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"        * openstack baremetal portgroup set [--address] [--name NAME]"},{"line_number":1108,"context_line":"          [--node \u003cuuid\u003e] [--extra \u003ckey\u003dvalue\u003e]"},{"line_number":1109,"context_line":"          [--support-standalone-ports | --unsupport-standalone-ports]"},{"line_number":1110,"context_line":"          [--fields \u003cfield\u003e [\u003cfield\u003e ...]]"},{"line_number":1111,"context_line":"          \u003cportgroup\u003e"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"        * openstack baremetal portgroup unset [--name] [--extra \u003ckey\u003e]"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_d57a74bc","line":1110,"updated":"2016-11-10 19:49:43.000000000","message":"looks like a copy/paste because I don\u0027t think we need it here. You\u0027ll find out when coding :)","commit_id":"36edf94c5dac1b27ab48c54e9399b07889b6ec62"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eed3e1c91d3d732c39cd9860aec80513285b44b7","unresolved":false,"context_lines":[{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    * To add ports to a portgroup, the portgroup should first"},{"line_number":1118,"context_line":"      be created and then port_update or port create called."},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"The python-ironicclient would also need the Port detailed resource extended"},{"line_number":1121,"context_line":"to include the new port attributes."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_f21eae0a","line":1118,"updated":"2016-11-10 19:04:20.000000000","message":"This seems like something that wouldn\u0027t be mentioned in a specification, but in full documentation.","commit_id":"36edf94c5dac1b27ab48c54e9399b07889b6ec62"}]}