)]}'
{"specs/approved/Intel-Node-Manager-sensor-collection.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Add support for collecting sensor data from Intel Node Manager"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad bug with ``rfe`` tag:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://bugs.launchpad.net/ironic/+bug/1645759"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_33e8d57c","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":55},"updated":"2016-12-30 14:38:58.000000000","message":"This instruction can be removed.","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"35e804df6acda65e5123a86e0c9f2bbda595797b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Add support for collecting sensor data from Intel Node Manager"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad bug with ``rfe`` tag:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://bugs.launchpad.net/ironic/+bug/1645759"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_9396854a","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":55},"in_reply_to":"ba5201f7_33e8d57c","updated":"2017-01-04 18:06:44.000000000","message":"Done","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://bugs.launchpad.net/ironic/+bug/1645759"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Ironic should be able to collect Intel Node Manager CUPS data."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"By collecting sensor data from Intel Node Manager enabled systems, operators"},{"line_number":18,"context_line":"will be able to more closely monitor the health of their bare metal fleets."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_93d8a1f1","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":62},"updated":"2016-12-30 14:38:58.000000000","message":"nit: This sentence seems redundant.","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"35e804df6acda65e5123a86e0c9f2bbda595797b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://bugs.launchpad.net/ironic/+bug/1645759"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Ironic should be able to collect Intel Node Manager CUPS data."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"By collecting sensor data from Intel Node Manager enabled systems, operators"},{"line_number":18,"context_line":"will be able to more closely monitor the health of their bare metal fleets."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_d3a00da2","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":62},"in_reply_to":"ba5201f7_93d8a1f1","updated":"2017-01-04 18:06:44.000000000","message":"Done","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* volumetric airflow"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* CUPS (compute usage per second) utilization"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_d3f9494f","line":32,"updated":"2016-12-30 14:38:58.000000000","message":"micro-nit: Might be useful to include a link or reference to this specifically.... that or include a link to the Intel spec in the paragraph above.","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"35e804df6acda65e5123a86e0c9f2bbda595797b","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* volumetric airflow"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* CUPS (compute usage per second) utilization"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_f3f8b14b","line":32,"in_reply_to":"ba5201f7_d3f9494f","updated":"2017-01-04 18:06:44.000000000","message":"Done","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Currently ironic is not able to collect extended sensor data from systems that"},{"line_number":39,"context_line":"have Intel Node Manager. Collecting the extended Node Manager sensor data can"},{"line_number":40,"context_line":"aid in better data center resource planning, for things such as power, cooling,"},{"line_number":41,"context_line":"and overall system capacity."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_b393e5f9","line":39,"range":{"start_line":39,"start_character":5,"end_line":39,"end_character":23},"updated":"2016-12-30 14:38:58.000000000","message":"Reading this, the natural question that comes to mind is \"What systems have Intel Node Manger?\" It might help the reader context to address that to some degree.","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"35e804df6acda65e5123a86e0c9f2bbda595797b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Currently ironic is not able to collect extended sensor data from systems that"},{"line_number":39,"context_line":"have Intel Node Manager. Collecting the extended Node Manager sensor data can"},{"line_number":40,"context_line":"aid in better data center resource planning, for things such as power, cooling,"},{"line_number":41,"context_line":"and overall system capacity."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_56108b01","line":39,"range":{"start_line":39,"start_character":5,"end_line":39,"end_character":23},"in_reply_to":"ba5201f7_b393e5f9","updated":"2017-01-04 18:06:44.000000000","message":"Done","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Currently ironic is not able to collect extended sensor data from systems that"},{"line_number":39,"context_line":"have Intel Node Manager. Collecting the extended Node Manager sensor data can"},{"line_number":40,"context_line":"aid in better data center resource planning, for things such as power, cooling,"},{"line_number":41,"context_line":"and overall system capacity."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_33b6158b","line":40,"range":{"start_line":40,"start_character":45,"end_line":40,"end_character":48},"updated":"2016-12-30 14:38:58.000000000","message":"nit: s/, for/\\ by providing insight into/","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"35e804df6acda65e5123a86e0c9f2bbda595797b","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Currently ironic is not able to collect extended sensor data from systems that"},{"line_number":39,"context_line":"have Intel Node Manager. Collecting the extended Node Manager sensor data can"},{"line_number":40,"context_line":"aid in better data center resource planning, for things such as power, cooling,"},{"line_number":41,"context_line":"and overall system capacity."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_91211d50","line":40,"range":{"start_line":40,"start_character":45,"end_line":40,"end_character":48},"in_reply_to":"ba5201f7_33b6158b","updated":"2017-01-04 18:06:44.000000000","message":"Done","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"By leveraging functions already in place in the IPMITOOL class the collection"},{"line_number":48,"context_line":"of Node Manager extended sensor data is relatively straight forward and easy."},{"line_number":49,"context_line":"For systems that support it collecting the extended sensor data will happen"},{"line_number":50,"context_line":"within the existing get_sensors_data framework."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_13367103","line":48,"range":{"start_line":48,"start_character":37,"end_line":48,"end_character":77},"updated":"2016-12-30 14:38:58.000000000","message":"Perhaps describe how it is accessed?","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"35e804df6acda65e5123a86e0c9f2bbda595797b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"By leveraging functions already in place in the IPMITOOL class the collection"},{"line_number":48,"context_line":"of Node Manager extended sensor data is relatively straight forward and easy."},{"line_number":49,"context_line":"For systems that support it collecting the extended sensor data will happen"},{"line_number":50,"context_line":"within the existing get_sensors_data framework."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_cc4f8ebb","line":48,"range":{"start_line":48,"start_character":37,"end_line":48,"end_character":77},"in_reply_to":"ba5201f7_13367103","updated":"2017-01-04 18:06:44.000000000","message":"Done","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"By leveraging functions already in place in the IPMITOOL class the collection"},{"line_number":48,"context_line":"of Node Manager extended sensor data is relatively straight forward and easy."},{"line_number":49,"context_line":"For systems that support it collecting the extended sensor data will happen"},{"line_number":50,"context_line":"within the existing get_sensors_data framework."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_53171951","line":49,"range":{"start_line":49,"start_character":25,"end_line":49,"end_character":27},"updated":"2016-12-30 14:38:58.000000000","message":"Is it Ironic, or is it the system?  This sentence seems a little awkward. :(","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"35e804df6acda65e5123a86e0c9f2bbda595797b","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"By leveraging functions already in place in the IPMITOOL class the collection"},{"line_number":48,"context_line":"of Node Manager extended sensor data is relatively straight forward and easy."},{"line_number":49,"context_line":"For systems that support it collecting the extended sensor data will happen"},{"line_number":50,"context_line":"within the existing get_sensors_data framework."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_2ccbba1f","line":49,"range":{"start_line":49,"start_character":25,"end_line":49,"end_character":27},"in_reply_to":"ba5201f7_53171951","updated":"2017-01-04 18:06:44.000000000","message":"Done","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":121,"context_line":"------------------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Minor impact to the periodic task that collects sensor data. This is due to"},{"line_number":124,"context_line":"the additional data being collect via the ipmi interface."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Other deployer impact"},{"line_number":127,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_134f5193","line":124,"range":{"start_line":124,"start_character":42,"end_line":124,"end_character":46},"updated":"2016-12-30 14:38:58.000000000","message":"nit: s/ipmi/IPMI/","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Work Items"},{"line_number":150,"context_line":"----------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Reference work for IPMITOOL driver can be reviewed"},{"line_number":153,"context_line":"`here \u003chttps://review.openstack.org/#/c/410465\u003e`_"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_7377bdd4","line":151,"updated":"2016-12-30 14:38:58.000000000","message":"I feel like this should be the TODO list, but since there is a revision already posted... *shrug*","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":150,"context_line":"----------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Reference work for IPMITOOL driver can be reviewed"},{"line_number":153,"context_line":"`here \u003chttps://review.openstack.org/#/c/410465\u003e`_"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Dependencies"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_336d3505","line":153,"updated":"2016-12-30 14:38:58.000000000","message":"nit: Add a period.","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"35e804df6acda65e5123a86e0c9f2bbda595797b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"----------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Reference work for IPMITOOL driver can be reviewed"},{"line_number":153,"context_line":"`here \u003chttps://review.openstack.org/#/c/410465\u003e`_"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Dependencies"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_e7ee2bb3","line":153,"in_reply_to":"ba5201f7_336d3505","updated":"2017-01-04 18:06:44.000000000","message":"Done","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Dependencies"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"IPMI and Intel Node Manager support."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Testing"},{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_937421d0","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":36},"updated":"2016-12-30 14:38:58.000000000","message":"It would be nice if this was elaborated a little bit.  Perhaps \"Drivers utilizing IPMI for xyz, and nodes with Intel Node Manager\"?","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"35e804df6acda65e5123a86e0c9f2bbda595797b","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Dependencies"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"IPMI and Intel Node Manager support."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Testing"},{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_a7f42387","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":36},"in_reply_to":"ba5201f7_937421d0","updated":"2017-01-04 18:06:44.000000000","message":"Done","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3582f6ee030f6dd569346b9c72f9ddd1b5e3f722","unresolved":false,"context_lines":[{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Unit test provided for testing"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_b3812592","line":164,"updated":"2016-12-30 14:38:58.000000000","message":"nit: Excess empty line.","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"35e804df6acda65e5123a86e0c9f2bbda595797b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Unit test provided for testing"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_e71c6bc3","line":164,"in_reply_to":"ba5201f7_b3812592","updated":"2017-01-04 18:06:44.000000000","message":"Done","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"35e804df6acda65e5123a86e0c9f2bbda595797b","unresolved":false,"context_lines":[{"line_number":178,"context_line":"References"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"`Intel Node Manager Spec \u003chttp://www.intel.com/content/www/us/en/power-management/intelligent-power-node-manager-3-0-specification.html\u003e`_"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5201f7_e7738b13","line":181,"range":{"start_line":181,"start_character":0,"end_line":181,"end_character":25},"updated":"2017-01-04 18:06:44.000000000","message":"corrected reference linking.","commit_id":"207c151b69f29bee0046129b3f8e6661363d40dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7f5e6ff632b8c1a83d742fe5a516a5f1c843e174","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"By leveraging functions like `send_raw`, already in place in the IPMITOOL"},{"line_number":46,"context_line":"class, the collection of Node Manager extended sensor data is relatively"},{"line_number":47,"context_line":"straight forward and easy by sending hex commands to the systems IPMI"},{"line_number":48,"context_line":"interface. For systems that support Intel Node Manager collecting the"},{"line_number":49,"context_line":"extended sensor data will happen within the existing get_sensors_data"},{"line_number":50,"context_line":"framework. On systems that do not support Intel Node Manager the collection"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_109d000a","line":47,"updated":"2017-01-05 14:39:53.000000000","message":"Are you going to split common parts from your patch and from https://github.com/openstack/ironic-staging-drivers/blob/master/ironic_staging_drivers/intel_nm/nm_commands.py ? Maybe worth adding those to ironic-lib?","commit_id":"0d0fec3b6973388c20dbbf6986dfc2685bfee102"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"6cdc3e50e79d87e5507c6a615d8f8b2d084619d5","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"By leveraging functions like `send_raw`, already in place in the IPMITOOL"},{"line_number":46,"context_line":"class, the collection of Node Manager extended sensor data is relatively"},{"line_number":47,"context_line":"straight forward and easy by sending hex commands to the systems IPMI"},{"line_number":48,"context_line":"interface. For systems that support Intel Node Manager collecting the"},{"line_number":49,"context_line":"extended sensor data will happen within the existing get_sensors_data"},{"line_number":50,"context_line":"framework. On systems that do not support Intel Node Manager the collection"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_284d343e","line":47,"in_reply_to":"ba5201f7_109d000a","updated":"2017-01-05 18:36:35.000000000","message":"Good point here. I have a work item to split out the POC work in to its own file. I will add a note about moving the common bits to ironic-lib!","commit_id":"0d0fec3b6973388c20dbbf6986dfc2685bfee102"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ecb87979d38469f9f57ce019eb648fbfe87bacbe","unresolved":false,"context_lines":[{"line_number":49,"context_line":"extended sensor data will happen within the existing get_sensors_data"},{"line_number":50,"context_line":"framework. On systems that do not support Intel Node Manager the collection"},{"line_number":51,"context_line":"of extended sensor data is skipped, even if the `send_sensor_data_types`"},{"line_number":52,"context_line":"config parameter is set to collect it."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"},{"line_number":55,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_e85b3ef4","line":52,"updated":"2017-01-05 11:13:29.000000000","message":"It would be good to the spec to specify which extra/extended data it\u0027s talking about, by looking at the patch I see: airflow, CUPS utilization, {out,in}let temperatures, etc...","commit_id":"0d0fec3b6973388c20dbbf6986dfc2685bfee102"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"6cdc3e50e79d87e5507c6a615d8f8b2d084619d5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"extended sensor data will happen within the existing get_sensors_data"},{"line_number":50,"context_line":"framework. On systems that do not support Intel Node Manager the collection"},{"line_number":51,"context_line":"of extended sensor data is skipped, even if the `send_sensor_data_types`"},{"line_number":52,"context_line":"config parameter is set to collect it."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"},{"line_number":55,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_a85f64e3","line":52,"in_reply_to":"ba5201f7_e85b3ef4","updated":"2017-01-05 18:36:35.000000000","message":"This information is provided in lines 21 through 29. Would it be better to move those lines to this section?","commit_id":"0d0fec3b6973388c20dbbf6986dfc2685bfee102"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ecb87979d38469f9f57ce019eb648fbfe87bacbe","unresolved":false,"context_lines":[{"line_number":123,"context_line":"------------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Minor impact to the periodic task that collects sensor data. This is due to"},{"line_number":126,"context_line":"the additional data being collect via the IPMI interface."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Other deployer impact"},{"line_number":129,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_68ff4eaa","line":126,"updated":"2017-01-05 11:13:29.000000000","message":"Would make sense to have a configuration option for people to disable these extended sensor in case they don\u0027t care about it ?\n\nI mean, even if Intel Node manager is available one could disable it so that Ironic doesn\u0027t send X extra request against their BMC because they are not interested in this extra data.","commit_id":"0d0fec3b6973388c20dbbf6986dfc2685bfee102"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7f5e6ff632b8c1a83d742fe5a516a5f1c843e174","unresolved":false,"context_lines":[{"line_number":123,"context_line":"------------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Minor impact to the periodic task that collects sensor data. This is due to"},{"line_number":126,"context_line":"the additional data being collect via the IPMI interface."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Other deployer impact"},{"line_number":129,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_b0e0b497","line":126,"in_reply_to":"ba5201f7_68ff4eaa","updated":"2017-01-05 14:39:53.000000000","message":"I think this happens already, if cups is not in send_sensor_data_types it will be filtered out - https://github.com/openstack/ironic/blob/a5a1a31761525a2cb34997454a1f7955eadd5ad4/ironic/conductor/manager.py#L2056","commit_id":"0d0fec3b6973388c20dbbf6986dfc2685bfee102"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"6cdc3e50e79d87e5507c6a615d8f8b2d084619d5","unresolved":false,"context_lines":[{"line_number":123,"context_line":"------------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Minor impact to the periodic task that collects sensor data. This is due to"},{"line_number":126,"context_line":"the additional data being collect via the IPMI interface."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Other deployer impact"},{"line_number":129,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_4ea36100","line":126,"in_reply_to":"ba5201f7_b0e0b497","updated":"2017-01-05 18:36:35.000000000","message":"Vladyslav is correct here if the not specified in the conf file the extend sensor data is not returned.","commit_id":"0d0fec3b6973388c20dbbf6986dfc2685bfee102"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f60eabc4d3e34d5b290fad309f70b7a37f7e9e71","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Items to be completed:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* split reference work out of ipmitool.py in to it\u0027s own file."},{"line_number":160,"context_line":"   * this should include moving common parts of the code to `ironic-lib`."},{"line_number":161,"context_line":"* verify data structure returned when Node Manager data is available."},{"line_number":162,"context_line":"* write usage docs."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba5201f7_d7d9a023","line":159,"updated":"2017-01-05 20:15:25.000000000","message":"nit: s/split/Split/ or Separate\n\nMy understanding is that the reference work is a proof of concept.  Would it make sense to specifically indicate that?","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"bc3cf519efce515c209db438f342489773887567","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Items to be completed:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* split reference work out of ipmitool.py in to it\u0027s own file."},{"line_number":160,"context_line":"   * this should include moving common parts of the code to `ironic-lib`."},{"line_number":161,"context_line":"* verify data structure returned when Node Manager data is available."},{"line_number":162,"context_line":"* write usage docs."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba5201f7_82cc386b","line":159,"in_reply_to":"ba5201f7_d7d9a023","updated":"2017-01-05 20:48:12.000000000","message":"Done","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f60eabc4d3e34d5b290fad309f70b7a37f7e9e71","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Items to be completed:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* split reference work out of ipmitool.py in to it\u0027s own file."},{"line_number":160,"context_line":"   * this should include moving common parts of the code to `ironic-lib`."},{"line_number":161,"context_line":"* verify data structure returned when Node Manager data is available."},{"line_number":162,"context_line":"* write usage docs."},{"line_number":163,"context_line":"* review and update unit tests."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba5201f7_d7c28033","line":160,"range":{"start_line":160,"start_character":5,"end_line":160,"end_character":6},"updated":"2017-01-05 20:15:25.000000000","message":"Nit: s/this/This/ since it is a proper sentence.","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"bc3cf519efce515c209db438f342489773887567","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Items to be completed:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* split reference work out of ipmitool.py in to it\u0027s own file."},{"line_number":160,"context_line":"   * this should include moving common parts of the code to `ironic-lib`."},{"line_number":161,"context_line":"* verify data structure returned when Node Manager data is available."},{"line_number":162,"context_line":"* write usage docs."},{"line_number":163,"context_line":"* review and update unit tests."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba5201f7_6201146a","line":160,"range":{"start_line":160,"start_character":5,"end_line":160,"end_character":6},"in_reply_to":"ba5201f7_d7c28033","updated":"2017-01-05 20:48:12.000000000","message":"Done","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f60eabc4d3e34d5b290fad309f70b7a37f7e9e71","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* split reference work out of ipmitool.py in to it\u0027s own file."},{"line_number":160,"context_line":"   * this should include moving common parts of the code to `ironic-lib`."},{"line_number":161,"context_line":"* verify data structure returned when Node Manager data is available."},{"line_number":162,"context_line":"* write usage docs."},{"line_number":163,"context_line":"* review and update unit tests."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba5201f7_370bcc8f","line":161,"range":{"start_line":161,"start_character":2,"end_line":161,"end_character":3},"updated":"2017-01-05 20:15:25.000000000","message":"nit: s/v/V/","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"bc3cf519efce515c209db438f342489773887567","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* split reference work out of ipmitool.py in to it\u0027s own file."},{"line_number":160,"context_line":"   * this should include moving common parts of the code to `ironic-lib`."},{"line_number":161,"context_line":"* verify data structure returned when Node Manager data is available."},{"line_number":162,"context_line":"* write usage docs."},{"line_number":163,"context_line":"* review and update unit tests."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba5201f7_a2f77c89","line":161,"range":{"start_line":161,"start_character":2,"end_line":161,"end_character":3},"in_reply_to":"ba5201f7_370bcc8f","updated":"2017-01-05 20:48:12.000000000","message":"Done","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f60eabc4d3e34d5b290fad309f70b7a37f7e9e71","unresolved":false,"context_lines":[{"line_number":159,"context_line":"* split reference work out of ipmitool.py in to it\u0027s own file."},{"line_number":160,"context_line":"   * this should include moving common parts of the code to `ironic-lib`."},{"line_number":161,"context_line":"* verify data structure returned when Node Manager data is available."},{"line_number":162,"context_line":"* write usage docs."},{"line_number":163,"context_line":"* review and update unit tests."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba5201f7_7701d469","line":162,"range":{"start_line":162,"start_character":2,"end_line":162,"end_character":19},"updated":"2017-01-05 20:15:25.000000000","message":"Perhaps \"Update documentation to detail usage.\"?","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"bc3cf519efce515c209db438f342489773887567","unresolved":false,"context_lines":[{"line_number":159,"context_line":"* split reference work out of ipmitool.py in to it\u0027s own file."},{"line_number":160,"context_line":"   * this should include moving common parts of the code to `ironic-lib`."},{"line_number":161,"context_line":"* verify data structure returned when Node Manager data is available."},{"line_number":162,"context_line":"* write usage docs."},{"line_number":163,"context_line":"* review and update unit tests."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba5201f7_42333062","line":162,"range":{"start_line":162,"start_character":2,"end_line":162,"end_character":19},"in_reply_to":"ba5201f7_7701d469","updated":"2017-01-05 20:48:12.000000000","message":"Done","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f60eabc4d3e34d5b290fad309f70b7a37f7e9e71","unresolved":false,"context_lines":[{"line_number":165,"context_line":"Dependencies"},{"line_number":166,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Drivers utilizing IPMITOOL for power managment, and nodes equipped"},{"line_number":169,"context_line":"with Intel Node Manager support."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba5201f7_f7edc4b7","line":168,"range":{"start_line":168,"start_character":46,"end_line":168,"end_character":47},"updated":"2017-01-05 20:15:25.000000000","message":"nit: The comma seems redundant.","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"bc3cf519efce515c209db438f342489773887567","unresolved":false,"context_lines":[{"line_number":165,"context_line":"Dependencies"},{"line_number":166,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Drivers utilizing IPMITOOL for power managment, and nodes equipped"},{"line_number":169,"context_line":"with Intel Node Manager support."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba5201f7_6238343e","line":168,"range":{"start_line":168,"start_character":46,"end_line":168,"end_character":47},"in_reply_to":"ba5201f7_f7edc4b7","updated":"2017-01-05 20:48:12.000000000","message":"Done","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f60eabc4d3e34d5b290fad309f70b7a37f7e9e71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ba5201f7_b76c1c36","line":193,"updated":"2017-01-05 20:15:25.000000000","message":"Note: Nothing is actually rendered under references.  I don\u0027t know if it makes sense to list the items so the links are functional and informative, or if it just makes sense to leave the links here.","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"bc3cf519efce515c209db438f342489773887567","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ba5201f7_8228b8e3","line":193,"in_reply_to":"ba5201f7_b76c1c36","updated":"2017-01-05 20:48:12.000000000","message":"These are here because the links are used above in lines: 17 \u0026 37","commit_id":"540fba5219954da481f8d5d1c46173c5d239ac51"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"62a2097794b664e4f4aff4260e84159530898462","unresolved":false,"context_lines":[{"line_number":14,"context_line":"will be able to more closely monitor the health of their bare metal fleets."},{"line_number":15,"context_line":"Systems that are equipped Intel Node Manager can provide a greater level of"},{"line_number":16,"context_line":"sensor data that can be monitored, thereby providing for better fleet"},{"line_number":17,"context_line":"oversight. For more details see `Intel Node Manager Spec`_. Some of"},{"line_number":18,"context_line":"the additional data points that can be collected from enabled systems"},{"line_number":19,"context_line":"are:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_3782bec8","line":17,"range":{"start_line":17,"start_character":32,"end_line":17,"end_character":58},"updated":"2017-01-06 23:56:10.000000000","message":"Typo in the references section below. Link doesn\u0027t work.","commit_id":"a84a15682e0d7cc5b4d3fa7f9c698d5385ea54cb"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8fcee0c45b179cb461afd6bffd8922ab961b53ac","unresolved":false,"context_lines":[{"line_number":14,"context_line":"will be able to more closely monitor the health of their bare metal fleets."},{"line_number":15,"context_line":"Systems that are equipped Intel Node Manager can provide a greater level of"},{"line_number":16,"context_line":"sensor data that can be monitored, thereby providing for better fleet"},{"line_number":17,"context_line":"oversight. For more details see `Intel Node Manager Spec`_. Some of"},{"line_number":18,"context_line":"the additional data points that can be collected from enabled systems"},{"line_number":19,"context_line":"are:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_1c9db259","line":17,"range":{"start_line":17,"start_character":32,"end_line":17,"end_character":58},"in_reply_to":"ba5201f7_3782bec8","updated":"2017-01-09 15:26:10.000000000","message":"Done","commit_id":"a84a15682e0d7cc5b4d3fa7f9c698d5385ea54cb"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"62a2097794b664e4f4aff4260e84159530898462","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Problem description"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Currently ironic is not able to collect extended sensor data from systems that"},{"line_number":36,"context_line":"have Intel Node Manager. A list of supported systems can be found here:"},{"line_number":37,"context_line":"`Node Manager Availability Matrix`_. Collecting the extended Node Manager"},{"line_number":38,"context_line":"sensor data can aid in better data center resource planning, by providing"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_976b6a1d","line":35,"range":{"start_line":35,"start_character":10,"end_line":35,"end_character":16},"updated":"2017-01-06 23:56:10.000000000","message":"``ironic``","commit_id":"a84a15682e0d7cc5b4d3fa7f9c698d5385ea54cb"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8fcee0c45b179cb461afd6bffd8922ab961b53ac","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Problem description"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Currently ironic is not able to collect extended sensor data from systems that"},{"line_number":36,"context_line":"have Intel Node Manager. A list of supported systems can be found here:"},{"line_number":37,"context_line":"`Node Manager Availability Matrix`_. Collecting the extended Node Manager"},{"line_number":38,"context_line":"sensor data can aid in better data center resource planning, by providing"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_1cecd28e","line":35,"range":{"start_line":35,"start_character":10,"end_line":35,"end_character":16},"in_reply_to":"ba5201f7_976b6a1d","updated":"2017-01-09 15:26:10.000000000","message":"Done","commit_id":"a84a15682e0d7cc5b4d3fa7f9c698d5385ea54cb"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"62a2097794b664e4f4aff4260e84159530898462","unresolved":false,"context_lines":[{"line_number":76,"context_line":"None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"ironic\" CLI"},{"line_number":79,"context_line":"~~~~~~~~~~~~"},{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"\"openstack baremetal\" CLI"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_d74892b5","line":79,"updated":"2017-01-06 23:56:10.000000000","message":"s/~~~~~~~~~~~~/----------","commit_id":"a84a15682e0d7cc5b4d3fa7f9c698d5385ea54cb"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8fcee0c45b179cb461afd6bffd8922ab961b53ac","unresolved":false,"context_lines":[{"line_number":76,"context_line":"None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"ironic\" CLI"},{"line_number":79,"context_line":"~~~~~~~~~~~~"},{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"\"openstack baremetal\" CLI"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_fc9d4e0b","line":79,"in_reply_to":"ba5201f7_d74892b5","updated":"2017-01-09 15:26:10.000000000","message":"This is formatting from the template: https://raw.githubusercontent.com/openstack/ironic-specs/master/specs/template.rst","commit_id":"a84a15682e0d7cc5b4d3fa7f9c698d5385ea54cb"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"62a2097794b664e4f4aff4260e84159530898462","unresolved":false,"context_lines":[{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"\"openstack baremetal\" CLI"},{"line_number":83,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":84,"context_line":"None"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"RPC API impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_f7f03669","line":83,"updated":"2017-01-06 23:56:10.000000000","message":"s/~~~~~~~~~~~~/----------","commit_id":"a84a15682e0d7cc5b4d3fa7f9c698d5385ea54cb"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8fcee0c45b179cb461afd6bffd8922ab961b53ac","unresolved":false,"context_lines":[{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"\"openstack baremetal\" CLI"},{"line_number":83,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":84,"context_line":"None"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"RPC API impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_9c8fe2cb","line":83,"in_reply_to":"ba5201f7_f7f03669","updated":"2017-01-09 15:26:10.000000000","message":"this formatting is from the template","commit_id":"a84a15682e0d7cc5b4d3fa7f9c698d5385ea54cb"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"90dea6f5f710ebe81c9d434d2ca0a8048b0c9c30","unresolved":false,"context_lines":[{"line_number":190,"context_line":"References"},{"line_number":191,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":".. _Intel Node Manager Spec: http://www.intel.com/content/www/us/en/power-management/intelligent-power-node-manager-3-0-specification.html"},{"line_number":194,"context_line":".. _Node Manager Availability Matrix: http://www.intel.com/content/www/us/en/data-center/data-center-management/node-manager-server-platforms-matrix-guide.html"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba5201f7_1f8cba34","line":193,"updated":"2017-01-09 18:36:32.000000000","message":"Hi, references are not showing in the spec: http://docs-draft.openstack.org/49/413249/10/check/gate-ironic-specs-docs-ubuntu-xenial/15d68f3//doc/build/html/specs/not-implemented/Intel-Node-Manager-sensor-collection.html","commit_id":"cd09e09988c4727044cd380e50512569f50c75f8"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d9d3bc9e72993ea0db220f58fd37468f8d57a4a1","unresolved":false,"context_lines":[{"line_number":190,"context_line":"References"},{"line_number":191,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":".. _Intel Node Manager Spec: http://www.intel.com/content/www/us/en/power-management/intelligent-power-node-manager-3-0-specification.html"},{"line_number":194,"context_line":".. _Node Manager Availability Matrix: http://www.intel.com/content/www/us/en/data-center/data-center-management/node-manager-server-platforms-matrix-guide.html"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba5201f7_fd29bef3","line":193,"in_reply_to":"ba5201f7_1f8cba34","updated":"2017-01-09 19:23:53.000000000","message":"Done","commit_id":"cd09e09988c4727044cd380e50512569f50c75f8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6890ad5e71c455cc9cfec83ef2a77afa165d2f50","unresolved":false,"context_lines":[{"line_number":50,"context_line":"framework. On systems that do not support Intel Node Manager the collection"},{"line_number":51,"context_line":"of extended sensor data is skipped, even if the `send_sensor_data_types`"},{"line_number":52,"context_line":"config parameter is set to collect it."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"},{"line_number":55,"context_line":"------------"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_e06c599e","line":53,"updated":"2017-01-11 12:36:34.000000000","message":"The change you actually propose is not clear to me. I understand it like: modify the ipmitool driver to try send_raw with something to collect additional sensors during get_sensors_data. Ignore failures. Is it right?","commit_id":"fcb051263c4f11409172729cef78ecee2f611b86"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"7b03d561e2be1595b15706baf21a0aadeaceba0c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"framework. On systems that do not support Intel Node Manager the collection"},{"line_number":51,"context_line":"of extended sensor data is skipped, even if the `send_sensor_data_types`"},{"line_number":52,"context_line":"config parameter is set to collect it."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"},{"line_number":55,"context_line":"------------"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_32c21e35","line":53,"in_reply_to":"ba5201f7_e06c599e","updated":"2017-01-11 19:09:44.000000000","message":"Done","commit_id":"fcb051263c4f11409172729cef78ecee2f611b86"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6890ad5e71c455cc9cfec83ef2a77afa165d2f50","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Items to be completed:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* Separate proof of concept reference work out of ipmitool.py in to it\u0027s own"},{"line_number":160,"context_line":"  file(s)."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"   * This should include moving common parts of the code to `ironic-lib`."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_00687d86","line":159,"updated":"2017-01-11 12:36:34.000000000","message":"which PoC work are you referring to here?","commit_id":"fcb051263c4f11409172729cef78ecee2f611b86"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"7b03d561e2be1595b15706baf21a0aadeaceba0c","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Items to be completed:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* Separate proof of concept reference work out of ipmitool.py in to it\u0027s own"},{"line_number":160,"context_line":"  file(s)."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"   * This should include moving common parts of the code to `ironic-lib`."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_527c02b5","line":159,"in_reply_to":"ba5201f7_00687d86","updated":"2017-01-11 19:09:44.000000000","message":"Done","commit_id":"fcb051263c4f11409172729cef78ecee2f611b86"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6890ad5e71c455cc9cfec83ef2a77afa165d2f50","unresolved":false,"context_lines":[{"line_number":159,"context_line":"* Separate proof of concept reference work out of ipmitool.py in to it\u0027s own"},{"line_number":160,"context_line":"  file(s)."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"   * This should include moving common parts of the code to `ironic-lib`."},{"line_number":163,"context_line":"* Verify data structure returned when Node Manager data is available."},{"line_number":164,"context_line":"* Update documentation to detail usage."},{"line_number":165,"context_line":"* Add / update unit tests."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_200581c1","line":162,"updated":"2017-01-11 12:36:34.000000000","message":"Why? Which Ironic projects are going to use this code?","commit_id":"fcb051263c4f11409172729cef78ecee2f611b86"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"7b03d561e2be1595b15706baf21a0aadeaceba0c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"* Separate proof of concept reference work out of ipmitool.py in to it\u0027s own"},{"line_number":160,"context_line":"  file(s)."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"   * This should include moving common parts of the code to `ironic-lib`."},{"line_number":163,"context_line":"* Verify data structure returned when Node Manager data is available."},{"line_number":164,"context_line":"* Update documentation to detail usage."},{"line_number":165,"context_line":"* Add / update unit tests."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_b5799884","line":162,"in_reply_to":"ba5201f7_200581c1","updated":"2017-01-11 19:09:44.000000000","message":"This was added by reviewer request on revision #5","commit_id":"fcb051263c4f11409172729cef78ecee2f611b86"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"a185689a6eb86f10b3e5942e894b9cb08dc07e2f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Proposed change"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"This patch will modify the collection of sensor data so that with in sensor"},{"line_number":46,"context_line":"data collection task, nodes are checked for Intel Node Manager support, if"},{"line_number":47,"context_line":"present extended sensor data is collected. This is accomplished by leveraging"},{"line_number":48,"context_line":"functions like `send_raw`, already in place in the IPMITOOL class, the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_c92cb69b","line":45,"range":{"start_line":45,"start_character":61,"end_line":45,"end_character":68},"updated":"2017-01-17 13:51:53.000000000","message":"possibly you meant `within` as one word?","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"9de5a0c17916dac66b0ebcb04bdcafbc41aa3ede","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Proposed change"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"This patch will modify the collection of sensor data so that with in sensor"},{"line_number":46,"context_line":"data collection task, nodes are checked for Intel Node Manager support, if"},{"line_number":47,"context_line":"present extended sensor data is collected. This is accomplished by leveraging"},{"line_number":48,"context_line":"functions like `send_raw`, already in place in the IPMITOOL class, the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_1928c585","line":45,"range":{"start_line":45,"start_character":61,"end_line":45,"end_character":68},"in_reply_to":"7a3c09a3_c92cb69b","updated":"2017-01-17 16:36:30.000000000","message":"Done","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"386cc0810b5a7b35ee6f8af2f9886e4c0a5869ca","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  None"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Reference work for IPMITOOL driver can be reviewed"},{"line_number":155,"context_line":"`Proof of Consept Reference`_."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Work Items"},{"line_number":158,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_dbdb0aec","line":155,"updated":"2017-01-14 00:14:44.000000000","message":"s/Consept/Concept","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"9de5a0c17916dac66b0ebcb04bdcafbc41aa3ede","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  None"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Reference work for IPMITOOL driver can be reviewed"},{"line_number":155,"context_line":"`Proof of Consept Reference`_."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Work Items"},{"line_number":158,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_9974b568","line":155,"in_reply_to":"7a3c09a3_dbdb0aec","updated":"2017-01-17 16:36:30.000000000","message":"Done","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"a185689a6eb86f10b3e5942e894b9cb08dc07e2f","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Items to be completed:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* Separate `Proof of Consept Reference`_ work out of ipmitool.py in to it\u0027s own"},{"line_number":163,"context_line":"  file(s)."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"   * This should include moving common parts of the code to `ironic-lib`."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_c9883674","line":162,"range":{"start_line":162,"start_character":65,"end_line":162,"end_character":70},"updated":"2017-01-17 13:51:53.000000000","message":"Possibly it is `into`?","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"386cc0810b5a7b35ee6f8af2f9886e4c0a5869ca","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Items to be completed:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* Separate `Proof of Consept Reference`_ work out of ipmitool.py in to it\u0027s own"},{"line_number":163,"context_line":"  file(s)."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"   * This should include moving common parts of the code to `ironic-lib`."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_3be32ea5","line":162,"updated":"2017-01-14 00:14:44.000000000","message":"ditto","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"9de5a0c17916dac66b0ebcb04bdcafbc41aa3ede","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Items to be completed:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* Separate `Proof of Consept Reference`_ work out of ipmitool.py in to it\u0027s own"},{"line_number":163,"context_line":"  file(s)."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"   * This should include moving common parts of the code to `ironic-lib`."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_d96abd80","line":162,"in_reply_to":"7a3c09a3_3be32ea5","updated":"2017-01-17 16:36:30.000000000","message":"Done","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"9de5a0c17916dac66b0ebcb04bdcafbc41aa3ede","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Items to be completed:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* Separate `Proof of Consept Reference`_ work out of ipmitool.py in to it\u0027s own"},{"line_number":163,"context_line":"  file(s)."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"   * This should include moving common parts of the code to `ironic-lib`."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_f96779b4","line":162,"range":{"start_line":162,"start_character":65,"end_line":162,"end_character":70},"in_reply_to":"7a3c09a3_c9883674","updated":"2017-01-17 16:36:30.000000000","message":"Done","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"a185689a6eb86f10b3e5942e894b9cb08dc07e2f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"* Separate `Proof of Consept Reference`_ work out of ipmitool.py in to it\u0027s own"},{"line_number":163,"context_line":"  file(s)."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"   * This should include moving common parts of the code to `ironic-lib`."},{"line_number":166,"context_line":"* Verify data structure returned when Node Manager data is available."},{"line_number":167,"context_line":"* Update documentation to detail usage."},{"line_number":168,"context_line":"* Add / update unit tests."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_97a80a22","line":165,"updated":"2017-01-17 13:51:53.000000000","message":"nit: looks line excessive blank line and two white-spaces","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"9de5a0c17916dac66b0ebcb04bdcafbc41aa3ede","unresolved":false,"context_lines":[{"line_number":162,"context_line":"* Separate `Proof of Consept Reference`_ work out of ipmitool.py in to it\u0027s own"},{"line_number":163,"context_line":"  file(s)."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"   * This should include moving common parts of the code to `ironic-lib`."},{"line_number":166,"context_line":"* Verify data structure returned when Node Manager data is available."},{"line_number":167,"context_line":"* Update documentation to detail usage."},{"line_number":168,"context_line":"* Add / update unit tests."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_f9713945","line":165,"in_reply_to":"7a3c09a3_97a80a22","updated":"2017-01-17 16:36:30.000000000","message":"This done for formatting","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"a185689a6eb86f10b3e5942e894b9cb08dc07e2f","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Dependencies"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Drivers utilizing IPMITOOL for power managment and nodes equipped"},{"line_number":174,"context_line":"with Intel Node Manager support."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_49dc4673","line":173,"range":{"start_line":173,"start_character":37,"end_line":173,"end_character":46},"updated":"2017-01-17 13:51:53.000000000","message":"Typo of: `management`","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"9de5a0c17916dac66b0ebcb04bdcafbc41aa3ede","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Dependencies"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Drivers utilizing IPMITOOL for power managment and nodes equipped"},{"line_number":174,"context_line":"with Intel Node Manager support."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_b9a25197","line":173,"range":{"start_line":173,"start_character":37,"end_line":173,"end_character":46},"in_reply_to":"7a3c09a3_49dc4673","updated":"2017-01-17 16:36:30.000000000","message":"Done","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"a185689a6eb86f10b3e5942e894b9cb08dc07e2f","unresolved":false,"context_lines":[{"line_number":176,"context_line":"Testing"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Unit test provided for testing"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_97564a28","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":30},"updated":"2017-01-17 13:51:53.000000000","message":"Tests will be provided, i think :)","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"9de5a0c17916dac66b0ebcb04bdcafbc41aa3ede","unresolved":false,"context_lines":[{"line_number":176,"context_line":"Testing"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Unit test provided for testing"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_d9c2bd33","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":30},"in_reply_to":"7a3c09a3_97564a28","updated":"2017-01-17 16:36:30.000000000","message":"Done","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"a185689a6eb86f10b3e5942e894b9cb08dc07e2f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"This change should have no impact other then older versions not being able to"},{"line_number":185,"context_line":"collect the Node Manager extended sensor data."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_494a8627","line":184,"range":{"start_line":184,"start_character":40,"end_line":184,"end_character":44},"updated":"2017-01-17 13:51:53.000000000","message":"Possibly confused `then` and `than`?","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"9de5a0c17916dac66b0ebcb04bdcafbc41aa3ede","unresolved":false,"context_lines":[{"line_number":181,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"This change should have no impact other then older versions not being able to"},{"line_number":185,"context_line":"collect the Node Manager extended sensor data."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_d9d9dd23","line":184,"range":{"start_line":184,"start_character":40,"end_line":184,"end_character":44},"in_reply_to":"7a3c09a3_494a8627","updated":"2017-01-17 16:36:30.000000000","message":"Done","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"386cc0810b5a7b35ee6f8af2f9886e4c0a5869ca","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"- `Intel Node Manager Spec`_"},{"line_number":197,"context_line":"- `Node Manager Availability Matrix`_"},{"line_number":198,"context_line":"- `Proof of Consept Reference`_"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. _Intel Node Manager Spec: http://www.intel.com/content/www/us/en/power-management/intelligent-power-node-manager-3-0-specification.html"},{"line_number":201,"context_line":".. _Node Manager Availability Matrix: http://www.intel.com/content/www/us/en/data-center/data-center-management/node-manager-server-platforms-matrix-guide.html"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_5bee3a8c","line":198,"updated":"2017-01-14 00:14:44.000000000","message":"ditto","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"9de5a0c17916dac66b0ebcb04bdcafbc41aa3ede","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"- `Intel Node Manager Spec`_"},{"line_number":197,"context_line":"- `Node Manager Availability Matrix`_"},{"line_number":198,"context_line":"- `Proof of Consept Reference`_"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. _Intel Node Manager Spec: http://www.intel.com/content/www/us/en/power-management/intelligent-power-node-manager-3-0-specification.html"},{"line_number":201,"context_line":".. _Node Manager Availability Matrix: http://www.intel.com/content/www/us/en/data-center/data-center-management/node-manager-server-platforms-matrix-guide.html"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_59fc0d72","line":198,"in_reply_to":"7a3c09a3_5bee3a8c","updated":"2017-01-17 16:36:30.000000000","message":"Done","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"386cc0810b5a7b35ee6f8af2f9886e4c0a5869ca","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. _Intel Node Manager Spec: http://www.intel.com/content/www/us/en/power-management/intelligent-power-node-manager-3-0-specification.html"},{"line_number":201,"context_line":".. _Node Manager Availability Matrix: http://www.intel.com/content/www/us/en/data-center/data-center-management/node-manager-server-platforms-matrix-guide.html"},{"line_number":202,"context_line":".. _Proof of Consept Reference: https://review.openstack.org/#/c/410465"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_9be8a27e","line":202,"updated":"2017-01-14 00:14:44.000000000","message":"ditto","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"9de5a0c17916dac66b0ebcb04bdcafbc41aa3ede","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. _Intel Node Manager Spec: http://www.intel.com/content/www/us/en/power-management/intelligent-power-node-manager-3-0-specification.html"},{"line_number":201,"context_line":".. _Node Manager Availability Matrix: http://www.intel.com/content/www/us/en/data-center/data-center-management/node-manager-server-platforms-matrix-guide.html"},{"line_number":202,"context_line":".. _Proof of Consept Reference: https://review.openstack.org/#/c/410465"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_7901c969","line":202,"in_reply_to":"7a3c09a3_9be8a27e","updated":"2017-01-17 16:36:30.000000000","message":"Done","commit_id":"31674a5605181d9a8a2151604daec4601f1c0934"}]}