)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3fb5bcc022f0d0b3d516167e21a1e24da2a9d09a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"redfish_system_id\" makes more sense and hopefully will make things more"},{"line_number":22,"context_line":"flexible when adapting the driver to work with different types of"},{"line_number":23,"context_line":"systems (hopefully we will only need to change the library underneath)."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[0] 88b55d4307cdc9e6ff37d8cbfea228c1c281e79f"},{"line_number":26,"context_line":"[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-03-14.log.html#t2017-03-14T12:05:46"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a22e58a_d936d5b3","line":24,"updated":"2017-03-14 12:55:37.000000000","message":"it\u0027s also worth noting that building URLs from the root one is how Redfish is meant to be used. And link to http://redfish.dmtf.org/schemas/DSP0266_1.1.html#uris","commit_id":"8070393da9a684f18947b6c8ba7761cbbd4f1e88"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"106aa0bceb63f70fcec40e98fac0a9dcd1c93fdf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"redfish_system_id\" makes more sense and hopefully will make things more"},{"line_number":22,"context_line":"flexible when adapting the driver to work with different types of"},{"line_number":23,"context_line":"systems (hopefully we will only need to change the library underneath)."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[0] 88b55d4307cdc9e6ff37d8cbfea228c1c281e79f"},{"line_number":26,"context_line":"[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-03-14.log.html#t2017-03-14T12:05:46"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a22e58a_1c7cdb71","line":24,"in_reply_to":"5a22e58a_d936d5b3","updated":"2017-03-14 13:17:26.000000000","message":"++ will add since there\u0027s a pep8 error in the current patch anyway :D","commit_id":"8070393da9a684f18947b6c8ba7761cbbd4f1e88"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bdef2e7af6e3cf0e068127bf0509c0fce3499425","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow-up patch for the Redfish spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch contains a changes to the driver\u0027s properties from the"},{"line_number":10,"context_line":"original Redfish spec[0]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Before the driver was expecting a single \"redfish_uri\" property which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a1ff146_aa7d4be9","line":9,"updated":"2017-03-14 14:47:43.000000000","message":"s/a changes/changes","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"65bbe52602cd63ab11292523302809bf57f55c4d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow-up patch for the Redfish spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch contains a changes to the driver\u0027s properties from the"},{"line_number":10,"context_line":"original Redfish spec[0]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Before the driver was expecting a single \"redfish_uri\" property which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a1ff146_186875ba","line":9,"in_reply_to":"3a1ff146_aa7d4be9","updated":"2017-03-14 15:16:01.000000000","message":"Done","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bdef2e7af6e3cf0e068127bf0509c0fce3499425","unresolved":false,"context_lines":[{"line_number":10,"context_line":"original Redfish spec[0]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Before the driver was expecting a single \"redfish_uri\" property which"},{"line_number":13,"context_line":"contained two information: The URI to the root resource and the system"},{"line_number":14,"context_line":"resource identifier."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As discussed on IRC on 14/03/2017 [1], turns out that the Redfish"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a1ff146_ea8743d5","line":13,"updated":"2017-03-14 14:47:43.000000000","message":"\"two pieces of information\"","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"65bbe52602cd63ab11292523302809bf57f55c4d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"original Redfish spec[0]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Before the driver was expecting a single \"redfish_uri\" property which"},{"line_number":13,"context_line":"contained two information: The URI to the root resource and the system"},{"line_number":14,"context_line":"resource identifier."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As discussed on IRC on 14/03/2017 [1], turns out that the Redfish"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a1ff146_5862edd9","line":13,"in_reply_to":"3a1ff146_ea8743d5","updated":"2017-03-14 15:16:01.000000000","message":"Done","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bdef2e7af6e3cf0e068127bf0509c0fce3499425","unresolved":false,"context_lines":[{"line_number":13,"context_line":"contained two information: The URI to the root resource and the system"},{"line_number":14,"context_line":"resource identifier."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As discussed on IRC on 14/03/2017 [1], turns out that the Redfish"},{"line_number":17,"context_line":"specification isn\u0027t very opinionated regarding the names of the resources"},{"line_number":18,"context_line":"which may lead to some implementations to call /Systems (as we call it in"},{"line_number":19,"context_line":"this specification) /Nodes or any other variant. Therefore, splitting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a1ff146_ca9e0707","line":16,"updated":"2017-03-14 14:47:43.000000000","message":"\"it turns out\"","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"65bbe52602cd63ab11292523302809bf57f55c4d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"contained two information: The URI to the root resource and the system"},{"line_number":14,"context_line":"resource identifier."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As discussed on IRC on 14/03/2017 [1], turns out that the Redfish"},{"line_number":17,"context_line":"specification isn\u0027t very opinionated regarding the names of the resources"},{"line_number":18,"context_line":"which may lead to some implementations to call /Systems (as we call it in"},{"line_number":19,"context_line":"this specification) /Nodes or any other variant. Therefore, splitting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a1ff146_785fa90e","line":16,"in_reply_to":"3a1ff146_ca9e0707","updated":"2017-03-14 15:16:01.000000000","message":"Done","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bdef2e7af6e3cf0e068127bf0509c0fce3499425","unresolved":false,"context_lines":[{"line_number":18,"context_line":"which may lead to some implementations to call /Systems (as we call it in"},{"line_number":19,"context_line":"this specification) /Nodes or any other variant. Therefore, splitting"},{"line_number":20,"context_line":"the old proposed \"redfish_uri\" into \"redfish_root_uri\" and"},{"line_number":21,"context_line":"\"redfish_system_id\" makes more sense and hopefully will make things more"},{"line_number":22,"context_line":"flexible when adapting the driver to work with different types of"},{"line_number":23,"context_line":"systems (hopefully we will only need to change the library underneath)."},{"line_number":24,"context_line":"Which, at the end is how Redfish is meant to be used [2], we should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a1ff146_2aaddb31","line":21,"updated":"2017-03-14 14:47:43.000000000","message":"http://redfish.dmtf.org/schemas/DSP0266_1.1.html#uris splits URIs into *three* sections: would it make sense to match that?","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"65bbe52602cd63ab11292523302809bf57f55c4d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"which may lead to some implementations to call /Systems (as we call it in"},{"line_number":19,"context_line":"this specification) /Nodes or any other variant. Therefore, splitting"},{"line_number":20,"context_line":"the old proposed \"redfish_uri\" into \"redfish_root_uri\" and"},{"line_number":21,"context_line":"\"redfish_system_id\" makes more sense and hopefully will make things more"},{"line_number":22,"context_line":"flexible when adapting the driver to work with different types of"},{"line_number":23,"context_line":"systems (hopefully we will only need to change the library underneath)."},{"line_number":24,"context_line":"Which, at the end is how Redfish is meant to be used [2], we should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a1ff146_f8a9d9e0","line":21,"in_reply_to":"3a1ff146_2aaddb31","updated":"2017-03-14 15:16:01.000000000","message":"This was something that was suggested in the spec when I first proposed splitting into these two. I don\u0027t think we need the first part for anything.\n\nThe root resource is the starting point for everything we need IMHO, it contains the information about what version of redfish we will communicate with and links to resources we need.\n\nThe first part, is would be important if we wanted to discover what are the major versions of Redfish available (v1, v2 ...) but, that would add more complexity because in case there\u0027s more than one major version (and there\u0027s none at the moment btw) we would need the user to also inform us which one the driver should be use. So IMHO, it\u0027s better to the user to just point to the Root resource of whatever version he wants to use (when it\u0027s an option) and we can handle everything else from there.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"}],"specs/approved/ironic-redfish.rst":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bdef2e7af6e3cf0e068127bf0509c0fce3499425","unresolved":false,"context_lines":[{"line_number":93,"context_line":"into Ironic:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_6a2c33ac","line":96,"updated":"2017-03-14 14:47:43.000000000","message":"In http://redfish.dmtf.org/schemas/DSP0266_1.1.html#uris, the \"root service and version\" portion of the URI ends in a slash - it would be good to match that (and state that requirement explicitly, to reduce potential number-of-slashes errors).","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"16c2e7583204312c5ac323158eb848546c1b3918","unresolved":false,"context_lines":[{"line_number":93,"context_line":"into Ironic:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_ed743937","line":96,"in_reply_to":"1a1ced50_82b9d47b","updated":"2017-03-21 09:36:23.000000000","message":"Thank @Mario, @Ruby, @Dmitry by the input.\n\n\u003e Furthermore, I would have liked if you had used the terminology in the DMTF.\n\n+1\n\n\u003e I hope you don\u0027t mean that we\u0027ll fail validation is it does not end with a slash. I\u0027m strongly against being so strict to users, our driver_info is confusing enough.\n\n+1, for not enforcing a trailing slash. I don\u0027t see any reason to enforce it specially when it seems to be more about style than technical.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"511c804277844424376058a858bbf0744ab78e69","unresolved":false,"context_lines":[{"line_number":93,"context_line":"into Ironic:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_82b9d47b","line":96,"in_reply_to":"1a1ced50_c4276e10","updated":"2017-03-21 09:23:53.000000000","message":"\u003e \"the root_uri always ends in a slash\" strikes me as a nice invariant to maintain\n\nI hope you don\u0027t mean that we\u0027ll fail validation is it does not end with a slash. I\u0027m strongly against being so strict to users, our driver_info is confusing enough.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b358d386dd63c7fd8dca2c236c03ae2574eef499","unresolved":false,"context_lines":[{"line_number":93,"context_line":"into Ironic:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_7ccf1829","line":96,"in_reply_to":"1a1ced50_c4276e10","updated":"2017-03-21 10:23:16.000000000","message":"\u003e I think Miles has a good point. We should update this spec with the correct URI; it should end with a slash because it isn\u0027t a resource itself. Whether in this patch or a follow up.\n\nI don\u0027t think that\u0027s correct, the https://.../redfish/v1/Systems *is* a resource, it\u0027s a collection resource [0][1] just like https://.../redfish/v1/Systems/blah is a singleton resource.\n\n[0] http://redfish.dmtf.org/schemas/v1/ComputerSystemCollection.json\n\n[1] https://www.thoughtworks.com/insights/blog/rest-api-design-resource-modeling","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6a221b94a52a1438bbb9d7861a53d5adb2ad3ccd","unresolved":false,"context_lines":[{"line_number":93,"context_line":"into Ironic:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_c4276e10","line":96,"in_reply_to":"1a1ced50_ccb87ae8","updated":"2017-03-20 21:18:08.000000000","message":"I think Miles has a good point. We should update this spec with the correct URI; it should end with a slash because it isn\u0027t a resource itself. Whether in this patch or a follow up.\n\nFurthermore, I would have liked if you had used the terminology in the DMTF. I quote:\n\n\"The first part includes the scheme and authority portions of the URI. The second part includes the root service and version. The third part is a unique resource identifier.\"\n\nSo the description for \u0027redfish_root_uri\u0027 might be better as something like\n\nThe Redfish URI that includes the root service and version in the format: \u003cscheme\u003e://\u003cauthority portion\u003e/\u003croot service\u003e/\u003cversion\u003e/\n\nFor example, \u0027https://mgmt.vendor.com/redfish/v1/\u0027.\n\nBTW, why the focus on \u003cIP\u003e:\u003cPORT\u003e?","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"4a45a6370f17a689711ccbd778845137dc0d23cd","unresolved":false,"context_lines":[{"line_number":93,"context_line":"into Ironic:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_ccb87ae8","line":96,"in_reply_to":"3a1ff146_337472ce","updated":"2017-03-20 18:40:26.000000000","message":"I think this can be addressed in the implementation.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"65bbe52602cd63ab11292523302809bf57f55c4d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"into Ironic:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_f82479b0","line":96,"in_reply_to":"3a1ff146_6a2c33ac","updated":"2017-03-14 15:16:01.000000000","message":"Fair, tho it\u0027s just an example","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"7e1734662bdb5394353b1c03d455f302def02251","unresolved":false,"context_lines":[{"line_number":93,"context_line":"into Ironic:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_337472ce","line":96,"in_reply_to":"3a1ff146_f82479b0","updated":"2017-03-14 15:52:47.000000000","message":"Sure, but \"the root_uri always ends in a slash\" strikes me as a nice invariant to maintain, so URI-generation code can be simple and consistent.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bdef2e7af6e3cf0e068127bf0509c0fce3499425","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_0a0c9f41","line":98,"updated":"2017-03-14 14:47:43.000000000","message":"It would be good to give an example here, and explicitly state that redfish_root_uri + redfish_system_id forms a valid URI for the System in question.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"511c804277844424376058a858bbf0744ab78e69","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_623938f2","line":98,"in_reply_to":"1a1ced50_32370ee5","updated":"2017-03-21 09:23:53.000000000","message":"\u003e redfish_system_id contains the \"unique identifier part\" of the URI\n\nIt seems to be not in spirit of the standard, and how API are commonly designed. E.g. when you work with Ironic API, you rely on node UUID, not on \"nodes/UUID\".","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6b59f53334aad4e6e572dbb3be00f4f31226bb42","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_f599896f","line":98,"in_reply_to":"1a1ced50_32370ee5","updated":"2017-03-20 13:33:42.000000000","message":"I\u0027m not sure if I like the proposal because I think a better approach would be the library to figure out what\u0027s the URL to the resource collection (.../Systems OR ../Nodes OR etc...). \n\n\u003e * you can get the full URI of the System by simply concatenating the two;\n\nThat\u0027s nice, but I think it\u0027s puts more effort on operators to figure that out and for the Ironic driver itself, that\u0027s irrelevant (assuming the library will take care of figuring it out).\n\n\u003e * the value of redfish_system_id is guaranteed to be unique (within the redfish manager) by the spec;\n\nThe identifier bit itself is the only unique part of that URL (and the one we require in this patch).\n\nInstead of \u0027/redfish/v1/Systems/2\u0027 only \u00272\u0027 is the unique bit.\n\n\u003e * Sushy does not need to know or care what different vendors call the collection of managed nodes.\n\nWell it actually does. There\u0027s much more to figure out from one vendor to another than the URL to that resource collection (e.g: What actions are supported, like reset system; the URL for those actions; what are the allowed values for such actions; attributes about the system in general; etc...)","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"5a0cd1ff99e09ff0c74d4ad25933d8663ba66c54","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_b8f18603","line":98,"in_reply_to":"1a1ced50_623938f2","updated":"2017-03-21 17:19:00.000000000","message":"It\u0027s not in the spirit of OpenStack APIs, but it is in the spirit of HATEOAS-style APIs, in which resources are identified by their URIs. AFAICT the Redfish API is designed in HATEOAS style.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"6090cbd6ec8e3b0b5c3a86a9da00af6bcd65a27d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_32370ee5","line":98,"in_reply_to":"1a1ced50_97d27433","updated":"2017-03-16 17:52:34.000000000","message":"On second thoughts... the quote in my previous comment argues for the following split:\n\n    redfish_root_uri \u003d \u0027http://path-to-my-redfish-manager\u0027\n    redfish_system_id \u003d \u0027/redfish/v1/Systems/2\u0027\n\nIn other words, redfish_system_id contains the \"unique identifier part\" of the URI. This means\n\n- you can get the full URI of the System by simply concatenating the two;\n- the value of redfish_system_id is guaranteed to be unique (within the redfish manager) by the spec;\n- Sushy does not need to know or care what different vendors call the collection of managed nodes.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"5a0cd1ff99e09ff0c74d4ad25933d8663ba66c54","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_b8a98692","line":98,"in_reply_to":"1a1ced50_f599896f","updated":"2017-03-21 17:19:00.000000000","message":"\u003e Instead of \u0027/redfish/v1/Systems/2\u0027 only \u00272\u0027 is the unique bit.\n\nThe \"2\" part is not guaranteed to be unique by the spec, but the whole thing is. It may be that the \"2\" part is enough to uniquely specify a node, but *we don\u0027t know that*. And if it *is* enough to uniquely specify a node, any longer part of the URI containing it will also be enough to uniquely specify a node. There\u0027s no need to find a minimal-length unique representation; uniqueness is enough for an identifier.\n\n\u003e There\u0027s much more to figure out from one vendor to another than the URL to that resource collection\n\nSure, but why give yourself extra work?","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"4a45a6370f17a689711ccbd778845137dc0d23cd","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_2ca10ea4","line":98,"in_reply_to":"1a1ced50_f599896f","updated":"2017-03-20 18:40:26.000000000","message":"I think this is addressed by the commit message. I\u0027d expect that the implementation and documentation addresses this more clearly. IMHO this is fine for the spec.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"65bbe52602cd63ab11292523302809bf57f55c4d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_d86dfdcd","line":98,"in_reply_to":"3a1ff146_0a0c9f41","updated":"2017-03-14 15:16:01.000000000","message":"Hmm I think it\u0027s kinda complicated to word. But the redfish_root_uri + redfish_system_id will not form a valid URI for the System.\n\nThe root URI is something like http://example.com/redfish/v1 and a System ID is just the name of the system, for example: \"FAKE\"\n\nhttp://example.com/redfish/v1/\u003cresource-name\u003e/FAKE, the \u003cresource-name\u003e is the problem and that\u0027s what the library should we use (sushy) should deals with converting from different redfish controllers to make it transparent for the driver in Ironic.\n\nI\u0027m open for suggestion about how to better word this, but, I think it\u0027s something that can be done in the documentation of the driver instead of here. As long as people understand what\u0027s being proposed here.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ecb457dd145090648e292c8aa3cd9ceb3e6b6b00","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_d99edf06","line":98,"in_reply_to":"3a1ff146_99b547d2","updated":"2017-03-14 16:21:08.000000000","message":"\u003e It would be good to give an example here, and explicitly state that redfish_root_uri + redfish_system_id forms a valid URI for the System in question.\n\nThis is not correct.\n\n\u003e giving redfish_system_ids like \"System/5\" rather than \"5\"\n\nI don\u0027t think this is correct either. An ID is \"5\". \"System/5\" implies URL structure, and may be not compatible with the approach of walking up the tree structure from the root (which is what python-redfish does). It should match whatever ID field a Redfish System object has, which is probably \"1\", not \"System/1\".","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"f06913e2100a2b7b7194343fe983d62afd057021","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_97d27433","line":98,"in_reply_to":"3a1ff146_99b547d2","updated":"2017-03-16 17:43:22.000000000","message":"I would be totally in favour of storing the whole URI.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"7e1734662bdb5394353b1c03d455f302def02251","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_dec965ae","line":98,"in_reply_to":"3a1ff146_d86dfdcd","updated":"2017-03-14 15:52:47.000000000","message":"\"As long as people understand what\u0027s being proposed here.\"\n\nClearly I didn\u0027t understand! I thought the point was that \u003cresource-name\u003e was not predictable, so we should store it as part of redfish_system_id (giving redfish_system_ids like \"System/5\" rather than \"5\"). This would allow for maximum flexibility while keeping our code simple and easily-understood.\n\nAFAICT the user will learn a system_id in one of two ways:\n\n1) by querying the BMC for a list of attached systems (in which case you\u0027ll get back a URI),\n2) by composing a system. According to http://redfish.dmtf.org/schemas/DSP0266_1.1.html#create-post-, the Redfish manager is allowed to ignore any user-specified ID but is required to set the Location header to the URI of the newly-created resource, so again you\u0027ll get back a full URI.\n\nSo I don\u0027t think we need to worry about saving operators from typing in \"System/\".\n\nEither way, an example here would make it much clearer what you mean.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"f06913e2100a2b7b7194343fe983d62afd057021","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_5720fcf7","line":98,"in_reply_to":"3a1ff146_d99edf06","updated":"2017-03-16 17:43:22.000000000","message":"From http://redfish.dmtf.org/schemas/DSP0266_1.1.html#uris:\n\n    The scheme and authority part of the URI shall not be considered part of the\n    unique identifier of the resource... The remainder of the URI (the service and\n    resource paths) is what uniquely identifies the resource, and this is what is\n    returned in all Redfish payloads.\n\n    The unique identifier part of a URI shall be unique within the implementation.\n\nSo \"5\" is not sufficient as an identifier - it\u0027s not guaranteed to be unique within a given Redfish manager. But the string that *is* guaranteed to be unique must have the structure of part of a URI.\n\nAlso, if I\u0027m reading Wan-yen Hsu\u0027s comments on https://review.openstack.org/#/c/184653/ correctly, we may see both /Systems/5 and /Nodes/5 on the same Redfish manager! So we can\u0027t rely on Sushy to correctly determine the \u003cresource-name\u003e in all cases.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e3cc5f82fc92e84d1924c150878a3af88ec68141","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_68441f74","line":98,"in_reply_to":"3a1ff146_d99edf06","updated":"2017-03-15 06:33:07.000000000","message":"To add on, generally the identifier \"1\" or \"5\" in this case is not fixed. It may vary as per system.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d6d2dc6ba2fe5c0f46b392b7ec2eafad92caf5eb","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    * redfish_root_uri: The URI to the Redfish Root resource"},{"line_number":96,"context_line":"                        (e.g.: http(s)://\u003cIP\u003e:\u003cPORT\u003e/redfish/v1)."},{"line_number":97,"context_line":"    * redfish_system_id: The identifier of the Redfish System resource that"},{"line_number":98,"context_line":"                         the driver will interact with."},{"line_number":99,"context_line":"    * redfish_username: User account with admin/server-profile access privilege"},{"line_number":100,"context_line":"    * redfish_password: User account password"},{"line_number":101,"context_line":"    * redfish_verify_ca: this property contains either a boolean value,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a1ff146_99b547d2","line":98,"in_reply_to":"3a1ff146_dec965ae","updated":"2017-03-14 16:15:28.000000000","message":"I think that leads us to the initial proposal which is to just pass the direct URI to the System resource in Redfish that the Ironic driver will manage.\n\nWhich may be better than splitting in two properties as you are proposing because, since we know that /redfish/v1 must be part of the URI it\u0027s easier for us to just parse the URI by looking at \"/redfish/v1\" string and assuming that what comes next is the ID \"Systems/1\" or \"/Nodes/1\" (or others) in a single property.\n\nThe idea of the split was so we can make the configuration of the Ironic driver agnostic to such variations and let the code (in this case in the library) to transparently handle it for us.\n\nI think I\u0027m indifferent about one approach or the other. But let\u0027s see what other people think.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6a221b94a52a1438bbb9d7861a53d5adb2ad3ccd","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Work Items"},{"line_number":141,"context_line":"----------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Add a new ``redfish`` hardware type, power and management interfaces."},{"line_number":144,"context_line":"* Write unit-tests for the new code."},{"line_number":145,"context_line":"* Modify the Ironic DevStack module to setup a virtual environment that"},{"line_number":146,"context_line":"  is able to test nodes using the new Redfish driver."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_04a186a3","line":143,"updated":"2017-03-20 21:18:08.000000000","message":"Sigh. There is nothing about that indicates this is what is being added :-(\n\nI would have been curious to know what the enabled interfaces \u0026 default interfaces would have been for this new redfish hardware type.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"511c804277844424376058a858bbf0744ab78e69","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Work Items"},{"line_number":141,"context_line":"----------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Add a new ``redfish`` hardware type, power and management interfaces."},{"line_number":144,"context_line":"* Write unit-tests for the new code."},{"line_number":145,"context_line":"* Modify the Ironic DevStack module to setup a virtual environment that"},{"line_number":146,"context_line":"  is able to test nodes using the new Redfish driver."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_a227b0c8","line":143,"in_reply_to":"1a1ced50_04a186a3","updated":"2017-03-21 09:23:53.000000000","message":"I find it quite obvious, but dunno. If you feel like.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"16c2e7583204312c5ac323158eb848546c1b3918","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Work Items"},{"line_number":141,"context_line":"----------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Add a new ``redfish`` hardware type, power and management interfaces."},{"line_number":144,"context_line":"* Write unit-tests for the new code."},{"line_number":145,"context_line":"* Modify the Ironic DevStack module to setup a virtual environment that"},{"line_number":146,"context_line":"  is able to test nodes using the new Redfish driver."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_ada5e1a2","line":143,"in_reply_to":"1a1ced50_a227b0c8","updated":"2017-03-21 09:36:23.000000000","message":"Sure, I will update the proposed changes to include those.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6a221b94a52a1438bbb9d7861a53d5adb2ad3ccd","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Dependencies"},{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":151,"context_line":"This driver requires either that python-redfish or sushy installed on the"},{"line_number":152,"context_line":"conductor node."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_44bb7ee5","line":151,"updated":"2017-03-20 21:18:08.000000000","message":"so what you\u0027re saying is that BOTH sushy AND python-redfish will work with this driver?","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"511c804277844424376058a858bbf0744ab78e69","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Dependencies"},{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":151,"context_line":"This driver requires either that python-redfish or sushy installed on the"},{"line_number":152,"context_line":"conductor node."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_a20ed038","line":151,"in_reply_to":"1a1ced50_44bb7ee5","updated":"2017-03-21 09:23:53.000000000","message":"Bad wording, I think. Should be changed to something like \"Right now the driver requires sushy library, we may switch to python-redfish in the near future without changing the public interface.\"","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"16c2e7583204312c5ac323158eb848546c1b3918","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Dependencies"},{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":151,"context_line":"This driver requires either that python-redfish or sushy installed on the"},{"line_number":152,"context_line":"conductor node."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_8db3c5e8","line":151,"in_reply_to":"1a1ced50_a20ed038","updated":"2017-03-21 09:36:23.000000000","message":"Yeah, bad wording indeed. As @Dmitry pointed out.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6a221b94a52a1438bbb9d7861a53d5adb2ad3ccd","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Documentation Impact"},{"line_number":168,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":169,"context_line":"* Updating Ironic documentation section _`Enabling Drivers`:"},{"line_number":170,"context_line":"  http://docs.openstack.org/developer/ironic/deploy/drivers.html with Redfish"},{"line_number":171,"context_line":"  related instructions."},{"line_number":172,"context_line":"* Updating Ironic install-guide documentation section"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_84101603","line":169,"updated":"2017-03-20 21:18:08.000000000","message":"this is formatted incorrectly; was the intent to just show \u0027Enabling Drivers\u0027 ? Cuz it also shows the link.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"16c2e7583204312c5ac323158eb848546c1b3918","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Documentation Impact"},{"line_number":168,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":169,"context_line":"* Updating Ironic documentation section _`Enabling Drivers`:"},{"line_number":170,"context_line":"  http://docs.openstack.org/developer/ironic/deploy/drivers.html with Redfish"},{"line_number":171,"context_line":"  related instructions."},{"line_number":172,"context_line":"* Updating Ironic install-guide documentation section"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_cdc93d5b","line":169,"in_reply_to":"1a1ced50_84101603","updated":"2017-03-21 09:36:23.000000000","message":"Done","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6a221b94a52a1438bbb9d7861a53d5adb2ad3ccd","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  http://docs.openstack.org/developer/ironic/deploy/drivers.html with Redfish"},{"line_number":171,"context_line":"  related instructions."},{"line_number":172,"context_line":"* Updating Ironic install-guide documentation section"},{"line_number":173,"context_line":"  _`Setup the drivers for the Bare Metal service`:"},{"line_number":174,"context_line":"  http://docs.openstack.org/project-install-guide/baremetal/draft/setup-drivers.html"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_040506bb","line":173,"updated":"2017-03-20 21:18:08.000000000","message":"ditto","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"16c2e7583204312c5ac323158eb848546c1b3918","unresolved":false,"context_lines":[{"line_number":170,"context_line":"  http://docs.openstack.org/developer/ironic/deploy/drivers.html with Redfish"},{"line_number":171,"context_line":"  related instructions."},{"line_number":172,"context_line":"* Updating Ironic install-guide documentation section"},{"line_number":173,"context_line":"  _`Setup the drivers for the Bare Metal service`:"},{"line_number":174,"context_line":"  http://docs.openstack.org/project-install-guide/baremetal/draft/setup-drivers.html"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_edc27933","line":173,"in_reply_to":"1a1ced50_040506bb","updated":"2017-03-21 09:36:23.000000000","message":"Done","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6a221b94a52a1438bbb9d7861a53d5adb2ad3ccd","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"_`Redfish DMTF`: http://www.dmtf.org/standards/redfish"},{"line_number":180,"context_line":"_`python-redfish`: https://github.com/openstack/python-redfish"},{"line_number":181,"context_line":"_`sushy`: https://github.com/openstack/sushy"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_24bbe20f","line":181,"updated":"2017-03-20 21:18:08.000000000","message":"outside the scope, so I\u0027ll update it if you don\u0027t. This isn\u0027t formatted properly.","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"16c2e7583204312c5ac323158eb848546c1b3918","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"_`Redfish DMTF`: http://www.dmtf.org/standards/redfish"},{"line_number":180,"context_line":"_`python-redfish`: https://github.com/openstack/python-redfish"},{"line_number":181,"context_line":"_`sushy`: https://github.com/openstack/sushy"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_2ddf310e","line":181,"in_reply_to":"1a1ced50_24bbe20f","updated":"2017-03-21 09:36:23.000000000","message":"Done","commit_id":"4136b458a0922e6113d3e45391c0d15a8b66c701"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4508ed9a966c0bffd039fece2df564cd9792f233","unresolved":false,"context_lines":[{"line_number":163,"context_line":"Dependencies"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":"The new ``redfish`` power and management interfaces will require the"},{"line_number":166,"context_line":"`sushy`_ library to be installed on the conductor node."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Testing"},{"line_number":169,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a1ced50_7fe54ada","line":166,"updated":"2017-03-21 10:40:31.000000000","message":"Note, the reason why I didn\u0027t mention python-redfish here is because it\u0027s not a dependency for this spec as-is and IMHO would just causes confusion (as per comments on the previous patch-set). The mention about switching libraries in the future is stated in the \"Proposed changes\" section.","commit_id":"9d23873263ad5e2d6c12691c4653458df428f40e"},{"author":{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},"change_message_id":"caf3c2de495f70c1c0032bf9fe21d5ed3c5a3158","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526477"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This specification proposes the addition of a new driver in order to support"},{"line_number":14,"context_line":"Ironic deployment on Redfish compliant servers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_a7388bf0","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":6},"updated":"2017-03-21 16:36:00.000000000","message":"s/Ironic/ironic","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2665beda117226b5e04821f23c3b8d09ade508c4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526477"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This specification proposes the addition of a new driver in order to support"},{"line_number":14,"context_line":"Ironic deployment on Redfish compliant servers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_b06c1609","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":6},"in_reply_to":"1a1ced50_827b7df4","updated":"2017-03-22 14:34:21.000000000","message":"Done","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"98b7879cf960ac6b84d57fefb6665ff9f8074883","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526477"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This specification proposes the addition of a new driver in order to support"},{"line_number":14,"context_line":"Ironic deployment on Redfish compliant servers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_827b7df4","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":6},"in_reply_to":"1a1ced50_a7388bf0","updated":"2017-03-21 17:17:41.000000000","message":"as a FYI, there is no rule in specs about the project name being lower cased.\n\nThat rule is from the docs people, and it only applies to (end) user-facing documents, not documents meant for us/developers.","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},"change_message_id":"caf3c2de495f70c1c0032bf9fe21d5ed3c5a3158","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This spec proposes adding a new ``redfish`` hardware type, power and"},{"line_number":28,"context_line":"management interfaces. None of wich will be enabled by default."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The new interfaces will use the `sushy`_ library in order to handle the"},{"line_number":31,"context_line":"communication between the driver and the Redfish controller. This library"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_e744431c","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":35},"updated":"2017-03-21 16:36:00.000000000","message":"s/wich/which","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2665beda117226b5e04821f23c3b8d09ade508c4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This spec proposes adding a new ``redfish`` hardware type, power and"},{"line_number":28,"context_line":"management interfaces. None of wich will be enabled by default."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The new interfaces will use the `sushy`_ library in order to handle the"},{"line_number":31,"context_line":"communication between the driver and the Redfish controller. This library"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_70661e2b","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":35},"in_reply_to":"1a1ced50_e744431c","updated":"2017-03-22 14:34:21.000000000","message":"Done","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"98b7879cf960ac6b84d57fefb6665ff9f8074883","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The new interfaces will use the `sushy`_ library in order to handle the"},{"line_number":31,"context_line":"communication between the driver and the Redfish controller. This library"},{"line_number":32,"context_line":"may be switched to `python-redfish`_ in the future after re-evaluation"},{"line_number":33,"context_line":"by the Ironic community. There will be no need to change any public"},{"line_number":34,"context_line":"interface when/if this change of libraries occur."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_b4019c6c","line":32,"updated":"2017-03-21 17:17:41.000000000","message":"I would start a new paragraph with \u0027This library may be switched... \u0027.","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2665beda117226b5e04821f23c3b8d09ade508c4","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The new interfaces will use the `sushy`_ library in order to handle the"},{"line_number":31,"context_line":"communication between the driver and the Redfish controller. This library"},{"line_number":32,"context_line":"may be switched to `python-redfish`_ in the future after re-evaluation"},{"line_number":33,"context_line":"by the Ironic community. There will be no need to change any public"},{"line_number":34,"context_line":"interface when/if this change of libraries occur."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_f0b3ee95","line":32,"in_reply_to":"1a1ced50_b4019c6c","updated":"2017-03-22 14:34:21.000000000","message":"Done","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"98b7879cf960ac6b84d57fefb6665ff9f8074883","unresolved":false,"context_lines":[{"line_number":31,"context_line":"communication between the driver and the Redfish controller. This library"},{"line_number":32,"context_line":"may be switched to `python-redfish`_ in the future after re-evaluation"},{"line_number":33,"context_line":"by the Ironic community. There will be no need to change any public"},{"line_number":34,"context_line":"interface when/if this change of libraries occur."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Note that no OEM specific extension will be supported."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_d46ff828","line":34,"updated":"2017-03-21 17:17:41.000000000","message":"instead of this last sentence, how about something like\n\nThe switch to `python-redfish`_ is outside the scope of this specification, but it should not cause any public interface to be changed. It would most likely involve code changes and new configuration options.","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2665beda117226b5e04821f23c3b8d09ade508c4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"communication between the driver and the Redfish controller. This library"},{"line_number":32,"context_line":"may be switched to `python-redfish`_ in the future after re-evaluation"},{"line_number":33,"context_line":"by the Ironic community. There will be no need to change any public"},{"line_number":34,"context_line":"interface when/if this change of libraries occur."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Note that no OEM specific extension will be supported."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_10afaa2a","line":34,"in_reply_to":"1a1ced50_d46ff828","updated":"2017-03-22 14:34:21.000000000","message":"Done\n\nThanks for the suggestion","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},"change_message_id":"caf3c2de495f70c1c0032bf9fe21d5ed3c5a3158","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Other deployer impact"},{"line_number":91,"context_line":"---------------------"},{"line_number":92,"context_line":"The following driver_info fields are required while enrolling nodes"},{"line_number":93,"context_line":"into Ironic:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * ``redfish_root_uri``: The Redfish URI that includes the root"},{"line_number":96,"context_line":"      service and version in the format: \u003cscheme\u003e://\u003cauthority"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_a71fab6a","line":93,"range":{"start_line":93,"start_character":5,"end_line":93,"end_character":11},"updated":"2017-03-21 16:36:00.000000000","message":"s/Ironic/ironic","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2665beda117226b5e04821f23c3b8d09ade508c4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Other deployer impact"},{"line_number":91,"context_line":"---------------------"},{"line_number":92,"context_line":"The following driver_info fields are required while enrolling nodes"},{"line_number":93,"context_line":"into Ironic:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * ``redfish_root_uri``: The Redfish URI that includes the root"},{"line_number":96,"context_line":"      service and version in the format: \u003cscheme\u003e://\u003cauthority"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_8477df9e","line":93,"range":{"start_line":93,"start_character":5,"end_line":93,"end_character":11},"in_reply_to":"1a1ced50_a71fab6a","updated":"2017-03-22 14:34:21.000000000","message":"Done","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},"change_message_id":"caf3c2de495f70c1c0032bf9fe21d5ed3c5a3158","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * ``redfish_root_uri``: The Redfish URI that includes the root"},{"line_number":96,"context_line":"      service and version in the format: \u003cscheme\u003e://\u003cauthority"},{"line_number":97,"context_line":"      portion\u003e/\u003croot service\u003e/\u003cversion\u003e/.  For example,"},{"line_number":98,"context_line":"      \u0027https://mgmt.vendor.com/redfish/v1/\u0027."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    * ``redfish_system_id``: The identifier of the Redfish System resource"},{"line_number":101,"context_line":"      that the driver will interact with."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_a2bdd9b8","line":98,"range":{"start_line":97,"start_character":55,"end_line":98,"end_character":44},"updated":"2017-03-21 16:36:00.000000000","message":"This could be written as  For example:https://mgmt.vendor.com/redfish/v1/\nOtherwise rst file take it as hyper link.","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2665beda117226b5e04821f23c3b8d09ade508c4","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    * ``redfish_root_uri``: The Redfish URI that includes the root"},{"line_number":96,"context_line":"      service and version in the format: \u003cscheme\u003e://\u003cauthority"},{"line_number":97,"context_line":"      portion\u003e/\u003croot service\u003e/\u003cversion\u003e/.  For example,"},{"line_number":98,"context_line":"      \u0027https://mgmt.vendor.com/redfish/v1/\u0027."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    * ``redfish_system_id``: The identifier of the Redfish System resource"},{"line_number":101,"context_line":"      that the driver will interact with."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_e40b3322","line":98,"range":{"start_line":97,"start_character":55,"end_line":98,"end_character":44},"in_reply_to":"1a1ced50_a2bdd9b8","updated":"2017-03-22 14:34:21.000000000","message":"Like without a space between the \":\" and \"http://...\" idk, I don\u0027t like that.\n\nThis is just a spec and that URL is just an example, it\u0027s not an \"official\" documentation for redfish or anything like that.","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"98b7879cf960ac6b84d57fefb6665ff9f8074883","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Note, the reason why we have a ``redfish_root_uri`` and"},{"line_number":117,"context_line":"``redfish_system_id`` separated in two options instead of a unique option"},{"line_number":118,"context_line":"pointing the full URI of the System resource is to make the configurations"},{"line_number":119,"context_line":"in Ironic vendor agnostic. Unfortunately the Redfish specification"},{"line_number":120,"context_line":"isn\u0027t very opinionated regarding the names of the resources which"},{"line_number":121,"context_line":"may lead to some implementations to call it ``/Systems`` or ``/Nodes``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_f4015439","line":118,"updated":"2017-03-21 17:17:41.000000000","message":"maybe \u0027instead of having one option with the full URI\u0027","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"788507553ddd8f9dd918250fe97fc875a4742ffb","unresolved":false,"context_lines":[{"line_number":120,"context_line":"isn\u0027t very opinionated regarding the names of the resources which"},{"line_number":121,"context_line":"may lead to some implementations to call it ``/Systems`` or ``/Nodes``"},{"line_number":122,"context_line":"(or any other variant); that would require the Ironic driver to be aware"},{"line_number":123,"context_line":"of such differences when parsing the URI if the single option design was"},{"line_number":124,"context_line":"chosen. Therefore, the split is an attempt to make things more generic in"},{"line_number":125,"context_line":"Ironic and let to the library communicating with the Redfish controller"},{"line_number":126,"context_line":"to handle those variations transparently for us."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_7801ce04","line":123,"updated":"2017-03-21 17:09:13.000000000","message":"Why does ironic need to parse the URI? Why can\u0027t ironic use the full \"unique identifier part\" (which the Redfish spec guarantees to be unique and which is included in every response) as its internal identifier for the node? This is just going to be kept in driver_info, so it doesn\u0027t matter if it doesn\u0027t look like a conventional identifier.","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"98b7879cf960ac6b84d57fefb6665ff9f8074883","unresolved":false,"context_lines":[{"line_number":122,"context_line":"(or any other variant); that would require the Ironic driver to be aware"},{"line_number":123,"context_line":"of such differences when parsing the URI if the single option design was"},{"line_number":124,"context_line":"chosen. Therefore, the split is an attempt to make things more generic in"},{"line_number":125,"context_line":"Ironic and let to the library communicating with the Redfish controller"},{"line_number":126,"context_line":"to handle those variations transparently for us."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"The following new configuration variables are proposed (and their default"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_743804f0","line":125,"updated":"2017-03-21 17:17:41.000000000","message":"s/let to the/left to the/ ?","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"788507553ddd8f9dd918250fe97fc875a4742ffb","unresolved":false,"context_lines":[{"line_number":123,"context_line":"of such differences when parsing the URI if the single option design was"},{"line_number":124,"context_line":"chosen. Therefore, the split is an attempt to make things more generic in"},{"line_number":125,"context_line":"Ironic and let to the library communicating with the Redfish controller"},{"line_number":126,"context_line":"to handle those variations transparently for us."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"The following new configuration variables are proposed (and their default"},{"line_number":129,"context_line":"values) to be added to the conductor variable group:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_7828ee86","line":126,"updated":"2017-03-21 17:09:13.000000000","message":"I think any code in Sushy that tries to guess whether to use /Systems or /Nodes or /Boxes is quickly going to become a brittle pile of unmaintainable heuristics, and it would be much simpler all round to just store it as part of the identifier.","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2665beda117226b5e04821f23c3b8d09ade508c4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"of such differences when parsing the URI if the single option design was"},{"line_number":124,"context_line":"chosen. Therefore, the split is an attempt to make things more generic in"},{"line_number":125,"context_line":"Ironic and let to the library communicating with the Redfish controller"},{"line_number":126,"context_line":"to handle those variations transparently for us."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"The following new configuration variables are proposed (and their default"},{"line_number":129,"context_line":"values) to be added to the conductor variable group:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_e4597336","line":126,"in_reply_to":"1a1ced50_1820da47","updated":"2017-03-22 14:34:21.000000000","message":"+1 Yeah, probably I will remove this whole paragraph or reword it entirely according to what was discussed on IRC.","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"98b7879cf960ac6b84d57fefb6665ff9f8074883","unresolved":false,"context_lines":[{"line_number":123,"context_line":"of such differences when parsing the URI if the single option design was"},{"line_number":124,"context_line":"chosen. Therefore, the split is an attempt to make things more generic in"},{"line_number":125,"context_line":"Ironic and let to the library communicating with the Redfish controller"},{"line_number":126,"context_line":"to handle those variations transparently for us."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"The following new configuration variables are proposed (and their default"},{"line_number":129,"context_line":"values) to be added to the conductor variable group:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_1820da47","line":126,"in_reply_to":"1a1ced50_7828ee86","updated":"2017-03-21 17:17:41.000000000","message":"Agreed. We discussed in irc a bit today [1] [2]. I can help with the naming since i love to bike shed, after we decide what the field(s) might be that are needed. Whatever we decide, we should link to the appropriate sections in the dmtf doc.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-03-21.log.html#t2017-03-21T14:42:48\n\n[2] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-03-21.log.html#t2017-03-21T16:36:08","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},"change_message_id":"caf3c2de495f70c1c0032bf9fe21d5ed3c5a3158","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Documentation Impact"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":"* Updating Ironic documentation section `Enabling Drivers"},{"line_number":188,"context_line":"  \u003chttp://docs.openstack.org/developer/ironic/deploy/drivers.html\u003e`_"},{"line_number":189,"context_line":"  with Redfish related instructions."},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_07d15f23","line":187,"range":{"start_line":187,"start_character":11,"end_line":187,"end_character":17},"updated":"2017-03-21 16:36:00.000000000","message":"s/Ironic/ironic","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2665beda117226b5e04821f23c3b8d09ade508c4","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Documentation Impact"},{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":"* Updating Ironic documentation section `Enabling Drivers"},{"line_number":188,"context_line":"  \u003chttp://docs.openstack.org/developer/ironic/deploy/drivers.html\u003e`_"},{"line_number":189,"context_line":"  with Redfish related instructions."},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_2440eb33","line":187,"range":{"start_line":187,"start_character":11,"end_line":187,"end_character":17},"in_reply_to":"1a1ced50_07d15f23","updated":"2017-03-22 14:34:21.000000000","message":"Done","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},"change_message_id":"caf3c2de495f70c1c0032bf9fe21d5ed3c5a3158","unresolved":false,"context_lines":[{"line_number":188,"context_line":"  \u003chttp://docs.openstack.org/developer/ironic/deploy/drivers.html\u003e`_"},{"line_number":189,"context_line":"  with Redfish related instructions."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"* Updating Ironic install-guide documentation section"},{"line_number":192,"context_line":"  `Setup the drivers for the Bare Metal service"},{"line_number":193,"context_line":"  \u003chttp://docs.openstack.org/project-install-guide/baremetal/draft/setup-drivers.html\u003e`_."},{"line_number":194,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_87a38fb1","line":191,"range":{"start_line":191,"start_character":11,"end_line":191,"end_character":17},"updated":"2017-03-21 16:36:00.000000000","message":"s/Ironic/ironic","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2665beda117226b5e04821f23c3b8d09ade508c4","unresolved":false,"context_lines":[{"line_number":188,"context_line":"  \u003chttp://docs.openstack.org/developer/ironic/deploy/drivers.html\u003e`_"},{"line_number":189,"context_line":"  with Redfish related instructions."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"* Updating Ironic install-guide documentation section"},{"line_number":192,"context_line":"  `Setup the drivers for the Bare Metal service"},{"line_number":193,"context_line":"  \u003chttp://docs.openstack.org/project-install-guide/baremetal/draft/setup-drivers.html\u003e`_."},{"line_number":194,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_64466350","line":191,"range":{"start_line":191,"start_character":11,"end_line":191,"end_character":17},"in_reply_to":"1a1ced50_87a38fb1","updated":"2017-03-22 14:34:21.000000000","message":"Done","commit_id":"b540576a4bc9f10935d08148ed902cf81187fc88"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5f6c8aa9186daddebe077abef66c5441c2cf795d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    * ``redfish_system_id``: The canonical path to the System resource"},{"line_number":103,"context_line":"      that the driver will interact with. It should include the root"},{"line_number":104,"context_line":"      service, version and the unique resource path to the System. For"},{"line_number":105,"context_line":"      example: /redfish/v1/Systems/1"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    * ``redfish_username``: User account with admin/server-profile"},{"line_number":108,"context_line":"      access privilege"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a1ced50_d37512cb","line":105,"updated":"2017-03-22 17:48:10.000000000","message":"http://redfish.dmtf.org/schemas/DSP0266_1.1.html#resource-identifier-property mentions that \"Resources identifiers shall be represented in JSON payloads as strings that conform to the rules for URI paths\". That is what this value is, right? The resource identifier? Which makes me think that something like \u0027redfish_resource_id\u0027 might be more consistent naming.\n\nAlso, it mentions that \"Resources within the same authority as the request URI shall be represented .... That is, they shall always start with a single forward slash (\"/\"). Resources within a different authority as the request URI shall start with a double-slash (\"//\") followed by the authority and path to the resource.\"\n\nI don\u0027t think we should deal with resources within a different authority. It might work, but it might not, so let\u0027s be explicit and say that this should be a resource within the same authority and it should start with /. \n\nI also wonder if we should be explicit. I think we are assuming that redfish_address+redfish_system_id \u003d\u003d full URI, right?","commit_id":"f70fb5446c3e0827973691daa96302483b17f82c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d07beb87efab5a6b12a168e598684ac45f36fa6e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    * ``redfish_system_id``: The canonical path to the System resource"},{"line_number":103,"context_line":"      that the driver will interact with. It should include the root"},{"line_number":104,"context_line":"      service, version and the unique resource path to the System. For"},{"line_number":105,"context_line":"      example: /redfish/v1/Systems/1"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    * ``redfish_username``: User account with admin/server-profile"},{"line_number":108,"context_line":"      access privilege"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a1ced50_c1ad3cea","line":105,"in_reply_to":"1a1ced50_76f28c07","updated":"2017-03-22 18:14:32.000000000","message":"Discussed with Lucas and Nisha. the \u0027system\u0027 is short for ComputerSystem [1], which is a redfish resource. There aren\u0027t any other FooSystem resources, so we should be able to assume that \u0027system\u0027 refers to ComputerSystem. So I\u0027m good with redfish_system_id, as long as it is always documented/described as a ComputerSystem resource :)\n\n[1] http://redfish.dmtf.org/schemas/v1/ComputerSystem.v1_0_0.json#/definitions/ComputerSystem","commit_id":"f70fb5446c3e0827973691daa96302483b17f82c"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"95d78bc8e6991ffd7f0615f9c762f8a51f01e876","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    * ``redfish_system_id``: The canonical path to the System resource"},{"line_number":103,"context_line":"      that the driver will interact with. It should include the root"},{"line_number":104,"context_line":"      service, version and the unique resource path to the System. For"},{"line_number":105,"context_line":"      example: /redfish/v1/Systems/1"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    * ``redfish_username``: User account with admin/server-profile"},{"line_number":108,"context_line":"      access privilege"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a1ced50_d8a339ff","line":105,"in_reply_to":"1a1ced50_76f28c07","updated":"2017-03-23 17:18:27.000000000","message":"I\u0027m having trouble making sense of RFC 3986, but http://formvalidation.io/validators/uri/ thinks that http://example.com/redfish/v1//example.com/Systems/1 is a valid URI. On the other hand, I\u0027m not sure that the Redfish spec means that you should make requests to URIs like that: I think it might be saying that \"if @odata.id starts with two slashes, go and bother some other authority\". I think requiring the resource to be in the same authority is the right thing to do for now.","commit_id":"f70fb5446c3e0827973691daa96302483b17f82c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7185b6236b6c9e87cf081ad5ab8f3518c29f58aa","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    * ``redfish_system_id``: The canonical path to the System resource"},{"line_number":103,"context_line":"      that the driver will interact with. It should include the root"},{"line_number":104,"context_line":"      service, version and the unique resource path to the System. For"},{"line_number":105,"context_line":"      example: /redfish/v1/Systems/1"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    * ``redfish_username``: User account with admin/server-profile"},{"line_number":108,"context_line":"      access privilege"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a1ced50_76f28c07","line":105,"in_reply_to":"1a1ced50_d37512cb","updated":"2017-03-22 18:01:34.000000000","message":"\u003e http://redfish.dmtf.org/schemas/DSP0266_1.1.html#resource-identifier-property mentions that \"Resources identifiers shall be represented in JSON payloads as strings that conform to the rules for URI paths\". That is what this value is, right? The resource identifier? Which makes me think that something like \u0027redfish_resource_id\u0027 might be more consistent naming.\n\nThe reason why I don\u0027t like \u0027redfish_resource_id\u0027 is because \"resource\" is a generic term and applies to all resources within Redfish (Systems, Managers, Chassis, SystemCollection etc...). \n\nThe mapping here is between a Node (in Ironic) with a System (in Redfish), that\u0027s why I think that having \"system_id\" in the name is better, at least more specific.\n\nMakes sense ?\n\n\u003e I don\u0027t think we should deal with resources within a different authority. It might work, but it might not, so let\u0027s be explicit and say that this should be a resource within the same authority and it should start with /. \n\n++\n\n\u003e I also wonder if we should be explicit. I think we are assuming that redfish_address+redfish_system_id \u003d\u003d full URI, right?\n\nI think that\u0027s right if we limit the resource to be in the same authority, otherwise, with the double slashes I don\u0027t think it would form a valid URI. e.g: http://example.com/redfish/v1//example.com/Systems/1 doesn\u0027t looks like a valid URI for me.\n\nSo I don\u0027t know where or if we actually need a note which says that contacting both should form a valid URI.","commit_id":"f70fb5446c3e0827973691daa96302483b17f82c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0c0f8dc87a499b2c2d17bbd868f56806fbb1650c","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Redfish driver interfaces"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526477"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_7c434b13","line":8,"updated":"2017-03-22 18:41:02.000000000","message":"It seems like it is really Redfish driver and interfaces :-)","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"74b6b4723d044a30b7593178c667d26424317735","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Redfish driver interfaces"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://bugs.launchpad.net/ironic/+bug/1526477"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_1a815bfb","line":8,"in_reply_to":"1a1ced50_7c434b13","updated":"2017-03-23 10:52:46.000000000","message":"heh yeah, \"hardware type and interfaces\"","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"37fca326c9a8ca22b16955c4796173a01e8cc55a","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Other deployer impact"},{"line_number":94,"context_line":"---------------------"},{"line_number":95,"context_line":"The following driver_info fields are required while enrolling nodes"},{"line_number":96,"context_line":"into ironic:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    * ``redfish_address``: The URL address to the Redfish controller. It"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_7c7eeb6a","line":95,"range":{"start_line":95,"start_character":52,"end_line":95,"end_character":61},"updated":"2017-03-22 18:37:50.000000000","message":"May be you can say registering here.","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"74b6b4723d044a30b7593178c667d26424317735","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Other deployer impact"},{"line_number":94,"context_line":"---------------------"},{"line_number":95,"context_line":"The following driver_info fields are required while enrolling nodes"},{"line_number":96,"context_line":"into ironic:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    * ``redfish_address``: The URL address to the Redfish controller. It"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_fa947f37","line":95,"range":{"start_line":95,"start_character":52,"end_line":95,"end_character":61},"in_reply_to":"1a1ced50_7c7eeb6a","updated":"2017-03-23 10:52:46.000000000","message":"We use the term \"enroll\", we even have a state called \"enroll\" for that purpose.","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"37fca326c9a8ca22b16955c4796173a01e8cc55a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      within the same authority as the redfish_address property. For"},{"line_number":106,"context_line":"      example: /redfish/v1/Systems/1"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    * ``redfish_username``: User account with admin/server-profile"},{"line_number":109,"context_line":"      access privilege"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    * ``redfish_password``: User account password"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_dc335ff4","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":24},"updated":"2017-03-22 18:37:50.000000000","message":"As per the driver code, this is optional driver_info field.","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"74b6b4723d044a30b7593178c667d26424317735","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      within the same authority as the redfish_address property. For"},{"line_number":106,"context_line":"      example: /redfish/v1/Systems/1"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    * ``redfish_username``: User account with admin/server-profile"},{"line_number":109,"context_line":"      access privilege"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    * ``redfish_password``: User account password"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_7aa16f93","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":24},"in_reply_to":"1a1ced50_dc335ff4","updated":"2017-03-23 10:52:46.000000000","message":"++\n\nYeah I will make it more explicit","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"37fca326c9a8ca22b16955c4796173a01e8cc55a","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    * ``redfish_username``: User account with admin/server-profile"},{"line_number":109,"context_line":"      access privilege"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    * ``redfish_password``: User account password"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    * ``redfish_verify_ca``: This property contains either a boolean"},{"line_number":114,"context_line":"      value, a path to a CA_BUNDLE file or directory with certificates"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_3c539318","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":24},"updated":"2017-03-22 18:37:50.000000000","message":"ditto","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"74b6b4723d044a30b7593178c667d26424317735","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    * ``redfish_username``: User account with admin/server-profile"},{"line_number":109,"context_line":"      access privilege"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    * ``redfish_password``: User account password"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    * ``redfish_verify_ca``: This property contains either a boolean"},{"line_number":114,"context_line":"      value, a path to a CA_BUNDLE file or directory with certificates"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_baa767a5","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":24},"in_reply_to":"1a1ced50_3c539318","updated":"2017-03-23 10:52:46.000000000","message":"ditto","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"37fca326c9a8ca22b16955c4796173a01e8cc55a","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    * ``redfish_password``: User account password"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    * ``redfish_verify_ca``: This property contains either a boolean"},{"line_number":114,"context_line":"      value, a path to a CA_BUNDLE file or directory with certificates"},{"line_number":115,"context_line":"      of trusted CAs. If set to True the driver will verify the host"},{"line_number":116,"context_line":"      certificates; if False the driver will ignore verifying the SSL"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_5c568f06","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":25},"updated":"2017-03-22 18:37:50.000000000","message":"ditto","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"74b6b4723d044a30b7593178c667d26424317735","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    * ``redfish_password``: User account password"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    * ``redfish_verify_ca``: This property contains either a boolean"},{"line_number":114,"context_line":"      value, a path to a CA_BUNDLE file or directory with certificates"},{"line_number":115,"context_line":"      of trusted CAs. If set to True the driver will verify the host"},{"line_number":116,"context_line":"      certificates; if False the driver will ignore verifying the SSL"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_1aaf9b7d","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":25},"in_reply_to":"1a1ced50_5c568f06","updated":"2017-03-23 10:52:46.000000000","message":"It already says. \"Defaults to ...\"","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0c0f8dc87a499b2c2d17bbd868f56806fbb1650c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      certificate or one of the certificates in the directory. Defaults"},{"line_number":119,"context_line":"      to True."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"For extra information about how the expected syntax of the"},{"line_number":122,"context_line":"``redfish_system_id`` property check the `Resource identifier property"},{"line_number":123,"context_line":"\u003chttp://redfish.dmtf.org/schemas/DSP0266_1.1.html#resource-identifier-property\u003e`_"},{"line_number":124,"context_line":"section of the DMTF specification."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_1cec1729","line":121,"updated":"2017-03-22 18:41:02.000000000","message":"nit s/extra/more/\n\ns/how//","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"74b6b4723d044a30b7593178c667d26424317735","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      certificate or one of the certificates in the directory. Defaults"},{"line_number":119,"context_line":"      to True."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"For extra information about how the expected syntax of the"},{"line_number":122,"context_line":"``redfish_system_id`` property check the `Resource identifier property"},{"line_number":123,"context_line":"\u003chttp://redfish.dmtf.org/schemas/DSP0266_1.1.html#resource-identifier-property\u003e`_"},{"line_number":124,"context_line":"section of the DMTF specification."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_5acd9364","line":121,"in_reply_to":"1a1ced50_1cec1729","updated":"2017-03-23 10:52:46.000000000","message":"Done","commit_id":"b39f81059ede0ae5a19110506500f95b49393544"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b11f9372736b9bd0882871bf9d1df573d09bc350","unresolved":false,"context_lines":[{"line_number":101,"context_line":"      https://mgmt.vendor.com"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    * ``redfish_system_id``: The canonical path to the ComputerSystem"},{"line_number":104,"context_line":"      resource that the driver will interact with. It should include the"},{"line_number":105,"context_line":"      root service, version and the unique resource path to a ComputerSystem"},{"line_number":106,"context_line":"      within the same authority as the redfish_address property. For"},{"line_number":107,"context_line":"      example: /redfish/v1/Systems/1"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    * ``redfish_username``: User account with admin/server-profile"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a1ced50_3847ed1e","line":106,"range":{"start_line":104,"start_character":51,"end_line":106,"end_character":63},"updated":"2017-03-23 17:21:51.000000000","message":"@Miles ^","commit_id":"6c8c98679ac42cb60dd3542af024aab08ac2f620"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bade714cf4a2a11ca29d5645589c41135f27d964","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    * ``redfish_system_id``: The canonical path to the ComputerSystem"},{"line_number":104,"context_line":"      resource that the driver will interact with. It should include the"},{"line_number":105,"context_line":"      root service, version and the unique resource path to a ComputerSystem"},{"line_number":106,"context_line":"      within the same authority as the redfish_address property. For"},{"line_number":107,"context_line":"      example: /redfish/v1/Systems/1"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    * ``redfish_username``: User account with admin/server-profile"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a1ced50_b8a4bdb9","line":106,"in_reply_to":"1a1ced50_3847ed1e","updated":"2017-03-23 17:29:23.000000000","message":"Thanks!","commit_id":"6c8c98679ac42cb60dd3542af024aab08ac2f620"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bade714cf4a2a11ca29d5645589c41135f27d964","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    * ``redfish_password``: User account password. Although this property"},{"line_number":114,"context_line":"      is not mandatory it\u0027s highly recommended to set a password. Optional"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    * ``redfish_verify_ca``: This property contains either a boolean"},{"line_number":117,"context_line":"      value, a path to a CA_BUNDLE file or directory with certificates"},{"line_number":118,"context_line":"      of trusted CAs. If set to True the driver will verify the host"},{"line_number":119,"context_line":"      certificates; if False the driver will ignore verifying the SSL"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a1ced50_18d071f7","line":116,"updated":"2017-03-23 17:29:23.000000000","message":"One of those occasions where Haskell-style algebraic datatypes would be really useful :-(\n\n    data VerifyCA \u003d Verify | Ignore | CustomCertPath String","commit_id":"6c8c98679ac42cb60dd3542af024aab08ac2f620"}]}
