)]}'
{"specs/approved/implement-rescue-mode.rst":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"59b90eaedabca7846d5fb0abc170961edff0a9d4","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Add a new method clean_up() for RescueInterface in base.py. This method would"},{"line_number":163,"context_line":"perform any necessary clean up of the node upon RESCUEWAIT timeout/failure"},{"line_number":164,"context_line":"or finishing rescue operation. Some of the cleaning tasks are removing rescue"},{"line_number":165,"context_line":"password from the node. Ramdisk boot environment should be cleaned if"},{"line_number":166,"context_line":"ironic is managing the ramdisk boot. It would have default implementation as"},{"line_number":167,"context_line":"given below::"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    class RescueInterface(BaseInterface):"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f2577a7_080fe8e1","line":166,"range":{"start_line":165,"start_character":24,"end_line":166,"end_character":36},"updated":"2017-09-12 07:11:35.000000000","message":"i guess this work belongs to boot interface, make sense?","commit_id":"6a67e4a816e006f01730452349ffb1da19478317"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b7ea0ca9d6c111463744058f761f24c34caa19ff","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Add a new method clean_up() for RescueInterface in base.py. This method would"},{"line_number":163,"context_line":"perform any necessary clean up of the node upon RESCUEWAIT timeout/failure"},{"line_number":164,"context_line":"or finishing rescue operation. Some of the cleaning tasks are removing rescue"},{"line_number":165,"context_line":"password from the node. Ramdisk boot environment should be cleaned if"},{"line_number":166,"context_line":"ironic is managing the ramdisk boot. It would have default implementation as"},{"line_number":167,"context_line":"given below::"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    class RescueInterface(BaseInterface):"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f2577a7_6b6ae680","line":166,"range":{"start_line":165,"start_character":24,"end_line":166,"end_character":36},"in_reply_to":"5f2577a7_080fe8e1","updated":"2017-09-12 08:08:55.000000000","message":"It is similar. One may call the boot.clean_up() to achieve it. See https://review.openstack.org/#/c/400437/55/ironic/drivers/modules/agent.py","commit_id":"6a67e4a816e006f01730452349ffb1da19478317"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"fb54a2dc5e1563f403be58397c163f77b7e6e408","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Add a new method clean_up() for RescueInterface in base.py. This method would"},{"line_number":163,"context_line":"perform any necessary clean up of the node upon RESCUEWAIT timeout/failure"},{"line_number":164,"context_line":"or finishing rescue operation. Some of the cleaning tasks are removing rescue"},{"line_number":165,"context_line":"password from the node. Ramdisk boot environment should be cleaned if"},{"line_number":166,"context_line":"ironic is managing the ramdisk boot. It would have default implementation as"},{"line_number":167,"context_line":"given below::"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    class RescueInterface(BaseInterface):"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f2577a7_1e8f222b","line":166,"range":{"start_line":165,"start_character":24,"end_line":166,"end_character":36},"in_reply_to":"5f2577a7_6b6ae680","updated":"2017-09-12 09:14:08.000000000","message":"calling a driver interface from another doesn\u0027t look good, why not put boot environment clean up to the caller of RescueInterface.clean_up()?","commit_id":"6a67e4a816e006f01730452349ffb1da19478317"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bbeb47a7b80dc6bccbcbe2ab88679db065d9f838","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* Add AgentRescue driver (implements base.RescueInterface). This implementation"},{"line_number":37,"context_line":"  will be available only through hardware type. It would not be supported in"},{"line_number":38,"context_line":"  the classic drivers as they would be deprecated shortly."},{"line_number":39,"context_line":"* For classic drivers rescue interface would be set to \u0027no-rescue\u0027 which would"},{"line_number":40,"context_line":"  generate \u0027UnsupportedDriverExtension\u0027 exception when any methods of this"},{"line_number":41,"context_line":"  interface are invoked."},{"line_number":42,"context_line":"* Add periodic task _check_rescue_timeouts to fail the rescue process if"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df87a7cf_b42d1aff","line":39,"updated":"2017-12-11 21:27:01.000000000","message":"This one isn\u0027t clear to me, I thought it was changed to None, but I need to get back to reviewing. We can always update later.","commit_id":"82f79a54e08194cd14744a0c7913dcb58b16e50e"}]}