)]}'
{"specs/approved/inspect-wait-state.rst":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"dcd52fe7e27e98e65c31cc91740133fe31053b78","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    into the ``inspect failed`` state (and the node is, if configured so,"},{"line_number":42,"context_line":"    powered-off)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  * upon the ``abort`` request, the node is kept in the same ``inspect wait`` state till either:"},{"line_number":45,"context_line":"    "},{"line_number":46,"context_line":"    * the (current) periodic task [1]_ moves the node state to the ``inspect"},{"line_number":47,"context_line":"      failed`` state"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_79d8ba51","line":45,"range":{"start_line":44,"start_character":1,"end_line":45,"end_character":4},"updated":"2017-10-27 09:18:32.000000000","message":"Oops!","commit_id":"86407dad45fbec3f587d2fc843608184e6ed016b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"07a64f8498dfd43fe40ba718288096e4bf6f1fb9","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"For asynchronous inspection like ironic inspector driver, ironic conductor"},{"line_number":31,"context_line":"will move node to ``inspecting`` state when an inspect request is issued, then"},{"line_number":32,"context_line":"the ironic inspector driver moves node to ``inspect-wait`` state after inspect"},{"line_number":33,"context_line":"request is successfully issued to ironic-inspector."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a new option ``[conductor]inspect_wait_timeout`` to guard state transition"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_b2a85277","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":27},"updated":"2018-03-12 05:30:22.000000000","message":"s/ \u0027driver\u0027 / \u0027insterface\u0027 /","commit_id":"a954248f186c50f76701367c85a51fb16e8910f6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c474e0f843da6bff3bd87021f5a32667419c0ee6","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"For asynchronous inspection like ironic inspector driver, ironic conductor"},{"line_number":31,"context_line":"will move node to ``inspecting`` state when an inspect request is issued, then"},{"line_number":32,"context_line":"the ironic inspector driver moves node to ``inspect-wait`` state after inspect"},{"line_number":33,"context_line":"request is successfully issued to ironic-inspector."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a new option ``[conductor]inspect_wait_timeout`` to guard state transition"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_326181d4","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":27},"in_reply_to":"df7087c5_b2a85277","updated":"2018-03-13 07:23:56.000000000","message":"Done","commit_id":"a954248f186c50f76701367c85a51fb16e8910f6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"07a64f8498dfd43fe40ba718288096e4bf6f1fb9","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a new option ``[conductor]inspect_wait_timeout`` to guard state transition"},{"line_number":36,"context_line":"from ``inspecting`` to other states (e.g. ``inspect wait``). The existing"},{"line_number":37,"context_line":"``[conductor]inspect_timeout`` is used to guard whole inspection timeout."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"If state transition from ``inspecting`` to other states is timed out, node"},{"line_number":40,"context_line":"will be moved from ``inspecting`` to ``inspect failed``. If the hardware"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_722f1af6","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":31},"updated":"2018-03-12 05:30:22.000000000","message":"Would we still need this config parameter? I suppose node will remain in \u0027inspect wait\u0027 state till ironic-inspector returns data or error.","commit_id":"a954248f186c50f76701367c85a51fb16e8910f6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c474e0f843da6bff3bd87021f5a32667419c0ee6","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a new option ``[conductor]inspect_wait_timeout`` to guard state transition"},{"line_number":36,"context_line":"from ``inspecting`` to other states (e.g. ``inspect wait``). The existing"},{"line_number":37,"context_line":"``[conductor]inspect_timeout`` is used to guard whole inspection timeout."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"If state transition from ``inspecting`` to other states is timed out, node"},{"line_number":40,"context_line":"will be moved from ``inspecting`` to ``inspect failed``. If the hardware"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_35bdeb01","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":31},"in_reply_to":"df7087c5_722f1af6","updated":"2018-03-13 07:23:56.000000000","message":"I think so, there is a race condition between ironic and ironic-inspector, when ironic issued request to ironic-inspector, inspector may have the node locked, which prevents ironic from updating the provision state [1].\n\n[1] https://github.com/openstack/ironic/blob/652fef5619d798c7acda6970a8e1beae600e5aed/ironic/drivers/modules/inspector.py#L161-L165","commit_id":"a954248f186c50f76701367c85a51fb16e8910f6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"07a64f8498dfd43fe40ba718288096e4bf6f1fb9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from ``inspecting`` to other states (e.g. ``inspect wait``). The existing"},{"line_number":37,"context_line":"``[conductor]inspect_timeout`` is used to guard whole inspection timeout."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"If state transition from ``inspecting`` to other states is timed out, node"},{"line_number":40,"context_line":"will be moved from ``inspecting`` to ``inspect failed``. If the hardware"},{"line_number":41,"context_line":"inspection is timed out in the state of ``inspect wait``, node will be moved"},{"line_number":42,"context_line":"from ``inspect wait`` to ``inspect failed``."}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_d23f0623","line":39,"range":{"start_line":39,"start_character":43,"end_line":39,"end_character":56},"updated":"2018-03-12 05:30:22.000000000","message":"What are the \u0027other states\u0027 here? Isn\u0027t it just \u0027inspect wait\u0027?","commit_id":"a954248f186c50f76701367c85a51fb16e8910f6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c474e0f843da6bff3bd87021f5a32667419c0ee6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from ``inspecting`` to other states (e.g. ``inspect wait``). The existing"},{"line_number":37,"context_line":"``[conductor]inspect_timeout`` is used to guard whole inspection timeout."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"If state transition from ``inspecting`` to other states is timed out, node"},{"line_number":40,"context_line":"will be moved from ``inspecting`` to ``inspect failed``. If the hardware"},{"line_number":41,"context_line":"inspection is timed out in the state of ``inspect wait``, node will be moved"},{"line_number":42,"context_line":"from ``inspect wait`` to ``inspect failed``."}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_b2b59180","line":39,"range":{"start_line":39,"start_character":43,"end_line":39,"end_character":56},"in_reply_to":"df7087c5_d23f0623","updated":"2018-03-13 07:23:56.000000000","message":"there is a transition from inspecting to inspect failed, in case if an inspect command is requested from ironic API, while ironic-inspector doesn\u0027t initiated the introspection process in time.\nI have explicitly written it down.","commit_id":"a954248f186c50f76701367c85a51fb16e8910f6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"07a64f8498dfd43fe40ba718288096e4bf6f1fb9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#. ``inspect wait`` to ``inspect failed`` with event ``fail``."},{"line_number":67,"context_line":"#. ``inspect wait`` to ``manageable`` with event ``done``."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Remove transition of ``inspecting`` to ``manageable`` with event ``done``."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"REST API impact"},{"line_number":72,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_72187ad2","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":74},"updated":"2018-03-12 05:30:22.000000000","message":"For OOB inspection, this transition would be still valid as it is performed synchronously.","commit_id":"a954248f186c50f76701367c85a51fb16e8910f6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c474e0f843da6bff3bd87021f5a32667419c0ee6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#. ``inspect wait`` to ``inspect failed`` with event ``fail``."},{"line_number":67,"context_line":"#. ``inspect wait`` to ``manageable`` with event ``done``."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Remove transition of ``inspecting`` to ``manageable`` with event ``done``."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"REST API impact"},{"line_number":72,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_554f3f33","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":74},"in_reply_to":"df7087c5_72187ad2","updated":"2018-03-13 07:23:56.000000000","message":"Done\nthanks!","commit_id":"a954248f186c50f76701367c85a51fb16e8910f6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff63981ddc7a9feef91bd478a23bd698fb391a28","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a new option ``[conductor]inspect_wait_timeout`` to guard state transition"},{"line_number":36,"context_line":"from ``inspecting`` to other states (e.g. ``inspect wait``). The existing"},{"line_number":37,"context_line":"``[conductor]inspect_timeout`` is used to guard whole inspection timeout."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"If state transition from ``inspecting`` to ``inspect wait`` or"},{"line_number":40,"context_line":"``inspect failed`` is timed out, node will be moved from ``inspecting`` to"}],"source_content_type":"text/x-rst","patch_set":7,"id":"df7087c5_9ccf3c55","line":37,"updated":"2018-03-13 09:45:52.000000000","message":"This option no longer looks useful. In any case, we can only abort introspection in INSPECT WAIT. If a driver gets stuck, for example, in an out-of-band inspection, it\u0027s their responsibility to have reasonable timeouts. I suggest deprecating inspect_timeout.","commit_id":"07df89d1c9d5de95b186b0bcaa38532ddbb64c76"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"930a1111c41023aed46d050518095dadbacc377e","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a new option ``[conductor]inspect_wait_timeout`` to guard state transition"},{"line_number":36,"context_line":"from ``inspecting`` to other states (e.g. ``inspect wait``). The existing"},{"line_number":37,"context_line":"``[conductor]inspect_timeout`` is used to guard whole inspection timeout."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"If state transition from ``inspecting`` to ``inspect wait`` or"},{"line_number":40,"context_line":"``inspect failed`` is timed out, node will be moved from ``inspecting`` to"}],"source_content_type":"text/x-rst","patch_set":7,"id":"df7087c5_a7152de7","line":37,"in_reply_to":"df7087c5_9ccf3c55","updated":"2018-03-14 08:16:42.000000000","message":"+1","commit_id":"07df89d1c9d5de95b186b0bcaa38532ddbb64c76"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c7e7d130cd79e76eecbe48968646297b7d28c8b1","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a new option ``[conductor]inspect_wait_timeout`` to guard state transition"},{"line_number":36,"context_line":"from ``inspecting`` to other states (e.g. ``inspect wait``). The existing"},{"line_number":37,"context_line":"``[conductor]inspect_timeout`` is used to guard whole inspection timeout."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"If state transition from ``inspecting`` to ``inspect wait`` or"},{"line_number":40,"context_line":"``inspect failed`` is timed out, node will be moved from ``inspecting`` to"}],"source_content_type":"text/x-rst","patch_set":7,"id":"df7087c5_bdb1a249","line":37,"in_reply_to":"df7087c5_9ccf3c55","updated":"2018-03-15 06:48:06.000000000","message":"Done","commit_id":"07df89d1c9d5de95b186b0bcaa38532ddbb64c76"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff63981ddc7a9feef91bd478a23bd698fb391a28","unresolved":false,"context_lines":[{"line_number":37,"context_line":"``[conductor]inspect_timeout`` is used to guard whole inspection timeout."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"If state transition from ``inspecting`` to ``inspect wait`` or"},{"line_number":40,"context_line":"``inspect failed`` is timed out, node will be moved from ``inspecting`` to"},{"line_number":41,"context_line":"``inspect failed``. If the hardware inspection is timed out in the state of"},{"line_number":42,"context_line":"``inspect wait``, node will be moved from ``inspect wait`` to"},{"line_number":43,"context_line":"``inspect failed``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"df7087c5_3cd8701c","line":40,"updated":"2018-03-13 09:45:52.000000000","message":"The first sentence here does not quite make sense to me. The transition cannot timeout, it\u0027s a quick operation on the database. What can timeout is \"inspect wait\" itself, which is covered by the next sentence.","commit_id":"07df89d1c9d5de95b186b0bcaa38532ddbb64c76"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b8209bfc666dc071fd3b0f13c46bba4015a6cff9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"``[conductor]inspect_timeout`` is used to guard whole inspection timeout."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"If state transition from ``inspecting`` to ``inspect wait`` or"},{"line_number":40,"context_line":"``inspect failed`` is timed out, node will be moved from ``inspecting`` to"},{"line_number":41,"context_line":"``inspect failed``. If the hardware inspection is timed out in the state of"},{"line_number":42,"context_line":"``inspect wait``, node will be moved from ``inspect wait`` to"},{"line_number":43,"context_line":"``inspect failed``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"df7087c5_7d290199","line":40,"in_reply_to":"df7087c5_3cd8701c","updated":"2018-03-13 12:13:15.000000000","message":"I\u0027m concerned with the race condition [1], after ironic issued introspection request to ironic-inspector, ironic-inspector may have the node locked for power and boot mode control, it can prevent ironic from finishing the transition.\n\nOr we directly handle the transition at conductor, we add a clause in _do_inspect_hardware [2] to handle the transition when new_state \u003d\u003d INSPECTING. The node lock is held at this time, so the transition will not fail.\nFor the ironic-inspector side, ironicclient has the retry mechanism when CONFLICT is received, I think it handles well even the node is locked.\nWe can also omit the timeout guard in this case.\n\nOpinions?\n\n[1] https://github.com/openstack/ironic/blob/652fef5619d798c7acda6970a8e1beae600e5aed/ironic/drivers/modules/inspector.py#L161-L165\n[2] https://github.com/openstack/ironic/blob/652fef5619d798c7acda6970a8e1beae600e5aed/ironic/conductor/manager.py#L3465-L3473","commit_id":"07df89d1c9d5de95b186b0bcaa38532ddbb64c76"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c7e7d130cd79e76eecbe48968646297b7d28c8b1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"``[conductor]inspect_timeout`` is used to guard whole inspection timeout."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"If state transition from ``inspecting`` to ``inspect wait`` or"},{"line_number":40,"context_line":"``inspect failed`` is timed out, node will be moved from ``inspecting`` to"},{"line_number":41,"context_line":"``inspect failed``. If the hardware inspection is timed out in the state of"},{"line_number":42,"context_line":"``inspect wait``, node will be moved from ``inspect wait`` to"},{"line_number":43,"context_line":"``inspect failed``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"df7087c5_dd1fb605","line":40,"in_reply_to":"df7087c5_47f1b16a","updated":"2018-03-15 06:48:06.000000000","message":"Done","commit_id":"07df89d1c9d5de95b186b0bcaa38532ddbb64c76"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"930a1111c41023aed46d050518095dadbacc377e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"``[conductor]inspect_timeout`` is used to guard whole inspection timeout."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"If state transition from ``inspecting`` to ``inspect wait`` or"},{"line_number":40,"context_line":"``inspect failed`` is timed out, node will be moved from ``inspecting`` to"},{"line_number":41,"context_line":"``inspect failed``. If the hardware inspection is timed out in the state of"},{"line_number":42,"context_line":"``inspect wait``, node will be moved from ``inspect wait`` to"},{"line_number":43,"context_line":"``inspect failed``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"df7087c5_47f1b16a","line":40,"in_reply_to":"df7087c5_7d290199","updated":"2018-03-14 08:16:42.000000000","message":"I agree, we need to handle this transition from conductor.","commit_id":"07df89d1c9d5de95b186b0bcaa38532ddbb64c76"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"930a1111c41023aed46d050518095dadbacc377e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"``inspect failed``."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"As ironic-inspector checks node provision state before starting inspection,"},{"line_number":46,"context_line":"the ``ironic wait`` state needs to be added to ironic-inspector as a valid"},{"line_number":47,"context_line":"state."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"df7087c5_3d860e15","line":47,"range":{"start_line":46,"start_character":67,"end_line":47,"end_character":6},"updated":"2018-03-14 08:16:42.000000000","message":"We allow node/port update when node is in \u0027inspecting\u0027 state. Would it be allowed in \u0027inspect wait\u0027 as well? May be better to capture that in the spec.","commit_id":"07df89d1c9d5de95b186b0bcaa38532ddbb64c76"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c7e7d130cd79e76eecbe48968646297b7d28c8b1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"``inspect failed``."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"As ironic-inspector checks node provision state before starting inspection,"},{"line_number":46,"context_line":"the ``ironic wait`` state needs to be added to ironic-inspector as a valid"},{"line_number":47,"context_line":"state."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"df7087c5_fda95a8f","line":47,"range":{"start_line":46,"start_character":67,"end_line":47,"end_character":6},"in_reply_to":"df7087c5_3d860e15","updated":"2018-03-15 06:48:06.000000000","message":"Done\ngood point, we should add inspect wait as a valid state here.","commit_id":"07df89d1c9d5de95b186b0bcaa38532ddbb64c76"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff63981ddc7a9feef91bd478a23bd698fb391a28","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"API microversion will be bumped to hide the new ``inspect wait`` state to"},{"line_number":74,"context_line":"clients with older microversion, this will be done in the"},{"line_number":75,"context_line":"``update_state_in_older_versions``."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Node related API endpoints will be affected:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"df7087c5_5cd524e4","line":75,"updated":"2018-03-13 09:45:52.000000000","message":"++","commit_id":"07df89d1c9d5de95b186b0bcaa38532ddbb64c76"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b557278814f46f148bd18394c56c581a99010ef4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"For asynchronous inspection like ironic inspector driver, ironic conductor"},{"line_number":31,"context_line":"will move node from ``manageable`` to ``inspecting`` state when an inspect"},{"line_number":32,"context_line":"request is issued, then the ironic conductor moves node to ``inspect-wait``"},{"line_number":33,"context_line":"state if ``InspectInterface.inspect_hardware`` returns ``INSPECTING``."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a new option ``[conductor]inspect_wait_timeout`` to guard the"},{"line_number":36,"context_line":"``inspect wait`` state, the default value is 1800 seconds as same as"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df7087c5_a1363402","line":33,"updated":"2018-03-16 10:37:28.000000000","message":"for a follow-up: we need to support returning INSPECTWAIT for consistency and deprecate returning INSPECTING","commit_id":"b2e9b6dac6c7a2f4c0755a94bdb008317c34a9df"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ef3a966d5c7bf0d3a9299a3b4ccee09ccb9fba8e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"---------------------"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Add a new option ``[conductor]inspect_wait_timeout`` to guard timeout of state"},{"line_number":148,"context_line":"``inspecting``, defaults to 150 seconds."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Developer impact"},{"line_number":151,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df7087c5_fbd29dff","line":148,"updated":"2018-03-16 09:17:15.000000000","message":"nit: Here was not updated. A follow-up would be fine.","commit_id":"b2e9b6dac6c7a2f4c0755a94bdb008317c34a9df"}]}