)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"39a6e34df14f50fe7666a31dfbc1be8a800276c3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support a new hardware type for PRIMEQUEST MMB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes to add Power, Management and Console capabilities for"},{"line_number":10,"context_line":"Fujitsu PRIMEQUEST ManageMent Board(MMB)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic308ab0b6ee57cd9895d9ff1a35085f55cad8e2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_318475b1","line":9,"updated":"2017-10-30 02:18:49.000000000","message":"It would be better to mention adding a new hardware type.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support a new hardware type for PRIMEQUEST MMB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes to add Power, Management and Console capabilities for"},{"line_number":10,"context_line":"Fujitsu PRIMEQUEST ManageMent Board(MMB)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic308ab0b6ee57cd9895d9ff1a35085f55cad8e2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_95164ea7","line":9,"in_reply_to":"3f4b6375_318475b1","updated":"2017-10-31 11:15:19.000000000","message":"Done","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"}],"specs/approved/support-fujitsu-pq-mmb-driver.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"09b613856591df2f37843a0d9d00fc015cff40dd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"and monitoring in the cabinet, partition management, and system initialization."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PRIMEQUEST 3000 Series servers provides the highest ever levels of performance"},{"line_number":19,"context_line":"and stability from industry standard servers, the firm claimed, all but"},{"line_number":20,"context_line":"eliminating unplanned downtime for demanding enterprise workloads."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_1eb4d634","line":19,"range":{"start_line":19,"start_character":44,"end_line":19,"end_character":62},"updated":"2017-10-30 16:08:29.000000000","message":"I\u0027m afraid this doesn\u0027t make sense to me.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"and monitoring in the cabinet, partition management, and system initialization."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"PRIMEQUEST 3000 Series servers provides the highest ever levels of performance"},{"line_number":19,"context_line":"and stability from industry standard servers, the firm claimed, all but"},{"line_number":20,"context_line":"eliminating unplanned downtime for demanding enterprise workloads."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_40c5b68d","line":19,"range":{"start_line":19,"start_character":44,"end_line":19,"end_character":62},"in_reply_to":"3f4b6375_1eb4d634","updated":"2017-10-31 11:15:19.000000000","message":"Thank you.  I check this paragraph again, and I thought this is not necessary.  Therefore, I\u0027ll remove this paragraph.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"09b613856591df2f37843a0d9d00fc015cff40dd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Ironic cannot handle Fujitsu PRIMEQUEST servers so far.  Therefore, this spec"},{"line_number":26,"context_line":"proposes a new hardware type for MMB in order to handle PRIMEQUEST by ironic."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_de875e61","line":25,"range":{"start_line":25,"start_character":48,"end_line":25,"end_character":54},"updated":"2017-10-30 16:08:29.000000000","message":"nit: s/so far/at present/","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Ironic cannot handle Fujitsu PRIMEQUEST servers so far.  Therefore, this spec"},{"line_number":26,"context_line":"proposes a new hardware type for MMB in order to handle PRIMEQUEST by ironic."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_60a7920d","line":25,"range":{"start_line":25,"start_character":48,"end_line":25,"end_character":54},"in_reply_to":"3f4b6375_de875e61","updated":"2017-10-31 11:15:19.000000000","message":"Done","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"39a6e34df14f50fe7666a31dfbc1be8a800276c3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"- driver_info"},{"line_number":39,"context_line":"    - (Required) **mmb_address**: IP address of the MMB to ssh into."},{"line_number":40,"context_line":"    - (Required) **mmb_username**: Username to authenticate as."},{"line_number":41,"context_line":"    - (Required) **mmb_partition**: Partition number to manage."},{"line_number":42,"context_line":"    - **mmb_ssh_key_contents**: Private key(s). If **mmb_ssh_password**"},{"line_number":43,"context_line":"                                   is also specified, it will be used for"},{"line_number":44,"context_line":"                                   unlocking the private key.  Do not specify"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_715aed2a","line":41,"updated":"2017-10-30 02:18:49.000000000","message":"What is a partition? Brief description would be necessary.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"- driver_info"},{"line_number":39,"context_line":"    - (Required) **mmb_address**: IP address of the MMB to ssh into."},{"line_number":40,"context_line":"    - (Required) **mmb_username**: Username to authenticate as."},{"line_number":41,"context_line":"    - (Required) **mmb_partition**: Partition number to manage."},{"line_number":42,"context_line":"    - **mmb_ssh_key_contents**: Private key(s). If **mmb_ssh_password**"},{"line_number":43,"context_line":"                                   is also specified, it will be used for"},{"line_number":44,"context_line":"                                   unlocking the private key.  Do not specify"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_a030ea9f","line":41,"in_reply_to":"3f4b6375_715aed2a","updated":"2017-10-31 11:15:19.000000000","message":"I\u0027ll add an explanation b/w PRIMEQUEST and partition at \u0027Problem description\u0027 section.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"09b613856591df2f37843a0d9d00fc015cff40dd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                   is also specified, it will be used for"},{"line_number":44,"context_line":"                                   unlocking the private key.  Do not specify"},{"line_number":45,"context_line":"                                   **mmb_ssh_key_filename** when this"},{"line_number":46,"context_line":"                                   property is specified."},{"line_number":47,"context_line":"    - **mmb_ssh_key_filename**: (List of)l filename(s) of optional private"},{"line_number":48,"context_line":"                                   key(s) for authentication. If"},{"line_number":49,"context_line":"                                   **mmb_ssh_password** is also specified,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_beca629e","line":46,"updated":"2017-10-30 16:08:29.000000000","message":"I\u0027m a little worried about storing private key data in driver_info. The reply of this will either need to be scrubbed for API replies. Perhaps just default to \"on-conductor\" files that an ironic user has access to. This reduces API information leakage risks.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                   is also specified, it will be used for"},{"line_number":44,"context_line":"                                   unlocking the private key.  Do not specify"},{"line_number":45,"context_line":"                                   **mmb_ssh_key_filename** when this"},{"line_number":46,"context_line":"                                   property is specified."},{"line_number":47,"context_line":"    - **mmb_ssh_key_filename**: (List of)l filename(s) of optional private"},{"line_number":48,"context_line":"                                   key(s) for authentication. If"},{"line_number":49,"context_line":"                                   **mmb_ssh_password** is also specified,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_a0beaad1","line":46,"in_reply_to":"3f4b6375_beca629e","updated":"2017-10-31 11:15:19.000000000","message":"Yes, it includes a security risk.  I\u0027ll remove this attribute and use \u0027mmb_ssh_key_filename\u0027 instead.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"39a6e34df14f50fe7666a31dfbc1be8a800276c3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                                   **mmb_ssh_key_contents** when this"},{"line_number":53,"context_line":"                                   property is specified."},{"line_number":54,"context_line":"    - **mmb_ssh_password**: Password to use for authentication or for"},{"line_number":55,"context_line":"                               unlocking a private key. At least one of this,"},{"line_number":56,"context_line":"                               **mmb_ssh_key_contents** , or"},{"line_number":57,"context_line":"                               **mmb_ssh_key_filename** must be specified."},{"line_number":58,"context_line":"    - **mmb_ssh_port**: Port on the node to connect to. Default is 22."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_910d69ea","line":55,"range":{"start_line":55,"start_character":56,"end_line":55,"end_character":64},"updated":"2017-10-30 02:18:49.000000000","message":"Can both mmb_ssh_key_contents and mmb_ssh_key_filename be set together?","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                                   **mmb_ssh_key_contents** when this"},{"line_number":53,"context_line":"                                   property is specified."},{"line_number":54,"context_line":"    - **mmb_ssh_password**: Password to use for authentication or for"},{"line_number":55,"context_line":"                               unlocking a private key. At least one of this,"},{"line_number":56,"context_line":"                               **mmb_ssh_key_contents** , or"},{"line_number":57,"context_line":"                               **mmb_ssh_key_filename** must be specified."},{"line_number":58,"context_line":"    - **mmb_ssh_port**: Port on the node to connect to. Default is 22."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_60ad529a","line":55,"range":{"start_line":55,"start_character":56,"end_line":55,"end_character":64},"in_reply_to":"3f4b6375_910d69ea","updated":"2017-10-31 11:15:19.000000000","message":"Initially, it raises an error.  But for security perspective, I\u0027ll remove \u0027mmb_ssh_key_contents\u0027 from driver_info and keep on using \u0027mmb_ssh_key_filename\u0027.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"09b613856591df2f37843a0d9d00fc015cff40dd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"- ``MMBConsole``"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"``MMBPower``"},{"line_number":71,"context_line":"    This interface controls and synchronizes the power state of the nodes"},{"line_number":72,"context_line":"    using MMB\u0027s command."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"``MMBManagement``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_3e5312e5","line":71,"range":{"start_line":71,"start_character":32,"end_line":71,"end_character":44},"updated":"2017-10-30 16:08:29.000000000","message":"note: Ironic sets/synchronizes by calling the interface and retrieving data. The interface wouldn\u0027t actually perform any synchronization work unless we are unable to get the current power state on demand.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"- ``MMBConsole``"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"``MMBPower``"},{"line_number":71,"context_line":"    This interface controls and synchronizes the power state of the nodes"},{"line_number":72,"context_line":"    using MMB\u0027s command."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"``MMBManagement``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_608552cf","line":71,"range":{"start_line":71,"start_character":32,"end_line":71,"end_character":44},"in_reply_to":"3f4b6375_3e5312e5","updated":"2017-10-31 11:15:19.000000000","message":"Thanks for your help.  I\u0027ll update this explanation a little.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"09b613856591df2f37843a0d9d00fc015cff40dd","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"* username for MMB"},{"line_number":136,"context_line":"* SSH private key for MMB"},{"line_number":137,"context_line":"* SSH password for MMB"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Other end user impact"},{"line_number":140,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_3e6c329b","line":137,"updated":"2017-10-30 16:08:29.000000000","message":"It would be good to note any mitigating factors that would prevent misuse of this information.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"* username for MMB"},{"line_number":136,"context_line":"* SSH private key for MMB"},{"line_number":137,"context_line":"* SSH password for MMB"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Other end user impact"},{"line_number":140,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_f3ed97b7","line":137,"in_reply_to":"3f4b6375_3e6c329b","updated":"2017-10-31 11:15:19.000000000","message":"Done","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"39a6e34df14f50fe7666a31dfbc1be8a800276c3","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Work Items"},{"line_number":172,"context_line":"----------"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"- Implement new ``mmb`` hardware type."},{"line_number":175,"context_line":"- Implement unit-test cases for ``mmb`` hardware type and following interfaces:"},{"line_number":176,"context_line":"  - MMBPower"},{"line_number":177,"context_line":"  - MMBManagement"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_31d8f57d","line":174,"updated":"2017-10-30 02:18:49.000000000","message":"We also need to implement the interfaces.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Work Items"},{"line_number":172,"context_line":"----------"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"- Implement new ``mmb`` hardware type."},{"line_number":175,"context_line":"- Implement unit-test cases for ``mmb`` hardware type and following interfaces:"},{"line_number":176,"context_line":"  - MMBPower"},{"line_number":177,"context_line":"  - MMBManagement"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_e6539a38","line":174,"in_reply_to":"3f4b6375_31d8f57d","updated":"2017-10-31 11:15:19.000000000","message":"Done","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"39a6e34df14f50fe7666a31dfbc1be8a800276c3","unresolved":false,"context_lines":[{"line_number":175,"context_line":"- Implement unit-test cases for ``mmb`` hardware type and following interfaces:"},{"line_number":176,"context_line":"  - MMBPower"},{"line_number":177,"context_line":"  - MMBManagement"},{"line_number":178,"context_line":"  - MMBConsole"},{"line_number":179,"context_line":"- Write configuration documents."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_319355a6","line":178,"updated":"2017-10-30 02:18:49.000000000","message":"This bullet list is not rendered well.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":175,"context_line":"- Implement unit-test cases for ``mmb`` hardware type and following interfaces:"},{"line_number":176,"context_line":"  - MMBPower"},{"line_number":177,"context_line":"  - MMBManagement"},{"line_number":178,"context_line":"  - MMBConsole"},{"line_number":179,"context_line":"- Write configuration documents."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_41401836","line":178,"in_reply_to":"3f4b6375_319355a6","updated":"2017-10-31 11:15:19.000000000","message":"I\u0027ll fix it.  Thanks.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"09b613856591df2f37843a0d9d00fc015cff40dd","unresolved":false,"context_lines":[{"line_number":176,"context_line":"  - MMBPower"},{"line_number":177,"context_line":"  - MMBManagement"},{"line_number":178,"context_line":"  - MMBConsole"},{"line_number":179,"context_line":"- Write configuration documents."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Dependencies"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_9eae8696","line":179,"range":{"start_line":179,"start_character":8,"end_line":179,"end_character":22},"updated":"2017-10-30 16:08:29.000000000","message":"Wouldn\u0027t this be hardware type documentation?","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":176,"context_line":"  - MMBPower"},{"line_number":177,"context_line":"  - MMBManagement"},{"line_number":178,"context_line":"  - MMBConsole"},{"line_number":179,"context_line":"- Write configuration documents."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Dependencies"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_b32ddffe","line":179,"range":{"start_line":179,"start_character":8,"end_line":179,"end_character":22},"in_reply_to":"3f4b6375_9eae8696","updated":"2017-10-31 11:15:19.000000000","message":"Done","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"09b613856591df2f37843a0d9d00fc015cff40dd","unresolved":false,"context_lines":[{"line_number":181,"context_line":"Dependencies"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"**Paramiko**: In order to connect to MMB and execute commands from the hardwar"},{"line_number":185,"context_line":"type."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_3e9d5266","line":184,"range":{"start_line":184,"start_character":71,"end_line":184,"end_character":78},"updated":"2017-10-30 16:08:29.000000000","message":"s/hardwar/hardware/","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":181,"context_line":"Dependencies"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"**Paramiko**: In order to connect to MMB and execute commands from the hardwar"},{"line_number":185,"context_line":"type."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_9334234c","line":184,"range":{"start_line":184,"start_character":71,"end_line":184,"end_character":78},"in_reply_to":"3f4b6375_3e9d5266","updated":"2017-10-31 11:15:19.000000000","message":"Done","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"39a6e34df14f50fe7666a31dfbc1be8a800276c3","unresolved":false,"context_lines":[{"line_number":187,"context_line":"Testing"},{"line_number":188,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"- Unit-tests will be implemented for the changes;"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"In the future, we\u0027ll add 3rd party CI for ``mmb`` hardware type."},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_71ed4d8a","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":1},"updated":"2017-10-30 02:18:49.000000000","message":"This listing is not necessary.\n\nUnit tests might be unnecessary to mention explicitly here since any changes require unit tests.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":187,"context_line":"Testing"},{"line_number":188,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"- Unit-tests will be implemented for the changes;"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"In the future, we\u0027ll add 3rd party CI for ``mmb`` hardware type."},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_416938bc","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":1},"in_reply_to":"3f4b6375_71ed4d8a","updated":"2017-10-31 11:15:19.000000000","message":"Indeed.  I\u0027ll remove it.  Thanks.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"09b613856591df2f37843a0d9d00fc015cff40dd","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"- Unit-tests will be implemented for the changes;"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"In the future, we\u0027ll add 3rd party CI for ``mmb`` hardware type."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":195,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_1ec5f65b","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":64},"updated":"2017-10-30 16:08:29.000000000","message":"From an inclusion standpoint, we will need a commitment for 3rd party CI to appear soon. In general, we should avoid indicating that something will happen in the future\" with a specification as they are sometimes referenced months or years later.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"- Unit-tests will be implemented for the changes;"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"In the future, we\u0027ll add 3rd party CI for ``mmb`` hardware type."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":195,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_c1e88817","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":64},"in_reply_to":"3f4b6375_1ec5f65b","updated":"2017-10-31 11:15:19.000000000","message":"Thank you.  I\u0027ll write explicitly a year ;)","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"09b613856591df2f37843a0d9d00fc015cff40dd","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Documentation Impact"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":200,"context_line":"The required parameters on the node and `[mmb]` section of `ironic.conf`"},{"line_number":201,"context_line":"will be included in the documentation to instruct operators how to use Ironic"},{"line_number":202,"context_line":"with MMB."},{"line_number":203,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_be8262ff","line":200,"range":{"start_line":200,"start_character":40,"end_line":200,"end_character":72},"updated":"2017-10-30 16:08:29.000000000","message":"I\u0027m not sure what this would actually comprise by reading this spec. What information is intended to be configured in ironic.conf outside of the node\u0027s driver_info?","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Documentation Impact"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":200,"context_line":"The required parameters on the node and `[mmb]` section of `ironic.conf`"},{"line_number":201,"context_line":"will be included in the documentation to instruct operators how to use Ironic"},{"line_number":202,"context_line":"with MMB."},{"line_number":203,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_33f32fea","line":200,"range":{"start_line":200,"start_character":40,"end_line":200,"end_character":72},"in_reply_to":"3f4b6375_be8262ff","updated":"2017-10-31 11:15:19.000000000","message":"Ohch!  This description is not necessary.  I\u0027ll remove it.  Sorry for confusing.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"39a6e34df14f50fe7666a31dfbc1be8a800276c3","unresolved":false,"context_lines":[{"line_number":200,"context_line":"The required parameters on the node and `[mmb]` section of `ironic.conf`"},{"line_number":201,"context_line":"will be included in the documentation to instruct operators how to use Ironic"},{"line_number":202,"context_line":"with MMB."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"References"},{"line_number":205,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_b1874562","line":203,"updated":"2017-10-30 02:18:49.000000000","message":"It would be better to also mention this configuration at the Deployer Impact section.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d9dac29520da6b57b64282fa24a3e1804da9c3c8","unresolved":false,"context_lines":[{"line_number":200,"context_line":"The required parameters on the node and `[mmb]` section of `ironic.conf`"},{"line_number":201,"context_line":"will be included in the documentation to instruct operators how to use Ironic"},{"line_number":202,"context_line":"with MMB."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"References"},{"line_number":205,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_53f90b7e","line":203,"in_reply_to":"3f4b6375_b1874562","updated":"2017-10-31 11:15:19.000000000","message":"Sorry Hironori.  Above description was my miss.  I\u0027ll remove it.","commit_id":"60365d2363705a17dbaed32efbf28cde5ce5c8f6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"68893193a387044533a71db3c8e5b51f2e961e67","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Ironic cannot handle Fujitsu PRIMEQUEST servers at present. Therefore, this"},{"line_number":22,"context_line":"spec proposes a new hardware type for MMB in order to handle PRIMEQUEST by"},{"line_number":23,"context_line":"ironic. PRIMEQUEST has multiple partitions. Each partition works as a physical"},{"line_number":24,"context_line":"server. That is, a partition relates an ironic node. In addition, several"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_bae339d8","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":59},"updated":"2017-11-02 05:06:23.000000000","message":"Since theere is an \u0027irmc\u0027 hardware type supported in the Ironic. It would be useful to mention why that hardware type cannot support this new hardware.","commit_id":"102572854c7e769a0dfb00cfa9e2910b409eb93f"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"86d5c27e2cdccd6d9eaf726fdab4817ea7b78fe0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Ironic cannot handle Fujitsu PRIMEQUEST servers at present. Therefore, this"},{"line_number":22,"context_line":"spec proposes a new hardware type for MMB in order to handle PRIMEQUEST by"},{"line_number":23,"context_line":"ironic. PRIMEQUEST has multiple partitions. Each partition works as a physical"},{"line_number":24,"context_line":"server. That is, a partition relates an ironic node. In addition, several"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_5c8ac563","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":59},"in_reply_to":"3f4b6375_bae339d8","updated":"2017-11-04 09:57:56.000000000","message":"+10.  Done","commit_id":"102572854c7e769a0dfb00cfa9e2910b409eb93f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"68893193a387044533a71db3c8e5b51f2e961e67","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"This spec proposes the ``mmb`` hardware type, implementing the Power,"},{"line_number":32,"context_line":"Management and Console. The hardware type uses ssh library in order to connect"},{"line_number":33,"context_line":"and execute commands into MMB."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_fa065186","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":28},"updated":"2017-11-02 05:06:23.000000000","message":"Can we name it as ``irmc-mmb`` to follow the convention followed by other vendors hardware types?\nhttps://github.com/openstack/ironic/blob/master/setup.cfg#L166-L167","commit_id":"102572854c7e769a0dfb00cfa9e2910b409eb93f"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"86d5c27e2cdccd6d9eaf726fdab4817ea7b78fe0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"This spec proposes the ``mmb`` hardware type, implementing the Power,"},{"line_number":32,"context_line":"Management and Console. The hardware type uses ssh library in order to connect"},{"line_number":33,"context_line":"and execute commands into MMB."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_3cd4a947","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":28},"in_reply_to":"3f4b6375_fa065186","updated":"2017-11-04 09:57:56.000000000","message":"Oh..  I understood your request.  However, if we align with above naming, we should re-name as follows.  Do you know better way to rename existing hardware type with no breaking compatibility? ;-)\n\n* fujitsu-irmc\n* fujitsu-mmb","commit_id":"102572854c7e769a0dfb00cfa9e2910b409eb93f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"68893193a387044533a71db3c8e5b51f2e961e67","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    This interface provides serial console view by executing the command on"},{"line_number":77,"context_line":"    MMB."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"This hardware type supports PXEBoot for boot and ISCSIDeploy/AgentDeploy for"},{"line_number":80,"context_line":"deploy."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_1a424dac","line":79,"range":{"start_line":79,"start_character":49,"end_line":79,"end_character":72},"updated":"2017-11-02 05:06:23.000000000","message":"nit: s/ ISCSIDeploy/AgentDeploy / ``ISCSIDeploy`` or ``AgentDeploy`` /","commit_id":"102572854c7e769a0dfb00cfa9e2910b409eb93f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"68893193a387044533a71db3c8e5b51f2e961e67","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    This interface provides serial console view by executing the command on"},{"line_number":77,"context_line":"    MMB."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"This hardware type supports PXEBoot for boot and ISCSIDeploy/AgentDeploy for"},{"line_number":80,"context_line":"deploy."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_5a3c452e","line":79,"range":{"start_line":79,"start_character":28,"end_line":79,"end_character":35},"updated":"2017-11-02 05:06:23.000000000","message":"nit: s/ PXEBoot / ``PXEBoot`` /","commit_id":"102572854c7e769a0dfb00cfa9e2910b409eb93f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"68893193a387044533a71db3c8e5b51f2e961e67","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    This interface provides serial console view by executing the command on"},{"line_number":77,"context_line":"    MMB."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"This hardware type supports PXEBoot for boot and ISCSIDeploy/AgentDeploy for"},{"line_number":80,"context_line":"deploy."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_da303559","line":79,"range":{"start_line":79,"start_character":19,"end_line":79,"end_character":27},"updated":"2017-11-02 05:06:23.000000000","message":"nit: s/ supports / will support /","commit_id":"102572854c7e769a0dfb00cfa9e2910b409eb93f"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"86d5c27e2cdccd6d9eaf726fdab4817ea7b78fe0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    This interface provides serial console view by executing the command on"},{"line_number":77,"context_line":"    MMB."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"This hardware type supports PXEBoot for boot and ISCSIDeploy/AgentDeploy for"},{"line_number":80,"context_line":"deploy."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_1cd7ad4d","line":79,"range":{"start_line":79,"start_character":49,"end_line":79,"end_character":72},"in_reply_to":"3f4b6375_1a424dac","updated":"2017-11-04 09:57:56.000000000","message":"Done","commit_id":"102572854c7e769a0dfb00cfa9e2910b409eb93f"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"86d5c27e2cdccd6d9eaf726fdab4817ea7b78fe0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    This interface provides serial console view by executing the command on"},{"line_number":77,"context_line":"    MMB."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"This hardware type supports PXEBoot for boot and ISCSIDeploy/AgentDeploy for"},{"line_number":80,"context_line":"deploy."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_dccc75bc","line":79,"range":{"start_line":79,"start_character":28,"end_line":79,"end_character":35},"in_reply_to":"3f4b6375_5a3c452e","updated":"2017-11-04 09:57:56.000000000","message":"Done","commit_id":"102572854c7e769a0dfb00cfa9e2910b409eb93f"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"86d5c27e2cdccd6d9eaf726fdab4817ea7b78fe0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    This interface provides serial console view by executing the command on"},{"line_number":77,"context_line":"    MMB."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"This hardware type supports PXEBoot for boot and ISCSIDeploy/AgentDeploy for"},{"line_number":80,"context_line":"deploy."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_bcc77996","line":79,"range":{"start_line":79,"start_character":19,"end_line":79,"end_character":27},"in_reply_to":"3f4b6375_da303559","updated":"2017-11-04 09:57:56.000000000","message":"Done","commit_id":"102572854c7e769a0dfb00cfa9e2910b409eb93f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1d717e81699c93b2e0b3646a9c30512e5c04f415","unresolved":false,"context_lines":[{"line_number":55,"context_line":"- **mmb_ssh_port**"},{"line_number":56,"context_line":"    - Port on the node to connect to. Default is 22."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"We\u0027ll define a new hardware type:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- ``mmb.MMBHardware``"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f485f77_d431650d","line":58,"updated":"2017-11-13 20:52:33.000000000","message":"this is a class, not the name right? because above, you have \u0027fujitsu-mmb\u0027.","commit_id":"af009e0ea7d9a0afd026a8adf61749b1a0d107de"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e712e7689889467aee729431b7687d61528af601","unresolved":false,"context_lines":[{"line_number":55,"context_line":"- **mmb_ssh_port**"},{"line_number":56,"context_line":"    - Port on the node to connect to. Default is 22."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"We\u0027ll define a new hardware type:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- ``mmb.MMBHardware``"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f485f77_37eaee74","line":58,"in_reply_to":"1f485f77_d431650d","updated":"2017-11-20 06:36:39.000000000","message":"Done","commit_id":"af009e0ea7d9a0afd026a8adf61749b1a0d107de"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1d717e81699c93b2e0b3646a9c30512e5c04f415","unresolved":false,"context_lines":[{"line_number":66,"context_line":"- ``MMBConsole``"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"``MMBPower``"},{"line_number":69,"context_line":"    Ironic sets/synchronizes this interfaces.  After syncronization, this"},{"line_number":70,"context_line":"    interface controls the power state of the nodes using MMB\u0027s command."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"``MMBManagement``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f485f77_b434a9fc","line":69,"updated":"2017-11-13 20:52:33.000000000","message":"nit s/syncronization/synchronization/\n\nby synchronization, i\u0027m guessing you mean the power. And that this interface does the sync\u0027ing etc.","commit_id":"af009e0ea7d9a0afd026a8adf61749b1a0d107de"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e712e7689889467aee729431b7687d61528af601","unresolved":false,"context_lines":[{"line_number":66,"context_line":"- ``MMBConsole``"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"``MMBPower``"},{"line_number":69,"context_line":"    Ironic sets/synchronizes this interfaces.  After syncronization, this"},{"line_number":70,"context_line":"    interface controls the power state of the nodes using MMB\u0027s command."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"``MMBManagement``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f485f77_17edb28a","line":69,"in_reply_to":"1f485f77_b434a9fc","updated":"2017-11-20 06:36:39.000000000","message":"Done","commit_id":"af009e0ea7d9a0afd026a8adf61749b1a0d107de"}]}